| @@ -75,7 +75,7 @@ | ||
| 75 | 75 |  			} elseif ($file->isMounted()) { | 
| 76 | 76 |  				$icon = \OC::$server->getMimeTypeDetector()->mimeTypeIcon('dir-external'); | 
| 77 | 77 | } | 
| 78 | -		}else{ | |
| 78 | +		} else{ | |
| 79 | 79 | $icon = \OC::$server->getMimeTypeDetector()->mimeTypeIcon($file->getMimetype()); | 
| 80 | 80 | } | 
| 81 | 81 | |
| @@ -41,44 +41,44 @@ | ||
| 41 | 41 | $is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL); | 
| 42 | 42 | |
| 43 | 43 |  		switch ($parameter->getType()) { | 
| 44 | - case DefinitionParameter::VALUE_PASSWORD: ?> | |
| 45 | -			<?php if ($is_optional) { $classes[] = 'optional'; } ?> | |
| 46 | - <input type="password" | |
| 44 | + case DefinitionParameter::VALUE_PASSWORD: ?> | |
| 45 | +    			<?php if ($is_optional) { $classes[] = 'optional'; } ?> | |
| 46 | + <input type="password" | |
| 47 | 47 |  				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?> | 
| 48 | - data-parameter="<?php p($parameter->getName()); ?>" | |
| 48 | + data-parameter="<?php p($parameter->getName()); ?>" | |
| 49 | 49 | value="<?php p($value); ?>" | 
| 50 | 50 | placeholder="<?php p($placeholder); ?>" | 
| 51 | 51 | /> | 
| 52 | 52 | <?php | 
| 53 | - break; | |
| 54 | - case DefinitionParameter::VALUE_BOOLEAN: ?> | |
| 55 | -			<?php $checkboxId = uniqid("checkbox_"); ?> | |
| 53 | + break; | |
| 54 | + case DefinitionParameter::VALUE_BOOLEAN: ?> | |
| 55 | +    			<?php $checkboxId = uniqid("checkbox_"); ?> | |
| 56 | 56 | <div> | 
| 57 | 57 | <label> | 
| 58 | 58 | <input type="checkbox" | 
| 59 | 59 | id="<?php p($checkboxId); ?>" | 
| 60 | 60 |  				<?php if (!empty($classes)): ?> class="checkbox <?php p(implode(' ', $classes)); ?>"<?php endif; ?> | 
| 61 | - data-parameter="<?php p($parameter->getName()); ?>" | |
| 61 | + data-parameter="<?php p($parameter->getName()); ?>" | |
| 62 | 62 | <?php if ($value === true): ?> checked="checked"<?php endif; ?> | 
| 63 | - /> | |
| 63 | + /> | |
| 64 | 64 | <?php p($placeholder); ?> | 
| 65 | 65 | </label> | 
| 66 | 66 | </div> | 
| 67 | 67 | <?php | 
| 68 | - break; | |
| 69 | - case DefinitionParameter::VALUE_HIDDEN: ?> | |
| 70 | - <input type="hidden" | |
| 68 | + break; | |
| 69 | + case DefinitionParameter::VALUE_HIDDEN: ?> | |
| 70 | + <input type="hidden" | |
| 71 | 71 |  				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?> | 
| 72 | - data-parameter="<?php p($parameter->getName()); ?>" | |
| 72 | + data-parameter="<?php p($parameter->getName()); ?>" | |
| 73 | 73 | value="<?php p($value); ?>" | 
| 74 | 74 | /> | 
| 75 | 75 | <?php | 
| 76 | - break; | |
| 77 | - default: ?> | |
| 78 | -			<?php if ($is_optional) { $classes[] = 'optional'; } ?> | |
| 79 | - <input type="text" | |
| 76 | + break; | |
| 77 | + default: ?> | |
| 78 | +    			<?php if ($is_optional) { $classes[] = 'optional'; } ?> | |
| 79 | + <input type="text" | |
| 80 | 80 |  				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?> | 
| 81 | - data-parameter="<?php p($parameter->getName()); ?>" | |
| 81 | + data-parameter="<?php p($parameter->getName()); ?>" | |
| 82 | 82 | value="<?php p($value); ?>" | 
| 83 | 83 | placeholder="<?php p($placeholder); ?>" | 
| 84 | 84 | /> | 
| @@ -100,7 +100,10 @@ discard block | ||
| 100 | 100 |  	<h2 class="inlineblock" data-anchor-name="external-storage"><?php p($l->t('External storages')); ?></h2> | 
| 101 | 101 |  	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-external-storage')); ?>"></a> | 
| 102 | 102 |  	<p class="settings-hint"><?php p($l->t('External storage enables you to mount external storage services and devices as secondary Nextcloud storage devices. You may also allow users to mount their own external storage services.')); ?></p> | 
| 103 | -	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) print_unescaped(''.$_['dependencies'].''); ?> | |
| 103 | +	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) { | |
| 104 | +    print_unescaped(''.$_['dependencies'].''); | |
| 105 | +} | |
| 106 | +?> | |
| 104 | 107 | <table id="externalStorage" class="grid" data-admin='<?php print_unescaped(json_encode($_['visibilityType'] === BackendService::VISIBILITY_ADMIN)); ?>'> | 
| 105 | 108 | <thead> | 
| 106 | 109 | <tr> | 
| @@ -109,7 +112,10 @@ discard block | ||
| 109 | 112 |  				<th><?php p($l->t('External storage')); ?></th> | 
| 110 | 113 |  				<th><?php p($l->t('Authentication')); ?></th> | 
| 111 | 114 |  				<th><?php p($l->t('Configuration')); ?></th> | 
| 112 | -				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) print_unescaped('<th>'.$l->t('Available for').'</th>'); ?> | |
| 115 | +				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) { | |
| 116 | +    print_unescaped('<th>'.$l->t('Available for').'</th>'); | |
| 117 | +} | |
| 118 | +?> | |
| 113 | 119 | <th> </th> | 
| 114 | 120 | <th> </th> | 
| 115 | 121 | <th> </th> | 
| @@ -142,7 +148,10 @@ discard block | ||
| 142 | 148 | }); | 
| 143 | 149 | ?> | 
| 144 | 150 | <?php foreach ($sortedBackends as $backend): ?> | 
| 145 | - <?php if ($backend->getDeprecateTo()) continue; // ignore deprecated backends ?> | |
| 151 | +							<?php if ($backend->getDeprecateTo()) { | |
| 152 | + continue; | |
| 153 | +} | |
| 154 | +// ignore deprecated backends ?> | |
| 146 | 155 | <option value="<?php p($backend->getIdentifier()); ?>"><?php p($backend->getText()); ?></option> | 
| 147 | 156 | <?php endforeach; ?> | 
| 148 | 157 | </select> | 
| @@ -167,7 +176,10 @@ discard block | ||
| 167 | 176 | |
| 168 | 177 | <?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN): ?> | 
| 169 | 178 | <input type="checkbox" name="allowUserMounting" id="allowUserMounting" class="checkbox" | 
| 170 | -			value="1" <?php if ($_['allowUserMounting']) print_unescaped(' checked="checked"'); ?> /> | |
| 179 | +			value="1" <?php if ($_['allowUserMounting']) { | |
| 180 | +    print_unescaped(' checked="checked"'); | |
| 181 | +} | |
| 182 | +?> /> | |
| 171 | 183 |  		<label for="allowUserMounting"><?php p($l->t('Allow users to mount external storage')); ?></label> <span id="userMountingMsg" class="msg"></span> | 
| 172 | 184 | |
| 173 | 185 | <p id="userMountingBackends"<?php if (!$_['allowUserMounting']): ?> class="hidden"<?php endif; ?>> | 
| @@ -179,8 +191,14 @@ discard block | ||
| 179 | 191 | <?php $i = 0; foreach ($userBackends as $backend): ?> | 
| 180 | 192 | <?php if ($deprecateTo = $backend->getDeprecateTo()): ?> | 
| 181 | 193 | <input type="hidden" id="allowUserMountingBackends<?php p($i); ?>" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" data-deprecate-to="<?php p($deprecateTo->getIdentifier()); ?>" /> | 
| 182 | - <?php else: ?> | |
| 183 | -					<input type="checkbox" id="allowUserMountingBackends<?php p($i); ?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) print_unescaped(' checked="checked"'); ?> /> | |
| 194 | +				<?php else { | |
| 195 | + : ?> | |
| 196 | + <input type="checkbox" id="allowUserMountingBackends<?php p($i); | |
| 197 | +} | |
| 198 | +?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) { | |
| 199 | +    print_unescaped(' checked="checked"'); | |
| 200 | +} | |
| 201 | +?> /> | |
| 184 | 202 | <label for="allowUserMountingBackends<?php p($i); ?>"><?php p($backend->getText()); ?></label> <br /> | 
| 185 | 203 | <?php endif; ?> | 
| 186 | 204 | <?php $i++; ?> | 
| @@ -93,8 +93,7 @@ | ||
| 93 | 93 |  	public function unlink($path) { | 
| 94 | 94 |  		if ($this->is_dir($path)) { | 
| 95 | 95 | return $this->rmdir($path); | 
| 96 | - } | |
| 97 | -		else { | |
| 96 | +		} else { | |
| 98 | 97 | $url = $this->constructUrl($path); | 
| 99 | 98 | $result = unlink($url); | 
| 100 | 99 | clearstatcache(true, $url); | 
| @@ -62,18 +62,18 @@ | ||
| 62 | 62 | $placeholder = substr($placeholder, 1); | 
| 63 | 63 | } | 
| 64 | 64 |  			switch ($placeholder[0]) { | 
| 65 | - case '!': | |
| 66 | - $type = DefinitionParameter::VALUE_BOOLEAN; | |
| 67 | - $placeholder = substr($placeholder, 1); | |
| 68 | - break; | |
| 69 | - case '*': | |
| 70 | - $type = DefinitionParameter::VALUE_PASSWORD; | |
| 71 | - $placeholder = substr($placeholder, 1); | |
| 72 | - break; | |
| 73 | - case '#': | |
| 74 | - $type = DefinitionParameter::VALUE_HIDDEN; | |
| 75 | - $placeholder = substr($placeholder, 1); | |
| 76 | - break; | |
| 65 | + case '!': | |
| 66 | + $type = DefinitionParameter::VALUE_BOOLEAN; | |
| 67 | + $placeholder = substr($placeholder, 1); | |
| 68 | + break; | |
| 69 | + case '*': | |
| 70 | + $type = DefinitionParameter::VALUE_PASSWORD; | |
| 71 | + $placeholder = substr($placeholder, 1); | |
| 72 | + break; | |
| 73 | + case '#': | |
| 74 | + $type = DefinitionParameter::VALUE_HIDDEN; | |
| 75 | + $placeholder = substr($placeholder, 1); | |
| 76 | + break; | |
| 77 | 77 | } | 
| 78 | 78 | $this->addParameter((new DefinitionParameter($name, $placeholder)) | 
| 79 | 79 | ->setType($type) | 
| @@ -119,8 +119,9 @@ | ||
| 119 | 119 | |
| 120 | 120 | // Only handling xml | 
| 121 | 121 |  		$contentType = $request->getHeader('Content-Type'); | 
| 122 | - if (strpos($contentType, 'application/xml') === false && strpos($contentType, 'text/xml') === false) | |
| 123 | - return; | |
| 122 | +		if (strpos($contentType, 'application/xml') === false && strpos($contentType, 'text/xml') === false) { | |
| 123 | + return; | |
| 124 | + } | |
| 124 | 125 | |
| 125 | 126 | // Making sure the node exists | 
| 126 | 127 |  		try { | 
| @@ -245,7 +245,9 @@ | ||
| 245 | 245 |  	function httpGet(RequestInterface $request, ResponseInterface $response) { | 
| 246 | 246 | // Only handle valid files | 
| 247 | 247 | $node = $this->tree->getNodeForPath($request->getPath()); | 
| 248 | - if (!($node instanceof IFile)) return; | |
| 248 | +		if (!($node instanceof IFile)) { | |
| 249 | + return; | |
| 250 | + } | |
| 249 | 251 | |
| 250 | 252 | // adds a 'Content-Disposition: attachment' header in case no disposition | 
| 251 | 253 | // header has been set before | 
| @@ -38,7 +38,9 @@ | ||
| 38 | 38 |  	public function getCurrentUserPrincipals() { | 
| 39 | 39 | $principalV2 = $this->getCurrentUserPrincipal(); | 
| 40 | 40 | |
| 41 | - if (is_null($principalV2)) return []; | |
| 41 | +		if (is_null($principalV2)) { | |
| 42 | + return []; | |
| 43 | + } | |
| 42 | 44 | |
| 43 | 45 | $principalV1 = $this->convertPrincipal($principalV2, false); | 
| 44 | 46 | return array_merge( | 
| @@ -745,7 +745,9 @@ | ||
| 745 | 745 | $stmt->execute([ $addressBookId ]); | 
| 746 | 746 | $currentToken = $stmt->fetchColumn(0); | 
| 747 | 747 | |
| 748 | - if (is_null($currentToken)) return null; | |
| 748 | +		if (is_null($currentToken)) { | |
| 749 | + return null; | |
| 750 | + } | |
| 749 | 751 | |
| 750 | 752 | $result = [ | 
| 751 | 753 | 'syncToken' => $currentToken, | 
| @@ -134,7 +134,7 @@ | ||
| 134 | 134 | } | 
| 135 | 135 |  				if(is_dir($source.'/'.$file)) { | 
| 136 | 136 | $this->addRecursive($path.'/'.$file, $source.'/'.$file); | 
| 137 | -				}else{ | |
| 137 | +				} else{ | |
| 138 | 138 | $this->addFile($path.'/'.$file, $source.'/'.$file); | 
| 139 | 139 | } | 
| 140 | 140 | } |