nextcloud / server

tests/lib/Files/Mount/ObjectHomeMountProviderTest.php

Indentation +223 added lines, -223 removed lines

@@ -12,232 +12,232 @@
 use OCP\IUser;
 
 class ObjectHomeMountProviderTest extends \Test\TestCase {
-	/** @var ObjectHomeMountProvider */
-	protected $provider;
-
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	protected $config;
-
-	/** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
-	protected $user;
-
-	/** @var IStorageFactory|\PHPUnit\Framework\MockObject\MockObject */
-	protected $loader;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->user = $this->createMock(IUser::class);
-		$this->loader = $this->createMock(IStorageFactory::class);
-
-		$this->provider = new ObjectHomeMountProvider($this->config);
-	}
-
-	public function testSingleBucket(): void {
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with($this->equalTo('objectstore'), '')
-			->willReturn([
-				'class' => 'Test\Files\Mount\FakeObjectStore',
-			]);
-
-		$this->user->expects($this->never())->method($this->anything());
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$config = $this->invokePrivate($this->provider, 'getSingleBucketObjectStoreConfig', [$this->user, $this->loader]);
-
-		$this->assertArrayHasKey('class', $config);
-		$this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
-		$this->assertArrayHasKey('arguments', $config);
-		$this->assertArrayHasKey('user', $config['arguments']);
-		$this->assertSame($this->user, $config['arguments']['user']);
-		$this->assertArrayHasKey('objectstore', $config['arguments']);
-		$this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
-	}
-
-	public function testMultiBucket(): void {
-		$this->config->expects($this->exactly(2))
-			->method('getSystemValue')
-			->with($this->equalTo('objectstore_multibucket'), '')
-			->willReturn([
-				'class' => 'Test\Files\Mount\FakeObjectStore',
-			]);
-
-		$this->user->method('getUID')
-			->willReturn('uid');
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with(
-				$this->equalTo('uid'),
-				$this->equalTo('homeobjectstore'),
-				$this->equalTo('bucket'),
-				$this->equalTo(null)
-			)->willReturn(null);
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				$this->equalTo('uid'),
-				$this->equalTo('homeobjectstore'),
-				$this->equalTo('bucket'),
-				$this->equalTo('49'),
-				$this->equalTo(null)
-			);
-
-		$config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
-
-		$this->assertArrayHasKey('class', $config);
-		$this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
-		$this->assertArrayHasKey('arguments', $config);
-		$this->assertArrayHasKey('user', $config['arguments']);
-		$this->assertSame($this->user, $config['arguments']['user']);
-		$this->assertArrayHasKey('objectstore', $config['arguments']);
-		$this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
-		$this->assertArrayHasKey('bucket', $config['arguments']);
-		$this->assertEquals('49', $config['arguments']['bucket']);
-	}
-
-	public function testMultiBucketWithPrefix(): void {
-		$this->config->expects($this->exactly(2))
-			->method('getSystemValue')
-			->with('objectstore_multibucket')
-			->willReturn([
-				'class' => 'Test\Files\Mount\FakeObjectStore',
-				'arguments' => [
-					'bucket' => 'myBucketPrefix',
-				],
-			]);
-
-		$this->user->method('getUID')
-			->willReturn('uid');
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with(
-				$this->equalTo('uid'),
-				$this->equalTo('homeobjectstore'),
-				$this->equalTo('bucket'),
-				$this->equalTo(null)
-			)->willReturn(null);
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with(
-				$this->equalTo('uid'),
-				$this->equalTo('homeobjectstore'),
-				$this->equalTo('bucket'),
-				$this->equalTo('myBucketPrefix49'),
-				$this->equalTo(null)
-			);
-
-		$config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
-
-		$this->assertArrayHasKey('class', $config);
-		$this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
-		$this->assertArrayHasKey('arguments', $config);
-		$this->assertArrayHasKey('user', $config['arguments']);
-		$this->assertSame($this->user, $config['arguments']['user']);
-		$this->assertArrayHasKey('objectstore', $config['arguments']);
-		$this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
-		$this->assertArrayHasKey('bucket', $config['arguments']);
-		$this->assertEquals('myBucketPrefix49', $config['arguments']['bucket']);
-	}
-
-	public function testMultiBucketBucketAlreadySet(): void {
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('objectstore_multibucket')
-			->willReturn([
-				'class' => 'Test\Files\Mount\FakeObjectStore',
-				'arguments' => [
-					'bucket' => 'myBucketPrefix',
-				],
-			]);
-
-		$this->user->method('getUID')
-			->willReturn('uid');
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with(
-				$this->equalTo('uid'),
-				$this->equalTo('homeobjectstore'),
-				$this->equalTo('bucket'),
-				$this->equalTo(null)
-			)->willReturn('awesomeBucket1');
-
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
-
-		$this->assertArrayHasKey('class', $config);
-		$this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
-		$this->assertArrayHasKey('arguments', $config);
-		$this->assertArrayHasKey('user', $config['arguments']);
-		$this->assertSame($this->user, $config['arguments']['user']);
-		$this->assertArrayHasKey('objectstore', $config['arguments']);
-		$this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
-		$this->assertArrayHasKey('bucket', $config['arguments']);
-		$this->assertEquals('awesomeBucket1', $config['arguments']['bucket']);
-	}
-
-	public function testMultiBucketConfigFirst(): void {
-		$this->config->expects($this->exactly(2))
-			->method('getSystemValue')
-			->with('objectstore_multibucket')
-			->willReturn([
-				'class' => 'Test\Files\Mount\FakeObjectStore',
-			]);
-
-		$this->user->method('getUID')
-			->willReturn('uid');
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
-		$this->assertInstanceOf('OC\Files\Mount\MountPoint', $mount);
-	}
-
-	public function testMultiBucketConfigFirstFallBackSingle(): void {
-		$this->config->expects($this->exactly(2))
-			->method('getSystemValue')->willReturnMap([
-				['objectstore_multibucket', '', ''],
-				['objectstore', '', [
-					'class' => 'Test\Files\Mount\FakeObjectStore',
-				]],
-			]);
-
-		$this->user->method('getUID')
-			->willReturn('uid');
-		$this->loader->expects($this->never())->method($this->anything());
-
-		$mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
-		$this->assertInstanceOf('OC\Files\Mount\MountPoint', $mount);
-	}
-
-	public function testNoObjectStore(): void {
-		$this->config->expects($this->exactly(2))
-			->method('getSystemValue')
-			->willReturn('');
-
-		$mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
-		$this->assertNull($mount);
-	}
+    /** @var ObjectHomeMountProvider */
+    protected $provider;
+
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    protected $config;
+
+    /** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
+    protected $user;
+
+    /** @var IStorageFactory|\PHPUnit\Framework\MockObject\MockObject */
+    protected $loader;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->user = $this->createMock(IUser::class);
+        $this->loader = $this->createMock(IStorageFactory::class);
+
+        $this->provider = new ObjectHomeMountProvider($this->config);
+    }
+
+    public function testSingleBucket(): void {
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with($this->equalTo('objectstore'), '')
+            ->willReturn([
+                'class' => 'Test\Files\Mount\FakeObjectStore',
+            ]);
+
+        $this->user->expects($this->never())->method($this->anything());
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $config = $this->invokePrivate($this->provider, 'getSingleBucketObjectStoreConfig', [$this->user, $this->loader]);
+
+        $this->assertArrayHasKey('class', $config);
+        $this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
+        $this->assertArrayHasKey('arguments', $config);
+        $this->assertArrayHasKey('user', $config['arguments']);
+        $this->assertSame($this->user, $config['arguments']['user']);
+        $this->assertArrayHasKey('objectstore', $config['arguments']);
+        $this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
+    }
+
+    public function testMultiBucket(): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->with($this->equalTo('objectstore_multibucket'), '')
+            ->willReturn([
+                'class' => 'Test\Files\Mount\FakeObjectStore',
+            ]);
+
+        $this->user->method('getUID')
+            ->willReturn('uid');
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with(
+                $this->equalTo('uid'),
+                $this->equalTo('homeobjectstore'),
+                $this->equalTo('bucket'),
+                $this->equalTo(null)
+            )->willReturn(null);
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                $this->equalTo('uid'),
+                $this->equalTo('homeobjectstore'),
+                $this->equalTo('bucket'),
+                $this->equalTo('49'),
+                $this->equalTo(null)
+            );
+
+        $config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
+
+        $this->assertArrayHasKey('class', $config);
+        $this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
+        $this->assertArrayHasKey('arguments', $config);
+        $this->assertArrayHasKey('user', $config['arguments']);
+        $this->assertSame($this->user, $config['arguments']['user']);
+        $this->assertArrayHasKey('objectstore', $config['arguments']);
+        $this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
+        $this->assertArrayHasKey('bucket', $config['arguments']);
+        $this->assertEquals('49', $config['arguments']['bucket']);
+    }
+
+    public function testMultiBucketWithPrefix(): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->with('objectstore_multibucket')
+            ->willReturn([
+                'class' => 'Test\Files\Mount\FakeObjectStore',
+                'arguments' => [
+                    'bucket' => 'myBucketPrefix',
+                ],
+            ]);
+
+        $this->user->method('getUID')
+            ->willReturn('uid');
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with(
+                $this->equalTo('uid'),
+                $this->equalTo('homeobjectstore'),
+                $this->equalTo('bucket'),
+                $this->equalTo(null)
+            )->willReturn(null);
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with(
+                $this->equalTo('uid'),
+                $this->equalTo('homeobjectstore'),
+                $this->equalTo('bucket'),
+                $this->equalTo('myBucketPrefix49'),
+                $this->equalTo(null)
+            );
+
+        $config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
+
+        $this->assertArrayHasKey('class', $config);
+        $this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
+        $this->assertArrayHasKey('arguments', $config);
+        $this->assertArrayHasKey('user', $config['arguments']);
+        $this->assertSame($this->user, $config['arguments']['user']);
+        $this->assertArrayHasKey('objectstore', $config['arguments']);
+        $this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
+        $this->assertArrayHasKey('bucket', $config['arguments']);
+        $this->assertEquals('myBucketPrefix49', $config['arguments']['bucket']);
+    }
+
+    public function testMultiBucketBucketAlreadySet(): void {
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('objectstore_multibucket')
+            ->willReturn([
+                'class' => 'Test\Files\Mount\FakeObjectStore',
+                'arguments' => [
+                    'bucket' => 'myBucketPrefix',
+                ],
+            ]);
+
+        $this->user->method('getUID')
+            ->willReturn('uid');
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with(
+                $this->equalTo('uid'),
+                $this->equalTo('homeobjectstore'),
+                $this->equalTo('bucket'),
+                $this->equalTo(null)
+            )->willReturn('awesomeBucket1');
+
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $config = $this->invokePrivate($this->provider, 'getMultiBucketObjectStoreConfig', [$this->user, $this->loader]);
+
+        $this->assertArrayHasKey('class', $config);
+        $this->assertEquals($config['class'], 'Test\Files\Mount\FakeObjectStore');
+        $this->assertArrayHasKey('arguments', $config);
+        $this->assertArrayHasKey('user', $config['arguments']);
+        $this->assertSame($this->user, $config['arguments']['user']);
+        $this->assertArrayHasKey('objectstore', $config['arguments']);
+        $this->assertInstanceOf('Test\Files\Mount\FakeObjectStore', $config['arguments']['objectstore']);
+        $this->assertArrayHasKey('bucket', $config['arguments']);
+        $this->assertEquals('awesomeBucket1', $config['arguments']['bucket']);
+    }
+
+    public function testMultiBucketConfigFirst(): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->with('objectstore_multibucket')
+            ->willReturn([
+                'class' => 'Test\Files\Mount\FakeObjectStore',
+            ]);
+
+        $this->user->method('getUID')
+            ->willReturn('uid');
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
+        $this->assertInstanceOf('OC\Files\Mount\MountPoint', $mount);
+    }
+
+    public function testMultiBucketConfigFirstFallBackSingle(): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getSystemValue')->willReturnMap([
+                ['objectstore_multibucket', '', ''],
+                ['objectstore', '', [
+                    'class' => 'Test\Files\Mount\FakeObjectStore',
+                ]],
+            ]);
+
+        $this->user->method('getUID')
+            ->willReturn('uid');
+        $this->loader->expects($this->never())->method($this->anything());
+
+        $mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
+        $this->assertInstanceOf('OC\Files\Mount\MountPoint', $mount);
+    }
+
+    public function testNoObjectStore(): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->willReturn('');
+
+        $mount = $this->provider->getHomeMountForUser($this->user, $this->loader);
+        $this->assertNull($mount);
+    }
 }
 
 class FakeObjectStore {
-	private $arguments;
+    private $arguments;
 
-	public function __construct(array $arguments) {
-		$this->arguments = $arguments;
-	}
+    public function __construct(array $arguments) {
+        $this->arguments = $arguments;
+    }
 
-	public function getArguments() {
-		return $this->arguments;
-	}
+    public function getArguments() {
+        return $this->arguments;
+    }
 }

tests/lib/Files/ViewTest.php

Indentation +2819 added lines, -2819 removed lines

@@ -39,40 +39,40 @@ 
 use Test\Traits\UserTrait;
 
 class TemporaryNoTouch extends Temporary {
-	public function touch(string $path, ?int $mtime = null): bool {
-		return false;
-	}
+    public function touch(string $path, ?int $mtime = null): bool {
+        return false;
+    }
 }
 
 class TemporaryNoCross extends Temporary {
-	public function copyFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath, bool $preserveMtime = false): bool {
-		return Common::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime);
-	}
+    public function copyFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath, bool $preserveMtime = false): bool {
+        return Common::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime);
+    }
 
-	public function moveFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath): bool {
-		return Common::moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
-	}
+    public function moveFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath): bool {
+        return Common::moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
+    }
 }
 
 class TemporaryNoLocal extends Temporary {
-	public function instanceOfStorage(string $class): bool {
-		if ($class === '\OC\Files\Storage\Local') {
-			return false;
-		} else {
-			return parent::instanceOfStorage($class);
-		}
-	}
+    public function instanceOfStorage(string $class): bool {
+        if ($class === '\OC\Files\Storage\Local') {
+            return false;
+        } else {
+            return parent::instanceOfStorage($class);
+        }
+    }
 }
 
 class TestEventHandler {
-	public function umount() {
-	}
-	public function post_umount() {
-	}
-	public function preCallback() {
-	}
-	public function postCallback() {
-	}
+    public function umount() {
+    }
+    public function post_umount() {
+    }
+    public function preCallback() {
+    }
+    public function postCallback() {
+    }
 }
 
 /**
@@ -83,2802 +83,2802 @@ 
  * @package Test\Files
  */
 class ViewTest extends \Test\TestCase {
-	use UserTrait;
-
-	/**
-	 * @var \OC\Files\Storage\Storage[] $storages
-	 */
-	private $storages = [];
-
-	/**
-	 * @var string
-	 */
-	private $user;
-
-	/**
-	 * @var \OCP\IUser
-	 */
-	private $userObject;
-
-	/**
-	 * @var \OCP\IGroup
-	 */
-	private $groupObject;
-
-	/** @var \OC\Files\Storage\Storage */
-	private $tempStorage;
-
-	protected function setUp(): void {
-		parent::setUp();
-		\OC_Hook::clear();
-
-		Server::get(IUserManager::class)->clearBackends();
-		Server::get(IUserManager::class)->registerBackend(new \Test\Util\User\Dummy());
-
-		//login
-		$userManager = \OC::$server->getUserManager();
-		$groupManager = \OC::$server->getGroupManager();
-		$this->user = 'test';
-		$this->userObject = $userManager->createUser('test', 'test');
-
-		$this->groupObject = $groupManager->createGroup('group1');
-		$this->groupObject->addUser($this->userObject);
-
-		self::loginAsUser($this->user);
-
-		/** @var IMountManager $manager */
-		$manager = \OC::$server->get(IMountManager::class);
-		$manager->removeMount('/test');
-
-		$this->tempStorage = null;
-	}
-
-	protected function tearDown(): void {
-		\OC_User::setUserId($this->user);
-		foreach ($this->storages as $storage) {
-			$cache = $storage->getCache();
-			$ids = $cache->getAll();
-			$cache->clear();
-		}
-
-		if ($this->tempStorage) {
-			system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
-		}
-
-		self::logout();
-
-		/** @var SetupManager $setupManager */
-		$setupManager = \OC::$server->get(SetupManager::class);
-		$setupManager->setupRoot();
-
-		$this->userObject->delete();
-		$this->groupObject->delete();
-
-		$mountProviderCollection = \OC::$server->getMountProviderCollection();
-		self::invokePrivate($mountProviderCollection, 'providers', [[]]);
-
-		parent::tearDown();
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testCacheAPI(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		Filesystem::mount($storage2, [], $root . '/substorage');
-		Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
-		$textSize = strlen("dummy file data\n");
-		$imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
-		$storageSize = $textSize * 2 + $imageSize;
-
-		$storageInfo = $storage3->getCache()->get('');
-		$this->assertEquals($storageSize, $storageInfo['size']);
-
-		$rootView = new View($root);
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertEquals($textSize, $cachedData['size']);
-		$this->assertEquals('text/plain', $cachedData['mimetype']);
-		$this->assertNotEquals(-1, $cachedData['permissions']);
-
-		$cachedData = $rootView->getFileInfo('/');
-		$this->assertEquals($storageSize * 3, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		// get cached data excluding mount points
-		$cachedData = $rootView->getFileInfo('/', false);
-		$this->assertEquals($storageSize, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		$cachedData = $rootView->getFileInfo('/folder');
-		$this->assertEquals($storageSize + $textSize, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		$folderData = $rootView->getDirectoryContent('/');
-		/**
-		 * expected entries:
-		 * folder
-		 * foo.png
-		 * foo.txt
-		 * substorage
-		 */
-		$this->assertCount(4, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-		$this->assertEquals('substorage', $folderData[3]['name']);
-
-		$this->assertEquals($storageSize + $textSize, $folderData[0]['size']);
-		$this->assertEquals($imageSize, $folderData[1]['size']);
-		$this->assertEquals($textSize, $folderData[2]['size']);
-		$this->assertEquals($storageSize, $folderData[3]['size']);
-
-		$folderData = $rootView->getDirectoryContent('/substorage');
-		/**
-		 * expected entries:
-		 * folder
-		 * foo.png
-		 * foo.txt
-		 */
-		$this->assertCount(3, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-
-		$folderView = new View($root . '/folder');
-		$this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertFalse($cachedData['encrypted']);
-		$id = $rootView->putFileInfo('/foo.txt', ['encrypted' => true]);
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertTrue($cachedData['encrypted']);
-		$this->assertEquals($cachedData['fileid'], $id);
-
-		$this->assertFalse($rootView->getFileInfo('/non/existing'));
-		$this->assertEquals([], $rootView->getDirectoryContent('/non/existing'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testGetPath(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-		Filesystem::mount($storage3, [], '/folder/anotherstorage');
-
-		$rootView = new View('');
-
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		/** @var int $id1 */
-		$id1 = $cachedData['fileid'];
-		$this->assertEquals('/foo.txt', $rootView->getPath($id1));
-
-		$cachedData = $rootView->getFileInfo('/substorage/foo.txt');
-		/** @var int $id2 */
-		$id2 = $cachedData['fileid'];
-		$this->assertEquals('/substorage/foo.txt', $rootView->getPath($id2));
-
-		$folderView = new View('/substorage');
-		$this->assertEquals('/foo.txt', $folderView->getPath($id2));
-	}
-
-
-	public function testGetPathNotExisting(): void {
-		$this->expectException(\OCP\Files\NotFoundException::class);
-
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$rootView = new View('');
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		/** @var int $id1 */
-		$id1 = $cachedData['fileid'];
-		$folderView = new View('/substorage');
-		$this->assertNull($folderView->getPath($id1));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testMountPointOverwrite(): void {
-		$storage1 = $this->getTestStorage(false);
-		$storage2 = $this->getTestStorage();
-		$storage1->mkdir('substorage');
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$folderContent = $rootView->getDirectoryContent('/');
-		$this->assertCount(4, $folderContent);
-	}
-
-	public static function sharingDisabledPermissionProvider(): array {
-		return [
-			['no', '', true],
-			['yes', 'group1', false],
-		];
-	}
-
-	/**
-	 * @dataProvider sharingDisabledPermissionProvider
-	 */
-	public function testRemoveSharePermissionWhenSharingDisabledForUser($excludeGroups, $excludeGroupsList, $expectedShareable): void {
-		// Reset sharing disabled for users cache
-		self::invokePrivate(\OC::$server->get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
-
-		$config = \OC::$server->getConfig();
-		$oldExcludeGroupsFlag = $config->getAppValue('core', 'shareapi_exclude_groups', 'no');
-		$oldExcludeGroupsList = $config->getAppValue('core', 'shareapi_exclude_groups_list', '');
-		$config->setAppValue('core', 'shareapi_exclude_groups', $excludeGroups);
-		$config->setAppValue('core', 'shareapi_exclude_groups_list', $excludeGroupsList);
-
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/mount');
-
-		$view = new View('/');
-
-		$folderContent = $view->getDirectoryContent('');
-		$this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
-
-		$folderContent = $view->getDirectoryContent('mount');
-		$this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
-
-		$config->setAppValue('core', 'shareapi_exclude_groups', $oldExcludeGroupsFlag);
-		$config->setAppValue('core', 'shareapi_exclude_groups_list', $oldExcludeGroupsList);
-
-		// Reset sharing disabled for users cache
-		self::invokePrivate(\OC::$server->get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
-	}
-
-	public function testCacheIncompleteFolder(): void {
-		$storage1 = $this->getTestStorage(false);
-		Filesystem::mount($storage1, [], '/incomplete');
-		$rootView = new View('/incomplete');
-
-		$entries = $rootView->getDirectoryContent('/');
-		$this->assertCount(3, $entries);
-
-		// /folder will already be in the cache but not scanned
-		$entries = $rootView->getDirectoryContent('/folder');
-		$this->assertCount(1, $entries);
-	}
-
-	public function testAutoScan(): void {
-		$storage1 = $this->getTestStorage(false);
-		$storage2 = $this->getTestStorage(false);
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-		$textSize = strlen("dummy file data\n");
-
-		$rootView = new View('');
-
-		$cachedData = $rootView->getFileInfo('/');
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-		$this->assertEquals(-1, $cachedData['size']);
-
-		$folderData = $rootView->getDirectoryContent('/substorage/folder');
-		$this->assertEquals('text/plain', $folderData[0]['mimetype']);
-		$this->assertEquals($textSize, $folderData[0]['size']);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testSearch(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-		Filesystem::mount($storage3, [], '/folder/anotherstorage');
-
-		$rootView = new View('');
-
-		$results = $rootView->search('foo');
-		$this->assertCount(6, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$this->assertEquals($result['path'], Filesystem::normalizePath($result['path']));
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/foo.txt', $paths);
-		$this->assertContains('/foo.png', $paths);
-		$this->assertContains('/substorage/foo.txt', $paths);
-		$this->assertContains('/substorage/foo.png', $paths);
-		$this->assertContains('/folder/anotherstorage/foo.txt', $paths);
-		$this->assertContains('/folder/anotherstorage/foo.png', $paths);
-
-		$folderView = new View('/folder');
-		$results = $folderView->search('bar');
-		$this->assertCount(2, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/anotherstorage/folder/bar.txt', $paths);
-		$this->assertContains('/bar.txt', $paths);
-
-		$results = $folderView->search('foo');
-		$this->assertCount(2, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/anotherstorage/foo.txt', $paths);
-		$this->assertContains('/anotherstorage/foo.png', $paths);
-
-		$this->assertCount(6, $rootView->searchByMime('text'));
-		$this->assertCount(3, $folderView->searchByMime('text'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testWatcher(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		$storage1->getWatcher()->setPolicy(Watcher::CHECK_ALWAYS);
-
-		$rootView = new View('');
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(16, $cachedData['size']);
-
-		$rootView->putFileInfo('foo.txt', ['storage_mtime' => 10]);
-		$storage1->file_put_contents('foo.txt', 'foo');
-		clearstatcache();
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(3, $cachedData['size']);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testCopyBetweenStorageNoCross(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testCopyBetweenStorageCross(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testCopyBetweenStorageCrossNonLocal(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	public function copyBetweenStorages($storage1, $storage2) {
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->mkdir('substorage/emptyfolder');
-		$rootView->copy('substorage', 'anotherfolder');
-		$this->assertTrue($rootView->is_dir('/anotherfolder'));
-		$this->assertTrue($rootView->is_dir('/substorage'));
-		$this->assertTrue($rootView->is_dir('/anotherfolder/emptyfolder'));
-		$this->assertTrue($rootView->is_dir('/substorage/emptyfolder'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/foo.txt'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/foo.png'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/folder/bar.txt'));
-		$this->assertTrue($rootView->file_exists('/substorage/foo.txt'));
-		$this->assertTrue($rootView->file_exists('/substorage/foo.png'));
-		$this->assertTrue($rootView->file_exists('/substorage/folder/bar.txt'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testMoveBetweenStorageNoCross(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testMoveBetweenStorageCross(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testMoveBetweenStorageCrossNonLocal(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	public function moveBetweenStorages($storage1, $storage2) {
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->rename('foo.txt', 'substorage/folder/foo.txt');
-		$this->assertFalse($rootView->file_exists('foo.txt'));
-		$this->assertTrue($rootView->file_exists('substorage/folder/foo.txt'));
-		$rootView->rename('substorage/folder', 'anotherfolder');
-		$this->assertFalse($rootView->is_dir('substorage/folder'));
-		$this->assertTrue($rootView->file_exists('anotherfolder/foo.txt'));
-		$this->assertTrue($rootView->file_exists('anotherfolder/bar.txt'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testUnlink(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$rootView->file_put_contents('/substorage/bar.txt', 'asd');
-
-		$this->assertTrue($rootView->file_exists('foo.txt'));
-		$this->assertTrue($rootView->file_exists('substorage/bar.txt'));
-
-		$this->assertTrue($rootView->unlink('foo.txt'));
-		$this->assertTrue($rootView->unlink('substorage/bar.txt'));
-
-		$this->assertFalse($rootView->file_exists('foo.txt'));
-		$this->assertFalse($rootView->file_exists('substorage/bar.txt'));
-	}
-
-	public static function rmdirOrUnlinkDataProvider(): array {
-		return [['rmdir'], ['unlink']];
-	}
-
-	/**
-	 * @dataProvider rmdirOrUnlinkDataProvider
-	 */
-	public function testRmdir($method): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$rootView = new View('');
-		$rootView->mkdir('sub');
-		$rootView->mkdir('sub/deep');
-		$rootView->file_put_contents('/sub/deep/foo.txt', 'asd');
-
-		$this->assertTrue($rootView->file_exists('sub/deep/foo.txt'));
-
-		$this->assertTrue($rootView->$method('sub'));
-
-		$this->assertFalse($rootView->file_exists('sub'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testUnlinkRootMustFail(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$rootView->file_put_contents('/substorage/bar.txt', 'asd');
-
-		$this->assertFalse($rootView->unlink(''));
-		$this->assertFalse($rootView->unlink('/'));
-		$this->assertFalse($rootView->unlink('substorage'));
-		$this->assertFalse($rootView->unlink('/substorage'));
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testTouch(): void {
-		$storage = $this->getTestStorage(true, TemporaryNoTouch::class);
-
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		$oldCachedData = $rootView->getFileInfo('foo.txt');
-
-		$rootView->touch('foo.txt', 500);
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(500, $cachedData['mtime']);
-		$this->assertEquals($oldCachedData['storage_mtime'], $cachedData['storage_mtime']);
-
-		$rootView->putFileInfo('foo.txt', ['storage_mtime' => 1000]); //make sure the watcher detects the change
-		$rootView->file_put_contents('foo.txt', 'asd');
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertGreaterThanOrEqual($oldCachedData['mtime'], $cachedData['mtime']);
-		$this->assertEquals($cachedData['storage_mtime'], $cachedData['mtime']);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testTouchFloat(): void {
-		$storage = $this->getTestStorage(true, TemporaryNoTouch::class);
-
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		$oldCachedData = $rootView->getFileInfo('foo.txt');
-
-		$rootView->touch('foo.txt', 500.5);
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(500, $cachedData['mtime']);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testViewHooks(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
-
-		$rootView = new View('');
-		$subView = new View($defaultRoot . '/substorage');
-		$this->hookPath = null;
-
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$this->assertNull($this->hookPath);
-
-		$subView->file_put_contents('/foo.txt', 'asd');
-		$this->assertEquals('/substorage/foo.txt', $this->hookPath);
-	}
-
-	private $hookPath;
-
-	public function dummyHook($params) {
-		$this->hookPath = $params['path'];
-	}
-
-	public function testSearchNotOutsideView(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		$storage1->rename('folder', 'foo');
-		$scanner = $storage1->getScanner();
-		$scanner->scan('');
-
-		$view = new View('/foo');
-
-		$result = $view->search('.txt');
-		$this->assertCount(1, $result);
-	}
-
-	/**
-	 * @param bool $scan
-	 * @param string $class
-	 * @return \OC\Files\Storage\Storage
-	 */
-	private function getTestStorage($scan = true, $class = Temporary::class) {
-		/**
-		 * @var \OC\Files\Storage\Storage $storage
-		 */
-		$storage = new $class([]);
-		$textData = "dummy file data\n";
-		$imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
-		$storage->mkdir('folder');
-		$storage->file_put_contents('foo.txt', $textData);
-		$storage->file_put_contents('foo.png', $imgData);
-		$storage->file_put_contents('folder/bar.txt', $textData);
-
-		if ($scan) {
-			$scanner = $storage->getScanner();
-			$scanner->scan('');
-		}
-		$this->storages[] = $storage;
-		return $storage;
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testViewHooksIfRootStartsTheSame(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
-
-		$subView = new View($defaultRoot . '_substorage');
-		$this->hookPath = null;
-
-		$subView->file_put_contents('/foo.txt', 'asd');
-		$this->assertNull($this->hookPath);
-	}
-
-	private $hookWritePath;
-	private $hookCreatePath;
-	private $hookUpdatePath;
-
-	public function dummyHookWrite($params) {
-		$this->hookWritePath = $params['path'];
-	}
-
-	public function dummyHookUpdate($params) {
-		$this->hookUpdatePath = $params['path'];
-	}
-
-	public function dummyHookCreate($params) {
-		$this->hookCreatePath = $params['path'];
-	}
-
-	public function testEditNoCreateHook(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot);
-		\OC_Hook::connect('OC_Filesystem', 'post_create', $this, 'dummyHookCreate');
-		\OC_Hook::connect('OC_Filesystem', 'post_update', $this, 'dummyHookUpdate');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHookWrite');
-
-		$view = new View($defaultRoot);
-		$this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
-
-		$view->file_put_contents('/asd.txt', 'foo');
-		$this->assertEquals('/asd.txt', $this->hookCreatePath);
-		$this->assertNull($this->hookUpdatePath);
-		$this->assertEquals('/asd.txt', $this->hookWritePath);
-
-		$this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
-
-		$view->file_put_contents('/asd.txt', 'foo');
-		$this->assertNull($this->hookCreatePath);
-		$this->assertEquals('/asd.txt', $this->hookUpdatePath);
-		$this->assertEquals('/asd.txt', $this->hookWritePath);
-
-		\OC_Hook::clear('OC_Filesystem', 'post_create');
-		\OC_Hook::clear('OC_Filesystem', 'post_update');
-		\OC_Hook::clear('OC_Filesystem', 'post_write');
-	}
-
-	/**
-	 * @dataProvider resolvePathTestProvider
-	 */
-	public function testResolvePath($expected, $pathToTest): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$view = new View('');
-
-		$result = $view->resolvePath($pathToTest);
-		$this->assertEquals($expected, $result[1]);
-
-		$exists = $view->file_exists($pathToTest);
-		$this->assertTrue($exists);
-
-		$exists = $view->file_exists($result[1]);
-		$this->assertTrue($exists);
-	}
-
-	public static function resolvePathTestProvider(): array {
-		return [
-			['foo.txt', 'foo.txt'],
-			['foo.txt', '/foo.txt'],
-			['folder', 'folder'],
-			['folder', '/folder'],
-			['folder', 'folder/'],
-			['folder', '/folder/'],
-			['folder/bar.txt', 'folder/bar.txt'],
-			['folder/bar.txt', '/folder/bar.txt'],
-			['', ''],
-			['', '/'],
-		];
-	}
-
-	public function testUTF8Names(): void {
-		$names = ['虚', '和知しゃ和で', 'regular ascii', 'sɨˈrɪlɪk', 'ѨѬ', 'أنا أحب القراءة كثيرا'];
-
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		foreach ($names as $name) {
-			$rootView->file_put_contents('/' . $name, 'dummy content');
-		}
-
-		$list = $rootView->getDirectoryContent('/');
-
-		$this->assertCount(count($names), $list);
-		foreach ($list as $item) {
-			$this->assertContains($item['name'], $names);
-		}
-
-		$cache = $storage->getCache();
-		$scanner = $storage->getScanner();
-		$scanner->scan('');
-
-		$list = $cache->getFolderContents('');
-
-		$this->assertCount(count($names), $list);
-		foreach ($list as $item) {
-			$this->assertContains($item['name'], $names);
-		}
-	}
-
-	public function xtestLongPath() {
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-
-		$longPath = '';
-		$ds = DIRECTORY_SEPARATOR;
-		/*
+    use UserTrait;
+
+    /**
+     * @var \OC\Files\Storage\Storage[] $storages
+     */
+    private $storages = [];
+
+    /**
+     * @var string
+     */
+    private $user;
+
+    /**
+     * @var \OCP\IUser
+     */
+    private $userObject;
+
+    /**
+     * @var \OCP\IGroup
+     */
+    private $groupObject;
+
+    /** @var \OC\Files\Storage\Storage */
+    private $tempStorage;
+
+    protected function setUp(): void {
+        parent::setUp();
+        \OC_Hook::clear();
+
+        Server::get(IUserManager::class)->clearBackends();
+        Server::get(IUserManager::class)->registerBackend(new \Test\Util\User\Dummy());
+
+        //login
+        $userManager = \OC::$server->getUserManager();
+        $groupManager = \OC::$server->getGroupManager();
+        $this->user = 'test';
+        $this->userObject = $userManager->createUser('test', 'test');
+
+        $this->groupObject = $groupManager->createGroup('group1');
+        $this->groupObject->addUser($this->userObject);
+
+        self::loginAsUser($this->user);
+
+        /** @var IMountManager $manager */
+        $manager = \OC::$server->get(IMountManager::class);
+        $manager->removeMount('/test');
+
+        $this->tempStorage = null;
+    }
+
+    protected function tearDown(): void {
+        \OC_User::setUserId($this->user);
+        foreach ($this->storages as $storage) {
+            $cache = $storage->getCache();
+            $ids = $cache->getAll();
+            $cache->clear();
+        }
+
+        if ($this->tempStorage) {
+            system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
+        }
+
+        self::logout();
+
+        /** @var SetupManager $setupManager */
+        $setupManager = \OC::$server->get(SetupManager::class);
+        $setupManager->setupRoot();
+
+        $this->userObject->delete();
+        $this->groupObject->delete();
+
+        $mountProviderCollection = \OC::$server->getMountProviderCollection();
+        self::invokePrivate($mountProviderCollection, 'providers', [[]]);
+
+        parent::tearDown();
+    }
+
+    /**
+     * @medium
+     */
+    public function testCacheAPI(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+        $root = self::getUniqueID('/');
+        Filesystem::mount($storage1, [], $root . '/');
+        Filesystem::mount($storage2, [], $root . '/substorage');
+        Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
+        $textSize = strlen("dummy file data\n");
+        $imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+        $storageSize = $textSize * 2 + $imageSize;
+
+        $storageInfo = $storage3->getCache()->get('');
+        $this->assertEquals($storageSize, $storageInfo['size']);
+
+        $rootView = new View($root);
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertEquals($textSize, $cachedData['size']);
+        $this->assertEquals('text/plain', $cachedData['mimetype']);
+        $this->assertNotEquals(-1, $cachedData['permissions']);
+
+        $cachedData = $rootView->getFileInfo('/');
+        $this->assertEquals($storageSize * 3, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        // get cached data excluding mount points
+        $cachedData = $rootView->getFileInfo('/', false);
+        $this->assertEquals($storageSize, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        $cachedData = $rootView->getFileInfo('/folder');
+        $this->assertEquals($storageSize + $textSize, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        $folderData = $rootView->getDirectoryContent('/');
+        /**
+         * expected entries:
+         * folder
+         * foo.png
+         * foo.txt
+         * substorage
+         */
+        $this->assertCount(4, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+        $this->assertEquals('substorage', $folderData[3]['name']);
+
+        $this->assertEquals($storageSize + $textSize, $folderData[0]['size']);
+        $this->assertEquals($imageSize, $folderData[1]['size']);
+        $this->assertEquals($textSize, $folderData[2]['size']);
+        $this->assertEquals($storageSize, $folderData[3]['size']);
+
+        $folderData = $rootView->getDirectoryContent('/substorage');
+        /**
+         * expected entries:
+         * folder
+         * foo.png
+         * foo.txt
+         */
+        $this->assertCount(3, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+
+        $folderView = new View($root . '/folder');
+        $this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertFalse($cachedData['encrypted']);
+        $id = $rootView->putFileInfo('/foo.txt', ['encrypted' => true]);
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertTrue($cachedData['encrypted']);
+        $this->assertEquals($cachedData['fileid'], $id);
+
+        $this->assertFalse($rootView->getFileInfo('/non/existing'));
+        $this->assertEquals([], $rootView->getDirectoryContent('/non/existing'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testGetPath(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+        Filesystem::mount($storage3, [], '/folder/anotherstorage');
+
+        $rootView = new View('');
+
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        /** @var int $id1 */
+        $id1 = $cachedData['fileid'];
+        $this->assertEquals('/foo.txt', $rootView->getPath($id1));
+
+        $cachedData = $rootView->getFileInfo('/substorage/foo.txt');
+        /** @var int $id2 */
+        $id2 = $cachedData['fileid'];
+        $this->assertEquals('/substorage/foo.txt', $rootView->getPath($id2));
+
+        $folderView = new View('/substorage');
+        $this->assertEquals('/foo.txt', $folderView->getPath($id2));
+    }
+
+
+    public function testGetPathNotExisting(): void {
+        $this->expectException(\OCP\Files\NotFoundException::class);
+
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $rootView = new View('');
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        /** @var int $id1 */
+        $id1 = $cachedData['fileid'];
+        $folderView = new View('/substorage');
+        $this->assertNull($folderView->getPath($id1));
+    }
+
+    /**
+     * @medium
+     */
+    public function testMountPointOverwrite(): void {
+        $storage1 = $this->getTestStorage(false);
+        $storage2 = $this->getTestStorage();
+        $storage1->mkdir('substorage');
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $folderContent = $rootView->getDirectoryContent('/');
+        $this->assertCount(4, $folderContent);
+    }
+
+    public static function sharingDisabledPermissionProvider(): array {
+        return [
+            ['no', '', true],
+            ['yes', 'group1', false],
+        ];
+    }
+
+    /**
+     * @dataProvider sharingDisabledPermissionProvider
+     */
+    public function testRemoveSharePermissionWhenSharingDisabledForUser($excludeGroups, $excludeGroupsList, $expectedShareable): void {
+        // Reset sharing disabled for users cache
+        self::invokePrivate(\OC::$server->get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
+
+        $config = \OC::$server->getConfig();
+        $oldExcludeGroupsFlag = $config->getAppValue('core', 'shareapi_exclude_groups', 'no');
+        $oldExcludeGroupsList = $config->getAppValue('core', 'shareapi_exclude_groups_list', '');
+        $config->setAppValue('core', 'shareapi_exclude_groups', $excludeGroups);
+        $config->setAppValue('core', 'shareapi_exclude_groups_list', $excludeGroupsList);
+
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/mount');
+
+        $view = new View('/');
+
+        $folderContent = $view->getDirectoryContent('');
+        $this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
+
+        $folderContent = $view->getDirectoryContent('mount');
+        $this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
+
+        $config->setAppValue('core', 'shareapi_exclude_groups', $oldExcludeGroupsFlag);
+        $config->setAppValue('core', 'shareapi_exclude_groups_list', $oldExcludeGroupsList);
+
+        // Reset sharing disabled for users cache
+        self::invokePrivate(\OC::$server->get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
+    }
+
+    public function testCacheIncompleteFolder(): void {
+        $storage1 = $this->getTestStorage(false);
+        Filesystem::mount($storage1, [], '/incomplete');
+        $rootView = new View('/incomplete');
+
+        $entries = $rootView->getDirectoryContent('/');
+        $this->assertCount(3, $entries);
+
+        // /folder will already be in the cache but not scanned
+        $entries = $rootView->getDirectoryContent('/folder');
+        $this->assertCount(1, $entries);
+    }
+
+    public function testAutoScan(): void {
+        $storage1 = $this->getTestStorage(false);
+        $storage2 = $this->getTestStorage(false);
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+        $textSize = strlen("dummy file data\n");
+
+        $rootView = new View('');
+
+        $cachedData = $rootView->getFileInfo('/');
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+        $this->assertEquals(-1, $cachedData['size']);
+
+        $folderData = $rootView->getDirectoryContent('/substorage/folder');
+        $this->assertEquals('text/plain', $folderData[0]['mimetype']);
+        $this->assertEquals($textSize, $folderData[0]['size']);
+    }
+
+    /**
+     * @medium
+     */
+    public function testSearch(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+        Filesystem::mount($storage3, [], '/folder/anotherstorage');
+
+        $rootView = new View('');
+
+        $results = $rootView->search('foo');
+        $this->assertCount(6, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $this->assertEquals($result['path'], Filesystem::normalizePath($result['path']));
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/foo.txt', $paths);
+        $this->assertContains('/foo.png', $paths);
+        $this->assertContains('/substorage/foo.txt', $paths);
+        $this->assertContains('/substorage/foo.png', $paths);
+        $this->assertContains('/folder/anotherstorage/foo.txt', $paths);
+        $this->assertContains('/folder/anotherstorage/foo.png', $paths);
+
+        $folderView = new View('/folder');
+        $results = $folderView->search('bar');
+        $this->assertCount(2, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/anotherstorage/folder/bar.txt', $paths);
+        $this->assertContains('/bar.txt', $paths);
+
+        $results = $folderView->search('foo');
+        $this->assertCount(2, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/anotherstorage/foo.txt', $paths);
+        $this->assertContains('/anotherstorage/foo.png', $paths);
+
+        $this->assertCount(6, $rootView->searchByMime('text'));
+        $this->assertCount(3, $folderView->searchByMime('text'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testWatcher(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        $storage1->getWatcher()->setPolicy(Watcher::CHECK_ALWAYS);
+
+        $rootView = new View('');
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(16, $cachedData['size']);
+
+        $rootView->putFileInfo('foo.txt', ['storage_mtime' => 10]);
+        $storage1->file_put_contents('foo.txt', 'foo');
+        clearstatcache();
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(3, $cachedData['size']);
+    }
+
+    /**
+     * @medium
+     */
+    public function testCopyBetweenStorageNoCross(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    /**
+     * @medium
+     */
+    public function testCopyBetweenStorageCross(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    /**
+     * @medium
+     */
+    public function testCopyBetweenStorageCrossNonLocal(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    public function copyBetweenStorages($storage1, $storage2) {
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->mkdir('substorage/emptyfolder');
+        $rootView->copy('substorage', 'anotherfolder');
+        $this->assertTrue($rootView->is_dir('/anotherfolder'));
+        $this->assertTrue($rootView->is_dir('/substorage'));
+        $this->assertTrue($rootView->is_dir('/anotherfolder/emptyfolder'));
+        $this->assertTrue($rootView->is_dir('/substorage/emptyfolder'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/foo.txt'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/foo.png'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/folder/bar.txt'));
+        $this->assertTrue($rootView->file_exists('/substorage/foo.txt'));
+        $this->assertTrue($rootView->file_exists('/substorage/foo.png'));
+        $this->assertTrue($rootView->file_exists('/substorage/folder/bar.txt'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testMoveBetweenStorageNoCross(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    /**
+     * @medium
+     */
+    public function testMoveBetweenStorageCross(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    /**
+     * @medium
+     */
+    public function testMoveBetweenStorageCrossNonLocal(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    public function moveBetweenStorages($storage1, $storage2) {
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->rename('foo.txt', 'substorage/folder/foo.txt');
+        $this->assertFalse($rootView->file_exists('foo.txt'));
+        $this->assertTrue($rootView->file_exists('substorage/folder/foo.txt'));
+        $rootView->rename('substorage/folder', 'anotherfolder');
+        $this->assertFalse($rootView->is_dir('substorage/folder'));
+        $this->assertTrue($rootView->file_exists('anotherfolder/foo.txt'));
+        $this->assertTrue($rootView->file_exists('anotherfolder/bar.txt'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testUnlink(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $rootView->file_put_contents('/substorage/bar.txt', 'asd');
+
+        $this->assertTrue($rootView->file_exists('foo.txt'));
+        $this->assertTrue($rootView->file_exists('substorage/bar.txt'));
+
+        $this->assertTrue($rootView->unlink('foo.txt'));
+        $this->assertTrue($rootView->unlink('substorage/bar.txt'));
+
+        $this->assertFalse($rootView->file_exists('foo.txt'));
+        $this->assertFalse($rootView->file_exists('substorage/bar.txt'));
+    }
+
+    public static function rmdirOrUnlinkDataProvider(): array {
+        return [['rmdir'], ['unlink']];
+    }
+
+    /**
+     * @dataProvider rmdirOrUnlinkDataProvider
+     */
+    public function testRmdir($method): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $rootView = new View('');
+        $rootView->mkdir('sub');
+        $rootView->mkdir('sub/deep');
+        $rootView->file_put_contents('/sub/deep/foo.txt', 'asd');
+
+        $this->assertTrue($rootView->file_exists('sub/deep/foo.txt'));
+
+        $this->assertTrue($rootView->$method('sub'));
+
+        $this->assertFalse($rootView->file_exists('sub'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testUnlinkRootMustFail(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $rootView->file_put_contents('/substorage/bar.txt', 'asd');
+
+        $this->assertFalse($rootView->unlink(''));
+        $this->assertFalse($rootView->unlink('/'));
+        $this->assertFalse($rootView->unlink('substorage'));
+        $this->assertFalse($rootView->unlink('/substorage'));
+    }
+
+    /**
+     * @medium
+     */
+    public function testTouch(): void {
+        $storage = $this->getTestStorage(true, TemporaryNoTouch::class);
+
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        $oldCachedData = $rootView->getFileInfo('foo.txt');
+
+        $rootView->touch('foo.txt', 500);
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(500, $cachedData['mtime']);
+        $this->assertEquals($oldCachedData['storage_mtime'], $cachedData['storage_mtime']);
+
+        $rootView->putFileInfo('foo.txt', ['storage_mtime' => 1000]); //make sure the watcher detects the change
+        $rootView->file_put_contents('foo.txt', 'asd');
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertGreaterThanOrEqual($oldCachedData['mtime'], $cachedData['mtime']);
+        $this->assertEquals($cachedData['storage_mtime'], $cachedData['mtime']);
+    }
+
+    /**
+     * @medium
+     */
+    public function testTouchFloat(): void {
+        $storage = $this->getTestStorage(true, TemporaryNoTouch::class);
+
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        $oldCachedData = $rootView->getFileInfo('foo.txt');
+
+        $rootView->touch('foo.txt', 500.5);
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(500, $cachedData['mtime']);
+    }
+
+    /**
+     * @medium
+     */
+    public function testViewHooks(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
+
+        $rootView = new View('');
+        $subView = new View($defaultRoot . '/substorage');
+        $this->hookPath = null;
+
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $this->assertNull($this->hookPath);
+
+        $subView->file_put_contents('/foo.txt', 'asd');
+        $this->assertEquals('/substorage/foo.txt', $this->hookPath);
+    }
+
+    private $hookPath;
+
+    public function dummyHook($params) {
+        $this->hookPath = $params['path'];
+    }
+
+    public function testSearchNotOutsideView(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        $storage1->rename('folder', 'foo');
+        $scanner = $storage1->getScanner();
+        $scanner->scan('');
+
+        $view = new View('/foo');
+
+        $result = $view->search('.txt');
+        $this->assertCount(1, $result);
+    }
+
+    /**
+     * @param bool $scan
+     * @param string $class
+     * @return \OC\Files\Storage\Storage
+     */
+    private function getTestStorage($scan = true, $class = Temporary::class) {
+        /**
+         * @var \OC\Files\Storage\Storage $storage
+         */
+        $storage = new $class([]);
+        $textData = "dummy file data\n";
+        $imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+        $storage->mkdir('folder');
+        $storage->file_put_contents('foo.txt', $textData);
+        $storage->file_put_contents('foo.png', $imgData);
+        $storage->file_put_contents('folder/bar.txt', $textData);
+
+        if ($scan) {
+            $scanner = $storage->getScanner();
+            $scanner->scan('');
+        }
+        $this->storages[] = $storage;
+        return $storage;
+    }
+
+    /**
+     * @medium
+     */
+    public function testViewHooksIfRootStartsTheSame(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
+
+        $subView = new View($defaultRoot . '_substorage');
+        $this->hookPath = null;
+
+        $subView->file_put_contents('/foo.txt', 'asd');
+        $this->assertNull($this->hookPath);
+    }
+
+    private $hookWritePath;
+    private $hookCreatePath;
+    private $hookUpdatePath;
+
+    public function dummyHookWrite($params) {
+        $this->hookWritePath = $params['path'];
+    }
+
+    public function dummyHookUpdate($params) {
+        $this->hookUpdatePath = $params['path'];
+    }
+
+    public function dummyHookCreate($params) {
+        $this->hookCreatePath = $params['path'];
+    }
+
+    public function testEditNoCreateHook(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot);
+        \OC_Hook::connect('OC_Filesystem', 'post_create', $this, 'dummyHookCreate');
+        \OC_Hook::connect('OC_Filesystem', 'post_update', $this, 'dummyHookUpdate');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHookWrite');
+
+        $view = new View($defaultRoot);
+        $this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
+
+        $view->file_put_contents('/asd.txt', 'foo');
+        $this->assertEquals('/asd.txt', $this->hookCreatePath);
+        $this->assertNull($this->hookUpdatePath);
+        $this->assertEquals('/asd.txt', $this->hookWritePath);
+
+        $this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
+
+        $view->file_put_contents('/asd.txt', 'foo');
+        $this->assertNull($this->hookCreatePath);
+        $this->assertEquals('/asd.txt', $this->hookUpdatePath);
+        $this->assertEquals('/asd.txt', $this->hookWritePath);
+
+        \OC_Hook::clear('OC_Filesystem', 'post_create');
+        \OC_Hook::clear('OC_Filesystem', 'post_update');
+        \OC_Hook::clear('OC_Filesystem', 'post_write');
+    }
+
+    /**
+     * @dataProvider resolvePathTestProvider
+     */
+    public function testResolvePath($expected, $pathToTest): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $view = new View('');
+
+        $result = $view->resolvePath($pathToTest);
+        $this->assertEquals($expected, $result[1]);
+
+        $exists = $view->file_exists($pathToTest);
+        $this->assertTrue($exists);
+
+        $exists = $view->file_exists($result[1]);
+        $this->assertTrue($exists);
+    }
+
+    public static function resolvePathTestProvider(): array {
+        return [
+            ['foo.txt', 'foo.txt'],
+            ['foo.txt', '/foo.txt'],
+            ['folder', 'folder'],
+            ['folder', '/folder'],
+            ['folder', 'folder/'],
+            ['folder', '/folder/'],
+            ['folder/bar.txt', 'folder/bar.txt'],
+            ['folder/bar.txt', '/folder/bar.txt'],
+            ['', ''],
+            ['', '/'],
+        ];
+    }
+
+    public function testUTF8Names(): void {
+        $names = ['虚', '和知しゃ和で', 'regular ascii', 'sɨˈrɪlɪk', 'ѨѬ', 'أنا أحب القراءة كثيرا'];
+
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        foreach ($names as $name) {
+            $rootView->file_put_contents('/' . $name, 'dummy content');
+        }
+
+        $list = $rootView->getDirectoryContent('/');
+
+        $this->assertCount(count($names), $list);
+        foreach ($list as $item) {
+            $this->assertContains($item['name'], $names);
+        }
+
+        $cache = $storage->getCache();
+        $scanner = $storage->getScanner();
+        $scanner->scan('');
+
+        $list = $cache->getFolderContents('');
+
+        $this->assertCount(count($names), $list);
+        foreach ($list as $item) {
+            $this->assertContains($item['name'], $names);
+        }
+    }
+
+    public function xtestLongPath() {
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+
+        $longPath = '';
+        $ds = DIRECTORY_SEPARATOR;
+        /*
 		 * 4096 is the maximum path length in file_cache.path in *nix
 		 * 1024 is the max path length in mac
 		 */
-		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
-		$tmpdirLength = strlen(\OC::$server->getTempManager()->getTemporaryFolder());
-		if (\OC_Util::runningOnMac()) {
-			$depth = ((1024 - $tmpdirLength) / 57);
-		} else {
-			$depth = ((4000 - $tmpdirLength) / 57);
-		}
-		foreach (range(0, $depth - 1) as $i) {
-			$longPath .= $ds . $folderName;
-			$result = $rootView->mkdir($longPath);
-			$this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
-
-			$result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
-			$this->assertEquals(5, $result, "file_put_contents failed on $i");
-
-			$this->assertTrue($rootView->file_exists($longPath));
-			$this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
-		}
-
-		$cache = $storage->getCache();
-		$scanner = $storage->getScanner();
-		$scanner->scan('');
-
-		$longPath = $folderName;
-		foreach (range(0, $depth - 1) as $i) {
-			$cachedFolder = $cache->get($longPath);
-			$this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
-			$this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
-
-			$cachedFile = $cache->get($longPath . '/test.txt');
-			$this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
-			$this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
-
-			$longPath .= $ds . $folderName;
-		}
-	}
-
-	public function testTouchNotSupported(): void {
-		$storage = new TemporaryNoTouch([]);
-		$scanner = $storage->getScanner();
-		Filesystem::mount($storage, [], '/test/');
-		$past = time() - 100;
-		$storage->file_put_contents('test', 'foobar');
-		$scanner->scan('');
-		$view = new View('');
-		$info = $view->getFileInfo('/test/test');
-
-		$view->touch('/test/test', $past);
-		$scanner->scanFile('test', \OC\Files\Cache\Scanner::REUSE_ETAG);
-
-		$info2 = $view->getFileInfo('/test/test');
-		$this->assertSame($info['etag'], $info2['etag']);
-	}
-
-	public function testWatcherEtagCrossStorage(): void {
-		$storage1 = new Temporary([]);
-		$storage2 = new Temporary([]);
-		$scanner1 = $storage1->getScanner();
-		$scanner2 = $storage2->getScanner();
-		$storage1->mkdir('sub');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		$past = time() - 100;
-		$storage2->file_put_contents('test.txt', 'foobar');
-		$scanner1->scan('');
-		$scanner2->scan('');
-		$view = new View('');
-
-		$storage2->getWatcher('')->setPolicy(Watcher::CHECK_ALWAYS);
-
-		$oldFileInfo = $view->getFileInfo('/test/sub/storage/test.txt');
-		$oldFolderInfo = $view->getFileInfo('/test');
-
-		$storage2->getCache()->update($oldFileInfo->getId(), [
-			'storage_mtime' => $past,
-		]);
-
-		$oldEtag = $oldFolderInfo->getEtag();
-
-		$view->getFileInfo('/test/sub/storage/test.txt');
-		$newFolderInfo = $view->getFileInfo('/test');
-
-		$this->assertNotEquals($newFolderInfo->getEtag(), $oldEtag);
-	}
-
-	/**
-	 * @dataProvider absolutePathProvider
-	 */
-	public function testGetAbsolutePath($expectedPath, $relativePath): void {
-		$view = new View('/files');
-		$this->assertEquals($expectedPath, $view->getAbsolutePath($relativePath));
-	}
-
-	public function testPartFileInfo(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		Filesystem::mount($storage, [], '/test/');
-		$storage->file_put_contents('test.part', 'foobar');
-		$scanner->scan('');
-		$view = new View('/test');
-		$info = $view->getFileInfo('test.part');
-
-		$this->assertInstanceOf('\OCP\Files\FileInfo', $info);
-		$this->assertNull($info->getId());
-		$this->assertEquals(6, $info->getSize());
-	}
-
-	public static function absolutePathProvider(): array {
-		return [
-			['/files/', ''],
-			['/files/0', '0'],
-			['/files/false', 'false'],
-			['/files/true', 'true'],
-			['/files/', '/'],
-			['/files/test', 'test'],
-			['/files/test', '/test'],
-		];
-	}
-
-	/**
-	 * @dataProvider chrootRelativePathProvider
-	 */
-	public function testChrootGetRelativePath($root, $absolutePath, $expectedPath): void {
-		$view = new View('/files');
-		$view->chroot($root);
-		$this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
-	}
-
-	public static function chrootRelativePathProvider(): array {
-		return self::relativePathProvider('/');
-	}
-
-	/**
-	 * @dataProvider initRelativePathProvider
-	 */
-	public function testInitGetRelativePath($root, $absolutePath, $expectedPath): void {
-		$view = new View($root);
-		$this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
-	}
-
-	public static function initRelativePathProvider(): array {
-		return self::relativePathProvider(null);
-	}
-
-	public static function relativePathProvider($missingRootExpectedPath): array {
-		return [
-			// No root - returns the path
-			['', '/files', '/files'],
-			['', '/files/', '/files/'],
-
-			// Root equals path - /
-			['/files/', '/files/', '/'],
-			['/files/', '/files', '/'],
-			['/files', '/files/', '/'],
-			['/files', '/files', '/'],
-
-			// False negatives: chroot fixes those by adding the leading slash.
-			// But setting them up with this root (instead of chroot($root))
-			// will fail them, although they should be the same.
-			// TODO init should be fixed, so it also adds the leading slash
-			['files/', '/files/', $missingRootExpectedPath],
-			['files', '/files/', $missingRootExpectedPath],
-			['files/', '/files', $missingRootExpectedPath],
-			['files', '/files', $missingRootExpectedPath],
-
-			// False negatives: Paths provided to the method should have a leading slash
-			// TODO input should be checked to have a leading slash
-			['/files/', 'files/', null],
-			['/files', 'files/', null],
-			['/files/', 'files', null],
-			['/files', 'files', null],
-
-			// with trailing slashes
-			['/files/', '/files/0', '0'],
-			['/files/', '/files/false', 'false'],
-			['/files/', '/files/true', 'true'],
-			['/files/', '/files/test', 'test'],
-			['/files/', '/files/test/foo', 'test/foo'],
-
-			// without trailing slashes
-			// TODO false expectation: Should match "with trailing slashes"
-			['/files', '/files/0', '/0'],
-			['/files', '/files/false', '/false'],
-			['/files', '/files/true', '/true'],
-			['/files', '/files/test', '/test'],
-			['/files', '/files/test/foo', '/test/foo'],
-
-			// leading slashes
-			['/files/', '/files_trashbin/', null],
-			['/files', '/files_trashbin/', null],
-			['/files/', '/files_trashbin', null],
-			['/files', '/files_trashbin', null],
-
-			// no leading slashes
-			['files/', 'files_trashbin/', null],
-			['files', 'files_trashbin/', null],
-			['files/', 'files_trashbin', null],
-			['files', 'files_trashbin', null],
-
-			// mixed leading slashes
-			['files/', '/files_trashbin/', null],
-			['/files/', 'files_trashbin/', null],
-			['files', '/files_trashbin/', null],
-			['/files', 'files_trashbin/', null],
-			['files/', '/files_trashbin', null],
-			['/files/', 'files_trashbin', null],
-			['files', '/files_trashbin', null],
-			['/files', 'files_trashbin', null],
-
-			['files', 'files_trashbin/test', null],
-			['/files', '/files_trashbin/test', null],
-			['/files', 'files_trashbin/test', null],
-		];
-	}
-
-	public function testFileView(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-		$view = new View('/test/foo.txt');
-
-		$this->assertEquals('bar', $view->file_get_contents(''));
-		$fh = tmpfile();
-		fwrite($fh, 'foo');
-		rewind($fh);
-		$view->file_put_contents('', $fh);
-		$this->assertEquals('foo', $view->file_get_contents(''));
-	}
-
-	/**
-	 * @dataProvider tooLongPathDataProvider
-	 */
-	public function testTooLongPath($operation, $param0 = null): void {
-		$this->expectException(\OCP\Files\InvalidPathException::class);
-
-
-		$longPath = '';
-		// 4000 is the maximum path length in file_cache.path
-		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
-		$depth = (4000 / 57);
-		foreach (range(0, $depth + 1) as $i) {
-			$longPath .= '/' . $folderName;
-		}
-
-		$storage = new Temporary([]);
-		$this->tempStorage = $storage; // for later hard cleanup
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-
-		if ($param0 === '@0') {
-			$param0 = $longPath;
-		}
-
-		if ($operation === 'hash') {
-			$param0 = $longPath;
-			$longPath = 'md5';
-		}
-
-		call_user_func([$rootView, $operation], $longPath, $param0);
-	}
-
-	public static function tooLongPathDataProvider(): array {
-		return [
-			['getAbsolutePath'],
-			['getRelativePath'],
-			['getMountPoint'],
-			['resolvePath'],
-			['getLocalFile'],
-			['mkdir'],
-			['rmdir'],
-			['opendir'],
-			['is_dir'],
-			['is_file'],
-			['stat'],
-			['filetype'],
-			['filesize'],
-			['readfile'],
-			['isCreatable'],
-			['isReadable'],
-			['isUpdatable'],
-			['isDeletable'],
-			['isSharable'],
-			['file_exists'],
-			['filemtime'],
-			['touch'],
-			['file_get_contents'],
-			['unlink'],
-			['deleteAll'],
-			['toTmpFile'],
-			['getMimeType'],
-			['free_space'],
-			['getFileInfo'],
-			['getDirectoryContent'],
-			['getOwner'],
-			['getETag'],
-			['file_put_contents', 'ipsum'],
-			['rename', '@0'],
-			['copy', '@0'],
-			['fopen', 'r'],
-			['fromTmpFile', '@0'],
-			['hash'],
-			['hasUpdated', 0],
-			['putFileInfo', []],
-		];
-	}
-
-	public function testRenameCrossStoragePreserveMtime(): void {
-		$storage1 = new Temporary([]);
-		$storage2 = new Temporary([]);
-		$storage1->mkdir('sub');
-		$storage1->mkdir('foo');
-		$storage1->file_put_contents('foo.txt', 'asd');
-		$storage1->file_put_contents('foo/bar.txt', 'asd');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		$view = new View('');
-		$time = time() - 200;
-		$view->touch('/test/foo.txt', $time);
-		$view->touch('/test/foo', $time);
-		$view->touch('/test/foo/bar.txt', $time);
-
-		$view->rename('/test/foo.txt', '/test/sub/storage/foo.txt');
-
-		$this->assertEquals($time, $view->filemtime('/test/sub/storage/foo.txt'));
-
-		$view->rename('/test/foo', '/test/sub/storage/foo');
-
-		$this->assertEquals($time, $view->filemtime('/test/sub/storage/foo/bar.txt'));
-	}
-
-	public function testRenameFailDeleteTargetKeepSource(): void {
-		$this->doTestCopyRenameFail('rename');
-	}
-
-	public function testCopyFailDeleteTargetKeepSource(): void {
-		$this->doTestCopyRenameFail('copy');
-	}
-
-	private function doTestCopyRenameFail($operation) {
-		$storage1 = new Temporary([]);
-		/** @var \PHPUnit\Framework\MockObject\MockObject|Temporary $storage2 */
-		$storage2 = $this->getMockBuilder(TemporaryNoCross::class)
-			->setConstructorArgs([[]])
-			->onlyMethods(['fopen', 'writeStream'])
-			->getMock();
-
-		$storage2->method('writeStream')
-			->willThrowException(new GenericFileException('Failed to copy stream'));
-
-		$storage1->mkdir('sub');
-		$storage1->file_put_contents('foo.txt', '0123456789ABCDEFGH');
-		$storage1->mkdir('dirtomove');
-		$storage1->file_put_contents('dirtomove/indir1.txt', '0123456'); // fits
-		$storage1->file_put_contents('dirtomove/indir2.txt', '0123456789ABCDEFGH'); // doesn't fit
-		$storage2->file_put_contents('existing.txt', '0123');
-		$storage1->getScanner()->scan('');
-		$storage2->getScanner()->scan('');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		// move file
-		$view = new View('');
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-		$this->assertFalse($storage2->file_exists('foo.txt'));
-		$this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/foo.txt'));
-		$this->assertFalse($storage2->file_exists('foo.txt'));
-		$this->assertFalse($storage2->getCache()->get('foo.txt'));
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-
-		// if target exists, it will be deleted too
-		$this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/existing.txt'));
-		$this->assertFalse($storage2->file_exists('existing.txt'));
-		$this->assertFalse($storage2->getCache()->get('existing.txt'));
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-
-		// move folder
-		$this->assertFalse($view->$operation('/test/dirtomove/', '/test/sub/storage/dirtomove/'));
-		// since the move failed, the full source tree is kept
-		$this->assertTrue($storage1->file_exists('dirtomove/indir1.txt'));
-		$this->assertTrue($storage1->file_exists('dirtomove/indir2.txt'));
-		// second file not moved/copied
-		$this->assertFalse($storage2->file_exists('dirtomove/indir2.txt'));
-		$this->assertFalse($storage2->getCache()->get('dirtomove/indir2.txt'));
-	}
-
-	public function testDeleteFailKeepCache(): void {
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->setConstructorArgs([[]])
-			->onlyMethods(['unlink'])
-			->getMock();
-		$storage->expects($this->once())
-			->method('unlink')
-			->willReturn(false);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->file_put_contents('foo.txt', 'asd');
-		$scanner->scan('');
-		Filesystem::mount($storage, [], '/test/');
-
-		$view = new View('/test');
-
-		$this->assertFalse($view->unlink('foo.txt'));
-		$this->assertTrue($cache->inCache('foo.txt'));
-	}
-
-	public static function directoryTraversalProvider(): array {
-		return [
-			['../test/'],
-			['..\\test\\my/../folder'],
-			['/test/my/../foo\\'],
-		];
-	}
-
-	/**
-	 * @dataProvider directoryTraversalProvider
-	 * @param string $root
-	 */
-	public function testConstructDirectoryTraversalException($root): void {
-		$this->expectException(\Exception::class);
-
-		new View($root);
-	}
-
-	public function testRenameOverWrite(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->mkdir('sub');
-		$storage->mkdir('foo');
-		$storage->file_put_contents('foo.txt', 'asd');
-		$storage->file_put_contents('foo/bar.txt', 'asd');
-		$scanner->scan('');
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('');
-		$this->assertTrue($view->rename('/test/foo.txt', '/test/foo/bar.txt'));
-	}
-
-	public function testSetMountOptionsInStorage(): void {
-		$mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['foo' => 'bar']);
-		Filesystem::getMountManager()->addMount($mount);
-		/** @var \OC\Files\Storage\Common $storage */
-		$storage = $mount->getStorage();
-		$this->assertEquals($storage->getMountOption('foo'), 'bar');
-	}
-
-	public function testSetMountOptionsWatcherPolicy(): void {
-		$mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['filesystem_check_changes' => Watcher::CHECK_NEVER]);
-		Filesystem::getMountManager()->addMount($mount);
-		/** @var \OC\Files\Storage\Common $storage */
-		$storage = $mount->getStorage();
-		$watcher = $storage->getWatcher();
-		$this->assertEquals(Watcher::CHECK_NEVER, $watcher->getPolicy());
-	}
-
-	public function testGetAbsolutePathOnNull(): void {
-		$view = new View();
-		$this->assertNull($view->getAbsolutePath(null));
-	}
-
-	public function testGetRelativePathOnNull(): void {
-		$view = new View();
-		$this->assertNull($view->getRelativePath(null));
-	}
-
-
-	public function testNullAsRoot(): void {
-		$this->expectException(\TypeError::class);
-
-		new View(null);
-	}
-
-	/**
-	 * e.g. reading from a folder that's being renamed
-	 *
-	 *
-	 * @dataProvider dataLockPaths
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	public function testReadFromWriteLockedPath($rootPath, $pathPrefix): void {
-		$this->expectException(\OCP\Lock\LockedException::class);
-
-		$rootPath = str_replace('{folder}', 'files', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
-	}
-
-	/**
-	 * Reading from a files_encryption folder that's being renamed
-	 *
-	 * @dataProvider dataLockPaths
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	public function testReadFromWriteUnlockablePath($rootPath, $pathPrefix): void {
-		$rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
-	}
-
-	/**
-	 * e.g. writing a file that's being downloaded
-	 *
-	 *
-	 * @dataProvider dataLockPaths
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	public function testWriteToReadLockedFile($rootPath, $pathPrefix): void {
-		$this->expectException(\OCP\Lock\LockedException::class);
-
-		$rootPath = str_replace('{folder}', 'files', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
-	}
-
-	/**
-	 * Writing a file that's being downloaded
-	 *
-	 * @dataProvider dataLockPaths
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	public function testWriteToReadUnlockableFile($rootPath, $pathPrefix): void {
-		$rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-	}
-
-	/**
-	 * Test that locks are on mount point paths instead of mount root
-	 */
-	public function testLockLocalMountPointPathInsteadOfStorageRoot(): void {
-		$lockingProvider = \OC::$server->get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
-
-		$this->assertTrue(
-			$view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, true),
-			'Can lock mount point'
-		);
-
-		// no exception here because storage root was not locked
-		$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$thrown = false;
-		try {
-			$storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Mount point path was locked on root storage');
-
-		$lockingProvider->releaseAll();
-	}
-
-	/**
-	 * Test that locks are on mount point paths and also mount root when requested
-	 */
-	public function testLockStorageRootButNotLocalMountPoint(): void {
-		$lockingProvider = \OC::$server->get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
-
-		$this->assertTrue(
-			$view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, false),
-			'Can lock mount point'
-		);
-
-		$thrown = false;
-		try {
-			$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Mount point storage root was locked on original storage');
-
-		// local mount point was not locked
-		$storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$lockingProvider->releaseAll();
-	}
-
-	/**
-	 * Test that locks are on mount point paths and also mount root when requested
-	 */
-	public function testLockMountPointPathFailReleasesBoth(): void {
-		$lockingProvider = \OC::$server->get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint.txt');
-
-		// this would happen if someone is writing on the mount point
-		$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$thrown = false;
-		try {
-			// this actually acquires two locks, one on the mount point and one on the storage root,
-			// but the one on the storage root will fail
-			$view->lockFile('/mountpoint.txt', ILockingProvider::LOCK_SHARED);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Cannot acquire shared lock because storage root is already locked');
-
-		// from here we expect that the lock on the local mount point was released properly
-		// so acquiring an exclusive lock will succeed
-		$storage->acquireLock('/testuser/files/mountpoint.txt', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$lockingProvider->releaseAll();
-	}
-
-	public static function dataLockPaths(): array {
-		return [
-			['/testuser/{folder}', ''],
-			['/testuser', '/{folder}'],
-			['', '/testuser/{folder}'],
-		];
-	}
-
-	public static function pathRelativeToFilesProvider(): array {
-		return [
-			['admin/files', ''],
-			['admin/files/x', 'x'],
-			['/admin/files', ''],
-			['/admin/files/sub', 'sub'],
-			['/admin/files/sub/', 'sub'],
-			['/admin/files/sub/sub2', 'sub/sub2'],
-			['//admin//files/sub//sub2', 'sub/sub2'],
-		];
-	}
-
-	/**
-	 * @dataProvider pathRelativeToFilesProvider
-	 */
-	public function testGetPathRelativeToFiles($path, $expectedPath): void {
-		$view = new View();
-		$this->assertEquals($expectedPath, $view->getPathRelativeToFiles($path));
-	}
-
-	public static function pathRelativeToFilesProviderExceptionCases(): array {
-		return [
-			[''],
-			['x'],
-			['files'],
-			['/files'],
-			['/admin/files_versions/abc'],
-		];
-	}
-
-	/**
-	 * @dataProvider pathRelativeToFilesProviderExceptionCases
-	 * @param string $path
-	 */
-	public function testGetPathRelativeToFilesWithInvalidArgument($path): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('$absolutePath must be relative to "files"');
-
-		$view = new View();
-		$view->getPathRelativeToFiles($path);
-	}
-
-	public function testChangeLock(): void {
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$view->lockFile('/test/sub', ILockingProvider::LOCK_SHARED);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-
-		$view->changeLock('//test/sub', ILockingProvider::LOCK_EXCLUSIVE);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-
-		$view->changeLock('test/sub', ILockingProvider::LOCK_SHARED);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-
-		$view->unlockFile('/test/sub/', ILockingProvider::LOCK_SHARED);
-
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-	}
-
-	public static function hookPathProvider(): array {
-		return [
-			['/foo/files', '/foo', true],
-			['/foo/files/bar', '/foo', true],
-			['/foo', '/foo', false],
-			['/foo', '/files/foo', true],
-			['/foo', 'filesfoo', false],
-			['', '/foo/files', true],
-			['', '/foo/files/bar.txt', true],
-		];
-	}
-
-	/**
-	 * @dataProvider hookPathProvider
-	 * @param $root
-	 * @param $path
-	 * @param $shouldEmit
-	 */
-	public function testHookPaths($root, $path, $shouldEmit): void {
-		$filesystemReflection = new \ReflectionClass(Filesystem::class);
-		$defaultRootValue = $filesystemReflection->getProperty('defaultInstance');
-		$defaultRootValue->setAccessible(true);
-		$oldRoot = $defaultRootValue->getValue();
-		$defaultView = new View('/foo/files');
-		$defaultRootValue->setValue(null, $defaultView);
-		$view = new View($root);
-		$result = self::invokePrivate($view, 'shouldEmitHooks', [$path]);
-		$defaultRootValue->setValue(null, $oldRoot);
-		$this->assertEquals($shouldEmit, $result);
-	}
-
-	/**
-	 * Create test movable mount points
-	 *
-	 * @param array $mountPoints array of mount point locations
-	 * @return array array of MountPoint objects
-	 */
-	private function createTestMovableMountPoints($mountPoints) {
-		$mounts = [];
-		foreach ($mountPoints as $mountPoint) {
-			$storage = $this->getMockBuilder(Storage::class)
-				->onlyMethods([])
-				->getMock();
-			$storage->method('getId')->willReturn('non-null-id');
-			$storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
-				return new \OC\Files\Cache\Storage($storage, true, \OC::$server->get(IDBConnection::class));
-			});
-
-			$mounts[] = $this->getMockBuilder(TestMoveableMountPoint::class)
-				->onlyMethods(['moveMount'])
-				->setConstructorArgs([$storage, $mountPoint])
-				->getMock();
-		}
-
-		/** @var IMountProvider|\PHPUnit\Framework\MockObject\MockObject $mountProvider */
-		$mountProvider = $this->createMock(IMountProvider::class);
-		$mountProvider->expects($this->any())
-			->method('getMountsForUser')
-			->willReturn($mounts);
-
-		$mountProviderCollection = \OC::$server->getMountProviderCollection();
-		$mountProviderCollection->registerProvider($mountProvider);
-
-		return $mounts;
-	}
-
-	/**
-	 * Test mount point move
-	 */
-	public function testMountPointMove(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-		$mount1->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$mount2->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('sub');
-
-		$this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
-		$this->assertTrue($view->rename('mount2', 'sub/moved_mount'), 'Can move a mount point into a subdirectory');
-	}
-
-	public function testMoveMountPointOverwrite(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->never())
-			->method('moveMount');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$this->expectException(ForbiddenException::class);
-		$view->rename('mount1', 'mount2');
-	}
-
-	public function testMoveMountPointIntoMount(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->never())
-			->method('moveMount');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$this->expectException(ForbiddenException::class);
-		$view->rename('mount1', 'mount2/sub');
-	}
-
-	/**
-	 * Test that moving a mount point into a shared folder is forbidden
-	 */
-	public function testMoveMountPointIntoSharedFolder(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('shareddir');
-		$view->mkdir('shareddir/sub');
-		$view->mkdir('shareddir/sub2');
-		// Create a similar named but non-shared folder
-		$view->mkdir('shareddir notshared');
-
-		$fileId = $view->getFileInfo('shareddir')->getId();
-		$userObject = \OC::$server->getUserManager()->createUser('test2', 'IHateNonMockableStaticClasses');
-
-		$userFolder = \OC::$server->getUserFolder($this->user);
-		$shareDir = $userFolder->get('shareddir');
-		$shareManager = \OC::$server->get(IShareManager::class);
-		$share = $shareManager->newShare();
-		$share->setSharedWith('test2')
-			->setSharedBy($this->user)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(\OCP\Constants::PERMISSION_READ)
-			->setNode($shareDir);
-		$shareManager->createShare($share);
-
-		try {
-			$view->rename('mount1', 'shareddir');
-			$this->fail('Cannot overwrite shared folder');
-		} catch (ForbiddenException $e) {
-
-		}
-		try {
-			$view->rename('mount1', 'shareddir/sub');
-			$this->fail('Cannot move mount point into shared folder');
-		} catch (ForbiddenException $e) {
-
-		}
-		try {
-			$view->rename('mount1', 'shareddir/sub/sub2');
-			$this->fail('Cannot move mount point into shared subfolder');
-		} catch (ForbiddenException $e) {
-
-		}
-		$this->assertTrue($view->rename('mount2', 'shareddir notshared/sub'), 'Can move mount point into a similarly named but non-shared folder');
-
-		$shareManager->deleteShare($share);
-		$userObject->delete();
-	}
-
-	public static function basicOperationProviderForLocks(): array {
-		return [
-			// --- write hook ----
-			[
-				'touch',
-				['touch-create.txt'],
-				'touch-create.txt',
-				'create',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'fopen',
-				['test-write.txt', 'w'],
-				'test-write.txt',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				null,
-				// exclusive lock stays until fclose
-				ILockingProvider::LOCK_EXCLUSIVE,
-			],
-			[
-				'mkdir',
-				['newdir'],
-				'newdir',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'file_put_contents',
-				['file_put_contents.txt', 'blah'],
-				'file_put_contents.txt',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				0,
-			],
-
-			// ---- delete hook ----
-			[
-				'rmdir',
-				['dir'],
-				'dir',
-				'delete',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'unlink',
-				['test.txt'],
-				'test.txt',
-				'delete',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-
-			// ---- read hook (no post hooks) ----
-			[
-				'file_get_contents',
-				['test.txt'],
-				'test.txt',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				null,
-				false,
-			],
-			[
-				'fopen',
-				['test.txt', 'r'],
-				'test.txt',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-			],
-			[
-				'opendir',
-				['dir'],
-				'dir',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-			],
-
-			// ---- no lock, touch hook ---
-			['touch', ['test.txt'], 'test.txt', 'touch', null, null, null],
-
-			// ---- no hooks, no locks ---
-			['is_dir', ['dir'], 'dir', null],
-			['is_file', ['dir'], 'dir', null],
-			[
-				'stat',
-				['dir'],
-				'dir',
-				null,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-			[
-				'filetype',
-				['dir'],
-				'dir',
-				null,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-			[
-				'filesize',
-				['dir'],
-				'dir',
-				null,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				/* Return an int */
-				100
-			],
-			['isCreatable', ['dir'], 'dir', null],
-			['isReadable', ['dir'], 'dir', null],
-			['isUpdatable', ['dir'], 'dir', null],
-			['isDeletable', ['dir'], 'dir', null],
-			['isSharable', ['dir'], 'dir', null],
-			['file_exists', ['dir'], 'dir', null],
-			[
-				'filemtime',
-				['dir'],
-				'dir',
-				null,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-		];
-	}
-
-	/**
-	 * Test whether locks are set before and after the operation
-	 *
-	 * @dataProvider basicOperationProviderForLocks
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $lockedPath path of the locked item to check
-	 * @param string $hookType hook type
-	 * @param int $expectedLockBefore expected lock during pre hooks
-	 * @param int $expectedLockDuring expected lock during operation
-	 * @param int $expectedLockAfter expected lock during post hooks
-	 * @param int $expectedStrayLock expected lock after returning, should
-	 *                               be null (unlock) for most operations
-	 */
-	public function testLockBasicOperation(
-		$operation,
-		$operationArgs,
-		$lockedPath,
-		$hookType,
-		$expectedLockBefore = ILockingProvider::LOCK_SHARED,
-		$expectedLockDuring = ILockingProvider::LOCK_SHARED,
-		$expectedLockAfter = ILockingProvider::LOCK_SHARED,
-		$expectedStrayLock = null,
-		$returnValue = true,
-	): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary&MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
-		Server::get(ITrashManager::class)->pauseTrash();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		// work directly on disk because mkdir might be mocked
-		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
-					$lockTypeDuring = $this->getFileLockType($view, $lockedPath);
-
-					return $returnValue;
-				}
-			);
-
-		$this->assertNull($this->getFileLockType($view, $lockedPath), 'File not locked before operation');
-
-		$this->connectMockHooks($hookType, $view, $lockedPath, $lockTypePre, $lockTypePost);
-
-		// do operation
-		call_user_func_array([$view, $operation], $operationArgs);
-
-		if ($hookType !== null) {
-			$this->assertEquals($expectedLockBefore, $lockTypePre, 'File locked properly during pre-hook');
-			$this->assertEquals($expectedLockAfter, $lockTypePost, 'File locked properly during post-hook');
-			$this->assertEquals($expectedLockDuring, $lockTypeDuring, 'File locked properly during operation');
-		} else {
-			$this->assertNull($lockTypeDuring, 'File not locked during operation');
-		}
-
-		$this->assertEquals($expectedStrayLock, $this->getFileLockType($view, $lockedPath));
-
-		/* Resume trash to avoid side effects */
-		Server::get(ITrashManager::class)->resumeTrash();
-	}
-
-	/**
-	 * Test locks for file_put_content with stream.
-	 * This code path uses $storage->fopen instead
-	 */
-	public function testLockFilePutContentWithStream(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$path = 'test_file_put_contents.txt';
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		$storage->expects($this->once())
-			->method('fopen')
-			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
-					$lockTypeDuring = $this->getFileLockType($view, $path);
-
-					return fopen('php://temp', 'r+');
-				}
-			);
-
-		$this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
-
-		// do operation
-		$view->file_put_contents($path, fopen('php://temp', 'r+'));
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePost, 'File locked properly during post-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
-
-		$this->assertNull($this->getFileLockType($view, $path));
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 */
-	public function testLockFopen(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$path = 'test_file_put_contents.txt';
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		$storage->expects($this->once())
-			->method('fopen')
-			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
-					$lockTypeDuring = $this->getFileLockType($view, $path);
-
-					return fopen('php://temp', 'r+');
-				}
-			);
-
-		$this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
-
-		// do operation
-		$res = $view->fopen($path, 'w');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
-		$this->assertNull($lockTypePost, 'No post hook, no lock check possible');
-
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File still locked after fopen');
-
-		fclose($res);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File unlocked after fclose');
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 *
-	 * @dataProvider basicOperationProviderForLocks
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $path path of the locked item to check
-	 */
-	public function testLockBasicOperationUnlocksAfterException(
-		$operation,
-		$operationArgs,
-		$path,
-	): void {
-		if ($operation === 'touch') {
-			$this->markTestSkipped('touch handles storage exceptions internally');
-		}
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
-		Server::get(ITrashManager::class)->pauseTrash();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		// work directly on disk because mkdir might be mocked
-		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function () {
-					throw new \Exception('Simulated exception');
-				}
-			);
-
-		$thrown = false;
-		try {
-			call_user_func_array([$view, $operation], $operationArgs);
-		} catch (\Exception $e) {
-			$thrown = true;
-			$this->assertEquals('Simulated exception', $e->getMessage());
-		}
-		$this->assertTrue($thrown, 'Exception was rethrown');
-		$this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
-
-		/* Resume trash to avoid side effects */
-		Server::get(ITrashManager::class)->resumeTrash();
-	}
-
-	public function testLockBasicOperationUnlocksAfterLockException(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$storage = new Temporary([]);
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		$storage->mkdir('files');
-		$storage->mkdir('files/dir');
-		$storage->file_put_contents('files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		// get a shared lock
-		$handle = $view->fopen('test.txt', 'r');
-
-		$thrown = false;
-		try {
-			// try (and fail) to get a write lock
-			$view->unlink('test.txt');
-		} catch (\Exception $e) {
-			$thrown = true;
-			$this->assertInstanceOf(LockedException::class, $e);
-		}
-		$this->assertTrue($thrown, 'Exception was rethrown');
-
-		// clean shared lock
-		fclose($handle);
-
-		$this->assertNull($this->getFileLockType($view, 'test.txt'), 'File got unlocked');
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 *
-	 * @dataProvider basicOperationProviderForLocks
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $path path of the locked item to check
-	 * @param string $hookType hook type
-	 */
-	public function testLockBasicOperationUnlocksAfterCancelledHook(
-		$operation,
-		$operationArgs,
-		$path,
-		$hookType,
-	): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			$hookType,
-			HookHelper::class,
-			'cancellingCallback'
-		);
-
-		call_user_func_array([$view, $operation], $operationArgs);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
-	}
-
-	public static function lockFileRenameOrCopyDataProvider(): array {
-		return [
-			['rename', ILockingProvider::LOCK_EXCLUSIVE],
-			['copy', ILockingProvider::LOCK_SHARED],
-		];
-	}
-
-	/**
-	 * Test locks for rename or copy operation
-	 *
-	 * @dataProvider lockFileRenameOrCopyDataProvider
-	 *
-	 * @param string $operation operation to be done on the view
-	 * @param int $expectedLockTypeSourceDuring expected lock type on source file during
-	 *                                          the operation
-	 */
-	public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation, 'getMetaData', 'filemtime'])
-			->getMock();
-
-		$storage->expects($this->any())
-			->method('getMetaData')
-			->will($this->returnValue([
-				'mtime' => 1885434487,
-				'etag' => '',
-				'mimetype' => 'text/plain',
-				'permissions' => Constants::PERMISSION_ALL,
-				'size' => 3
-			]));
-		$storage->expects($this->any())
-			->method('filemtime')
-			->willReturn(123456789);
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks($operation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks($operation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		$view->$operation($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
-		$this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-	}
-
-	/**
-	 * simulate a failed copy operation.
-	 * We expect that we catch the exception, free the lock and re-throw it.
-	 *
-	 */
-	public function testLockFileCopyException(): void {
-		$this->expectException(\Exception::class);
-
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['copy'])
-			->getMock();
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-
-		$storage->expects($this->once())
-			->method('copy')
-			->willReturnCallback(
-				function () {
-					throw new \Exception();
-				}
-			);
-
-		$this->connectMockHooks('copy', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks('copy', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		try {
-			$view->copy($sourcePath, $targetPath);
-		} catch (\Exception $e) {
-			$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-			$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-			throw $e;
-		}
-	}
-
-	/**
-	 * Test rename operation: unlock first path when second path was locked
-	 */
-	public function testLockFileRenameUnlockOnException(): void {
-		self::loginAsUser('test');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-		$view->file_put_contents($sourcePath, 'meh');
-
-		// simulate that the target path is already locked
-		$view->lockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file is locked before operation');
-
-		$thrown = false;
-		try {
-			$view->rename($sourcePath, $targetPath);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown, 'LockedException thrown');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file still locked after operation');
-
-		$view->unlockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
-	}
-
-	/**
-	 * Test rename operation: unlock first path when second path was locked
-	 */
-	public function testGetOwner(): void {
-		self::loginAsUser('test');
-
-		$view = new View('/test/files/');
-
-		$path = 'foo.txt';
-		$view->file_put_contents($path, 'meh');
-
-		$this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
-
-		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
-			return $info->getName() === 'foo.txt';
-		}));
-
-		$this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
-
-		$subStorage = new Temporary();
-		Filesystem::mount($subStorage, [], '/test/files/asd');
-
-		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
-			return $info->getName() === 'asd';
-		}));
-
-		$this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
-	}
-
-	public static function lockFileRenameOrCopyCrossStorageDataProvider(): array {
-		return [
-			['rename', 'moveFromStorage', ILockingProvider::LOCK_EXCLUSIVE],
-			['copy', 'copyFromStorage', ILockingProvider::LOCK_SHARED],
-		];
-	}
-
-	/**
-	 * Test locks for rename or copy operation cross-storage
-	 *
-	 * @dataProvider lockFileRenameOrCopyCrossStorageDataProvider
-	 *
-	 * @param string $viewOperation operation to be done on the view
-	 * @param string $storageOperation operation to be mocked on the storage
-	 * @param int $expectedLockTypeSourceDuring expected lock type on source file during
-	 *                                          the operation
-	 */
-	public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$storageOperation])
-			->getMock();
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage2 */
-		$storage2 = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$storageOperation, 'getMetaData', 'filemtime'])
-			->getMock();
-
-		$storage2->expects($this->any())
-			->method('getMetaData')
-			->will($this->returnValue([
-				'mtime' => 1885434487,
-				'etag' => '',
-				'mimetype' => 'text/plain',
-				'permissions' => Constants::PERMISSION_ALL,
-				'size' => 3
-			]));
-		$storage2->expects($this->any())
-			->method('filemtime')
-			->willReturn(123456789);
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'substorage/target.txt';
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		Filesystem::mount($storage2, [], $this->user . '/files/substorage');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-		$storage2->getUpdater()->update('');
-
-		$storage->expects($this->never())
-			->method($storageOperation);
-		$storage2->expects($this->once())
-			->method($storageOperation)
-			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks($viewOperation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks($viewOperation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		$view->$viewOperation($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
-		$this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-	}
-
-	/**
-	 * Test locks when moving a mount point
-	 */
-	public function testLockMoveMountPoint(): void {
-		self::loginAsUser('test');
-
-		[$mount] = $this->createTestMovableMountPoints([
-			$this->user . '/files/substorage',
-		]);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('subdir');
-
-		$sourcePath = 'substorage';
-		$targetPath = 'subdir/substorage_moved';
-
-		$mount->expects($this->once())
-			->method('moveMount')
-			->willReturnCallback(
-				function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
-
-					$lockTypeSharedRootDuring = $this->getFileLockType($view, $sourcePath, false);
-
-					$mount->setMountPoint($target);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost, true);
-		$this->connectMockHooks('rename', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost, true);
-		// in pre-hook, mount point is still on $sourcePath
-		$this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSharedRootPre, $dummy, false);
-		// in post-hook, mount point is now on $targetPath
-		$this->connectMockHooks('rename', $view, $targetPath, $dummy, $lockTypeSharedRootPost, false);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked before operation');
-
-		$view->rename($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source path locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeSourceDuring, 'Source path locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source path locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target path locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target path locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target path locked properly during post-hook');
-
-		$this->assertNull($lockTypeSharedRootPre, 'Shared storage root not locked during pre-hook');
-		$this->assertNull($lockTypeSharedRootDuring, 'Shared storage root not locked during move');
-		$this->assertNull($lockTypeSharedRootPost, 'Shared storage root not locked during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked after operation');
-	}
-
-	/**
-	 * Connect hook callbacks for hook type
-	 *
-	 * @param string $hookType hook type or null for none
-	 * @param View $view view to check the lock on
-	 * @param string $path path for which to check the lock
-	 * @param int $lockTypePre variable to receive lock type that was active in the pre-hook
-	 * @param int $lockTypePost variable to receive lock type that was active in the post-hook
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 */
-	private function connectMockHooks($hookType, $view, $path, &$lockTypePre, &$lockTypePost, $onMountPoint = false) {
-		if ($hookType === null) {
-			return;
-		}
-
-		$eventHandler = $this->getMockBuilder(TestEventHandler::class)
-			->onlyMethods(['preCallback', 'postCallback'])
-			->getMock();
-
-		$eventHandler->expects($this->any())
-			->method('preCallback')
-			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePre) {
-					$lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
-				}
-			);
-		$eventHandler->expects($this->any())
-			->method('postCallback')
-			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePost) {
-					$lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
-				}
-			);
-
-		if ($hookType !== null) {
-			Util::connectHook(
-				Filesystem::CLASSNAME,
-				$hookType,
-				$eventHandler,
-				'preCallback'
-			);
-			Util::connectHook(
-				Filesystem::CLASSNAME,
-				'post_' . $hookType,
-				$eventHandler,
-				'postCallback'
-			);
-		}
-	}
-
-	/**
-	 * Returns the file lock type
-	 *
-	 * @param View $view view
-	 * @param string $path path
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 *
-	 * @return int lock type or null if file was not locked
-	 */
-	private function getFileLockType(View $view, $path, $onMountPoint = false) {
-		if ($this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE, $onMountPoint)) {
-			return ILockingProvider::LOCK_EXCLUSIVE;
-		} elseif ($this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED, $onMountPoint)) {
-			return ILockingProvider::LOCK_SHARED;
-		}
-		return null;
-	}
-
-
-	public function testRemoveMoveableMountPoint(): void {
-		$mountPoint = '/' . $this->user . '/files/mount/';
-
-		// Mock the mount point
-		/** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
-		$mount = $this->createMock(TestMoveableMountPoint::class);
-		$mount->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mount->expects($this->once())
-			->method('removeMount')
-			->willReturn('foo');
-		$mount->expects($this->any())
-			->method('getInternalPath')
-			->willReturn('');
-
-		// Register mount
-		Filesystem::getMountManager()->addMount($mount);
-
-		// Listen for events
-		$eventHandler = $this->getMockBuilder(TestEventHandler::class)
-			->onlyMethods(['umount', 'post_umount'])
-			->getMock();
-		$eventHandler->expects($this->once())
-			->method('umount')
-			->with([Filesystem::signal_param_path => '/mount']);
-		$eventHandler->expects($this->once())
-			->method('post_umount')
-			->with([Filesystem::signal_param_path => '/mount']);
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			'umount',
-			$eventHandler,
-			'umount'
-		);
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			'post_umount',
-			$eventHandler,
-			'post_umount'
-		);
-
-		//Delete the mountpoint
-		$view = new View('/' . $this->user . '/files');
-		$this->assertEquals('foo', $view->rmdir('mount'));
-	}
-
-	public static function mimeFilterProvider(): array {
-		return [
-			[null, ['test1.txt', 'test2.txt', 'test3.md', 'test4.png']],
-			['text/plain', ['test1.txt', 'test2.txt']],
-			['text/markdown', ['test3.md']],
-			['text', ['test1.txt', 'test2.txt', 'test3.md']],
-		];
-	}
-
-	/**
-	 * @param string $filter
-	 * @param string[] $expected
-	 * @dataProvider mimeFilterProvider
-	 */
-	public function testGetDirectoryContentMimeFilter($filter, $expected): void {
-		$storage1 = new Temporary();
-		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		$view = new View($root);
-
-		$view->file_put_contents('test1.txt', 'asd');
-		$view->file_put_contents('test2.txt', 'asd');
-		$view->file_put_contents('test3.md', 'asd');
-		$view->file_put_contents('test4.png', '');
-
-		$content = $view->getDirectoryContent('', $filter);
-
-		$files = array_map(function (FileInfo $info) {
-			return $info->getName();
-		}, $content);
-		sort($files);
-
-		$this->assertEquals($expected, $files);
-	}
-
-	public function testFilePutContentsClearsChecksum(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$view = new View('/test/foo.txt');
-		$view->putFileInfo('.', ['checksum' => '42']);
-
-		$this->assertEquals('bar', $view->file_get_contents(''));
-		$fh = tmpfile();
-		fwrite($fh, 'fooo');
-		rewind($fh);
-		clearstatcache();
-		$view->file_put_contents('', $fh);
-		$this->assertEquals('fooo', $view->file_get_contents(''));
-		$data = $view->getFileInfo('.');
-		$this->assertEquals('', $data->getChecksum());
-	}
-
-	public function testDeleteGhostFile(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$storage->unlink('foo.txt');
-
-		$this->assertTrue($cache->inCache('foo.txt'));
-
-		$view = new View('/test');
-		$rootInfo = $view->getFileInfo('');
-		$this->assertEquals(3, $rootInfo->getSize());
-		$view->unlink('foo.txt');
-		$newInfo = $view->getFileInfo('');
-
-		$this->assertFalse($cache->inCache('foo.txt'));
-		$this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
-		$this->assertEquals(0, $newInfo->getSize());
-	}
-
-	public function testDeleteGhostFolder(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->mkdir('foo');
-		$storage->file_put_contents('foo/foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$storage->rmdir('foo');
-
-		$this->assertTrue($cache->inCache('foo'));
-		$this->assertTrue($cache->inCache('foo/foo.txt'));
-
-		$view = new View('/test');
-		$rootInfo = $view->getFileInfo('');
-		$this->assertEquals(3, $rootInfo->getSize());
-		$view->rmdir('foo');
-		$newInfo = $view->getFileInfo('');
-
-		$this->assertFalse($cache->inCache('foo'));
-		$this->assertFalse($cache->inCache('foo/foo.txt'));
-		$this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
-		$this->assertEquals(0, $newInfo->getSize());
-	}
-
-	public function testCreateParentDirectories(): void {
-		$view = $this->getMockBuilder(View::class)
-			->disableOriginalConstructor()
-			->onlyMethods([
-				'is_file',
-				'file_exists',
-				'mkdir',
-			])
-			->getMock();
-
-		$view->expects($this->exactly(3))
-			->method('is_file')
-			->willReturnMap([
-				['/new', false],
-				['/new/folder', false],
-				['/new/folder/structure', false],
-			]);
-		$view->expects($this->exactly(3))
-			->method('file_exists')
-			->willReturnMap([
-				['/new', true],
-				['/new/folder', false],
-				['/new/folder/structure', false],
-			]);
-
-		$calls = ['/new/folder', '/new/folder/structure'];
-		$view->expects($this->exactly(2))
-			->method('mkdir')
-			->willReturnCallback(function ($dir) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $dir);
-			});
-
-		$this->assertTrue(self::invokePrivate($view, 'createParentDirectories', ['/new/folder/structure']));
-	}
-
-	public function testCreateParentDirectoriesWithExistingFile(): void {
-		$view = $this->getMockBuilder(View::class)
-			->disableOriginalConstructor()
-			->onlyMethods([
-				'is_file',
-				'file_exists',
-				'mkdir',
-			])
-			->getMock();
-
-		$view
-			->expects($this->once())
-			->method('is_file')
-			->with('/file.txt')
-			->willReturn(true);
-		$this->assertFalse(self::invokePrivate($view, 'createParentDirectories', ['/file.txt/folder/structure']));
-	}
-
-	public function testCacheExtension(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		$scanner->scan('');
-
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('/test');
-
-		$info = $view->getFileInfo('/foo.txt');
-		$this->assertEquals(0, $info->getUploadTime());
-		$this->assertEquals(0, $info->getCreationTime());
-
-		$view->putFileInfo('/foo.txt', ['upload_time' => 25]);
-
-		$info = $view->getFileInfo('/foo.txt');
-		$this->assertEquals(25, $info->getUploadTime());
-		$this->assertEquals(0, $info->getCreationTime());
-	}
-
-	public function testFopenGone(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		$scanner->scan('');
-		$cache = $storage->getCache();
-
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('/test');
-
-		$storage->unlink('foo.txt');
-
-		$this->assertTrue($cache->inCache('foo.txt'));
-
-		$this->assertFalse($view->fopen('foo.txt', 'r'));
-
-		$this->assertFalse($cache->inCache('foo.txt'));
-	}
-
-	public function testMountpointParentsCreated(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage2, [], '/A/B/C');
-
-		$rootView = new View('');
-
-		$folderData = $rootView->getDirectoryContent('/');
-		$this->assertCount(4, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-		$this->assertEquals('A', $folderData[3]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A');
-		$this->assertCount(1, $folderData);
-		$this->assertEquals('B', $folderData[0]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A/B');
-		$this->assertCount(1, $folderData);
-		$this->assertEquals('C', $folderData[0]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A/B/C');
-		$this->assertCount(3, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-	}
-
-	public function testCopyPreservesContent() {
-		$viewUser1 = new View('/' . 'userId' . '/files');
-		$viewUser1->mkdir('');
-		$viewUser1->file_put_contents('foo.txt', 'foo');
-		$viewUser1->copy('foo.txt', 'bar.txt');
-		$this->assertEquals('foo', $viewUser1->file_get_contents('bar.txt'));
-	}
+        $folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
+        $tmpdirLength = strlen(\OC::$server->getTempManager()->getTemporaryFolder());
+        if (\OC_Util::runningOnMac()) {
+            $depth = ((1024 - $tmpdirLength) / 57);
+        } else {
+            $depth = ((4000 - $tmpdirLength) / 57);
+        }
+        foreach (range(0, $depth - 1) as $i) {
+            $longPath .= $ds . $folderName;
+            $result = $rootView->mkdir($longPath);
+            $this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
+
+            $result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
+            $this->assertEquals(5, $result, "file_put_contents failed on $i");
+
+            $this->assertTrue($rootView->file_exists($longPath));
+            $this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
+        }
+
+        $cache = $storage->getCache();
+        $scanner = $storage->getScanner();
+        $scanner->scan('');
+
+        $longPath = $folderName;
+        foreach (range(0, $depth - 1) as $i) {
+            $cachedFolder = $cache->get($longPath);
+            $this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
+            $this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
+
+            $cachedFile = $cache->get($longPath . '/test.txt');
+            $this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
+            $this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
+
+            $longPath .= $ds . $folderName;
+        }
+    }
+
+    public function testTouchNotSupported(): void {
+        $storage = new TemporaryNoTouch([]);
+        $scanner = $storage->getScanner();
+        Filesystem::mount($storage, [], '/test/');
+        $past = time() - 100;
+        $storage->file_put_contents('test', 'foobar');
+        $scanner->scan('');
+        $view = new View('');
+        $info = $view->getFileInfo('/test/test');
+
+        $view->touch('/test/test', $past);
+        $scanner->scanFile('test', \OC\Files\Cache\Scanner::REUSE_ETAG);
+
+        $info2 = $view->getFileInfo('/test/test');
+        $this->assertSame($info['etag'], $info2['etag']);
+    }
+
+    public function testWatcherEtagCrossStorage(): void {
+        $storage1 = new Temporary([]);
+        $storage2 = new Temporary([]);
+        $scanner1 = $storage1->getScanner();
+        $scanner2 = $storage2->getScanner();
+        $storage1->mkdir('sub');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        $past = time() - 100;
+        $storage2->file_put_contents('test.txt', 'foobar');
+        $scanner1->scan('');
+        $scanner2->scan('');
+        $view = new View('');
+
+        $storage2->getWatcher('')->setPolicy(Watcher::CHECK_ALWAYS);
+
+        $oldFileInfo = $view->getFileInfo('/test/sub/storage/test.txt');
+        $oldFolderInfo = $view->getFileInfo('/test');
+
+        $storage2->getCache()->update($oldFileInfo->getId(), [
+            'storage_mtime' => $past,
+        ]);
+
+        $oldEtag = $oldFolderInfo->getEtag();
+
+        $view->getFileInfo('/test/sub/storage/test.txt');
+        $newFolderInfo = $view->getFileInfo('/test');
+
+        $this->assertNotEquals($newFolderInfo->getEtag(), $oldEtag);
+    }
+
+    /**
+     * @dataProvider absolutePathProvider
+     */
+    public function testGetAbsolutePath($expectedPath, $relativePath): void {
+        $view = new View('/files');
+        $this->assertEquals($expectedPath, $view->getAbsolutePath($relativePath));
+    }
+
+    public function testPartFileInfo(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        Filesystem::mount($storage, [], '/test/');
+        $storage->file_put_contents('test.part', 'foobar');
+        $scanner->scan('');
+        $view = new View('/test');
+        $info = $view->getFileInfo('test.part');
+
+        $this->assertInstanceOf('\OCP\Files\FileInfo', $info);
+        $this->assertNull($info->getId());
+        $this->assertEquals(6, $info->getSize());
+    }
+
+    public static function absolutePathProvider(): array {
+        return [
+            ['/files/', ''],
+            ['/files/0', '0'],
+            ['/files/false', 'false'],
+            ['/files/true', 'true'],
+            ['/files/', '/'],
+            ['/files/test', 'test'],
+            ['/files/test', '/test'],
+        ];
+    }
+
+    /**
+     * @dataProvider chrootRelativePathProvider
+     */
+    public function testChrootGetRelativePath($root, $absolutePath, $expectedPath): void {
+        $view = new View('/files');
+        $view->chroot($root);
+        $this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
+    }
+
+    public static function chrootRelativePathProvider(): array {
+        return self::relativePathProvider('/');
+    }
+
+    /**
+     * @dataProvider initRelativePathProvider
+     */
+    public function testInitGetRelativePath($root, $absolutePath, $expectedPath): void {
+        $view = new View($root);
+        $this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
+    }
+
+    public static function initRelativePathProvider(): array {
+        return self::relativePathProvider(null);
+    }
+
+    public static function relativePathProvider($missingRootExpectedPath): array {
+        return [
+            // No root - returns the path
+            ['', '/files', '/files'],
+            ['', '/files/', '/files/'],
+
+            // Root equals path - /
+            ['/files/', '/files/', '/'],
+            ['/files/', '/files', '/'],
+            ['/files', '/files/', '/'],
+            ['/files', '/files', '/'],
+
+            // False negatives: chroot fixes those by adding the leading slash.
+            // But setting them up with this root (instead of chroot($root))
+            // will fail them, although they should be the same.
+            // TODO init should be fixed, so it also adds the leading slash
+            ['files/', '/files/', $missingRootExpectedPath],
+            ['files', '/files/', $missingRootExpectedPath],
+            ['files/', '/files', $missingRootExpectedPath],
+            ['files', '/files', $missingRootExpectedPath],
+
+            // False negatives: Paths provided to the method should have a leading slash
+            // TODO input should be checked to have a leading slash
+            ['/files/', 'files/', null],
+            ['/files', 'files/', null],
+            ['/files/', 'files', null],
+            ['/files', 'files', null],
+
+            // with trailing slashes
+            ['/files/', '/files/0', '0'],
+            ['/files/', '/files/false', 'false'],
+            ['/files/', '/files/true', 'true'],
+            ['/files/', '/files/test', 'test'],
+            ['/files/', '/files/test/foo', 'test/foo'],
+
+            // without trailing slashes
+            // TODO false expectation: Should match "with trailing slashes"
+            ['/files', '/files/0', '/0'],
+            ['/files', '/files/false', '/false'],
+            ['/files', '/files/true', '/true'],
+            ['/files', '/files/test', '/test'],
+            ['/files', '/files/test/foo', '/test/foo'],
+
+            // leading slashes
+            ['/files/', '/files_trashbin/', null],
+            ['/files', '/files_trashbin/', null],
+            ['/files/', '/files_trashbin', null],
+            ['/files', '/files_trashbin', null],
+
+            // no leading slashes
+            ['files/', 'files_trashbin/', null],
+            ['files', 'files_trashbin/', null],
+            ['files/', 'files_trashbin', null],
+            ['files', 'files_trashbin', null],
+
+            // mixed leading slashes
+            ['files/', '/files_trashbin/', null],
+            ['/files/', 'files_trashbin/', null],
+            ['files', '/files_trashbin/', null],
+            ['/files', 'files_trashbin/', null],
+            ['files/', '/files_trashbin', null],
+            ['/files/', 'files_trashbin', null],
+            ['files', '/files_trashbin', null],
+            ['/files', 'files_trashbin', null],
+
+            ['files', 'files_trashbin/test', null],
+            ['/files', '/files_trashbin/test', null],
+            ['/files', 'files_trashbin/test', null],
+        ];
+    }
+
+    public function testFileView(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+        $view = new View('/test/foo.txt');
+
+        $this->assertEquals('bar', $view->file_get_contents(''));
+        $fh = tmpfile();
+        fwrite($fh, 'foo');
+        rewind($fh);
+        $view->file_put_contents('', $fh);
+        $this->assertEquals('foo', $view->file_get_contents(''));
+    }
+
+    /**
+     * @dataProvider tooLongPathDataProvider
+     */
+    public function testTooLongPath($operation, $param0 = null): void {
+        $this->expectException(\OCP\Files\InvalidPathException::class);
+
+
+        $longPath = '';
+        // 4000 is the maximum path length in file_cache.path
+        $folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
+        $depth = (4000 / 57);
+        foreach (range(0, $depth + 1) as $i) {
+            $longPath .= '/' . $folderName;
+        }
+
+        $storage = new Temporary([]);
+        $this->tempStorage = $storage; // for later hard cleanup
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+
+        if ($param0 === '@0') {
+            $param0 = $longPath;
+        }
+
+        if ($operation === 'hash') {
+            $param0 = $longPath;
+            $longPath = 'md5';
+        }
+
+        call_user_func([$rootView, $operation], $longPath, $param0);
+    }
+
+    public static function tooLongPathDataProvider(): array {
+        return [
+            ['getAbsolutePath'],
+            ['getRelativePath'],
+            ['getMountPoint'],
+            ['resolvePath'],
+            ['getLocalFile'],
+            ['mkdir'],
+            ['rmdir'],
+            ['opendir'],
+            ['is_dir'],
+            ['is_file'],
+            ['stat'],
+            ['filetype'],
+            ['filesize'],
+            ['readfile'],
+            ['isCreatable'],
+            ['isReadable'],
+            ['isUpdatable'],
+            ['isDeletable'],
+            ['isSharable'],
+            ['file_exists'],
+            ['filemtime'],
+            ['touch'],
+            ['file_get_contents'],
+            ['unlink'],
+            ['deleteAll'],
+            ['toTmpFile'],
+            ['getMimeType'],
+            ['free_space'],
+            ['getFileInfo'],
+            ['getDirectoryContent'],
+            ['getOwner'],
+            ['getETag'],
+            ['file_put_contents', 'ipsum'],
+            ['rename', '@0'],
+            ['copy', '@0'],
+            ['fopen', 'r'],
+            ['fromTmpFile', '@0'],
+            ['hash'],
+            ['hasUpdated', 0],
+            ['putFileInfo', []],
+        ];
+    }
+
+    public function testRenameCrossStoragePreserveMtime(): void {
+        $storage1 = new Temporary([]);
+        $storage2 = new Temporary([]);
+        $storage1->mkdir('sub');
+        $storage1->mkdir('foo');
+        $storage1->file_put_contents('foo.txt', 'asd');
+        $storage1->file_put_contents('foo/bar.txt', 'asd');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        $view = new View('');
+        $time = time() - 200;
+        $view->touch('/test/foo.txt', $time);
+        $view->touch('/test/foo', $time);
+        $view->touch('/test/foo/bar.txt', $time);
+
+        $view->rename('/test/foo.txt', '/test/sub/storage/foo.txt');
+
+        $this->assertEquals($time, $view->filemtime('/test/sub/storage/foo.txt'));
+
+        $view->rename('/test/foo', '/test/sub/storage/foo');
+
+        $this->assertEquals($time, $view->filemtime('/test/sub/storage/foo/bar.txt'));
+    }
+
+    public function testRenameFailDeleteTargetKeepSource(): void {
+        $this->doTestCopyRenameFail('rename');
+    }
+
+    public function testCopyFailDeleteTargetKeepSource(): void {
+        $this->doTestCopyRenameFail('copy');
+    }
+
+    private function doTestCopyRenameFail($operation) {
+        $storage1 = new Temporary([]);
+        /** @var \PHPUnit\Framework\MockObject\MockObject|Temporary $storage2 */
+        $storage2 = $this->getMockBuilder(TemporaryNoCross::class)
+            ->setConstructorArgs([[]])
+            ->onlyMethods(['fopen', 'writeStream'])
+            ->getMock();
+
+        $storage2->method('writeStream')
+            ->willThrowException(new GenericFileException('Failed to copy stream'));
+
+        $storage1->mkdir('sub');
+        $storage1->file_put_contents('foo.txt', '0123456789ABCDEFGH');
+        $storage1->mkdir('dirtomove');
+        $storage1->file_put_contents('dirtomove/indir1.txt', '0123456'); // fits
+        $storage1->file_put_contents('dirtomove/indir2.txt', '0123456789ABCDEFGH'); // doesn't fit
+        $storage2->file_put_contents('existing.txt', '0123');
+        $storage1->getScanner()->scan('');
+        $storage2->getScanner()->scan('');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        // move file
+        $view = new View('');
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+        $this->assertFalse($storage2->file_exists('foo.txt'));
+        $this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/foo.txt'));
+        $this->assertFalse($storage2->file_exists('foo.txt'));
+        $this->assertFalse($storage2->getCache()->get('foo.txt'));
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+
+        // if target exists, it will be deleted too
+        $this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/existing.txt'));
+        $this->assertFalse($storage2->file_exists('existing.txt'));
+        $this->assertFalse($storage2->getCache()->get('existing.txt'));
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+
+        // move folder
+        $this->assertFalse($view->$operation('/test/dirtomove/', '/test/sub/storage/dirtomove/'));
+        // since the move failed, the full source tree is kept
+        $this->assertTrue($storage1->file_exists('dirtomove/indir1.txt'));
+        $this->assertTrue($storage1->file_exists('dirtomove/indir2.txt'));
+        // second file not moved/copied
+        $this->assertFalse($storage2->file_exists('dirtomove/indir2.txt'));
+        $this->assertFalse($storage2->getCache()->get('dirtomove/indir2.txt'));
+    }
+
+    public function testDeleteFailKeepCache(): void {
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->setConstructorArgs([[]])
+            ->onlyMethods(['unlink'])
+            ->getMock();
+        $storage->expects($this->once())
+            ->method('unlink')
+            ->willReturn(false);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->file_put_contents('foo.txt', 'asd');
+        $scanner->scan('');
+        Filesystem::mount($storage, [], '/test/');
+
+        $view = new View('/test');
+
+        $this->assertFalse($view->unlink('foo.txt'));
+        $this->assertTrue($cache->inCache('foo.txt'));
+    }
+
+    public static function directoryTraversalProvider(): array {
+        return [
+            ['../test/'],
+            ['..\\test\\my/../folder'],
+            ['/test/my/../foo\\'],
+        ];
+    }
+
+    /**
+     * @dataProvider directoryTraversalProvider
+     * @param string $root
+     */
+    public function testConstructDirectoryTraversalException($root): void {
+        $this->expectException(\Exception::class);
+
+        new View($root);
+    }
+
+    public function testRenameOverWrite(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->mkdir('sub');
+        $storage->mkdir('foo');
+        $storage->file_put_contents('foo.txt', 'asd');
+        $storage->file_put_contents('foo/bar.txt', 'asd');
+        $scanner->scan('');
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('');
+        $this->assertTrue($view->rename('/test/foo.txt', '/test/foo/bar.txt'));
+    }
+
+    public function testSetMountOptionsInStorage(): void {
+        $mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['foo' => 'bar']);
+        Filesystem::getMountManager()->addMount($mount);
+        /** @var \OC\Files\Storage\Common $storage */
+        $storage = $mount->getStorage();
+        $this->assertEquals($storage->getMountOption('foo'), 'bar');
+    }
+
+    public function testSetMountOptionsWatcherPolicy(): void {
+        $mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['filesystem_check_changes' => Watcher::CHECK_NEVER]);
+        Filesystem::getMountManager()->addMount($mount);
+        /** @var \OC\Files\Storage\Common $storage */
+        $storage = $mount->getStorage();
+        $watcher = $storage->getWatcher();
+        $this->assertEquals(Watcher::CHECK_NEVER, $watcher->getPolicy());
+    }
+
+    public function testGetAbsolutePathOnNull(): void {
+        $view = new View();
+        $this->assertNull($view->getAbsolutePath(null));
+    }
+
+    public function testGetRelativePathOnNull(): void {
+        $view = new View();
+        $this->assertNull($view->getRelativePath(null));
+    }
+
+
+    public function testNullAsRoot(): void {
+        $this->expectException(\TypeError::class);
+
+        new View(null);
+    }
+
+    /**
+     * e.g. reading from a folder that's being renamed
+     *
+     *
+     * @dataProvider dataLockPaths
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    public function testReadFromWriteLockedPath($rootPath, $pathPrefix): void {
+        $this->expectException(\OCP\Lock\LockedException::class);
+
+        $rootPath = str_replace('{folder}', 'files', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+        $view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
+    }
+
+    /**
+     * Reading from a files_encryption folder that's being renamed
+     *
+     * @dataProvider dataLockPaths
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    public function testReadFromWriteUnlockablePath($rootPath, $pathPrefix): void {
+        $rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
+    }
+
+    /**
+     * e.g. writing a file that's being downloaded
+     *
+     *
+     * @dataProvider dataLockPaths
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    public function testWriteToReadLockedFile($rootPath, $pathPrefix): void {
+        $this->expectException(\OCP\Lock\LockedException::class);
+
+        $rootPath = str_replace('{folder}', 'files', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
+        $view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
+    }
+
+    /**
+     * Writing a file that's being downloaded
+     *
+     * @dataProvider dataLockPaths
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    public function testWriteToReadUnlockableFile($rootPath, $pathPrefix): void {
+        $rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+    }
+
+    /**
+     * Test that locks are on mount point paths instead of mount root
+     */
+    public function testLockLocalMountPointPathInsteadOfStorageRoot(): void {
+        $lockingProvider = \OC::$server->get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
+
+        $this->assertTrue(
+            $view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, true),
+            'Can lock mount point'
+        );
+
+        // no exception here because storage root was not locked
+        $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $thrown = false;
+        try {
+            $storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Mount point path was locked on root storage');
+
+        $lockingProvider->releaseAll();
+    }
+
+    /**
+     * Test that locks are on mount point paths and also mount root when requested
+     */
+    public function testLockStorageRootButNotLocalMountPoint(): void {
+        $lockingProvider = \OC::$server->get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
+
+        $this->assertTrue(
+            $view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, false),
+            'Can lock mount point'
+        );
+
+        $thrown = false;
+        try {
+            $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Mount point storage root was locked on original storage');
+
+        // local mount point was not locked
+        $storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $lockingProvider->releaseAll();
+    }
+
+    /**
+     * Test that locks are on mount point paths and also mount root when requested
+     */
+    public function testLockMountPointPathFailReleasesBoth(): void {
+        $lockingProvider = \OC::$server->get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint.txt');
+
+        // this would happen if someone is writing on the mount point
+        $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $thrown = false;
+        try {
+            // this actually acquires two locks, one on the mount point and one on the storage root,
+            // but the one on the storage root will fail
+            $view->lockFile('/mountpoint.txt', ILockingProvider::LOCK_SHARED);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Cannot acquire shared lock because storage root is already locked');
+
+        // from here we expect that the lock on the local mount point was released properly
+        // so acquiring an exclusive lock will succeed
+        $storage->acquireLock('/testuser/files/mountpoint.txt', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $lockingProvider->releaseAll();
+    }
+
+    public static function dataLockPaths(): array {
+        return [
+            ['/testuser/{folder}', ''],
+            ['/testuser', '/{folder}'],
+            ['', '/testuser/{folder}'],
+        ];
+    }
+
+    public static function pathRelativeToFilesProvider(): array {
+        return [
+            ['admin/files', ''],
+            ['admin/files/x', 'x'],
+            ['/admin/files', ''],
+            ['/admin/files/sub', 'sub'],
+            ['/admin/files/sub/', 'sub'],
+            ['/admin/files/sub/sub2', 'sub/sub2'],
+            ['//admin//files/sub//sub2', 'sub/sub2'],
+        ];
+    }
+
+    /**
+     * @dataProvider pathRelativeToFilesProvider
+     */
+    public function testGetPathRelativeToFiles($path, $expectedPath): void {
+        $view = new View();
+        $this->assertEquals($expectedPath, $view->getPathRelativeToFiles($path));
+    }
+
+    public static function pathRelativeToFilesProviderExceptionCases(): array {
+        return [
+            [''],
+            ['x'],
+            ['files'],
+            ['/files'],
+            ['/admin/files_versions/abc'],
+        ];
+    }
+
+    /**
+     * @dataProvider pathRelativeToFilesProviderExceptionCases
+     * @param string $path
+     */
+    public function testGetPathRelativeToFilesWithInvalidArgument($path): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('$absolutePath must be relative to "files"');
+
+        $view = new View();
+        $view->getPathRelativeToFiles($path);
+    }
+
+    public function testChangeLock(): void {
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $view->lockFile('/test/sub', ILockingProvider::LOCK_SHARED);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+
+        $view->changeLock('//test/sub', ILockingProvider::LOCK_EXCLUSIVE);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+
+        $view->changeLock('test/sub', ILockingProvider::LOCK_SHARED);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+
+        $view->unlockFile('/test/sub/', ILockingProvider::LOCK_SHARED);
+
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+    }
+
+    public static function hookPathProvider(): array {
+        return [
+            ['/foo/files', '/foo', true],
+            ['/foo/files/bar', '/foo', true],
+            ['/foo', '/foo', false],
+            ['/foo', '/files/foo', true],
+            ['/foo', 'filesfoo', false],
+            ['', '/foo/files', true],
+            ['', '/foo/files/bar.txt', true],
+        ];
+    }
+
+    /**
+     * @dataProvider hookPathProvider
+     * @param $root
+     * @param $path
+     * @param $shouldEmit
+     */
+    public function testHookPaths($root, $path, $shouldEmit): void {
+        $filesystemReflection = new \ReflectionClass(Filesystem::class);
+        $defaultRootValue = $filesystemReflection->getProperty('defaultInstance');
+        $defaultRootValue->setAccessible(true);
+        $oldRoot = $defaultRootValue->getValue();
+        $defaultView = new View('/foo/files');
+        $defaultRootValue->setValue(null, $defaultView);
+        $view = new View($root);
+        $result = self::invokePrivate($view, 'shouldEmitHooks', [$path]);
+        $defaultRootValue->setValue(null, $oldRoot);
+        $this->assertEquals($shouldEmit, $result);
+    }
+
+    /**
+     * Create test movable mount points
+     *
+     * @param array $mountPoints array of mount point locations
+     * @return array array of MountPoint objects
+     */
+    private function createTestMovableMountPoints($mountPoints) {
+        $mounts = [];
+        foreach ($mountPoints as $mountPoint) {
+            $storage = $this->getMockBuilder(Storage::class)
+                ->onlyMethods([])
+                ->getMock();
+            $storage->method('getId')->willReturn('non-null-id');
+            $storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
+                return new \OC\Files\Cache\Storage($storage, true, \OC::$server->get(IDBConnection::class));
+            });
+
+            $mounts[] = $this->getMockBuilder(TestMoveableMountPoint::class)
+                ->onlyMethods(['moveMount'])
+                ->setConstructorArgs([$storage, $mountPoint])
+                ->getMock();
+        }
+
+        /** @var IMountProvider|\PHPUnit\Framework\MockObject\MockObject $mountProvider */
+        $mountProvider = $this->createMock(IMountProvider::class);
+        $mountProvider->expects($this->any())
+            ->method('getMountsForUser')
+            ->willReturn($mounts);
+
+        $mountProviderCollection = \OC::$server->getMountProviderCollection();
+        $mountProviderCollection->registerProvider($mountProvider);
+
+        return $mounts;
+    }
+
+    /**
+     * Test mount point move
+     */
+    public function testMountPointMove(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+        $mount1->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $mount2->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('sub');
+
+        $this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
+        $this->assertTrue($view->rename('mount2', 'sub/moved_mount'), 'Can move a mount point into a subdirectory');
+    }
+
+    public function testMoveMountPointOverwrite(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->never())
+            ->method('moveMount');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $this->expectException(ForbiddenException::class);
+        $view->rename('mount1', 'mount2');
+    }
+
+    public function testMoveMountPointIntoMount(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->never())
+            ->method('moveMount');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $this->expectException(ForbiddenException::class);
+        $view->rename('mount1', 'mount2/sub');
+    }
+
+    /**
+     * Test that moving a mount point into a shared folder is forbidden
+     */
+    public function testMoveMountPointIntoSharedFolder(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('shareddir');
+        $view->mkdir('shareddir/sub');
+        $view->mkdir('shareddir/sub2');
+        // Create a similar named but non-shared folder
+        $view->mkdir('shareddir notshared');
+
+        $fileId = $view->getFileInfo('shareddir')->getId();
+        $userObject = \OC::$server->getUserManager()->createUser('test2', 'IHateNonMockableStaticClasses');
+
+        $userFolder = \OC::$server->getUserFolder($this->user);
+        $shareDir = $userFolder->get('shareddir');
+        $shareManager = \OC::$server->get(IShareManager::class);
+        $share = $shareManager->newShare();
+        $share->setSharedWith('test2')
+            ->setSharedBy($this->user)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(\OCP\Constants::PERMISSION_READ)
+            ->setNode($shareDir);
+        $shareManager->createShare($share);
+
+        try {
+            $view->rename('mount1', 'shareddir');
+            $this->fail('Cannot overwrite shared folder');
+        } catch (ForbiddenException $e) {
+
+        }
+        try {
+            $view->rename('mount1', 'shareddir/sub');
+            $this->fail('Cannot move mount point into shared folder');
+        } catch (ForbiddenException $e) {
+
+        }
+        try {
+            $view->rename('mount1', 'shareddir/sub/sub2');
+            $this->fail('Cannot move mount point into shared subfolder');
+        } catch (ForbiddenException $e) {
+
+        }
+        $this->assertTrue($view->rename('mount2', 'shareddir notshared/sub'), 'Can move mount point into a similarly named but non-shared folder');
+
+        $shareManager->deleteShare($share);
+        $userObject->delete();
+    }
+
+    public static function basicOperationProviderForLocks(): array {
+        return [
+            // --- write hook ----
+            [
+                'touch',
+                ['touch-create.txt'],
+                'touch-create.txt',
+                'create',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'fopen',
+                ['test-write.txt', 'w'],
+                'test-write.txt',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                null,
+                // exclusive lock stays until fclose
+                ILockingProvider::LOCK_EXCLUSIVE,
+            ],
+            [
+                'mkdir',
+                ['newdir'],
+                'newdir',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'file_put_contents',
+                ['file_put_contents.txt', 'blah'],
+                'file_put_contents.txt',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                0,
+            ],
+
+            // ---- delete hook ----
+            [
+                'rmdir',
+                ['dir'],
+                'dir',
+                'delete',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'unlink',
+                ['test.txt'],
+                'test.txt',
+                'delete',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+
+            // ---- read hook (no post hooks) ----
+            [
+                'file_get_contents',
+                ['test.txt'],
+                'test.txt',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                null,
+                false,
+            ],
+            [
+                'fopen',
+                ['test.txt', 'r'],
+                'test.txt',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+            ],
+            [
+                'opendir',
+                ['dir'],
+                'dir',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+            ],
+
+            // ---- no lock, touch hook ---
+            ['touch', ['test.txt'], 'test.txt', 'touch', null, null, null],
+
+            // ---- no hooks, no locks ---
+            ['is_dir', ['dir'], 'dir', null],
+            ['is_file', ['dir'], 'dir', null],
+            [
+                'stat',
+                ['dir'],
+                'dir',
+                null,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+            [
+                'filetype',
+                ['dir'],
+                'dir',
+                null,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+            [
+                'filesize',
+                ['dir'],
+                'dir',
+                null,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                /* Return an int */
+                100
+            ],
+            ['isCreatable', ['dir'], 'dir', null],
+            ['isReadable', ['dir'], 'dir', null],
+            ['isUpdatable', ['dir'], 'dir', null],
+            ['isDeletable', ['dir'], 'dir', null],
+            ['isSharable', ['dir'], 'dir', null],
+            ['file_exists', ['dir'], 'dir', null],
+            [
+                'filemtime',
+                ['dir'],
+                'dir',
+                null,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+        ];
+    }
+
+    /**
+     * Test whether locks are set before and after the operation
+     *
+     * @dataProvider basicOperationProviderForLocks
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $lockedPath path of the locked item to check
+     * @param string $hookType hook type
+     * @param int $expectedLockBefore expected lock during pre hooks
+     * @param int $expectedLockDuring expected lock during operation
+     * @param int $expectedLockAfter expected lock during post hooks
+     * @param int $expectedStrayLock expected lock after returning, should
+     *                               be null (unlock) for most operations
+     */
+    public function testLockBasicOperation(
+        $operation,
+        $operationArgs,
+        $lockedPath,
+        $hookType,
+        $expectedLockBefore = ILockingProvider::LOCK_SHARED,
+        $expectedLockDuring = ILockingProvider::LOCK_SHARED,
+        $expectedLockAfter = ILockingProvider::LOCK_SHARED,
+        $expectedStrayLock = null,
+        $returnValue = true,
+    ): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary&MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        /* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
+        Server::get(ITrashManager::class)->pauseTrash();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        // work directly on disk because mkdir might be mocked
+        $realPath = $storage->getSourcePath('');
+        mkdir($realPath . '/files');
+        mkdir($realPath . '/files/dir');
+        file_put_contents($realPath . '/files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
+                    $lockTypeDuring = $this->getFileLockType($view, $lockedPath);
+
+                    return $returnValue;
+                }
+            );
+
+        $this->assertNull($this->getFileLockType($view, $lockedPath), 'File not locked before operation');
+
+        $this->connectMockHooks($hookType, $view, $lockedPath, $lockTypePre, $lockTypePost);
+
+        // do operation
+        call_user_func_array([$view, $operation], $operationArgs);
+
+        if ($hookType !== null) {
+            $this->assertEquals($expectedLockBefore, $lockTypePre, 'File locked properly during pre-hook');
+            $this->assertEquals($expectedLockAfter, $lockTypePost, 'File locked properly during post-hook');
+            $this->assertEquals($expectedLockDuring, $lockTypeDuring, 'File locked properly during operation');
+        } else {
+            $this->assertNull($lockTypeDuring, 'File not locked during operation');
+        }
+
+        $this->assertEquals($expectedStrayLock, $this->getFileLockType($view, $lockedPath));
+
+        /* Resume trash to avoid side effects */
+        Server::get(ITrashManager::class)->resumeTrash();
+    }
+
+    /**
+     * Test locks for file_put_content with stream.
+     * This code path uses $storage->fopen instead
+     */
+    public function testLockFilePutContentWithStream(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $path = 'test_file_put_contents.txt';
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        $storage->expects($this->once())
+            ->method('fopen')
+            ->willReturnCallback(
+                function () use ($view, $path, &$lockTypeDuring) {
+                    $lockTypeDuring = $this->getFileLockType($view, $path);
+
+                    return fopen('php://temp', 'r+');
+                }
+            );
+
+        $this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
+
+        // do operation
+        $view->file_put_contents($path, fopen('php://temp', 'r+'));
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePost, 'File locked properly during post-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
+
+        $this->assertNull($this->getFileLockType($view, $path));
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     */
+    public function testLockFopen(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $path = 'test_file_put_contents.txt';
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        $storage->expects($this->once())
+            ->method('fopen')
+            ->willReturnCallback(
+                function () use ($view, $path, &$lockTypeDuring) {
+                    $lockTypeDuring = $this->getFileLockType($view, $path);
+
+                    return fopen('php://temp', 'r+');
+                }
+            );
+
+        $this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
+
+        // do operation
+        $res = $view->fopen($path, 'w');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
+        $this->assertNull($lockTypePost, 'No post hook, no lock check possible');
+
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File still locked after fopen');
+
+        fclose($res);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File unlocked after fclose');
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     *
+     * @dataProvider basicOperationProviderForLocks
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $path path of the locked item to check
+     */
+    public function testLockBasicOperationUnlocksAfterException(
+        $operation,
+        $operationArgs,
+        $path,
+    ): void {
+        if ($operation === 'touch') {
+            $this->markTestSkipped('touch handles storage exceptions internally');
+        }
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        /* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
+        Server::get(ITrashManager::class)->pauseTrash();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        // work directly on disk because mkdir might be mocked
+        $realPath = $storage->getSourcePath('');
+        mkdir($realPath . '/files');
+        mkdir($realPath . '/files/dir');
+        file_put_contents($realPath . '/files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function () {
+                    throw new \Exception('Simulated exception');
+                }
+            );
+
+        $thrown = false;
+        try {
+            call_user_func_array([$view, $operation], $operationArgs);
+        } catch (\Exception $e) {
+            $thrown = true;
+            $this->assertEquals('Simulated exception', $e->getMessage());
+        }
+        $this->assertTrue($thrown, 'Exception was rethrown');
+        $this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
+
+        /* Resume trash to avoid side effects */
+        Server::get(ITrashManager::class)->resumeTrash();
+    }
+
+    public function testLockBasicOperationUnlocksAfterLockException(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $storage = new Temporary([]);
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        $storage->mkdir('files');
+        $storage->mkdir('files/dir');
+        $storage->file_put_contents('files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        // get a shared lock
+        $handle = $view->fopen('test.txt', 'r');
+
+        $thrown = false;
+        try {
+            // try (and fail) to get a write lock
+            $view->unlink('test.txt');
+        } catch (\Exception $e) {
+            $thrown = true;
+            $this->assertInstanceOf(LockedException::class, $e);
+        }
+        $this->assertTrue($thrown, 'Exception was rethrown');
+
+        // clean shared lock
+        fclose($handle);
+
+        $this->assertNull($this->getFileLockType($view, 'test.txt'), 'File got unlocked');
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     *
+     * @dataProvider basicOperationProviderForLocks
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $path path of the locked item to check
+     * @param string $hookType hook type
+     */
+    public function testLockBasicOperationUnlocksAfterCancelledHook(
+        $operation,
+        $operationArgs,
+        $path,
+        $hookType,
+    ): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            $hookType,
+            HookHelper::class,
+            'cancellingCallback'
+        );
+
+        call_user_func_array([$view, $operation], $operationArgs);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
+    }
+
+    public static function lockFileRenameOrCopyDataProvider(): array {
+        return [
+            ['rename', ILockingProvider::LOCK_EXCLUSIVE],
+            ['copy', ILockingProvider::LOCK_SHARED],
+        ];
+    }
+
+    /**
+     * Test locks for rename or copy operation
+     *
+     * @dataProvider lockFileRenameOrCopyDataProvider
+     *
+     * @param string $operation operation to be done on the view
+     * @param int $expectedLockTypeSourceDuring expected lock type on source file during
+     *                                          the operation
+     */
+    public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation, 'getMetaData', 'filemtime'])
+            ->getMock();
+
+        $storage->expects($this->any())
+            ->method('getMetaData')
+            ->will($this->returnValue([
+                'mtime' => 1885434487,
+                'etag' => '',
+                'mimetype' => 'text/plain',
+                'permissions' => Constants::PERMISSION_ALL,
+                'size' => 3
+            ]));
+        $storage->expects($this->any())
+            ->method('filemtime')
+            ->willReturn(123456789);
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks($operation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks($operation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        $view->$operation($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
+        $this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+    }
+
+    /**
+     * simulate a failed copy operation.
+     * We expect that we catch the exception, free the lock and re-throw it.
+     *
+     */
+    public function testLockFileCopyException(): void {
+        $this->expectException(\Exception::class);
+
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['copy'])
+            ->getMock();
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+
+        $storage->expects($this->once())
+            ->method('copy')
+            ->willReturnCallback(
+                function () {
+                    throw new \Exception();
+                }
+            );
+
+        $this->connectMockHooks('copy', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks('copy', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        try {
+            $view->copy($sourcePath, $targetPath);
+        } catch (\Exception $e) {
+            $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+            $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+            throw $e;
+        }
+    }
+
+    /**
+     * Test rename operation: unlock first path when second path was locked
+     */
+    public function testLockFileRenameUnlockOnException(): void {
+        self::loginAsUser('test');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+        $view->file_put_contents($sourcePath, 'meh');
+
+        // simulate that the target path is already locked
+        $view->lockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file is locked before operation');
+
+        $thrown = false;
+        try {
+            $view->rename($sourcePath, $targetPath);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown, 'LockedException thrown');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file still locked after operation');
+
+        $view->unlockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
+    }
+
+    /**
+     * Test rename operation: unlock first path when second path was locked
+     */
+    public function testGetOwner(): void {
+        self::loginAsUser('test');
+
+        $view = new View('/test/files/');
+
+        $path = 'foo.txt';
+        $view->file_put_contents($path, 'meh');
+
+        $this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
+
+        $folderInfo = $view->getDirectoryContent('');
+        $folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+            return $info->getName() === 'foo.txt';
+        }));
+
+        $this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
+
+        $subStorage = new Temporary();
+        Filesystem::mount($subStorage, [], '/test/files/asd');
+
+        $folderInfo = $view->getDirectoryContent('');
+        $folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+            return $info->getName() === 'asd';
+        }));
+
+        $this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
+    }
+
+    public static function lockFileRenameOrCopyCrossStorageDataProvider(): array {
+        return [
+            ['rename', 'moveFromStorage', ILockingProvider::LOCK_EXCLUSIVE],
+            ['copy', 'copyFromStorage', ILockingProvider::LOCK_SHARED],
+        ];
+    }
+
+    /**
+     * Test locks for rename or copy operation cross-storage
+     *
+     * @dataProvider lockFileRenameOrCopyCrossStorageDataProvider
+     *
+     * @param string $viewOperation operation to be done on the view
+     * @param string $storageOperation operation to be mocked on the storage
+     * @param int $expectedLockTypeSourceDuring expected lock type on source file during
+     *                                          the operation
+     */
+    public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$storageOperation])
+            ->getMock();
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage2 */
+        $storage2 = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$storageOperation, 'getMetaData', 'filemtime'])
+            ->getMock();
+
+        $storage2->expects($this->any())
+            ->method('getMetaData')
+            ->will($this->returnValue([
+                'mtime' => 1885434487,
+                'etag' => '',
+                'mimetype' => 'text/plain',
+                'permissions' => Constants::PERMISSION_ALL,
+                'size' => 3
+            ]));
+        $storage2->expects($this->any())
+            ->method('filemtime')
+            ->willReturn(123456789);
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'substorage/target.txt';
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        Filesystem::mount($storage2, [], $this->user . '/files/substorage');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+        $storage2->getUpdater()->update('');
+
+        $storage->expects($this->never())
+            ->method($storageOperation);
+        $storage2->expects($this->once())
+            ->method($storageOperation)
+            ->willReturnCallback(
+                function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks($viewOperation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks($viewOperation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        $view->$viewOperation($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
+        $this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+    }
+
+    /**
+     * Test locks when moving a mount point
+     */
+    public function testLockMoveMountPoint(): void {
+        self::loginAsUser('test');
+
+        [$mount] = $this->createTestMovableMountPoints([
+            $this->user . '/files/substorage',
+        ]);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('subdir');
+
+        $sourcePath = 'substorage';
+        $targetPath = 'subdir/substorage_moved';
+
+        $mount->expects($this->once())
+            ->method('moveMount')
+            ->willReturnCallback(
+                function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
+
+                    $lockTypeSharedRootDuring = $this->getFileLockType($view, $sourcePath, false);
+
+                    $mount->setMountPoint($target);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost, true);
+        $this->connectMockHooks('rename', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost, true);
+        // in pre-hook, mount point is still on $sourcePath
+        $this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSharedRootPre, $dummy, false);
+        // in post-hook, mount point is now on $targetPath
+        $this->connectMockHooks('rename', $view, $targetPath, $dummy, $lockTypeSharedRootPost, false);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked before operation');
+
+        $view->rename($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source path locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeSourceDuring, 'Source path locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source path locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target path locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target path locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target path locked properly during post-hook');
+
+        $this->assertNull($lockTypeSharedRootPre, 'Shared storage root not locked during pre-hook');
+        $this->assertNull($lockTypeSharedRootDuring, 'Shared storage root not locked during move');
+        $this->assertNull($lockTypeSharedRootPost, 'Shared storage root not locked during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked after operation');
+    }
+
+    /**
+     * Connect hook callbacks for hook type
+     *
+     * @param string $hookType hook type or null for none
+     * @param View $view view to check the lock on
+     * @param string $path path for which to check the lock
+     * @param int $lockTypePre variable to receive lock type that was active in the pre-hook
+     * @param int $lockTypePost variable to receive lock type that was active in the post-hook
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     */
+    private function connectMockHooks($hookType, $view, $path, &$lockTypePre, &$lockTypePost, $onMountPoint = false) {
+        if ($hookType === null) {
+            return;
+        }
+
+        $eventHandler = $this->getMockBuilder(TestEventHandler::class)
+            ->onlyMethods(['preCallback', 'postCallback'])
+            ->getMock();
+
+        $eventHandler->expects($this->any())
+            ->method('preCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, $onMountPoint, &$lockTypePre) {
+                    $lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
+                }
+            );
+        $eventHandler->expects($this->any())
+            ->method('postCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, $onMountPoint, &$lockTypePost) {
+                    $lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
+                }
+            );
+
+        if ($hookType !== null) {
+            Util::connectHook(
+                Filesystem::CLASSNAME,
+                $hookType,
+                $eventHandler,
+                'preCallback'
+            );
+            Util::connectHook(
+                Filesystem::CLASSNAME,
+                'post_' . $hookType,
+                $eventHandler,
+                'postCallback'
+            );
+        }
+    }
+
+    /**
+     * Returns the file lock type
+     *
+     * @param View $view view
+     * @param string $path path
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     *
+     * @return int lock type or null if file was not locked
+     */
+    private function getFileLockType(View $view, $path, $onMountPoint = false) {
+        if ($this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE, $onMountPoint)) {
+            return ILockingProvider::LOCK_EXCLUSIVE;
+        } elseif ($this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED, $onMountPoint)) {
+            return ILockingProvider::LOCK_SHARED;
+        }
+        return null;
+    }
+
+
+    public function testRemoveMoveableMountPoint(): void {
+        $mountPoint = '/' . $this->user . '/files/mount/';
+
+        // Mock the mount point
+        /** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
+        $mount = $this->createMock(TestMoveableMountPoint::class);
+        $mount->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mount->expects($this->once())
+            ->method('removeMount')
+            ->willReturn('foo');
+        $mount->expects($this->any())
+            ->method('getInternalPath')
+            ->willReturn('');
+
+        // Register mount
+        Filesystem::getMountManager()->addMount($mount);
+
+        // Listen for events
+        $eventHandler = $this->getMockBuilder(TestEventHandler::class)
+            ->onlyMethods(['umount', 'post_umount'])
+            ->getMock();
+        $eventHandler->expects($this->once())
+            ->method('umount')
+            ->with([Filesystem::signal_param_path => '/mount']);
+        $eventHandler->expects($this->once())
+            ->method('post_umount')
+            ->with([Filesystem::signal_param_path => '/mount']);
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            'umount',
+            $eventHandler,
+            'umount'
+        );
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            'post_umount',
+            $eventHandler,
+            'post_umount'
+        );
+
+        //Delete the mountpoint
+        $view = new View('/' . $this->user . '/files');
+        $this->assertEquals('foo', $view->rmdir('mount'));
+    }
+
+    public static function mimeFilterProvider(): array {
+        return [
+            [null, ['test1.txt', 'test2.txt', 'test3.md', 'test4.png']],
+            ['text/plain', ['test1.txt', 'test2.txt']],
+            ['text/markdown', ['test3.md']],
+            ['text', ['test1.txt', 'test2.txt', 'test3.md']],
+        ];
+    }
+
+    /**
+     * @param string $filter
+     * @param string[] $expected
+     * @dataProvider mimeFilterProvider
+     */
+    public function testGetDirectoryContentMimeFilter($filter, $expected): void {
+        $storage1 = new Temporary();
+        $root = self::getUniqueID('/');
+        Filesystem::mount($storage1, [], $root . '/');
+        $view = new View($root);
+
+        $view->file_put_contents('test1.txt', 'asd');
+        $view->file_put_contents('test2.txt', 'asd');
+        $view->file_put_contents('test3.md', 'asd');
+        $view->file_put_contents('test4.png', '');
+
+        $content = $view->getDirectoryContent('', $filter);
+
+        $files = array_map(function (FileInfo $info) {
+            return $info->getName();
+        }, $content);
+        sort($files);
+
+        $this->assertEquals($expected, $files);
+    }
+
+    public function testFilePutContentsClearsChecksum(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $view = new View('/test/foo.txt');
+        $view->putFileInfo('.', ['checksum' => '42']);
+
+        $this->assertEquals('bar', $view->file_get_contents(''));
+        $fh = tmpfile();
+        fwrite($fh, 'fooo');
+        rewind($fh);
+        clearstatcache();
+        $view->file_put_contents('', $fh);
+        $this->assertEquals('fooo', $view->file_get_contents(''));
+        $data = $view->getFileInfo('.');
+        $this->assertEquals('', $data->getChecksum());
+    }
+
+    public function testDeleteGhostFile(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $storage->unlink('foo.txt');
+
+        $this->assertTrue($cache->inCache('foo.txt'));
+
+        $view = new View('/test');
+        $rootInfo = $view->getFileInfo('');
+        $this->assertEquals(3, $rootInfo->getSize());
+        $view->unlink('foo.txt');
+        $newInfo = $view->getFileInfo('');
+
+        $this->assertFalse($cache->inCache('foo.txt'));
+        $this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
+        $this->assertEquals(0, $newInfo->getSize());
+    }
+
+    public function testDeleteGhostFolder(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->mkdir('foo');
+        $storage->file_put_contents('foo/foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $storage->rmdir('foo');
+
+        $this->assertTrue($cache->inCache('foo'));
+        $this->assertTrue($cache->inCache('foo/foo.txt'));
+
+        $view = new View('/test');
+        $rootInfo = $view->getFileInfo('');
+        $this->assertEquals(3, $rootInfo->getSize());
+        $view->rmdir('foo');
+        $newInfo = $view->getFileInfo('');
+
+        $this->assertFalse($cache->inCache('foo'));
+        $this->assertFalse($cache->inCache('foo/foo.txt'));
+        $this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
+        $this->assertEquals(0, $newInfo->getSize());
+    }
+
+    public function testCreateParentDirectories(): void {
+        $view = $this->getMockBuilder(View::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods([
+                'is_file',
+                'file_exists',
+                'mkdir',
+            ])
+            ->getMock();
+
+        $view->expects($this->exactly(3))
+            ->method('is_file')
+            ->willReturnMap([
+                ['/new', false],
+                ['/new/folder', false],
+                ['/new/folder/structure', false],
+            ]);
+        $view->expects($this->exactly(3))
+            ->method('file_exists')
+            ->willReturnMap([
+                ['/new', true],
+                ['/new/folder', false],
+                ['/new/folder/structure', false],
+            ]);
+
+        $calls = ['/new/folder', '/new/folder/structure'];
+        $view->expects($this->exactly(2))
+            ->method('mkdir')
+            ->willReturnCallback(function ($dir) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $dir);
+            });
+
+        $this->assertTrue(self::invokePrivate($view, 'createParentDirectories', ['/new/folder/structure']));
+    }
+
+    public function testCreateParentDirectoriesWithExistingFile(): void {
+        $view = $this->getMockBuilder(View::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods([
+                'is_file',
+                'file_exists',
+                'mkdir',
+            ])
+            ->getMock();
+
+        $view
+            ->expects($this->once())
+            ->method('is_file')
+            ->with('/file.txt')
+            ->willReturn(true);
+        $this->assertFalse(self::invokePrivate($view, 'createParentDirectories', ['/file.txt/folder/structure']));
+    }
+
+    public function testCacheExtension(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        $scanner->scan('');
+
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('/test');
+
+        $info = $view->getFileInfo('/foo.txt');
+        $this->assertEquals(0, $info->getUploadTime());
+        $this->assertEquals(0, $info->getCreationTime());
+
+        $view->putFileInfo('/foo.txt', ['upload_time' => 25]);
+
+        $info = $view->getFileInfo('/foo.txt');
+        $this->assertEquals(25, $info->getUploadTime());
+        $this->assertEquals(0, $info->getCreationTime());
+    }
+
+    public function testFopenGone(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        $scanner->scan('');
+        $cache = $storage->getCache();
+
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('/test');
+
+        $storage->unlink('foo.txt');
+
+        $this->assertTrue($cache->inCache('foo.txt'));
+
+        $this->assertFalse($view->fopen('foo.txt', 'r'));
+
+        $this->assertFalse($cache->inCache('foo.txt'));
+    }
+
+    public function testMountpointParentsCreated(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage2, [], '/A/B/C');
+
+        $rootView = new View('');
+
+        $folderData = $rootView->getDirectoryContent('/');
+        $this->assertCount(4, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+        $this->assertEquals('A', $folderData[3]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A');
+        $this->assertCount(1, $folderData);
+        $this->assertEquals('B', $folderData[0]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A/B');
+        $this->assertCount(1, $folderData);
+        $this->assertEquals('C', $folderData[0]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A/B/C');
+        $this->assertCount(3, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+    }
+
+    public function testCopyPreservesContent() {
+        $viewUser1 = new View('/' . 'userId' . '/files');
+        $viewUser1->mkdir('');
+        $viewUser1->file_put_contents('foo.txt', 'foo');
+        $viewUser1->copy('foo.txt', 'bar.txt');
+        $this->assertEquals('foo', $viewUser1->file_get_contents('bar.txt'));
+    }
 }

Spacing +87 added lines, -87 removed lines

@@ -142,7 +142,7 @@ 
 		}
 
 		if ($this->tempStorage) {
-			system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
+			system('rm -rf '.escapeshellarg($this->tempStorage->getDataDir()));
 		}
 
 		self::logout();
@@ -168,11 +168,11 @@ 
 		$storage2 = $this->getTestStorage();
 		$storage3 = $this->getTestStorage();
 		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		Filesystem::mount($storage2, [], $root . '/substorage');
-		Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
+		Filesystem::mount($storage1, [], $root.'/');
+		Filesystem::mount($storage2, [], $root.'/substorage');
+		Filesystem::mount($storage3, [], $root.'/folder/anotherstorage');
 		$textSize = strlen("dummy file data\n");
-		$imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+		$imageSize = filesize(\OC::$SERVERROOT.'/core/img/logo/logo.png');
 		$storageSize = $textSize * 2 + $imageSize;
 
 		$storageInfo = $storage3->getCache()->get('');
@@ -229,7 +229,7 @@ 
 		$this->assertEquals('foo.png', $folderData[1]['name']);
 		$this->assertEquals('foo.txt', $folderData[2]['name']);
 
-		$folderView = new View($root . '/folder');
+		$folderView = new View($root.'/folder');
 		$this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
 
 		$cachedData = $rootView->getFileInfo('/foo.txt');
@@ -645,11 +645,11 @@ 
 		$storage2 = $this->getTestStorage();
 		$defaultRoot = Filesystem::getRoot();
 		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
+		Filesystem::mount($storage2, [], $defaultRoot.'/substorage');
 		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
 
 		$rootView = new View('');
-		$subView = new View($defaultRoot . '/substorage');
+		$subView = new View($defaultRoot.'/substorage');
 		$this->hookPath = null;
 
 		$rootView->file_put_contents('/foo.txt', 'asd');
@@ -689,7 +689,7 @@ 
 		 */
 		$storage = new $class([]);
 		$textData = "dummy file data\n";
-		$imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+		$imgData = file_get_contents(\OC::$SERVERROOT.'/core/img/logo/logo.png');
 		$storage->mkdir('folder');
 		$storage->file_put_contents('foo.txt', $textData);
 		$storage->file_put_contents('foo.png', $imgData);
@@ -711,10 +711,10 @@ 
 		$storage2 = $this->getTestStorage();
 		$defaultRoot = Filesystem::getRoot();
 		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
+		Filesystem::mount($storage2, [], $defaultRoot.'_substorage');
 		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
 
-		$subView = new View($defaultRoot . '_substorage');
+		$subView = new View($defaultRoot.'_substorage');
 		$this->hookPath = null;
 
 		$subView->file_put_contents('/foo.txt', 'asd');
@@ -809,7 +809,7 @@ 
 
 		$rootView = new View('');
 		foreach ($names as $name) {
-			$rootView->file_put_contents('/' . $name, 'dummy content');
+			$rootView->file_put_contents('/'.$name, 'dummy content');
 		}
 
 		$list = $rootView->getDirectoryContent('/');
@@ -851,15 +851,15 @@ 
 			$depth = ((4000 - $tmpdirLength) / 57);
 		}
 		foreach (range(0, $depth - 1) as $i) {
-			$longPath .= $ds . $folderName;
+			$longPath .= $ds.$folderName;
 			$result = $rootView->mkdir($longPath);
-			$this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
+			$this->assertTrue($result, "mkdir failed on $i - path length: ".strlen($longPath));
 
-			$result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
+			$result = $rootView->file_put_contents($longPath."{$ds}test.txt", 'lorem');
 			$this->assertEquals(5, $result, "file_put_contents failed on $i");
 
 			$this->assertTrue($rootView->file_exists($longPath));
-			$this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
+			$this->assertTrue($rootView->file_exists($longPath."{$ds}test.txt"));
 		}
 
 		$cache = $storage->getCache();
@@ -872,11 +872,11 @@ 
 			$this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
 			$this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
 
-			$cachedFile = $cache->get($longPath . '/test.txt');
+			$cachedFile = $cache->get($longPath.'/test.txt');
 			$this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
 			$this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
 
-			$longPath .= $ds . $folderName;
+			$longPath .= $ds.$folderName;
 		}
 	}
 
@@ -1087,7 +1087,7 @@ 
 		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
 		$depth = (4000 / 57);
 		foreach (range(0, $depth + 1) as $i) {
-			$longPath .= '/' . $folderName;
+			$longPath .= '/'.$folderName;
 		}
 
 		$storage = new Temporary([]);
@@ -1337,8 +1337,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
+		$this->assertTrue($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$view->lockFile($pathPrefix.'/foo/bar/asd', ILockingProvider::LOCK_SHARED);
 	}
 
 	/**
@@ -1356,8 +1356,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar/asd', ILockingProvider::LOCK_SHARED));
 	}
 
 	/**
@@ -1378,8 +1378,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
+		$this->assertTrue($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_SHARED));
+		$view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
 	}
 
 	/**
@@ -1397,8 +1397,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_SHARED));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
 	}
 
 	/**
@@ -1607,7 +1607,7 @@ 
 				->onlyMethods([])
 				->getMock();
 			$storage->method('getId')->willReturn('non-null-id');
-			$storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
+			$storage->method('getStorageCache')->willReturnCallback(function() use ($storage) {
 				return new \OC\Files\Cache\Storage($storage, true, \OC::$server->get(IDBConnection::class));
 			});
 
@@ -1636,8 +1636,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 		$mount1->expects($this->once())
 			->method('moveMount')
@@ -1647,7 +1647,7 @@ 
 			->method('moveMount')
 			->willReturn(true);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('sub');
 
 		$this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
@@ -1658,8 +1658,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1668,7 +1668,7 @@ 
 		$mount2->expects($this->never())
 			->method('moveMount');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$this->expectException(ForbiddenException::class);
 		$view->rename('mount1', 'mount2');
@@ -1678,8 +1678,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1688,7 +1688,7 @@ 
 		$mount2->expects($this->never())
 			->method('moveMount');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$this->expectException(ForbiddenException::class);
 		$view->rename('mount1', 'mount2/sub');
@@ -1701,8 +1701,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1712,7 +1712,7 @@ 
 			->method('moveMount')
 			->willReturn(true);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('shareddir');
 		$view->mkdir('shareddir/sub');
 		$view->mkdir('shareddir/sub2');
@@ -1938,7 +1938,7 @@ 
 		$expectedStrayLock = null,
 		$returnValue = true,
 	): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary&MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -1948,19 +1948,19 @@ 
 		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
 		Server::get(ITrashManager::class)->pauseTrash();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		// work directly on disk because mkdir might be mocked
 		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
+		mkdir($realPath.'/files');
+		mkdir($realPath.'/files/dir');
+		file_put_contents($realPath.'/files/test.txt', 'blah');
 		$storage->getScanner()->scan('files');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
+				function() use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
 					$lockTypeDuring = $this->getFileLockType($view, $lockedPath);
 
 					return $returnValue;
@@ -1993,7 +1993,7 @@ 
 	 * This code path uses $storage->fopen instead
 	 */
 	public function testLockFilePutContentWithStream(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test_file_put_contents.txt';
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
@@ -2001,13 +2001,13 @@ 
 			->onlyMethods(['fopen'])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		$storage->expects($this->once())
 			->method('fopen')
 			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
+				function() use ($view, $path, &$lockTypeDuring) {
 					$lockTypeDuring = $this->getFileLockType($view, $path);
 
 					return fopen('php://temp', 'r+');
@@ -2032,7 +2032,7 @@ 
 	 * Test locks for fopen with fclose at the end
 	 */
 	public function testLockFopen(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test_file_put_contents.txt';
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
@@ -2040,13 +2040,13 @@ 
 			->onlyMethods(['fopen'])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		$storage->expects($this->once())
 			->method('fopen')
 			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
+				function() use ($view, $path, &$lockTypeDuring) {
 					$lockTypeDuring = $this->getFileLockType($view, $path);
 
 					return fopen('php://temp', 'r+');
@@ -2088,7 +2088,7 @@ 
 		if ($operation === 'touch') {
 			$this->markTestSkipped('touch handles storage exceptions internally');
 		}
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2098,19 +2098,19 @@ 
 		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
 		Server::get(ITrashManager::class)->pauseTrash();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		// work directly on disk because mkdir might be mocked
 		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
+		mkdir($realPath.'/files');
+		mkdir($realPath.'/files/dir');
+		file_put_contents($realPath.'/files/test.txt', 'blah');
 		$storage->getScanner()->scan('files');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function () {
+				function() {
 					throw new \Exception('Simulated exception');
 				}
 			);
@@ -2130,11 +2130,11 @@ 
 	}
 
 	public function testLockBasicOperationUnlocksAfterLockException(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$storage = new Temporary([]);
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		$storage->mkdir('files');
 		$storage->mkdir('files/dir');
@@ -2176,14 +2176,14 @@ 
 		$path,
 		$hookType,
 	): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
 			->onlyMethods([$operation])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		Util::connectHook(
@@ -2215,7 +2215,7 @@ 
 	 *                                          the operation
 	 */
 	public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2238,14 +2238,14 @@ 
 		$sourcePath = 'original.txt';
 		$targetPath = 'target.txt';
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+				function() use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
 
@@ -2281,7 +2281,7 @@ 
 	public function testLockFileCopyException(): void {
 		$this->expectException(\Exception::class);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2291,14 +2291,14 @@ 
 		$sourcePath = 'original.txt';
 		$targetPath = 'target.txt';
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 
 		$storage->expects($this->once())
 			->method('copy')
 			->willReturnCallback(
-				function () {
+				function() {
 					throw new \Exception();
 				}
 			);
@@ -2324,7 +2324,7 @@ 
 	public function testLockFileRenameUnlockOnException(): void {
 		self::loginAsUser('test');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$sourcePath = 'original.txt';
 		$targetPath = 'target.txt';
@@ -2365,7 +2365,7 @@ 
 		$this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
 
 		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+		$folderInfo = array_values(array_filter($folderInfo, function(FileInfo $info) {
 			return $info->getName() === 'foo.txt';
 		}));
 
@@ -2375,7 +2375,7 @@ 
 		Filesystem::mount($subStorage, [], '/test/files/asd');
 
 		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+		$folderInfo = array_values(array_filter($folderInfo, function(FileInfo $info) {
 			return $info->getName() === 'asd';
 		}));
 
@@ -2400,7 +2400,7 @@ 
 	 *                                          the operation
 	 */
 	public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2427,8 +2427,8 @@ 
 		$sourcePath = 'original.txt';
 		$targetPath = 'substorage/target.txt';
 
-		Filesystem::mount($storage, [], $this->user . '/');
-		Filesystem::mount($storage2, [], $this->user . '/files/substorage');
+		Filesystem::mount($storage, [], $this->user.'/');
+		Filesystem::mount($storage2, [], $this->user.'/files/substorage');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 		$storage2->getUpdater()->update('');
@@ -2438,7 +2438,7 @@ 
 		$storage2->expects($this->once())
 			->method($storageOperation)
 			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+				function() use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
 
@@ -2473,10 +2473,10 @@ 
 		self::loginAsUser('test');
 
 		[$mount] = $this->createTestMovableMountPoints([
-			$this->user . '/files/substorage',
+			$this->user.'/files/substorage',
 		]);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('subdir');
 
 		$sourcePath = 'substorage';
@@ -2485,7 +2485,7 @@ 
 		$mount->expects($this->once())
 			->method('moveMount')
 			->willReturnCallback(
-				function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
+				function($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
 
@@ -2550,14 +2550,14 @@ 
 		$eventHandler->expects($this->any())
 			->method('preCallback')
 			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePre) {
+				function() use ($view, $path, $onMountPoint, &$lockTypePre) {
 					$lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
 				}
 			);
 		$eventHandler->expects($this->any())
 			->method('postCallback')
 			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePost) {
+				function() use ($view, $path, $onMountPoint, &$lockTypePost) {
 					$lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
 				}
 			);
@@ -2571,7 +2571,7 @@ 
 			);
 			Util::connectHook(
 				Filesystem::CLASSNAME,
-				'post_' . $hookType,
+				'post_'.$hookType,
 				$eventHandler,
 				'postCallback'
 			);
@@ -2599,7 +2599,7 @@ 
 
 
 	public function testRemoveMoveableMountPoint(): void {
-		$mountPoint = '/' . $this->user . '/files/mount/';
+		$mountPoint = '/'.$this->user.'/files/mount/';
 
 		// Mock the mount point
 		/** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
@@ -2641,7 +2641,7 @@ 
 		);
 
 		//Delete the mountpoint
-		$view = new View('/' . $this->user . '/files');
+		$view = new View('/'.$this->user.'/files');
 		$this->assertEquals('foo', $view->rmdir('mount'));
 	}
 
@@ -2662,7 +2662,7 @@ 
 	public function testGetDirectoryContentMimeFilter($filter, $expected): void {
 		$storage1 = new Temporary();
 		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
+		Filesystem::mount($storage1, [], $root.'/');
 		$view = new View($root);
 
 		$view->file_put_contents('test1.txt', 'asd');
@@ -2672,7 +2672,7 @@ 
 
 		$content = $view->getDirectoryContent('', $filter);
 
-		$files = array_map(function (FileInfo $info) {
+		$files = array_map(function(FileInfo $info) {
 			return $info->getName();
 		}, $content);
 		sort($files);
@@ -2778,7 +2778,7 @@ 
 		$calls = ['/new/folder', '/new/folder/structure'];
 		$view->expects($this->exactly(2))
 			->method('mkdir')
-			->willReturnCallback(function ($dir) use (&$calls) {
+			->willReturnCallback(function($dir) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $dir);
 			});
@@ -2875,7 +2875,7 @@ 
 	}
 
 	public function testCopyPreservesContent() {
-		$viewUser1 = new View('/' . 'userId' . '/files');
+		$viewUser1 = new View('/'.'userId'.'/files');
 		$viewUser1->mkdir('');
 		$viewUser1->file_put_contents('foo.txt', 'foo');
 		$viewUser1->copy('foo.txt', 'bar.txt');

tests/lib/Share20/ManagerTest.php

Indentation +4698 added lines, -4698 removed lines

@@ -60,10 +60,10 @@ 
 use Psr\Log\LoggerInterface;
 
 class DummyShareManagerListener {
-	public function post() {
-	}
-	public function listener() {
-	}
+    public function post() {
+    }
+    public function listener() {
+    }
 }
 
 /**
@@ -73,4897 +73,4897 @@ 
  * @group DB
  */
 class ManagerTest extends \Test\TestCase {
-	/** @var Manager */
-	protected $manager;
-	/** @var LoggerInterface|MockObject */
-	protected $logger;
-	/** @var IConfig|MockObject */
-	protected $config;
-	/** @var ISecureRandom|MockObject */
-	protected $secureRandom;
-	/** @var IHasher|MockObject */
-	protected $hasher;
-	/** @var IShareProvider|MockObject */
-	protected $defaultProvider;
-	/** @var IMountManager|MockObject */
-	protected $mountManager;
-	/** @var IGroupManager|MockObject */
-	protected $groupManager;
-	/** @var IL10N|MockObject */
-	protected $l;
-	/** @var IFactory|MockObject */
-	protected $l10nFactory;
-	/** @var DummyFactory */
-	protected $factory;
-	/** @var IUserManager|MockObject */
-	protected $userManager;
-	/** @var IRootFolder | MockObject */
-	protected $rootFolder;
-	/** @var IEventDispatcher|MockObject */
-	protected $dispatcher;
-	/** @var IMailer|MockObject */
-	protected $mailer;
-	/** @var IURLGenerator|MockObject */
-	protected $urlGenerator;
-	/** @var \OC_Defaults|MockObject */
-	protected $defaults;
-	/** @var IUserSession|MockObject */
-	protected $userSession;
-	/** @var KnownUserService|MockObject */
-	protected $knownUserService;
-	/** @var ShareDisableChecker|MockObject */
-	protected $shareDisabledChecker;
-	private DateTimeZone $timezone;
-	/** @var IDateTimeZone|MockObject */
-	protected $dateTimeZone;
-	/** @var IAppConfig|MockObject */
-	protected $appConfig;
-
-	protected function setUp(): void {
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->secureRandom = $this->createMock(ISecureRandom::class);
-		$this->hasher = $this->createMock(IHasher::class);
-		$this->mountManager = $this->createMock(IMountManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->mailer = $this->createMock(IMailer::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->defaults = $this->createMock(\OC_Defaults::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->knownUserService = $this->createMock(KnownUserService::class);
-
-		$this->shareDisabledChecker = new ShareDisableChecker($this->config, $this->userManager, $this->groupManager);
-		$this->dateTimeZone = $this->createMock(IDateTimeZone::class);
-		$this->timezone = new \DateTimeZone('Pacific/Auckland');
-		$this->dateTimeZone->method('getTimeZone')->willReturnCallback(fn () => $this->timezone);
-
-		$this->appConfig = $this->createMock(IAppConfig::class);
-
-		$this->l10nFactory = $this->createMock(IFactory::class);
-		$this->l = $this->createMock(IL10N::class);
-		$this->l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-		$this->l->method('n')
-			->willReturnCallback(function ($singular, $plural, $count, $parameters = []) {
-				return vsprintf(str_replace('%n', $count, ($count === 1) ? $singular : $plural), $parameters);
-			});
-		$this->l10nFactory->method('get')->willReturn($this->l);
-
-		$this->factory = new DummyFactory(\OC::$server);
-
-		$this->manager = $this->createManager($this->factory);
-
-		$this->defaultProvider = $this->createMock(DefaultShareProvider::class);
-		$this->defaultProvider->method('identifier')->willReturn('default');
-		$this->factory->setProvider($this->defaultProvider);
-	}
-
-	private function createManager(IProviderFactory $factory): Manager {
-		return new Manager(
-			$this->logger,
-			$this->config,
-			$this->secureRandom,
-			$this->hasher,
-			$this->mountManager,
-			$this->groupManager,
-			$this->l10nFactory,
-			$factory,
-			$this->userManager,
-			$this->rootFolder,
-			$this->mailer,
-			$this->urlGenerator,
-			$this->defaults,
-			$this->dispatcher,
-			$this->userSession,
-			$this->knownUserService,
-			$this->shareDisabledChecker,
-			$this->dateTimeZone,
-			$this->appConfig,
-		);
-	}
-
-	/**
-	 * @return MockBuilder
-	 */
-	private function createManagerMock() {
-		return $this->getMockBuilder(Manager::class)
-			->setConstructorArgs([
-				$this->logger,
-				$this->config,
-				$this->secureRandom,
-				$this->hasher,
-				$this->mountManager,
-				$this->groupManager,
-				$this->l10nFactory,
-				$this->factory,
-				$this->userManager,
-				$this->rootFolder,
-				$this->mailer,
-				$this->urlGenerator,
-				$this->defaults,
-				$this->dispatcher,
-				$this->userSession,
-				$this->knownUserService,
-				$this->shareDisabledChecker,
-				$this->dateTimeZone,
-				$this->appConfig,
-			]);
-	}
-
-	private function createFolderMock(string $folderPath): MockObject&Folder {
-		$folder = $this->createMock(Folder::class);
-		$folder->method('getPath')->willReturn($folderPath);
-		$folder->method('getRelativePath')->willReturnCallback(
-			fn (string $path): ?string => PathHelper::getRelativePath($folderPath, $path)
-		);
-		return $folder;
-	}
-
-	public function testDeleteNoShareId(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$share = $this->manager->newShare();
-
-		$this->manager->deleteShare($share);
-	}
-
-	public static function dataTestDelete(): array {
-		return [
-			[IShare::TYPE_USER, 'sharedWithUser'],
-			[IShare::TYPE_GROUP, 'sharedWithGroup'],
-			[IShare::TYPE_LINK, ''],
-			[IShare::TYPE_REMOTE, 'foo@bar.com'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataTestDelete
-	 */
-	public function testDelete($shareType, $sharedWith): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['getShareById', 'deleteChildren', 'promoteReshares'])
-			->getMock();
-
-		$manager->method('deleteChildren')->willReturn([]);
-
-		$path = $this->createMock(File::class);
-		$path->method('getId')->willReturn(1);
-
-		$share = $this->manager->newShare();
-		$share->setId(42)
-			->setProviderId('prov')
-			->setShareType($shareType)
-			->setSharedWith($sharedWith)
-			->setSharedBy('sharedBy')
-			->setNode($path)
-			->setTarget('myTarget');
-
-		$manager->expects($this->once())->method('deleteChildren')->with($share);
-		$manager->expects($this->once())->method('promoteReshares')->with($share);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('delete')
-			->with($share);
-
-		$calls = [
-			BeforeShareDeletedEvent::class,
-			ShareDeletedEvent::class,
-		];
-		$this->dispatcher->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $share) {
-				$expected = array_shift($calls);
-				$this->assertInstanceOf($expected, $event);
-				$this->assertEquals($share, $event->getShare());
-			});
-
-		$manager->deleteShare($share);
-	}
-
-	public function testDeleteLazyShare(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['getShareById', 'deleteChildren', 'promoteReshares'])
-			->getMock();
-
-		$manager->method('deleteChildren')->willReturn([]);
-
-		$share = $this->manager->newShare();
-		$share->setId(42)
-			->setProviderId('prov')
-			->setShareType(IShare::TYPE_USER)
-			->setSharedWith('sharedWith')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setTarget('myTarget')
-			->setNodeId(1)
-			->setNodeType('file');
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$manager->expects($this->once())->method('deleteChildren')->with($share);
-		$manager->expects($this->once())->method('promoteReshares')->with($share);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('delete')
-			->with($share);
-
-		$calls = [
-			BeforeShareDeletedEvent::class,
-			ShareDeletedEvent::class,
-		];
-		$this->dispatcher->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $share) {
-				$expected = array_shift($calls);
-				$this->assertInstanceOf($expected, $event);
-				$this->assertEquals($share, $event->getShare());
-			});
-
-		$manager->deleteShare($share);
-	}
-
-	public function testDeleteNested(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['getShareById', 'promoteReshares'])
-			->getMock();
-
-		$path = $this->createMock(File::class);
-		$path->method('getId')->willReturn(1);
-
-		$share1 = $this->manager->newShare();
-		$share1->setId(42)
-			->setProviderId('prov')
-			->setShareType(IShare::TYPE_USER)
-			->setSharedWith('sharedWith1')
-			->setSharedBy('sharedBy1')
-			->setNode($path)
-			->setTarget('myTarget1');
-
-		$share2 = $this->manager->newShare();
-		$share2->setId(43)
-			->setProviderId('prov')
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('sharedWith2')
-			->setSharedBy('sharedBy2')
-			->setNode($path)
-			->setTarget('myTarget2')
-			->setParent(42);
-
-		$share3 = $this->manager->newShare();
-		$share3->setId(44)
-			->setProviderId('prov')
-			->setShareType(IShare::TYPE_LINK)
-			->setSharedBy('sharedBy3')
-			->setNode($path)
-			->setTarget('myTarget3')
-			->setParent(43);
-
-		$this->defaultProvider
-			->method('getChildren')
-			->willReturnMap([
-				[$share1, [$share2]],
-				[$share2, [$share3]],
-				[$share3, []],
-			]);
-
-		$deleteCalls = [
-			$share3,
-			$share2,
-			$share1,
-		];
-		$this->defaultProvider->expects($this->exactly(3))
-			->method('delete')
-			->willReturnCallback(function ($share) use (&$deleteCalls) {
-				$expected = array_shift($deleteCalls);
-				$this->assertEquals($expected, $share);
-			});
-
-		$dispatchCalls = [
-			[BeforeShareDeletedEvent::class, $share1],
-			[BeforeShareDeletedEvent::class, $share2],
-			[BeforeShareDeletedEvent::class, $share3],
-			[ShareDeletedEvent::class, $share3],
-			[ShareDeletedEvent::class, $share2],
-			[ShareDeletedEvent::class, $share1],
-		];
-		$this->dispatcher->expects($this->exactly(6))
-			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$dispatchCalls) {
-				$expected = array_shift($dispatchCalls);
-				$this->assertInstanceOf($expected[0], $event);
-				$this->assertEquals($expected[1]->getId(), $event->getShare()->getId());
-			});
-
-		$manager->deleteShare($share1);
-	}
-
-	public function testDeleteFromSelf(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['getShareById'])
-			->getMock();
-
-		$recipientId = 'unshareFrom';
-		$share = $this->manager->newShare();
-		$share->setId(42)
-			->setProviderId('prov')
-			->setShareType(IShare::TYPE_USER)
-			->setSharedWith('sharedWith')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setTarget('myTarget')
-			->setNodeId(1)
-			->setNodeType('file');
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('deleteFromSelf')
-			->with($share, $recipientId);
-
-		$this->dispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with(
-				$this->callBack(function (ShareDeletedFromSelfEvent $e) use ($share) {
-					return $e->getShare() === $share;
-				})
-			);
-
-		$manager->deleteFromSelf($share, $recipientId);
-	}
-
-	public function testDeleteChildren(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['deleteShare'])
-			->getMock();
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-
-		$child1 = $this->createMock(IShare::class);
-		$child1->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$child2 = $this->createMock(IShare::class);
-		$child2->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$child3 = $this->createMock(IShare::class);
-		$child3->method('getShareType')->willReturn(IShare::TYPE_USER);
-
-		$shares = [
-			$child1,
-			$child2,
-			$child3,
-		];
-
-		$this->defaultProvider
-			->expects($this->exactly(4))
-			->method('getChildren')
-			->willReturnCallback(function ($_share) use ($share, $shares) {
-				if ($_share === $share) {
-					return $shares;
-				}
-				return [];
-			});
-
-		$calls = [
-			$child1,
-			$child2,
-			$child3,
-		];
-		$this->defaultProvider->expects($this->exactly(3))
-			->method('delete')
-			->willReturnCallback(function ($share) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $share);
-			});
-
-		$result = self::invokePrivate($manager, 'deleteChildren', [$share]);
-		$this->assertSame($shares, $result);
-	}
-
-	public function testPromoteReshareFile(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['updateShare', 'getSharesInFolder', 'generalCreateChecks'])
-			->getMock();
-
-		$file = $this->createMock(File::class);
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getNodeType')->willReturn('folder');
-		$share->method('getSharedWith')->willReturn('userB');
-		$share->method('getNode')->willReturn($file);
-
-		$reShare = $this->createMock(IShare::class);
-		$reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShare->method('getSharedBy')->willReturn('userB');
-		$reShare->method('getSharedWith')->willReturn('userC');
-		$reShare->method('getNode')->willReturn($file);
-
-		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $file) {
-				$this->assertEquals($file, $node);
-				if ($shareType === IShare::TYPE_USER) {
-					return match($userId) {
-						'userB' => [$reShare],
-					};
-				} else {
-					return [];
-				}
-			});
-		$manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
-
-		$manager->expects($this->exactly(1))->method('updateShare')->with($reShare);
-
-		self::invokePrivate($manager, 'promoteReshares', [$share]);
-	}
-
-	public function testPromoteReshare(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['updateShare', 'getSharesInFolder', 'generalCreateChecks'])
-			->getMock();
-
-		$folder = $this->createFolderMock('/path/to/folder');
-
-		$subFolder = $this->createFolderMock('/path/to/folder/sub');
-
-		$otherFolder = $this->createFolderMock('/path/to/otherfolder/');
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getNodeType')->willReturn('folder');
-		$share->method('getSharedWith')->willReturn('userB');
-		$share->method('getNode')->willReturn($folder);
-
-		$reShare = $this->createMock(IShare::class);
-		$reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShare->method('getSharedBy')->willReturn('userB');
-		$reShare->method('getSharedWith')->willReturn('userC');
-		$reShare->method('getNode')->willReturn($folder);
-
-		$reShareInSubFolder = $this->createMock(IShare::class);
-		$reShareInSubFolder->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShareInSubFolder->method('getSharedBy')->willReturn('userB');
-		$reShareInSubFolder->method('getNode')->willReturn($subFolder);
-
-		$reShareInOtherFolder = $this->createMock(IShare::class);
-		$reShareInOtherFolder->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShareInOtherFolder->method('getSharedBy')->willReturn('userB');
-		$reShareInOtherFolder->method('getNode')->willReturn($otherFolder);
-
-		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $reShareInSubFolder, $reShareInOtherFolder) {
-				if ($shareType === IShare::TYPE_USER) {
-					return match($userId) {
-						'userB' => [$reShare,$reShareInSubFolder,$reShareInOtherFolder],
-					};
-				} else {
-					return [];
-				}
-			});
-		$manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
-
-		$calls = [
-			$reShare,
-			$reShareInSubFolder,
-		];
-		$manager->expects($this->exactly(2))
-			->method('updateShare')
-			->willReturnCallback(function ($share) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $share);
-			});
-
-		self::invokePrivate($manager, 'promoteReshares', [$share]);
-	}
-
-	public function testPromoteReshareWhenUserHasAnotherShare(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['updateShare', 'getSharesInFolder', 'getSharedWith', 'generalCreateChecks'])
-			->getMock();
-
-		$folder = $this->createFolderMock('/path/to/folder');
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getNodeType')->willReturn('folder');
-		$share->method('getSharedWith')->willReturn('userB');
-		$share->method('getNode')->willReturn($folder);
-
-		$reShare = $this->createMock(IShare::class);
-		$reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShare->method('getNodeType')->willReturn('folder');
-		$reShare->method('getSharedBy')->willReturn('userB');
-		$reShare->method('getNode')->willReturn($folder);
-
-		$this->defaultProvider->method('getSharesBy')->willReturn([$reShare]);
-		$manager->method('generalCreateChecks')->willReturn(true);
-
-		/* No share is promoted because generalCreateChecks does not throw */
-		$manager->expects($this->never())->method('updateShare');
-
-		self::invokePrivate($manager, 'promoteReshares', [$share]);
-	}
-
-	public function testPromoteReshareOfUsersInGroupShare(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['updateShare', 'getSharesInFolder', 'getSharedWith', 'generalCreateChecks'])
-			->getMock();
-
-		$folder = $this->createFolderMock('/path/to/folder');
-
-		$userA = $this->createMock(IUser::class);
-		$userA->method('getUID')->willReturn('userA');
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
-		$share->method('getNodeType')->willReturn('folder');
-		$share->method('getSharedWith')->willReturn('Group');
-		$share->method('getNode')->willReturn($folder);
-		$share->method('getShareOwner')->willReturn($userA);
-
-		$reShare1 = $this->createMock(IShare::class);
-		$reShare1->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShare1->method('getNodeType')->willReturn('folder');
-		$reShare1->method('getSharedBy')->willReturn('userB');
-		$reShare1->method('getNode')->willReturn($folder);
-
-		$reShare2 = $this->createMock(IShare::class);
-		$reShare2->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$reShare2->method('getNodeType')->willReturn('folder');
-		$reShare2->method('getSharedBy')->willReturn('userC');
-		$reShare2->method('getNode')->willReturn($folder);
-
-		$userB = $this->createMock(IUser::class);
-		$userB->method('getUID')->willReturn('userB');
-		$userC = $this->createMock(IUser::class);
-		$userC->method('getUID')->willReturn('userC');
-		$group = $this->createMock(IGroup::class);
-		$group->method('getUsers')->willReturn([$userB, $userC]);
-		$this->groupManager->method('get')->with('Group')->willReturn($group);
-
-		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare1, $reShare2) {
-				if ($shareType === IShare::TYPE_USER) {
-					return match($userId) {
-						'userB' => [$reShare1],
-						'userC' => [$reShare2],
-					};
-				} else {
-					return [];
-				}
-			});
-		$manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
-
-		$manager->method('getSharedWith')->willReturn([]);
-
-		$calls = [
-			$reShare1,
-			$reShare2,
-		];
-		$manager->expects($this->exactly(2))
-			->method('updateShare')
-			->willReturnCallback(function ($share) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $share);
-			});
-
-		self::invokePrivate($manager, 'promoteReshares', [$share]);
-	}
-
-	public function testGetShareById(): void {
-		$share = $this->createMock(IShare::class);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('getShareById')
-			->with(42)
-			->willReturn($share);
-
-		$this->assertEquals($share, $this->manager->getShareById('default:42'));
-	}
-
-
-	public function testGetExpiredShareById(): void {
-		$this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
-
-		$manager = $this->createManagerMock()
-			->onlyMethods(['deleteShare'])
-			->getMock();
-
-		$date = new \DateTime();
-		$date->setTime(0, 0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($date)
-			->setShareType(IShare::TYPE_LINK);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareById')
-			->with('42')
-			->willReturn($share);
-
-		$manager->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$manager->getShareById('default:42');
-	}
-
-
-	public function testVerifyPasswordNullButEnforced(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Passwords are enforced for link and mail shares');
-
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
-			['core', 'shareapi_enforce_links_password', 'no', 'yes'],
-		]);
-
-		self::invokePrivate($this->manager, 'verifyPassword', [null]);
-	}
-
-	public function testVerifyPasswordNotEnforcedGroup(): void {
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', '["admin"]'],
-			['core', 'shareapi_enforce_links_password', 'no', 'yes'],
-		]);
-
-		// Create admin user
-		$user = $this->createMock(IUser::class);
-		$this->userSession->method('getUser')->willReturn($user);
-		$this->groupManager->method('getUserGroupIds')->with($user)->willReturn(['admin']);
-
-		$result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
-		$this->assertNull($result);
-	}
-
-	public function testVerifyPasswordNotEnforcedMultipleGroups(): void {
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', '["admin", "special"]'],
-			['core', 'shareapi_enforce_links_password', 'no', 'yes'],
-		]);
-
-		// Create admin user
-		$user = $this->createMock(IUser::class);
-		$this->userSession->method('getUser')->willReturn($user);
-		$this->groupManager->method('getUserGroupIds')->with($user)->willReturn(['special']);
-
-		$result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
-		$this->assertNull($result);
-	}
-
-	public function testVerifyPasswordNull(): void {
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
-			['core', 'shareapi_enforce_links_password', 'no', 'no'],
-		]);
-
-		$result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
-		$this->assertNull($result);
-	}
-
-	public function testVerifyPasswordHook(): void {
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
-			['core', 'shareapi_enforce_links_password', 'no', 'no'],
-		]);
-
-		$this->dispatcher->expects($this->once())->method('dispatchTyped')
-			->willReturnCallback(function (Event $event) {
-				$this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
-				/** @var ValidatePasswordPolicyEvent $event */
-				$this->assertSame('password', $event->getPassword());
-			}
-			);
-
-		$result = self::invokePrivate($this->manager, 'verifyPassword', ['password']);
-		$this->assertNull($result);
-	}
-
-
-	public function testVerifyPasswordHookFails(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('password not accepted');
-
-		$this->config->method('getAppValue')->willReturnMap([
-			['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
-			['core', 'shareapi_enforce_links_password', 'no', 'no'],
-		]);
-
-		$this->dispatcher->expects($this->once())->method('dispatchTyped')
-			->willReturnCallback(function (Event $event) {
-				$this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
-				/** @var ValidatePasswordPolicyEvent $event */
-				$this->assertSame('password', $event->getPassword());
-				throw new HintException('password not accepted');
-			}
-			);
-
-		self::invokePrivate($this->manager, 'verifyPassword', ['password']);
-	}
-
-	public function createShare($id, $type, $node, $sharedWith, $sharedBy, $shareOwner,
-		$permissions, $expireDate = null, $password = null, $attributes = null) {
-		$share = $this->createMock(IShare::class);
-
-		$share->method('getShareType')->willReturn($type);
-		$share->method('getSharedWith')->willReturn($sharedWith);
-		$share->method('getSharedBy')->willReturn($sharedBy);
-		$share->method('getShareOwner')->willReturn($shareOwner);
-		$share->method('getNode')->willReturn($node);
-		if ($node && $node->getId()) {
-			$share->method('getNodeId')->willReturn($node->getId());
-		}
-		$share->method('getPermissions')->willReturn($permissions);
-		$share->method('getAttributes')->willReturn($attributes);
-		$share->method('getExpirationDate')->willReturn($expireDate);
-		$share->method('getPassword')->willReturn($password);
-
-		return $share;
-	}
-
-	public function dataGeneralChecks() {
-		$user0 = 'user0';
-		$user2 = 'user1';
-		$group0 = 'group0';
-		$owner = $this->createMock(IUser::class);
-		$owner->method('getUID')
-			->willReturn($user0);
-
-		$file = $this->createMock(File::class);
-		$node = $this->createMock(Node::class);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->with('\OCA\Files_Sharing\External\Storage')
-			->willReturn(false);
-		$file->method('getStorage')
-			->willReturn($storage);
-		$file->method('getId')->willReturn(108);
-		$node->method('getStorage')
-			->willReturn($storage);
-		$node->method('getId')->willReturn(108);
-
-		$data = [
-			[$this->createShare(null, IShare::TYPE_USER, $file, null, $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
-			[$this->createShare(null, IShare::TYPE_USER, $file, $group0, $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
-			[$this->createShare(null, IShare::TYPE_USER, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, $file, null, $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, $file, $user2, $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
-			[$this->createShare(null, IShare::TYPE_LINK, $file, $user2, $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
-			[$this->createShare(null, IShare::TYPE_LINK, $file, $group0, $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
-			[$this->createShare(null, IShare::TYPE_LINK, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
-			[$this->createShare(null, -1, $file, null, $user0, $user0, 31, null, null), 'Unknown share type', true],
-
-			[$this->createShare(null, IShare::TYPE_USER, $file, $user2, null, $user0, 31, null, null), 'Share initiator must be set', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, $file, $group0, null, $user0, 31, null, null), 'Share initiator must be set', true],
-			[$this->createShare(null, IShare::TYPE_LINK, $file, null, null, $user0, 31, null, null), 'Share initiator must be set', true],
-
-			[$this->createShare(null, IShare::TYPE_USER, $file, $user0, $user0, $user0, 31, null, null), 'Cannot share with yourself', true],
-
-			[$this->createShare(null, IShare::TYPE_USER, null, $user2, $user0, $user0, 31, null, null), 'Shared path must be set', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, null, $group0, $user0, $user0, 31, null, null), 'Shared path must be set', true],
-			[$this->createShare(null, IShare::TYPE_LINK, null, null, $user0, $user0, 31, null, null), 'Shared path must be set', true],
-
-			[$this->createShare(null, IShare::TYPE_USER, $node, $user2, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
-			[$this->createShare(null, IShare::TYPE_GROUP, $node, $group0, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
-			[$this->createShare(null, IShare::TYPE_LINK, $node, null, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
-		];
-
-		$nonShareAble = $this->createMock(Folder::class);
-		$nonShareAble->method('getId')->willReturn(108);
-		$nonShareAble->method('isShareable')->willReturn(false);
-		$nonShareAble->method('getPath')->willReturn('path');
-		$nonShareAble->method('getName')->willReturn('name');
-		$nonShareAble->method('getOwner')
-			->willReturn($owner);
-		$nonShareAble->method('getStorage')
-			->willReturn($storage);
-
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $nonShareAble, $user2, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $nonShareAble, $group0, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $nonShareAble, null, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
-
-		$limitedPermssions = $this->createMock(File::class);
-		$limitedPermssions->method('isShareable')->willReturn(true);
-		$limitedPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
-		$limitedPermssions->method('getId')->willReturn(108);
-		$limitedPermssions->method('getPath')->willReturn('path');
-		$limitedPermssions->method('getName')->willReturn('name');
-		$limitedPermssions->method('getOwner')
-			->willReturn($owner);
-		$limitedPermssions->method('getStorage')
-			->willReturn($storage);
-
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $limitedPermssions, $user2, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $limitedPermssions, null, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
-
-		$mount = $this->createMock(MoveableMount::class);
-		$limitedPermssions->method('getMountPoint')->willReturn($mount);
-
-		// increase permissions of a re-share
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, 17, null, null), 'Cannot increase permissions of path', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $limitedPermssions, $user2, $user0, $user0, 3, null, null), 'Cannot increase permissions of path', true];
-
-		$nonMovableStorage = $this->createMock(IStorage::class);
-		$nonMovableStorage->method('instanceOfStorage')
-			->with('\OCA\Files_Sharing\External\Storage')
-			->willReturn(false);
-		$nonMovableStorage->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
-		$nonMoveableMountPermssions = $this->createMock(Folder::class);
-		$nonMoveableMountPermssions->method('isShareable')->willReturn(true);
-		$nonMoveableMountPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
-		$nonMoveableMountPermssions->method('getId')->willReturn(108);
-		$nonMoveableMountPermssions->method('getPath')->willReturn('path');
-		$nonMoveableMountPermssions->method('getName')->willReturn('name');
-		$nonMoveableMountPermssions->method('getInternalPath')->willReturn('');
-		$nonMoveableMountPermssions->method('getOwner')
-			->willReturn($owner);
-		$nonMoveableMountPermssions->method('getStorage')
-			->willReturn($nonMovableStorage);
-
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $nonMoveableMountPermssions, $user2, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $nonMoveableMountPermssions, $group0, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
-
-		$rootFolder = $this->createMock(Folder::class);
-		$rootFolder->method('isShareable')->willReturn(true);
-		$rootFolder->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
-		$rootFolder->method('getId')->willReturn(42);
-
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $rootFolder, $user2, $user0, $user0, 30, null, null), 'You cannot share your root folder', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $rootFolder, $group0, $user0, $user0, 2, null, null), 'You cannot share your root folder', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $rootFolder, null, $user0, $user0, 16, null, null), 'You cannot share your root folder', true];
-
-		$allPermssionsFiles = $this->createMock(File::class);
-		$allPermssionsFiles->method('isShareable')->willReturn(true);
-		$allPermssionsFiles->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
-		$allPermssionsFiles->method('getId')->willReturn(187);
-		$allPermssionsFiles->method('getOwner')
-			->willReturn($owner);
-		$allPermssionsFiles->method('getStorage')
-			->willReturn($storage);
-
-		// test invalid CREATE or DELETE permissions
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssionsFiles, $user2, $user0, $user0, \OCP\Constants::PERMISSION_ALL, null, null), 'File shares cannot have create or delete permissions', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssionsFiles, $group0, $user0, $user0, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE, null, null), 'File shares cannot have create or delete permissions', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssionsFiles, null, $user0, $user0, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_DELETE, null, null), 'File shares cannot have create or delete permissions', true];
-
-		$allPermssions = $this->createMock(Folder::class);
-		$allPermssions->method('isShareable')->willReturn(true);
-		$allPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
-		$allPermssions->method('getId')->willReturn(108);
-		$allPermssions->method('getOwner')
-			->willReturn($owner);
-		$allPermssions->method('getStorage')
-			->willReturn($storage);
-
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 30, null, null), 'Shares need at least read permissions', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 2, null, null), 'Shares need at least read permissions', true];
-
-		// test invalid permissions
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 32, null, null), 'Valid permissions are required for sharing', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 63, null, null), 'Valid permissions are required for sharing', true];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssions, null, $user0, $user0, -1, null, null), 'Valid permissions are required for sharing', true];
-
-		// working shares
-		$data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 31, null, null), null, false];
-		$data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 3, null, null), null, false];
-		$data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssions, null, $user0, $user0, 17, null, null), null, false];
-
-
-		$remoteStorage = $this->createMock(IStorage::class);
-		$remoteStorage->method('instanceOfStorage')
-			->with('\OCA\Files_Sharing\External\Storage')
-			->willReturn(true);
-		$remoteFile = $this->createMock(Folder::class);
-		$remoteFile->method('isShareable')->willReturn(true);
-		$remoteFile->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ ^ \OCP\Constants::PERMISSION_UPDATE);
-		$remoteFile->method('getId')->willReturn(108);
-		$remoteFile->method('getOwner')
-			->willReturn($owner);
-		$remoteFile->method('getStorage')
-			->willReturn($storage);
-		$data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 1, null, null), null, false];
-		$data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 3, null, null), null, false];
-		$data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 31, null, null), 'Cannot increase permissions of ', true];
-
-		return $data;
-	}
-
-	/**
-	 * @dataProvider dataGeneralChecks
-	 *
-	 * @param $share
-	 * @param $exceptionMessage
-	 * @param $exception
-	 */
-	public function testGeneralChecks($share, $exceptionMessage, $exception): void {
-		$thrown = null;
-
-		$this->userManager->method('userExists')->willReturnMap([
-			['user0', true],
-			['user1', true],
-		]);
-
-		$this->groupManager->method('groupExists')->willReturnMap([
-			['group0', true],
-		]);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->expects($this->any())
-			->method('getId')
-			->willReturn(42);
-		// Id 108 is used in the data to refer to the node of the share.
-		$userFolder->method('getById')
-			->with(108)
-			->willReturn([$share->getNode()]);
-		$userFolder->expects($this->any())
-			->method('getRelativePath')
-			->willReturnArgument(0);
-		$this->rootFolder->method('getUserFolder')->willReturn($userFolder);
-
-
-		try {
-			self::invokePrivate($this->manager, 'generalCreateChecks', [$share]);
-			$thrown = false;
-		} catch (\OCP\Share\Exceptions\GenericShareException $e) {
-			$this->assertEquals($exceptionMessage, $e->getHint());
-			$thrown = true;
-		} catch (\InvalidArgumentException $e) {
-			$this->assertEquals($exceptionMessage, $e->getMessage());
-			$thrown = true;
-		}
-
-		$this->assertSame($exception, $thrown);
-	}
-
-
-	public function testGeneralCheckShareRoot(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('You cannot share your root folder');
-
-		$thrown = null;
-
-		$this->userManager->method('userExists')->willReturnMap([
-			['user0', true],
-			['user1', true],
-		]);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->method('isSubNode')->with($userFolder)->willReturn(false);
-		$this->rootFolder->method('getUserFolder')->willReturn($userFolder);
-
-		$share = $this->manager->newShare();
-
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedWith('user0')
-			->setSharedBy('user1')
-			->setNode($userFolder);
-
-		self::invokePrivate($this->manager, 'generalCreateChecks', [$share]);
-	}
-
-	public static function validateExpirationDateInternalProvider() {
-		return [[IShare::TYPE_USER], [IShare::TYPE_REMOTE], [IShare::TYPE_REMOTE_GROUP]];
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalInPast($shareType): void {
-		$this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
-		$this->expectExceptionMessage('Expiration date is in the past');
-
-		// Expire date in the past
-		$past = new \DateTime();
-		$past->sub(new \DateInterval('P1D'));
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($past);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceButNotSet($shareType): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Expiration date is enforced');
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')->setId('bar');
-		$share->setShareType($shareType);
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-				]);
-		}
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceButNotEnabledAndNotSet($shareType): void {
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')->setId('bar');
-		$share->setShareType($shareType);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-				]);
-		}
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertNull($share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceButNotSetNewShare($shareType): void {
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'internal_defaultExpDays', '3', '3'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'remote_defaultExpDays', '3', '3'],
-				]);
-		}
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->setTime(0, 0, 0);
-		$expected->add(new \DateInterval('P3D'));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertNotNull($share->getExpirationDate());
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceRelaxedDefaultButNotSetNewShare($shareType): void {
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'internal_defaultExpDays', '3', '1'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'remote_defaultExpDays', '3', '1'],
-				]);
-		}
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->setTime(0, 0, 0);
-		$expected->add(new \DateInterval('P1D'));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertNotNull($share->getExpirationDate());
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceTooFarIntoFuture($shareType): void {
-		$this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
-		$this->expectExceptionMessage('Cannot set expiration date more than 3 days in the future');
-
-		$future = new \DateTime();
-		$future->add(new \DateInterval('P7D'));
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($future);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-				]);
-		}
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalEnforceValid($shareType): void {
-		$future = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-		$future->add(new \DateInterval('P2D'));
-		$future->setTime(1, 2, 3);
-
-		$expected = clone $future;
-		$expected->setTime(0, 0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($future);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-				]);
-		}
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
-			return $data['expirationDate'] == $future;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalNoDefault($shareType): void {
-		$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-		$date->add(new \DateInterval('P5D'));
-		$date->setTime(1, 2, 3);
-
-		$expected = clone $date;
-		$expected->setTime(0, 0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($date);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalNoDateNoDefault($shareType): void {
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
-			return $data['expirationDate'] === null && $data['passwordSet'] === true;
-		}));
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setPassword('password');
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertNull($share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalNoDateDefault($shareType): void {
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->setTime(0, 0);
-		$expected->add(new \DateInterval('P3D'));
-		$expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'internal_defaultExpDays', '3', '3'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'remote_defaultExpDays', '3', '3'],
-				]);
-		}
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalDefault($shareType): void {
-		$future = new \DateTime('now', $this->timezone);
-		$future->add(new \DateInterval('P5D'));
-		$future->setTime(1, 2, 3);
-
-		$expected = clone $future;
-		$expected->setTime(0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($future);
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
-					['core', 'internal_defaultExpDays', '3', '1'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
-					['core', 'remote_defaultExpDays', '3', '1'],
-				]);
-		}
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalHookModification($shareType): void {
-		$nextWeek = new \DateTime('now', $this->timezone);
-		$nextWeek->add(new \DateInterval('P7D'));
-		$nextWeek->setTime(0, 0, 0);
-
-		$save = clone $nextWeek;
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
-			$data['expirationDate']->sub(new \DateInterval('P2D'));
-		});
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($nextWeek);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$save->sub(new \DateInterval('P2D'));
-		$this->assertEquals($save, $share->getExpirationDate());
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalHookException($shareType): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Invalid date!');
-
-		$nextWeek = new \DateTime();
-		$nextWeek->add(new \DateInterval('P7D'));
-		$nextWeek->setTime(0, 0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setExpirationDate($nextWeek);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
-			$data['accepted'] = false;
-			$data['message'] = 'Invalid date!';
-		});
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-	}
-
-	/**
-	 * @dataProvider validateExpirationDateInternalProvider
-	 */
-	public function testValidateExpirationDateInternalExistingShareNoDefault($shareType): void {
-		$share = $this->manager->newShare();
-		$share->setShareType($shareType);
-		$share->setId('42')->setProviderId('foo');
-
-		if ($shareType === IShare::TYPE_USER) {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
-					['core', 'shareapi_internal_expire_after_n_days', '7', '6'],
-				]);
-		} else {
-			$this->config->method('getAppValue')
-				->willReturnMap([
-					['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
-					['core', 'shareapi_remote_expire_after_n_days', '7', '6'],
-				]);
-		}
-
-		self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
-
-		$this->assertEquals(null, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateInPast(): void {
-		$this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
-		$this->expectExceptionMessage('Expiration date is in the past');
-
-		// Expire date in the past
-		$past = new \DateTime();
-		$past->sub(new \DateInterval('P1D'));
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($past);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-	}
-
-	public function testValidateExpirationDateEnforceButNotSet(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Expiration date is enforced');
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')->setId('bar');
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-			]);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-	}
-
-	public function testValidateExpirationDateEnforceButNotEnabledAndNotSet(): void {
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')->setId('bar');
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-			]);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertNull($share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateEnforceButNotSetNewShare(): void {
-		$share = $this->manager->newShare();
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'link_defaultExpDays', '3', '3'],
-			]);
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->setTime(0, 0, 0);
-		$expected->add(new \DateInterval('P3D'));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertNotNull($share->getExpirationDate());
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateEnforceRelaxedDefaultButNotSetNewShare(): void {
-		$share = $this->manager->newShare();
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'link_defaultExpDays', '3', '1'],
-			]);
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->setTime(0, 0, 0);
-		$expected->add(new \DateInterval('P1D'));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertNotNull($share->getExpirationDate());
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateEnforceTooFarIntoFuture(): void {
-		$this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
-		$this->expectExceptionMessage('Cannot set expiration date more than 3 days in the future');
+    /** @var Manager */
+    protected $manager;
+    /** @var LoggerInterface|MockObject */
+    protected $logger;
+    /** @var IConfig|MockObject */
+    protected $config;
+    /** @var ISecureRandom|MockObject */
+    protected $secureRandom;
+    /** @var IHasher|MockObject */
+    protected $hasher;
+    /** @var IShareProvider|MockObject */
+    protected $defaultProvider;
+    /** @var IMountManager|MockObject */
+    protected $mountManager;
+    /** @var IGroupManager|MockObject */
+    protected $groupManager;
+    /** @var IL10N|MockObject */
+    protected $l;
+    /** @var IFactory|MockObject */
+    protected $l10nFactory;
+    /** @var DummyFactory */
+    protected $factory;
+    /** @var IUserManager|MockObject */
+    protected $userManager;
+    /** @var IRootFolder | MockObject */
+    protected $rootFolder;
+    /** @var IEventDispatcher|MockObject */
+    protected $dispatcher;
+    /** @var IMailer|MockObject */
+    protected $mailer;
+    /** @var IURLGenerator|MockObject */
+    protected $urlGenerator;
+    /** @var \OC_Defaults|MockObject */
+    protected $defaults;
+    /** @var IUserSession|MockObject */
+    protected $userSession;
+    /** @var KnownUserService|MockObject */
+    protected $knownUserService;
+    /** @var ShareDisableChecker|MockObject */
+    protected $shareDisabledChecker;
+    private DateTimeZone $timezone;
+    /** @var IDateTimeZone|MockObject */
+    protected $dateTimeZone;
+    /** @var IAppConfig|MockObject */
+    protected $appConfig;
+
+    protected function setUp(): void {
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->secureRandom = $this->createMock(ISecureRandom::class);
+        $this->hasher = $this->createMock(IHasher::class);
+        $this->mountManager = $this->createMock(IMountManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->mailer = $this->createMock(IMailer::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->defaults = $this->createMock(\OC_Defaults::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->knownUserService = $this->createMock(KnownUserService::class);
+
+        $this->shareDisabledChecker = new ShareDisableChecker($this->config, $this->userManager, $this->groupManager);
+        $this->dateTimeZone = $this->createMock(IDateTimeZone::class);
+        $this->timezone = new \DateTimeZone('Pacific/Auckland');
+        $this->dateTimeZone->method('getTimeZone')->willReturnCallback(fn () => $this->timezone);
+
+        $this->appConfig = $this->createMock(IAppConfig::class);
+
+        $this->l10nFactory = $this->createMock(IFactory::class);
+        $this->l = $this->createMock(IL10N::class);
+        $this->l->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+        $this->l->method('n')
+            ->willReturnCallback(function ($singular, $plural, $count, $parameters = []) {
+                return vsprintf(str_replace('%n', $count, ($count === 1) ? $singular : $plural), $parameters);
+            });
+        $this->l10nFactory->method('get')->willReturn($this->l);
+
+        $this->factory = new DummyFactory(\OC::$server);
+
+        $this->manager = $this->createManager($this->factory);
+
+        $this->defaultProvider = $this->createMock(DefaultShareProvider::class);
+        $this->defaultProvider->method('identifier')->willReturn('default');
+        $this->factory->setProvider($this->defaultProvider);
+    }
+
+    private function createManager(IProviderFactory $factory): Manager {
+        return new Manager(
+            $this->logger,
+            $this->config,
+            $this->secureRandom,
+            $this->hasher,
+            $this->mountManager,
+            $this->groupManager,
+            $this->l10nFactory,
+            $factory,
+            $this->userManager,
+            $this->rootFolder,
+            $this->mailer,
+            $this->urlGenerator,
+            $this->defaults,
+            $this->dispatcher,
+            $this->userSession,
+            $this->knownUserService,
+            $this->shareDisabledChecker,
+            $this->dateTimeZone,
+            $this->appConfig,
+        );
+    }
+
+    /**
+     * @return MockBuilder
+     */
+    private function createManagerMock() {
+        return $this->getMockBuilder(Manager::class)
+            ->setConstructorArgs([
+                $this->logger,
+                $this->config,
+                $this->secureRandom,
+                $this->hasher,
+                $this->mountManager,
+                $this->groupManager,
+                $this->l10nFactory,
+                $this->factory,
+                $this->userManager,
+                $this->rootFolder,
+                $this->mailer,
+                $this->urlGenerator,
+                $this->defaults,
+                $this->dispatcher,
+                $this->userSession,
+                $this->knownUserService,
+                $this->shareDisabledChecker,
+                $this->dateTimeZone,
+                $this->appConfig,
+            ]);
+    }
+
+    private function createFolderMock(string $folderPath): MockObject&Folder {
+        $folder = $this->createMock(Folder::class);
+        $folder->method('getPath')->willReturn($folderPath);
+        $folder->method('getRelativePath')->willReturnCallback(
+            fn (string $path): ?string => PathHelper::getRelativePath($folderPath, $path)
+        );
+        return $folder;
+    }
+
+    public function testDeleteNoShareId(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $share = $this->manager->newShare();
+
+        $this->manager->deleteShare($share);
+    }
+
+    public static function dataTestDelete(): array {
+        return [
+            [IShare::TYPE_USER, 'sharedWithUser'],
+            [IShare::TYPE_GROUP, 'sharedWithGroup'],
+            [IShare::TYPE_LINK, ''],
+            [IShare::TYPE_REMOTE, 'foo@bar.com'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataTestDelete
+     */
+    public function testDelete($shareType, $sharedWith): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['getShareById', 'deleteChildren', 'promoteReshares'])
+            ->getMock();
+
+        $manager->method('deleteChildren')->willReturn([]);
+
+        $path = $this->createMock(File::class);
+        $path->method('getId')->willReturn(1);
+
+        $share = $this->manager->newShare();
+        $share->setId(42)
+            ->setProviderId('prov')
+            ->setShareType($shareType)
+            ->setSharedWith($sharedWith)
+            ->setSharedBy('sharedBy')
+            ->setNode($path)
+            ->setTarget('myTarget');
+
+        $manager->expects($this->once())->method('deleteChildren')->with($share);
+        $manager->expects($this->once())->method('promoteReshares')->with($share);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('delete')
+            ->with($share);
+
+        $calls = [
+            BeforeShareDeletedEvent::class,
+            ShareDeletedEvent::class,
+        ];
+        $this->dispatcher->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->willReturnCallback(function ($event) use (&$calls, $share) {
+                $expected = array_shift($calls);
+                $this->assertInstanceOf($expected, $event);
+                $this->assertEquals($share, $event->getShare());
+            });
+
+        $manager->deleteShare($share);
+    }
+
+    public function testDeleteLazyShare(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['getShareById', 'deleteChildren', 'promoteReshares'])
+            ->getMock();
+
+        $manager->method('deleteChildren')->willReturn([]);
+
+        $share = $this->manager->newShare();
+        $share->setId(42)
+            ->setProviderId('prov')
+            ->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('sharedWith')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setTarget('myTarget')
+            ->setNodeId(1)
+            ->setNodeType('file');
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $manager->expects($this->once())->method('deleteChildren')->with($share);
+        $manager->expects($this->once())->method('promoteReshares')->with($share);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('delete')
+            ->with($share);
+
+        $calls = [
+            BeforeShareDeletedEvent::class,
+            ShareDeletedEvent::class,
+        ];
+        $this->dispatcher->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->willReturnCallback(function ($event) use (&$calls, $share) {
+                $expected = array_shift($calls);
+                $this->assertInstanceOf($expected, $event);
+                $this->assertEquals($share, $event->getShare());
+            });
+
+        $manager->deleteShare($share);
+    }
+
+    public function testDeleteNested(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['getShareById', 'promoteReshares'])
+            ->getMock();
+
+        $path = $this->createMock(File::class);
+        $path->method('getId')->willReturn(1);
+
+        $share1 = $this->manager->newShare();
+        $share1->setId(42)
+            ->setProviderId('prov')
+            ->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('sharedWith1')
+            ->setSharedBy('sharedBy1')
+            ->setNode($path)
+            ->setTarget('myTarget1');
+
+        $share2 = $this->manager->newShare();
+        $share2->setId(43)
+            ->setProviderId('prov')
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('sharedWith2')
+            ->setSharedBy('sharedBy2')
+            ->setNode($path)
+            ->setTarget('myTarget2')
+            ->setParent(42);
+
+        $share3 = $this->manager->newShare();
+        $share3->setId(44)
+            ->setProviderId('prov')
+            ->setShareType(IShare::TYPE_LINK)
+            ->setSharedBy('sharedBy3')
+            ->setNode($path)
+            ->setTarget('myTarget3')
+            ->setParent(43);
+
+        $this->defaultProvider
+            ->method('getChildren')
+            ->willReturnMap([
+                [$share1, [$share2]],
+                [$share2, [$share3]],
+                [$share3, []],
+            ]);
+
+        $deleteCalls = [
+            $share3,
+            $share2,
+            $share1,
+        ];
+        $this->defaultProvider->expects($this->exactly(3))
+            ->method('delete')
+            ->willReturnCallback(function ($share) use (&$deleteCalls) {
+                $expected = array_shift($deleteCalls);
+                $this->assertEquals($expected, $share);
+            });
+
+        $dispatchCalls = [
+            [BeforeShareDeletedEvent::class, $share1],
+            [BeforeShareDeletedEvent::class, $share2],
+            [BeforeShareDeletedEvent::class, $share3],
+            [ShareDeletedEvent::class, $share3],
+            [ShareDeletedEvent::class, $share2],
+            [ShareDeletedEvent::class, $share1],
+        ];
+        $this->dispatcher->expects($this->exactly(6))
+            ->method('dispatchTyped')
+            ->willReturnCallback(function ($event) use (&$dispatchCalls) {
+                $expected = array_shift($dispatchCalls);
+                $this->assertInstanceOf($expected[0], $event);
+                $this->assertEquals($expected[1]->getId(), $event->getShare()->getId());
+            });
+
+        $manager->deleteShare($share1);
+    }
+
+    public function testDeleteFromSelf(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['getShareById'])
+            ->getMock();
+
+        $recipientId = 'unshareFrom';
+        $share = $this->manager->newShare();
+        $share->setId(42)
+            ->setProviderId('prov')
+            ->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('sharedWith')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setTarget('myTarget')
+            ->setNodeId(1)
+            ->setNodeType('file');
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('deleteFromSelf')
+            ->with($share, $recipientId);
+
+        $this->dispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with(
+                $this->callBack(function (ShareDeletedFromSelfEvent $e) use ($share) {
+                    return $e->getShare() === $share;
+                })
+            );
+
+        $manager->deleteFromSelf($share, $recipientId);
+    }
+
+    public function testDeleteChildren(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['deleteShare'])
+            ->getMock();
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+
+        $child1 = $this->createMock(IShare::class);
+        $child1->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $child2 = $this->createMock(IShare::class);
+        $child2->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $child3 = $this->createMock(IShare::class);
+        $child3->method('getShareType')->willReturn(IShare::TYPE_USER);
+
+        $shares = [
+            $child1,
+            $child2,
+            $child3,
+        ];
+
+        $this->defaultProvider
+            ->expects($this->exactly(4))
+            ->method('getChildren')
+            ->willReturnCallback(function ($_share) use ($share, $shares) {
+                if ($_share === $share) {
+                    return $shares;
+                }
+                return [];
+            });
+
+        $calls = [
+            $child1,
+            $child2,
+            $child3,
+        ];
+        $this->defaultProvider->expects($this->exactly(3))
+            ->method('delete')
+            ->willReturnCallback(function ($share) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $share);
+            });
+
+        $result = self::invokePrivate($manager, 'deleteChildren', [$share]);
+        $this->assertSame($shares, $result);
+    }
+
+    public function testPromoteReshareFile(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['updateShare', 'getSharesInFolder', 'generalCreateChecks'])
+            ->getMock();
+
+        $file = $this->createMock(File::class);
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getNodeType')->willReturn('folder');
+        $share->method('getSharedWith')->willReturn('userB');
+        $share->method('getNode')->willReturn($file);
+
+        $reShare = $this->createMock(IShare::class);
+        $reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShare->method('getSharedBy')->willReturn('userB');
+        $reShare->method('getSharedWith')->willReturn('userC');
+        $reShare->method('getNode')->willReturn($file);
+
+        $this->defaultProvider->method('getSharesBy')
+            ->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $file) {
+                $this->assertEquals($file, $node);
+                if ($shareType === IShare::TYPE_USER) {
+                    return match($userId) {
+                        'userB' => [$reShare],
+                    };
+                } else {
+                    return [];
+                }
+            });
+        $manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
+
+        $manager->expects($this->exactly(1))->method('updateShare')->with($reShare);
+
+        self::invokePrivate($manager, 'promoteReshares', [$share]);
+    }
+
+    public function testPromoteReshare(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['updateShare', 'getSharesInFolder', 'generalCreateChecks'])
+            ->getMock();
+
+        $folder = $this->createFolderMock('/path/to/folder');
+
+        $subFolder = $this->createFolderMock('/path/to/folder/sub');
+
+        $otherFolder = $this->createFolderMock('/path/to/otherfolder/');
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getNodeType')->willReturn('folder');
+        $share->method('getSharedWith')->willReturn('userB');
+        $share->method('getNode')->willReturn($folder);
+
+        $reShare = $this->createMock(IShare::class);
+        $reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShare->method('getSharedBy')->willReturn('userB');
+        $reShare->method('getSharedWith')->willReturn('userC');
+        $reShare->method('getNode')->willReturn($folder);
+
+        $reShareInSubFolder = $this->createMock(IShare::class);
+        $reShareInSubFolder->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShareInSubFolder->method('getSharedBy')->willReturn('userB');
+        $reShareInSubFolder->method('getNode')->willReturn($subFolder);
+
+        $reShareInOtherFolder = $this->createMock(IShare::class);
+        $reShareInOtherFolder->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShareInOtherFolder->method('getSharedBy')->willReturn('userB');
+        $reShareInOtherFolder->method('getNode')->willReturn($otherFolder);
+
+        $this->defaultProvider->method('getSharesBy')
+            ->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $reShareInSubFolder, $reShareInOtherFolder) {
+                if ($shareType === IShare::TYPE_USER) {
+                    return match($userId) {
+                        'userB' => [$reShare,$reShareInSubFolder,$reShareInOtherFolder],
+                    };
+                } else {
+                    return [];
+                }
+            });
+        $manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
+
+        $calls = [
+            $reShare,
+            $reShareInSubFolder,
+        ];
+        $manager->expects($this->exactly(2))
+            ->method('updateShare')
+            ->willReturnCallback(function ($share) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $share);
+            });
+
+        self::invokePrivate($manager, 'promoteReshares', [$share]);
+    }
+
+    public function testPromoteReshareWhenUserHasAnotherShare(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['updateShare', 'getSharesInFolder', 'getSharedWith', 'generalCreateChecks'])
+            ->getMock();
+
+        $folder = $this->createFolderMock('/path/to/folder');
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getNodeType')->willReturn('folder');
+        $share->method('getSharedWith')->willReturn('userB');
+        $share->method('getNode')->willReturn($folder);
+
+        $reShare = $this->createMock(IShare::class);
+        $reShare->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShare->method('getNodeType')->willReturn('folder');
+        $reShare->method('getSharedBy')->willReturn('userB');
+        $reShare->method('getNode')->willReturn($folder);
+
+        $this->defaultProvider->method('getSharesBy')->willReturn([$reShare]);
+        $manager->method('generalCreateChecks')->willReturn(true);
+
+        /* No share is promoted because generalCreateChecks does not throw */
+        $manager->expects($this->never())->method('updateShare');
+
+        self::invokePrivate($manager, 'promoteReshares', [$share]);
+    }
+
+    public function testPromoteReshareOfUsersInGroupShare(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['updateShare', 'getSharesInFolder', 'getSharedWith', 'generalCreateChecks'])
+            ->getMock();
+
+        $folder = $this->createFolderMock('/path/to/folder');
+
+        $userA = $this->createMock(IUser::class);
+        $userA->method('getUID')->willReturn('userA');
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
+        $share->method('getNodeType')->willReturn('folder');
+        $share->method('getSharedWith')->willReturn('Group');
+        $share->method('getNode')->willReturn($folder);
+        $share->method('getShareOwner')->willReturn($userA);
+
+        $reShare1 = $this->createMock(IShare::class);
+        $reShare1->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShare1->method('getNodeType')->willReturn('folder');
+        $reShare1->method('getSharedBy')->willReturn('userB');
+        $reShare1->method('getNode')->willReturn($folder);
+
+        $reShare2 = $this->createMock(IShare::class);
+        $reShare2->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $reShare2->method('getNodeType')->willReturn('folder');
+        $reShare2->method('getSharedBy')->willReturn('userC');
+        $reShare2->method('getNode')->willReturn($folder);
+
+        $userB = $this->createMock(IUser::class);
+        $userB->method('getUID')->willReturn('userB');
+        $userC = $this->createMock(IUser::class);
+        $userC->method('getUID')->willReturn('userC');
+        $group = $this->createMock(IGroup::class);
+        $group->method('getUsers')->willReturn([$userB, $userC]);
+        $this->groupManager->method('get')->with('Group')->willReturn($group);
+
+        $this->defaultProvider->method('getSharesBy')
+            ->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare1, $reShare2) {
+                if ($shareType === IShare::TYPE_USER) {
+                    return match($userId) {
+                        'userB' => [$reShare1],
+                        'userC' => [$reShare2],
+                    };
+                } else {
+                    return [];
+                }
+            });
+        $manager->method('generalCreateChecks')->willThrowException(new GenericShareException());
+
+        $manager->method('getSharedWith')->willReturn([]);
+
+        $calls = [
+            $reShare1,
+            $reShare2,
+        ];
+        $manager->expects($this->exactly(2))
+            ->method('updateShare')
+            ->willReturnCallback(function ($share) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $share);
+            });
+
+        self::invokePrivate($manager, 'promoteReshares', [$share]);
+    }
+
+    public function testGetShareById(): void {
+        $share = $this->createMock(IShare::class);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with(42)
+            ->willReturn($share);
+
+        $this->assertEquals($share, $this->manager->getShareById('default:42'));
+    }
+
+
+    public function testGetExpiredShareById(): void {
+        $this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['deleteShare'])
+            ->getMock();
+
+        $date = new \DateTime();
+        $date->setTime(0, 0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($date)
+            ->setShareType(IShare::TYPE_LINK);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareById')
+            ->with('42')
+            ->willReturn($share);
+
+        $manager->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $manager->getShareById('default:42');
+    }
+
+
+    public function testVerifyPasswordNullButEnforced(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Passwords are enforced for link and mail shares');
+
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
+            ['core', 'shareapi_enforce_links_password', 'no', 'yes'],
+        ]);
+
+        self::invokePrivate($this->manager, 'verifyPassword', [null]);
+    }
+
+    public function testVerifyPasswordNotEnforcedGroup(): void {
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', '["admin"]'],
+            ['core', 'shareapi_enforce_links_password', 'no', 'yes'],
+        ]);
+
+        // Create admin user
+        $user = $this->createMock(IUser::class);
+        $this->userSession->method('getUser')->willReturn($user);
+        $this->groupManager->method('getUserGroupIds')->with($user)->willReturn(['admin']);
+
+        $result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
+        $this->assertNull($result);
+    }
+
+    public function testVerifyPasswordNotEnforcedMultipleGroups(): void {
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', '["admin", "special"]'],
+            ['core', 'shareapi_enforce_links_password', 'no', 'yes'],
+        ]);
+
+        // Create admin user
+        $user = $this->createMock(IUser::class);
+        $this->userSession->method('getUser')->willReturn($user);
+        $this->groupManager->method('getUserGroupIds')->with($user)->willReturn(['special']);
+
+        $result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
+        $this->assertNull($result);
+    }
+
+    public function testVerifyPasswordNull(): void {
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
+            ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+        ]);
+
+        $result = self::invokePrivate($this->manager, 'verifyPassword', [null]);
+        $this->assertNull($result);
+    }
+
+    public function testVerifyPasswordHook(): void {
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
+            ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+        ]);
+
+        $this->dispatcher->expects($this->once())->method('dispatchTyped')
+            ->willReturnCallback(function (Event $event) {
+                $this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
+                /** @var ValidatePasswordPolicyEvent $event */
+                $this->assertSame('password', $event->getPassword());
+            }
+            );
+
+        $result = self::invokePrivate($this->manager, 'verifyPassword', ['password']);
+        $this->assertNull($result);
+    }
+
+
+    public function testVerifyPasswordHookFails(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('password not accepted');
+
+        $this->config->method('getAppValue')->willReturnMap([
+            ['core', 'shareapi_enforce_links_password_excluded_groups', '', ''],
+            ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+        ]);
+
+        $this->dispatcher->expects($this->once())->method('dispatchTyped')
+            ->willReturnCallback(function (Event $event) {
+                $this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
+                /** @var ValidatePasswordPolicyEvent $event */
+                $this->assertSame('password', $event->getPassword());
+                throw new HintException('password not accepted');
+            }
+            );
+
+        self::invokePrivate($this->manager, 'verifyPassword', ['password']);
+    }
+
+    public function createShare($id, $type, $node, $sharedWith, $sharedBy, $shareOwner,
+        $permissions, $expireDate = null, $password = null, $attributes = null) {
+        $share = $this->createMock(IShare::class);
+
+        $share->method('getShareType')->willReturn($type);
+        $share->method('getSharedWith')->willReturn($sharedWith);
+        $share->method('getSharedBy')->willReturn($sharedBy);
+        $share->method('getShareOwner')->willReturn($shareOwner);
+        $share->method('getNode')->willReturn($node);
+        if ($node && $node->getId()) {
+            $share->method('getNodeId')->willReturn($node->getId());
+        }
+        $share->method('getPermissions')->willReturn($permissions);
+        $share->method('getAttributes')->willReturn($attributes);
+        $share->method('getExpirationDate')->willReturn($expireDate);
+        $share->method('getPassword')->willReturn($password);
+
+        return $share;
+    }
+
+    public function dataGeneralChecks() {
+        $user0 = 'user0';
+        $user2 = 'user1';
+        $group0 = 'group0';
+        $owner = $this->createMock(IUser::class);
+        $owner->method('getUID')
+            ->willReturn($user0);
+
+        $file = $this->createMock(File::class);
+        $node = $this->createMock(Node::class);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->with('\OCA\Files_Sharing\External\Storage')
+            ->willReturn(false);
+        $file->method('getStorage')
+            ->willReturn($storage);
+        $file->method('getId')->willReturn(108);
+        $node->method('getStorage')
+            ->willReturn($storage);
+        $node->method('getId')->willReturn(108);
+
+        $data = [
+            [$this->createShare(null, IShare::TYPE_USER, $file, null, $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
+            [$this->createShare(null, IShare::TYPE_USER, $file, $group0, $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
+            [$this->createShare(null, IShare::TYPE_USER, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient is not a valid user', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, $file, null, $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, $file, $user2, $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient is not a valid group', true],
+            [$this->createShare(null, IShare::TYPE_LINK, $file, $user2, $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
+            [$this->createShare(null, IShare::TYPE_LINK, $file, $group0, $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
+            [$this->createShare(null, IShare::TYPE_LINK, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'Share recipient should be empty', true],
+            [$this->createShare(null, -1, $file, null, $user0, $user0, 31, null, null), 'Unknown share type', true],
+
+            [$this->createShare(null, IShare::TYPE_USER, $file, $user2, null, $user0, 31, null, null), 'Share initiator must be set', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, $file, $group0, null, $user0, 31, null, null), 'Share initiator must be set', true],
+            [$this->createShare(null, IShare::TYPE_LINK, $file, null, null, $user0, 31, null, null), 'Share initiator must be set', true],
+
+            [$this->createShare(null, IShare::TYPE_USER, $file, $user0, $user0, $user0, 31, null, null), 'Cannot share with yourself', true],
+
+            [$this->createShare(null, IShare::TYPE_USER, null, $user2, $user0, $user0, 31, null, null), 'Shared path must be set', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, null, $group0, $user0, $user0, 31, null, null), 'Shared path must be set', true],
+            [$this->createShare(null, IShare::TYPE_LINK, null, null, $user0, $user0, 31, null, null), 'Shared path must be set', true],
+
+            [$this->createShare(null, IShare::TYPE_USER, $node, $user2, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
+            [$this->createShare(null, IShare::TYPE_GROUP, $node, $group0, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
+            [$this->createShare(null, IShare::TYPE_LINK, $node, null, $user0, $user0, 31, null, null), 'Shared path must be either a file or a folder', true],
+        ];
+
+        $nonShareAble = $this->createMock(Folder::class);
+        $nonShareAble->method('getId')->willReturn(108);
+        $nonShareAble->method('isShareable')->willReturn(false);
+        $nonShareAble->method('getPath')->willReturn('path');
+        $nonShareAble->method('getName')->willReturn('name');
+        $nonShareAble->method('getOwner')
+            ->willReturn($owner);
+        $nonShareAble->method('getStorage')
+            ->willReturn($storage);
+
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $nonShareAble, $user2, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $nonShareAble, $group0, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $nonShareAble, null, $user0, $user0, 31, null, null), 'You are not allowed to share name', true];
+
+        $limitedPermssions = $this->createMock(File::class);
+        $limitedPermssions->method('isShareable')->willReturn(true);
+        $limitedPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
+        $limitedPermssions->method('getId')->willReturn(108);
+        $limitedPermssions->method('getPath')->willReturn('path');
+        $limitedPermssions->method('getName')->willReturn('name');
+        $limitedPermssions->method('getOwner')
+            ->willReturn($owner);
+        $limitedPermssions->method('getStorage')
+            ->willReturn($storage);
+
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $limitedPermssions, $user2, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $limitedPermssions, null, $user0, $user0, null, null, null), 'Valid permissions are required for sharing', true];
+
+        $mount = $this->createMock(MoveableMount::class);
+        $limitedPermssions->method('getMountPoint')->willReturn($mount);
+
+        // increase permissions of a re-share
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, 17, null, null), 'Cannot increase permissions of path', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $limitedPermssions, $user2, $user0, $user0, 3, null, null), 'Cannot increase permissions of path', true];
+
+        $nonMovableStorage = $this->createMock(IStorage::class);
+        $nonMovableStorage->method('instanceOfStorage')
+            ->with('\OCA\Files_Sharing\External\Storage')
+            ->willReturn(false);
+        $nonMovableStorage->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
+        $nonMoveableMountPermssions = $this->createMock(Folder::class);
+        $nonMoveableMountPermssions->method('isShareable')->willReturn(true);
+        $nonMoveableMountPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
+        $nonMoveableMountPermssions->method('getId')->willReturn(108);
+        $nonMoveableMountPermssions->method('getPath')->willReturn('path');
+        $nonMoveableMountPermssions->method('getName')->willReturn('name');
+        $nonMoveableMountPermssions->method('getInternalPath')->willReturn('');
+        $nonMoveableMountPermssions->method('getOwner')
+            ->willReturn($owner);
+        $nonMoveableMountPermssions->method('getStorage')
+            ->willReturn($nonMovableStorage);
+
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $nonMoveableMountPermssions, $user2, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $nonMoveableMountPermssions, $group0, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
+
+        $rootFolder = $this->createMock(Folder::class);
+        $rootFolder->method('isShareable')->willReturn(true);
+        $rootFolder->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
+        $rootFolder->method('getId')->willReturn(42);
+
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $rootFolder, $user2, $user0, $user0, 30, null, null), 'You cannot share your root folder', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $rootFolder, $group0, $user0, $user0, 2, null, null), 'You cannot share your root folder', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $rootFolder, null, $user0, $user0, 16, null, null), 'You cannot share your root folder', true];
+
+        $allPermssionsFiles = $this->createMock(File::class);
+        $allPermssionsFiles->method('isShareable')->willReturn(true);
+        $allPermssionsFiles->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
+        $allPermssionsFiles->method('getId')->willReturn(187);
+        $allPermssionsFiles->method('getOwner')
+            ->willReturn($owner);
+        $allPermssionsFiles->method('getStorage')
+            ->willReturn($storage);
+
+        // test invalid CREATE or DELETE permissions
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssionsFiles, $user2, $user0, $user0, \OCP\Constants::PERMISSION_ALL, null, null), 'File shares cannot have create or delete permissions', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssionsFiles, $group0, $user0, $user0, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE, null, null), 'File shares cannot have create or delete permissions', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssionsFiles, null, $user0, $user0, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_DELETE, null, null), 'File shares cannot have create or delete permissions', true];
+
+        $allPermssions = $this->createMock(Folder::class);
+        $allPermssions->method('isShareable')->willReturn(true);
+        $allPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
+        $allPermssions->method('getId')->willReturn(108);
+        $allPermssions->method('getOwner')
+            ->willReturn($owner);
+        $allPermssions->method('getStorage')
+            ->willReturn($storage);
+
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 30, null, null), 'Shares need at least read permissions', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 2, null, null), 'Shares need at least read permissions', true];
+
+        // test invalid permissions
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 32, null, null), 'Valid permissions are required for sharing', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 63, null, null), 'Valid permissions are required for sharing', true];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssions, null, $user0, $user0, -1, null, null), 'Valid permissions are required for sharing', true];
+
+        // working shares
+        $data[] = [$this->createShare(null, IShare::TYPE_USER, $allPermssions, $user2, $user0, $user0, 31, null, null), null, false];
+        $data[] = [$this->createShare(null, IShare::TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 3, null, null), null, false];
+        $data[] = [$this->createShare(null, IShare::TYPE_LINK, $allPermssions, null, $user0, $user0, 17, null, null), null, false];
+
+
+        $remoteStorage = $this->createMock(IStorage::class);
+        $remoteStorage->method('instanceOfStorage')
+            ->with('\OCA\Files_Sharing\External\Storage')
+            ->willReturn(true);
+        $remoteFile = $this->createMock(Folder::class);
+        $remoteFile->method('isShareable')->willReturn(true);
+        $remoteFile->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ ^ \OCP\Constants::PERMISSION_UPDATE);
+        $remoteFile->method('getId')->willReturn(108);
+        $remoteFile->method('getOwner')
+            ->willReturn($owner);
+        $remoteFile->method('getStorage')
+            ->willReturn($storage);
+        $data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 1, null, null), null, false];
+        $data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 3, null, null), null, false];
+        $data[] = [$this->createShare(null, IShare::TYPE_REMOTE, $remoteFile, $user2, $user0, $user0, 31, null, null), 'Cannot increase permissions of ', true];
+
+        return $data;
+    }
+
+    /**
+     * @dataProvider dataGeneralChecks
+     *
+     * @param $share
+     * @param $exceptionMessage
+     * @param $exception
+     */
+    public function testGeneralChecks($share, $exceptionMessage, $exception): void {
+        $thrown = null;
+
+        $this->userManager->method('userExists')->willReturnMap([
+            ['user0', true],
+            ['user1', true],
+        ]);
+
+        $this->groupManager->method('groupExists')->willReturnMap([
+            ['group0', true],
+        ]);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->expects($this->any())
+            ->method('getId')
+            ->willReturn(42);
+        // Id 108 is used in the data to refer to the node of the share.
+        $userFolder->method('getById')
+            ->with(108)
+            ->willReturn([$share->getNode()]);
+        $userFolder->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+        $this->rootFolder->method('getUserFolder')->willReturn($userFolder);
+
+
+        try {
+            self::invokePrivate($this->manager, 'generalCreateChecks', [$share]);
+            $thrown = false;
+        } catch (\OCP\Share\Exceptions\GenericShareException $e) {
+            $this->assertEquals($exceptionMessage, $e->getHint());
+            $thrown = true;
+        } catch (\InvalidArgumentException $e) {
+            $this->assertEquals($exceptionMessage, $e->getMessage());
+            $thrown = true;
+        }
+
+        $this->assertSame($exception, $thrown);
+    }
+
+
+    public function testGeneralCheckShareRoot(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('You cannot share your root folder');
+
+        $thrown = null;
+
+        $this->userManager->method('userExists')->willReturnMap([
+            ['user0', true],
+            ['user1', true],
+        ]);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->method('isSubNode')->with($userFolder)->willReturn(false);
+        $this->rootFolder->method('getUserFolder')->willReturn($userFolder);
+
+        $share = $this->manager->newShare();
+
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('user0')
+            ->setSharedBy('user1')
+            ->setNode($userFolder);
+
+        self::invokePrivate($this->manager, 'generalCreateChecks', [$share]);
+    }
+
+    public static function validateExpirationDateInternalProvider() {
+        return [[IShare::TYPE_USER], [IShare::TYPE_REMOTE], [IShare::TYPE_REMOTE_GROUP]];
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalInPast($shareType): void {
+        $this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
+        $this->expectExceptionMessage('Expiration date is in the past');
+
+        // Expire date in the past
+        $past = new \DateTime();
+        $past->sub(new \DateInterval('P1D'));
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($past);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceButNotSet($shareType): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Expiration date is enforced');
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')->setId('bar');
+        $share->setShareType($shareType);
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                ]);
+        }
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceButNotEnabledAndNotSet($shareType): void {
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')->setId('bar');
+        $share->setShareType($shareType);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                ]);
+        }
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertNull($share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceButNotSetNewShare($shareType): void {
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'internal_defaultExpDays', '3', '3'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'remote_defaultExpDays', '3', '3'],
+                ]);
+        }
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->setTime(0, 0, 0);
+        $expected->add(new \DateInterval('P3D'));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertNotNull($share->getExpirationDate());
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceRelaxedDefaultButNotSetNewShare($shareType): void {
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'internal_defaultExpDays', '3', '1'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'remote_defaultExpDays', '3', '1'],
+                ]);
+        }
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->setTime(0, 0, 0);
+        $expected->add(new \DateInterval('P1D'));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertNotNull($share->getExpirationDate());
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceTooFarIntoFuture($shareType): void {
+        $this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
+        $this->expectExceptionMessage('Cannot set expiration date more than 3 days in the future');
+
+        $future = new \DateTime();
+        $future->add(new \DateInterval('P7D'));
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($future);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                ]);
+        }
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalEnforceValid($shareType): void {
+        $future = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+        $future->add(new \DateInterval('P2D'));
+        $future->setTime(1, 2, 3);
+
+        $expected = clone $future;
+        $expected->setTime(0, 0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($future);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_enforce_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                ]);
+        }
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
+            return $data['expirationDate'] == $future;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalNoDefault($shareType): void {
+        $date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+        $date->add(new \DateInterval('P5D'));
+        $date->setTime(1, 2, 3);
+
+        $expected = clone $date;
+        $expected->setTime(0, 0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($date);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalNoDateNoDefault($shareType): void {
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
+            return $data['expirationDate'] === null && $data['passwordSet'] === true;
+        }));
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setPassword('password');
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertNull($share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalNoDateDefault($shareType): void {
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->setTime(0, 0);
+        $expected->add(new \DateInterval('P3D'));
+        $expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'internal_defaultExpDays', '3', '3'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'remote_defaultExpDays', '3', '3'],
+                ]);
+        }
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalDefault($shareType): void {
+        $future = new \DateTime('now', $this->timezone);
+        $future->add(new \DateInterval('P5D'));
+        $future->setTime(1, 2, 3);
+
+        $expected = clone $future;
+        $expected->setTime(0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($future);
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '3'],
+                    ['core', 'internal_defaultExpDays', '3', '1'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '3'],
+                    ['core', 'remote_defaultExpDays', '3', '1'],
+                ]);
+        }
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalHookModification($shareType): void {
+        $nextWeek = new \DateTime('now', $this->timezone);
+        $nextWeek->add(new \DateInterval('P7D'));
+        $nextWeek->setTime(0, 0, 0);
+
+        $save = clone $nextWeek;
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+            $data['expirationDate']->sub(new \DateInterval('P2D'));
+        });
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($nextWeek);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $save->sub(new \DateInterval('P2D'));
+        $this->assertEquals($save, $share->getExpirationDate());
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalHookException($shareType): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Invalid date!');
+
+        $nextWeek = new \DateTime();
+        $nextWeek->add(new \DateInterval('P7D'));
+        $nextWeek->setTime(0, 0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setExpirationDate($nextWeek);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+            $data['accepted'] = false;
+            $data['message'] = 'Invalid date!';
+        });
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+    }
+
+    /**
+     * @dataProvider validateExpirationDateInternalProvider
+     */
+    public function testValidateExpirationDateInternalExistingShareNoDefault($shareType): void {
+        $share = $this->manager->newShare();
+        $share->setShareType($shareType);
+        $share->setId('42')->setProviderId('foo');
+
+        if ($shareType === IShare::TYPE_USER) {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_internal_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_internal_expire_after_n_days', '7', '6'],
+                ]);
+        } else {
+            $this->config->method('getAppValue')
+                ->willReturnMap([
+                    ['core', 'shareapi_default_remote_expire_date', 'no', 'yes'],
+                    ['core', 'shareapi_remote_expire_after_n_days', '7', '6'],
+                ]);
+        }
+
+        self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
+
+        $this->assertEquals(null, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateInPast(): void {
+        $this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
+        $this->expectExceptionMessage('Expiration date is in the past');
+
+        // Expire date in the past
+        $past = new \DateTime();
+        $past->sub(new \DateInterval('P1D'));
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($past);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+    }
+
+    public function testValidateExpirationDateEnforceButNotSet(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Expiration date is enforced');
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')->setId('bar');
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+            ]);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+    }
+
+    public function testValidateExpirationDateEnforceButNotEnabledAndNotSet(): void {
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')->setId('bar');
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+            ]);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertNull($share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateEnforceButNotSetNewShare(): void {
+        $share = $this->manager->newShare();
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'link_defaultExpDays', '3', '3'],
+            ]);
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->setTime(0, 0, 0);
+        $expected->add(new \DateInterval('P3D'));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertNotNull($share->getExpirationDate());
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateEnforceRelaxedDefaultButNotSetNewShare(): void {
+        $share = $this->manager->newShare();
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'link_defaultExpDays', '3', '1'],
+            ]);
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->setTime(0, 0, 0);
+        $expected->add(new \DateInterval('P1D'));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertNotNull($share->getExpirationDate());
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateEnforceTooFarIntoFuture(): void {
+        $this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
+        $this->expectExceptionMessage('Cannot set expiration date more than 3 days in the future');
 
-		$future = new \DateTime();
-		$future->add(new \DateInterval('P7D'));
+        $future = new \DateTime();
+        $future->add(new \DateInterval('P7D'));
 
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($future);
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($future);
 
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-			]);
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+            ]);
 
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-	}
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+    }
 
-	public function testValidateExpirationDateEnforceValid(): void {
-		$future = new \DateTime('now', $this->timezone);
-		$future->add(new \DateInterval('P2D'));
-		$future->setTime(1, 2, 3);
+    public function testValidateExpirationDateEnforceValid(): void {
+        $future = new \DateTime('now', $this->timezone);
+        $future->add(new \DateInterval('P2D'));
+        $future->setTime(1, 2, 3);
 
-		$expected = clone $future;
-		$expected->setTime(0, 0, 0);
+        $expected = clone $future;
+        $expected->setTime(0, 0, 0);
 
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($future);
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-			]);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
-			return $data['expirationDate'] == $future;
-		}));
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($future);
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+            ]);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
+            return $data['expirationDate'] == $future;
+        }));
 
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateNoDefault(): void {
-		$date = new \DateTime('now', $this->timezone);
-		$date->add(new \DateInterval('P5D'));
-		$date->setTime(1, 2, 3);
-
-		$expected = clone $date;
-		$expected->setTime(0, 0);
-		$expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($date);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateNoDateNoDefault(): void {
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
-			return $data['expirationDate'] === null && $data['passwordSet'] === true;
-		}));
-
-		$share = $this->manager->newShare();
-		$share->setPassword('password');
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertNull($share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateNoDateDefault(): void {
-		$share = $this->manager->newShare();
-
-		$expected = new \DateTime('now', $this->timezone);
-		$expected->add(new \DateInterval('P3D'));
-		$expected->setTime(0, 0);
-		$expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'link_defaultExpDays', '3', '3'],
-			]);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateDefault(): void {
-		$future = new \DateTime('now', $this->timezone);
-		$future->add(new \DateInterval('P5D'));
-		$future->setTime(1, 2, 3);
-
-		$expected = clone $future;
-		$expected->setTime(0, 0);
-		$expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($future);
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateNoDefault(): void {
+        $date = new \DateTime('now', $this->timezone);
+        $date->add(new \DateInterval('P5D'));
+        $date->setTime(1, 2, 3);
+
+        $expected = clone $date;
+        $expected->setTime(0, 0);
+        $expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($date);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateNoDateNoDefault(): void {
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
+            return $data['expirationDate'] === null && $data['passwordSet'] === true;
+        }));
+
+        $share = $this->manager->newShare();
+        $share->setPassword('password');
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertNull($share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateNoDateDefault(): void {
+        $share = $this->manager->newShare();
+
+        $expected = new \DateTime('now', $this->timezone);
+        $expected->add(new \DateInterval('P3D'));
+        $expected->setTime(0, 0);
+        $expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'link_defaultExpDays', '3', '3'],
+            ]);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateDefault(): void {
+        $future = new \DateTime('now', $this->timezone);
+        $future->add(new \DateInterval('P5D'));
+        $future->setTime(1, 2, 3);
+
+        $expected = clone $future;
+        $expected->setTime(0, 0);
+        $expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($future);
 
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'link_defaultExpDays', '3', '1'],
-			]);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected;
-		}));
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'link_defaultExpDays', '3', '1'],
+            ]);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected;
+        }));
 
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
 
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
 
-	public function testValidateExpirationNegativeOffsetTimezone(): void {
-		$this->timezone = new \DateTimeZone('Pacific/Tahiti');
-		$future = new \DateTime();
-		$future->add(new \DateInterval('P5D'));
+    public function testValidateExpirationNegativeOffsetTimezone(): void {
+        $this->timezone = new \DateTimeZone('Pacific/Tahiti');
+        $future = new \DateTime();
+        $future->add(new \DateInterval('P5D'));
 
-		$expected = clone $future;
-		$expected->setTimezone($this->timezone);
-		$expected->setTime(0, 0);
-		$expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+        $expected = clone $future;
+        $expected->setTimezone($this->timezone);
+        $expected->setTime(0, 0);
+        $expected->setTimezone(new \DateTimeZone(date_default_timezone_get()));
 
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($future);
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '3'],
-				['core', 'link_defaultExpDays', '3', '1'],
-			]);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
-			return $data['expirationDate'] == $expected;
-		}));
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals($expected, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateHookModification(): void {
-		$nextWeek = new \DateTime('now', $this->timezone);
-		$nextWeek->add(new \DateInterval('P7D'));
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($future);
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '3'],
+                ['core', 'link_defaultExpDays', '3', '1'],
+            ]);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+            return $data['expirationDate'] == $expected;
+        }));
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals($expected, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateHookModification(): void {
+        $nextWeek = new \DateTime('now', $this->timezone);
+        $nextWeek->add(new \DateInterval('P7D'));
 
-		$save = clone $nextWeek;
-		$save->setTime(0, 0);
-		$save->sub(new \DateInterval('P2D'));
-		$save->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
-			$data['expirationDate']->sub(new \DateInterval('P2D'));
-		});
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($nextWeek);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals($save, $share->getExpirationDate());
-	}
-
-	public function testValidateExpirationDateHookException(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Invalid date!');
-
-		$nextWeek = new \DateTime();
-		$nextWeek->add(new \DateInterval('P7D'));
-		$nextWeek->setTime(0, 0, 0);
-
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($nextWeek);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
-			$data['accepted'] = false;
-			$data['message'] = 'Invalid date!';
-		});
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-	}
-
-	public function testValidateExpirationDateExistingShareNoDefault(): void {
-		$share = $this->manager->newShare();
-
-		$share->setId('42')->setProviderId('foo');
-
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_default_expire_date', 'no', 'yes'],
-				['core', 'shareapi_expire_after_n_days', '7', '6'],
-			]);
-
-		self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
-
-		$this->assertEquals(null, $share->getExpirationDate());
-	}
-
-	public function testUserCreateChecksShareWithGroupMembersOnlyDifferentGroups(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Sharing is only allowed with group members');
+        $save = clone $nextWeek;
+        $save->setTime(0, 0);
+        $save->sub(new \DateInterval('P2D'));
+        $save->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+            $data['expirationDate']->sub(new \DateInterval('P2D'));
+        });
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($nextWeek);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals($save, $share->getExpirationDate());
+    }
+
+    public function testValidateExpirationDateHookException(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Invalid date!');
+
+        $nextWeek = new \DateTime();
+        $nextWeek->add(new \DateInterval('P7D'));
+        $nextWeek->setTime(0, 0, 0);
+
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($nextWeek);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
+        $hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+            $data['accepted'] = false;
+            $data['message'] = 'Invalid date!';
+        });
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+    }
+
+    public function testValidateExpirationDateExistingShareNoDefault(): void {
+        $share = $this->manager->newShare();
+
+        $share->setId('42')->setProviderId('foo');
+
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+                ['core', 'shareapi_expire_after_n_days', '7', '6'],
+            ]);
+
+        self::invokePrivate($this->manager, 'validateExpirationDateLink', [$share]);
+
+        $this->assertEquals(null, $share->getExpirationDate());
+    }
+
+    public function testUserCreateChecksShareWithGroupMembersOnlyDifferentGroups(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Sharing is only allowed with group members');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$sharedBy = $this->createMock(IUser::class);
-		$sharedWith = $this->createMock(IUser::class);
-		$share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
+        $sharedBy = $this->createMock(IUser::class);
+        $sharedWith = $this->createMock(IUser::class);
+        $share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
 
-		$this->groupManager
-			->method('getUserGroupIds')
-			->willReturnMap(
-				[
-					[$sharedBy, ['group1']],
-					[$sharedWith, ['group2']],
-				]
-			);
+        $this->groupManager
+            ->method('getUserGroupIds')
+            ->willReturnMap(
+                [
+                    [$sharedBy, ['group1']],
+                    [$sharedWith, ['group2']],
+                ]
+            );
 
-		$this->userManager->method('get')->willReturnMap([
-			['sharedBy', $sharedBy],
-			['sharedWith', $sharedWith],
-		]);
+        $this->userManager->method('get')->willReturnMap([
+            ['sharedBy', $sharedBy],
+            ['sharedWith', $sharedWith],
+        ]);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
 
-		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
+    }
 
-	public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup(): void {
-		$share = $this->manager->newShare();
+    public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup(): void {
+        $share = $this->manager->newShare();
 
-		$sharedBy = $this->createMock(IUser::class);
-		$sharedWith = $this->createMock(IUser::class);
-		$share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
+        $sharedBy = $this->createMock(IUser::class);
+        $sharedWith = $this->createMock(IUser::class);
+        $share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
 
-		$path = $this->createMock(Node::class);
-		$share->setNode($path);
+        $path = $this->createMock(Node::class);
+        $share->setNode($path);
 
-		$this->groupManager
-			->method('getUserGroupIds')
-			->willReturnMap(
-				[
-					[$sharedBy, ['group1', 'group3']],
-					[$sharedWith, ['group2', 'group3']],
-				]
-			);
+        $this->groupManager
+            ->method('getUserGroupIds')
+            ->willReturnMap(
+                [
+                    [$sharedBy, ['group1', 'group3']],
+                    [$sharedWith, ['group2', 'group3']],
+                ]
+            );
 
-		$this->userManager->method('get')->willReturnMap([
-			['sharedBy', $sharedBy],
-			['sharedWith', $sharedWith],
-		]);
+        $this->userManager->method('get')->willReturnMap([
+            ['sharedBy', $sharedBy],
+            ['sharedWith', $sharedWith],
+        ]);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
 
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($path)
-			->willReturn([]);
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([]);
 
-		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
 
-	public function testUserCreateChecksIdenticalShareExists(): void {
-		$this->expectException(AlreadySharedException::class);
-		$this->expectExceptionMessage('Sharing name.txt failed, because this item is already shared with the account user');
+    public function testUserCreateChecksIdenticalShareExists(): void {
+        $this->expectException(AlreadySharedException::class);
+        $this->expectExceptionMessage('Sharing name.txt failed, because this item is already shared with the account user');
 
-		$share = $this->manager->newShare();
-		$share->setSharedWithDisplayName('user');
-		$share2 = $this->manager->newShare();
+        $share = $this->manager->newShare();
+        $share->setSharedWithDisplayName('user');
+        $share2 = $this->manager->newShare();
 
-		$sharedWith = $this->createMock(IUser::class);
-		$path = $this->createMock(Node::class);
+        $sharedWith = $this->createMock(IUser::class);
+        $path = $this->createMock(Node::class);
 
-		$share->setSharedWith('sharedWith')->setNode($path)
-			->setProviderId('foo')->setId('bar');
+        $share->setSharedWith('sharedWith')->setNode($path)
+            ->setProviderId('foo')->setId('bar');
 
-		$share2->setSharedWith('sharedWith')->setNode($path)
-			->setProviderId('foo')->setId('baz');
+        $share2->setSharedWith('sharedWith')->setNode($path)
+            ->setProviderId('foo')->setId('baz');
 
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		$path->method('getName')
-			->willReturn('name.txt');
+        $path->method('getName')
+            ->willReturn('name.txt');
 
-		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-	}
-
-
-	public function testUserCreateChecksIdenticalPathSharedViaGroup(): void {
-		$this->expectException(AlreadySharedException::class);
-		$this->expectExceptionMessage('Sharing name2.txt failed, because this item is already shared with the account userName');
-
-		$share = $this->manager->newShare();
+        self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
+    }
+
+
+    public function testUserCreateChecksIdenticalPathSharedViaGroup(): void {
+        $this->expectException(AlreadySharedException::class);
+        $this->expectExceptionMessage('Sharing name2.txt failed, because this item is already shared with the account userName');
+
+        $share = $this->manager->newShare();
 
-		$sharedWith = $this->createMock(IUser::class);
-		$sharedWith->method('getUID')->willReturn('sharedWith');
-
-		$this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
+        $sharedWith = $this->createMock(IUser::class);
+        $sharedWith->method('getUID')->willReturn('sharedWith');
+
+        $this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
 
-		$path = $this->createMock(Node::class);
+        $path = $this->createMock(Node::class);
 
-		$share->setSharedWith('sharedWith')
-			->setNode($path)
-			->setShareOwner('shareOwner')
-			->setSharedWithDisplayName('userName')
-			->setProviderId('foo')
-			->setId('bar');
+        $share->setSharedWith('sharedWith')
+            ->setNode($path)
+            ->setShareOwner('shareOwner')
+            ->setSharedWithDisplayName('userName')
+            ->setProviderId('foo')
+            ->setId('bar');
 
-		$share2 = $this->manager->newShare();
-		$share2->setShareType(IShare::TYPE_GROUP)
-			->setShareOwner('shareOwner2')
-			->setProviderId('foo')
-			->setId('baz')
-			->setSharedWith('group');
+        $share2 = $this->manager->newShare();
+        $share2->setShareType(IShare::TYPE_GROUP)
+            ->setShareOwner('shareOwner2')
+            ->setProviderId('foo')
+            ->setId('baz')
+            ->setSharedWith('group');
 
-		$group = $this->createMock(IGroup::class);
-		$group->method('inGroup')
-			->with($sharedWith)
-			->willReturn(true);
+        $group = $this->createMock(IGroup::class);
+        $group->method('inGroup')
+            ->with($sharedWith)
+            ->willReturn(true);
 
-		$this->groupManager->method('get')->with('group')->willReturn($group);
+        $this->groupManager->method('get')->with('group')->willReturn($group);
 
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		$path->method('getName')
-			->willReturn('name2.txt');
+        $path->method('getName')
+            ->willReturn('name2.txt');
 
-		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
+    }
 
-	public function testUserCreateChecksIdenticalPathSharedViaDeletedGroup(): void {
-		$share = $this->manager->newShare();
+    public function testUserCreateChecksIdenticalPathSharedViaDeletedGroup(): void {
+        $share = $this->manager->newShare();
 
-		$sharedWith = $this->createMock(IUser::class);
-		$sharedWith->method('getUID')->willReturn('sharedWith');
+        $sharedWith = $this->createMock(IUser::class);
+        $sharedWith->method('getUID')->willReturn('sharedWith');
 
-		$this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
+        $this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
 
-		$path = $this->createMock(Node::class);
+        $path = $this->createMock(Node::class);
 
-		$share->setSharedWith('sharedWith')
-			->setNode($path)
-			->setShareOwner('shareOwner')
-			->setProviderId('foo')
-			->setId('bar');
+        $share->setSharedWith('sharedWith')
+            ->setNode($path)
+            ->setShareOwner('shareOwner')
+            ->setProviderId('foo')
+            ->setId('bar');
 
-		$share2 = $this->manager->newShare();
-		$share2->setShareType(IShare::TYPE_GROUP)
-			->setShareOwner('shareOwner2')
-			->setProviderId('foo')
-			->setId('baz')
-			->setSharedWith('group');
+        $share2 = $this->manager->newShare();
+        $share2->setShareType(IShare::TYPE_GROUP)
+            ->setShareOwner('shareOwner2')
+            ->setProviderId('foo')
+            ->setId('baz')
+            ->setSharedWith('group');
 
-		$this->groupManager->method('get')->with('group')->willReturn(null);
+        $this->groupManager->method('get')->with('group')->willReturn(null);
 
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		$this->assertNull($this->invokePrivate($this->manager, 'userCreateChecks', [$share]));
-	}
+        $this->assertNull($this->invokePrivate($this->manager, 'userCreateChecks', [$share]));
+    }
 
-	public function testUserCreateChecksIdenticalPathNotSharedWithUser(): void {
-		$share = $this->manager->newShare();
-		$sharedWith = $this->createMock(IUser::class);
-		$path = $this->createMock(Node::class);
-		$share->setSharedWith('sharedWith')
-			->setNode($path)
-			->setShareOwner('shareOwner')
-			->setProviderId('foo')
-			->setId('bar');
+    public function testUserCreateChecksIdenticalPathNotSharedWithUser(): void {
+        $share = $this->manager->newShare();
+        $sharedWith = $this->createMock(IUser::class);
+        $path = $this->createMock(Node::class);
+        $share->setSharedWith('sharedWith')
+            ->setNode($path)
+            ->setShareOwner('shareOwner')
+            ->setProviderId('foo')
+            ->setId('bar');
 
-		$this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
+        $this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
 
-		$share2 = $this->manager->newShare();
-		$share2->setShareType(IShare::TYPE_GROUP)
-			->setShareOwner('shareOwner2')
-			->setProviderId('foo')
-			->setId('baz');
+        $share2 = $this->manager->newShare();
+        $share2->setShareType(IShare::TYPE_GROUP)
+            ->setShareOwner('shareOwner2')
+            ->setProviderId('foo')
+            ->setId('baz');
 
-		$group = $this->createMock(IGroup::class);
-		$group->method('inGroup')
-			->with($sharedWith)
-			->willReturn(false);
+        $group = $this->createMock(IGroup::class);
+        $group->method('inGroup')
+            ->with($sharedWith)
+            ->willReturn(false);
 
-		$this->groupManager->method('get')->with('group')->willReturn($group);
+        $this->groupManager->method('get')->with('group')->willReturn($group);
 
-		$share2->setSharedWith('group');
+        $share2->setSharedWith('group');
 
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
 
-	public function testGroupCreateChecksShareWithGroupMembersGroupSharingNotAllowed(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Group sharing is now allowed');
+    public function testGroupCreateChecksShareWithGroupMembersGroupSharingNotAllowed(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Group sharing is now allowed');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_group_sharing', 'yes', 'no'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'no'],
+            ]);
 
-		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+    }
 
 
-	public function testGroupCreateChecksShareWithGroupMembersOnlyNotInGroup(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Sharing is only allowed within your own groups');
+    public function testGroupCreateChecksShareWithGroupMembersOnlyNotInGroup(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Sharing is only allowed within your own groups');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$user = $this->createMock(IUser::class);
-		$group = $this->createMock(IGroup::class);
-		$share->setSharedBy('user')->setSharedWith('group');
+        $user = $this->createMock(IUser::class);
+        $group = $this->createMock(IGroup::class);
+        $share->setSharedBy('user')->setSharedWith('group');
 
-		$group->method('inGroup')->with($user)->willReturn(false);
+        $group->method('inGroup')->with($user)->willReturn(false);
 
-		$this->groupManager->method('get')->with('group')->willReturn($group);
-		$this->userManager->method('get')->with('user')->willReturn($user);
+        $this->groupManager->method('get')->with('group')->willReturn($group);
+        $this->userManager->method('get')->with('user')->willReturn($user);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
 
-		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+    }
 
 
-	public function testGroupCreateChecksShareWithGroupMembersOnlyNullGroup(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Sharing is only allowed within your own groups');
+    public function testGroupCreateChecksShareWithGroupMembersOnlyNullGroup(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Sharing is only allowed within your own groups');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$user = $this->createMock(IUser::class);
-		$share->setSharedBy('user')->setSharedWith('group');
+        $user = $this->createMock(IUser::class);
+        $share->setSharedBy('user')->setSharedWith('group');
 
-		$this->groupManager->method('get')->with('group')->willReturn(null);
-		$this->userManager->method('get')->with('user')->willReturn($user);
+        $this->groupManager->method('get')->with('group')->willReturn(null);
+        $this->userManager->method('get')->with('user')->willReturn($user);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
 
-		$this->assertNull($this->invokePrivate($this->manager, 'groupCreateChecks', [$share]));
-	}
+        $this->assertNull($this->invokePrivate($this->manager, 'groupCreateChecks', [$share]));
+    }
 
-	public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup(): void {
-		$share = $this->manager->newShare();
+    public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup(): void {
+        $share = $this->manager->newShare();
 
-		$user = $this->createMock(IUser::class);
-		$group = $this->createMock(IGroup::class);
-		$share->setSharedBy('user')->setSharedWith('group');
+        $user = $this->createMock(IUser::class);
+        $group = $this->createMock(IGroup::class);
+        $share->setSharedBy('user')->setSharedWith('group');
 
-		$this->userManager->method('get')->with('user')->willReturn($user);
-		$this->groupManager->method('get')->with('group')->willReturn($group);
+        $this->userManager->method('get')->with('user')->willReturn($user);
+        $this->groupManager->method('get')->with('group')->willReturn($group);
 
-		$group->method('inGroup')->with($user)->willReturn(true);
+        $group->method('inGroup')->with($user)->willReturn(true);
 
-		$path = $this->createMock(Node::class);
-		$share->setNode($path);
+        $path = $this->createMock(Node::class);
+        $share->setNode($path);
 
-		$this->defaultProvider->method('getSharesByPath')
-			->with($path)
-			->willReturn([]);
+        $this->defaultProvider->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([]);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
 
-		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
 
-	public function testGroupCreateChecksPathAlreadySharedWithSameGroup(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Path is already shared with this group');
+    public function testGroupCreateChecksPathAlreadySharedWithSameGroup(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Path is already shared with this group');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$path = $this->createMock(Node::class);
-		$share->setSharedWith('sharedWith')
-			->setNode($path)
-			->setProviderId('foo')
-			->setId('bar');
+        $path = $this->createMock(Node::class);
+        $share->setSharedWith('sharedWith')
+            ->setNode($path)
+            ->setProviderId('foo')
+            ->setId('bar');
 
-		$share2 = $this->manager->newShare();
-		$share2->setSharedWith('sharedWith')
-			->setProviderId('foo')
-			->setId('baz');
+        $share2 = $this->manager->newShare();
+        $share2->setSharedWith('sharedWith')
+            ->setProviderId('foo')
+            ->setId('baz');
 
-		$this->defaultProvider->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
+            ]);
 
-		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+    }
 
-	public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup(): void {
-		$share = $this->manager->newShare();
+    public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup(): void {
+        $share = $this->manager->newShare();
 
-		$share->setSharedWith('sharedWith');
+        $share->setSharedWith('sharedWith');
 
-		$path = $this->createMock(Node::class);
-		$share->setNode($path);
+        $path = $this->createMock(Node::class);
+        $share->setNode($path);
 
-		$share2 = $this->manager->newShare();
-		$share2->setSharedWith('sharedWith2');
+        $share2 = $this->manager->newShare();
+        $share2->setSharedWith('sharedWith2');
 
-		$this->defaultProvider->method('getSharesByPath')
-			->with($path)
-			->willReturn([$share2]);
+        $this->defaultProvider->method('getSharesByPath')
+            ->with($path)
+            ->willReturn([$share2]);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
+            ]);
 
-		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
 
-	public function testLinkCreateChecksNoLinkSharesAllowed(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Link sharing is not allowed');
+    public function testLinkCreateChecksNoLinkSharesAllowed(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Link sharing is not allowed');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'no'],
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'no'],
+            ]);
 
-		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+    }
 
 
-	public function testFileLinkCreateChecksNoPublicUpload(): void {
-		$share = $this->manager->newShare();
+    public function testFileLinkCreateChecksNoPublicUpload(): void {
+        $share = $this->manager->newShare();
 
-		$share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
-		$share->setNodeType('file');
+        $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+        $share->setNodeType('file');
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['core', 'shareapi_allow_public_upload', 'yes', 'no']
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['core', 'shareapi_allow_public_upload', 'yes', 'no']
+            ]);
 
-		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
-	public function testFolderLinkCreateChecksNoPublicUpload(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Public upload is not allowed');
+    public function testFolderLinkCreateChecksNoPublicUpload(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Public upload is not allowed');
 
-		$share = $this->manager->newShare();
+        $share = $this->manager->newShare();
 
-		$share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
-		$share->setNodeType('folder');
+        $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+        $share->setNodeType('folder');
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['core', 'shareapi_allow_public_upload', 'yes', 'no']
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['core', 'shareapi_allow_public_upload', 'yes', 'no']
+            ]);
 
-		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-	}
+        self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+    }
 
-	public function testLinkCreateChecksPublicUpload(): void {
-		$share = $this->manager->newShare();
+    public function testLinkCreateChecksPublicUpload(): void {
+        $share = $this->manager->newShare();
 
-		$share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
-		$share->setSharedWith('sharedWith');
-		$folder = $this->createMock(\OC\Files\Node\Folder::class);
-		$share->setNode($folder);
+        $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+        $share->setSharedWith('sharedWith');
+        $folder = $this->createMock(\OC\Files\Node\Folder::class);
+        $share->setNode($folder);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['core', 'shareapi_allow_public_upload', 'yes', 'yes']
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['core', 'shareapi_allow_public_upload', 'yes', 'yes']
+            ]);
 
-		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
+        self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
 
-	public function testLinkCreateChecksReadOnly(): void {
-		$share = $this->manager->newShare();
+    public function testLinkCreateChecksReadOnly(): void {
+        $share = $this->manager->newShare();
 
-		$share->setPermissions(\OCP\Constants::PERMISSION_READ);
-		$share->setSharedWith('sharedWith');
-		$folder = $this->createMock(\OC\Files\Node\Folder::class);
-		$share->setNode($folder);
+        $share->setPermissions(\OCP\Constants::PERMISSION_READ);
+        $share->setSharedWith('sharedWith');
+        $folder = $this->createMock(\OC\Files\Node\Folder::class);
+        $share->setNode($folder);
 
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['core', 'shareapi_allow_public_upload', 'yes', 'no']
-			]);
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['core', 'shareapi_allow_public_upload', 'yes', 'no']
+            ]);
 
-		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
-	}
-
-
-	public function testPathCreateChecksContainsSharedMount(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('You cannot share a folder that contains other shares');
+        self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+        $this->addToAssertionCount(1);
+    }
+
+
+    public function testPathCreateChecksContainsSharedMount(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('You cannot share a folder that contains other shares');
 
-		$path = $this->createMock(Folder::class);
-		$path->method('getPath')->willReturn('path');
+        $path = $this->createMock(Folder::class);
+        $path->method('getPath')->willReturn('path');
 
-		$mount = $this->createMock(IMountPoint::class);
-		$storage = $this->createMock(IStorage::class);
-		$mount->method('getStorage')->willReturn($storage);
-		$storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(true);
-
-		$this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
-
-		self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
-	}
-
-	public function testPathCreateChecksContainsNoSharedMount(): void {
-		$path = $this->createMock(Folder::class);
-		$path->method('getPath')->willReturn('path');
+        $mount = $this->createMock(IMountPoint::class);
+        $storage = $this->createMock(IStorage::class);
+        $mount->method('getStorage')->willReturn($storage);
+        $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(true);
+
+        $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
+
+        self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+    }
+
+    public function testPathCreateChecksContainsNoSharedMount(): void {
+        $path = $this->createMock(Folder::class);
+        $path->method('getPath')->willReturn('path');
 
-		$mount = $this->createMock(IMountPoint::class);
-		$storage = $this->createMock(IStorage::class);
-		$mount->method('getStorage')->willReturn($storage);
-		$storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(false);
-
-		$this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
-
-		self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
-		$this->addToAssertionCount(1);
-	}
-
-	public function testPathCreateChecksContainsNoFolder(): void {
-		$path = $this->createMock(File::class);
-
-		self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
-		$this->addToAssertionCount(1);
-	}
-
-	public static function dataIsSharingDisabledForUser() {
-		$data = [];
-
-		// No exclude groups
-		$data[] = ['no', null, null, [], false];
-
-		// empty exclude / allow list, user no groups
-		$data[] = ['yes', '', json_encode(['']), [], false];
-		$data[] = ['allow', '', json_encode(['']), [], true];
-
-		// empty exclude / allow list, user groups
-		$data[] = ['yes', '', json_encode(['']), ['group1', 'group2'], false];
-		$data[] = ['allow', '', json_encode(['']), ['group1', 'group2'], true];
-
-		// Convert old list to json
-		$data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), [], false];
-		$data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), [], true];
-
-		// Old list partly groups in common
-		$data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
-		$data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
-
-		// Old list only groups in common
-		$data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], true];
-		$data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], false];
-
-		// New list partly in common
-		$data[] = ['yes', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
-		$data[] = ['allow', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
-
-		// New list only groups in common
-		$data[] = ['yes', json_encode(['group1', 'group2']), null, ['group2'], true];
-		$data[] = ['allow', json_encode(['group1', 'group2']), null, ['group2'], false];
-
-		return $data;
-	}
+        $mount = $this->createMock(IMountPoint::class);
+        $storage = $this->createMock(IStorage::class);
+        $mount->method('getStorage')->willReturn($storage);
+        $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(false);
+
+        $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
+
+        self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+        $this->addToAssertionCount(1);
+    }
+
+    public function testPathCreateChecksContainsNoFolder(): void {
+        $path = $this->createMock(File::class);
+
+        self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+        $this->addToAssertionCount(1);
+    }
+
+    public static function dataIsSharingDisabledForUser() {
+        $data = [];
+
+        // No exclude groups
+        $data[] = ['no', null, null, [], false];
+
+        // empty exclude / allow list, user no groups
+        $data[] = ['yes', '', json_encode(['']), [], false];
+        $data[] = ['allow', '', json_encode(['']), [], true];
+
+        // empty exclude / allow list, user groups
+        $data[] = ['yes', '', json_encode(['']), ['group1', 'group2'], false];
+        $data[] = ['allow', '', json_encode(['']), ['group1', 'group2'], true];
+
+        // Convert old list to json
+        $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), [], false];
+        $data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), [], true];
+
+        // Old list partly groups in common
+        $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
+        $data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
+
+        // Old list only groups in common
+        $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], true];
+        $data[] = ['allow', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], false];
+
+        // New list partly in common
+        $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
+        $data[] = ['allow', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
+
+        // New list only groups in common
+        $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group2'], true];
+        $data[] = ['allow', json_encode(['group1', 'group2']), null, ['group2'], false];
+
+        return $data;
+    }
 
-	/**
-	 * @dataProvider dataIsSharingDisabledForUser
-	 *
-	 * @param string $excludeGroups
-	 * @param string $groupList
-	 * @param string $setList
-	 * @param string[] $groupIds
-	 * @param bool $expected
-	 */
-	public function testIsSharingDisabledForUser($excludeGroups, $groupList, $setList, $groupIds, $expected): void {
-		$user = $this->createMock(IUser::class);
+    /**
+     * @dataProvider dataIsSharingDisabledForUser
+     *
+     * @param string $excludeGroups
+     * @param string $groupList
+     * @param string $setList
+     * @param string[] $groupIds
+     * @param bool $expected
+     */
+    public function testIsSharingDisabledForUser($excludeGroups, $groupList, $setList, $groupIds, $expected): void {
+        $user = $this->createMock(IUser::class);
 
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
-				['core', 'shareapi_exclude_groups_list', '', $groupList],
-			]);
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
+                ['core', 'shareapi_exclude_groups_list', '', $groupList],
+            ]);
 
-		if ($setList !== null) {
-			$this->config->expects($this->once())
-				->method('setAppValue')
-				->with('core', 'shareapi_exclude_groups_list', $setList);
-		} else {
-			$this->config->expects($this->never())
-				->method('setAppValue');
-		}
+        if ($setList !== null) {
+            $this->config->expects($this->once())
+                ->method('setAppValue')
+                ->with('core', 'shareapi_exclude_groups_list', $setList);
+        } else {
+            $this->config->expects($this->never())
+                ->method('setAppValue');
+        }
 
-		$this->groupManager->method('getUserGroupIds')
-			->with($user)
-			->willReturn($groupIds);
+        $this->groupManager->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn($groupIds);
 
-		$this->userManager->method('get')->with('user')->willReturn($user);
-
-		$res = $this->manager->sharingDisabledForUser('user');
-		$this->assertEquals($expected, $res);
-	}
-
-	public static function dataCanShare() {
-		$data = [];
-
-		/*
+        $this->userManager->method('get')->with('user')->willReturn($user);
+
+        $res = $this->manager->sharingDisabledForUser('user');
+        $this->assertEquals($expected, $res);
+    }
+
+    public static function dataCanShare() {
+        $data = [];
+
+        /*
 		 * [expected, sharing enabled, disabled for user]
 		 */
 
-		$data[] = [false, 'no', false];
-		$data[] = [false, 'no', true];
-		$data[] = [true, 'yes', false];
-		$data[] = [false, 'yes', true];
-
-		return $data;
-	}
-
-	/**
-	 * @dataProvider dataCanShare
-	 *
-	 * @param bool $expected
-	 * @param string $sharingEnabled
-	 * @param bool $disabledForUser
-	 */
-	public function testCanShare($expected, $sharingEnabled, $disabledForUser): void {
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_enabled', 'yes', $sharingEnabled],
-			]);
-
-		$manager = $this->createManagerMock()
-			->onlyMethods(['sharingDisabledForUser'])
-			->getMock();
-
-		$manager->method('sharingDisabledForUser')
-			->with('user')
-			->willReturn($disabledForUser);
-
-		$share = $this->manager->newShare();
-		$share->setSharedBy('user');
-
-		$exception = false;
-		try {
-			$res = self::invokePrivate($manager, 'canShare', [$share]);
-		} catch (\Exception $e) {
-			$exception = true;
-		}
-
-		$this->assertEquals($expected, !$exception);
-	}
-
-	public function testCreateShareUser(): void {
-		/** @var Manager&MockObject $manager */
-		$manager = $this->createManagerMock()
-			->onlyMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$path = $this->createMock(File::class);
-		$path->method('getOwner')->willReturn($shareOwner);
-		$path->method('getName')->willReturn('target');
-		$path->method('getStorage')->willReturn($storage);
-
-		$share = $this->createShare(
-			null,
-			IShare::TYPE_USER,
-			$path,
-			'sharedWith',
-			'sharedBy',
-			null,
-			\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('userCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('create')
-			->with($share)
-			->willReturnArgument(0);
-
-		$share->expects($this->once())
-			->method('setShareOwner')
-			->with('shareOwner');
-		$share->expects($this->once())
-			->method('setTarget')
-			->with('/target');
-
-		$manager->createShare($share);
-	}
-
-	public function testCreateShareGroup(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['canShare', 'generalCreateChecks', 'groupCreateChecks', 'pathCreateChecks'])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$path = $this->createMock(File::class);
-		$path->method('getOwner')->willReturn($shareOwner);
-		$path->method('getName')->willReturn('target');
-		$path->method('getStorage')->willReturn($storage);
-
-		$share = $this->createShare(
-			null,
-			IShare::TYPE_GROUP,
-			$path,
-			'sharedWith',
-			'sharedBy',
-			null,
-			\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('groupCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('create')
-			->with($share)
-			->willReturnArgument(0);
-
-		$share->expects($this->once())
-			->method('setShareOwner')
-			->with('shareOwner');
-		$share->expects($this->once())
-			->method('setTarget')
-			->with('/target');
-
-		$manager->createShare($share);
-	}
-
-	public function testCreateShareLink(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'generalCreateChecks',
-				'linkCreateChecks',
-				'pathCreateChecks',
-				'validateExpirationDateLink',
-				'verifyPassword',
-				'setLinkParent',
-			])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$path = $this->createMock(File::class);
-		$path->method('getOwner')->willReturn($shareOwner);
-		$path->method('getName')->willReturn('target');
-		$path->method('getId')->willReturn(1);
-		$path->method('getStorage')->willReturn($storage);
-
-		$date = new \DateTime();
-
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_LINK)
-			->setNode($path)
-			->setSharedBy('sharedBy')
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setExpirationDate($date)
-			->setPassword('password');
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('linkCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-		$manager->expects($this->once())
-			->method('validateExpirationDateLink')
-			->with($share)
-			->willReturn($share);
-		$manager->expects($this->once())
-			->method('verifyPassword')
-			->with('password');
-		$manager->expects($this->once())
-			->method('setLinkParent')
-			->with($share);
-
-		$this->hasher->expects($this->once())
-			->method('hash')
-			->with('password')
-			->willReturn('hashed');
-
-		$this->secureRandom->method('generate')
-			->willReturn('token');
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('create')
-			->with($share)
-			->willReturnCallback(function (Share $share) {
-				return $share->setId(42);
-			});
-
-		$calls = [
-			BeforeShareCreatedEvent::class,
-			ShareCreatedEvent::class,
-		];
-		$this->dispatcher->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $date, $path) {
-				$expected = array_shift($calls);
-				$this->assertInstanceOf($expected, $event);
-				$share = $event->getShare();
-
-				$this->assertEquals(IShare::TYPE_LINK, $share->getShareType(), 'getShareType');
-				$this->assertEquals($path, $share->getNode(), 'getNode');
-				$this->assertEquals('sharedBy', $share->getSharedBy(), 'getSharedBy');
-				$this->assertEquals(\OCP\Constants::PERMISSION_ALL, $share->getPermissions(), 'getPermissions');
-				$this->assertEquals($date, $share->getExpirationDate(), 'getExpirationDate');
-				$this->assertEquals('hashed', $share->getPassword(), 'getPassword');
-				$this->assertEquals('token', $share->getToken(), 'getToken');
-
-				if ($expected === ShareCreatedEvent::class) {
-					$this->assertEquals('42', $share->getId(), 'getId');
-					$this->assertEquals('/target', $share->getTarget(), 'getTarget');
-				}
-			});
-
-		/** @var IShare $share */
-		$share = $manager->createShare($share);
-
-		$this->assertSame('shareOwner', $share->getShareOwner());
-		$this->assertEquals('/target', $share->getTarget());
-		$this->assertSame($date, $share->getExpirationDate());
-		$this->assertEquals('token', $share->getToken());
-		$this->assertEquals('hashed', $share->getPassword());
-	}
-
-	public function testCreateShareMail(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'generalCreateChecks',
-				'linkCreateChecks',
-				'pathCreateChecks',
-				'validateExpirationDateLink',
-				'verifyPassword',
-				'setLinkParent',
-			])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$path = $this->createMock(File::class);
-		$path->method('getOwner')->willReturn($shareOwner);
-		$path->method('getName')->willReturn('target');
-		$path->method('getId')->willReturn(1);
-		$path->method('getStorage')->willReturn($storage);
-
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_EMAIL)
-			->setNode($path)
-			->setSharedBy('sharedBy')
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-
-		$manager->expects($this->once())
-			->method('linkCreateChecks');
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-		$manager->expects($this->once())
-			->method('validateExpirationDateLink')
-			->with($share)
-			->willReturn($share);
-		$manager->expects($this->once())
-			->method('verifyPassword');
-		$manager->expects($this->once())
-			->method('setLinkParent');
-
-		$this->secureRandom->method('generate')
-			->willReturn('token');
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('create')
-			->with($share)
-			->willReturnCallback(function (Share $share) {
-				return $share->setId(42);
-			});
-
-		$calls = [
-			BeforeShareCreatedEvent::class,
-			ShareCreatedEvent::class,
-		];
-		$this->dispatcher->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $path) {
-				$expected = array_shift($calls);
-				$this->assertInstanceOf($expected, $event);
-				$share = $event->getShare();
-
-				$this->assertEquals(IShare::TYPE_EMAIL, $share->getShareType(), 'getShareType');
-				$this->assertEquals($path, $share->getNode(), 'getNode');
-				$this->assertEquals('sharedBy', $share->getSharedBy(), 'getSharedBy');
-				$this->assertEquals(\OCP\Constants::PERMISSION_ALL, $share->getPermissions(), 'getPermissions');
-				$this->assertNull($share->getExpirationDate(), 'getExpirationDate');
-				$this->assertNull($share->getPassword(), 'getPassword');
-				$this->assertEquals('token', $share->getToken(), 'getToken');
-
-				if ($expected === ShareCreatedEvent::class) {
-					$this->assertEquals('42', $share->getId(), 'getId');
-					$this->assertEquals('/target', $share->getTarget(), 'getTarget');
-				}
-			});
-
-		/** @var IShare $share */
-		$share = $manager->createShare($share);
-
-		$this->assertSame('shareOwner', $share->getShareOwner());
-		$this->assertEquals('/target', $share->getTarget());
-		$this->assertEquals('token', $share->getToken());
-	}
-
-
-	public function testCreateShareHookError(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('I won\'t let you share');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'generalCreateChecks',
-				'userCreateChecks',
-				'pathCreateChecks',
-			])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$path = $this->createMock(File::class);
-		$path->method('getOwner')->willReturn($shareOwner);
-		$path->method('getName')->willReturn('target');
-		$path->method('getStorage')->willReturn($storage);
-
-		$share = $this->createShare(
-			null,
-			IShare::TYPE_USER,
-			$path,
-			'sharedWith',
-			'sharedBy',
-			null,
-			\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('userCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-
-		$share->expects($this->once())
-			->method('setShareOwner')
-			->with('shareOwner');
-		$share->expects($this->once())
-			->method('setTarget')
-			->with('/target');
-
-		// Pre share
-		$this->dispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with(
-				$this->isInstanceOf(BeforeShareCreatedEvent::class)
-			)->willReturnCallback(function (BeforeShareCreatedEvent $e) {
-				$e->setError('I won\'t let you share!');
-				$e->stopPropagation();
-			}
-			);
-
-		$manager->createShare($share);
-	}
-
-	public function testCreateShareOfIncomingFederatedShare(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
-			->getMock();
-
-		$shareOwner = $this->createMock(IUser::class);
-		$shareOwner->method('getUID')->willReturn('shareOwner');
-
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->with('OCA\Files_Sharing\External\Storage')
-			->willReturn(true);
-
-		$storage2 = $this->createMock(IStorage::class);
-		$storage2->method('instanceOfStorage')
-			->with('OCA\Files_Sharing\External\Storage')
-			->willReturn(false);
-
-		$path = $this->createMock(File::class);
-		$path->expects($this->never())->method('getOwner');
-		$path->method('getName')->willReturn('target');
-		$path->method('getStorage')->willReturn($storage);
-
-		$parent = $this->createMock(Folder::class);
-		$parent->method('getStorage')->willReturn($storage);
-
-		$parentParent = $this->createMock(Folder::class);
-		$parentParent->method('getStorage')->willReturn($storage2);
-		$parentParent->method('getOwner')->willReturn($shareOwner);
-
-		$path->method('getParent')->willReturn($parent);
-		$parent->method('getParent')->willReturn($parentParent);
-
-		$share = $this->createShare(
-			null,
-			IShare::TYPE_USER,
-			$path,
-			'sharedWith',
-			'sharedBy',
-			null,
-			\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())
-			->method('canShare')
-			->with($share)
-			->willReturn(true);
-		$manager->expects($this->once())
-			->method('generalCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('userCreateChecks')
-			->with($share);
-		;
-		$manager->expects($this->once())
-			->method('pathCreateChecks')
-			->with($path);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('create')
-			->with($share)
-			->willReturnArgument(0);
-
-		$share->expects($this->once())
-			->method('setShareOwner')
-			->with('shareOwner');
-		$share->expects($this->once())
-			->method('setTarget')
-			->with('/target');
-
-		$manager->createShare($share);
-	}
-
-	public function testGetSharesBy(): void {
-		$share = $this->manager->newShare();
-
-		$node = $this->createMock(Folder::class);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getSharesBy')
-			->with(
-				$this->equalTo('user'),
-				$this->equalTo(IShare::TYPE_USER),
-				$this->equalTo($node),
-				$this->equalTo(true),
-				$this->equalTo(1),
-				$this->equalTo(1)
-			)->willReturn([$share]);
-
-		$shares = $this->manager->getSharesBy('user', IShare::TYPE_USER, $node, true, 1, 1);
-
-		$this->assertCount(1, $shares);
-		$this->assertSame($share, $shares[0]);
-	}
-
-	public function testGetSharesByOwnerless(): void {
-		$mount = $this->createMock(IShareOwnerlessMount::class);
-
-		$node = $this->createMock(Folder::class);
-		$node
-			->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mount);
-
-		$share = $this->manager->newShare();
-		$share->setNode($node);
-		$share->setShareType(IShare::TYPE_USER);
-
-		$this->defaultProvider
-			->expects($this->once())
-			->method('getSharesByPath')
-			->with($this->equalTo($node))
-			->willReturn([$share]);
-
-		$shares = $this->manager->getSharesBy('user', IShare::TYPE_USER, $node, true, 1, 1);
-
-		$this->assertCount(1, $shares);
-		$this->assertSame($share, $shares[0]);
-	}
-
-	/**
-	 * Test to ensure we correctly remove expired link shares
-	 *
-	 * We have 8 Shares and we want the 3 first valid shares.
-	 * share 3-6 and 8 are expired. Thus at the end of this test we should
-	 * have received share 1,2 and 7. And from the manager. Share 3-6 should be
-	 * deleted (as they are evaluated). but share 8 should still be there.
-	 */
-	public function testGetSharesByExpiredLinkShares(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods(['deleteShare'])
-			->getMock();
-
-		/** @var \OCP\Share\IShare[] $shares */
-		$shares = [];
-
-		/*
+        $data[] = [false, 'no', false];
+        $data[] = [false, 'no', true];
+        $data[] = [true, 'yes', false];
+        $data[] = [false, 'yes', true];
+
+        return $data;
+    }
+
+    /**
+     * @dataProvider dataCanShare
+     *
+     * @param bool $expected
+     * @param string $sharingEnabled
+     * @param bool $disabledForUser
+     */
+    public function testCanShare($expected, $sharingEnabled, $disabledForUser): void {
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_enabled', 'yes', $sharingEnabled],
+            ]);
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['sharingDisabledForUser'])
+            ->getMock();
+
+        $manager->method('sharingDisabledForUser')
+            ->with('user')
+            ->willReturn($disabledForUser);
+
+        $share = $this->manager->newShare();
+        $share->setSharedBy('user');
+
+        $exception = false;
+        try {
+            $res = self::invokePrivate($manager, 'canShare', [$share]);
+        } catch (\Exception $e) {
+            $exception = true;
+        }
+
+        $this->assertEquals($expected, !$exception);
+    }
+
+    public function testCreateShareUser(): void {
+        /** @var Manager&MockObject $manager */
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $path = $this->createMock(File::class);
+        $path->method('getOwner')->willReturn($shareOwner);
+        $path->method('getName')->willReturn('target');
+        $path->method('getStorage')->willReturn($storage);
+
+        $share = $this->createShare(
+            null,
+            IShare::TYPE_USER,
+            $path,
+            'sharedWith',
+            'sharedBy',
+            null,
+            \OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('userCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('create')
+            ->with($share)
+            ->willReturnArgument(0);
+
+        $share->expects($this->once())
+            ->method('setShareOwner')
+            ->with('shareOwner');
+        $share->expects($this->once())
+            ->method('setTarget')
+            ->with('/target');
+
+        $manager->createShare($share);
+    }
+
+    public function testCreateShareGroup(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['canShare', 'generalCreateChecks', 'groupCreateChecks', 'pathCreateChecks'])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $path = $this->createMock(File::class);
+        $path->method('getOwner')->willReturn($shareOwner);
+        $path->method('getName')->willReturn('target');
+        $path->method('getStorage')->willReturn($storage);
+
+        $share = $this->createShare(
+            null,
+            IShare::TYPE_GROUP,
+            $path,
+            'sharedWith',
+            'sharedBy',
+            null,
+            \OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('groupCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('create')
+            ->with($share)
+            ->willReturnArgument(0);
+
+        $share->expects($this->once())
+            ->method('setShareOwner')
+            ->with('shareOwner');
+        $share->expects($this->once())
+            ->method('setTarget')
+            ->with('/target');
+
+        $manager->createShare($share);
+    }
+
+    public function testCreateShareLink(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'generalCreateChecks',
+                'linkCreateChecks',
+                'pathCreateChecks',
+                'validateExpirationDateLink',
+                'verifyPassword',
+                'setLinkParent',
+            ])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $path = $this->createMock(File::class);
+        $path->method('getOwner')->willReturn($shareOwner);
+        $path->method('getName')->willReturn('target');
+        $path->method('getId')->willReturn(1);
+        $path->method('getStorage')->willReturn($storage);
+
+        $date = new \DateTime();
+
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_LINK)
+            ->setNode($path)
+            ->setSharedBy('sharedBy')
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setExpirationDate($date)
+            ->setPassword('password');
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('linkCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+        $manager->expects($this->once())
+            ->method('validateExpirationDateLink')
+            ->with($share)
+            ->willReturn($share);
+        $manager->expects($this->once())
+            ->method('verifyPassword')
+            ->with('password');
+        $manager->expects($this->once())
+            ->method('setLinkParent')
+            ->with($share);
+
+        $this->hasher->expects($this->once())
+            ->method('hash')
+            ->with('password')
+            ->willReturn('hashed');
+
+        $this->secureRandom->method('generate')
+            ->willReturn('token');
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('create')
+            ->with($share)
+            ->willReturnCallback(function (Share $share) {
+                return $share->setId(42);
+            });
+
+        $calls = [
+            BeforeShareCreatedEvent::class,
+            ShareCreatedEvent::class,
+        ];
+        $this->dispatcher->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->willReturnCallback(function ($event) use (&$calls, $date, $path) {
+                $expected = array_shift($calls);
+                $this->assertInstanceOf($expected, $event);
+                $share = $event->getShare();
+
+                $this->assertEquals(IShare::TYPE_LINK, $share->getShareType(), 'getShareType');
+                $this->assertEquals($path, $share->getNode(), 'getNode');
+                $this->assertEquals('sharedBy', $share->getSharedBy(), 'getSharedBy');
+                $this->assertEquals(\OCP\Constants::PERMISSION_ALL, $share->getPermissions(), 'getPermissions');
+                $this->assertEquals($date, $share->getExpirationDate(), 'getExpirationDate');
+                $this->assertEquals('hashed', $share->getPassword(), 'getPassword');
+                $this->assertEquals('token', $share->getToken(), 'getToken');
+
+                if ($expected === ShareCreatedEvent::class) {
+                    $this->assertEquals('42', $share->getId(), 'getId');
+                    $this->assertEquals('/target', $share->getTarget(), 'getTarget');
+                }
+            });
+
+        /** @var IShare $share */
+        $share = $manager->createShare($share);
+
+        $this->assertSame('shareOwner', $share->getShareOwner());
+        $this->assertEquals('/target', $share->getTarget());
+        $this->assertSame($date, $share->getExpirationDate());
+        $this->assertEquals('token', $share->getToken());
+        $this->assertEquals('hashed', $share->getPassword());
+    }
+
+    public function testCreateShareMail(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'generalCreateChecks',
+                'linkCreateChecks',
+                'pathCreateChecks',
+                'validateExpirationDateLink',
+                'verifyPassword',
+                'setLinkParent',
+            ])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $path = $this->createMock(File::class);
+        $path->method('getOwner')->willReturn($shareOwner);
+        $path->method('getName')->willReturn('target');
+        $path->method('getId')->willReturn(1);
+        $path->method('getStorage')->willReturn($storage);
+
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_EMAIL)
+            ->setNode($path)
+            ->setSharedBy('sharedBy')
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+
+        $manager->expects($this->once())
+            ->method('linkCreateChecks');
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+        $manager->expects($this->once())
+            ->method('validateExpirationDateLink')
+            ->with($share)
+            ->willReturn($share);
+        $manager->expects($this->once())
+            ->method('verifyPassword');
+        $manager->expects($this->once())
+            ->method('setLinkParent');
+
+        $this->secureRandom->method('generate')
+            ->willReturn('token');
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('create')
+            ->with($share)
+            ->willReturnCallback(function (Share $share) {
+                return $share->setId(42);
+            });
+
+        $calls = [
+            BeforeShareCreatedEvent::class,
+            ShareCreatedEvent::class,
+        ];
+        $this->dispatcher->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->willReturnCallback(function ($event) use (&$calls, $path) {
+                $expected = array_shift($calls);
+                $this->assertInstanceOf($expected, $event);
+                $share = $event->getShare();
+
+                $this->assertEquals(IShare::TYPE_EMAIL, $share->getShareType(), 'getShareType');
+                $this->assertEquals($path, $share->getNode(), 'getNode');
+                $this->assertEquals('sharedBy', $share->getSharedBy(), 'getSharedBy');
+                $this->assertEquals(\OCP\Constants::PERMISSION_ALL, $share->getPermissions(), 'getPermissions');
+                $this->assertNull($share->getExpirationDate(), 'getExpirationDate');
+                $this->assertNull($share->getPassword(), 'getPassword');
+                $this->assertEquals('token', $share->getToken(), 'getToken');
+
+                if ($expected === ShareCreatedEvent::class) {
+                    $this->assertEquals('42', $share->getId(), 'getId');
+                    $this->assertEquals('/target', $share->getTarget(), 'getTarget');
+                }
+            });
+
+        /** @var IShare $share */
+        $share = $manager->createShare($share);
+
+        $this->assertSame('shareOwner', $share->getShareOwner());
+        $this->assertEquals('/target', $share->getTarget());
+        $this->assertEquals('token', $share->getToken());
+    }
+
+
+    public function testCreateShareHookError(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('I won\'t let you share');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'generalCreateChecks',
+                'userCreateChecks',
+                'pathCreateChecks',
+            ])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $path = $this->createMock(File::class);
+        $path->method('getOwner')->willReturn($shareOwner);
+        $path->method('getName')->willReturn('target');
+        $path->method('getStorage')->willReturn($storage);
+
+        $share = $this->createShare(
+            null,
+            IShare::TYPE_USER,
+            $path,
+            'sharedWith',
+            'sharedBy',
+            null,
+            \OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('userCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+
+        $share->expects($this->once())
+            ->method('setShareOwner')
+            ->with('shareOwner');
+        $share->expects($this->once())
+            ->method('setTarget')
+            ->with('/target');
+
+        // Pre share
+        $this->dispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with(
+                $this->isInstanceOf(BeforeShareCreatedEvent::class)
+            )->willReturnCallback(function (BeforeShareCreatedEvent $e) {
+                $e->setError('I won\'t let you share!');
+                $e->stopPropagation();
+            }
+            );
+
+        $manager->createShare($share);
+    }
+
+    public function testCreateShareOfIncomingFederatedShare(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
+            ->getMock();
+
+        $shareOwner = $this->createMock(IUser::class);
+        $shareOwner->method('getUID')->willReturn('shareOwner');
+
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->with('OCA\Files_Sharing\External\Storage')
+            ->willReturn(true);
+
+        $storage2 = $this->createMock(IStorage::class);
+        $storage2->method('instanceOfStorage')
+            ->with('OCA\Files_Sharing\External\Storage')
+            ->willReturn(false);
+
+        $path = $this->createMock(File::class);
+        $path->expects($this->never())->method('getOwner');
+        $path->method('getName')->willReturn('target');
+        $path->method('getStorage')->willReturn($storage);
+
+        $parent = $this->createMock(Folder::class);
+        $parent->method('getStorage')->willReturn($storage);
+
+        $parentParent = $this->createMock(Folder::class);
+        $parentParent->method('getStorage')->willReturn($storage2);
+        $parentParent->method('getOwner')->willReturn($shareOwner);
+
+        $path->method('getParent')->willReturn($parent);
+        $parent->method('getParent')->willReturn($parentParent);
+
+        $share = $this->createShare(
+            null,
+            IShare::TYPE_USER,
+            $path,
+            'sharedWith',
+            'sharedBy',
+            null,
+            \OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())
+            ->method('canShare')
+            ->with($share)
+            ->willReturn(true);
+        $manager->expects($this->once())
+            ->method('generalCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('userCreateChecks')
+            ->with($share);
+        ;
+        $manager->expects($this->once())
+            ->method('pathCreateChecks')
+            ->with($path);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('create')
+            ->with($share)
+            ->willReturnArgument(0);
+
+        $share->expects($this->once())
+            ->method('setShareOwner')
+            ->with('shareOwner');
+        $share->expects($this->once())
+            ->method('setTarget')
+            ->with('/target');
+
+        $manager->createShare($share);
+    }
+
+    public function testGetSharesBy(): void {
+        $share = $this->manager->newShare();
+
+        $node = $this->createMock(Folder::class);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getSharesBy')
+            ->with(
+                $this->equalTo('user'),
+                $this->equalTo(IShare::TYPE_USER),
+                $this->equalTo($node),
+                $this->equalTo(true),
+                $this->equalTo(1),
+                $this->equalTo(1)
+            )->willReturn([$share]);
+
+        $shares = $this->manager->getSharesBy('user', IShare::TYPE_USER, $node, true, 1, 1);
+
+        $this->assertCount(1, $shares);
+        $this->assertSame($share, $shares[0]);
+    }
+
+    public function testGetSharesByOwnerless(): void {
+        $mount = $this->createMock(IShareOwnerlessMount::class);
+
+        $node = $this->createMock(Folder::class);
+        $node
+            ->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mount);
+
+        $share = $this->manager->newShare();
+        $share->setNode($node);
+        $share->setShareType(IShare::TYPE_USER);
+
+        $this->defaultProvider
+            ->expects($this->once())
+            ->method('getSharesByPath')
+            ->with($this->equalTo($node))
+            ->willReturn([$share]);
+
+        $shares = $this->manager->getSharesBy('user', IShare::TYPE_USER, $node, true, 1, 1);
+
+        $this->assertCount(1, $shares);
+        $this->assertSame($share, $shares[0]);
+    }
+
+    /**
+     * Test to ensure we correctly remove expired link shares
+     *
+     * We have 8 Shares and we want the 3 first valid shares.
+     * share 3-6 and 8 are expired. Thus at the end of this test we should
+     * have received share 1,2 and 7. And from the manager. Share 3-6 should be
+     * deleted (as they are evaluated). but share 8 should still be there.
+     */
+    public function testGetSharesByExpiredLinkShares(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['deleteShare'])
+            ->getMock();
+
+        /** @var \OCP\Share\IShare[] $shares */
+        $shares = [];
+
+        /*
 		 * This results in an array of 8 IShare elements
 		 */
-		for ($i = 0; $i < 8; $i++) {
-			$share = $this->manager->newShare();
-			$share->setId($i);
-			$shares[] = $share;
-		}
+        for ($i = 0; $i < 8; $i++) {
+            $share = $this->manager->newShare();
+            $share->setId($i);
+            $shares[] = $share;
+        }
 
-		$today = new \DateTime();
-		$today->setTime(0, 0, 0);
+        $today = new \DateTime();
+        $today->setTime(0, 0, 0);
 
-		/*
+        /*
 		 * Set the expiration date to today for some shares
 		 */
-		$shares[2]->setExpirationDate($today);
-		$shares[3]->setExpirationDate($today);
-		$shares[4]->setExpirationDate($today);
-		$shares[5]->setExpirationDate($today);
+        $shares[2]->setExpirationDate($today);
+        $shares[3]->setExpirationDate($today);
+        $shares[4]->setExpirationDate($today);
+        $shares[5]->setExpirationDate($today);
 
-		/** @var \OCP\Share\IShare[] $i */
-		$shares2 = [];
-		for ($i = 0; $i < 8; $i++) {
-			$shares2[] = clone $shares[$i];
-		}
+        /** @var \OCP\Share\IShare[] $i */
+        $shares2 = [];
+        for ($i = 0; $i < 8; $i++) {
+            $shares2[] = clone $shares[$i];
+        }
 
-		$node = $this->createMock(File::class);
+        $node = $this->createMock(File::class);
 
-		/*
+        /*
 		 * Simulate the getSharesBy call.
 		 */
-		$this->defaultProvider
-			->method('getSharesBy')
-			->willReturnCallback(function ($uid, $type, $node, $reshares, $limit, $offset) use (&$shares2) {
-				return array_slice($shares2, $offset, $limit);
-			});
+        $this->defaultProvider
+            ->method('getSharesBy')
+            ->willReturnCallback(function ($uid, $type, $node, $reshares, $limit, $offset) use (&$shares2) {
+                return array_slice($shares2, $offset, $limit);
+            });
 
-		/*
+        /*
 		 * Simulate the deleteShare call.
 		 */
-		$manager->method('deleteShare')
-			->willReturnCallback(function ($share) use (&$shares2) {
-				for ($i = 0; $i < count($shares2); $i++) {
-					if ($shares2[$i]->getId() === $share->getId()) {
-						array_splice($shares2, $i, 1);
-						break;
-					}
-				}
-			});
-
-		$res = $manager->getSharesBy('user', IShare::TYPE_LINK, $node, true, 3, 0);
-
-		$this->assertCount(3, $res);
-		$this->assertEquals($shares[0]->getId(), $res[0]->getId());
-		$this->assertEquals($shares[1]->getId(), $res[1]->getId());
-		$this->assertEquals($shares[6]->getId(), $res[2]->getId());
-
-		$this->assertCount(4, $shares2);
-		$this->assertEquals(0, $shares2[0]->getId());
-		$this->assertEquals(1, $shares2[1]->getId());
-		$this->assertEquals(6, $shares2[2]->getId());
-		$this->assertEquals(7, $shares2[3]->getId());
-		$this->assertSame($today, $shares[3]->getExpirationDate());
-	}
-
-	public function testGetShareByToken(): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
-			]);
-
-		$factory = $this->createMock(IProviderFactory::class);
-
-		$manager = $this->createManager($factory);
-
-		$share = $this->createMock(IShare::class);
-
-		$factory->expects($this->once())
-			->method('getProviderForType')
-			->with(IShare::TYPE_LINK)
-			->willReturn($this->defaultProvider);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-
-		$ret = $manager->getShareByToken('token');
-		$this->assertSame($share, $ret);
-	}
-
-	public function testGetShareByTokenRoom(): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'no'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
-			]);
-
-		$factory = $this->createMock(IProviderFactory::class);
-
-		$manager = $this->createManager($factory);
-
-		$share = $this->createMock(IShare::class);
-
-		$roomShareProvider = $this->createMock(IShareProvider::class);
-
-		$factory->expects($this->any())
-			->method('getProviderForType')
-			->willReturnCallback(function ($shareType) use ($roomShareProvider) {
-				if ($shareType !== IShare::TYPE_ROOM) {
-					throw new Exception\ProviderException();
-				}
-
-				return $roomShareProvider;
-			});
-
-		$roomShareProvider->expects($this->once())
-			->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-
-		$ret = $manager->getShareByToken('token');
-		$this->assertSame($share, $ret);
-	}
-
-	public function testGetShareByTokenWithException(): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
-			]);
-
-		$factory = $this->createMock(IProviderFactory::class);
-
-		$manager = $this->createManager($factory);
-
-		$share = $this->createMock(IShare::class);
-
-		$calls = [
-			[IShare::TYPE_LINK],
-			[IShare::TYPE_REMOTE],
-		];
-		$factory->expects($this->exactly(2))
-			->method('getProviderForType')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return $this->defaultProvider;
-			});
-
-		$this->defaultProvider->expects($this->exactly(2))
-			->method('getShareByToken')
-			->with('token')
-			->willReturnOnConsecutiveCalls(
-				$this->throwException(new ShareNotFound()),
-				$share
-			);
-
-		$ret = $manager->getShareByToken('token');
-		$this->assertSame($share, $ret);
-	}
-
-
-	public function testGetShareByTokenHideDisabledUser(): void {
-		$this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
-		$this->expectExceptionMessage('The requested share comes from a disabled user');
-
-		$this->config
-			->expects($this->exactly(2))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'yes'],
-			]);
-
-		$this->l->expects($this->once())
-			->method('t')
-			->willReturnArgument(0);
-
-		$manager = $this->createManagerMock()
-			->onlyMethods(['deleteShare'])
-			->getMock();
-
-		$date = new \DateTime();
-		$date->setTime(0, 0, 0);
-		$date->add(new \DateInterval('P2D'));
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($date);
-		$share->setShareOwner('owner');
-		$share->setSharedBy('sharedBy');
-
-		$sharedBy = $this->createMock(IUser::class);
-		$owner = $this->createMock(IUser::class);
-
-		$this->userManager->method('get')->willReturnMap([
-			['sharedBy', $sharedBy],
-			['owner', $owner],
-		]);
-
-		$owner->expects($this->once())
-			->method('isEnabled')
-			->willReturn(true);
-		$sharedBy->expects($this->once())
-			->method('isEnabled')
-			->willReturn(false);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareByToken')
-			->with('expiredToken')
-			->willReturn($share);
-
-		$manager->expects($this->never())
-			->method('deleteShare');
-
-		$manager->getShareByToken('expiredToken');
-	}
-
-
-	public function testGetShareByTokenExpired(): void {
-		$this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
-		$this->expectExceptionMessage('The requested share does not exist anymore');
-
-		$this->config
-			->expects($this->once())
-			->method('getAppValue')
-			->with('core', 'shareapi_allow_links', 'yes')
-			->willReturn('yes');
-
-		$this->l->expects($this->once())
-			->method('t')
-			->willReturnArgument(0);
-
-		$manager = $this->createManagerMock()
-			->onlyMethods(['deleteShare'])
-			->getMock();
-
-		$date = new \DateTime();
-		$date->setTime(0, 0, 0);
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($date);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareByToken')
-			->with('expiredToken')
-			->willReturn($share);
-
-		$manager->expects($this->once())
-			->method('deleteShare')
-			->with($this->equalTo($share));
-
-		$manager->getShareByToken('expiredToken');
-	}
-
-	public function testGetShareByTokenNotExpired(): void {
-		$this->config
-			->expects($this->exactly(2))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
-			]);
-
-		$date = new \DateTime();
-		$date->setTime(0, 0, 0);
-		$date->add(new \DateInterval('P2D'));
-		$share = $this->manager->newShare();
-		$share->setExpirationDate($date);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareByToken')
-			->with('expiredToken')
-			->willReturn($share);
-
-		$res = $this->manager->getShareByToken('expiredToken');
-
-		$this->assertSame($share, $res);
-	}
-
-
-	public function testGetShareByTokenWithPublicLinksDisabled(): void {
-		$this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
-
-		$this->config
-			->expects($this->once())
-			->method('getAppValue')
-			->with('core', 'shareapi_allow_links', 'yes')
-			->willReturn('no');
-		$this->manager->getShareByToken('validToken');
-	}
-
-	public function testGetShareByTokenPublicUploadDisabled(): void {
-		$this->config
-			->expects($this->exactly(3))
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_links', 'yes', 'yes'],
-				['core', 'shareapi_allow_public_upload', 'yes', 'no'],
-				['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
-			]);
-
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_LINK)
-			->setPermissions(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
-		$share->setSharedWith('sharedWith');
-		$folder = $this->createMock(\OC\Files\Node\Folder::class);
-		$share->setNode($folder);
-
-		$this->defaultProvider->expects($this->once())
-			->method('getShareByToken')
-			->willReturn('validToken')
-			->willReturn($share);
-
-		$res = $this->manager->getShareByToken('validToken');
-
-		$this->assertSame(\OCP\Constants::PERMISSION_READ, $res->getPermissions());
-	}
-
-	public function testCheckPasswordNoLinkShare(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$this->assertFalse($this->manager->checkPassword($share, 'password'));
-	}
-
-	public function testCheckPasswordNoPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$this->assertFalse($this->manager->checkPassword($share, 'password'));
-
-		$share->method('getPassword')->willReturn('password');
-		$this->assertFalse($this->manager->checkPassword($share, null));
-	}
-
-	public function testCheckPasswordInvalidPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$share->method('getPassword')->willReturn('password');
-
-		$this->hasher->method('verify')->with('invalidpassword', 'password', '')->willReturn(false);
-
-		$this->assertFalse($this->manager->checkPassword($share, 'invalidpassword'));
-	}
-
-	public function testCheckPasswordValidPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$share->method('getPassword')->willReturn('passwordHash');
-
-		$this->hasher->method('verify')->with('password', 'passwordHash', '')->willReturn(true);
-
-		$this->assertTrue($this->manager->checkPassword($share, 'password'));
-	}
-
-	public function testCheckPasswordUpdateShare(): void {
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_LINK)
-			->setPassword('passwordHash');
-
-		$this->hasher->method('verify')->with('password', 'passwordHash', '')
-			->willReturnCallback(function ($pass, $hash, &$newHash) {
-				$newHash = 'newHash';
-
-				return true;
-			});
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($this->callback(function (\OCP\Share\IShare $share) {
-				return $share->getPassword() === 'newHash';
-			}));
-
-		$this->assertTrue($this->manager->checkPassword($share, 'password'));
-	}
-
-
-	public function testUpdateShareCantChangeShareType(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Cannot change share type');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById'
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_GROUP);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-
-		$share = $this->manager->newShare();
-		$attrs = $this->manager->newShare()->newAttributes();
-		$attrs->setAttribute('app1', 'perm1', true);
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_USER);
-
-		$manager->updateShare($share);
-	}
-
-
-	public function testUpdateShareCantChangeRecipientForGroupShare(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Can only update recipient on user shares');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById'
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('origGroup');
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('newGroup');
-
-		$manager->updateShare($share);
-	}
-
-
-	public function testUpdateShareCantShareWithOwner(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Cannot share with the share owner');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById'
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_USER)
-			->setSharedWith('sharedWith');
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_USER)
-			->setSharedWith('newUser')
-			->setShareOwner('newUser');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareUser(): void {
-		$this->userManager->expects($this->any())->method('userExists')->willReturn(true);
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'userCreateChecks',
-				'pathCreateChecks',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_USER)
-			->setSharedWith('origUser')
-			->setPermissions(1);
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(100);
-		$node->method('getPath')->willReturn('/newUser/files/myPath');
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-
-		$share = $this->manager->newShare();
-		$attrs = $this->manager->newShare()->newAttributes();
-		$attrs->setAttribute('app1', 'perm1', true);
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_USER)
-			->setSharedWith('origUser')
-			->setShareOwner('newUser')
-			->setSharedBy('sharer')
-			->setPermissions(31)
-			->setAttributes($attrs)
-			->setNode($node);
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share)
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$this->rootFolder->method('getUserFolder')->with('newUser')->willReturnSelf();
-		$this->rootFolder->method('getRelativePath')->with('/newUser/files/myPath')->willReturn('/myPath');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener2, 'post');
-		$hookListener2->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'shareType' => IShare::TYPE_USER,
-			'shareWith' => 'origUser',
-			'uidOwner' => 'sharer',
-			'permissions' => 31,
-			'path' => '/myPath',
-			'attributes' => $attrs->toArray(),
-		]);
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareGroup(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'groupCreateChecks',
-				'pathCreateChecks',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('origUser')
-			->setPermissions(31);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-
-		$node = $this->createMock(File::class);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('origUser')
-			->setShareOwner('owner')
-			->setNode($node)
-			->setPermissions(31);
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share)
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareLink(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'linkCreateChecks',
-				'pathCreateChecks',
-				'verifyPassword',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_LINK)
-			->setPermissions(15);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_LINK)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('password')
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(15);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('validateExpirationDateLink')->with($share);
-		$manager->expects($this->once())->method('verifyPassword')->with('password');
-
-		$this->hasher->expects($this->once())
-			->method('hash')
-			->with('password')
-			->willReturn('hashed');
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share)
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'date' => $tomorrow,
-			'uidOwner' => 'owner',
-		]);
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'uidOwner' => 'owner',
-			'token' => 'token',
-			'disabled' => false,
-		]);
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareLinkEnableSendPasswordByTalkWithNoPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'linkCreateChecks',
-				'pathCreateChecks',
-				'verifyPassword',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_LINK)
-			->setPermissions(15);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_LINK)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword(null)
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(15);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('linkCreateChecks')->with($share);
-		$manager->expects($this->never())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMail(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('password')
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('verifyPassword')->with('password');
-		$manager->expects($this->once())->method('pathCreateChecks')->with($file);
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->once())->method('validateExpirationDateLink');
-
-		$this->hasher->expects($this->once())
-			->method('hash')
-			->with('password')
-			->willReturn('hashed');
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share, 'password')
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'date' => $tomorrow,
-			'uidOwner' => 'owner',
-		]);
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'uidOwner' => 'owner',
-			'token' => 'token',
-			'disabled' => false,
-		]);
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMailEnableSendPasswordByTalk(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword(null)
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('verifyPassword')->with('password');
-		$manager->expects($this->once())->method('pathCreateChecks')->with($file);
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->once())->method('validateExpirationDateLink');
-
-		$this->hasher->expects($this->once())
-			->method('hash')
-			->with('password')
-			->willReturn('hashed');
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share, 'password')
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'date' => $tomorrow,
-			'uidOwner' => 'owner',
-		]);
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'uidOwner' => 'owner',
-			'token' => 'token',
-			'disabled' => false,
-		]);
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMailEnableSendPasswordByTalkWithDifferentPassword(): void {
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('anotherPasswordHash')
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('verifyPassword')->with('password');
-		$manager->expects($this->once())->method('pathCreateChecks')->with($file);
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->once())->method('validateExpirationDateLink');
-
-		$this->hasher->expects($this->once())
-			->method('verify')
-			->with('password', 'anotherPasswordHash')
-			->willReturn(false);
-
-		$this->hasher->expects($this->once())
-			->method('hash')
-			->with('password')
-			->willReturn('hashed');
-
-		$this->defaultProvider->expects($this->once())
-			->method('update')
-			->with($share, 'password')
-			->willReturn($share);
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'date' => $tomorrow,
-			'uidOwner' => 'owner',
-		]);
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->once())->method('post')->with([
-			'itemType' => 'file',
-			'itemSource' => 100,
-			'uidOwner' => 'owner',
-			'token' => 'token',
-			'disabled' => false,
-		]);
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMailEnableSendPasswordByTalkWithNoPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword(null)
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword(null)
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->never())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the password is empty, we have nothing to hash
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-
-	public function testUpdateShareMailEnableSendPasswordByTalkRemovingPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword(null)
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the password is empty, we have nothing to hash
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-
-	public function testUpdateShareMailEnableSendPasswordByTalkRemovingPasswordWithEmptyString(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->once())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the password is empty, we have nothing to hash
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-
-	public function testUpdateShareMailEnableSendPasswordByTalkWithPreviousPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot enable sending the password by Talk without setting a new password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('password')
-			->setSendPasswordByTalk(false);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->never())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the old & new passwords are the same, we don't do anything
-		$this->hasher->expects($this->never())
-			->method('verify');
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMailDisableSendPasswordByTalkWithPreviousPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot disable sending the password by Talk without setting a new password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(true);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(false)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->never())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the old & new passwords are the same, we don't do anything
-		$this->hasher->expects($this->never())
-			->method('verify');
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
-
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
-
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
-
-		$manager->updateShare($share);
-	}
-
-	public function testUpdateShareMailDisableSendPasswordByTalkWithoutChangingPassword(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot disable sending the password by Talk without setting a new password');
-
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'canShare',
-				'getShareById',
-				'generalCreateChecks',
-				'verifyPassword',
-				'pathCreateChecks',
-				'linkCreateChecks',
-				'validateExpirationDateLink',
-			])
-			->getMock();
-
-		$originalShare = $this->manager->newShare();
-		$originalShare->setShareType(IShare::TYPE_EMAIL)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL)
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(true);
-
-		$tomorrow = new \DateTime();
-		$tomorrow->setTime(0, 0, 0);
-		$tomorrow->add(new \DateInterval('P1D'));
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(100);
-
-		$share = $this->manager->newShare();
-		$share->setProviderId('foo')
-			->setId('42')
-			->setShareType(IShare::TYPE_EMAIL)
-			->setToken('token')
-			->setSharedBy('owner')
-			->setShareOwner('owner')
-			->setPassword('passwordHash')
-			->setSendPasswordByTalk(false)
-			->setExpirationDate($tomorrow)
-			->setNode($file)
-			->setPermissions(\OCP\Constants::PERMISSION_ALL);
-
-		$manager->expects($this->once())->method('canShare')->willReturn(true);
-		$manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
-		$manager->expects($this->once())->method('generalCreateChecks')->with($share);
-		$manager->expects($this->never())->method('verifyPassword');
-		$manager->expects($this->never())->method('pathCreateChecks');
-		$manager->expects($this->once())->method('linkCreateChecks');
-		$manager->expects($this->never())->method('validateExpirationDateLink');
-
-		// If the old & new passwords are the same, we don't do anything
-		$this->hasher->expects($this->never())
-			->method('verify');
-		$this->hasher->expects($this->never())
-			->method('hash');
-
-		$this->defaultProvider->expects($this->never())
-			->method('update');
-
-		$hookListener = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
-		$hookListener->expects($this->never())->method('post');
+        $manager->method('deleteShare')
+            ->willReturnCallback(function ($share) use (&$shares2) {
+                for ($i = 0; $i < count($shares2); $i++) {
+                    if ($shares2[$i]->getId() === $share->getId()) {
+                        array_splice($shares2, $i, 1);
+                        break;
+                    }
+                }
+            });
+
+        $res = $manager->getSharesBy('user', IShare::TYPE_LINK, $node, true, 3, 0);
+
+        $this->assertCount(3, $res);
+        $this->assertEquals($shares[0]->getId(), $res[0]->getId());
+        $this->assertEquals($shares[1]->getId(), $res[1]->getId());
+        $this->assertEquals($shares[6]->getId(), $res[2]->getId());
+
+        $this->assertCount(4, $shares2);
+        $this->assertEquals(0, $shares2[0]->getId());
+        $this->assertEquals(1, $shares2[1]->getId());
+        $this->assertEquals(6, $shares2[2]->getId());
+        $this->assertEquals(7, $shares2[3]->getId());
+        $this->assertSame($today, $shares[3]->getExpirationDate());
+    }
+
+    public function testGetShareByToken(): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
+            ]);
+
+        $factory = $this->createMock(IProviderFactory::class);
+
+        $manager = $this->createManager($factory);
+
+        $share = $this->createMock(IShare::class);
+
+        $factory->expects($this->once())
+            ->method('getProviderForType')
+            ->with(IShare::TYPE_LINK)
+            ->willReturn($this->defaultProvider);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+
+        $ret = $manager->getShareByToken('token');
+        $this->assertSame($share, $ret);
+    }
+
+    public function testGetShareByTokenRoom(): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'no'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
+            ]);
+
+        $factory = $this->createMock(IProviderFactory::class);
+
+        $manager = $this->createManager($factory);
+
+        $share = $this->createMock(IShare::class);
+
+        $roomShareProvider = $this->createMock(IShareProvider::class);
+
+        $factory->expects($this->any())
+            ->method('getProviderForType')
+            ->willReturnCallback(function ($shareType) use ($roomShareProvider) {
+                if ($shareType !== IShare::TYPE_ROOM) {
+                    throw new Exception\ProviderException();
+                }
+
+                return $roomShareProvider;
+            });
+
+        $roomShareProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+
+        $ret = $manager->getShareByToken('token');
+        $this->assertSame($share, $ret);
+    }
+
+    public function testGetShareByTokenWithException(): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
+            ]);
+
+        $factory = $this->createMock(IProviderFactory::class);
+
+        $manager = $this->createManager($factory);
+
+        $share = $this->createMock(IShare::class);
+
+        $calls = [
+            [IShare::TYPE_LINK],
+            [IShare::TYPE_REMOTE],
+        ];
+        $factory->expects($this->exactly(2))
+            ->method('getProviderForType')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return $this->defaultProvider;
+            });
+
+        $this->defaultProvider->expects($this->exactly(2))
+            ->method('getShareByToken')
+            ->with('token')
+            ->willReturnOnConsecutiveCalls(
+                $this->throwException(new ShareNotFound()),
+                $share
+            );
+
+        $ret = $manager->getShareByToken('token');
+        $this->assertSame($share, $ret);
+    }
+
+
+    public function testGetShareByTokenHideDisabledUser(): void {
+        $this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
+        $this->expectExceptionMessage('The requested share comes from a disabled user');
+
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'yes'],
+            ]);
+
+        $this->l->expects($this->once())
+            ->method('t')
+            ->willReturnArgument(0);
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['deleteShare'])
+            ->getMock();
+
+        $date = new \DateTime();
+        $date->setTime(0, 0, 0);
+        $date->add(new \DateInterval('P2D'));
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($date);
+        $share->setShareOwner('owner');
+        $share->setSharedBy('sharedBy');
+
+        $sharedBy = $this->createMock(IUser::class);
+        $owner = $this->createMock(IUser::class);
+
+        $this->userManager->method('get')->willReturnMap([
+            ['sharedBy', $sharedBy],
+            ['owner', $owner],
+        ]);
+
+        $owner->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(true);
+        $sharedBy->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(false);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->with('expiredToken')
+            ->willReturn($share);
+
+        $manager->expects($this->never())
+            ->method('deleteShare');
+
+        $manager->getShareByToken('expiredToken');
+    }
+
+
+    public function testGetShareByTokenExpired(): void {
+        $this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
+        $this->expectExceptionMessage('The requested share does not exist anymore');
+
+        $this->config
+            ->expects($this->once())
+            ->method('getAppValue')
+            ->with('core', 'shareapi_allow_links', 'yes')
+            ->willReturn('yes');
+
+        $this->l->expects($this->once())
+            ->method('t')
+            ->willReturnArgument(0);
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods(['deleteShare'])
+            ->getMock();
+
+        $date = new \DateTime();
+        $date->setTime(0, 0, 0);
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($date);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->with('expiredToken')
+            ->willReturn($share);
+
+        $manager->expects($this->once())
+            ->method('deleteShare')
+            ->with($this->equalTo($share));
+
+        $manager->getShareByToken('expiredToken');
+    }
+
+    public function testGetShareByTokenNotExpired(): void {
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
+            ]);
+
+        $date = new \DateTime();
+        $date->setTime(0, 0, 0);
+        $date->add(new \DateInterval('P2D'));
+        $share = $this->manager->newShare();
+        $share->setExpirationDate($date);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->with('expiredToken')
+            ->willReturn($share);
+
+        $res = $this->manager->getShareByToken('expiredToken');
+
+        $this->assertSame($share, $res);
+    }
+
+
+    public function testGetShareByTokenWithPublicLinksDisabled(): void {
+        $this->expectException(\OCP\Share\Exceptions\ShareNotFound::class);
+
+        $this->config
+            ->expects($this->once())
+            ->method('getAppValue')
+            ->with('core', 'shareapi_allow_links', 'yes')
+            ->willReturn('no');
+        $this->manager->getShareByToken('validToken');
+    }
+
+    public function testGetShareByTokenPublicUploadDisabled(): void {
+        $this->config
+            ->expects($this->exactly(3))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_links', 'yes', 'yes'],
+                ['core', 'shareapi_allow_public_upload', 'yes', 'no'],
+                ['files_sharing', 'hide_disabled_user_shares', 'no', 'no'],
+            ]);
+
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+        $share->setSharedWith('sharedWith');
+        $folder = $this->createMock(\OC\Files\Node\Folder::class);
+        $share->setNode($folder);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('getShareByToken')
+            ->willReturn('validToken')
+            ->willReturn($share);
+
+        $res = $this->manager->getShareByToken('validToken');
+
+        $this->assertSame(\OCP\Constants::PERMISSION_READ, $res->getPermissions());
+    }
+
+    public function testCheckPasswordNoLinkShare(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $this->assertFalse($this->manager->checkPassword($share, 'password'));
+    }
+
+    public function testCheckPasswordNoPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $this->assertFalse($this->manager->checkPassword($share, 'password'));
+
+        $share->method('getPassword')->willReturn('password');
+        $this->assertFalse($this->manager->checkPassword($share, null));
+    }
+
+    public function testCheckPasswordInvalidPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $share->method('getPassword')->willReturn('password');
+
+        $this->hasher->method('verify')->with('invalidpassword', 'password', '')->willReturn(false);
+
+        $this->assertFalse($this->manager->checkPassword($share, 'invalidpassword'));
+    }
+
+    public function testCheckPasswordValidPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $share->method('getPassword')->willReturn('passwordHash');
+
+        $this->hasher->method('verify')->with('password', 'passwordHash', '')->willReturn(true);
+
+        $this->assertTrue($this->manager->checkPassword($share, 'password'));
+    }
+
+    public function testCheckPasswordUpdateShare(): void {
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_LINK)
+            ->setPassword('passwordHash');
+
+        $this->hasher->method('verify')->with('password', 'passwordHash', '')
+            ->willReturnCallback(function ($pass, $hash, &$newHash) {
+                $newHash = 'newHash';
+
+                return true;
+            });
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($this->callback(function (\OCP\Share\IShare $share) {
+                return $share->getPassword() === 'newHash';
+            }));
+
+        $this->assertTrue($this->manager->checkPassword($share, 'password'));
+    }
+
+
+    public function testUpdateShareCantChangeShareType(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Cannot change share type');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById'
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_GROUP);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+
+        $share = $this->manager->newShare();
+        $attrs = $this->manager->newShare()->newAttributes();
+        $attrs->setAttribute('app1', 'perm1', true);
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_USER);
+
+        $manager->updateShare($share);
+    }
+
+
+    public function testUpdateShareCantChangeRecipientForGroupShare(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Can only update recipient on user shares');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById'
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('origGroup');
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('newGroup');
+
+        $manager->updateShare($share);
+    }
+
+
+    public function testUpdateShareCantShareWithOwner(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Cannot share with the share owner');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById'
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('sharedWith');
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('newUser')
+            ->setShareOwner('newUser');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareUser(): void {
+        $this->userManager->expects($this->any())->method('userExists')->willReturn(true);
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'userCreateChecks',
+                'pathCreateChecks',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('origUser')
+            ->setPermissions(1);
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(100);
+        $node->method('getPath')->willReturn('/newUser/files/myPath');
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+
+        $share = $this->manager->newShare();
+        $attrs = $this->manager->newShare()->newAttributes();
+        $attrs->setAttribute('app1', 'perm1', true);
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('origUser')
+            ->setShareOwner('newUser')
+            ->setSharedBy('sharer')
+            ->setPermissions(31)
+            ->setAttributes($attrs)
+            ->setNode($node);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share)
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $this->rootFolder->method('getUserFolder')->with('newUser')->willReturnSelf();
+        $this->rootFolder->method('getRelativePath')->with('/newUser/files/myPath')->willReturn('/myPath');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener2, 'post');
+        $hookListener2->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'shareType' => IShare::TYPE_USER,
+            'shareWith' => 'origUser',
+            'uidOwner' => 'sharer',
+            'permissions' => 31,
+            'path' => '/myPath',
+            'attributes' => $attrs->toArray(),
+        ]);
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareGroup(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'groupCreateChecks',
+                'pathCreateChecks',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('origUser')
+            ->setPermissions(31);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+
+        $node = $this->createMock(File::class);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('origUser')
+            ->setShareOwner('owner')
+            ->setNode($node)
+            ->setPermissions(31);
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share)
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareLink(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'linkCreateChecks',
+                'pathCreateChecks',
+                'verifyPassword',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(15);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_LINK)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('password')
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(15);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('validateExpirationDateLink')->with($share);
+        $manager->expects($this->once())->method('verifyPassword')->with('password');
+
+        $this->hasher->expects($this->once())
+            ->method('hash')
+            ->with('password')
+            ->willReturn('hashed');
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share)
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'date' => $tomorrow,
+            'uidOwner' => 'owner',
+        ]);
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'uidOwner' => 'owner',
+            'token' => 'token',
+            'disabled' => false,
+        ]);
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareLinkEnableSendPasswordByTalkWithNoPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'linkCreateChecks',
+                'pathCreateChecks',
+                'verifyPassword',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(15);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_LINK)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword(null)
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(15);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('linkCreateChecks')->with($share);
+        $manager->expects($this->never())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMail(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('password')
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('verifyPassword')->with('password');
+        $manager->expects($this->once())->method('pathCreateChecks')->with($file);
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->once())->method('validateExpirationDateLink');
+
+        $this->hasher->expects($this->once())
+            ->method('hash')
+            ->with('password')
+            ->willReturn('hashed');
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share, 'password')
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'date' => $tomorrow,
+            'uidOwner' => 'owner',
+        ]);
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'uidOwner' => 'owner',
+            'token' => 'token',
+            'disabled' => false,
+        ]);
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMailEnableSendPasswordByTalk(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword(null)
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('verifyPassword')->with('password');
+        $manager->expects($this->once())->method('pathCreateChecks')->with($file);
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->once())->method('validateExpirationDateLink');
+
+        $this->hasher->expects($this->once())
+            ->method('hash')
+            ->with('password')
+            ->willReturn('hashed');
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share, 'password')
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'date' => $tomorrow,
+            'uidOwner' => 'owner',
+        ]);
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'uidOwner' => 'owner',
+            'token' => 'token',
+            'disabled' => false,
+        ]);
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMailEnableSendPasswordByTalkWithDifferentPassword(): void {
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('anotherPasswordHash')
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('verifyPassword')->with('password');
+        $manager->expects($this->once())->method('pathCreateChecks')->with($file);
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->once())->method('validateExpirationDateLink');
+
+        $this->hasher->expects($this->once())
+            ->method('verify')
+            ->with('password', 'anotherPasswordHash')
+            ->willReturn(false);
+
+        $this->hasher->expects($this->once())
+            ->method('hash')
+            ->with('password')
+            ->willReturn('hashed');
+
+        $this->defaultProvider->expects($this->once())
+            ->method('update')
+            ->with($share, 'password')
+            ->willReturn($share);
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'date' => $tomorrow,
+            'uidOwner' => 'owner',
+        ]);
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->once())->method('post')->with([
+            'itemType' => 'file',
+            'itemSource' => 100,
+            'uidOwner' => 'owner',
+            'token' => 'token',
+            'disabled' => false,
+        ]);
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMailEnableSendPasswordByTalkWithNoPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword(null)
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword(null)
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->never())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the password is empty, we have nothing to hash
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+
+    public function testUpdateShareMailEnableSendPasswordByTalkRemovingPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword(null)
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the password is empty, we have nothing to hash
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+
+    public function testUpdateShareMailEnableSendPasswordByTalkRemovingPasswordWithEmptyString(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot enable sending the password by Talk with an empty password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->once())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the password is empty, we have nothing to hash
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+
+    public function testUpdateShareMailEnableSendPasswordByTalkWithPreviousPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot enable sending the password by Talk without setting a new password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(false);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->never())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the old & new passwords are the same, we don't do anything
+        $this->hasher->expects($this->never())
+            ->method('verify');
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMailDisableSendPasswordByTalkWithPreviousPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot disable sending the password by Talk without setting a new password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(true);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(false)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->never())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the old & new passwords are the same, we don't do anything
+        $this->hasher->expects($this->never())
+            ->method('verify');
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
+
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
+
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
+
+        $manager->updateShare($share);
+    }
+
+    public function testUpdateShareMailDisableSendPasswordByTalkWithoutChangingPassword(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot disable sending the password by Talk without setting a new password');
+
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'canShare',
+                'getShareById',
+                'generalCreateChecks',
+                'verifyPassword',
+                'pathCreateChecks',
+                'linkCreateChecks',
+                'validateExpirationDateLink',
+            ])
+            ->getMock();
+
+        $originalShare = $this->manager->newShare();
+        $originalShare->setShareType(IShare::TYPE_EMAIL)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL)
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(true);
+
+        $tomorrow = new \DateTime();
+        $tomorrow->setTime(0, 0, 0);
+        $tomorrow->add(new \DateInterval('P1D'));
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(100);
+
+        $share = $this->manager->newShare();
+        $share->setProviderId('foo')
+            ->setId('42')
+            ->setShareType(IShare::TYPE_EMAIL)
+            ->setToken('token')
+            ->setSharedBy('owner')
+            ->setShareOwner('owner')
+            ->setPassword('passwordHash')
+            ->setSendPasswordByTalk(false)
+            ->setExpirationDate($tomorrow)
+            ->setNode($file)
+            ->setPermissions(\OCP\Constants::PERMISSION_ALL);
+
+        $manager->expects($this->once())->method('canShare')->willReturn(true);
+        $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
+        $manager->expects($this->once())->method('generalCreateChecks')->with($share);
+        $manager->expects($this->never())->method('verifyPassword');
+        $manager->expects($this->never())->method('pathCreateChecks');
+        $manager->expects($this->once())->method('linkCreateChecks');
+        $manager->expects($this->never())->method('validateExpirationDateLink');
+
+        // If the old & new passwords are the same, we don't do anything
+        $this->hasher->expects($this->never())
+            ->method('verify');
+        $this->hasher->expects($this->never())
+            ->method('hash');
+
+        $this->defaultProvider->expects($this->never())
+            ->method('update');
+
+        $hookListener = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListener, 'post');
+        $hookListener->expects($this->never())->method('post');
 
-		$hookListener2 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
-		$hookListener2->expects($this->never())->method('post');
+        $hookListener2 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_password', $hookListener2, 'post');
+        $hookListener2->expects($this->never())->method('post');
 
-		$hookListener3 = $this->createMock(DummyShareManagerListener::class);
-		\OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
-		$hookListener3->expects($this->never())->method('post');
+        $hookListener3 = $this->createMock(DummyShareManagerListener::class);
+        \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListener3, 'post');
+        $hookListener3->expects($this->never())->method('post');
 
-		$manager->updateShare($share);
-	}
+        $manager->updateShare($share);
+    }
 
-	public function testMoveShareLink(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Cannot change target of link share');
+    public function testMoveShareLink(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot change target of link share');
 
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_LINK);
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_LINK);
 
-		$recipient = $this->createMock(IUser::class);
+        $recipient = $this->createMock(IUser::class);
 
-		$this->manager->moveShare($share, $recipient);
-	}
+        $this->manager->moveShare($share, $recipient);
+    }
 
 
-	public function testMoveShareUserNotRecipient(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Invalid share recipient');
+    public function testMoveShareUserNotRecipient(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid share recipient');
 
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_USER);
-
-		$share->setSharedWith('sharedWith');
-
-		$this->manager->moveShare($share, 'recipient');
-	}
-
-	public function testMoveShareUser(): void {
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setId('42')
-			->setProviderId('foo');
-
-		$share->setSharedWith('recipient');
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_USER);
+
+        $share->setSharedWith('sharedWith');
+
+        $this->manager->moveShare($share, 'recipient');
+    }
+
+    public function testMoveShareUser(): void {
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setId('42')
+            ->setProviderId('foo');
+
+        $share->setSharedWith('recipient');
 
-		$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
+        $this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
 
-		$this->manager->moveShare($share, 'recipient');
-		$this->addToAssertionCount(1);
-	}
+        $this->manager->moveShare($share, 'recipient');
+        $this->addToAssertionCount(1);
+    }
 
 
-	public function testMoveShareGroupNotRecipient(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Invalid share recipient');
+    public function testMoveShareGroupNotRecipient(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid share recipient');
 
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_GROUP);
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_GROUP);
 
-		$sharedWith = $this->createMock(IGroup::class);
-		$share->setSharedWith('shareWith');
+        $sharedWith = $this->createMock(IGroup::class);
+        $share->setSharedWith('shareWith');
 
-		$recipient = $this->createMock(IUser::class);
-		$sharedWith->method('inGroup')->with($recipient)->willReturn(false);
+        $recipient = $this->createMock(IUser::class);
+        $sharedWith->method('inGroup')->with($recipient)->willReturn(false);
 
-		$this->groupManager->method('get')->with('shareWith')->willReturn($sharedWith);
-		$this->userManager->method('get')->with('recipient')->willReturn($recipient);
-
-		$this->manager->moveShare($share, 'recipient');
-	}
+        $this->groupManager->method('get')->with('shareWith')->willReturn($sharedWith);
+        $this->userManager->method('get')->with('recipient')->willReturn($recipient);
+
+        $this->manager->moveShare($share, 'recipient');
+    }
 
 
-	public function testMoveShareGroupNull(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Group "shareWith" does not exist');
+    public function testMoveShareGroupNull(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Group "shareWith" does not exist');
 
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_GROUP);
-		$share->setSharedWith('shareWith');
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_GROUP);
+        $share->setSharedWith('shareWith');
 
-		$recipient = $this->createMock(IUser::class);
+        $recipient = $this->createMock(IUser::class);
 
-		$this->groupManager->method('get')->with('shareWith')->willReturn(null);
-		$this->userManager->method('get')->with('recipient')->willReturn($recipient);
+        $this->groupManager->method('get')->with('shareWith')->willReturn(null);
+        $this->userManager->method('get')->with('recipient')->willReturn($recipient);
 
-		$this->manager->moveShare($share, 'recipient');
-	}
+        $this->manager->moveShare($share, 'recipient');
+    }
 
-	public function testMoveShareGroup(): void {
-		$share = $this->manager->newShare();
-		$share->setShareType(IShare::TYPE_GROUP)
-			->setId('42')
-			->setProviderId('foo');
+    public function testMoveShareGroup(): void {
+        $share = $this->manager->newShare();
+        $share->setShareType(IShare::TYPE_GROUP)
+            ->setId('42')
+            ->setProviderId('foo');
 
-		$group = $this->createMock(IGroup::class);
-		$share->setSharedWith('group');
+        $group = $this->createMock(IGroup::class);
+        $share->setSharedWith('group');
 
-		$recipient = $this->createMock(IUser::class);
-		$group->method('inGroup')->with($recipient)->willReturn(true);
+        $recipient = $this->createMock(IUser::class);
+        $group->method('inGroup')->with($recipient)->willReturn(true);
 
-		$this->groupManager->method('get')->with('group')->willReturn($group);
-		$this->userManager->method('get')->with('recipient')->willReturn($recipient);
+        $this->groupManager->method('get')->with('group')->willReturn($group);
+        $this->userManager->method('get')->with('recipient')->willReturn($recipient);
 
-		$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
+        $this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
 
-		$this->manager->moveShare($share, 'recipient');
-		$this->addToAssertionCount(1);
-	}
+        $this->manager->moveShare($share, 'recipient');
+        $this->addToAssertionCount(1);
+    }
 
-	/**
-	 * @dataProvider dataTestShareProviderExists
-	 */
-	public function testShareProviderExists($shareType, $expected): void {
-		$factory = $this->getMockBuilder('OCP\Share\IProviderFactory')->getMock();
-		$factory->expects($this->any())->method('getProviderForType')
-			->willReturnCallback(function ($id) {
-				if ($id === IShare::TYPE_USER) {
-					return true;
-				}
-				throw new Exception\ProviderException();
-			});
+    /**
+     * @dataProvider dataTestShareProviderExists
+     */
+    public function testShareProviderExists($shareType, $expected): void {
+        $factory = $this->getMockBuilder('OCP\Share\IProviderFactory')->getMock();
+        $factory->expects($this->any())->method('getProviderForType')
+            ->willReturnCallback(function ($id) {
+                if ($id === IShare::TYPE_USER) {
+                    return true;
+                }
+                throw new Exception\ProviderException();
+            });
 
-		$manager = $this->createManager($factory);
-		$this->assertSame($expected,
-			$manager->shareProviderExists($shareType)
-		);
-	}
+        $manager = $this->createManager($factory);
+        $this->assertSame($expected,
+            $manager->shareProviderExists($shareType)
+        );
+    }
 
-	public static function dataTestShareProviderExists() {
-		return [
-			[IShare::TYPE_USER, true],
-			[42, false],
-		];
-	}
+    public static function dataTestShareProviderExists() {
+        return [
+            [IShare::TYPE_USER, true],
+            [42, false],
+        ];
+    }
 
-	public function testGetSharesInFolder(): void {
-		$factory = new DummyFactory2($this->createMock(IServerContainer::class));
+    public function testGetSharesInFolder(): void {
+        $factory = new DummyFactory2($this->createMock(IServerContainer::class));
 
-		$manager = $this->createManager($factory);
+        $manager = $this->createManager($factory);
 
-		$factory->setProvider($this->defaultProvider);
-		$extraProvider = $this->createMock(IShareProvider::class);
-		$factory->setSecondProvider($extraProvider);
+        $factory->setProvider($this->defaultProvider);
+        $extraProvider = $this->createMock(IShareProvider::class);
+        $factory->setSecondProvider($extraProvider);
 
-		$share1 = $this->createMock(IShare::class);
-		$share2 = $this->createMock(IShare::class);
-		$share3 = $this->createMock(IShare::class);
-		$share4 = $this->createMock(IShare::class);
-
-		$folder = $this->createMock(Folder::class);
+        $share1 = $this->createMock(IShare::class);
+        $share2 = $this->createMock(IShare::class);
+        $share3 = $this->createMock(IShare::class);
+        $share4 = $this->createMock(IShare::class);
+
+        $folder = $this->createMock(Folder::class);
 
-		$this->defaultProvider->method('getSharesInFolder')
-			->with(
-				$this->equalTo('user'),
-				$this->equalTo($folder),
-				$this->equalTo(false)
-			)->willReturn([
-				1 => [$share1],
-				2 => [$share2],
-			]);
-
-		$extraProvider->method('getSharesInFolder')
-			->with(
-				$this->equalTo('user'),
-				$this->equalTo($folder),
-				$this->equalTo(false)
-			)->willReturn([
-				2 => [$share3],
-				3 => [$share4],
-			]);
-
-		$result = $manager->getSharesInFolder('user', $folder, false);
-
-		$expects = [
-			1 => [$share1],
-			2 => [$share2, $share3],
-			3 => [$share4],
-		];
-
-		$this->assertSame($expects, $result);
-	}
-
-	public function testGetSharesInFolderOwnerless(): void {
-		$factory = new DummyFactory2($this->createMock(IServerContainer::class));
-
-		$manager = $this->createManager($factory);
-
-		$factory->setProvider($this->defaultProvider);
-		$extraProvider = $this->createMock(IShareProvider::class);
-		$factory->setSecondProvider($extraProvider);
-
-		$share1 = $this->createMock(IShare::class);
-		$share2 = $this->createMock(IShare::class);
-
-		$mount = $this->createMock(IShareOwnerlessMount::class);
-
-		$file = $this->createMock(File::class);
-		$file
-			->method('getId')
-			->willReturn(1);
-
-		$folder = $this->createMock(Folder::class);
-		$folder
-			->method('getMountPoint')
-			->willReturn($mount);
-		$folder
-			->method('getDirectoryListing')
-			->willReturn([$file]);
-
-		$this->defaultProvider
-			->method('getSharesByPath')
-			->with($file)
-			->willReturn([$share1]);
-
-		$extraProvider
-			->method('getSharesByPath')
-			->with($file)
-			->willReturn([$share2]);
-
-		$this->assertSame([
-			1 => [$share1, $share2],
-		], $manager->getSharesInFolder('user', $folder));
-	}
-
-
-	public function testGetAccessList(): void {
-		$factory = new DummyFactory2($this->createMock(IServerContainer::class));
-
-		$manager = $this->createManager($factory);
-
-		$factory->setProvider($this->defaultProvider);
-		$extraProvider = $this->createMock(IShareProvider::class);
-		$factory->setSecondProvider($extraProvider);
-
-		$nodeOwner = $this->createMock(IUser::class);
-		$nodeOwner->expects($this->once())
-			->method('getUID')
-			->willReturn('user1');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($nodeOwner);
-		$node->method('getId')
-			->willReturn(42);
-
-		$userFolder = $this->createMock(Folder::class);
-		$file = $this->createMock(File::class);
-		$folder = $this->createMock(Folder::class);
-
-		$owner = $this->createMock(IUser::class);
-		$owner->expects($this->once())
-			->method('getUID')
-			->willReturn('owner');
-
-		$file->method('getParent')
-			->willReturn($folder);
-		$file->method('getPath')
-			->willReturn('/owner/files/folder/file');
-		$file->method('getOwner')
-			->willReturn($owner);
-		$file->method('getId')
-			->willReturn(23);
-		$folder->method('getParent')
-			->willReturn($userFolder);
-		$folder->method('getPath')
-			->willReturn('/owner/files/folder');
-		$userFolder->method('getFirstNodeById')
-			->with($this->equalTo(42))
-			->willReturn($file);
-		$userFolder->method('getPath')
-			->willReturn('/user1/files');
-
-		$this->userManager->method('userExists')
-			->with($this->equalTo('user1'))
-			->willReturn(true);
-
-		$this->defaultProvider->method('getAccessList')
-			->with(
-				$this->equalTo([$file, $folder]),
-				false
-			)
-			->willReturn([
-				'users' => [
-					'user1',
-					'user2',
-					'user3',
-					'123456',
-				],
-				'public' => true,
-			]);
-
-		$extraProvider->method('getAccessList')
-			->with(
-				$this->equalTo([$file, $folder]),
-				false
-			)
-			->willReturn([
-				'users' => [
-					'user3',
-					'user4',
-					'user5',
-					'234567',
-				],
-				'remote' => true,
-			]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo('user1'))
-			->willReturn($userFolder);
-
-		$expected = [
-			'users' => ['owner', 'user1', 'user2', 'user3', '123456','user4', 'user5', '234567'],
-			'remote' => true,
-			'public' => true,
-		];
-
-		$result = $manager->getAccessList($node, true, false);
-
-		$this->assertSame($expected['public'], $result['public']);
-		$this->assertSame($expected['remote'], $result['remote']);
-		$this->assertSame($expected['users'], $result['users']);
-	}
-
-	public function testGetAccessListWithCurrentAccess(): void {
-		$factory = new DummyFactory2($this->createMock(IServerContainer::class));
-
-		$manager = $this->createManager($factory);
-
-		$factory->setProvider($this->defaultProvider);
-		$extraProvider = $this->createMock(IShareProvider::class);
-		$factory->setSecondProvider($extraProvider);
-
-		$nodeOwner = $this->createMock(IUser::class);
-		$nodeOwner->expects($this->once())
-			->method('getUID')
-			->willReturn('user1');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($nodeOwner);
-		$node->method('getId')
-			->willReturn(42);
-
-		$userFolder = $this->createMock(Folder::class);
-		$file = $this->createMock(File::class);
-
-		$owner = $this->createMock(IUser::class);
-		$owner->expects($this->once())
-			->method('getUID')
-			->willReturn('owner');
-		$folder = $this->createMock(Folder::class);
-
-		$file->method('getParent')
-			->willReturn($folder);
-		$file->method('getPath')
-			->willReturn('/owner/files/folder/file');
-		$file->method('getOwner')
-			->willReturn($owner);
-		$file->method('getId')
-			->willReturn(23);
-		$folder->method('getParent')
-			->willReturn($userFolder);
-		$folder->method('getPath')
-			->willReturn('/owner/files/folder');
-		$userFolder->method('getFirstNodeById')
-			->with($this->equalTo(42))
-			->willReturn($file);
-		$userFolder->method('getPath')
-			->willReturn('/user1/files');
-
-		$this->userManager->method('userExists')
-			->with($this->equalTo('user1'))
-			->willReturn(true);
-
-		$this->defaultProvider->method('getAccessList')
-			->with(
-				$this->equalTo([$file, $folder]),
-				true
-			)
-			->willReturn([
-				'users' => [
-					'user1' => [],
-					'user2' => [],
-					'user3' => [],
-					'123456' => [],
-				],
-				'public' => true,
-			]);
-
-		$extraProvider->method('getAccessList')
-			->with(
-				$this->equalTo([$file, $folder]),
-				true
-			)
-			->willReturn([
-				'users' => [
-					'user3' => [],
-					'user4' => [],
-					'user5' => [],
-					'234567' => [],
-				],
-				'remote' => [
-					'remote1',
-				],
-			]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo('user1'))
-			->willReturn($userFolder);
-
-		$expected = [
-			'users' => [
-				'owner' => [
-					'node_id' => 23,
-					'node_path' => '/folder/file'
-				]
-				, 'user1' => [], 'user2' => [], 'user3' => [], '123456' => [], 'user4' => [], 'user5' => [], '234567' => []],
-			'remote' => [
-				'remote1',
-			],
-			'public' => true,
-		];
-
-		$result = $manager->getAccessList($node, true, true);
-
-		$this->assertSame($expected['public'], $result['public']);
-		$this->assertSame($expected['remote'], $result['remote']);
-		$this->assertSame($expected['users'], $result['users']);
-	}
-
-	public function testGetAllShares(): void {
-		$factory = new DummyFactory2($this->createMock(IServerContainer::class));
-
-		$manager = $this->createManager($factory);
-
-		$factory->setProvider($this->defaultProvider);
-		$extraProvider = $this->createMock(IShareProvider::class);
-		$factory->setSecondProvider($extraProvider);
-
-		$share1 = $this->createMock(IShare::class);
-		$share2 = $this->createMock(IShare::class);
-		$share3 = $this->createMock(IShare::class);
-		$share4 = $this->createMock(IShare::class);
-
-		$this->defaultProvider->method('getAllShares')
-			->willReturnCallback(function () use ($share1, $share2) {
-				yield $share1;
-				yield $share2;
-			});
-		$extraProvider->method('getAllShares')
-			->willReturnCallback(function () use ($share3, $share4) {
-				yield $share3;
-				yield $share4;
-			});
-
-		// "yield from", used in "getAllShares()", does not reset the keys, so
-		// "use_keys" has to be disabled to collect all the values while
-		// ignoring the keys returned by the generator.
-		$result = iterator_to_array($manager->getAllShares(), $use_keys = false);
-
-		$expects = [$share1, $share2, $share3, $share4];
-
-		$this->assertSame($expects, $result);
-	}
-
-	public static function dataCurrentUserCanEnumerateTargetUser(): array {
-		return [
-			'Full match guest' => [true, true, false, false, false, false, false, true],
-			'Full match user' => [false, true, false, false, false, false, false, true],
-			'Enumeration off guest' => [true, false, false, false, false, false, false, false],
-			'Enumeration off user' => [false, false, false, false, false, false, false, false],
-			'Enumeration guest' => [true, false, true, false, false, false, false, true],
-			'Enumeration user' => [false, false, true, false, false, false, false, true],
-
-			// Restricted enumerations guests never works
-			'Guest phone' => [true, false, true, true, false, false, false, false],
-			'Guest group' => [true, false, true, false, true, false, false, false],
-			'Guest both' => [true, false, true, true, true, false, false, false],
-
-			// Restricted enumerations users
-			'User phone but not known' => [false, false, true, true, false, false, false, false],
-			'User phone known' => [false, false, true, true, false, true, false, true],
-			'User group but no match' => [false, false, true, false, true, false, false, false],
-			'User group with match' => [false, false, true, false, true, false, true, true],
-		];
-	}
-
-	/**
-	 * @dataProvider dataCurrentUserCanEnumerateTargetUser
-	 * @param bool $expected
-	 */
-	public function testCurrentUserCanEnumerateTargetUser(bool $currentUserIsGuest, bool $allowEnumerationFullMatch, bool $allowEnumeration, bool $limitEnumerationToPhone, bool $limitEnumerationToGroups, bool $isKnownToUser, bool $haveCommonGroup, bool $expected): void {
-		/** @var IManager|MockObject $manager */
-		$manager = $this->createManagerMock()
-			->onlyMethods([
-				'allowEnumerationFullMatch',
-				'allowEnumeration',
-				'limitEnumerationToPhone',
-				'limitEnumerationToGroups',
-			])
-			->getMock();
-
-		$manager->method('allowEnumerationFullMatch')
-			->willReturn($allowEnumerationFullMatch);
-		$manager->method('allowEnumeration')
-			->willReturn($allowEnumeration);
-		$manager->method('limitEnumerationToPhone')
-			->willReturn($limitEnumerationToPhone);
-		$manager->method('limitEnumerationToGroups')
-			->willReturn($limitEnumerationToGroups);
-
-		$this->knownUserService->method('isKnownToUser')
-			->with('current', 'target')
-			->willReturn($isKnownToUser);
-
-		$currentUser = null;
-		if (!$currentUserIsGuest) {
-			$currentUser = $this->createMock(IUser::class);
-			$currentUser->method('getUID')
-				->willReturn('current');
-		}
-		$targetUser = $this->createMock(IUser::class);
-		$targetUser->method('getUID')
-			->willReturn('target');
-
-		if ($haveCommonGroup) {
-			$this->groupManager->method('getUserGroupIds')
-				->willReturnMap([
-					[$targetUser, ['gid1', 'gid2']],
-					[$currentUser, ['gid2', 'gid3']],
-				]);
-		} else {
-			$this->groupManager->method('getUserGroupIds')
-				->willReturnMap([
-					[$targetUser, ['gid1', 'gid2']],
-					[$currentUser, ['gid3', 'gid4']],
-				]);
-		}
-
-		$this->assertSame($expected, $manager->currentUserCanEnumerateTargetUser($currentUser, $targetUser));
-	}
+        $this->defaultProvider->method('getSharesInFolder')
+            ->with(
+                $this->equalTo('user'),
+                $this->equalTo($folder),
+                $this->equalTo(false)
+            )->willReturn([
+                1 => [$share1],
+                2 => [$share2],
+            ]);
+
+        $extraProvider->method('getSharesInFolder')
+            ->with(
+                $this->equalTo('user'),
+                $this->equalTo($folder),
+                $this->equalTo(false)
+            )->willReturn([
+                2 => [$share3],
+                3 => [$share4],
+            ]);
+
+        $result = $manager->getSharesInFolder('user', $folder, false);
+
+        $expects = [
+            1 => [$share1],
+            2 => [$share2, $share3],
+            3 => [$share4],
+        ];
+
+        $this->assertSame($expects, $result);
+    }
+
+    public function testGetSharesInFolderOwnerless(): void {
+        $factory = new DummyFactory2($this->createMock(IServerContainer::class));
+
+        $manager = $this->createManager($factory);
+
+        $factory->setProvider($this->defaultProvider);
+        $extraProvider = $this->createMock(IShareProvider::class);
+        $factory->setSecondProvider($extraProvider);
+
+        $share1 = $this->createMock(IShare::class);
+        $share2 = $this->createMock(IShare::class);
+
+        $mount = $this->createMock(IShareOwnerlessMount::class);
+
+        $file = $this->createMock(File::class);
+        $file
+            ->method('getId')
+            ->willReturn(1);
+
+        $folder = $this->createMock(Folder::class);
+        $folder
+            ->method('getMountPoint')
+            ->willReturn($mount);
+        $folder
+            ->method('getDirectoryListing')
+            ->willReturn([$file]);
+
+        $this->defaultProvider
+            ->method('getSharesByPath')
+            ->with($file)
+            ->willReturn([$share1]);
+
+        $extraProvider
+            ->method('getSharesByPath')
+            ->with($file)
+            ->willReturn([$share2]);
+
+        $this->assertSame([
+            1 => [$share1, $share2],
+        ], $manager->getSharesInFolder('user', $folder));
+    }
+
+
+    public function testGetAccessList(): void {
+        $factory = new DummyFactory2($this->createMock(IServerContainer::class));
+
+        $manager = $this->createManager($factory);
+
+        $factory->setProvider($this->defaultProvider);
+        $extraProvider = $this->createMock(IShareProvider::class);
+        $factory->setSecondProvider($extraProvider);
+
+        $nodeOwner = $this->createMock(IUser::class);
+        $nodeOwner->expects($this->once())
+            ->method('getUID')
+            ->willReturn('user1');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($nodeOwner);
+        $node->method('getId')
+            ->willReturn(42);
+
+        $userFolder = $this->createMock(Folder::class);
+        $file = $this->createMock(File::class);
+        $folder = $this->createMock(Folder::class);
+
+        $owner = $this->createMock(IUser::class);
+        $owner->expects($this->once())
+            ->method('getUID')
+            ->willReturn('owner');
+
+        $file->method('getParent')
+            ->willReturn($folder);
+        $file->method('getPath')
+            ->willReturn('/owner/files/folder/file');
+        $file->method('getOwner')
+            ->willReturn($owner);
+        $file->method('getId')
+            ->willReturn(23);
+        $folder->method('getParent')
+            ->willReturn($userFolder);
+        $folder->method('getPath')
+            ->willReturn('/owner/files/folder');
+        $userFolder->method('getFirstNodeById')
+            ->with($this->equalTo(42))
+            ->willReturn($file);
+        $userFolder->method('getPath')
+            ->willReturn('/user1/files');
+
+        $this->userManager->method('userExists')
+            ->with($this->equalTo('user1'))
+            ->willReturn(true);
+
+        $this->defaultProvider->method('getAccessList')
+            ->with(
+                $this->equalTo([$file, $folder]),
+                false
+            )
+            ->willReturn([
+                'users' => [
+                    'user1',
+                    'user2',
+                    'user3',
+                    '123456',
+                ],
+                'public' => true,
+            ]);
+
+        $extraProvider->method('getAccessList')
+            ->with(
+                $this->equalTo([$file, $folder]),
+                false
+            )
+            ->willReturn([
+                'users' => [
+                    'user3',
+                    'user4',
+                    'user5',
+                    '234567',
+                ],
+                'remote' => true,
+            ]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo('user1'))
+            ->willReturn($userFolder);
+
+        $expected = [
+            'users' => ['owner', 'user1', 'user2', 'user3', '123456','user4', 'user5', '234567'],
+            'remote' => true,
+            'public' => true,
+        ];
+
+        $result = $manager->getAccessList($node, true, false);
+
+        $this->assertSame($expected['public'], $result['public']);
+        $this->assertSame($expected['remote'], $result['remote']);
+        $this->assertSame($expected['users'], $result['users']);
+    }
+
+    public function testGetAccessListWithCurrentAccess(): void {
+        $factory = new DummyFactory2($this->createMock(IServerContainer::class));
+
+        $manager = $this->createManager($factory);
+
+        $factory->setProvider($this->defaultProvider);
+        $extraProvider = $this->createMock(IShareProvider::class);
+        $factory->setSecondProvider($extraProvider);
+
+        $nodeOwner = $this->createMock(IUser::class);
+        $nodeOwner->expects($this->once())
+            ->method('getUID')
+            ->willReturn('user1');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($nodeOwner);
+        $node->method('getId')
+            ->willReturn(42);
+
+        $userFolder = $this->createMock(Folder::class);
+        $file = $this->createMock(File::class);
+
+        $owner = $this->createMock(IUser::class);
+        $owner->expects($this->once())
+            ->method('getUID')
+            ->willReturn('owner');
+        $folder = $this->createMock(Folder::class);
+
+        $file->method('getParent')
+            ->willReturn($folder);
+        $file->method('getPath')
+            ->willReturn('/owner/files/folder/file');
+        $file->method('getOwner')
+            ->willReturn($owner);
+        $file->method('getId')
+            ->willReturn(23);
+        $folder->method('getParent')
+            ->willReturn($userFolder);
+        $folder->method('getPath')
+            ->willReturn('/owner/files/folder');
+        $userFolder->method('getFirstNodeById')
+            ->with($this->equalTo(42))
+            ->willReturn($file);
+        $userFolder->method('getPath')
+            ->willReturn('/user1/files');
+
+        $this->userManager->method('userExists')
+            ->with($this->equalTo('user1'))
+            ->willReturn(true);
+
+        $this->defaultProvider->method('getAccessList')
+            ->with(
+                $this->equalTo([$file, $folder]),
+                true
+            )
+            ->willReturn([
+                'users' => [
+                    'user1' => [],
+                    'user2' => [],
+                    'user3' => [],
+                    '123456' => [],
+                ],
+                'public' => true,
+            ]);
+
+        $extraProvider->method('getAccessList')
+            ->with(
+                $this->equalTo([$file, $folder]),
+                true
+            )
+            ->willReturn([
+                'users' => [
+                    'user3' => [],
+                    'user4' => [],
+                    'user5' => [],
+                    '234567' => [],
+                ],
+                'remote' => [
+                    'remote1',
+                ],
+            ]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo('user1'))
+            ->willReturn($userFolder);
+
+        $expected = [
+            'users' => [
+                'owner' => [
+                    'node_id' => 23,
+                    'node_path' => '/folder/file'
+                ]
+                , 'user1' => [], 'user2' => [], 'user3' => [], '123456' => [], 'user4' => [], 'user5' => [], '234567' => []],
+            'remote' => [
+                'remote1',
+            ],
+            'public' => true,
+        ];
+
+        $result = $manager->getAccessList($node, true, true);
+
+        $this->assertSame($expected['public'], $result['public']);
+        $this->assertSame($expected['remote'], $result['remote']);
+        $this->assertSame($expected['users'], $result['users']);
+    }
+
+    public function testGetAllShares(): void {
+        $factory = new DummyFactory2($this->createMock(IServerContainer::class));
+
+        $manager = $this->createManager($factory);
+
+        $factory->setProvider($this->defaultProvider);
+        $extraProvider = $this->createMock(IShareProvider::class);
+        $factory->setSecondProvider($extraProvider);
+
+        $share1 = $this->createMock(IShare::class);
+        $share2 = $this->createMock(IShare::class);
+        $share3 = $this->createMock(IShare::class);
+        $share4 = $this->createMock(IShare::class);
+
+        $this->defaultProvider->method('getAllShares')
+            ->willReturnCallback(function () use ($share1, $share2) {
+                yield $share1;
+                yield $share2;
+            });
+        $extraProvider->method('getAllShares')
+            ->willReturnCallback(function () use ($share3, $share4) {
+                yield $share3;
+                yield $share4;
+            });
+
+        // "yield from", used in "getAllShares()", does not reset the keys, so
+        // "use_keys" has to be disabled to collect all the values while
+        // ignoring the keys returned by the generator.
+        $result = iterator_to_array($manager->getAllShares(), $use_keys = false);
+
+        $expects = [$share1, $share2, $share3, $share4];
+
+        $this->assertSame($expects, $result);
+    }
+
+    public static function dataCurrentUserCanEnumerateTargetUser(): array {
+        return [
+            'Full match guest' => [true, true, false, false, false, false, false, true],
+            'Full match user' => [false, true, false, false, false, false, false, true],
+            'Enumeration off guest' => [true, false, false, false, false, false, false, false],
+            'Enumeration off user' => [false, false, false, false, false, false, false, false],
+            'Enumeration guest' => [true, false, true, false, false, false, false, true],
+            'Enumeration user' => [false, false, true, false, false, false, false, true],
+
+            // Restricted enumerations guests never works
+            'Guest phone' => [true, false, true, true, false, false, false, false],
+            'Guest group' => [true, false, true, false, true, false, false, false],
+            'Guest both' => [true, false, true, true, true, false, false, false],
+
+            // Restricted enumerations users
+            'User phone but not known' => [false, false, true, true, false, false, false, false],
+            'User phone known' => [false, false, true, true, false, true, false, true],
+            'User group but no match' => [false, false, true, false, true, false, false, false],
+            'User group with match' => [false, false, true, false, true, false, true, true],
+        ];
+    }
+
+    /**
+     * @dataProvider dataCurrentUserCanEnumerateTargetUser
+     * @param bool $expected
+     */
+    public function testCurrentUserCanEnumerateTargetUser(bool $currentUserIsGuest, bool $allowEnumerationFullMatch, bool $allowEnumeration, bool $limitEnumerationToPhone, bool $limitEnumerationToGroups, bool $isKnownToUser, bool $haveCommonGroup, bool $expected): void {
+        /** @var IManager|MockObject $manager */
+        $manager = $this->createManagerMock()
+            ->onlyMethods([
+                'allowEnumerationFullMatch',
+                'allowEnumeration',
+                'limitEnumerationToPhone',
+                'limitEnumerationToGroups',
+            ])
+            ->getMock();
+
+        $manager->method('allowEnumerationFullMatch')
+            ->willReturn($allowEnumerationFullMatch);
+        $manager->method('allowEnumeration')
+            ->willReturn($allowEnumeration);
+        $manager->method('limitEnumerationToPhone')
+            ->willReturn($limitEnumerationToPhone);
+        $manager->method('limitEnumerationToGroups')
+            ->willReturn($limitEnumerationToGroups);
+
+        $this->knownUserService->method('isKnownToUser')
+            ->with('current', 'target')
+            ->willReturn($isKnownToUser);
+
+        $currentUser = null;
+        if (!$currentUserIsGuest) {
+            $currentUser = $this->createMock(IUser::class);
+            $currentUser->method('getUID')
+                ->willReturn('current');
+        }
+        $targetUser = $this->createMock(IUser::class);
+        $targetUser->method('getUID')
+            ->willReturn('target');
+
+        if ($haveCommonGroup) {
+            $this->groupManager->method('getUserGroupIds')
+                ->willReturnMap([
+                    [$targetUser, ['gid1', 'gid2']],
+                    [$currentUser, ['gid2', 'gid3']],
+                ]);
+        } else {
+            $this->groupManager->method('getUserGroupIds')
+                ->willReturnMap([
+                    [$targetUser, ['gid1', 'gid2']],
+                    [$currentUser, ['gid3', 'gid4']],
+                ]);
+        }
+
+        $this->assertSame($expected, $manager->currentUserCanEnumerateTargetUser($currentUser, $targetUser));
+    }
 }
 
 class DummyFactory implements IProviderFactory {
-	/** @var IShareProvider */
-	protected $provider;
-
-	public function __construct(\OCP\IServerContainer $serverContainer) {
-	}
-
-	/**
-	 * @param IShareProvider $provider
-	 */
-	public function setProvider($provider) {
-		$this->provider = $provider;
-	}
-
-	/**
-	 * @param string $id
-	 * @return IShareProvider
-	 */
-	public function getProvider($id) {
-		return $this->provider;
-	}
-
-	/**
-	 * @param int $shareType
-	 * @return IShareProvider
-	 */
-	public function getProviderForType($shareType) {
-		return $this->provider;
-	}
-
-	/**
-	 * @return IShareProvider[]
-	 */
-	public function getAllProviders() {
-		return [$this->provider];
-	}
-
-	public function registerProvider(string $shareProvier): void {
-	}
+    /** @var IShareProvider */
+    protected $provider;
+
+    public function __construct(\OCP\IServerContainer $serverContainer) {
+    }
+
+    /**
+     * @param IShareProvider $provider
+     */
+    public function setProvider($provider) {
+        $this->provider = $provider;
+    }
+
+    /**
+     * @param string $id
+     * @return IShareProvider
+     */
+    public function getProvider($id) {
+        return $this->provider;
+    }
+
+    /**
+     * @param int $shareType
+     * @return IShareProvider
+     */
+    public function getProviderForType($shareType) {
+        return $this->provider;
+    }
+
+    /**
+     * @return IShareProvider[]
+     */
+    public function getAllProviders() {
+        return [$this->provider];
+    }
+
+    public function registerProvider(string $shareProvier): void {
+    }
 }
 
 class DummyFactory2 extends DummyFactory {
-	/** @var IShareProvider */
-	private $provider2;
-
-	/**
-	 * @param IShareProvider $provider
-	 */
-	public function setSecondProvider($provider) {
-		$this->provider2 = $provider;
-	}
-
-	public function getAllProviders() {
-		return [$this->provider, $this->provider2];
-	}
-
-	public function registerProvider(string $shareProvier): void {
-	}
+    /** @var IShareProvider */
+    private $provider2;
+
+    /**
+     * @param IShareProvider $provider
+     */
+    public function setSecondProvider($provider) {
+        $this->provider2 = $provider;
+    }
+
+    public function getAllProviders() {
+        return [$this->provider, $this->provider2];
+    }
+
+    public function registerProvider(string $shareProvier): void {
+    }
 }

Spacing +47 added lines, -47 removed lines

@@ -145,11 +145,11 @@ 
 		$this->l10nFactory = $this->createMock(IFactory::class);
 		$this->l = $this->createMock(IL10N::class);
 		$this->l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
+			->willReturnCallback(function($text, $parameters = []) {
 				return vsprintf($text, $parameters);
 			});
 		$this->l->method('n')
-			->willReturnCallback(function ($singular, $plural, $count, $parameters = []) {
+			->willReturnCallback(function($singular, $plural, $count, $parameters = []) {
 				return vsprintf(str_replace('%n', $count, ($count === 1) ? $singular : $plural), $parameters);
 			});
 		$this->l10nFactory->method('get')->willReturn($this->l);
@@ -277,7 +277,7 @@ 
 		];
 		$this->dispatcher->expects($this->exactly(2))
 			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $share) {
+			->willReturnCallback(function($event) use (&$calls, $share) {
 				$expected = array_shift($calls);
 				$this->assertInstanceOf($expected, $event);
 				$this->assertEquals($share, $event->getShare());
@@ -320,7 +320,7 @@ 
 		];
 		$this->dispatcher->expects($this->exactly(2))
 			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $share) {
+			->willReturnCallback(function($event) use (&$calls, $share) {
 				$expected = array_shift($calls);
 				$this->assertInstanceOf($expected, $event);
 				$this->assertEquals($share, $event->getShare());
@@ -380,7 +380,7 @@ 
 		];
 		$this->defaultProvider->expects($this->exactly(3))
 			->method('delete')
-			->willReturnCallback(function ($share) use (&$deleteCalls) {
+			->willReturnCallback(function($share) use (&$deleteCalls) {
 				$expected = array_shift($deleteCalls);
 				$this->assertEquals($expected, $share);
 			});
@@ -395,7 +395,7 @@ 
 		];
 		$this->dispatcher->expects($this->exactly(6))
 			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$dispatchCalls) {
+			->willReturnCallback(function($event) use (&$dispatchCalls) {
 				$expected = array_shift($dispatchCalls);
 				$this->assertInstanceOf($expected[0], $event);
 				$this->assertEquals($expected[1]->getId(), $event->getShare()->getId());
@@ -429,7 +429,7 @@ 
 		$this->dispatcher->expects($this->once())
 			->method('dispatchTyped')
 			->with(
-				$this->callBack(function (ShareDeletedFromSelfEvent $e) use ($share) {
+				$this->callBack(function(ShareDeletedFromSelfEvent $e) use ($share) {
 					return $e->getShare() === $share;
 				})
 			);
@@ -461,7 +461,7 @@ 
 		$this->defaultProvider
 			->expects($this->exactly(4))
 			->method('getChildren')
-			->willReturnCallback(function ($_share) use ($share, $shares) {
+			->willReturnCallback(function($_share) use ($share, $shares) {
 				if ($_share === $share) {
 					return $shares;
 				}
@@ -475,7 +475,7 @@ 
 		];
 		$this->defaultProvider->expects($this->exactly(3))
 			->method('delete')
-			->willReturnCallback(function ($share) use (&$calls) {
+			->willReturnCallback(function($share) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $share);
 			});
@@ -504,7 +504,7 @@ 
 		$reShare->method('getNode')->willReturn($file);
 
 		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $file) {
+			->willReturnCallback(function($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $file) {
 				$this->assertEquals($file, $node);
 				if ($shareType === IShare::TYPE_USER) {
 					return match($userId) {
@@ -555,10 +555,10 @@ 
 		$reShareInOtherFolder->method('getNode')->willReturn($otherFolder);
 
 		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $reShareInSubFolder, $reShareInOtherFolder) {
+			->willReturnCallback(function($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare, $reShareInSubFolder, $reShareInOtherFolder) {
 				if ($shareType === IShare::TYPE_USER) {
 					return match($userId) {
-						'userB' => [$reShare,$reShareInSubFolder,$reShareInOtherFolder],
+						'userB' => [$reShare, $reShareInSubFolder, $reShareInOtherFolder],
 					};
 				} else {
 					return [];
@@ -572,7 +572,7 @@ 
 		];
 		$manager->expects($this->exactly(2))
 			->method('updateShare')
-			->willReturnCallback(function ($share) use (&$calls) {
+			->willReturnCallback(function($share) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $share);
 			});
@@ -646,7 +646,7 @@ 
 		$this->groupManager->method('get')->with('Group')->willReturn($group);
 
 		$this->defaultProvider->method('getSharesBy')
-			->willReturnCallback(function ($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare1, $reShare2) {
+			->willReturnCallback(function($userId, $shareType, $node, $reshares, $limit, $offset) use ($reShare1, $reShare2) {
 				if ($shareType === IShare::TYPE_USER) {
 					return match($userId) {
 						'userB' => [$reShare1],
@@ -666,7 +666,7 @@ 
 		];
 		$manager->expects($this->exactly(2))
 			->method('updateShare')
-			->willReturnCallback(function ($share) use (&$calls) {
+			->willReturnCallback(function($share) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $share);
 			});
@@ -773,7 +773,7 @@ 
 		]);
 
 		$this->dispatcher->expects($this->once())->method('dispatchTyped')
-			->willReturnCallback(function (Event $event) {
+			->willReturnCallback(function(Event $event) {
 				$this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
 				/** @var ValidatePasswordPolicyEvent $event */
 				$this->assertSame('password', $event->getPassword());
@@ -795,7 +795,7 @@ 
 		]);
 
 		$this->dispatcher->expects($this->once())->method('dispatchTyped')
-			->willReturnCallback(function (Event $event) {
+			->willReturnCallback(function(Event $event) {
 				$this->assertInstanceOf(ValidatePasswordPolicyEvent::class, $event);
 				/** @var ValidatePasswordPolicyEvent $event */
 				$this->assertSame('password', $event->getPassword());
@@ -1278,7 +1278,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($future) {
 			return $data['expirationDate'] == $future;
 		}));
 
@@ -1304,7 +1304,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
 		}));
 
@@ -1319,7 +1319,7 @@ 
 	public function testValidateExpirationDateInternalNoDateNoDefault($shareType): void {
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) {
 			return $data['expirationDate'] === null && $data['passwordSet'] === true;
 		}));
 
@@ -1362,7 +1362,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected;
 		}));
 
@@ -1404,7 +1404,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected;
 		}));
 
@@ -1425,7 +1425,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function($data) {
 			$data['expirationDate']->sub(new \DateInterval('P2D'));
 		});
 
@@ -1456,7 +1456,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function($data) {
 			$data['accepted'] = false;
 			$data['message'] = 'Invalid date!';
 		});
@@ -1617,7 +1617,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($future) {
 			return $data['expirationDate'] == $future;
 		}));
 
@@ -1640,7 +1640,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
 		}));
 
@@ -1652,7 +1652,7 @@ 
 	public function testValidateExpirationDateNoDateNoDefault(): void {
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) {
 			return $data['expirationDate'] === null && $data['passwordSet'] === true;
 		}));
 
@@ -1681,7 +1681,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected;
 		}));
 
@@ -1711,7 +1711,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected;
 		}));
 
@@ -1742,7 +1742,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
+		$hookListener->expects($this->once())->method('listener')->with($this->callback(function($data) use ($expected) {
 			return $data['expirationDate'] == $expected;
 		}));
 
@@ -1762,7 +1762,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function($data) {
 			$data['expirationDate']->sub(new \DateInterval('P2D'));
 		});
 
@@ -1787,7 +1787,7 @@ 
 
 		$hookListener = $this->createMock(DummyShareManagerListener::class);
 		\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
-		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function ($data) {
+		$hookListener->expects($this->once())->method('listener')->willReturnCallback(function($data) {
 			$data['accepted'] = false;
 			$data['message'] = 'Invalid date!';
 		});
@@ -2619,7 +2619,7 @@ 
 			->expects($this->once())
 			->method('create')
 			->with($share)
-			->willReturnCallback(function (Share $share) {
+			->willReturnCallback(function(Share $share) {
 				return $share->setId(42);
 			});
 
@@ -2629,7 +2629,7 @@ 
 		];
 		$this->dispatcher->expects($this->exactly(2))
 			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $date, $path) {
+			->willReturnCallback(function($event) use (&$calls, $date, $path) {
 				$expected = array_shift($calls);
 				$this->assertInstanceOf($expected, $event);
 				$share = $event->getShare();
@@ -2716,7 +2716,7 @@ 
 			->expects($this->once())
 			->method('create')
 			->with($share)
-			->willReturnCallback(function (Share $share) {
+			->willReturnCallback(function(Share $share) {
 				return $share->setId(42);
 			});
 
@@ -2726,7 +2726,7 @@ 
 		];
 		$this->dispatcher->expects($this->exactly(2))
 			->method('dispatchTyped')
-			->willReturnCallback(function ($event) use (&$calls, $path) {
+			->willReturnCallback(function($event) use (&$calls, $path) {
 				$expected = array_shift($calls);
 				$this->assertInstanceOf($expected, $event);
 				$share = $event->getShare();
@@ -2813,7 +2813,7 @@ 
 			->method('dispatchTyped')
 			->with(
 				$this->isInstanceOf(BeforeShareCreatedEvent::class)
-			)->willReturnCallback(function (BeforeShareCreatedEvent $e) {
+			)->willReturnCallback(function(BeforeShareCreatedEvent $e) {
 				$e->setError('I won\'t let you share!');
 				$e->stopPropagation();
 			}
@@ -2992,7 +2992,7 @@ 
 		 */
 		$this->defaultProvider
 			->method('getSharesBy')
-			->willReturnCallback(function ($uid, $type, $node, $reshares, $limit, $offset) use (&$shares2) {
+			->willReturnCallback(function($uid, $type, $node, $reshares, $limit, $offset) use (&$shares2) {
 				return array_slice($shares2, $offset, $limit);
 			});
 
@@ -3000,7 +3000,7 @@ 
 		 * Simulate the deleteShare call.
 		 */
 		$manager->method('deleteShare')
-			->willReturnCallback(function ($share) use (&$shares2) {
+			->willReturnCallback(function($share) use (&$shares2) {
 				for ($i = 0; $i < count($shares2); $i++) {
 					if ($shares2[$i]->getId() === $share->getId()) {
 						array_splice($shares2, $i, 1);
@@ -3072,7 +3072,7 @@ 
 
 		$factory->expects($this->any())
 			->method('getProviderForType')
-			->willReturnCallback(function ($shareType) use ($roomShareProvider) {
+			->willReturnCallback(function($shareType) use ($roomShareProvider) {
 				if ($shareType !== IShare::TYPE_ROOM) {
 					throw new Exception\ProviderException();
 				}
@@ -3110,7 +3110,7 @@ 
 		];
 		$factory->expects($this->exactly(2))
 			->method('getProviderForType')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 				return $this->defaultProvider;
@@ -3324,7 +3324,7 @@ 
 			->setPassword('passwordHash');
 
 		$this->hasher->method('verify')->with('password', 'passwordHash', '')
-			->willReturnCallback(function ($pass, $hash, &$newHash) {
+			->willReturnCallback(function($pass, $hash, &$newHash) {
 				$newHash = 'newHash';
 
 				return true;
@@ -3332,7 +3332,7 @@ 
 
 		$this->defaultProvider->expects($this->once())
 			->method('update')
-			->with($this->callback(function (\OCP\Share\IShare $share) {
+			->with($this->callback(function(\OCP\Share\IShare $share) {
 				return $share->getPassword() === 'newHash';
 			}));
 
@@ -4478,7 +4478,7 @@ 
 	public function testShareProviderExists($shareType, $expected): void {
 		$factory = $this->getMockBuilder('OCP\Share\IProviderFactory')->getMock();
 		$factory->expects($this->any())->method('getProviderForType')
-			->willReturnCallback(function ($id) {
+			->willReturnCallback(function($id) {
 				if ($id === IShare::TYPE_USER) {
 					return true;
 				}
@@ -4675,7 +4675,7 @@ 
 			->willReturn($userFolder);
 
 		$expected = [
-			'users' => ['owner', 'user1', 'user2', 'user3', '123456','user4', 'user5', '234567'],
+			'users' => ['owner', 'user1', 'user2', 'user3', '123456', 'user4', 'user5', '234567'],
 			'remote' => true,
 			'public' => true,
 		];
@@ -4810,12 +4810,12 @@ 
 		$share4 = $this->createMock(IShare::class);
 
 		$this->defaultProvider->method('getAllShares')
-			->willReturnCallback(function () use ($share1, $share2) {
+			->willReturnCallback(function() use ($share1, $share2) {
 				yield $share1;
 				yield $share2;
 			});
 		$extraProvider->method('getAllShares')
-			->willReturnCallback(function () use ($share3, $share4) {
+			->willReturnCallback(function() use ($share3, $share4) {
 				yield $share3;
 				yield $share4;
 			});

tests/Core/Command/Apps/AppsDisableTest.php

Indentation +37 added lines, -37 removed lines

@@ -18,52 +18,52 @@
  * @group DB
  */
 class AppsDisableTest extends TestCase {
-	/** @var CommandTester */
-	private $commandTester;
+    /** @var CommandTester */
+    private $commandTester;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$command = new Disable(
-			\OC::$server->getAppManager()
-		);
+        $command = new Disable(
+            \OC::$server->getAppManager()
+        );
 
-		$this->commandTester = new CommandTester($command);
+        $this->commandTester = new CommandTester($command);
 
-		\OC::$server->getAppManager()->enableApp('admin_audit');
-		\OC::$server->getAppManager()->enableApp('comments');
-	}
+        \OC::$server->getAppManager()->enableApp('admin_audit');
+        \OC::$server->getAppManager()->enableApp('comments');
+    }
 
-	/**
-	 * @dataProvider dataCommandInput
-	 * @param $appId
-	 * @param $groups
-	 * @param $statusCode
-	 * @param $pattern
-	 */
-	public function testCommandInput($appId, $statusCode, $pattern): void {
-		$input = ['app-id' => $appId];
+    /**
+     * @dataProvider dataCommandInput
+     * @param $appId
+     * @param $groups
+     * @param $statusCode
+     * @param $pattern
+     */
+    public function testCommandInput($appId, $statusCode, $pattern): void {
+        $input = ['app-id' => $appId];
 
-		$this->commandTester->execute($input);
+        $this->commandTester->execute($input);
 
-		$this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
-		$this->assertSame($statusCode, $this->commandTester->getStatusCode());
-	}
+        $this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
+        $this->assertSame($statusCode, $this->commandTester->getStatusCode());
+    }
 
-	public static function dataCommandInput(): array {
-		return [
-			[['admin_audit'], 0, 'admin_audit ([\d\.]*) disabled'],
-			[['comments'], 0, 'comments ([\d\.]*) disabled'],
-			[['invalid_app'], 0, 'No such app enabled: invalid_app'],
+    public static function dataCommandInput(): array {
+        return [
+            [['admin_audit'], 0, 'admin_audit ([\d\.]*) disabled'],
+            [['comments'], 0, 'comments ([\d\.]*) disabled'],
+            [['invalid_app'], 0, 'No such app enabled: invalid_app'],
 
-			[['admin_audit', 'comments'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled"],
-			[['admin_audit', 'comments', 'invalid_app'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled\nNo such app enabled: invalid_app"],
+            [['admin_audit', 'comments'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled"],
+            [['admin_audit', 'comments', 'invalid_app'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled\nNo such app enabled: invalid_app"],
 
-			[['files'], 2, "files can't be disabled"],
-			[['provisioning_api'], 2, "provisioning_api can't be disabled"],
+            [['files'], 2, "files can't be disabled"],
+            [['provisioning_api'], 2, "provisioning_api can't be disabled"],
 
-			[['files', 'admin_audit'], 2, "files can't be disabled.\nadmin_audit ([\d\.]*) disabled"],
-			[['provisioning_api', 'comments'], 2, "provisioning_api can't be disabled.\ncomments ([\d\.]*) disabled"],
-		];
-	}
+            [['files', 'admin_audit'], 2, "files can't be disabled.\nadmin_audit ([\d\.]*) disabled"],
+            [['provisioning_api', 'comments'], 2, "provisioning_api can't be disabled.\ncomments ([\d\.]*) disabled"],
+        ];
+    }
 }

tests/Core/Command/Apps/AppsEnableTest.php

Indentation +59 added lines, -59 removed lines

@@ -19,63 +19,63 @@
  * @group DB
  */
 class AppsEnableTest extends TestCase {
-	/** @var CommandTester */
-	private $commandTester;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$command = new Enable(
-			\OC::$server->getAppManager(),
-			\OC::$server->getGroupManager(),
-			\OC::$server->get(Installer::class),
-		);
-
-		$this->commandTester = new CommandTester($command);
-
-		\OC::$server->getAppManager()->disableApp('admin_audit');
-		\OC::$server->getAppManager()->disableApp('comments');
-	}
-
-	/**
-	 * @dataProvider dataCommandInput
-	 * @param $appId
-	 * @param $groups
-	 * @param $statusCode
-	 * @param $pattern
-	 */
-	public function testCommandInput($appId, $groups, $statusCode, $pattern): void {
-		$input = ['app-id' => $appId];
-
-		if (is_array($groups)) {
-			$input['--groups'] = $groups;
-		}
-
-		$this->commandTester->execute($input);
-
-		$this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
-		$this->assertSame($statusCode, $this->commandTester->getStatusCode());
-	}
-
-	public static function dataCommandInput(): array {
-		return [
-			[['admin_audit'], null, 0, 'admin_audit ([\d\.]*) enabled'],
-			[['comments'], null, 0, 'comments ([\d\.]*) enabled'],
-			[['comments', 'comments'], null, 0, "comments ([\d\.]*) enabled\ncomments already enabled"],
-			[['invalid_app'], null, 1, 'Could not download app invalid_app'],
-
-			[['admin_audit', 'comments'], null, 0, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled"],
-			[['admin_audit', 'comments', 'invalid_app'], null, 1, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled\nCould not download app invalid_app"],
-
-			[['admin_audit'], ['admin'], 1, "admin_audit can't be enabled for groups"],
-			[['comments'], ['admin'], 1, "comments can't be enabled for groups"],
-
-			[['updatenotification'], ['admin'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
-			[['updatenotification', 'dashboard'], ['admin'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin"],
-
-			[['updatenotification'], ['admin', 'invalid_group'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
-			[['updatenotification', 'dashboard'], ['admin', 'invalid_group'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin"],
-			[['updatenotification', 'dashboard', 'invalid_app'], ['admin', 'invalid_group'], 1, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin\nCould not download app invalid_app"],
-		];
-	}
+    /** @var CommandTester */
+    private $commandTester;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $command = new Enable(
+            \OC::$server->getAppManager(),
+            \OC::$server->getGroupManager(),
+            \OC::$server->get(Installer::class),
+        );
+
+        $this->commandTester = new CommandTester($command);
+
+        \OC::$server->getAppManager()->disableApp('admin_audit');
+        \OC::$server->getAppManager()->disableApp('comments');
+    }
+
+    /**
+     * @dataProvider dataCommandInput
+     * @param $appId
+     * @param $groups
+     * @param $statusCode
+     * @param $pattern
+     */
+    public function testCommandInput($appId, $groups, $statusCode, $pattern): void {
+        $input = ['app-id' => $appId];
+
+        if (is_array($groups)) {
+            $input['--groups'] = $groups;
+        }
+
+        $this->commandTester->execute($input);
+
+        $this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
+        $this->assertSame($statusCode, $this->commandTester->getStatusCode());
+    }
+
+    public static function dataCommandInput(): array {
+        return [
+            [['admin_audit'], null, 0, 'admin_audit ([\d\.]*) enabled'],
+            [['comments'], null, 0, 'comments ([\d\.]*) enabled'],
+            [['comments', 'comments'], null, 0, "comments ([\d\.]*) enabled\ncomments already enabled"],
+            [['invalid_app'], null, 1, 'Could not download app invalid_app'],
+
+            [['admin_audit', 'comments'], null, 0, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled"],
+            [['admin_audit', 'comments', 'invalid_app'], null, 1, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled\nCould not download app invalid_app"],
+
+            [['admin_audit'], ['admin'], 1, "admin_audit can't be enabled for groups"],
+            [['comments'], ['admin'], 1, "comments can't be enabled for groups"],
+
+            [['updatenotification'], ['admin'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
+            [['updatenotification', 'dashboard'], ['admin'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin"],
+
+            [['updatenotification'], ['admin', 'invalid_group'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
+            [['updatenotification', 'dashboard'], ['admin', 'invalid_group'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin"],
+            [['updatenotification', 'dashboard', 'invalid_app'], ['admin', 'invalid_group'], 1, "updatenotification ([\d\.]*) enabled for groups: admin\ndashboard ([\d\.]*) enabled for groups: admin\nCould not download app invalid_app"],
+        ];
+    }
 }

tests/Core/Command/Encryption/SetDefaultModuleTest.php

Indentation +111 added lines, -111 removed lines

@@ -15,115 +15,115 @@
 use Test\TestCase;
 
 class SetDefaultModuleTest extends TestCase {
-	/** @var \PHPUnit\Framework\MockObject\MockObject|IManager */
-	protected $manager;
-	/** @var \PHPUnit\Framework\MockObject\MockObject|IConfig */
-	protected $config;
-	/** @var \PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleInput;
-	/** @var \PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleOutput;
-
-	/** @var \Symfony\Component\Console\Command\Command */
-	protected $command;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->manager = $this->getMockBuilder(IManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->config = $this->getMockBuilder(IConfig::class)
-			->getMock();
-
-		$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
-		$this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
-
-		$this->command = new SetDefaultModule($this->manager, $this->config);
-	}
-
-
-	public static function dataSetDefaultModule(): array {
-		return [
-			['ID0', 'ID0', null, null, 'already'],
-			['ID0', 'ID1', 'ID1', true, 'info'],
-			['ID0', 'ID1', 'ID1', false, 'error'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataSetDefaultModule
-	 *
-	 * @param string $oldModule
-	 * @param string $newModule
-	 * @param string $updateModule
-	 * @param bool $updateSuccess
-	 * @param string $expectedString
-	 */
-	public function testSetDefaultModule($oldModule, $newModule, $updateModule, $updateSuccess, $expectedString): void {
-		$this->consoleInput->expects($this->once())
-			->method('getArgument')
-			->with('module')
-			->willReturn($newModule);
-
-		$this->manager->expects($this->once())
-			->method('getDefaultEncryptionModuleId')
-			->willReturn($oldModule);
-
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('maintenance', false)
-			->willReturn(false);
-
-		if ($updateModule) {
-			$this->manager->expects($this->once())
-				->method('setDefaultEncryptionModule')
-				->with($updateModule)
-				->willReturn($updateSuccess);
-		}
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with($this->stringContains($expectedString));
-
-		self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
-
-	/**
-	 * @dataProvider dataSetDefaultModule
-	 *
-	 * @param string $oldModule
-	 * @param string $newModule
-	 * @param string $updateModule
-	 * @param bool $updateSuccess
-	 * @param string $expectedString
-	 */
-	public function testMaintenanceMode($oldModule, $newModule, $updateModule, $updateSuccess, $expectedString): void {
-		$this->consoleInput->expects($this->never())
-			->method('getArgument')
-			->with('module')
-			->willReturn($newModule);
-
-		$this->manager->expects($this->never())
-			->method('getDefaultEncryptionModuleId')
-			->willReturn($oldModule);
-
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('maintenance', false)
-			->willReturn(true);
-
-		$calls = [
-			'Maintenance mode must be disabled when setting default module,',
-			'in order to load the relevant encryption modules correctly.',
-		];
-		$this->consoleOutput->expects($this->exactly(2))
-			->method('writeln')
-			->willReturnCallback(function ($message) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertStringContainsString($expected, $message);
-			});
-
-		self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
+    /** @var \PHPUnit\Framework\MockObject\MockObject|IManager */
+    protected $manager;
+    /** @var \PHPUnit\Framework\MockObject\MockObject|IConfig */
+    protected $config;
+    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleInput;
+    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleOutput;
+
+    /** @var \Symfony\Component\Console\Command\Command */
+    protected $command;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->manager = $this->getMockBuilder(IManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->config = $this->getMockBuilder(IConfig::class)
+            ->getMock();
+
+        $this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
+        $this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
+
+        $this->command = new SetDefaultModule($this->manager, $this->config);
+    }
+
+
+    public static function dataSetDefaultModule(): array {
+        return [
+            ['ID0', 'ID0', null, null, 'already'],
+            ['ID0', 'ID1', 'ID1', true, 'info'],
+            ['ID0', 'ID1', 'ID1', false, 'error'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataSetDefaultModule
+     *
+     * @param string $oldModule
+     * @param string $newModule
+     * @param string $updateModule
+     * @param bool $updateSuccess
+     * @param string $expectedString
+     */
+    public function testSetDefaultModule($oldModule, $newModule, $updateModule, $updateSuccess, $expectedString): void {
+        $this->consoleInput->expects($this->once())
+            ->method('getArgument')
+            ->with('module')
+            ->willReturn($newModule);
+
+        $this->manager->expects($this->once())
+            ->method('getDefaultEncryptionModuleId')
+            ->willReturn($oldModule);
+
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('maintenance', false)
+            ->willReturn(false);
+
+        if ($updateModule) {
+            $this->manager->expects($this->once())
+                ->method('setDefaultEncryptionModule')
+                ->with($updateModule)
+                ->willReturn($updateSuccess);
+        }
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with($this->stringContains($expectedString));
+
+        self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
+
+    /**
+     * @dataProvider dataSetDefaultModule
+     *
+     * @param string $oldModule
+     * @param string $newModule
+     * @param string $updateModule
+     * @param bool $updateSuccess
+     * @param string $expectedString
+     */
+    public function testMaintenanceMode($oldModule, $newModule, $updateModule, $updateSuccess, $expectedString): void {
+        $this->consoleInput->expects($this->never())
+            ->method('getArgument')
+            ->with('module')
+            ->willReturn($newModule);
+
+        $this->manager->expects($this->never())
+            ->method('getDefaultEncryptionModuleId')
+            ->willReturn($oldModule);
+
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('maintenance', false)
+            ->willReturn(true);
+
+        $calls = [
+            'Maintenance mode must be disabled when setting default module,',
+            'in order to load the relevant encryption modules correctly.',
+        ];
+        $this->consoleOutput->expects($this->exactly(2))
+            ->method('writeln')
+            ->willReturnCallback(function ($message) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertStringContainsString($expected, $message);
+            });
+
+        self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
 		];
 		$this->consoleOutput->expects($this->exactly(2))
 			->method('writeln')
-			->willReturnCallback(function ($message) use (&$calls) {
+			->willReturnCallback(function($message) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertStringContainsString($expected, $message);
 			});

tests/Core/Command/Encryption/EncryptAllTest.php

Indentation +97 added lines, -97 removed lines

@@ -18,101 +18,101 @@
 use Test\TestCase;
 
 class EncryptAllTest extends TestCase {
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\IConfig */
-	protected $config;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IManager */
-	protected $encryptionManager;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\App\IAppManager */
-	protected $appManager;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Input\InputInterface */
-	protected $consoleInput;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Output\OutputInterface */
-	protected $consoleOutput;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Helper\QuestionHelper */
-	protected $questionHelper;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IEncryptionModule */
-	protected $encryptionModule;
-
-	/** @var EncryptAll */
-	protected $command;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->encryptionManager = $this->getMockBuilder(IManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->appManager = $this->getMockBuilder(IAppManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->encryptionModule = $this->getMockBuilder(IEncryptionModule::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->questionHelper = $this->getMockBuilder(QuestionHelper::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
-		$this->consoleInput->expects($this->any())
-			->method('isInteractive')
-			->willReturn(true);
-		$this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
-	}
-
-	public function testEncryptAll(): void {
-		// trash bin needs to be disabled in order to avoid adding dummy files to the users
-		// trash bin which gets deleted during the encryption process
-		$this->appManager->expects($this->once())->method('disableApp')->with('files_trashbin');
-
-		$instance = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
-		$this->invokePrivate($instance, 'forceMaintenanceAndTrashbin');
-		$this->invokePrivate($instance, 'resetMaintenanceAndTrashbin');
-	}
-
-	/**
-	 * @dataProvider dataTestExecute
-	 */
-	public function testExecute($answer, $askResult): void {
-		$command = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
-
-		$this->encryptionManager->expects($this->once())->method('isEnabled')->willReturn(true);
-		$this->questionHelper->expects($this->once())->method('ask')->willReturn($askResult);
-
-		if ($answer === 'Y' || $answer === 'y') {
-			$this->encryptionManager->expects($this->once())
-				->method('getEncryptionModule')->willReturn($this->encryptionModule);
-			$this->encryptionModule->expects($this->once())
-				->method('encryptAll')->with($this->consoleInput, $this->consoleOutput);
-		} else {
-			$this->encryptionManager->expects($this->never())->method('getEncryptionModule');
-			$this->encryptionModule->expects($this->never())->method('encryptAll');
-		}
-
-		$this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
-
-	public static function dataTestExecute(): array {
-		return [
-			['y', true], ['Y', true], ['n', false], ['N', false], ['', false]
-		];
-	}
-
-
-	public function testExecuteException(): void {
-		$this->expectException(\Exception::class);
-
-		$command = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
-		$this->encryptionManager->expects($this->once())->method('isEnabled')->willReturn(false);
-		$this->encryptionManager->expects($this->never())->method('getEncryptionModule');
-		$this->encryptionModule->expects($this->never())->method('encryptAll');
-		$this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\IConfig */
+    protected $config;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IManager */
+    protected $encryptionManager;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\App\IAppManager */
+    protected $appManager;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Input\InputInterface */
+    protected $consoleInput;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Output\OutputInterface */
+    protected $consoleOutput;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Helper\QuestionHelper */
+    protected $questionHelper;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IEncryptionModule */
+    protected $encryptionModule;
+
+    /** @var EncryptAll */
+    protected $command;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->encryptionManager = $this->getMockBuilder(IManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->appManager = $this->getMockBuilder(IAppManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->encryptionModule = $this->getMockBuilder(IEncryptionModule::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->questionHelper = $this->getMockBuilder(QuestionHelper::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
+        $this->consoleInput->expects($this->any())
+            ->method('isInteractive')
+            ->willReturn(true);
+        $this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
+    }
+
+    public function testEncryptAll(): void {
+        // trash bin needs to be disabled in order to avoid adding dummy files to the users
+        // trash bin which gets deleted during the encryption process
+        $this->appManager->expects($this->once())->method('disableApp')->with('files_trashbin');
+
+        $instance = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
+        $this->invokePrivate($instance, 'forceMaintenanceAndTrashbin');
+        $this->invokePrivate($instance, 'resetMaintenanceAndTrashbin');
+    }
+
+    /**
+     * @dataProvider dataTestExecute
+     */
+    public function testExecute($answer, $askResult): void {
+        $command = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
+
+        $this->encryptionManager->expects($this->once())->method('isEnabled')->willReturn(true);
+        $this->questionHelper->expects($this->once())->method('ask')->willReturn($askResult);
+
+        if ($answer === 'Y' || $answer === 'y') {
+            $this->encryptionManager->expects($this->once())
+                ->method('getEncryptionModule')->willReturn($this->encryptionModule);
+            $this->encryptionModule->expects($this->once())
+                ->method('encryptAll')->with($this->consoleInput, $this->consoleOutput);
+        } else {
+            $this->encryptionManager->expects($this->never())->method('getEncryptionModule');
+            $this->encryptionModule->expects($this->never())->method('encryptAll');
+        }
+
+        $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
+
+    public static function dataTestExecute(): array {
+        return [
+            ['y', true], ['Y', true], ['n', false], ['N', false], ['', false]
+        ];
+    }
+
+
+    public function testExecuteException(): void {
+        $this->expectException(\Exception::class);
+
+        $command = new EncryptAll($this->encryptionManager, $this->appManager, $this->config, $this->questionHelper);
+        $this->encryptionManager->expects($this->once())->method('isEnabled')->willReturn(false);
+        $this->encryptionManager->expects($this->never())->method('getEncryptionModule');
+        $this->encryptionModule->expects($this->never())->method('encryptAll');
+        $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
 }

tests/Core/Command/Encryption/DecryptAllTest.php

Indentation +197 added lines, -197 removed lines

@@ -17,201 +17,201 @@
 use Test\TestCase;
 
 class DecryptAllTest extends TestCase {
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\IConfig */
-	protected $config;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IManager */
-	protected $encryptionManager;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\App\IAppManager */
-	protected $appManager;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Input\InputInterface */
-	protected $consoleInput;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Output\OutputInterface */
-	protected $consoleOutput;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Helper\QuestionHelper */
-	protected $questionHelper;
-
-	/** @var \PHPUnit\Framework\MockObject\MockObject | \OC\Encryption\DecryptAll */
-	protected $decryptAll;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->encryptionManager = $this->getMockBuilder(IManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->appManager = $this->getMockBuilder(IAppManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->questionHelper = $this->getMockBuilder(QuestionHelper::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->decryptAll = $this->getMockBuilder(\OC\Encryption\DecryptAll::class)
-			->disableOriginalConstructor()->getMock();
-		$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
-		$this->consoleInput->expects($this->any())
-			->method('isInteractive')
-			->willReturn(true);
-		$this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
-
-		$this->config->expects($this->any())
-			->method('getSystemValue')
-			->with('maintenance', false)
-			->willReturn(false);
-		$this->appManager->expects($this->any())
-			->method('isEnabledForUser')
-			->with('files_trashbin')->willReturn(true);
-	}
-
-	public function testMaintenanceAndTrashbin(): void {
-		// on construct we enable single-user-mode and disable the trash bin
-		// on destruct we disable single-user-mode again and enable the trash bin
-		$calls = [
-			['maintenance', true],
-			['maintenance', false],
-		];
-		$this->config->expects($this->exactly(2))
-			->method('setSystemValue')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->appManager->expects($this->once())
-			->method('disableApp')
-			->with('files_trashbin');
-		$this->appManager->expects($this->once())
-			->method('enableApp')
-			->with('files_trashbin');
-
-		$instance = new DecryptAll(
-			$this->encryptionManager,
-			$this->appManager,
-			$this->config,
-			$this->decryptAll,
-			$this->questionHelper
-		);
-		$this->invokePrivate($instance, 'forceMaintenanceAndTrashbin');
-
-		$this->assertTrue(
-			$this->invokePrivate($instance, 'wasTrashbinEnabled')
-		);
-
-		$this->assertFalse(
-			$this->invokePrivate($instance, 'wasMaintenanceModeEnabled')
-		);
-		$this->invokePrivate($instance, 'resetMaintenanceAndTrashbin');
-	}
-
-	/**
-	 * @dataProvider dataTestExecute
-	 */
-	public function testExecute($encryptionEnabled, $continue): void {
-		$instance = new DecryptAll(
-			$this->encryptionManager,
-			$this->appManager,
-			$this->config,
-			$this->decryptAll,
-			$this->questionHelper
-		);
-
-		$this->encryptionManager->expects($this->once())
-			->method('isEnabled')
-			->willReturn($encryptionEnabled);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->with('user')
-			->willReturn('user1');
-
-		if ($encryptionEnabled) {
-			$calls = [
-				['core', 'encryption_enabled', 'no'],
-				['core', 'encryption_enabled', 'yes'],
-			];
-			$this->config->expects($this->exactly(2))
-				->method('setAppValue')
-				->willReturnCallback(function () use (&$calls) {
-					$expected = array_shift($calls);
-					$this->assertEquals($expected, func_get_args());
-				});
-			$this->questionHelper->expects($this->once())
-				->method('ask')
-				->willReturn($continue);
-			if ($continue) {
-				$this->decryptAll->expects($this->once())
-					->method('decryptAll')
-					->with($this->consoleInput, $this->consoleOutput, 'user1');
-			} else {
-				$this->decryptAll->expects($this->never())->method('decryptAll');
-			}
-		} else {
-			$this->config->expects($this->never())->method('setAppValue');
-			$this->decryptAll->expects($this->never())->method('decryptAll');
-			$this->questionHelper->expects($this->never())->method('ask');
-		}
-
-		$this->invokePrivate($instance, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
-
-	public static function dataTestExecute(): array {
-		return [
-			[true, true],
-			[true, false],
-			[false, true],
-			[false, false]
-		];
-	}
-
-
-	public function testExecuteFailure(): void {
-		$this->expectException(\Exception::class);
-
-		$instance = new DecryptAll(
-			$this->encryptionManager,
-			$this->appManager,
-			$this->config,
-			$this->decryptAll,
-			$this->questionHelper
-		);
-
-		// make sure that we enable encryption again after a exception was thrown
-		$calls = [
-			['core', 'encryption_enabled', 'no'],
-			['core', 'encryption_enabled', 'yes'],
-		];
-		$this->config->expects($this->exactly(2))
-			->method('setAppValue')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->encryptionManager->expects($this->once())
-			->method('isEnabled')
-			->willReturn(true);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->with('user')
-			->willReturn('user1');
-
-		$this->questionHelper->expects($this->once())
-			->method('ask')
-			->willReturn(true);
-
-		$this->decryptAll->expects($this->once())
-			->method('decryptAll')
-			->with($this->consoleInput, $this->consoleOutput, 'user1')
-			->willReturnCallback(function () {
-				throw new \Exception();
-			});
-
-		$this->invokePrivate($instance, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\IConfig */
+    protected $config;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\Encryption\IManager */
+    protected $encryptionManager;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OCP\App\IAppManager */
+    protected $appManager;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Input\InputInterface */
+    protected $consoleInput;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Output\OutputInterface */
+    protected $consoleOutput;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \Symfony\Component\Console\Helper\QuestionHelper */
+    protected $questionHelper;
+
+    /** @var \PHPUnit\Framework\MockObject\MockObject | \OC\Encryption\DecryptAll */
+    protected $decryptAll;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->encryptionManager = $this->getMockBuilder(IManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->appManager = $this->getMockBuilder(IAppManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->questionHelper = $this->getMockBuilder(QuestionHelper::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->decryptAll = $this->getMockBuilder(\OC\Encryption\DecryptAll::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
+        $this->consoleInput->expects($this->any())
+            ->method('isInteractive')
+            ->willReturn(true);
+        $this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
+
+        $this->config->expects($this->any())
+            ->method('getSystemValue')
+            ->with('maintenance', false)
+            ->willReturn(false);
+        $this->appManager->expects($this->any())
+            ->method('isEnabledForUser')
+            ->with('files_trashbin')->willReturn(true);
+    }
+
+    public function testMaintenanceAndTrashbin(): void {
+        // on construct we enable single-user-mode and disable the trash bin
+        // on destruct we disable single-user-mode again and enable the trash bin
+        $calls = [
+            ['maintenance', true],
+            ['maintenance', false],
+        ];
+        $this->config->expects($this->exactly(2))
+            ->method('setSystemValue')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->appManager->expects($this->once())
+            ->method('disableApp')
+            ->with('files_trashbin');
+        $this->appManager->expects($this->once())
+            ->method('enableApp')
+            ->with('files_trashbin');
+
+        $instance = new DecryptAll(
+            $this->encryptionManager,
+            $this->appManager,
+            $this->config,
+            $this->decryptAll,
+            $this->questionHelper
+        );
+        $this->invokePrivate($instance, 'forceMaintenanceAndTrashbin');
+
+        $this->assertTrue(
+            $this->invokePrivate($instance, 'wasTrashbinEnabled')
+        );
+
+        $this->assertFalse(
+            $this->invokePrivate($instance, 'wasMaintenanceModeEnabled')
+        );
+        $this->invokePrivate($instance, 'resetMaintenanceAndTrashbin');
+    }
+
+    /**
+     * @dataProvider dataTestExecute
+     */
+    public function testExecute($encryptionEnabled, $continue): void {
+        $instance = new DecryptAll(
+            $this->encryptionManager,
+            $this->appManager,
+            $this->config,
+            $this->decryptAll,
+            $this->questionHelper
+        );
+
+        $this->encryptionManager->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn($encryptionEnabled);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->with('user')
+            ->willReturn('user1');
+
+        if ($encryptionEnabled) {
+            $calls = [
+                ['core', 'encryption_enabled', 'no'],
+                ['core', 'encryption_enabled', 'yes'],
+            ];
+            $this->config->expects($this->exactly(2))
+                ->method('setAppValue')
+                ->willReturnCallback(function () use (&$calls) {
+                    $expected = array_shift($calls);
+                    $this->assertEquals($expected, func_get_args());
+                });
+            $this->questionHelper->expects($this->once())
+                ->method('ask')
+                ->willReturn($continue);
+            if ($continue) {
+                $this->decryptAll->expects($this->once())
+                    ->method('decryptAll')
+                    ->with($this->consoleInput, $this->consoleOutput, 'user1');
+            } else {
+                $this->decryptAll->expects($this->never())->method('decryptAll');
+            }
+        } else {
+            $this->config->expects($this->never())->method('setAppValue');
+            $this->decryptAll->expects($this->never())->method('decryptAll');
+            $this->questionHelper->expects($this->never())->method('ask');
+        }
+
+        $this->invokePrivate($instance, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
+
+    public static function dataTestExecute(): array {
+        return [
+            [true, true],
+            [true, false],
+            [false, true],
+            [false, false]
+        ];
+    }
+
+
+    public function testExecuteFailure(): void {
+        $this->expectException(\Exception::class);
+
+        $instance = new DecryptAll(
+            $this->encryptionManager,
+            $this->appManager,
+            $this->config,
+            $this->decryptAll,
+            $this->questionHelper
+        );
+
+        // make sure that we enable encryption again after a exception was thrown
+        $calls = [
+            ['core', 'encryption_enabled', 'no'],
+            ['core', 'encryption_enabled', 'yes'],
+        ];
+        $this->config->expects($this->exactly(2))
+            ->method('setAppValue')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->encryptionManager->expects($this->once())
+            ->method('isEnabled')
+            ->willReturn(true);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->with('user')
+            ->willReturn('user1');
+
+        $this->questionHelper->expects($this->once())
+            ->method('ask')
+            ->willReturn(true);
+
+        $this->decryptAll->expects($this->once())
+            ->method('decryptAll')
+            ->with($this->consoleInput, $this->consoleOutput, 'user1')
+            ->willReturnCallback(function () {
+                throw new \Exception();
+            });
+
+        $this->invokePrivate($instance, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -79,7 +79,7 @@ 
 		];
 		$this->config->expects($this->exactly(2))
 			->method('setSystemValue')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -137,7 +137,7 @@ 
 			];
 			$this->config->expects($this->exactly(2))
 				->method('setAppValue')
-				->willReturnCallback(function () use (&$calls) {
+				->willReturnCallback(function() use (&$calls) {
 					$expected = array_shift($calls);
 					$this->assertEquals($expected, func_get_args());
 				});
@@ -188,7 +188,7 @@ 
 		];
 		$this->config->expects($this->exactly(2))
 			->method('setAppValue')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -208,7 +208,7 @@ 
 		$this->decryptAll->expects($this->once())
 			->method('decryptAll')
 			->with($this->consoleInput, $this->consoleOutput, 'user1')
-			->willReturnCallback(function () {
+			->willReturnCallback(function() {
 				throw new \Exception();
 			});
 

tests/Core/Command/Encryption/ChangeKeyStorageRootTest.php

Indentation +339 added lines, -339 removed lines

@@ -20,343 +20,343 @@
 use Test\TestCase;
 
 class ChangeKeyStorageRootTest extends TestCase {
-	/** @var ChangeKeyStorageRoot */
-	protected $changeKeyStorageRoot;
-
-	/** @var View | \PHPUnit\Framework\MockObject\MockObject */
-	protected $view;
-
-	/** @var IUserManager | \PHPUnit\Framework\MockObject\MockObject */
-	protected $userManager;
-
-	/** @var IConfig | \PHPUnit\Framework\MockObject\MockObject */
-	protected $config;
-
-	/** @var Util | \PHPUnit\Framework\MockObject\MockObject */
-	protected $util;
-
-	/** @var QuestionHelper | \PHPUnit\Framework\MockObject\MockObject */
-	protected $questionHelper;
-
-	/** @var InputInterface | \PHPUnit\Framework\MockObject\MockObject */
-	protected $inputInterface;
-
-	/** @var OutputInterface | \PHPUnit\Framework\MockObject\MockObject */
-	protected $outputInterface;
-
-	/** @var \OCP\UserInterface |  \PHPUnit\Framework\MockObject\MockObject */
-	protected $userInterface;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->view = $this->getMockBuilder(View::class)->getMock();
-		$this->userManager = $this->getMockBuilder(IUserManager::class)->getMock();
-		$this->config = $this->getMockBuilder(IConfig::class)->getMock();
-		$this->util = $this->getMockBuilder('OC\Encryption\Util')->disableOriginalConstructor()->getMock();
-		$this->questionHelper = $this->getMockBuilder(QuestionHelper::class)->getMock();
-		$this->inputInterface = $this->getMockBuilder(InputInterface::class)->getMock();
-		$this->outputInterface = $this->getMockBuilder(OutputInterface::class)->getMock();
-		$this->userInterface = $this->getMockBuilder(UserInterface::class)->getMock();
-
-		/* We need format method to return a string */
-		$outputFormatter = $this->createMock(OutputFormatterInterface::class);
-		$outputFormatter->method('isDecorated')->willReturn(false);
-		$outputFormatter->method('format')->willReturnArgument(0);
-
-		$this->outputInterface->expects($this->any())->method('getFormatter')
-			->willReturn($outputFormatter);
-
-		$this->changeKeyStorageRoot = new ChangeKeyStorageRoot(
-			$this->view,
-			$this->userManager,
-			$this->config,
-			$this->util,
-			$this->questionHelper
-		);
-	}
-
-	/**
-	 * @dataProvider dataTestExecute
-	 */
-	public function testExecute($newRoot, $answer, $successMoveKey): void {
-		$changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
-			->setConstructorArgs(
-				[
-					$this->view,
-					$this->userManager,
-					$this->config,
-					$this->util,
-					$this->questionHelper
-				]
-			)->onlyMethods(['moveAllKeys'])->getMock();
-
-		$this->util->expects($this->once())->method('getKeyStorageRoot')
-			->willReturn('');
-		$this->inputInterface->expects($this->once())->method('getArgument')
-			->with('newRoot')->willReturn($newRoot);
-
-		if ($answer === true || $newRoot !== null) {
-			$changeKeyStorageRoot->expects($this->once())->method('moveAllKeys')
-				->willReturn($successMoveKey);
-		} else {
-			$changeKeyStorageRoot->expects($this->never())->method('moveAllKeys');
-		}
-
-		if ($successMoveKey === true) {
-			$this->util->expects($this->once())->method('setKeyStorageRoot');
-		} else {
-			$this->util->expects($this->never())->method('setKeyStorageRoot');
-		}
-
-		if ($newRoot === null) {
-			$this->questionHelper->expects($this->once())->method('ask')->willReturn($answer);
-		} else {
-			$this->questionHelper->expects($this->never())->method('ask');
-		}
-
-		$this->invokePrivate(
-			$changeKeyStorageRoot,
-			'execute',
-			[$this->inputInterface, $this->outputInterface]
-		);
-	}
-
-	public static function dataTestExecute(): array {
-		return [
-			[null, true, true],
-			[null, true, false],
-			[null, false, null],
-			['/newRoot', null, true],
-			['/newRoot', null, false]
-		];
-	}
-
-	public function testMoveAllKeys(): void {
-		/** @var \OC\Core\Command\Encryption\ChangeKeyStorageRoot $changeKeyStorageRoot */
-		$changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
-			->setConstructorArgs(
-				[
-					$this->view,
-					$this->userManager,
-					$this->config,
-					$this->util,
-					$this->questionHelper
-				]
-			)->onlyMethods(['prepareNewRoot', 'moveSystemKeys', 'moveUserKeys'])->getMock();
-
-		$changeKeyStorageRoot->expects($this->once())->method('prepareNewRoot')->with('newRoot');
-		$changeKeyStorageRoot->expects($this->once())->method('moveSystemKeys')->with('oldRoot', 'newRoot');
-		$changeKeyStorageRoot->expects($this->once())->method('moveUserKeys')->with('oldRoot', 'newRoot', $this->outputInterface);
-
-		$this->invokePrivate($changeKeyStorageRoot, 'moveAllKeys', ['oldRoot', 'newRoot', $this->outputInterface]);
-	}
-
-	public function testPrepareNewRoot(): void {
-		$this->view->expects($this->once())->method('is_dir')->with('newRoot')
-			->willReturn(true);
-
-		$this->view->expects($this->once())->method('file_put_contents')
-			->with('newRoot/' . \OC\Encryption\Keys\Storage::KEY_STORAGE_MARKER,
-				'Nextcloud will detect this folder as key storage root only if this file exists')->willReturn(true);
-
-		$this->invokePrivate($this->changeKeyStorageRoot, 'prepareNewRoot', ['newRoot']);
-	}
-
-	/**
-	 * @dataProvider dataTestPrepareNewRootException
-	 *
-	 * @param bool $dirExists
-	 * @param bool $couldCreateFile
-	 */
-	public function testPrepareNewRootException($dirExists, $couldCreateFile): void {
-		$this->expectException(\Exception::class);
-
-		$this->view->expects($this->once())->method('is_dir')->with('newRoot')
-			->willReturn($dirExists);
-		$this->view->expects($this->any())->method('file_put_contents')->willReturn($couldCreateFile);
-
-		$this->invokePrivate($this->changeKeyStorageRoot, 'prepareNewRoot', ['newRoot']);
-	}
-
-	public static function dataTestPrepareNewRootException(): array {
-		return [
-			[true, false],
-			[true, null],
-			[false, true]
-		];
-	}
-
-	/**
-	 * @dataProvider dataTestMoveSystemKeys
-	 *
-	 * @param bool $dirExists
-	 * @param bool $targetExists
-	 * @param bool $executeRename
-	 */
-	public function testMoveSystemKeys($dirExists, $targetExists, $executeRename): void {
-		$changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
-			->setConstructorArgs(
-				[
-					$this->view,
-					$this->userManager,
-					$this->config,
-					$this->util,
-					$this->questionHelper
-				]
-			)->onlyMethods(['targetExists'])->getMock();
-
-		$this->view->expects($this->once())->method('is_dir')
-			->with('oldRoot/files_encryption')->willReturn($dirExists);
-		$changeKeyStorageRoot->expects($this->any())->method('targetExists')
-			->with('newRoot/files_encryption')->willReturn($targetExists);
-
-		if ($executeRename) {
-			$this->view->expects($this->once())->method('rename')
-				->with('oldRoot/files_encryption', 'newRoot/files_encryption');
-		} else {
-			$this->view->expects($this->never())->method('rename');
-		}
-
-		$this->invokePrivate($changeKeyStorageRoot, 'moveSystemKeys', ['oldRoot', 'newRoot']);
-	}
-
-	public static function dataTestMoveSystemKeys(): array {
-		return [
-			[true, false, true],
-			[false, true, false],
-			[true, true, false],
-			[false, false, false]
-		];
-	}
-
-
-	public function testMoveUserKeys(): void {
-		$changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
-			->setConstructorArgs(
-				[
-					$this->view,
-					$this->userManager,
-					$this->config,
-					$this->util,
-					$this->questionHelper
-				]
-			)->onlyMethods(['setupUserFS', 'moveUserEncryptionFolder'])->getMock();
-
-		$this->userManager->expects($this->once())->method('getBackends')
-			->willReturn([$this->userInterface]);
-		$this->userInterface->expects($this->once())->method('getUsers')
-			->willReturn(['user1', 'user2']);
-		$changeKeyStorageRoot->expects($this->exactly(2))->method('setupUserFS');
-		$changeKeyStorageRoot->expects($this->exactly(2))->method('moveUserEncryptionFolder');
-
-		$this->invokePrivate($changeKeyStorageRoot, 'moveUserKeys', ['oldRoot', 'newRoot', $this->outputInterface]);
-	}
-
-	/**
-	 * @dataProvider dataTestMoveUserEncryptionFolder
-	 *
-	 * @param bool $userExists
-	 * @param bool $isDir
-	 * @param bool $targetExists
-	 * @param bool $shouldRename
-	 */
-	public function testMoveUserEncryptionFolder($userExists, $isDir, $targetExists, $shouldRename): void {
-		$changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
-			->setConstructorArgs(
-				[
-					$this->view,
-					$this->userManager,
-					$this->config,
-					$this->util,
-					$this->questionHelper
-				]
-			)->onlyMethods(['targetExists', 'prepareParentFolder'])->getMock();
-
-		$this->userManager->expects($this->once())->method('userExists')
-			->willReturn($userExists);
-		$this->view->expects($this->any())->method('is_dir')
-			->willReturn($isDir);
-		$changeKeyStorageRoot->expects($this->any())->method('targetExists')
-			->willReturn($targetExists);
-
-		if ($shouldRename) {
-			$changeKeyStorageRoot->expects($this->once())->method('prepareParentFolder')
-				->with('newRoot/user1');
-			$this->view->expects($this->once())->method('rename')
-				->with('oldRoot/user1/files_encryption', 'newRoot/user1/files_encryption');
-		} else {
-			$changeKeyStorageRoot->expects($this->never())->method('prepareParentFolder');
-			$this->view->expects($this->never())->method('rename');
-		}
-
-		$this->invokePrivate($changeKeyStorageRoot, 'moveUserEncryptionFolder', ['user1', 'oldRoot', 'newRoot']);
-	}
-
-	public static function dataTestMoveUserEncryptionFolder(): array {
-		return [
-			[true, true, false, true],
-			[true, false, true, false],
-			[false, true, true, false],
-			[false, false, true, false],
-			[false, true, false, false],
-			[false, true, true, false],
-			[false, false, false, false]
-		];
-	}
-
-
-	/**
-	 * @dataProvider dataTestPrepareParentFolder
-	 */
-	public function testPrepareParentFolder($path, $pathExists): void {
-		$this->view->expects($this->any())->method('file_exists')
-			->willReturnCallback(
-				function ($fileExistsPath) use ($path, $pathExists) {
-					if ($path === $fileExistsPath) {
-						return $pathExists;
-					}
-					return false;
-				}
-			);
-
-		if ($pathExists === false) {
-			$subDirs = explode('/', ltrim($path, '/'));
-			$this->view->expects($this->exactly(count($subDirs)))->method('mkdir');
-		} else {
-			$this->view->expects($this->never())->method('mkdir');
-		}
-
-		$this->invokePrivate(
-			$this->changeKeyStorageRoot,
-			'prepareParentFolder',
-			[$path]
-		);
-	}
-
-	public static function dataTestPrepareParentFolder(): array {
-		return [
-			['/user/folder/sub_folder/keystorage', true],
-			['/user/folder/sub_folder/keystorage', false]
-		];
-	}
-
-	public function testTargetExists(): void {
-		$this->view->expects($this->once())->method('file_exists')->with('path')
-			->willReturn(false);
-
-		$this->assertFalse(
-			$this->invokePrivate($this->changeKeyStorageRoot, 'targetExists', ['path'])
-		);
-	}
-
-
-	public function testTargetExistsException(): void {
-		$this->expectException(\Exception::class);
-
-		$this->view->expects($this->once())->method('file_exists')->with('path')
-			->willReturn(true);
-
-		$this->invokePrivate($this->changeKeyStorageRoot, 'targetExists', ['path']);
-	}
+    /** @var ChangeKeyStorageRoot */
+    protected $changeKeyStorageRoot;
+
+    /** @var View | \PHPUnit\Framework\MockObject\MockObject */
+    protected $view;
+
+    /** @var IUserManager | \PHPUnit\Framework\MockObject\MockObject */
+    protected $userManager;
+
+    /** @var IConfig | \PHPUnit\Framework\MockObject\MockObject */
+    protected $config;
+
+    /** @var Util | \PHPUnit\Framework\MockObject\MockObject */
+    protected $util;
+
+    /** @var QuestionHelper | \PHPUnit\Framework\MockObject\MockObject */
+    protected $questionHelper;
+
+    /** @var InputInterface | \PHPUnit\Framework\MockObject\MockObject */
+    protected $inputInterface;
+
+    /** @var OutputInterface | \PHPUnit\Framework\MockObject\MockObject */
+    protected $outputInterface;
+
+    /** @var \OCP\UserInterface |  \PHPUnit\Framework\MockObject\MockObject */
+    protected $userInterface;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->view = $this->getMockBuilder(View::class)->getMock();
+        $this->userManager = $this->getMockBuilder(IUserManager::class)->getMock();
+        $this->config = $this->getMockBuilder(IConfig::class)->getMock();
+        $this->util = $this->getMockBuilder('OC\Encryption\Util')->disableOriginalConstructor()->getMock();
+        $this->questionHelper = $this->getMockBuilder(QuestionHelper::class)->getMock();
+        $this->inputInterface = $this->getMockBuilder(InputInterface::class)->getMock();
+        $this->outputInterface = $this->getMockBuilder(OutputInterface::class)->getMock();
+        $this->userInterface = $this->getMockBuilder(UserInterface::class)->getMock();
+
+        /* We need format method to return a string */
+        $outputFormatter = $this->createMock(OutputFormatterInterface::class);
+        $outputFormatter->method('isDecorated')->willReturn(false);
+        $outputFormatter->method('format')->willReturnArgument(0);
+
+        $this->outputInterface->expects($this->any())->method('getFormatter')
+            ->willReturn($outputFormatter);
+
+        $this->changeKeyStorageRoot = new ChangeKeyStorageRoot(
+            $this->view,
+            $this->userManager,
+            $this->config,
+            $this->util,
+            $this->questionHelper
+        );
+    }
+
+    /**
+     * @dataProvider dataTestExecute
+     */
+    public function testExecute($newRoot, $answer, $successMoveKey): void {
+        $changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
+            ->setConstructorArgs(
+                [
+                    $this->view,
+                    $this->userManager,
+                    $this->config,
+                    $this->util,
+                    $this->questionHelper
+                ]
+            )->onlyMethods(['moveAllKeys'])->getMock();
+
+        $this->util->expects($this->once())->method('getKeyStorageRoot')
+            ->willReturn('');
+        $this->inputInterface->expects($this->once())->method('getArgument')
+            ->with('newRoot')->willReturn($newRoot);
+
+        if ($answer === true || $newRoot !== null) {
+            $changeKeyStorageRoot->expects($this->once())->method('moveAllKeys')
+                ->willReturn($successMoveKey);
+        } else {
+            $changeKeyStorageRoot->expects($this->never())->method('moveAllKeys');
+        }
+
+        if ($successMoveKey === true) {
+            $this->util->expects($this->once())->method('setKeyStorageRoot');
+        } else {
+            $this->util->expects($this->never())->method('setKeyStorageRoot');
+        }
+
+        if ($newRoot === null) {
+            $this->questionHelper->expects($this->once())->method('ask')->willReturn($answer);
+        } else {
+            $this->questionHelper->expects($this->never())->method('ask');
+        }
+
+        $this->invokePrivate(
+            $changeKeyStorageRoot,
+            'execute',
+            [$this->inputInterface, $this->outputInterface]
+        );
+    }
+
+    public static function dataTestExecute(): array {
+        return [
+            [null, true, true],
+            [null, true, false],
+            [null, false, null],
+            ['/newRoot', null, true],
+            ['/newRoot', null, false]
+        ];
+    }
+
+    public function testMoveAllKeys(): void {
+        /** @var \OC\Core\Command\Encryption\ChangeKeyStorageRoot $changeKeyStorageRoot */
+        $changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
+            ->setConstructorArgs(
+                [
+                    $this->view,
+                    $this->userManager,
+                    $this->config,
+                    $this->util,
+                    $this->questionHelper
+                ]
+            )->onlyMethods(['prepareNewRoot', 'moveSystemKeys', 'moveUserKeys'])->getMock();
+
+        $changeKeyStorageRoot->expects($this->once())->method('prepareNewRoot')->with('newRoot');
+        $changeKeyStorageRoot->expects($this->once())->method('moveSystemKeys')->with('oldRoot', 'newRoot');
+        $changeKeyStorageRoot->expects($this->once())->method('moveUserKeys')->with('oldRoot', 'newRoot', $this->outputInterface);
+
+        $this->invokePrivate($changeKeyStorageRoot, 'moveAllKeys', ['oldRoot', 'newRoot', $this->outputInterface]);
+    }
+
+    public function testPrepareNewRoot(): void {
+        $this->view->expects($this->once())->method('is_dir')->with('newRoot')
+            ->willReturn(true);
+
+        $this->view->expects($this->once())->method('file_put_contents')
+            ->with('newRoot/' . \OC\Encryption\Keys\Storage::KEY_STORAGE_MARKER,
+                'Nextcloud will detect this folder as key storage root only if this file exists')->willReturn(true);
+
+        $this->invokePrivate($this->changeKeyStorageRoot, 'prepareNewRoot', ['newRoot']);
+    }
+
+    /**
+     * @dataProvider dataTestPrepareNewRootException
+     *
+     * @param bool $dirExists
+     * @param bool $couldCreateFile
+     */
+    public function testPrepareNewRootException($dirExists, $couldCreateFile): void {
+        $this->expectException(\Exception::class);
+
+        $this->view->expects($this->once())->method('is_dir')->with('newRoot')
+            ->willReturn($dirExists);
+        $this->view->expects($this->any())->method('file_put_contents')->willReturn($couldCreateFile);
+
+        $this->invokePrivate($this->changeKeyStorageRoot, 'prepareNewRoot', ['newRoot']);
+    }
+
+    public static function dataTestPrepareNewRootException(): array {
+        return [
+            [true, false],
+            [true, null],
+            [false, true]
+        ];
+    }
+
+    /**
+     * @dataProvider dataTestMoveSystemKeys
+     *
+     * @param bool $dirExists
+     * @param bool $targetExists
+     * @param bool $executeRename
+     */
+    public function testMoveSystemKeys($dirExists, $targetExists, $executeRename): void {
+        $changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
+            ->setConstructorArgs(
+                [
+                    $this->view,
+                    $this->userManager,
+                    $this->config,
+                    $this->util,
+                    $this->questionHelper
+                ]
+            )->onlyMethods(['targetExists'])->getMock();
+
+        $this->view->expects($this->once())->method('is_dir')
+            ->with('oldRoot/files_encryption')->willReturn($dirExists);
+        $changeKeyStorageRoot->expects($this->any())->method('targetExists')
+            ->with('newRoot/files_encryption')->willReturn($targetExists);
+
+        if ($executeRename) {
+            $this->view->expects($this->once())->method('rename')
+                ->with('oldRoot/files_encryption', 'newRoot/files_encryption');
+        } else {
+            $this->view->expects($this->never())->method('rename');
+        }
+
+        $this->invokePrivate($changeKeyStorageRoot, 'moveSystemKeys', ['oldRoot', 'newRoot']);
+    }
+
+    public static function dataTestMoveSystemKeys(): array {
+        return [
+            [true, false, true],
+            [false, true, false],
+            [true, true, false],
+            [false, false, false]
+        ];
+    }
+
+
+    public function testMoveUserKeys(): void {
+        $changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
+            ->setConstructorArgs(
+                [
+                    $this->view,
+                    $this->userManager,
+                    $this->config,
+                    $this->util,
+                    $this->questionHelper
+                ]
+            )->onlyMethods(['setupUserFS', 'moveUserEncryptionFolder'])->getMock();
+
+        $this->userManager->expects($this->once())->method('getBackends')
+            ->willReturn([$this->userInterface]);
+        $this->userInterface->expects($this->once())->method('getUsers')
+            ->willReturn(['user1', 'user2']);
+        $changeKeyStorageRoot->expects($this->exactly(2))->method('setupUserFS');
+        $changeKeyStorageRoot->expects($this->exactly(2))->method('moveUserEncryptionFolder');
+
+        $this->invokePrivate($changeKeyStorageRoot, 'moveUserKeys', ['oldRoot', 'newRoot', $this->outputInterface]);
+    }
+
+    /**
+     * @dataProvider dataTestMoveUserEncryptionFolder
+     *
+     * @param bool $userExists
+     * @param bool $isDir
+     * @param bool $targetExists
+     * @param bool $shouldRename
+     */
+    public function testMoveUserEncryptionFolder($userExists, $isDir, $targetExists, $shouldRename): void {
+        $changeKeyStorageRoot = $this->getMockBuilder('OC\Core\Command\Encryption\ChangeKeyStorageRoot')
+            ->setConstructorArgs(
+                [
+                    $this->view,
+                    $this->userManager,
+                    $this->config,
+                    $this->util,
+                    $this->questionHelper
+                ]
+            )->onlyMethods(['targetExists', 'prepareParentFolder'])->getMock();
+
+        $this->userManager->expects($this->once())->method('userExists')
+            ->willReturn($userExists);
+        $this->view->expects($this->any())->method('is_dir')
+            ->willReturn($isDir);
+        $changeKeyStorageRoot->expects($this->any())->method('targetExists')
+            ->willReturn($targetExists);
+
+        if ($shouldRename) {
+            $changeKeyStorageRoot->expects($this->once())->method('prepareParentFolder')
+                ->with('newRoot/user1');
+            $this->view->expects($this->once())->method('rename')
+                ->with('oldRoot/user1/files_encryption', 'newRoot/user1/files_encryption');
+        } else {
+            $changeKeyStorageRoot->expects($this->never())->method('prepareParentFolder');
+            $this->view->expects($this->never())->method('rename');
+        }
+
+        $this->invokePrivate($changeKeyStorageRoot, 'moveUserEncryptionFolder', ['user1', 'oldRoot', 'newRoot']);
+    }
+
+    public static function dataTestMoveUserEncryptionFolder(): array {
+        return [
+            [true, true, false, true],
+            [true, false, true, false],
+            [false, true, true, false],
+            [false, false, true, false],
+            [false, true, false, false],
+            [false, true, true, false],
+            [false, false, false, false]
+        ];
+    }
+
+
+    /**
+     * @dataProvider dataTestPrepareParentFolder
+     */
+    public function testPrepareParentFolder($path, $pathExists): void {
+        $this->view->expects($this->any())->method('file_exists')
+            ->willReturnCallback(
+                function ($fileExistsPath) use ($path, $pathExists) {
+                    if ($path === $fileExistsPath) {
+                        return $pathExists;
+                    }
+                    return false;
+                }
+            );
+
+        if ($pathExists === false) {
+            $subDirs = explode('/', ltrim($path, '/'));
+            $this->view->expects($this->exactly(count($subDirs)))->method('mkdir');
+        } else {
+            $this->view->expects($this->never())->method('mkdir');
+        }
+
+        $this->invokePrivate(
+            $this->changeKeyStorageRoot,
+            'prepareParentFolder',
+            [$path]
+        );
+    }
+
+    public static function dataTestPrepareParentFolder(): array {
+        return [
+            ['/user/folder/sub_folder/keystorage', true],
+            ['/user/folder/sub_folder/keystorage', false]
+        ];
+    }
+
+    public function testTargetExists(): void {
+        $this->view->expects($this->once())->method('file_exists')->with('path')
+            ->willReturn(false);
+
+        $this->assertFalse(
+            $this->invokePrivate($this->changeKeyStorageRoot, 'targetExists', ['path'])
+        );
+    }
+
+
+    public function testTargetExistsException(): void {
+        $this->expectException(\Exception::class);
+
+        $this->view->expects($this->once())->method('file_exists')->with('path')
+            ->willReturn(true);
+
+        $this->invokePrivate($this->changeKeyStorageRoot, 'targetExists', ['path']);
+    }
 }