nextcloud / server

tests/Core/Command/Preview/RepairTest.php

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
 		$this->input = $this->createMock(InputInterface::class);
 		$this->input->expects($this->any())
 			->method('getOption')
-			->willReturnCallback(function ($parameter) {
+			->willReturnCallback(function($parameter) {
 				if ($parameter === 'batch') {
 					return true;
 				}
@@ -79,8 +79,8 @@ 
 			->willReturn($outputFormatter);
 		$this->output->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function ($line) use ($self) {
-				$self->outputLines .= $line . "\n";
+			->willReturnCallback(function($line) use ($self) {
+				$self->outputLines .= $line."\n";
 			});
 	}
 
@@ -116,7 +116,7 @@ 
 	public function testEmptyExecute($directoryNames, $expectedOutput): void {
 		$previewFolder = $this->getMockBuilder(Folder::class)
 			->getMock();
-		$directories = array_map(function ($element) {
+		$directories = array_map(function($element) {
 			$dir = $this->getMockBuilder(Folder::class)
 				->getMock();
 			$dir->expects($this->any())

tests/Core/Command/Maintenance/Mimetype/UpdateDBTest.php

Spacing +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
 		];
 		$this->consoleOutput->expects($this->exactly(2))
 			->method('writeln')
-			->willReturnCallback(function ($message) use (&$calls) {
+			->willReturnCallback(function($message) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertStringContainsString($expected, $message);
 			});
@@ -110,7 +110,7 @@ 
 		];
 		$this->consoleOutput->expects($this->exactly(4))
 			->method('writeln')
-			->willReturnCallback(function ($message) use (&$calls) {
+			->willReturnCallback(function($message) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertStringContainsString($expected, $message);
 			});
@@ -163,7 +163,7 @@ 
 		];
 		$this->consoleOutput->expects($this->exactly(3))
 			->method('writeln')
-			->willReturnCallback(function ($message) use (&$calls) {
+			->willReturnCallback(function($message) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertStringContainsString($expected, $message);
 			});

tests/Core/Controller/LoginControllerTest.php

Spacing +6 added lines, -6 removed lines

@@ -99,7 +99,7 @@ 
 
 		$this->l->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
+			->willReturnCallback(function($text, $parameters = []) {
 				return vsprintf($text, $parameters);
 			});
 
@@ -279,7 +279,7 @@ 
 		];
 		$this->initialState->expects($this->exactly(13))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				if (!empty($expected)) {
 					$this->assertEquals($expected, func_get_args());
@@ -316,7 +316,7 @@ 
 		];
 		$this->initialState->expects($this->exactly(14))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				if (!empty($expected)) {
 					$this->assertEquals($expected, func_get_args());
@@ -396,7 +396,7 @@ 
 		];
 		$this->initialState->expects($this->exactly(13))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				if (!empty($expected)) {
 					$this->assertEquals($expected, func_get_args());
@@ -459,7 +459,7 @@ 
 		];
 		$this->initialState->expects($this->exactly(13))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				if (!empty($expected)) {
 					$this->assertEquals($expected, func_get_args());
@@ -670,7 +670,7 @@ 
 		$loginChain->expects($this->once())
 			->method('process')
 			->with($this->equalTo($loginData))
-			->willReturnCallback(function (LoginData $data) use ($loginResult) {
+			->willReturnCallback(function(LoginData $data) use ($loginResult) {
 				$data->setUsername('john');
 				return $loginResult;
 			});

tests/Core/Controller/LostControllerTest.php

Spacing +5 added lines, -5 removed lines

@@ -100,7 +100,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
+			->willReturnCallback(function($text, $parameters = []) {
 				return vsprintf($text, $parameters);
 			});
 		$this->defaults = $this->createMock(Defaults::class);
@@ -180,7 +180,7 @@ 
 		$this->initialState
 			->expects($this->exactly(2))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -461,7 +461,7 @@ 
 		$this->eventDispatcher
 			->expects($this->exactly(2))
 			->method('dispatchTyped')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -591,7 +591,7 @@ 
 		$encryptionModule = $this->createMock(IEncryptionModule::class);
 		$encryptionModule->expects($this->once())->method('needDetailedAccessList')->willReturn(true);
 		$this->encryptionManager->expects($this->once())->method('getEncryptionModules')
-			->willReturn([0 => ['callback' => function () use ($encryptionModule) {
+			->willReturn([0 => ['callback' => function() use ($encryptionModule) {
 				return $encryptionModule;
 			}]]);
 		$response = $this->lostController->setPassword('myToken', 'user', 'newpass', false);
@@ -603,7 +603,7 @@ 
 		$encryptionModule = $this->createMock(IEncryptionModule::class);
 		$encryptionModule->expects($this->once())->method('needDetailedAccessList')->willReturn(false);
 		$this->encryptionManager->expects($this->once())->method('getEncryptionModules')
-			->willReturn([0 => ['callback' => function () use ($encryptionModule) {
+			->willReturn([0 => ['callback' => function() use ($encryptionModule) {
 				return $encryptionModule;
 			}]]);
 		$this->config->method('getUserValue')

tests/Core/Controller/WipeControllerTest.php

Spacing +3 added lines, -3 removed lines

@@ -36,9 +36,9 @@
 	public static function dataTest(): array {
 		return [
 			// valid token, could perform operation, valid result
-			[ true,  true,  true],
-			[ true, false, false],
-			[false,  true, false],
+			[true, true, true],
+			[true, false, false],
+			[false, true, false],
 			[false, false, false],
 		];
 	}

tests/Core/Controller/AutoCompleteControllerTest.php

Spacing +16 added lines, -16 removed lines

@@ -44,7 +44,7 @@ 
 
 	public static function searchDataProvider(): array {
 		return [
-			[ #0 – regular search
+			[#0 – regular search
 				// searchResults
 				[
 					'exact' => [
@@ -58,15 +58,15 @@ 
 				],
 				// expected
 				[
-					[ 'id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
-					[ 'id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
 				],
 				'',
 				'files',
 				'42',
 				null
 			],
-			[ #1 – missing itemtype and id
+			[#1 – missing itemtype and id
 				[
 					'exact' => [
 						'users' => [],
@@ -79,15 +79,15 @@ 
 				],
 				// expected
 				[
-					[ 'id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
-					[ 'id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
 				],
 				'',
 				null,
 				null,
 				null
 			],
-			[ #2 – with sorter
+			[#2 – with sorter
 				[
 					'exact' => [
 						'users' => [],
@@ -100,15 +100,15 @@ 
 				],
 				// expected
 				[
-					[ 'id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
-					[ 'id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
 				],
 				'',
 				'files',
 				'42',
 				'karma|bus-factor'
 			],
-			[ #3 – exact Match
+			[#3 – exact Match
 				[
 					'exact' => [
 						'users' => [
@@ -121,15 +121,15 @@ 
 					],
 				],
 				[
-					[ 'id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
-					[ 'id' => 'bobby', 'label' => 'Robert R.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'bob', 'label' => 'Bob Y.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
+					['id' => 'bobby', 'label' => 'Robert R.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => ''],
 				],
 				'bob',
 				'files',
 				'42',
 				null
 			],
-			[ #4 – with unique name
+			[#4 – with unique name
 				[
 					'exact' => [
 						'users' => [],
@@ -142,8 +142,8 @@ 
 				],
 				// expected
 				[
-					[ 'id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => 'alica@nextcloud.com'],
-					[ 'id' => 'alicea', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => 'alicaa@nextcloud.com'],
+					['id' => 'alice', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => 'alica@nextcloud.com'],
+					['id' => 'alicea', 'label' => 'Alice A.', 'icon' => '', 'source' => 'users', 'status' => '', 'subline' => '', 'shareWithDisplayNameUnique' => 'alicaa@nextcloud.com'],
 				],
 				'',
 				'files',
@@ -168,7 +168,7 @@ 
 		$response = $this->controller->get($searchTerm, $itemType, $itemId, $sorter);
 
 		$list = $response->getData();
-		$this->assertEquals($expected, $list);	// has better error output…
+		$this->assertEquals($expected, $list); // has better error output…
 		$this->assertSame($expected, $list);
 	}
 }

tests/Core/Controller/TwoFactorChallengeControllerTest.php

Spacing +1 added lines, -1 removed lines

@@ -308,7 +308,7 @@
 		];
 		$this->session->expects($this->exactly(2))
 			->method('set')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

tests/Core/Controller/ClientFlowLoginControllerTest.php

Spacing +7 added lines, -7 removed lines

@@ -62,7 +62,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
+			->willReturnCallback(function($text, $parameters = []) {
 				return vsprintf($text, $parameters);
 			});
 		$this->defaults = $this->createMock(Defaults::class);
@@ -127,7 +127,7 @@ 
 			->method('generate')
 			->with(
 				64,
-				ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_DIGITS
+				ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_UPPER.ISecureRandom::CHAR_DIGITS
 			)
 			->willReturn('StateToken');
 		$this->session
@@ -194,7 +194,7 @@ 
 			->method('generate')
 			->with(
 				64,
-				ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_DIGITS
+				ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_UPPER.ISecureRandom::CHAR_DIGITS
 			)
 			->willReturn('StateToken');
 		$this->session
@@ -406,7 +406,7 @@ 
 		];
 		$this->session
 			->method('remove')
-			->willReturnCallback(function ($key) use (&$calls) {
+			->willReturnCallback(function($key) use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $key);
 			});
@@ -432,8 +432,8 @@ 
 		$this->random
 			->method('generate')
 			->willReturnMap([
-				[72, ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_DIGITS, 'MyGeneratedToken'],
-				[128, ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_DIGITS, 'MyAccessCode'],
+				[72, ISecureRandom::CHAR_UPPER.ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_DIGITS, 'MyGeneratedToken'],
+				[128, ISecureRandom::CHAR_UPPER.ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_DIGITS, 'MyAccessCode'],
 			]);
 		$user = $this->createMock(IUser::class);
 		$user
@@ -676,7 +676,7 @@ 
 		$this->eventDispatcher->expects($this->once())
 			->method('dispatchTyped');
 
-		$expected = new Http\RedirectResponse('nc://login/server:' . $expected . '://example.com&user:MyLoginName&password:MyGeneratedToken');
+		$expected = new Http\RedirectResponse('nc://login/server:'.$expected.'://example.com&user:MyLoginName&password:MyGeneratedToken');
 		$this->assertEquals($expected, $this->clientFlowLoginController->generateAppPassword('MyStateToken'));
 	}
 }

tests/Core/Middleware/TwoFactorMiddlewareTest.php

Spacing +3 added lines, -3 removed lines

@@ -208,7 +208,7 @@ 
 
 		$this->reflector
 			->method('hasAnnotation')
-			->willReturnCallback(function (string $annotation) {
+			->willReturnCallback(function(string $annotation) {
 				return $annotation === 'TwoFactorSetUpDoneRequired';
 			});
 		$this->userSession->expects($this->once())
@@ -237,9 +237,9 @@ 
 	public static function dataRequires2FASetupDone(): array {
 		return [
 			[false, false, false],
-			[false,  true,  true],
+			[false, true, true],
 			[true, false, true],
-			[true, true,  true],
+			[true, true, true],
 		];
 	}