Passed
Push — master ( a16703...c6645c )
by John
17:09 queued 13s
created
core/templates/404-profile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 	require_once '../../lib/base.php';
8 8
 
9 9
 	$urlGenerator = \OC::$server->getURLGenerator();
10
-	header('Location: ' . $urlGenerator->getAbsoluteURL('/'));
10
+	header('Location: '.$urlGenerator->getAbsoluteURL('/'));
11 11
 	exit;
12 12
 }
13 13
 // @codeCoverageIgnoreEnd
Please login to merge, or discard this patch.
core/templates/confirmation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 ?>
7 7
 
8 8
 <div class="update">
9
-	<form method="POST" action="<?php print_unescaped($_['targetUrl']);?>">
9
+	<form method="POST" action="<?php print_unescaped($_['targetUrl']); ?>">
10 10
 		<h2><?php p($_['title']) ?></h2>
11 11
 		<p><?php p($_['message']) ?></p>
12 12
 		<div class="buttons">
Please login to merge, or discard this patch.
core/Controller/ProfileApiController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 		$config = $this->configMapper->get($targetUserId);
88 88
 
89 89
 		if (!in_array($paramId, array_keys($config->getVisibilityMap()), true)) {
90
-			throw new OCSBadRequestException('User does not have a profile parameter with ID: ' . $paramId);
90
+			throw new OCSBadRequestException('User does not have a profile parameter with ID: '.$paramId);
91 91
 		}
92 92
 
93 93
 		$config->setVisibility($paramId, $visibility);
Please login to merge, or discard this patch.
core/Migrations/Version23000Date20210930122352.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 				'notnull' => true,
61 61
 			]);
62 62
 			$table->setPrimaryKey(['id']);
63
-			$table->addUniqueIndex(['user_id'], self::TABLE_NAME . '_user_id_idx');
63
+			$table->addUniqueIndex(['user_id'], self::TABLE_NAME.'_user_id_idx');
64 64
 			return $schema;
65 65
 		}
66 66
 
Please login to merge, or discard this patch.
core/Migrations/Version23000Date20211203110726.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 		$table = $schema->getTable(self::TABLE_NAME);
48 48
 		if ($table->hasIndex('user_id')) {
49
-			$table->renameIndex('user_id', self::TABLE_NAME . '_user_id_idx');
49
+			$table->renameIndex('user_id', self::TABLE_NAME.'_user_id_idx');
50 50
 			return $schema;
51 51
 		}
52 52
 		return null;
Please login to merge, or discard this patch.
apps/federation/composer/composer/InstalledVersions.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             return implode(' || ', $ranges);
157 157
         }
158 158
 
159
-        throw new \OutOfBoundsException('Package "' . $packageName . '" is not installed');
159
+        throw new \OutOfBoundsException('Package "'.$packageName.'" is not installed');
160 160
     }
161 161
 
162 162
     /**
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             return $installed['versions'][$packageName]['version'];
178 178
         }
179 179
 
180
-        throw new \OutOfBoundsException('Package "' . $packageName . '" is not installed');
180
+        throw new \OutOfBoundsException('Package "'.$packageName.'" is not installed');
181 181
     }
182 182
 
183 183
     /**
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
             return $installed['versions'][$packageName]['pretty_version'];
199 199
         }
200 200
 
201
-        throw new \OutOfBoundsException('Package "' . $packageName . '" is not installed');
201
+        throw new \OutOfBoundsException('Package "'.$packageName.'" is not installed');
202 202
     }
203 203
 
204 204
     /**
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
             return $installed['versions'][$packageName]['reference'];
220 220
         }
221 221
 
222
-        throw new \OutOfBoundsException('Package "' . $packageName . '" is not installed');
222
+        throw new \OutOfBoundsException('Package "'.$packageName.'" is not installed');
223 223
     }
224 224
 
225 225
     /**
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
             return isset($installed['versions'][$packageName]['install_path']) ? $installed['versions'][$packageName]['install_path'] : null;
237 237
         }
238 238
 
239
-        throw new \OutOfBoundsException('Package "' . $packageName . '" is not installed');
239
+        throw new \OutOfBoundsException('Package "'.$packageName.'" is not installed');
240 240
     }
241 241
 
242 242
     /**
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
             // only require the installed.php file if this file is loaded from its dumped location,
266 266
             // and not from its source location in the composer/composer package, see https://github.com/composer/composer/issues/9937
267 267
             if (substr(__DIR__, -8, 1) !== 'C') {
268
-                self::$installed = include __DIR__ . '/installed.php';
268
+                self::$installed = include __DIR__.'/installed.php';
269 269
             } else {
270 270
                 self::$installed = array();
271 271
             }
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
             // only require the installed.php file if this file is loaded from its dumped location,
339 339
             // and not from its source location in the composer/composer package, see https://github.com/composer/composer/issues/9937
340 340
             if (substr(__DIR__, -8, 1) !== 'C') {
341
-                self::$installed = require __DIR__ . '/installed.php';
341
+                self::$installed = require __DIR__.'/installed.php';
342 342
             } else {
343 343
                 self::$installed = array();
344 344
             }
Please login to merge, or discard this patch.
apps/files/lib/Command/TransferOwnership.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -114,12 +114,12 @@  discard block
 block discarded – undo
114 114
 		$destinationUserObject = $this->userManager->get($input->getArgument('destination-user'));
115 115
 
116 116
 		if (!$sourceUserObject instanceof IUser) {
117
-			$output->writeln("<error>Unknown source user " . $input->getArgument('source-user') . "</error>");
117
+			$output->writeln("<error>Unknown source user ".$input->getArgument('source-user')."</error>");
118 118
 			return 1;
119 119
 		}
120 120
 
121 121
 		if (!$destinationUserObject instanceof IUser) {
122
-			$output->writeln("<error>Unknown destination user " . $input->getArgument('destination-user') . "</error>");
122
+			$output->writeln("<error>Unknown destination user ".$input->getArgument('destination-user')."</error>");
123 123
 			return 1;
124 124
 		}
125 125
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				$includeIncoming
157 157
 			);
158 158
 		} catch (TransferOwnershipException $e) {
159
-			$output->writeln("<error>" . $e->getMessage() . "</error>");
159
+			$output->writeln("<error>".$e->getMessage()."</error>");
160 160
 			return $e->getCode() !== 0 ? $e->getCode() : 1;
161 161
 		}
162 162
 
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 		// for backward compatibility make sure that the remote url stored in the
201 201
 		// database ends with a trailing slash
202 202
 		if (substr($remote, -1) !== '/') {
203
-			$remote = $remote . '/';
203
+			$remote = $remote.'/';
204 204
 		}
205 205
 
206 206
 		$token = $share->getShareSecret();
@@ -227,27 +227,27 @@  discard block
 block discarded – undo
227 227
 
228 228
 			// FIXME this should be a method in the user management instead
229 229
 			if ($shareType === IShare::TYPE_USER) {
230
-				$this->logger->debug('shareWith before, ' . $shareWith, ['app' => 'files_sharing']);
230
+				$this->logger->debug('shareWith before, '.$shareWith, ['app' => 'files_sharing']);
231 231
 				Util::emitHook(
232 232
 					'\OCA\Files_Sharing\API\Server2Server',
233 233
 					'preLoginNameUsedAsUserName',
234 234
 					['uid' => &$shareWith]
235 235
 				);
236
-				$this->logger->debug('shareWith after, ' . $shareWith, ['app' => 'files_sharing']);
236
+				$this->logger->debug('shareWith after, '.$shareWith, ['app' => 'files_sharing']);
237 237
 
238 238
 				if (!$this->userManager->userExists($shareWith)) {
239
-					throw new ProviderCouldNotAddShareException('User does not exists', '',Http::STATUS_BAD_REQUEST);
239
+					throw new ProviderCouldNotAddShareException('User does not exists', '', Http::STATUS_BAD_REQUEST);
240 240
 				}
241 241
 
242 242
 				\OC_Util::setupFS($shareWith);
243 243
 			}
244 244
 
245 245
 			if ($shareType === IShare::TYPE_GROUP && !$this->groupManager->groupExists($shareWith)) {
246
-				throw new ProviderCouldNotAddShareException('Group does not exists', '',Http::STATUS_BAD_REQUEST);
246
+				throw new ProviderCouldNotAddShareException('Group does not exists', '', Http::STATUS_BAD_REQUEST);
247 247
 			}
248 248
 
249 249
 			try {
250
-				$this->externalShareManager->addShare($remote, $token, '', $name, $owner, $shareType,false, $shareWith, $remoteId);
250
+				$this->externalShareManager->addShare($remote, $token, '', $name, $owner, $shareType, false, $shareWith, $remoteId);
251 251
 				$shareId = \OC::$server->getDatabaseConnection()->lastInsertId('*PREFIX*share_external');
252 252
 
253 253
 				if ($shareType === IShare::TYPE_USER) {
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 					'level' => ILogger::ERROR,
280 280
 					'app' => 'files_sharing'
281 281
 				]);
282
-				throw new ProviderCouldNotAddShareException('internal server error, was not able to add share from ' . $remote, '', HTTP::STATUS_INTERNAL_SERVER_ERROR);
282
+				throw new ProviderCouldNotAddShareException('internal server error, was not able to add share from '.$remote, '', HTTP::STATUS_INTERNAL_SERVER_ERROR);
283 283
 			}
284 284
 		}
285 285
 
@@ -345,12 +345,12 @@  discard block
 block discarded – undo
345 345
 
346 346
 		$declineAction = $notification->createAction();
347 347
 		$declineAction->setLabel('decline')
348
-			->setLink($this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending/' . $shareId)), 'DELETE');
348
+			->setLink($this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending/'.$shareId)), 'DELETE');
349 349
 		$notification->addAction($declineAction);
350 350
 
351 351
 		$acceptAction = $notification->createAction();
352 352
 		$acceptAction->setLabel('accept')
353
-			->setLink($this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending/' . $shareId)), 'POST');
353
+			->setLink($this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending/'.$shareId)), 'POST');
354 354
 		$notification->addAction($acceptAction);
355 355
 
356 356
 		$this->notificationManager->notify($notification);
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
 	 */
409 409
 	protected function executeAcceptShare(IShare $share) {
410 410
 		try {
411
-			$fileId = (int)$share->getNode()->getId();
411
+			$fileId = (int) $share->getNode()->getId();
412 412
 			[$file, $link] = $this->getFile($this->getCorrectUid($share), $fileId);
413 413
 		} catch (\Exception $e) {
414 414
 			throw new ShareNotFound();
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
 		$this->federatedShareProvider->removeShareFromTable($share);
485 485
 
486 486
 		try {
487
-			$fileId = (int)$share->getNode()->getId();
487
+			$fileId = (int) $share->getNode()->getId();
488 488
 			[$file, $link] = $this->getFile($this->getCorrectUid($share), $fileId);
489 489
 		} catch (\Exception $e) {
490 490
 			throw new ShareNotFound();
@@ -576,10 +576,10 @@  discard block
 block discarded – undo
576 576
 			// delete all child in case of a group share
577 577
 			$qb = $this->connection->getQueryBuilder();
578 578
 			$qb->delete('share_external')
579
-				->where($qb->expr()->eq('parent', $qb->createNamedParameter((int)$share['id'])));
579
+				->where($qb->expr()->eq('parent', $qb->createNamedParameter((int) $share['id'])));
580 580
 			$qb->execute();
581 581
 
582
-			if ((int)$share['share_type'] === IShare::TYPE_USER) {
582
+			if ((int) $share['share_type'] === IShare::TYPE_USER) {
583 583
 				if ($share['accepted']) {
584 584
 					$path = trim($mountpoint, '/');
585 585
 				} else {
@@ -588,7 +588,7 @@  discard block
 block discarded – undo
588 588
 				$notification = $this->notificationManager->createNotification();
589 589
 				$notification->setApp('files_sharing')
590 590
 					->setUser($share['user'])
591
-					->setObject('remote_share', (int)$share['id']);
591
+					->setObject('remote_share', (int) $share['id']);
592 592
 				$this->notificationManager->markProcessed($notification);
593 593
 
594 594
 				$event = $this->activityManager->generateEvent();
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
 					->setType('remote_share')
597 597
 					->setSubject(RemoteShares::SUBJECT_REMOTE_SHARE_UNSHARED, [$owner->getId(), $path])
598 598
 					->setAffectedUser($user)
599
-					->setObject('remote_share', (int)$share['id'], $path);
599
+					->setObject('remote_share', (int) $share['id'], $path);
600 600
 				\OC::$server->getActivityManager()->publish($event);
601 601
 			}
602 602
 		}
@@ -640,7 +640,7 @@  discard block
 block discarded – undo
640 640
 		$share = $this->federatedShareProvider->getShareById($id);
641 641
 
642 642
 		// We have to respect the default share permissions
643
-		$permissions = $share->getPermissions() & (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL);
643
+		$permissions = $share->getPermissions() & (int) $this->config->getAppValue('core', 'shareapi_default_permissions', (string) Constants::PERMISSION_ALL);
644 644
 		$share->setPermissions($permissions);
645 645
 
646 646
 		// don't allow to share a file back to the owner
@@ -649,7 +649,7 @@  discard block
 block discarded – undo
649 649
 			$owner = $share->getShareOwner();
650 650
 			$currentServer = $this->addressHandler->generateRemoteURL();
651 651
 			if ($this->addressHandler->compareAddresses($user, $remote, $owner, $currentServer)) {
652
-				throw new ProviderCouldNotAddShareException('Resharing back to the owner is not allowed: ' . $id);
652
+				throw new ProviderCouldNotAddShareException('Resharing back to the owner is not allowed: '.$id);
653 653
 			}
654 654
 		} catch (\Exception $e) {
655 655
 			throw new ProviderCouldNotAddShareException($e->getMessage());
@@ -663,10 +663,10 @@  discard block
 block discarded – undo
663 663
 			$share->setSharedBy($share->getSharedWith());
664 664
 			$share->setSharedWith($shareWith);
665 665
 			$result = $this->federatedShareProvider->create($share);
666
-			$this->federatedShareProvider->storeRemoteId((int)$result->getId(), $senderId);
666
+			$this->federatedShareProvider->storeRemoteId((int) $result->getId(), $senderId);
667 667
 			return ['token' => $result->getToken(), 'providerId' => $result->getId()];
668 668
 		} else {
669
-			throw new ProviderCouldNotAddShareException('resharing not allowed for share: ' . $id);
669
+			throw new ProviderCouldNotAddShareException('resharing not allowed for share: '.$id);
670 670
 		}
671 671
 	}
672 672
 
Please login to merge, or discard this patch.
apps/systemtags/lib/AppInfo/Application.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -45,19 +45,19 @@  discard block
 block discarded – undo
45 45
 	}
46 46
 
47 47
 	public function boot(IBootContext $context): void {
48
-		$context->injectFn(function (EventDispatcher $dispatcher) use ($context) {
48
+		$context->injectFn(function(EventDispatcher $dispatcher) use ($context) {
49 49
 			/*
50 50
 			 * @todo move the OCP events and then move the registration to `register`
51 51
 			 */
52 52
 			$dispatcher->addListener(
53 53
 				'OCA\Files::loadAdditionalScripts',
54
-				function () {
54
+				function() {
55 55
 					\OCP\Util::addScript('core', 'systemtags');
56 56
 					\OCP\Util::addScript(self::APP_ID, 'systemtags');
57 57
 				}
58 58
 			);
59 59
 
60
-			$managerListener = function (ManagerEvent $event) use ($context) {
60
+			$managerListener = function(ManagerEvent $event) use ($context) {
61 61
 				/** @var \OCA\SystemTags\Activity\Listener $listener */
62 62
 				$listener = $context->getServerContainer()->query(Listener::class);
63 63
 				$listener->event($event);
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 			$dispatcher->addListener(ManagerEvent::EVENT_DELETE, $managerListener);
67 67
 			$dispatcher->addListener(ManagerEvent::EVENT_UPDATE, $managerListener);
68 68
 
69
-			$mapperListener = function (MapperEvent $event) use ($context) {
69
+			$mapperListener = function(MapperEvent $event) use ($context) {
70 70
 				/** @var \OCA\SystemTags\Activity\Listener $listener */
71 71
 				$listener = $context->getServerContainer()->query(Listener::class);
72 72
 				$listener->mapperEvent($event);
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 			$dispatcher->addListener(MapperEvent::EVENT_UNASSIGN, $mapperListener);
76 76
 		});
77 77
 
78
-		\OCA\Files\App::getNavigationManager()->add(function () {
78
+		\OCA\Files\App::getNavigationManager()->add(function() {
79 79
 			$l = \OC::$server->getL10N(self::APP_ID);
80 80
 			return [
81 81
 				'id' => 'systemtagsfilter',
Please login to merge, or discard this patch.