Passed
Push — master ( a16703...c6645c )
by John
17:09 queued 13s
created
core/Command/Maintenance/Install.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
 			// ignore the OS X setup warning
98 98
 			if (count($errors) !== 1 ||
99
-				(string)$errors[0]['error'] !== 'Mac OS X is not supported and Nextcloud will not work properly on this platform. Use it at your own risk! ') {
99
+				(string) $errors[0]['error'] !== 'Mac OS X is not supported and Nextcloud will not work properly on this platform. Use it at your own risk! ') {
100 100
 				return 1;
101 101
 			}
102 102
 		}
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 		}
140 140
 		if ($dbPort) {
141 141
 			// Append the port to the host so it is the same as in the config (there is no dbport config)
142
-			$dbHost .= ':' . $dbPort;
142
+			$dbHost .= ':'.$dbPort;
143 143
 		}
144 144
 		if ($input->hasParameterOption('--database-pass')) {
145 145
 			$dbPass = (string) $input->getOption('database-pass');
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 		}
177 177
 
178 178
 		if ($adminEmail !== null && !filter_var($adminEmail, FILTER_VALIDATE_EMAIL)) {
179
-			throw new InvalidArgumentException('Invalid e-mail-address <' . $adminEmail . '> for <' . $adminLogin . '>.');
179
+			throw new InvalidArgumentException('Invalid e-mail-address <'.$adminEmail.'> for <'.$adminLogin.'>.');
180 180
 		}
181 181
 
182 182
 		$options = [
@@ -203,25 +203,25 @@  discard block
 block discarded – undo
203 203
 	protected function printErrors(OutputInterface $output, $errors) {
204 204
 		foreach ($errors as $error) {
205 205
 			if (is_array($error)) {
206
-				$output->writeln('<error>' . $error['error'] . '</error>');
206
+				$output->writeln('<error>'.$error['error'].'</error>');
207 207
 				if (isset($error['hint']) && !empty($error['hint'])) {
208
-					$output->writeln('<info> -> ' . $error['hint'] . '</info>');
208
+					$output->writeln('<info> -> '.$error['hint'].'</info>');
209 209
 				}
210 210
 				if (isset($error['exception']) && $error['exception'] instanceof Throwable) {
211 211
 					$this->printThrowable($output, $error['exception']);
212 212
 				}
213 213
 			} else {
214
-				$output->writeln('<error>' . $error . '</error>');
214
+				$output->writeln('<error>'.$error.'</error>');
215 215
 			}
216 216
 		}
217 217
 	}
218 218
 
219 219
 	private function printThrowable(OutputInterface $output, Throwable $t): void {
220
-		$output->write('<info>Trace: ' . $t->getTraceAsString() . '</info>');
220
+		$output->write('<info>Trace: '.$t->getTraceAsString().'</info>');
221 221
 		$output->writeln('');
222 222
 		if ($t->getPrevious() !== null) {
223 223
 			$output->writeln('');
224
-			$output->writeln('<info>Previous: ' . get_class($t->getPrevious()) . ': ' . $t->getPrevious()->getMessage() . '</info>');
224
+			$output->writeln('<info>Previous: '.get_class($t->getPrevious()).': '.$t->getPrevious()->getMessage().'</info>');
225 225
 			$this->printThrowable($output, $t->getPrevious());
226 226
 		}
227 227
 	}
Please login to merge, or discard this patch.
lib/private/Setup/OCI.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -70,18 +70,18 @@
 block discarded – undo
70 70
 			$errorMessage = $this->getLastError();
71 71
 			if ($errorMessage) {
72 72
 				throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
73
-					$errorMessage . ' Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
74
-					. ' ORACLE_SID=' . getenv('ORACLE_SID')
75
-					. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
76
-					. ' NLS_LANG=' . getenv('NLS_LANG')
77
-					. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable', 0, $e);
73
+					$errorMessage.' Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
74
+					. ' ORACLE_SID='.getenv('ORACLE_SID')
75
+					. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
76
+					. ' NLS_LANG='.getenv('NLS_LANG')
77
+					. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable', 0, $e);
78 78
 			}
79 79
 			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
80
-				'Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
81
-				. ' ORACLE_SID=' . getenv('ORACLE_SID')
82
-				. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
83
-				. ' NLS_LANG=' . getenv('NLS_LANG')
84
-				. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable', 0, $e);
80
+				'Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
81
+				. ' ORACLE_SID='.getenv('ORACLE_SID')
82
+				. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
83
+				. ' NLS_LANG='.getenv('NLS_LANG')
84
+				. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable', 0, $e);
85 85
 		}
86 86
 
87 87
 		$this->config->setValues([
Please login to merge, or discard this patch.
apps/dav/lib/Migration/BuildCalendarSearchIndex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 		}
75 75
 
76 76
 		$query = $this->db->getQueryBuilder();
77
-		$query->select($query->createFunction('MAX(' . $query->getColumnName('id') . ')'))
77
+		$query->select($query->createFunction('MAX('.$query->getColumnName('id').')'))
78 78
 			->from('calendarobjects');
79 79
 		$result = $query->execute();
80 80
 		$maxId = (int) $result->fetchOne();
Please login to merge, or discard this patch.
apps/dav/lib/Migration/BuildSocialSearchIndex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 		$query->select($query->func()->max('cardid'))
75 75
 			->from('cards_properties')
76 76
 			->where($query->expr()->eq('name', $query->createNamedParameter('X-SOCIALPROFILE')));
77
-		$maxId = (int)$query->execute()->fetchOne();
77
+		$maxId = (int) $query->execute()->fetchOne();
78 78
 
79 79
 		if ($maxId === 0) {
80 80
 			return;
Please login to merge, or discard this patch.
lib/private/DB/SQLiteSessionInit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,8 +58,8 @@
 block discarded – undo
58 58
 	 */
59 59
 	public function postConnect(ConnectionEventArgs $args) {
60 60
 		$sensitive = $this->caseSensitiveLike ? 'true' : 'false';
61
-		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
62
-		$args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
61
+		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = '.$sensitive);
62
+		$args->getConnection()->executeUpdate('PRAGMA journal_mode = '.$this->journalMode);
63 63
 		/** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
64 64
 		$connection = $args->getConnection()->getWrappedConnection();
65 65
 		$pdo = $connection->getWrappedConnection();
Please login to merge, or discard this patch.
lib/private/DB/PgSqlTools.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,9 +54,9 @@
 block discarded – undo
54 54
 	 */
55 55
 	public function resynchronizeDatabaseSequences(Connection $conn) {
56 56
 		$databaseName = $conn->getDatabase();
57
-		$conn->getConfiguration()->setSchemaAssetsFilter(function ($asset) {
57
+		$conn->getConfiguration()->setSchemaAssetsFilter(function($asset) {
58 58
 			/** @var string|AbstractAsset $asset */
59
-			$filterExpression = '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
59
+			$filterExpression = '/^'.preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')).'/';
60 60
 			if ($asset instanceof AbstractAsset) {
61 61
 				return preg_match($filterExpression, $asset->getName()) !== false;
62 62
 			}
Please login to merge, or discard this patch.
lib/private/Repair/RepairMimeTypes.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 		if (empty($this->folderMimeTypeId)) {
72 72
 			$query->setParameter('mimetype', 'httpd/unix-directory');
73 73
 			$result = $query->execute();
74
-			$this->folderMimeTypeId = (int)$result->fetchOne();
74
+			$this->folderMimeTypeId = (int) $result->fetchOne();
75 75
 			$result->closeCursor();
76 76
 		}
77 77
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 			// get target mimetype id
89 89
 			$query->setParameter('mimetype', $mimetype);
90 90
 			$result = $query->execute();
91
-			$mimetypeId = (int)$result->fetchOne();
91
+			$mimetypeId = (int) $result->fetchOne();
92 92
 			$result->closeCursor();
93 93
 
94 94
 			if (!$mimetypeId) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 			// change mimetype for files with x extension
102 102
 			$update->setParameter('mimetype', $mimetypeId)
103
-				->setParameter('name', '%' . $this->connection->escapeLikeParameter('.' . $extension));
103
+				->setParameter('name', '%'.$this->connection->escapeLikeParameter('.'.$extension));
104 104
 			$count += $update->execute();
105 105
 		}
106 106
 
Please login to merge, or discard this patch.
apps/dav/lib/Migration/RegisterBuildReminderIndexBackgroundJob.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 		}
75 75
 
76 76
 		$query = $this->db->getQueryBuilder();
77
-		$query->select($query->createFunction('MAX(' . $query->getColumnName('id') . ')'))
77
+		$query->select($query->createFunction('MAX('.$query->getColumnName('id').')'))
78 78
 			->from('calendarobjects');
79 79
 		$result = $query->execute();
80 80
 		$maxId = (int) $result->fetchOne();
Please login to merge, or discard this patch.
lib/private/App/DependencyAnalyzer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 		if (!is_array($supportedArchitectures)) {
190 190
 			$supportedArchitectures = [$supportedArchitectures];
191 191
 		}
192
-		$supportedArchitectures = array_map(function ($architecture) {
192
+		$supportedArchitectures = array_map(function($architecture) {
193 193
 			return $this->getValue($architecture);
194 194
 		}, $supportedArchitectures);
195 195
 		$currentArchitecture = $this->platform->getArchitecture();
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 		if (!is_array($supportedDatabases)) {
217 217
 			$supportedDatabases = [$supportedDatabases];
218 218
 		}
219
-		$supportedDatabases = array_map(function ($db) {
219
+		$supportedDatabases = array_map(function($db) {
220 220
 			return $this->getValue($db);
221 221
 		}, $supportedDatabases);
222 222
 		$currentDatabase = $this->platform->getDatabase();
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 			return $missing;
317 317
 		}
318 318
 		if (is_array($oss)) {
319
-			$oss = array_map(function ($os) {
319
+			$oss = array_map(function($os) {
320 320
 				return $this->getValue($os);
321 321
 			}, $oss);
322 322
 		} else {
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 				return '10';
388 388
 			default:
389 389
 				if (strpos($version, '9.1.') === 0) {
390
-					$version = '10.0.' . substr($version, 4);
390
+					$version = '10.0.'.substr($version, 4);
391 391
 				}
392 392
 				return $version;
393 393
 		}
@@ -401,6 +401,6 @@  discard block
 block discarded – undo
401 401
 		if (isset($element['@value'])) {
402 402
 			return $element['@value'];
403 403
 		}
404
-		return (string)$element;
404
+		return (string) $element;
405 405
 	}
406 406
 }
Please login to merge, or discard this patch.