Completed
Pull Request — stable9 (#2883)
by Lukas
12:25 queued 06:02
created
lib/private/session/cryptosessiondata.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 
177 177
 	/**
178 178
 	 * @param mixed $offset
179
-	 * @return mixed
179
+	 * @return string|null
180 180
 	 */
181 181
 	public function offsetGet($offset) {
182 182
 		return $this->get($offset);
Please login to merge, or discard this patch.
lib/private/share20/manager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@  discard block
 block discarded – undo
30 30
 use OCP\IUserManager;
31 31
 use OCP\Share\IManager;
32 32
 use OCP\Share\IProviderFactory;
33
-use OC\Share20\Exception\BackendError;
34 33
 use OCP\IConfig;
35 34
 use OCP\IL10N;
36 35
 use OCP\ILogger;
@@ -40,7 +39,6 @@  discard block
 block discarded – undo
40 39
 use OCP\IGroupManager;
41 40
 use OCP\Files\File;
42 41
 use OCP\Files\Folder;
43
-
44 42
 use OCP\Share\Exceptions\ShareNotFound;
45 43
 use OCP\Share\Exceptions\GenericShareException;
46 44
 
Please login to merge, or discard this patch.
lib/private/tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return array_search(strtolower($needle), array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return strtolower(call_user_func(array($tag, $mem)));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/private/template/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 	/**
104 104
 	 * Appends a variable
105 105
 	 * @param string $key key
106
-	 * @param mixed $value value
106
+	 * @param string $value value
107 107
 	 * @return boolean|null
108 108
 	 *
109 109
 	 * This function assigns a variable in an array context. If the key already
Please login to merge, or discard this patch.
lib/private/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
  * make preview_icon available as a simple function
183 183
  * Returns the path to the preview of the image.
184 184
  * @param string $path path of file
185
- * @return link to the preview
185
+ * @return string to the preview
186 186
  */
187 187
 function preview_icon( $path ) {
188 188
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_preview', ['x' => 32, 'y' => 32, 'file' => $path]);
@@ -190,6 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
 /**
192 192
  * @param string $path
193
+ * @param string $token
193 194
  */
194 195
 function publicPreview_icon ( $path, $token ) {
195 196
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
lib/private/user.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -245,6 +245,7 @@
 block discarded – undo
245 245
 
246 246
 	/**
247 247
 	 * Sets user id for session and triggers emit
248
+	 * @param string $uid
248 249
 	 */
249 250
 	public static function setUserId($uid) {
250 251
 		$userSession = \OC::$server->getUserSession();
Please login to merge, or discard this patch.
lib/private/user/session.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	/**
144 144
 	 * get the current active user
145 145
 	 *
146
-	 * @return \OCP\IUser|null Current user, otherwise null
146
+	 * @return null|User Current user, otherwise null
147 147
 	 */
148 148
 	public function getUser() {
149 149
 		// FIXME: This is a quick'n dirty work-around for the incognito mode as
Please login to merge, or discard this patch.
lib/public/app/managerevent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	 * DispatcherEvent constructor.
47 47
 	 *
48 48
 	 * @param string $event
49
-	 * @param $appID
49
+	 * @param string $appID
50 50
 	 * @param \OCP\IGroup[] $groups
51 51
 	 * @since 9.0.0
52 52
 	 */
Please login to merge, or discard this patch.
lib/public/appframework/db/mapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@
 block discarded – undo
335 335
 	 * Returns an db result and throws exceptions when there are more or less
336 336
 	 * results
337 337
 	 * @param string $sql the sql query
338
-	 * @param array $params the parameters of the sql query
338
+	 * @param string[] $params the parameters of the sql query
339 339
 	 * @param int $limit the maximum number of rows
340 340
 	 * @param int $offset from which row we want to start
341 341
 	 * @throws DoesNotExistException if the item does not exist
Please login to merge, or discard this patch.