Completed
Pull Request — master (#2000)
by Jan-Christoph
41:39 queued 28:04
created
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -105,6 +105,9 @@
 block discarded – undo
105 105
 		return $result;
106 106
 	}
107 107
 
108
+	/**
109
+	 * @param string $value
110
+	 */
108 111
 	private function getServersConfig($value) {
109 112
 		$regex = '/' . $value . '$/S';
110 113
 
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	 *
159 159
 	 * By default this excludes the automatically generated birthday calendar
160 160
 	 *
161
-	 * @param $principalUri
161
+	 * @param string $principalUri
162 162
 	 * @param bool $excludeBirthday
163 163
 	 * @return int
164 164
 	 */
@@ -303,6 +303,9 @@  discard block
 block discarded – undo
303 303
 		return array_values($calendars);
304 304
 	}
305 305
 
306
+	/**
307
+	 * @param string $principalUri
308
+	 */
306 309
 	public function getUsersOwnCalendars($principalUri) {
307 310
 		$principalUri = $this->convertPrincipal($principalUri, true);
308 311
 		$fields = array_values($this->propertyMap);
@@ -851,7 +854,7 @@  discard block
 block discarded – undo
851 854
 	 * calendar-data. If the result of a subsequent GET to this object is not
852 855
 	 * the exact same as this request body, you should omit the ETag.
853 856
 	 *
854
-	 * @param mixed $calendarId
857
+	 * @param integer $calendarId
855 858
 	 * @param string $objectUri
856 859
 	 * @param string $calendarData
857 860
 	 * @return string
@@ -894,7 +897,7 @@  discard block
 block discarded – undo
894 897
 	 * calendar-data. If the result of a subsequent GET to this object is not
895 898
 	 * the exact same as this request body, you should omit the ETag.
896 899
 	 *
897
-	 * @param mixed $calendarId
900
+	 * @param integer $calendarId
898 901
 	 * @param string $objectUri
899 902
 	 * @param string $calendarData
900 903
 	 * @return string
@@ -1309,7 +1312,7 @@  discard block
 block discarded – undo
1309 1312
 	 * @param string $principalUri
1310 1313
 	 * @param string $uri
1311 1314
 	 * @param array $properties
1312
-	 * @return mixed
1315
+	 * @return integer
1313 1316
 	 */
1314 1317
 	function createSubscription($principalUri, $uri, array $properties) {
1315 1318
 
@@ -1712,6 +1715,9 @@  discard block
 block discarded – undo
1712 1715
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1713 1716
 	}
1714 1717
 
1718
+	/**
1719
+	 * @param boolean $toV2
1720
+	 */
1715 1721
 	private function convertPrincipal($principalUri, $toV2) {
1716 1722
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1717 1723
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/Repair/Collation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	}
91 91
 
92 92
 	/**
93
-	 * @param \Doctrine\DBAL\Connection $connection
93
+	 * @param IDBConnection $connection
94 94
 	 * @return string[]
95 95
 	 */
96 96
 	protected function getAllNonUTF8BinTables($connection) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 * The deserialize method is called during xml parsing.
62 62
 	 *
63 63
 	 * @param Reader $reader
64
-	 * @return mixed
64
+	 * @return null|ShareTypeList
65 65
 	 */
66 66
 	static function xmlDeserialize(Reader $reader) {
67 67
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 	 * the next element.
81 81
 	 *
82 82
 	 * @param Reader $reader
83
-	 * @return mixed
83
+	 * @return null|TagList
84 84
 	 */
85 85
 	static function xmlDeserialize(Reader $reader) {
86 86
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @param ITagManager $fileTagger manager for private tags
106 106
 	 * @param IUserSession $userSession
107 107
 	 * @param IGroupManager $groupManager
108
-	 * @param Folder $userfolder
108
+	 * @param Folder $userFolder
109 109
 	 */
110 110
 	public function __construct(Tree $tree,
111 111
 								View $view,
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 	 * This will be used in the {DAV:}supported-report-set property.
152 152
 	 *
153 153
 	 * @param string $uri
154
-	 * @return array
154
+	 * @return string[]
155 155
 	 */
156 156
 	public function getSupportedReportSet($uri) {
157 157
 		return [self::REPORT_NAME];
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 * @param string $reportName
164 164
 	 * @param [] $report
165 165
 	 * @param string $uri
166
-	 * @return bool
166
+	 * @return null|false
167 167
 	 * @throws NotFound
168 168
 	 * @throws ReportNotSupported
169 169
 	 */
@@ -336,6 +336,7 @@  discard block
 block discarded – undo
336 336
 	 * with a leading slash but no trailing slash
337 337
 	 * @param string[] $requestedProps requested properties
338 338
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
339
+	 * @param Node[] $nodes
339 340
 	 * @return Response[]
340 341
 	 */
341 342
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 
31 31
 namespace OC\Share;
32 32
 
33
-use DateTime;
34 33
 use OCP\IL10N;
35 34
 use OCP\IURLGenerator;
36 35
 use OCP\IUser;
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 	 * @param bool $isLoggedIn
92 92
 	 * @param bool $isAdminUser
93 93
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
94
-	 * @param CSRFTokenManager $csrfTokenManager
94
+	 * @param CsrfTokenManager $csrfTokenManager
95 95
 	 */
96 96
 	public function __construct(IRequest $request,
97 97
 								ControllerMethodReflector $reflector,
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,6 +175,12 @@  discard block
 block discarded – undo
175 175
 
176 176
 	}
177 177
 
178
+	/**
179
+	 * @param string $link
180
+	 * @param string $owner
181
+	 * @param string $initiator
182
+	 * @param string $shareWith
183
+	 */
178 184
 	private function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
179 185
 		if ($owner === $initiator) {
180 186
 			$subject = (string)$this->l->t('%s shared »%s« with you', array($owner, $filename));
@@ -200,6 +206,7 @@  discard block
 block discarded – undo
200 206
 	 * @param $link
201 207
 	 * @param $owner
202 208
 	 * @param $initiator
209
+	 * @param string $template
203 210
 	 * @return string plain text mail
204 211
 	 * @throws HintException
205 212
 	 */
@@ -639,7 +646,7 @@  discard block
 block discarded – undo
639 646
 	/**
640 647
 	 * get database row of a give share
641 648
 	 *
642
-	 * @param $id
649
+	 * @param integer $id
643 650
 	 * @return array
644 651
 	 * @throws ShareNotFound
645 652
 	 */
Please login to merge, or discard this patch.