Passed
Push — master ( 539c06...513aba )
by Roeland
14:57 queued 10s
created
apps/dav/lib/Upload/UploadFolder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 	}
40 40
 
41 41
 	public function createDirectory($name) {
42
-		throw new Forbidden('Permission denied to create file (filename ' . $name . ')');
42
+		throw new Forbidden('Permission denied to create file (filename '.$name.')');
43 43
 	}
44 44
 
45 45
 	public function getChild($name) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/FutureFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	 */
85 85
 	public function getSize() {
86 86
 		$children = $this->root->getChildren();
87
-		$sizes = array_map(function ($node) {
87
+		$sizes = array_map(function($node) {
88 88
 			/** @var IFile $node */
89 89
 			return $node->getSize();
90 90
 		}, $children);
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/webdav.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
 $requestUri = \OC::$server->getRequest()->getRequestUri();
64 64
 
65
-$server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function () {
65
+$server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function() {
66 66
 	// use the view for the logged in user
67 67
 	return \OC\Files\Filesystem::getView();
68 68
 });
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Scanner.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -88,8 +88,8 @@  discard block
 block discarded – undo
88 88
 		} catch (\Exception $e) {
89 89
 			$this->storage->checkStorageAvailability();
90 90
 			throw new \Exception(
91
-				'Error while scanning remote share: "' .
92
-				$this->storage->getRemote() . '" ' .
91
+				'Error while scanning remote share: "'.
92
+				$this->storage->getRemote().'" '.
93 93
 				$e->getMessage()
94 94
 			);
95 95
 		}
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 			$this->addResult($data['data'], '');
98 98
 		} else {
99 99
 			throw new \Exception(
100
-				'Error while scanning remote share: "' .
101
-				$this->storage->getRemote() . '"'
100
+				'Error while scanning remote share: "'.
101
+				$this->storage->getRemote().'"'
102 102
 			);
103 103
 		}
104 104
 	}
@@ -113,14 +113,14 @@  discard block
 block discarded – undo
113 113
 			$children = [];
114 114
 			foreach ($data['children'] as $child) {
115 115
 				$children[$child['name']] = true;
116
-				$this->addResult($child, ltrim($path . '/' . $child['name'], '/'));
116
+				$this->addResult($child, ltrim($path.'/'.$child['name'], '/'));
117 117
 			}
118 118
 
119 119
 			$existingCache = $this->cache->getFolderContentsById($id);
120 120
 			foreach ($existingCache as $existingChild) {
121 121
 				// if an existing child is not in the new data, remove it
122 122
 				if (!isset($children[$existingChild['name']])) {
123
-					$this->cache->remove(ltrim($path . '/' . $existingChild['name'], '/'));
123
+					$this->cache->remove(ltrim($path.'/'.$existingChild['name'], '/'));
124 124
 				}
125 125
 			}
126 126
 		}
Please login to merge, or discard this patch.
apps/files_sharing/lib/DeleteOrphanedSharesJob.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,8 +55,8 @@
 block discarded – undo
55 55
 		$logger = \OC::$server->getLogger();
56 56
 
57 57
 		$sql =
58
-			'DELETE FROM `*PREFIX*share` ' .
59
-			'WHERE `item_type` in (\'file\', \'folder\') ' .
58
+			'DELETE FROM `*PREFIX*share` '.
59
+			'WHERE `item_type` in (\'file\', \'folder\') '.
60 60
 			'AND NOT EXISTS (SELECT `fileid` FROM `*PREFIX*filecache` WHERE `file_source` = `fileid`)';
61 61
 
62 62
 		$deletedEntries = $connection->executeUpdate($sql);
Please login to merge, or discard this patch.
apps/testing/lib/Controller/LockingController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	 */
101 101
 	protected function getPath($user, $path) {
102 102
 		$node = $this->rootFolder->getUserFolder($user)->get($path);
103
-		return 'files/' . md5($node->getStorage()->getId() . '::' . trim($node->getInternalPath(), '/'));
103
+		return 'files/'.md5($node->getStorage()->getId().'::'.trim($node->getInternalPath(), '/'));
104 104
 	}
105 105
 
106 106
 	/**
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 
137 137
 		try {
138 138
 			$lockingProvider->acquireLock($path, $type);
139
-			$this->config->setAppValue('testing', 'locking_' . $path, $type);
139
+			$this->config->setAppValue('testing', 'locking_'.$path, $type);
140 140
 			return new DataResponse();
141 141
 		} catch (LockedException $e) {
142 142
 			throw new OCSException('', Http::STATUS_LOCKED, $e);
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 
164 164
 		try {
165 165
 			$lockingProvider->changeLock($path, $type);
166
-			$this->config->setAppValue('testing', 'locking_' . $path, $type);
166
+			$this->config->setAppValue('testing', 'locking_'.$path, $type);
167 167
 			return new DataResponse();
168 168
 		} catch (LockedException $e) {
169 169
 			throw new OCSException('', Http::STATUS_LOCKED, $e);
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
 		try {
192 192
 			$lockingProvider->releaseLock($path, $type);
193
-			$this->config->deleteAppValue('testing', 'locking_' . $path);
193
+			$this->config->deleteAppValue('testing', 'locking_'.$path);
194 194
 			return new DataResponse();
195 195
 		} catch (LockedException $e) {
196 196
 			throw new OCSException('', Http::STATUS_LOCKED, $e);
@@ -233,9 +233,9 @@  discard block
 block discarded – undo
233 233
 			if (strpos($lock, 'locking_') === 0) {
234 234
 				$path = substr($lock, strlen('locking_'));
235 235
 
236
-				if ($type === ILockingProvider::LOCK_EXCLUSIVE && (int)$this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_EXCLUSIVE) {
236
+				if ($type === ILockingProvider::LOCK_EXCLUSIVE && (int) $this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_EXCLUSIVE) {
237 237
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));
238
-				} elseif ($type === ILockingProvider::LOCK_SHARED && (int)$this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_SHARED) {
238
+				} elseif ($type === ILockingProvider::LOCK_SHARED && (int) $this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_SHARED) {
239 239
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));
240 240
 				} else {
241 241
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/StorageConfig.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 				if (isset($parameters[$key])) {
221 221
 					switch ($parameters[$key]->getType()) {
222 222
 						case \OCA\Files_External\Lib\DefinitionParameter::VALUE_BOOLEAN:
223
-							$value = (bool)$value;
223
+							$value = (bool) $value;
224 224
 							break;
225 225
 					}
226 226
 					$backendOptions[$key] = $value;
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
 			$result['statusMessage'] = $this->statusMessage;
427 427
 		}
428 428
 		$result['userProvided'] = $this->authMechanism instanceof IUserProvided;
429
-		$result['type'] = ($this->getType() === self::MOUNT_TYPE_PERSONAl) ? 'personal': 'system';
429
+		$result['type'] = ($this->getType() === self::MOUNT_TYPE_PERSONAl) ? 'personal' : 'system';
430 430
 		return $result;
431 431
 	}
432 432
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/Swift.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 					->setFlag(DefinitionParameter::FLAG_OPTIONAL),
51 51
 			])
52 52
 			->addAuthScheme(AuthMechanism::SCHEME_OPENSTACK)
53
-			->setLegacyAuthMechanismCallback(function (array $params) use ($openstackAuth, $rackspaceAuth) {
53
+			->setLegacyAuthMechanismCallback(function(array $params) use ($openstackAuth, $rackspaceAuth) {
54 54
 				if (isset($params['options']['key']) && $params['options']['key']) {
55 55
 					return $rackspaceAuth;
56 56
 				}
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 */
135 135
 	public function requestSharedSecret($url, $token) {
136 136
 		if ($this->trustedServers->isTrustedServer($url) === false) {
137
-			$this->logger->error('remote server not trusted (' . $url . ') while requesting shared secret', ['app' => 'federation']);
137
+			$this->logger->error('remote server not trusted ('.$url.') while requesting shared secret', ['app' => 'federation']);
138 138
 			throw new OCSForbiddenException();
139 139
 		}
140 140
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		$localToken = $this->dbHandler->getToken($url);
144 144
 		if (strcmp($localToken, $token) > 0) {
145 145
 			$this->logger->info(
146
-				'remote server (' . $url . ') presented lower token. We will initiate the exchange of the shared secret.',
146
+				'remote server ('.$url.') presented lower token. We will initiate the exchange of the shared secret.',
147 147
 				['app' => 'federation']
148 148
 			);
149 149
 			throw new OCSForbiddenException();
@@ -183,14 +183,14 @@  discard block
 block discarded – undo
183 183
 	 */
184 184
 	public function getSharedSecret($url, $token) {
185 185
 		if ($this->trustedServers->isTrustedServer($url) === false) {
186
-			$this->logger->error('remote server not trusted (' . $url . ') while getting shared secret', ['app' => 'federation']);
186
+			$this->logger->error('remote server not trusted ('.$url.') while getting shared secret', ['app' => 'federation']);
187 187
 			throw new OCSForbiddenException();
188 188
 		}
189 189
 
190 190
 		if ($this->isValidToken($url, $token) === false) {
191 191
 			$expectedToken = $this->dbHandler->getToken($url);
192 192
 			$this->logger->error(
193
-				'remote server (' . $url . ') didn\'t send a valid token (got "' . $token . '" but expected "'. $expectedToken . '") while getting shared secret',
193
+				'remote server ('.$url.') didn\'t send a valid token (got "'.$token.'" but expected "'.$expectedToken.'") while getting shared secret',
194 194
 				['app' => 'federation']
195 195
 			);
196 196
 			throw new OCSForbiddenException();
Please login to merge, or discard this patch.