Passed
Push — master ( ff6610...e81fdf )
by Robin
14:53 queued 15s
created
core/Command/Integrity/SignCore.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 			$this->checker->writeCoreSignature($x509, $rsa, $path);
100 100
 			$output->writeln('Successfully signed "core"');
101 101
 		} catch (\Exception $e) {
102
-			$output->writeln('Error: ' . $e->getMessage());
102
+			$output->writeln('Error: '.$e->getMessage());
103 103
 			return 1;
104 104
 		}
105 105
 		return 0;
Please login to merge, or discard this patch.
Indentation   +51 added lines, -51 removed lines patch added patch discarded remove patch
@@ -39,63 +39,63 @@
 block discarded – undo
39 39
  * @package OC\Core\Command\Integrity
40 40
  */
41 41
 class SignCore extends Command {
42
-	private Checker $checker;
43
-	private FileAccessHelper $fileAccessHelper;
42
+    private Checker $checker;
43
+    private FileAccessHelper $fileAccessHelper;
44 44
 
45
-	public function __construct(Checker $checker,
46
-								FileAccessHelper $fileAccessHelper) {
47
-		parent::__construct(null);
48
-		$this->checker = $checker;
49
-		$this->fileAccessHelper = $fileAccessHelper;
50
-	}
45
+    public function __construct(Checker $checker,
46
+                                FileAccessHelper $fileAccessHelper) {
47
+        parent::__construct(null);
48
+        $this->checker = $checker;
49
+        $this->fileAccessHelper = $fileAccessHelper;
50
+    }
51 51
 
52
-	protected function configure() {
53
-		$this
54
-			->setName('integrity:sign-core')
55
-			->setDescription('Sign core using a private key.')
56
-			->addOption('privateKey', null, InputOption::VALUE_REQUIRED, 'Path to private key to use for signing')
57
-			->addOption('certificate', null, InputOption::VALUE_REQUIRED, 'Path to certificate to use for signing')
58
-			->addOption('path', null, InputOption::VALUE_REQUIRED, 'Path of core to sign');
59
-	}
52
+    protected function configure() {
53
+        $this
54
+            ->setName('integrity:sign-core')
55
+            ->setDescription('Sign core using a private key.')
56
+            ->addOption('privateKey', null, InputOption::VALUE_REQUIRED, 'Path to private key to use for signing')
57
+            ->addOption('certificate', null, InputOption::VALUE_REQUIRED, 'Path to certificate to use for signing')
58
+            ->addOption('path', null, InputOption::VALUE_REQUIRED, 'Path of core to sign');
59
+    }
60 60
 
61
-	/**
62
-	 * {@inheritdoc }
63
-	 */
64
-	protected function execute(InputInterface $input, OutputInterface $output): int {
65
-		$privateKeyPath = $input->getOption('privateKey');
66
-		$keyBundlePath = $input->getOption('certificate');
67
-		$path = $input->getOption('path');
68
-		if (is_null($privateKeyPath) || is_null($keyBundlePath) || is_null($path)) {
69
-			$output->writeln('--privateKey, --certificate and --path are required.');
70
-			return 1;
71
-		}
61
+    /**
62
+     * {@inheritdoc }
63
+     */
64
+    protected function execute(InputInterface $input, OutputInterface $output): int {
65
+        $privateKeyPath = $input->getOption('privateKey');
66
+        $keyBundlePath = $input->getOption('certificate');
67
+        $path = $input->getOption('path');
68
+        if (is_null($privateKeyPath) || is_null($keyBundlePath) || is_null($path)) {
69
+            $output->writeln('--privateKey, --certificate and --path are required.');
70
+            return 1;
71
+        }
72 72
 
73
-		$privateKey = $this->fileAccessHelper->file_get_contents($privateKeyPath);
74
-		$keyBundle = $this->fileAccessHelper->file_get_contents($keyBundlePath);
73
+        $privateKey = $this->fileAccessHelper->file_get_contents($privateKeyPath);
74
+        $keyBundle = $this->fileAccessHelper->file_get_contents($keyBundlePath);
75 75
 
76
-		if ($privateKey === false) {
77
-			$output->writeln(sprintf('Private key "%s" does not exists.', $privateKeyPath));
78
-			return 1;
79
-		}
76
+        if ($privateKey === false) {
77
+            $output->writeln(sprintf('Private key "%s" does not exists.', $privateKeyPath));
78
+            return 1;
79
+        }
80 80
 
81
-		if ($keyBundle === false) {
82
-			$output->writeln(sprintf('Certificate "%s" does not exists.', $keyBundlePath));
83
-			return 1;
84
-		}
81
+        if ($keyBundle === false) {
82
+            $output->writeln(sprintf('Certificate "%s" does not exists.', $keyBundlePath));
83
+            return 1;
84
+        }
85 85
 
86
-		$rsa = new RSA();
87
-		$rsa->loadKey($privateKey);
88
-		$x509 = new X509();
89
-		$x509->loadX509($keyBundle);
90
-		$x509->setPrivateKey($rsa);
86
+        $rsa = new RSA();
87
+        $rsa->loadKey($privateKey);
88
+        $x509 = new X509();
89
+        $x509->loadX509($keyBundle);
90
+        $x509->setPrivateKey($rsa);
91 91
 
92
-		try {
93
-			$this->checker->writeCoreSignature($x509, $rsa, $path);
94
-			$output->writeln('Successfully signed "core"');
95
-		} catch (\Exception $e) {
96
-			$output->writeln('Error: ' . $e->getMessage());
97
-			return 1;
98
-		}
99
-		return 0;
100
-	}
92
+        try {
93
+            $this->checker->writeCoreSignature($x509, $rsa, $path);
94
+            $output->writeln('Successfully signed "core"');
95
+        } catch (\Exception $e) {
96
+            $output->writeln('Error: ' . $e->getMessage());
97
+            return 1;
98
+        }
99
+        return 0;
100
+    }
101 101
 }
Please login to merge, or discard this patch.
core/Command/TwoFactorAuth/Base.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	 */
52 52
 	public function completeArgumentValues($argumentName, CompletionContext $context) {
53 53
 		if ($argumentName === 'uid') {
54
-			return array_map(function (IUser $user) {
54
+			return array_map(function(IUser $user) {
55 55
 				return $user->getUID();
56 56
 			}, $this->userManager->search($context->getCurrentWord(), 100));
57 57
 		}
Please login to merge, or discard this patch.
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -30,32 +30,32 @@
 block discarded – undo
30 30
 use Stecman\Component\Symfony\Console\BashCompletion\CompletionContext;
31 31
 
32 32
 class Base extends \OC\Core\Command\Base {
33
-	protected IUserManager $userManager;
33
+    protected IUserManager $userManager;
34 34
 
35
-	/**
36
-	 * Return possible values for the named option
37
-	 *
38
-	 * @param string $optionName
39
-	 * @param CompletionContext $context
40
-	 * @return string[]
41
-	 */
42
-	public function completeOptionValues($optionName, CompletionContext $context) {
43
-		return [];
44
-	}
35
+    /**
36
+     * Return possible values for the named option
37
+     *
38
+     * @param string $optionName
39
+     * @param CompletionContext $context
40
+     * @return string[]
41
+     */
42
+    public function completeOptionValues($optionName, CompletionContext $context) {
43
+        return [];
44
+    }
45 45
 
46
-	/**
47
-	 * Return possible values for the named argument
48
-	 *
49
-	 * @param string $argumentName
50
-	 * @param CompletionContext $context
51
-	 * @return string[]
52
-	 */
53
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
54
-		if ($argumentName === 'uid') {
55
-			return array_map(function (IUser $user) {
56
-				return $user->getUID();
57
-			}, $this->userManager->search($context->getCurrentWord(), 100));
58
-		}
59
-		return [];
60
-	}
46
+    /**
47
+     * Return possible values for the named argument
48
+     *
49
+     * @param string $argumentName
50
+     * @param CompletionContext $context
51
+     * @return string[]
52
+     */
53
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
54
+        if ($argumentName === 'uid') {
55
+            return array_map(function (IUser $user) {
56
+                return $user->getUID();
57
+            }, $this->userManager->search($context->getCurrentWord(), 100));
58
+        }
59
+        return [];
60
+    }
61 61
 }
Please login to merge, or discard this patch.
core/Command/Background/Ajax.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class Ajax extends Base {
29
-	protected function getMode() {
30
-		return 'ajax';
31
-	}
29
+    protected function getMode() {
30
+        return 'ajax';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Background/Cron.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class Cron extends Base {
29
-	protected function getMode() {
30
-		return 'cron';
31
-	}
29
+    protected function getMode() {
30
+        return 'cron';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Background/WebCron.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class WebCron extends Base {
29
-	protected function getMode() {
30
-		return 'webcron';
31
-	}
29
+    protected function getMode() {
30
+        return 'webcron';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Encryption/ListModules.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,11 +67,11 @@
 block discarded – undo
67 67
 	 */
68 68
 	protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
69 69
 		if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
70
-			array_walk($items, function (&$item) {
70
+			array_walk($items, function(&$item) {
71 71
 				if (!$item['default']) {
72 72
 					$item = $item['displayName'];
73 73
 				} else {
74
-					$item = $item['displayName'] . ' [default*]';
74
+					$item = $item['displayName'].' [default*]';
75 75
 				}
76 76
 			});
77 77
 		}
Please login to merge, or discard this patch.
Indentation   +51 added lines, -51 removed lines patch added patch discarded remove patch
@@ -30,63 +30,63 @@
 block discarded – undo
30 30
 use Symfony\Component\Console\Output\OutputInterface;
31 31
 
32 32
 class ListModules extends Base {
33
-	protected IManager $encryptionManager;
34
-	protected IConfig $config;
33
+    protected IManager $encryptionManager;
34
+    protected IConfig $config;
35 35
 
36
-	public function __construct(
37
-		IManager $encryptionManager,
38
-		IConfig $config
39
-	) {
40
-		parent::__construct();
41
-		$this->encryptionManager = $encryptionManager;
42
-		$this->config = $config;
43
-	}
36
+    public function __construct(
37
+        IManager $encryptionManager,
38
+        IConfig $config
39
+    ) {
40
+        parent::__construct();
41
+        $this->encryptionManager = $encryptionManager;
42
+        $this->config = $config;
43
+    }
44 44
 
45
-	protected function configure() {
46
-		parent::configure();
45
+    protected function configure() {
46
+        parent::configure();
47 47
 
48
-		$this
49
-			->setName('encryption:list-modules')
50
-			->setDescription('List all available encryption modules')
51
-		;
52
-	}
48
+        $this
49
+            ->setName('encryption:list-modules')
50
+            ->setDescription('List all available encryption modules')
51
+        ;
52
+    }
53 53
 
54
-	protected function execute(InputInterface $input, OutputInterface $output): int {
55
-		$isMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
56
-		if ($isMaintenanceModeEnabled) {
57
-			$output->writeln("Maintenance mode must be disabled when listing modules");
58
-			$output->writeln("in order to list the relevant encryption modules correctly.");
59
-			return 1;
60
-		}
54
+    protected function execute(InputInterface $input, OutputInterface $output): int {
55
+        $isMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
56
+        if ($isMaintenanceModeEnabled) {
57
+            $output->writeln("Maintenance mode must be disabled when listing modules");
58
+            $output->writeln("in order to list the relevant encryption modules correctly.");
59
+            return 1;
60
+        }
61 61
 
62
-		$encryptionModules = $this->encryptionManager->getEncryptionModules();
63
-		$defaultEncryptionModuleId = $this->encryptionManager->getDefaultEncryptionModuleId();
62
+        $encryptionModules = $this->encryptionManager->getEncryptionModules();
63
+        $defaultEncryptionModuleId = $this->encryptionManager->getDefaultEncryptionModuleId();
64 64
 
65
-		$encModules = [];
66
-		foreach ($encryptionModules as $module) {
67
-			$encModules[$module['id']]['displayName'] = $module['displayName'];
68
-			$encModules[$module['id']]['default'] = $module['id'] === $defaultEncryptionModuleId;
69
-		}
70
-		$this->writeModuleList($input, $output, $encModules);
71
-		return 0;
72
-	}
65
+        $encModules = [];
66
+        foreach ($encryptionModules as $module) {
67
+            $encModules[$module['id']]['displayName'] = $module['displayName'];
68
+            $encModules[$module['id']]['default'] = $module['id'] === $defaultEncryptionModuleId;
69
+        }
70
+        $this->writeModuleList($input, $output, $encModules);
71
+        return 0;
72
+    }
73 73
 
74
-	/**
75
-	 * @param InputInterface $input
76
-	 * @param OutputInterface $output
77
-	 * @param array $items
78
-	 */
79
-	protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
80
-		if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
81
-			array_walk($items, function (&$item) {
82
-				if (!$item['default']) {
83
-					$item = $item['displayName'];
84
-				} else {
85
-					$item = $item['displayName'] . ' [default*]';
86
-				}
87
-			});
88
-		}
74
+    /**
75
+     * @param InputInterface $input
76
+     * @param OutputInterface $output
77
+     * @param array $items
78
+     */
79
+    protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
80
+        if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
81
+            array_walk($items, function (&$item) {
82
+                if (!$item['default']) {
83
+                    $item = $item['displayName'];
84
+                } else {
85
+                    $item = $item['displayName'] . ' [default*]';
86
+                }
87
+            });
88
+        }
89 89
 
90
-		$this->writeArrayInOutputFormat($input, $output, $items);
91
-	}
90
+        $this->writeArrayInOutputFormat($input, $output, $items);
91
+    }
92 92
 }
Please login to merge, or discard this patch.
core/templates/twofactorshowchallenge.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,8 +16,11 @@
 block discarded – undo
16 16
 	<?php if ($error): ?>
17 17
 			<?php if ($error_message): ?>
18 18
 				<p><strong><?php p($error_message); ?></strong></p>
19
-			<?php else: ?>
20
-				<p><strong><?php p($l->t('Error while validating your second factor')); ?></strong></p>
19
+			<?php else {
20
+    : ?>
21
+				<p><strong><?php p($l->t('Error while validating your second factor'));
22
+}
23
+?></strong></p>
21 24
 			<?php endif; ?>
22 25
 	<?php endif; ?>
23 26
 	<?php print_unescaped($template); ?>
Please login to merge, or discard this patch.
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,11 +24,11 @@
 block discarded – undo
24 24
 	<?php if (!is_null($_['backupProvider'])): ?>
25 25
 	<p>
26 26
 		<a class="two-factor-secondary" href="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.showChallenge',
27
-			[
28
-				'challengeProviderId' => $_['backupProvider']->getId(),
29
-				'redirect_url' => $_['redirect_url'],
30
-			]
31
-		)) ?>">
27
+            [
28
+                'challengeProviderId' => $_['backupProvider']->getId(),
29
+                'redirect_url' => $_['redirect_url'],
30
+            ]
31
+        )) ?>">
32 32
 			<?php p($l->t('Use backup code')) ?>
33 33
 		</a>
34 34
 	</p>
Please login to merge, or discard this patch.
apps/files_sharing/lib/Middleware/OCSShareAPIMiddleware.php 1 patch
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -11,43 +11,43 @@
 block discarded – undo
11 11
 use OCP\Share\IManager;
12 12
 
13 13
 class OCSShareAPIMiddleware extends Middleware {
14
-	/** @var IManager */
15
-	private $shareManager;
16
-	/** @var IL10N */
17
-	private $l;
14
+    /** @var IManager */
15
+    private $shareManager;
16
+    /** @var IL10N */
17
+    private $l;
18 18
 
19
-	public function __construct(IManager $shareManager,
20
-								IL10N $l) {
21
-		$this->shareManager = $shareManager;
22
-		$this->l = $l;
23
-	}
19
+    public function __construct(IManager $shareManager,
20
+                                IL10N $l) {
21
+        $this->shareManager = $shareManager;
22
+        $this->l = $l;
23
+    }
24 24
 
25
-	/**
26
-	 * @param Controller $controller
27
-	 * @param string $methodName
28
-	 *
29
-	 * @throws OCSNotFoundException
30
-	 */
31
-	public function beforeController($controller, $methodName) {
32
-		if ($controller instanceof ShareAPIController) {
33
-			if (!$this->shareManager->shareApiEnabled()) {
34
-				throw new OCSNotFoundException($this->l->t('Share API is disabled'));
35
-			}
36
-		}
37
-	}
25
+    /**
26
+     * @param Controller $controller
27
+     * @param string $methodName
28
+     *
29
+     * @throws OCSNotFoundException
30
+     */
31
+    public function beforeController($controller, $methodName) {
32
+        if ($controller instanceof ShareAPIController) {
33
+            if (!$this->shareManager->shareApiEnabled()) {
34
+                throw new OCSNotFoundException($this->l->t('Share API is disabled'));
35
+            }
36
+        }
37
+    }
38 38
 
39
-	/**
40
-	 * @param Controller $controller
41
-	 * @param string $methodName
42
-	 * @param Response $response
43
-	 * @return Response
44
-	 */
45
-	public function afterController($controller, $methodName, Response $response) {
46
-		if ($controller instanceof ShareAPIController) {
47
-			/** @var ShareAPIController $controller */
48
-			$controller->cleanup();
49
-		}
39
+    /**
40
+     * @param Controller $controller
41
+     * @param string $methodName
42
+     * @param Response $response
43
+     * @return Response
44
+     */
45
+    public function afterController($controller, $methodName, Response $response) {
46
+        if ($controller instanceof ShareAPIController) {
47
+            /** @var ShareAPIController $controller */
48
+            $controller->cleanup();
49
+        }
50 50
 
51
-		return $response;
52
-	}
51
+        return $response;
52
+    }
53 53
 }
Please login to merge, or discard this patch.
apps/files_sharing/lib/Middleware/ShareInfoMiddleware.php 1 patch
Indentation   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -13,74 +13,74 @@
 block discarded – undo
13 13
 use OCP\Share\IManager;
14 14
 
15 15
 class ShareInfoMiddleware extends Middleware {
16
-	/** @var IManager */
17
-	private $shareManager;
16
+    /** @var IManager */
17
+    private $shareManager;
18 18
 
19
-	public function __construct(IManager $shareManager) {
20
-		$this->shareManager = $shareManager;
21
-	}
19
+    public function __construct(IManager $shareManager) {
20
+        $this->shareManager = $shareManager;
21
+    }
22 22
 
23
-	/**
24
-	 * @param Controller $controller
25
-	 * @param string $methodName
26
-	 * @throws S2SException
27
-	 */
28
-	public function beforeController($controller, $methodName) {
29
-		if (!($controller instanceof ShareInfoController)) {
30
-			return;
31
-		}
23
+    /**
24
+     * @param Controller $controller
25
+     * @param string $methodName
26
+     * @throws S2SException
27
+     */
28
+    public function beforeController($controller, $methodName) {
29
+        if (!($controller instanceof ShareInfoController)) {
30
+            return;
31
+        }
32 32
 
33
-		if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
34
-			throw new S2SException();
35
-		}
36
-	}
33
+        if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
34
+            throw new S2SException();
35
+        }
36
+    }
37 37
 
38
-	/**
39
-	 * @param Controller $controller
40
-	 * @param string $methodName
41
-	 * @param \Exception $exception
42
-	 * @throws \Exception
43
-	 * @return Response
44
-	 */
45
-	public function afterException($controller, $methodName, \Exception $exception) {
46
-		if (!($controller instanceof ShareInfoController)) {
47
-			throw $exception;
48
-		}
38
+    /**
39
+     * @param Controller $controller
40
+     * @param string $methodName
41
+     * @param \Exception $exception
42
+     * @throws \Exception
43
+     * @return Response
44
+     */
45
+    public function afterException($controller, $methodName, \Exception $exception) {
46
+        if (!($controller instanceof ShareInfoController)) {
47
+            throw $exception;
48
+        }
49 49
 
50
-		if ($exception instanceof S2SException) {
51
-			return new JSONResponse([], Http::STATUS_NOT_FOUND);
52
-		}
50
+        if ($exception instanceof S2SException) {
51
+            return new JSONResponse([], Http::STATUS_NOT_FOUND);
52
+        }
53 53
 
54
-		throw $exception;
55
-	}
54
+        throw $exception;
55
+    }
56 56
 
57
-	/**
58
-	 * @param Controller $controller
59
-	 * @param string $methodName
60
-	 * @param Response $response
61
-	 * @return Response
62
-	 */
63
-	public function afterController($controller, $methodName, Response $response) {
64
-		if (!($controller instanceof ShareInfoController)) {
65
-			return $response;
66
-		}
57
+    /**
58
+     * @param Controller $controller
59
+     * @param string $methodName
60
+     * @param Response $response
61
+     * @return Response
62
+     */
63
+    public function afterController($controller, $methodName, Response $response) {
64
+        if (!($controller instanceof ShareInfoController)) {
65
+            return $response;
66
+        }
67 67
 
68
-		if (!($response instanceof JSONResponse)) {
69
-			return $response;
70
-		}
68
+        if (!($response instanceof JSONResponse)) {
69
+            return $response;
70
+        }
71 71
 
72
-		$data = $response->getData();
73
-		$status = 'error';
72
+        $data = $response->getData();
73
+        $status = 'error';
74 74
 
75
-		if ($response->getStatus() === Http::STATUS_OK) {
76
-			$status = 'success';
77
-		}
75
+        if ($response->getStatus() === Http::STATUS_OK) {
76
+            $status = 'success';
77
+        }
78 78
 
79
-		$response->setData([
80
-			'data' => $data,
81
-			'status' => $status,
82
-		]);
79
+        $response->setData([
80
+            'data' => $data,
81
+            'status' => $status,
82
+        ]);
83 83
 
84
-		return $response;
85
-	}
84
+        return $response;
85
+    }
86 86
 }
Please login to merge, or discard this patch.