Completed
Pull Request — stable10 (#5732)
by Morris
14:18
created
apps/user_ldap/templates/part.wizard-server.php 2 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -9,19 +9,19 @@
 block discarded – undo
9 9
 		<p>
10 10
 		<select id="ldap_serverconfig_chooser" name="ldap_serverconfig_chooser">
11 11
 		<?php if(count($_['serverConfigurationPrefixes']) === 0 ) {
12
-			?>
12
+            ?>
13 13
 				<option value="" selected><?php p($l->t('1. Server'));?></option>');
14 14
 			<?php
15
-		} else {
16
-			$i = 1;
17
-			$sel = ' selected';
18
-			foreach($_['serverConfigurationPrefixes'] as $prefix) {
19
-				?>
15
+        } else {
16
+            $i = 1;
17
+            $sel = ' selected';
18
+            foreach($_['serverConfigurationPrefixes'] as $prefix) {
19
+                ?>
20 20
 				<option value="<?php p($prefix); ?>"<?php p($sel); $sel = ''; ?>><?php p($l->t('%s. Server:', array($i++)));?> <?php p(' '.$_['serverConfigurationHosts'][$prefix]); ?></option>
21 21
 				<?php
22
-			}
23
-		}
24
-		?>
22
+            }
23
+        }
24
+        ?>
25 25
 		</select>
26 26
 		<button type="button" id="ldap_action_add_configuration"
27 27
 			name="ldap_action_add_configuration" class="icon-add icon-default-style"
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -8,16 +8,16 @@  discard block
 block discarded – undo
8 8
 <fieldset id="ldapWizard1">
9 9
 		<p>
10 10
 		<select id="ldap_serverconfig_chooser" name="ldap_serverconfig_chooser">
11
-		<?php if(count($_['serverConfigurationPrefixes']) === 0 ) {
11
+		<?php if (count($_['serverConfigurationPrefixes']) === 0) {
12 12
 			?>
13
-				<option value="" selected><?php p($l->t('1. Server'));?></option>');
13
+				<option value="" selected><?php p($l->t('1. Server')); ?></option>');
14 14
 			<?php
15 15
 		} else {
16 16
 			$i = 1;
17 17
 			$sel = ' selected';
18
-			foreach($_['serverConfigurationPrefixes'] as $prefix) {
18
+			foreach ($_['serverConfigurationPrefixes'] as $prefix) {
19 19
 				?>
20
-				<option value="<?php p($prefix); ?>"<?php p($sel); $sel = ''; ?>><?php p($l->t('%s. Server:', array($i++)));?> <?php p(' '.$_['serverConfigurationHosts'][$prefix]); ?></option>
20
+				<option value="<?php p($prefix); ?>"<?php p($sel); $sel = ''; ?>><?php p($l->t('%s. Server:', array($i++))); ?> <?php p(' '.$_['serverConfigurationHosts'][$prefix]); ?></option>
21 21
 				<?php
22 22
 			}
23 23
 		}
@@ -25,14 +25,14 @@  discard block
 block discarded – undo
25 25
 		</select>
26 26
 		<button type="button" id="ldap_action_add_configuration"
27 27
 			name="ldap_action_add_configuration" class="icon-add icon-default-style"
28
-			title="<?php p($l->t('Add a new and blank configuration'));?>">&nbsp;</button>
28
+			title="<?php p($l->t('Add a new and blank configuration')); ?>">&nbsp;</button>
29 29
 		<button type="button" id="ldap_action_copy_configuration"
30 30
 			name="ldap_action_copy_configuration"
31 31
 			class="ldapIconCopy icon-default-style"
32
-			title="<?php p($l->t('Copy current configuration into new directory binding'));?>">&nbsp;</button>
32
+			title="<?php p($l->t('Copy current configuration into new directory binding')); ?>">&nbsp;</button>
33 33
 		<button type="button" id="ldap_action_delete_configuration"
34 34
 			name="ldap_action_delete_configuration" class="icon-delete icon-default-style"
35
-			title="<?php p($l->t('Delete the current configuration'));?>">&nbsp;</button>
35
+			title="<?php p($l->t('Delete the current configuration')); ?>">&nbsp;</button>
36 36
 		</p>
37 37
 
38 38
 		<div class="hostPortCombinator">
@@ -41,14 +41,14 @@  discard block
 block discarded – undo
41 41
 					<div class="table">
42 42
 						<input type="text" class="host" id="ldap_host"
43 43
 							name="ldap_host"
44
-							placeholder="<?php p($l->t('Host'));?>"
45
-							title="<?php p($l->t('You can omit the protocol, except you require SSL. Then start with ldaps://'));?>"
44
+							placeholder="<?php p($l->t('Host')); ?>"
45
+							title="<?php p($l->t('You can omit the protocol, except you require SSL. Then start with ldaps://')); ?>"
46 46
 							/>
47 47
 						<span class="hostPortCombinatorSpan">
48 48
 							<input type="number" id="ldap_port" name="ldap_port"
49
-								placeholder="<?php p($l->t('Port'));?>" />
49
+								placeholder="<?php p($l->t('Port')); ?>" />
50 50
 							<button class="ldapDetectPort" name="ldapDetectPort" type="button">
51
-								<?php p($l->t('Detect Port'));?>
51
+								<?php p($l->t('Detect Port')); ?>
52 52
 							</button>
53 53
 						</span>
54 54
 					</div>
@@ -57,40 +57,40 @@  discard block
 block discarded – undo
57 57
 			<div class="tablerow">
58 58
 				<input type="text" id="ldap_dn" name="ldap_dn"
59 59
 				class="tablecell"
60
-				placeholder="<?php p($l->t('User DN'));?>" autocomplete="off"
61
-				title="<?php p($l->t('The DN of the client user with which the bind shall be done, e.g. uid=agent,dc=example,dc=com. For anonymous access, leave DN and Password empty.'));?>"
60
+				placeholder="<?php p($l->t('User DN')); ?>" autocomplete="off"
61
+				title="<?php p($l->t('The DN of the client user with which the bind shall be done, e.g. uid=agent,dc=example,dc=com. For anonymous access, leave DN and Password empty.')); ?>"
62 62
 				/>
63 63
 			</div>
64 64
 
65 65
 			<div class="tablerow">
66 66
 				<input type="password" id="ldap_agent_password"
67 67
 				class="tablecell" name="ldap_agent_password"
68
-				placeholder="<?php p($l->t('Password'));?>" autocomplete="off"
69
-				title="<?php p($l->t('For anonymous access, leave DN and Password empty.'));?>"
68
+				placeholder="<?php p($l->t('Password')); ?>" autocomplete="off"
69
+				title="<?php p($l->t('For anonymous access, leave DN and Password empty.')); ?>"
70 70
 				/>
71 71
 			</div>
72 72
 
73 73
 			<div class="tablerow">
74 74
 				<textarea id="ldap_base" name="ldap_base"
75 75
 					class="tablecell"
76
-					placeholder="<?php p($l->t('One Base DN per line'));?>"
77
-					title="<?php p($l->t('You can specify Base DN for users and groups in the Advanced tab'));?>">
76
+					placeholder="<?php p($l->t('One Base DN per line')); ?>"
77
+					title="<?php p($l->t('You can specify Base DN for users and groups in the Advanced tab')); ?>">
78 78
 				</textarea>
79 79
 				<button class="ldapDetectBase" name="ldapDetectBase" type="button">
80
-					<?php p($l->t('Detect Base DN'));?>
80
+					<?php p($l->t('Detect Base DN')); ?>
81 81
 				</button>
82 82
 				<button class="ldapTestBase" name="ldapTestBase" type="button">
83
-					<?php p($l->t('Test Base DN'));?>
83
+					<?php p($l->t('Test Base DN')); ?>
84 84
 				</button>
85 85
 			</div>
86 86
 
87 87
 			<div class="tablerow left">
88 88
 				<input type="checkbox" id="ldap_experienced_admin" value="1"
89 89
 					name="ldap_experienced_admin" class="tablecell"
90
-					title="<?php p($l->t('Avoids automatic LDAP requests. Better for bigger setups, but requires some LDAP knowledge.'));?>"
90
+					title="<?php p($l->t('Avoids automatic LDAP requests. Better for bigger setups, but requires some LDAP knowledge.')); ?>"
91 91
 					/>
92 92
 				<label for="ldap_experienced_admin" class="tablecell">
93
-					<?php p($l->t('Manually enter LDAP filters (recommended for large directories)'));?>
93
+					<?php p($l->t('Manually enter LDAP filters (recommended for large directories)')); ?>
94 94
 				</label>
95 95
 			</div>
96 96
 
Please login to merge, or discard this patch.
apps/user_ldap/templates/part.wizard-loginfilter.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,29 +1,29 @@  discard block
 block discarded – undo
1 1
 <fieldset id="ldapWizard3">
2 2
 	<div>
3 3
 		<p>
4
-			<?php p($l->t('When logging in, %s will find the user based on the following attributes:', $theme->getName()));?>
4
+			<?php p($l->t('When logging in, %s will find the user based on the following attributes:', $theme->getName())); ?>
5 5
 		</p>
6 6
 		<p>
7 7
 			<label for="ldap_loginfilter_username">
8
-				<?php p($l->t('LDAP / AD Username:'));?>
8
+				<?php p($l->t('LDAP / AD Username:')); ?>
9 9
 			</label>
10 10
 
11 11
 			<input type="checkbox" id="ldap_loginfilter_username"
12
-				   title="<?php p($l->t('Allows login against the LDAP / AD username, which is either uid or samaccountname and will be detected.'));?>"
12
+				   title="<?php p($l->t('Allows login against the LDAP / AD username, which is either uid or samaccountname and will be detected.')); ?>"
13 13
 				   name="ldap_loginfilter_username" value="1" />
14 14
 		</p>
15 15
 		<p>
16 16
 			<label for="ldap_loginfilter_email">
17
-				<?php p($l->t('LDAP / AD Email Address:'));?>
17
+				<?php p($l->t('LDAP / AD Email Address:')); ?>
18 18
 			</label>
19 19
 
20 20
 			<input type="checkbox" id="ldap_loginfilter_email"
21
-				   title="<?php p($l->t('Allows login against an email attribute. Mail and mailPrimaryAddress will be allowed.'));?>"
21
+				   title="<?php p($l->t('Allows login against an email attribute. Mail and mailPrimaryAddress will be allowed.')); ?>"
22 22
 				   name="ldap_loginfilter_email" value="1" />
23 23
 		</p>
24 24
 		<p>
25 25
 			<label for="ldap_loginfilter_attributes">
26
-				<?php p($l->t('Other Attributes:'));?>
26
+				<?php p($l->t('Other Attributes:')); ?>
27 27
 			</label>
28 28
 
29 29
 			<select id="ldap_loginfilter_attributes" multiple="multiple"
@@ -31,17 +31,17 @@  discard block
 block discarded – undo
31 31
 			</select>
32 32
 		</p>
33 33
 		<p>
34
-			<label><a id='toggleRawLoginFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query'));?></a></label>
34
+			<label><a id='toggleRawLoginFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query')); ?></a></label>
35 35
 		</p>
36 36
 		<p id="ldapReadOnlyLoginFilterContainer" class="hidden ldapReadOnlyFilterContainer">
37
-			<label><?php p($l->t('LDAP Filter:'));?></label>
37
+			<label><?php p($l->t('LDAP Filter:')); ?></label>
38 38
 			<span class="ldapFilterReadOnlyElement ldapInputColElement"></span>
39 39
 		</p>
40 40
 		<p id="rawLoginFilterContainer" class="invisible">
41 41
 			<textarea type="text" id="ldap_login_filter" name="ldap_login_filter"
42 42
 				class="ldapFilterInputElement"
43
-				placeholder="<?php p($l->t('Edit LDAP Query'));?>"
44
-				title="<?php p($l->t('Defines the filter to apply, when login is attempted. %%uid replaces the username in the login action. Example: "uid=%%uid"'));?>">
43
+				placeholder="<?php p($l->t('Edit LDAP Query')); ?>"
44
+				title="<?php p($l->t('Defines the filter to apply, when login is attempted. %%uid replaces the username in the login action. Example: "uid=%%uid"')); ?>">
45 45
 			</textarea>
46 46
 		</p>
47 47
 		<p>
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
 		</p>
50 50
 		<p class="ldap_verify">
51 51
 			<input type="text" id="ldap_test_loginname" name="ldap_test_loginname"
52
-				   placeholder="<?php p($l->t('Test Loginname'));?>"
52
+				   placeholder="<?php p($l->t('Test Loginname')); ?>"
53 53
 				   class="ldapVerifyInput"
54 54
 				   title="Attempts to receive a DN for the given loginname and the current login filter"/>
55 55
 			<button class="ldapVerifyLoginName" name="ldapTestLoginSettings" type="button" disabled="disabled">
56
-				<?php p($l->t('Verify settings'));?>
56
+				<?php p($l->t('Verify settings')); ?>
57 57
 			</button>
58 58
 		</p>
59 59
 		<?php print_unescaped($_['wizardControls']); ?>
Please login to merge, or discard this patch.
apps/user_ldap/ajax/clearMappings.php 2 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -34,16 +34,16 @@
 block discarded – undo
34 34
 $subject = (string)$_POST['ldap_clear_mapping'];
35 35
 $mapping = null;
36 36
 if($subject === 'user') {
37
-	$mapping = new UserMapping(\OC::$server->getDatabaseConnection());
37
+    $mapping = new UserMapping(\OC::$server->getDatabaseConnection());
38 38
 } else if($subject === 'group') {
39
-	$mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
39
+    $mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
40 40
 }
41 41
 try {
42
-	if(is_null($mapping) || !$mapping->clear()) {
43
-		$l = \OC::$server->getL10N('user_ldap');
44
-		throw new \Exception($l->t('Failed to clear the mappings.'));
45
-	}
46
-	OCP\JSON::success();
42
+    if(is_null($mapping) || !$mapping->clear()) {
43
+        $l = \OC::$server->getL10N('user_ldap');
44
+        throw new \Exception($l->t('Failed to clear the mappings.'));
45
+    }
46
+    OCP\JSON::success();
47 47
 } catch (\Exception $e) {
48
-	OCP\JSON::error(array('message' => $e->getMessage()));
48
+    OCP\JSON::error(array('message' => $e->getMessage()));
49 49
 }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,15 +31,15 @@
 block discarded – undo
31 31
 OCP\JSON::checkAppEnabled('user_ldap');
32 32
 OCP\JSON::callCheck();
33 33
 
34
-$subject = (string)$_POST['ldap_clear_mapping'];
34
+$subject = (string) $_POST['ldap_clear_mapping'];
35 35
 $mapping = null;
36
-if($subject === 'user') {
36
+if ($subject === 'user') {
37 37
 	$mapping = new UserMapping(\OC::$server->getDatabaseConnection());
38
-} else if($subject === 'group') {
38
+} else if ($subject === 'group') {
39 39
 	$mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
40 40
 }
41 41
 try {
42
-	if(is_null($mapping) || !$mapping->clear()) {
42
+	if (is_null($mapping) || !$mapping->clear()) {
43 43
 		$l = \OC::$server->getL10N('user_ldap');
44 44
 		throw new \Exception($l->t('Failed to clear the mappings.'));
45 45
 	}
Please login to merge, or discard this patch.
apps/user_ldap/ajax/testConfiguration.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 			try {
67 67
 				$ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
68 68
 			} catch (\Exception $e) {
69
-				if($e->getCode() === 1) {
69
+				if ($e->getCode() === 1) {
70 70
 					OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
71 71
 					exit;
72 72
 				}
Please login to merge, or discard this patch.
Indentation   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -38,10 +38,10 @@  discard block
 block discarded – undo
38 38
 $_POST['ldap_configuration_active'] = 1;
39 39
 
40 40
 try {
41
-	if ($connection->setConfiguration($_POST)) {
42
-		//Configuration is okay
43
-		if ($connection->bind()) {
44
-			/*
41
+    if ($connection->setConfiguration($_POST)) {
42
+        //Configuration is okay
43
+        if ($connection->bind()) {
44
+            /*
45 45
 			 * This shiny if block is an ugly hack to find out whether anonymous
46 46
 			 * bind is possible on AD or not. Because AD happily and constantly
47 47
 			 * replies with success to any anonymous bind request, we need to
@@ -50,24 +50,24 @@  discard block
 block discarded – undo
50 50
 			 * exception by the LDAP wrapper. We catch this. Other cases may
51 51
 			 * pass (like e.g. expected syntax error).
52 52
 			 */
53
-			try {
54
-				$ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
55
-			} catch (\Exception $e) {
56
-				if($e->getCode() === 1) {
57
-					OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
58
-					exit;
59
-				}
60
-			}
61
-			OCP\JSON::success(array('message'
62
-			=> $l->t('The configuration is valid and the connection could be established!')));
63
-		} else {
64
-			OCP\JSON::error(array('message'
65
-			=> $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
66
-		}
67
-	} else {
68
-		OCP\JSON::error(array('message'
69
-		=> $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
70
-	}
53
+            try {
54
+                $ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
55
+            } catch (\Exception $e) {
56
+                if($e->getCode() === 1) {
57
+                    OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
58
+                    exit;
59
+                }
60
+            }
61
+            OCP\JSON::success(array('message'
62
+            => $l->t('The configuration is valid and the connection could be established!')));
63
+        } else {
64
+            OCP\JSON::error(array('message'
65
+            => $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
66
+        }
67
+    } else {
68
+        OCP\JSON::error(array('message'
69
+        => $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
70
+    }
71 71
 } catch (\Exception $e) {
72
-	OCP\JSON::error(array('message' => $e->getMessage()));
72
+    OCP\JSON::error(array('message' => $e->getMessage()));
73 73
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/setConfiguration.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@
 block discarded – undo
36 36
 // only legacy checkboxes (Advanced and Expert tab) need to be handled here,
37 37
 // the Wizard-like tabs handle it on their own
38 38
 $chkboxes = array('ldap_configuration_active', 'ldap_override_main_server',
39
-				  'ldap_turn_off_cert_check');
39
+                    'ldap_turn_off_cert_check');
40 40
 foreach($chkboxes as $boxid) {
41
-	if(!isset($_POST[$boxid])) {
42
-		$_POST[$boxid] = 0;
43
-	}
41
+    if(!isset($_POST[$boxid])) {
42
+        $_POST[$boxid] = 0;
43
+    }
44 44
 }
45 45
 
46 46
 $ldapWrapper = new OCA\User_LDAP\LDAP();
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,15 +30,15 @@
 block discarded – undo
30 30
 OCP\JSON::checkAppEnabled('user_ldap');
31 31
 OCP\JSON::callCheck();
32 32
 
33
-$prefix = (string)$_POST['ldap_serverconfig_chooser'];
33
+$prefix = (string) $_POST['ldap_serverconfig_chooser'];
34 34
 
35 35
 // Checkboxes are not submitted, when they are unchecked. Set them manually.
36 36
 // only legacy checkboxes (Advanced and Expert tab) need to be handled here,
37 37
 // the Wizard-like tabs handle it on their own
38 38
 $chkboxes = array('ldap_configuration_active', 'ldap_override_main_server',
39 39
 				  'ldap_turn_off_cert_check');
40
-foreach($chkboxes as $boxid) {
41
-	if(!isset($_POST[$boxid])) {
40
+foreach ($chkboxes as $boxid) {
41
+	if (!isset($_POST[$boxid])) {
42 42
 		$_POST[$boxid] = 0;
43 43
 	}
44 44
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/wizard.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -32,16 +32,16 @@  discard block
 block discarded – undo
32 32
 
33 33
 $l = \OC::$server->getL10N('user_ldap');
34 34
 
35
-if(!isset($_POST['action'])) {
35
+if (!isset($_POST['action'])) {
36 36
 	\OCP\JSON::error(array('message' => $l->t('No action specified')));
37 37
 }
38
-$action = (string)$_POST['action'];
38
+$action = (string) $_POST['action'];
39 39
 
40 40
 
41
-if(!isset($_POST['ldap_serverconfig_chooser'])) {
41
+if (!isset($_POST['ldap_serverconfig_chooser'])) {
42 42
 	\OCP\JSON::error(array('message' => $l->t('No configuration specified')));
43 43
 }
44
-$prefix = (string)$_POST['ldap_serverconfig_chooser'];
44
+$prefix = (string) $_POST['ldap_serverconfig_chooser'];
45 45
 
46 46
 $ldapWrapper = new \OCA\User_LDAP\LDAP();
47 47
 $configuration = new \OCA\User_LDAP\Configuration($prefix);
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
 $wizard = new \OCA\User_LDAP\Wizard($configuration, $ldapWrapper, $access);
68 68
 
69
-switch($action) {
69
+switch ($action) {
70 70
 	case 'guessPortAndTLS':
71 71
 	case 'guessBaseDN':
72 72
 	case 'detectEmailAttribute':
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	case 'countInBaseDN':
86 86
 		try {
87 87
 			$result = $wizard->$action();
88
-			if($result !== false) {
88
+			if ($result !== false) {
89 89
 				OCP\JSON::success($result->getResultArray());
90 90
 				exit;
91 91
 			}
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 		try {
102 102
 			$loginName = $_POST['ldap_test_loginname'];
103 103
 			$result = $wizard->$action($loginName);
104
-			if($result !== false) {
104
+			if ($result !== false) {
105 105
 				OCP\JSON::success($result->getResultArray());
106 106
 				exit;
107 107
 			}
@@ -117,14 +117,14 @@  discard block
 block discarded – undo
117 117
 	case 'save':
118 118
 		$key = isset($_POST['cfgkey']) ? $_POST['cfgkey'] : false;
119 119
 		$val = isset($_POST['cfgval']) ? $_POST['cfgval'] : null;
120
-		if($key === false || is_null($val)) {
120
+		if ($key === false || is_null($val)) {
121 121
 			\OCP\JSON::error(array('message' => $l->t('No data specified')));
122 122
 			exit;
123 123
 		}
124 124
 		$cfg = array($key => $val);
125 125
 		$setParameters = array();
126 126
 		$configuration->setConfiguration($cfg, $setParameters);
127
-		if(!in_array($key, $setParameters)) {
127
+		if (!in_array($key, $setParameters)) {
128 128
 			\OCP\JSON::error(array('message' => $l->t($key.
129 129
 				' Could not set configuration %s', $setParameters[0])));
130 130
 			exit;
Please login to merge, or discard this patch.
Indentation   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
33 33
 $l = \OC::$server->getL10N('user_ldap');
34 34
 
35 35
 if(!isset($_POST['action'])) {
36
-	\OCP\JSON::error(array('message' => $l->t('No action specified')));
36
+    \OCP\JSON::error(array('message' => $l->t('No action specified')));
37 37
 }
38 38
 $action = (string)$_POST['action'];
39 39
 
40 40
 
41 41
 if(!isset($_POST['ldap_serverconfig_chooser'])) {
42
-	\OCP\JSON::error(array('message' => $l->t('No configuration specified')));
42
+    \OCP\JSON::error(array('message' => $l->t('No configuration specified')));
43 43
 }
44 44
 $prefix = (string)$_POST['ldap_serverconfig_chooser'];
45 45
 
@@ -52,88 +52,88 @@  discard block
 block discarded – undo
52 52
 $con->setIgnoreValidation(true);
53 53
 
54 54
 $userManager = new \OCA\User_LDAP\User\Manager(
55
-	\OC::$server->getConfig(),
56
-	new \OCA\User_LDAP\FilesystemHelper(),
57
-	new \OCA\User_LDAP\LogWrapper(),
58
-	\OC::$server->getAvatarManager(),
59
-	new \OCP\Image(),
60
-	\OC::$server->getDatabaseConnection(),
61
-	\OC::$server->getUserManager());
55
+    \OC::$server->getConfig(),
56
+    new \OCA\User_LDAP\FilesystemHelper(),
57
+    new \OCA\User_LDAP\LogWrapper(),
58
+    \OC::$server->getAvatarManager(),
59
+    new \OCP\Image(),
60
+    \OC::$server->getDatabaseConnection(),
61
+    \OC::$server->getUserManager());
62 62
 
63 63
 $access = new \OCA\User_LDAP\Access($con, $ldapWrapper, $userManager, new \OCA\User_LDAP\Helper());
64 64
 
65 65
 $wizard = new \OCA\User_LDAP\Wizard($configuration, $ldapWrapper, $access);
66 66
 
67 67
 switch($action) {
68
-	case 'guessPortAndTLS':
69
-	case 'guessBaseDN':
70
-	case 'detectEmailAttribute':
71
-	case 'detectUserDisplayNameAttribute':
72
-	case 'determineGroupMemberAssoc':
73
-	case 'determineUserObjectClasses':
74
-	case 'determineGroupObjectClasses':
75
-	case 'determineGroupsForUsers':
76
-	case 'determineGroupsForGroups':
77
-	case 'determineAttributes':
78
-	case 'getUserListFilter':
79
-	case 'getUserLoginFilter':
80
-	case 'getGroupFilter':
81
-	case 'countUsers':
82
-	case 'countGroups':
83
-	case 'countInBaseDN':
84
-		try {
85
-			$result = $wizard->$action();
86
-			if($result !== false) {
87
-				OCP\JSON::success($result->getResultArray());
88
-				exit;
89
-			}
90
-		} catch (\Exception $e) {
91
-			\OCP\JSON::error(array('message' => $e->getMessage(), 'code' => $e->getCode()));
92
-			exit;
93
-		}
94
-		\OCP\JSON::error();
95
-		exit;
96
-		break;
68
+    case 'guessPortAndTLS':
69
+    case 'guessBaseDN':
70
+    case 'detectEmailAttribute':
71
+    case 'detectUserDisplayNameAttribute':
72
+    case 'determineGroupMemberAssoc':
73
+    case 'determineUserObjectClasses':
74
+    case 'determineGroupObjectClasses':
75
+    case 'determineGroupsForUsers':
76
+    case 'determineGroupsForGroups':
77
+    case 'determineAttributes':
78
+    case 'getUserListFilter':
79
+    case 'getUserLoginFilter':
80
+    case 'getGroupFilter':
81
+    case 'countUsers':
82
+    case 'countGroups':
83
+    case 'countInBaseDN':
84
+        try {
85
+            $result = $wizard->$action();
86
+            if($result !== false) {
87
+                OCP\JSON::success($result->getResultArray());
88
+                exit;
89
+            }
90
+        } catch (\Exception $e) {
91
+            \OCP\JSON::error(array('message' => $e->getMessage(), 'code' => $e->getCode()));
92
+            exit;
93
+        }
94
+        \OCP\JSON::error();
95
+        exit;
96
+        break;
97 97
 
98
-	case 'testLoginName': {
99
-		try {
100
-			$loginName = $_POST['ldap_test_loginname'];
101
-			$result = $wizard->$action($loginName);
102
-			if($result !== false) {
103
-				OCP\JSON::success($result->getResultArray());
104
-				exit;
105
-			}
106
-		} catch (\Exception $e) {
107
-			\OCP\JSON::error(array('message' => $e->getMessage()));
108
-			exit;
109
-		}
110
-		\OCP\JSON::error();
111
-		exit;
112
-		break;
113
-	}
98
+    case 'testLoginName': {
99
+        try {
100
+            $loginName = $_POST['ldap_test_loginname'];
101
+            $result = $wizard->$action($loginName);
102
+            if($result !== false) {
103
+                OCP\JSON::success($result->getResultArray());
104
+                exit;
105
+            }
106
+        } catch (\Exception $e) {
107
+            \OCP\JSON::error(array('message' => $e->getMessage()));
108
+            exit;
109
+        }
110
+        \OCP\JSON::error();
111
+        exit;
112
+        break;
113
+    }
114 114
 
115
-	case 'save':
116
-		$key = isset($_POST['cfgkey']) ? $_POST['cfgkey'] : false;
117
-		$val = isset($_POST['cfgval']) ? $_POST['cfgval'] : null;
118
-		if($key === false || is_null($val)) {
119
-			\OCP\JSON::error(array('message' => $l->t('No data specified')));
120
-			exit;
121
-		}
122
-		$cfg = array($key => $val);
123
-		$setParameters = array();
124
-		$configuration->setConfiguration($cfg, $setParameters);
125
-		if(!in_array($key, $setParameters)) {
126
-			\OCP\JSON::error(array('message' => $l->t($key.
127
-				' Could not set configuration %s', $setParameters[0])));
128
-			exit;
129
-		}
130
-		$configuration->saveConfiguration();
131
-		//clear the cache on save
132
-		$connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
133
-		$connection->clearCache();
134
-		OCP\JSON::success();
135
-		break;
136
-	default:
137
-		\OCP\JSON::error(array('message' => $l->t('Action does not exist')));
138
-		break;
115
+    case 'save':
116
+        $key = isset($_POST['cfgkey']) ? $_POST['cfgkey'] : false;
117
+        $val = isset($_POST['cfgval']) ? $_POST['cfgval'] : null;
118
+        if($key === false || is_null($val)) {
119
+            \OCP\JSON::error(array('message' => $l->t('No data specified')));
120
+            exit;
121
+        }
122
+        $cfg = array($key => $val);
123
+        $setParameters = array();
124
+        $configuration->setConfiguration($cfg, $setParameters);
125
+        if(!in_array($key, $setParameters)) {
126
+            \OCP\JSON::error(array('message' => $l->t($key.
127
+                ' Could not set configuration %s', $setParameters[0])));
128
+            exit;
129
+        }
130
+        $configuration->saveConfiguration();
131
+        //clear the cache on save
132
+        $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
133
+        $connection->clearCache();
134
+        OCP\JSON::success();
135
+        break;
136
+    default:
137
+        \OCP\JSON::error(array('message' => $l->t('Action does not exist')));
138
+        break;
139 139
 }
Please login to merge, or discard this patch.
apps/user_ldap/ajax/getNewServerConfigPrefix.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -38,12 +38,12 @@
 block discarded – undo
38 38
 
39 39
 $newConfig = new \OCA\User_LDAP\Configuration($nk, false);
40 40
 if(isset($_POST['copyConfig'])) {
41
-	$originalConfig = new \OCA\User_LDAP\Configuration($_POST['copyConfig']);
42
-	$newConfig->setConfiguration($originalConfig->getConfiguration());
41
+    $originalConfig = new \OCA\User_LDAP\Configuration($_POST['copyConfig']);
42
+    $newConfig->setConfiguration($originalConfig->getConfiguration());
43 43
 } else {
44
-	$configuration = new \OCA\User_LDAP\Configuration($nk, false);
45
-	$newConfig->setConfiguration($configuration->getDefaults());
46
-	$resultData['defaults'] = $configuration->getDefaults();
44
+    $configuration = new \OCA\User_LDAP\Configuration($nk, false);
45
+    $newConfig->setConfiguration($configuration->getDefaults());
46
+    $resultData['defaults'] = $configuration->getDefaults();
47 47
 }
48 48
 $newConfig->saveConfiguration();
49 49
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,12 +32,12 @@
 block discarded – undo
32 32
 sort($serverConnections);
33 33
 $lk = array_pop($serverConnections);
34 34
 $ln = intval(str_replace('s', '', $lk));
35
-$nk = 's'.str_pad($ln+1, 2, '0', STR_PAD_LEFT);
35
+$nk = 's'.str_pad($ln + 1, 2, '0', STR_PAD_LEFT);
36 36
 
37 37
 $resultData = array('configPrefix' => $nk);
38 38
 
39 39
 $newConfig = new \OCA\User_LDAP\Configuration($nk, false);
40
-if(isset($_POST['copyConfig'])) {
40
+if (isset($_POST['copyConfig'])) {
41 41
 	$originalConfig = new \OCA\User_LDAP\Configuration($_POST['copyConfig']);
42 42
 	$newConfig->setConfiguration($originalConfig->getConfiguration());
43 43
 } else {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Mapping/GroupMapping.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,12 +29,12 @@
 block discarded – undo
29 29
 */
30 30
 class GroupMapping extends AbstractMapping {
31 31
 
32
-	/**
33
-	* returns the DB table name which holds the mappings
34
-	* @return string
35
-	*/
36
-	protected function getTableName() {
37
-		return '*PREFIX*ldap_group_mapping';
38
-	}
32
+    /**
33
+     * returns the DB table name which holds the mappings
34
+     * @return string
35
+     */
36
+    protected function getTableName() {
37
+        return '*PREFIX*ldap_group_mapping';
38
+    }
39 39
 
40 40
 }
Please login to merge, or discard this patch.
apps/user_ldap/lib/Mapping/UserMapping.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,12 +29,12 @@
 block discarded – undo
29 29
 */
30 30
 class UserMapping extends AbstractMapping {
31 31
 
32
-	/**
33
-	 * returns the DB table name which holds the mappings
34
-	 * @return string
35
-	 */
36
-	protected function getTableName() {
37
-		return '*PREFIX*ldap_user_mapping';
38
-	}
32
+    /**
33
+     * returns the DB table name which holds the mappings
34
+     * @return string
35
+     */
36
+    protected function getTableName() {
37
+        return '*PREFIX*ldap_user_mapping';
38
+    }
39 39
 
40 40
 }
Please login to merge, or discard this patch.