| Conditions | 1 |
| Paths | 1 |
| Total Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 45 | public function __construct() { |
||
| 46 | parent::__construct('federatedfilesharing'); |
||
| 47 | |||
| 48 | $container = $this->getContainer(); |
||
| 49 | $server = $container->getServer(); |
||
| 50 | |||
| 51 | $cloudFederationManager = $server->getCloudFederationProviderManager(); |
||
| 52 | $cloudFederationManager->addCloudFederationProvider('file', |
||
| 53 | 'Federated Files Sharing', |
||
| 54 | function() use ($container) { |
||
| 55 | $server = $container->getServer(); |
||
| 56 | return new CloudFederationProviderFiles( |
||
| 57 | $server->getAppManager(), |
||
| 58 | $server->query(FederatedShareProvider::class), |
||
| 59 | $server->query(AddressHandler::class), |
||
| 60 | $server->getLogger(), |
||
| 61 | $server->getUserManager(), |
||
| 62 | $server->getCloudIdManager(), |
||
| 63 | $server->getActivityManager(), |
||
| 64 | $server->getNotificationManager(), |
||
| 65 | $server->getURLGenerator(), |
||
| 66 | $server->getCloudFederationFactory(), |
||
| 67 | $server->getCloudFederationProviderManager(), |
||
| 68 | $server->getDatabaseConnection() |
||
| 69 | ); |
||
| 70 | }); |
||
| 71 | |||
| 72 | $container->registerService('RequestHandlerController', function(SimpleContainer $c) use ($server) { |
||
| 73 | $addressHandler = new AddressHandler( |
||
| 74 | $server->getURLGenerator(), |
||
| 75 | $server->getL10N('federatedfilesharing'), |
||
| 76 | $server->getCloudIdManager() |
||
| 77 | ); |
||
| 78 | $notification = new Notifications( |
||
| 79 | $addressHandler, |
||
| 80 | $server->getHTTPClientService(), |
||
| 81 | $server->query(\OCP\OCS\IDiscoveryService::class), |
||
| 82 | \OC::$server->getJobList(), |
||
| 83 | \OC::$server->getCloudFederationProviderManager(), |
||
| 84 | \OC::$server->getCloudFederationFactory() |
||
| 85 | ); |
||
| 86 | return new RequestHandlerController( |
||
| 87 | $c->query('AppName'), |
||
| 88 | $server->getRequest(), |
||
| 89 | $this->getFederatedShareProvider(), |
||
| 90 | $server->getDatabaseConnection(), |
||
| 91 | $server->getShareManager(), |
||
| 92 | $notification, |
||
| 93 | $addressHandler, |
||
| 94 | $server->getUserManager(), |
||
| 95 | $server->getCloudIdManager(), |
||
| 96 | $server->getLogger(), |
||
| 97 | $server->getCloudFederationFactory(), |
||
| 98 | $server->getCloudFederationProviderManager() |
||
| 99 | ); |
||
| 100 | }); |
||
| 101 | } |
||
| 102 | |||
| 153 |