Inspection of "Create activities for (un)publishing calendar even..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6590)

by Thomas

created 2017-09-20 15:36 UTC

Status

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -94,44 +94,44 @@  discard block
 block discarded – undo
 
 		if ($event->getSubject() === self::SUBJECT_ADD) {
 			$subject = $this->l->t('{actor} created calendar {calendar}');
-		} else if ($event->getSubject() === self::SUBJECT_ADD . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_ADD.'_self') {
 			$subject = $this->l->t('You created calendar {calendar}');
 		} else if ($event->getSubject() === self::SUBJECT_DELETE) {
 			$subject = $this->l->t('{actor} deleted calendar {calendar}');
-		} else if ($event->getSubject() === self::SUBJECT_DELETE . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_DELETE.'_self') {
 			$subject = $this->l->t('You deleted calendar {calendar}');
 		} else if ($event->getSubject() === self::SUBJECT_UPDATE) {
 			$subject = $this->l->t('{actor} updated calendar {calendar}');
-		} else if ($event->getSubject() === self::SUBJECT_UPDATE . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_UPDATE.'_self') {
 			$subject = $this->l->t('You updated calendar {calendar}');
 
-		} else if ($event->getSubject() === self::SUBJECT_PUBLISH . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_PUBLISH.'_self') {
 			$subject = $this->l->t('You published calendar {calendar}');
-		} else if ($event->getSubject() === self::SUBJECT_UNPUBLISH . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_UNPUBLISH.'_self') {
 			$subject = $this->l->t('You unpublished calendar {calendar}');
 
 		} else if ($event->getSubject() === self::SUBJECT_SHARE_USER) {
 			$subject = $this->l->t('{actor} shared calendar {calendar} with you');
-		} else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_you') {
+		} else if ($event->getSubject() === self::SUBJECT_SHARE_USER.'_you') {
 			$subject = $this->l->t('You shared calendar {calendar} with {user}');
-		} else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_by') {
+		} else if ($event->getSubject() === self::SUBJECT_SHARE_USER.'_by') {
 			$subject = $this->l->t('{actor} shared calendar {calendar} with {user}');
 		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER) {
 			$subject = $this->l->t('{actor} unshared calendar {calendar} from you');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_you') {
+		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_you') {
 			$subject = $this->l->t('You unshared calendar {calendar} from {user}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_by') {
+		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_by') {
 			$subject = $this->l->t('{actor} unshared calendar {calendar} from {user}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_self') {
+		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_self') {
 			$subject = $this->l->t('{actor} unshared calendar {calendar} from themselves');
 
-		} else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_you') {
+		} else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP.'_you') {
 			$subject = $this->l->t('You shared calendar {calendar} with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_by') {
+		} else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP.'_by') {
 			$subject = $this->l->t('{actor} shared calendar {calendar} with group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_you') {
+		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP.'_you') {
 			$subject = $this->l->t('You unshared calendar {calendar} from group {group}');
-		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_by') {
+		} else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP.'_by') {
 			$subject = $this->l->t('{actor} unshared calendar {calendar} from group {group}');
 		} else {
 			throw new \InvalidArgumentException();
@@ -165,44 +165,44 @@  discard block
 block discarded – undo
 
 		switch ($subject) {
 			case self::SUBJECT_ADD:
-			case self::SUBJECT_ADD . '_self':
+			case self::SUBJECT_ADD.'_self':
 			case self::SUBJECT_DELETE:
-			case self::SUBJECT_DELETE . '_self':
+			case self::SUBJECT_DELETE.'_self':
 			case self::SUBJECT_UPDATE:
-			case self::SUBJECT_UPDATE . '_self':
-			case self::SUBJECT_PUBLISH . '_self':
-			case self::SUBJECT_UNPUBLISH . '_self':
+			case self::SUBJECT_UPDATE.'_self':
+			case self::SUBJECT_PUBLISH.'_self':
+			case self::SUBJECT_UNPUBLISH.'_self':
 			case self::SUBJECT_SHARE_USER:
 			case self::SUBJECT_UNSHARE_USER:
-			case self::SUBJECT_UNSHARE_USER . '_self':
+			case self::SUBJECT_UNSHARE_USER.'_self':
 				return [
 					'actor' => $this->generateUserParameter($parameters[0]),
-					'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
+					'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
 				];
-			case self::SUBJECT_SHARE_USER . '_you':
-			case self::SUBJECT_UNSHARE_USER . '_you':
+			case self::SUBJECT_SHARE_USER.'_you':
+			case self::SUBJECT_UNSHARE_USER.'_you':
 				return [
 					'user' => $this->generateUserParameter($parameters[0]),
-					'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
+					'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
 				];
-			case self::SUBJECT_SHARE_USER . '_by':
-			case self::SUBJECT_UNSHARE_USER . '_by':
+			case self::SUBJECT_SHARE_USER.'_by':
+			case self::SUBJECT_UNSHARE_USER.'_by':
 				return [
 					'user' => $this->generateUserParameter($parameters[0]),
-					'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
+					'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
 					'actor' => $this->generateUserParameter($parameters[2]),
 				];
-			case self::SUBJECT_SHARE_GROUP . '_you':
-			case self::SUBJECT_UNSHARE_GROUP . '_you':
+			case self::SUBJECT_SHARE_GROUP.'_you':
+			case self::SUBJECT_UNSHARE_GROUP.'_you':
 				return [
 					'group' => $this->generateGroupParameter($parameters[0]),
-					'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
+					'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
 				];
-			case self::SUBJECT_SHARE_GROUP . '_by':
-			case self::SUBJECT_UNSHARE_GROUP . '_by':
+			case self::SUBJECT_SHARE_GROUP.'_by':
+			case self::SUBJECT_UNSHARE_GROUP.'_by':
 				return [
 					'group' => $this->generateGroupParameter($parameters[0]),
-					'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
+					'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
 					'actor' => $this->generateUserParameter($parameters[2]),
 				];
 		}

Please login to merge, or discard this patch.

		@@ -94,44 +94,44 @@ discard block
		block discarded – undo
94	94
95	95	if ($event->getSubject() === self::SUBJECT_ADD) {
96	96	$subject = $this->l->t('{actor} created calendar {calendar}');
97		- } else if ($event->getSubject() === self::SUBJECT_ADD . '_self') {
	97	+ } else if ($event->getSubject() === self::SUBJECT_ADD.'_self') {
98	98	$subject = $this->l->t('You created calendar {calendar}');
99	99	} else if ($event->getSubject() === self::SUBJECT_DELETE) {
100	100	$subject = $this->l->t('{actor} deleted calendar {calendar}');
101		- } else if ($event->getSubject() === self::SUBJECT_DELETE . '_self') {
	101	+ } else if ($event->getSubject() === self::SUBJECT_DELETE.'_self') {
102	102	$subject = $this->l->t('You deleted calendar {calendar}');
103	103	} else if ($event->getSubject() === self::SUBJECT_UPDATE) {
104	104	$subject = $this->l->t('{actor} updated calendar {calendar}');
105		- } else if ($event->getSubject() === self::SUBJECT_UPDATE . '_self') {
	105	+ } else if ($event->getSubject() === self::SUBJECT_UPDATE.'_self') {
106	106	$subject = $this->l->t('You updated calendar {calendar}');
107	107
108		- } else if ($event->getSubject() === self::SUBJECT_PUBLISH . '_self') {
	108	+ } else if ($event->getSubject() === self::SUBJECT_PUBLISH.'_self') {
109	109	$subject = $this->l->t('You published calendar {calendar}');
110		- } else if ($event->getSubject() === self::SUBJECT_UNPUBLISH . '_self') {
	110	+ } else if ($event->getSubject() === self::SUBJECT_UNPUBLISH.'_self') {
111	111	$subject = $this->l->t('You unpublished calendar {calendar}');
112	112
113	113	} else if ($event->getSubject() === self::SUBJECT_SHARE_USER) {
114	114	$subject = $this->l->t('{actor} shared calendar {calendar} with you');
115		- } else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_you') {
	115	+ } else if ($event->getSubject() === self::SUBJECT_SHARE_USER.'_you') {
116	116	$subject = $this->l->t('You shared calendar {calendar} with {user}');
117		- } else if ($event->getSubject() === self::SUBJECT_SHARE_USER . '_by') {
	117	+ } else if ($event->getSubject() === self::SUBJECT_SHARE_USER.'_by') {
118	118	$subject = $this->l->t('{actor} shared calendar {calendar} with {user}');
119	119	} else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER) {
120	120	$subject = $this->l->t('{actor} unshared calendar {calendar} from you');
121		- } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_you') {
	121	+ } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_you') {
122	122	$subject = $this->l->t('You unshared calendar {calendar} from {user}');
123		- } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_by') {
	123	+ } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_by') {
124	124	$subject = $this->l->t('{actor} unshared calendar {calendar} from {user}');
125		- } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_self') {
	125	+ } else if ($event->getSubject() === self::SUBJECT_UNSHARE_USER.'_self') {
126	126	$subject = $this->l->t('{actor} unshared calendar {calendar} from themselves');
127	127
128		- } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_you') {
	128	+ } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP.'_you') {
129	129	$subject = $this->l->t('You shared calendar {calendar} with group {group}');
130		- } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_by') {
	130	+ } else if ($event->getSubject() === self::SUBJECT_SHARE_GROUP.'_by') {
131	131	$subject = $this->l->t('{actor} shared calendar {calendar} with group {group}');
132		- } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_you') {
	132	+ } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP.'_you') {
133	133	$subject = $this->l->t('You unshared calendar {calendar} from group {group}');
134		- } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_by') {
	134	+ } else if ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP.'_by') {
135	135	$subject = $this->l->t('{actor} unshared calendar {calendar} from group {group}');
136	136	} else {
137	137	throw new \InvalidArgumentException();
		@@ -165,44 +165,44 @@ discard block
		block discarded – undo
165	165
166	166	switch ($subject) {
167	167	case self::SUBJECT_ADD:
168		- case self::SUBJECT_ADD . '_self':
	168	+ case self::SUBJECT_ADD.'_self':
169	169	case self::SUBJECT_DELETE:
170		- case self::SUBJECT_DELETE . '_self':
	170	+ case self::SUBJECT_DELETE.'_self':
171	171	case self::SUBJECT_UPDATE:
172		- case self::SUBJECT_UPDATE . '_self':
173		- case self::SUBJECT_PUBLISH . '_self':
174		- case self::SUBJECT_UNPUBLISH . '_self':
	172	+ case self::SUBJECT_UPDATE.'_self':
	173	+ case self::SUBJECT_PUBLISH.'_self':
	174	+ case self::SUBJECT_UNPUBLISH.'_self':
175	175	case self::SUBJECT_SHARE_USER:
176	176	case self::SUBJECT_UNSHARE_USER:
177		- case self::SUBJECT_UNSHARE_USER . '_self':
	177	+ case self::SUBJECT_UNSHARE_USER.'_self':
178	178	return [
179	179	'actor' => $this->generateUserParameter($parameters[0]),
180		- 'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
	180	+ 'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
181	181	];
182		- case self::SUBJECT_SHARE_USER . '_you':
183		- case self::SUBJECT_UNSHARE_USER . '_you':
	182	+ case self::SUBJECT_SHARE_USER.'_you':
	183	+ case self::SUBJECT_UNSHARE_USER.'_you':
184	184	return [
185	185	'user' => $this->generateUserParameter($parameters[0]),
186		- 'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
	186	+ 'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
187	187	];
188		- case self::SUBJECT_SHARE_USER . '_by':
189		- case self::SUBJECT_UNSHARE_USER . '_by':
	188	+ case self::SUBJECT_SHARE_USER.'_by':
	189	+ case self::SUBJECT_UNSHARE_USER.'_by':
190	190	return [
191	191	'user' => $this->generateUserParameter($parameters[0]),
192		- 'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
	192	+ 'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
193	193	'actor' => $this->generateUserParameter($parameters[2]),
194	194	];
195		- case self::SUBJECT_SHARE_GROUP . '_you':
196		- case self::SUBJECT_UNSHARE_GROUP . '_you':
	195	+ case self::SUBJECT_SHARE_GROUP.'_you':
	196	+ case self::SUBJECT_UNSHARE_GROUP.'_you':
197	197	return [
198	198	'group' => $this->generateGroupParameter($parameters[0]),
199		- 'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
	199	+ 'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
200	200	];
201		- case self::SUBJECT_SHARE_GROUP . '_by':
202		- case self::SUBJECT_UNSHARE_GROUP . '_by':
	201	+ case self::SUBJECT_SHARE_GROUP.'_by':
	202	+ case self::SUBJECT_UNSHARE_GROUP.'_by':
203	203	return [
204	204	'group' => $this->generateGroupParameter($parameters[0]),
205		- 'calendar' => $this->generateCalendarParameter((int)$event->getObjectId(), $parameters[1]),
	205	+ 'calendar' => $this->generateCalendarParameter((int) $event->getObjectId(), $parameters[1]),
206	206	'actor' => $this->generateUserParameter($parameters[2]),
207	207	];
208	208	}

nextcloud / server

Pull Request — master (#6590)

Status

Category

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch