nextcloud / server

lib/private/Files/Storage/PolyFill/CopyDirectory.php

Indentation +71 added lines, -71 removed lines

@@ -25,81 +25,81 @@
 namespace OC\Files\Storage\PolyFill;
 
 trait CopyDirectory {
-	/**
-	 * Check if a path is a directory
-	 *
-	 * @param string $path
-	 * @return bool
-	 */
-	abstract public function is_dir($path);
+    /**
+     * Check if a path is a directory
+     *
+     * @param string $path
+     * @return bool
+     */
+    abstract public function is_dir($path);
 
-	/**
-	 * Check if a file or folder exists
-	 *
-	 * @param string $path
-	 * @return bool
-	 */
-	abstract public function file_exists($path);
+    /**
+     * Check if a file or folder exists
+     *
+     * @param string $path
+     * @return bool
+     */
+    abstract public function file_exists($path);
 
-	/**
-	 * Delete a file or folder
-	 *
-	 * @param string $path
-	 * @return bool
-	 */
-	abstract public function unlink($path);
+    /**
+     * Delete a file or folder
+     *
+     * @param string $path
+     * @return bool
+     */
+    abstract public function unlink($path);
 
-	/**
-	 * Open a directory handle for a folder
-	 *
-	 * @param string $path
-	 * @return resource | bool
-	 */
-	abstract public function opendir($path);
+    /**
+     * Open a directory handle for a folder
+     *
+     * @param string $path
+     * @return resource | bool
+     */
+    abstract public function opendir($path);
 
-	/**
-	 * Create a new folder
-	 *
-	 * @param string $path
-	 * @return bool
-	 */
-	abstract public function mkdir($path);
+    /**
+     * Create a new folder
+     *
+     * @param string $path
+     * @return bool
+     */
+    abstract public function mkdir($path);
 
-	public function copy($source, $target) {
-		if ($this->is_dir($source)) {
-			if ($this->file_exists($target)) {
-				$this->unlink($target);
-			}
-			$this->mkdir($target);
-			return $this->copyRecursive($source, $target);
-		} else {
-			return parent::copy($source, $target);
-		}
-	}
+    public function copy($source, $target) {
+        if ($this->is_dir($source)) {
+            if ($this->file_exists($target)) {
+                $this->unlink($target);
+            }
+            $this->mkdir($target);
+            return $this->copyRecursive($source, $target);
+        } else {
+            return parent::copy($source, $target);
+        }
+    }
 
-	/**
-	 * For adapters that don't support copying folders natively
-	 *
-	 * @param $source
-	 * @param $target
-	 * @return bool
-	 */
-	protected function copyRecursive($source, $target) {
-		$dh = $this->opendir($source);
-		$result = true;
-		while ($file = readdir($dh)) {
-			if (!\OC\Files\Filesystem::isIgnoredDir($file)) {
-				if ($this->is_dir($source . '/' . $file)) {
-					$this->mkdir($target . '/' . $file);
-					$result = $this->copyRecursive($source . '/' . $file, $target . '/' . $file);
-				} else {
-					$result = parent::copy($source . '/' . $file, $target . '/' . $file);
-				}
-				if (!$result) {
-					break;
-				}
-			}
-		}
-		return $result;
-	}
+    /**
+     * For adapters that don't support copying folders natively
+     *
+     * @param $source
+     * @param $target
+     * @return bool
+     */
+    protected function copyRecursive($source, $target) {
+        $dh = $this->opendir($source);
+        $result = true;
+        while ($file = readdir($dh)) {
+            if (!\OC\Files\Filesystem::isIgnoredDir($file)) {
+                if ($this->is_dir($source . '/' . $file)) {
+                    $this->mkdir($target . '/' . $file);
+                    $result = $this->copyRecursive($source . '/' . $file, $target . '/' . $file);
+                } else {
+                    $result = parent::copy($source . '/' . $file, $target . '/' . $file);
+                }
+                if (!$result) {
+                    break;
+                }
+            }
+        }
+        return $result;
+    }
 }

lib/private/Files/Storage/Flysystem.php

Indentation +201 added lines, -201 removed lines

@@ -35,223 +35,223 @@
  * To use: subclass and call $this->buildFlysystem with the flysystem adapter of choice
  */
 abstract class Flysystem extends Common {
-	/**
-	 * @var Filesystem
-	 */
-	protected $flysystem;
+    /**
+     * @var Filesystem
+     */
+    protected $flysystem;
 
-	/**
-	 * @var string
-	 */
-	protected $root = '';
+    /**
+     * @var string
+     */
+    protected $root = '';
 
-	/**
-	 * Initialize the storage backend with a flyssytem adapter
-	 *
-	 * @param \League\Flysystem\AdapterInterface $adapter
-	 */
-	protected function buildFlySystem(AdapterInterface $adapter) {
-		$this->flysystem = new Filesystem($adapter);
-		$this->flysystem->addPlugin(new GetWithMetadata());
-	}
+    /**
+     * Initialize the storage backend with a flyssytem adapter
+     *
+     * @param \League\Flysystem\AdapterInterface $adapter
+     */
+    protected function buildFlySystem(AdapterInterface $adapter) {
+        $this->flysystem = new Filesystem($adapter);
+        $this->flysystem->addPlugin(new GetWithMetadata());
+    }
 
-	protected function buildPath($path) {
-		$fullPath = \OC\Files\Filesystem::normalizePath($this->root . '/' . $path);
-		return ltrim($fullPath, '/');
-	}
+    protected function buildPath($path) {
+        $fullPath = \OC\Files\Filesystem::normalizePath($this->root . '/' . $path);
+        return ltrim($fullPath, '/');
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function file_get_contents($path) {
-		return $this->flysystem->read($this->buildPath($path));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function file_get_contents($path) {
+        return $this->flysystem->read($this->buildPath($path));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function file_put_contents($path, $data) {
-		return $this->flysystem->put($this->buildPath($path), $data);
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function file_put_contents($path, $data) {
+        return $this->flysystem->put($this->buildPath($path), $data);
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function file_exists($path) {
-		return $this->flysystem->has($this->buildPath($path));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function file_exists($path) {
+        return $this->flysystem->has($this->buildPath($path));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function unlink($path) {
-		if ($this->is_dir($path)) {
-			return $this->rmdir($path);
-		}
-		try {
-			return $this->flysystem->delete($this->buildPath($path));
-		} catch (FileNotFoundException $e) {
-			return false;
-		}
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function unlink($path) {
+        if ($this->is_dir($path)) {
+            return $this->rmdir($path);
+        }
+        try {
+            return $this->flysystem->delete($this->buildPath($path));
+        } catch (FileNotFoundException $e) {
+            return false;
+        }
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function rename($source, $target) {
-		if ($this->file_exists($target)) {
-			$this->unlink($target);
-		}
-		return $this->flysystem->rename($this->buildPath($source), $this->buildPath($target));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function rename($source, $target) {
+        if ($this->file_exists($target)) {
+            $this->unlink($target);
+        }
+        return $this->flysystem->rename($this->buildPath($source), $this->buildPath($target));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function copy($source, $target) {
-		if ($this->file_exists($target)) {
-			$this->unlink($target);
-		}
-		return $this->flysystem->copy($this->buildPath($source), $this->buildPath($target));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function copy($source, $target) {
+        if ($this->file_exists($target)) {
+            $this->unlink($target);
+        }
+        return $this->flysystem->copy($this->buildPath($source), $this->buildPath($target));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function filesize($path) {
-		if ($this->is_dir($path)) {
-			return 0;
-		} else {
-			return $this->flysystem->getSize($this->buildPath($path));
-		}
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function filesize($path) {
+        if ($this->is_dir($path)) {
+            return 0;
+        } else {
+            return $this->flysystem->getSize($this->buildPath($path));
+        }
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function mkdir($path) {
-		if ($this->file_exists($path)) {
-			return false;
-		}
-		return $this->flysystem->createDir($this->buildPath($path));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function mkdir($path) {
+        if ($this->file_exists($path)) {
+            return false;
+        }
+        return $this->flysystem->createDir($this->buildPath($path));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function filemtime($path) {
-		return $this->flysystem->getTimestamp($this->buildPath($path));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function filemtime($path) {
+        return $this->flysystem->getTimestamp($this->buildPath($path));
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function rmdir($path) {
-		try {
-			return @$this->flysystem->deleteDir($this->buildPath($path));
-		} catch (FileNotFoundException $e) {
-			return false;
-		}
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function rmdir($path) {
+        try {
+            return @$this->flysystem->deleteDir($this->buildPath($path));
+        } catch (FileNotFoundException $e) {
+            return false;
+        }
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function opendir($path) {
-		try {
-			$content = $this->flysystem->listContents($this->buildPath($path));
-		} catch (FileNotFoundException $e) {
-			return false;
-		}
-		$names = array_map(function ($object) {
-			return $object['basename'];
-		}, $content);
-		return IteratorDirectory::wrap($names);
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function opendir($path) {
+        try {
+            $content = $this->flysystem->listContents($this->buildPath($path));
+        } catch (FileNotFoundException $e) {
+            return false;
+        }
+        $names = array_map(function ($object) {
+            return $object['basename'];
+        }, $content);
+        return IteratorDirectory::wrap($names);
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function fopen($path, $mode) {
-		$fullPath = $this->buildPath($path);
-		$useExisting = true;
-		switch ($mode) {
-			case 'r':
-			case 'rb':
-				try {
-					return $this->flysystem->readStream($fullPath);
-				} catch (FileNotFoundException $e) {
-					return false;
-				}
-			case 'w':
-			case 'w+':
-			case 'wb':
-			case 'wb+':
-				$useExisting = false;
-			case 'a':
-			case 'ab':
-			case 'r+':
-			case 'a+':
-			case 'x':
-			case 'x+':
-			case 'c':
-			case 'c+':
-				//emulate these
-				if ($useExisting and $this->file_exists($path)) {
-					if (!$this->isUpdatable($path)) {
-						return false;
-					}
-					$tmpFile = $this->getCachedFile($path);
-				} else {
-					if (!$this->isCreatable(dirname($path))) {
-						return false;
-					}
-					$tmpFile = \OCP\Files::tmpFile();
-				}
-				$source = fopen($tmpFile, $mode);
-				return CallbackWrapper::wrap($source, null, null, function () use ($tmpFile, $fullPath) {
-					$this->flysystem->putStream($fullPath, fopen($tmpFile, 'r'));
-					unlink($tmpFile);
-				});
-		}
-		return false;
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function fopen($path, $mode) {
+        $fullPath = $this->buildPath($path);
+        $useExisting = true;
+        switch ($mode) {
+            case 'r':
+            case 'rb':
+                try {
+                    return $this->flysystem->readStream($fullPath);
+                } catch (FileNotFoundException $e) {
+                    return false;
+                }
+            case 'w':
+            case 'w+':
+            case 'wb':
+            case 'wb+':
+                $useExisting = false;
+            case 'a':
+            case 'ab':
+            case 'r+':
+            case 'a+':
+            case 'x':
+            case 'x+':
+            case 'c':
+            case 'c+':
+                //emulate these
+                if ($useExisting and $this->file_exists($path)) {
+                    if (!$this->isUpdatable($path)) {
+                        return false;
+                    }
+                    $tmpFile = $this->getCachedFile($path);
+                } else {
+                    if (!$this->isCreatable(dirname($path))) {
+                        return false;
+                    }
+                    $tmpFile = \OCP\Files::tmpFile();
+                }
+                $source = fopen($tmpFile, $mode);
+                return CallbackWrapper::wrap($source, null, null, function () use ($tmpFile, $fullPath) {
+                    $this->flysystem->putStream($fullPath, fopen($tmpFile, 'r'));
+                    unlink($tmpFile);
+                });
+        }
+        return false;
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function touch($path, $mtime = null) {
-		if ($this->file_exists($path)) {
-			return false;
-		} else {
-			$this->file_put_contents($path, '');
-			return true;
-		}
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function touch($path, $mtime = null) {
+        if ($this->file_exists($path)) {
+            return false;
+        } else {
+            $this->file_put_contents($path, '');
+            return true;
+        }
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function stat($path) {
-		$info = $this->flysystem->getWithMetadata($this->buildPath($path), ['timestamp', 'size']);
-		return [
-			'mtime' => $info['timestamp'],
-			'size' => $info['size']
-		];
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function stat($path) {
+        $info = $this->flysystem->getWithMetadata($this->buildPath($path), ['timestamp', 'size']);
+        return [
+            'mtime' => $info['timestamp'],
+            'size' => $info['size']
+        ];
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	public function filetype($path) {
-		if ($path === '' or $path === '/' or $path === '.') {
-			return 'dir';
-		}
-		try {
-			$info = $this->flysystem->getMetadata($this->buildPath($path));
-		} catch (FileNotFoundException $e) {
-			return false;
-		}
-		return $info['type'];
-	}
+    /**
+     * {@inheritdoc}
+     */
+    public function filetype($path) {
+        if ($path === '' or $path === '/' or $path === '.') {
+            return 'dir';
+        }
+        try {
+            $info = $this->flysystem->getMetadata($this->buildPath($path));
+        } catch (FileNotFoundException $e) {
+            return false;
+        }
+        return $info['type'];
+    }
 }

lib/private/Files/Storage/CommonTest.php

Indentation +47 added lines, -47 removed lines

@@ -33,53 +33,53 @@
 namespace OC\Files\Storage;
 
 class CommonTest extends \OC\Files\Storage\Common{
-	/**
-	 * underlying local storage used for missing functions
-	 * @var \OC\Files\Storage\Local
-	 */
-	private $storage;
+    /**
+     * underlying local storage used for missing functions
+     * @var \OC\Files\Storage\Local
+     */
+    private $storage;
 
-	public function __construct($params) {
-		$this->storage=new \OC\Files\Storage\Local($params);
-	}
+    public function __construct($params) {
+        $this->storage=new \OC\Files\Storage\Local($params);
+    }
 
-	public function getId(){
-		return 'test::'.$this->storage->getId();
-	}
-	public function mkdir($path) {
-		return $this->storage->mkdir($path);
-	}
-	public function rmdir($path) {
-		return $this->storage->rmdir($path);
-	}
-	public function opendir($path) {
-		return $this->storage->opendir($path);
-	}
-	public function stat($path) {
-		return $this->storage->stat($path);
-	}
-	public function filetype($path) {
-		return @$this->storage->filetype($path);
-	}
-	public function isReadable($path) {
-		return $this->storage->isReadable($path);
-	}
-	public function isUpdatable($path) {
-		return $this->storage->isUpdatable($path);
-	}
-	public function file_exists($path) {
-		return $this->storage->file_exists($path);
-	}
-	public function unlink($path) {
-		return $this->storage->unlink($path);
-	}
-	public function fopen($path, $mode) {
-		return $this->storage->fopen($path, $mode);
-	}
-	public function free_space($path) {
-		return $this->storage->free_space($path);
-	}
-	public function touch($path, $mtime=null) {
-		return $this->storage->touch($path, $mtime);
-	}
+    public function getId(){
+        return 'test::'.$this->storage->getId();
+    }
+    public function mkdir($path) {
+        return $this->storage->mkdir($path);
+    }
+    public function rmdir($path) {
+        return $this->storage->rmdir($path);
+    }
+    public function opendir($path) {
+        return $this->storage->opendir($path);
+    }
+    public function stat($path) {
+        return $this->storage->stat($path);
+    }
+    public function filetype($path) {
+        return @$this->storage->filetype($path);
+    }
+    public function isReadable($path) {
+        return $this->storage->isReadable($path);
+    }
+    public function isUpdatable($path) {
+        return $this->storage->isUpdatable($path);
+    }
+    public function file_exists($path) {
+        return $this->storage->file_exists($path);
+    }
+    public function unlink($path) {
+        return $this->storage->unlink($path);
+    }
+    public function fopen($path, $mode) {
+        return $this->storage->fopen($path, $mode);
+    }
+    public function free_space($path) {
+        return $this->storage->free_space($path);
+    }
+    public function touch($path, $mtime=null) {
+        return $this->storage->touch($path, $mtime);
+    }
 }

lib/private/Files/Notify/RenameChange.php

Indentation +21 added lines, -21 removed lines

@@ -26,27 +26,27 @@
 use OCP\Files\Notify\IRenameChange;
 
 class RenameChange extends Change implements IRenameChange {
-	/** @var string */
-	private $targetPath;
+    /** @var string */
+    private $targetPath;
 
-	/**
-	 * Change constructor.
-	 *
-	 * @param int $type
-	 * @param string $path
-	 * @param string $targetPath
-	 */
-	public function __construct($type, $path, $targetPath) {
-		parent::__construct($type, $path);
-		$this->targetPath = $targetPath;
-	}
+    /**
+     * Change constructor.
+     *
+     * @param int $type
+     * @param string $path
+     * @param string $targetPath
+     */
+    public function __construct($type, $path, $targetPath) {
+        parent::__construct($type, $path);
+        $this->targetPath = $targetPath;
+    }
 
-	/**
-	 * Get the new path of the renamed file relative to the storage root
-	 *
-	 * @return string
-	 */
-	public function getTargetPath() {
-		return $this->targetPath;
-	}
+    /**
+     * Get the new path of the renamed file relative to the storage root
+     *
+     * @return string
+     */
+    public function getTargetPath() {
+        return $this->targetPath;
+    }
 }

lib/private/Files/Notify/Change.php

Indentation +32 added lines, -32 removed lines

@@ -26,40 +26,40 @@
 use OCP\Files\Notify\IChange;
 
 class Change implements IChange {
-	/** @var int */
-	private $type;
+    /** @var int */
+    private $type;
 
-	/** @var string */
-	private $path;
+    /** @var string */
+    private $path;
 
-	/**
-	 * Change constructor.
-	 *
-	 * @param int $type
-	 * @param string $path
-	 */
-	public function __construct($type, $path) {
-		$this->type = $type;
-		$this->path = $path;
-	}
+    /**
+     * Change constructor.
+     *
+     * @param int $type
+     * @param string $path
+     */
+    public function __construct($type, $path) {
+        $this->type = $type;
+        $this->path = $path;
+    }
 
-	/**
-	 * Get the type of the change
-	 *
-	 * @return int IChange::ADDED, IChange::REMOVED, IChange::MODIFIED or IChange::RENAMED
-	 */
-	public function getType() {
-		return $this->type;
-	}
+    /**
+     * Get the type of the change
+     *
+     * @return int IChange::ADDED, IChange::REMOVED, IChange::MODIFIED or IChange::RENAMED
+     */
+    public function getType() {
+        return $this->type;
+    }
 
-	/**
-	 * Get the path of the file that was changed relative to the root of the storage
-	 *
-	 * Note, for rename changes this path is the old path for the file
-	 *
-	 * @return mixed
-	 */
-	public function getPath() {
-		return $this->path;
-	}
+    /**
+     * Get the path of the file that was changed relative to the root of the storage
+     *
+     * Note, for rename changes this path is the old path for the file
+     *
+     * @return mixed
+     */
+    public function getPath() {
+        return $this->path;
+    }
 }

lib/private/Files/Cache/Storage.php

Indentation +157 added lines, -157 removed lines

@@ -40,161 +40,161 @@
  * @package OC\Files\Cache
  */
 class Storage {
-	/** @var StorageGlobal|null */
-	private static $globalCache = null;
-	private $storageId;
-	private $numericId;
-
-	/**
-	 * @return StorageGlobal
-	 */
-	public static function getGlobalCache() {
-		if (is_null(self::$globalCache)) {
-			self::$globalCache = new StorageGlobal(\OC::$server->getDatabaseConnection());
-		}
-		return self::$globalCache;
-	}
-
-	/**
-	 * @param \OC\Files\Storage\Storage|string $storage
-	 * @param bool $isAvailable
-	 * @throws \RuntimeException
-	 */
-	public function __construct($storage, $isAvailable = true) {
-		if ($storage instanceof \OC\Files\Storage\Storage) {
-			$this->storageId = $storage->getId();
-		} else {
-			$this->storageId = $storage;
-		}
-		$this->storageId = self::adjustStorageId($this->storageId);
-
-		if ($row = self::getStorageById($this->storageId)) {
-			$this->numericId = (int)$row['numeric_id'];
-		} else {
-			$connection = \OC::$server->getDatabaseConnection();
-			$available = $isAvailable ? 1 : 0;
-			if ($connection->insertIfNotExist('*PREFIX*storages', ['id' => $this->storageId, 'available' => $available])) {
-				$this->numericId = (int)$connection->lastInsertId('*PREFIX*storages');
-			} else {
-				if ($row = self::getStorageById($this->storageId)) {
-					$this->numericId = (int)$row['numeric_id'];
-				} else {
-					throw new \RuntimeException('Storage could neither be inserted nor be selected from the database');
-				}
-			}
-		}
-	}
-
-	/**
-	 * @param string $storageId
-	 * @return array
-	 */
-	public static function getStorageById($storageId) {
-		return self::getGlobalCache()->getStorageInfo($storageId);
-	}
-
-	/**
-	 * Adjusts the storage id to use md5 if too long
-	 * @param string $storageId storage id
-	 * @return string unchanged $storageId if its length is less than 64 characters,
-	 * else returns the md5 of $storageId
-	 */
-	public static function adjustStorageId($storageId) {
-		if (strlen($storageId) > 64) {
-			return md5($storageId);
-		}
-		return $storageId;
-	}
-
-	/**
-	 * Get the numeric id for the storage
-	 *
-	 * @return int
-	 */
-	public function getNumericId() {
-		return $this->numericId;
-	}
-
-	/**
-	 * Get the string id for the storage
-	 *
-	 * @param int $numericId
-	 * @return string|null either the storage id string or null if the numeric id is not known
-	 */
-	public static function getStorageId($numericId) {
-
-		$sql = 'SELECT `id` FROM `*PREFIX*storages` WHERE `numeric_id` = ?';
-		$result = \OC_DB::executeAudited($sql, array($numericId));
-		if ($row = $result->fetchRow()) {
-			return $row['id'];
-		} else {
-			return null;
-		}
-	}
-
-	/**
-	 * Get the numeric of the storage with the provided string id
-	 *
-	 * @param $storageId
-	 * @return int|null either the numeric storage id or null if the storage id is not knwon
-	 */
-	public static function getNumericStorageId($storageId) {
-		$storageId = self::adjustStorageId($storageId);
-
-		if ($row = self::getStorageById($storageId)) {
-			return (int)$row['numeric_id'];
-		} else {
-			return null;
-		}
-	}
-
-	/**
-	 * @return array|null [ available, last_checked ]
-	 */
-	public function getAvailability() {
-		if ($row = self::getStorageById($this->storageId)) {
-			return [
-				'available' => ((int)$row['available'] === 1),
-				'last_checked' => $row['last_checked']
-			];
-		} else {
-			return null;
-		}
-	}
-
-	/**
-	 * @param bool $isAvailable
-	 */
-	public function setAvailability($isAvailable) {
-		$sql = 'UPDATE `*PREFIX*storages` SET `available` = ?, `last_checked` = ? WHERE `id` = ?';
-		$available = $isAvailable ? 1 : 0;
-		\OC_DB::executeAudited($sql, array($available, time(), $this->storageId));
-	}
-
-	/**
-	 * Check if a string storage id is known
-	 *
-	 * @param string $storageId
-	 * @return bool
-	 */
-	public static function exists($storageId) {
-		return !is_null(self::getNumericStorageId($storageId));
-	}
-
-	/**
-	 * remove the entry for the storage
-	 *
-	 * @param string $storageId
-	 */
-	public static function remove($storageId) {
-		$storageId = self::adjustStorageId($storageId);
-		$numericId = self::getNumericStorageId($storageId);
-		$sql = 'DELETE FROM `*PREFIX*storages` WHERE `id` = ?';
-		\OC_DB::executeAudited($sql, array($storageId));
-
-		if (!is_null($numericId)) {
-			$sql = 'DELETE FROM `*PREFIX*filecache` WHERE `storage` = ?';
-			\OC_DB::executeAudited($sql, array($numericId));
-		}
-	}
+    /** @var StorageGlobal|null */
+    private static $globalCache = null;
+    private $storageId;
+    private $numericId;
+
+    /**
+     * @return StorageGlobal
+     */
+    public static function getGlobalCache() {
+        if (is_null(self::$globalCache)) {
+            self::$globalCache = new StorageGlobal(\OC::$server->getDatabaseConnection());
+        }
+        return self::$globalCache;
+    }
+
+    /**
+     * @param \OC\Files\Storage\Storage|string $storage
+     * @param bool $isAvailable
+     * @throws \RuntimeException
+     */
+    public function __construct($storage, $isAvailable = true) {
+        if ($storage instanceof \OC\Files\Storage\Storage) {
+            $this->storageId = $storage->getId();
+        } else {
+            $this->storageId = $storage;
+        }
+        $this->storageId = self::adjustStorageId($this->storageId);
+
+        if ($row = self::getStorageById($this->storageId)) {
+            $this->numericId = (int)$row['numeric_id'];
+        } else {
+            $connection = \OC::$server->getDatabaseConnection();
+            $available = $isAvailable ? 1 : 0;
+            if ($connection->insertIfNotExist('*PREFIX*storages', ['id' => $this->storageId, 'available' => $available])) {
+                $this->numericId = (int)$connection->lastInsertId('*PREFIX*storages');
+            } else {
+                if ($row = self::getStorageById($this->storageId)) {
+                    $this->numericId = (int)$row['numeric_id'];
+                } else {
+                    throw new \RuntimeException('Storage could neither be inserted nor be selected from the database');
+                }
+            }
+        }
+    }
+
+    /**
+     * @param string $storageId
+     * @return array
+     */
+    public static function getStorageById($storageId) {
+        return self::getGlobalCache()->getStorageInfo($storageId);
+    }
+
+    /**
+     * Adjusts the storage id to use md5 if too long
+     * @param string $storageId storage id
+     * @return string unchanged $storageId if its length is less than 64 characters,
+     * else returns the md5 of $storageId
+     */
+    public static function adjustStorageId($storageId) {
+        if (strlen($storageId) > 64) {
+            return md5($storageId);
+        }
+        return $storageId;
+    }
+
+    /**
+     * Get the numeric id for the storage
+     *
+     * @return int
+     */
+    public function getNumericId() {
+        return $this->numericId;
+    }
+
+    /**
+     * Get the string id for the storage
+     *
+     * @param int $numericId
+     * @return string|null either the storage id string or null if the numeric id is not known
+     */
+    public static function getStorageId($numericId) {
+
+        $sql = 'SELECT `id` FROM `*PREFIX*storages` WHERE `numeric_id` = ?';
+        $result = \OC_DB::executeAudited($sql, array($numericId));
+        if ($row = $result->fetchRow()) {
+            return $row['id'];
+        } else {
+            return null;
+        }
+    }
+
+    /**
+     * Get the numeric of the storage with the provided string id
+     *
+     * @param $storageId
+     * @return int|null either the numeric storage id or null if the storage id is not knwon
+     */
+    public static function getNumericStorageId($storageId) {
+        $storageId = self::adjustStorageId($storageId);
+
+        if ($row = self::getStorageById($storageId)) {
+            return (int)$row['numeric_id'];
+        } else {
+            return null;
+        }
+    }
+
+    /**
+     * @return array|null [ available, last_checked ]
+     */
+    public function getAvailability() {
+        if ($row = self::getStorageById($this->storageId)) {
+            return [
+                'available' => ((int)$row['available'] === 1),
+                'last_checked' => $row['last_checked']
+            ];
+        } else {
+            return null;
+        }
+    }
+
+    /**
+     * @param bool $isAvailable
+     */
+    public function setAvailability($isAvailable) {
+        $sql = 'UPDATE `*PREFIX*storages` SET `available` = ?, `last_checked` = ? WHERE `id` = ?';
+        $available = $isAvailable ? 1 : 0;
+        \OC_DB::executeAudited($sql, array($available, time(), $this->storageId));
+    }
+
+    /**
+     * Check if a string storage id is known
+     *
+     * @param string $storageId
+     * @return bool
+     */
+    public static function exists($storageId) {
+        return !is_null(self::getNumericStorageId($storageId));
+    }
+
+    /**
+     * remove the entry for the storage
+     *
+     * @param string $storageId
+     */
+    public static function remove($storageId) {
+        $storageId = self::adjustStorageId($storageId);
+        $numericId = self::getNumericStorageId($storageId);
+        $sql = 'DELETE FROM `*PREFIX*storages` WHERE `id` = ?';
+        \OC_DB::executeAudited($sql, array($storageId));
+
+        if (!is_null($numericId)) {
+            $sql = 'DELETE FROM `*PREFIX*filecache` WHERE `storage` = ?';
+            \OC_DB::executeAudited($sql, array($numericId));
+        }
+    }
 }

lib/private/Files/Cache/HomePropagator.php

Indentation +21 added lines, -21 removed lines

@@ -25,28 +25,28 @@
 use OCP\IDBConnection;
 
 class HomePropagator extends Propagator {
-	private $ignoredBaseFolders;
+    private $ignoredBaseFolders;
 
-	/**
-	 * @param \OC\Files\Storage\Storage $storage
-	 */
-	public function __construct(\OC\Files\Storage\Storage $storage, IDBConnection $connection) {
-		parent::__construct($storage, $connection);
-		$this->ignoredBaseFolders = ['files_encryption'];
-	}
+    /**
+     * @param \OC\Files\Storage\Storage $storage
+     */
+    public function __construct(\OC\Files\Storage\Storage $storage, IDBConnection $connection) {
+        parent::__construct($storage, $connection);
+        $this->ignoredBaseFolders = ['files_encryption'];
+    }
 
 
-	/**
-	 * @param string $internalPath
-	 * @param int $time
-	 * @param int $sizeDifference number of bytes the file has grown
-	 */
-	public function propagateChange($internalPath, $time, $sizeDifference = 0) {
-		list($baseFolder) = explode('/', $internalPath, 2);
-		if (in_array($baseFolder, $this->ignoredBaseFolders)) {
-			return [];
-		} else {
-			parent::propagateChange($internalPath, $time, $sizeDifference);
-		}
-	}
+    /**
+     * @param string $internalPath
+     * @param int $time
+     * @param int $sizeDifference number of bytes the file has grown
+     */
+    public function propagateChange($internalPath, $time, $sizeDifference = 0) {
+        list($baseFolder) = explode('/', $internalPath, 2);
+        if (in_array($baseFolder, $this->ignoredBaseFolders)) {
+            return [];
+        } else {
+            parent::propagateChange($internalPath, $time, $sizeDifference);
+        }
+    }
 }

lib/private/Files/Cache/Updater.php

Indentation +212 added lines, -212 removed lines

@@ -36,216 +36,216 @@
  *
  */
 class Updater implements IUpdater {
-	/**
-	 * @var bool
-	 */
-	protected $enabled = true;
-
-	/**
-	 * @var \OC\Files\Storage\Storage
-	 */
-	protected $storage;
-
-	/**
-	 * @var \OC\Files\Cache\Propagator
-	 */
-	protected $propagator;
-
-	/**
-	 * @var Scanner
-	 */
-	protected $scanner;
-
-	/**
-	 * @var Cache
-	 */
-	protected $cache;
-
-	/**
-	 * @param \OC\Files\Storage\Storage $storage
-	 */
-	public function __construct(\OC\Files\Storage\Storage $storage) {
-		$this->storage = $storage;
-		$this->propagator = $storage->getPropagator();
-		$this->scanner = $storage->getScanner();
-		$this->cache = $storage->getCache();
-	}
-
-	/**
-	 * Disable updating the cache trough this updater
-	 */
-	public function disable() {
-		$this->enabled = false;
-	}
-
-	/**
-	 * Re-enable the updating of the cache trough this updater
-	 */
-	public function enable() {
-		$this->enabled = true;
-	}
-
-	/**
-	 * Get the propagator for etags and mtime for the view the updater works on
-	 *
-	 * @return Propagator
-	 */
-	public function getPropagator() {
-		return $this->propagator;
-	}
-
-	/**
-	 * Propagate etag and mtime changes for the parent folders of $path up to the root of the filesystem
-	 *
-	 * @param string $path the path of the file to propagate the changes for
-	 * @param int|null $time the timestamp to set as mtime for the parent folders, if left out the current time is used
-	 */
-	public function propagate($path, $time = null) {
-		if (Scanner::isPartialFile($path)) {
-			return;
-		}
-		$this->propagator->propagateChange($path, $time);
-	}
-
-	/**
-	 * Update the cache for $path and update the size, etag and mtime of the parent folders
-	 *
-	 * @param string $path
-	 * @param int $time
-	 */
-	public function update($path, $time = null) {
-		if (!$this->enabled or Scanner::isPartialFile($path)) {
-			return;
-		}
-		if (is_null($time)) {
-			$time = time();
-		}
-
-		$data = $this->scanner->scan($path, Scanner::SCAN_SHALLOW, -1, false);
-		if (
-			isset($data['oldSize']) && isset($data['size']) &&
-			!$data['encrypted'] // encryption is a pita and touches the cache itself
-		) {
-			$sizeDifference = $data['size'] - $data['oldSize'];
-		} else {
-			// scanner didn't provide size info, fallback to full size calculation
-			$sizeDifference = 0;
-			if ($this->cache instanceof Cache) {
-				$this->cache->correctFolderSize($path, $data);
-			}
-		}
-		$this->correctParentStorageMtime($path);
-		$this->propagator->propagateChange($path, $time, $sizeDifference);
-	}
-
-	/**
-	 * Remove $path from the cache and update the size, etag and mtime of the parent folders
-	 *
-	 * @param string $path
-	 */
-	public function remove($path) {
-		if (!$this->enabled or Scanner::isPartialFile($path)) {
-			return;
-		}
-
-		$parent = dirname($path);
-		if ($parent === '.') {
-			$parent = '';
-		}
-
-		$entry = $this->cache->get($path);
-
-		$this->cache->remove($path);
-
-		$this->correctParentStorageMtime($path);
-		if ($entry instanceof ICacheEntry) {
-			$this->propagator->propagateChange($path, time(), -$entry->getSize());
-		} else {
-			$this->propagator->propagateChange($path, time());
-			if ($this->cache instanceof Cache) {
-				$this->cache->correctFolderSize($parent);
-			}
-		}
-
-	}
-
-	/**
-	 * Rename a file or folder in the cache and update the size, etag and mtime of the parent folders
-	 *
-	 * @param IStorage $sourceStorage
-	 * @param string $source
-	 * @param string $target
-	 */
-	public function renameFromStorage(IStorage $sourceStorage, $source, $target) {
-		if (!$this->enabled or Scanner::isPartialFile($source) or Scanner::isPartialFile($target)) {
-			return;
-		}
-
-		$time = time();
-
-		$sourceCache = $sourceStorage->getCache();
-		$sourceUpdater = $sourceStorage->getUpdater();
-		$sourcePropagator = $sourceStorage->getPropagator();
-
-		if ($sourceCache->inCache($source)) {
-			if ($this->cache->inCache($target)) {
-				$this->cache->remove($target);
-			}
-
-			if ($sourceStorage === $this->storage) {
-				$this->cache->move($source, $target);
-			} else {
-				$this->cache->moveFromCache($sourceCache, $source, $target);
-			}
-		}
-
-		if (pathinfo($source, PATHINFO_EXTENSION) !== pathinfo($target, PATHINFO_EXTENSION)) {
-			// handle mime type change
-			$mimeType = $this->storage->getMimeType($target);
-			$fileId = $this->cache->getId($target);
-			$this->cache->update($fileId, ['mimetype' => $mimeType]);
-		}
-
-		if ($sourceCache instanceof Cache) {
-			$sourceCache->correctFolderSize($source);
-		}
-		if ($this->cache instanceof Cache) {
-			$this->cache->correctFolderSize($target);
-		}
-		if ($sourceUpdater instanceof Updater) {
-			$sourceUpdater->correctParentStorageMtime($source);
-		}
-		$this->correctParentStorageMtime($target);
-		$this->updateStorageMTimeOnly($target);
-		$sourcePropagator->propagateChange($source, $time);
-		$this->propagator->propagateChange($target, $time);
-	}
-
-	private function updateStorageMTimeOnly($internalPath) {
-		$fileId = $this->cache->getId($internalPath);
-		if ($fileId !== -1) {
-			$this->cache->update(
-				$fileId, [
-					'mtime' => null, // this magic tells it to not overwrite mtime
-					'storage_mtime' => $this->storage->filemtime($internalPath)
-				]
-			);
-		}
-	}
-
-	/**
-	 * update the storage_mtime of the direct parent in the cache to the mtime from the storage
-	 *
-	 * @param string $internalPath
-	 */
-	private function correctParentStorageMtime($internalPath) {
-		$parentId = $this->cache->getParentId($internalPath);
-		$parent = dirname($internalPath);
-		if ($parentId != -1) {
-			$mtime = $this->storage->filemtime($parent);
-			if ($mtime !== false) {
-				$this->cache->update($parentId, array('storage_mtime' => $mtime));
-			}
-		}
-	}
+    /**
+     * @var bool
+     */
+    protected $enabled = true;
+
+    /**
+     * @var \OC\Files\Storage\Storage
+     */
+    protected $storage;
+
+    /**
+     * @var \OC\Files\Cache\Propagator
+     */
+    protected $propagator;
+
+    /**
+     * @var Scanner
+     */
+    protected $scanner;
+
+    /**
+     * @var Cache
+     */
+    protected $cache;
+
+    /**
+     * @param \OC\Files\Storage\Storage $storage
+     */
+    public function __construct(\OC\Files\Storage\Storage $storage) {
+        $this->storage = $storage;
+        $this->propagator = $storage->getPropagator();
+        $this->scanner = $storage->getScanner();
+        $this->cache = $storage->getCache();
+    }
+
+    /**
+     * Disable updating the cache trough this updater
+     */
+    public function disable() {
+        $this->enabled = false;
+    }
+
+    /**
+     * Re-enable the updating of the cache trough this updater
+     */
+    public function enable() {
+        $this->enabled = true;
+    }
+
+    /**
+     * Get the propagator for etags and mtime for the view the updater works on
+     *
+     * @return Propagator
+     */
+    public function getPropagator() {
+        return $this->propagator;
+    }
+
+    /**
+     * Propagate etag and mtime changes for the parent folders of $path up to the root of the filesystem
+     *
+     * @param string $path the path of the file to propagate the changes for
+     * @param int|null $time the timestamp to set as mtime for the parent folders, if left out the current time is used
+     */
+    public function propagate($path, $time = null) {
+        if (Scanner::isPartialFile($path)) {
+            return;
+        }
+        $this->propagator->propagateChange($path, $time);
+    }
+
+    /**
+     * Update the cache for $path and update the size, etag and mtime of the parent folders
+     *
+     * @param string $path
+     * @param int $time
+     */
+    public function update($path, $time = null) {
+        if (!$this->enabled or Scanner::isPartialFile($path)) {
+            return;
+        }
+        if (is_null($time)) {
+            $time = time();
+        }
+
+        $data = $this->scanner->scan($path, Scanner::SCAN_SHALLOW, -1, false);
+        if (
+            isset($data['oldSize']) && isset($data['size']) &&
+            !$data['encrypted'] // encryption is a pita and touches the cache itself
+        ) {
+            $sizeDifference = $data['size'] - $data['oldSize'];
+        } else {
+            // scanner didn't provide size info, fallback to full size calculation
+            $sizeDifference = 0;
+            if ($this->cache instanceof Cache) {
+                $this->cache->correctFolderSize($path, $data);
+            }
+        }
+        $this->correctParentStorageMtime($path);
+        $this->propagator->propagateChange($path, $time, $sizeDifference);
+    }
+
+    /**
+     * Remove $path from the cache and update the size, etag and mtime of the parent folders
+     *
+     * @param string $path
+     */
+    public function remove($path) {
+        if (!$this->enabled or Scanner::isPartialFile($path)) {
+            return;
+        }
+
+        $parent = dirname($path);
+        if ($parent === '.') {
+            $parent = '';
+        }
+
+        $entry = $this->cache->get($path);
+
+        $this->cache->remove($path);
+
+        $this->correctParentStorageMtime($path);
+        if ($entry instanceof ICacheEntry) {
+            $this->propagator->propagateChange($path, time(), -$entry->getSize());
+        } else {
+            $this->propagator->propagateChange($path, time());
+            if ($this->cache instanceof Cache) {
+                $this->cache->correctFolderSize($parent);
+            }
+        }
+
+    }
+
+    /**
+     * Rename a file or folder in the cache and update the size, etag and mtime of the parent folders
+     *
+     * @param IStorage $sourceStorage
+     * @param string $source
+     * @param string $target
+     */
+    public function renameFromStorage(IStorage $sourceStorage, $source, $target) {
+        if (!$this->enabled or Scanner::isPartialFile($source) or Scanner::isPartialFile($target)) {
+            return;
+        }
+
+        $time = time();
+
+        $sourceCache = $sourceStorage->getCache();
+        $sourceUpdater = $sourceStorage->getUpdater();
+        $sourcePropagator = $sourceStorage->getPropagator();
+
+        if ($sourceCache->inCache($source)) {
+            if ($this->cache->inCache($target)) {
+                $this->cache->remove($target);
+            }
+
+            if ($sourceStorage === $this->storage) {
+                $this->cache->move($source, $target);
+            } else {
+                $this->cache->moveFromCache($sourceCache, $source, $target);
+            }
+        }
+
+        if (pathinfo($source, PATHINFO_EXTENSION) !== pathinfo($target, PATHINFO_EXTENSION)) {
+            // handle mime type change
+            $mimeType = $this->storage->getMimeType($target);
+            $fileId = $this->cache->getId($target);
+            $this->cache->update($fileId, ['mimetype' => $mimeType]);
+        }
+
+        if ($sourceCache instanceof Cache) {
+            $sourceCache->correctFolderSize($source);
+        }
+        if ($this->cache instanceof Cache) {
+            $this->cache->correctFolderSize($target);
+        }
+        if ($sourceUpdater instanceof Updater) {
+            $sourceUpdater->correctParentStorageMtime($source);
+        }
+        $this->correctParentStorageMtime($target);
+        $this->updateStorageMTimeOnly($target);
+        $sourcePropagator->propagateChange($source, $time);
+        $this->propagator->propagateChange($target, $time);
+    }
+
+    private function updateStorageMTimeOnly($internalPath) {
+        $fileId = $this->cache->getId($internalPath);
+        if ($fileId !== -1) {
+            $this->cache->update(
+                $fileId, [
+                    'mtime' => null, // this magic tells it to not overwrite mtime
+                    'storage_mtime' => $this->storage->filemtime($internalPath)
+                ]
+            );
+        }
+    }
+
+    /**
+     * update the storage_mtime of the direct parent in the cache to the mtime from the storage
+     *
+     * @param string $internalPath
+     */
+    private function correctParentStorageMtime($internalPath) {
+        $parentId = $this->cache->getParentId($internalPath);
+        $parent = dirname($internalPath);
+        if ($parentId != -1) {
+            $mtime = $this->storage->filemtime($parent);
+            if ($mtime !== false) {
+                $this->cache->update($parentId, array('storage_mtime' => $mtime));
+            }
+        }
+    }
 }

lib/private/Files/Cache/CacheEntry.php

Indentation +62 added lines, -62 removed lines

@@ -28,88 +28,88 @@
  * meta data for a file or folder
  */
 class CacheEntry implements ICacheEntry, \ArrayAccess {
-	/**
-	 * @var array
-	 */
-	private $data;
+    /**
+     * @var array
+     */
+    private $data;
 
-	public function __construct(array $data) {
-		$this->data = $data;
-	}
+    public function __construct(array $data) {
+        $this->data = $data;
+    }
 
-	public function offsetSet($offset, $value) {
-		$this->data[$offset] = $value;
-	}
+    public function offsetSet($offset, $value) {
+        $this->data[$offset] = $value;
+    }
 
-	public function offsetExists($offset) {
-		return isset($this->data[$offset]);
-	}
+    public function offsetExists($offset) {
+        return isset($this->data[$offset]);
+    }
 
-	public function offsetUnset($offset) {
-		unset($this->data[$offset]);
-	}
+    public function offsetUnset($offset) {
+        unset($this->data[$offset]);
+    }
 
-	public function offsetGet($offset) {
-		if (isset($this->data[$offset])) {
-			return $this->data[$offset];
-		} else {
-			return null;
-		}
-	}
+    public function offsetGet($offset) {
+        if (isset($this->data[$offset])) {
+            return $this->data[$offset];
+        } else {
+            return null;
+        }
+    }
 
-	public function getId() {
-		return (int)$this->data['fileid'];
-	}
+    public function getId() {
+        return (int)$this->data['fileid'];
+    }
 
-	public function getStorageId() {
-		return $this->data['storage'];
-	}
+    public function getStorageId() {
+        return $this->data['storage'];
+    }
 
 
-	public function getPath() {
-		return $this->data['path'];
-	}
+    public function getPath() {
+        return $this->data['path'];
+    }
 
 
-	public function getName() {
-		return $this->data['name'];
-	}
+    public function getName() {
+        return $this->data['name'];
+    }
 
 
-	public function getMimeType() {
-		return $this->data['mimetype'];
-	}
+    public function getMimeType() {
+        return $this->data['mimetype'];
+    }
 
 
-	public function getMimePart() {
-		return $this->data['mimepart'];
-	}
+    public function getMimePart() {
+        return $this->data['mimepart'];
+    }
 
-	public function getSize() {
-		return $this->data['size'];
-	}
+    public function getSize() {
+        return $this->data['size'];
+    }
 
-	public function getMTime() {
-		return $this->data['mtime'];
-	}
+    public function getMTime() {
+        return $this->data['mtime'];
+    }
 
-	public function getStorageMTime() {
-		return $this->data['storage_mtime'];
-	}
+    public function getStorageMTime() {
+        return $this->data['storage_mtime'];
+    }
 
-	public function getEtag() {
-		return $this->data['etag'];
-	}
+    public function getEtag() {
+        return $this->data['etag'];
+    }
 
-	public function getPermissions() {
-		return $this->data['permissions'];
-	}
+    public function getPermissions() {
+        return $this->data['permissions'];
+    }
 
-	public function isEncrypted() {
-		return isset($this->data['encrypted']) && $this->data['encrypted'];
-	}
+    public function isEncrypted() {
+        return isset($this->data['encrypted']) && $this->data['encrypted'];
+    }
 
-	public function getData() {
-		return $this->data;
-	}
+    public function getData() {
+        return $this->data;
+    }
 }