View GitHub Repository server

Schedule Inspection
Subscribe
Passed
Push — master ( 91788c...5495d2 )
by John
52:58 queued 39:06
created
Status
Category
Toggle Patches
apps/settings/templates/settings/admin/sharing.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch 
@@ -27,17 +27,17 @@  discard block
 
 block discarded – undo
27 27 
 ?>
28 28
29 29 
 <div class="section" id="shareAPI">
30 
-	<h2><?php p($l->t('Sharing'));?></h2>
30 
+	<h2><?php p($l->t('Sharing')); ?></h2>
31 31 
 	<a target="_blank" rel="noreferrer noopener" class="icon-info"
32 
-	   title="<?php p($l->t('Open documentation'));?>"
32 
+	   title="<?php p($l->t('Open documentation')); ?>"
33 33 
 	   href="<?php p(link_to_docs('admin-sharing')); ?>"></a>
34 
-        <p class="settings-hint"><?php p($l->t('As admin you can fine-tune the sharing behavior. Please see the documentation for more information.'));?></p>
34 
+        <p class="settings-hint"><?php p($l->t('As admin you can fine-tune the sharing behavior. Please see the documentation for more information.')); ?></p>
35 35 
 	<p id="enable">
36 36 
 		<input type="checkbox" name="shareapi_enabled" id="shareAPIEnabled" class="checkbox"
37 37 
 			   value="1" <?php if ($_['shareAPIEnabled'] === 'yes') {
38 38 
 	print_unescaped('checked="checked"');
39 39 
 } ?> />
40 
-		<label for="shareAPIEnabled"><?php p($l->t('Allow apps to use the Share API'));?></label><br/>
40 
+		<label for="shareAPIEnabled"><?php p($l->t('Allow apps to use the Share API')); ?></label><br/>
41 41 
 	</p>
42 42
43 43 
 	<p id="internalShareSettings" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
 
@@ -47,12 +47,12 @@  discard block
 
 block discarded – undo
47 47 
 			   value="1" <?php if ($_['shareDefaultInternalExpireDateSet'] === 'yes') {
48 48 
 	print_unescaped('checked="checked"');
49 49 
 } ?> />
50 
-		<label for="shareapiDefaultInternalExpireDate"><?php p($l->t('Set default expiration date for shares'));?></label><br/>
50 
+		<label for="shareapiDefaultInternalExpireDate"><?php p($l->t('Set default expiration date for shares')); ?></label><br/>
51 51 
 	</p>
52 52 
 	<p id="setDefaultInternalExpireDate" class="double-indent <?php if ($_['shareDefaultInternalExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') {
53 53 
 	p('hidden');
54 54 
 }?>">
55 
-		<?php p($l->t('Expire after') . ' '); ?>
55 
+		<?php p($l->t('Expire after').' '); ?>
56 56 
 		<input type="text" name='shareapi_internal_expire_after_n_days' id="shareapiInternalExpireAfterNDays" placeholder="<?php p('7')?>"
57 57 
 			   value='<?php p($_['shareInternalExpireAfterNDays']) ?>' />
58 58 
 		<?php p($l->t('days')); ?>
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
 			   value="1" <?php if ($_['shareInternalEnforceExpireDate'] === 'yes') {
61 61 
 	print_unescaped('checked="checked"');
62 62 
 } ?> />
63 
-		<label for="shareapiInternalEnforceExpireDate"><?php p($l->t('Enforce expiration date'));?></label><br/>
63 
+		<label for="shareapiInternalEnforceExpireDate"><?php p($l->t('Enforce expiration date')); ?></label><br/>
64 64 
 	</p>
65 65
66 66 
 	<p id="remoteShareSettings" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
 
@@ -70,12 +70,12 @@  discard block
 
 block discarded – undo
70 70 
 			   value="1" <?php if ($_['shareDefaultRemoteExpireDateSet'] === 'yes') {
71 71 
 	print_unescaped('checked="checked"');
72 72 
 } ?> />
73 
-		<label for="shareapiDefaultRemoteExpireDate"><?php p($l->t('Set default expiration date for shares to other servers'));?></label><br/>
73 
+		<label for="shareapiDefaultRemoteExpireDate"><?php p($l->t('Set default expiration date for shares to other servers')); ?></label><br/>
74 74 
 	</p>
75 75 
 	<p id="setDefaultRemoteExpireDate" class="double-indent <?php if ($_['shareDefaultRemoteExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') {
76 76 
 	p('hidden');
77 77 
 }?>">
78 
-		<?php p($l->t('Expire after'). ' '); ?>
78 
+		<?php p($l->t('Expire after').' '); ?>
79 79 
 		<input type="text" name='shareapi_remote_expire_after_n_days' id="shareapiRemoteExpireAfterNDays" placeholder="<?php p('7')?>"
80 80 
 			   value='<?php p($_['shareRemoteExpireAfterNDays']) ?>' />
81 81 
 		<?php p($l->t('days')); ?>
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
 			   value="1" <?php if ($_['shareRemoteEnforceExpireDate'] === 'yes') {
84 84 
 	print_unescaped('checked="checked"');
85 85 
 } ?> />
86 
-		<label for="shareapiRemoteEnforceExpireDate"><?php p($l->t('Enforce expiration date'));?></label><br/>
86 
+		<label for="shareapiRemoteEnforceExpireDate"><?php p($l->t('Enforce expiration date')); ?></label><br/>
87 87 
 	</p>
88 88
89 89 
 	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
 
@@ -93,7 +93,7 @@  discard block
 
 block discarded – undo
93 93 
 			   value="1" <?php if ($_['allowLinks'] === 'yes') {
94 94 
 	print_unescaped('checked="checked"');
95 95 
 } ?> />
96 
-		<label for="allowLinks"><?php p($l->t('Allow users to share via link and emails'));?></label><br/>
96 
+		<label for="allowLinks"><?php p($l->t('Allow users to share via link and emails')); ?></label><br/>
97 97 
 	</p>
98 98
99 99 
 	<p id="publicLinkSettings" class="indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareAPIEnabled'] === 'no') {
 
@@ -103,29 +103,29 @@  discard block
 
 block discarded – undo
103 103 
 			   value="1" <?php if ($_['allowPublicUpload'] == 'yes') {
104 104 
 	print_unescaped('checked="checked"');
105 105 
 } ?> />
106 
-		<label for="allowPublicUpload"><?php p($l->t('Allow public uploads'));?></label><br/>
106 
+		<label for="allowPublicUpload"><?php p($l->t('Allow public uploads')); ?></label><br/>
107 107 
 		<input type="checkbox" name="shareapi_enable_link_password_by_default" id="enableLinkPasswordByDefault" class="checkbox"
108 108 
 			   value="1" <?php if ($_['enableLinkPasswordByDefault'] === 'yes') {
109 109 
 	print_unescaped('checked="checked"');
110 110 
 } ?> />
111 
-		<label for="enableLinkPasswordByDefault"><?php p($l->t('Always ask for a password'));?></label><br/>
111 
+		<label for="enableLinkPasswordByDefault"><?php p($l->t('Always ask for a password')); ?></label><br/>
112 112 
 		<input type="checkbox" name="shareapi_enforce_links_password" id="enforceLinkPassword" class="checkbox"
113 113 
 			   value="1" <?php if ($_['enforceLinkPassword']) {
114 114 
 	print_unescaped('checked="checked"');
115 115 
 } ?> />
116 
-		<label for="enforceLinkPassword"><?php p($l->t('Enforce password protection'));?></label><br/>
116 
+		<label for="enforceLinkPassword"><?php p($l->t('Enforce password protection')); ?></label><br/>
117 117
118 118 
 		<input type="checkbox" name="shareapi_default_expire_date" id="shareapiDefaultExpireDate" class="checkbox"
119 119 
 			   value="1" <?php if ($_['shareDefaultExpireDateSet'] === 'yes') {
120 120 
 	print_unescaped('checked="checked"');
121 121 
 } ?> />
122 
-		<label for="shareapiDefaultExpireDate"><?php p($l->t('Set default expiration date'));?></label><br/>
122 
+		<label for="shareapiDefaultExpireDate"><?php p($l->t('Set default expiration date')); ?></label><br/>
123 123
124 124 
 	</p>
125 125 
 	<p id="setDefaultExpireDate" class="double-indent <?php if ($_['allowLinks'] !== 'yes' || $_['shareDefaultExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') {
126 126 
 	p('hidden');
127 127 
 }?>">
128 
-		<?php p($l->t('Expire after'). ' '); ?>
128 
+		<?php p($l->t('Expire after').' '); ?>
129 129 
 		<input type="text" name='shareapi_expire_after_n_days' id="shareapiExpireAfterNDays" placeholder="<?php p('7')?>"
130 130 
 			   value='<?php p($_['shareExpireAfterNDays']) ?>' />
131 131 
 		<?php p($l->t('days')); ?>
 
@@ -133,13 +133,13 @@  discard block
 
 block discarded – undo
133 133 
 			   value="1" <?php if ($_['shareEnforceExpireDate'] === 'yes') {
134 134 
 	print_unescaped('checked="checked"');
135 135 
 } ?> />
136 
-		<label for="shareapiEnforceExpireDate"><?php p($l->t('Enforce expiration date'));?></label><br/>
136 
+		<label for="shareapiEnforceExpireDate"><?php p($l->t('Enforce expiration date')); ?></label><br/>
137 137 
 	</p>
138 138 
 	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
139 139 
 	p('hidden');
140 140 
 }?>">
141 141 
 	<p class="indent">
142 
-		<?php p($l->t('Exclude groups from creating link shares:'));?>
142 
+		<?php p($l->t('Exclude groups from creating link shares:')); ?>
143 143 
 	</p>
144 144 
 	<p id="selectLinksExcludedGroups" class="indent <?php if ($_['allowLinks'] === 'no') {
145 145 
 	p('hidden');
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
 			   value="1" <?php if ($_['allowResharing'] === 'yes') {
151 151 
 	print_unescaped('checked="checked"');
152 152 
 } ?> />
153 
-		<label for="allowResharing"><?php p($l->t('Allow resharing'));?></label><br/>
153 
+		<label for="allowResharing"><?php p($l->t('Allow resharing')); ?></label><br/>
154 154 
 	</p>
155 155 
 	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
156 156 
 	p('hidden');
 
@@ -159,7 +159,7 @@  discard block
 
 block discarded – undo
159 159 
 			   value="1" <?php if ($_['allowGroupSharing'] === 'yes') {
160 160 
 	print_unescaped('checked="checked"');
161 161 
 } ?> />
162 
-		<label for="allowGroupSharing"><?php p($l->t('Allow sharing with groups'));?></label><br />
162 
+		<label for="allowGroupSharing"><?php p($l->t('Allow sharing with groups')); ?></label><br />
163 163 
 	</p>
164 164 
 	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
165 165 
 	p('hidden');
 
@@ -168,7 +168,7 @@  discard block
 
 block discarded – undo
168 168 
 			   value="1" <?php if ($_['onlyShareWithGroupMembers']) {
169 169 
 	print_unescaped('checked="checked"');
170 170 
 } ?> />
171 
-		<label for="onlyShareWithGroupMembers"><?php p($l->t('Restrict users to only share with users in their groups'));?></label><br/>
171 
+		<label for="onlyShareWithGroupMembers"><?php p($l->t('Restrict users to only share with users in their groups')); ?></label><br/>
172 172 
 	</p>
173 173 
 	<p class="<?php if ($_['shareAPIEnabled'] === 'no') {
174 174 
 	p('hidden');
 
@@ -177,7 +177,7 @@  discard block
 
 block discarded – undo
177 177 
 			   value="1" <?php if ($_['shareExcludeGroups']) {
178 178 
 	print_unescaped('checked="checked"');
179 179 
 } ?> />
180 
-		<label for="shareapiExcludeGroups"><?php p($l->t('Exclude groups from sharing'));?></label><br/>
180 
+		<label for="shareapiExcludeGroups"><?php p($l->t('Exclude groups from sharing')); ?></label><br/>
181 181 
 	</p>
182 182 
 	<p id="selectExcludedGroups" class="indent <?php if (!$_['shareExcludeGroups'] || $_['shareAPIEnabled'] === 'no') {
183 183 
 	p('hidden');
 
@@ -194,7 +194,7 @@  discard block
 
 block discarded – undo
194 194 
 			<?php if ($_['allowShareDialogUserEnumeration'] === 'yes') {
195 195 
 	print_unescaped('checked="checked"');
196 196 
 } ?> />
197 
-		<label for="shareapi_allow_share_dialog_user_enumeration"><?php p($l->t('Allow username autocompletion in share dialog'));?></label><br />
197 
+		<label for="shareapi_allow_share_dialog_user_enumeration"><?php p($l->t('Allow username autocompletion in share dialog')); ?></label><br />
198 198 
 	</p>
199 199
200 200 
 	<p id="shareapi_restrict_user_enumeration_to_group_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no' || $_['allowShareDialogUserEnumeration'] === 'no') {
 
@@ -204,7 +204,7 @@  discard block
 
 block discarded – undo
204 204 
 			<?php if ($_['restrictUserEnumerationToGroup'] === 'yes') {
205 205 
 	print_unescaped('checked="checked"');
206 206 
 } ?> />
207 
-		<label for="shareapi_restrict_user_enumeration_to_group"><?php p($l->t('Allow username autocompletion to users within the same groups'));?></label><br />
207 
+		<label for="shareapi_restrict_user_enumeration_to_group"><?php p($l->t('Allow username autocompletion to users within the same groups')); ?></label><br />
208 208 
 	</p>
209 209
210 210 
 	<p id="shareapi_restrict_user_enumeration_to_phone_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no' || $_['allowShareDialogUserEnumeration'] === 'no') {
 
@@ -214,12 +214,12 @@  discard block
 
 block discarded – undo
214 214 
 			<?php if ($_['restrictUserEnumerationToPhone'] === 'yes') {
215 215 
 	print_unescaped('checked="checked"');
216 216 
 } ?> />
217 
-		<label for="shareapi_restrict_user_enumeration_to_phone"><?php p($l->t('Allow username autocompletion to users based on phone number integration'));?></label><br />
217 
+		<label for="shareapi_restrict_user_enumeration_to_phone"><?php p($l->t('Allow username autocompletion to users based on phone number integration')); ?></label><br />
218 218 
 	</p>
219 219 
 	<p id="shareapi_restrict_user_enumeration_combinewarning_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no' || $_['allowShareDialogUserEnumeration'] === 'no') {
220 220 
 	p('hidden');
221 221 
 }?>">
222 
-		<em><?php p($l->t('If autocompletion "same group" and "phone number integration" are enabled a match in either is enough to show the user.'));?></em><br />
222 
+		<em><?php p($l->t('If autocompletion "same group" and "phone number integration" are enabled a match in either is enough to show the user.')); ?></em><br />
223 223 
 	</p>
224 224 
 	<p id="shareapi_restrict_user_enumeration_full_match_setting" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
225 225 
 	p('hidden');
 
@@ -228,7 +228,7 @@  discard block
 
 block discarded – undo
228 228 
 				<?php if ($_['restrictUserEnumerationFullMatch'] === 'yes') {
229 229 
 	print_unescaped('checked="checked"');
230 230 
 } ?> />
231 
-		<label for="shareapi_restrict_user_enumeration_full_match"><?php p($l->t('Allow username autocompletion when entering the full name or email address (ignoring missing phonebook match and being in the same group)'));?></label><br />
231 
+		<label for="shareapi_restrict_user_enumeration_full_match"><?php p($l->t('Allow username autocompletion when entering the full name or email address (ignoring missing phonebook match and being in the same group)')); ?></label><br />
232 232 
 	</p>
233 233
234 234 
 	<p>
 
@@ -236,7 +236,7 @@  discard block
 
 block discarded – undo
236 236 
 			<?php if ($_['publicShareDisclaimerText'] !== null) {
237 237 
 	print_unescaped('checked="checked"');
238 238 
 } ?> />
239 
-		<label for="publicShareDisclaimer"><?php p($l->t('Show disclaimer text on the public link upload page (only shown when the file list is hidden)'));?></label>
239 
+		<label for="publicShareDisclaimer"><?php p($l->t('Show disclaimer text on the public link upload page (only shown when the file list is hidden)')); ?></label>
240 240 
 		<span id="publicShareDisclaimerStatus" class="msg" style="display:none"></span>
241 241 
 		<br/>
242 242 
 		<textarea placeholder="<?php p($l->t('This text will be shown on the public link upload page when the file list is hidden.')) ?>" id="publicShareDisclaimerText" <?php if ($_['publicShareDisclaimerText'] === null) {
 
@@ -244,7 +244,7 @@  discard block
 
 block discarded – undo
244 244 
 } ?>><?php p($_['publicShareDisclaimerText']) ?></textarea>
245 245 
 	</p>
246 246
247 
-	<h3><?php p($l->t('Default share permissions'));?></h3>
247 
+	<h3><?php p($l->t('Default share permissions')); ?></h3>
248 248 
 	<input type="hidden" name="shareapi_default_permissions" id="shareApiDefaultPermissions" class="checkbox"
249 249 
 		   value="<?php p($_['shareApiDefaultPermissions']) ?>" />
250 250 
 	<p id="shareApiDefaultPermissionsSection" class="indent <?php if ($_['shareAPIEnabled'] === 'no') {
 
@@ -255,7 +255,7 @@  discard block
 
 block discarded – undo
255 255 
 				   class="noautosave checkbox" value="<?php p($perm['value']) ?>" <?php if (($_['shareApiDefaultPermissions'] & $perm['value']) !== 0) {
256 256 
 	print_unescaped('checked="checked"');
257 257 
 } ?> />
258 
-			<label for="shareapi_default_permission_<?php p($perm['id']) ?>"><?php p($perm['label']);?></label>
258 
+			<label for="shareapi_default_permission_<?php p($perm['id']) ?>"><?php p($perm['label']); ?></label>
259 259 
 		<?php endforeach ?>
260 260 
 	</p>
261 261 
 </div>
Please login to merge, or discard this patch.