Completed
Pull Request — master (#4303)
by Björn
35:10 queued 22:04
created
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -237,10 +237,10 @@  discard block
 block discarded – undo
237 237
 	 * publish activity if a file/folder was shared by mail
238 238
 	 *
239 239
 	 * @param $subject
240
-	 * @param $parameters
241
-	 * @param $affectedUser
240
+	 * @param string[] $parameters
241
+	 * @param string $affectedUser
242 242
 	 * @param $fileId
243
-	 * @param $filePath
243
+	 * @param string $filePath
244 244
 	 */
245 245
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
246 246
 		$event = $this->activityManager->generateEvent();
@@ -293,6 +293,12 @@  discard block
 block discarded – undo
293 293
 
294 294
 	}
295 295
 
296
+	/**
297
+	 * @param string $link
298
+	 * @param string $owner
299
+	 * @param string $initiator
300
+	 * @param string $shareWith
301
+	 */
296 302
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
297 303
 		$ownerUser = $this->userManager->get($owner);
298 304
 		$initiatorUser = $this->userManager->get($initiator);
@@ -471,6 +477,7 @@  discard block
 block discarded – undo
471 477
 	 * @param string $uidOwner
472 478
 	 * @param int $permissions
473 479
 	 * @param string $token
480
+	 * @param string $password
474 481
 	 * @return int
475 482
 	 */
476 483
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -864,7 +871,7 @@  discard block
 block discarded – undo
864 871
 	/**
865 872
 	 * get database row of a give share
866 873
 	 *
867
-	 * @param $id
874
+	 * @param integer $id
868 875
 	 * @return array
869 876
 	 * @throws ShareNotFound
870 877
 	 */
Please login to merge, or discard this patch.