Completed
Push — stable12 ( 58a5e5...857491 )
by Morris
20:18 queued 12s
created
settings/ajax/updateapp.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	return;
35 35
 }
36 36
 
37
-$appId = (string)$_POST['appid'];
37
+$appId = (string) $_POST['appid'];
38 38
 $appId = OC_App::cleanAppId($appId);
39 39
 
40 40
 $config = \OC::$server->getConfig();
@@ -48,15 +48,15 @@  discard block
 block discarded – undo
48 48
 	);
49 49
 	$result = $installer->updateAppstoreApp($appId);
50 50
 	$config->setSystemValue('maintenance', false);
51
-} catch(Exception $ex) {
51
+} catch (Exception $ex) {
52 52
 	$config->setSystemValue('maintenance', false);
53
-	OC_JSON::error(array("data" => array( "message" => $ex->getMessage() )));
53
+	OC_JSON::error(array("data" => array("message" => $ex->getMessage())));
54 54
 	return;
55 55
 }
56 56
 
57
-if($result !== false) {
57
+if ($result !== false) {
58 58
 	OC_JSON::success(array('data' => array('appid' => $appId)));
59 59
 } else {
60 60
 	$l = \OC::$server->getL10N('settings');
61
-	OC_JSON::error(array("data" => array( "message" => $l->t("Couldn't update app.") )));
61
+	OC_JSON::error(array("data" => array("message" => $l->t("Couldn't update app."))));
62 62
 }
Please login to merge, or discard this patch.
settings/ajax/uninstallapp.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 $lastConfirm = (int) \OC::$server->getSession()->get('last-password-confirm');
28 28
 if ($lastConfirm < (time() - 30 * 60 + 15)) { // allow 15 seconds delay
29 29
 	$l = \OC::$server->getL10N('core');
30
-	OC_JSON::error(array( 'data' => array( 'message' => $l->t('Password confirmation is required'))));
30
+	OC_JSON::error(array('data' => array('message' => $l->t('Password confirmation is required'))));
31 31
 	exit();
32 32
 }
33 33
 
@@ -36,16 +36,16 @@  discard block
 block discarded – undo
36 36
 	exit;
37 37
 }
38 38
 
39
-$appId = (string)$_POST['appid'];
39
+$appId = (string) $_POST['appid'];
40 40
 $appId = OC_App::cleanAppId($appId);
41 41
 
42 42
 $result = OC_App::removeApp($appId);
43
-if($result !== false) {
43
+if ($result !== false) {
44 44
 	// FIXME: Clear the cache - move that into some sane helper method
45 45
 	\OC::$server->getMemCacheFactory()->create('settings')->remove('listApps-0');
46 46
 	\OC::$server->getMemCacheFactory()->create('settings')->remove('listApps-1');
47 47
 	OC_JSON::success(array('data' => array('appid' => $appId)));
48 48
 } else {
49 49
 	$l = \OC::$server->getL10N('settings');
50
-	OC_JSON::error(array("data" => array( "message" => $l->t("Couldn't remove app.") )));
50
+	OC_JSON::error(array("data" => array("message" => $l->t("Couldn't remove app."))));
51 51
 }
Please login to merge, or discard this patch.
settings/Controller/EncryptionController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
 		} catch (\Exception $e) {
131 131
 			return [
132 132
 				'data' => [
133
-					'message' => (string)$this->l10n->t('A problem occurred, please check your log files (Error: %s)', [$e->getMessage()]),
133
+					'message' => (string) $this->l10n->t('A problem occurred, please check your log files (Error: %s)', [$e->getMessage()]),
134 134
 				],
135 135
 				'status' => 'error',
136 136
 			];
Please login to merge, or discard this patch.
settings/Controller/GroupsController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -100,15 +100,15 @@  discard block
 block discarded – undo
100 100
 	 * @return DataResponse
101 101
 	 */
102 102
 	public function create($id) {
103
-		if($this->groupManager->groupExists($id)) {
103
+		if ($this->groupManager->groupExists($id)) {
104 104
 			return new DataResponse(
105 105
 				array(
106
-					'message' => (string)$this->l10n->t('Group already exists.')
106
+					'message' => (string) $this->l10n->t('Group already exists.')
107 107
 				),
108 108
 				Http::STATUS_CONFLICT
109 109
 			);
110 110
 		}
111
-		if($this->groupManager->createGroup($id)) {
111
+		if ($this->groupManager->createGroup($id)) {
112 112
 			return new DataResponse(
113 113
 				array(
114 114
 					'groupname' => $id
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 			array(
122 122
 				'status' => 'error',
123 123
 				'data' => array(
124
-					'message' => (string)$this->l10n->t('Unable to add group.')
124
+					'message' => (string) $this->l10n->t('Unable to add group.')
125 125
 				)
126 126
 			),
127 127
 			Http::STATUS_FORBIDDEN
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 			array(
153 153
 				'status' => 'error',
154 154
 				'data' => array(
155
-					'message' => (string)$this->l10n->t('Unable to delete group.')
155
+					'message' => (string) $this->l10n->t('Unable to delete group.')
156 156
 				),
157 157
 			),
158 158
 			Http::STATUS_FORBIDDEN
Please login to merge, or discard this patch.
settings/Controller/MailSettingsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
 
98 98
 		$params = get_defined_vars();
99 99
 		$configs = [];
100
-		foreach($params as $key => $value) {
100
+		foreach ($params as $key => $value) {
101 101
 			$configs[$key] = (empty($value)) ? null : $value;
102 102
 		}
103 103
 
Please login to merge, or discard this patch.
settings/Middleware/SubadminMiddleware.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
 	 * @throws \Exception
60 60
 	 */
61 61
 	public function beforeController($controller, $methodName) {
62
-		if(!$this->reflector->hasAnnotation('NoSubadminRequired')) {
63
-			if(!$this->isSubAdmin) {
62
+		if (!$this->reflector->hasAnnotation('NoSubadminRequired')) {
63
+			if (!$this->isSubAdmin) {
64 64
 				throw new NotAdminException('Logged in user must be a subadmin');
65 65
 			}
66 66
 		}
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 * @throws \Exception
76 76
 	 */
77 77
 	public function afterException($controller, $methodName, \Exception $exception) {
78
-		if($exception instanceof NotAdminException) {
78
+		if ($exception instanceof NotAdminException) {
79 79
 			$response = new TemplateResponse('core', '403', array(), 'guest');
80 80
 			$response->setStatus(Http::STATUS_FORBIDDEN);
81 81
 			return $response;
Please login to merge, or discard this patch.
settings/help.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -31,28 +31,28 @@
 block discarded – undo
31 31
 OC_Util::checkLoggedIn();
32 32
 
33 33
 // Load the files we need
34
-OC_Util::addStyle( "settings", "settings" );
34
+OC_Util::addStyle("settings", "settings");
35 35
 \OC::$server->getNavigationManager()->setActiveEntry('help');
36 36
 
37 37
 
38
-if(isset($_GET['mode']) and $_GET['mode'] === 'admin') {
39
-	$url=\OCP\Util::linkToAbsolute( 'core', 'doc/admin/index.html' );
40
-	$style1='';
41
-	$style2=' active';
42
-}else{
43
-	$url=\OCP\Util::linkToAbsolute( 'core', 'doc/user/index.html' );
44
-	$style1=' active';
45
-	$style2='';
38
+if (isset($_GET['mode']) and $_GET['mode'] === 'admin') {
39
+	$url = \OCP\Util::linkToAbsolute('core', 'doc/admin/index.html');
40
+	$style1 = '';
41
+	$style2 = ' active';
42
+} else {
43
+	$url = \OCP\Util::linkToAbsolute('core', 'doc/user/index.html');
44
+	$style1 = ' active';
45
+	$style2 = '';
46 46
 }
47 47
 
48
-$url1=\OC::$server->getURLGenerator()->linkToRoute('settings_help').'?mode=user';
49
-$url2=\OC::$server->getURLGenerator()->linkToRoute('settings_help').'?mode=admin';
48
+$url1 = \OC::$server->getURLGenerator()->linkToRoute('settings_help').'?mode=user';
49
+$url2 = \OC::$server->getURLGenerator()->linkToRoute('settings_help').'?mode=admin';
50 50
 
51
-$tmpl = new OC_Template( "settings", "help", "user" );
52
-$tmpl->assign( "admin", OC_User::isAdminUser(OC_User::getUser()));
53
-$tmpl->assign( "url", $url );
54
-$tmpl->assign( "url1", $url1 );
55
-$tmpl->assign( "url2", $url2 );
56
-$tmpl->assign( "style1", $style1 );
57
-$tmpl->assign( "style2", $style2 );
51
+$tmpl = new OC_Template("settings", "help", "user");
52
+$tmpl->assign("admin", OC_User::isAdminUser(OC_User::getUser()));
53
+$tmpl->assign("url", $url);
54
+$tmpl->assign("url1", $url1);
55
+$tmpl->assign("url2", $url2);
56
+$tmpl->assign("style1", $style1);
57
+$tmpl->assign("style2", $style2);
58 58
 $tmpl->printPage();
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/DoesNotExistException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	 * @param string $msg the error message
38 38
 	 * @since 7.0.0
39 39
 	 */
40
-	public function __construct($msg){
40
+	public function __construct($msg) {
41 41
 		parent::__construct($msg);
42 42
 	}
43 43
 
Please login to merge, or discard this patch.
lib/public/SystemTag/SystemTagsEntityEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 */
62 62
 	public function addEntityCollection($name, \Closure $entityExistsFunction) {
63 63
 		if (isset($this->collections[$name])) {
64
-			throw new \OutOfBoundsException('Duplicate entity name "' . $name . '"');
64
+			throw new \OutOfBoundsException('Duplicate entity name "'.$name.'"');
65 65
 		}
66 66
 
67 67
 		$this->collections[$name] = $entityExistsFunction;
Please login to merge, or discard this patch.