Completed
Push — stable12 ( 58a5e5...857491 )
by Morris
20:18 queued 12s
created
lib/private/Preview/Bitmap.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 		try {
49 49
 			$bp = $this->getResizedPreview($tmpPath, $maxX, $maxY);
50 50
 		} catch (\Exception $e) {
51
-			\OCP\Util::writeLog('core', 'ImageMagick says: ' . $e->getmessage(), \OCP\Util::ERROR);
51
+			\OCP\Util::writeLog('core', 'ImageMagick says: '.$e->getmessage(), \OCP\Util::ERROR);
52 52
 			return false;
53 53
 		}
54 54
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 		$bp = new Imagick();
80 80
 
81 81
 		// Layer 0 contains either the bitmap or a flat representation of all vector layers
82
-		$bp->readImage($tmpPath . '[0]');
82
+		$bp->readImage($tmpPath.'[0]');
83 83
 
84 84
 		$bp = $this->resize($bp, $maxX, $maxY);
85 85
 
Please login to merge, or discard this patch.
lib/private/Preview/Office.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -41,20 +41,20 @@
 block discarded – undo
41 41
 
42 42
 		$tmpDir = \OC::$server->getTempManager()->getTempBaseDir();
43 43
 
44
-		$defaultParameters = ' -env:UserInstallation=file://' . escapeshellarg($tmpDir . '/owncloud-' . \OC_Util::getInstanceId() . '/') . ' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to pdf --outdir ';
44
+		$defaultParameters = ' -env:UserInstallation=file://'.escapeshellarg($tmpDir.'/owncloud-'.\OC_Util::getInstanceId().'/').' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to pdf --outdir ';
45 45
 		$clParameters = \OCP\Config::getSystemValue('preview_office_cl_parameters', $defaultParameters);
46 46
 
47
-		$exec = $this->cmd . $clParameters . escapeshellarg($tmpDir) . ' ' . escapeshellarg($absPath);
47
+		$exec = $this->cmd.$clParameters.escapeshellarg($tmpDir).' '.escapeshellarg($absPath);
48 48
 
49 49
 		shell_exec($exec);
50 50
 
51 51
 		//create imagick object from pdf
52 52
 		$pdfPreview = null;
53 53
 		try {
54
-			list($dirname, , , $filename) = array_values(pathinfo($absPath));
55
-			$pdfPreview = $dirname . '/' . $filename . '.pdf';
54
+			list($dirname,,, $filename) = array_values(pathinfo($absPath));
55
+			$pdfPreview = $dirname.'/'.$filename.'.pdf';
56 56
 
57
-			$pdf = new \imagick($pdfPreview . '[0]');
57
+			$pdf = new \imagick($pdfPreview.'[0]');
58 58
 			$pdf->setImageFormat('jpg');
59 59
 		} catch (\Exception $e) {
60 60
 			unlink($absPath);
Please login to merge, or discard this patch.
lib/private/Preview/Movie.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -84,15 +84,15 @@
 block discarded – undo
84 84
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
85 85
 
86 86
 		if (self::$avconvBinary) {
87
-			$cmd = self::$avconvBinary . ' -y -ss ' . escapeshellarg($second) .
88
-				' -i ' . escapeshellarg($absPath) .
89
-				' -an -f mjpeg -vframes 1 -vsync 1 ' . escapeshellarg($tmpPath) .
87
+			$cmd = self::$avconvBinary.' -y -ss '.escapeshellarg($second).
88
+				' -i '.escapeshellarg($absPath).
89
+				' -an -f mjpeg -vframes 1 -vsync 1 '.escapeshellarg($tmpPath).
90 90
 				' > /dev/null 2>&1';
91 91
 		} else {
92
-			$cmd = self::$ffmpegBinary . ' -y -ss ' . escapeshellarg($second) .
93
-				' -i ' . escapeshellarg($absPath) .
94
-				' -f mjpeg -vframes 1' .
95
-				' ' . escapeshellarg($tmpPath) .
92
+			$cmd = self::$ffmpegBinary.' -y -ss '.escapeshellarg($second).
93
+				' -i '.escapeshellarg($absPath).
94
+				' -f mjpeg -vframes 1'.
95
+				' '.escapeshellarg($tmpPath).
96 96
 				' > /dev/null 2>&1';
97 97
 		}
98 98
 
Please login to merge, or discard this patch.
lib/private/Preview/SVG.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 
43 43
 			$content = stream_get_contents($fileview->fopen($path, 'r'));
44 44
 			if (substr($content, 0, 5) !== '<?xml') {
45
-				$content = '<?xml version="1.0" encoding="UTF-8" standalone="no"?>' . $content;
45
+				$content = '<?xml version="1.0" encoding="UTF-8" standalone="no"?>'.$content;
46 46
 			}
47 47
 
48 48
 			// Do not parse SVG files with references
Please login to merge, or discard this patch.
lib/private/Share20/Share.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -86,10 +86,10 @@  discard block
 block discarded – undo
86 86
 	 */
87 87
 	public function setId($id) {
88 88
 		if (is_int($id)) {
89
-			$id = (string)$id;
89
+			$id = (string) $id;
90 90
 		}
91 91
 
92
-		if(!is_string($id)) {
92
+		if (!is_string($id)) {
93 93
 			throw new \InvalidArgumentException('String expected.');
94 94
 		}
95 95
 
@@ -115,14 +115,14 @@  discard block
 block discarded – undo
115 115
 		if ($this->providerId === null || $this->id === null) {
116 116
 			throw new \UnexpectedValueException;
117 117
 		}
118
-		return $this->providerId . ':' . $this->id;
118
+		return $this->providerId.':'.$this->id;
119 119
 	}
120 120
 
121 121
 	/**
122 122
 	 * @inheritdoc
123 123
 	 */
124 124
 	public function setProviderId($id) {
125
-		if(!is_string($id)) {
125
+		if (!is_string($id)) {
126 126
 			throw new \InvalidArgumentException('String expected.');
127 127
 		}
128 128
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 
157 157
 			// for federated shares the owner can be a remote user, in this
158 158
 			// case we use the initiator
159
-			if($this->userManager->userExists($this->shareOwner)) {
159
+			if ($this->userManager->userExists($this->shareOwner)) {
160 160
 				$userFolder = $this->rootFolder->getUserFolder($this->shareOwner);
161 161
 			} else {
162 162
 				$userFolder = $this->rootFolder->getUserFolder($this->sharedBy);
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 
165 165
 			$nodes = $userFolder->getById($this->fileId);
166 166
 			if (empty($nodes)) {
167
-				throw new NotFoundException('Node for share not found, fileid: ' . $this->fileId);
167
+				throw new NotFoundException('Node for share not found, fileid: '.$this->fileId);
168 168
 			}
169 169
 
170 170
 			$this->node = $nodes[0];
Please login to merge, or discard this patch.
lib/private/Setup/PostgreSQL.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 				//use the admin login data for the new database user
61 61
 
62 62
 				//add prefix to the postgresql user name to prevent collisions
63
-				$this->dbUser = 'oc_' . strtolower($username);
63
+				$this->dbUser = 'oc_'.strtolower($username);
64 64
 				//create a new password so we don't need to store the admin config in the config file
65
-				$this->dbPassword = \OC::$server->getSecureRandom()->generate(30, \OCP\Security\ISecureRandom::CHAR_LOWER . \OCP\Security\ISecureRandom::CHAR_DIGITS);
65
+				$this->dbPassword = \OC::$server->getSecureRandom()->generate(30, \OCP\Security\ISecureRandom::CHAR_LOWER.\OCP\Security\ISecureRandom::CHAR_DIGITS);
66 66
 
67 67
 				$this->createDBUser($connection);
68 68
 			}
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 			//create the database
76 76
 			$this->createDatabase($connection);
77 77
 			$query = $connection->prepare("select count(*) FROM pg_class WHERE relname=? limit 1");
78
-			$query->execute([$this->tablePrefix . "users"]);
78
+			$query->execute([$this->tablePrefix."users"]);
79 79
 			$tablesSetup = $query->fetchColumn() > 0;
80 80
 
81 81
 			// the connection to dbname=postgres is not needed anymore
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	private function createDatabase(IDBConnection $connection) {
112 112
 		if (!$this->databaseExists($connection)) {
113 113
 			//The database does not exists... let's create it
114
-			$query = $connection->prepare("CREATE DATABASE " . addslashes($this->dbName) . " OWNER " . addslashes($this->dbUser));
114
+			$query = $connection->prepare("CREATE DATABASE ".addslashes($this->dbName)." OWNER ".addslashes($this->dbUser));
115 115
 			try {
116 116
 				$query->execute();
117 117
 			} catch (DatabaseException $e) {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 				$this->logger->logException($e);
120 120
 			}
121 121
 		} else {
122
-			$query = $connection->prepare("REVOKE ALL PRIVILEGES ON DATABASE " . addslashes($this->dbName) . " FROM PUBLIC");
122
+			$query = $connection->prepare("REVOKE ALL PRIVILEGES ON DATABASE ".addslashes($this->dbName)." FROM PUBLIC");
123 123
 			try {
124 124
 				$query->execute();
125 125
 			} catch (DatabaseException $e) {
@@ -155,11 +155,11 @@  discard block
 block discarded – undo
155 155
 			$i = 1;
156 156
 			while ($this->userExists($connection)) {
157 157
 				$i++;
158
-				$this->dbUser = $dbUser . $i;
158
+				$this->dbUser = $dbUser.$i;
159 159
 			};
160 160
 
161 161
 			// create the user
162
-			$query = $connection->prepare("CREATE USER " . addslashes($this->dbUser) . " CREATEDB PASSWORD '" . addslashes($this->dbPassword) . "'");
162
+			$query = $connection->prepare("CREATE USER ".addslashes($this->dbUser)." CREATEDB PASSWORD '".addslashes($this->dbPassword)."'");
163 163
 			$query->execute();
164 164
 		} catch (DatabaseException $e) {
165 165
 			$this->logger->error('Error while trying to create database user');
Please login to merge, or discard this patch.
lib/private/Setup/AbstractDatabase.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -68,14 +68,14 @@
 block discarded – undo
68 68
 
69 69
 	public function validate($config) {
70 70
 		$errors = array();
71
-		if(empty($config['dbuser']) && empty($config['dbname'])) {
71
+		if (empty($config['dbuser']) && empty($config['dbname'])) {
72 72
 			$errors[] = $this->trans->t("%s enter the database username and name.", array($this->dbprettyname));
73
-		} else if(empty($config['dbuser'])) {
73
+		} else if (empty($config['dbuser'])) {
74 74
 			$errors[] = $this->trans->t("%s enter the database username.", array($this->dbprettyname));
75
-		} else if(empty($config['dbname'])) {
75
+		} else if (empty($config['dbname'])) {
76 76
 			$errors[] = $this->trans->t("%s enter the database name.", array($this->dbprettyname));
77 77
 		}
78
-		if(substr_count($config['dbname'], '.') >= 1) {
78
+		if (substr_count($config['dbname'], '.') >= 1) {
79 79
 			$errors[] = $this->trans->t("%s you may not use dots in the database name", array($this->dbprettyname));
80 80
 		}
81 81
 		return $errors;
Please login to merge, or discard this patch.
lib/private/Setup/MySQL.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 		$this->createDatabase($connection);
44 44
 
45 45
 		//fill the database if needed
46
-		$query='select count(*) from information_schema.tables where table_schema=? AND table_name = ?';
46
+		$query = 'select count(*) from information_schema.tables where table_schema=? AND table_name = ?';
47 47
 		$result = $connection->executeQuery($query, [$this->dbName, $this->tablePrefix.'users']);
48 48
 		$row = $result->fetch();
49 49
 		if (!$row or $row['count(*)'] === '0') {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * @param \OC\DB\Connection $connection
56 56
 	 */
57 57
 	private function createDatabase($connection) {
58
-		try{
58
+		try {
59 59
 			$name = $this->dbName;
60 60
 			$user = $this->dbUser;
61 61
 			//we can't use OC_DB functions here because we need to connect as the administrative user.
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
 		try {
74 74
 			//this query will fail if there aren't the right permissions, ignore the error
75
-			$query="GRANT ALL PRIVILEGES ON `$name` . * TO '$user'";
75
+			$query = "GRANT ALL PRIVILEGES ON `$name` . * TO '$user'";
76 76
 			$connection->executeUpdate($query);
77 77
 		} catch (\Exception $ex) {
78 78
 			$this->logger->debug('Could not automatically grant privileges, this can be ignored if database user already had privileges: {error}', [
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 * @throws \OC\DatabaseSetupException
88 88
 	 */
89 89
 	private function createDBUser($connection) {
90
-		try{
90
+		try {
91 91
 			$name = $this->dbUser;
92 92
 			$password = $this->dbPassword;
93 93
 			// we need to create 2 accounts, one for global use and one for local user. if we don't specify the local one,
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 			$query = "CREATE USER '$name'@'%' IDENTIFIED BY '$password'";
98 98
 			$connection->executeUpdate($query);
99 99
 		}
100
-		catch (\Exception $ex){
100
+		catch (\Exception $ex) {
101 101
 			$this->logger->error('Database User creation failed: {error}', [
102 102
                                 'app' => 'mysql.setup',
103 103
                                 'error' => $ex->getMessage()
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 			//we don't have a dbuser specified in config
119 119
 			if ($this->dbUser !== $oldUser) {
120 120
 				//add prefix to the admin username to prevent collisions
121
-				$adminUser = substr('oc_' . $username, 0, 16);
121
+				$adminUser = substr('oc_'.$username, 0, 16);
122 122
 
123 123
 				$i = 1;
124 124
 				while (true) {
@@ -135,15 +135,15 @@  discard block
 block discarded – undo
135 135
 							$this->dbUser = $adminUser;
136 136
 
137 137
 							//create a random password so we don't need to store the admin password in the config file
138
-							$this->dbPassword =  $this->random->generate(30);
138
+							$this->dbPassword = $this->random->generate(30);
139 139
 
140 140
 							$this->createDBUser($connection);
141 141
 
142 142
 							break;
143 143
 						} else {
144 144
 							//repeat with different username
145
-							$length = strlen((string)$i);
146
-							$adminUser = substr('oc_' . $username, 0, 16 - $length) . $i;
145
+							$length = strlen((string) $i);
146
+							$adminUser = substr('oc_'.$username, 0, 16 - $length).$i;
147 147
 							$i++;
148 148
 						}
149 149
 					} else {
Please login to merge, or discard this patch.
lib/private/PreviewManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
 		}
245 245
 
246 246
 		$mount = $file->getMountPoint();
247
-		if ($mount and !$mount->getOption('previews', true)){
247
+		if ($mount and !$mount->getOption('previews', true)) {
248 248
 			return false;
249 249
 		}
250 250
 
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
 	 */
331 331
 	protected function registerCoreProvider($class, $mimeType, $options = []) {
332 332
 		if (in_array(trim($class, '\\'), $this->getEnabledDefaultProvider())) {
333
-			$this->registerProvider($mimeType, function () use ($class, $options) {
333
+			$this->registerProvider($mimeType, function() use ($class, $options) {
334 334
 				return new $class($options);
335 335
 			});
336 336
 		}
Please login to merge, or discard this patch.