Completed
Push — stable12 ( 58a5e5...857491 )
by Morris
20:18 queued 12s
created
lib/private/Repair/NC13/RepairInvalidPaths.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -79,6 +79,9 @@  discard block
 block discarded – undo
79 79
 		} while (count($rows) > 0);
80 80
 	}
81 81
 
82
+	/**
83
+	 * @param string $path
84
+	 */
82 85
 	private function getId($storage, $path) {
83 86
 		if (!$this->getIdQuery) {
84 87
 			$builder = $this->connection->getQueryBuilder();
@@ -95,6 +98,9 @@  discard block
 block discarded – undo
95 98
 		return $this->getIdQuery->execute()->fetchColumn();
96 99
 	}
97 100
 
101
+	/**
102
+	 * @param string $newPath
103
+	 */
98 104
 	private function update($fileid, $newPath, $newStorage) {
99 105
 		if (!$this->updateQuery) {
100 106
 			$builder = $this->connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Contacts/ContactsMenu/ContactsStore.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 	/**
64 64
 	 * @param IUser $user
65 65
 	 * @param string|null $filter
66
-	 * @return IEntry[]
66
+	 * @return Entry[]
67 67
 	 */
68 68
 	public function getContacts(IUser $user, $filter) {
69 69
 		$allContacts = $this->contactsManager->search($filter ?: '', [
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesAPIController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 	 * split user and remote from federated cloud id
392 392
 	 *
393 393
 	 * @param string $address federated share address
394
-	 * @return array [user, remoteURL]
394
+	 * @return string[] [user, remoteURL]
395 395
 	 * @throws \InvalidArgumentException
396 396
 	 */
397 397
 	public function splitUserRemote($address) {
@@ -697,6 +697,9 @@  discard block
 block discarded – undo
697 697
 		return $result;
698 698
 	}
699 699
 
700
+	/**
701
+	 * @param string $search
702
+	 */
700 703
 	protected function getLookup($search) {
701 704
 		$isEnabled = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no');
702 705
 		$lookupServerUrl = $this->config->getSystemValue('lookup_server', 'https://lookup.nextcloud.com');
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -450,6 +450,10 @@
 block discarded – undo
450 450
 		return $url;
451 451
 	}
452 452
 
453
+	/**
454
+	 * @param string $feature
455
+	 * @param string $oldValue
456
+	 */
453 457
 	public function triggerChange($feature, $value = null, $oldValue = null) {
454 458
 		if ($this->emitter) {
455 459
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value, $oldValue));
Please login to merge, or discard this patch.
apps/files_sharing/lib/Cache.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -135,6 +135,10 @@
 block discarded – undo
135 135
 		return parent::moveFromCache($sourceCache, $sourcePath, $targetPath);
136 136
 	}
137 137
 
138
+	/**
139
+	 * @param ICacheEntry $entry
140
+	 * @param string $path
141
+	 */
138 142
 	protected function formatCacheEntry($entry, $path = null) {
139 143
 		if (is_null($path)) {
140 144
 			$path = isset($entry['path']) ? $entry['path'] : '';
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/S3Signature.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -119,6 +119,9 @@
 block discarded – undo
119 119
 		return Psr7\modify_request($request, $modify);
120 120
 	}
121 121
 
122
+	/**
123
+	 * @param string $string
124
+	 */
122 125
 	private function signString($string, CredentialsInterface $credentials)
123 126
 	{
124 127
 		return base64_encode(
Please login to merge, or discard this patch.
lib/private/Authentication/Token/DefaultTokenProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	 * where a high number of (session) tokens is generated
144 144
 	 *
145 145
 	 * @param IUser $user
146
-	 * @return IToken[]
146
+	 * @return DefaultToken[]
147 147
 	 */
148 148
 	public function getTokenByUser(IUser $user) {
149 149
 		return $this->mapper->getTokenByUser($user);
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -5 removed lines patch added patch discarded remove patch
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 
496 496
 	/**
497 497
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
498
-	 * @param string $dn the dn of the user object
498
+	 * @param string $fdn the dn of the user object
499 499
 	 * @param string $ldapName optional, the display name of the object
500 500
 	 * @return string|false with with the name to use in Nextcloud
501 501
 	 */
@@ -512,7 +512,7 @@  discard block
 block discarded – undo
512 512
 
513 513
 	/**
514 514
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
515
-	 * @param string $dn the dn of the user object
515
+	 * @param string $fdn the dn of the user object
516 516
 	 * @param string $ldapName optional, the display name of the object
517 517
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
518 518
 	 * @return string|false with with the name to use in Nextcloud
@@ -787,7 +787,7 @@  discard block
 block discarded – undo
787 787
 	 * the login filter.
788 788
 	 *
789 789
 	 * @param string $loginName
790
-	 * @param array $attributes optional, list of attributes to read
790
+	 * @param string[] $attributes optional, list of attributes to read
791 791
 	 * @return array
792 792
 	 */
793 793
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -860,7 +860,7 @@  discard block
 block discarded – undo
860 860
 
861 861
 	/**
862 862
 	 * @param string $filter
863
-	 * @param string|string[] $attr
863
+	 * @param string[] $attr
864 864
 	 * @param int $limit
865 865
 	 * @param int $offset
866 866
 	 * @return array
@@ -908,7 +908,7 @@  discard block
 block discarded – undo
908 908
 
909 909
 	/**
910 910
 	 * @param string $filter
911
-	 * @param string|string[] $attr
911
+	 * @param string[] $attr
912 912
 	 * @param int $limit
913 913
 	 * @param int $offset
914 914
 	 * @return false|int
@@ -1008,6 +1008,7 @@  discard block
 block discarded – undo
1008 1008
 	 * retrieved. Results will according to the order in the array.
1009 1009
 	 * @param int $limit optional, maximum results to be counted
1010 1010
 	 * @param int $offset optional, a starting point
1011
+	 * @param string $filter
1011 1012
 	 * @return array|false array with the search result as first value and pagedSearchOK as
1012 1013
 	 * second | false if not successful
1013 1014
 	 * @throws \OC\ServerNotAvailableException
@@ -1299,6 +1300,7 @@  discard block
 block discarded – undo
1299 1300
 	* escapes (user provided) parts for LDAP filter
1300 1301
 	* @param string $input, the provided value
1301 1302
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1303
+	* @param string $input
1302 1304
 	* @return string the escaped string
1303 1305
 	*/
1304 1306
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.