nextcloud / server

apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return CalendarSearchReport
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$elems = $reader->parseInnerTree([

lib/private/Share20/Manager.php

Doc Comments +3 added lines

@@ -1100,6 +1100,9 @@
 		return $share;
 	}
 
+	/**
+	 * @param \OCP\Share\IShare $share
+	 */
 	protected function checkExpireDate($share) {
 		if ($share->getExpirationDate() !== null &&
 			$share->getExpirationDate() <= new \DateTime()) {

apps/dav/lib/CardDAV/SyncService.php

Doc Comments +1 added lines, -2 removed lines

@@ -163,7 +163,6 @@ 
 	/**
 	 * @param string $url
 	 * @param string $userName
-	 * @param string $addressBookUrl
 	 * @param string $sharedSecret
 	 * @return Client
 	 */
@@ -301,7 +300,7 @@ 
 	}
 
 	/**
-	 * @return array|null
+	 * @return string
 	 */
 	public function getLocalSystemAddressBook() {
 		if (is_null($this->localSystemAddressBook)) {

lib/private/Mail/EMailTemplate.php

Doc Comments +1 added lines, -1 removed lines

@@ -335,7 +335,7 @@
 	 * Adds a heading to the email
 	 *
 	 * @param string $title
-	 * @param string $plainTitle|bool Title that is used in the plain text email
+	 * @param string $plainTitle Title that is used in the plain text email
 	 *   if empty the $title is used, if false none will be used
 	 */
 	public function addHeading($title, $plainTitle = '') {

lib/private/AppFramework/Utility/ControllerMethodReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 	private $parameters = [];
 
 	/**
-	 * @param object $object an object or classname
+	 * @param \OCP\AppFramework\Controller $object an object or classname
 	 * @param string $method the method which we want to inspect
 	 */
 	public function reflect($object, $method){

lib/private/User/Session.php

Doc Comments +5 added lines, -2 removed lines

@@ -329,7 +329,7 @@ 
 	 * @param IUser $user
 	 * @param array $loginDetails
 	 * @param bool $regenerateSessionId
-	 * @return true returns true if login successful or an exception otherwise
+	 * @return boolean returns true if login successful or an exception otherwise
 	 * @throws LoginException
 	 */
 	public function completeLogin(IUser $user, array $loginDetails, $regenerateSessionId = true) {
@@ -377,7 +377,7 @@ 
 	 * @param OC\Security\Bruteforce\Throttler $throttler
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user,
 								$password,
@@ -431,6 +431,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
 	 * @param bool $isLoggedIn
 	 * @param bool $isAdminUser
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
-	 * @param CSRFTokenManager $csrfTokenManager
+	 * @param CsrfTokenManager $csrfTokenManager
 	 * @param ContentSecurityPolicyNonceManager $cspNonceManager
 	 */
 	public function __construct(IRequest $request,

apps/sharebymail/lib/ShareByMailProvider.php

Doc Comments +5 added lines, -4 removed lines

@@ -276,10 +276,10 @@ 
 	 * publish activity if a file/folder was shared by mail
 	 *
 	 * @param $subject
-	 * @param $parameters
-	 * @param $affectedUser
+	 * @param string[] $parameters
+	 * @param string $affectedUser
 	 * @param $fileId
-	 * @param $filePath
+	 * @param string $filePath
 	 */
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
 		$event = $this->activityManager->generateEvent();
@@ -557,6 +557,7 @@ 
 	 * @param string $uidOwner
 	 * @param int $permissions
 	 * @param string $token
+	 * @param string $password
 	 * @return int
 	 */
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -950,7 +951,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +11 added lines, -3 removed lines

@@ -104,7 +104,7 @@ 
 	/**
 	 * Return the number of address books for a principal
 	 *
-	 * @param $principalUri
+	 * @param string $principalUri
 	 * @return int
 	 */
 	public function getAddressBooksForUserCount($principalUri) {
@@ -212,6 +212,9 @@ 
 		return array_values($addressBooks);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnAddressBooks($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$query = $this->db->getQueryBuilder();
@@ -280,7 +283,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -969,6 +973,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -1068,7 +1073,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -1076,6 +1081,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);