@@ -1037,7 +1037,7 @@ discard block |
||
| 1037 | 1037 | * @param string $principalUri |
| 1038 | 1038 | * @param string $uri |
| 1039 | 1039 | * @param array $properties |
| 1040 | - * @return mixed |
|
| 1040 | + * @return integer |
|
| 1041 | 1041 | */ |
| 1042 | 1042 | function createSubscription($principalUri, $uri, array $properties) { |
| 1043 | 1043 | |
@@ -1378,6 +1378,9 @@ discard block |
||
| 1378 | 1378 | return $this->sharingBackend->applyShareAcl($resourceId, $acl); |
| 1379 | 1379 | } |
| 1380 | 1380 | |
| 1381 | + /** |
|
| 1382 | + * @param boolean $toV2 |
|
| 1383 | + */ |
|
| 1381 | 1384 | private function convertPrincipal($principalUri, $toV2) { |
| 1382 | 1385 | if ($this->principalBackend->getPrincipalPrefix() === 'principals') { |
| 1383 | 1386 | list(, $name) = URLUtil::splitPath($principalUri); |
@@ -808,7 +808,9 @@ |
||
| 808 | 808 | $stmt = $query->execute(); |
| 809 | 809 | $row = $stmt->fetch(\PDO::FETCH_ASSOC); |
| 810 | 810 | |
| 811 | - if(!$row) return null; |
|
| 811 | + if(!$row) { |
|
| 812 | + return null; |
|
| 813 | + } |
|
| 812 | 814 | |
| 813 | 815 | return [ |
| 814 | 816 | 'id' => $row['id'], |
@@ -188,7 +188,8 @@ discard block |
||
| 188 | 188 | } |
| 189 | 189 | |
| 190 | 190 | /** |
| 191 | - * @param $addressBookUri |
|
| 191 | + * @param string $addressBookUri |
|
| 192 | + * @param string $principal |
|
| 192 | 193 | * @return array|null |
| 193 | 194 | */ |
| 194 | 195 | public function getAddressBooksByUri($principal, $addressBookUri) { |
@@ -868,6 +869,7 @@ discard block |
||
| 868 | 869 | * * readOnly - boolean |
| 869 | 870 | * * summary - Optional, a description for the share |
| 870 | 871 | * |
| 872 | + * @param integer $addressBookId |
|
| 871 | 873 | * @return array |
| 872 | 874 | */ |
| 873 | 875 | public function getShares($addressBookId) { |
@@ -967,7 +969,7 @@ discard block |
||
| 967 | 969 | |
| 968 | 970 | /** |
| 969 | 971 | * For shared address books the sharee is set in the ACL of the address book |
| 970 | - * @param $addressBookId |
|
| 972 | + * @param integer $addressBookId |
|
| 971 | 973 | * @param $acl |
| 972 | 974 | * @return array |
| 973 | 975 | */ |
@@ -975,6 +977,9 @@ discard block |
||
| 975 | 977 | return $this->sharingBackend->applyShareAcl($addressBookId, $acl); |
| 976 | 978 | } |
| 977 | 979 | |
| 980 | + /** |
|
| 981 | + * @param boolean $toV2 |
|
| 982 | + */ |
|
| 978 | 983 | private function convertPrincipal($principalUri, $toV2) { |
| 979 | 984 | if ($this->principalBackend->getPrincipalPrefix() === 'principals') { |
| 980 | 985 | list(, $name) = URLUtil::splitPath($principalUri); |
@@ -745,7 +745,9 @@ |
||
| 745 | 745 | $stmt->execute([ $addressBookId ]); |
| 746 | 746 | $currentToken = $stmt->fetchColumn(0); |
| 747 | 747 | |
| 748 | - if (is_null($currentToken)) return null; |
|
| 748 | + if (is_null($currentToken)) { |
|
| 749 | + return null; |
|
| 750 | + } |
|
| 749 | 751 | |
| 750 | 752 | $result = [ |
| 751 | 753 | 'syncToken' => $currentToken, |
@@ -246,7 +246,7 @@ |
||
| 246 | 246 | } |
| 247 | 247 | |
| 248 | 248 | /** |
| 249 | - * @return array|null |
|
| 249 | + * @return string |
|
| 250 | 250 | */ |
| 251 | 251 | public function getLocalSystemAddressBook() { |
| 252 | 252 | if (is_null($this->localSystemAddressBook)) { |
@@ -93,7 +93,7 @@ |
||
| 93 | 93 | /** |
| 94 | 94 | * returns a list of all possible property names |
| 95 | 95 | * |
| 96 | - * @return array |
|
| 96 | + * @return string[] |
|
| 97 | 97 | */ |
| 98 | 98 | static public function getPropertyNames() { |
| 99 | 99 | return [ |
@@ -138,7 +138,7 @@ |
||
| 138 | 138 | * This will be used in the {DAV:}supported-report-set property. |
| 139 | 139 | * |
| 140 | 140 | * @param string $uri |
| 141 | - * @return array |
|
| 141 | + * @return string[] |
|
| 142 | 142 | */ |
| 143 | 143 | public function getSupportedReportSet($uri) { |
| 144 | 144 | return [self::REPORT_NAME]; |
@@ -115,7 +115,7 @@ |
||
| 115 | 115 | /** |
| 116 | 116 | * Returns an array with all the child nodes |
| 117 | 117 | * |
| 118 | - * @return \Sabre\DAV\INode[] |
|
| 118 | + * @return CommentNode[] |
|
| 119 | 119 | */ |
| 120 | 120 | function getChildren() { |
| 121 | 121 | return $this->findChildren(); |
@@ -64,6 +64,9 @@ |
||
| 64 | 64 | ); |
| 65 | 65 | } |
| 66 | 66 | |
| 67 | + /** |
|
| 68 | + * @param boolean $toV2 |
|
| 69 | + */ |
|
| 67 | 70 | private function convertPrincipal($principal, $toV2) { |
| 68 | 71 | list(, $name) = URLUtil::splitPath($principal); |
| 69 | 72 | if ($toV2) { |
@@ -53,7 +53,9 @@ |
||
| 53 | 53 | function getCurrentUserPrincipals() { |
| 54 | 54 | $principalV2 = $this->getCurrentUserPrincipal(); |
| 55 | 55 | |
| 56 | - if (is_null($principalV2)) return []; |
|
| 56 | + if (is_null($principalV2)) { |
|
| 57 | + return []; |
|
| 58 | + } |
|
| 57 | 59 | |
| 58 | 60 | $principalV1 = $this->convertPrincipal($principalV2, false); |
| 59 | 61 | return array_merge( |
@@ -75,7 +75,7 @@ |
||
| 75 | 75 | private $cache = []; |
| 76 | 76 | |
| 77 | 77 | /** |
| 78 | - * @param Tree $tree node tree |
|
| 78 | + * @param ObjectTree $tree node tree |
|
| 79 | 79 | * @param IDBConnection $connection database connection |
| 80 | 80 | * @param IUser $user owner of the tree and properties |
| 81 | 81 | */ |
@@ -232,6 +232,9 @@ |
||
| 232 | 232 | return '"' . $this->info->getEtag() . '"'; |
| 233 | 233 | } |
| 234 | 234 | |
| 235 | + /** |
|
| 236 | + * @param string $path |
|
| 237 | + */ |
|
| 235 | 238 | private function getPartFileBasePath($path) { |
| 236 | 239 | $partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true); |
| 237 | 240 | if ($partFileInStorage) { |