Inspection of "[stable9] Make sure invalid images don't flood the..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — stable9 (#3442)

by Joas

created 2017-02-10 12:52 UTC

Status

Unused Use Statements -4 removed lines patch added patch discarded remove patch

@@ -24,10 +24,6 @@
 block discarded – undo
 
 use OCA\DAV\CardDAV\SyncService;
 use OCP\AppFramework\Http;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\ProgressBar;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class SyncFederationAddressBooks {
 

Please login to merge, or discard this patch.

apps/files/controller/apicontroller.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -35,7 +35,6 @@
 block discarded – undo
 use OCA\Files\Service\TagService;
 use OCP\IPreview;
 use OCP\Share\IManager;
-use OCP\Files\FileInfo;
 use OCP\Files\Node;
 use OCP\IUserSession;
 

Please login to merge, or discard this patch.

apps/files/service/tagservice.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -24,7 +24,6 @@
 block discarded – undo
 
 namespace OCA\Files\Service;
 
-use OC\Files\FileInfo;
 use OCP\Files\Node;
 
 /**

Please login to merge, or discard this patch.

apps/files_external/command/applicable.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -28,8 +28,6 @@
 block discarded – undo
 use OCP\IGroupManager;
 use OCP\IUserManager;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;

Please login to merge, or discard this patch.

apps/files_external/command/backends.php 1 patch

Unused Use Statements -6 removed lines patch added patch discarded remove patch

@@ -22,18 +22,12 @@
 block discarded – undo
 namespace OCA\Files_External\Command;
 
 use OC\Core\Command\Base;
-use OCA\Files_External\Lib\Auth\AuthMechanism;
 use OCA\Files_External\Lib\Backend\Backend;
 use OCA\Files_External\Lib\DefinitionParameter;
 use OCA\Files_External\Service\BackendService;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
-use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Backends extends Base {

Please login to merge, or discard this patch.

apps/files_external/command/create.php 1 patch

Unused Use Statements -4 removed lines patch added patch discarded remove patch

@@ -30,18 +30,14 @@
 block discarded – undo
 use OCA\Files_external\Lib\StorageConfig;
 use OCA\Files_External\Service\BackendService;
 use OCA\Files_external\Service\GlobalStoragesService;
-use OCA\Files_external\Service\ImportLegacyStoragesService;
 use OCA\Files_external\Service\UserStoragesService;
 use OCP\IUserManager;
 use OCP\IUserSession;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Create extends Base {

Please login to merge, or discard this patch.

apps/files_external/command/delete.php 1 patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -22,15 +22,12 @@
 block discarded – undo
 namespace OCA\Files_External\Command;
 
 use OC\Core\Command\Base;
-use OCA\Files_external\Lib\StorageConfig;
 use OCA\Files_external\NotFoundException;
 use OCA\Files_external\Service\GlobalStoragesService;
 use OCA\Files_external\Service\UserStoragesService;
 use OCP\IUserManager;
 use OCP\IUserSession;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;

Please login to merge, or discard this patch.

apps/files_external/command/import.php 1 patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -31,13 +31,10 @@
 block discarded – undo
 use OCP\IUserManager;
 use OCP\IUserSession;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Import extends Base {

Please login to merge, or discard this patch.

apps/files_external/command/verify.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,8 +30,6 @@
 block discarded – undo
 use OCA\Files_external\Service\GlobalStoragesService;
 use OCP\Files\StorageNotAvailableException;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;

Please login to merge, or discard this patch.

		@@ -35,7 +35,6 @@
		block discarded – undo
35	35	use OCA\Files\Service\TagService;
36	36	use OCP\IPreview;
37	37	use OCP\Share\IManager;
38		-use OCP\Files\FileInfo;
39	38	use OCP\Files\Node;
40	39	use OCP\IUserSession;
41	40

		@@ -24,10 +24,6 @@
		block discarded – undo
24	24
25	25	use OCA\DAV\CardDAV\SyncService;
26	26	use OCP\AppFramework\Http;
27		-use Symfony\Component\Console\Command\Command;
28		-use Symfony\Component\Console\Helper\ProgressBar;
29		-use Symfony\Component\Console\Input\InputInterface;
30		-use Symfony\Component\Console\Output\OutputInterface;
31	27
32	28	class SyncFederationAddressBooks {
33	29

		@@ -24,7 +24,6 @@
		block discarded – undo
24	24
25	25	namespace OCA\Files\Service;
26	26
27		-use OC\Files\FileInfo;
28	27	use OCP\Files\Node;
29	28
30	29	/**

		@@ -28,8 +28,6 @@
		block discarded – undo
28	28	use OCP\IGroupManager;
29	29	use OCP\IUserManager;
30	30	use Symfony\Component\Console\Command\Command;
31		-use Symfony\Component\Console\Helper\Table;
32		-use Symfony\Component\Console\Helper\TableHelper;
33	31	use Symfony\Component\Console\Input\InputArgument;
34	32	use Symfony\Component\Console\Input\InputInterface;
35	33	use Symfony\Component\Console\Input\InputOption;

		@@ -22,18 +22,12 @@
		block discarded – undo
22	22	namespace OCA\Files_External\Command;
23	23
24	24	use OC\Core\Command\Base;
25		-use OCA\Files_External\Lib\Auth\AuthMechanism;
26	25	use OCA\Files_External\Lib\Backend\Backend;
27	26	use OCA\Files_External\Lib\DefinitionParameter;
28	27	use OCA\Files_External\Service\BackendService;
29	28	use Symfony\Component\Console\Command\Command;
30		-use Symfony\Component\Console\Helper\Table;
31		-use Symfony\Component\Console\Helper\TableHelper;
32		-use Symfony\Component\Console\Input\ArrayInput;
33	29	use Symfony\Component\Console\Input\InputArgument;
34	30	use Symfony\Component\Console\Input\InputInterface;
35		-use Symfony\Component\Console\Input\InputOption;
36		-use Symfony\Component\Console\Input\Input;
37	31	use Symfony\Component\Console\Output\OutputInterface;
38	32
39	33	class Backends extends Base {

		@@ -30,18 +30,14 @@
		block discarded – undo
30	30	use OCA\Files_external\Lib\StorageConfig;
31	31	use OCA\Files_External\Service\BackendService;
32	32	use OCA\Files_external\Service\GlobalStoragesService;
33		-use OCA\Files_external\Service\ImportLegacyStoragesService;
34	33	use OCA\Files_external\Service\UserStoragesService;
35	34	use OCP\IUserManager;
36	35	use OCP\IUserSession;
37	36	use Symfony\Component\Console\Command\Command;
38		-use Symfony\Component\Console\Helper\Table;
39		-use Symfony\Component\Console\Helper\TableHelper;
40	37	use Symfony\Component\Console\Input\ArrayInput;
41	38	use Symfony\Component\Console\Input\InputArgument;
42	39	use Symfony\Component\Console\Input\InputInterface;
43	40	use Symfony\Component\Console\Input\InputOption;
44		-use Symfony\Component\Console\Input\Input;
45	41	use Symfony\Component\Console\Output\OutputInterface;
46	42
47	43	class Create extends Base {

		@@ -22,15 +22,12 @@
		block discarded – undo
22	22	namespace OCA\Files_External\Command;
23	23
24	24	use OC\Core\Command\Base;
25		-use OCA\Files_external\Lib\StorageConfig;
26	25	use OCA\Files_external\NotFoundException;
27	26	use OCA\Files_external\Service\GlobalStoragesService;
28	27	use OCA\Files_external\Service\UserStoragesService;
29	28	use OCP\IUserManager;
30	29	use OCP\IUserSession;
31	30	use Symfony\Component\Console\Command\Command;
32		-use Symfony\Component\Console\Helper\Table;
33		-use Symfony\Component\Console\Helper\TableHelper;
34	31	use Symfony\Component\Console\Input\ArrayInput;
35	32	use Symfony\Component\Console\Input\InputArgument;
36	33	use Symfony\Component\Console\Input\InputInterface;

		@@ -31,13 +31,10 @@
		block discarded – undo
31	31	use OCP\IUserManager;
32	32	use OCP\IUserSession;
33	33	use Symfony\Component\Console\Command\Command;
34		-use Symfony\Component\Console\Helper\Table;
35		-use Symfony\Component\Console\Helper\TableHelper;
36	34	use Symfony\Component\Console\Input\ArrayInput;
37	35	use Symfony\Component\Console\Input\InputArgument;
38	36	use Symfony\Component\Console\Input\InputInterface;
39	37	use Symfony\Component\Console\Input\InputOption;
40		-use Symfony\Component\Console\Input\Input;
41	38	use Symfony\Component\Console\Output\OutputInterface;
42	39
43	40	class Import extends Base {

		@@ -30,8 +30,6 @@
		block discarded – undo
30	30	use OCA\Files_external\Service\GlobalStoragesService;
31	31	use OCP\Files\StorageNotAvailableException;
32	32	use Symfony\Component\Console\Command\Command;
33		-use Symfony\Component\Console\Helper\Table;
34		-use Symfony\Component\Console\Helper\TableHelper;
35	33	use Symfony\Component\Console\Input\InputArgument;
36	34	use Symfony\Component\Console\Input\InputInterface;
37	35	use Symfony\Component\Console\Input\InputOption;

nextcloud / server

Pull Request — stable9 (#3442)

Status

Category

Unused Use Statements -4 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -6 removed lines patch added patch discarded remove patch

Unused Use Statements -4 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch