nextcloud / server

apps/files_external/lib/Command/Config.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 		try {
 			$mount = $this->globalService->getStorage($mountId);
 		} catch (NotFoundException $e) {
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
+			$output->writeln('<error>Mount with id "'.$mountId.' not found, check "occ files_external:list" to get available mounts"</error>');
 			return 404;
 		}
 

Indentation +78 added lines, -78 removed lines

@@ -34,88 +34,88 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Config extends Base {
-	/**
-	 * @var GlobalStoragesService
-	 */
-	protected $globalService;
+    /**
+     * @var GlobalStoragesService
+     */
+    protected $globalService;
 
-	public function __construct(GlobalStoragesService $globalService) {
-		parent::__construct();
-		$this->globalService = $globalService;
-	}
+    public function __construct(GlobalStoragesService $globalService) {
+        parent::__construct();
+        $this->globalService = $globalService;
+    }
 
-	protected function configure() {
-		$this
-			->setName('files_external:config')
-			->setDescription('Manage backend configuration for a mount')
-			->addArgument(
-				'mount_id',
-				InputArgument::REQUIRED,
-				'The id of the mount to edit'
-			)->addArgument(
-				'key',
-				InputArgument::REQUIRED,
-				'key of the config option to set/get'
-			)->addArgument(
-				'value',
-				InputArgument::OPTIONAL,
-				'value to set the config option to, when no value is provided the existing value will be printed'
-			);
-		parent::configure();
-	}
+    protected function configure() {
+        $this
+            ->setName('files_external:config')
+            ->setDescription('Manage backend configuration for a mount')
+            ->addArgument(
+                'mount_id',
+                InputArgument::REQUIRED,
+                'The id of the mount to edit'
+            )->addArgument(
+                'key',
+                InputArgument::REQUIRED,
+                'key of the config option to set/get'
+            )->addArgument(
+                'value',
+                InputArgument::OPTIONAL,
+                'value to set the config option to, when no value is provided the existing value will be printed'
+            );
+        parent::configure();
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$mountId = $input->getArgument('mount_id');
-		$key = $input->getArgument('key');
-		try {
-			$mount = $this->globalService->getStorage($mountId);
-		} catch (NotFoundException $e) {
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
-			return 404;
-		}
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $mountId = $input->getArgument('mount_id');
+        $key = $input->getArgument('key');
+        try {
+            $mount = $this->globalService->getStorage($mountId);
+        } catch (NotFoundException $e) {
+            $output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
+            return 404;
+        }
 
-		$value = $input->getArgument('value');
-		if ($value !== null) {
-			$this->setOption($mount, $key, $value, $output);
-		} else {
-			$this->getOption($mount, $key, $output);
-		}
-		return 0;
-	}
+        $value = $input->getArgument('value');
+        if ($value !== null) {
+            $this->setOption($mount, $key, $value, $output);
+        } else {
+            $this->getOption($mount, $key, $output);
+        }
+        return 0;
+    }
 
-	/**
-	 * @param StorageConfig $mount
-	 * @param string $key
-	 * @param OutputInterface $output
-	 */
-	protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
-		if ($key === 'mountpoint' || $key === 'mount_point') {
-			$value = $mount->getMountPoint();
-		} else {
-			$value = $mount->getBackendOption($key);
-		}
-		if (!is_string($value) && json_decode(json_encode($value)) === $value) { // show bools and objects correctly
-			$value = json_encode($value);
-		}
-		$output->writeln($value);
-	}
+    /**
+     * @param StorageConfig $mount
+     * @param string $key
+     * @param OutputInterface $output
+     */
+    protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
+        if ($key === 'mountpoint' || $key === 'mount_point') {
+            $value = $mount->getMountPoint();
+        } else {
+            $value = $mount->getBackendOption($key);
+        }
+        if (!is_string($value) && json_decode(json_encode($value)) === $value) { // show bools and objects correctly
+            $value = json_encode($value);
+        }
+        $output->writeln($value);
+    }
 
-	/**
-	 * @param StorageConfig $mount
-	 * @param string $key
-	 * @param string $value
-	 * @param OutputInterface $output
-	 */
-	protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
-		$decoded = json_decode($value, true);
-		if (!is_null($decoded) && json_encode($decoded) === $value) {
-			$value = $decoded;
-		}
-		if ($key === 'mountpoint' || $key === 'mount_point') {
-			$mount->setMountPoint($value);
-		} else {
-			$mount->setBackendOption($key, $value);
-		}
-		$this->globalService->updateStorage($mount);
-	}
+    /**
+     * @param StorageConfig $mount
+     * @param string $key
+     * @param string $value
+     * @param OutputInterface $output
+     */
+    protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
+        $decoded = json_decode($value, true);
+        if (!is_null($decoded) && json_encode($decoded) === $value) {
+            $value = $decoded;
+        }
+        if ($key === 'mountpoint' || $key === 'mount_point') {
+            $mount->setMountPoint($value);
+        } else {
+            $mount->setBackendOption($key, $value);
+        }
+        $this->globalService->updateStorage($mount);
+    }
 }

apps/files_external/lib/Command/Option.php

Indentation +44 added lines, -44 removed lines

@@ -28,50 +28,50 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Option extends Config {
-	protected function configure() {
-		$this
-			->setName('files_external:option')
-			->setDescription('Manage mount options for a mount')
-			->addArgument(
-				'mount_id',
-				InputArgument::REQUIRED,
-				'The id of the mount to edit'
-			)->addArgument(
-				'key',
-				InputArgument::REQUIRED,
-				'key of the mount option to set/get'
-			)->addArgument(
-				'value',
-				InputArgument::OPTIONAL,
-				'value to set the mount option to, when no value is provided the existing value will be printed'
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('files_external:option')
+            ->setDescription('Manage mount options for a mount')
+            ->addArgument(
+                'mount_id',
+                InputArgument::REQUIRED,
+                'The id of the mount to edit'
+            )->addArgument(
+                'key',
+                InputArgument::REQUIRED,
+                'key of the mount option to set/get'
+            )->addArgument(
+                'value',
+                InputArgument::OPTIONAL,
+                'value to set the mount option to, when no value is provided the existing value will be printed'
+            );
+    }
 
-	/**
-	 * @param StorageConfig $mount
-	 * @param string $key
-	 * @param OutputInterface $output
-	 */
-	protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
-		$value = $mount->getMountOption($key);
-		if (!is_string($value)) { // show bools and objects correctly
-			$value = json_encode($value);
-		}
-		$output->writeln($value);
-	}
+    /**
+     * @param StorageConfig $mount
+     * @param string $key
+     * @param OutputInterface $output
+     */
+    protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
+        $value = $mount->getMountOption($key);
+        if (!is_string($value)) { // show bools and objects correctly
+            $value = json_encode($value);
+        }
+        $output->writeln($value);
+    }
 
-	/**
-	 * @param StorageConfig $mount
-	 * @param string $key
-	 * @param string $value
-	 * @param OutputInterface $output
-	 */
-	protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
-		$decoded = json_decode($value, true);
-		if (!is_null($decoded)) {
-			$value = $decoded;
-		}
-		$mount->setMountOption($key, $value);
-		$this->globalService->updateStorage($mount);
-	}
+    /**
+     * @param StorageConfig $mount
+     * @param string $key
+     * @param string $value
+     * @param OutputInterface $output
+     */
+    protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
+        $decoded = json_decode($value, true);
+        if (!is_null($decoded)) {
+            $value = $decoded;
+        }
+        $mount->setMountOption($key, $value);
+        $this->globalService->updateStorage($mount);
+    }
 }

apps/files_external/lib/Command/Backends.php

Spacing +5 added lines, -5 removed lines

@@ -71,14 +71,14 @@ 
 		$backend = $input->getArgument('backend');
 		if ($type) {
 			if (!isset($data[$type])) {
-				$output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
+				$output->writeln('<error>Invalid type "'.$type.'". Possible values are "authentication" or "storage"</error>');
 				return 1;
 			}
 			$data = $data[$type];
 
 			if ($backend) {
 				if (!isset($data[$backend])) {
-					$output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
+					$output->writeln('<error>Unknown backend "'.$backend.'" of type  "'.$type.'"</error>');
 					return 1;
 				}
 				$data = $data[$backend];
@@ -99,7 +99,7 @@ 
 			$result['storage_class'] = $backend->getStorageClass();
 			$authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
 			$result['supported_authentication_backends'] = array_keys($authBackends);
-			$authConfig = array_map(function (AuthMechanism $auth) {
+			$authConfig = array_map(function(AuthMechanism $auth) {
 				return $this->serializeAuthBackend($auth)['configuration'];
 			}, $authBackends);
 			$result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
@@ -112,10 +112,10 @@ 
 	 * @return string[]
 	 */
 	private function formatConfiguration(array $parameters) {
-		$configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
+		$configuration = array_filter($parameters, function(DefinitionParameter $parameter) {
 			return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
 		});
-		return array_map(function (DefinitionParameter $parameter) {
+		return array_map(function(DefinitionParameter $parameter) {
 			return $parameter->getTypeName();
 		}, $configuration);
 	}

Indentation +78 added lines, -78 removed lines

@@ -33,92 +33,92 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Backends extends Base {
-	/** @var BackendService */
-	private $backendService;
+    /** @var BackendService */
+    private $backendService;
 
-	public function __construct(BackendService $backendService
-	) {
-		parent::__construct();
+    public function __construct(BackendService $backendService
+    ) {
+        parent::__construct();
 
-		$this->backendService = $backendService;
-	}
+        $this->backendService = $backendService;
+    }
 
-	protected function configure() {
-		$this
-			->setName('files_external:backends')
-			->setDescription('Show available authentication and storage backends')
-			->addArgument(
-				'type',
-				InputArgument::OPTIONAL,
-				'only show backends of a certain type. Possible values are "authentication" or "storage"'
-			)->addArgument(
-				'backend',
-				InputArgument::OPTIONAL,
-				'only show information of a specific backend'
-			);
-		parent::configure();
-	}
+    protected function configure() {
+        $this
+            ->setName('files_external:backends')
+            ->setDescription('Show available authentication and storage backends')
+            ->addArgument(
+                'type',
+                InputArgument::OPTIONAL,
+                'only show backends of a certain type. Possible values are "authentication" or "storage"'
+            )->addArgument(
+                'backend',
+                InputArgument::OPTIONAL,
+                'only show information of a specific backend'
+            );
+        parent::configure();
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$authBackends = $this->backendService->getAuthMechanisms();
-		$storageBackends = $this->backendService->getBackends();
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $authBackends = $this->backendService->getAuthMechanisms();
+        $storageBackends = $this->backendService->getBackends();
 
-		$data = [
-			'authentication' => array_map([$this, 'serializeAuthBackend'], $authBackends),
-			'storage' => array_map([$this, 'serializeAuthBackend'], $storageBackends)
-		];
+        $data = [
+            'authentication' => array_map([$this, 'serializeAuthBackend'], $authBackends),
+            'storage' => array_map([$this, 'serializeAuthBackend'], $storageBackends)
+        ];
 
-		$type = $input->getArgument('type');
-		$backend = $input->getArgument('backend');
-		if ($type) {
-			if (!isset($data[$type])) {
-				$output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
-				return 1;
-			}
-			$data = $data[$type];
+        $type = $input->getArgument('type');
+        $backend = $input->getArgument('backend');
+        if ($type) {
+            if (!isset($data[$type])) {
+                $output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
+                return 1;
+            }
+            $data = $data[$type];
 
-			if ($backend) {
-				if (!isset($data[$backend])) {
-					$output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
-					return 1;
-				}
-				$data = $data[$backend];
-			}
-		}
+            if ($backend) {
+                if (!isset($data[$backend])) {
+                    $output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
+                    return 1;
+                }
+                $data = $data[$backend];
+            }
+        }
 
-		$this->writeArrayInOutputFormat($input, $output, $data);
-		return 0;
-	}
+        $this->writeArrayInOutputFormat($input, $output, $data);
+        return 0;
+    }
 
-	private function serializeAuthBackend(\JsonSerializable $backend) {
-		$data = $backend->jsonSerialize();
-		$result = [
-			'name' => $data['name'],
-			'identifier' => $data['identifier'],
-			'configuration' => $this->formatConfiguration($data['configuration'])
-		];
-		if ($backend instanceof Backend) {
-			$result['storage_class'] = $backend->getStorageClass();
-			$authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
-			$result['supported_authentication_backends'] = array_keys($authBackends);
-			$authConfig = array_map(function (AuthMechanism $auth) {
-				return $this->serializeAuthBackend($auth)['configuration'];
-			}, $authBackends);
-			$result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
-		}
-		return $result;
-	}
+    private function serializeAuthBackend(\JsonSerializable $backend) {
+        $data = $backend->jsonSerialize();
+        $result = [
+            'name' => $data['name'],
+            'identifier' => $data['identifier'],
+            'configuration' => $this->formatConfiguration($data['configuration'])
+        ];
+        if ($backend instanceof Backend) {
+            $result['storage_class'] = $backend->getStorageClass();
+            $authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
+            $result['supported_authentication_backends'] = array_keys($authBackends);
+            $authConfig = array_map(function (AuthMechanism $auth) {
+                return $this->serializeAuthBackend($auth)['configuration'];
+            }, $authBackends);
+            $result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
+        }
+        return $result;
+    }
 
-	/**
-	 * @param DefinitionParameter[] $parameters
-	 * @return string[]
-	 */
-	private function formatConfiguration(array $parameters) {
-		$configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
-			return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
-		});
-		return array_map(function (DefinitionParameter $parameter) {
-			return $parameter->getTypeName();
-		}, $configuration);
-	}
+    /**
+     * @param DefinitionParameter[] $parameters
+     * @return string[]
+     */
+    private function formatConfiguration(array $parameters) {
+        $configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
+            return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
+        });
+        return array_map(function (DefinitionParameter $parameter) {
+            return $parameter->getTypeName();
+        }, $configuration);
+    }
 }

apps/files_external/lib/Lib/LegacyDependencyCheckPolyfill.php

Indentation +34 added lines, -34 removed lines

@@ -29,43 +29,43 @@
  */
 trait LegacyDependencyCheckPolyfill {
 
-	/**
-	 * @return string
-	 */
-	abstract public function getStorageClass();
+    /**
+     * @return string
+     */
+    abstract public function getStorageClass();
 
-	/**
-	 * Check if object is valid for use
-	 *
-	 * @return MissingDependency[] Unsatisfied dependencies
-	 */
-	public function checkDependencies() {
-		$ret = [];
+    /**
+     * Check if object is valid for use
+     *
+     * @return MissingDependency[] Unsatisfied dependencies
+     */
+    public function checkDependencies() {
+        $ret = [];
 
-		$result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
-		if ($result !== true) {
-			if (!is_array($result)) {
-				$result = [$result];
-			}
-			foreach ($result as $key => $value) {
-				if (!($value instanceof MissingDependency)) {
-					$module = null;
-					$message = null;
-					if (is_numeric($key)) {
-						$module = $value;
-					} else {
-						$module = $key;
-						$message = $value;
-					}
-					$value = new MissingDependency($module, $this);
-					$value->setMessage($message);
-				}
-				$ret[] = $value;
-			}
-		}
+        $result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
+        if ($result !== true) {
+            if (!is_array($result)) {
+                $result = [$result];
+            }
+            foreach ($result as $key => $value) {
+                if (!($value instanceof MissingDependency)) {
+                    $module = null;
+                    $message = null;
+                    if (is_numeric($key)) {
+                        $module = $value;
+                    } else {
+                        $module = $key;
+                        $message = $value;
+                    }
+                    $value = new MissingDependency($module, $this);
+                    $value->setMessage($message);
+                }
+                $ret[] = $value;
+            }
+        }
 
-		return $ret;
-	}
+        return $ret;
+    }
 
 }
 

apps/files_external/lib/Lib/DefinitionParameter.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 	 * @return bool
 	 */
 	public function isFlagSet($flag) {
-		return (bool)($this->flags & $flag);
+		return (bool) ($this->flags & $flag);
 	}
 
 	/**

Indentation +187 added lines, -187 removed lines

@@ -27,191 +27,191 @@
  * Parameter for an external storage definition
  */
 class DefinitionParameter implements \JsonSerializable {
-	// placeholder value for password fields, when the client updates a storage configuration
-	// placeholder values are ignored and the field is left unmodified
-	public const UNMODIFIED_PLACEHOLDER = '__unmodified__';
-
-	/** Value constants */
-	public const VALUE_TEXT = 0;
-	public const VALUE_BOOLEAN = 1;
-	public const VALUE_PASSWORD = 2;
-	public const VALUE_HIDDEN = 3;
-
-	/** Flag constants */
-	public const FLAG_NONE = 0;
-	public const FLAG_OPTIONAL = 1;
-	public const FLAG_USER_PROVIDED = 2;
-
-	/** @var string name of parameter */
-	private $name;
-
-	/** @var string human-readable parameter text */
-	private $text;
-
-	/** @var string human-readable parameter tooltip */
-	private $tooltip = '';
-
-	/** @var int value type, see self::VALUE_* constants */
-	private $type = self::VALUE_TEXT;
-
-	/** @var int flags, see self::FLAG_* constants */
-	private $flags = self::FLAG_NONE;
-
-	/**
-	 * @param string $name
-	 * @param string $text
-	 */
-	public function __construct($name, $text) {
-		$this->name = $name;
-		$this->text = $text;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getName() {
-		return $this->name;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getText() {
-		return $this->text;
-	}
-
-	/**
-	 * Get value type
-	 *
-	 * @return int
-	 */
-	public function getType() {
-		return $this->type;
-	}
-
-	/**
-	 * Set value type
-	 *
-	 * @param int $type
-	 * @return self
-	 */
-	public function setType($type) {
-		$this->type = $type;
-		return $this;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTypeName() {
-		switch ($this->type) {
-			case self::VALUE_BOOLEAN:
-				return 'boolean';
-			case self::VALUE_TEXT:
-				return 'text';
-			case self::VALUE_PASSWORD:
-				return 'password';
-			default:
-				return 'unknown';
-		}
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getFlags() {
-		return $this->flags;
-	}
-
-	/**
-	 * @param int $flags
-	 * @return self
-	 */
-	public function setFlags($flags) {
-		$this->flags = $flags;
-		return $this;
-	}
-
-	/**
-	 * @param int $flag
-	 * @return self
-	 */
-	public function setFlag($flag) {
-		$this->flags |= $flag;
-		return $this;
-	}
-
-	/**
-	 * @param int $flag
-	 * @return bool
-	 */
-	public function isFlagSet($flag) {
-		return (bool)($this->flags & $flag);
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTooltip(): string {
-		return $this->tooltip;
-	}
-
-	/**
-	 * @param string $tooltip
-	 * @return self
-	 */
-	public function setTooltip(string $tooltip) {
-		$this->tooltip = $tooltip;
-		return $this;
-	}
-
-	/**
-	 * Serialize into JSON for client-side JS
-	 *
-	 * @return string
-	 */
-	public function jsonSerialize() {
-		return [
-			'value' => $this->getText(),
-			'flags' => $this->getFlags(),
-			'type' => $this->getType(),
-			'tooltip' => $this->getTooltip(),
-		];
-	}
-
-	public function isOptional() {
-		return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
-	}
-
-	/**
-	 * Validate a parameter value against this
-	 * Convert type as necessary
-	 *
-	 * @param mixed $value Value to check
-	 * @return bool success
-	 */
-	public function validateValue(&$value) {
-		switch ($this->getType()) {
-			case self::VALUE_BOOLEAN:
-				if (!is_bool($value)) {
-					switch ($value) {
-						case 'true':
-							$value = true;
-							break;
-						case 'false':
-							$value = false;
-							break;
-						default:
-							return false;
-					}
-				}
-				break;
-			default:
-				if (!$value && !$this->isOptional()) {
-					return false;
-				}
-				break;
-		}
-		return true;
-	}
+    // placeholder value for password fields, when the client updates a storage configuration
+    // placeholder values are ignored and the field is left unmodified
+    public const UNMODIFIED_PLACEHOLDER = '__unmodified__';
+
+    /** Value constants */
+    public const VALUE_TEXT = 0;
+    public const VALUE_BOOLEAN = 1;
+    public const VALUE_PASSWORD = 2;
+    public const VALUE_HIDDEN = 3;
+
+    /** Flag constants */
+    public const FLAG_NONE = 0;
+    public const FLAG_OPTIONAL = 1;
+    public const FLAG_USER_PROVIDED = 2;
+
+    /** @var string name of parameter */
+    private $name;
+
+    /** @var string human-readable parameter text */
+    private $text;
+
+    /** @var string human-readable parameter tooltip */
+    private $tooltip = '';
+
+    /** @var int value type, see self::VALUE_* constants */
+    private $type = self::VALUE_TEXT;
+
+    /** @var int flags, see self::FLAG_* constants */
+    private $flags = self::FLAG_NONE;
+
+    /**
+     * @param string $name
+     * @param string $text
+     */
+    public function __construct($name, $text) {
+        $this->name = $name;
+        $this->text = $text;
+    }
+
+    /**
+     * @return string
+     */
+    public function getName() {
+        return $this->name;
+    }
+
+    /**
+     * @return string
+     */
+    public function getText() {
+        return $this->text;
+    }
+
+    /**
+     * Get value type
+     *
+     * @return int
+     */
+    public function getType() {
+        return $this->type;
+    }
+
+    /**
+     * Set value type
+     *
+     * @param int $type
+     * @return self
+     */
+    public function setType($type) {
+        $this->type = $type;
+        return $this;
+    }
+
+    /**
+     * @return string
+     */
+    public function getTypeName() {
+        switch ($this->type) {
+            case self::VALUE_BOOLEAN:
+                return 'boolean';
+            case self::VALUE_TEXT:
+                return 'text';
+            case self::VALUE_PASSWORD:
+                return 'password';
+            default:
+                return 'unknown';
+        }
+    }
+
+    /**
+     * @return int
+     */
+    public function getFlags() {
+        return $this->flags;
+    }
+
+    /**
+     * @param int $flags
+     * @return self
+     */
+    public function setFlags($flags) {
+        $this->flags = $flags;
+        return $this;
+    }
+
+    /**
+     * @param int $flag
+     * @return self
+     */
+    public function setFlag($flag) {
+        $this->flags |= $flag;
+        return $this;
+    }
+
+    /**
+     * @param int $flag
+     * @return bool
+     */
+    public function isFlagSet($flag) {
+        return (bool)($this->flags & $flag);
+    }
+
+    /**
+     * @return string
+     */
+    public function getTooltip(): string {
+        return $this->tooltip;
+    }
+
+    /**
+     * @param string $tooltip
+     * @return self
+     */
+    public function setTooltip(string $tooltip) {
+        $this->tooltip = $tooltip;
+        return $this;
+    }
+
+    /**
+     * Serialize into JSON for client-side JS
+     *
+     * @return string
+     */
+    public function jsonSerialize() {
+        return [
+            'value' => $this->getText(),
+            'flags' => $this->getFlags(),
+            'type' => $this->getType(),
+            'tooltip' => $this->getTooltip(),
+        ];
+    }
+
+    public function isOptional() {
+        return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
+    }
+
+    /**
+     * Validate a parameter value against this
+     * Convert type as necessary
+     *
+     * @param mixed $value Value to check
+     * @return bool success
+     */
+    public function validateValue(&$value) {
+        switch ($this->getType()) {
+            case self::VALUE_BOOLEAN:
+                if (!is_bool($value)) {
+                    switch ($value) {
+                        case 'true':
+                            $value = true;
+                            break;
+                        case 'false':
+                            $value = false;
+                            break;
+                        default:
+                            return false;
+                    }
+                }
+                break;
+            default:
+                if (!$value && !$this->isOptional()) {
+                    return false;
+                }
+                break;
+        }
+        return true;
+    }
 }

apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php

Indentation +21 added lines, -21 removed lines

@@ -39,31 +39,31 @@
  */
 class SessionCredentials extends AuthMechanism {
 
-	/** @var CredentialsStore */
-	private $credentialsStore;
+    /** @var CredentialsStore */
+    private $credentialsStore;
 
-	public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
-		$this->credentialsStore = $credentialsStore;
+    public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
+        $this->credentialsStore = $credentialsStore;
 
-		$this->setIdentifier('password::sessioncredentials')
-			->setScheme(self::SCHEME_PASSWORD)
-			->setText($l->t('Log-in credentials, save in session'))
-			->addParameters([]);
-	}
+        $this->setIdentifier('password::sessioncredentials')
+            ->setScheme(self::SCHEME_PASSWORD)
+            ->setText($l->t('Log-in credentials, save in session'))
+            ->addParameters([]);
+    }
 
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
-		try {
-			$credentials = $this->credentialsStore->getLoginCredentials();
-		} catch (CredentialsUnavailableException $e) {
-			throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
-		}
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
+        try {
+            $credentials = $this->credentialsStore->getLoginCredentials();
+        } catch (CredentialsUnavailableException $e) {
+            throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
+        }
 
-		$storage->setBackendOption('user', $credentials->getLoginName());
-		$storage->setBackendOption('password', $credentials->getPassword());
-	}
+        $storage->setBackendOption('user', $credentials->getLoginName());
+        $storage->setBackendOption('password', $credentials->getPassword());
+    }
 
-	public function wrapStorage(Storage $storage) {
-		return new SessionStorageWrapper(['storage' => $storage]);
-	}
+    public function wrapStorage(Storage $storage) {
+        return new SessionStorageWrapper(['storage' => $storage]);
+    }
 
 }

apps/files_external/lib/Lib/Auth/IUserProvided.php

Indentation +6 added lines, -6 removed lines

@@ -28,10 +28,10 @@
  * For auth mechanisms where the user needs to provide credentials
  */
 interface IUserProvided {
-	/**
-	 * @param IUser $user the user for which to save the user provided options
-	 * @param int $mountId the mount id to save the options for
-	 * @param array $options the user provided options
-	 */
-	public function saveBackendOptions(IUser $user, $mountId, array $options);
+    /**
+     * @param IUser $user the user for which to save the user provided options
+     * @param int $mountId the mount id to save the options for
+     * @param array $options the user provided options
+     */
+    public function saveBackendOptions(IUser $user, $mountId, array $options);
 }

apps/files_external/lib/Lib/Config/IBackendProvider.php

Indentation +5 added lines, -5 removed lines

@@ -30,10 +30,10 @@
  */
 interface IBackendProvider {
 
-	/**
-	 * @since 9.1.0
-	 * @return Backend[]
-	 */
-	public function getBackends();
+    /**
+     * @since 9.1.0
+     * @return Backend[]
+     */
+    public function getBackends();
 
 }

apps/files_external/lib/Lib/Config/IAuthMechanismProvider.php

Indentation +5 added lines, -5 removed lines

@@ -30,10 +30,10 @@
  */
 interface IAuthMechanismProvider {
 
-	/**
-	 * @since 9.1.0
-	 * @return AuthMechanism[]
-	 */
-	public function getAuthMechanisms();
+    /**
+     * @since 9.1.0
+     * @return AuthMechanism[]
+     */
+    public function getAuthMechanisms();
 
 }