Completed
Pull Request — stable9 (#84)
by Blizzz
18:24 queued 08:38
created
lib/private/files/cache/cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/files/cache/scanner.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -476,6 +476,9 @@
 block discarded – undo
476 476
 		}
477 477
 	}
478 478
 
479
+	/**
480
+	 * @param string|boolean $path
481
+	 */
479 482
 	private function runBackgroundScanJob(callable $callback, $path) {
480 483
 		try {
481 484
 			$callback();
Please login to merge, or discard this patch.
lib/private/files/cache/wrapper/cachejail.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 	/**
72 72
 	 * @param array $entry
73
-	 * @return array
73
+	 * @return string
74 74
 	 */
75 75
 	protected function formatCacheEntry($entry) {
76 76
 		if (isset($entry['path'])) {
@@ -189,6 +189,9 @@  discard block
 block discarded – undo
189 189
 		return $this->cache->getStatus($this->getSourcePath($file));
190 190
 	}
191 191
 
192
+	/**
193
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
194
+	 */
192 195
 	private function formatSearchResults($results) {
193 196
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
194 197
 		$results = array_values($results);
@@ -274,7 +277,7 @@  discard block
 block discarded – undo
274 277
 	 * use the one with the highest id gives the best result with the background scanner, since that is most
275 278
 	 * likely the folder where we stopped scanning previously
276 279
 	 *
277
-	 * @return string|bool the path of the folder or false when no folder matched
280
+	 * @return boolean the path of the folder or false when no folder matched
278 281
 	 */
279 282
 	public function getIncomplete() {
280 283
 		// not supported
Please login to merge, or discard this patch.
lib/private/files/config/usermountcache.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $fileId
209
+	 * @param integer $fileId
210 210
 	 * @return array
211 211
 	 * @throws \OCP\Files\NotFoundException
212 212
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -23,15 +23,12 @@
 block discarded – undo
23 23
 
24 24
 namespace OC\Files\Config;
25 25
 
26
-use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
27
-use OC\Files\Filesystem;
28 26
 use OCA\Files_Sharing\SharedMount;
29 27
 use OCP\DB\QueryBuilder\IQueryBuilder;
30 28
 use OCP\Files\Config\ICachedMountInfo;
31 29
 use OCP\Files\Config\IUserMountCache;
32 30
 use OCP\Files\Mount\IMountPoint;
33 31
 use OCP\Files\NotFoundException;
34
-use OCP\ICache;
35 32
 use OCP\IDBConnection;
36 33
 use OCP\ILogger;
37 34
 use OCP\IUser;
Please login to merge, or discard this patch.
lib/private/files/filesystem.php 2 patches
Doc Comments   +29 added lines, -2 removed lines patch added patch discarded remove patch
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		}
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $root
360
+	 */
358 361
 	static public function init($user, $root) {
359 362
 		if (self::$defaultInstance) {
360 363
 			return false;
@@ -494,7 +497,7 @@  discard block
 block discarded – undo
494 497
 	/**
495 498
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
496 499
 	 *
497
-	 * @param \OC\Files\Storage\Storage|string $class
500
+	 * @param string $class
498 501
 	 * @param array $arguments
499 502
 	 * @param string $mountpoint
500 503
 	 */
@@ -605,6 +608,7 @@  discard block
 block discarded – undo
605 608
 
606 609
 	/**
607 610
 	 * following functions are equivalent to their php builtin equivalents for arguments/return values.
611
+	 * @param string $path
608 612
 	 */
609 613
 	static public function mkdir($path) {
610 614
 		return self::$defaultInstance->mkdir($path);
@@ -626,6 +630,9 @@  discard block
 block discarded – undo
626 630
 		return self::$defaultInstance->is_dir($path);
627 631
 	}
628 632
 
633
+	/**
634
+	 * @param string $path
635
+	 */
629 636
 	static public function is_file($path) {
630 637
 		return self::$defaultInstance->is_file($path);
631 638
 	}
@@ -638,6 +645,9 @@  discard block
 block discarded – undo
638 645
 		return self::$defaultInstance->filetype($path);
639 646
 	}
640 647
 
648
+	/**
649
+	 * @param string $path
650
+	 */
641 651
 	static public function filesize($path) {
642 652
 		return self::$defaultInstance->filesize($path);
643 653
 	}
@@ -650,6 +660,9 @@  discard block
 block discarded – undo
650 660
 		return self::$defaultInstance->isCreatable($path);
651 661
 	}
652 662
 
663
+	/**
664
+	 * @param string $path
665
+	 */
653 666
 	static public function isReadable($path) {
654 667
 		return self::$defaultInstance->isReadable($path);
655 668
 	}
@@ -662,6 +675,9 @@  discard block
 block discarded – undo
662 675
 		return self::$defaultInstance->isDeletable($path);
663 676
 	}
664 677
 
678
+	/**
679
+	 * @param string $path
680
+	 */
665 681
 	static public function isSharable($path) {
666 682
 		return self::$defaultInstance->isSharable($path);
667 683
 	}
@@ -679,6 +695,7 @@  discard block
 block discarded – undo
679 695
 	}
680 696
 
681 697
 	/**
698
+	 * @param string $path
682 699
 	 * @return string
683 700
 	 */
684 701
 	static public function file_get_contents($path) {
@@ -701,6 +718,10 @@  discard block
 block discarded – undo
701 718
 		return self::$defaultInstance->copy($path1, $path2);
702 719
 	}
703 720
 
721
+	/**
722
+	 * @param string $path
723
+	 * @param string $mode
724
+	 */
704 725
 	static public function fopen($path, $mode) {
705 726
 		return self::$defaultInstance->fopen($path, $mode);
706 727
 	}
@@ -716,6 +737,9 @@  discard block
 block discarded – undo
716 737
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
717 738
 	}
718 739
 
740
+	/**
741
+	 * @param string $path
742
+	 */
719 743
 	static public function getMimeType($path) {
720 744
 		return self::$defaultInstance->getMimeType($path);
721 745
 	}
@@ -728,6 +752,9 @@  discard block
 block discarded – undo
728 752
 		return self::$defaultInstance->free_space($path);
729 753
 	}
730 754
 
755
+	/**
756
+	 * @param string $query
757
+	 */
731 758
 	static public function search($query) {
732 759
 		return self::$defaultInstance->search($query);
733 760
 	}
@@ -836,7 +863,7 @@  discard block
 block discarded – undo
836 863
 	 * @param string $path
837 864
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
838 865
 	 * defaults to true
839
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
866
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
840 867
 	 */
841 868
 	public static function getFileInfo($path, $includeMountPoints = true) {
842 869
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,6 @@
 block discarded – undo
62 62
 use OC\Files\Mount\MountPoint;
63 63
 use OC\Files\Storage\StorageFactory;
64 64
 use OCP\Files\Config\IMountProvider;
65
-use OCP\Files\Mount\IMountPoint;
66 65
 use OCP\Files\NotFoundException;
67 66
 use OCP\IUserManager;
68 67
 
Please login to merge, or discard this patch.
lib/private/files/objectstore/objectstorestorage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/files/storage/flysystem.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/files/storage/storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
100 100
 	 * @param \OCP\Lock\ILockingProvider $provider
101 101
 	 * @throws \OCP\Lock\LockedException
102
+	 * @return void
102 103
 	 */
103 104
 	public function acquireLock($path, $type, ILockingProvider $provider);
104 105
 
@@ -106,6 +107,7 @@  discard block
 block discarded – undo
106 107
 	 * @param string $path The path of the file to release the lock for
107 108
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
108 109
 	 * @param \OCP\Lock\ILockingProvider $provider
110
+	 * @return void
109 111
 	 */
110 112
 	public function releaseLock($path, $type, ILockingProvider $provider);
111 113
 
@@ -114,6 +116,7 @@  discard block
 block discarded – undo
114 116
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
115 117
 	 * @param \OCP\Lock\ILockingProvider $provider
116 118
 	 * @throws \OCP\Lock\LockedException
119
+	 * @return void
117 120
 	 */
118 121
 	public function changeLock($path, $type, ILockingProvider $provider);
119 122
 }
Please login to merge, or discard this patch.
lib/private/files/storage/wrapper/encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -982,7 +982,7 @@
 block discarded – undo
982 982
 	/**
983 983
 	 * check if path points to a files version
984 984
 	 *
985
-	 * @param $path
985
+	 * @param string $path
986 986
 	 * @return bool
987 987
 	 */
988 988
 	protected function isVersion($path) {
Please login to merge, or discard this patch.