Inspection of "Merge pull request #53449 from nextcloud/feat/noid..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 672e4f...e22914 )

by Maxence

created 2025-07-16 09:03 UTC

Status

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -33,56 +33,56 @@
 block discarded – undo
 
 class Version1005Date20180530124431 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 13.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 13.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$types = ['resources', 'rooms'];
-		foreach ($types as $type) {
-			if (!$schema->hasTable('calendar_' . $type)) {
-				$table = $schema->createTable('calendar_' . $type);
+        $types = ['resources', 'rooms'];
+        foreach ($types as $type) {
+            if (!$schema->hasTable('calendar_' . $type)) {
+                $table = $schema->createTable('calendar_' . $type);
 
-				$table->addColumn('id', Types::BIGINT, [
-					'autoincrement' => true,
-					'notnull' => true,
-					'length' => 11,
-					'unsigned' => true,
-				]);
-				$table->addColumn('backend_id', Types::STRING, [
-					'notnull' => false,
-					'length' => 64,
-				]);
-				$table->addColumn('resource_id', Types::STRING, [
-					'notnull' => false,
-					'length' => 64,
-				]);
-				$table->addColumn('email', Types::STRING, [
-					'notnull' => false,
-					'length' => 255,
-				]);
-				$table->addColumn('displayname', Types::STRING, [
-					'notnull' => false,
-					'length' => 255,
-				]);
-				$table->addColumn('group_restrictions', Types::STRING, [
-					'notnull' => false,
-					'length' => 4000,
-				]);
+                $table->addColumn('id', Types::BIGINT, [
+                    'autoincrement' => true,
+                    'notnull' => true,
+                    'length' => 11,
+                    'unsigned' => true,
+                ]);
+                $table->addColumn('backend_id', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 64,
+                ]);
+                $table->addColumn('resource_id', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 64,
+                ]);
+                $table->addColumn('email', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 255,
+                ]);
+                $table->addColumn('displayname', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 255,
+                ]);
+                $table->addColumn('group_restrictions', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 4000,
+                ]);
 
-				$table->setPrimaryKey(['id']);
-				$table->addIndex(['backend_id', 'resource_id'], 'calendar_' . $type . '_bkdrsc');
-				$table->addIndex(['email'], 'calendar_' . $type . '_email');
-				$table->addIndex(['displayname'], 'calendar_' . $type . '_name');
-			}
-		}
+                $table->setPrimaryKey(['id']);
+                $table->addIndex(['backend_id', 'resource_id'], 'calendar_' . $type . '_bkdrsc');
+                $table->addIndex(['email'], 'calendar_' . $type . '_email');
+                $table->addIndex(['displayname'], 'calendar_' . $type . '_name');
+            }
+        }
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/dav/lib/Migration/Version1011Date20190725113607.php 1 patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -37,55 +37,55 @@
 block discarded – undo
  */
 class Version1011Date20190725113607 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 13.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 13.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$types = ['resource', 'room'];
-		foreach ($types as $type) {
-			if (!$schema->hasTable($this->getMetadataTableName($type))) {
-				$table = $schema->createTable($this->getMetadataTableName($type));
+        $types = ['resource', 'room'];
+        foreach ($types as $type) {
+            if (!$schema->hasTable($this->getMetadataTableName($type))) {
+                $table = $schema->createTable($this->getMetadataTableName($type));
 
-				$table->addColumn('id', Types::BIGINT, [
-					'autoincrement' => true,
-					'notnull' => true,
-					'length' => 11,
-					'unsigned' => true,
-				]);
-				$table->addColumn($type . '_id', Types::BIGINT, [
-					'notnull' => true,
-					'length' => 11,
-					'unsigned' => true,
-				]);
-				$table->addColumn('key', Types::STRING, [
-					'notnull' => true,
-					'length' => 255,
-				]);
-				$table->addColumn('value', Types::STRING, [
-					'notnull' => false,
-					'length' => 4000,
-				]);
+                $table->addColumn('id', Types::BIGINT, [
+                    'autoincrement' => true,
+                    'notnull' => true,
+                    'length' => 11,
+                    'unsigned' => true,
+                ]);
+                $table->addColumn($type . '_id', Types::BIGINT, [
+                    'notnull' => true,
+                    'length' => 11,
+                    'unsigned' => true,
+                ]);
+                $table->addColumn('key', Types::STRING, [
+                    'notnull' => true,
+                    'length' => 255,
+                ]);
+                $table->addColumn('value', Types::STRING, [
+                    'notnull' => false,
+                    'length' => 4000,
+                ]);
 
-				$table->setPrimaryKey(['id']);
-				$table->addIndex([$type . '_id', 'key'], $this->getMetadataTableName($type) . '_idk');
-			}
-		}
+                $table->setPrimaryKey(['id']);
+                $table->addIndex([$type . '_id', 'key'], $this->getMetadataTableName($type) . '_idk');
+            }
+        }
 
-		return $schema;
-	}
+        return $schema;
+    }
 
-	/**
-	 * @param string $type
-	 * @return string
-	 */
-	private function getMetadataTableName(string $type):string {
-		return 'calendar_' . $type . 's_md';
-	}
+    /**
+     * @param string $type
+     * @return string
+     */
+    private function getMetadataTableName(string $type):string {
+        return 'calendar_' . $type . 's_md';
+    }
 }

Please login to merge, or discard this patch.

apps/sharebymail/lib/AppInfo/Application.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -35,16 +35,16 @@
 block discarded – undo
 use OCP\AppFramework\Bootstrap\IRegistrationContext;
 
 class Application extends App implements IBootstrap {
-	public const APP_ID = 'sharebymail';
+    public const APP_ID = 'sharebymail';
 
-	public function __construct() {
-		parent::__construct(self::APP_ID);
-	}
+    public function __construct() {
+        parent::__construct(self::APP_ID);
+    }
 
-	public function register(IRegistrationContext $context): void {
-		$context->registerCapability(Capabilities::class);
-	}
+    public function register(IRegistrationContext $context): void {
+        $context->registerCapability(Capabilities::class);
+    }
 
-	public function boot(IBootContext $context): void {
-	}
+    public function boot(IBootContext $context): void {
+    }
 }

Please login to merge, or discard this patch.

apps/federation/lib/Migration/Version1010Date20200630191302.php 1 patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -33,51 +33,51 @@
 block discarded – undo
 
 class Version1010Date20200630191302 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		if (!$schema->hasTable('trusted_servers')) {
-			$table = $schema->createTable('trusted_servers');
-			$table->addColumn('id', Types::INTEGER, [
-				'autoincrement' => true,
-				'notnull' => true,
-				'length' => 4,
-			]);
-			$table->addColumn('url', Types::STRING, [
-				'notnull' => true,
-				'length' => 512,
-			]);
-			$table->addColumn('url_hash', Types::STRING, [
-				'notnull' => true,
-				'default' => '',
-			]);
-			$table->addColumn('token', Types::STRING, [
-				'notnull' => false,
-				'length' => 128,
-			]);
-			$table->addColumn('shared_secret', Types::STRING, [
-				'notnull' => false,
-				'length' => 256,
-			]);
-			$table->addColumn('status', Types::INTEGER, [
-				'notnull' => true,
-				'length' => 4,
-				'default' => 2,
-			]);
-			$table->addColumn('sync_token', Types::STRING, [
-				'notnull' => false,
-				'length' => 512,
-			]);
-			$table->setPrimaryKey(['id']);
-			$table->addUniqueIndex(['url_hash'], 'url_hash');
-		}
-		return $schema;
-	}
+        if (!$schema->hasTable('trusted_servers')) {
+            $table = $schema->createTable('trusted_servers');
+            $table->addColumn('id', Types::INTEGER, [
+                'autoincrement' => true,
+                'notnull' => true,
+                'length' => 4,
+            ]);
+            $table->addColumn('url', Types::STRING, [
+                'notnull' => true,
+                'length' => 512,
+            ]);
+            $table->addColumn('url_hash', Types::STRING, [
+                'notnull' => true,
+                'default' => '',
+            ]);
+            $table->addColumn('token', Types::STRING, [
+                'notnull' => false,
+                'length' => 128,
+            ]);
+            $table->addColumn('shared_secret', Types::STRING, [
+                'notnull' => false,
+                'length' => 256,
+            ]);
+            $table->addColumn('status', Types::INTEGER, [
+                'notnull' => true,
+                'length' => 4,
+                'default' => 2,
+            ]);
+            $table->addColumn('sync_token', Types::STRING, [
+                'notnull' => false,
+                'length' => 512,
+            ]);
+            $table->setPrimaryKey(['id']);
+            $table->addUniqueIndex(['url_hash'], 'url_hash');
+        }
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/contactsinteraction/lib/AppInfo/Application.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -33,16 +33,16 @@
 block discarded – undo
 use OCP\Contacts\Events\ContactInteractedWithEvent;
 
 class Application extends App implements IBootstrap {
-	public const APP_ID = 'contactsinteraction';
+    public const APP_ID = 'contactsinteraction';
 
-	public function __construct() {
-		parent::__construct(self::APP_ID);
-	}
+    public function __construct() {
+        parent::__construct(self::APP_ID);
+    }
 
-	public function register(IRegistrationContext $context): void {
-		$context->registerEventListener(ContactInteractedWithEvent::class, ContactInteractionListener::class);
-	}
+    public function register(IRegistrationContext $context): void {
+        $context->registerEventListener(ContactInteractedWithEvent::class, ContactInteractionListener::class);
+    }
 
-	public function boot(IBootContext $context): void {
-	}
+    public function boot(IBootContext $context): void {
+    }
 }

Please login to merge, or discard this patch.

apps/cloud_federation_api/lib/AppInfo/Application.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -33,16 +33,16 @@
 block discarded – undo
 use OCP\AppFramework\Bootstrap\IRegistrationContext;
 
 class Application extends App implements IBootstrap {
-	public const APP_ID = 'cloud_federation_api';
+    public const APP_ID = 'cloud_federation_api';
 
-	public function __construct() {
-		parent::__construct(self::APP_ID);
-	}
+    public function __construct() {
+        parent::__construct(self::APP_ID);
+    }
 
-	public function register(IRegistrationContext $context): void {
-		$context->registerCapability(Capabilities::class);
-	}
+    public function register(IRegistrationContext $context): void {
+        $context->registerCapability(Capabilities::class);
+    }
 
-	public function boot(IBootContext $context): void {
-	}
+    public function boot(IBootContext $context): void {
+    }
 }

Please login to merge, or discard this patch.

lib/public/User/Backend/ICustomLogout.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -32,12 +32,12 @@
 block discarded – undo
  * SSO providers that also have a SSO logout url
  */
 interface ICustomLogout {
-	/**
-	 * @since 20.0.0
-	 *
-	 * The url to redirect to for logout
-	 *
-	 * @return string
-	 */
-	public function getLogoutUrl(): string;
+    /**
+     * @since 20.0.0
+     *
+     * The url to redirect to for logout
+     *
+     * @return string
+     */
+    public function getLogoutUrl(): string;
 }

Please login to merge, or discard this patch.

lib/public/Files/Config/IRootMountProvider.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -31,11 +31,11 @@
 block discarded – undo
  * @since 20.0.0
  */
 interface IRootMountProvider {
-	/**
-	 * Get all root mountpoints of this provider
-	 *
-	 * @return \OCP\Files\Mount\IMountPoint[]
-	 * @since 20.0.0
-	 */
-	public function getRootMounts(IStorageFactory $loader): array;
+    /**
+     * Get all root mountpoints of this provider
+     *
+     * @return \OCP\Files\Mount\IMountPoint[]
+     * @since 20.0.0
+     */
+    public function getRootMounts(IStorageFactory $loader): array;
 }

Please login to merge, or discard this patch.

lib/public/WorkflowEngine/IRuleMatcher.php 1 patch

Indentation +47 added lines, -47 removed lines patch added patch discarded remove patch

@@ -36,56 +36,56 @@
 block discarded – undo
  * @since 18.0.0
  */
 interface IRuleMatcher extends IFileCheck {
-	/**
-	 * This method is left for backwards compatibility and easier porting of
-	 * apps. Please use 'getFlows' instead (and setOperation if you implement
-	 * an IComplexOperation).
-	 *
-	 * @since 18.0.0
-	 * @deprecated 18.0.0
-	 */
-	public function getMatchingOperations(string $class, bool $returnFirstMatchingOperationOnly = true): array;
+    /**
+     * This method is left for backwards compatibility and easier porting of
+     * apps. Please use 'getFlows' instead (and setOperation if you implement
+     * an IComplexOperation).
+     *
+     * @since 18.0.0
+     * @deprecated 18.0.0
+     */
+    public function getMatchingOperations(string $class, bool $returnFirstMatchingOperationOnly = true): array;
 
-	/**
-	 * @throws RuntimeException
-	 * @since 18.0.0
-	 */
-	public function getFlows(bool $returnFirstMatchingOperationOnly = true): array;
+    /**
+     * @throws RuntimeException
+     * @since 18.0.0
+     */
+    public function getFlows(bool $returnFirstMatchingOperationOnly = true): array;
 
-	/**
-	 * this method can only be called once and is typically called by the
-	 * Flow engine, unless for IComplexOperations.
-	 *
-	 * @throws RuntimeException
-	 * @since 18.0.0
-	 */
-	public function setOperation(IOperation $operation): void;
+    /**
+     * this method can only be called once and is typically called by the
+     * Flow engine, unless for IComplexOperations.
+     *
+     * @throws RuntimeException
+     * @since 18.0.0
+     */
+    public function setOperation(IOperation $operation): void;
 
-	/**
-	 * this method can only be called once and is typically called by the
-	 * Flow engine, unless for IComplexOperations.
-	 *
-	 * @throws RuntimeException
-	 * @since 18.0.0
-	 */
-	public function setEntity(IEntity $entity): void;
+    /**
+     * this method can only be called once and is typically called by the
+     * Flow engine, unless for IComplexOperations.
+     *
+     * @throws RuntimeException
+     * @since 18.0.0
+     */
+    public function setEntity(IEntity $entity): void;
 
-	/**
-	 * returns the entity which might provide more information, depending on
-	 * the interfaces it implements
-	 *
-	 * @return IEntity
-	 * @since 18.0.0
-	 */
-	public function getEntity(): IEntity;
+    /**
+     * returns the entity which might provide more information, depending on
+     * the interfaces it implements
+     *
+     * @return IEntity
+     * @since 18.0.0
+     */
+    public function getEntity(): IEntity;
 
-	/**
-	 * this method can be called once to set the event name that is currently
-	 * being processed. The workflow engine takes care of this usually, only an
-	 * IComplexOperation might want to make use of it.
-	 *
-	 * @throws RuntimeException
-	 * @since 20.0.0
-	 */
-	public function setEventName(string $eventName): void;
+    /**
+     * this method can be called once to set the event name that is currently
+     * being processed. The workflow engine takes care of this usually, only an
+     * IComplexOperation might want to make use of it.
+     *
+     * @throws RuntimeException
+     * @since 20.0.0
+     */
+    public function setEventName(string $eventName): void;
 }

Please login to merge, or discard this patch.

		@@ -33,56 +33,56 @@
		block discarded – undo
33	33
34	34	class Version1005Date20180530124431 extends SimpleMigrationStep {
35	35
36		- /**
37		- * @param IOutput $output
38		- * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
39		- * @param array $options
40		- * @return null\|ISchemaWrapper
41		- * @since 13.0.0
42		- */
43		- public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
44		- /** @var ISchemaWrapper $schema */
45		- $schema = $schemaClosure();
	36	+ /**
	37	+ * @param IOutput $output
	38	+ * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	39	+ * @param array $options
	40	+ * @return null\|ISchemaWrapper
	41	+ * @since 13.0.0
	42	+ */
	43	+ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
	44	+ /** @var ISchemaWrapper $schema */
	45	+ $schema = $schemaClosure();
46	46
47		- $types = ['resources', 'rooms'];
48		- foreach ($types as $type) {
49		- if (!$schema->hasTable('calendar_' . $type)) {
50		- $table = $schema->createTable('calendar_' . $type);
	47	+ $types = ['resources', 'rooms'];
	48	+ foreach ($types as $type) {
	49	+ if (!$schema->hasTable('calendar_' . $type)) {
	50	+ $table = $schema->createTable('calendar_' . $type);
51	51
52		- $table->addColumn('id', Types::BIGINT, [
53		- 'autoincrement' => true,
54		- 'notnull' => true,
55		- 'length' => 11,
56		- 'unsigned' => true,
57		- ]);
58		- $table->addColumn('backend_id', Types::STRING, [
59		- 'notnull' => false,
60		- 'length' => 64,
61		- ]);
62		- $table->addColumn('resource_id', Types::STRING, [
63		- 'notnull' => false,
64		- 'length' => 64,
65		- ]);
66		- $table->addColumn('email', Types::STRING, [
67		- 'notnull' => false,
68		- 'length' => 255,
69		- ]);
70		- $table->addColumn('displayname', Types::STRING, [
71		- 'notnull' => false,
72		- 'length' => 255,
73		- ]);
74		- $table->addColumn('group_restrictions', Types::STRING, [
75		- 'notnull' => false,
76		- 'length' => 4000,
77		- ]);
	52	+ $table->addColumn('id', Types::BIGINT, [
	53	+ 'autoincrement' => true,
	54	+ 'notnull' => true,
	55	+ 'length' => 11,
	56	+ 'unsigned' => true,
	57	+ ]);
	58	+ $table->addColumn('backend_id', Types::STRING, [
	59	+ 'notnull' => false,
	60	+ 'length' => 64,
	61	+ ]);
	62	+ $table->addColumn('resource_id', Types::STRING, [
	63	+ 'notnull' => false,
	64	+ 'length' => 64,
	65	+ ]);
	66	+ $table->addColumn('email', Types::STRING, [
	67	+ 'notnull' => false,
	68	+ 'length' => 255,
	69	+ ]);
	70	+ $table->addColumn('displayname', Types::STRING, [
	71	+ 'notnull' => false,
	72	+ 'length' => 255,
	73	+ ]);
	74	+ $table->addColumn('group_restrictions', Types::STRING, [
	75	+ 'notnull' => false,
	76	+ 'length' => 4000,
	77	+ ]);
78	78
79		- $table->setPrimaryKey(['id']);
80		- $table->addIndex(['backend_id', 'resource_id'], 'calendar_' . $type . '_bkdrsc');
81		- $table->addIndex(['email'], 'calendar_' . $type . '_email');
82		- $table->addIndex(['displayname'], 'calendar_' . $type . '_name');
83		- }
84		- }
	79	+ $table->setPrimaryKey(['id']);
	80	+ $table->addIndex(['backend_id', 'resource_id'], 'calendar_' . $type . '_bkdrsc');
	81	+ $table->addIndex(['email'], 'calendar_' . $type . '_email');
	82	+ $table->addIndex(['displayname'], 'calendar_' . $type . '_name');
	83	+ }
	84	+ }
85	85
86		- return $schema;
87		- }
	86	+ return $schema;
	87	+ }
88	88	}

		@@ -37,55 +37,55 @@
		block discarded – undo
37	37	*/
38	38	class Version1011Date20190725113607 extends SimpleMigrationStep {
39	39
40		- /**
41		- * @param IOutput $output
42		- * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
43		- * @param array $options
44		- * @return null\|ISchemaWrapper
45		- * @since 13.0.0
46		- */
47		- public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
48		- /** @var ISchemaWrapper $schema */
49		- $schema = $schemaClosure();
	40	+ /**
	41	+ * @param IOutput $output
	42	+ * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	43	+ * @param array $options
	44	+ * @return null\|ISchemaWrapper
	45	+ * @since 13.0.0
	46	+ */
	47	+ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
	48	+ /** @var ISchemaWrapper $schema */
	49	+ $schema = $schemaClosure();
50	50
51		- $types = ['resource', 'room'];
52		- foreach ($types as $type) {
53		- if (!$schema->hasTable($this->getMetadataTableName($type))) {
54		- $table = $schema->createTable($this->getMetadataTableName($type));
	51	+ $types = ['resource', 'room'];
	52	+ foreach ($types as $type) {
	53	+ if (!$schema->hasTable($this->getMetadataTableName($type))) {
	54	+ $table = $schema->createTable($this->getMetadataTableName($type));
55	55
56		- $table->addColumn('id', Types::BIGINT, [
57		- 'autoincrement' => true,
58		- 'notnull' => true,
59		- 'length' => 11,
60		- 'unsigned' => true,
61		- ]);
62		- $table->addColumn($type . '_id', Types::BIGINT, [
63		- 'notnull' => true,
64		- 'length' => 11,
65		- 'unsigned' => true,
66		- ]);
67		- $table->addColumn('key', Types::STRING, [
68		- 'notnull' => true,
69		- 'length' => 255,
70		- ]);
71		- $table->addColumn('value', Types::STRING, [
72		- 'notnull' => false,
73		- 'length' => 4000,
74		- ]);
	56	+ $table->addColumn('id', Types::BIGINT, [
	57	+ 'autoincrement' => true,
	58	+ 'notnull' => true,
	59	+ 'length' => 11,
	60	+ 'unsigned' => true,
	61	+ ]);
	62	+ $table->addColumn($type . '_id', Types::BIGINT, [
	63	+ 'notnull' => true,
	64	+ 'length' => 11,
	65	+ 'unsigned' => true,
	66	+ ]);
	67	+ $table->addColumn('key', Types::STRING, [
	68	+ 'notnull' => true,
	69	+ 'length' => 255,
	70	+ ]);
	71	+ $table->addColumn('value', Types::STRING, [
	72	+ 'notnull' => false,
	73	+ 'length' => 4000,
	74	+ ]);
75	75
76		- $table->setPrimaryKey(['id']);
77		- $table->addIndex([$type . '_id', 'key'], $this->getMetadataTableName($type) . '_idk');
78		- }
79		- }
	76	+ $table->setPrimaryKey(['id']);
	77	+ $table->addIndex([$type . '_id', 'key'], $this->getMetadataTableName($type) . '_idk');
	78	+ }
	79	+ }
80	80
81		- return $schema;
82		- }
	81	+ return $schema;
	82	+ }
83	83
84		- /**
85		- * @param string $type
86		- * @return string
87		- */
88		- private function getMetadataTableName(string $type):string {
89		- return 'calendar_' . $type . 's_md';
90		- }
	84	+ /**
	85	+ * @param string $type
	86	+ * @return string
	87	+ */
	88	+ private function getMetadataTableName(string $type):string {
	89	+ return 'calendar_' . $type . 's_md';
	90	+ }
91	91	}

		@@ -35,16 +35,16 @@
		block discarded – undo
35	35	use OCP\AppFramework\Bootstrap\IRegistrationContext;
36	36
37	37	class Application extends App implements IBootstrap {
38		- public const APP_ID = 'sharebymail';
	38	+ public const APP_ID = 'sharebymail';
39	39
40		- public function __construct() {
41		- parent::__construct(self::APP_ID);
42		- }
	40	+ public function __construct() {
	41	+ parent::__construct(self::APP_ID);
	42	+ }
43	43
44		- public function register(IRegistrationContext $context): void {
45		- $context->registerCapability(Capabilities::class);
46		- }
	44	+ public function register(IRegistrationContext $context): void {
	45	+ $context->registerCapability(Capabilities::class);
	46	+ }
47	47
48		- public function boot(IBootContext $context): void {
49		- }
	48	+ public function boot(IBootContext $context): void {
	49	+ }
50	50	}

		@@ -33,51 +33,51 @@
		block discarded – undo
33	33
34	34	class Version1010Date20200630191302 extends SimpleMigrationStep {
35	35
36		- /**
37		- * @param IOutput $output
38		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
39		- * @param array $options
40		- * @return null\|ISchemaWrapper
41		- */
42		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
43		- /** @var ISchemaWrapper $schema */
44		- $schema = $schemaClosure();
	36	+ /**
	37	+ * @param IOutput $output
	38	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	39	+ * @param array $options
	40	+ * @return null\|ISchemaWrapper
	41	+ */
	42	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	43	+ /** @var ISchemaWrapper $schema */
	44	+ $schema = $schemaClosure();
45	45
46		- if (!$schema->hasTable('trusted_servers')) {
47		- $table = $schema->createTable('trusted_servers');
48		- $table->addColumn('id', Types::INTEGER, [
49		- 'autoincrement' => true,
50		- 'notnull' => true,
51		- 'length' => 4,
52		- ]);
53		- $table->addColumn('url', Types::STRING, [
54		- 'notnull' => true,
55		- 'length' => 512,
56		- ]);
57		- $table->addColumn('url_hash', Types::STRING, [
58		- 'notnull' => true,
59		- 'default' => '',
60		- ]);
61		- $table->addColumn('token', Types::STRING, [
62		- 'notnull' => false,
63		- 'length' => 128,
64		- ]);
65		- $table->addColumn('shared_secret', Types::STRING, [
66		- 'notnull' => false,
67		- 'length' => 256,
68		- ]);
69		- $table->addColumn('status', Types::INTEGER, [
70		- 'notnull' => true,
71		- 'length' => 4,
72		- 'default' => 2,
73		- ]);
74		- $table->addColumn('sync_token', Types::STRING, [
75		- 'notnull' => false,
76		- 'length' => 512,
77		- ]);
78		- $table->setPrimaryKey(['id']);
79		- $table->addUniqueIndex(['url_hash'], 'url_hash');
80		- }
81		- return $schema;
82		- }
	46	+ if (!$schema->hasTable('trusted_servers')) {
	47	+ $table = $schema->createTable('trusted_servers');
	48	+ $table->addColumn('id', Types::INTEGER, [
	49	+ 'autoincrement' => true,
	50	+ 'notnull' => true,
	51	+ 'length' => 4,
	52	+ ]);
	53	+ $table->addColumn('url', Types::STRING, [
	54	+ 'notnull' => true,
	55	+ 'length' => 512,
	56	+ ]);
	57	+ $table->addColumn('url_hash', Types::STRING, [
	58	+ 'notnull' => true,
	59	+ 'default' => '',
	60	+ ]);
	61	+ $table->addColumn('token', Types::STRING, [
	62	+ 'notnull' => false,
	63	+ 'length' => 128,
	64	+ ]);
	65	+ $table->addColumn('shared_secret', Types::STRING, [
	66	+ 'notnull' => false,
	67	+ 'length' => 256,
	68	+ ]);
	69	+ $table->addColumn('status', Types::INTEGER, [
	70	+ 'notnull' => true,
	71	+ 'length' => 4,
	72	+ 'default' => 2,
	73	+ ]);
	74	+ $table->addColumn('sync_token', Types::STRING, [
	75	+ 'notnull' => false,
	76	+ 'length' => 512,
	77	+ ]);
	78	+ $table->setPrimaryKey(['id']);
	79	+ $table->addUniqueIndex(['url_hash'], 'url_hash');
	80	+ }
	81	+ return $schema;
	82	+ }
83	83	}

		@@ -33,16 +33,16 @@
		block discarded – undo
33	33	use OCP\Contacts\Events\ContactInteractedWithEvent;
34	34
35	35	class Application extends App implements IBootstrap {
36		- public const APP_ID = 'contactsinteraction';
	36	+ public const APP_ID = 'contactsinteraction';
37	37
38		- public function __construct() {
39		- parent::__construct(self::APP_ID);
40		- }
	38	+ public function __construct() {
	39	+ parent::__construct(self::APP_ID);
	40	+ }
41	41
42		- public function register(IRegistrationContext $context): void {
43		- $context->registerEventListener(ContactInteractedWithEvent::class, ContactInteractionListener::class);
44		- }
	42	+ public function register(IRegistrationContext $context): void {
	43	+ $context->registerEventListener(ContactInteractedWithEvent::class, ContactInteractionListener::class);
	44	+ }
45	45
46		- public function boot(IBootContext $context): void {
47		- }
	46	+ public function boot(IBootContext $context): void {
	47	+ }
48	48	}

		@@ -32,12 +32,12 @@
		block discarded – undo
32	32	* SSO providers that also have a SSO logout url
33	33	*/
34	34	interface ICustomLogout {
35		- /**
36		- * @since 20.0.0
37		- *
38		- * The url to redirect to for logout
39		- *
40		- * @return string
41		- */
42		- public function getLogoutUrl(): string;
	35	+ /**
	36	+ * @since 20.0.0
	37	+ *
	38	+ * The url to redirect to for logout
	39	+ *
	40	+ * @return string
	41	+ */
	42	+ public function getLogoutUrl(): string;
43	43	}

		@@ -31,11 +31,11 @@
		block discarded – undo
31	31	* @since 20.0.0
32	32	*/
33	33	interface IRootMountProvider {
34		- /**
35		- * Get all root mountpoints of this provider
36		- *
37		- * @return \OCP\Files\Mount\IMountPoint[]
38		- * @since 20.0.0
39		- */
40		- public function getRootMounts(IStorageFactory $loader): array;
	34	+ /**
	35	+ * Get all root mountpoints of this provider
	36	+ *
	37	+ * @return \OCP\Files\Mount\IMountPoint[]
	38	+ * @since 20.0.0
	39	+ */
	40	+ public function getRootMounts(IStorageFactory $loader): array;
41	41	}

		@@ -36,56 +36,56 @@
		block discarded – undo
36	36	* @since 18.0.0
37	37	*/
38	38	interface IRuleMatcher extends IFileCheck {
39		- /**
40		- * This method is left for backwards compatibility and easier porting of
41		- * apps. Please use 'getFlows' instead (and setOperation if you implement
42		- * an IComplexOperation).
43		- *
44		- * @since 18.0.0
45		- * @deprecated 18.0.0
46		- */
47		- public function getMatchingOperations(string $class, bool $returnFirstMatchingOperationOnly = true): array;
	39	+ /**
	40	+ * This method is left for backwards compatibility and easier porting of
	41	+ * apps. Please use 'getFlows' instead (and setOperation if you implement
	42	+ * an IComplexOperation).
	43	+ *
	44	+ * @since 18.0.0
	45	+ * @deprecated 18.0.0
	46	+ */
	47	+ public function getMatchingOperations(string $class, bool $returnFirstMatchingOperationOnly = true): array;
48	48
49		- /**
50		- * @throws RuntimeException
51		- * @since 18.0.0
52		- */
53		- public function getFlows(bool $returnFirstMatchingOperationOnly = true): array;
	49	+ /**
	50	+ * @throws RuntimeException
	51	+ * @since 18.0.0
	52	+ */
	53	+ public function getFlows(bool $returnFirstMatchingOperationOnly = true): array;
54	54
55		- /**
56		- * this method can only be called once and is typically called by the
57		- * Flow engine, unless for IComplexOperations.
58		- *
59		- * @throws RuntimeException
60		- * @since 18.0.0
61		- */
62		- public function setOperation(IOperation $operation): void;
	55	+ /**
	56	+ * this method can only be called once and is typically called by the
	57	+ * Flow engine, unless for IComplexOperations.
	58	+ *
	59	+ * @throws RuntimeException
	60	+ * @since 18.0.0
	61	+ */
	62	+ public function setOperation(IOperation $operation): void;
63	63
64		- /**
65		- * this method can only be called once and is typically called by the
66		- * Flow engine, unless for IComplexOperations.
67		- *
68		- * @throws RuntimeException
69		- * @since 18.0.0
70		- */
71		- public function setEntity(IEntity $entity): void;
	64	+ /**
	65	+ * this method can only be called once and is typically called by the
	66	+ * Flow engine, unless for IComplexOperations.
	67	+ *
	68	+ * @throws RuntimeException
	69	+ * @since 18.0.0
	70	+ */
	71	+ public function setEntity(IEntity $entity): void;
72	72
73		- /**
74		- * returns the entity which might provide more information, depending on
75		- * the interfaces it implements
76		- *
77		- * @return IEntity
78		- * @since 18.0.0
79		- */
80		- public function getEntity(): IEntity;
	73	+ /**
	74	+ * returns the entity which might provide more information, depending on
	75	+ * the interfaces it implements
	76	+ *
	77	+ * @return IEntity
	78	+ * @since 18.0.0
	79	+ */
	80	+ public function getEntity(): IEntity;
81	81
82		- /**
83		- * this method can be called once to set the event name that is currently
84		- * being processed. The workflow engine takes care of this usually, only an
85		- * IComplexOperation might want to make use of it.
86		- *
87		- * @throws RuntimeException
88		- * @since 20.0.0
89		- */
90		- public function setEventName(string $eventName): void;
	82	+ /**
	83	+ * this method can be called once to set the event name that is currently
	84	+ * being processed. The workflow engine takes care of this usually, only an
	85	+ * IComplexOperation might want to make use of it.
	86	+ *
	87	+ * @throws RuntimeException
	88	+ * @since 20.0.0
	89	+ */
	90	+ public function setEventName(string $eventName): void;
91	91	}

nextcloud / server

Push — master ( 672e4f...e22914 )

Status

Category

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +47 added lines, -47 removed lines patch added patch discarded remove patch