nextcloud / server

apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php

Indentation +45 added lines, -45 removed lines

@@ -28,54 +28,54 @@
 use OCP\Http\Client\IClientService;
 
 class RetryJob extends Job {
-	/** @var IClientService */
-	private $clientService;
-	/** @var IJobList */
-	private $jobList;
-	/** @var string */
-	private $lookupServer = 'https://lookup.nextcloud.com/users';
+    /** @var IClientService */
+    private $clientService;
+    /** @var IJobList */
+    private $jobList;
+    /** @var string */
+    private $lookupServer = 'https://lookup.nextcloud.com/users';
 
-	/**
-	 * @param IClientService|null $clientService
-	 * @param IJobList|null $jobList
-	 */
-	public function __construct(IClientService $clientService = null,
-								IJobList $jobList = null) {
-		if($clientService !== null) {
-			$this->clientService = $clientService;
-		} else {
-			$this->clientService = \OC::$server->getHTTPClientService();
-		}
-		if($jobList !== null) {
-			$this->jobList = $jobList;
-		} else {
-			$this->jobList = \OC::$server->getJobList();
-		}
-	}
+    /**
+     * @param IClientService|null $clientService
+     * @param IJobList|null $jobList
+     */
+    public function __construct(IClientService $clientService = null,
+                                IJobList $jobList = null) {
+        if($clientService !== null) {
+            $this->clientService = $clientService;
+        } else {
+            $this->clientService = \OC::$server->getHTTPClientService();
+        }
+        if($jobList !== null) {
+            $this->jobList = $jobList;
+        } else {
+            $this->jobList = \OC::$server->getJobList();
+        }
+    }
 
-	protected function run($argument) {
-		if($argument['retryNo'] === 5) {
-			return;
-		}
+    protected function run($argument) {
+        if($argument['retryNo'] === 5) {
+            return;
+        }
 
-		$client = $this->clientService->newClient();
+        $client = $this->clientService->newClient();
 
-		try {
-			$client->post($this->lookupServer,
-				[
-					'body' => json_encode($argument['dataArray']),
-					'timeout' => 10,
-					'connect_timeout' => 3,
-				]
-			);
-		} catch (\Exception $e) {
-			$this->jobList->add(RetryJob::class,
-				[
-					'dataArray' => $argument['dataArray'],
-					'retryNo' => $argument['retryNo'] + 1,
-				]
-			);
+        try {
+            $client->post($this->lookupServer,
+                [
+                    'body' => json_encode($argument['dataArray']),
+                    'timeout' => 10,
+                    'connect_timeout' => 3,
+                ]
+            );
+        } catch (\Exception $e) {
+            $this->jobList->add(RetryJob::class,
+                [
+                    'dataArray' => $argument['dataArray'],
+                    'retryNo' => $argument['retryNo'] + 1,
+                ]
+            );
 
-		}
-	}
+        }
+    }
 }

apps/lookup_server_connector/appinfo/app.php

Indentation +19 added lines, -19 removed lines

@@ -22,24 +22,24 @@
 $dispatcher = \OC::$server->getEventDispatcher();
 
 $dispatcher->addListener('OC\AccountManager::userUpdated', function(\Symfony\Component\EventDispatcher\GenericEvent $event) {
-	$user = $event->getSubject();
+    $user = $event->getSubject();
 
-	$keyManager = new \OC\Security\IdentityProof\Manager(
-		\OC::$server->getAppDataDir('identityproof'),
-		\OC::$server->getCrypto()
-	);
-	$updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
-		new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
-		\OC::$server->getConfig(),
-		\OC::$server->getSecureRandom(),
-		\OC::$server->getHTTPClientService(),
-		$keyManager,
-		new \OC\Security\IdentityProof\Signer(
-			$keyManager,
-			new \OC\AppFramework\Utility\TimeFactory(),
-			\OC::$server->getUserManager()
-		),
-		\OC::$server->getJobList()
-	);
-	$updateLookupServer->userUpdated($user);
+    $keyManager = new \OC\Security\IdentityProof\Manager(
+        \OC::$server->getAppDataDir('identityproof'),
+        \OC::$server->getCrypto()
+    );
+    $updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
+        new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
+        \OC::$server->getConfig(),
+        \OC::$server->getSecureRandom(),
+        \OC::$server->getHTTPClientService(),
+        $keyManager,
+        new \OC\Security\IdentityProof\Signer(
+            $keyManager,
+            new \OC\AppFramework\Utility\TimeFactory(),
+            \OC::$server->getUserManager()
+        ),
+        \OC::$server->getJobList()
+    );
+    $updateLookupServer->userUpdated($user);
 });

apps/user_ldap/templates/settings.php

Indentation +46 added lines, -46 removed lines

@@ -5,46 +5,46 @@ 
 vendor_style('user_ldap', 'ui-multiselect/jquery.multiselect');
 
 script('user_ldap', [
-	'wizard/controller',
-	'wizard/configModel',
-	'wizard/view',
-	'wizard/wizardObject',
-	'wizard/wizardTabGeneric',
-	'wizard/wizardTabElementary',
-	'wizard/wizardTabAbstractFilter',
-	'wizard/wizardTabUserFilter',
-	'wizard/wizardTabLoginFilter',
-	'wizard/wizardTabGroupFilter',
-	'wizard/wizardTabAdvanced',
-	'wizard/wizardTabExpert',
-	'wizard/wizardDetectorQueue',
-	'wizard/wizardDetectorGeneric',
-	'wizard/wizardDetectorPort',
-	'wizard/wizardDetectorBaseDN',
-	'wizard/wizardDetectorFeatureAbstract',
-	'wizard/wizardDetectorUserObjectClasses',
-	'wizard/wizardDetectorGroupObjectClasses',
-	'wizard/wizardDetectorGroupsForUsers',
-	'wizard/wizardDetectorGroupsForGroups',
-	'wizard/wizardDetectorSimpleRequestAbstract',
-	'wizard/wizardDetectorFilterUser',
-	'wizard/wizardDetectorFilterLogin',
-	'wizard/wizardDetectorFilterGroup',
-	'wizard/wizardDetectorUserCount',
-	'wizard/wizardDetectorGroupCount',
-	'wizard/wizardDetectorEmailAttribute',
-	'wizard/wizardDetectorUserDisplayNameAttribute',
-	'wizard/wizardDetectorUserGroupAssociation',
-	'wizard/wizardDetectorAvailableAttributes',
-	'wizard/wizardDetectorTestAbstract',
-	'wizard/wizardDetectorTestLoginName',
-	'wizard/wizardDetectorTestBaseDN',
-	'wizard/wizardDetectorTestConfiguration',
-	'wizard/wizardDetectorClearUserMappings',
-	'wizard/wizardDetectorClearGroupMappings',
-	'wizard/wizardFilterOnType',
-	'wizard/wizardFilterOnTypeFactory',
-	'wizard/wizard'
+    'wizard/controller',
+    'wizard/configModel',
+    'wizard/view',
+    'wizard/wizardObject',
+    'wizard/wizardTabGeneric',
+    'wizard/wizardTabElementary',
+    'wizard/wizardTabAbstractFilter',
+    'wizard/wizardTabUserFilter',
+    'wizard/wizardTabLoginFilter',
+    'wizard/wizardTabGroupFilter',
+    'wizard/wizardTabAdvanced',
+    'wizard/wizardTabExpert',
+    'wizard/wizardDetectorQueue',
+    'wizard/wizardDetectorGeneric',
+    'wizard/wizardDetectorPort',
+    'wizard/wizardDetectorBaseDN',
+    'wizard/wizardDetectorFeatureAbstract',
+    'wizard/wizardDetectorUserObjectClasses',
+    'wizard/wizardDetectorGroupObjectClasses',
+    'wizard/wizardDetectorGroupsForUsers',
+    'wizard/wizardDetectorGroupsForGroups',
+    'wizard/wizardDetectorSimpleRequestAbstract',
+    'wizard/wizardDetectorFilterUser',
+    'wizard/wizardDetectorFilterLogin',
+    'wizard/wizardDetectorFilterGroup',
+    'wizard/wizardDetectorUserCount',
+    'wizard/wizardDetectorGroupCount',
+    'wizard/wizardDetectorEmailAttribute',
+    'wizard/wizardDetectorUserDisplayNameAttribute',
+    'wizard/wizardDetectorUserGroupAssociation',
+    'wizard/wizardDetectorAvailableAttributes',
+    'wizard/wizardDetectorTestAbstract',
+    'wizard/wizardDetectorTestLoginName',
+    'wizard/wizardDetectorTestBaseDN',
+    'wizard/wizardDetectorTestConfiguration',
+    'wizard/wizardDetectorClearUserMappings',
+    'wizard/wizardDetectorClearGroupMappings',
+    'wizard/wizardFilterOnType',
+    'wizard/wizardFilterOnTypeFactory',
+    'wizard/wizard'
 ]);
 
 style('user_ldap', 'settings');
@@ -67,12 +67,12 @@ 
 		<li class="ldapSettingsTabs"><a href="#ldapSettings-1"><?php p($l->t('Advanced'));?></a></li>
 	</ul>
 	<?php if(OCP\App::isEnabled('user_webdavauth')) {
-		print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> Apps user_ldap and user_webdavauth are incompatible. You may experience unexpected behavior. Please ask your system administrator to disable one of them.').'</p>');
-	}
-	if(!function_exists('ldap_connect')) {
-		print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> The PHP LDAP module is not installed, the backend will not work. Please ask your system administrator to install it.').'</p>');
-	}
-	?>
+        print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> Apps user_ldap and user_webdavauth are incompatible. You may experience unexpected behavior. Please ask your system administrator to disable one of them.').'</p>');
+    }
+    if(!function_exists('ldap_connect')) {
+        print_unescaped('<p class="ldapwarning">'.$l->t('<b>Warning:</b> The PHP LDAP module is not installed, the backend will not work. Please ask your system administrator to install it.').'</p>');
+    }
+    ?>
 	<?php require_once(__DIR__ . '/part.wizard-server.php'); ?>
 	<?php require_once(__DIR__ . '/part.wizard-userfilter.php'); ?>
 	<?php require_once(__DIR__ . '/part.wizard-loginfilter.php'); ?>

apps/user_ldap/templates/part.wizard-server.php

Indentation +9 added lines, -9 removed lines

@@ -9,19 +9,19 @@
 		<p>
 		<select id="ldap_serverconfig_chooser" name="ldap_serverconfig_chooser">
 		<?php if(count($_['serverConfigurationPrefixes']) === 0 ) {
-			?>
+            ?>
 				<option value="" selected><?php p($l->t('1. Server'));?></option>');
 			<?php
-		} else {
-			$i = 1;
-			$sel = ' selected';
-			foreach($_['serverConfigurationPrefixes'] as $prefix) {
-				?>
+        } else {
+            $i = 1;
+            $sel = ' selected';
+            foreach($_['serverConfigurationPrefixes'] as $prefix) {
+                ?>
 				<option value="<?php p($prefix); ?>"<?php p($sel); $sel = ''; ?>><?php p($l->t('%s. Server:', array($i++)));?> <?php p(' '.$_['serverConfigurationHosts'][$prefix]); ?></option>
 				<?php
-			}
-		}
-		?>
+            }
+        }
+        ?>
 		</select>
 		<button type="button" id="ldap_action_add_configuration"
 			name="ldap_action_add_configuration" class="icon-add icon-default-style"

apps/user_ldap/ajax/clearMappings.php

Indentation +8 added lines, -8 removed lines

@@ -34,16 +34,16 @@
 $subject = (string)$_POST['ldap_clear_mapping'];
 $mapping = null;
 if($subject === 'user') {
-	$mapping = new UserMapping(\OC::$server->getDatabaseConnection());
+    $mapping = new UserMapping(\OC::$server->getDatabaseConnection());
 } else if($subject === 'group') {
-	$mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
+    $mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
 }
 try {
-	if(is_null($mapping) || !$mapping->clear()) {
-		$l = \OC::$server->getL10N('user_ldap');
-		throw new \Exception($l->t('Failed to clear the mappings.'));
-	}
-	OCP\JSON::success();
+    if(is_null($mapping) || !$mapping->clear()) {
+        $l = \OC::$server->getL10N('user_ldap');
+        throw new \Exception($l->t('Failed to clear the mappings.'));
+    }
+    OCP\JSON::success();
 } catch (\Exception $e) {
-	OCP\JSON::error(array('message' => $e->getMessage()));
+    OCP\JSON::error(array('message' => $e->getMessage()));
 }

apps/user_ldap/ajax/testConfiguration.php

Indentation +32 added lines, -32 removed lines

@@ -37,24 +37,24 @@ 
 
 
 try {
-	$configurationOk = true;
-	$conf = $connection->getConfiguration();
-	if ($conf['ldap_configuration_active'] === '0') {
-		//needs to be true, otherwise it will also fail with an irritating message
-		$conf['ldap_configuration_active'] = '1';
-		$configurationOk = $connection->setConfiguration($conf);
-	}
-	if ($configurationOk) {
-		//Configuration is okay
-		/*
+    $configurationOk = true;
+    $conf = $connection->getConfiguration();
+    if ($conf['ldap_configuration_active'] === '0') {
+        //needs to be true, otherwise it will also fail with an irritating message
+        $conf['ldap_configuration_active'] = '1';
+        $configurationOk = $connection->setConfiguration($conf);
+    }
+    if ($configurationOk) {
+        //Configuration is okay
+        /*
 		 * Clossing the session since it won't be used from this point on. There might be a potential
 		 * race condition if a second request is made: either this request or the other might not
 		 * contact the LDAP backup server the first time when it should, but there shouldn't be any
 		 * problem with that other than the extra connection.
 		 */
-		\OC::$server->getSession()->close();
-		if ($connection->bind()) {
-			/*
+        \OC::$server->getSession()->close();
+        if ($connection->bind()) {
+            /*
 			 * This shiny if block is an ugly hack to find out whether anonymous
 			 * bind is possible on AD or not. Because AD happily and constantly
 			 * replies with success to any anonymous bind request, we need to
@@ -63,24 +63,24 @@ 
 			 * exception by the LDAP wrapper. We catch this. Other cases may
 			 * pass (like e.g. expected syntax error).
 			 */
-			try {
-				$ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
-			} catch (\Exception $e) {
-				if($e->getCode() === 1) {
-					OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
-					exit;
-				}
-			}
-			OCP\JSON::success(array('message'
-			=> $l->t('The configuration is valid and the connection could be established!')));
-		} else {
-			OCP\JSON::error(array('message'
-			=> $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
-		}
-	} else {
-		OCP\JSON::error(array('message'
-		=> $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
-	}
+            try {
+                $ldapWrapper->read($connection->getConnectionResource(), '', 'objectClass=*', array('dn'));
+            } catch (\Exception $e) {
+                if($e->getCode() === 1) {
+                    OCP\JSON::error(array('message' => $l->t('The configuration is invalid: anonymous bind is not allowed.')));
+                    exit;
+                }
+            }
+            OCP\JSON::success(array('message'
+            => $l->t('The configuration is valid and the connection could be established!')));
+        } else {
+            OCP\JSON::error(array('message'
+            => $l->t('The configuration is valid, but the Bind failed. Please check the server settings and credentials.')));
+        }
+    } else {
+        OCP\JSON::error(array('message'
+        => $l->t('The configuration is invalid. Please have a look at the logs for further details.')));
+    }
 } catch (\Exception $e) {
-	OCP\JSON::error(array('message' => $e->getMessage()));
+    OCP\JSON::error(array('message' => $e->getMessage()));
 }

apps/user_ldap/ajax/getConfiguration.php

Indentation +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@
 $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
 $configuration = $connection->getConfiguration();
 if (isset($configuration['ldap_agent_password']) && $configuration['ldap_agent_password'] !== '') {
-	// hide password
-	$configuration['ldap_agent_password'] = '**PASSWORD SET**';
+    // hide password
+    $configuration['ldap_agent_password'] = '**PASSWORD SET**';
 }
 OCP\JSON::success(array('configuration' => $configuration));

apps/user_ldap/ajax/setConfiguration.php

Indentation +4 added lines, -4 removed lines

@@ -36,11 +36,11 @@
 // only legacy checkboxes (Advanced and Expert tab) need to be handled here,
 // the Wizard-like tabs handle it on their own
 $chkboxes = array('ldap_configuration_active', 'ldap_override_main_server',
-				  'ldap_turn_off_cert_check');
+                    'ldap_turn_off_cert_check');
 foreach($chkboxes as $boxid) {
-	if(!isset($_POST[$boxid])) {
-		$_POST[$boxid] = 0;
-	}
+    if(!isset($_POST[$boxid])) {
+        $_POST[$boxid] = 0;
+    }
 }
 
 $ldapWrapper = new OCA\User_LDAP\LDAP();

apps/user_ldap/ajax/deleteConfiguration.php

Indentation +3 added lines, -3 removed lines

@@ -34,8 +34,8 @@
 $prefix = (string)$_POST['ldap_serverconfig_chooser'];
 $helper = new \OCA\User_LDAP\Helper(\OC::$server->getConfig());
 if($helper->deleteServerConfiguration($prefix)) {
-	OCP\JSON::success();
+    OCP\JSON::success();
 } else {
-	$l = \OC::$server->getL10N('user_ldap');
-	OCP\JSON::error(array('message' => $l->t('Failed to delete the server configuration')));
+    $l = \OC::$server->getL10N('user_ldap');
+    OCP\JSON::error(array('message' => $l->t('Failed to delete the server configuration')));
 }