Inspection of "Merge pull request #16586 from nextcloud/feature/1..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2e2d1b...edf9de )

by Roeland

created 2019-08-01 10:35 UTC

Status

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 	 * @param array $params
 	 */
 	public function shared(array $params) {
-		if($params['shareType'] === Share::SHARE_TYPE_LINK) {
+		if ($params['shareType'] === Share::SHARE_TYPE_LINK) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared via link with permissions "%s" (Share ID: %s)',
 				$params,
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_USER) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_USER) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the user "%s" with permissions "%s"  (Share ID: %s)',
 				$params,
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_GROUP) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_GROUP) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the group "%s" with permissions "%s"  (Share ID: %s)',
 				$params,
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_ROOM) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the room "%s" with permissions "%s" (Share ID: %s)',
 				$params,
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the email recipient "%s" with permissions "%s" (Share ID: %s)',
 				$params,
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the circle "%s" with permissions "%s" (Share ID: %s)',
 				$params,
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the remote user "%s" with permissions "%s" (Share ID: %s)',
 				$params,
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been shared to the remote group "%s" with permissions "%s" (Share ID: %s)',
 				$params,
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
 	 * @param array $params
 	 */
 	public function unshare(array $params) {
-		if($params['shareType'] === Share::SHARE_TYPE_LINK) {
+		if ($params['shareType'] === Share::SHARE_TYPE_LINK) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared (Share ID: %s)',
 				$params,
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_USER) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_USER) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the user "%s" (Share ID: %s)',
 				$params,
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_GROUP) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_GROUP) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the group "%s" (Share ID: %s)',
 				$params,
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_ROOM) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the room "%s" (Share ID: %s)',
 				$params,
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the email recipient "%s" (Share ID: %s)',
 				$params,
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the circle "%s" (Share ID: %s)',
 				$params,
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the remote user "%s" (Share ID: %s)',
 				$params,
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
 					'id',
 				]
 			);
-		} elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
+		} elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
 			$this->log(
 				'The %s "%s" with ID "%s" has been unshared from the remote group "%s" (Share ID: %s)',
 				$params,

Please login to merge, or discard this patch.

		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40	* @param array $params
41	41	*/
42	42	public function shared(array $params) {
43		- if($params['shareType'] === Share::SHARE_TYPE_LINK) {
	43	+ if ($params['shareType'] === Share::SHARE_TYPE_LINK) {
44	44	$this->log(
45	45	'The %s "%s" with ID "%s" has been shared via link with permissions "%s" (Share ID: %s)',
46	46	$params,
		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	'id',
53	53	]
54	54	);
55		- } elseif($params['shareType'] === Share::SHARE_TYPE_USER) {
	55	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_USER) {
56	56	$this->log(
57	57	'The %s "%s" with ID "%s" has been shared to the user "%s" with permissions "%s" (Share ID: %s)',
58	58	$params,
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	'id',
66	66	]
67	67	);
68		- } elseif($params['shareType'] === Share::SHARE_TYPE_GROUP) {
	68	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_GROUP) {
69	69	$this->log(
70	70	'The %s "%s" with ID "%s" has been shared to the group "%s" with permissions "%s" (Share ID: %s)',
71	71	$params,
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	'id',
79	79	]
80	80	);
81		- } elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
	81	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_ROOM) {
82	82	$this->log(
83	83	'The %s "%s" with ID "%s" has been shared to the room "%s" with permissions "%s" (Share ID: %s)',
84	84	$params,
		@@ -91,7 +91,7 @@ discard block
		block discarded – undo
91	91	'id',
92	92	]
93	93	);
94		- } elseif($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
	94	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
95	95	$this->log(
96	96	'The %s "%s" with ID "%s" has been shared to the email recipient "%s" with permissions "%s" (Share ID: %s)',
97	97	$params,
		@@ -104,7 +104,7 @@ discard block
		block discarded – undo
104	104	'id',
105	105	]
106	106	);
107		- } elseif($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
	107	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
108	108	$this->log(
109	109	'The %s "%s" with ID "%s" has been shared to the circle "%s" with permissions "%s" (Share ID: %s)',
110	110	$params,
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117	'id',
118	118	]
119	119	);
120		- } elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
	120	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
121	121	$this->log(
122	122	'The %s "%s" with ID "%s" has been shared to the remote user "%s" with permissions "%s" (Share ID: %s)',
123	123	$params,
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	'id',
131	131	]
132	132	);
133		- } elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
	133	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
134	134	$this->log(
135	135	'The %s "%s" with ID "%s" has been shared to the remote group "%s" with permissions "%s" (Share ID: %s)',
136	136	$params,
		@@ -152,7 +152,7 @@ discard block
		block discarded – undo
152	152	* @param array $params
153	153	*/
154	154	public function unshare(array $params) {
155		- if($params['shareType'] === Share::SHARE_TYPE_LINK) {
	155	+ if ($params['shareType'] === Share::SHARE_TYPE_LINK) {
156	156	$this->log(
157	157	'The %s "%s" with ID "%s" has been unshared (Share ID: %s)',
158	158	$params,
		@@ -163,7 +163,7 @@ discard block
		block discarded – undo
163	163	'id',
164	164	]
165	165	);
166		- } elseif($params['shareType'] === Share::SHARE_TYPE_USER) {
	166	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_USER) {
167	167	$this->log(
168	168	'The %s "%s" with ID "%s" has been unshared from the user "%s" (Share ID: %s)',
169	169	$params,
		@@ -175,7 +175,7 @@ discard block
		block discarded – undo
175	175	'id',
176	176	]
177	177	);
178		- } elseif($params['shareType'] === Share::SHARE_TYPE_GROUP) {
	178	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_GROUP) {
179	179	$this->log(
180	180	'The %s "%s" with ID "%s" has been unshared from the group "%s" (Share ID: %s)',
181	181	$params,
		@@ -187,7 +187,7 @@ discard block
		block discarded – undo
187	187	'id',
188	188	]
189	189	);
190		- } elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
	190	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_ROOM) {
191	191	$this->log(
192	192	'The %s "%s" with ID "%s" has been unshared from the room "%s" (Share ID: %s)',
193	193	$params,
		@@ -199,7 +199,7 @@ discard block
		block discarded – undo
199	199	'id',
200	200	]
201	201	);
202		- } elseif($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
	202	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_EMAIL) {
203	203	$this->log(
204	204	'The %s "%s" with ID "%s" has been unshared from the email recipient "%s" (Share ID: %s)',
205	205	$params,
		@@ -211,7 +211,7 @@ discard block
		block discarded – undo
211	211	'id',
212	212	]
213	213	);
214		- } elseif($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
	214	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_CIRCLE) {
215	215	$this->log(
216	216	'The %s "%s" with ID "%s" has been unshared from the circle "%s" (Share ID: %s)',
217	217	$params,
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	'id',
224	224	]
225	225	);
226		- } elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
	226	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE) {
227	227	$this->log(
228	228	'The %s "%s" with ID "%s" has been unshared from the remote user "%s" (Share ID: %s)',
229	229	$params,
		@@ -235,7 +235,7 @@ discard block
		block discarded – undo
235	235	'id',
236	236	]
237	237	);
238		- } elseif($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
	238	+ } elseif ($params['shareType'] === Share::SHARE_TYPE_REMOTE_GROUP) {
239	239	$this->log(
240	240	'The %s "%s" with ID "%s" has been unshared from the remote group "%s" (Share ID: %s)',
241	241	$params,

nextcloud / server

Push — master ( 2e2d1b...edf9de )

Status

Category

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch