nextcloud / server

apps/dav/tests/unit/BackgroundJob/CleanupOrphanedChildrenJobTest.php

Indentation +146 added lines, -146 removed lines

@@ -21,150 +21,150 @@
 use Test\TestCase;
 
 class CleanupOrphanedChildrenJobTest extends TestCase {
-	private CleanupOrphanedChildrenJob $job;
-
-	private ITimeFactory&MockObject $timeFactory;
-	private IDBConnection&MockObject $connection;
-	private LoggerInterface&MockObject $logger;
-	private IJobList&MockObject $jobList;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->connection = $this->createMock(IDBConnection::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->job = new CleanupOrphanedChildrenJob(
-			$this->timeFactory,
-			$this->connection,
-			$this->logger,
-			$this->jobList,
-		);
-	}
-
-	private function getArgument(): array {
-		return [
-			'childTable' => 'childTable',
-			'parentTable' => 'parentTable',
-			'parentId' => 'parentId',
-			'logMessage' => 'logMessage',
-		];
-	}
-
-	private function getMockQueryBuilder(): IQueryBuilder&MockObject {
-		$expr = $this->createMock(IExpressionBuilder::class);
-		$qb = $this->createMock(IQueryBuilder::class);
-		$qb->method('select')
-			->willReturnSelf();
-		$qb->method('from')
-			->willReturnSelf();
-		$qb->method('leftJoin')
-			->willReturnSelf();
-		$qb->method('where')
-			->willReturnSelf();
-		$qb->method('setMaxResults')
-			->willReturnSelf();
-		$qb->method('andWhere')
-			->willReturnSelf();
-		$qb->method('expr')
-			->willReturn($expr);
-		$qb->method('delete')
-			->willReturnSelf();
-		return $qb;
-	}
-
-	public function testRunWithoutOrphans(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$this->connection->expects(self::once())
-			->method('getQueryBuilder')
-			->willReturn($selectQb);
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAll')
-			->willReturn([]);
-		$result->expects(self::once())
-			->method('closeCursor');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
-
-	public function testRunWithPartialBatch(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$deleteQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$calls = [
-			$selectQb,
-			$deleteQb,
-		];
-		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
-				return array_shift($calls);
-			});
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAll')
-			->willReturn([
-				['id' => 42],
-				['id' => 43],
-			]);
-		$result->expects(self::once())
-			->method('closeCursor');
-		$deleteQb->expects(self::once())
-			->method('delete')
-			->willReturnSelf();
-		$deleteQb->expects(self::once())
-			->method('executeStatement');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
-
-	public function testRunWithFullBatch(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$deleteQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$calls = [
-			$selectQb,
-			$deleteQb,
-		];
-		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
-				return array_shift($calls);
-			});
-
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAll')
-			->willReturn(array_map(static fn ($i) => ['id' => 42 + $i], range(0, 999)));
-		$result->expects(self::once())
-			->method('closeCursor');
-		$deleteQb->expects(self::once())
-			->method('delete')
-			->willReturnSelf();
-		$deleteQb->expects(self::once())
-			->method('executeStatement');
-		$this->jobList->expects(self::once())
-			->method('add')
-			->with(CleanupOrphanedChildrenJob::class, $argument);
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
+    private CleanupOrphanedChildrenJob $job;
+
+    private ITimeFactory&MockObject $timeFactory;
+    private IDBConnection&MockObject $connection;
+    private LoggerInterface&MockObject $logger;
+    private IJobList&MockObject $jobList;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->connection = $this->createMock(IDBConnection::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->job = new CleanupOrphanedChildrenJob(
+            $this->timeFactory,
+            $this->connection,
+            $this->logger,
+            $this->jobList,
+        );
+    }
+
+    private function getArgument(): array {
+        return [
+            'childTable' => 'childTable',
+            'parentTable' => 'parentTable',
+            'parentId' => 'parentId',
+            'logMessage' => 'logMessage',
+        ];
+    }
+
+    private function getMockQueryBuilder(): IQueryBuilder&MockObject {
+        $expr = $this->createMock(IExpressionBuilder::class);
+        $qb = $this->createMock(IQueryBuilder::class);
+        $qb->method('select')
+            ->willReturnSelf();
+        $qb->method('from')
+            ->willReturnSelf();
+        $qb->method('leftJoin')
+            ->willReturnSelf();
+        $qb->method('where')
+            ->willReturnSelf();
+        $qb->method('setMaxResults')
+            ->willReturnSelf();
+        $qb->method('andWhere')
+            ->willReturnSelf();
+        $qb->method('expr')
+            ->willReturn($expr);
+        $qb->method('delete')
+            ->willReturnSelf();
+        return $qb;
+    }
+
+    public function testRunWithoutOrphans(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $this->connection->expects(self::once())
+            ->method('getQueryBuilder')
+            ->willReturn($selectQb);
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAll')
+            ->willReturn([]);
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
+
+    public function testRunWithPartialBatch(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $deleteQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $calls = [
+            $selectQb,
+            $deleteQb,
+        ];
+        $this->connection->method('getQueryBuilder')
+            ->willReturnCallback(function () use (&$calls) {
+                return array_shift($calls);
+            });
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAll')
+            ->willReturn([
+                ['id' => 42],
+                ['id' => 43],
+            ]);
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $deleteQb->expects(self::once())
+            ->method('delete')
+            ->willReturnSelf();
+        $deleteQb->expects(self::once())
+            ->method('executeStatement');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
+
+    public function testRunWithFullBatch(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $deleteQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $calls = [
+            $selectQb,
+            $deleteQb,
+        ];
+        $this->connection->method('getQueryBuilder')
+            ->willReturnCallback(function () use (&$calls) {
+                return array_shift($calls);
+            });
+
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAll')
+            ->willReturn(array_map(static fn ($i) => ['id' => 42 + $i], range(0, 999)));
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $deleteQb->expects(self::once())
+            ->method('delete')
+            ->willReturnSelf();
+        $deleteQb->expects(self::once())
+            ->method('executeStatement');
+        $this->jobList->expects(self::once())
+            ->method('add')
+            ->with(CleanupOrphanedChildrenJob::class, $argument);
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -108,7 +108,7 @@ 
 			$deleteQb,
 		];
 		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				return array_shift($calls);
 			});
 		$selectQb->expects(self::once())
@@ -144,7 +144,7 @@ 
 			$deleteQb,
 		];
 		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				return array_shift($calls);
 			});
 

apps/dav/tests/unit/BackgroundJob/RefreshWebcalJobTest.php

Indentation +75 added lines, -75 removed lines

@@ -19,79 +19,79 @@
 use Test\TestCase;
 
 class RefreshWebcalJobTest extends TestCase {
-	private RefreshWebcalService&MockObject $refreshWebcalService;
-	private IConfig&MockObject $config;
-	private LoggerInterface $logger;
-	private ITimeFactory&MockObject $timeFactory;
-	private IJobList&MockObject $jobList;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-
-		$this->jobList = $this->createMock(IJobList::class);
-	}
-
-	/**
-	 *
-	 * @param int $lastRun
-	 * @param int $time
-	 * @param bool $process
-	 *
-	 * @dataProvider runDataProvider
-	 */
-	public function testRun(int $lastRun, int $time, bool $process): void {
-		$backgroundJob = new RefreshWebcalJob($this->refreshWebcalService, $this->config, $this->logger, $this->timeFactory);
-		$backgroundJob->setId(42);
-
-		$backgroundJob->setArgument([
-			'principaluri' => 'principals/users/testuser',
-			'uri' => 'sub123',
-		]);
-		$backgroundJob->setLastRun($lastRun);
-
-		$this->refreshWebcalService->expects($this->once())
-			->method('getSubscription')
-			->with('principals/users/testuser', 'sub123')
-			->willReturn([
-				'id' => '99',
-				'uri' => 'sub456',
-				'{http://apple.com/ns/ical/}refreshrate' => 'P1D',
-				'{http://calendarserver.org/ns/}subscribed-strip-todos' => '1',
-				'{http://calendarserver.org/ns/}subscribed-strip-alarms' => '1',
-				'{http://calendarserver.org/ns/}subscribed-strip-attachments' => '1',
-				'source' => 'webcal://foo.bar/bla'
-			]);
-
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'calendarSubscriptionRefreshRate', 'P1D')
-			->willReturn('P1W');
-
-		$this->timeFactory->method('getTime')
-			->willReturn($time);
-
-		if ($process) {
-			$this->refreshWebcalService->expects($this->once())
-				->method('refreshSubscription')
-				->with('principals/users/testuser', 'sub123');
-		} else {
-			$this->refreshWebcalService->expects($this->never())
-				->method('refreshSubscription')
-				->with('principals/users/testuser', 'sub123');
-		}
-
-		$backgroundJob->start($this->jobList);
-	}
-
-	public static function runDataProvider():array {
-		return [
-			[0, 100000, true],
-			[100000, 100000, false]
-		];
-	}
+    private RefreshWebcalService&MockObject $refreshWebcalService;
+    private IConfig&MockObject $config;
+    private LoggerInterface $logger;
+    private ITimeFactory&MockObject $timeFactory;
+    private IJobList&MockObject $jobList;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+
+        $this->jobList = $this->createMock(IJobList::class);
+    }
+
+    /**
+     *
+     * @param int $lastRun
+     * @param int $time
+     * @param bool $process
+     *
+     * @dataProvider runDataProvider
+     */
+    public function testRun(int $lastRun, int $time, bool $process): void {
+        $backgroundJob = new RefreshWebcalJob($this->refreshWebcalService, $this->config, $this->logger, $this->timeFactory);
+        $backgroundJob->setId(42);
+
+        $backgroundJob->setArgument([
+            'principaluri' => 'principals/users/testuser',
+            'uri' => 'sub123',
+        ]);
+        $backgroundJob->setLastRun($lastRun);
+
+        $this->refreshWebcalService->expects($this->once())
+            ->method('getSubscription')
+            ->with('principals/users/testuser', 'sub123')
+            ->willReturn([
+                'id' => '99',
+                'uri' => 'sub456',
+                '{http://apple.com/ns/ical/}refreshrate' => 'P1D',
+                '{http://calendarserver.org/ns/}subscribed-strip-todos' => '1',
+                '{http://calendarserver.org/ns/}subscribed-strip-alarms' => '1',
+                '{http://calendarserver.org/ns/}subscribed-strip-attachments' => '1',
+                'source' => 'webcal://foo.bar/bla'
+            ]);
+
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'calendarSubscriptionRefreshRate', 'P1D')
+            ->willReturn('P1W');
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($time);
+
+        if ($process) {
+            $this->refreshWebcalService->expects($this->once())
+                ->method('refreshSubscription')
+                ->with('principals/users/testuser', 'sub123');
+        } else {
+            $this->refreshWebcalService->expects($this->never())
+                ->method('refreshSubscription')
+                ->with('principals/users/testuser', 'sub123');
+        }
+
+        $backgroundJob->start($this->jobList);
+    }
+
+    public static function runDataProvider():array {
+        return [
+            [0, 100000, true],
+            [100000, 100000, false]
+        ];
+    }
 }

apps/dav/tests/unit/Upload/AssemblyStreamTest.php

Indentation +157 added lines, -157 removed lines

@@ -12,161 +12,161 @@
 
 class AssemblyStreamTest extends \Test\TestCase {
 
-	/**
-	 * @dataProvider providesNodes()
-	 */
-	public function testGetContents(string $expected, array $nodeData): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-		$stream = AssemblyStream::wrap($nodes);
-		$content = stream_get_contents($stream);
-
-		$this->assertEquals($expected, $content);
-	}
-
-	/**
-	 * @dataProvider providesNodes()
-	 */
-	public function testGetContentsFread(string $expected, array $nodeData, int $chunkLength = 3): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-		$stream = AssemblyStream::wrap($nodes);
-
-		$content = '';
-		while (!feof($stream)) {
-			$chunk = fread($stream, $chunkLength);
-			$content .= $chunk;
-			if ($chunkLength !== 3) {
-				$this->assertEquals($chunkLength, strlen($chunk));
-			}
-		}
-
-		$this->assertEquals($expected, $content);
-	}
-
-	/**
-	 * @dataProvider providesNodes()
-	 */
-	public function testSeek(string $expected, array $nodeData): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-
-		$stream = AssemblyStream::wrap($nodes);
-
-		$offset = floor(strlen($expected) * 0.6);
-		if (fseek($stream, $offset) === -1) {
-			$this->fail('fseek failed');
-		}
-
-		$content = stream_get_contents($stream);
-		$this->assertEquals(substr($expected, $offset), $content);
-	}
-
-	public static function providesNodes(): array {
-		$data8k = self::makeData(8192);
-		$dataLess8k = self::makeData(8191);
-
-		$tonofnodes = [];
-		$tonofdata = '';
-		for ($i = 0; $i < 101; $i++) {
-			$thisdata = random_int(0, 100); // variable length and content
-			$tonofdata .= $thisdata;
-			$tonofnodes[] = [(string)$i, (string)$thisdata];
-		}
-
-		return[
-			'one node zero bytes' => [
-				'', [
-					['0', ''],
-				]],
-			'one node only' => [
-				'1234567890', [
-					['0', '1234567890'],
-				]],
-			'one node buffer boundary' => [
-				$data8k, [
-					['0', $data8k],
-				]],
-			'two nodes' => [
-				'1234567890', [
-					['1', '67890'],
-					['0', '12345'],
-				]],
-			'two nodes end on buffer boundary' => [
-				$data8k . $data8k, [
-					['1', $data8k],
-					['0', $data8k],
-				]],
-			'two nodes with one on buffer boundary' => [
-				$data8k . $dataLess8k, [
-					['1', $dataLess8k],
-					['0', $data8k],
-				]],
-			'two nodes on buffer boundary plus one byte' => [
-				$data8k . 'X' . $data8k, [
-					['1', $data8k],
-					['0', $data8k . 'X'],
-				]],
-			'two nodes on buffer boundary plus one byte at the end' => [
-				$data8k . $data8k . 'X', [
-					['1', $data8k . 'X'],
-					['0', $data8k],
-				]],
-			'a ton of nodes' => [
-				$tonofdata, $tonofnodes
-			],
-			'one read over multiple nodes' => [
-				'1234567890', [
-					['0', '1234'],
-					['1', '5678'],
-					['2', '90'],
-				], 10],
-			'two reads over multiple nodes' => [
-				'1234567890', [
-					['0', '1234'],
-					['1', '5678'],
-					['2', '90'],
-				], 5],
-		];
-	}
-
-	private static function makeData(int $count): string {
-		$data = '';
-		$base = '1234567890';
-		$j = 0;
-		for ($i = 0; $i < $count; $i++) {
-			$data .= $base[$j];
-			$j++;
-			if (!isset($base[$j])) {
-				$j = 0;
-			}
-		}
-		return $data;
-	}
-
-	private function buildNode(string $name, string $data) {
-		$node = $this->getMockBuilder(File::class)
-			->onlyMethods(['getName', 'get', 'getSize'])
-			->getMock();
-
-		$node->expects($this->any())
-			->method('getName')
-			->willReturn($name);
-
-		$node->expects($this->any())
-			->method('get')
-			->willReturn($data);
-
-		$node->expects($this->any())
-			->method('getSize')
-			->willReturn(strlen($data));
-
-		return $node;
-	}
+    /**
+     * @dataProvider providesNodes()
+     */
+    public function testGetContents(string $expected, array $nodeData): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+        $stream = AssemblyStream::wrap($nodes);
+        $content = stream_get_contents($stream);
+
+        $this->assertEquals($expected, $content);
+    }
+
+    /**
+     * @dataProvider providesNodes()
+     */
+    public function testGetContentsFread(string $expected, array $nodeData, int $chunkLength = 3): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+        $stream = AssemblyStream::wrap($nodes);
+
+        $content = '';
+        while (!feof($stream)) {
+            $chunk = fread($stream, $chunkLength);
+            $content .= $chunk;
+            if ($chunkLength !== 3) {
+                $this->assertEquals($chunkLength, strlen($chunk));
+            }
+        }
+
+        $this->assertEquals($expected, $content);
+    }
+
+    /**
+     * @dataProvider providesNodes()
+     */
+    public function testSeek(string $expected, array $nodeData): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+
+        $stream = AssemblyStream::wrap($nodes);
+
+        $offset = floor(strlen($expected) * 0.6);
+        if (fseek($stream, $offset) === -1) {
+            $this->fail('fseek failed');
+        }
+
+        $content = stream_get_contents($stream);
+        $this->assertEquals(substr($expected, $offset), $content);
+    }
+
+    public static function providesNodes(): array {
+        $data8k = self::makeData(8192);
+        $dataLess8k = self::makeData(8191);
+
+        $tonofnodes = [];
+        $tonofdata = '';
+        for ($i = 0; $i < 101; $i++) {
+            $thisdata = random_int(0, 100); // variable length and content
+            $tonofdata .= $thisdata;
+            $tonofnodes[] = [(string)$i, (string)$thisdata];
+        }
+
+        return[
+            'one node zero bytes' => [
+                '', [
+                    ['0', ''],
+                ]],
+            'one node only' => [
+                '1234567890', [
+                    ['0', '1234567890'],
+                ]],
+            'one node buffer boundary' => [
+                $data8k, [
+                    ['0', $data8k],
+                ]],
+            'two nodes' => [
+                '1234567890', [
+                    ['1', '67890'],
+                    ['0', '12345'],
+                ]],
+            'two nodes end on buffer boundary' => [
+                $data8k . $data8k, [
+                    ['1', $data8k],
+                    ['0', $data8k],
+                ]],
+            'two nodes with one on buffer boundary' => [
+                $data8k . $dataLess8k, [
+                    ['1', $dataLess8k],
+                    ['0', $data8k],
+                ]],
+            'two nodes on buffer boundary plus one byte' => [
+                $data8k . 'X' . $data8k, [
+                    ['1', $data8k],
+                    ['0', $data8k . 'X'],
+                ]],
+            'two nodes on buffer boundary plus one byte at the end' => [
+                $data8k . $data8k . 'X', [
+                    ['1', $data8k . 'X'],
+                    ['0', $data8k],
+                ]],
+            'a ton of nodes' => [
+                $tonofdata, $tonofnodes
+            ],
+            'one read over multiple nodes' => [
+                '1234567890', [
+                    ['0', '1234'],
+                    ['1', '5678'],
+                    ['2', '90'],
+                ], 10],
+            'two reads over multiple nodes' => [
+                '1234567890', [
+                    ['0', '1234'],
+                    ['1', '5678'],
+                    ['2', '90'],
+                ], 5],
+        ];
+    }
+
+    private static function makeData(int $count): string {
+        $data = '';
+        $base = '1234567890';
+        $j = 0;
+        for ($i = 0; $i < $count; $i++) {
+            $data .= $base[$j];
+            $j++;
+            if (!isset($base[$j])) {
+                $j = 0;
+            }
+        }
+        return $data;
+    }
+
+    private function buildNode(string $name, string $data) {
+        $node = $this->getMockBuilder(File::class)
+            ->onlyMethods(['getName', 'get', 'getSize'])
+            ->getMock();
+
+        $node->expects($this->any())
+            ->method('getName')
+            ->willReturn($name);
+
+        $node->expects($this->any())
+            ->method('get')
+            ->willReturn($data);
+
+        $node->expects($this->any())
+            ->method('getSize')
+            ->willReturn(strlen($data));
+
+        return $node;
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -77,7 +77,7 @@ 
 		for ($i = 0; $i < 101; $i++) {
 			$thisdata = random_int(0, 100); // variable length and content
 			$tonofdata .= $thisdata;
-			$tonofnodes[] = [(string)$i, (string)$thisdata];
+			$tonofnodes[] = [(string) $i, (string) $thisdata];
 		}
 
 		return[
@@ -99,23 +99,23 @@ 
 					['0', '12345'],
 				]],
 			'two nodes end on buffer boundary' => [
-				$data8k . $data8k, [
+				$data8k.$data8k, [
 					['1', $data8k],
 					['0', $data8k],
 				]],
 			'two nodes with one on buffer boundary' => [
-				$data8k . $dataLess8k, [
+				$data8k.$dataLess8k, [
 					['1', $dataLess8k],
 					['0', $data8k],
 				]],
 			'two nodes on buffer boundary plus one byte' => [
-				$data8k . 'X' . $data8k, [
+				$data8k.'X'.$data8k, [
 					['1', $data8k],
-					['0', $data8k . 'X'],
+					['0', $data8k.'X'],
 				]],
 			'two nodes on buffer boundary plus one byte at the end' => [
-				$data8k . $data8k . 'X', [
-					['1', $data8k . 'X'],
+				$data8k.$data8k.'X', [
+					['1', $data8k.'X'],
 					['0', $data8k],
 				]],
 			'a ton of nodes' => [