nextcloud / server

apps/dav/tests/unit/CalDAV/WebcalCaching/ConnectionTest.php

Indentation +155 added lines, -155 removed lines

@@ -20,159 +20,159 @@
 
 class ConnectionTest extends TestCase {
 
-	private IClientService&MockObject $clientService;
-	private IAppConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private Connection $connection;
-
-	public function setUp(): void {
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->config = $this->createMock(IAppConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->connection = new Connection($this->clientService, $this->config, $this->logger);
-	}
-
-	/**
-	 * @dataProvider runLocalURLDataProvider
-	 */
-	public function testLocalUrl($source): void {
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => $source,
-			'lastmodified' => 0,
-		];
-
-		$client = $this->createMock(IClient::class);
-		$this->clientService->expects(self::once())
-			->method('newClient')
-			->with()
-			->willReturn($client);
-
-		$this->config->expects(self::once())
-			->method('getValueString')
-			->with('dav', 'webcalAllowLocalAccess', 'no')
-			->willReturn('no');
-
-		$localServerException = new LocalServerException();
-		$client->expects(self::once())
-			->method('get')
-			->willThrowException($localServerException);
-		$this->logger->expects(self::once())
-			->method('warning')
-			->with('Subscription 42 was not refreshed because it violates local access rules', ['exception' => $localServerException]);
-
-		$this->connection->queryWebcalFeed($subscription);
-	}
-
-	public function testInvalidUrl(): void {
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => '!@#$',
-			'lastmodified' => 0,
-		];
-
-		$client = $this->createMock(IClient::class);
-		$this->config->expects(self::never())
-			->method('getValueString');
-		$client->expects(self::never())
-			->method('get');
-
-		$this->connection->queryWebcalFeed($subscription);
-
-	}
-
-	/**
-	 * @param string $result
-	 * @param string $contentType
-	 * @dataProvider urlDataProvider
-	 */
-	public function testConnection(string $url, string $result, string $contentType): void {
-		$client = $this->createMock(IClient::class);
-		$response = $this->createMock(IResponse::class);
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => $url,
-			'lastmodified' => 0,
-		];
-
-		$this->clientService->expects($this->once())
-			->method('newClient')
-			->with()
-			->willReturn($client);
-
-		$this->config->expects($this->once())
-			->method('getValueString')
-			->with('dav', 'webcalAllowLocalAccess', 'no')
-			->willReturn('no');
-
-		$client->expects($this->once())
-			->method('get')
-			->with('https://foo.bar/bla2')
-			->willReturn($response);
-
-		$response->expects($this->once())
-			->method('getBody')
-			->with()
-			->willReturn($result);
-		$response->expects($this->once())
-			->method('getHeader')
-			->with('Content-Type')
-			->willReturn($contentType);
-
-		$this->connection->queryWebcalFeed($subscription);
-	}
-
-	public static function runLocalURLDataProvider(): array {
-		return [
-			['localhost/foo.bar'],
-			['localHost/foo.bar'],
-			['random-host/foo.bar'],
-			['[::1]/bla.blub'],
-			['[::]/bla.blub'],
-			['192.168.0.1'],
-			['172.16.42.1'],
-			['[fdf8:f53b:82e4::53]/secret.ics'],
-			['[fe80::200:5aee:feaa:20a2]/secret.ics'],
-			['[0:0:0:0:0:0:10.0.0.1]/secret.ics'],
-			['[0:0:0:0:0:ffff:127.0.0.0]/secret.ics'],
-			['10.0.0.1'],
-			['another-host.local'],
-			['service.localhost'],
-		];
-	}
-
-	public static function urlDataProvider(): array {
-		return [
-			[
-				'https://foo.bar/bla2',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-				'text/calendar;charset=utf8',
-			],
-			[
-				'https://foo.bar/bla2',
-				'["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
-				'application/calendar+json',
-			],
-			[
-				'https://foo.bar/bla2',
-				'<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
-				'application/calendar+xml',
-			],
-		];
-	}
+    private IClientService&MockObject $clientService;
+    private IAppConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private Connection $connection;
+
+    public function setUp(): void {
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->config = $this->createMock(IAppConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->connection = new Connection($this->clientService, $this->config, $this->logger);
+    }
+
+    /**
+     * @dataProvider runLocalURLDataProvider
+     */
+    public function testLocalUrl($source): void {
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => $source,
+            'lastmodified' => 0,
+        ];
+
+        $client = $this->createMock(IClient::class);
+        $this->clientService->expects(self::once())
+            ->method('newClient')
+            ->with()
+            ->willReturn($client);
+
+        $this->config->expects(self::once())
+            ->method('getValueString')
+            ->with('dav', 'webcalAllowLocalAccess', 'no')
+            ->willReturn('no');
+
+        $localServerException = new LocalServerException();
+        $client->expects(self::once())
+            ->method('get')
+            ->willThrowException($localServerException);
+        $this->logger->expects(self::once())
+            ->method('warning')
+            ->with('Subscription 42 was not refreshed because it violates local access rules', ['exception' => $localServerException]);
+
+        $this->connection->queryWebcalFeed($subscription);
+    }
+
+    public function testInvalidUrl(): void {
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => '!@#$',
+            'lastmodified' => 0,
+        ];
+
+        $client = $this->createMock(IClient::class);
+        $this->config->expects(self::never())
+            ->method('getValueString');
+        $client->expects(self::never())
+            ->method('get');
+
+        $this->connection->queryWebcalFeed($subscription);
+
+    }
+
+    /**
+     * @param string $result
+     * @param string $contentType
+     * @dataProvider urlDataProvider
+     */
+    public function testConnection(string $url, string $result, string $contentType): void {
+        $client = $this->createMock(IClient::class);
+        $response = $this->createMock(IResponse::class);
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => $url,
+            'lastmodified' => 0,
+        ];
+
+        $this->clientService->expects($this->once())
+            ->method('newClient')
+            ->with()
+            ->willReturn($client);
+
+        $this->config->expects($this->once())
+            ->method('getValueString')
+            ->with('dav', 'webcalAllowLocalAccess', 'no')
+            ->willReturn('no');
+
+        $client->expects($this->once())
+            ->method('get')
+            ->with('https://foo.bar/bla2')
+            ->willReturn($response);
+
+        $response->expects($this->once())
+            ->method('getBody')
+            ->with()
+            ->willReturn($result);
+        $response->expects($this->once())
+            ->method('getHeader')
+            ->with('Content-Type')
+            ->willReturn($contentType);
+
+        $this->connection->queryWebcalFeed($subscription);
+    }
+
+    public static function runLocalURLDataProvider(): array {
+        return [
+            ['localhost/foo.bar'],
+            ['localHost/foo.bar'],
+            ['random-host/foo.bar'],
+            ['[::1]/bla.blub'],
+            ['[::]/bla.blub'],
+            ['192.168.0.1'],
+            ['172.16.42.1'],
+            ['[fdf8:f53b:82e4::53]/secret.ics'],
+            ['[fe80::200:5aee:feaa:20a2]/secret.ics'],
+            ['[0:0:0:0:0:0:10.0.0.1]/secret.ics'],
+            ['[0:0:0:0:0:ffff:127.0.0.0]/secret.ics'],
+            ['10.0.0.1'],
+            ['another-host.local'],
+            ['service.localhost'],
+        ];
+    }
+
+    public static function urlDataProvider(): array {
+        return [
+            [
+                'https://foo.bar/bla2',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+                'text/calendar;charset=utf8',
+            ],
+            [
+                'https://foo.bar/bla2',
+                '["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
+                'application/calendar+json',
+            ],
+            [
+                'https://foo.bar/bla2',
+                '<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
+                'application/calendar+xml',
+            ],
+        ];
+    }
 }

apps/dav/tests/unit/CalDAV/CalendarHomeTest.php

Indentation +314 added lines, -314 removed lines

@@ -24,324 +24,324 @@
 use Test\TestCase;
 
 class CalendarHomeTest extends TestCase {
-	private CalDavBackend&MockObject $backend;
-	private array $principalInfo = [];
-	private PluginManager&MockObject $pluginManager;
-	private LoggerInterface&MockObject $logger;
-	private CalendarHome $calendarHome;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->backend = $this->createMock(CalDavBackend::class);
-		$this->principalInfo = [
-			'uri' => 'user-principal-123',
-		];
-		$this->pluginManager = $this->createMock(PluginManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			false
-		);
-
-		// Replace PluginManager with our mock
-		$reflection = new \ReflectionClass($this->calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($this->calendarHome, $this->pluginManager);
-	}
-
-	public function testCreateCalendarValidName(): void {
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$mkCol->method('getResourceType')
-			->willReturn(['{DAV:}collection',
-				'{urn:ietf:params:xml:ns:caldav}calendar']);
-		$mkCol->method('getRemainingValues')
-			->willReturn(['... properties ...']);
-
-		$this->backend->expects(self::once())
-			->method('createCalendar')
-			->with('user-principal-123', 'name123', ['... properties ...']);
-
-		$this->calendarHome->createExtendedCollection('name123', $mkCol);
-	}
-
-	public function testCreateCalendarReservedName(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('The resource you tried to create has a reserved name');
-
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$this->calendarHome->createExtendedCollection('contact_birthdays', $mkCol);
-	}
-
-	public function testCreateCalendarReservedNameAppGenerated(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('The resource you tried to create has a reserved name');
-
-		/** @var MkCol&MockObject $mkCol */
-		$mkCol = $this->createMock(MkCol::class);
-
-		$this->calendarHome->createExtendedCollection('app-generated--example--foo-1', $mkCol);
-	}
-
-	public function testGetChildren():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$calendarPlugin1 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin1
-			->expects(self::once())
-			->method('fetchAllForCalendarHome')
-			->with('user-principal-123')
-			->willReturn(['plugin1calendar1', 'plugin1calendar2']);
-
-		$calendarPlugin2 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('fetchAllForCalendarHome')
-			->with('user-principal-123')
-			->willReturn(['plugin2calendar1', 'plugin2calendar2']);
-
-		$this->pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([$calendarPlugin1, $calendarPlugin2]);
-
-		$actual = $this->calendarHome->getChildren();
-
-		$this->assertCount(7, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertEquals('plugin1calendar1', $actual[3]);
-		$this->assertEquals('plugin1calendar2', $actual[4]);
-		$this->assertEquals('plugin2calendar1', $actual[5]);
-		$this->assertEquals('plugin2calendar2', $actual[6]);
-	}
-
-	public function testGetChildNonAppGenerated():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarByUri')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->pluginManager
-			->expects(self::never())
-			->method('getCalendarPlugins');
-
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('Node with name \'personal\' could not be found');
-
-		$this->calendarHome->getChild('personal');
-	}
-
-	public function testGetChildAppGenerated():void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarByUri')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$calendarPlugin1 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin1
-			->expects(self::once())
-			->method('getAppId')
-			->with()
-			->willReturn('calendar_plugin_1');
-		$calendarPlugin1
-			->expects(self::never())
-			->method('hasCalendarInCalendarHome');
-		$calendarPlugin1
-			->expects(self::never())
-			->method('getCalendarInCalendarHome');
-
-		$externalCalendarMock = $this->createMock(ExternalCalendar::class);
-
-		$calendarPlugin2 = $this->createMock(ICalendarProvider::class);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('getAppId')
-			->with()
-			->willReturn('calendar_plugin_2');
-		$calendarPlugin2
-			->expects(self::once())
-			->method('hasCalendarInCalendarHome')
-			->with('user-principal-123', 'calendar-uri-from-backend')
-			->willReturn(true);
-		$calendarPlugin2
-			->expects(self::once())
-			->method('getCalendarInCalendarHome')
-			->with('user-principal-123', 'calendar-uri-from-backend')
-			->willReturn($externalCalendarMock);
-
-		$this->pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([$calendarPlugin1, $calendarPlugin2]);
-
-		$actual = $this->calendarHome->getChild('app-generated--calendar_plugin_2--calendar-uri-from-backend');
-		$this->assertEquals($externalCalendarMock, $actual);
-	}
-
-	public function testGetChildrenSubscriptions(): void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([
-				[
-					'id' => 'subscription-1',
-					'uri' => 'subscription-1',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-1',
-					// A subscription array has actually more properties.
-				],
-				[
-					'id' => 'subscription-2',
-					'uri' => 'subscription-2',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-2',
-					// A subscription array has actually more properties.
-				]
-			]);
-
-		/*
+    private CalDavBackend&MockObject $backend;
+    private array $principalInfo = [];
+    private PluginManager&MockObject $pluginManager;
+    private LoggerInterface&MockObject $logger;
+    private CalendarHome $calendarHome;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->backend = $this->createMock(CalDavBackend::class);
+        $this->principalInfo = [
+            'uri' => 'user-principal-123',
+        ];
+        $this->pluginManager = $this->createMock(PluginManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            false
+        );
+
+        // Replace PluginManager with our mock
+        $reflection = new \ReflectionClass($this->calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($this->calendarHome, $this->pluginManager);
+    }
+
+    public function testCreateCalendarValidName(): void {
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $mkCol->method('getResourceType')
+            ->willReturn(['{DAV:}collection',
+                '{urn:ietf:params:xml:ns:caldav}calendar']);
+        $mkCol->method('getRemainingValues')
+            ->willReturn(['... properties ...']);
+
+        $this->backend->expects(self::once())
+            ->method('createCalendar')
+            ->with('user-principal-123', 'name123', ['... properties ...']);
+
+        $this->calendarHome->createExtendedCollection('name123', $mkCol);
+    }
+
+    public function testCreateCalendarReservedName(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('The resource you tried to create has a reserved name');
+
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $this->calendarHome->createExtendedCollection('contact_birthdays', $mkCol);
+    }
+
+    public function testCreateCalendarReservedNameAppGenerated(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('The resource you tried to create has a reserved name');
+
+        /** @var MkCol&MockObject $mkCol */
+        $mkCol = $this->createMock(MkCol::class);
+
+        $this->calendarHome->createExtendedCollection('app-generated--example--foo-1', $mkCol);
+    }
+
+    public function testGetChildren():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $calendarPlugin1 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin1
+            ->expects(self::once())
+            ->method('fetchAllForCalendarHome')
+            ->with('user-principal-123')
+            ->willReturn(['plugin1calendar1', 'plugin1calendar2']);
+
+        $calendarPlugin2 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('fetchAllForCalendarHome')
+            ->with('user-principal-123')
+            ->willReturn(['plugin2calendar1', 'plugin2calendar2']);
+
+        $this->pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([$calendarPlugin1, $calendarPlugin2]);
+
+        $actual = $this->calendarHome->getChildren();
+
+        $this->assertCount(7, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertEquals('plugin1calendar1', $actual[3]);
+        $this->assertEquals('plugin1calendar2', $actual[4]);
+        $this->assertEquals('plugin2calendar1', $actual[5]);
+        $this->assertEquals('plugin2calendar2', $actual[6]);
+    }
+
+    public function testGetChildNonAppGenerated():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarByUri')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->pluginManager
+            ->expects(self::never())
+            ->method('getCalendarPlugins');
+
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('Node with name \'personal\' could not be found');
+
+        $this->calendarHome->getChild('personal');
+    }
+
+    public function testGetChildAppGenerated():void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarByUri')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $calendarPlugin1 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin1
+            ->expects(self::once())
+            ->method('getAppId')
+            ->with()
+            ->willReturn('calendar_plugin_1');
+        $calendarPlugin1
+            ->expects(self::never())
+            ->method('hasCalendarInCalendarHome');
+        $calendarPlugin1
+            ->expects(self::never())
+            ->method('getCalendarInCalendarHome');
+
+        $externalCalendarMock = $this->createMock(ExternalCalendar::class);
+
+        $calendarPlugin2 = $this->createMock(ICalendarProvider::class);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('getAppId')
+            ->with()
+            ->willReturn('calendar_plugin_2');
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('hasCalendarInCalendarHome')
+            ->with('user-principal-123', 'calendar-uri-from-backend')
+            ->willReturn(true);
+        $calendarPlugin2
+            ->expects(self::once())
+            ->method('getCalendarInCalendarHome')
+            ->with('user-principal-123', 'calendar-uri-from-backend')
+            ->willReturn($externalCalendarMock);
+
+        $this->pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([$calendarPlugin1, $calendarPlugin2]);
+
+        $actual = $this->calendarHome->getChild('app-generated--calendar_plugin_2--calendar-uri-from-backend');
+        $this->assertEquals($externalCalendarMock, $actual);
+    }
+
+    public function testGetChildrenSubscriptions(): void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([
+                [
+                    'id' => 'subscription-1',
+                    'uri' => 'subscription-1',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-1',
+                    // A subscription array has actually more properties.
+                ],
+                [
+                    'id' => 'subscription-2',
+                    'uri' => 'subscription-2',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-2',
+                    // A subscription array has actually more properties.
+                ]
+            ]);
+
+        /*
 		 * @FIXME: PluginManager should be injected via constructor.
 		 */
 
-		$pluginManager = $this->createMock(PluginManager::class);
-		$pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([]);
-
-		$calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			false
-		);
-
-		$reflection = new \ReflectionClass($calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($calendarHome, $pluginManager);
-
-		$actual = $calendarHome->getChildren();
-
-		$this->assertCount(5, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertInstanceOf(Subscription::class, $actual[3]);
-		$this->assertInstanceOf(Subscription::class, $actual[4]);
-	}
-
-	public function testGetChildrenCachedSubscriptions(): void {
-		$this->backend
-			->expects(self::once())
-			->method('getCalendarsForUser')
-			->with('user-principal-123')
-			->willReturn([]);
-
-		$this->backend
-			->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('user-principal-123')
-			->willReturn([
-				[
-					'id' => 'subscription-1',
-					'uri' => 'subscription-1',
-					'principaluris' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-1',
-					// A subscription array has actually more properties.
-				],
-				[
-					'id' => 'subscription-2',
-					'uri' => 'subscription-2',
-					'principaluri' => 'user-principal-123',
-					'source' => 'https://localhost/subscription-2',
-					// A subscription array has actually more properties.
-				]
-			]);
-
-		/*
+        $pluginManager = $this->createMock(PluginManager::class);
+        $pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([]);
+
+        $calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            false
+        );
+
+        $reflection = new \ReflectionClass($calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($calendarHome, $pluginManager);
+
+        $actual = $calendarHome->getChildren();
+
+        $this->assertCount(5, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertInstanceOf(Subscription::class, $actual[3]);
+        $this->assertInstanceOf(Subscription::class, $actual[4]);
+    }
+
+    public function testGetChildrenCachedSubscriptions(): void {
+        $this->backend
+            ->expects(self::once())
+            ->method('getCalendarsForUser')
+            ->with('user-principal-123')
+            ->willReturn([]);
+
+        $this->backend
+            ->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('user-principal-123')
+            ->willReturn([
+                [
+                    'id' => 'subscription-1',
+                    'uri' => 'subscription-1',
+                    'principaluris' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-1',
+                    // A subscription array has actually more properties.
+                ],
+                [
+                    'id' => 'subscription-2',
+                    'uri' => 'subscription-2',
+                    'principaluri' => 'user-principal-123',
+                    'source' => 'https://localhost/subscription-2',
+                    // A subscription array has actually more properties.
+                ]
+            ]);
+
+        /*
 		 * @FIXME: PluginManager should be injected via constructor.
 		 */
 
-		$pluginManager = $this->createMock(PluginManager::class);
-		$pluginManager
-			->expects(self::once())
-			->method('getCalendarPlugins')
-			->with()
-			->willReturn([]);
-
-		$calendarHome = new CalendarHome(
-			$this->backend,
-			$this->principalInfo,
-			$this->logger,
-			true
-		);
-
-		$reflection = new \ReflectionClass($calendarHome);
-		$reflectionProperty = $reflection->getProperty('pluginManager');
-		$reflectionProperty->setValue($calendarHome, $pluginManager);
-
-		$actual = $calendarHome->getChildren();
-
-		$this->assertCount(5, $actual);
-		$this->assertInstanceOf(Inbox::class, $actual[0]);
-		$this->assertInstanceOf(Outbox::class, $actual[1]);
-		$this->assertInstanceOf(TrashbinHome::class, $actual[2]);
-		$this->assertInstanceOf(CachedSubscription::class, $actual[3]);
-		$this->assertInstanceOf(CachedSubscription::class, $actual[4]);
-	}
+        $pluginManager = $this->createMock(PluginManager::class);
+        $pluginManager
+            ->expects(self::once())
+            ->method('getCalendarPlugins')
+            ->with()
+            ->willReturn([]);
+
+        $calendarHome = new CalendarHome(
+            $this->backend,
+            $this->principalInfo,
+            $this->logger,
+            true
+        );
+
+        $reflection = new \ReflectionClass($calendarHome);
+        $reflectionProperty = $reflection->getProperty('pluginManager');
+        $reflectionProperty->setValue($calendarHome, $pluginManager);
+
+        $actual = $calendarHome->getChildren();
+
+        $this->assertCount(5, $actual);
+        $this->assertInstanceOf(Inbox::class, $actual[0]);
+        $this->assertInstanceOf(Outbox::class, $actual[1]);
+        $this->assertInstanceOf(TrashbinHome::class, $actual[2]);
+        $this->assertInstanceOf(CachedSubscription::class, $actual[3]);
+        $this->assertInstanceOf(CachedSubscription::class, $actual[4]);
+    }
 }

apps/dav/tests/unit/CalDAV/OutboxTest.php

Indentation +83 added lines, -83 removed lines

@@ -13,93 +13,93 @@
 use Test\TestCase;
 
 class OutboxTest extends TestCase {
-	private IConfig&MockObject $config;
-	private Outbox $outbox;
+    private IConfig&MockObject $config;
+    private Outbox $outbox;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->createMock(IConfig::class);
-		$this->outbox = new Outbox($this->config, 'user-principal-123');
-	}
+        $this->config = $this->createMock(IConfig::class);
+        $this->outbox = new Outbox($this->config, 'user-principal-123');
+    }
 
-	public function testGetACLFreeBusyEnabled(): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'disableFreeBusy', 'no')
-			->willReturn('no');
+    public function testGetACLFreeBusyEnabled(): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'disableFreeBusy', 'no')
+            ->willReturn('no');
 
-		$this->assertEquals([
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123/calendar-proxy-read',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123/calendar-proxy-write',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send',
-				'principal' => 'user-principal-123',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send',
-				'principal' => 'user-principal-123/calendar-proxy-write',
-				'protected' => true,
-			],
-		], $this->outbox->getACL());
-	}
+        $this->assertEquals([
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123/calendar-proxy-read',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123/calendar-proxy-write',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send',
+                'principal' => 'user-principal-123',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send',
+                'principal' => 'user-principal-123/calendar-proxy-write',
+                'protected' => true,
+            ],
+        ], $this->outbox->getACL());
+    }
 
-	public function testGetACLFreeBusyDisabled(): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'disableFreeBusy', 'no')
-			->willReturn('yes');
+    public function testGetACLFreeBusyDisabled(): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'disableFreeBusy', 'no')
+            ->willReturn('yes');
 
-		$this->assertEquals([
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123/calendar-proxy-read',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user-principal-123/calendar-proxy-write',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-invite',
-				'principal' => 'user-principal-123',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-invite',
-				'principal' => 'user-principal-123/calendar-proxy-write',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-reply',
-				'principal' => 'user-principal-123',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-reply',
-				'principal' => 'user-principal-123/calendar-proxy-write',
-				'protected' => true,
-			],
-		], $this->outbox->getACL());
-	}
+        $this->assertEquals([
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123/calendar-proxy-read',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user-principal-123/calendar-proxy-write',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-invite',
+                'principal' => 'user-principal-123',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-invite',
+                'principal' => 'user-principal-123/calendar-proxy-write',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-reply',
+                'principal' => 'user-principal-123',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}schedule-send-reply',
+                'principal' => 'user-principal-123/calendar-proxy-write',
+                'protected' => true,
+            ],
+        ], $this->outbox->getACL());
+    }
 }

apps/dav/tests/unit/CalDAV/ResourceBooking/RoomPrincipalBackendTest.php

Indentation +11 added lines, -11 removed lines

@@ -10,19 +10,19 @@
 use OCA\DAV\CalDAV\ResourceBooking\RoomPrincipalBackend;
 
 class RoomPrincipalBackendTest extends AbstractPrincipalBackendTestCase {
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->principalBackend = new RoomPrincipalBackend(self::$realDatabase,
-			$this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);
+        $this->principalBackend = new RoomPrincipalBackend(self::$realDatabase,
+            $this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);
 
-		$this->mainDbTable = 'calendar_rooms';
-		$this->metadataDbTable = 'calendar_rooms_md';
-		$this->foreignKey = 'room_id';
+        $this->mainDbTable = 'calendar_rooms';
+        $this->metadataDbTable = 'calendar_rooms_md';
+        $this->foreignKey = 'room_id';
 
-		$this->principalPrefix = 'principals/calendar-rooms';
-		$this->expectedCUType = 'ROOM';
+        $this->principalPrefix = 'principals/calendar-rooms';
+        $this->expectedCUType = 'ROOM';
 
-		$this->createTestDatasetInDb();
-	}
+        $this->createTestDatasetInDb();
+    }
 }

apps/dav/tests/unit/CalDAV/ResourceBooking/ResourcePrincipalBackendTest.php

Indentation +11 added lines, -11 removed lines

@@ -10,19 +10,19 @@
 use OCA\DAV\CalDAV\ResourceBooking\ResourcePrincipalBackend;
 
 class ResourcePrincipalBackendTest extends AbstractPrincipalBackendTestCase {
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->principalBackend = new ResourcePrincipalBackend(self::$realDatabase,
-			$this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);
+        $this->principalBackend = new ResourcePrincipalBackend(self::$realDatabase,
+            $this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);
 
-		$this->mainDbTable = 'calendar_resources';
-		$this->metadataDbTable = 'calendar_resources_md';
-		$this->foreignKey = 'resource_id';
+        $this->mainDbTable = 'calendar_resources';
+        $this->metadataDbTable = 'calendar_resources_md';
+        $this->foreignKey = 'resource_id';
 
-		$this->principalPrefix = 'principals/calendar-resources';
-		$this->expectedCUType = 'RESOURCE';
+        $this->principalPrefix = 'principals/calendar-resources';
+        $this->expectedCUType = 'RESOURCE';
 
-		$this->createTestDatasetInDb();
-	}
+        $this->createTestDatasetInDb();
+    }
 }

apps/dav/tests/unit/CalDAV/Listener/CalendarShareUpdateListenerTest.php

Indentation +25 added lines, -25 removed lines

@@ -16,33 +16,33 @@
 use Test\TestCase;
 
 class CalendarShareUpdateListenerTest extends TestCase {
-	private Backend&MockObject $activityBackend;
-	private LoggerInterface&MockObject $logger;
-	private CalendarShareUpdateListener $calendarPublicationListener;
-	private CalendarShareUpdatedEvent&MockObject $event;
+    private Backend&MockObject $activityBackend;
+    private LoggerInterface&MockObject $logger;
+    private CalendarShareUpdateListener $calendarPublicationListener;
+    private CalendarShareUpdatedEvent&MockObject $event;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->activityBackend = $this->createMock(Backend::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->event = $this->createMock(CalendarShareUpdatedEvent::class);
-		$this->calendarPublicationListener = new CalendarShareUpdateListener($this->activityBackend, $this->logger);
-	}
+        $this->activityBackend = $this->createMock(Backend::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->event = $this->createMock(CalendarShareUpdatedEvent::class);
+        $this->calendarPublicationListener = new CalendarShareUpdateListener($this->activityBackend, $this->logger);
+    }
 
-	public function testInvalidEvent(): void {
-		$this->activityBackend->expects($this->never())->method('onCalendarUpdateShares');
-		$this->logger->expects($this->never())->method('debug');
-		$this->calendarPublicationListener->handle(new Event());
-	}
+    public function testInvalidEvent(): void {
+        $this->activityBackend->expects($this->never())->method('onCalendarUpdateShares');
+        $this->logger->expects($this->never())->method('debug');
+        $this->calendarPublicationListener->handle(new Event());
+    }
 
-	public function testEvent(): void {
-		$this->event->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
-		$this->event->expects($this->once())->method('getOldShares')->with()->willReturn([]);
-		$this->event->expects($this->once())->method('getAdded')->with()->willReturn([]);
-		$this->event->expects($this->once())->method('getRemoved')->with()->willReturn([]);
-		$this->activityBackend->expects($this->once())->method('onCalendarUpdateShares')->with([], [], [], []);
-		$this->logger->expects($this->once())->method('debug');
-		$this->calendarPublicationListener->handle($this->event);
-	}
+    public function testEvent(): void {
+        $this->event->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
+        $this->event->expects($this->once())->method('getOldShares')->with()->willReturn([]);
+        $this->event->expects($this->once())->method('getAdded')->with()->willReturn([]);
+        $this->event->expects($this->once())->method('getRemoved')->with()->willReturn([]);
+        $this->activityBackend->expects($this->once())->method('onCalendarUpdateShares')->with([], [], [], []);
+        $this->logger->expects($this->once())->method('debug');
+        $this->calendarPublicationListener->handle($this->event);
+    }
 }

apps/dav/tests/unit/CalDAV/Listener/CalendarPublicationListenerTest.php

Indentation +35 added lines, -35 removed lines

@@ -17,39 +17,39 @@
 use Test\TestCase;
 
 class CalendarPublicationListenerTest extends TestCase {
-	private Backend&MockObject $activityBackend;
-	private LoggerInterface&MockObject $logger;
-	private CalendarPublicationListener $calendarPublicationListener;
-	private CalendarPublishedEvent&MockObject $publicationEvent;
-	private CalendarUnpublishedEvent&MockObject $unpublicationEvent;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->activityBackend = $this->createMock(Backend::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->publicationEvent = $this->createMock(CalendarPublishedEvent::class);
-		$this->unpublicationEvent = $this->createMock(CalendarUnpublishedEvent::class);
-		$this->calendarPublicationListener = new CalendarPublicationListener($this->activityBackend, $this->logger);
-	}
-
-	public function testInvalidEvent(): void {
-		$this->activityBackend->expects($this->never())->method('onCalendarPublication');
-		$this->logger->expects($this->never())->method('debug');
-		$this->calendarPublicationListener->handle(new Event());
-	}
-
-	public function testPublicationEvent(): void {
-		$this->publicationEvent->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
-		$this->activityBackend->expects($this->once())->method('onCalendarPublication')->with([], true);
-		$this->logger->expects($this->once())->method('debug');
-		$this->calendarPublicationListener->handle($this->publicationEvent);
-	}
-
-	public function testUnPublicationEvent(): void {
-		$this->unpublicationEvent->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
-		$this->activityBackend->expects($this->once())->method('onCalendarPublication')->with([], false);
-		$this->logger->expects($this->once())->method('debug');
-		$this->calendarPublicationListener->handle($this->unpublicationEvent);
-	}
+    private Backend&MockObject $activityBackend;
+    private LoggerInterface&MockObject $logger;
+    private CalendarPublicationListener $calendarPublicationListener;
+    private CalendarPublishedEvent&MockObject $publicationEvent;
+    private CalendarUnpublishedEvent&MockObject $unpublicationEvent;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->activityBackend = $this->createMock(Backend::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->publicationEvent = $this->createMock(CalendarPublishedEvent::class);
+        $this->unpublicationEvent = $this->createMock(CalendarUnpublishedEvent::class);
+        $this->calendarPublicationListener = new CalendarPublicationListener($this->activityBackend, $this->logger);
+    }
+
+    public function testInvalidEvent(): void {
+        $this->activityBackend->expects($this->never())->method('onCalendarPublication');
+        $this->logger->expects($this->never())->method('debug');
+        $this->calendarPublicationListener->handle(new Event());
+    }
+
+    public function testPublicationEvent(): void {
+        $this->publicationEvent->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
+        $this->activityBackend->expects($this->once())->method('onCalendarPublication')->with([], true);
+        $this->logger->expects($this->once())->method('debug');
+        $this->calendarPublicationListener->handle($this->publicationEvent);
+    }
+
+    public function testUnPublicationEvent(): void {
+        $this->unpublicationEvent->expects($this->once())->method('getCalendarData')->with()->willReturn([]);
+        $this->activityBackend->expects($this->once())->method('onCalendarPublication')->with([], false);
+        $this->logger->expects($this->once())->method('debug');
+        $this->calendarPublicationListener->handle($this->unpublicationEvent);
+    }
 }

apps/dav/tests/unit/CalDAV/Listener/SubscriptionListenerTest.php

Indentation +39 added lines, -39 removed lines

@@ -20,48 +20,48 @@
 use Test\TestCase;
 
 class SubscriptionListenerTest extends TestCase {
-	private RefreshWebcalService&MockObject $refreshWebcalService;
-	private Backend&MockObject $reminderBackend;
-	private IJobList&MockObject $jobList;
-	private LoggerInterface&MockObject $logger;
-	private SubscriptionListener $calendarPublicationListener;
-	private SubscriptionCreatedEvent&MockObject $subscriptionCreatedEvent;
-	private SubscriptionDeletedEvent&MockObject $subscriptionDeletedEvent;
+    private RefreshWebcalService&MockObject $refreshWebcalService;
+    private Backend&MockObject $reminderBackend;
+    private IJobList&MockObject $jobList;
+    private LoggerInterface&MockObject $logger;
+    private SubscriptionListener $calendarPublicationListener;
+    private SubscriptionCreatedEvent&MockObject $subscriptionCreatedEvent;
+    private SubscriptionDeletedEvent&MockObject $subscriptionDeletedEvent;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
-		$this->reminderBackend = $this->createMock(Backend::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->subscriptionCreatedEvent = $this->createMock(SubscriptionCreatedEvent::class);
-		$this->subscriptionDeletedEvent = $this->createMock(SubscriptionDeletedEvent::class);
-		$this->calendarPublicationListener = new SubscriptionListener($this->jobList, $this->refreshWebcalService, $this->reminderBackend, $this->logger);
-	}
+        $this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
+        $this->reminderBackend = $this->createMock(Backend::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->subscriptionCreatedEvent = $this->createMock(SubscriptionCreatedEvent::class);
+        $this->subscriptionDeletedEvent = $this->createMock(SubscriptionDeletedEvent::class);
+        $this->calendarPublicationListener = new SubscriptionListener($this->jobList, $this->refreshWebcalService, $this->reminderBackend, $this->logger);
+    }
 
-	public function testInvalidEvent(): void {
-		$this->refreshWebcalService->expects($this->never())->method('refreshSubscription');
-		$this->jobList->expects($this->never())->method('add');
-		$this->logger->expects($this->never())->method('debug');
-		$this->calendarPublicationListener->handle(new Event());
-	}
+    public function testInvalidEvent(): void {
+        $this->refreshWebcalService->expects($this->never())->method('refreshSubscription');
+        $this->jobList->expects($this->never())->method('add');
+        $this->logger->expects($this->never())->method('debug');
+        $this->calendarPublicationListener->handle(new Event());
+    }
 
-	public function testCreateSubscriptionEvent(): void {
-		$this->subscriptionCreatedEvent->expects($this->once())->method('getSubscriptionId')->with()->willReturn(5);
-		$this->subscriptionCreatedEvent->expects($this->once())->method('getSubscriptionData')->with()->willReturn(['principaluri' => 'principaluri', 'uri' => 'uri']);
-		$this->refreshWebcalService->expects($this->once())->method('refreshSubscription')->with('principaluri', 'uri');
-		$this->jobList->expects($this->once())->method('add')->with(RefreshWebcalJob::class, ['principaluri' => 'principaluri', 'uri' => 'uri']);
-		$this->logger->expects($this->exactly(2))->method('debug');
-		$this->calendarPublicationListener->handle($this->subscriptionCreatedEvent);
-	}
+    public function testCreateSubscriptionEvent(): void {
+        $this->subscriptionCreatedEvent->expects($this->once())->method('getSubscriptionId')->with()->willReturn(5);
+        $this->subscriptionCreatedEvent->expects($this->once())->method('getSubscriptionData')->with()->willReturn(['principaluri' => 'principaluri', 'uri' => 'uri']);
+        $this->refreshWebcalService->expects($this->once())->method('refreshSubscription')->with('principaluri', 'uri');
+        $this->jobList->expects($this->once())->method('add')->with(RefreshWebcalJob::class, ['principaluri' => 'principaluri', 'uri' => 'uri']);
+        $this->logger->expects($this->exactly(2))->method('debug');
+        $this->calendarPublicationListener->handle($this->subscriptionCreatedEvent);
+    }
 
-	public function testDeleteSubscriptionEvent(): void {
-		$this->subscriptionDeletedEvent->expects($this->once())->method('getSubscriptionId')->with()->willReturn(5);
-		$this->subscriptionDeletedEvent->expects($this->once())->method('getSubscriptionData')->with()->willReturn(['principaluri' => 'principaluri', 'uri' => 'uri']);
-		$this->jobList->expects($this->once())->method('remove')->with(RefreshWebcalJob::class, ['principaluri' => 'principaluri', 'uri' => 'uri']);
-		$this->reminderBackend->expects($this->once())->method('cleanRemindersForCalendar')->with(5);
-		$this->logger->expects($this->exactly(2))->method('debug');
-		$this->calendarPublicationListener->handle($this->subscriptionDeletedEvent);
-	}
+    public function testDeleteSubscriptionEvent(): void {
+        $this->subscriptionDeletedEvent->expects($this->once())->method('getSubscriptionId')->with()->willReturn(5);
+        $this->subscriptionDeletedEvent->expects($this->once())->method('getSubscriptionData')->with()->willReturn(['principaluri' => 'principaluri', 'uri' => 'uri']);
+        $this->jobList->expects($this->once())->method('remove')->with(RefreshWebcalJob::class, ['principaluri' => 'principaluri', 'uri' => 'uri']);
+        $this->reminderBackend->expects($this->once())->method('cleanRemindersForCalendar')->with(5);
+        $this->logger->expects($this->exactly(2))->method('debug');
+        $this->calendarPublicationListener->handle($this->subscriptionDeletedEvent);
+    }
 }

apps/dav/tests/unit/CalDAV/PluginTest.php

Indentation +35 added lines, -35 removed lines

@@ -11,39 +11,39 @@
 use Test\TestCase;
 
 class PluginTest extends TestCase {
-	private Plugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->plugin = new Plugin();
-	}
-
-	public static function linkProvider(): array {
-		return [
-			[
-				'principals/users/MyUserName',
-				'calendars/MyUserName',
-			],
-			[
-				'principals/calendar-resources/Resource-ABC',
-				'system-calendars/calendar-resources/Resource-ABC',
-			],
-			[
-				'principals/calendar-rooms/Room-ABC',
-				'system-calendars/calendar-rooms/Room-ABC',
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider linkProvider
-	 */
-	public function testGetCalendarHomeForPrincipal(string $input, string $expected): void {
-		$this->assertSame($expected, $this->plugin->getCalendarHomeForPrincipal($input));
-	}
-
-	public function testGetCalendarHomeForUnknownPrincipal(): void {
-		$this->assertNull($this->plugin->getCalendarHomeForPrincipal('FOO/BAR/BLUB'));
-	}
+    private Plugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->plugin = new Plugin();
+    }
+
+    public static function linkProvider(): array {
+        return [
+            [
+                'principals/users/MyUserName',
+                'calendars/MyUserName',
+            ],
+            [
+                'principals/calendar-resources/Resource-ABC',
+                'system-calendars/calendar-resources/Resource-ABC',
+            ],
+            [
+                'principals/calendar-rooms/Room-ABC',
+                'system-calendars/calendar-rooms/Room-ABC',
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider linkProvider
+     */
+    public function testGetCalendarHomeForPrincipal(string $input, string $expected): void {
+        $this->assertSame($expected, $this->plugin->getCalendarHomeForPrincipal($input));
+    }
+
+    public function testGetCalendarHomeForUnknownPrincipal(): void {
+        $this->assertNull($this->plugin->getCalendarHomeForPrincipal('FOO/BAR/BLUB'));
+    }
 }