nextcloud / server

apps/dav/tests/unit/CalDAV/CalendarTest.php

Indentation +469 added lines, -469 removed lines

@@ -20,304 +20,304 @@ 
 use Test\TestCase;
 
 class CalendarTest extends TestCase {
-	protected IL10N&MockObject $l10n;
-	protected IConfig&MockObject $config;
-	protected LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-	}
-
-	public function testDelete(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())
-			->method('updateShares');
-		$backend->expects($this->once())
-			->method('unshare');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-
-	public function testDeleteFromGroup(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())
-			->method('updateShares');
-		$backend->expects($this->once())
-			->method('unshare');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public function testDeleteOwn(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())->method('updateShares');
-		$backend->expects($this->never())->method('getShares');
-
-		$this->config->expects($this->never())->method('setUserValue');
-
-		$backend->expects($this->once())->method('deleteCalendar')
-			->with(666);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public function testDeleteBirthdayCalendar(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->once())->method('deleteCalendar')
-			->with(666);
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with('user1', 'dav', 'generateBirthdayCalendar', 'no');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'principals/users/user1',
-			'principaluri' => 'principals/users/user1',
-			'id' => 666,
-			'uri' => 'contact_birthdays',
-			'{DAV:}displayname' => 'Test',
-		];
-
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public static function dataPropPatch(): array {
-		return [
-			['user1', 'user2', [], true],
-			['user1', 'user2', [
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], true],
-			['user1', 'user2', [
-				'{DAV:}displayname' => true,
-			], true],
-			['user1', 'user2', [
-				'{DAV:}displayname' => true,
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], true],
-			['user1', 'user1', [], false],
-			['user1', 'user1', [
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], false],
-			['user1', 'user1', [
-				'{DAV:}displayname' => true,
-			], false],
-			['user1', 'user1', [
-				'{DAV:}displayname' => true,
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], false],
-		];
-	}
-
-	/**
-	 * @dataProvider dataPropPatch
-	 */
-	public function testPropPatch(string $ownerPrincipal, string $principalUri, array $mutations, bool $shared): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => $ownerPrincipal,
-			'principaluri' => $principalUri,
-			'id' => 666,
-			'uri' => 'default'
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$propPatch = new PropPatch($mutations);
-
-		if (!$shared) {
-			$backend->expects($this->once())
-				->method('updateCalendar')
-				->with(666, $propPatch);
-		}
-		$c->propPatch($propPatch);
-		$this->addToAssertionCount(1);
-	}
-
-	/**
-	 * @dataProvider providesReadOnlyInfo
-	 */
-	public function testAcl($expectsWrite, $readOnlyValue, $hasOwnerSet, $uri = 'default'): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-		$calendarInfo = [
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => $uri
-		];
-		$calendarInfo['{DAV:}displayname'] = 'Test';
-		if (!is_null($readOnlyValue)) {
-			$calendarInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
-		}
-		if ($hasOwnerSet) {
-			$calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
-		}
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$acl = $c->getACL();
-		$childAcl = $c->getChildACL();
-
-		$expectedAcl = [[
-			'privilege' => '{DAV:}read',
-			'principal' => $hasOwnerSet ? 'user1' : 'user2',
-			'protected' => true
-		], [
-			'privilege' => '{DAV:}read',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-			'protected' => true,
-		], [
-			'privilege' => '{DAV:}read',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
-			'protected' => true,
-		]];
-		if ($uri === BirthdayService::BIRTHDAY_CALENDAR_URI) {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write-properties',
-				'principal' => $hasOwnerSet ? 'user1' : 'user2',
-				'protected' => true
-			];
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write-properties',
-				'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-				'protected' => true
-			];
-		} else {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write',
-				'principal' => $hasOwnerSet ? 'user1' : 'user2',
-				'protected' => true
-			];
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write',
-				'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-				'protected' => true
-			];
-		}
-
-		$expectedAcl[] = [
-			'privilege' => '{DAV:}write-properties',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
-			'protected' => true
-		];
-
-		if ($hasOwnerSet) {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}read',
-				'principal' => 'user2',
-				'protected' => true
-			];
-			if ($expectsWrite) {
-				$expectedAcl[] = [
-					'privilege' => '{DAV:}write',
-					'principal' => 'user2',
-					'protected' => true
-				];
-			} else {
-				$expectedAcl[] = [
-					'privilege' => '{DAV:}write-properties',
-					'principal' => 'user2',
-					'protected' => true
-				];
-			}
-		}
-		$this->assertEquals($expectedAcl, $acl);
-		$this->assertEquals($expectedAcl, $childAcl);
-	}
-
-	public static function providesReadOnlyInfo(): array {
-		return [
-			'read-only property not set' => [true, null, true],
-			'read-only property is false' => [true, false, true],
-			'read-only property is true' => [false, true, true],
-			'read-only property not set and no owner' => [true, null, false],
-			'read-only property is false and no owner' => [true, false, false],
-			'read-only property is true and no owner' => [false, true, false],
-			'birthday calendar' => [false, false, false, BirthdayService::BIRTHDAY_CALENDAR_URI]
-		];
-	}
-
-	/**
-	 * @dataProvider providesConfidentialClassificationData
-	 */
-	public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject2)->with(666, 'event-2');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		if ($isShared) {
-			$calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
-		}
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$children = $c->getChildren();
-		$this->assertEquals($expectedChildren, count($children));
-		$children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
-		$this->assertEquals($expectedChildren, count($children));
-
-		$this->assertEquals(!$isShared, $c->childExists('event-2'));
-	}
-
-	/**
-	 * @dataProvider providesConfidentialClassificationData
-	 */
-	public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
-		$start = '20160609';
-		$end = '20160610';
-
-		$calData = <<<EOD
+    protected IL10N&MockObject $l10n;
+    protected IConfig&MockObject $config;
+    protected LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+    }
+
+    public function testDelete(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())
+            ->method('updateShares');
+        $backend->expects($this->once())
+            ->method('unshare');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+
+    public function testDeleteFromGroup(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())
+            ->method('updateShares');
+        $backend->expects($this->once())
+            ->method('unshare');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public function testDeleteOwn(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())->method('updateShares');
+        $backend->expects($this->never())->method('getShares');
+
+        $this->config->expects($this->never())->method('setUserValue');
+
+        $backend->expects($this->once())->method('deleteCalendar')
+            ->with(666);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public function testDeleteBirthdayCalendar(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->once())->method('deleteCalendar')
+            ->with(666);
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with('user1', 'dav', 'generateBirthdayCalendar', 'no');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'principals/users/user1',
+            'principaluri' => 'principals/users/user1',
+            'id' => 666,
+            'uri' => 'contact_birthdays',
+            '{DAV:}displayname' => 'Test',
+        ];
+
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public static function dataPropPatch(): array {
+        return [
+            ['user1', 'user2', [], true],
+            ['user1', 'user2', [
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], true],
+            ['user1', 'user2', [
+                '{DAV:}displayname' => true,
+            ], true],
+            ['user1', 'user2', [
+                '{DAV:}displayname' => true,
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], true],
+            ['user1', 'user1', [], false],
+            ['user1', 'user1', [
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], false],
+            ['user1', 'user1', [
+                '{DAV:}displayname' => true,
+            ], false],
+            ['user1', 'user1', [
+                '{DAV:}displayname' => true,
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], false],
+        ];
+    }
+
+    /**
+     * @dataProvider dataPropPatch
+     */
+    public function testPropPatch(string $ownerPrincipal, string $principalUri, array $mutations, bool $shared): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => $ownerPrincipal,
+            'principaluri' => $principalUri,
+            'id' => 666,
+            'uri' => 'default'
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $propPatch = new PropPatch($mutations);
+
+        if (!$shared) {
+            $backend->expects($this->once())
+                ->method('updateCalendar')
+                ->with(666, $propPatch);
+        }
+        $c->propPatch($propPatch);
+        $this->addToAssertionCount(1);
+    }
+
+    /**
+     * @dataProvider providesReadOnlyInfo
+     */
+    public function testAcl($expectsWrite, $readOnlyValue, $hasOwnerSet, $uri = 'default'): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+        $calendarInfo = [
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => $uri
+        ];
+        $calendarInfo['{DAV:}displayname'] = 'Test';
+        if (!is_null($readOnlyValue)) {
+            $calendarInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
+        }
+        if ($hasOwnerSet) {
+            $calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
+        }
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $acl = $c->getACL();
+        $childAcl = $c->getChildACL();
+
+        $expectedAcl = [[
+            'privilege' => '{DAV:}read',
+            'principal' => $hasOwnerSet ? 'user1' : 'user2',
+            'protected' => true
+        ], [
+            'privilege' => '{DAV:}read',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+            'protected' => true,
+        ], [
+            'privilege' => '{DAV:}read',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
+            'protected' => true,
+        ]];
+        if ($uri === BirthdayService::BIRTHDAY_CALENDAR_URI) {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => $hasOwnerSet ? 'user1' : 'user2',
+                'protected' => true
+            ];
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+                'protected' => true
+            ];
+        } else {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write',
+                'principal' => $hasOwnerSet ? 'user1' : 'user2',
+                'protected' => true
+            ];
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write',
+                'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+                'protected' => true
+            ];
+        }
+
+        $expectedAcl[] = [
+            'privilege' => '{DAV:}write-properties',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
+            'protected' => true
+        ];
+
+        if ($hasOwnerSet) {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user2',
+                'protected' => true
+            ];
+            if ($expectsWrite) {
+                $expectedAcl[] = [
+                    'privilege' => '{DAV:}write',
+                    'principal' => 'user2',
+                    'protected' => true
+                ];
+            } else {
+                $expectedAcl[] = [
+                    'privilege' => '{DAV:}write-properties',
+                    'principal' => 'user2',
+                    'protected' => true
+                ];
+            }
+        }
+        $this->assertEquals($expectedAcl, $acl);
+        $this->assertEquals($expectedAcl, $childAcl);
+    }
+
+    public static function providesReadOnlyInfo(): array {
+        return [
+            'read-only property not set' => [true, null, true],
+            'read-only property is false' => [true, false, true],
+            'read-only property is true' => [false, true, true],
+            'read-only property not set and no owner' => [true, null, false],
+            'read-only property is false and no owner' => [true, false, false],
+            'read-only property is true and no owner' => [false, true, false],
+            'birthday calendar' => [false, false, false, BirthdayService::BIRTHDAY_CALENDAR_URI]
+        ];
+    }
+
+    /**
+     * @dataProvider providesConfidentialClassificationData
+     */
+    public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject2)->with(666, 'event-2');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        if ($isShared) {
+            $calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
+        }
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $children = $c->getChildren();
+        $this->assertEquals($expectedChildren, count($children));
+        $children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
+        $this->assertEquals($expectedChildren, count($children));
+
+        $this->assertEquals(!$isShared, $c->childExists('event-2'));
+    }
+
+    /**
+     * @dataProvider providesConfidentialClassificationData
+     */
+    public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
+        $start = '20160609';
+        $end = '20160610';
+
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//ownCloud calendar v1.2.2
 BEGIN:VEVENT
@@ -359,84 +359,84 @@ 
 END:VCALENDAR
 EOD;
 
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject1)->with(666, 'event-1');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => $isShared ? 'user1' : 'user2',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-
-		$this->assertEquals(count($c->getChildren()), $expectedChildren);
-
-		// test private event
-		$privateEvent = $c->getChild('event-1');
-		$calData = $privateEvent->get();
-		$event = Reader::read($calData);
-
-		$this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
-		$this->assertEquals($end, $event->VEVENT->DTEND->getValue());
-
-		if ($isShared) {
-			$this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
-			$this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
-			$this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
-			$this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
-			$this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
-		} else {
-			$this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
-		}
-
-		// Test l10n
-		$l10n = $this->createMock(IL10N::class);
-		if ($isShared) {
-			$l10n->expects($this->once())
-				->method('t')
-				->with('Busy')
-				->willReturn('Translated busy');
-		} else {
-			$l10n->expects($this->never())
-				->method('t');
-		}
-		$c = new Calendar($backend, $calendarInfo, $l10n, $this->config, $this->logger);
-
-		$calData = $c->getChild('event-1')->get();
-		$event = Reader::read($calData);
-
-		if ($isShared) {
-			$this->assertEquals('Translated busy', $event->VEVENT->SUMMARY->getValue());
-		} else {
-			$this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
-		}
-	}
-
-	public static function providesConfidentialClassificationData(): array {
-		return [
-			[3, false],
-			[2, true]
-		];
-	}
-
-	public function testRemoveVAlarms(): void {
-		$publicObjectData = <<<EOD
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject1)->with(666, 'event-1');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => $isShared ? 'user1' : 'user2',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+
+        $this->assertEquals(count($c->getChildren()), $expectedChildren);
+
+        // test private event
+        $privateEvent = $c->getChild('event-1');
+        $calData = $privateEvent->get();
+        $event = Reader::read($calData);
+
+        $this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
+        $this->assertEquals($end, $event->VEVENT->DTEND->getValue());
+
+        if ($isShared) {
+            $this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
+            $this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
+            $this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
+            $this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
+            $this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
+        } else {
+            $this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
+        }
+
+        // Test l10n
+        $l10n = $this->createMock(IL10N::class);
+        if ($isShared) {
+            $l10n->expects($this->once())
+                ->method('t')
+                ->with('Busy')
+                ->willReturn('Translated busy');
+        } else {
+            $l10n->expects($this->never())
+                ->method('t');
+        }
+        $c = new Calendar($backend, $calendarInfo, $l10n, $this->config, $this->logger);
+
+        $calData = $c->getChild('event-1')->get();
+        $event = Reader::read($calData);
+
+        if ($isShared) {
+            $this->assertEquals('Translated busy', $event->VEVENT->SUMMARY->getValue());
+        } else {
+            $this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
+        }
+    }
+
+    public static function providesConfidentialClassificationData(): array {
+        return [
+            [3, false],
+            [2, true]
+        ];
+    }
+
+    public function testRemoveVAlarms(): void {
+        $publicObjectData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -460,7 +460,7 @@ 
 
 EOD;
 
-		$confidentialObjectData = <<<EOD
+        $confidentialObjectData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -484,7 +484,7 @@ 
 
 EOD;
 
-		$publicObjectDataWithoutVAlarm = <<<EOD
+        $publicObjectDataWithoutVAlarm = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -504,7 +504,7 @@ 
 
 EOD;
 
-		$confidentialObjectCleaned = <<<EOD
+        $confidentialObjectCleaned = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -523,94 +523,94 @@ 
 
 
 
-		$publicObject = ['uri' => 'event-0',
-			'classification' => CalDavBackend::CLASSIFICATION_PUBLIC,
-			'calendardata' => $publicObjectData];
-
-		$confidentialObject = ['uri' => 'event-1',
-			'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL,
-			'calendardata' => $confidentialObjectData];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())
-			->method('getCalendarObjects')
-			->willReturn([$publicObject, $confidentialObject]);
-
-		$backend->expects($this->any())
-			->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1'])
-			->willReturn([$publicObject, $confidentialObject]);
-
-		$backend->expects($this->any())
-			->method('getCalendarObject')
-			->willReturnCallback(function ($cId, $uri) use ($publicObject, $confidentialObject) {
-				switch ($uri) {
-					case 'event-0':
-						return $publicObject;
-
-					case 'event-1':
-						return $confidentialObject;
-
-					default:
-						throw new \Exception('unexpected uri');
-				}
-			});
-
-		$backend->expects($this->any())
-			->method('applyShareAcl')
-			->willReturnArgument(1);
-
-		$calendarInfoOwner = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$calendarInfoSharedRW = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$calendarInfoSharedRO = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{http://owncloud.org/ns}read-only' => true,
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$ownerCalendar = new Calendar($backend, $calendarInfoOwner, $this->l10n, $this->config, $this->logger);
-		$rwCalendar = new Calendar($backend, $calendarInfoSharedRW, $this->l10n, $this->config, $this->logger);
-		$roCalendar = new Calendar($backend, $calendarInfoSharedRO, $this->l10n, $this->config, $this->logger);
-
-		$this->assertCount(2, $ownerCalendar->getChildren());
-		$this->assertCount(2, $rwCalendar->getChildren());
-		$this->assertCount(2, $roCalendar->getChildren());
-
-		// calendar data shall not be altered for the owner
-		$this->assertEquals($ownerCalendar->getChild('event-0')->get(), $publicObjectData);
-		$this->assertEquals($ownerCalendar->getChild('event-1')->get(), $confidentialObjectData);
-
-		// valarms shall not be removed for read-write shares
-		$this->assertEquals(
-			$this->fixLinebreak($rwCalendar->getChild('event-0')->get()),
-			$this->fixLinebreak($publicObjectData));
-		$this->assertEquals(
-			$this->fixLinebreak($rwCalendar->getChild('event-1')->get()),
-			$this->fixLinebreak($confidentialObjectCleaned));
-
-		// valarms shall be removed for read-only shares
-		$this->assertEquals(
-			$this->fixLinebreak($roCalendar->getChild('event-0')->get()),
-			$this->fixLinebreak($publicObjectDataWithoutVAlarm));
-		$this->assertEquals(
-			$this->fixLinebreak($roCalendar->getChild('event-1')->get()),
-			$this->fixLinebreak($confidentialObjectCleaned));
-	}
-
-	private function fixLinebreak(string $str): string {
-		return preg_replace('~(*BSR_ANYCRLF)\R~', "\r\n", $str);
-	}
+        $publicObject = ['uri' => 'event-0',
+            'classification' => CalDavBackend::CLASSIFICATION_PUBLIC,
+            'calendardata' => $publicObjectData];
+
+        $confidentialObject = ['uri' => 'event-1',
+            'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL,
+            'calendardata' => $confidentialObjectData];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())
+            ->method('getCalendarObjects')
+            ->willReturn([$publicObject, $confidentialObject]);
+
+        $backend->expects($this->any())
+            ->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1'])
+            ->willReturn([$publicObject, $confidentialObject]);
+
+        $backend->expects($this->any())
+            ->method('getCalendarObject')
+            ->willReturnCallback(function ($cId, $uri) use ($publicObject, $confidentialObject) {
+                switch ($uri) {
+                    case 'event-0':
+                        return $publicObject;
+
+                    case 'event-1':
+                        return $confidentialObject;
+
+                    default:
+                        throw new \Exception('unexpected uri');
+                }
+            });
+
+        $backend->expects($this->any())
+            ->method('applyShareAcl')
+            ->willReturnArgument(1);
+
+        $calendarInfoOwner = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $calendarInfoSharedRW = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $calendarInfoSharedRO = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{http://owncloud.org/ns}read-only' => true,
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $ownerCalendar = new Calendar($backend, $calendarInfoOwner, $this->l10n, $this->config, $this->logger);
+        $rwCalendar = new Calendar($backend, $calendarInfoSharedRW, $this->l10n, $this->config, $this->logger);
+        $roCalendar = new Calendar($backend, $calendarInfoSharedRO, $this->l10n, $this->config, $this->logger);
+
+        $this->assertCount(2, $ownerCalendar->getChildren());
+        $this->assertCount(2, $rwCalendar->getChildren());
+        $this->assertCount(2, $roCalendar->getChildren());
+
+        // calendar data shall not be altered for the owner
+        $this->assertEquals($ownerCalendar->getChild('event-0')->get(), $publicObjectData);
+        $this->assertEquals($ownerCalendar->getChild('event-1')->get(), $confidentialObjectData);
+
+        // valarms shall not be removed for read-write shares
+        $this->assertEquals(
+            $this->fixLinebreak($rwCalendar->getChild('event-0')->get()),
+            $this->fixLinebreak($publicObjectData));
+        $this->assertEquals(
+            $this->fixLinebreak($rwCalendar->getChild('event-1')->get()),
+            $this->fixLinebreak($confidentialObjectCleaned));
+
+        // valarms shall be removed for read-only shares
+        $this->assertEquals(
+            $this->fixLinebreak($roCalendar->getChild('event-0')->get()),
+            $this->fixLinebreak($publicObjectDataWithoutVAlarm));
+        $this->assertEquals(
+            $this->fixLinebreak($roCalendar->getChild('event-1')->get()),
+            $this->fixLinebreak($confidentialObjectCleaned));
+    }
+
+    private function fixLinebreak(string $str): string {
+        return preg_replace('~(*BSR_ANYCRLF)\R~', "\r\n", $str);
+    }
 }

apps/dav/tests/unit/CalDAV/Search/Request/CalendarSearchReportTest.php

Indentation +177 added lines, -177 removed lines

@@ -12,13 +12,13 @@ 
 use Test\TestCase;
 
 class CalendarSearchReportTest extends TestCase {
-	private array $elementMap = [
-		'{http://nextcloud.com/ns}calendar-search' =>
-			'OCA\\DAV\\CalDAV\\Search\\Xml\\Request\\CalendarSearchReport',
-	];
+    private array $elementMap = [
+        '{http://nextcloud.com/ns}calendar-search' =>
+            'OCA\\DAV\\CalDAV\\Search\\Xml\\Request\\CalendarSearchReport',
+    ];
 
-	public function testFoo(): void {
-		$xml = <<<XML
+    public function testFoo(): void {
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -39,42 +39,42 @@ 
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
-
-		$calendarSearchReport = new CalendarSearchReport();
-		$calendarSearchReport->properties = [
-			'{DAV:}getetag',
-			'{urn:ietf:params:xml:ns:caldav}calendar-data',
-		];
-		$calendarSearchReport->filters = [
-			'comps' => [
-				'VEVENT',
-				'VTODO'
-			],
-			'props' => [
-				'SUMMARY',
-				'LOCATION',
-				'ATTENDEE'
-			],
-			'params' => [
-				[
-					'property' => 'ATTENDEE',
-					'parameter' => 'CN'
-				]
-			],
-			'search-term' => 'foo'
-		];
-		$calendarSearchReport->limit = 10;
-		$calendarSearchReport->offset = 5;
-
-		$this->assertEquals(
-			$calendarSearchReport,
-			$result['value']
-		);
-	}
-
-	public function testNoLimitOffset(): void {
-		$xml = <<<XML
+        $result = $this->parse($xml);
+
+        $calendarSearchReport = new CalendarSearchReport();
+        $calendarSearchReport->properties = [
+            '{DAV:}getetag',
+            '{urn:ietf:params:xml:ns:caldav}calendar-data',
+        ];
+        $calendarSearchReport->filters = [
+            'comps' => [
+                'VEVENT',
+                'VTODO'
+            ],
+            'props' => [
+                'SUMMARY',
+                'LOCATION',
+                'ATTENDEE'
+            ],
+            'params' => [
+                [
+                    'property' => 'ATTENDEE',
+                    'parameter' => 'CN'
+                ]
+            ],
+            'search-term' => 'foo'
+        ];
+        $calendarSearchReport->limit = 10;
+        $calendarSearchReport->offset = 5;
+
+        $this->assertEquals(
+            $calendarSearchReport,
+            $result['value']
+        );
+    }
+
+    public function testNoLimitOffset(): void {
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -89,37 +89,37 @@ 
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
-
-		$calendarSearchReport = new CalendarSearchReport();
-		$calendarSearchReport->properties = [
-			'{DAV:}getetag',
-			'{urn:ietf:params:xml:ns:caldav}calendar-data',
-		];
-		$calendarSearchReport->filters = [
-			'comps' => [
-				'VEVENT',
-			],
-			'props' => [
-				'SUMMARY',
-			],
-			'search-term' => 'foo'
-		];
-		$calendarSearchReport->limit = null;
-		$calendarSearchReport->offset = null;
-
-		$this->assertEquals(
-			$calendarSearchReport,
-			$result['value']
-		);
-	}
-
-
-	public function testRequiresCompFilter(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
-		$this->expectExceptionMessage('{http://nextcloud.com/ns}prop-filter or {http://nextcloud.com/ns}param-filter given without any {http://nextcloud.com/ns}comp-filter');
-
-		$xml = <<<XML
+        $result = $this->parse($xml);
+
+        $calendarSearchReport = new CalendarSearchReport();
+        $calendarSearchReport->properties = [
+            '{DAV:}getetag',
+            '{urn:ietf:params:xml:ns:caldav}calendar-data',
+        ];
+        $calendarSearchReport->filters = [
+            'comps' => [
+                'VEVENT',
+            ],
+            'props' => [
+                'SUMMARY',
+            ],
+            'search-term' => 'foo'
+        ];
+        $calendarSearchReport->limit = null;
+        $calendarSearchReport->offset = null;
+
+        $this->assertEquals(
+            $calendarSearchReport,
+            $result['value']
+        );
+    }
+
+
+    public function testRequiresCompFilter(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+        $this->expectExceptionMessage('{http://nextcloud.com/ns}prop-filter or {http://nextcloud.com/ns}param-filter given without any {http://nextcloud.com/ns}comp-filter');
+
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -138,15 +138,15 @@ 
 </nc:calendar-search>
 XML;
 
-		$this->parse($xml);
-	}
+        $this->parse($xml);
+    }
 
 
-	public function testRequiresFilter(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
-		$this->expectExceptionMessage('The {http://nextcloud.com/ns}filter element is required for this request');
+    public function testRequiresFilter(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+        $this->expectExceptionMessage('The {http://nextcloud.com/ns}filter element is required for this request');
 
-		$xml = <<<XML
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -156,15 +156,15 @@ 
 </nc:calendar-search>
 XML;
 
-		$this->parse($xml);
-	}
+        $this->parse($xml);
+    }
 
 
-	public function testNoSearchTerm(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
-		$this->expectExceptionMessage('{http://nextcloud.com/ns}search-term is required for this request');
+    public function testNoSearchTerm(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+        $this->expectExceptionMessage('{http://nextcloud.com/ns}search-term is required for this request');
 
-		$xml = <<<XML
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -184,15 +184,15 @@ 
 </nc:calendar-search>
 XML;
 
-		$this->parse($xml);
-	}
+        $this->parse($xml);
+    }
 
 
-	public function testCompOnly(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
-		$this->expectExceptionMessage('At least one{http://nextcloud.com/ns}prop-filter or {http://nextcloud.com/ns}param-filter is required for this request');
+    public function testCompOnly(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+        $this->expectExceptionMessage('At least one{http://nextcloud.com/ns}prop-filter or {http://nextcloud.com/ns}param-filter is required for this request');
 
-		$xml = <<<XML
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -207,31 +207,31 @@ 
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
-
-		$calendarSearchReport = new CalendarSearchReport();
-		$calendarSearchReport->properties = [
-			'{DAV:}getetag',
-			'{urn:ietf:params:xml:ns:caldav}calendar-data',
-		];
-		$calendarSearchReport->filters = [
-			'comps' => [
-				'VEVENT',
-				'VTODO'
-			],
-			'search-term' => 'foo'
-		];
-		$calendarSearchReport->limit = null;
-		$calendarSearchReport->offset = null;
-
-		$this->assertEquals(
-			$calendarSearchReport,
-			$result['value']
-		);
-	}
-
-	public function testPropOnly(): void {
-		$xml = <<<XML
+        $result = $this->parse($xml);
+
+        $calendarSearchReport = new CalendarSearchReport();
+        $calendarSearchReport->properties = [
+            '{DAV:}getetag',
+            '{urn:ietf:params:xml:ns:caldav}calendar-data',
+        ];
+        $calendarSearchReport->filters = [
+            'comps' => [
+                'VEVENT',
+                'VTODO'
+            ],
+            'search-term' => 'foo'
+        ];
+        $calendarSearchReport->limit = null;
+        $calendarSearchReport->offset = null;
+
+        $this->assertEquals(
+            $calendarSearchReport,
+            $result['value']
+        );
+    }
+
+    public function testPropOnly(): void {
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -246,33 +246,33 @@ 
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
-
-		$calendarSearchReport = new CalendarSearchReport();
-		$calendarSearchReport->properties = [
-			'{DAV:}getetag',
-			'{urn:ietf:params:xml:ns:caldav}calendar-data',
-		];
-		$calendarSearchReport->filters = [
-			'comps' => [
-				'VEVENT',
-			],
-			'props' => [
-				'SUMMARY',
-			],
-			'search-term' => 'foo'
-		];
-		$calendarSearchReport->limit = null;
-		$calendarSearchReport->offset = null;
-
-		$this->assertEquals(
-			$calendarSearchReport,
-			$result['value']
-		);
-	}
-
-	public function testParamOnly(): void {
-		$xml = <<<XML
+        $result = $this->parse($xml);
+
+        $calendarSearchReport = new CalendarSearchReport();
+        $calendarSearchReport->properties = [
+            '{DAV:}getetag',
+            '{urn:ietf:params:xml:ns:caldav}calendar-data',
+        ];
+        $calendarSearchReport->filters = [
+            'comps' => [
+                'VEVENT',
+            ],
+            'props' => [
+                'SUMMARY',
+            ],
+            'search-term' => 'foo'
+        ];
+        $calendarSearchReport->limit = null;
+        $calendarSearchReport->offset = null;
+
+        $this->assertEquals(
+            $calendarSearchReport,
+            $result['value']
+        );
+    }
+
+    public function testParamOnly(): void {
+        $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
 <nc:calendar-search xmlns:nc="http://nextcloud.com/ns" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:">
    <d:prop>
@@ -287,38 +287,38 @@ 
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
-
-		$calendarSearchReport = new CalendarSearchReport();
-		$calendarSearchReport->properties = [
-			'{DAV:}getetag',
-			'{urn:ietf:params:xml:ns:caldav}calendar-data',
-		];
-		$calendarSearchReport->filters = [
-			'comps' => [
-				'VEVENT',
-			],
-			'params' => [
-				[
-					'property' => 'ATTENDEE',
-					'parameter' => 'CN'
-				]
-			],
-			'search-term' => 'foo'
-		];
-		$calendarSearchReport->limit = null;
-		$calendarSearchReport->offset = null;
-
-		$this->assertEquals(
-			$calendarSearchReport,
-			$result['value']
-		);
-	}
-
-	private function parse(string $xml, array $elementMap = []): array {
-		$reader = new Reader();
-		$reader->elementMap = array_merge($this->elementMap, $elementMap);
-		$reader->xml($xml);
-		return $reader->parse();
-	}
+        $result = $this->parse($xml);
+
+        $calendarSearchReport = new CalendarSearchReport();
+        $calendarSearchReport->properties = [
+            '{DAV:}getetag',
+            '{urn:ietf:params:xml:ns:caldav}calendar-data',
+        ];
+        $calendarSearchReport->filters = [
+            'comps' => [
+                'VEVENT',
+            ],
+            'params' => [
+                [
+                    'property' => 'ATTENDEE',
+                    'parameter' => 'CN'
+                ]
+            ],
+            'search-term' => 'foo'
+        ];
+        $calendarSearchReport->limit = null;
+        $calendarSearchReport->offset = null;
+
+        $this->assertEquals(
+            $calendarSearchReport,
+            $result['value']
+        );
+    }
+
+    private function parse(string $xml, array $elementMap = []): array {
+        $reader = new Reader();
+        $reader->elementMap = array_merge($this->elementMap, $elementMap);
+        $reader->xml($xml);
+        return $reader->parse();
+    }
 }

apps/dav/tests/unit/CalDAV/Publishing/PublishingTest.php

Indentation +42 added lines, -42 removed lines

@@ -20,55 +20,55 @@
 use Test\TestCase;
 
 class PublishingTest extends TestCase {
-	private PublishPlugin $plugin;
-	private Server $server;
-	private Calendar&MockObject $book;
-	private IConfig&MockObject $config;
-	private IURLGenerator&MockObject $urlGenerator;
+    private PublishPlugin $plugin;
+    private Server $server;
+    private Calendar&MockObject $book;
+    private IConfig&MockObject $config;
+    private IURLGenerator&MockObject $urlGenerator;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->createMock(IConfig::class);
-		$this->config->expects($this->any())->method('getSystemValue')
-			->with($this->equalTo('secret'))
-			->willReturn('mysecret');
+        $this->config = $this->createMock(IConfig::class);
+        $this->config->expects($this->any())->method('getSystemValue')
+            ->with($this->equalTo('secret'))
+            ->willReturn('mysecret');
 
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
 
-		/** @var IRequest $request */
-		$this->plugin = new PublishPlugin($this->config, $this->urlGenerator);
+        /** @var IRequest $request */
+        $this->plugin = new PublishPlugin($this->config, $this->urlGenerator);
 
-		$root = new SimpleCollection('calendars');
-		$this->server = new Server($root);
-		/** @var SimpleCollection $node */
-		$this->book = $this->getMockBuilder(Calendar::class)->
-			disableOriginalConstructor()->
-			getMock();
-		$this->book->method('getName')->willReturn('cal1');
-		$root->addChild($this->book);
-		$this->plugin->initialize($this->server);
-	}
+        $root = new SimpleCollection('calendars');
+        $this->server = new Server($root);
+        /** @var SimpleCollection $node */
+        $this->book = $this->getMockBuilder(Calendar::class)->
+            disableOriginalConstructor()->
+            getMock();
+        $this->book->method('getName')->willReturn('cal1');
+        $root->addChild($this->book);
+        $this->plugin->initialize($this->server);
+    }
 
-	public function testPublishing(): void {
-		$this->book->expects($this->once())->method('setPublishStatus')->with(true);
+    public function testPublishing(): void {
+        $this->book->expects($this->once())->method('setPublishStatus')->with(true);
 
-		// setup request
-		$request = new Request('POST', 'cal1');
-		$request->addHeader('Content-Type', 'application/xml');
-		$request->setBody('<o:publish-calendar xmlns:o="http://calendarserver.org/ns/"/>');
-		$response = new Response();
-		$this->plugin->httpPost($request, $response);
-	}
+        // setup request
+        $request = new Request('POST', 'cal1');
+        $request->addHeader('Content-Type', 'application/xml');
+        $request->setBody('<o:publish-calendar xmlns:o="http://calendarserver.org/ns/"/>');
+        $response = new Response();
+        $this->plugin->httpPost($request, $response);
+    }
 
-	public function testUnPublishing(): void {
-		$this->book->expects($this->once())->method('setPublishStatus')->with(false);
+    public function testUnPublishing(): void {
+        $this->book->expects($this->once())->method('setPublishStatus')->with(false);
 
-		// setup request
-		$request = new Request('POST', 'cal1');
-		$request->addHeader('Content-Type', 'application/xml');
-		$request->setBody('<o:unpublish-calendar xmlns:o="http://calendarserver.org/ns/"/>');
-		$response = new Response();
-		$this->plugin->httpPost($request, $response);
-	}
+        // setup request
+        $request = new Request('POST', 'cal1');
+        $request->addHeader('Content-Type', 'application/xml');
+        $request->setBody('<o:unpublish-calendar xmlns:o="http://calendarserver.org/ns/"/>');
+        $response = new Response();
+        $this->plugin->httpPost($request, $response);
+    }
 }

apps/dav/tests/unit/CalDAV/Publishing/PublisherTest.php

Indentation +34 added lines, -34 removed lines

@@ -12,50 +12,50 @@
 use Test\TestCase;
 
 class PublisherTest extends TestCase {
-	public const NS_CALENDARSERVER = 'http://calendarserver.org/ns/';
+    public const NS_CALENDARSERVER = 'http://calendarserver.org/ns/';
 
-	public function testSerializePublished(): void {
-		$publish = new Publisher('urltopublish', true);
+    public function testSerializePublished(): void {
+        $publish = new Publisher('urltopublish', true);
 
-		$xml = $this->write([
-			'{' . self::NS_CALENDARSERVER . '}publish-url' => $publish,
-		]);
+        $xml = $this->write([
+            '{' . self::NS_CALENDARSERVER . '}publish-url' => $publish,
+        ]);
 
-		$this->assertEquals('urltopublish', $publish->getValue());
+        $this->assertEquals('urltopublish', $publish->getValue());
 
-		$this->assertXmlStringEqualsXmlString(
-			'<?xml version="1.0"?>
+        $this->assertXmlStringEqualsXmlString(
+            '<?xml version="1.0"?>
 			<x1:publish-url xmlns:d="DAV:" xmlns:x1="' . self::NS_CALENDARSERVER . '">
 			<d:href>urltopublish</d:href>
 			</x1:publish-url>', $xml);
-	}
+    }
 
-	public function testSerializeNotPublished(): void {
-		$publish = new Publisher('urltopublish', false);
+    public function testSerializeNotPublished(): void {
+        $publish = new Publisher('urltopublish', false);
 
-		$xml = $this->write([
-			'{' . self::NS_CALENDARSERVER . '}pre-publish-url' => $publish,
-		]);
+        $xml = $this->write([
+            '{' . self::NS_CALENDARSERVER . '}pre-publish-url' => $publish,
+        ]);
 
-		$this->assertEquals('urltopublish', $publish->getValue());
+        $this->assertEquals('urltopublish', $publish->getValue());
 
-		$this->assertXmlStringEqualsXmlString(
-			'<?xml version="1.0"?>
+        $this->assertXmlStringEqualsXmlString(
+            '<?xml version="1.0"?>
 			<x1:pre-publish-url xmlns:d="DAV:" xmlns:x1="' . self::NS_CALENDARSERVER . '">urltopublish</x1:pre-publish-url>', $xml);
-	}
-
-
-	protected array $elementMap = [];
-	protected array $namespaceMap = ['DAV:' => 'd'];
-	protected string $contextUri = '/';
-
-	private function write($input) {
-		$writer = new Writer();
-		$writer->contextUri = $this->contextUri;
-		$writer->namespaceMap = $this->namespaceMap;
-		$writer->openMemory();
-		$writer->setIndent(true);
-		$writer->write($input);
-		return $writer->outputMemory();
-	}
+    }
+
+
+    protected array $elementMap = [];
+    protected array $namespaceMap = ['DAV:' => 'd'];
+    protected string $contextUri = '/';
+
+    private function write($input) {
+        $writer = new Writer();
+        $writer->contextUri = $this->contextUri;
+        $writer->namespaceMap = $this->namespaceMap;
+        $writer->openMemory();
+        $writer->setIndent(true);
+        $writer->write($input);
+        return $writer->outputMemory();
+    }
 }

apps/dav/tests/unit/CalDAV/CachedSubscriptionTest.php

Indentation +281 added lines, -281 removed lines

@@ -11,285 +11,285 @@
 use Sabre\DAV\PropPatch;
 
 class CachedSubscriptionTest extends \Test\TestCase {
-	public function testGetACL(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$this->assertEquals([
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1/calendar-proxy-write',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1/calendar-proxy-read',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{urn:ietf:params:xml:ns:caldav}read-free-busy',
-				'principal' => '{DAV:}authenticated',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}write-properties',
-				'principal' => 'user1',
-				'protected' => 'true'
-			]
-		], $calendar->getACL());
-	}
-
-	public function testGetChildACL(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$this->assertEquals([
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1/calendar-proxy-write',
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => 'user1/calendar-proxy-read',
-				'protected' => true,
-			]
-		], $calendar->getChildACL());
-	}
-
-	public function testGetOwner(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$this->assertEquals('user1', $calendar->getOwner());
-	}
-
-	public function testDelete(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$backend->expects($this->once())
-			->method('deleteSubscription')
-			->with(666);
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$calendar->delete();
-	}
-
-	public function testPropPatch(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$propPatch = $this->createMock(PropPatch::class);
-
-		$backend->expects($this->once())
-			->method('updateSubscription')
-			->with(666, $propPatch);
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$calendar->propPatch($propPatch);
-	}
-
-
-	public function testGetChild(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('Calendar object not found');
-
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calls = [
-			[666, 'foo1', 1, [
-				'id' => 99,
-				'uri' => 'foo1'
-			]],
-			[666, 'foo2', 1, null],
-		];
-		$backend->expects($this->exactly(2))
-			->method('getCalendarObject')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$return = array_pop($expected);
-				$this->assertEquals($expected, func_get_args());
-				return $return;
-			});
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-
-		$first = $calendar->getChild('foo1');
-		$this->assertInstanceOf(CachedSubscriptionObject::class, $first);
-
-		$calendar->getChild('foo2');
-	}
-
-	public function testGetChildren(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$backend->expects($this->once())
-			->method('getCalendarObjects')
-			->with(666, 1)
-			->willReturn([
-				[
-					'id' => 99,
-					'uri' => 'foo1'
-				],
-				[
-					'id' => 100,
-					'uri' => 'foo2'
-				],
-			]);
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-
-		$res = $calendar->getChildren();
-		$this->assertCount(2, $res);
-		$this->assertInstanceOf(CachedSubscriptionObject::class, $res[0]);
-		$this->assertInstanceOf(CachedSubscriptionObject::class, $res[1]);
-	}
-
-	public function testGetMultipleChildren(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$backend->expects($this->once())
-			->method('getMultipleCalendarObjects')
-			->with(666, ['foo1', 'foo2'], 1)
-			->willReturn([
-				[
-					'id' => 99,
-					'uri' => 'foo1'
-				],
-				[
-					'id' => 100,
-					'uri' => 'foo2'
-				],
-			]);
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-
-		$res = $calendar->getMultipleChildren(['foo1', 'foo2']);
-		$this->assertCount(2, $res);
-		$this->assertInstanceOf(CachedSubscriptionObject::class, $res[0]);
-		$this->assertInstanceOf(CachedSubscriptionObject::class, $res[1]);
-	}
-
-
-	public function testCreateFile(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('Creating objects in cached subscription is not allowed');
-
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-		$calendar->createFile('foo', []);
-	}
-
-	public function testChildExists(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$calls = [
-			[666, 'foo1', 1, [
-				'id' => 99,
-				'uri' => 'foo1'
-			]],
-			[666, 'foo2', 1, null],
-		];
-		$backend->expects($this->exactly(2))
-			->method('getCalendarObject')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$return = array_pop($expected);
-				$this->assertEquals($expected, func_get_args());
-				return $return;
-			});
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-
-		$this->assertEquals(true, $calendar->childExists('foo1'));
-		$this->assertEquals(false, $calendar->childExists('foo2'));
-	}
-
-	public function testCalendarQuery(): void {
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$backend->expects($this->once())
-			->method('calendarQuery')
-			->with(666, ['foo'], 1)
-			->willReturn([99]);
-
-		$calendar = new CachedSubscription($backend, $calendarInfo);
-
-		$this->assertEquals([99], $calendar->calendarQuery(['foo']));
-	}
+    public function testGetACL(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $this->assertEquals([
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1/calendar-proxy-write',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1/calendar-proxy-read',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{urn:ietf:params:xml:ns:caldav}read-free-busy',
+                'principal' => '{DAV:}authenticated',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => 'user1',
+                'protected' => 'true'
+            ]
+        ], $calendar->getACL());
+    }
+
+    public function testGetChildACL(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $this->assertEquals([
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1/calendar-proxy-write',
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user1/calendar-proxy-read',
+                'protected' => true,
+            ]
+        ], $calendar->getChildACL());
+    }
+
+    public function testGetOwner(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $this->assertEquals('user1', $calendar->getOwner());
+    }
+
+    public function testDelete(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $backend->expects($this->once())
+            ->method('deleteSubscription')
+            ->with(666);
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $calendar->delete();
+    }
+
+    public function testPropPatch(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $propPatch = $this->createMock(PropPatch::class);
+
+        $backend->expects($this->once())
+            ->method('updateSubscription')
+            ->with(666, $propPatch);
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $calendar->propPatch($propPatch);
+    }
+
+
+    public function testGetChild(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('Calendar object not found');
+
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calls = [
+            [666, 'foo1', 1, [
+                'id' => 99,
+                'uri' => 'foo1'
+            ]],
+            [666, 'foo2', 1, null],
+        ];
+        $backend->expects($this->exactly(2))
+            ->method('getCalendarObject')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $return = array_pop($expected);
+                $this->assertEquals($expected, func_get_args());
+                return $return;
+            });
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+
+        $first = $calendar->getChild('foo1');
+        $this->assertInstanceOf(CachedSubscriptionObject::class, $first);
+
+        $calendar->getChild('foo2');
+    }
+
+    public function testGetChildren(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $backend->expects($this->once())
+            ->method('getCalendarObjects')
+            ->with(666, 1)
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'uri' => 'foo1'
+                ],
+                [
+                    'id' => 100,
+                    'uri' => 'foo2'
+                ],
+            ]);
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+
+        $res = $calendar->getChildren();
+        $this->assertCount(2, $res);
+        $this->assertInstanceOf(CachedSubscriptionObject::class, $res[0]);
+        $this->assertInstanceOf(CachedSubscriptionObject::class, $res[1]);
+    }
+
+    public function testGetMultipleChildren(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $backend->expects($this->once())
+            ->method('getMultipleCalendarObjects')
+            ->with(666, ['foo1', 'foo2'], 1)
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'uri' => 'foo1'
+                ],
+                [
+                    'id' => 100,
+                    'uri' => 'foo2'
+                ],
+            ]);
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+
+        $res = $calendar->getMultipleChildren(['foo1', 'foo2']);
+        $this->assertCount(2, $res);
+        $this->assertInstanceOf(CachedSubscriptionObject::class, $res[0]);
+        $this->assertInstanceOf(CachedSubscriptionObject::class, $res[1]);
+    }
+
+
+    public function testCreateFile(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('Creating objects in cached subscription is not allowed');
+
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+        $calendar->createFile('foo', []);
+    }
+
+    public function testChildExists(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $calls = [
+            [666, 'foo1', 1, [
+                'id' => 99,
+                'uri' => 'foo1'
+            ]],
+            [666, 'foo2', 1, null],
+        ];
+        $backend->expects($this->exactly(2))
+            ->method('getCalendarObject')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $return = array_pop($expected);
+                $this->assertEquals($expected, func_get_args());
+                return $return;
+            });
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+
+        $this->assertEquals(true, $calendar->childExists('foo1'));
+        $this->assertEquals(false, $calendar->childExists('foo2'));
+    }
+
+    public function testCalendarQuery(): void {
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $backend->expects($this->once())
+            ->method('calendarQuery')
+            ->with(666, ['foo'], 1)
+            ->willReturn([99]);
+
+        $calendar = new CachedSubscription($backend, $calendarInfo);
+
+        $this->assertEquals([99], $calendar->calendarQuery(['foo']));
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -149,7 +149,7 @@ 
 		];
 		$backend->expects($this->exactly(2))
 			->method('getCalendarObject')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$return = array_pop($expected);
 				$this->assertEquals($expected, func_get_args());
@@ -261,7 +261,7 @@ 
 		];
 		$backend->expects($this->exactly(2))
 			->method('getCalendarObject')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$return = array_pop($expected);
 				$this->assertEquals($expected, func_get_args());

apps/dav/tests/unit/CalDAV/Security/RateLimitingPluginTest.php

Indentation +160 added lines, -160 removed lines

@@ -24,165 +24,165 @@
 
 class RateLimitingPluginTest extends TestCase {
 
-	private Limiter&MockObject $limiter;
-	private CalDavBackend&MockObject $caldavBackend;
-	private IUserManager&MockObject $userManager;
-	private LoggerInterface&MockObject $logger;
-	private IAppConfig&MockObject $config;
-	private string $userId = 'user123';
-	private RateLimitingPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->limiter = $this->createMock(Limiter::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->caldavBackend = $this->createMock(CalDavBackend::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IAppConfig::class);
-		$this->plugin = new RateLimitingPlugin(
-			$this->limiter,
-			$this->userManager,
-			$this->caldavBackend,
-			$this->logger,
-			$this->config,
-			$this->userId,
-		);
-	}
-
-	public function testNoUserObject(): void {
-		$this->limiter->expects(self::never())
-			->method('registerUserRequest');
-
-		$this->plugin->beforeBind('calendars/foo/cal');
-	}
-
-	public function testUnrelated(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with($this->userId)
-			->willReturn($user);
-		$this->limiter->expects(self::never())
-			->method('registerUserRequest');
-
-		$this->plugin->beforeBind('foo/bar');
-	}
-
-	public function testRegisterCalendarCreation(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with($this->userId)
-			->willReturn($user);
-		$this->config
-			->method('getValueInt')
-			->with('dav')
-			->willReturnArgument(2);
-		$this->limiter->expects(self::once())
-			->method('registerUserRequest')
-			->with(
-				'caldav-create-calendar',
-				10,
-				3600,
-				$user,
-			);
-
-		$this->plugin->beforeBind('calendars/foo/cal');
-	}
-
-	public function testCalendarCreationRateLimitExceeded(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with($this->userId)
-			->willReturn($user);
-		$this->config
-			->method('getValueInt')
-			->with('dav')
-			->willReturnArgument(2);
-		$this->limiter->expects(self::once())
-			->method('registerUserRequest')
-			->with(
-				'caldav-create-calendar',
-				10,
-				3600,
-				$user,
-			)
-			->willThrowException(new RateLimitExceededException());
-		$this->expectException(TooManyRequests::class);
-
-		$this->plugin->beforeBind('calendars/foo/cal');
-	}
-
-	public function testCalendarLimitReached(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with($this->userId)
-			->willReturn($user);
-		$user->method('getUID')->willReturn('user123');
-		$this->config
-			->method('getValueInt')
-			->with('dav')
-			->willReturnArgument(2);
-		$this->limiter->expects(self::once())
-			->method('registerUserRequest')
-			->with(
-				'caldav-create-calendar',
-				10,
-				3600,
-				$user,
-			);
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarsForUserCount')
-			->with('principals/users/user123')
-			->willReturn(27);
-		$this->caldavBackend->expects(self::once())
-			->method('getSubscriptionsForUserCount')
-			->with('principals/users/user123')
-			->willReturn(3);
-		$this->expectException(Forbidden::class);
-
-		$this->plugin->beforeBind('calendars/foo/cal');
-	}
-
-	public function testNoCalendarsSubscriptsLimit(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects(self::once())
-			->method('get')
-			->with($this->userId)
-			->willReturn($user);
-		$user->method('getUID')->willReturn('user123');
-		$this->config
-			->method('getValueInt')
-			->with('dav')
-			->willReturnCallback(function ($app, $key, $default) {
-				switch ($key) {
-					case 'maximumCalendarsSubscriptions':
-						return -1;
-					default:
-						return $default;
-				}
-			});
-		$this->limiter->expects(self::once())
-			->method('registerUserRequest')
-			->with(
-				'caldav-create-calendar',
-				10,
-				3600,
-				$user,
-			);
-		$this->caldavBackend->expects(self::never())
-			->method('getCalendarsForUserCount')
-			->with('principals/users/user123')
-			->willReturn(27);
-		$this->caldavBackend->expects(self::never())
-			->method('getSubscriptionsForUserCount')
-			->with('principals/users/user123')
-			->willReturn(3);
-
-		$this->plugin->beforeBind('calendars/foo/cal');
-	}
+    private Limiter&MockObject $limiter;
+    private CalDavBackend&MockObject $caldavBackend;
+    private IUserManager&MockObject $userManager;
+    private LoggerInterface&MockObject $logger;
+    private IAppConfig&MockObject $config;
+    private string $userId = 'user123';
+    private RateLimitingPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->limiter = $this->createMock(Limiter::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->caldavBackend = $this->createMock(CalDavBackend::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IAppConfig::class);
+        $this->plugin = new RateLimitingPlugin(
+            $this->limiter,
+            $this->userManager,
+            $this->caldavBackend,
+            $this->logger,
+            $this->config,
+            $this->userId,
+        );
+    }
+
+    public function testNoUserObject(): void {
+        $this->limiter->expects(self::never())
+            ->method('registerUserRequest');
+
+        $this->plugin->beforeBind('calendars/foo/cal');
+    }
+
+    public function testUnrelated(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with($this->userId)
+            ->willReturn($user);
+        $this->limiter->expects(self::never())
+            ->method('registerUserRequest');
+
+        $this->plugin->beforeBind('foo/bar');
+    }
+
+    public function testRegisterCalendarCreation(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with($this->userId)
+            ->willReturn($user);
+        $this->config
+            ->method('getValueInt')
+            ->with('dav')
+            ->willReturnArgument(2);
+        $this->limiter->expects(self::once())
+            ->method('registerUserRequest')
+            ->with(
+                'caldav-create-calendar',
+                10,
+                3600,
+                $user,
+            );
+
+        $this->plugin->beforeBind('calendars/foo/cal');
+    }
+
+    public function testCalendarCreationRateLimitExceeded(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with($this->userId)
+            ->willReturn($user);
+        $this->config
+            ->method('getValueInt')
+            ->with('dav')
+            ->willReturnArgument(2);
+        $this->limiter->expects(self::once())
+            ->method('registerUserRequest')
+            ->with(
+                'caldav-create-calendar',
+                10,
+                3600,
+                $user,
+            )
+            ->willThrowException(new RateLimitExceededException());
+        $this->expectException(TooManyRequests::class);
+
+        $this->plugin->beforeBind('calendars/foo/cal');
+    }
+
+    public function testCalendarLimitReached(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with($this->userId)
+            ->willReturn($user);
+        $user->method('getUID')->willReturn('user123');
+        $this->config
+            ->method('getValueInt')
+            ->with('dav')
+            ->willReturnArgument(2);
+        $this->limiter->expects(self::once())
+            ->method('registerUserRequest')
+            ->with(
+                'caldav-create-calendar',
+                10,
+                3600,
+                $user,
+            );
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarsForUserCount')
+            ->with('principals/users/user123')
+            ->willReturn(27);
+        $this->caldavBackend->expects(self::once())
+            ->method('getSubscriptionsForUserCount')
+            ->with('principals/users/user123')
+            ->willReturn(3);
+        $this->expectException(Forbidden::class);
+
+        $this->plugin->beforeBind('calendars/foo/cal');
+    }
+
+    public function testNoCalendarsSubscriptsLimit(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->with($this->userId)
+            ->willReturn($user);
+        $user->method('getUID')->willReturn('user123');
+        $this->config
+            ->method('getValueInt')
+            ->with('dav')
+            ->willReturnCallback(function ($app, $key, $default) {
+                switch ($key) {
+                    case 'maximumCalendarsSubscriptions':
+                        return -1;
+                    default:
+                        return $default;
+                }
+            });
+        $this->limiter->expects(self::once())
+            ->method('registerUserRequest')
+            ->with(
+                'caldav-create-calendar',
+                10,
+                3600,
+                $user,
+            );
+        $this->caldavBackend->expects(self::never())
+            ->method('getCalendarsForUserCount')
+            ->with('principals/users/user123')
+            ->willReturn(27);
+        $this->caldavBackend->expects(self::never())
+            ->method('getSubscriptionsForUserCount')
+            ->with('principals/users/user123')
+            ->willReturn(3);
+
+        $this->plugin->beforeBind('calendars/foo/cal');
+    }
 
 }

Spacing +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
 		$this->config
 			->method('getValueInt')
 			->with('dav')
-			->willReturnCallback(function ($app, $key, $default) {
+			->willReturnCallback(function($app, $key, $default) {
 				switch ($key) {
 					case 'maximumCalendarsSubscriptions':
 						return -1;

apps/dav/tests/unit/CalDAV/CalendarManagerTest.php

Indentation +38 added lines, -38 removed lines

@@ -18,47 +18,47 @@
 use Psr\Log\LoggerInterface;
 
 class CalendarManagerTest extends \Test\TestCase {
-	private CalDavBackend&MockObject $backend;
-	private IL10N&MockObject $l10n;
-	private IConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private CalendarManager $manager;
+    private CalDavBackend&MockObject $backend;
+    private IL10N&MockObject $l10n;
+    private IConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private CalendarManager $manager;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->backend = $this->createMock(CalDavBackend::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->manager = new CalendarManager(
-			$this->backend,
-			$this->l10n,
-			$this->config,
-			$this->logger
-		);
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->backend = $this->createMock(CalDavBackend::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->manager = new CalendarManager(
+            $this->backend,
+            $this->l10n,
+            $this->config,
+            $this->logger
+        );
+    }
 
-	public function testSetupCalendarProvider(): void {
-		$this->backend->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/user123')
-			->willReturn([
-				['id' => 123, 'uri' => 'blablub1'],
-				['id' => 456, 'uri' => 'blablub2'],
-			]);
+    public function testSetupCalendarProvider(): void {
+        $this->backend->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/user123')
+            ->willReturn([
+                ['id' => 123, 'uri' => 'blablub1'],
+                ['id' => 456, 'uri' => 'blablub2'],
+            ]);
 
-		/** @var IManager&MockObject $calendarManager */
-		$calendarManager = $this->createMock(Manager::class);
-		$registeredIds = [];
-		$calendarManager->expects($this->exactly(2))
-			->method('registerCalendar')
-			->willReturnCallback(function ($parameter) use (&$registeredIds): void {
-				$this->assertInstanceOf(CalendarImpl::class, $parameter);
-				$registeredIds[] = $parameter->getKey();
-			});
+        /** @var IManager&MockObject $calendarManager */
+        $calendarManager = $this->createMock(Manager::class);
+        $registeredIds = [];
+        $calendarManager->expects($this->exactly(2))
+            ->method('registerCalendar')
+            ->willReturnCallback(function ($parameter) use (&$registeredIds): void {
+                $this->assertInstanceOf(CalendarImpl::class, $parameter);
+                $registeredIds[] = $parameter->getKey();
+            });
 
-		$this->manager->setupCalendarProvider($calendarManager, 'user123');
+        $this->manager->setupCalendarProvider($calendarManager, 'user123');
 
-		$this->assertEquals(['123','456'], $registeredIds);
-	}
+        $this->assertEquals(['123','456'], $registeredIds);
+    }
 }

apps/dav/tests/unit/CalDAV/CachedSubscriptionImplTest.php

Indentation +61 added lines, -61 removed lines

@@ -16,65 +16,65 @@
 use Test\TestCase;
 
 class CachedSubscriptionImplTest extends TestCase {
-	private CachedSubscription&MockObject $cachedSubscription;
-	private array $cachedSubscriptionInfo;
-	private CalDavBackend&MockObject $backend;
-	private CachedSubscriptionImpl $cachedSubscriptionImpl;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->cachedSubscription = $this->createMock(CachedSubscription::class);
-		$this->cachedSubscriptionInfo = [
-			'id' => 'fancy_id_123',
-			'{DAV:}displayname' => 'user readable name 123',
-			'{http://apple.com/ns/ical/}calendar-color' => '#AABBCC',
-			'uri' => '/this/is/a/uri',
-			'source' => 'https://test.localhost/calendar1',
-		];
-		$this->backend = $this->createMock(CalDavBackend::class);
-
-		$this->cachedSubscriptionImpl = new CachedSubscriptionImpl(
-			$this->cachedSubscription,
-			$this->cachedSubscriptionInfo,
-			$this->backend
-		);
-	}
-
-	public function testGetKey(): void {
-		$this->assertEquals($this->cachedSubscriptionImpl->getKey(), 'fancy_id_123');
-	}
-
-	public function testGetDisplayname(): void {
-		$this->assertEquals($this->cachedSubscriptionImpl->getDisplayName(), 'user readable name 123');
-	}
-
-	public function testGetDisplayColor(): void {
-		$this->assertEquals($this->cachedSubscriptionImpl->getDisplayColor(), '#AABBCC');
-	}
-
-	public function testGetSource(): void {
-		$this->assertEquals($this->cachedSubscriptionImpl->getSource(), 'https://test.localhost/calendar1');
-	}
-
-	public function testSearch(): void {
-		$this->backend->expects($this->once())
-			->method('search')
-			->with($this->cachedSubscriptionInfo, 'abc', ['def'], ['ghi'], 42, 1337)
-			->willReturn(['SEARCHRESULTS']);
-
-		$result = $this->cachedSubscriptionImpl->search('abc', ['def'], ['ghi'], 42, 1337);
-		$this->assertEquals($result, ['SEARCHRESULTS']);
-	}
-
-	public function testGetPermissionRead(): void {
-		$this->cachedSubscription->expects($this->once())
-			->method('getACL')
-			->with()
-			->willReturn([
-				['privilege' => '{DAV:}read']
-			]);
-
-		$this->assertEquals(1, $this->cachedSubscriptionImpl->getPermissions());
-	}
+    private CachedSubscription&MockObject $cachedSubscription;
+    private array $cachedSubscriptionInfo;
+    private CalDavBackend&MockObject $backend;
+    private CachedSubscriptionImpl $cachedSubscriptionImpl;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->cachedSubscription = $this->createMock(CachedSubscription::class);
+        $this->cachedSubscriptionInfo = [
+            'id' => 'fancy_id_123',
+            '{DAV:}displayname' => 'user readable name 123',
+            '{http://apple.com/ns/ical/}calendar-color' => '#AABBCC',
+            'uri' => '/this/is/a/uri',
+            'source' => 'https://test.localhost/calendar1',
+        ];
+        $this->backend = $this->createMock(CalDavBackend::class);
+
+        $this->cachedSubscriptionImpl = new CachedSubscriptionImpl(
+            $this->cachedSubscription,
+            $this->cachedSubscriptionInfo,
+            $this->backend
+        );
+    }
+
+    public function testGetKey(): void {
+        $this->assertEquals($this->cachedSubscriptionImpl->getKey(), 'fancy_id_123');
+    }
+
+    public function testGetDisplayname(): void {
+        $this->assertEquals($this->cachedSubscriptionImpl->getDisplayName(), 'user readable name 123');
+    }
+
+    public function testGetDisplayColor(): void {
+        $this->assertEquals($this->cachedSubscriptionImpl->getDisplayColor(), '#AABBCC');
+    }
+
+    public function testGetSource(): void {
+        $this->assertEquals($this->cachedSubscriptionImpl->getSource(), 'https://test.localhost/calendar1');
+    }
+
+    public function testSearch(): void {
+        $this->backend->expects($this->once())
+            ->method('search')
+            ->with($this->cachedSubscriptionInfo, 'abc', ['def'], ['ghi'], 42, 1337)
+            ->willReturn(['SEARCHRESULTS']);
+
+        $result = $this->cachedSubscriptionImpl->search('abc', ['def'], ['ghi'], 42, 1337);
+        $this->assertEquals($result, ['SEARCHRESULTS']);
+    }
+
+    public function testGetPermissionRead(): void {
+        $this->cachedSubscription->expects($this->once())
+            ->method('getACL')
+            ->with()
+            ->willReturn([
+                ['privilege' => '{DAV:}read']
+            ]);
+
+        $this->assertEquals(1, $this->cachedSubscriptionImpl->getPermissions());
+    }
 }

apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php

Indentation +164 added lines, -164 removed lines

@@ -43,144 +43,144 @@ 
 abstract class AbstractCalDavBackend extends TestCase {
 
 
-	protected CalDavBackend $backend;
-	protected Principal&MockObject $principal;
-	protected IUserManager&MockObject $userManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IEventDispatcher&MockObject $dispatcher;
-	private LoggerInterface&MockObject $logger;
-	private IConfig&MockObject $config;
-	private ISecureRandom $random;
-	protected SharingBackend $sharingBackend;
-	protected IDBConnection $db;
-	public const UNIT_TEST_USER = 'principals/users/caldav-unit-test';
-	public const UNIT_TEST_USER1 = 'principals/users/caldav-unit-test1';
-	public const UNIT_TEST_GROUP = 'principals/groups/caldav-unit-test-group';
-	public const UNIT_TEST_GROUP2 = 'principals/groups/caldav-unit-test-group2';
+    protected CalDavBackend $backend;
+    protected Principal&MockObject $principal;
+    protected IUserManager&MockObject $userManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IEventDispatcher&MockObject $dispatcher;
+    private LoggerInterface&MockObject $logger;
+    private IConfig&MockObject $config;
+    private ISecureRandom $random;
+    protected SharingBackend $sharingBackend;
+    protected IDBConnection $db;
+    public const UNIT_TEST_USER = 'principals/users/caldav-unit-test';
+    public const UNIT_TEST_USER1 = 'principals/users/caldav-unit-test1';
+    public const UNIT_TEST_GROUP = 'principals/groups/caldav-unit-test-group';
+    public const UNIT_TEST_GROUP2 = 'principals/groups/caldav-unit-test-group2';
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->principal = $this->getMockBuilder(Principal::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->createMock(IAccountManager::class),
-				$this->createMock(ShareManager::class),
-				$this->createMock(IUserSession::class),
-				$this->createMock(IAppManager::class),
-				$this->createMock(ProxyMapper::class),
-				$this->createMock(KnownUserService::class),
-				$this->createMock(IConfig::class),
-				$this->createMock(IFactory::class)
-			])
-			->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
-			->getMock();
-		$this->principal->expects($this->any())->method('getPrincipalByPath')
-			->willReturn([
-				'uri' => 'principals/best-friend',
-				'{DAV:}displayname' => 'User\'s displayname',
-			]);
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->principal = $this->getMockBuilder(Principal::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->createMock(IAccountManager::class),
+                $this->createMock(ShareManager::class),
+                $this->createMock(IUserSession::class),
+                $this->createMock(IAppManager::class),
+                $this->createMock(ProxyMapper::class),
+                $this->createMock(KnownUserService::class),
+                $this->createMock(IConfig::class),
+                $this->createMock(IFactory::class)
+            ])
+            ->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
+            ->getMock();
+        $this->principal->expects($this->any())->method('getPrincipalByPath')
+            ->willReturn([
+                'uri' => 'principals/best-friend',
+                '{DAV:}displayname' => 'User\'s displayname',
+            ]);
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
 
-		$this->db = Server::get(IDBConnection::class);
-		$this->random = Server::get(ISecureRandom::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->sharingBackend = new SharingBackend(
-			$this->userManager,
-			$this->groupManager,
-			$this->principal,
-			$this->createMock(ICacheFactory::class),
-			new Service(new SharingMapper($this->db)),
-			$this->logger);
-		$this->backend = new CalDavBackend(
-			$this->db,
-			$this->principal,
-			$this->userManager,
-			$this->random,
-			$this->logger,
-			$this->dispatcher,
-			$this->config,
-			$this->sharingBackend,
-			false,
-		);
+        $this->db = Server::get(IDBConnection::class);
+        $this->random = Server::get(ISecureRandom::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->sharingBackend = new SharingBackend(
+            $this->userManager,
+            $this->groupManager,
+            $this->principal,
+            $this->createMock(ICacheFactory::class),
+            new Service(new SharingMapper($this->db)),
+            $this->logger);
+        $this->backend = new CalDavBackend(
+            $this->db,
+            $this->principal,
+            $this->userManager,
+            $this->random,
+            $this->logger,
+            $this->dispatcher,
+            $this->config,
+            $this->sharingBackend,
+            false,
+        );
 
-		$this->cleanUpBackend();
-	}
+        $this->cleanUpBackend();
+    }
 
-	protected function tearDown(): void {
-		$this->cleanUpBackend();
-		parent::tearDown();
-	}
+    protected function tearDown(): void {
+        $this->cleanUpBackend();
+        parent::tearDown();
+    }
 
-	public function cleanUpBackend(): void {
-		if (is_null($this->backend)) {
-			return;
-		}
-		$this->principal->expects($this->any())->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
-		$this->cleanupForPrincipal(self::UNIT_TEST_USER);
-		$this->cleanupForPrincipal(self::UNIT_TEST_USER1);
-	}
+    public function cleanUpBackend(): void {
+        if (is_null($this->backend)) {
+            return;
+        }
+        $this->principal->expects($this->any())->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP, self::UNIT_TEST_GROUP2]);
+        $this->cleanupForPrincipal(self::UNIT_TEST_USER);
+        $this->cleanupForPrincipal(self::UNIT_TEST_USER1);
+    }
 
-	private function cleanupForPrincipal($principal): void {
-		$calendars = $this->backend->getCalendarsForUser($principal);
-		$this->dispatcher->expects(self::any())
-			->method('dispatchTyped');
-		foreach ($calendars as $calendar) {
-			$this->backend->deleteCalendar($calendar['id'], true);
-		}
-		$subscriptions = $this->backend->getSubscriptionsForUser($principal);
-		foreach ($subscriptions as $subscription) {
-			$this->backend->deleteSubscription($subscription['id']);
-		}
-	}
+    private function cleanupForPrincipal($principal): void {
+        $calendars = $this->backend->getCalendarsForUser($principal);
+        $this->dispatcher->expects(self::any())
+            ->method('dispatchTyped');
+        foreach ($calendars as $calendar) {
+            $this->backend->deleteCalendar($calendar['id'], true);
+        }
+        $subscriptions = $this->backend->getSubscriptionsForUser($principal);
+        foreach ($subscriptions as $subscription) {
+            $this->backend->deleteSubscription($subscription['id']);
+        }
+    }
 
-	protected function createTestCalendar(): int {
-		$this->dispatcher->expects(self::any())
-			->method('dispatchTyped');
+    protected function createTestCalendar(): int {
+        $this->dispatcher->expects(self::any())
+            ->method('dispatchTyped');
 
-		$this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', [
-			'{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF'
-		]);
-		$calendars = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($calendars));
-		$this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
-		/** @var SupportedCalendarComponentSet $components */
-		$components = $calendars[0]['{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set'];
-		$this->assertEquals(['VEVENT','VTODO','VJOURNAL'], $components->getValue());
-		$color = $calendars[0]['{http://apple.com/ns/ical/}calendar-color'];
-		$this->assertEquals('#1C4587FF', $color);
-		$this->assertEquals('Example', $calendars[0]['uri']);
-		$this->assertEquals('Example', $calendars[0]['{DAV:}displayname']);
-		return (int)$calendars[0]['id'];
-	}
+        $this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', [
+            '{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF'
+        ]);
+        $calendars = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($calendars));
+        $this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
+        /** @var SupportedCalendarComponentSet $components */
+        $components = $calendars[0]['{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set'];
+        $this->assertEquals(['VEVENT','VTODO','VJOURNAL'], $components->getValue());
+        $color = $calendars[0]['{http://apple.com/ns/ical/}calendar-color'];
+        $this->assertEquals('#1C4587FF', $color);
+        $this->assertEquals('Example', $calendars[0]['uri']);
+        $this->assertEquals('Example', $calendars[0]['{DAV:}displayname']);
+        return (int)$calendars[0]['id'];
+    }
 
-	protected function createTestSubscription() {
-		$this->backend->createSubscription(self::UNIT_TEST_USER, 'Example', [
-			'{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF',
-			'{http://calendarserver.org/ns/}source' => new Href(['foo']),
-		]);
-		$calendars = $this->backend->getSubscriptionsForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($calendars));
-		$this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
-		$this->assertEquals('Example', $calendars[0]['uri']);
-		$calendarId = $calendars[0]['id'];
+    protected function createTestSubscription() {
+        $this->backend->createSubscription(self::UNIT_TEST_USER, 'Example', [
+            '{http://apple.com/ns/ical/}calendar-color' => '#1C4587FF',
+            '{http://calendarserver.org/ns/}source' => new Href(['foo']),
+        ]);
+        $calendars = $this->backend->getSubscriptionsForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($calendars));
+        $this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
+        $this->assertEquals('Example', $calendars[0]['uri']);
+        $calendarId = $calendars[0]['id'];
 
-		return $calendarId;
-	}
+        return $calendarId;
+    }
 
-	protected function createEvent($calendarId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
-		$randomPart = self::getUniqueID();
+    protected function createEvent($calendarId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
+        $randomPart = self::getUniqueID();
 
-		$calData = <<<EOD
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:ownCloud Calendar
@@ -196,20 +196,20 @@ 
 END:VEVENT
 END:VCALENDAR
 EOD;
-		$uri0 = $this->getUniqueID('event');
+        $uri0 = $this->getUniqueID('event');
 
-		$this->dispatcher->expects(self::atLeastOnce())
-			->method('dispatchTyped');
+        $this->dispatcher->expects(self::atLeastOnce())
+            ->method('dispatchTyped');
 
-		$this->backend->createCalendarObject($calendarId, $uri0, $calData);
+        $this->backend->createCalendarObject($calendarId, $uri0, $calData);
 
-		return $uri0;
-	}
+        return $uri0;
+    }
 
-	protected function modifyEvent($calendarId, $objectId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
-		$randomPart = self::getUniqueID();
+    protected function modifyEvent($calendarId, $objectId, $start = '20130912T130000Z', $end = '20130912T140000Z') {
+        $randomPart = self::getUniqueID();
 
-		$calData = <<<EOD
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:ownCloud Calendar
@@ -226,38 +226,38 @@ 
 END:VCALENDAR
 EOD;
 
-		$this->backend->updateCalendarObject($calendarId, $objectId, $calData);
-	}
+        $this->backend->updateCalendarObject($calendarId, $objectId, $calData);
+    }
 
-	protected function deleteEvent($calendarId, $objectId) {
-		$this->backend->deleteCalendarObject($calendarId, $objectId);
-	}
+    protected function deleteEvent($calendarId, $objectId) {
+        $this->backend->deleteCalendarObject($calendarId, $objectId);
+    }
 
-	protected function assertAcl($principal, $privilege, $acl) {
-		foreach ($acl as $a) {
-			if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
-				$this->addToAssertionCount(1);
-				return;
-			}
-		}
-		$this->fail("ACL does not contain $principal / $privilege");
-	}
+    protected function assertAcl($principal, $privilege, $acl) {
+        foreach ($acl as $a) {
+            if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
+                $this->addToAssertionCount(1);
+                return;
+            }
+        }
+        $this->fail("ACL does not contain $principal / $privilege");
+    }
 
-	protected function assertNotAcl($principal, $privilege, $acl) {
-		foreach ($acl as $a) {
-			if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
-				$this->fail("ACL contains $principal / $privilege");
-				return;
-			}
-		}
-		$this->addToAssertionCount(1);
-	}
+    protected function assertNotAcl($principal, $privilege, $acl) {
+        foreach ($acl as $a) {
+            if ($a['principal'] === $principal && $a['privilege'] === $privilege) {
+                $this->fail("ACL contains $principal / $privilege");
+                return;
+            }
+        }
+        $this->addToAssertionCount(1);
+    }
 
-	protected function assertAccess($shouldHaveAcl, $principal, $privilege, $acl) {
-		if ($shouldHaveAcl) {
-			$this->assertAcl($principal, $privilege, $acl);
-		} else {
-			$this->assertNotAcl($principal, $privilege, $acl);
-		}
-	}
+    protected function assertAccess($shouldHaveAcl, $principal, $privilege, $acl) {
+        if ($shouldHaveAcl) {
+            $this->assertAcl($principal, $privilege, $acl);
+        } else {
+            $this->assertNotAcl($principal, $privilege, $acl);
+        }
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -155,12 +155,12 @@
 		$this->assertEquals(self::UNIT_TEST_USER, $calendars[0]['principaluri']);
 		/** @var SupportedCalendarComponentSet $components */
 		$components = $calendars[0]['{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set'];
-		$this->assertEquals(['VEVENT','VTODO','VJOURNAL'], $components->getValue());
+		$this->assertEquals(['VEVENT', 'VTODO', 'VJOURNAL'], $components->getValue());
 		$color = $calendars[0]['{http://apple.com/ns/ical/}calendar-color'];
 		$this->assertEquals('#1C4587FF', $color);
 		$this->assertEquals('Example', $calendars[0]['uri']);
 		$this->assertEquals('Example', $calendars[0]['{DAV:}displayname']);
-		return (int)$calendars[0]['id'];
+		return (int) $calendars[0]['id'];
 	}
 
 	protected function createTestSubscription() {