Passed
Push — master ( d23e96...1bc100 )
by Roeland
11:25 queued 10s
created
lib/public/Files/Config/IUserMountCache.php 1 patch
Indentation   +77 added lines, -77 removed lines patch added patch discarded remove patch
@@ -31,89 +31,89 @@
 block discarded – undo
31 31
  * @since 9.0.0
32 32
  */
33 33
 interface IUserMountCache {
34
-	/**
35
-	 * Register mounts for a user to the cache
36
-	 *
37
-	 * @param IUser $user
38
-	 * @param IMountPoint[] $mounts
39
-	 * @since 9.0.0
40
-	 */
41
-	public function registerMounts(IUser $user, array $mounts);
34
+    /**
35
+     * Register mounts for a user to the cache
36
+     *
37
+     * @param IUser $user
38
+     * @param IMountPoint[] $mounts
39
+     * @since 9.0.0
40
+     */
41
+    public function registerMounts(IUser $user, array $mounts);
42 42
 
43
-	/**
44
-	 * Get all cached mounts for a user
45
-	 *
46
-	 * @param IUser $user
47
-	 * @return ICachedMountInfo[]
48
-	 * @since 9.0.0
49
-	 */
50
-	public function getMountsForUser(IUser $user);
43
+    /**
44
+     * Get all cached mounts for a user
45
+     *
46
+     * @param IUser $user
47
+     * @return ICachedMountInfo[]
48
+     * @since 9.0.0
49
+     */
50
+    public function getMountsForUser(IUser $user);
51 51
 
52
-	/**
53
-	 * Get all cached mounts by storage
54
-	 *
55
-	 * @param int $numericStorageId
56
-	 * @param string|null $user limit the results to a single user @since 12.0.0
57
-	 * @return ICachedMountInfo[]
58
-	 * @since 9.0.0
59
-	 */
60
-	public function getMountsForStorageId($numericStorageId, $user = null);
52
+    /**
53
+     * Get all cached mounts by storage
54
+     *
55
+     * @param int $numericStorageId
56
+     * @param string|null $user limit the results to a single user @since 12.0.0
57
+     * @return ICachedMountInfo[]
58
+     * @since 9.0.0
59
+     */
60
+    public function getMountsForStorageId($numericStorageId, $user = null);
61 61
 
62
-	/**
63
-	 * Get all cached mounts by root
64
-	 *
65
-	 * @param int $rootFileId
66
-	 * @return ICachedMountInfo[]
67
-	 * @since 9.0.0
68
-	 */
69
-	public function getMountsForRootId($rootFileId);
62
+    /**
63
+     * Get all cached mounts by root
64
+     *
65
+     * @param int $rootFileId
66
+     * @return ICachedMountInfo[]
67
+     * @since 9.0.0
68
+     */
69
+    public function getMountsForRootId($rootFileId);
70 70
 
71
-	/**
72
-	 * Get all cached mounts that contain a file
73
-	 *
74
-	 * @param int $fileId
75
-	 * @param string|null $user optionally restrict the results to a single user @since 12.0.0
76
-	 * @return ICachedMountFileInfo[]
77
-	 * @since 9.0.0
78
-	 */
79
-	public function getMountsForFileId($fileId, $user = null);
71
+    /**
72
+     * Get all cached mounts that contain a file
73
+     *
74
+     * @param int $fileId
75
+     * @param string|null $user optionally restrict the results to a single user @since 12.0.0
76
+     * @return ICachedMountFileInfo[]
77
+     * @since 9.0.0
78
+     */
79
+    public function getMountsForFileId($fileId, $user = null);
80 80
 
81
-	/**
82
-	 * Remove all cached mounts for a user
83
-	 *
84
-	 * @param IUser $user
85
-	 * @since 9.0.0
86
-	 */
87
-	public function removeUserMounts(IUser $user);
81
+    /**
82
+     * Remove all cached mounts for a user
83
+     *
84
+     * @param IUser $user
85
+     * @since 9.0.0
86
+     */
87
+    public function removeUserMounts(IUser $user);
88 88
 
89
-	/**
90
-	 * Remove all mounts for a user and storage
91
-	 *
92
-	 * @param $storageId
93
-	 * @param string $userId
94
-	 * @return mixed
95
-	 * @since 9.0.0
96
-	 */
97
-	public function removeUserStorageMount($storageId, $userId);
89
+    /**
90
+     * Remove all mounts for a user and storage
91
+     *
92
+     * @param $storageId
93
+     * @param string $userId
94
+     * @return mixed
95
+     * @since 9.0.0
96
+     */
97
+    public function removeUserStorageMount($storageId, $userId);
98 98
 
99
-	/**
100
-	 * Remove all cached mounts for a storage
101
-	 *
102
-	 * @param $storageId
103
-	 * @return mixed
104
-	 * @since 9.0.0
105
-	 */
106
-	public function remoteStorageMounts($storageId);
99
+    /**
100
+     * Remove all cached mounts for a storage
101
+     *
102
+     * @param $storageId
103
+     * @return mixed
104
+     * @since 9.0.0
105
+     */
106
+    public function remoteStorageMounts($storageId);
107 107
 
108
-	/**
109
-	 * Get the used space for users
110
-	 *
111
-	 * Note that this only includes the space in their home directory,
112
-	 * not any incoming shares or external storages.
113
-	 *
114
-	 * @param IUser[] $users
115
-	 * @return int[] [$userId => $userSpace]
116
-	 * @since 13.0.0
117
-	 */
118
-	public function getUsedSpaceForUsers(array $users);
108
+    /**
109
+     * Get the used space for users
110
+     *
111
+     * Note that this only includes the space in their home directory,
112
+     * not any incoming shares or external storages.
113
+     *
114
+     * @param IUser[] $users
115
+     * @return int[] [$userId => $userSpace]
116
+     * @since 13.0.0
117
+     */
118
+    public function getUsedSpaceForUsers(array $users);
119 119
 }
Please login to merge, or discard this patch.
lib/private/Files/Config/CachedMountFileInfo.php 2 patches
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -26,23 +26,23 @@
 block discarded – undo
26 26
 use OCP\IUser;
27 27
 
28 28
 class CachedMountFileInfo extends CachedMountInfo implements ICachedMountFileInfo {
29
-	/** @var string */
30
-	private $internalPath;
29
+    /** @var string */
30
+    private $internalPath;
31 31
 
32
-	public function __construct(IUser $user, $storageId, $rootId, $mountPoint, $mountId = null, $rootInternalPath = '', $internalPath) {
33
-		parent::__construct($user, $storageId, $rootId, $mountPoint, $mountId, $rootInternalPath);
34
-		$this->internalPath = $internalPath;
35
-	}
32
+    public function __construct(IUser $user, $storageId, $rootId, $mountPoint, $mountId = null, $rootInternalPath = '', $internalPath) {
33
+        parent::__construct($user, $storageId, $rootId, $mountPoint, $mountId, $rootInternalPath);
34
+        $this->internalPath = $internalPath;
35
+    }
36 36
 
37
-	public function getInternalPath() {
38
-		if ($this->getRootInternalPath()) {
39
-			return substr($this->internalPath, strlen($this->getRootInternalPath()) + 1);
40
-		} else {
41
-			return $this->internalPath;
42
-		}
43
-	}
37
+    public function getInternalPath() {
38
+        if ($this->getRootInternalPath()) {
39
+            return substr($this->internalPath, strlen($this->getRootInternalPath()) + 1);
40
+        } else {
41
+            return $this->internalPath;
42
+        }
43
+    }
44 44
 
45
-	public function getPath() {
46
-		return $this->getMountPoint() . $this->getInternalPath();
47
-	}
45
+    public function getPath() {
46
+        return $this->getMountPoint() . $this->getInternalPath();
47
+    }
48 48
 }
49 49
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,6 +43,6 @@
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	public function getPath() {
46
-		return $this->getMountPoint() . $this->getInternalPath();
46
+		return $this->getMountPoint().$this->getInternalPath();
47 47
 	}
48 48
 }
49 49
\ No newline at end of file
Please login to merge, or discard this patch.
lib/private/Command/AsyncBus.php 1 patch
Indentation   +66 added lines, -66 removed lines patch added patch discarded remove patch
@@ -29,76 +29,76 @@
 block discarded – undo
29 29
  * Asynchronous command bus that uses the background job system as backend
30 30
  */
31 31
 abstract class AsyncBus implements IBus {
32
-	/**
33
-	 * List of traits for command which require sync execution
34
-	 *
35
-	 * @var string[]
36
-	 */
37
-	private $syncTraits = [];
32
+    /**
33
+     * List of traits for command which require sync execution
34
+     *
35
+     * @var string[]
36
+     */
37
+    private $syncTraits = [];
38 38
 
39
-	/**
40
-	 * Schedule a command to be fired
41
-	 *
42
-	 * @param \OCP\Command\ICommand | callable $command
43
-	 */
44
-	public function push($command) {
45
-		if ($this->canRunAsync($command)) {
46
-			$this->queueCommand($command);
47
-		} else {
48
-			$this->runCommand($command);
49
-		}
50
-	}
39
+    /**
40
+     * Schedule a command to be fired
41
+     *
42
+     * @param \OCP\Command\ICommand | callable $command
43
+     */
44
+    public function push($command) {
45
+        if ($this->canRunAsync($command)) {
46
+            $this->queueCommand($command);
47
+        } else {
48
+            $this->runCommand($command);
49
+        }
50
+    }
51 51
 
52
-	/**
53
-	 * Queue a command in the bus
54
-	 *
55
-	 * @param \OCP\Command\ICommand | callable $command
56
-	 */
57
-	abstract protected function queueCommand($command);
52
+    /**
53
+     * Queue a command in the bus
54
+     *
55
+     * @param \OCP\Command\ICommand | callable $command
56
+     */
57
+    abstract protected function queueCommand($command);
58 58
 
59
-	/**
60
-	 * Require all commands using a trait to be run synchronous
61
-	 *
62
-	 * @param string $trait
63
-	 */
64
-	public function requireSync($trait) {
65
-		$this->syncTraits[] = trim($trait, '\\');
66
-	}
59
+    /**
60
+     * Require all commands using a trait to be run synchronous
61
+     *
62
+     * @param string $trait
63
+     */
64
+    public function requireSync($trait) {
65
+        $this->syncTraits[] = trim($trait, '\\');
66
+    }
67 67
 
68
-	/**
69
-	 * @param \OCP\Command\ICommand | callable $command
70
-	 */
71
-	private function runCommand($command) {
72
-		if ($command instanceof ICommand) {
73
-			$command->handle();
74
-		} else {
75
-			$command();
76
-		}
77
-	}
68
+    /**
69
+     * @param \OCP\Command\ICommand | callable $command
70
+     */
71
+    private function runCommand($command) {
72
+        if ($command instanceof ICommand) {
73
+            $command->handle();
74
+        } else {
75
+            $command();
76
+        }
77
+    }
78 78
 
79
-	/**
80
-	 * @param \OCP\Command\ICommand | callable $command
81
-	 * @return bool
82
-	 */
83
-	private function canRunAsync($command) {
84
-		$traits = $this->getTraits($command);
85
-		foreach ($traits as $trait) {
86
-			if (array_search($trait, $this->syncTraits) !== false) {
87
-				return false;
88
-			}
89
-		}
90
-		return true;
91
-	}
79
+    /**
80
+     * @param \OCP\Command\ICommand | callable $command
81
+     * @return bool
82
+     */
83
+    private function canRunAsync($command) {
84
+        $traits = $this->getTraits($command);
85
+        foreach ($traits as $trait) {
86
+            if (array_search($trait, $this->syncTraits) !== false) {
87
+                return false;
88
+            }
89
+        }
90
+        return true;
91
+    }
92 92
 
93
-	/**
94
-	 * @param \OCP\Command\ICommand | callable $command
95
-	 * @return string[]
96
-	 */
97
-	private function getTraits($command) {
98
-		if ($command instanceof ICommand) {
99
-			return class_uses($command);
100
-		} else {
101
-			return [];
102
-		}
103
-	}
93
+    /**
94
+     * @param \OCP\Command\ICommand | callable $command
95
+     * @return string[]
96
+     */
97
+    private function getTraits($command) {
98
+        if ($command instanceof ICommand) {
99
+            return class_uses($command);
100
+        } else {
101
+            return [];
102
+        }
103
+    }
104 104
 }
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/webdav.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
 // no php execution timeout for webdav
27 27
 if (strpos(@ini_get('disable_functions'), 'set_time_limit') === false) {
28
-	@set_time_limit(0);
28
+    @set_time_limit(0);
29 29
 }
30 30
 ignore_user_abort(true);
31 31
 
@@ -33,38 +33,38 @@  discard block
 block discarded – undo
33 33
 \OC_Util::obEnd();
34 34
 
35 35
 $serverFactory = new \OCA\DAV\Connector\Sabre\ServerFactory(
36
-	\OC::$server->getConfig(),
37
-	\OC::$server->getLogger(),
38
-	\OC::$server->getDatabaseConnection(),
39
-	\OC::$server->getUserSession(),
40
-	\OC::$server->getMountManager(),
41
-	\OC::$server->getTagManager(),
42
-	\OC::$server->getRequest(),
43
-	\OC::$server->getPreviewManager()
36
+    \OC::$server->getConfig(),
37
+    \OC::$server->getLogger(),
38
+    \OC::$server->getDatabaseConnection(),
39
+    \OC::$server->getUserSession(),
40
+    \OC::$server->getMountManager(),
41
+    \OC::$server->getTagManager(),
42
+    \OC::$server->getRequest(),
43
+    \OC::$server->getPreviewManager()
44 44
 );
45 45
 
46 46
 // Backends
47 47
 $authBackend = new \OCA\DAV\Connector\Sabre\Auth(
48
-	\OC::$server->getSession(),
49
-	\OC::$server->getUserSession(),
50
-	\OC::$server->getRequest(),
51
-	\OC::$server->getTwoFactorAuthManager(),
52
-	\OC::$server->getBruteForceThrottler(),
53
-	'principals/'
48
+    \OC::$server->getSession(),
49
+    \OC::$server->getUserSession(),
50
+    \OC::$server->getRequest(),
51
+    \OC::$server->getTwoFactorAuthManager(),
52
+    \OC::$server->getBruteForceThrottler(),
53
+    'principals/'
54 54
 );
55 55
 $authPlugin = new \Sabre\DAV\Auth\Plugin($authBackend);
56 56
 $bearerAuthPlugin = new \OCA\DAV\Connector\Sabre\BearerAuth(
57
-	\OC::$server->getUserSession(),
58
-	\OC::$server->getSession(),
59
-	\OC::$server->getRequest()
57
+    \OC::$server->getUserSession(),
58
+    \OC::$server->getSession(),
59
+    \OC::$server->getRequest()
60 60
 );
61 61
 $authPlugin->addBackend($bearerAuthPlugin);
62 62
 
63 63
 $requestUri = \OC::$server->getRequest()->getRequestUri();
64 64
 
65 65
 $server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function() {
66
-	// use the view for the logged in user
67
-	return \OC\Files\Filesystem::getView();
66
+    // use the view for the logged in user
67
+    return \OC\Files\Filesystem::getView();
68 68
 });
69 69
 
70 70
 $dispatcher = \OC::$server->getEventDispatcher();
Please login to merge, or discard this patch.
lib/private/Template/ResourceLocator.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 				$this->doFind($resource);
76 76
 			} catch (ResourceNotFoundException $e) {
77 77
 				$resourceApp = substr($resource, 0, strpos($resource, '/'));
78
-				$this->logger->debug('Could not find resource file "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
78
+				$this->logger->debug('Could not find resource file "'.$e->getResourcePath().'"', ['app' => $resourceApp]);
79 79
 			}
80 80
 		}
81 81
 		if (!empty($this->theme)) {
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 					$this->doFindTheme($resource);
85 85
 				} catch (ResourceNotFoundException $e) {
86 86
 					$resourceApp = substr($resource, 0, strpos($resource, '/'));
87
-					$this->logger->debug('Could not find resource file in theme "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
87
+					$this->logger->debug('Could not find resource file in theme "'.$e->getResourcePath().'"', ['app' => $resourceApp]);
88 88
 				}
89 89
 			}
90 90
 		}
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 		}
186 186
 		$this->resources[] = array($root, $webRoot, $file);
187 187
 
188
-		if ($throw && !is_file($root . '/' . $file)) {
188
+		if ($throw && !is_file($root.'/'.$file)) {
189 189
 			throw new ResourceNotFoundException($file, $webRoot);
190 190
 		}
191 191
 	}
Please login to merge, or discard this patch.
Indentation   +169 added lines, -169 removed lines patch added patch discarded remove patch
@@ -27,173 +27,173 @@
 block discarded – undo
27 27
 namespace OC\Template;
28 28
 
29 29
 abstract class ResourceLocator {
30
-	protected $theme;
31
-
32
-	protected $mapping;
33
-	protected $serverroot;
34
-	protected $thirdpartyroot;
35
-	protected $webroot;
36
-
37
-	protected $resources = array();
38
-
39
-	/** @var \OCP\ILogger */
40
-	protected $logger;
41
-
42
-	/**
43
-	 * @param \OCP\ILogger $logger
44
-	 * @param string $theme
45
-	 * @param array $core_map
46
-	 * @param array $party_map
47
-	 */
48
-	public function __construct(\OCP\ILogger $logger, $theme, $core_map, $party_map) {
49
-		$this->logger = $logger;
50
-		$this->theme = $theme;
51
-		$this->mapping = $core_map + $party_map;
52
-		$this->serverroot = key($core_map);
53
-		$this->thirdpartyroot = key($party_map);
54
-		$this->webroot = $this->mapping[$this->serverroot];
55
-	}
56
-
57
-	/**
58
-	 * @param string $resource
59
-	 */
60
-	abstract public function doFind($resource);
61
-
62
-	/**
63
-	 * @param string $resource
64
-	 */
65
-	abstract public function doFindTheme($resource);
66
-
67
-	/**
68
-	 * Finds the resources and adds them to the list
69
-	 *
70
-	 * @param array $resources
71
-	 */
72
-	public function find($resources) {
73
-		foreach ($resources as $resource) {
74
-			try {
75
-				$this->doFind($resource);
76
-			} catch (ResourceNotFoundException $e) {
77
-				$resourceApp = substr($resource, 0, strpos($resource, '/'));
78
-				$this->logger->debug('Could not find resource file "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
79
-			}
80
-		}
81
-		if (!empty($this->theme)) {
82
-			foreach ($resources as $resource) {
83
-				try {
84
-					$this->doFindTheme($resource);
85
-				} catch (ResourceNotFoundException $e) {
86
-					$resourceApp = substr($resource, 0, strpos($resource, '/'));
87
-					$this->logger->debug('Could not find resource file in theme "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
88
-				}
89
-			}
90
-		}
91
-	}
92
-
93
-	/**
94
-	 * append the $file resource if exist at $root
95
-	 *
96
-	 * @param string $root path to check
97
-	 * @param string $file the filename
98
-	 * @param string|null $webRoot base for path, default map $root to $webRoot
99
-	 * @return bool True if the resource was found, false otherwise
100
-	 */
101
-	protected function appendIfExist($root, $file, $webRoot = null) {
102
-		if (is_file($root.'/'.$file)) {
103
-			$this->append($root, $file, $webRoot, false);
104
-			return true;
105
-		}
106
-		return false;
107
-	}
108
-
109
-	/**
110
-	 * Attempt to find the webRoot
111
-	 *
112
-	 * traverse the potential web roots upwards in the path
113
-	 *
114
-	 * example:
115
-	 *   - root: /srv/www/apps/myapp
116
-	 *   - available mappings: ['/srv/www']
117
-	 *
118
-	 * First we check if a mapping for /srv/www/apps/myapp is available,
119
-	 * then /srv/www/apps, /srv/www/apps, /srv/www, ... until we find a
120
-	 * valid web root
121
-	 *
122
-	 * @param string $root
123
-	 * @return string|null The web root or null on failure
124
-	 */
125
-	protected function findWebRoot($root) {
126
-		$webRoot = null;
127
-		$tmpRoot = $root;
128
-
129
-		while ($webRoot === null) {
130
-			if (isset($this->mapping[$tmpRoot])) {
131
-				$webRoot = $this->mapping[$tmpRoot];
132
-				break;
133
-			}
134
-
135
-			if ($tmpRoot === '/') {
136
-				break;
137
-			}
138
-
139
-			$tmpRoot = dirname($tmpRoot);
140
-		}
141
-
142
-		if ($webRoot === null) {
143
-			$realpath = realpath($root);
144
-
145
-			if ($realpath && ($realpath !== $root)) {
146
-				return $this->findWebRoot($realpath);
147
-			}
148
-		}
149
-
150
-		return $webRoot;
151
-	}
152
-
153
-	/**
154
-	 * append the $file resource at $root
155
-	 *
156
-	 * @param string $root path to check
157
-	 * @param string $file the filename
158
-	 * @param string|null $webRoot base for path, default map $root to $webRoot
159
-	 * @param bool $throw Throw an exception, when the route does not exist
160
-	 * @throws ResourceNotFoundException Only thrown when $throw is true and the resource is missing
161
-	 */
162
-	protected function append($root, $file, $webRoot = null, $throw = true) {
163
-
164
-		if (!is_string($root)) {
165
-			if ($throw) {
166
-				throw new ResourceNotFoundException($file, $webRoot);
167
-			}
168
-			return;
169
-		}
170
-
171
-		if (!$webRoot) {
172
-			$webRoot = $this->findWebRoot($root);
173
-
174
-			if ($webRoot === null) {
175
-				$webRoot = '';
176
-				$this->logger->error('ResourceLocator can not find a web root (root: {root}, file: {file}, webRoot: {webRoot}, throw: {throw})', [
177
-					'app' => 'lib',
178
-					'root' => $root,
179
-					'file' => $file,
180
-					'webRoot' => $webRoot,
181
-					'throw' => $throw ? 'true' : 'false'
182
-				]);
183
-			}
184
-		}
185
-		$this->resources[] = array($root, $webRoot, $file);
186
-
187
-		if ($throw && !is_file($root . '/' . $file)) {
188
-			throw new ResourceNotFoundException($file, $webRoot);
189
-		}
190
-	}
191
-
192
-	/**
193
-	 * Returns the list of all resources that should be loaded
194
-	 * @return array
195
-	 */
196
-	public function getResources() {
197
-		return $this->resources;
198
-	}
30
+    protected $theme;
31
+
32
+    protected $mapping;
33
+    protected $serverroot;
34
+    protected $thirdpartyroot;
35
+    protected $webroot;
36
+
37
+    protected $resources = array();
38
+
39
+    /** @var \OCP\ILogger */
40
+    protected $logger;
41
+
42
+    /**
43
+     * @param \OCP\ILogger $logger
44
+     * @param string $theme
45
+     * @param array $core_map
46
+     * @param array $party_map
47
+     */
48
+    public function __construct(\OCP\ILogger $logger, $theme, $core_map, $party_map) {
49
+        $this->logger = $logger;
50
+        $this->theme = $theme;
51
+        $this->mapping = $core_map + $party_map;
52
+        $this->serverroot = key($core_map);
53
+        $this->thirdpartyroot = key($party_map);
54
+        $this->webroot = $this->mapping[$this->serverroot];
55
+    }
56
+
57
+    /**
58
+     * @param string $resource
59
+     */
60
+    abstract public function doFind($resource);
61
+
62
+    /**
63
+     * @param string $resource
64
+     */
65
+    abstract public function doFindTheme($resource);
66
+
67
+    /**
68
+     * Finds the resources and adds them to the list
69
+     *
70
+     * @param array $resources
71
+     */
72
+    public function find($resources) {
73
+        foreach ($resources as $resource) {
74
+            try {
75
+                $this->doFind($resource);
76
+            } catch (ResourceNotFoundException $e) {
77
+                $resourceApp = substr($resource, 0, strpos($resource, '/'));
78
+                $this->logger->debug('Could not find resource file "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
79
+            }
80
+        }
81
+        if (!empty($this->theme)) {
82
+            foreach ($resources as $resource) {
83
+                try {
84
+                    $this->doFindTheme($resource);
85
+                } catch (ResourceNotFoundException $e) {
86
+                    $resourceApp = substr($resource, 0, strpos($resource, '/'));
87
+                    $this->logger->debug('Could not find resource file in theme "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
88
+                }
89
+            }
90
+        }
91
+    }
92
+
93
+    /**
94
+     * append the $file resource if exist at $root
95
+     *
96
+     * @param string $root path to check
97
+     * @param string $file the filename
98
+     * @param string|null $webRoot base for path, default map $root to $webRoot
99
+     * @return bool True if the resource was found, false otherwise
100
+     */
101
+    protected function appendIfExist($root, $file, $webRoot = null) {
102
+        if (is_file($root.'/'.$file)) {
103
+            $this->append($root, $file, $webRoot, false);
104
+            return true;
105
+        }
106
+        return false;
107
+    }
108
+
109
+    /**
110
+     * Attempt to find the webRoot
111
+     *
112
+     * traverse the potential web roots upwards in the path
113
+     *
114
+     * example:
115
+     *   - root: /srv/www/apps/myapp
116
+     *   - available mappings: ['/srv/www']
117
+     *
118
+     * First we check if a mapping for /srv/www/apps/myapp is available,
119
+     * then /srv/www/apps, /srv/www/apps, /srv/www, ... until we find a
120
+     * valid web root
121
+     *
122
+     * @param string $root
123
+     * @return string|null The web root or null on failure
124
+     */
125
+    protected function findWebRoot($root) {
126
+        $webRoot = null;
127
+        $tmpRoot = $root;
128
+
129
+        while ($webRoot === null) {
130
+            if (isset($this->mapping[$tmpRoot])) {
131
+                $webRoot = $this->mapping[$tmpRoot];
132
+                break;
133
+            }
134
+
135
+            if ($tmpRoot === '/') {
136
+                break;
137
+            }
138
+
139
+            $tmpRoot = dirname($tmpRoot);
140
+        }
141
+
142
+        if ($webRoot === null) {
143
+            $realpath = realpath($root);
144
+
145
+            if ($realpath && ($realpath !== $root)) {
146
+                return $this->findWebRoot($realpath);
147
+            }
148
+        }
149
+
150
+        return $webRoot;
151
+    }
152
+
153
+    /**
154
+     * append the $file resource at $root
155
+     *
156
+     * @param string $root path to check
157
+     * @param string $file the filename
158
+     * @param string|null $webRoot base for path, default map $root to $webRoot
159
+     * @param bool $throw Throw an exception, when the route does not exist
160
+     * @throws ResourceNotFoundException Only thrown when $throw is true and the resource is missing
161
+     */
162
+    protected function append($root, $file, $webRoot = null, $throw = true) {
163
+
164
+        if (!is_string($root)) {
165
+            if ($throw) {
166
+                throw new ResourceNotFoundException($file, $webRoot);
167
+            }
168
+            return;
169
+        }
170
+
171
+        if (!$webRoot) {
172
+            $webRoot = $this->findWebRoot($root);
173
+
174
+            if ($webRoot === null) {
175
+                $webRoot = '';
176
+                $this->logger->error('ResourceLocator can not find a web root (root: {root}, file: {file}, webRoot: {webRoot}, throw: {throw})', [
177
+                    'app' => 'lib',
178
+                    'root' => $root,
179
+                    'file' => $file,
180
+                    'webRoot' => $webRoot,
181
+                    'throw' => $throw ? 'true' : 'false'
182
+                ]);
183
+            }
184
+        }
185
+        $this->resources[] = array($root, $webRoot, $file);
186
+
187
+        if ($throw && !is_file($root . '/' . $file)) {
188
+            throw new ResourceNotFoundException($file, $webRoot);
189
+        }
190
+    }
191
+
192
+    /**
193
+     * Returns the list of all resources that should be loaded
194
+     * @return array
195
+     */
196
+    public function getResources() {
197
+        return $this->resources;
198
+    }
199 199
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/InvalidBackend.php 2 patches
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -32,34 +32,34 @@
 block discarded – undo
32 32
  */
33 33
 class InvalidBackend extends Backend {
34 34
 
35
-	/** @var string Invalid backend id */
36
-	private $invalidId;
35
+    /** @var string Invalid backend id */
36
+    private $invalidId;
37 37
 
38
-	/**
39
-	 * Constructs a new InvalidBackend with the id of the invalid backend
40
-	 * for display purposes
41
-	 *
42
-	 * @param string $invalidId id of the backend that did not exist
43
-	 */
44
-	function __construct($invalidId) {
45
-		$this->invalidId = $invalidId;
46
-		$this
47
-			->setIdentifier($invalidId)
48
-			->setStorageClass('\OC\Files\Storage\FailedStorage')
49
-			->setText('Unknown storage backend ' . $invalidId);
50
-	}
38
+    /**
39
+     * Constructs a new InvalidBackend with the id of the invalid backend
40
+     * for display purposes
41
+     *
42
+     * @param string $invalidId id of the backend that did not exist
43
+     */
44
+    function __construct($invalidId) {
45
+        $this->invalidId = $invalidId;
46
+        $this
47
+            ->setIdentifier($invalidId)
48
+            ->setStorageClass('\OC\Files\Storage\FailedStorage')
49
+            ->setText('Unknown storage backend ' . $invalidId);
50
+    }
51 51
 
52
-	/**
53
-	 * Returns the invalid backend id
54
-	 *
55
-	 * @return string invalid backend id
56
-	 */
57
-	public function getInvalidId() {
58
-		return $this->invalidId;
59
-	}
52
+    /**
53
+     * Returns the invalid backend id
54
+     *
55
+     * @return string invalid backend id
56
+     */
57
+    public function getInvalidId() {
58
+        return $this->invalidId;
59
+    }
60 60
 
61
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
62
-		$storage->setBackendOption('exception', new \Exception('Unknown storage backend "' . $this->invalidId . '"', StorageNotAvailableException::STATUS_ERROR));
63
-	}
61
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
62
+        $storage->setBackendOption('exception', new \Exception('Unknown storage backend "' . $this->invalidId . '"', StorageNotAvailableException::STATUS_ERROR));
63
+    }
64 64
 }
65 65
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 		$this
50 50
 			->setIdentifier($invalidId)
51 51
 			->setStorageClass('\OC\Files\Storage\FailedStorage')
52
-			->setText('Unknown storage backend ' . $invalidId);
52
+			->setText('Unknown storage backend '.$invalidId);
53 53
 	}
54 54
 
55 55
 	/**
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	}
63 63
 
64 64
 	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
65
-		$storage->setBackendOption('exception', new \Exception('Unknown storage backend "' . $this->invalidId . '"', StorageNotAvailableException::STATUS_ERROR));
65
+		$storage->setBackendOption('exception', new \Exception('Unknown storage backend "'.$this->invalidId.'"', StorageNotAvailableException::STATUS_ERROR));
66 66
 	}
67 67
 }
68 68
 
Please login to merge, or discard this patch.
lib/public/GroupInterface.php 2 patches
Indentation   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -40,84 +40,84 @@
 block discarded – undo
40 40
  */
41 41
 interface GroupInterface {
42 42
 
43
-	/**
44
-	 * actions that user backends can define
45
-	 */
46
-	const CREATE_GROUP		= 0x00000001;
47
-	const DELETE_GROUP		= 0x00000010;
48
-	const ADD_TO_GROUP		= 0x00000100;
49
-	const REMOVE_FROM_GOUP	= 0x00001000; // oops
50
-	const REMOVE_FROM_GROUP	= 0x00001000;
51
-	//OBSOLETE const GET_DISPLAYNAME	= 0x00010000;
52
-	const COUNT_USERS		= 0x00100000;
53
-	const GROUP_DETAILS		= 0x01000000;
54
-	/**
55
-	 * @since 13.0.0
56
-	 */
57
-	const IS_ADMIN  = 0x10000000;
43
+    /**
44
+     * actions that user backends can define
45
+     */
46
+    const CREATE_GROUP		= 0x00000001;
47
+    const DELETE_GROUP		= 0x00000010;
48
+    const ADD_TO_GROUP		= 0x00000100;
49
+    const REMOVE_FROM_GOUP	= 0x00001000; // oops
50
+    const REMOVE_FROM_GROUP	= 0x00001000;
51
+    //OBSOLETE const GET_DISPLAYNAME	= 0x00010000;
52
+    const COUNT_USERS		= 0x00100000;
53
+    const GROUP_DETAILS		= 0x01000000;
54
+    /**
55
+     * @since 13.0.0
56
+     */
57
+    const IS_ADMIN  = 0x10000000;
58 58
 
59
-	/**
60
-	 * Check if backend implements actions
61
-	 * @param int $actions bitwise-or'ed actions
62
-	 * @return boolean
63
-	 * @since 4.5.0
64
-	 *
65
-	 * Returns the supported actions as int to be
66
-	 * compared with \OC_Group_Backend::CREATE_GROUP etc.
67
-	 */
68
-	public function implementsActions($actions);
59
+    /**
60
+     * Check if backend implements actions
61
+     * @param int $actions bitwise-or'ed actions
62
+     * @return boolean
63
+     * @since 4.5.0
64
+     *
65
+     * Returns the supported actions as int to be
66
+     * compared with \OC_Group_Backend::CREATE_GROUP etc.
67
+     */
68
+    public function implementsActions($actions);
69 69
 
70
-	/**
71
-	 * is user in group?
72
-	 * @param string $uid uid of the user
73
-	 * @param string $gid gid of the group
74
-	 * @return bool
75
-	 * @since 4.5.0
76
-	 *
77
-	 * Checks whether the user is member of a group or not.
78
-	 */
79
-	public function inGroup($uid, $gid);
70
+    /**
71
+     * is user in group?
72
+     * @param string $uid uid of the user
73
+     * @param string $gid gid of the group
74
+     * @return bool
75
+     * @since 4.5.0
76
+     *
77
+     * Checks whether the user is member of a group or not.
78
+     */
79
+    public function inGroup($uid, $gid);
80 80
 
81
-	/**
82
-	 * Get all groups a user belongs to
83
-	 * @param string $uid Name of the user
84
-	 * @return array an array of group names
85
-	 * @since 4.5.0
86
-	 *
87
-	 * This function fetches all groups a user belongs to. It does not check
88
-	 * if the user exists at all.
89
-	 */
90
-	public function getUserGroups($uid);
81
+    /**
82
+     * Get all groups a user belongs to
83
+     * @param string $uid Name of the user
84
+     * @return array an array of group names
85
+     * @since 4.5.0
86
+     *
87
+     * This function fetches all groups a user belongs to. It does not check
88
+     * if the user exists at all.
89
+     */
90
+    public function getUserGroups($uid);
91 91
 
92
-	/**
93
-	 * get a list of all groups
94
-	 * @param string $search
95
-	 * @param int $limit
96
-	 * @param int $offset
97
-	 * @return array an array of group names
98
-	 * @since 4.5.0
99
-	 *
100
-	 * Returns a list with all groups
101
-	 */
102
-	public function getGroups($search = '', $limit = -1, $offset = 0);
92
+    /**
93
+     * get a list of all groups
94
+     * @param string $search
95
+     * @param int $limit
96
+     * @param int $offset
97
+     * @return array an array of group names
98
+     * @since 4.5.0
99
+     *
100
+     * Returns a list with all groups
101
+     */
102
+    public function getGroups($search = '', $limit = -1, $offset = 0);
103 103
 
104
-	/**
105
-	 * check if a group exists
106
-	 * @param string $gid
107
-	 * @return bool
108
-	 * @since 4.5.0
109
-	 */
110
-	public function groupExists($gid);
104
+    /**
105
+     * check if a group exists
106
+     * @param string $gid
107
+     * @return bool
108
+     * @since 4.5.0
109
+     */
110
+    public function groupExists($gid);
111 111
 
112
-	/**
113
-	 * get a list of all users in a group
114
-	 * @param string $gid
115
-	 * @param string $search
116
-	 * @param int $limit
117
-	 * @param int $offset
118
-	 * @return array an array of user ids
119
-	 * @since 4.5.0
120
-	 */
121
-	public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0);
112
+    /**
113
+     * get a list of all users in a group
114
+     * @param string $gid
115
+     * @param string $search
116
+     * @param int $limit
117
+     * @param int $offset
118
+     * @return array an array of user ids
119
+     * @since 4.5.0
120
+     */
121
+    public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0);
122 122
 
123 123
 }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,15 +46,15 @@
 block discarded – undo
46 46
 	const CREATE_GROUP		= 0x00000001;
47 47
 	const DELETE_GROUP		= 0x00000010;
48 48
 	const ADD_TO_GROUP		= 0x00000100;
49
-	const REMOVE_FROM_GOUP	= 0x00001000; // oops
50
-	const REMOVE_FROM_GROUP	= 0x00001000;
49
+	const REMOVE_FROM_GOUP = 0x00001000; // oops
50
+	const REMOVE_FROM_GROUP = 0x00001000;
51 51
 	//OBSOLETE const GET_DISPLAYNAME	= 0x00010000;
52
-	const COUNT_USERS		= 0x00100000;
53
-	const GROUP_DETAILS		= 0x01000000;
52
+	const COUNT_USERS = 0x00100000;
53
+	const GROUP_DETAILS = 0x01000000;
54 54
 	/**
55 55
 	 * @since 13.0.0
56 56
 	 */
57
-	const IS_ADMIN  = 0x10000000;
57
+	const IS_ADMIN = 0x10000000;
58 58
 
59 59
 	/**
60 60
 	 * Check if backend implements actions
Please login to merge, or discard this patch.
lib/public/Collaboration/Collaborators/ISearchPlugin.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -30,13 +30,13 @@
 block discarded – undo
30 30
  * @since 13.0.0
31 31
  */
32 32
 interface ISearchPlugin {
33
-	/**
34
-	 * @param string $search
35
-	 * @param int $limit
36
-	 * @param int $offset
37
-	 * @param ISearchResult $searchResult
38
-	 * @return bool whether the plugin has more results
39
-	 * @since 13.0.0
40
-	 */
41
-	public function search($search, $limit, $offset, ISearchResult $searchResult);
33
+    /**
34
+     * @param string $search
35
+     * @param int $limit
36
+     * @param int $offset
37
+     * @param ISearchResult $searchResult
38
+     * @return bool whether the plugin has more results
39
+     * @since 13.0.0
40
+     */
41
+    public function search($search, $limit, $offset, ISearchResult $searchResult);
42 42
 }
Please login to merge, or discard this patch.
lib/private/Setup/OCI.php 2 patches
Indentation   +70 added lines, -70 removed lines patch added patch discarded remove patch
@@ -32,81 +32,81 @@
 block discarded – undo
32 32
 namespace OC\Setup;
33 33
 
34 34
 class OCI extends AbstractDatabase {
35
-	public $dbprettyname = 'Oracle';
35
+    public $dbprettyname = 'Oracle';
36 36
 
37
-	protected $dbtablespace;
37
+    protected $dbtablespace;
38 38
 
39
-	public function initialize($config) {
40
-		parent::initialize($config);
41
-		if (array_key_exists('dbtablespace', $config)) {
42
-			$this->dbtablespace = $config['dbtablespace'];
43
-		} else {
44
-			$this->dbtablespace = 'USERS';
45
-		}
46
-		// allow empty hostname for oracle
47
-		$this->dbHost = $config['dbhost'];
39
+    public function initialize($config) {
40
+        parent::initialize($config);
41
+        if (array_key_exists('dbtablespace', $config)) {
42
+            $this->dbtablespace = $config['dbtablespace'];
43
+        } else {
44
+            $this->dbtablespace = 'USERS';
45
+        }
46
+        // allow empty hostname for oracle
47
+        $this->dbHost = $config['dbhost'];
48 48
 
49
-		$this->config->setValues([
50
-			'dbhost' => $this->dbHost,
51
-			'dbtablespace' => $this->dbtablespace,
52
-		]);
53
-	}
49
+        $this->config->setValues([
50
+            'dbhost' => $this->dbHost,
51
+            'dbtablespace' => $this->dbtablespace,
52
+        ]);
53
+    }
54 54
 
55
-	public function validate($config) {
56
-		$errors = array();
57
-		if (empty($config['dbuser']) && empty($config['dbname'])) {
58
-			$errors[] = $this->trans->t("%s enter the database username and name.", array($this->dbprettyname));
59
-		} else if (empty($config['dbuser'])) {
60
-			$errors[] = $this->trans->t("%s enter the database username.", array($this->dbprettyname));
61
-		} else if (empty($config['dbname'])) {
62
-			$errors[] = $this->trans->t("%s enter the database name.", array($this->dbprettyname));
63
-		}
64
-		return $errors;
65
-	}
55
+    public function validate($config) {
56
+        $errors = array();
57
+        if (empty($config['dbuser']) && empty($config['dbname'])) {
58
+            $errors[] = $this->trans->t("%s enter the database username and name.", array($this->dbprettyname));
59
+        } else if (empty($config['dbuser'])) {
60
+            $errors[] = $this->trans->t("%s enter the database username.", array($this->dbprettyname));
61
+        } else if (empty($config['dbname'])) {
62
+            $errors[] = $this->trans->t("%s enter the database name.", array($this->dbprettyname));
63
+        }
64
+        return $errors;
65
+    }
66 66
 
67
-	public function setupDatabase($username) {
68
-		try {
69
-			$this->connect();
70
-		} catch (\Exception $e) {
71
-			$errorMessage = $this->getLastError();
72
-			if ($errorMessage) {
73
-				throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
74
-					$errorMessage . ' Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
75
-					. ' ORACLE_SID=' . getenv('ORACLE_SID')
76
-					. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
77
-					. ' NLS_LANG=' . getenv('NLS_LANG')
78
-					. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
79
-			}
80
-			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
81
-				'Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
82
-				. ' ORACLE_SID=' . getenv('ORACLE_SID')
83
-				. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
84
-				. ' NLS_LANG=' . getenv('NLS_LANG')
85
-				. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
86
-		}
67
+    public function setupDatabase($username) {
68
+        try {
69
+            $this->connect();
70
+        } catch (\Exception $e) {
71
+            $errorMessage = $this->getLastError();
72
+            if ($errorMessage) {
73
+                throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
74
+                    $errorMessage . ' Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
75
+                    . ' ORACLE_SID=' . getenv('ORACLE_SID')
76
+                    . ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
77
+                    . ' NLS_LANG=' . getenv('NLS_LANG')
78
+                    . ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
79
+            }
80
+            throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
81
+                'Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
82
+                . ' ORACLE_SID=' . getenv('ORACLE_SID')
83
+                . ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
84
+                . ' NLS_LANG=' . getenv('NLS_LANG')
85
+                . ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
86
+        }
87 87
 
88
-		$this->config->setValues([
89
-			'dbuser' => $this->dbUser,
90
-			'dbname' => $this->dbName,
91
-			'dbpassword' => $this->dbPassword,
92
-		]);
93
-	}
88
+        $this->config->setValues([
89
+            'dbuser' => $this->dbUser,
90
+            'dbname' => $this->dbName,
91
+            'dbpassword' => $this->dbPassword,
92
+        ]);
93
+    }
94 94
 
95
-	/**
96
-	 * @param resource $connection
97
-	 * @return string
98
-	 */
99
-	protected function getLastError($connection = null) {
100
-		if ($connection) {
101
-			$error = oci_error($connection);
102
-		} else {
103
-			$error = oci_error();
104
-		}
105
-		foreach (array('message', 'code') as $key) {
106
-			if (isset($error[$key])) {
107
-				return $error[$key];
108
-			}
109
-		}
110
-		return '';
111
-	}
95
+    /**
96
+     * @param resource $connection
97
+     * @return string
98
+     */
99
+    protected function getLastError($connection = null) {
100
+        if ($connection) {
101
+            $error = oci_error($connection);
102
+        } else {
103
+            $error = oci_error();
104
+        }
105
+        foreach (array('message', 'code') as $key) {
106
+            if (isset($error[$key])) {
107
+                return $error[$key];
108
+            }
109
+        }
110
+        return '';
111
+    }
112 112
 }
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -71,18 +71,18 @@
 block discarded – undo
71 71
 			$errorMessage = $this->getLastError();
72 72
 			if ($errorMessage) {
73 73
 				throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
74
-					$errorMessage . ' Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
75
-					. ' ORACLE_SID=' . getenv('ORACLE_SID')
76
-					. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
77
-					. ' NLS_LANG=' . getenv('NLS_LANG')
78
-					. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
74
+					$errorMessage.' Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
75
+					. ' ORACLE_SID='.getenv('ORACLE_SID')
76
+					. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
77
+					. ' NLS_LANG='.getenv('NLS_LANG')
78
+					. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable');
79 79
 			}
80 80
 			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
81
-				'Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
82
-				. ' ORACLE_SID=' . getenv('ORACLE_SID')
83
-				. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
84
-				. ' NLS_LANG=' . getenv('NLS_LANG')
85
-				. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
81
+				'Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
82
+				. ' ORACLE_SID='.getenv('ORACLE_SID')
83
+				. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
84
+				. ' NLS_LANG='.getenv('NLS_LANG')
85
+				. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable');
86 86
 		}
87 87
 
88 88
 		$this->config->setValues([
Please login to merge, or discard this patch.