nextcloud / server

apps/files_external/lib/Lib/Backend/Backend.php

Indentation +104 added lines, -104 removed lines

@@ -57,110 +57,110 @@
  */
 class Backend implements \JsonSerializable {
 
-	use VisibilityTrait;
-	use FrontendDefinitionTrait;
-	use PriorityTrait;
-	use DependencyTrait;
-	use StorageModifierTrait;
-	use IdentifierTrait;
-
-	/** @var string storage class */
-	private $storageClass;
-
-	/** @var array 'scheme' => true, supported authentication schemes */
-	private $authSchemes = [];
-
-	/** @var AuthMechanism|callable authentication mechanism fallback */
-	private $legacyAuthMechanism;
-
-	/**
-	 * @return string
-	 */
-	public function getStorageClass() {
-		return $this->storageClass;
-	}
-
-	/**
-	 * @param string $class
-	 * @return $this
-	 */
-	public function setStorageClass($class) {
-		$this->storageClass = $class;
-		return $this;
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAuthSchemes() {
-		if (empty($this->authSchemes)) {
-			return [AuthMechanism::SCHEME_NULL => true];
-		}
-		return $this->authSchemes;
-	}
-
-	/**
-	 * @param string $scheme
-	 * @return self
-	 */
-	public function addAuthScheme($scheme) {
-		$this->authSchemes[$scheme] = true;
-		return $this;
-	}
-
-	/**
-	 * @param array $parameters storage parameters, for dynamic mechanism selection
-	 * @return AuthMechanism
-	 */
-	public function getLegacyAuthMechanism(array $parameters = []) {
-		if (is_callable($this->legacyAuthMechanism)) {
-			return call_user_func($this->legacyAuthMechanism, $parameters);
-		}
-		return $this->legacyAuthMechanism;
-	}
-
-	/**
-	 * @param AuthMechanism $authMechanism
-	 * @return self
-	 */
-	public function setLegacyAuthMechanism(AuthMechanism $authMechanism) {
-		$this->legacyAuthMechanism = $authMechanism;
-		return $this;
-	}
-
-	/**
-	 * @param callable $callback dynamic auth mechanism selection
-	 * @return self
-	 */
-	public function setLegacyAuthMechanismCallback(callable $callback) {
-		$this->legacyAuthMechanism = $callback;
-	}
-
-	/**
-	 * Serialize into JSON for client-side JS
-	 *
-	 * @return array
-	 */
-	public function jsonSerialize() {
-		$data = $this->jsonSerializeDefinition();
-		$data += $this->jsonSerializeIdentifier();
-
-		$data['backend'] = $data['name']; // legacy compat
-		$data['priority'] = $this->getPriority();
-		$data['authSchemes'] = $this->getAuthSchemes();
-
-		return $data;
-	}
-
-	/**
-	 * Check if parameters are satisfied in a StorageConfig
-	 *
-	 * @param StorageConfig $storage
-	 * @return bool
-	 */
-	public function validateStorage(StorageConfig $storage) {
-		return $this->validateStorageDefinition($storage);
-	}
+    use VisibilityTrait;
+    use FrontendDefinitionTrait;
+    use PriorityTrait;
+    use DependencyTrait;
+    use StorageModifierTrait;
+    use IdentifierTrait;
+
+    /** @var string storage class */
+    private $storageClass;
+
+    /** @var array 'scheme' => true, supported authentication schemes */
+    private $authSchemes = [];
+
+    /** @var AuthMechanism|callable authentication mechanism fallback */
+    private $legacyAuthMechanism;
+
+    /**
+     * @return string
+     */
+    public function getStorageClass() {
+        return $this->storageClass;
+    }
+
+    /**
+     * @param string $class
+     * @return $this
+     */
+    public function setStorageClass($class) {
+        $this->storageClass = $class;
+        return $this;
+    }
+
+    /**
+     * @return array
+     */
+    public function getAuthSchemes() {
+        if (empty($this->authSchemes)) {
+            return [AuthMechanism::SCHEME_NULL => true];
+        }
+        return $this->authSchemes;
+    }
+
+    /**
+     * @param string $scheme
+     * @return self
+     */
+    public function addAuthScheme($scheme) {
+        $this->authSchemes[$scheme] = true;
+        return $this;
+    }
+
+    /**
+     * @param array $parameters storage parameters, for dynamic mechanism selection
+     * @return AuthMechanism
+     */
+    public function getLegacyAuthMechanism(array $parameters = []) {
+        if (is_callable($this->legacyAuthMechanism)) {
+            return call_user_func($this->legacyAuthMechanism, $parameters);
+        }
+        return $this->legacyAuthMechanism;
+    }
+
+    /**
+     * @param AuthMechanism $authMechanism
+     * @return self
+     */
+    public function setLegacyAuthMechanism(AuthMechanism $authMechanism) {
+        $this->legacyAuthMechanism = $authMechanism;
+        return $this;
+    }
+
+    /**
+     * @param callable $callback dynamic auth mechanism selection
+     * @return self
+     */
+    public function setLegacyAuthMechanismCallback(callable $callback) {
+        $this->legacyAuthMechanism = $callback;
+    }
+
+    /**
+     * Serialize into JSON for client-side JS
+     *
+     * @return array
+     */
+    public function jsonSerialize() {
+        $data = $this->jsonSerializeDefinition();
+        $data += $this->jsonSerializeIdentifier();
+
+        $data['backend'] = $data['name']; // legacy compat
+        $data['priority'] = $this->getPriority();
+        $data['authSchemes'] = $this->getAuthSchemes();
+
+        return $data;
+    }
+
+    /**
+     * Check if parameters are satisfied in a StorageConfig
+     *
+     * @param StorageConfig $storage
+     * @return bool
+     */
+    public function validateStorage(StorageConfig $storage) {
+        return $this->validateStorageDefinition($storage);
+    }
 
 }
 

apps/files_external/lib/Lib/FrontendDefinitionTrait.php

Indentation +124 added lines, -124 removed lines

@@ -31,129 +31,129 @@
  */
 trait FrontendDefinitionTrait {
 
-	/** @var string human-readable mechanism name */
-	private $text;
-
-	/** @var DefinitionParameter[] parameters for mechanism */
-	private $parameters = [];
-
-	/** @var string[] custom JS */
-	private $customJs = [];
-
-	/**
-	 * @return string
-	 */
-	public function getText() {
-		return $this->text;
-	}
-
-	/**
-	 * @param string $text
-	 * @return $this
-	 */
-	public function setText($text) {
-		$this->text = $text;
-		return $this;
-	}
-
-	/**
-	 * @param FrontendDefinitionTrait $a
-	 * @param FrontendDefinitionTrait $b
-	 * @return int
-	 */
-	public static function lexicalCompare(FrontendDefinitionTrait $a, FrontendDefinitionTrait $b) {
-		return strcmp($a->getText(), $b->getText());
-	}
-
-	/**
-	 * @return DefinitionParameter[]
-	 */
-	public function getParameters() {
-		return $this->parameters;
-	}
-
-	/**
-	 * @param DefinitionParameter[] $parameters
-	 * @return self
-	 */
-	public function addParameters(array $parameters) {
-		foreach ($parameters as $parameter) {
-			$this->addParameter($parameter);
-		}
-		return $this;
-	}
-
-	/**
-	 * @param DefinitionParameter $parameter
-	 * @return self
-	 */
-	public function addParameter(DefinitionParameter $parameter) {
-		$this->parameters[$parameter->getName()] = $parameter;
-		return $this;
-	}
-
-	/**
-	 * @return string[]
-	 */
-	public function getCustomJs() {
-		return $this->customJs;
-	}
-
-	/**
-	 * @param string $custom
-	 * @return self
-	 */
-	public function addCustomJs($custom) {
-		$this->customJs[] = $custom;
-		return $this;
-	}
-
-	/**
-	 * @param string $custom
-	 * @return self
-	 * @deprecated 9.1.0, use addCustomJs() instead
-	 */
-	public function setCustomJs($custom) {
-		$this->customJs = [$custom];
-		return $this;
-	}
-
-	/**
-	 * Serialize into JSON for client-side JS
-	 *
-	 * @return array
-	 */
-	public function jsonSerializeDefinition() {
-		$configuration = [];
-		foreach ($this->getParameters() as $parameter) {
-			$configuration[$parameter->getName()] = $parameter;
-		}
-
-		$data = [
-			'name' => $this->getText(),
-			'configuration' => $configuration,
-			'custom' => $this->getCustomJs(),
-		];
-		return $data;
-	}
-
-	/**
-	 * Check if parameters are satisfied in a StorageConfig
-	 *
-	 * @param StorageConfig $storage
-	 * @return bool
-	 */
-	public function validateStorageDefinition(StorageConfig $storage) {
-		foreach ($this->getParameters() as $name => $parameter) {
-			$value = $storage->getBackendOption($name);
-			if (!is_null($value) || !$parameter->isOptional()) {
-				if (!$parameter->validateValue($value)) {
-					return false;
-				}
-				$storage->setBackendOption($name, $value);
-			}
-		}
-		return true;
-	}
+    /** @var string human-readable mechanism name */
+    private $text;
+
+    /** @var DefinitionParameter[] parameters for mechanism */
+    private $parameters = [];
+
+    /** @var string[] custom JS */
+    private $customJs = [];
+
+    /**
+     * @return string
+     */
+    public function getText() {
+        return $this->text;
+    }
+
+    /**
+     * @param string $text
+     * @return $this
+     */
+    public function setText($text) {
+        $this->text = $text;
+        return $this;
+    }
+
+    /**
+     * @param FrontendDefinitionTrait $a
+     * @param FrontendDefinitionTrait $b
+     * @return int
+     */
+    public static function lexicalCompare(FrontendDefinitionTrait $a, FrontendDefinitionTrait $b) {
+        return strcmp($a->getText(), $b->getText());
+    }
+
+    /**
+     * @return DefinitionParameter[]
+     */
+    public function getParameters() {
+        return $this->parameters;
+    }
+
+    /**
+     * @param DefinitionParameter[] $parameters
+     * @return self
+     */
+    public function addParameters(array $parameters) {
+        foreach ($parameters as $parameter) {
+            $this->addParameter($parameter);
+        }
+        return $this;
+    }
+
+    /**
+     * @param DefinitionParameter $parameter
+     * @return self
+     */
+    public function addParameter(DefinitionParameter $parameter) {
+        $this->parameters[$parameter->getName()] = $parameter;
+        return $this;
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getCustomJs() {
+        return $this->customJs;
+    }
+
+    /**
+     * @param string $custom
+     * @return self
+     */
+    public function addCustomJs($custom) {
+        $this->customJs[] = $custom;
+        return $this;
+    }
+
+    /**
+     * @param string $custom
+     * @return self
+     * @deprecated 9.1.0, use addCustomJs() instead
+     */
+    public function setCustomJs($custom) {
+        $this->customJs = [$custom];
+        return $this;
+    }
+
+    /**
+     * Serialize into JSON for client-side JS
+     *
+     * @return array
+     */
+    public function jsonSerializeDefinition() {
+        $configuration = [];
+        foreach ($this->getParameters() as $parameter) {
+            $configuration[$parameter->getName()] = $parameter;
+        }
+
+        $data = [
+            'name' => $this->getText(),
+            'configuration' => $configuration,
+            'custom' => $this->getCustomJs(),
+        ];
+        return $data;
+    }
+
+    /**
+     * Check if parameters are satisfied in a StorageConfig
+     *
+     * @param StorageConfig $storage
+     * @return bool
+     */
+    public function validateStorageDefinition(StorageConfig $storage) {
+        foreach ($this->getParameters() as $name => $parameter) {
+            $value = $storage->getBackendOption($name);
+            if (!is_null($value) || !$parameter->isOptional()) {
+                if (!$parameter->validateValue($value)) {
+                    return false;
+                }
+                $storage->setBackendOption($name, $value);
+            }
+        }
+        return true;
+    }
 
 }

apps/files_external/lib/Lib/InsufficientDataForMeaningfulAnswerException.php

Indentation +11 added lines, -11 removed lines

@@ -29,15 +29,15 @@
  * Authentication mechanism or backend has insufficient data
  */
 class InsufficientDataForMeaningfulAnswerException extends StorageNotAvailableException {
-	/**
-	 * StorageNotAvailableException constructor.
-	 *
-	 * @param string $message
-	 * @param int $code
-	 * @param \Exception|null $previous
-	 * @since 6.0.0
-	 */
-	public function __construct($message = '', $code = self::STATUS_INDETERMINATE, \Exception $previous = null) {
-		parent::__construct($message, $code, $previous);
-	}
+    /**
+     * StorageNotAvailableException constructor.
+     *
+     * @param string $message
+     * @param int $code
+     * @param \Exception|null $previous
+     * @since 6.0.0
+     */
+    public function __construct($message = '', $code = self::STATUS_INDETERMINATE, \Exception $previous = null) {
+        parent::__construct($message, $code, $previous);
+    }
 }

apps/files_external/lib/Lib/IdentifierTrait.php

Indentation +62 added lines, -62 removed lines

@@ -28,76 +28,76 @@
  */
 trait IdentifierTrait {
 
-	/** @var string */
-	protected $identifier;
+    /** @var string */
+    protected $identifier;
 
-	/** @var string[] */
-	protected $identifierAliases = [];
+    /** @var string[] */
+    protected $identifierAliases = [];
 
-	/** @var IdentifierTrait */
-	protected $deprecateTo = null;
+    /** @var IdentifierTrait */
+    protected $deprecateTo = null;
 
-	/**
-	 * @return string
-	 */
-	public function getIdentifier() {
-		return $this->identifier;
-	}
+    /**
+     * @return string
+     */
+    public function getIdentifier() {
+        return $this->identifier;
+    }
 
-	/**
-	 * @param string $identifier
-	 * @return $this
-	 */
-	public function setIdentifier($identifier) {
-		$this->identifier = $identifier;
-		$this->identifierAliases[] = $identifier;
-		return $this;
-	}
+    /**
+     * @param string $identifier
+     * @return $this
+     */
+    public function setIdentifier($identifier) {
+        $this->identifier = $identifier;
+        $this->identifierAliases[] = $identifier;
+        return $this;
+    }
 
-	/**
-	 * @return string[]
-	 */
-	public function getIdentifierAliases() {
-		return $this->identifierAliases;
-	}
+    /**
+     * @return string[]
+     */
+    public function getIdentifierAliases() {
+        return $this->identifierAliases;
+    }
 
-	/**
-	 * @param string $alias
-	 * @return $this
-	 */
-	public function addIdentifierAlias($alias) {
-		$this->identifierAliases[] = $alias;
-		return $this;
-	}
+    /**
+     * @param string $alias
+     * @return $this
+     */
+    public function addIdentifierAlias($alias) {
+        $this->identifierAliases[] = $alias;
+        return $this;
+    }
 
-	/**
-	 * @return object|null
-	 */
-	public function getDeprecateTo() {
-		return $this->deprecateTo;
-	}
+    /**
+     * @return object|null
+     */
+    public function getDeprecateTo() {
+        return $this->deprecateTo;
+    }
 
-	/**
-	 * @param object $destinationObject
-	 * @return self
-	 */
-	public function deprecateTo($destinationObject) {
-		$this->deprecateTo = $destinationObject;
-		return $this;
-	}
+    /**
+     * @param object $destinationObject
+     * @return self
+     */
+    public function deprecateTo($destinationObject) {
+        $this->deprecateTo = $destinationObject;
+        return $this;
+    }
 
-	/**
-	 * @return array
-	 */
-	public function jsonSerializeIdentifier() {
-		$data = [
-			'identifier' => $this->identifier,
-			'identifierAliases' => $this->identifierAliases,
-		];
-		if ($this->deprecateTo) {
-			$data['deprecateTo'] = $this->deprecateTo->getIdentifier();
-		}
-		return $data;
-	}
+    /**
+     * @return array
+     */
+    public function jsonSerializeIdentifier() {
+        $data = [
+            'identifier' => $this->identifier,
+            'identifierAliases' => $this->identifierAliases,
+        ];
+        if ($this->deprecateTo) {
+            $data['deprecateTo'] = $this->deprecateTo->getIdentifier();
+        }
+        return $data;
+    }
 
 }

apps/files_external/lib/Command/Create.php

Indentation +178 added lines, -178 removed lines

@@ -42,182 +42,182 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Create extends Base {
-	/**
-	 * @var GlobalStoragesService
-	 */
-	private $globalService;
-
-	/**
-	 * @var UserStoragesService
-	 */
-	private $userService;
-
-	/**
-	 * @var IUserManager
-	 */
-	private $userManager;
-
-	/** @var BackendService */
-	private $backendService;
-
-	/** @var IUserSession */
-	private $userSession;
-
-	function __construct(GlobalStoragesService $globalService,
-						 UserStoragesService $userService,
-						 IUserManager $userManager,
-						 IUserSession $userSession,
-						 BackendService $backendService
-	) {
-		parent::__construct();
-		$this->globalService = $globalService;
-		$this->userService = $userService;
-		$this->userManager = $userManager;
-		$this->userSession = $userSession;
-		$this->backendService = $backendService;
-	}
-
-	protected function configure() {
-		$this
-			->setName('files_external:create')
-			->setDescription('Create a new mount configuration')
-			->addOption(
-				'user',
-				'',
-				InputOption::VALUE_OPTIONAL,
-				'user to add the mount configuration for, if not set the mount will be added as system mount'
-			)
-			->addArgument(
-				'mount_point',
-				InputArgument::REQUIRED,
-				'mount point for the new mount'
-			)
-			->addArgument(
-				'storage_backend',
-				InputArgument::REQUIRED,
-				'storage backend identifier for the new mount, see `occ files_external:backends` for possible values'
-			)
-			->addArgument(
-				'authentication_backend',
-				InputArgument::REQUIRED,
-				'authentication backend identifier for the new mount, see `occ files_external:backends` for possible values'
-			)
-			->addOption(
-				'config',
-				'c',
-				InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
-				'Mount configuration option in key=value format'
-			)
-			->addOption(
-				'dry',
-				'',
-				InputOption::VALUE_NONE,
-				'Don\'t save the created mount, only list the new mount'
-			);
-		parent::configure();
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$user = $input->getOption('user');
-		$mountPoint = $input->getArgument('mount_point');
-		$storageIdentifier = $input->getArgument('storage_backend');
-		$authIdentifier = $input->getArgument('authentication_backend');
-		$configInput = $input->getOption('config');
-
-		$storageBackend = $this->backendService->getBackend($storageIdentifier);
-		$authBackend = $this->backendService->getAuthMechanism($authIdentifier);
-
-		if (!Filesystem::isValidPath($mountPoint)) {
-			$output->writeln('<error>Invalid mountpoint "' . $mountPoint . '"</error>');
-			return 1;
-		}
-		if (is_null($storageBackend)) {
-			$output->writeln('<error>Storage backend with identifier "' . $storageIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
-			return 404;
-		}
-		if (is_null($authBackend)) {
-			$output->writeln('<error>Authentication backend with identifier "' . $authIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
-			return 404;
-		}
-		$supportedSchemes = array_keys($storageBackend->getAuthSchemes());
-		if (!in_array($authBackend->getScheme(), $supportedSchemes)) {
-			$output->writeln('<error>Authentication backend "' . $authIdentifier . '" not valid for storage backend "' . $storageIdentifier . '" (see `occ files_external:backends storage ' . $storageIdentifier . '` for possible values)</error>');
-			return 1;
-		}
-
-		$config = [];
-		foreach ($configInput as $configOption) {
-			if (!strpos($configOption, '=')) {
-				$output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
-				return 1;
-			}
-			list($key, $value) = explode('=', $configOption, 2);
-			if (!$this->validateParam($key, $value, $storageBackend, $authBackend)) {
-				$output->writeln('<error>Unknown configuration for backends "' . $key . '"</error>');
-				return 1;
-			}
-			$config[$key] = $value;
-		}
-
-		$mount = new StorageConfig();
-		$mount->setMountPoint($mountPoint);
-		$mount->setBackend($storageBackend);
-		$mount->setAuthMechanism($authBackend);
-		$mount->setBackendOptions($config);
-
-		if ($user) {
-			if (!$this->userManager->userExists($user)) {
-				$output->writeln('<error>User "' . $user . '" not found</error>');
-				return 1;
-			}
-			$mount->setApplicableUsers([$user]);
-		}
-
-		if ($input->getOption('dry')) {
-			$this->showMount($user, $mount, $input, $output);
-		} else {
-			$this->getStorageService($user)->addStorage($mount);
-			if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
-				$output->writeln('<info>Storage created with id ' . $mount->getId() . '</info>');
-			} else {
-				$output->writeln((string)$mount->getId());
-			}
-		}
-		return 0;
-	}
-
-	private function validateParam($key, &$value, Backend $storageBackend, AuthMechanism $authBackend) {
-		$params = array_merge($storageBackend->getParameters(), $authBackend->getParameters());
-		foreach ($params as $param) {
-			/** @var DefinitionParameter $param */
-			if ($param->getName() === $key) {
-				if ($param->getType() === DefinitionParameter::VALUE_BOOLEAN) {
-					$value = ($value === 'true');
-				}
-				return true;
-			}
-		}
-		return false;
-	}
-
-	private function showMount($user, StorageConfig $mount, InputInterface $input, OutputInterface $output) {
-		$listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
-		$listInput = new ArrayInput([], $listCommand->getDefinition());
-		$listInput->setOption('output', $input->getOption('output'));
-		$listInput->setOption('show-password', true);
-		$listCommand->listMounts($user, [$mount], $listInput, $output);
-	}
-
-	protected function getStorageService($userId) {
-		if (!empty($userId)) {
-			$user = $this->userManager->get($userId);
-			if (is_null($user)) {
-				throw new NoUserException("user $userId not found");
-			}
-			$this->userSession->setUser($user);
-			return $this->userService;
-		} else {
-			return $this->globalService;
-		}
-	}
+    /**
+     * @var GlobalStoragesService
+     */
+    private $globalService;
+
+    /**
+     * @var UserStoragesService
+     */
+    private $userService;
+
+    /**
+     * @var IUserManager
+     */
+    private $userManager;
+
+    /** @var BackendService */
+    private $backendService;
+
+    /** @var IUserSession */
+    private $userSession;
+
+    function __construct(GlobalStoragesService $globalService,
+                            UserStoragesService $userService,
+                            IUserManager $userManager,
+                            IUserSession $userSession,
+                            BackendService $backendService
+    ) {
+        parent::__construct();
+        $this->globalService = $globalService;
+        $this->userService = $userService;
+        $this->userManager = $userManager;
+        $this->userSession = $userSession;
+        $this->backendService = $backendService;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('files_external:create')
+            ->setDescription('Create a new mount configuration')
+            ->addOption(
+                'user',
+                '',
+                InputOption::VALUE_OPTIONAL,
+                'user to add the mount configuration for, if not set the mount will be added as system mount'
+            )
+            ->addArgument(
+                'mount_point',
+                InputArgument::REQUIRED,
+                'mount point for the new mount'
+            )
+            ->addArgument(
+                'storage_backend',
+                InputArgument::REQUIRED,
+                'storage backend identifier for the new mount, see `occ files_external:backends` for possible values'
+            )
+            ->addArgument(
+                'authentication_backend',
+                InputArgument::REQUIRED,
+                'authentication backend identifier for the new mount, see `occ files_external:backends` for possible values'
+            )
+            ->addOption(
+                'config',
+                'c',
+                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
+                'Mount configuration option in key=value format'
+            )
+            ->addOption(
+                'dry',
+                '',
+                InputOption::VALUE_NONE,
+                'Don\'t save the created mount, only list the new mount'
+            );
+        parent::configure();
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $user = $input->getOption('user');
+        $mountPoint = $input->getArgument('mount_point');
+        $storageIdentifier = $input->getArgument('storage_backend');
+        $authIdentifier = $input->getArgument('authentication_backend');
+        $configInput = $input->getOption('config');
+
+        $storageBackend = $this->backendService->getBackend($storageIdentifier);
+        $authBackend = $this->backendService->getAuthMechanism($authIdentifier);
+
+        if (!Filesystem::isValidPath($mountPoint)) {
+            $output->writeln('<error>Invalid mountpoint "' . $mountPoint . '"</error>');
+            return 1;
+        }
+        if (is_null($storageBackend)) {
+            $output->writeln('<error>Storage backend with identifier "' . $storageIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
+            return 404;
+        }
+        if (is_null($authBackend)) {
+            $output->writeln('<error>Authentication backend with identifier "' . $authIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
+            return 404;
+        }
+        $supportedSchemes = array_keys($storageBackend->getAuthSchemes());
+        if (!in_array($authBackend->getScheme(), $supportedSchemes)) {
+            $output->writeln('<error>Authentication backend "' . $authIdentifier . '" not valid for storage backend "' . $storageIdentifier . '" (see `occ files_external:backends storage ' . $storageIdentifier . '` for possible values)</error>');
+            return 1;
+        }
+
+        $config = [];
+        foreach ($configInput as $configOption) {
+            if (!strpos($configOption, '=')) {
+                $output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
+                return 1;
+            }
+            list($key, $value) = explode('=', $configOption, 2);
+            if (!$this->validateParam($key, $value, $storageBackend, $authBackend)) {
+                $output->writeln('<error>Unknown configuration for backends "' . $key . '"</error>');
+                return 1;
+            }
+            $config[$key] = $value;
+        }
+
+        $mount = new StorageConfig();
+        $mount->setMountPoint($mountPoint);
+        $mount->setBackend($storageBackend);
+        $mount->setAuthMechanism($authBackend);
+        $mount->setBackendOptions($config);
+
+        if ($user) {
+            if (!$this->userManager->userExists($user)) {
+                $output->writeln('<error>User "' . $user . '" not found</error>');
+                return 1;
+            }
+            $mount->setApplicableUsers([$user]);
+        }
+
+        if ($input->getOption('dry')) {
+            $this->showMount($user, $mount, $input, $output);
+        } else {
+            $this->getStorageService($user)->addStorage($mount);
+            if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
+                $output->writeln('<info>Storage created with id ' . $mount->getId() . '</info>');
+            } else {
+                $output->writeln((string)$mount->getId());
+            }
+        }
+        return 0;
+    }
+
+    private function validateParam($key, &$value, Backend $storageBackend, AuthMechanism $authBackend) {
+        $params = array_merge($storageBackend->getParameters(), $authBackend->getParameters());
+        foreach ($params as $param) {
+            /** @var DefinitionParameter $param */
+            if ($param->getName() === $key) {
+                if ($param->getType() === DefinitionParameter::VALUE_BOOLEAN) {
+                    $value = ($value === 'true');
+                }
+                return true;
+            }
+        }
+        return false;
+    }
+
+    private function showMount($user, StorageConfig $mount, InputInterface $input, OutputInterface $output) {
+        $listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
+        $listInput = new ArrayInput([], $listCommand->getDefinition());
+        $listInput->setOption('output', $input->getOption('output'));
+        $listInput->setOption('show-password', true);
+        $listCommand->listMounts($user, [$mount], $listInput, $output);
+    }
+
+    protected function getStorageService($userId) {
+        if (!empty($userId)) {
+            $user = $this->userManager->get($userId);
+            if (is_null($user)) {
+                throw new NoUserException("user $userId not found");
+            }
+            $this->userSession->setUser($user);
+            return $this->userService;
+        } else {
+            return $this->globalService;
+        }
+    }
 }

Spacing +9 added lines, -9 removed lines

@@ -128,32 +128,32 @@ 
 		$authBackend = $this->backendService->getAuthMechanism($authIdentifier);
 
 		if (!Filesystem::isValidPath($mountPoint)) {
-			$output->writeln('<error>Invalid mountpoint "' . $mountPoint . '"</error>');
+			$output->writeln('<error>Invalid mountpoint "'.$mountPoint.'"</error>');
 			return 1;
 		}
 		if (is_null($storageBackend)) {
-			$output->writeln('<error>Storage backend with identifier "' . $storageIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
+			$output->writeln('<error>Storage backend with identifier "'.$storageIdentifier.'" not found (see `occ files_external:backends` for possible values)</error>');
 			return 404;
 		}
 		if (is_null($authBackend)) {
-			$output->writeln('<error>Authentication backend with identifier "' . $authIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
+			$output->writeln('<error>Authentication backend with identifier "'.$authIdentifier.'" not found (see `occ files_external:backends` for possible values)</error>');
 			return 404;
 		}
 		$supportedSchemes = array_keys($storageBackend->getAuthSchemes());
 		if (!in_array($authBackend->getScheme(), $supportedSchemes)) {
-			$output->writeln('<error>Authentication backend "' . $authIdentifier . '" not valid for storage backend "' . $storageIdentifier . '" (see `occ files_external:backends storage ' . $storageIdentifier . '` for possible values)</error>');
+			$output->writeln('<error>Authentication backend "'.$authIdentifier.'" not valid for storage backend "'.$storageIdentifier.'" (see `occ files_external:backends storage '.$storageIdentifier.'` for possible values)</error>');
 			return 1;
 		}
 
 		$config = [];
 		foreach ($configInput as $configOption) {
 			if (!strpos($configOption, '=')) {
-				$output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
+				$output->writeln('<error>Invalid mount configuration option "'.$configOption.'"</error>');
 				return 1;
 			}
 			list($key, $value) = explode('=', $configOption, 2);
 			if (!$this->validateParam($key, $value, $storageBackend, $authBackend)) {
-				$output->writeln('<error>Unknown configuration for backends "' . $key . '"</error>');
+				$output->writeln('<error>Unknown configuration for backends "'.$key.'"</error>');
 				return 1;
 			}
 			$config[$key] = $value;
@@ -167,7 +167,7 @@ 
 
 		if ($user) {
 			if (!$this->userManager->userExists($user)) {
-				$output->writeln('<error>User "' . $user . '" not found</error>');
+				$output->writeln('<error>User "'.$user.'" not found</error>');
 				return 1;
 			}
 			$mount->setApplicableUsers([$user]);
@@ -178,9 +178,9 @@ 
 		} else {
 			$this->getStorageService($user)->addStorage($mount);
 			if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
-				$output->writeln('<info>Storage created with id ' . $mount->getId() . '</info>');
+				$output->writeln('<info>Storage created with id '.$mount->getId().'</info>');
 			} else {
-				$output->writeln((string)$mount->getId());
+				$output->writeln((string) $mount->getId());
 			}
 		}
 		return 0;

apps/testing/appinfo/routes.php

Indentation +57 added lines, -57 removed lines

@@ -21,62 +21,62 @@
  */
 
 return [
-	'routes' => [
-		[
-			'name' => 'RateLimitTest#userAndAnonProtected',
-			'url' => '/userAndAnonProtected',
-			'verb' => 'GET',
-		],
-		[
-			'name' => 'RateLimitTest#onlyAnonProtected',
-			'url' => '/anonProtected',
-			'verb' => 'GET',
-		],
-	],
+    'routes' => [
+        [
+            'name' => 'RateLimitTest#userAndAnonProtected',
+            'url' => '/userAndAnonProtected',
+            'verb' => 'GET',
+        ],
+        [
+            'name' => 'RateLimitTest#onlyAnonProtected',
+            'url' => '/anonProtected',
+            'verb' => 'GET',
+        ],
+    ],
 
-	'ocs' => [
-		[
-			'name' => 'Config#setAppValue',
-			'url'  => '/api/v1/app/{appid}/{configkey}',
-			'verb' => 'POST',
-		],
-		[
-			'name' => 'Config#deleteAppValue',
-			'url'  => '/api/v1/app/{appid}/{configkey}',
-			'verb' => 'DELETE',
-		],
-		[
-			'name' => 'Locking#isLockingEnabled',
-			'url'  => '/api/v1/lockprovisioning',
-			'verb' => 'GET',
-		],
-		[
-			'name' => 'Locking#isLocked',
-			'url'  => '/api/v1/lockprovisioning/{type}/{user}',
-			'verb' => 'GET',
-		],
-		[
-			'name' => 'Locking#acquireLock',
-			'url'  => '/api/v1/lockprovisioning/{type}/{user}',
-			'verb' => 'POST',
-		],
-		[
-			'name' => 'Locking#changeLock',
-			'url'  => '/api/v1/lockprovisioning/{type}/{user}',
-			'verb' => 'PUT',
-		],
-		[
-			'name' => 'Locking#releaseLock',
-			'url'  => '/api/v1/lockprovisioning/{type}/{user}',
-			'verb' => 'DELETE',
-		],
-		[
-			'name' => 'Locking#releaseAll',
-			'url'  => '/api/v1/lockprovisioning/{type}',
-			'verb' => 'DELETE',
-			'defaults' => [
-				'type' => null
-			]
-		],
-	],
+    'ocs' => [
+        [
+            'name' => 'Config#setAppValue',
+            'url'  => '/api/v1/app/{appid}/{configkey}',
+            'verb' => 'POST',
+        ],
+        [
+            'name' => 'Config#deleteAppValue',
+            'url'  => '/api/v1/app/{appid}/{configkey}',
+            'verb' => 'DELETE',
+        ],
+        [
+            'name' => 'Locking#isLockingEnabled',
+            'url'  => '/api/v1/lockprovisioning',
+            'verb' => 'GET',
+        ],
+        [
+            'name' => 'Locking#isLocked',
+            'url'  => '/api/v1/lockprovisioning/{type}/{user}',
+            'verb' => 'GET',
+        ],
+        [
+            'name' => 'Locking#acquireLock',
+            'url'  => '/api/v1/lockprovisioning/{type}/{user}',
+            'verb' => 'POST',
+        ],
+        [
+            'name' => 'Locking#changeLock',
+            'url'  => '/api/v1/lockprovisioning/{type}/{user}',
+            'verb' => 'PUT',
+        ],
+        [
+            'name' => 'Locking#releaseLock',
+            'url'  => '/api/v1/lockprovisioning/{type}/{user}',
+            'verb' => 'DELETE',
+        ],
+        [
+            'name' => 'Locking#releaseAll',
+            'url'  => '/api/v1/lockprovisioning/{type}',
+            'verb' => 'DELETE',
+            'defaults' => [
+                'type' => null
+            ]
+        ],
+    ],
 ];

lib/public/AppFramework/OCS/OCSNotFoundException.php

Indentation +10 added lines, -10 removed lines

@@ -32,14 +32,14 @@
  * @since 9.1.0
  */
 class OCSNotFoundException extends OCSException {
-	/**
-	 * OCSNotFoundException constructor.
-	 *
-	 * @param string $message
-	 * @param Exception|null $previous
-	 * @since 9.1.0
-	 */
-	public function __construct($message = '', Exception $previous = null) {
-		parent::__construct($message, Http::STATUS_NOT_FOUND, $previous);
-	}
+    /**
+     * OCSNotFoundException constructor.
+     *
+     * @param string $message
+     * @param Exception|null $previous
+     * @since 9.1.0
+     */
+    public function __construct($message = '', Exception $previous = null) {
+        parent::__construct($message, Http::STATUS_NOT_FOUND, $previous);
+    }
 }

lib/public/AppFramework/OCS/OCSForbiddenException.php

Indentation +10 added lines, -10 removed lines

@@ -32,14 +32,14 @@
  * @since 9.1.0
  */
 class OCSForbiddenException extends OCSException {
-	/**
-	 * OCSForbiddenException constructor.
-	 *
-	 * @param string $message
-	 * @param Exception|null $previous
-	 * @since 9.1.0
-	 */
-	public function __construct($message = '', Exception $previous = null) {
-		parent::__construct($message, Http::STATUS_FORBIDDEN, $previous);
-	}
+    /**
+     * OCSForbiddenException constructor.
+     *
+     * @param string $message
+     * @param Exception|null $previous
+     * @since 9.1.0
+     */
+    public function __construct($message = '', Exception $previous = null) {
+        parent::__construct($message, Http::STATUS_FORBIDDEN, $previous);
+    }
 }

lib/public/AppFramework/OCS/OCSBadRequestException.php

Indentation +10 added lines, -10 removed lines

@@ -32,14 +32,14 @@
  * @since 9.1.0
  */
 class OCSBadRequestException extends OCSException {
-	/**
-	 * OCSBadRequestException constructor.
-	 *
-	 * @param string $message
-	 * @param Exception|null $previous
-	 * @since 9.1.0
-	 */
-	public function __construct($message = '', Exception $previous = null) {
-		parent::__construct($message, Http::STATUS_BAD_REQUEST, $previous);
-	}
+    /**
+     * OCSBadRequestException constructor.
+     *
+     * @param string $message
+     * @param Exception|null $previous
+     * @since 9.1.0
+     */
+    public function __construct($message = '', Exception $previous = null) {
+        parent::__construct($message, Http::STATUS_BAD_REQUEST, $previous);
+    }
 }