nextcloud / server

lib/private/AppFramework/Routing/RouteActionHandler.php

Indentation +15 added lines, -15 removed lines

@@ -29,21 +29,21 @@
 use \OC\AppFramework\DependencyInjection\DIContainer;
 
 class RouteActionHandler {
-	private $controllerName;
-	private $actionName;
-	private $container;
+    private $controllerName;
+    private $actionName;
+    private $container;
 
-	/**
-	 * @param string $controllerName
-	 * @param string $actionName
-	 */
-	public function __construct(DIContainer $container, $controllerName, $actionName) {
-		$this->controllerName = $controllerName;
-		$this->actionName = $actionName;
-		$this->container = $container;
-	}
+    /**
+     * @param string $controllerName
+     * @param string $actionName
+     */
+    public function __construct(DIContainer $container, $controllerName, $actionName) {
+        $this->controllerName = $controllerName;
+        $this->actionName = $actionName;
+        $this->container = $container;
+    }
 
-	public function __invoke($params) {
-		App::main($this->controllerName, $this->actionName, $this->container, $params);
-	}
+    public function __invoke($params) {
+        App::main($this->controllerName, $this->actionName, $this->container, $params);
+    }
 }

lib/private/Share/SearchResultSorter.php

Indentation +43 added lines, -43 removed lines

@@ -26,51 +26,51 @@
 use OCP\ILogger;
 
 class SearchResultSorter {
-	private $search;
-	private $encoding;
-	private $key;
-	private $log;
+    private $search;
+    private $encoding;
+    private $key;
+    private $log;
 
-	/**
-	 * @param string $search the search term as was given by the user
-	 * @param string $key the array key containing the value that should be compared
-	 * against
-	 * @param string $encoding optional, encoding to use, defaults to UTF-8
-	 * @param ILogger $log optional
-	 */
-	public function __construct($search, $key, ILogger $log = null, $encoding = 'UTF-8') {
-		$this->encoding = $encoding;
-		$this->key = $key;
-		$this->log = $log;
-		$this->search = mb_strtolower($search, $this->encoding);
-	}
+    /**
+     * @param string $search the search term as was given by the user
+     * @param string $key the array key containing the value that should be compared
+     * against
+     * @param string $encoding optional, encoding to use, defaults to UTF-8
+     * @param ILogger $log optional
+     */
+    public function __construct($search, $key, ILogger $log = null, $encoding = 'UTF-8') {
+        $this->encoding = $encoding;
+        $this->key = $key;
+        $this->log = $log;
+        $this->search = mb_strtolower($search, $this->encoding);
+    }
 
-	/**
-	 * User and Group names matching the search term at the beginning shall appear
-	 * on top of the share dialog. Following entries in alphabetical order.
-	 * Callback function for usort. http://php.net/usort
-	 */
-	public function sort($a, $b) {
-		if(!isset($a[$this->key]) || !isset($b[$this->key])) {
-			if(!is_null($this->log)) {
-				$this->log->error('Sharing dialogue: cannot sort due to ' .
-								  'missing array key', array('app' => 'core'));
-			}
-			return 0;
-		}
-		$nameA = mb_strtolower($a[$this->key], $this->encoding);
-		$nameB = mb_strtolower($b[$this->key], $this->encoding);
-		$i = mb_strpos($nameA, $this->search, 0, $this->encoding);
-		$j = mb_strpos($nameB, $this->search, 0, $this->encoding);
+    /**
+     * User and Group names matching the search term at the beginning shall appear
+     * on top of the share dialog. Following entries in alphabetical order.
+     * Callback function for usort. http://php.net/usort
+     */
+    public function sort($a, $b) {
+        if(!isset($a[$this->key]) || !isset($b[$this->key])) {
+            if(!is_null($this->log)) {
+                $this->log->error('Sharing dialogue: cannot sort due to ' .
+                                    'missing array key', array('app' => 'core'));
+            }
+            return 0;
+        }
+        $nameA = mb_strtolower($a[$this->key], $this->encoding);
+        $nameB = mb_strtolower($b[$this->key], $this->encoding);
+        $i = mb_strpos($nameA, $this->search, 0, $this->encoding);
+        $j = mb_strpos($nameB, $this->search, 0, $this->encoding);
 
-		if($i === $j || $i > 0 && $j > 0) {
-			return strcmp(mb_strtolower($nameA, $this->encoding),
-						  mb_strtolower($nameB, $this->encoding));
-		} elseif ($i === 0) {
-			return -1;
-		} else {
-			return 1;
-		}
-	}
+        if($i === $j || $i > 0 && $j > 0) {
+            return strcmp(mb_strtolower($nameA, $this->encoding),
+                            mb_strtolower($nameB, $this->encoding));
+        } elseif ($i === 0) {
+            return -1;
+        } else {
+            return 1;
+        }
+    }
 }
 

Spacing +4 added lines, -4 removed lines

@@ -51,9 +51,9 @@ 
 	 * Callback function for usort. http://php.net/usort
 	 */
 	public function sort($a, $b) {
-		if(!isset($a[$this->key]) || !isset($b[$this->key])) {
-			if(!is_null($this->log)) {
-				$this->log->error('Sharing dialogue: cannot sort due to ' .
+		if (!isset($a[$this->key]) || !isset($b[$this->key])) {
+			if (!is_null($this->log)) {
+				$this->log->error('Sharing dialogue: cannot sort due to '.
 								  'missing array key', array('app' => 'core'));
 			}
 			return 0;
@@ -63,7 +63,7 @@ 
 		$i = mb_strpos($nameA, $this->search, 0, $this->encoding);
 		$j = mb_strpos($nameB, $this->search, 0, $this->encoding);
 
-		if($i === $j || $i > 0 && $j > 0) {
+		if ($i === $j || $i > 0 && $j > 0) {
 			return strcmp(mb_strtolower($nameA, $this->encoding),
 						  mb_strtolower($nameB, $this->encoding));
 		} elseif ($i === 0) {

lib/private/Share/Constants.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 
 	const FORMAT_NONE = -1;
 	const FORMAT_STATUSES = -2;
-	const FORMAT_SOURCES = -3;  // ToDo Check if it is still in use otherwise remove it
+	const FORMAT_SOURCES = -3; // ToDo Check if it is still in use otherwise remove it
 
 	const RESPONSE_FORMAT = 'json'; // default resonse format for ocs calls
 

Indentation +49 added lines, -49 removed lines

@@ -31,57 +31,57 @@
 
 class Constants {
 
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_USER instead
-	 */
-	const SHARE_TYPE_USER = 0;
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_GROUP instead
-	 */
-	const SHARE_TYPE_GROUP = 1;
-	// const SHARE_TYPE_USERGROUP = 2; // Internal type used by DefaultShareProvider
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_LINK instead
-	 */
-	const SHARE_TYPE_LINK = 3;
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_EMAIL instead
-	 */
-	const SHARE_TYPE_EMAIL = 4;
-	const SHARE_TYPE_CONTACT = 5; // ToDo Check if it is still in use otherwise remove it
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_REMOTE instead
-	 */
-	const SHARE_TYPE_REMOTE = 6;
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_CIRCLE instead
-	 */
-	const SHARE_TYPE_CIRCLE = 7;
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_GUEST instead
-	 */
-	const SHARE_TYPE_GUEST = 8;
-	/**
-	 * @deprecated 17.0.0 - use IShare::REMOTE_GROUP instead
-	 */
-	const SHARE_TYPE_REMOTE_GROUP = 9;
-	/**
-	 * @deprecated 17.0.0 - use IShare::TYPE_ROOM instead
-	 */
-	const SHARE_TYPE_ROOM = 10;
-	// const SHARE_TYPE_USERROOM = 11; // Internal type used by RoomShareProvider
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_USER instead
+     */
+    const SHARE_TYPE_USER = 0;
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_GROUP instead
+     */
+    const SHARE_TYPE_GROUP = 1;
+    // const SHARE_TYPE_USERGROUP = 2; // Internal type used by DefaultShareProvider
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_LINK instead
+     */
+    const SHARE_TYPE_LINK = 3;
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_EMAIL instead
+     */
+    const SHARE_TYPE_EMAIL = 4;
+    const SHARE_TYPE_CONTACT = 5; // ToDo Check if it is still in use otherwise remove it
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_REMOTE instead
+     */
+    const SHARE_TYPE_REMOTE = 6;
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_CIRCLE instead
+     */
+    const SHARE_TYPE_CIRCLE = 7;
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_GUEST instead
+     */
+    const SHARE_TYPE_GUEST = 8;
+    /**
+     * @deprecated 17.0.0 - use IShare::REMOTE_GROUP instead
+     */
+    const SHARE_TYPE_REMOTE_GROUP = 9;
+    /**
+     * @deprecated 17.0.0 - use IShare::TYPE_ROOM instead
+     */
+    const SHARE_TYPE_ROOM = 10;
+    // const SHARE_TYPE_USERROOM = 11; // Internal type used by RoomShareProvider
 
-	const FORMAT_NONE = -1;
-	const FORMAT_STATUSES = -2;
-	const FORMAT_SOURCES = -3;  // ToDo Check if it is still in use otherwise remove it
+    const FORMAT_NONE = -1;
+    const FORMAT_STATUSES = -2;
+    const FORMAT_SOURCES = -3;  // ToDo Check if it is still in use otherwise remove it
 
-	const RESPONSE_FORMAT = 'json'; // default resonse format for ocs calls
+    const RESPONSE_FORMAT = 'json'; // default resonse format for ocs calls
 
-	const TOKEN_LENGTH = 15; // old (oc7) length is 32, keep token length in db at least that for compatibility
+    const TOKEN_LENGTH = 15; // old (oc7) length is 32, keep token length in db at least that for compatibility
 
-	protected static $shareTypeUserAndGroups = -1;
-	protected static $shareTypeGroupUserUnique = 2;
-	protected static $backends = array();
-	protected static $backendTypes = array();
-	protected static $isResharingAllowed;
+    protected static $shareTypeUserAndGroups = -1;
+    protected static $shareTypeGroupUserUnique = 2;
+    protected static $backends = array();
+    protected static $backendTypes = array();
+    protected static $isResharingAllowed;
 }

lib/private/Repair/MoveUpdaterStepFile.php

Indentation +39 added lines, -39 removed lines

@@ -28,53 +28,53 @@
 
 class MoveUpdaterStepFile implements IRepairStep {
 
-	/** @var \OCP\IConfig */
-	protected $config;
+    /** @var \OCP\IConfig */
+    protected $config;
 
-	/**
-	 * @param \OCP\IConfig $config
-	 */
-	public function __construct($config) {
-		$this->config = $config;
-	}
+    /**
+     * @param \OCP\IConfig $config
+     */
+    public function __construct($config) {
+        $this->config = $config;
+    }
 
-	public function getName() {
-		return 'Move .step file of updater to backup location';
-	}
+    public function getName() {
+        return 'Move .step file of updater to backup location';
+    }
 
-	public function run(IOutput $output) {
+    public function run(IOutput $output) {
 
-		$dataDir = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data');
-		$instanceId = $this->config->getSystemValue('instanceid', null);
+        $dataDir = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data');
+        $instanceId = $this->config->getSystemValue('instanceid', null);
 
-		if(!is_string($instanceId) || empty($instanceId)) {
-			return;
-		}
+        if(!is_string($instanceId) || empty($instanceId)) {
+            return;
+        }
 
-		$updaterFolderPath = $dataDir . '/updater-' . $instanceId;
-		$stepFile = $updaterFolderPath . '/.step';
-		if(file_exists($stepFile)) {
-			$output->info('.step file exists');
+        $updaterFolderPath = $dataDir . '/updater-' . $instanceId;
+        $stepFile = $updaterFolderPath . '/.step';
+        if(file_exists($stepFile)) {
+            $output->info('.step file exists');
 
-			$previousStepFile = $updaterFolderPath . '/.step-previous-update';
+            $previousStepFile = $updaterFolderPath . '/.step-previous-update';
 
-			// cleanup
-			if(file_exists($previousStepFile)) {
-				if(\OC_Helper::rmdirr($previousStepFile)) {
-					$output->info('.step-previous-update removed');
-				} else {
-					$output->info('.step-previous-update can\'t be removed - abort move of .step file');
-					return;
-				}
-			}
+            // cleanup
+            if(file_exists($previousStepFile)) {
+                if(\OC_Helper::rmdirr($previousStepFile)) {
+                    $output->info('.step-previous-update removed');
+                } else {
+                    $output->info('.step-previous-update can\'t be removed - abort move of .step file');
+                    return;
+                }
+            }
 
-			// move step file
-			if(rename($stepFile, $previousStepFile)) {
-				$output->info('.step file moved to .step-previous-update');
-			} else {
-				$output->warning('.step file can\'t be moved');
-			}
-		}
-	}
+            // move step file
+            if(rename($stepFile, $previousStepFile)) {
+                $output->info('.step file moved to .step-previous-update');
+            } else {
+                $output->warning('.step file can\'t be moved');
+            }
+        }
+    }
 }
 

Spacing +9 added lines, -9 removed lines

@@ -44,23 +44,23 @@ 
 
 	public function run(IOutput $output) {
 
-		$dataDir = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data');
+		$dataDir = $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT.'/data');
 		$instanceId = $this->config->getSystemValue('instanceid', null);
 
-		if(!is_string($instanceId) || empty($instanceId)) {
+		if (!is_string($instanceId) || empty($instanceId)) {
 			return;
 		}
 
-		$updaterFolderPath = $dataDir . '/updater-' . $instanceId;
-		$stepFile = $updaterFolderPath . '/.step';
-		if(file_exists($stepFile)) {
+		$updaterFolderPath = $dataDir.'/updater-'.$instanceId;
+		$stepFile = $updaterFolderPath.'/.step';
+		if (file_exists($stepFile)) {
 			$output->info('.step file exists');
 
-			$previousStepFile = $updaterFolderPath . '/.step-previous-update';
+			$previousStepFile = $updaterFolderPath.'/.step-previous-update';
 
 			// cleanup
-			if(file_exists($previousStepFile)) {
-				if(\OC_Helper::rmdirr($previousStepFile)) {
+			if (file_exists($previousStepFile)) {
+				if (\OC_Helper::rmdirr($previousStepFile)) {
 					$output->info('.step-previous-update removed');
 				} else {
 					$output->info('.step-previous-update can\'t be removed - abort move of .step file');
@@ -69,7 +69,7 @@ 
 			}
 
 			// move step file
-			if(rename($stepFile, $previousStepFile)) {
+			if (rename($stepFile, $previousStepFile)) {
 				$output->info('.step file moved to .step-previous-update');
 			} else {
 				$output->warning('.step file can\'t be moved');

lib/private/Repair/NC11/FixMountStorages.php

Indentation +39 added lines, -39 removed lines

@@ -29,50 +29,50 @@
 
 class FixMountStorages implements IRepairStep {
 
-	/** @var IDBConnection */
-	private $db;
+    /** @var IDBConnection */
+    private $db;
 
-	/**
-	 * @param IDBConnection $db
-	 */
-	public function __construct(IDBConnection $db) {
-		$this->db = $db;
-	}
+    /**
+     * @param IDBConnection $db
+     */
+    public function __construct(IDBConnection $db) {
+        $this->db = $db;
+    }
 
-	/**
-	 * @return string
-	 */
-	public function getName() {
-		return 'Fix potential broken mount points';
-	}
+    /**
+     * @return string
+     */
+    public function getName() {
+        return 'Fix potential broken mount points';
+    }
 
-	public function run(IOutput $output) {
-		$query = $this->db->getQueryBuilder();
-		$query->select('m.id', 'f.storage')
-			->from('mounts', 'm')
-			->leftJoin('m', 'filecache', 'f', $query->expr()->eq('m.root_id', 'f.fileid'))
-			->where($query->expr()->neq('m.storage_id', 'f.storage'));
+    public function run(IOutput $output) {
+        $query = $this->db->getQueryBuilder();
+        $query->select('m.id', 'f.storage')
+            ->from('mounts', 'm')
+            ->leftJoin('m', 'filecache', 'f', $query->expr()->eq('m.root_id', 'f.fileid'))
+            ->where($query->expr()->neq('m.storage_id', 'f.storage'));
 
-		$update = $this->db->getQueryBuilder();
-		$update->update('mounts')
-			->set('storage_id', $update->createParameter('storage'))
-			->where($query->expr()->eq('id', $update->createParameter('mount')));
+        $update = $this->db->getQueryBuilder();
+        $update->update('mounts')
+            ->set('storage_id', $update->createParameter('storage'))
+            ->where($query->expr()->eq('id', $update->createParameter('mount')));
 
-		$result = $query->execute();
-		$entriesUpdated = 0;
-		while ($row = $result->fetch()) {
-			$update->setParameter('storage', $row['storage'], IQueryBuilder::PARAM_INT)
-				->setParameter('mount', $row['id'], IQueryBuilder::PARAM_INT);
-			$update->execute();
-			$entriesUpdated++;
-		}
-		$result->closeCursor();
+        $result = $query->execute();
+        $entriesUpdated = 0;
+        while ($row = $result->fetch()) {
+            $update->setParameter('storage', $row['storage'], IQueryBuilder::PARAM_INT)
+                ->setParameter('mount', $row['id'], IQueryBuilder::PARAM_INT);
+            $update->execute();
+            $entriesUpdated++;
+        }
+        $result->closeCursor();
 
-		if ($entriesUpdated > 0) {
-			$output->info($entriesUpdated . ' mounts updated');
-			return;
-		}
+        if ($entriesUpdated > 0) {
+            $output->info($entriesUpdated . ' mounts updated');
+            return;
+        }
 
-		$output->info('No mounts updated');
-	}
+        $output->info('No mounts updated');
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 		$result->closeCursor();
 
 		if ($entriesUpdated > 0) {
-			$output->info($entriesUpdated . ' mounts updated');
+			$output->info($entriesUpdated.' mounts updated');
 			return;
 		}
 

lib/private/Repair/SqliteAutoincrement.php

Indentation +52 added lines, -52 removed lines

@@ -36,66 +36,66 @@
  * altered in order to retrigger SQL schema generation through OCSqlitePlatform.
  */
 class SqliteAutoincrement implements IRepairStep {
-	/**
-	 * @var \OC\DB\Connection
-	 */
-	protected $connection;
+    /**
+     * @var \OC\DB\Connection
+     */
+    protected $connection;
 
-	/**
-	 * @param \OC\DB\Connection $connection
-	 */
-	public function __construct($connection) {
-		$this->connection = $connection;
-	}
+    /**
+     * @param \OC\DB\Connection $connection
+     */
+    public function __construct($connection) {
+        $this->connection = $connection;
+    }
 
-	public function getName() {
-		return 'Repair SQLite autoincrement';
-	}
+    public function getName() {
+        return 'Repair SQLite autoincrement';
+    }
 
-	/**
-	 * Fix mime types
-	 */
-	public function run(IOutput $out) {
-		if (!$this->connection->getDatabasePlatform() instanceof SqlitePlatform) {
-			return;
-		}
+    /**
+     * Fix mime types
+     */
+    public function run(IOutput $out) {
+        if (!$this->connection->getDatabasePlatform() instanceof SqlitePlatform) {
+            return;
+        }
 
-		$sourceSchema = $this->connection->getSchemaManager()->createSchema();
+        $sourceSchema = $this->connection->getSchemaManager()->createSchema();
 
-		$schemaDiff = new SchemaDiff();
+        $schemaDiff = new SchemaDiff();
 
-		foreach ($sourceSchema->getTables() as $tableSchema) {
-			$primaryKey = $tableSchema->getPrimaryKey();
-			if (!$primaryKey) {
-				continue;
-			}
+        foreach ($sourceSchema->getTables() as $tableSchema) {
+            $primaryKey = $tableSchema->getPrimaryKey();
+            if (!$primaryKey) {
+                continue;
+            }
 
-			$columnNames = $primaryKey->getColumns();
+            $columnNames = $primaryKey->getColumns();
 
-			// add a column diff for every primary key column,
-			// but do not actually change anything, this will
-			// force the generation of SQL statements to alter
-			// those tables, which will then trigger the
-			// specific SQL code from OCSqlitePlatform
-			try {
-				$tableDiff = new TableDiff($tableSchema->getName());
-				$tableDiff->fromTable = $tableSchema;
-				foreach ($columnNames as $columnName) {
-					$columnSchema = $tableSchema->getColumn($columnName);
-					$columnDiff = new ColumnDiff($columnSchema->getName(), $columnSchema);
-					$tableDiff->changedColumns[] = $columnDiff;
-					$schemaDiff->changedTables[] = $tableDiff;
-				}
-			} catch (SchemaException $e) {
-				// ignore
-			}
-		}
+            // add a column diff for every primary key column,
+            // but do not actually change anything, this will
+            // force the generation of SQL statements to alter
+            // those tables, which will then trigger the
+            // specific SQL code from OCSqlitePlatform
+            try {
+                $tableDiff = new TableDiff($tableSchema->getName());
+                $tableDiff->fromTable = $tableSchema;
+                foreach ($columnNames as $columnName) {
+                    $columnSchema = $tableSchema->getColumn($columnName);
+                    $columnDiff = new ColumnDiff($columnSchema->getName(), $columnSchema);
+                    $tableDiff->changedColumns[] = $columnDiff;
+                    $schemaDiff->changedTables[] = $tableDiff;
+                }
+            } catch (SchemaException $e) {
+                // ignore
+            }
+        }
 
-		$this->connection->beginTransaction();
-		foreach ($schemaDiff->toSql($this->connection->getDatabasePlatform()) as $sql) {
-			$this->connection->query($sql);
-		}
-		$this->connection->commit();
-	}
+        $this->connection->beginTransaction();
+        foreach ($schemaDiff->toSql($this->connection->getDatabasePlatform()) as $sql) {
+            $this->connection->query($sql);
+        }
+        $this->connection->commit();
+    }
 }
 

lib/private/Repair/OldGroupMembershipShares.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
 		$result->closeCursor();
 
 		if ($deletedEntries) {
-			$output->info('Removed ' . $deletedEntries . ' shares where user is not a member of the group anymore');
+			$output->info('Removed '.$deletedEntries.' shares where user is not a member of the group anymore');
 		}
 	}
 

Indentation +85 added lines, -85 removed lines

@@ -31,89 +31,89 @@
 
 class OldGroupMembershipShares implements IRepairStep {
 
-	/** @var \OCP\IDBConnection */
-	protected $connection;
-
-	/** @var \OCP\IGroupManager */
-	protected $groupManager;
-
-	/**
-	 * @var array [gid => [uid => (bool)]]
-	 */
-	protected $memberships;
-
-	/**
-	 * @param IDBConnection $connection
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(IDBConnection $connection, IGroupManager $groupManager) {
-		$this->connection = $connection;
-		$this->groupManager = $groupManager;
-	}
-
-	/**
-	 * Returns the step's name
-	 *
-	 * @return string
-	 */
-	public function getName() {
-		return 'Remove shares of old group memberships';
-	}
-
-	/**
-	 * Run repair step.
-	 * Must throw exception on error.
-	 *
-	 * @throws \Exception in case of failure
-	 * @suppress SqlInjectionChecker
-	 */
-	public function run(IOutput $output) {
-		$deletedEntries = 0;
-
-		$query = $this->connection->getQueryBuilder();
-		$query->select('s1.id')->selectAlias('s1.share_with', 'user')->selectAlias('s2.share_with', 'group')
-			->from('share', 's1')
-			->where($query->expr()->isNotNull('s1.parent'))
-				// \OC\Share\Constant::$shareTypeGroupUserUnique === 2
-				->andWhere($query->expr()->eq('s1.share_type', $query->expr()->literal(2)))
-				->andWhere($query->expr()->isNotNull('s2.id'))
-				->andWhere($query->expr()->eq('s2.share_type', $query->expr()->literal(Share::SHARE_TYPE_GROUP)))
-			->leftJoin('s1', 'share', 's2', $query->expr()->eq('s1.parent', 's2.id'));
-
-		$deleteQuery = $this->connection->getQueryBuilder();
-		$deleteQuery->delete('share')
-			->where($query->expr()->eq('id', $deleteQuery->createParameter('share')));
-
-		$result = $query->execute();
-		while ($row = $result->fetch()) {
-			if (!$this->isMember($row['group'], $row['user'])) {
-				$deletedEntries += $deleteQuery->setParameter('share', (int) $row['id'])
-					->execute();
-			}
-		}
-		$result->closeCursor();
-
-		if ($deletedEntries) {
-			$output->info('Removed ' . $deletedEntries . ' shares where user is not a member of the group anymore');
-		}
-	}
-
-	/**
-	 * @param string $gid
-	 * @param string $uid
-	 * @return bool
-	 */
-	protected function isMember($gid, $uid) {
-		if (isset($this->memberships[$gid][$uid])) {
-			return $this->memberships[$gid][$uid];
-		}
-
-		$isMember = $this->groupManager->isInGroup($uid, $gid);
-		if (!isset($this->memberships[$gid])) {
-			$this->memberships[$gid] = [];
-		}
-		$this->memberships[$gid][$uid] = $isMember;
-
-		return $isMember;
-	}
+    /** @var \OCP\IDBConnection */
+    protected $connection;
+
+    /** @var \OCP\IGroupManager */
+    protected $groupManager;
+
+    /**
+     * @var array [gid => [uid => (bool)]]
+     */
+    protected $memberships;
+
+    /**
+     * @param IDBConnection $connection
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(IDBConnection $connection, IGroupManager $groupManager) {
+        $this->connection = $connection;
+        $this->groupManager = $groupManager;
+    }
+
+    /**
+     * Returns the step's name
+     *
+     * @return string
+     */
+    public function getName() {
+        return 'Remove shares of old group memberships';
+    }
+
+    /**
+     * Run repair step.
+     * Must throw exception on error.
+     *
+     * @throws \Exception in case of failure
+     * @suppress SqlInjectionChecker
+     */
+    public function run(IOutput $output) {
+        $deletedEntries = 0;
+
+        $query = $this->connection->getQueryBuilder();
+        $query->select('s1.id')->selectAlias('s1.share_with', 'user')->selectAlias('s2.share_with', 'group')
+            ->from('share', 's1')
+            ->where($query->expr()->isNotNull('s1.parent'))
+                // \OC\Share\Constant::$shareTypeGroupUserUnique === 2
+                ->andWhere($query->expr()->eq('s1.share_type', $query->expr()->literal(2)))
+                ->andWhere($query->expr()->isNotNull('s2.id'))
+                ->andWhere($query->expr()->eq('s2.share_type', $query->expr()->literal(Share::SHARE_TYPE_GROUP)))
+            ->leftJoin('s1', 'share', 's2', $query->expr()->eq('s1.parent', 's2.id'));
+
+        $deleteQuery = $this->connection->getQueryBuilder();
+        $deleteQuery->delete('share')
+            ->where($query->expr()->eq('id', $deleteQuery->createParameter('share')));
+
+        $result = $query->execute();
+        while ($row = $result->fetch()) {
+            if (!$this->isMember($row['group'], $row['user'])) {
+                $deletedEntries += $deleteQuery->setParameter('share', (int) $row['id'])
+                    ->execute();
+            }
+        }
+        $result->closeCursor();
+
+        if ($deletedEntries) {
+            $output->info('Removed ' . $deletedEntries . ' shares where user is not a member of the group anymore');
+        }
+    }
+
+    /**
+     * @param string $gid
+     * @param string $uid
+     * @return bool
+     */
+    protected function isMember($gid, $uid) {
+        if (isset($this->memberships[$gid][$uid])) {
+            return $this->memberships[$gid][$uid];
+        }
+
+        $isMember = $this->groupManager->isInGroup($uid, $gid);
+        if (!isset($this->memberships[$gid])) {
+            $this->memberships[$gid] = [];
+        }
+        $this->memberships[$gid][$uid] = $isMember;
+
+        return $isMember;
+    }
 }

lib/private/DB/AdapterOCI8.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 		}
 		if ($table !== null) {
 			$suffix = '_SEQ';
-			$table = '"' . $table . $suffix . '"';
+			$table = '"'.$table.$suffix.'"';
 		}
 		return $this->conn->realLastInsertId($table);
 	}

Indentation +18 added lines, -18 removed lines

@@ -27,24 +27,24 @@
 namespace OC\DB;
 
 class AdapterOCI8 extends Adapter {
-	public function lastInsertId($table) {
-		if (is_null($table)) {
-			throw new \InvalidArgumentException('Oracle requires a table name to be passed into lastInsertId()');
-		}
-		if ($table !== null) {
-			$suffix = '_SEQ';
-			$table = '"' . $table . $suffix . '"';
-		}
-		return $this->conn->realLastInsertId($table);
-	}
+    public function lastInsertId($table) {
+        if (is_null($table)) {
+            throw new \InvalidArgumentException('Oracle requires a table name to be passed into lastInsertId()');
+        }
+        if ($table !== null) {
+            $suffix = '_SEQ';
+            $table = '"' . $table . $suffix . '"';
+        }
+        return $this->conn->realLastInsertId($table);
+    }
 
-	const UNIX_TIMESTAMP_REPLACEMENT = "(cast(sys_extract_utc(systimestamp) as date) - date'1970-01-01') * 86400";
+    const UNIX_TIMESTAMP_REPLACEMENT = "(cast(sys_extract_utc(systimestamp) as date) - date'1970-01-01') * 86400";
 
-	public function fixupStatement($statement) {
-		$statement = preg_replace('/`(\w+)` ILIKE \?/', 'REGEXP_LIKE(`$1`, \'^\' || REPLACE(?, \'%\', \'.*\') || \'$\', \'i\')', $statement);
-		$statement = str_replace('`', '"', $statement);
-		$statement = str_ireplace('NOW()', 'CURRENT_TIMESTAMP', $statement);
-		$statement = str_ireplace('UNIX_TIMESTAMP()', self::UNIX_TIMESTAMP_REPLACEMENT, $statement);
-		return $statement;
-	}
+    public function fixupStatement($statement) {
+        $statement = preg_replace('/`(\w+)` ILIKE \?/', 'REGEXP_LIKE(`$1`, \'^\' || REPLACE(?, \'%\', \'.*\') || \'$\', \'i\')', $statement);
+        $statement = str_replace('`', '"', $statement);
+        $statement = str_ireplace('NOW()', 'CURRENT_TIMESTAMP', $statement);
+        $statement = str_ireplace('UNIX_TIMESTAMP()', self::UNIX_TIMESTAMP_REPLACEMENT, $statement);
+        return $statement;
+    }
 }

lib/private/DB/MySQLMigrator.php

Indentation +19 added lines, -19 removed lines

@@ -29,28 +29,28 @@
 use Doctrine\DBAL\Schema\Table;
 
 class MySQLMigrator extends Migrator {
-	/**
-	 * @param Schema $targetSchema
-	 * @param \Doctrine\DBAL\Connection $connection
-	 * @return \Doctrine\DBAL\Schema\SchemaDiff
-	 */
-	protected function getDiff(Schema $targetSchema, \Doctrine\DBAL\Connection $connection) {
-		$platform = $connection->getDatabasePlatform();
-		$platform->registerDoctrineTypeMapping('enum', 'string');
-		$platform->registerDoctrineTypeMapping('bit', 'string');
+    /**
+     * @param Schema $targetSchema
+     * @param \Doctrine\DBAL\Connection $connection
+     * @return \Doctrine\DBAL\Schema\SchemaDiff
+     */
+    protected function getDiff(Schema $targetSchema, \Doctrine\DBAL\Connection $connection) {
+        $platform = $connection->getDatabasePlatform();
+        $platform->registerDoctrineTypeMapping('enum', 'string');
+        $platform->registerDoctrineTypeMapping('bit', 'string');
 
-		$schemaDiff = parent::getDiff($targetSchema, $connection);
+        $schemaDiff = parent::getDiff($targetSchema, $connection);
 
-		// identifiers need to be quoted for mysql
-		foreach ($schemaDiff->changedTables as $tableDiff) {
-			$tableDiff->name = $this->connection->quoteIdentifier($tableDiff->name);
-			foreach ($tableDiff->changedColumns as $column) {
-				$column->oldColumnName = $this->connection->quoteIdentifier($column->oldColumnName);
-			}
-		}
+        // identifiers need to be quoted for mysql
+        foreach ($schemaDiff->changedTables as $tableDiff) {
+            $tableDiff->name = $this->connection->quoteIdentifier($tableDiff->name);
+            foreach ($tableDiff->changedColumns as $column) {
+                $column->oldColumnName = $this->connection->quoteIdentifier($column->oldColumnName);
+            }
+        }
 
-		return $schemaDiff;
-	}
+        return $schemaDiff;
+    }
 	
         /**
          * Speed up migration test by disabling autocommit and unique indexes check