Passed
Push — master ( 773e28...7e8ddc )
by Joas
13:16 queued 11s
created
apps/settings/lib/Controller/AdminSettingsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,9 +87,9 @@
 block discarded – undo
87 87
 	private function getLegacyForms() {
88 88
 		$forms = \OC_App::getForms('admin');
89 89
 
90
-		$forms = array_map(function ($form) {
90
+		$forms = array_map(function($form) {
91 91
 			if (preg_match('%(<h2(?P<class>[^>]*)>.*?</h2>)%i', $form, $regs)) {
92
-				$sectionName = str_replace('<h2' . $regs['class'] . '>', '', $regs[0]);
92
+				$sectionName = str_replace('<h2'.$regs['class'].'>', '', $regs[0]);
93 93
 				$sectionName = str_replace('</h2>', '', $sectionName);
94 94
 				$anchor = strtolower($sectionName);
95 95
 				$anchor = str_replace(' ', '-', $anchor);
Please login to merge, or discard this patch.
apps/settings/lib/Controller/PersonalSettingsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,9 +79,9 @@
 block discarded – undo
79 79
 	private function getLegacyForms() {
80 80
 		$forms = \OC_App::getForms('personal');
81 81
 
82
-		$forms = array_map(function ($form) {
82
+		$forms = array_map(function($form) {
83 83
 			if (preg_match('%(<h2(?P<class>[^>]*)>.*?</h2>)%i', $form, $regs)) {
84
-				$sectionName = str_replace('<h2' . $regs['class'] . '>', '', $regs[0]);
84
+				$sectionName = str_replace('<h2'.$regs['class'].'>', '', $regs[0]);
85 85
 				$sectionName = str_replace('</h2>', '', $sectionName);
86 86
 				$anchor = strtolower($sectionName);
87 87
 				$anchor = str_replace(' ', '-', $anchor);
Please login to merge, or discard this patch.
apps/settings/lib/Controller/ChangePasswordController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@
 block discarded – undo
229 229
 						'message' => $this->l->t('Please provide an admin recovery password; otherwise, all user data will be lost.'),
230 230
 					]
231 231
 				]);
232
-			} elseif ($recoveryEnabledForUser && ! $validRecoveryPassword) {
232
+			} elseif ($recoveryEnabledForUser && !$validRecoveryPassword) {
233 233
 				return new JSONResponse([
234 234
 					'status' => 'error',
235 235
 					'data' => [
Please login to merge, or discard this patch.
apps/settings/lib/Controller/HelpController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 		}
77 77
 
78 78
 		$documentationUrl = $this->urlGenerator->getAbsoluteURL(
79
-			$this->urlGenerator->linkTo('core', 'doc/' . $mode . '/index.html')
79
+			$this->urlGenerator->linkTo('core', 'doc/'.$mode.'/index.html')
80 80
 		);
81 81
 
82 82
 		$urlUserDocs = $this->urlGenerator->linkToRoute('settings.Help.help', ['mode' => 'user']);
Please login to merge, or discard this patch.
apps/settings/lib/Mailer/NewUserMailHelper.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,13 +102,13 @@
 block discarded – undo
102 102
 		if ($generatePasswordResetToken) {
103 103
 			$token = $this->secureRandom->generate(
104 104
 				21,
105
-				ISecureRandom::CHAR_DIGITS .
106
-				ISecureRandom::CHAR_LOWER .
105
+				ISecureRandom::CHAR_DIGITS.
106
+				ISecureRandom::CHAR_LOWER.
107 107
 				ISecureRandom::CHAR_UPPER
108 108
 			);
109
-			$tokenValue = $this->timeFactory->getTime() . ':' . $token;
109
+			$tokenValue = $this->timeFactory->getTime().':'.$token;
110 110
 			$mailAddress = (null !== $user->getEMailAddress()) ? $user->getEMailAddress() : '';
111
-			$encryptedValue = $this->crypto->encrypt($tokenValue, $mailAddress . $this->config->getSystemValue('secret'));
111
+			$encryptedValue = $this->crypto->encrypt($tokenValue, $mailAddress.$this->config->getSystemValue('secret'));
112 112
 			$this->config->setUserValue($user->getUID(), 'core', 'lostpassword', $encryptedValue);
113 113
 			$link = $this->urlGenerator->linkToRouteAbsolute('core.lost.resetform', ['userId' => $user->getUID(), 'token' => $token]);
114 114
 		} else {
Please login to merge, or discard this patch.
apps/settings/templates/settings/admin/overview.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -28,21 +28,21 @@  discard block
 block discarded – undo
28 28
 ?>
29 29
 
30 30
 <div id="security-warning" class="section">
31
-	<h2 class="inlineblock"><?php p($l->t('Security & setup warnings'));?></h2>
32
-	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
33
-	<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.'));?></p>
31
+	<h2 class="inlineblock"><?php p($l->t('Security & setup warnings')); ?></h2>
32
+	<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation')); ?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
33
+	<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.')); ?></p>
34 34
 
35 35
 	<div id="security-warning-state-ok" class="hidden">
36
-		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.'));?></span>
36
+		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.')); ?></span>
37 37
 	</div>
38 38
 	<div id="security-warning-state-failure" class="hidden">
39
-		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('There are some errors regarding your setup.'));?></span>
39
+		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('There are some errors regarding your setup.')); ?></span>
40 40
 	</div>
41 41
 	<div id="security-warning-state-warning" class="hidden">
42
-		<span class="icon icon-error-white"></span><span class="message"><?php p($l->t('There are some warnings regarding your setup.'));?></span>
42
+		<span class="icon icon-error-white"></span><span class="message"><?php p($l->t('There are some warnings regarding your setup.')); ?></span>
43 43
 	</div>
44 44
 	<div id="security-warning-state-loading">
45
-		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.'));?></span>
45
+		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.')); ?></span>
46 46
 	</div>
47 47
 
48 48
 	<div id="postsetupchecks" data-check-wellknown="<?php if ($_['checkForWorkingWellKnownSetup']) {
@@ -59,13 +59,13 @@  discard block
 block discarded – undo
59 59
 	</p>
60 60
 
61 61
 	<p class="extra-top-margin">
62
-		<?php print_unescaped($l->t('Check the security of your Nextcloud over <a target="_blank" rel="noreferrer noopener" href="%s">our security scan ↗</a>.', ['https://scan.nextcloud.com']));?>
62
+		<?php print_unescaped($l->t('Check the security of your Nextcloud over <a target="_blank" rel="noreferrer noopener" href="%s">our security scan ↗</a>.', ['https://scan.nextcloud.com'])); ?>
63 63
 	</p>
64 64
 
65 65
 </div>
66 66
 
67 67
 <div id="version" class="section">
68 68
 	<!-- should be the last part, so Updater can follow if enabled (it has no heading therefore). -->
69
-	<h2><?php p($l->t('Version'));?></h2>
69
+	<h2><?php p($l->t('Version')); ?></h2>
70 70
 	<p><strong><a href="<?php print_unescaped($theme->getBaseUrl()); ?>" rel="noreferrer noopener" target="_blank"><?php p($theme->getTitle()); ?></a> <?php p(OC_Util::getHumanVersion()) ?></strong></p>
71 71
 </div>
Please login to merge, or discard this patch.
apps/settings/templates/settings/additional.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,6 +28,6 @@
 block discarded – undo
28 28
 
29 29
 <?php foreach ($_['forms'] as $form) {
30 30
 	if (isset($form['form'])) {?>
31
-		<div id="<?php isset($form['anchor']) ? p($form['anchor']) : p('');?>"><?php print_unescaped($form['form']);?></div>
31
+		<div id="<?php isset($form['anchor']) ? p($form['anchor']) : p(''); ?>"><?php print_unescaped($form['form']); ?></div>
32 32
 	<?php }
33 33
 } ?>
Please login to merge, or discard this patch.
apps/files/templates/list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	<?php if (isset($_['dirToken'])):?>
16 16
 	<input type="hidden" id="publicUploadRequestToken" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
17 17
 	<input type="hidden" id="dirToken" name="dirToken" value="<?php p($_['dirToken']) ?>" />
18
-	<?php endif;?>
18
+	<?php endif; ?>
19 19
 	<input type="hidden" class="max_human_file_size"
20 20
 		   value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
21 21
 </div>
@@ -77,6 +77,6 @@  discard block
 block discarded – undo
77 77
 <div id="editor"></div><!-- FIXME Do not use this div in your app! It is deprecated and will be removed in the future! -->
78 78
 <div id="uploadsize-message" title="<?php p($l->t('Upload too large'))?>">
79 79
 	<p>
80
-	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.'));?>
80
+	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.')); ?>
81 81
 	</p>
82 82
 </div>
Please login to merge, or discard this patch.
apps/dav/lib/DAV/CustomPropertiesBackend.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @return void
145 145
 	 */
146 146
 	public function propPatch($path, PropPatch $propPatch) {
147
-		$propPatch->handleRemaining(function ($changedProps) use ($path) {
147
+		$propPatch->handleRemaining(function($changedProps) use ($path) {
148 148
 			return $this->updateProperties($path, $changedProps);
149 149
 		});
150 150
 	}
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	 */
175 175
 	public function move($source, $destination) {
176 176
 		$statement = $this->connection->prepare(
177
-			'UPDATE `*PREFIX*properties` SET `propertypath` = ?' .
177
+			'UPDATE `*PREFIX*properties` SET `propertypath` = ?'.
178 178
 			' WHERE `userid` = ? AND `propertypath` = ?'
179 179
 		);
180 180
 		$statement->execute([$this->formatPath($destination), $this->user->getUID(), $this->formatPath($source)]);
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 	 * @return bool
237 237
 	 */
238 238
 	private function updateProperties(string $path, array $properties) {
239
-		$deleteStatement = 'DELETE FROM `*PREFIX*properties`' .
239
+		$deleteStatement = 'DELETE FROM `*PREFIX*properties`'.
240 240
 			' WHERE `userid` = ? AND `propertypath` = ? AND `propertyname` = ?';
241 241
 
242
-		$insertStatement = 'INSERT INTO `*PREFIX*properties`' .
242
+		$insertStatement = 'INSERT INTO `*PREFIX*properties`'.
243 243
 			' (`userid`,`propertypath`,`propertyname`,`propertyvalue`) VALUES(?,?,?,?)';
244 244
 
245
-		$updateStatement = 'UPDATE `*PREFIX*properties` SET `propertyvalue` = ?' .
245
+		$updateStatement = 'UPDATE `*PREFIX*properties` SET `propertyvalue` = ?'.
246 246
 			' WHERE `userid` = ? AND `propertypath` = ? AND `propertyname` = ?';
247 247
 
248 248
 		// TODO: use "insert or update" strategy ?
Please login to merge, or discard this patch.