Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 36 | class JSCombiner { |
||
| 37 | |||
| 38 | /** @var IAppData */ |
||
| 39 | protected $appData; |
||
| 40 | |||
| 41 | /** @var IURLGenerator */ |
||
| 42 | protected $urlGenerator; |
||
| 43 | |||
| 44 | /** @var ICache */ |
||
| 45 | protected $depsCache; |
||
| 46 | |||
| 47 | /** @var SystemConfig */ |
||
| 48 | protected $config; |
||
| 49 | |||
| 50 | /** @var ILogger */ |
||
| 51 | protected $logger; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @param IAppData $appData |
||
| 55 | * @param IURLGenerator $urlGenerator |
||
| 56 | * @param ICache $depsCache |
||
| 57 | * @param SystemConfig $config |
||
| 58 | * @param ILogger $logger |
||
| 59 | */ |
||
| 60 | public function __construct(IAppData $appData, |
||
| 61 | IURLGenerator $urlGenerator, |
||
| 62 | ICache $depsCache, |
||
| 63 | SystemConfig $config, |
||
| 64 | ILogger $logger) { |
||
| 65 | $this->appData = $appData; |
||
| 66 | $this->urlGenerator = $urlGenerator; |
||
| 67 | $this->depsCache = $depsCache; |
||
| 68 | $this->config = $config; |
||
| 69 | $this->logger = $logger; |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @param string $root |
||
| 74 | * @param string $file |
||
| 75 | * @param string $app |
||
| 76 | * @return bool |
||
| 77 | */ |
||
| 78 | public function process($root, $file, $app) { |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @param string $fileName |
||
| 103 | * @param ISimpleFolder $folder |
||
| 104 | * @return bool |
||
| 105 | */ |
||
| 106 | protected function isCached($fileName, ISimpleFolder $folder) { |
||
| 107 | $fileName = str_replace('.json', '.js', $fileName); |
||
| 108 | |||
| 109 | if (!$folder->fileExists($fileName)) { |
||
| 110 | return false; |
||
| 111 | } |
||
| 112 | |||
| 113 | $fileName = $fileName . '.deps'; |
||
| 114 | try { |
||
| 115 | $deps = $this->depsCache->get($folder->getName() . '-' . $fileName); |
||
| 116 | if ($deps === null || $deps === '') { |
||
| 117 | $depFile = $folder->getFile($fileName); |
||
| 118 | $deps = $depFile->getContent(); |
||
| 119 | } |
||
| 120 | |||
| 121 | // check again |
||
| 122 | if ($deps === null || $deps === '') { |
||
| 123 | $this->logger->info('JSCombiner: deps file empty: ' . $fileName); |
||
| 124 | return false; |
||
| 125 | } |
||
| 126 | |||
| 127 | $deps = json_decode($deps, true); |
||
| 128 | |||
| 129 | if ($deps === NULL) { |
||
| 130 | return false; |
||
| 131 | } |
||
| 132 | |||
| 133 | View Code Duplication | foreach ($deps as $file=>$mtime) { |
|
| 134 | if (!file_exists($file) || filemtime($file) > $mtime) { |
||
| 135 | return false; |
||
| 136 | } |
||
| 137 | } |
||
| 138 | |||
| 139 | return true; |
||
| 140 | } catch(NotFoundException $e) { |
||
| 141 | return false; |
||
| 142 | } |
||
| 143 | } |
||
| 144 | |||
| 145 | /** |
||
| 146 | * @param string $path |
||
| 147 | * @param string $fileName |
||
| 148 | * @param ISimpleFolder $folder |
||
| 149 | * @return bool |
||
| 150 | */ |
||
| 151 | protected function cache($path, $fileName, ISimpleFolder $folder) { |
||
| 201 | |||
| 202 | /** |
||
| 203 | * @param string $appName |
||
| 204 | * @param string $fileName |
||
| 205 | * @return string |
||
| 206 | */ |
||
| 207 | View Code Duplication | public function getCachedJS($appName, $fileName) { |
|
| 214 | |||
| 215 | /** |
||
| 216 | * @param string $root |
||
| 217 | * @param string $file |
||
| 218 | * @return string[] |
||
| 219 | */ |
||
| 220 | public function getContent($root, $file) { |
||
| 238 | |||
| 239 | |||
| 240 | /** |
||
| 241 | * Clear cache with combined javascript files |
||
| 242 | * |
||
| 243 | * @throws NotFoundException |
||
| 244 | */ |
||
| 245 | public function resetCache() { |
||
| 254 | } |
||
| 255 |