nextcloud / server

apps/federation/tests/Controller/SettingsControllerTest.php

Indentation +123 added lines, -123 removed lines

@@ -20,127 +20,127 @@
 use Test\TestCase;
 
 class SettingsControllerTest extends TestCase {
-	private SettingsController $controller;
-
-	private IRequest&MockObject $request;
-	private IL10N&MockObject $l10n;
-	private TrustedServers&MockObject $trustedServers;
-	private LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(IRequest::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->trustedServers = $this->createMock(TrustedServers::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->controller = new SettingsController(
-			'SettingsControllerTest',
-			$this->request,
-			$this->l10n,
-			$this->trustedServers,
-			$this->logger,
-		);
-	}
-
-	public function testAddServer(): void {
-		$this->trustedServers
-			->expects($this->once())
-			->method('isTrustedServer')
-			->with('url')
-			->willReturn(false);
-		$this->trustedServers
-			->expects($this->once())
-			->method('isNextcloudServer')
-			->with('url')
-			->willReturn(true);
-
-		$result = $this->controller->addServer('url');
-		$this->assertInstanceOf(DataResponse::class, $result);
-
-		$data = $result->getData();
-		$this->assertSame(200, $result->getStatus());
-		$this->assertSame('url', $data['url']);
-		$this->assertArrayHasKey('id', $data);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('checkServerFails')]
-	public function testAddServerFail(bool $isTrustedServer, bool $isNextcloud): void {
-		$this->trustedServers
-			->expects($this->any())
-			->method('isTrustedServer')
-			->with('url')
-			->willReturn($isTrustedServer);
-		$this->trustedServers
-			->expects($this->any())
-			->method('isNextcloudServer')
-			->with('url')
-			->willReturn($isNextcloud);
-
-		if ($isTrustedServer) {
-			$this->expectException(OCSException::class);
-		} else {
-			$this->expectException(OCSNotFoundException::class);
-		}
-
-		$this->controller->addServer('url');
-	}
-
-	public function testRemoveServer(): void {
-		$this->trustedServers->expects($this->once())
-			->method('removeServer')
-			->with(1);
-		$result = $this->controller->removeServer(1);
-		$this->assertTrue($result instanceof DataResponse);
-		$this->assertSame(200, $result->getStatus());
-	}
-
-	public function testCheckServer(): void {
-		$this->trustedServers
-			->expects($this->once())
-			->method('isTrustedServer')
-			->with('url')
-			->willReturn(false);
-		$this->trustedServers
-			->expects($this->once())
-			->method('isNextcloudServer')
-			->with('url')
-			->willReturn(true);
-
-		$this->assertNull(
-			self::invokePrivate($this->controller, 'checkServer', ['url'])
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('checkServerFails')]
-	public function testCheckServerFail(bool $isTrustedServer, bool $isNextcloud): void {
-		$this->trustedServers
-			->expects($this->any())
-			->method('isTrustedServer')
-			->with('url')
-			->willReturn($isTrustedServer);
-		$this->trustedServers
-			->expects($this->any())
-			->method('isNextcloudServer')
-			->with('url')
-			->willReturn($isNextcloud);
-
-		if ($isTrustedServer) {
-			$this->expectException(OCSException::class);
-		} else {
-			$this->expectException(OCSNotFoundException::class);
-		}
-
-		$this->assertTrue(
-			self::invokePrivate($this->controller, 'checkServer', ['url'])
-		);
-	}
-
-	public static function checkServerFails(): array {
-		return [
-			[true, true],
-			[false, false]
-		];
-	}
+    private SettingsController $controller;
+
+    private IRequest&MockObject $request;
+    private IL10N&MockObject $l10n;
+    private TrustedServers&MockObject $trustedServers;
+    private LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(IRequest::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->trustedServers = $this->createMock(TrustedServers::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->controller = new SettingsController(
+            'SettingsControllerTest',
+            $this->request,
+            $this->l10n,
+            $this->trustedServers,
+            $this->logger,
+        );
+    }
+
+    public function testAddServer(): void {
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('isTrustedServer')
+            ->with('url')
+            ->willReturn(false);
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('isNextcloudServer')
+            ->with('url')
+            ->willReturn(true);
+
+        $result = $this->controller->addServer('url');
+        $this->assertInstanceOf(DataResponse::class, $result);
+
+        $data = $result->getData();
+        $this->assertSame(200, $result->getStatus());
+        $this->assertSame('url', $data['url']);
+        $this->assertArrayHasKey('id', $data);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('checkServerFails')]
+    public function testAddServerFail(bool $isTrustedServer, bool $isNextcloud): void {
+        $this->trustedServers
+            ->expects($this->any())
+            ->method('isTrustedServer')
+            ->with('url')
+            ->willReturn($isTrustedServer);
+        $this->trustedServers
+            ->expects($this->any())
+            ->method('isNextcloudServer')
+            ->with('url')
+            ->willReturn($isNextcloud);
+
+        if ($isTrustedServer) {
+            $this->expectException(OCSException::class);
+        } else {
+            $this->expectException(OCSNotFoundException::class);
+        }
+
+        $this->controller->addServer('url');
+    }
+
+    public function testRemoveServer(): void {
+        $this->trustedServers->expects($this->once())
+            ->method('removeServer')
+            ->with(1);
+        $result = $this->controller->removeServer(1);
+        $this->assertTrue($result instanceof DataResponse);
+        $this->assertSame(200, $result->getStatus());
+    }
+
+    public function testCheckServer(): void {
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('isTrustedServer')
+            ->with('url')
+            ->willReturn(false);
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('isNextcloudServer')
+            ->with('url')
+            ->willReturn(true);
+
+        $this->assertNull(
+            self::invokePrivate($this->controller, 'checkServer', ['url'])
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('checkServerFails')]
+    public function testCheckServerFail(bool $isTrustedServer, bool $isNextcloud): void {
+        $this->trustedServers
+            ->expects($this->any())
+            ->method('isTrustedServer')
+            ->with('url')
+            ->willReturn($isTrustedServer);
+        $this->trustedServers
+            ->expects($this->any())
+            ->method('isNextcloudServer')
+            ->with('url')
+            ->willReturn($isNextcloud);
+
+        if ($isTrustedServer) {
+            $this->expectException(OCSException::class);
+        } else {
+            $this->expectException(OCSNotFoundException::class);
+        }
+
+        $this->assertTrue(
+            self::invokePrivate($this->controller, 'checkServer', ['url'])
+        );
+    }
+
+    public static function checkServerFails(): array {
+        return [
+            [true, true],
+            [false, false]
+        ];
+    }
 }

apps/federation/tests/Controller/OCSAuthAPIControllerTest.php

Indentation +141 added lines, -141 removed lines

@@ -23,145 +23,145 @@
 use Test\TestCase;
 
 class OCSAuthAPIControllerTest extends TestCase {
-	private IRequest&MockObject $request;
-	private ISecureRandom&MockObject $secureRandom;
-	private JobList&MockObject $jobList;
-	private TrustedServers&MockObject $trustedServers;
-	private DbHandler&MockObject $dbHandler;
-	private LoggerInterface&MockObject $logger;
-	private ITimeFactory&MockObject $timeFactory;
-	private IThrottler&MockObject $throttler;
-	private OCSAuthAPIController $ocsAuthApi;
-
-	/** @var int simulated timestamp */
-	private int $currentTime = 1234567;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(IRequest::class);
-		$this->secureRandom = $this->createMock(ISecureRandom::class);
-		$this->trustedServers = $this->createMock(TrustedServers::class);
-		$this->dbHandler = $this->createMock(DbHandler::class);
-		$this->jobList = $this->createMock(JobList::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->throttler = $this->createMock(IThrottler::class);
-
-		$this->ocsAuthApi = new OCSAuthAPIController(
-			'federation',
-			$this->request,
-			$this->secureRandom,
-			$this->jobList,
-			$this->trustedServers,
-			$this->dbHandler,
-			$this->logger,
-			$this->timeFactory,
-			$this->throttler
-		);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($this->currentTime);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRequestSharedSecret')]
-	public function testRequestSharedSecret(string $token, string $localToken, bool $isTrustedServer, bool $ok): void {
-		$url = 'url';
-
-		$this->trustedServers
-			->expects($this->once())
-			->method('isTrustedServer')->with($url)->willReturn($isTrustedServer);
-		$this->dbHandler->expects($this->any())
-			->method('getToken')->with($url)->willReturn($localToken);
-
-		if ($ok) {
-			$this->jobList->expects($this->once())->method('add')
-				->with(GetSharedSecret::class, ['url' => $url, 'token' => $token, 'created' => $this->currentTime]);
-		} else {
-			$this->jobList->expects($this->never())->method('add');
-			$this->jobList->expects($this->never())->method('remove');
-			if (!$isTrustedServer) {
-				$this->throttler->expects($this->once())
-					->method('registerAttempt')
-					->with('federationSharedSecret');
-			}
-		}
-
-
-		try {
-			$this->ocsAuthApi->requestSharedSecret($url, $token);
-			$this->assertTrue($ok);
-		} catch (OCSForbiddenException $e) {
-			$this->assertFalse($ok);
-		}
-	}
-
-	public static function dataTestRequestSharedSecret(): array {
-		return [
-			['token2', 'token1', true, true],
-			['token1', 'token2', false, false],
-			['token1', 'token2', true, false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestGetSharedSecret')]
-	public function testGetSharedSecret(bool $isTrustedServer, bool $isValidToken, bool $ok): void {
-		$url = 'url';
-		$token = 'token';
-
-		/** @var OCSAuthAPIController&MockObject $ocsAuthApi */
-		$ocsAuthApi = $this->getMockBuilder(OCSAuthAPIController::class)
-			->setConstructorArgs(
-				[
-					'federation',
-					$this->request,
-					$this->secureRandom,
-					$this->jobList,
-					$this->trustedServers,
-					$this->dbHandler,
-					$this->logger,
-					$this->timeFactory,
-					$this->throttler
-				]
-			)
-			->onlyMethods(['isValidToken'])
-			->getMock();
-
-		$this->trustedServers
-			->expects($this->any())
-			->method('isTrustedServer')->with($url)->willReturn($isTrustedServer);
-		$ocsAuthApi->expects($this->any())
-			->method('isValidToken')->with($url, $token)->willReturn($isValidToken);
-
-		if ($ok) {
-			$this->secureRandom->expects($this->once())->method('generate')->with(32)
-				->willReturn('secret');
-			$this->trustedServers->expects($this->once())
-				->method('addSharedSecret')->with($url, 'secret');
-		} else {
-			$this->secureRandom->expects($this->never())->method('generate');
-			$this->trustedServers->expects($this->never())->method('addSharedSecret');
-			$this->throttler->expects($this->once())
-				->method('registerAttempt')
-				->with('federationSharedSecret');
-		}
-
-		try {
-			$result = $ocsAuthApi->getSharedSecret($url, $token);
-			$this->assertTrue($ok);
-			$data = $result->getData();
-			$this->assertSame('secret', $data['sharedSecret']);
-		} catch (OCSForbiddenException $e) {
-			$this->assertFalse($ok);
-		}
-	}
-
-	public static function dataTestGetSharedSecret(): array {
-		return [
-			[true, true, true],
-			[false, true, false],
-			[true, false, false],
-			[false, false, false],
-		];
-	}
+    private IRequest&MockObject $request;
+    private ISecureRandom&MockObject $secureRandom;
+    private JobList&MockObject $jobList;
+    private TrustedServers&MockObject $trustedServers;
+    private DbHandler&MockObject $dbHandler;
+    private LoggerInterface&MockObject $logger;
+    private ITimeFactory&MockObject $timeFactory;
+    private IThrottler&MockObject $throttler;
+    private OCSAuthAPIController $ocsAuthApi;
+
+    /** @var int simulated timestamp */
+    private int $currentTime = 1234567;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(IRequest::class);
+        $this->secureRandom = $this->createMock(ISecureRandom::class);
+        $this->trustedServers = $this->createMock(TrustedServers::class);
+        $this->dbHandler = $this->createMock(DbHandler::class);
+        $this->jobList = $this->createMock(JobList::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->throttler = $this->createMock(IThrottler::class);
+
+        $this->ocsAuthApi = new OCSAuthAPIController(
+            'federation',
+            $this->request,
+            $this->secureRandom,
+            $this->jobList,
+            $this->trustedServers,
+            $this->dbHandler,
+            $this->logger,
+            $this->timeFactory,
+            $this->throttler
+        );
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($this->currentTime);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRequestSharedSecret')]
+    public function testRequestSharedSecret(string $token, string $localToken, bool $isTrustedServer, bool $ok): void {
+        $url = 'url';
+
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('isTrustedServer')->with($url)->willReturn($isTrustedServer);
+        $this->dbHandler->expects($this->any())
+            ->method('getToken')->with($url)->willReturn($localToken);
+
+        if ($ok) {
+            $this->jobList->expects($this->once())->method('add')
+                ->with(GetSharedSecret::class, ['url' => $url, 'token' => $token, 'created' => $this->currentTime]);
+        } else {
+            $this->jobList->expects($this->never())->method('add');
+            $this->jobList->expects($this->never())->method('remove');
+            if (!$isTrustedServer) {
+                $this->throttler->expects($this->once())
+                    ->method('registerAttempt')
+                    ->with('federationSharedSecret');
+            }
+        }
+
+
+        try {
+            $this->ocsAuthApi->requestSharedSecret($url, $token);
+            $this->assertTrue($ok);
+        } catch (OCSForbiddenException $e) {
+            $this->assertFalse($ok);
+        }
+    }
+
+    public static function dataTestRequestSharedSecret(): array {
+        return [
+            ['token2', 'token1', true, true],
+            ['token1', 'token2', false, false],
+            ['token1', 'token2', true, false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestGetSharedSecret')]
+    public function testGetSharedSecret(bool $isTrustedServer, bool $isValidToken, bool $ok): void {
+        $url = 'url';
+        $token = 'token';
+
+        /** @var OCSAuthAPIController&MockObject $ocsAuthApi */
+        $ocsAuthApi = $this->getMockBuilder(OCSAuthAPIController::class)
+            ->setConstructorArgs(
+                [
+                    'federation',
+                    $this->request,
+                    $this->secureRandom,
+                    $this->jobList,
+                    $this->trustedServers,
+                    $this->dbHandler,
+                    $this->logger,
+                    $this->timeFactory,
+                    $this->throttler
+                ]
+            )
+            ->onlyMethods(['isValidToken'])
+            ->getMock();
+
+        $this->trustedServers
+            ->expects($this->any())
+            ->method('isTrustedServer')->with($url)->willReturn($isTrustedServer);
+        $ocsAuthApi->expects($this->any())
+            ->method('isValidToken')->with($url, $token)->willReturn($isValidToken);
+
+        if ($ok) {
+            $this->secureRandom->expects($this->once())->method('generate')->with(32)
+                ->willReturn('secret');
+            $this->trustedServers->expects($this->once())
+                ->method('addSharedSecret')->with($url, 'secret');
+        } else {
+            $this->secureRandom->expects($this->never())->method('generate');
+            $this->trustedServers->expects($this->never())->method('addSharedSecret');
+            $this->throttler->expects($this->once())
+                ->method('registerAttempt')
+                ->with('federationSharedSecret');
+        }
+
+        try {
+            $result = $ocsAuthApi->getSharedSecret($url, $token);
+            $this->assertTrue($ok);
+            $data = $result->getData();
+            $this->assertSame('secret', $data['sharedSecret']);
+        } catch (OCSForbiddenException $e) {
+            $this->assertFalse($ok);
+        }
+    }
+
+    public static function dataTestGetSharedSecret(): array {
+        return [
+            [true, true, true],
+            [false, true, false],
+            [true, false, false],
+            [false, false, false],
+        ];
+    }
 }

apps/federation/tests/Settings/AdminTest.php

Indentation +32 added lines, -32 removed lines

@@ -15,36 +15,36 @@
 use Test\TestCase;
 
 class AdminTest extends TestCase {
-	private TrustedServers&MockObject $trustedServers;
-	private Admin $admin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->trustedServers = $this->createMock(TrustedServers::class);
-		$this->admin = new Admin(
-			$this->trustedServers,
-			$this->createMock(IL10N::class)
-		);
-	}
-
-	public function testGetForm(): void {
-		$this->trustedServers
-			->expects($this->once())
-			->method('getServers')
-			->willReturn(['myserver', 'secondserver']);
-
-		$params = [
-			'trustedServers' => ['myserver', 'secondserver'],
-		];
-		$expected = new TemplateResponse('federation', 'settings-admin', $params, '');
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
-
-	public function testGetSection(): void {
-		$this->assertSame('sharing', $this->admin->getSection());
-	}
-
-	public function testGetPriority(): void {
-		$this->assertSame(30, $this->admin->getPriority());
-	}
+    private TrustedServers&MockObject $trustedServers;
+    private Admin $admin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->trustedServers = $this->createMock(TrustedServers::class);
+        $this->admin = new Admin(
+            $this->trustedServers,
+            $this->createMock(IL10N::class)
+        );
+    }
+
+    public function testGetForm(): void {
+        $this->trustedServers
+            ->expects($this->once())
+            ->method('getServers')
+            ->willReturn(['myserver', 'secondserver']);
+
+        $params = [
+            'trustedServers' => ['myserver', 'secondserver'],
+        ];
+        $expected = new TemplateResponse('federation', 'settings-admin', $params, '');
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
+
+    public function testGetSection(): void {
+        $this->assertSame('sharing', $this->admin->getSection());
+    }
+
+    public function testGetPriority(): void {
+        $this->assertSame(30, $this->admin->getPriority());
+    }
 }

apps/federation/tests/TrustedServersTest.php

Indentation +252 added lines, -252 removed lines

@@ -26,256 +26,256 @@
 use Test\TestCase;
 
 class TrustedServersTest extends TestCase {
-	private TrustedServers $trustedServers;
-	private DbHandler&MockObject $dbHandler;
-	private IClientService&MockObject $httpClientService;
-	private IClient&MockObject $httpClient;
-	private IResponse&MockObject $response;
-	private LoggerInterface&MockObject $logger;
-	private IJobList&MockObject $jobList;
-	private ISecureRandom&MockObject $secureRandom;
-	private IConfig&MockObject $config;
-	private IEventDispatcher&MockObject $dispatcher;
-	private ITimeFactory&MockObject $timeFactory;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbHandler = $this->createMock(DbHandler::class);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->httpClientService = $this->createMock(IClientService::class);
-		$this->httpClient = $this->createMock(IClient::class);
-		$this->response = $this->createMock(IResponse::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->secureRandom = $this->createMock(ISecureRandom::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-
-		$this->trustedServers = new TrustedServers(
-			$this->dbHandler,
-			$this->httpClientService,
-			$this->logger,
-			$this->jobList,
-			$this->secureRandom,
-			$this->config,
-			$this->dispatcher,
-			$this->timeFactory
-		);
-	}
-
-	public function testAddServer(): void {
-		/** @var TrustedServers&MockObject $trustedServers */
-		$trustedServers = $this->getMockBuilder(TrustedServers::class)
-			->setConstructorArgs(
-				[
-					$this->dbHandler,
-					$this->httpClientService,
-					$this->logger,
-					$this->jobList,
-					$this->secureRandom,
-					$this->config,
-					$this->dispatcher,
-					$this->timeFactory
-				]
-			)
-			->onlyMethods(['updateProtocol'])
-			->getMock();
-		$trustedServers->expects($this->once())->method('updateProtocol')
-			->with('url')->willReturn('https://url');
-		$this->timeFactory->method('getTime')
-			->willReturn(1234567);
-		$this->dbHandler->expects($this->once())->method('addServer')->with('https://url')
-			->willReturn(1);
-
-		$this->secureRandom->expects($this->once())->method('generate')
-			->willReturn('token');
-		$this->dbHandler->expects($this->once())->method('addToken')->with('https://url', 'token');
-		$this->jobList->expects($this->once())->method('add')
-			->with(RequestSharedSecret::class,
-				['url' => 'https://url', 'token' => 'token', 'created' => 1234567]);
-
-		$this->assertSame(
-			1,
-			$trustedServers->addServer('url')
-		);
-	}
-
-	public function testAddSharedSecret(): void {
-		$this->dbHandler->expects($this->once())->method('addSharedSecret')
-			->with('url', 'secret');
-		$this->trustedServers->addSharedSecret('url', 'secret');
-	}
-
-	public function testGetSharedSecret(): void {
-		$this->dbHandler->expects($this->once())
-			->method('getSharedSecret')
-			->with('url')
-			->willReturn('secret');
-		$this->assertSame(
-			$this->trustedServers->getSharedSecret('url'),
-			'secret'
-		);
-	}
-
-	public function testRemoveServer(): void {
-		$id = 42;
-		$server = ['url_hash' => 'url_hash'];
-		$this->dbHandler->expects($this->once())->method('removeServer')->with($id);
-		$this->dbHandler->expects($this->once())->method('getServerById')->with($id)
-			->willReturn($server);
-		$this->dispatcher->expects($this->once())->method('dispatchTyped')
-			->willReturnCallback(
-				function ($event): void {
-					$this->assertSame(get_class($event), TrustedServerRemovedEvent::class);
-					/** @var \OCP\Federated\Events\TrustedServerRemovedEvent $event */
-					$this->assertSame('url_hash', $event->getUrlHash());
-				}
-			);
-		$this->trustedServers->removeServer($id);
-	}
-
-	public function testGetServers(): void {
-		$this->dbHandler->expects($this->once())->method('getAllServer')->willReturn(['servers']);
-
-		$this->assertEquals(
-			['servers'],
-			$this->trustedServers->getServers()
-		);
-	}
-
-
-	public function testIsTrustedServer(): void {
-		$this->dbHandler->expects($this->once())
-			->method('serverExists')->with('url')
-			->willReturn(true);
-
-		$this->assertTrue(
-			$this->trustedServers->isTrustedServer('url')
-		);
-	}
-
-	public function testSetServerStatus(): void {
-		$this->dbHandler->expects($this->once())->method('setServerStatus')
-			->with('url', 1);
-		$this->trustedServers->setServerStatus('url', 1);
-	}
-
-	public function testGetServerStatus(): void {
-		$this->dbHandler->expects($this->once())->method('getServerStatus')
-			->with('url')->willReturn(1);
-		$this->assertSame(
-			$this->trustedServers->getServerStatus('url'),
-			1
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsNextcloudServer')]
-	public function testIsNextcloudServer(int $statusCode, bool $isValidNextcloudVersion, bool $expected): void {
-		$server = 'server1';
-
-		/** @var TrustedServers&MockObject $trustedServers */
-		$trustedServers = $this->getMockBuilder(TrustedServers::class)
-			->setConstructorArgs(
-				[
-					$this->dbHandler,
-					$this->httpClientService,
-					$this->logger,
-					$this->jobList,
-					$this->secureRandom,
-					$this->config,
-					$this->dispatcher,
-					$this->timeFactory
-				]
-			)
-			->onlyMethods(['checkNextcloudVersion'])
-			->getMock();
-
-		$this->httpClientService->expects($this->once())->method('newClient')
-			->willReturn($this->httpClient);
-
-		$this->httpClient->expects($this->once())->method('get')->with($server . '/status.php')
-			->willReturn($this->response);
-
-		$this->response->expects($this->once())->method('getStatusCode')
-			->willReturn($statusCode);
-
-		if ($statusCode === 200) {
-			$this->response->expects($this->once())->method('getBody')
-				->willReturn('');
-			$trustedServers->expects($this->once())->method('checkNextcloudVersion')
-				->willReturn($isValidNextcloudVersion);
-		} else {
-			$trustedServers->expects($this->never())->method('checkNextcloudVersion');
-		}
-
-		$this->assertSame($expected,
-			$trustedServers->isNextcloudServer($server)
-		);
-	}
-
-	public static function dataTestIsNextcloudServer(): array {
-		return [
-			[200, true, true],
-			[200, false, false],
-			[404, true, false],
-		];
-	}
-
-	public function testIsNextcloudServerFail(): void {
-		$server = 'server1';
-
-		$this->httpClientService->expects($this->once())
-			->method('newClient')
-			->willReturn($this->httpClient);
-
-		$this->httpClient->expects($this->once())
-			->method('get')
-			->with($server . '/status.php')
-			->willThrowException(new \Exception('simulated exception'));
-
-		$this->assertFalse($this->trustedServers->isNextcloudServer($server));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCheckNextcloudVersion')]
-	public function testCheckNextcloudVersion(string $status): void {
-		$this->assertTrue(self::invokePrivate($this->trustedServers, 'checkNextcloudVersion', [$status]));
-	}
-
-	public static function dataTestCheckNextcloudVersion(): array {
-		return [
-			['{"version":"9.0.0"}'],
-			['{"version":"9.1.0"}']
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCheckNextcloudVersionTooLow')]
-	public function testCheckNextcloudVersionTooLow(string $status): void {
-		$this->expectException(HintException::class);
-		$this->expectExceptionMessage('Remote server version is too low. 9.0 is required.');
-
-		self::invokePrivate($this->trustedServers, 'checkNextcloudVersion', [$status]);
-	}
-
-	public static function dataTestCheckNextcloudVersionTooLow(): array {
-		return [
-			['{"version":"8.2.3"}'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestUpdateProtocol')]
-	public function testUpdateProtocol(string $url, string $expected): void {
-		$this->assertSame($expected,
-			self::invokePrivate($this->trustedServers, 'updateProtocol', [$url])
-		);
-	}
-
-	public static function dataTestUpdateProtocol(): array {
-		return [
-			['http://owncloud.org', 'http://owncloud.org'],
-			['https://owncloud.org', 'https://owncloud.org'],
-			['owncloud.org', 'https://owncloud.org'],
-			['httpserver', 'https://httpserver'],
-		];
-	}
+    private TrustedServers $trustedServers;
+    private DbHandler&MockObject $dbHandler;
+    private IClientService&MockObject $httpClientService;
+    private IClient&MockObject $httpClient;
+    private IResponse&MockObject $response;
+    private LoggerInterface&MockObject $logger;
+    private IJobList&MockObject $jobList;
+    private ISecureRandom&MockObject $secureRandom;
+    private IConfig&MockObject $config;
+    private IEventDispatcher&MockObject $dispatcher;
+    private ITimeFactory&MockObject $timeFactory;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbHandler = $this->createMock(DbHandler::class);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->httpClientService = $this->createMock(IClientService::class);
+        $this->httpClient = $this->createMock(IClient::class);
+        $this->response = $this->createMock(IResponse::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->secureRandom = $this->createMock(ISecureRandom::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+
+        $this->trustedServers = new TrustedServers(
+            $this->dbHandler,
+            $this->httpClientService,
+            $this->logger,
+            $this->jobList,
+            $this->secureRandom,
+            $this->config,
+            $this->dispatcher,
+            $this->timeFactory
+        );
+    }
+
+    public function testAddServer(): void {
+        /** @var TrustedServers&MockObject $trustedServers */
+        $trustedServers = $this->getMockBuilder(TrustedServers::class)
+            ->setConstructorArgs(
+                [
+                    $this->dbHandler,
+                    $this->httpClientService,
+                    $this->logger,
+                    $this->jobList,
+                    $this->secureRandom,
+                    $this->config,
+                    $this->dispatcher,
+                    $this->timeFactory
+                ]
+            )
+            ->onlyMethods(['updateProtocol'])
+            ->getMock();
+        $trustedServers->expects($this->once())->method('updateProtocol')
+            ->with('url')->willReturn('https://url');
+        $this->timeFactory->method('getTime')
+            ->willReturn(1234567);
+        $this->dbHandler->expects($this->once())->method('addServer')->with('https://url')
+            ->willReturn(1);
+
+        $this->secureRandom->expects($this->once())->method('generate')
+            ->willReturn('token');
+        $this->dbHandler->expects($this->once())->method('addToken')->with('https://url', 'token');
+        $this->jobList->expects($this->once())->method('add')
+            ->with(RequestSharedSecret::class,
+                ['url' => 'https://url', 'token' => 'token', 'created' => 1234567]);
+
+        $this->assertSame(
+            1,
+            $trustedServers->addServer('url')
+        );
+    }
+
+    public function testAddSharedSecret(): void {
+        $this->dbHandler->expects($this->once())->method('addSharedSecret')
+            ->with('url', 'secret');
+        $this->trustedServers->addSharedSecret('url', 'secret');
+    }
+
+    public function testGetSharedSecret(): void {
+        $this->dbHandler->expects($this->once())
+            ->method('getSharedSecret')
+            ->with('url')
+            ->willReturn('secret');
+        $this->assertSame(
+            $this->trustedServers->getSharedSecret('url'),
+            'secret'
+        );
+    }
+
+    public function testRemoveServer(): void {
+        $id = 42;
+        $server = ['url_hash' => 'url_hash'];
+        $this->dbHandler->expects($this->once())->method('removeServer')->with($id);
+        $this->dbHandler->expects($this->once())->method('getServerById')->with($id)
+            ->willReturn($server);
+        $this->dispatcher->expects($this->once())->method('dispatchTyped')
+            ->willReturnCallback(
+                function ($event): void {
+                    $this->assertSame(get_class($event), TrustedServerRemovedEvent::class);
+                    /** @var \OCP\Federated\Events\TrustedServerRemovedEvent $event */
+                    $this->assertSame('url_hash', $event->getUrlHash());
+                }
+            );
+        $this->trustedServers->removeServer($id);
+    }
+
+    public function testGetServers(): void {
+        $this->dbHandler->expects($this->once())->method('getAllServer')->willReturn(['servers']);
+
+        $this->assertEquals(
+            ['servers'],
+            $this->trustedServers->getServers()
+        );
+    }
+
+
+    public function testIsTrustedServer(): void {
+        $this->dbHandler->expects($this->once())
+            ->method('serverExists')->with('url')
+            ->willReturn(true);
+
+        $this->assertTrue(
+            $this->trustedServers->isTrustedServer('url')
+        );
+    }
+
+    public function testSetServerStatus(): void {
+        $this->dbHandler->expects($this->once())->method('setServerStatus')
+            ->with('url', 1);
+        $this->trustedServers->setServerStatus('url', 1);
+    }
+
+    public function testGetServerStatus(): void {
+        $this->dbHandler->expects($this->once())->method('getServerStatus')
+            ->with('url')->willReturn(1);
+        $this->assertSame(
+            $this->trustedServers->getServerStatus('url'),
+            1
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsNextcloudServer')]
+    public function testIsNextcloudServer(int $statusCode, bool $isValidNextcloudVersion, bool $expected): void {
+        $server = 'server1';
+
+        /** @var TrustedServers&MockObject $trustedServers */
+        $trustedServers = $this->getMockBuilder(TrustedServers::class)
+            ->setConstructorArgs(
+                [
+                    $this->dbHandler,
+                    $this->httpClientService,
+                    $this->logger,
+                    $this->jobList,
+                    $this->secureRandom,
+                    $this->config,
+                    $this->dispatcher,
+                    $this->timeFactory
+                ]
+            )
+            ->onlyMethods(['checkNextcloudVersion'])
+            ->getMock();
+
+        $this->httpClientService->expects($this->once())->method('newClient')
+            ->willReturn($this->httpClient);
+
+        $this->httpClient->expects($this->once())->method('get')->with($server . '/status.php')
+            ->willReturn($this->response);
+
+        $this->response->expects($this->once())->method('getStatusCode')
+            ->willReturn($statusCode);
+
+        if ($statusCode === 200) {
+            $this->response->expects($this->once())->method('getBody')
+                ->willReturn('');
+            $trustedServers->expects($this->once())->method('checkNextcloudVersion')
+                ->willReturn($isValidNextcloudVersion);
+        } else {
+            $trustedServers->expects($this->never())->method('checkNextcloudVersion');
+        }
+
+        $this->assertSame($expected,
+            $trustedServers->isNextcloudServer($server)
+        );
+    }
+
+    public static function dataTestIsNextcloudServer(): array {
+        return [
+            [200, true, true],
+            [200, false, false],
+            [404, true, false],
+        ];
+    }
+
+    public function testIsNextcloudServerFail(): void {
+        $server = 'server1';
+
+        $this->httpClientService->expects($this->once())
+            ->method('newClient')
+            ->willReturn($this->httpClient);
+
+        $this->httpClient->expects($this->once())
+            ->method('get')
+            ->with($server . '/status.php')
+            ->willThrowException(new \Exception('simulated exception'));
+
+        $this->assertFalse($this->trustedServers->isNextcloudServer($server));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCheckNextcloudVersion')]
+    public function testCheckNextcloudVersion(string $status): void {
+        $this->assertTrue(self::invokePrivate($this->trustedServers, 'checkNextcloudVersion', [$status]));
+    }
+
+    public static function dataTestCheckNextcloudVersion(): array {
+        return [
+            ['{"version":"9.0.0"}'],
+            ['{"version":"9.1.0"}']
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCheckNextcloudVersionTooLow')]
+    public function testCheckNextcloudVersionTooLow(string $status): void {
+        $this->expectException(HintException::class);
+        $this->expectExceptionMessage('Remote server version is too low. 9.0 is required.');
+
+        self::invokePrivate($this->trustedServers, 'checkNextcloudVersion', [$status]);
+    }
+
+    public static function dataTestCheckNextcloudVersionTooLow(): array {
+        return [
+            ['{"version":"8.2.3"}'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestUpdateProtocol')]
+    public function testUpdateProtocol(string $url, string $expected): void {
+        $this->assertSame($expected,
+            self::invokePrivate($this->trustedServers, 'updateProtocol', [$url])
+        );
+    }
+
+    public static function dataTestUpdateProtocol(): array {
+        return [
+            ['http://owncloud.org', 'http://owncloud.org'],
+            ['https://owncloud.org', 'https://owncloud.org'],
+            ['owncloud.org', 'https://owncloud.org'],
+            ['httpserver', 'https://httpserver'],
+        ];
+    }
 }

apps/federation/tests/DbHandlerTest.php

Indentation +262 added lines, -262 removed lines

@@ -20,266 +20,266 @@
  * @group DB
  */
 class DbHandlerTest extends TestCase {
-	private DbHandler $dbHandler;
-	private IL10N&MockObject $il10n;
-	private IDBConnection $connection;
-	private string $dbTable = 'trusted_servers';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-		$this->il10n = $this->createMock(IL10N::class);
-
-		$this->dbHandler = new DbHandler(
-			$this->connection,
-			$this->il10n
-		);
-
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertEmpty($result, 'we need to start with a empty trusted_servers table');
-	}
-
-	protected function tearDown(): void {
-		$query = $this->connection->getQueryBuilder()->delete($this->dbTable);
-		$query->executeStatement()
-		;
-		parent::tearDown();
-	}
-
-	/**
-	 *
-	 * @param string $url passed to the method
-	 * @param string $expectedUrl the url we expect to be written to the db
-	 * @param string $expectedHash the hash value we expect to be written to the db
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestAddServer')]
-	public function testAddServer(string $url, string $expectedUrl, string $expectedHash): void {
-		$id = $this->dbHandler->addServer($url);
-
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame($expectedUrl, $result[0]['url']);
-		$this->assertSame($id, (int)$result[0]['id']);
-		$this->assertSame($expectedHash, $result[0]['url_hash']);
-		$this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
-	}
-
-	public static function dataTestAddServer(): array {
-		return [
-			['http://owncloud.org', 'http://owncloud.org', sha1('owncloud.org')],
-			['https://owncloud.org', 'https://owncloud.org', sha1('owncloud.org')],
-			['http://owncloud.org/', 'http://owncloud.org', sha1('owncloud.org')],
-		];
-	}
-
-	public function testRemove(): void {
-		$id1 = $this->dbHandler->addServer('server1');
-		$id2 = $this->dbHandler->addServer('server2');
-
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(2, $result);
-		$this->assertSame('server1', $result[0]['url']);
-		$this->assertSame('server2', $result[1]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
-		$this->assertSame($id2, (int)$result[1]['id']);
-
-		$this->dbHandler->removeServer($id2);
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame('server1', $result[0]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
-	}
-
-
-	public function testGetServerById(): void {
-		$this->dbHandler->addServer('server1');
-		$id = $this->dbHandler->addServer('server2');
-
-		$result = $this->dbHandler->getServerById($id);
-		$this->assertSame('server2', $result['url']);
-	}
-
-	public function testGetAll(): void {
-		$id1 = $this->dbHandler->addServer('server1');
-		$id2 = $this->dbHandler->addServer('server2');
-
-		$result = $this->dbHandler->getAllServer();
-		$this->assertSame(2, count($result));
-		$this->assertSame('server1', $result[0]['url']);
-		$this->assertSame('server2', $result[1]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
-		$this->assertSame($id2, (int)$result[1]['id']);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestServerExists')]
-	public function testServerExists(string $serverInTable, string $checkForServer, bool $expected): void {
-		$this->dbHandler->addServer($serverInTable);
-		$this->assertSame($expected,
-			$this->dbHandler->serverExists($checkForServer)
-		);
-	}
-
-	public static function dataTestServerExists(): array {
-		return [
-			['server1', 'server1', true],
-			['server1', 'http://server1', true],
-			['server1', 'server2', false]
-		];
-	}
-
-	public function XtestAddToken() {
-		$this->dbHandler->addServer('server1');
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame(null, $result[0]['token']);
-		$this->dbHandler->addToken('http://server1', 'token');
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame('token', $result[0]['token']);
-	}
-
-	public function testGetToken(): void {
-		$this->dbHandler->addServer('server1');
-		$this->dbHandler->addToken('http://server1', 'token');
-		$this->assertSame('token',
-			$this->dbHandler->getToken('https://server1')
-		);
-	}
-
-	public function XtestAddSharedSecret() {
-		$this->dbHandler->addServer('server1');
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame(null, $result[0]['shared_secret']);
-		$this->dbHandler->addSharedSecret('http://server1', 'secret');
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame('secret', $result[0]['shared_secret']);
-	}
-
-	public function testGetSharedSecret(): void {
-		$this->dbHandler->addServer('server1');
-		$this->dbHandler->addSharedSecret('http://server1', 'secret');
-		$this->assertSame('secret',
-			$this->dbHandler->getSharedSecret('https://server1')
-		);
-	}
-
-	public function testSetServerStatus(): void {
-		$this->dbHandler->addServer('server1');
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
-		$this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK);
-		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-		$this->assertCount(1, $result);
-		$this->assertSame(TrustedServers::STATUS_OK, (int)$result[0]['status']);
-	}
-
-	public function testGetServerStatus(): void {
-		$this->dbHandler->addServer('server1');
-		$this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK);
-		$this->assertSame(TrustedServers::STATUS_OK,
-			$this->dbHandler->getServerStatus('https://server1')
-		);
-
-		// test sync token
-		$this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK, 'token1234567890');
-		$servers = $this->dbHandler->getAllServer();
-		$this->assertSame('token1234567890', $servers[0]['sync_token']);
-	}
-
-	/**
-	 * hash should always be computed with the normalized URL
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestHash')]
-	public function testHash(string $url, string $expected): void {
-		$this->assertSame($expected,
-			$this->invokePrivate($this->dbHandler, 'hash', [$url])
-		);
-	}
-
-	public static function dataTestHash(): array {
-		return [
-			['server1', sha1('server1')],
-			['http://server1', sha1('server1')],
-			['https://server1', sha1('server1')],
-			['http://server1/', sha1('server1')],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestNormalizeUrl')]
-	public function testNormalizeUrl(string $url, string $expected): void {
-		$this->assertSame($expected,
-			$this->invokePrivate($this->dbHandler, 'normalizeUrl', [$url])
-		);
-	}
-
-	public static function dataTestNormalizeUrl(): array {
-		return [
-			['owncloud.org', 'owncloud.org'],
-			['http://owncloud.org', 'owncloud.org'],
-			['https://owncloud.org', 'owncloud.org'],
-			['https://owncloud.org//mycloud', 'owncloud.org/mycloud'],
-			['https://owncloud.org/mycloud/', 'owncloud.org/mycloud'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesAuth')]
-	public function testAuth(bool $expectedResult, string $user, string $password): void {
-		if ($expectedResult) {
-			$this->dbHandler->addServer('url1');
-			$this->dbHandler->addSharedSecret('url1', $password);
-		}
-		$result = $this->dbHandler->auth($user, $password);
-		$this->assertEquals($expectedResult, $result);
-	}
-
-	public static function providesAuth(): array {
-		return [
-			[false, 'foo', ''],
-			[true, 'system', '123456789'],
-		];
-	}
+    private DbHandler $dbHandler;
+    private IL10N&MockObject $il10n;
+    private IDBConnection $connection;
+    private string $dbTable = 'trusted_servers';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+        $this->il10n = $this->createMock(IL10N::class);
+
+        $this->dbHandler = new DbHandler(
+            $this->connection,
+            $this->il10n
+        );
+
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertEmpty($result, 'we need to start with a empty trusted_servers table');
+    }
+
+    protected function tearDown(): void {
+        $query = $this->connection->getQueryBuilder()->delete($this->dbTable);
+        $query->executeStatement()
+        ;
+        parent::tearDown();
+    }
+
+    /**
+     *
+     * @param string $url passed to the method
+     * @param string $expectedUrl the url we expect to be written to the db
+     * @param string $expectedHash the hash value we expect to be written to the db
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestAddServer')]
+    public function testAddServer(string $url, string $expectedUrl, string $expectedHash): void {
+        $id = $this->dbHandler->addServer($url);
+
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame($expectedUrl, $result[0]['url']);
+        $this->assertSame($id, (int)$result[0]['id']);
+        $this->assertSame($expectedHash, $result[0]['url_hash']);
+        $this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
+    }
+
+    public static function dataTestAddServer(): array {
+        return [
+            ['http://owncloud.org', 'http://owncloud.org', sha1('owncloud.org')],
+            ['https://owncloud.org', 'https://owncloud.org', sha1('owncloud.org')],
+            ['http://owncloud.org/', 'http://owncloud.org', sha1('owncloud.org')],
+        ];
+    }
+
+    public function testRemove(): void {
+        $id1 = $this->dbHandler->addServer('server1');
+        $id2 = $this->dbHandler->addServer('server2');
+
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(2, $result);
+        $this->assertSame('server1', $result[0]['url']);
+        $this->assertSame('server2', $result[1]['url']);
+        $this->assertSame($id1, (int)$result[0]['id']);
+        $this->assertSame($id2, (int)$result[1]['id']);
+
+        $this->dbHandler->removeServer($id2);
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame('server1', $result[0]['url']);
+        $this->assertSame($id1, (int)$result[0]['id']);
+    }
+
+
+    public function testGetServerById(): void {
+        $this->dbHandler->addServer('server1');
+        $id = $this->dbHandler->addServer('server2');
+
+        $result = $this->dbHandler->getServerById($id);
+        $this->assertSame('server2', $result['url']);
+    }
+
+    public function testGetAll(): void {
+        $id1 = $this->dbHandler->addServer('server1');
+        $id2 = $this->dbHandler->addServer('server2');
+
+        $result = $this->dbHandler->getAllServer();
+        $this->assertSame(2, count($result));
+        $this->assertSame('server1', $result[0]['url']);
+        $this->assertSame('server2', $result[1]['url']);
+        $this->assertSame($id1, (int)$result[0]['id']);
+        $this->assertSame($id2, (int)$result[1]['id']);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestServerExists')]
+    public function testServerExists(string $serverInTable, string $checkForServer, bool $expected): void {
+        $this->dbHandler->addServer($serverInTable);
+        $this->assertSame($expected,
+            $this->dbHandler->serverExists($checkForServer)
+        );
+    }
+
+    public static function dataTestServerExists(): array {
+        return [
+            ['server1', 'server1', true],
+            ['server1', 'http://server1', true],
+            ['server1', 'server2', false]
+        ];
+    }
+
+    public function XtestAddToken() {
+        $this->dbHandler->addServer('server1');
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame(null, $result[0]['token']);
+        $this->dbHandler->addToken('http://server1', 'token');
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame('token', $result[0]['token']);
+    }
+
+    public function testGetToken(): void {
+        $this->dbHandler->addServer('server1');
+        $this->dbHandler->addToken('http://server1', 'token');
+        $this->assertSame('token',
+            $this->dbHandler->getToken('https://server1')
+        );
+    }
+
+    public function XtestAddSharedSecret() {
+        $this->dbHandler->addServer('server1');
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame(null, $result[0]['shared_secret']);
+        $this->dbHandler->addSharedSecret('http://server1', 'secret');
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame('secret', $result[0]['shared_secret']);
+    }
+
+    public function testGetSharedSecret(): void {
+        $this->dbHandler->addServer('server1');
+        $this->dbHandler->addSharedSecret('http://server1', 'secret');
+        $this->assertSame('secret',
+            $this->dbHandler->getSharedSecret('https://server1')
+        );
+    }
+
+    public function testSetServerStatus(): void {
+        $this->dbHandler->addServer('server1');
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
+        $this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK);
+        $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+        $this->assertCount(1, $result);
+        $this->assertSame(TrustedServers::STATUS_OK, (int)$result[0]['status']);
+    }
+
+    public function testGetServerStatus(): void {
+        $this->dbHandler->addServer('server1');
+        $this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK);
+        $this->assertSame(TrustedServers::STATUS_OK,
+            $this->dbHandler->getServerStatus('https://server1')
+        );
+
+        // test sync token
+        $this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK, 'token1234567890');
+        $servers = $this->dbHandler->getAllServer();
+        $this->assertSame('token1234567890', $servers[0]['sync_token']);
+    }
+
+    /**
+     * hash should always be computed with the normalized URL
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestHash')]
+    public function testHash(string $url, string $expected): void {
+        $this->assertSame($expected,
+            $this->invokePrivate($this->dbHandler, 'hash', [$url])
+        );
+    }
+
+    public static function dataTestHash(): array {
+        return [
+            ['server1', sha1('server1')],
+            ['http://server1', sha1('server1')],
+            ['https://server1', sha1('server1')],
+            ['http://server1/', sha1('server1')],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestNormalizeUrl')]
+    public function testNormalizeUrl(string $url, string $expected): void {
+        $this->assertSame($expected,
+            $this->invokePrivate($this->dbHandler, 'normalizeUrl', [$url])
+        );
+    }
+
+    public static function dataTestNormalizeUrl(): array {
+        return [
+            ['owncloud.org', 'owncloud.org'],
+            ['http://owncloud.org', 'owncloud.org'],
+            ['https://owncloud.org', 'owncloud.org'],
+            ['https://owncloud.org//mycloud', 'owncloud.org/mycloud'],
+            ['https://owncloud.org/mycloud/', 'owncloud.org/mycloud'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesAuth')]
+    public function testAuth(bool $expectedResult, string $user, string $password): void {
+        if ($expectedResult) {
+            $this->dbHandler->addServer('url1');
+            $this->dbHandler->addSharedSecret('url1', $password);
+        }
+        $result = $this->dbHandler->auth($user, $password);
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    public static function providesAuth(): array {
+        return [
+            [false, 'foo', ''],
+            [true, 'system', '123456789'],
+        ];
+    }
 }

Spacing +9 added lines, -9 removed lines

@@ -68,9 +68,9 @@ 
 		$qResult->closeCursor();
 		$this->assertCount(1, $result);
 		$this->assertSame($expectedUrl, $result[0]['url']);
-		$this->assertSame($id, (int)$result[0]['id']);
+		$this->assertSame($id, (int) $result[0]['id']);
 		$this->assertSame($expectedHash, $result[0]['url_hash']);
-		$this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
+		$this->assertSame(TrustedServers::STATUS_PENDING, (int) $result[0]['status']);
 	}
 
 	public static function dataTestAddServer(): array {
@@ -93,8 +93,8 @@ 
 		$this->assertCount(2, $result);
 		$this->assertSame('server1', $result[0]['url']);
 		$this->assertSame('server2', $result[1]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
-		$this->assertSame($id2, (int)$result[1]['id']);
+		$this->assertSame($id1, (int) $result[0]['id']);
+		$this->assertSame($id2, (int) $result[1]['id']);
 
 		$this->dbHandler->removeServer($id2);
 		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
@@ -104,7 +104,7 @@ 
 		$qResult->closeCursor();
 		$this->assertCount(1, $result);
 		$this->assertSame('server1', $result[0]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
+		$this->assertSame($id1, (int) $result[0]['id']);
 	}
 
 
@@ -124,8 +124,8 @@ 
 		$this->assertSame(2, count($result));
 		$this->assertSame('server1', $result[0]['url']);
 		$this->assertSame('server2', $result[1]['url']);
-		$this->assertSame($id1, (int)$result[0]['id']);
-		$this->assertSame($id2, (int)$result[1]['id']);
+		$this->assertSame($id1, (int) $result[0]['id']);
+		$this->assertSame($id2, (int) $result[1]['id']);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestServerExists')]
@@ -206,7 +206,7 @@ 
 		$result = $qResult->fetchAll();
 		$qResult->closeCursor();
 		$this->assertCount(1, $result);
-		$this->assertSame(TrustedServers::STATUS_PENDING, (int)$result[0]['status']);
+		$this->assertSame(TrustedServers::STATUS_PENDING, (int) $result[0]['status']);
 		$this->dbHandler->setServerStatus('http://server1', TrustedServers::STATUS_OK);
 		$query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable);
 
@@ -214,7 +214,7 @@ 
 		$result = $qResult->fetchAll();
 		$qResult->closeCursor();
 		$this->assertCount(1, $result);
-		$this->assertSame(TrustedServers::STATUS_OK, (int)$result[0]['status']);
+		$this->assertSame(TrustedServers::STATUS_OK, (int) $result[0]['status']);
 	}
 
 	public function testGetServerStatus(): void {

apps/federation/tests/BackgroundJob/GetSharedSecretTest.php

Indentation +226 added lines, -226 removed lines

@@ -33,230 +33,230 @@
  */
 class GetSharedSecretTest extends TestCase {
 
-	private MockObject&IClient $httpClient;
-	private MockObject&IClientService $httpClientService;
-	private MockObject&IJobList $jobList;
-	private MockObject&IURLGenerator $urlGenerator;
-	private MockObject&TrustedServers $trustedServers;
-	private MockObject&LoggerInterface $logger;
-	private MockObject&IResponse $response;
-	private MockObject&IDiscoveryService $discoverService;
-	private MockObject&ITimeFactory $timeFactory;
-	private MockObject&IConfig $config;
-
-	private GetSharedSecret $getSharedSecret;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->httpClientService = $this->createMock(IClientService::class);
-		$this->httpClient = $this->getMockBuilder(IClient::class)->getMock();
-		$this->jobList = $this->getMockBuilder(IJobList::class)->getMock();
-		$this->urlGenerator = $this->getMockBuilder(IURLGenerator::class)->getMock();
-		$this->trustedServers = $this->getMockBuilder(TrustedServers::class)
-			->disableOriginalConstructor()->getMock();
-		$this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
-		$this->response = $this->getMockBuilder(IResponse::class)->getMock();
-		$this->discoverService = $this->getMockBuilder(IDiscoveryService::class)->getMock();
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->discoverService->expects($this->any())->method('discover')->willReturn([]);
-		$this->httpClientService->expects($this->any())->method('newClient')->willReturn($this->httpClient);
-
-		$this->getSharedSecret = new GetSharedSecret(
-			$this->httpClientService,
-			$this->urlGenerator,
-			$this->jobList,
-			$this->trustedServers,
-			$this->logger,
-			$this->discoverService,
-			$this->timeFactory,
-			$this->config,
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestExecute')]
-	public function testExecute(bool $isTrustedServer, bool $retainBackgroundJob): void {
-		/** @var GetSharedSecret&MockObject $getSharedSecret */
-		$getSharedSecret = $this->getMockBuilder(GetSharedSecret::class)
-			->setConstructorArgs(
-				[
-					$this->httpClientService,
-					$this->urlGenerator,
-					$this->jobList,
-					$this->trustedServers,
-					$this->logger,
-					$this->discoverService,
-					$this->timeFactory,
-					$this->config,
-				]
-			)
-			->onlyMethods(['parentStart'])
-			->getMock();
-		self::invokePrivate($getSharedSecret, 'argument', [['url' => 'url', 'token' => 'token']]);
-
-		$this->trustedServers->expects($this->once())->method('isTrustedServer')
-			->with('url')->willReturn($isTrustedServer);
-		if ($isTrustedServer) {
-			$getSharedSecret->expects($this->once())->method('parentStart');
-		} else {
-			$getSharedSecret->expects($this->never())->method('parentStart');
-		}
-		self::invokePrivate($getSharedSecret, 'retainJob', [$retainBackgroundJob]);
-		$this->jobList->expects($this->once())->method('remove');
-
-		$this->timeFactory->method('getTime')->willReturn(42);
-
-		if ($retainBackgroundJob) {
-			$this->jobList->expects($this->once())
-				->method('add')
-				->with(
-					GetSharedSecret::class,
-					[
-						'url' => 'url',
-						'token' => 'token',
-						'created' => 42,
-					]
-				);
-		} else {
-			$this->jobList->expects($this->never())->method('add');
-		}
-
-		$getSharedSecret->start($this->jobList);
-	}
-
-	public static function dataTestExecute(): array {
-		return [
-			[true, true],
-			[true, false],
-			[false, false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
-	public function testRun(int $statusCode): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-
-		$argument = ['url' => $target, 'token' => $token];
-
-		$this->timeFactory->method('getTime')
-			->willReturn(42);
-
-		$this->urlGenerator->expects($this->once())->method('getAbsoluteURL')->with('/')
-			->willReturn($source);
-		$this->httpClient->expects($this->once())->method('get')
-			->with(
-				$target . '/ocs/v2.php/apps/federation/api/v1/shared-secret',
-				[
-					'query' => [
-						'url' => $source,
-						'token' => $token,
-						'format' => 'json',
-					],
-					'timeout' => 3,
-					'connect_timeout' => 3,
-					'verify' => true,
-				]
-			)->willReturn($this->response);
-
-		$this->response->expects($this->once())->method('getStatusCode')
-			->willReturn($statusCode);
-
-		if ($statusCode === Http::STATUS_OK) {
-			$this->response->expects($this->once())->method('getBody')
-				->willReturn('{"ocs":{"data":{"sharedSecret":"secret"}}}');
-			$this->trustedServers->expects($this->once())->method('addSharedSecret')
-				->with($target, 'secret');
-		} else {
-			$this->trustedServers->expects($this->never())->method('addSharedSecret');
-		}
-
-		self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
-		if (
-			$statusCode !== Http::STATUS_OK
-			&& $statusCode !== Http::STATUS_FORBIDDEN
-		) {
-			$this->assertTrue(self::invokePrivate($this->getSharedSecret, 'retainJob'));
-		} else {
-			$this->assertFalse(self::invokePrivate($this->getSharedSecret, 'retainJob'));
-		}
-	}
-
-	public static function dataTestRun(): array {
-		return [
-			[Http::STATUS_OK],
-			[Http::STATUS_FORBIDDEN],
-			[Http::STATUS_CONFLICT],
-		];
-	}
-
-	public function testRunExpired(): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-		$created = 42;
-
-		$argument = [
-			'url' => $target,
-			'token' => $token,
-			'created' => $created,
-		];
-
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('/')
-			->willReturn($source);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($created + 2592000 + 1);
-
-		$this->trustedServers->expects($this->once())
-			->method('setServerStatus')
-			->with(
-				$target,
-				TrustedServers::STATUS_FAILURE
-			);
-
-		self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
-	}
-
-	public function testRunConnectionError(): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-
-		$argument = ['url' => $target, 'token' => $token];
-
-		$this->timeFactory->method('getTime')
-			->willReturn(42);
-
-		$this->urlGenerator
-			->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('/')
-			->willReturn($source);
-		$this->httpClient->expects($this->once())->method('get')
-			->with(
-				$target . '/ocs/v2.php/apps/federation/api/v1/shared-secret',
-				[
-					'query' => [
-						'url' => $source,
-						'token' => $token,
-						'format' => 'json',
-					],
-					'timeout' => 3,
-					'connect_timeout' => 3,
-					'verify' => true,
-				]
-			)->willThrowException($this->createMock(ConnectException::class));
-
-		$this->trustedServers->expects($this->never())->method('addSharedSecret');
-
-		self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
-
-		$this->assertTrue(self::invokePrivate($this->getSharedSecret, 'retainJob'));
-	}
+    private MockObject&IClient $httpClient;
+    private MockObject&IClientService $httpClientService;
+    private MockObject&IJobList $jobList;
+    private MockObject&IURLGenerator $urlGenerator;
+    private MockObject&TrustedServers $trustedServers;
+    private MockObject&LoggerInterface $logger;
+    private MockObject&IResponse $response;
+    private MockObject&IDiscoveryService $discoverService;
+    private MockObject&ITimeFactory $timeFactory;
+    private MockObject&IConfig $config;
+
+    private GetSharedSecret $getSharedSecret;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->httpClientService = $this->createMock(IClientService::class);
+        $this->httpClient = $this->getMockBuilder(IClient::class)->getMock();
+        $this->jobList = $this->getMockBuilder(IJobList::class)->getMock();
+        $this->urlGenerator = $this->getMockBuilder(IURLGenerator::class)->getMock();
+        $this->trustedServers = $this->getMockBuilder(TrustedServers::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
+        $this->response = $this->getMockBuilder(IResponse::class)->getMock();
+        $this->discoverService = $this->getMockBuilder(IDiscoveryService::class)->getMock();
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->discoverService->expects($this->any())->method('discover')->willReturn([]);
+        $this->httpClientService->expects($this->any())->method('newClient')->willReturn($this->httpClient);
+
+        $this->getSharedSecret = new GetSharedSecret(
+            $this->httpClientService,
+            $this->urlGenerator,
+            $this->jobList,
+            $this->trustedServers,
+            $this->logger,
+            $this->discoverService,
+            $this->timeFactory,
+            $this->config,
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestExecute')]
+    public function testExecute(bool $isTrustedServer, bool $retainBackgroundJob): void {
+        /** @var GetSharedSecret&MockObject $getSharedSecret */
+        $getSharedSecret = $this->getMockBuilder(GetSharedSecret::class)
+            ->setConstructorArgs(
+                [
+                    $this->httpClientService,
+                    $this->urlGenerator,
+                    $this->jobList,
+                    $this->trustedServers,
+                    $this->logger,
+                    $this->discoverService,
+                    $this->timeFactory,
+                    $this->config,
+                ]
+            )
+            ->onlyMethods(['parentStart'])
+            ->getMock();
+        self::invokePrivate($getSharedSecret, 'argument', [['url' => 'url', 'token' => 'token']]);
+
+        $this->trustedServers->expects($this->once())->method('isTrustedServer')
+            ->with('url')->willReturn($isTrustedServer);
+        if ($isTrustedServer) {
+            $getSharedSecret->expects($this->once())->method('parentStart');
+        } else {
+            $getSharedSecret->expects($this->never())->method('parentStart');
+        }
+        self::invokePrivate($getSharedSecret, 'retainJob', [$retainBackgroundJob]);
+        $this->jobList->expects($this->once())->method('remove');
+
+        $this->timeFactory->method('getTime')->willReturn(42);
+
+        if ($retainBackgroundJob) {
+            $this->jobList->expects($this->once())
+                ->method('add')
+                ->with(
+                    GetSharedSecret::class,
+                    [
+                        'url' => 'url',
+                        'token' => 'token',
+                        'created' => 42,
+                    ]
+                );
+        } else {
+            $this->jobList->expects($this->never())->method('add');
+        }
+
+        $getSharedSecret->start($this->jobList);
+    }
+
+    public static function dataTestExecute(): array {
+        return [
+            [true, true],
+            [true, false],
+            [false, false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
+    public function testRun(int $statusCode): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+
+        $argument = ['url' => $target, 'token' => $token];
+
+        $this->timeFactory->method('getTime')
+            ->willReturn(42);
+
+        $this->urlGenerator->expects($this->once())->method('getAbsoluteURL')->with('/')
+            ->willReturn($source);
+        $this->httpClient->expects($this->once())->method('get')
+            ->with(
+                $target . '/ocs/v2.php/apps/federation/api/v1/shared-secret',
+                [
+                    'query' => [
+                        'url' => $source,
+                        'token' => $token,
+                        'format' => 'json',
+                    ],
+                    'timeout' => 3,
+                    'connect_timeout' => 3,
+                    'verify' => true,
+                ]
+            )->willReturn($this->response);
+
+        $this->response->expects($this->once())->method('getStatusCode')
+            ->willReturn($statusCode);
+
+        if ($statusCode === Http::STATUS_OK) {
+            $this->response->expects($this->once())->method('getBody')
+                ->willReturn('{"ocs":{"data":{"sharedSecret":"secret"}}}');
+            $this->trustedServers->expects($this->once())->method('addSharedSecret')
+                ->with($target, 'secret');
+        } else {
+            $this->trustedServers->expects($this->never())->method('addSharedSecret');
+        }
+
+        self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
+        if (
+            $statusCode !== Http::STATUS_OK
+            && $statusCode !== Http::STATUS_FORBIDDEN
+        ) {
+            $this->assertTrue(self::invokePrivate($this->getSharedSecret, 'retainJob'));
+        } else {
+            $this->assertFalse(self::invokePrivate($this->getSharedSecret, 'retainJob'));
+        }
+    }
+
+    public static function dataTestRun(): array {
+        return [
+            [Http::STATUS_OK],
+            [Http::STATUS_FORBIDDEN],
+            [Http::STATUS_CONFLICT],
+        ];
+    }
+
+    public function testRunExpired(): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+        $created = 42;
+
+        $argument = [
+            'url' => $target,
+            'token' => $token,
+            'created' => $created,
+        ];
+
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('/')
+            ->willReturn($source);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($created + 2592000 + 1);
+
+        $this->trustedServers->expects($this->once())
+            ->method('setServerStatus')
+            ->with(
+                $target,
+                TrustedServers::STATUS_FAILURE
+            );
+
+        self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
+    }
+
+    public function testRunConnectionError(): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+
+        $argument = ['url' => $target, 'token' => $token];
+
+        $this->timeFactory->method('getTime')
+            ->willReturn(42);
+
+        $this->urlGenerator
+            ->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('/')
+            ->willReturn($source);
+        $this->httpClient->expects($this->once())->method('get')
+            ->with(
+                $target . '/ocs/v2.php/apps/federation/api/v1/shared-secret',
+                [
+                    'query' => [
+                        'url' => $source,
+                        'token' => $token,
+                        'format' => 'json',
+                    ],
+                    'timeout' => 3,
+                    'connect_timeout' => 3,
+                    'verify' => true,
+                ]
+            )->willThrowException($this->createMock(ConnectException::class));
+
+        $this->trustedServers->expects($this->never())->method('addSharedSecret');
+
+        self::invokePrivate($this->getSharedSecret, 'run', [$argument]);
+
+        $this->assertTrue(self::invokePrivate($this->getSharedSecret, 'retainJob'));
+    }
 }

apps/federation/tests/BackgroundJob/RequestSharedSecretTest.php

Indentation +215 added lines, -215 removed lines

@@ -25,219 +25,219 @@
 use Test\TestCase;
 
 class RequestSharedSecretTest extends TestCase {
-	private IClientService&MockObject $httpClientService;
-	private IClient&MockObject $httpClient;
-	private IJobList&MockObject $jobList;
-	private IURLGenerator&MockObject $urlGenerator;
-	private TrustedServers&MockObject $trustedServers;
-	private IResponse&MockObject $response;
-	private IDiscoveryService&MockObject $discoveryService;
-	private LoggerInterface&MockObject $logger;
-	private ITimeFactory&MockObject $timeFactory;
-	private IConfig&MockObject $config;
-	private RequestSharedSecret $requestSharedSecret;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->httpClientService = $this->createMock(IClientService::class);
-		$this->httpClient = $this->createMock(IClient::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->trustedServers = $this->createMock(TrustedServers::class);
-		$this->response = $this->createMock(IResponse::class);
-		$this->discoveryService = $this->createMock(IDiscoveryService::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->discoveryService->expects($this->any())->method('discover')->willReturn([]);
-		$this->httpClientService->expects($this->any())->method('newClient')->willReturn($this->httpClient);
-
-		$this->requestSharedSecret = new RequestSharedSecret(
-			$this->httpClientService,
-			$this->urlGenerator,
-			$this->jobList,
-			$this->trustedServers,
-			$this->discoveryService,
-			$this->logger,
-			$this->timeFactory,
-			$this->config,
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestStart')]
-	public function testStart(bool $isTrustedServer, bool $retainBackgroundJob): void {
-		/** @var RequestSharedSecret&MockObject $requestSharedSecret */
-		$requestSharedSecret = $this->getMockBuilder(RequestSharedSecret::class)
-			->setConstructorArgs(
-				[
-					$this->httpClientService,
-					$this->urlGenerator,
-					$this->jobList,
-					$this->trustedServers,
-					$this->discoveryService,
-					$this->logger,
-					$this->timeFactory,
-					$this->config,
-				]
-			)
-			->onlyMethods(['parentStart'])
-			->getMock();
-		self::invokePrivate($requestSharedSecret, 'argument', [['url' => 'url', 'token' => 'token']]);
-
-		$this->trustedServers->expects($this->once())->method('isTrustedServer')
-			->with('url')->willReturn($isTrustedServer);
-		if ($isTrustedServer) {
-			$requestSharedSecret->expects($this->once())->method('parentStart');
-		} else {
-			$requestSharedSecret->expects($this->never())->method('parentStart');
-		}
-		self::invokePrivate($requestSharedSecret, 'retainJob', [$retainBackgroundJob]);
-		$this->jobList->expects($this->once())->method('remove');
-
-		$this->timeFactory->method('getTime')->willReturn(42);
-
-		if ($retainBackgroundJob) {
-			$this->jobList->expects($this->once())
-				->method('add')
-				->with(
-					RequestSharedSecret::class,
-					[
-						'url' => 'url',
-						'token' => 'token',
-						'created' => 42,
-						'attempt' => 1,
-					]
-				);
-		} else {
-			$this->jobList->expects($this->never())->method('add');
-		}
-
-		$requestSharedSecret->start($this->jobList);
-	}
-
-	public static function dataTestStart(): array {
-		return [
-			[true, true],
-			[true, false],
-			[false, false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
-	public function testRun(int $statusCode, int $attempt = 0): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-
-		$argument = ['url' => $target, 'token' => $token, 'attempt' => $attempt];
-
-		$this->timeFactory->method('getTime')->willReturn(42);
-
-		$this->urlGenerator->expects($this->once())->method('getAbsoluteURL')->with('/')
-			->willReturn($source);
-		$this->httpClient->expects($this->once())->method('post')
-			->with(
-				$target . '/ocs/v2.php/apps/federation/api/v1/request-shared-secret',
-				[
-					'body' => [
-						'url' => $source,
-						'token' => $token,
-						'format' => 'json',
-					],
-					'timeout' => 3,
-					'connect_timeout' => 3,
-					'verify' => true,
-				]
-			)->willReturn($this->response);
-
-		$this->response->expects($this->once())->method('getStatusCode')
-			->willReturn($statusCode);
-
-		self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
-		if (
-			$statusCode !== Http::STATUS_OK
-			&& ($statusCode !== Http::STATUS_FORBIDDEN || $attempt < 5)
-		) {
-			$this->assertTrue(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
-		} else {
-			$this->assertFalse(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
-		}
-	}
-
-	public static function dataTestRun(): array {
-		return [
-			[Http::STATUS_OK],
-			[Http::STATUS_FORBIDDEN, 5],
-			[Http::STATUS_FORBIDDEN],
-			[Http::STATUS_CONFLICT],
-		];
-	}
-
-	public function testRunExpired(): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-		$created = 42;
-
-		$argument = [
-			'url' => $target,
-			'token' => $token,
-			'created' => $created,
-		];
-
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('/')
-			->willReturn($source);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($created + 2592000 + 1);
-
-		$this->trustedServers->expects($this->once())
-			->method('setServerStatus')
-			->with(
-				$target,
-				TrustedServers::STATUS_FAILURE
-			);
-
-		self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
-	}
-
-	public function testRunConnectionError(): void {
-		$target = 'targetURL';
-		$source = 'sourceURL';
-		$token = 'token';
-
-		$argument = ['url' => $target, 'token' => $token];
-
-		$this->timeFactory->method('getTime')->willReturn(42);
-
-		$this->urlGenerator
-			->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('/')
-			->willReturn($source);
-
-		$this->httpClient
-			->expects($this->once())
-			->method('post')
-			->with(
-				$target . '/ocs/v2.php/apps/federation/api/v1/request-shared-secret',
-				[
-					'body' => [
-						'url' => $source,
-						'token' => $token,
-						'format' => 'json',
-					],
-					'timeout' => 3,
-					'connect_timeout' => 3,
-					'verify' => true,
-				]
-			)->willThrowException($this->createMock(ConnectException::class));
-
-		self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
-		$this->assertTrue(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
-	}
+    private IClientService&MockObject $httpClientService;
+    private IClient&MockObject $httpClient;
+    private IJobList&MockObject $jobList;
+    private IURLGenerator&MockObject $urlGenerator;
+    private TrustedServers&MockObject $trustedServers;
+    private IResponse&MockObject $response;
+    private IDiscoveryService&MockObject $discoveryService;
+    private LoggerInterface&MockObject $logger;
+    private ITimeFactory&MockObject $timeFactory;
+    private IConfig&MockObject $config;
+    private RequestSharedSecret $requestSharedSecret;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->httpClientService = $this->createMock(IClientService::class);
+        $this->httpClient = $this->createMock(IClient::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->trustedServers = $this->createMock(TrustedServers::class);
+        $this->response = $this->createMock(IResponse::class);
+        $this->discoveryService = $this->createMock(IDiscoveryService::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->discoveryService->expects($this->any())->method('discover')->willReturn([]);
+        $this->httpClientService->expects($this->any())->method('newClient')->willReturn($this->httpClient);
+
+        $this->requestSharedSecret = new RequestSharedSecret(
+            $this->httpClientService,
+            $this->urlGenerator,
+            $this->jobList,
+            $this->trustedServers,
+            $this->discoveryService,
+            $this->logger,
+            $this->timeFactory,
+            $this->config,
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestStart')]
+    public function testStart(bool $isTrustedServer, bool $retainBackgroundJob): void {
+        /** @var RequestSharedSecret&MockObject $requestSharedSecret */
+        $requestSharedSecret = $this->getMockBuilder(RequestSharedSecret::class)
+            ->setConstructorArgs(
+                [
+                    $this->httpClientService,
+                    $this->urlGenerator,
+                    $this->jobList,
+                    $this->trustedServers,
+                    $this->discoveryService,
+                    $this->logger,
+                    $this->timeFactory,
+                    $this->config,
+                ]
+            )
+            ->onlyMethods(['parentStart'])
+            ->getMock();
+        self::invokePrivate($requestSharedSecret, 'argument', [['url' => 'url', 'token' => 'token']]);
+
+        $this->trustedServers->expects($this->once())->method('isTrustedServer')
+            ->with('url')->willReturn($isTrustedServer);
+        if ($isTrustedServer) {
+            $requestSharedSecret->expects($this->once())->method('parentStart');
+        } else {
+            $requestSharedSecret->expects($this->never())->method('parentStart');
+        }
+        self::invokePrivate($requestSharedSecret, 'retainJob', [$retainBackgroundJob]);
+        $this->jobList->expects($this->once())->method('remove');
+
+        $this->timeFactory->method('getTime')->willReturn(42);
+
+        if ($retainBackgroundJob) {
+            $this->jobList->expects($this->once())
+                ->method('add')
+                ->with(
+                    RequestSharedSecret::class,
+                    [
+                        'url' => 'url',
+                        'token' => 'token',
+                        'created' => 42,
+                        'attempt' => 1,
+                    ]
+                );
+        } else {
+            $this->jobList->expects($this->never())->method('add');
+        }
+
+        $requestSharedSecret->start($this->jobList);
+    }
+
+    public static function dataTestStart(): array {
+        return [
+            [true, true],
+            [true, false],
+            [false, false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
+    public function testRun(int $statusCode, int $attempt = 0): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+
+        $argument = ['url' => $target, 'token' => $token, 'attempt' => $attempt];
+
+        $this->timeFactory->method('getTime')->willReturn(42);
+
+        $this->urlGenerator->expects($this->once())->method('getAbsoluteURL')->with('/')
+            ->willReturn($source);
+        $this->httpClient->expects($this->once())->method('post')
+            ->with(
+                $target . '/ocs/v2.php/apps/federation/api/v1/request-shared-secret',
+                [
+                    'body' => [
+                        'url' => $source,
+                        'token' => $token,
+                        'format' => 'json',
+                    ],
+                    'timeout' => 3,
+                    'connect_timeout' => 3,
+                    'verify' => true,
+                ]
+            )->willReturn($this->response);
+
+        $this->response->expects($this->once())->method('getStatusCode')
+            ->willReturn($statusCode);
+
+        self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
+        if (
+            $statusCode !== Http::STATUS_OK
+            && ($statusCode !== Http::STATUS_FORBIDDEN || $attempt < 5)
+        ) {
+            $this->assertTrue(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
+        } else {
+            $this->assertFalse(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
+        }
+    }
+
+    public static function dataTestRun(): array {
+        return [
+            [Http::STATUS_OK],
+            [Http::STATUS_FORBIDDEN, 5],
+            [Http::STATUS_FORBIDDEN],
+            [Http::STATUS_CONFLICT],
+        ];
+    }
+
+    public function testRunExpired(): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+        $created = 42;
+
+        $argument = [
+            'url' => $target,
+            'token' => $token,
+            'created' => $created,
+        ];
+
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('/')
+            ->willReturn($source);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($created + 2592000 + 1);
+
+        $this->trustedServers->expects($this->once())
+            ->method('setServerStatus')
+            ->with(
+                $target,
+                TrustedServers::STATUS_FAILURE
+            );
+
+        self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
+    }
+
+    public function testRunConnectionError(): void {
+        $target = 'targetURL';
+        $source = 'sourceURL';
+        $token = 'token';
+
+        $argument = ['url' => $target, 'token' => $token];
+
+        $this->timeFactory->method('getTime')->willReturn(42);
+
+        $this->urlGenerator
+            ->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('/')
+            ->willReturn($source);
+
+        $this->httpClient
+            ->expects($this->once())
+            ->method('post')
+            ->with(
+                $target . '/ocs/v2.php/apps/federation/api/v1/request-shared-secret',
+                [
+                    'body' => [
+                        'url' => $source,
+                        'token' => $token,
+                        'format' => 'json',
+                    ],
+                    'timeout' => 3,
+                    'connect_timeout' => 3,
+                    'verify' => true,
+                ]
+            )->willThrowException($this->createMock(ConnectException::class));
+
+        self::invokePrivate($this->requestSharedSecret, 'run', [$argument]);
+        $this->assertTrue(self::invokePrivate($this->requestSharedSecret, 'retainJob'));
+    }
 }

apps/sharebymail/tests/ShareByMailProviderTest.php

Indentation +1847 added lines, -1847 removed lines

@@ -50,1898 +50,1898 @@
  */
 class ShareByMailProviderTest extends TestCase {
 
-	private IDBConnection $connection;
-
-	private IL10N&MockObject $l;
-	private IShare&MockObject $share;
-	private IConfig&MockObject $config;
-	private IMailer&MockObject $mailer;
-	private IHasher&MockObject $hasher;
-	private Defaults&MockObject $defaults;
-	private IManager&MockObject $shareManager;
-	private LoggerInterface&MockObject $logger;
-	private IRootFolder&MockObject $rootFolder;
-	private IUserManager&MockObject $userManager;
-	private ISecureRandom&MockObject $secureRandom;
-	private IURLGenerator&MockObject $urlGenerator;
-	private SettingsManager&MockObject $settingsManager;
-	private IActivityManager&MockObject $activityManager;
-	private IEventDispatcher&MockObject $eventDispatcher;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-
-		$this->l = $this->createMock(IL10N::class);
-		$this->l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->rootFolder = $this->createMock('OCP\Files\IRootFolder');
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->secureRandom = $this->createMock('\OCP\Security\ISecureRandom');
-		$this->mailer = $this->createMock('\OCP\Mail\IMailer');
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->share = $this->createMock(IShare::class);
-		$this->activityManager = $this->createMock('OCP\Activity\IManager');
-		$this->settingsManager = $this->createMock(SettingsManager::class);
-		$this->defaults = $this->createMock(Defaults::class);
-		$this->hasher = $this->createMock(IHasher::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$this->shareManager = $this->createMock(IManager::class);
-
-		$this->userManager->expects($this->any())->method('userExists')->willReturn(true);
-		$this->config->expects($this->any())->method('getAppValue')->with('core', 'enforce_strict_email_check')->willReturn('yes');
-	}
-
-	/**
-	 * get instance of Mocked ShareByMailProvider
-	 *
-	 * @param array $mockedMethods internal methods which should be mocked
-	 * @return \PHPUnit\Framework\MockObject\MockObject | ShareByMailProvider
-	 */
-	private function getInstance(array $mockedMethods = []) {
-		if (!empty($mockedMethods)) {
-			return $this->getMockBuilder(ShareByMailProvider::class)
-				->setConstructorArgs([
-					$this->config,
-					$this->connection,
-					$this->secureRandom,
-					$this->userManager,
-					$this->rootFolder,
-					$this->l,
-					$this->logger,
-					$this->mailer,
-					$this->urlGenerator,
-					$this->activityManager,
-					$this->settingsManager,
-					$this->defaults,
-					$this->hasher,
-					$this->eventDispatcher,
-					$this->shareManager,
-				])
-				->onlyMethods($mockedMethods)
-				->getMock();
-		}
-
-		return new ShareByMailProvider(
-			$this->config,
-			$this->connection,
-			$this->secureRandom,
-			$this->userManager,
-			$this->rootFolder,
-			$this->l,
-			$this->logger,
-			$this->mailer,
-			$this->urlGenerator,
-			$this->activityManager,
-			$this->settingsManager,
-			$this->defaults,
-			$this->hasher,
-			$this->eventDispatcher,
-			$this->shareManager,
-		);
-	}
-
-	protected function tearDown(): void {
-		$this->connection
-			->getQueryBuilder()
-			->delete('share')
-			->executeStatement();
-
-		parent::tearDown();
-	}
-
-	public function testCreate(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('user1');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'sendEmail', 'sendPassword']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare'])->willReturn($expectedShare);
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-
-		// As share api link password is not enforced, the password will not be generated.
-		$this->shareManager->expects($this->once())->method('shareApiLinkEnforcePassword')->willReturn(false);
-		$this->settingsManager->expects($this->never())->method('sendPasswordByMail');
-
-		// Mail notification is triggered by the share manager.
-		$instance->expects($this->never())->method('sendEmail');
-		$instance->expects($this->never())->method('sendPassword');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-	}
-
-	public function testCreateSendPasswordByMailWithoutEnforcedPasswordProtection(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@examplelölöl.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare'])->willReturn($expectedShare);
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-
-		// The autogenerated password should not be mailed.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
-		$this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
-		$instance->expects($this->never())->method('autoGeneratePassword');
-
-		// No password is set and no password sent via talk is requested
-		$instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@examplelölöl.com']);
-		$instance->expects($this->never())->method('sendPassword');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-		// The manager sends the mail notification.
-		// For the sake of testing simplicity, we will handle it ourselves.
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateSendPasswordByMailWithPasswordAndWithoutEnforcedPasswordProtectionWithPermanentPassword(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-
-		$share->expects($this->any())->method('getPassword')->willReturn('password');
-		$this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
-		$share->expects($this->once())->method('setPassword')->with('passwordHashed');
-
-		// The given password (but not the autogenerated password) should not be
-		// mailed to the receiver of the share because permanent passwords are not enforced.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
-		$this->config->expects($this->once())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
-		$instance->expects($this->never())->method('autoGeneratePassword');
-
-		// A password is set but no password sent via talk has been requested
-		$instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@example.com']);
-		$instance->expects($this->once())->method('sendPassword')->with($share, 'password');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateSendPasswordByMailWithPasswordAndWithoutEnforcedPasswordProtectionWithoutPermanentPassword(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance([
-			'getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject',
-			'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity',
-			'sendEmail', 'sendPassword', 'sendPasswordToOwner',
-		]);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-
-		$share->expects($this->any())->method('getPassword')->willReturn('password');
-		$this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
-		$share->expects($this->once())->method('setPassword')->with('passwordHashed');
-
-		// No password is generated, so no emails need to be sent
-		// aside from the main email notification.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
-		$instance->expects($this->never())->method('autoGeneratePassword');
-		$this->config->expects($this->once())->method('getSystemValue')
-			->with('sharing.enable_mail_link_password_expiration')
-			->willReturn(true);
-
-		// No password has been set and no password sent via talk has been requested,
-		// but password has been enforced for the whole instance and will be generated.
-		$instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@example.com']);
-		$instance->expects($this->never())->method('sendPassword');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateSendPasswordByMailWithEnforcedPasswordProtectionWithPermanentPassword(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$this->secureRandom->expects($this->once())
-			->method('generate')
-			->with(8, ISecureRandom::CHAR_HUMAN_READABLE)
-			->willReturn('autogeneratedPassword');
-		$this->eventDispatcher->expects($this->once())
-			->method('dispatchTyped')
-			->with(new GenerateSecurePasswordEvent(PasswordContext::SHARING));
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'createPasswordSendActivity', 'sendPasswordToOwner']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'autogeneratedPassword']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'autogeneratedPassword'])->willReturn($expectedShare);
-
-		// Initially not set, but will be set by the autoGeneratePassword method.
-		$share->expects($this->exactly(3))->method('getPassword')->willReturnOnConsecutiveCalls(null, 'autogeneratedPassword', 'autogeneratedPassword');
-		$this->hasher->expects($this->once())->method('hash')->with('autogeneratedPassword')->willReturn('autogeneratedPasswordHashed');
-		$share->expects($this->once())->method('setPassword')->with('autogeneratedPasswordHashed');
-
-		// The autogenerated password should be mailed to the receiver of the share because permanent passwords are enforced.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
-		$this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
-		$this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
-
-		$message = $this->createMock(IMessage::class);
-		$message->expects($this->exactly(2))->method('setTo')->with(['receiver@example.com']);
-		$this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
-		$calls = [
-			[
-				'sharebymail.RecipientNotification',
-				[
-					'filename' => 'filename',
-					'link' => 'https://example.com/file.txt',
-					'initiator' => 'owner',
-					'expiration' => null,
-					'shareWith' => 'receiver@example.com',
-					'note' => '',
-				],
-			],
-			[
-				'sharebymail.RecipientPasswordNotification',
-				[
-					'filename' => 'filename',
-					'password' => 'autogeneratedPassword',
-					'initiator' => 'owner',
-					'initiatorEmail' => null,
-					'shareWith' => 'receiver@example.com',
-				],
-			],
-		];
-		$this->mailer->expects($this->exactly(2))
-			->method('createEMailTemplate')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return $this->createMock(IEMailTemplate::class);
-			});
-
-		// Main email notification is sent as well as the password
-		// to the recipient because shareApiLinkEnforcePassword is enabled.
-		$this->mailer->expects($this->exactly(2))->method('send');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateSendPasswordByMailWithPasswordAndWithEnforcedPasswordProtectionWithPermanentPassword(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendPasswordToOwner']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
-
-		$share->expects($this->exactly(3))->method('getPassword')->willReturn('password');
-		$this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
-		$share->expects($this->once())->method('setPassword')->with('passwordHashed');
-
-		// The given password (but not the autogenerated password) should be
-		// mailed to the receiver of the share.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
-		$this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
-		$this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
-		$instance->expects($this->never())->method('autoGeneratePassword');
-
-		$message = $this->createMock(IMessage::class);
-		$message->expects($this->exactly(2))->method('setTo')->with(['receiver@example.com']);
-		$this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
-
-		$calls = [
-			[
-				'sharebymail.RecipientNotification',
-				[
-					'filename' => 'filename',
-					'link' => 'https://example.com/file.txt',
-					'initiator' => 'owner',
-					'expiration' => null,
-					'shareWith' => 'receiver@example.com',
-					'note' => '',
-				],
-			],
-			[
-				'sharebymail.RecipientPasswordNotification',
-				[
-					'filename' => 'filename',
-					'password' => 'password',
-					'initiator' => 'owner',
-					'initiatorEmail' => null,
-					'shareWith' => 'receiver@example.com',
-				],
-			],
-		];
-		$this->mailer->expects($this->exactly(2))
-			->method('createEMailTemplate')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return $this->createMock(IEMailTemplate::class);
-			});
-
-		// Main email notification is sent as well as the password
-		// to the recipient because the password is set.
-		$this->mailer->expects($this->exactly(2))->method('send');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateSendPasswordByTalkWithEnforcedPasswordProtectionWithPermanentPassword(): void {
-		$expectedShare = $this->createMock(IShare::class);
-
-		// The owner of the share.
-		$owner = $this->createMock(IUser::class);
-		$this->userManager->expects($this->any())->method('get')->with('owner')->willReturn($owner);
-		$owner->expects($this->any())->method('getEMailAddress')->willReturn('owner@example.com');
-		$owner->expects($this->any())->method('getDisplayName')->willReturn('owner');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(true);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'autogeneratedPassword']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'autogeneratedPassword'])->willReturn($expectedShare);
-
-		$share->expects($this->exactly(4))->method('getPassword')->willReturnOnConsecutiveCalls(null, 'autogeneratedPassword', 'autogeneratedPassword', 'autogeneratedPassword');
-		$this->hasher->expects($this->once())->method('hash')->with('autogeneratedPassword')->willReturn('autogeneratedPasswordHashed');
-		$share->expects($this->once())->method('setPassword')->with('autogeneratedPasswordHashed');
-
-		// The autogenerated password should be mailed to the owner of the share.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
-		$this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
-		$this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
-		$instance->expects($this->once())->method('autoGeneratePassword')->with($share)->willReturn('autogeneratedPassword');
-
-		$message = $this->createMock(IMessage::class);
-		$setToCalls = [
-			[['receiver@example.com']],
-			[['owner@example.com' => 'owner']],
-		];
-		$message->expects($this->exactly(2))
-			->method('setTo')
-			->willReturnCallback(function () use (&$setToCalls, $message) {
-				$expected = array_shift($setToCalls);
-				$this->assertEquals($expected, func_get_args());
-				return $message;
-			});
-		$this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
-
-		$calls = [
-			[
-				'sharebymail.RecipientNotification',
-				[
-					'filename' => 'filename',
-					'link' => 'https://example.com/file.txt',
-					'initiator' => 'owner',
-					'expiration' => null,
-					'shareWith' => 'receiver@example.com',
-					'note' => '',
-				],
-			],
-			[
-				'sharebymail.OwnerPasswordNotification',
-				[
-					'filename' => 'filename',
-					'password' => 'autogeneratedPassword',
-					'initiator' => 'owner',
-					'initiatorEmail' => 'owner@example.com',
-					'shareWith' => 'receiver@example.com',
-				],
-			],
-		];
-		$this->mailer->expects($this->exactly(2))
-			->method('createEMailTemplate')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return $this->createMock(IEMailTemplate::class);
-			});
-
-		// Main email notification is sent as well as the password to owner
-		// because the password is set and SendPasswordByTalk is enabled.
-		$this->mailer->expects($this->exactly(2))->method('send');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	// If attributes is set to multiple emails, use them as BCC
-	public function sendNotificationToMultipleEmails() {
-		$expectedShare = $this->createMock(IShare::class);
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('');
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('owner');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		$attributes = $this->createMock(IAttributes::class);
-		$share->expects($this->any())->method('getAttributes')->willReturn($attributes);
-		$attributes->expects($this->any())->method('getAttribute')->with('shareWith', 'emails')->willReturn([
-			'receiver1@example.com',
-			'receiver2@example.com',
-			'receiver3@example.com',
-		]);
-
-		// Assume the mail address is valid.
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn([]);
-		$instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($share);
-		$instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
-		$instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-
-		$share->expects($this->any())->method('getPassword')->willReturn('password');
-		$this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
-		$share->expects($this->once())->method('setPassword')->with('passwordHashed');
-
-		// The given password (but not the autogenerated password) should not be
-		// mailed to the receiver of the share because permanent passwords are not enforced.
-		$this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
-		$this->config->expects($this->once())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
-		$instance->expects($this->never())->method('autoGeneratePassword');
-
-		// A password is set but no password sent via talk has been requested
-		$instance->expects($this->once())->method('sendEmail')
-			->with($share, ['receiver1@example.com', 'receiver2@example.com', 'receiver3@example.com']);
-		$instance->expects($this->once())->method('sendPassword')->with($share, 'password');
-		$instance->expects($this->never())->method('sendPasswordToOwner');
-
-
-		$message = $this->createMock(IMessage::class);
-		$message->expects($this->never())->method('setTo');
-		$message->expects($this->exactly(2))->method('setBcc')->with(['receiver1@example.com', 'receiver2@example.com', 'receiver3@example.com']);
-		$this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
-
-		// Main email notification is sent as well as the password
-		// to recipients because the password is set.
-		$this->mailer->expects($this->exactly(2))->method('send');
-
-		$this->assertSame($expectedShare, $instance->create($share));
-		$instance->sendMailNotification($share);
-	}
-
-	public function testCreateFailed(): void {
-		$this->expectException(\Exception::class);
-
-		$this->share->expects($this->once())->method('getSharedWith')->willReturn('user1');
-		$node = $this->createMock('OCP\Files\Node');
-		$node->expects($this->any())->method('getName')->willReturn('fileName');
-		$this->share->expects($this->any())->method('getNode')->willReturn($node);
-
-		$instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject']);
-
-		$instance->expects($this->once())->method('getSharedWith')->willReturn(['found']);
-		$instance->expects($this->never())->method('createMailShare');
-		$instance->expects($this->never())->method('getRawShare');
-		$instance->expects($this->never())->method('createShareObject');
-
-		$this->assertSame('shareObject',
-			$instance->create($this->share)
-		);
-	}
-
-	public function testCreateMailShare(): void {
-		$this->share->expects($this->any())->method('getToken')->willReturn('token');
-		$this->share->expects($this->once())->method('setToken')->with('token');
-		$this->share->expects($this->any())->method('getSharedBy')->willReturn('validby@valid.com');
-		$this->share->expects($this->any())->method('getSharedWith')->willReturn('validwith@valid.com');
-		$this->share->expects($this->any())->method('getNote')->willReturn('Check this!');
-		$this->share->expects($this->any())->method('getMailSend')->willReturn(true);
-
-		$node = $this->createMock('OCP\Files\Node');
-		$node->expects($this->any())->method('getName')->willReturn('fileName');
-		$this->share->expects($this->any())->method('getNode')->willReturn($node);
-
-		$instance = $this->getInstance(['generateToken', 'addShareToDB', 'sendMailNotification']);
-
-		$instance->expects($this->once())->method('generateToken')->willReturn('token');
-		$instance->expects($this->once())->method('addShareToDB')->willReturn(42);
-
-		// The manager handle the mail sending
-		$instance->expects($this->never())->method('sendMailNotification');
-
-		$this->assertSame(42,
-			$this->invokePrivate($instance, 'createMailShare', [$this->share])
-		);
-	}
-
-	public function testGenerateToken(): void {
-		$instance = $this->getInstance();
-
-		$this->secureRandom->expects($this->once())->method('generate')->willReturn('token');
-
-		$this->assertSame('token',
-			$this->invokePrivate($instance, 'generateToken')
-		);
-	}
-
-	public function testAddShareToDB(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-		$password = 'password';
-		$sendPasswordByTalk = true;
-		$hideDownload = true;
-		$label = 'label';
-		$expiration = new \DateTime();
-		$passwordExpirationTime = new \DateTime();
-
-
-		$instance = $this->getInstance();
-		$id = $this->invokePrivate(
-			$instance,
-			'addShareToDB',
-			[
-				$itemSource,
-				$itemType,
-				$shareWith,
-				$sharedBy,
-				$uidOwner,
-				$permissions,
-				$token,
-				$password,
-				$passwordExpirationTime,
-				$sendPasswordByTalk,
-				$hideDownload,
-				$label,
-				$expiration
-			]
-		);
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($id)));
-
-		$qResult = $qb->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-
-		$this->assertSame($itemSource, (int)$result[0]['item_source']);
-		$this->assertSame($itemType, $result[0]['item_type']);
-		$this->assertSame($shareWith, $result[0]['share_with']);
-		$this->assertSame($sharedBy, $result[0]['uid_initiator']);
-		$this->assertSame($uidOwner, $result[0]['uid_owner']);
-		$this->assertSame($permissions, (int)$result[0]['permissions']);
-		$this->assertSame($token, $result[0]['token']);
-		$this->assertSame($password, $result[0]['password']);
-		$this->assertSame($passwordExpirationTime->getTimestamp(), \DateTime::createFromFormat('Y-m-d H:i:s', $result[0]['password_expiration_time'])->getTimestamp());
-		$this->assertSame($sendPasswordByTalk, (bool)$result[0]['password_by_talk']);
-		$this->assertSame($hideDownload, (bool)$result[0]['hide_download']);
-		$this->assertSame($label, $result[0]['label']);
-		$this->assertSame($expiration->getTimestamp(), \DateTime::createFromFormat('Y-m-d H:i:s', $result[0]['expiration'])->getTimestamp());
-	}
-
-	public function testUpdate(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-		$note = 'personal note';
-
-
-		$instance = $this->getInstance();
-
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $note);
-
-		$this->share->expects($this->once())->method('getPermissions')->willReturn($permissions + 1);
-		$this->share->expects($this->once())->method('getShareOwner')->willReturn($uidOwner);
-		$this->share->expects($this->once())->method('getSharedBy')->willReturn($sharedBy);
-		$this->share->expects($this->any())->method('getNote')->willReturn($note);
-		$this->share->expects($this->atLeastOnce())->method('getId')->willReturn($id);
-		$this->share->expects($this->atLeastOnce())->method('getNodeId')->willReturn($itemSource);
-		$this->share->expects($this->once())->method('getSharedWith')->willReturn($shareWith);
-
-		$this->assertSame($this->share,
-			$instance->update($this->share)
-		);
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($id)));
-
-		$qResult = $qb->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-
-		$this->assertSame($itemSource, (int)$result[0]['item_source']);
-		$this->assertSame($itemType, $result[0]['item_type']);
-		$this->assertSame($shareWith, $result[0]['share_with']);
-		$this->assertSame($sharedBy, $result[0]['uid_initiator']);
-		$this->assertSame($uidOwner, $result[0]['uid_owner']);
-		$this->assertSame($permissions + 1, (int)$result[0]['permissions']);
-		$this->assertSame($token, $result[0]['token']);
-		$this->assertSame($note, $result[0]['note']);
-	}
-
-	public static function dataUpdateSendPassword(): array {
-		return [
-			['password', 'hashed', 'hashed new', false, false, true],
-			['', 'hashed', 'hashed new', false, false, false],
-			[null, 'hashed', 'hashed new', false, false, false],
-			['password', 'hashed', 'hashed', false, false, false],
-			['password', 'hashed', 'hashed new', false, true, false],
-			['password', 'hashed', 'hashed new', true, false, true],
-			['password', 'hashed', 'hashed', true, false, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateSendPassword')]
-	public function testUpdateSendPassword(?string $plainTextPassword, string $originalPassword, string $newPassword, bool $originalSendPasswordByTalk, bool $newSendPasswordByTalk, bool $sendMail): void {
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('filename');
-
-		$this->settingsManager->method('sendPasswordByMail')->willReturn(true);
-
-		$originalShare = $this->createMock(IShare::class);
-		$originalShare->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$originalShare->expects($this->any())->method('getNode')->willReturn($node);
-		$originalShare->expects($this->any())->method('getId')->willReturn(42);
-		$originalShare->expects($this->any())->method('getPassword')->willReturn($originalPassword);
-		$originalShare->expects($this->any())->method('getSendPasswordByTalk')->willReturn($originalSendPasswordByTalk);
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getPassword')->willReturn($newPassword);
-		$share->expects($this->any())->method('getSendPasswordByTalk')->willReturn($newSendPasswordByTalk);
-
-		if ($sendMail) {
-			$this->mailer->expects($this->once())->method('createEMailTemplate')->with('sharebymail.RecipientPasswordNotification', [
-				'filename' => 'filename',
-				'password' => $plainTextPassword,
-				'initiator' => null,
-				'initiatorEmail' => null,
-				'shareWith' => 'receiver@example.com',
-			]);
-			$this->mailer->expects($this->once())->method('send');
-		} else {
-			$this->mailer->expects($this->never())->method('send');
-		}
-
-		$instance = $this->getInstance(['getShareById', 'createPasswordSendActivity']);
-		$instance->expects($this->once())->method('getShareById')->willReturn($originalShare);
-
-		$this->assertSame($share,
-			$instance->update($share, $plainTextPassword)
-		);
-	}
-
-	public function testDelete(): void {
-		$instance = $this->getInstance(['removeShareFromTable', 'createShareActivity']);
-		$this->share->expects($this->once())->method('getId')->willReturn(42);
-		$instance->expects($this->once())->method('removeShareFromTable')->with(42);
-		$instance->expects($this->once())->method('createShareActivity')->with($this->share, 'unshare');
-		$instance->delete($this->share);
-	}
-
-	public function testGetShareById(): void {
-		$instance = $this->getInstance(['createShareObject']);
-
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-
-		$this->createDummyShare($itemType, $itemSource, $shareWith, 'user1wrong', 'user2wrong', $permissions, $token);
-		$id2 = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-
-		$instance->expects($this->once())->method('createShareObject')
-			->willReturnCallback(
-				function ($data) use ($uidOwner, $sharedBy, $id2) {
-					$this->assertSame($uidOwner, $data['uid_owner']);
-					$this->assertSame($sharedBy, $data['uid_initiator']);
-					$this->assertSame($id2, (int)$data['id']);
-					return $this->share;
-				}
-			);
-
-		$result = $instance->getShareById($id2);
-
-		$this->assertInstanceOf('OCP\Share\IShare', $result);
-	}
-
-
-	public function testGetShareByIdFailed(): void {
-		$this->expectException(ShareNotFound::class);
-
-		$instance = $this->getInstance(['createShareObject']);
-
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-
-		$instance->getShareById($id + 1);
-	}
-
-	public function testGetShareByPath(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->once())->method('getId')->willReturn($itemSource);
-
-
-		$instance = $this->getInstance(['createShareObject']);
-
-		$this->createDummyShare($itemType, 111, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-
-		$instance->expects($this->once())->method('createShareObject')
-			->willReturnCallback(
-				function ($data) use ($uidOwner, $sharedBy, $id) {
-					$this->assertSame($uidOwner, $data['uid_owner']);
-					$this->assertSame($sharedBy, $data['uid_initiator']);
-					$this->assertSame($id, (int)$data['id']);
-					return $this->share;
-				}
-			);
-
-		$result = $instance->getSharesByPath($node);
-
-		$this->assertTrue(is_array($result));
-		$this->assertSame(1, count($result));
-		$this->assertInstanceOf('OCP\Share\IShare', $result[0]);
-	}
-
-	public function testGetShareByToken(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
+    private IDBConnection $connection;
+
+    private IL10N&MockObject $l;
+    private IShare&MockObject $share;
+    private IConfig&MockObject $config;
+    private IMailer&MockObject $mailer;
+    private IHasher&MockObject $hasher;
+    private Defaults&MockObject $defaults;
+    private IManager&MockObject $shareManager;
+    private LoggerInterface&MockObject $logger;
+    private IRootFolder&MockObject $rootFolder;
+    private IUserManager&MockObject $userManager;
+    private ISecureRandom&MockObject $secureRandom;
+    private IURLGenerator&MockObject $urlGenerator;
+    private SettingsManager&MockObject $settingsManager;
+    private IActivityManager&MockObject $activityManager;
+    private IEventDispatcher&MockObject $eventDispatcher;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+
+        $this->l = $this->createMock(IL10N::class);
+        $this->l->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->rootFolder = $this->createMock('OCP\Files\IRootFolder');
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->secureRandom = $this->createMock('\OCP\Security\ISecureRandom');
+        $this->mailer = $this->createMock('\OCP\Mail\IMailer');
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->share = $this->createMock(IShare::class);
+        $this->activityManager = $this->createMock('OCP\Activity\IManager');
+        $this->settingsManager = $this->createMock(SettingsManager::class);
+        $this->defaults = $this->createMock(Defaults::class);
+        $this->hasher = $this->createMock(IHasher::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->shareManager = $this->createMock(IManager::class);
+
+        $this->userManager->expects($this->any())->method('userExists')->willReturn(true);
+        $this->config->expects($this->any())->method('getAppValue')->with('core', 'enforce_strict_email_check')->willReturn('yes');
+    }
+
+    /**
+     * get instance of Mocked ShareByMailProvider
+     *
+     * @param array $mockedMethods internal methods which should be mocked
+     * @return \PHPUnit\Framework\MockObject\MockObject | ShareByMailProvider
+     */
+    private function getInstance(array $mockedMethods = []) {
+        if (!empty($mockedMethods)) {
+            return $this->getMockBuilder(ShareByMailProvider::class)
+                ->setConstructorArgs([
+                    $this->config,
+                    $this->connection,
+                    $this->secureRandom,
+                    $this->userManager,
+                    $this->rootFolder,
+                    $this->l,
+                    $this->logger,
+                    $this->mailer,
+                    $this->urlGenerator,
+                    $this->activityManager,
+                    $this->settingsManager,
+                    $this->defaults,
+                    $this->hasher,
+                    $this->eventDispatcher,
+                    $this->shareManager,
+                ])
+                ->onlyMethods($mockedMethods)
+                ->getMock();
+        }
+
+        return new ShareByMailProvider(
+            $this->config,
+            $this->connection,
+            $this->secureRandom,
+            $this->userManager,
+            $this->rootFolder,
+            $this->l,
+            $this->logger,
+            $this->mailer,
+            $this->urlGenerator,
+            $this->activityManager,
+            $this->settingsManager,
+            $this->defaults,
+            $this->hasher,
+            $this->eventDispatcher,
+            $this->shareManager,
+        );
+    }
+
+    protected function tearDown(): void {
+        $this->connection
+            ->getQueryBuilder()
+            ->delete('share')
+            ->executeStatement();
+
+        parent::tearDown();
+    }
+
+    public function testCreate(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('user1');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'sendEmail', 'sendPassword']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare'])->willReturn($expectedShare);
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+
+        // As share api link password is not enforced, the password will not be generated.
+        $this->shareManager->expects($this->once())->method('shareApiLinkEnforcePassword')->willReturn(false);
+        $this->settingsManager->expects($this->never())->method('sendPasswordByMail');
+
+        // Mail notification is triggered by the share manager.
+        $instance->expects($this->never())->method('sendEmail');
+        $instance->expects($this->never())->method('sendPassword');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+    }
+
+    public function testCreateSendPasswordByMailWithoutEnforcedPasswordProtection(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@examplelölöl.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare'])->willReturn($expectedShare);
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+
+        // The autogenerated password should not be mailed.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
+        $this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
+        $instance->expects($this->never())->method('autoGeneratePassword');
+
+        // No password is set and no password sent via talk is requested
+        $instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@examplelölöl.com']);
+        $instance->expects($this->never())->method('sendPassword');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+        // The manager sends the mail notification.
+        // For the sake of testing simplicity, we will handle it ourselves.
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateSendPasswordByMailWithPasswordAndWithoutEnforcedPasswordProtectionWithPermanentPassword(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+
+        $share->expects($this->any())->method('getPassword')->willReturn('password');
+        $this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
+        $share->expects($this->once())->method('setPassword')->with('passwordHashed');
+
+        // The given password (but not the autogenerated password) should not be
+        // mailed to the receiver of the share because permanent passwords are not enforced.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
+        $this->config->expects($this->once())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
+        $instance->expects($this->never())->method('autoGeneratePassword');
+
+        // A password is set but no password sent via talk has been requested
+        $instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@example.com']);
+        $instance->expects($this->once())->method('sendPassword')->with($share, 'password');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateSendPasswordByMailWithPasswordAndWithoutEnforcedPasswordProtectionWithoutPermanentPassword(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance([
+            'getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject',
+            'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity',
+            'sendEmail', 'sendPassword', 'sendPasswordToOwner',
+        ]);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+
+        $share->expects($this->any())->method('getPassword')->willReturn('password');
+        $this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
+        $share->expects($this->once())->method('setPassword')->with('passwordHashed');
+
+        // No password is generated, so no emails need to be sent
+        // aside from the main email notification.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
+        $instance->expects($this->never())->method('autoGeneratePassword');
+        $this->config->expects($this->once())->method('getSystemValue')
+            ->with('sharing.enable_mail_link_password_expiration')
+            ->willReturn(true);
+
+        // No password has been set and no password sent via talk has been requested,
+        // but password has been enforced for the whole instance and will be generated.
+        $instance->expects($this->once())->method('sendEmail')->with($share, ['receiver@example.com']);
+        $instance->expects($this->never())->method('sendPassword');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateSendPasswordByMailWithEnforcedPasswordProtectionWithPermanentPassword(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $this->secureRandom->expects($this->once())
+            ->method('generate')
+            ->with(8, ISecureRandom::CHAR_HUMAN_READABLE)
+            ->willReturn('autogeneratedPassword');
+        $this->eventDispatcher->expects($this->once())
+            ->method('dispatchTyped')
+            ->with(new GenerateSecurePasswordEvent(PasswordContext::SHARING));
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'createPasswordSendActivity', 'sendPasswordToOwner']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'autogeneratedPassword']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'autogeneratedPassword'])->willReturn($expectedShare);
+
+        // Initially not set, but will be set by the autoGeneratePassword method.
+        $share->expects($this->exactly(3))->method('getPassword')->willReturnOnConsecutiveCalls(null, 'autogeneratedPassword', 'autogeneratedPassword');
+        $this->hasher->expects($this->once())->method('hash')->with('autogeneratedPassword')->willReturn('autogeneratedPasswordHashed');
+        $share->expects($this->once())->method('setPassword')->with('autogeneratedPasswordHashed');
+
+        // The autogenerated password should be mailed to the receiver of the share because permanent passwords are enforced.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
+        $this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
+        $this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
+
+        $message = $this->createMock(IMessage::class);
+        $message->expects($this->exactly(2))->method('setTo')->with(['receiver@example.com']);
+        $this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
+        $calls = [
+            [
+                'sharebymail.RecipientNotification',
+                [
+                    'filename' => 'filename',
+                    'link' => 'https://example.com/file.txt',
+                    'initiator' => 'owner',
+                    'expiration' => null,
+                    'shareWith' => 'receiver@example.com',
+                    'note' => '',
+                ],
+            ],
+            [
+                'sharebymail.RecipientPasswordNotification',
+                [
+                    'filename' => 'filename',
+                    'password' => 'autogeneratedPassword',
+                    'initiator' => 'owner',
+                    'initiatorEmail' => null,
+                    'shareWith' => 'receiver@example.com',
+                ],
+            ],
+        ];
+        $this->mailer->expects($this->exactly(2))
+            ->method('createEMailTemplate')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return $this->createMock(IEMailTemplate::class);
+            });
+
+        // Main email notification is sent as well as the password
+        // to the recipient because shareApiLinkEnforcePassword is enabled.
+        $this->mailer->expects($this->exactly(2))->method('send');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateSendPasswordByMailWithPasswordAndWithEnforcedPasswordProtectionWithPermanentPassword(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendPasswordToOwner']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
+
+        $share->expects($this->exactly(3))->method('getPassword')->willReturn('password');
+        $this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
+        $share->expects($this->once())->method('setPassword')->with('passwordHashed');
+
+        // The given password (but not the autogenerated password) should be
+        // mailed to the receiver of the share.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
+        $this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
+        $this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
+        $instance->expects($this->never())->method('autoGeneratePassword');
+
+        $message = $this->createMock(IMessage::class);
+        $message->expects($this->exactly(2))->method('setTo')->with(['receiver@example.com']);
+        $this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
+
+        $calls = [
+            [
+                'sharebymail.RecipientNotification',
+                [
+                    'filename' => 'filename',
+                    'link' => 'https://example.com/file.txt',
+                    'initiator' => 'owner',
+                    'expiration' => null,
+                    'shareWith' => 'receiver@example.com',
+                    'note' => '',
+                ],
+            ],
+            [
+                'sharebymail.RecipientPasswordNotification',
+                [
+                    'filename' => 'filename',
+                    'password' => 'password',
+                    'initiator' => 'owner',
+                    'initiatorEmail' => null,
+                    'shareWith' => 'receiver@example.com',
+                ],
+            ],
+        ];
+        $this->mailer->expects($this->exactly(2))
+            ->method('createEMailTemplate')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return $this->createMock(IEMailTemplate::class);
+            });
+
+        // Main email notification is sent as well as the password
+        // to the recipient because the password is set.
+        $this->mailer->expects($this->exactly(2))->method('send');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateSendPasswordByTalkWithEnforcedPasswordProtectionWithPermanentPassword(): void {
+        $expectedShare = $this->createMock(IShare::class);
+
+        // The owner of the share.
+        $owner = $this->createMock(IUser::class);
+        $this->userManager->expects($this->any())->method('get')->with('owner')->willReturn($owner);
+        $owner->expects($this->any())->method('getEMailAddress')->willReturn('owner@example.com');
+        $owner->expects($this->any())->method('getDisplayName')->willReturn('owner');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(true);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'autogeneratedPassword']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'autogeneratedPassword'])->willReturn($expectedShare);
+
+        $share->expects($this->exactly(4))->method('getPassword')->willReturnOnConsecutiveCalls(null, 'autogeneratedPassword', 'autogeneratedPassword', 'autogeneratedPassword');
+        $this->hasher->expects($this->once())->method('hash')->with('autogeneratedPassword')->willReturn('autogeneratedPasswordHashed');
+        $share->expects($this->once())->method('setPassword')->with('autogeneratedPasswordHashed');
+
+        // The autogenerated password should be mailed to the owner of the share.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(true);
+        $this->config->expects($this->any())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
+        $this->settingsManager->expects($this->any())->method('sendPasswordByMail')->willReturn(true);
+        $instance->expects($this->once())->method('autoGeneratePassword')->with($share)->willReturn('autogeneratedPassword');
+
+        $message = $this->createMock(IMessage::class);
+        $setToCalls = [
+            [['receiver@example.com']],
+            [['owner@example.com' => 'owner']],
+        ];
+        $message->expects($this->exactly(2))
+            ->method('setTo')
+            ->willReturnCallback(function () use (&$setToCalls, $message) {
+                $expected = array_shift($setToCalls);
+                $this->assertEquals($expected, func_get_args());
+                return $message;
+            });
+        $this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
+
+        $calls = [
+            [
+                'sharebymail.RecipientNotification',
+                [
+                    'filename' => 'filename',
+                    'link' => 'https://example.com/file.txt',
+                    'initiator' => 'owner',
+                    'expiration' => null,
+                    'shareWith' => 'receiver@example.com',
+                    'note' => '',
+                ],
+            ],
+            [
+                'sharebymail.OwnerPasswordNotification',
+                [
+                    'filename' => 'filename',
+                    'password' => 'autogeneratedPassword',
+                    'initiator' => 'owner',
+                    'initiatorEmail' => 'owner@example.com',
+                    'shareWith' => 'receiver@example.com',
+                ],
+            ],
+        ];
+        $this->mailer->expects($this->exactly(2))
+            ->method('createEMailTemplate')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return $this->createMock(IEMailTemplate::class);
+            });
+
+        // Main email notification is sent as well as the password to owner
+        // because the password is set and SendPasswordByTalk is enabled.
+        $this->mailer->expects($this->exactly(2))->method('send');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    // If attributes is set to multiple emails, use them as BCC
+    public function sendNotificationToMultipleEmails() {
+        $expectedShare = $this->createMock(IShare::class);
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('');
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn(false);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('owner');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        $attributes = $this->createMock(IAttributes::class);
+        $share->expects($this->any())->method('getAttributes')->willReturn($attributes);
+        $attributes->expects($this->any())->method('getAttribute')->with('shareWith', 'emails')->willReturn([
+            'receiver1@example.com',
+            'receiver2@example.com',
+            'receiver3@example.com',
+        ]);
+
+        // Assume the mail address is valid.
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject', 'createShareActivity', 'autoGeneratePassword', 'createPasswordSendActivity', 'sendEmail', 'sendPassword', 'sendPasswordToOwner']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn([]);
+        $instance->expects($this->once())->method('createMailShare')->with($share)->willReturn(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($share);
+        $instance->expects($this->once())->method('getRawShare')->with(42)->willReturn(['rawShare', 'password' => 'password']);
+        $instance->expects($this->once())->method('createShareObject')->with(['rawShare', 'password' => 'password'])->willReturn($expectedShare);
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+
+        $share->expects($this->any())->method('getPassword')->willReturn('password');
+        $this->hasher->expects($this->once())->method('hash')->with('password')->willReturn('passwordHashed');
+        $share->expects($this->once())->method('setPassword')->with('passwordHashed');
+
+        // The given password (but not the autogenerated password) should not be
+        // mailed to the receiver of the share because permanent passwords are not enforced.
+        $this->shareManager->expects($this->any())->method('shareApiLinkEnforcePassword')->willReturn(false);
+        $this->config->expects($this->once())->method('getSystemValue')->with('sharing.enable_mail_link_password_expiration')->willReturn(false);
+        $instance->expects($this->never())->method('autoGeneratePassword');
+
+        // A password is set but no password sent via talk has been requested
+        $instance->expects($this->once())->method('sendEmail')
+            ->with($share, ['receiver1@example.com', 'receiver2@example.com', 'receiver3@example.com']);
+        $instance->expects($this->once())->method('sendPassword')->with($share, 'password');
+        $instance->expects($this->never())->method('sendPasswordToOwner');
+
+
+        $message = $this->createMock(IMessage::class);
+        $message->expects($this->never())->method('setTo');
+        $message->expects($this->exactly(2))->method('setBcc')->with(['receiver1@example.com', 'receiver2@example.com', 'receiver3@example.com']);
+        $this->mailer->expects($this->exactly(2))->method('createMessage')->willReturn($message);
+
+        // Main email notification is sent as well as the password
+        // to recipients because the password is set.
+        $this->mailer->expects($this->exactly(2))->method('send');
+
+        $this->assertSame($expectedShare, $instance->create($share));
+        $instance->sendMailNotification($share);
+    }
+
+    public function testCreateFailed(): void {
+        $this->expectException(\Exception::class);
+
+        $this->share->expects($this->once())->method('getSharedWith')->willReturn('user1');
+        $node = $this->createMock('OCP\Files\Node');
+        $node->expects($this->any())->method('getName')->willReturn('fileName');
+        $this->share->expects($this->any())->method('getNode')->willReturn($node);
+
+        $instance = $this->getInstance(['getSharedWith', 'createMailShare', 'getRawShare', 'createShareObject']);
+
+        $instance->expects($this->once())->method('getSharedWith')->willReturn(['found']);
+        $instance->expects($this->never())->method('createMailShare');
+        $instance->expects($this->never())->method('getRawShare');
+        $instance->expects($this->never())->method('createShareObject');
+
+        $this->assertSame('shareObject',
+            $instance->create($this->share)
+        );
+    }
+
+    public function testCreateMailShare(): void {
+        $this->share->expects($this->any())->method('getToken')->willReturn('token');
+        $this->share->expects($this->once())->method('setToken')->with('token');
+        $this->share->expects($this->any())->method('getSharedBy')->willReturn('validby@valid.com');
+        $this->share->expects($this->any())->method('getSharedWith')->willReturn('validwith@valid.com');
+        $this->share->expects($this->any())->method('getNote')->willReturn('Check this!');
+        $this->share->expects($this->any())->method('getMailSend')->willReturn(true);
+
+        $node = $this->createMock('OCP\Files\Node');
+        $node->expects($this->any())->method('getName')->willReturn('fileName');
+        $this->share->expects($this->any())->method('getNode')->willReturn($node);
+
+        $instance = $this->getInstance(['generateToken', 'addShareToDB', 'sendMailNotification']);
+
+        $instance->expects($this->once())->method('generateToken')->willReturn('token');
+        $instance->expects($this->once())->method('addShareToDB')->willReturn(42);
+
+        // The manager handle the mail sending
+        $instance->expects($this->never())->method('sendMailNotification');
+
+        $this->assertSame(42,
+            $this->invokePrivate($instance, 'createMailShare', [$this->share])
+        );
+    }
+
+    public function testGenerateToken(): void {
+        $instance = $this->getInstance();
+
+        $this->secureRandom->expects($this->once())->method('generate')->willReturn('token');
+
+        $this->assertSame('token',
+            $this->invokePrivate($instance, 'generateToken')
+        );
+    }
+
+    public function testAddShareToDB(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+        $password = 'password';
+        $sendPasswordByTalk = true;
+        $hideDownload = true;
+        $label = 'label';
+        $expiration = new \DateTime();
+        $passwordExpirationTime = new \DateTime();
+
+
+        $instance = $this->getInstance();
+        $id = $this->invokePrivate(
+            $instance,
+            'addShareToDB',
+            [
+                $itemSource,
+                $itemType,
+                $shareWith,
+                $sharedBy,
+                $uidOwner,
+                $permissions,
+                $token,
+                $password,
+                $passwordExpirationTime,
+                $sendPasswordByTalk,
+                $hideDownload,
+                $label,
+                $expiration
+            ]
+        );
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($id)));
+
+        $qResult = $qb->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+
+        $this->assertSame($itemSource, (int)$result[0]['item_source']);
+        $this->assertSame($itemType, $result[0]['item_type']);
+        $this->assertSame($shareWith, $result[0]['share_with']);
+        $this->assertSame($sharedBy, $result[0]['uid_initiator']);
+        $this->assertSame($uidOwner, $result[0]['uid_owner']);
+        $this->assertSame($permissions, (int)$result[0]['permissions']);
+        $this->assertSame($token, $result[0]['token']);
+        $this->assertSame($password, $result[0]['password']);
+        $this->assertSame($passwordExpirationTime->getTimestamp(), \DateTime::createFromFormat('Y-m-d H:i:s', $result[0]['password_expiration_time'])->getTimestamp());
+        $this->assertSame($sendPasswordByTalk, (bool)$result[0]['password_by_talk']);
+        $this->assertSame($hideDownload, (bool)$result[0]['hide_download']);
+        $this->assertSame($label, $result[0]['label']);
+        $this->assertSame($expiration->getTimestamp(), \DateTime::createFromFormat('Y-m-d H:i:s', $result[0]['expiration'])->getTimestamp());
+    }
+
+    public function testUpdate(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+        $note = 'personal note';
+
+
+        $instance = $this->getInstance();
+
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $note);
+
+        $this->share->expects($this->once())->method('getPermissions')->willReturn($permissions + 1);
+        $this->share->expects($this->once())->method('getShareOwner')->willReturn($uidOwner);
+        $this->share->expects($this->once())->method('getSharedBy')->willReturn($sharedBy);
+        $this->share->expects($this->any())->method('getNote')->willReturn($note);
+        $this->share->expects($this->atLeastOnce())->method('getId')->willReturn($id);
+        $this->share->expects($this->atLeastOnce())->method('getNodeId')->willReturn($itemSource);
+        $this->share->expects($this->once())->method('getSharedWith')->willReturn($shareWith);
+
+        $this->assertSame($this->share,
+            $instance->update($this->share)
+        );
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($id)));
+
+        $qResult = $qb->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+
+        $this->assertSame($itemSource, (int)$result[0]['item_source']);
+        $this->assertSame($itemType, $result[0]['item_type']);
+        $this->assertSame($shareWith, $result[0]['share_with']);
+        $this->assertSame($sharedBy, $result[0]['uid_initiator']);
+        $this->assertSame($uidOwner, $result[0]['uid_owner']);
+        $this->assertSame($permissions + 1, (int)$result[0]['permissions']);
+        $this->assertSame($token, $result[0]['token']);
+        $this->assertSame($note, $result[0]['note']);
+    }
+
+    public static function dataUpdateSendPassword(): array {
+        return [
+            ['password', 'hashed', 'hashed new', false, false, true],
+            ['', 'hashed', 'hashed new', false, false, false],
+            [null, 'hashed', 'hashed new', false, false, false],
+            ['password', 'hashed', 'hashed', false, false, false],
+            ['password', 'hashed', 'hashed new', false, true, false],
+            ['password', 'hashed', 'hashed new', true, false, true],
+            ['password', 'hashed', 'hashed', true, false, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateSendPassword')]
+    public function testUpdateSendPassword(?string $plainTextPassword, string $originalPassword, string $newPassword, bool $originalSendPasswordByTalk, bool $newSendPasswordByTalk, bool $sendMail): void {
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('filename');
+
+        $this->settingsManager->method('sendPasswordByMail')->willReturn(true);
+
+        $originalShare = $this->createMock(IShare::class);
+        $originalShare->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $originalShare->expects($this->any())->method('getNode')->willReturn($node);
+        $originalShare->expects($this->any())->method('getId')->willReturn(42);
+        $originalShare->expects($this->any())->method('getPassword')->willReturn($originalPassword);
+        $originalShare->expects($this->any())->method('getSendPasswordByTalk')->willReturn($originalSendPasswordByTalk);
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedWith')->willReturn('receiver@example.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getPassword')->willReturn($newPassword);
+        $share->expects($this->any())->method('getSendPasswordByTalk')->willReturn($newSendPasswordByTalk);
+
+        if ($sendMail) {
+            $this->mailer->expects($this->once())->method('createEMailTemplate')->with('sharebymail.RecipientPasswordNotification', [
+                'filename' => 'filename',
+                'password' => $plainTextPassword,
+                'initiator' => null,
+                'initiatorEmail' => null,
+                'shareWith' => 'receiver@example.com',
+            ]);
+            $this->mailer->expects($this->once())->method('send');
+        } else {
+            $this->mailer->expects($this->never())->method('send');
+        }
+
+        $instance = $this->getInstance(['getShareById', 'createPasswordSendActivity']);
+        $instance->expects($this->once())->method('getShareById')->willReturn($originalShare);
+
+        $this->assertSame($share,
+            $instance->update($share, $plainTextPassword)
+        );
+    }
+
+    public function testDelete(): void {
+        $instance = $this->getInstance(['removeShareFromTable', 'createShareActivity']);
+        $this->share->expects($this->once())->method('getId')->willReturn(42);
+        $instance->expects($this->once())->method('removeShareFromTable')->with(42);
+        $instance->expects($this->once())->method('createShareActivity')->with($this->share, 'unshare');
+        $instance->delete($this->share);
+    }
+
+    public function testGetShareById(): void {
+        $instance = $this->getInstance(['createShareObject']);
+
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+
+        $this->createDummyShare($itemType, $itemSource, $shareWith, 'user1wrong', 'user2wrong', $permissions, $token);
+        $id2 = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+
+        $instance->expects($this->once())->method('createShareObject')
+            ->willReturnCallback(
+                function ($data) use ($uidOwner, $sharedBy, $id2) {
+                    $this->assertSame($uidOwner, $data['uid_owner']);
+                    $this->assertSame($sharedBy, $data['uid_initiator']);
+                    $this->assertSame($id2, (int)$data['id']);
+                    return $this->share;
+                }
+            );
+
+        $result = $instance->getShareById($id2);
+
+        $this->assertInstanceOf('OCP\Share\IShare', $result);
+    }
+
+
+    public function testGetShareByIdFailed(): void {
+        $this->expectException(ShareNotFound::class);
+
+        $instance = $this->getInstance(['createShareObject']);
+
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+
+        $instance->getShareById($id + 1);
+    }
+
+    public function testGetShareByPath(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->once())->method('getId')->willReturn($itemSource);
+
+
+        $instance = $this->getInstance(['createShareObject']);
+
+        $this->createDummyShare($itemType, 111, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+
+        $instance->expects($this->once())->method('createShareObject')
+            ->willReturnCallback(
+                function ($data) use ($uidOwner, $sharedBy, $id) {
+                    $this->assertSame($uidOwner, $data['uid_owner']);
+                    $this->assertSame($sharedBy, $data['uid_initiator']);
+                    $this->assertSame($id, (int)$data['id']);
+                    return $this->share;
+                }
+            );
+
+        $result = $instance->getSharesByPath($node);
+
+        $this->assertTrue(is_array($result));
+        $this->assertSame(1, count($result));
+        $this->assertInstanceOf('OCP\Share\IShare', $result[0]);
+    }
+
+    public function testGetShareByToken(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
 
-		$instance = $this->getInstance(['createShareObject']);
+        $instance = $this->getInstance(['createShareObject']);
 
-		$idMail = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-		$idPublic = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, '', IShare::TYPE_LINK);
+        $idMail = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $idPublic = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, '', IShare::TYPE_LINK);
 
-		$this->assertTrue($idMail !== $idPublic);
+        $this->assertTrue($idMail !== $idPublic);
 
-		$instance->expects($this->once())->method('createShareObject')
-			->willReturnCallback(
-				function ($data) use ($idMail) {
-					$this->assertSame($idMail, (int)$data['id']);
-					return $this->share;
-				}
-			);
+        $instance->expects($this->once())->method('createShareObject')
+            ->willReturnCallback(
+                function ($data) use ($idMail) {
+                    $this->assertSame($idMail, (int)$data['id']);
+                    return $this->share;
+                }
+            );
 
-		$result = $instance->getShareByToken('token');
+        $result = $instance->getShareByToken('token');
 
-		$this->assertInstanceOf('OCP\Share\IShare', $result);
-	}
+        $this->assertInstanceOf('OCP\Share\IShare', $result);
+    }
 
 
-	public function testGetShareByTokenFailed(): void {
-		$this->expectException(ShareNotFound::class);
+    public function testGetShareByTokenFailed(): void {
+        $this->expectException(ShareNotFound::class);
 
 
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
 
-		$instance = $this->getInstance(['createShareObject']);
+        $instance = $this->getInstance(['createShareObject']);
 
-		$idMail = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-		$idPublic = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, 'token2', '', IShare::TYPE_LINK);
+        $idMail = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $idPublic = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, 'token2', '', IShare::TYPE_LINK);
 
-		$this->assertTrue($idMail !== $idPublic);
+        $this->assertTrue($idMail !== $idPublic);
 
-		$this->assertInstanceOf('OCP\Share\IShare',
-			$instance->getShareByToken('token2')
-		);
-	}
+        $this->assertInstanceOf('OCP\Share\IShare',
+            $instance->getShareByToken('token2')
+        );
+    }
 
-	public function testRemoveShareFromTable(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
+    public function testRemoveShareFromTable(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
 
-		$instance = $this->getInstance();
+        $instance = $this->getInstance();
 
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
 
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')->from('share')
-			->where($query->expr()->eq('id', $query->createNamedParameter($id)));
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')->from('share')
+            ->where($query->expr()->eq('id', $query->createNamedParameter($id)));
 
-		$result = $query->execute();
-		$before = $result->fetchAll();
-		$result->closeCursor();
+        $result = $query->execute();
+        $before = $result->fetchAll();
+        $result->closeCursor();
 
-		$this->assertTrue(is_array($before));
-		$this->assertSame(1, count($before));
+        $this->assertTrue(is_array($before));
+        $this->assertSame(1, count($before));
 
-		$this->invokePrivate($instance, 'removeShareFromTable', [$id]);
+        $this->invokePrivate($instance, 'removeShareFromTable', [$id]);
 
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')->from('share')
-			->where($query->expr()->eq('id', $query->createNamedParameter($id)));
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')->from('share')
+            ->where($query->expr()->eq('id', $query->createNamedParameter($id)));
 
-		$result = $query->execute();
-		$after = $result->fetchAll();
-		$result->closeCursor();
+        $result = $query->execute();
+        $after = $result->fetchAll();
+        $result->closeCursor();
 
-		$this->assertTrue(is_array($after));
-		$this->assertEmpty($after);
-	}
+        $this->assertTrue(is_array($after));
+        $this->assertEmpty($after);
+    }
 
-	public function testUserDeleted(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
+    public function testUserDeleted(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
 
-		$this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, 'user2Wrong', $permissions, $token);
+        $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, 'user2Wrong', $permissions, $token);
 
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')->from('share');
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')->from('share');
 
-		$result = $query->execute();
-		$before = $result->fetchAll();
-		$result->closeCursor();
+        $result = $query->execute();
+        $before = $result->fetchAll();
+        $result->closeCursor();
 
-		$this->assertTrue(is_array($before));
-		$this->assertSame(2, count($before));
+        $this->assertTrue(is_array($before));
+        $this->assertSame(2, count($before));
 
 
-		$instance = $this->getInstance();
+        $instance = $this->getInstance();
 
-		$instance->userDeleted($uidOwner, IShare::TYPE_EMAIL);
+        $instance->userDeleted($uidOwner, IShare::TYPE_EMAIL);
 
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')->from('share');
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')->from('share');
 
-		$result = $query->execute();
-		$after = $result->fetchAll();
-		$result->closeCursor();
+        $result = $query->execute();
+        $after = $result->fetchAll();
+        $result->closeCursor();
 
-		$this->assertTrue(is_array($after));
-		$this->assertSame(1, count($after));
-		$this->assertSame($id, (int)$after[0]['id']);
-	}
+        $this->assertTrue(is_array($after));
+        $this->assertSame(1, count($after));
+        $this->assertSame($id, (int)$after[0]['id']);
+    }
 
-	public function testGetRawShare(): void {
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
+    public function testGetRawShare(): void {
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
 
-		$instance = $this->getInstance();
+        $instance = $this->getInstance();
 
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
 
-		$result = $this->invokePrivate($instance, 'getRawShare', [$id]);
-
-		$this->assertTrue(is_array($result));
-		$this->assertSame($itemSource, (int)$result['item_source']);
-		$this->assertSame($itemType, $result['item_type']);
-		$this->assertSame($shareWith, $result['share_with']);
-		$this->assertSame($sharedBy, $result['uid_initiator']);
-		$this->assertSame($uidOwner, $result['uid_owner']);
-		$this->assertSame($permissions, (int)$result['permissions']);
-		$this->assertSame($token, $result['token']);
-	}
+        $result = $this->invokePrivate($instance, 'getRawShare', [$id]);
+
+        $this->assertTrue(is_array($result));
+        $this->assertSame($itemSource, (int)$result['item_source']);
+        $this->assertSame($itemType, $result['item_type']);
+        $this->assertSame($shareWith, $result['share_with']);
+        $this->assertSame($sharedBy, $result['uid_initiator']);
+        $this->assertSame($uidOwner, $result['uid_owner']);
+        $this->assertSame($permissions, (int)$result['permissions']);
+        $this->assertSame($token, $result['token']);
+    }
 
 
-	public function testGetRawShareFailed(): void {
-		$this->expectException(ShareNotFound::class);
+    public function testGetRawShareFailed(): void {
+        $this->expectException(ShareNotFound::class);
 
-		$itemSource = 11;
-		$itemType = 'file';
-		$shareWith = 'user@server.com';
-		$sharedBy = 'user1';
-		$uidOwner = 'user2';
-		$permissions = 1;
-		$token = 'token';
-
-		$instance = $this->getInstance();
+        $itemSource = 11;
+        $itemType = 'file';
+        $shareWith = 'user@server.com';
+        $sharedBy = 'user1';
+        $uidOwner = 'user2';
+        $permissions = 1;
+        $token = 'token';
+
+        $instance = $this->getInstance();
 
-		$id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
-
-		$this->invokePrivate($instance, 'getRawShare', [$id + 1]);
-	}
+        $id = $this->createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token);
+
+        $this->invokePrivate($instance, 'getRawShare', [$id + 1]);
+    }
 
-	private function createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $note = '', $shareType = IShare::TYPE_EMAIL) {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->setValue('share_type', $qb->createNamedParameter($shareType))
-			->setValue('item_type', $qb->createNamedParameter($itemType))
-			->setValue('item_source', $qb->createNamedParameter($itemSource))
-			->setValue('file_source', $qb->createNamedParameter($itemSource))
-			->setValue('share_with', $qb->createNamedParameter($shareWith))
-			->setValue('uid_owner', $qb->createNamedParameter($uidOwner))
-			->setValue('uid_initiator', $qb->createNamedParameter($sharedBy))
-			->setValue('permissions', $qb->createNamedParameter($permissions))
-			->setValue('token', $qb->createNamedParameter($token))
-			->setValue('note', $qb->createNamedParameter($note))
-			->setValue('stime', $qb->createNamedParameter(time()));
-
-		/*
+    private function createDummyShare($itemType, $itemSource, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $note = '', $shareType = IShare::TYPE_EMAIL) {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->setValue('share_type', $qb->createNamedParameter($shareType))
+            ->setValue('item_type', $qb->createNamedParameter($itemType))
+            ->setValue('item_source', $qb->createNamedParameter($itemSource))
+            ->setValue('file_source', $qb->createNamedParameter($itemSource))
+            ->setValue('share_with', $qb->createNamedParameter($shareWith))
+            ->setValue('uid_owner', $qb->createNamedParameter($uidOwner))
+            ->setValue('uid_initiator', $qb->createNamedParameter($sharedBy))
+            ->setValue('permissions', $qb->createNamedParameter($permissions))
+            ->setValue('token', $qb->createNamedParameter($token))
+            ->setValue('note', $qb->createNamedParameter($note))
+            ->setValue('stime', $qb->createNamedParameter(time()));
+
+        /*
 		 * Added to fix https://github.com/owncloud/core/issues/22215
 		 * Can be removed once we get rid of ajax/share.php
 		 */
-		$qb->setValue('file_target', $qb->createNamedParameter(''));
-
-		$qb->execute();
-		$id = $qb->getLastInsertId();
-
-		return (int)$id;
-	}
-
-	public function testGetSharesInFolder(): void {
-		$userManager = Server::get(IUserManager::class);
-		$rootFolder = Server::get(IRootFolder::class);
-
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturn(new Share($rootFolder, $userManager));
-
-		$provider = $this->getInstance(['sendMailNotification', 'createShareActivity']);
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$u1 = $userManager->createUser('testFed', md5((string)time()));
-		$u2 = $userManager->createUser('testFed2', md5((string)time()));
-
-		$folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
-		$file1 = $folder1->newFile('bar1');
-		$file2 = $folder1->newFile('bar2');
-
-		$share1 = $this->shareManager->newShare();
-		$share1->setSharedWith('user@server.com')
-			->setSharedBy($u1->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1);
-		$provider->create($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user@server.com')
-			->setSharedBy($u2->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file2);
-		$provider->create($share2);
-
-		$result = $provider->getSharesInFolder($u1->getUID(), $folder1, false);
-		$this->assertCount(1, $result);
-		$this->assertCount(1, $result[$file1->getId()]);
-
-		$result = $provider->getSharesInFolder($u1->getUID(), $folder1, true);
-		$this->assertCount(2, $result);
-		$this->assertCount(1, $result[$file1->getId()]);
-		$this->assertCount(1, $result[$file2->getId()]);
-
-		$u1->delete();
-		$u2->delete();
-	}
-
-	public function testGetAccessList(): void {
-		$userManager = Server::get(IUserManager::class);
-		$rootFolder = Server::get(IRootFolder::class);
-
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturn(new Share($rootFolder, $userManager));
-
-		$provider = $this->getInstance(['sendMailNotification', 'createShareActivity']);
-		$this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
-
-		$u1 = $userManager->createUser('testFed', md5((string)time()));
-		$u2 = $userManager->createUser('testFed2', md5((string)time()));
-
-		$folder = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
-
-		$accessList = $provider->getAccessList([$folder], true);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertFalse($accessList['public']);
-		$accessList = $provider->getAccessList([$folder], false);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertFalse($accessList['public']);
-
-		$share1 = $this->shareManager->newShare();
-		$share1->setSharedWith('user@server.com')
-			->setSharedBy($u1->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-		$share1 = $provider->create($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user2@server.com')
-			->setSharedBy($u2->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-		$share2 = $provider->create($share2);
-
-		$accessList = $provider->getAccessList([$folder], true);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertTrue($accessList['public']);
-		$accessList = $provider->getAccessList([$folder], false);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertTrue($accessList['public']);
-
-		$provider->delete($share2);
-
-		$accessList = $provider->getAccessList([$folder], true);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertTrue($accessList['public']);
-		$accessList = $provider->getAccessList([$folder], false);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertTrue($accessList['public']);
-
-		$provider->delete($share1);
-
-		$accessList = $provider->getAccessList([$folder], true);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertFalse($accessList['public']);
-		$accessList = $provider->getAccessList([$folder], false);
-		$this->assertArrayHasKey('public', $accessList);
-		$this->assertFalse($accessList['public']);
-
-		$u1->delete();
-		$u2->delete();
-	}
-
-	public function testSendMailNotificationWithSameUserAndUserEmail(): void {
-		$provider = $this->getInstance();
-		$user = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('OwnerUser')
-			->willReturn($user);
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mrs. Owner User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mrs. Owner User shared file.txt with you');
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
-			]);
-		$user
-			->expects($this->once())
-			->method('getEMailAddress')
-			->willReturn('owner@example.com');
-		$message
-			->expects($this->once())
-			->method('setReplyTo')
-			->with(['owner@example.com' => 'Mrs. Owner User']);
-		$this->defaults
-			->expects($this->exactly(2))
-			->method('getSlogan')
-			->willReturn('Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('UnitTestCloud - Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mrs. Owner User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
-
-	public function testSendMailNotificationWithSameUserAndUserEmailAndNote(): void {
-		$provider = $this->getInstance();
-		$user = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('OwnerUser')
-			->willReturn($user);
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mrs. Owner User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mrs. Owner User shared file.txt with you');
-
-		$this->urlGenerator->expects($this->once())->method('imagePath')
-			->with('core', 'caldav/description.png')
-			->willReturn('core/img/caldav/description.png');
-		$this->urlGenerator->expects($this->once())->method('getAbsoluteURL')
-			->with('core/img/caldav/description.png')
-			->willReturn('https://example.com/core/img/caldav/description.png');
-		$template
-			->expects($this->once())
-			->method('addBodyListItem')
-			->with(
-				'This is a note to the recipient',
-				'Note:',
-				'https://example.com/core/img/caldav/description.png',
-				'This is a note to the recipient'
-			);
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
-			]);
-		$user
-			->expects($this->once())
-			->method('getEMailAddress')
-			->willReturn('owner@example.com');
-		$message
-			->expects($this->once())
-			->method('setReplyTo')
-			->with(['owner@example.com' => 'Mrs. Owner User']);
-		$this->defaults
-			->expects($this->exactly(2))
-			->method('getSlogan')
-			->willReturn('Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('UnitTestCloud - Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mrs. Owner User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('This is a note to the recipient');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
-
-	public function testSendMailNotificationWithSameUserAndUserEmailAndExpiration(): void {
-		$provider = $this->getInstance();
-		$user = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('OwnerUser')
-			->willReturn($user);
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mrs. Owner User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mrs. Owner User shared file.txt with you');
-
-		$expiration = new DateTime('2001-01-01');
-		$this->l->expects($this->once())
-			->method('l')
-			->with('date', $expiration, ['width' => 'medium'])
-			->willReturn('2001-01-01');
-		$this->urlGenerator->expects($this->once())->method('imagePath')
-			->with('core', 'caldav/time.png')
-			->willReturn('core/img/caldav/time.png');
-		$this->urlGenerator->expects($this->once())->method('getAbsoluteURL')
-			->with('core/img/caldav/time.png')
-			->willReturn('https://example.com/core/img/caldav/time.png');
-		$template
-			->expects($this->once())
-			->method('addBodyListItem')
-			->with(
-				'This share is valid until 2001-01-01 at midnight',
-				'Expiration:',
-				'https://example.com/core/img/caldav/time.png',
-			);
-
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
-			]);
-		$user
-			->expects($this->once())
-			->method('getEMailAddress')
-			->willReturn('owner@example.com');
-		$message
-			->expects($this->once())
-			->method('setReplyTo')
-			->with(['owner@example.com' => 'Mrs. Owner User']);
-		$this->defaults
-			->expects($this->exactly(2))
-			->method('getSlogan')
-			->willReturn('Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('UnitTestCloud - Testing like 1990');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mrs. Owner User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getExpirationDate')->willReturn($expiration);
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
-
-	public function testSendMailNotificationWithDifferentUserAndNoUserEmail(): void {
-		$provider = $this->getInstance();
-		$initiatorUser = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('InitiatorUser')
-			->willReturn($initiatorUser);
-		$initiatorUser
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mr. Initiator User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mr. Initiator User shared file.txt with you');
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'Mr. Initiator User via UnitTestCloud'
-			]);
-		$message
-			->expects($this->never())
-			->method('setReplyTo');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mr. Initiator User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('InitiatorUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
-
-	public function testSendMailNotificationWithSameUserAndUserEmailAndReplyToDesactivate(): void {
-		$provider = $this->getInstance();
-		$user = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(false);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('OwnerUser')
-			->willReturn($user);
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mrs. Owner User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mrs. Owner User shared file.txt with you');
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'UnitTestCloud'
-			]);
-		// Since replyToInitiator is false, we never get the initiator email address
-		$user
-			->expects($this->never())
-			->method('getEMailAddress');
-		$message
-			->expects($this->never())
-			->method('setReplyTo');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mrs. Owner User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
-
-	public function testSendMailNotificationWithDifferentUserAndNoUserEmailAndReplyToDesactivate(): void {
-		$provider = $this->getInstance();
-		$initiatorUser = $this->createMock(IUser::class);
-		$this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(false);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('InitiatorUser')
-			->willReturn($initiatorUser);
-		$initiatorUser
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('Mr. Initiator User');
-		$message = $this->createMock(Message::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createMessage')
-			->willReturn($message);
-		$template = $this->createMock(IEMailTemplate::class);
-		$this->mailer
-			->expects($this->once())
-			->method('createEMailTemplate')
-			->willReturn($template);
-		$template
-			->expects($this->once())
-			->method('addHeader');
-		$template
-			->expects($this->once())
-			->method('addHeading')
-			->with('Mr. Initiator User shared file.txt with you');
-		$template
-			->expects($this->once())
-			->method('addBodyButton')
-			->with(
-				'Open file.txt',
-				'https://example.com/file.txt'
-			);
-		$message
-			->expects($this->once())
-			->method('setTo')
-			->with(['john@doe.com']);
-		$this->defaults
-			->expects($this->once())
-			->method('getName')
-			->willReturn('UnitTestCloud');
-		$message
-			->expects($this->once())
-			->method('setFrom')
-			->with([
-				Util::getDefaultEmailAddress('UnitTestCloud') => 'UnitTestCloud'
-			]);
-		$message
-			->expects($this->never())
-			->method('setReplyTo');
-		$template
-			->expects($this->once())
-			->method('addFooter')
-			->with('');
-		$template
-			->expects($this->once())
-			->method('setSubject')
-			->with('Mr. Initiator User shared file.txt with you');
-		$message
-			->expects($this->once())
-			->method('useTemplate')
-			->with($template);
-
-		$this->mailer->expects($this->once())
-			->method('validateMailAddress')
-			->willReturn(true);
-		$this->mailer
-			->expects($this->once())
-			->method('send')
-			->with($message);
-
-		$this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
-			->willReturn('https://example.com/file.txt');
-
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())->method('getName')->willReturn('file.txt');
-
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())->method('getSharedBy')->willReturn('InitiatorUser');
-		$share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
-		$share->expects($this->any())->method('getNode')->willReturn($node);
-		$share->expects($this->any())->method('getId')->willReturn(42);
-		$share->expects($this->any())->method('getNote')->willReturn('');
-		$share->expects($this->any())->method('getToken')->willReturn('token');
-
-		self::invokePrivate(
-			$provider,
-			'sendMailNotification',
-			[$share]
-		);
-	}
+        $qb->setValue('file_target', $qb->createNamedParameter(''));
+
+        $qb->execute();
+        $id = $qb->getLastInsertId();
+
+        return (int)$id;
+    }
+
+    public function testGetSharesInFolder(): void {
+        $userManager = Server::get(IUserManager::class);
+        $rootFolder = Server::get(IRootFolder::class);
+
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturn(new Share($rootFolder, $userManager));
+
+        $provider = $this->getInstance(['sendMailNotification', 'createShareActivity']);
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $u1 = $userManager->createUser('testFed', md5((string)time()));
+        $u2 = $userManager->createUser('testFed2', md5((string)time()));
+
+        $folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
+        $file1 = $folder1->newFile('bar1');
+        $file2 = $folder1->newFile('bar2');
+
+        $share1 = $this->shareManager->newShare();
+        $share1->setSharedWith('user@server.com')
+            ->setSharedBy($u1->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1);
+        $provider->create($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user@server.com')
+            ->setSharedBy($u2->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file2);
+        $provider->create($share2);
+
+        $result = $provider->getSharesInFolder($u1->getUID(), $folder1, false);
+        $this->assertCount(1, $result);
+        $this->assertCount(1, $result[$file1->getId()]);
+
+        $result = $provider->getSharesInFolder($u1->getUID(), $folder1, true);
+        $this->assertCount(2, $result);
+        $this->assertCount(1, $result[$file1->getId()]);
+        $this->assertCount(1, $result[$file2->getId()]);
+
+        $u1->delete();
+        $u2->delete();
+    }
+
+    public function testGetAccessList(): void {
+        $userManager = Server::get(IUserManager::class);
+        $rootFolder = Server::get(IRootFolder::class);
+
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturn(new Share($rootFolder, $userManager));
+
+        $provider = $this->getInstance(['sendMailNotification', 'createShareActivity']);
+        $this->mailer->expects($this->any())->method('validateMailAddress')->willReturn(true);
+
+        $u1 = $userManager->createUser('testFed', md5((string)time()));
+        $u2 = $userManager->createUser('testFed2', md5((string)time()));
+
+        $folder = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
+
+        $accessList = $provider->getAccessList([$folder], true);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertFalse($accessList['public']);
+        $accessList = $provider->getAccessList([$folder], false);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertFalse($accessList['public']);
+
+        $share1 = $this->shareManager->newShare();
+        $share1->setSharedWith('user@server.com')
+            ->setSharedBy($u1->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+        $share1 = $provider->create($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user2@server.com')
+            ->setSharedBy($u2->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+        $share2 = $provider->create($share2);
+
+        $accessList = $provider->getAccessList([$folder], true);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertTrue($accessList['public']);
+        $accessList = $provider->getAccessList([$folder], false);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertTrue($accessList['public']);
+
+        $provider->delete($share2);
+
+        $accessList = $provider->getAccessList([$folder], true);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertTrue($accessList['public']);
+        $accessList = $provider->getAccessList([$folder], false);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertTrue($accessList['public']);
+
+        $provider->delete($share1);
+
+        $accessList = $provider->getAccessList([$folder], true);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertFalse($accessList['public']);
+        $accessList = $provider->getAccessList([$folder], false);
+        $this->assertArrayHasKey('public', $accessList);
+        $this->assertFalse($accessList['public']);
+
+        $u1->delete();
+        $u2->delete();
+    }
+
+    public function testSendMailNotificationWithSameUserAndUserEmail(): void {
+        $provider = $this->getInstance();
+        $user = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('OwnerUser')
+            ->willReturn($user);
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mrs. Owner User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
+            ]);
+        $user
+            ->expects($this->once())
+            ->method('getEMailAddress')
+            ->willReturn('owner@example.com');
+        $message
+            ->expects($this->once())
+            ->method('setReplyTo')
+            ->with(['owner@example.com' => 'Mrs. Owner User']);
+        $this->defaults
+            ->expects($this->exactly(2))
+            ->method('getSlogan')
+            ->willReturn('Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('UnitTestCloud - Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
+
+    public function testSendMailNotificationWithSameUserAndUserEmailAndNote(): void {
+        $provider = $this->getInstance();
+        $user = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('OwnerUser')
+            ->willReturn($user);
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mrs. Owner User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mrs. Owner User shared file.txt with you');
+
+        $this->urlGenerator->expects($this->once())->method('imagePath')
+            ->with('core', 'caldav/description.png')
+            ->willReturn('core/img/caldav/description.png');
+        $this->urlGenerator->expects($this->once())->method('getAbsoluteURL')
+            ->with('core/img/caldav/description.png')
+            ->willReturn('https://example.com/core/img/caldav/description.png');
+        $template
+            ->expects($this->once())
+            ->method('addBodyListItem')
+            ->with(
+                'This is a note to the recipient',
+                'Note:',
+                'https://example.com/core/img/caldav/description.png',
+                'This is a note to the recipient'
+            );
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
+            ]);
+        $user
+            ->expects($this->once())
+            ->method('getEMailAddress')
+            ->willReturn('owner@example.com');
+        $message
+            ->expects($this->once())
+            ->method('setReplyTo')
+            ->with(['owner@example.com' => 'Mrs. Owner User']);
+        $this->defaults
+            ->expects($this->exactly(2))
+            ->method('getSlogan')
+            ->willReturn('Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('UnitTestCloud - Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('This is a note to the recipient');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
+
+    public function testSendMailNotificationWithSameUserAndUserEmailAndExpiration(): void {
+        $provider = $this->getInstance();
+        $user = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('OwnerUser')
+            ->willReturn($user);
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mrs. Owner User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mrs. Owner User shared file.txt with you');
+
+        $expiration = new DateTime('2001-01-01');
+        $this->l->expects($this->once())
+            ->method('l')
+            ->with('date', $expiration, ['width' => 'medium'])
+            ->willReturn('2001-01-01');
+        $this->urlGenerator->expects($this->once())->method('imagePath')
+            ->with('core', 'caldav/time.png')
+            ->willReturn('core/img/caldav/time.png');
+        $this->urlGenerator->expects($this->once())->method('getAbsoluteURL')
+            ->with('core/img/caldav/time.png')
+            ->willReturn('https://example.com/core/img/caldav/time.png');
+        $template
+            ->expects($this->once())
+            ->method('addBodyListItem')
+            ->with(
+                'This share is valid until 2001-01-01 at midnight',
+                'Expiration:',
+                'https://example.com/core/img/caldav/time.png',
+            );
+
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'Mrs. Owner User via UnitTestCloud'
+            ]);
+        $user
+            ->expects($this->once())
+            ->method('getEMailAddress')
+            ->willReturn('owner@example.com');
+        $message
+            ->expects($this->once())
+            ->method('setReplyTo')
+            ->with(['owner@example.com' => 'Mrs. Owner User']);
+        $this->defaults
+            ->expects($this->exactly(2))
+            ->method('getSlogan')
+            ->willReturn('Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('UnitTestCloud - Testing like 1990');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getExpirationDate')->willReturn($expiration);
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
+
+    public function testSendMailNotificationWithDifferentUserAndNoUserEmail(): void {
+        $provider = $this->getInstance();
+        $initiatorUser = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(true);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('InitiatorUser')
+            ->willReturn($initiatorUser);
+        $initiatorUser
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mr. Initiator User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mr. Initiator User shared file.txt with you');
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'Mr. Initiator User via UnitTestCloud'
+            ]);
+        $message
+            ->expects($this->never())
+            ->method('setReplyTo');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mr. Initiator User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('InitiatorUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
+
+    public function testSendMailNotificationWithSameUserAndUserEmailAndReplyToDesactivate(): void {
+        $provider = $this->getInstance();
+        $user = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(false);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('OwnerUser')
+            ->willReturn($user);
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mrs. Owner User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'UnitTestCloud'
+            ]);
+        // Since replyToInitiator is false, we never get the initiator email address
+        $user
+            ->expects($this->never())
+            ->method('getEMailAddress');
+        $message
+            ->expects($this->never())
+            ->method('setReplyTo');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mrs. Owner User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('OwnerUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
+
+    public function testSendMailNotificationWithDifferentUserAndNoUserEmailAndReplyToDesactivate(): void {
+        $provider = $this->getInstance();
+        $initiatorUser = $this->createMock(IUser::class);
+        $this->settingsManager->expects($this->any())->method('replyToInitiator')->willReturn(false);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('InitiatorUser')
+            ->willReturn($initiatorUser);
+        $initiatorUser
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('Mr. Initiator User');
+        $message = $this->createMock(Message::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createMessage')
+            ->willReturn($message);
+        $template = $this->createMock(IEMailTemplate::class);
+        $this->mailer
+            ->expects($this->once())
+            ->method('createEMailTemplate')
+            ->willReturn($template);
+        $template
+            ->expects($this->once())
+            ->method('addHeader');
+        $template
+            ->expects($this->once())
+            ->method('addHeading')
+            ->with('Mr. Initiator User shared file.txt with you');
+        $template
+            ->expects($this->once())
+            ->method('addBodyButton')
+            ->with(
+                'Open file.txt',
+                'https://example.com/file.txt'
+            );
+        $message
+            ->expects($this->once())
+            ->method('setTo')
+            ->with(['john@doe.com']);
+        $this->defaults
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('UnitTestCloud');
+        $message
+            ->expects($this->once())
+            ->method('setFrom')
+            ->with([
+                Util::getDefaultEmailAddress('UnitTestCloud') => 'UnitTestCloud'
+            ]);
+        $message
+            ->expects($this->never())
+            ->method('setReplyTo');
+        $template
+            ->expects($this->once())
+            ->method('addFooter')
+            ->with('');
+        $template
+            ->expects($this->once())
+            ->method('setSubject')
+            ->with('Mr. Initiator User shared file.txt with you');
+        $message
+            ->expects($this->once())
+            ->method('useTemplate')
+            ->with($template);
+
+        $this->mailer->expects($this->once())
+            ->method('validateMailAddress')
+            ->willReturn(true);
+        $this->mailer
+            ->expects($this->once())
+            ->method('send')
+            ->with($message);
+
+        $this->urlGenerator->expects($this->once())->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'token'])
+            ->willReturn('https://example.com/file.txt');
+
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())->method('getName')->willReturn('file.txt');
+
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())->method('getSharedBy')->willReturn('InitiatorUser');
+        $share->expects($this->any())->method('getSharedWith')->willReturn('john@doe.com');
+        $share->expects($this->any())->method('getNode')->willReturn($node);
+        $share->expects($this->any())->method('getId')->willReturn(42);
+        $share->expects($this->any())->method('getNote')->willReturn('');
+        $share->expects($this->any())->method('getToken')->willReturn('token');
+
+        self::invokePrivate(
+            $provider,
+            'sendMailNotification',
+            [$share]
+        );
+    }
 }

apps/files/tests/Command/DeleteOrphanedFilesTest.php

Indentation +81 added lines, -81 removed lines

@@ -28,111 +28,111 @@
  */
 class DeleteOrphanedFilesTest extends TestCase {
 
-	private DeleteOrphanedFiles $command;
-	private IDBConnection $connection;
-	private string $user1;
+    private DeleteOrphanedFiles $command;
+    private IDBConnection $connection;
+    private string $user1;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->connection = Server::get(IDBConnection::class);
+        $this->connection = Server::get(IDBConnection::class);
 
-		$this->user1 = $this->getUniqueID('user1_');
+        $this->user1 = $this->getUniqueID('user1_');
 
-		$userManager = Server::get(IUserManager::class);
-		$userManager->createUser($this->user1, 'pass');
+        $userManager = Server::get(IUserManager::class);
+        $userManager->createUser($this->user1, 'pass');
 
-		$this->command = new DeleteOrphanedFiles($this->connection);
-	}
+        $this->command = new DeleteOrphanedFiles($this->connection);
+    }
 
-	protected function tearDown(): void {
-		$userManager = Server::get(IUserManager::class);
-		$user1 = $userManager->get($this->user1);
-		if ($user1) {
-			$user1->delete();
-		}
+    protected function tearDown(): void {
+        $userManager = Server::get(IUserManager::class);
+        $user1 = $userManager->get($this->user1);
+        if ($user1) {
+            $user1->delete();
+        }
 
-		$this->logout();
+        $this->logout();
 
-		parent::tearDown();
-	}
+        parent::tearDown();
+    }
 
-	protected function getFile(int $fileId): array {
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')
-			->from('filecache')
-			->where($query->expr()->eq('fileid', $query->createNamedParameter($fileId)));
-		return $query->executeQuery()->fetchAll();
-	}
+    protected function getFile(int $fileId): array {
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')
+            ->from('filecache')
+            ->where($query->expr()->eq('fileid', $query->createNamedParameter($fileId)));
+        return $query->executeQuery()->fetchAll();
+    }
 
-	protected function getMounts(int $storageId): array {
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')
-			->from('mounts')
-			->where($query->expr()->eq('storage_id', $query->createNamedParameter($storageId)));
-		return $query->executeQuery()->fetchAll();
-	}
+    protected function getMounts(int $storageId): array {
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')
+            ->from('mounts')
+            ->where($query->expr()->eq('storage_id', $query->createNamedParameter($storageId)));
+        return $query->executeQuery()->fetchAll();
+    }
 
-	/**
-	 * Test clearing orphaned files
-	 */
-	public function testClearFiles(): void {
-		$input = $this->createMock(InputInterface::class);
-		$output = $this->createMock(OutputInterface::class);
+    /**
+     * Test clearing orphaned files
+     */
+    public function testClearFiles(): void {
+        $input = $this->createMock(InputInterface::class);
+        $output = $this->createMock(OutputInterface::class);
 
-		$rootFolder = Server::get(IRootFolder::class);
+        $rootFolder = Server::get(IRootFolder::class);
 
-		// scan home storage so that mounts are properly setup
-		$rootFolder->getUserFolder($this->user1)->getStorage()->getScanner()->scan('');
+        // scan home storage so that mounts are properly setup
+        $rootFolder->getUserFolder($this->user1)->getStorage()->getScanner()->scan('');
 
-		$this->loginAsUser($this->user1);
+        $this->loginAsUser($this->user1);
 
-		$view = new View('/' . $this->user1 . '/');
-		$view->mkdir('files/test');
+        $view = new View('/' . $this->user1 . '/');
+        $view->mkdir('files/test');
 
-		$fileInfo = $view->getFileInfo('files/test');
+        $fileInfo = $view->getFileInfo('files/test');
 
-		$storageId = $fileInfo->getStorage()->getId();
-		$numericStorageId = $fileInfo->getStorage()->getStorageCache()->getNumericId();
+        $storageId = $fileInfo->getStorage()->getId();
+        $numericStorageId = $fileInfo->getStorage()->getStorageCache()->getNumericId();
 
-		$this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is available');
-		$this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is available');
+        $this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is available');
+        $this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is available');
 
-		$this->command->execute($input, $output);
+        $this->command->execute($input, $output);
 
-		$this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is still available');
-		$this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is still available');
+        $this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is still available');
+        $this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is still available');
 
 
-		$deletedRows = $this->connection->executeUpdate('DELETE FROM `*PREFIX*storages` WHERE `id` = ?', [$storageId]);
-		$this->assertNotNull($deletedRows, 'Asserts that storage got deleted');
-		$this->assertSame(1, $deletedRows, 'Asserts that storage got deleted');
+        $deletedRows = $this->connection->executeUpdate('DELETE FROM `*PREFIX*storages` WHERE `id` = ?', [$storageId]);
+        $this->assertNotNull($deletedRows, 'Asserts that storage got deleted');
+        $this->assertSame(1, $deletedRows, 'Asserts that storage got deleted');
 
-		// parent folder, `files`, ´test` and `welcome.txt` => 4 elements
-		$calls = [
-			'3 orphaned file cache entries deleted',
-			'0 orphaned file cache extended entries deleted',
-			'1 orphaned mount entries deleted',
-		];
-		$output
-			->expects($this->exactly(3))
-			->method('writeln')
-			->willReturnCallback(function (string $message) use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertSame($expected, $message);
-			});
+        // parent folder, `files`, ´test` and `welcome.txt` => 4 elements
+        $calls = [
+            '3 orphaned file cache entries deleted',
+            '0 orphaned file cache extended entries deleted',
+            '1 orphaned mount entries deleted',
+        ];
+        $output
+            ->expects($this->exactly(3))
+            ->method('writeln')
+            ->willReturnCallback(function (string $message) use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertSame($expected, $message);
+            });
 
-		$this->command->execute($input, $output);
+        $this->command->execute($input, $output);
 
-		$this->assertCount(0, $this->getFile($fileInfo->getId()), 'Asserts that file gets cleaned up');
-		$this->assertCount(0, $this->getMounts($numericStorageId), 'Asserts that mount gets cleaned up');
+        $this->assertCount(0, $this->getFile($fileInfo->getId()), 'Asserts that file gets cleaned up');
+        $this->assertCount(0, $this->getMounts($numericStorageId), 'Asserts that mount gets cleaned up');
 
-		// Rescan folder to add back to cache before deleting
-		$rootFolder->getUserFolder($this->user1)->getStorage()->getScanner()->scan('');
-		// since we deleted the storage it might throw a (valid) StorageNotAvailableException
-		try {
-			$view->unlink('files/test');
-		} catch (StorageNotAvailableException $e) {
-		}
-	}
+        // Rescan folder to add back to cache before deleting
+        $rootFolder->getUserFolder($this->user1)->getStorage()->getScanner()->scan('');
+        // since we deleted the storage it might throw a (valid) StorageNotAvailableException
+        try {
+            $view->unlink('files/test');
+        } catch (StorageNotAvailableException $e) {
+        }
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -87,7 +87,7 @@ 
 
 		$this->loginAsUser($this->user1);
 
-		$view = new View('/' . $this->user1 . '/');
+		$view = new View('/'.$this->user1.'/');
 		$view->mkdir('files/test');
 
 		$fileInfo = $view->getFileInfo('files/test');
@@ -117,7 +117,7 @@ 
 		$output
 			->expects($this->exactly(3))
 			->method('writeln')
-			->willReturnCallback(function (string $message) use (&$calls): void {
+			->willReturnCallback(function(string $message) use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertSame($expected, $message);
 			});