nextcloud / server

apps/files_sharing/lib/Controller/DeletedShareAPIController.php

Indentation +203 added lines, -203 removed lines

@@ -35,207 +35,207 @@
  */
 class DeletedShareAPIController extends OCSController {
 
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private ShareManager $shareManager,
-		private ?string $userId,
-		private IUserManager $userManager,
-		private IGroupManager $groupManager,
-		private IRootFolder $rootFolder,
-		private IAppManager $appManager,
-		private IServerContainer $serverContainer,
-	) {
-		parent::__construct($appName, $request);
-	}
-
-	/**
-	 * @suppress PhanUndeclaredClassMethod
-	 *
-	 * @return Files_SharingDeletedShare
-	 */
-	private function formatShare(IShare $share): array {
-		$result = [
-			'id' => $share->getFullId(),
-			'share_type' => $share->getShareType(),
-			'uid_owner' => $share->getSharedBy(),
-			'displayname_owner' => $this->userManager->get($share->getSharedBy())->getDisplayName(),
-			'permissions' => 0,
-			'stime' => $share->getShareTime()->getTimestamp(),
-			'parent' => null,
-			'expiration' => null,
-			'token' => null,
-			'uid_file_owner' => $share->getShareOwner(),
-			'displayname_file_owner' => $this->userManager->get($share->getShareOwner())->getDisplayName(),
-			'path' => $share->getTarget(),
-		];
-		$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
-		$node = $userFolder->getFirstNodeById($share->getNodeId());
-		if (!$node) {
-			// fallback to guessing the path
-			$node = $userFolder->get($share->getTarget());
-			if ($node === null || $share->getTarget() === '') {
-				throw new NotFoundException();
-			}
-		}
-
-		$result['path'] = $userFolder->getRelativePath($node->getPath());
-		if ($node instanceof Folder) {
-			$result['item_type'] = 'folder';
-		} else {
-			$result['item_type'] = 'file';
-		}
-		$result['mimetype'] = $node->getMimetype();
-		$result['storage_id'] = $node->getStorage()->getId();
-		$result['storage'] = $node->getStorage()->getCache()->getNumericStorageId();
-		$result['item_source'] = $node->getId();
-		$result['file_source'] = $node->getId();
-		$result['file_parent'] = $node->getParent()->getId();
-		$result['file_target'] = $share->getTarget();
-		$result['item_size'] = $node->getSize();
-		$result['item_mtime'] = $node->getMTime();
-
-		$expiration = $share->getExpirationDate();
-		if ($expiration !== null) {
-			$result['expiration'] = $expiration->format('Y-m-d 00:00:00');
-		}
-
-		if ($share->getShareType() === IShare::TYPE_GROUP) {
-			$group = $this->groupManager->get($share->getSharedWith());
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = $group !== null ? $group->getDisplayName() : $share->getSharedWith();
-		} elseif ($share->getShareType() === IShare::TYPE_ROOM) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				$result = array_merge($result, $this->getRoomShareHelper()->formatShare($share));
-			} catch (QueryException $e) {
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_DECK) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				$result = array_merge($result, $this->getDeckShareHelper()->formatShare($share));
-			} catch (QueryException $e) {
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				$result = array_merge($result, $this->getSciencemeshShareHelper()->formatShare($share));
-			} catch (QueryException $e) {
-			}
-		}
-
-		return $result;
-	}
-
-	/**
-	 * Get a list of all deleted shares
-	 *
-	 * @return DataResponse<Http::STATUS_OK, list<Files_SharingDeletedShare>, array{}>
-	 *
-	 * 200: Deleted shares returned
-	 */
-	#[NoAdminRequired]
-	public function index(): DataResponse {
-		$groupShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_GROUP, null, -1, 0);
-		$teamShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_CIRCLE, null, -1, 0);
-		$roomShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_ROOM, null, -1, 0);
-		$deckShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_DECK, null, -1, 0);
-		$sciencemeshShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_SCIENCEMESH, null, -1, 0);
-
-		$shares = array_merge($groupShares, $teamShares, $roomShares, $deckShares, $sciencemeshShares);
-
-		$shares = array_values(array_map(function (IShare $share) {
-			return $this->formatShare($share);
-		}, $shares));
-
-		return new DataResponse($shares);
-	}
-
-	/**
-	 * Undelete a deleted share
-	 *
-	 * @param string $id ID of the share
-	 * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
-	 * @throws OCSException
-	 * @throws OCSNotFoundException Share not found
-	 *
-	 * 200: Share undeleted successfully
-	 */
-	#[NoAdminRequired]
-	public function undelete(string $id): DataResponse {
-		try {
-			$share = $this->shareManager->getShareById($id, $this->userId);
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException('Share not found');
-		}
-
-		if ($share->getPermissions() !== 0) {
-			throw new OCSNotFoundException('No deleted share found');
-		}
-
-		try {
-			$this->shareManager->restoreShare($share, $this->userId);
-		} catch (GenericShareException $e) {
-			throw new OCSException('Something went wrong');
-		}
-
-		return new DataResponse([]);
-	}
-
-	/**
-	 * Returns the helper of DeletedShareAPIController for room shares.
-	 *
-	 * If the Talk application is not enabled or the helper is not available
-	 * a QueryException is thrown instead.
-	 *
-	 * @return \OCA\Talk\Share\Helper\DeletedShareAPIController
-	 * @throws QueryException
-	 */
-	private function getRoomShareHelper() {
-		if (!$this->appManager->isEnabledForUser('spreed')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\Talk\Share\Helper\DeletedShareAPIController');
-	}
-
-	/**
-	 * Returns the helper of DeletedShareAPIHelper for deck shares.
-	 *
-	 * If the Deck application is not enabled or the helper is not available
-	 * a QueryException is thrown instead.
-	 *
-	 * @return ShareAPIHelper
-	 * @throws QueryException
-	 */
-	private function getDeckShareHelper() {
-		if (!$this->appManager->isEnabledForUser('deck')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\Deck\Sharing\ShareAPIHelper');
-	}
-
-	/**
-	 * Returns the helper of DeletedShareAPIHelper for sciencemesh shares.
-	 *
-	 * If the sciencemesh application is not enabled or the helper is not available
-	 * a QueryException is thrown instead.
-	 *
-	 * @return ShareAPIHelper
-	 * @throws QueryException
-	 */
-	private function getSciencemeshShareHelper() {
-		if (!$this->appManager->isEnabledForUser('sciencemesh')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\ScienceMesh\Sharing\ShareAPIHelper');
-	}
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private ShareManager $shareManager,
+        private ?string $userId,
+        private IUserManager $userManager,
+        private IGroupManager $groupManager,
+        private IRootFolder $rootFolder,
+        private IAppManager $appManager,
+        private IServerContainer $serverContainer,
+    ) {
+        parent::__construct($appName, $request);
+    }
+
+    /**
+     * @suppress PhanUndeclaredClassMethod
+     *
+     * @return Files_SharingDeletedShare
+     */
+    private function formatShare(IShare $share): array {
+        $result = [
+            'id' => $share->getFullId(),
+            'share_type' => $share->getShareType(),
+            'uid_owner' => $share->getSharedBy(),
+            'displayname_owner' => $this->userManager->get($share->getSharedBy())->getDisplayName(),
+            'permissions' => 0,
+            'stime' => $share->getShareTime()->getTimestamp(),
+            'parent' => null,
+            'expiration' => null,
+            'token' => null,
+            'uid_file_owner' => $share->getShareOwner(),
+            'displayname_file_owner' => $this->userManager->get($share->getShareOwner())->getDisplayName(),
+            'path' => $share->getTarget(),
+        ];
+        $userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
+        $node = $userFolder->getFirstNodeById($share->getNodeId());
+        if (!$node) {
+            // fallback to guessing the path
+            $node = $userFolder->get($share->getTarget());
+            if ($node === null || $share->getTarget() === '') {
+                throw new NotFoundException();
+            }
+        }
+
+        $result['path'] = $userFolder->getRelativePath($node->getPath());
+        if ($node instanceof Folder) {
+            $result['item_type'] = 'folder';
+        } else {
+            $result['item_type'] = 'file';
+        }
+        $result['mimetype'] = $node->getMimetype();
+        $result['storage_id'] = $node->getStorage()->getId();
+        $result['storage'] = $node->getStorage()->getCache()->getNumericStorageId();
+        $result['item_source'] = $node->getId();
+        $result['file_source'] = $node->getId();
+        $result['file_parent'] = $node->getParent()->getId();
+        $result['file_target'] = $share->getTarget();
+        $result['item_size'] = $node->getSize();
+        $result['item_mtime'] = $node->getMTime();
+
+        $expiration = $share->getExpirationDate();
+        if ($expiration !== null) {
+            $result['expiration'] = $expiration->format('Y-m-d 00:00:00');
+        }
+
+        if ($share->getShareType() === IShare::TYPE_GROUP) {
+            $group = $this->groupManager->get($share->getSharedWith());
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = $group !== null ? $group->getDisplayName() : $share->getSharedWith();
+        } elseif ($share->getShareType() === IShare::TYPE_ROOM) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                $result = array_merge($result, $this->getRoomShareHelper()->formatShare($share));
+            } catch (QueryException $e) {
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_DECK) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                $result = array_merge($result, $this->getDeckShareHelper()->formatShare($share));
+            } catch (QueryException $e) {
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                $result = array_merge($result, $this->getSciencemeshShareHelper()->formatShare($share));
+            } catch (QueryException $e) {
+            }
+        }
+
+        return $result;
+    }
+
+    /**
+     * Get a list of all deleted shares
+     *
+     * @return DataResponse<Http::STATUS_OK, list<Files_SharingDeletedShare>, array{}>
+     *
+     * 200: Deleted shares returned
+     */
+    #[NoAdminRequired]
+    public function index(): DataResponse {
+        $groupShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_GROUP, null, -1, 0);
+        $teamShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_CIRCLE, null, -1, 0);
+        $roomShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_ROOM, null, -1, 0);
+        $deckShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_DECK, null, -1, 0);
+        $sciencemeshShares = $this->shareManager->getDeletedSharedWith($this->userId, IShare::TYPE_SCIENCEMESH, null, -1, 0);
+
+        $shares = array_merge($groupShares, $teamShares, $roomShares, $deckShares, $sciencemeshShares);
+
+        $shares = array_values(array_map(function (IShare $share) {
+            return $this->formatShare($share);
+        }, $shares));
+
+        return new DataResponse($shares);
+    }
+
+    /**
+     * Undelete a deleted share
+     *
+     * @param string $id ID of the share
+     * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
+     * @throws OCSException
+     * @throws OCSNotFoundException Share not found
+     *
+     * 200: Share undeleted successfully
+     */
+    #[NoAdminRequired]
+    public function undelete(string $id): DataResponse {
+        try {
+            $share = $this->shareManager->getShareById($id, $this->userId);
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException('Share not found');
+        }
+
+        if ($share->getPermissions() !== 0) {
+            throw new OCSNotFoundException('No deleted share found');
+        }
+
+        try {
+            $this->shareManager->restoreShare($share, $this->userId);
+        } catch (GenericShareException $e) {
+            throw new OCSException('Something went wrong');
+        }
+
+        return new DataResponse([]);
+    }
+
+    /**
+     * Returns the helper of DeletedShareAPIController for room shares.
+     *
+     * If the Talk application is not enabled or the helper is not available
+     * a QueryException is thrown instead.
+     *
+     * @return \OCA\Talk\Share\Helper\DeletedShareAPIController
+     * @throws QueryException
+     */
+    private function getRoomShareHelper() {
+        if (!$this->appManager->isEnabledForUser('spreed')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\Talk\Share\Helper\DeletedShareAPIController');
+    }
+
+    /**
+     * Returns the helper of DeletedShareAPIHelper for deck shares.
+     *
+     * If the Deck application is not enabled or the helper is not available
+     * a QueryException is thrown instead.
+     *
+     * @return ShareAPIHelper
+     * @throws QueryException
+     */
+    private function getDeckShareHelper() {
+        if (!$this->appManager->isEnabledForUser('deck')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\Deck\Sharing\ShareAPIHelper');
+    }
+
+    /**
+     * Returns the helper of DeletedShareAPIHelper for sciencemesh shares.
+     *
+     * If the sciencemesh application is not enabled or the helper is not available
+     * a QueryException is thrown instead.
+     *
+     * @return ShareAPIHelper
+     * @throws QueryException
+     */
+    private function getSciencemeshShareHelper() {
+        if (!$this->appManager->isEnabledForUser('sciencemesh')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\ScienceMesh\Sharing\ShareAPIHelper');
+    }
 }

apps/files_sharing/lib/Controller/ShareAPIController.php

Indentation +2184 added lines, -2184 removed lines

@@ -73,2191 +73,2191 @@
  */
 class ShareAPIController extends OCSController {
 
-	private ?Node $lockedNode = null;
-
-	/**
-	 * Share20OCS constructor.
-	 */
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private IManager $shareManager,
-		private IGroupManager $groupManager,
-		private IUserManager $userManager,
-		private IRootFolder $rootFolder,
-		private IURLGenerator $urlGenerator,
-		private IL10N $l,
-		private IConfig $config,
-		private IAppManager $appManager,
-		private ContainerInterface $serverContainer,
-		private IUserStatusManager $userStatusManager,
-		private IPreview $previewManager,
-		private IDateTimeZone $dateTimeZone,
-		private LoggerInterface $logger,
-		private IProviderFactory $factory,
-		private IMailer $mailer,
-		private ITagManager $tagManager,
-		private ?string $userId = null,
-	) {
-		parent::__construct($appName, $request);
-	}
-
-	/**
-	 * Convert an IShare to an array for OCS output
-	 *
-	 * @param IShare $share
-	 * @param Node|null $recipientNode
-	 * @return Files_SharingShare
-	 * @throws NotFoundException In case the node can't be resolved.
-	 *
-	 * @suppress PhanUndeclaredClassMethod
-	 */
-	protected function formatShare(IShare $share, ?Node $recipientNode = null): array {
-		$sharedBy = $this->userManager->get($share->getSharedBy());
-		$shareOwner = $this->userManager->get($share->getShareOwner());
-
-		$isOwnShare = false;
-		if ($shareOwner !== null) {
-			$isOwnShare = $shareOwner->getUID() === $this->userId;
-		}
-
-		$result = [
-			'id' => $share->getId(),
-			'share_type' => $share->getShareType(),
-			'uid_owner' => $share->getSharedBy(),
-			'displayname_owner' => $sharedBy !== null ? $sharedBy->getDisplayName() : $share->getSharedBy(),
-			// recipient permissions
-			'permissions' => $share->getPermissions(),
-			// current user permissions on this share
-			'can_edit' => $this->canEditShare($share),
-			'can_delete' => $this->canDeleteShare($share),
-			'stime' => $share->getShareTime()->getTimestamp(),
-			'parent' => null,
-			'expiration' => null,
-			'token' => null,
-			'uid_file_owner' => $share->getShareOwner(),
-			'note' => $share->getNote(),
-			'label' => $share->getLabel(),
-			'displayname_file_owner' => $shareOwner !== null ? $shareOwner->getDisplayName() : $share->getShareOwner(),
-		];
-
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		if ($recipientNode) {
-			$node = $recipientNode;
-		} else {
-			$node = $userFolder->getFirstNodeById($share->getNodeId());
-			if (!$node) {
-				// fallback to guessing the path
-				$node = $userFolder->get($share->getTarget());
-				if ($node === null || $share->getTarget() === '') {
-					throw new NotFoundException();
-				}
-			}
-		}
-
-		$result['path'] = $userFolder->getRelativePath($node->getPath());
-		if ($node instanceof Folder) {
-			$result['item_type'] = 'folder';
-		} else {
-			$result['item_type'] = 'file';
-		}
-
-		// Get the original node permission if the share owner is the current user
-		if ($isOwnShare) {
-			$result['item_permissions'] = $node->getPermissions();
-		}
-
-		// If we're on the recipient side, the node permissions
-		// are bound to the share permissions. So we need to
-		// adjust the permissions to the share permissions if necessary.
-		if (!$isOwnShare) {
-			$result['item_permissions'] = $share->getPermissions();
-
-			// For some reason, single files share are forbidden to have the delete permission
-			// since we have custom methods to check those, let's adjust straight away.
-			// DAV permissions does not have that issue though.
-			if ($this->canDeleteShare($share) || $this->canDeleteShareFromSelf($share)) {
-				$result['item_permissions'] |= Constants::PERMISSION_DELETE;
-			}
-			if ($this->canEditShare($share)) {
-				$result['item_permissions'] |= Constants::PERMISSION_UPDATE;
-			}
-		}
-
-		// See MOUNT_ROOT_PROPERTYNAME dav property
-		$result['is-mount-root'] = $node->getInternalPath() === '';
-		$result['mount-type'] = $node->getMountPoint()->getMountType();
-
-		$result['mimetype'] = $node->getMimetype();
-		$result['has_preview'] = $this->previewManager->isAvailable($node);
-		$result['storage_id'] = $node->getStorage()->getId();
-		$result['storage'] = $node->getStorage()->getCache()->getNumericStorageId();
-		$result['item_source'] = $node->getId();
-		$result['file_source'] = $node->getId();
-		$result['file_parent'] = $node->getParent()->getId();
-		$result['file_target'] = $share->getTarget();
-		$result['item_size'] = $node->getSize();
-		$result['item_mtime'] = $node->getMTime();
-
-		$expiration = $share->getExpirationDate();
-		if ($expiration !== null) {
-			$expiration->setTimezone($this->dateTimeZone->getTimeZone());
-			$result['expiration'] = $expiration->format('Y-m-d 00:00:00');
-		}
-
-		if ($share->getShareType() === IShare::TYPE_USER) {
-			$sharedWith = $this->userManager->get($share->getSharedWith());
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = $sharedWith !== null ? $sharedWith->getDisplayName() : $share->getSharedWith();
-			$result['share_with_displayname_unique'] = $sharedWith !== null ? (
-				!empty($sharedWith->getSystemEMailAddress()) ? $sharedWith->getSystemEMailAddress() : $sharedWith->getUID()
-			) : $share->getSharedWith();
-
-			$userStatuses = $this->userStatusManager->getUserStatuses([$share->getSharedWith()]);
-			$userStatus = array_shift($userStatuses);
-			if ($userStatus) {
-				$result['status'] = [
-					'status' => $userStatus->getStatus(),
-					'message' => $userStatus->getMessage(),
-					'icon' => $userStatus->getIcon(),
-					'clearAt' => $userStatus->getClearAt()
-						? (int)$userStatus->getClearAt()->format('U')
-						: null,
-				];
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-			$group = $this->groupManager->get($share->getSharedWith());
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = $group !== null ? $group->getDisplayName() : $share->getSharedWith();
-		} elseif ($share->getShareType() === IShare::TYPE_LINK) {
-
-			// "share_with" and "share_with_displayname" for passwords of link
-			// shares was deprecated in Nextcloud 15, use "password" instead.
-			$result['share_with'] = $share->getPassword();
-			$result['share_with_displayname'] = '(' . $this->l->t('Shared link') . ')';
-
-			$result['password'] = $share->getPassword();
-
-			$result['send_password_by_talk'] = $share->getSendPasswordByTalk();
-
-			$result['token'] = $share->getToken();
-			$result['url'] = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.showShare', ['token' => $share->getToken()]);
-		} elseif ($share->getShareType() === IShare::TYPE_REMOTE) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = $this->getCachedFederatedDisplayName($share->getSharedWith());
-			$result['token'] = $share->getToken();
-		} elseif ($share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = $this->getDisplayNameFromAddressBook($share->getSharedWith(), 'CLOUD');
-			$result['token'] = $share->getToken();
-		} elseif ($share->getShareType() === IShare::TYPE_EMAIL) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['password'] = $share->getPassword();
-			$result['password_expiration_time'] = $share->getPasswordExpirationTime() !== null ? $share->getPasswordExpirationTime()->format(\DateTime::ATOM) : null;
-			$result['send_password_by_talk'] = $share->getSendPasswordByTalk();
-			$result['share_with_displayname'] = $this->getDisplayNameFromAddressBook($share->getSharedWith(), 'EMAIL');
-			$result['token'] = $share->getToken();
-		} elseif ($share->getShareType() === IShare::TYPE_CIRCLE) {
-			// getSharedWith() returns either "name (type, owner)" or
-			// "name (type, owner) [id]", depending on the Teams app version.
-			$hasCircleId = (substr($share->getSharedWith(), -1) === ']');
-
-			$result['share_with_displayname'] = $share->getSharedWithDisplayName();
-			if (empty($result['share_with_displayname'])) {
-				$displayNameLength = ($hasCircleId ? strrpos($share->getSharedWith(), ' ') : strlen($share->getSharedWith()));
-				$result['share_with_displayname'] = substr($share->getSharedWith(), 0, $displayNameLength);
-			}
-
-			$result['share_with_avatar'] = $share->getSharedWithAvatar();
-
-			$shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
-			$shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
-			if ($shareWithLength === false) {
-				$result['share_with'] = substr($share->getSharedWith(), $shareWithStart);
-			} else {
-				$result['share_with'] = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_ROOM) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				/** @var array{share_with_displayname: string, share_with_link: string, share_with?: string, token?: string} $roomShare */
-				$roomShare = $this->getRoomShareHelper()->formatShare($share);
-				$result = array_merge($result, $roomShare);
-			} catch (ContainerExceptionInterface $e) {
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_DECK) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				/** @var array{share_with: string, share_with_displayname: string, share_with_link: string} $deckShare */
-				$deckShare = $this->getDeckShareHelper()->formatShare($share);
-				$result = array_merge($result, $deckShare);
-			} catch (ContainerExceptionInterface $e) {
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
-			$result['share_with'] = $share->getSharedWith();
-			$result['share_with_displayname'] = '';
-
-			try {
-				/** @var array{share_with: string, share_with_displayname: string, token: string} $scienceMeshShare */
-				$scienceMeshShare = $this->getSciencemeshShareHelper()->formatShare($share);
-				$result = array_merge($result, $scienceMeshShare);
-			} catch (ContainerExceptionInterface $e) {
-			}
-		}
-
-
-		$result['mail_send'] = $share->getMailSend() ? 1 : 0;
-		$result['hide_download'] = $share->getHideDownload() ? 1 : 0;
-
-		$result['attributes'] = null;
-		if ($attributes = $share->getAttributes()) {
-			$result['attributes'] = (string)\json_encode($attributes->toArray());
-		}
-
-		return $result;
-	}
-
-	/**
-	 * Check if one of the users address books knows the exact property, if
-	 * not we return the full name.
-	 *
-	 * @param string $query
-	 * @param string $property
-	 * @return string
-	 */
-	private function getDisplayNameFromAddressBook(string $query, string $property): string {
-		// FIXME: If we inject the contacts manager it gets initialized before any address books are registered
-		try {
-			$result = Server::get(\OCP\Contacts\IManager::class)->search($query, [$property], [
-				'limit' => 1,
-				'enumeration' => false,
-				'strict_search' => true,
-			]);
-		} catch (Exception $e) {
-			$this->logger->error(
-				$e->getMessage(),
-				['exception' => $e]
-			);
-			return $query;
-		}
-
-		foreach ($result as $r) {
-			foreach ($r[$property] as $value) {
-				if ($value === $query && $r['FN']) {
-					return $r['FN'];
-				}
-			}
-		}
-
-		return $query;
-	}
-
-
-	/**
-	 * @param list<Files_SharingShare> $shares
-	 * @param array<string, string>|null $updatedDisplayName
-	 *
-	 * @return list<Files_SharingShare>
-	 */
-	private function fixMissingDisplayName(array $shares, ?array $updatedDisplayName = null): array {
-		$userIds = $updated = [];
-		foreach ($shares as $share) {
-			// share is federated and share have no display name yet
-			if ($share['share_type'] === IShare::TYPE_REMOTE
-				&& ($share['share_with'] ?? '') !== ''
-				&& ($share['share_with_displayname'] ?? '') === '') {
-				$userIds[] = $userId = $share['share_with'];
-
-				if ($updatedDisplayName !== null && array_key_exists($userId, $updatedDisplayName)) {
-					$share['share_with_displayname'] = $updatedDisplayName[$userId];
-				}
-			}
-
-			// prepping userIds with displayName to be updated
-			$updated[] = $share;
-		}
-
-		// if $updatedDisplayName is not null, it means we should have already fixed displayNames of the shares
-		if ($updatedDisplayName !== null) {
-			return $updated;
-		}
-
-		// get displayName for the generated list of userId with no displayName
-		$displayNames = $this->retrieveFederatedDisplayName($userIds);
-
-		// if no displayName are updated, we exit
-		if (empty($displayNames)) {
-			return $updated;
-		}
-
-		// let's fix missing display name and returns all shares
-		return $this->fixMissingDisplayName($shares, $displayNames);
-	}
-
-
-	/**
-	 * get displayName of a list of userIds from the lookup-server; through the globalsiteselector app.
-	 * returns an array with userIds as keys and displayName as values.
-	 *
-	 * @param array $userIds
-	 * @param bool $cacheOnly - do not reach LUS, get data from cache.
-	 *
-	 * @return array
-	 * @throws ContainerExceptionInterface
-	 */
-	private function retrieveFederatedDisplayName(array $userIds, bool $cacheOnly = false): array {
-		// check if gss is enabled and available
-		if (count($userIds) === 0
-			|| !$this->appManager->isEnabledForAnyone('globalsiteselector')
-			|| !class_exists('\OCA\GlobalSiteSelector\Service\SlaveService')) {
-			return [];
-		}
-
-		try {
-			$slaveService = Server::get(SlaveService::class);
-		} catch (\Throwable $e) {
-			$this->logger->error(
-				$e->getMessage(),
-				['exception' => $e]
-			);
-			return [];
-		}
-
-		return $slaveService->getUsersDisplayName($userIds, $cacheOnly);
-	}
-
-
-	/**
-	 * retrieve displayName from cache if available (should be used on federated shares)
-	 * if not available in cache/lus, try for get from address-book, else returns empty string.
-	 *
-	 * @param string $userId
-	 * @param bool $cacheOnly if true will not reach the lus but will only get data from cache
-	 *
-	 * @return string
-	 */
-	private function getCachedFederatedDisplayName(string $userId, bool $cacheOnly = true): string {
-		$details = $this->retrieveFederatedDisplayName([$userId], $cacheOnly);
-		if (array_key_exists($userId, $details)) {
-			return $details[$userId];
-		}
-
-		$displayName = $this->getDisplayNameFromAddressBook($userId, 'CLOUD');
-		return ($displayName === $userId) ? '' : $displayName;
-	}
-
-
-
-	/**
-	 * Get a specific share by id
-	 *
-	 * @param string $id ID of the share
-	 * @param bool $include_tags Include tags in the share
-	 * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
-	 * @throws OCSNotFoundException Share not found
-	 *
-	 * 200: Share returned
-	 */
-	#[NoAdminRequired]
-	public function getShare(string $id, bool $include_tags = false): DataResponse {
-		try {
-			$share = $this->getShareById($id);
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		try {
-			if ($this->canAccessShare($share)) {
-				$share = $this->formatShare($share);
-
-				if ($include_tags) {
-					$share = $this->populateTags([$share]);
-				} else {
-					$share = [$share];
-				}
-
-				return new DataResponse($share);
-			}
-		} catch (NotFoundException $e) {
-			// Fall through
-		}
-
-		throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-	}
-
-	/**
-	 * Delete a share
-	 *
-	 * @param string $id ID of the share
-	 * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
-	 * @throws OCSNotFoundException Share not found
-	 * @throws OCSForbiddenException Missing permissions to delete the share
-	 *
-	 * 200: Share deleted successfully
-	 */
-	#[NoAdminRequired]
-	public function deleteShare(string $id): DataResponse {
-		try {
-			$share = $this->getShareById($id);
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		try {
-			$this->lock($share->getNode());
-		} catch (LockedException $e) {
-			throw new OCSNotFoundException($this->l->t('Could not delete share'));
-		}
-
-		if (!$this->canAccessShare($share)) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		// if it's a group share or a room share
-		// we don't delete the share, but only the
-		// mount point. Allowing it to be restored
-		// from the deleted shares
-		if ($this->canDeleteShareFromSelf($share)) {
-			$this->shareManager->deleteFromSelf($share, $this->userId);
-		} else {
-			if (!$this->canDeleteShare($share)) {
-				throw new OCSForbiddenException($this->l->t('Could not delete share'));
-			}
-
-			$this->shareManager->deleteShare($share);
-		}
-
-		return new DataResponse();
-	}
-
-	/**
-	 * Create a share
-	 *
-	 * @param string|null $path Path of the share
-	 * @param int|null $permissions Permissions for the share
-	 * @param int $shareType Type of the share
-	 * @param ?string $shareWith The entity this should be shared with
-	 * @param 'true'|'false'|null $publicUpload If public uploading is allowed (deprecated)
-	 * @param string $password Password for the share
-	 * @param string|null $sendPasswordByTalk Send the password for the share over Talk
-	 * @param ?string $expireDate The expiry date of the share in the user's timezone at 00:00.
-	 *                            If $expireDate is not supplied or set to `null`, the system default will be used.
-	 * @param string $note Note for the share
-	 * @param string $label Label for the share (only used in link and email)
-	 * @param string|null $attributes Additional attributes for the share
-	 * @param 'false'|'true'|null $sendMail Send a mail to the recipient
-	 *
-	 * @return DataResponse<Http::STATUS_OK, Files_SharingShare, array{}>
-	 * @throws OCSBadRequestException Unknown share type
-	 * @throws OCSException
-	 * @throws OCSForbiddenException Creating the share is not allowed
-	 * @throws OCSNotFoundException Creating the share failed
-	 * @suppress PhanUndeclaredClassMethod
-	 *
-	 * 200: Share created
-	 */
-	#[NoAdminRequired]
-	#[UserRateLimit(limit: 20, period: 600)]
-	public function createShare(
-		?string $path = null,
-		?int $permissions = null,
-		int $shareType = -1,
-		?string $shareWith = null,
-		?string $publicUpload = null,
-		string $password = '',
-		?string $sendPasswordByTalk = null,
-		?string $expireDate = null,
-		string $note = '',
-		string $label = '',
-		?string $attributes = null,
-		?string $sendMail = null,
-	): DataResponse {
-		assert($this->userId !== null);
-
-		$share = $this->shareManager->newShare();
-		$hasPublicUpload = $this->getLegacyPublicUpload($publicUpload);
-
-		// Verify path
-		if ($path === null) {
-			throw new OCSNotFoundException($this->l->t('Please specify a file or folder path'));
-		}
-
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		try {
-			/** @var \OC\Files\Node\Node $node */
-			$node = $userFolder->get($path);
-		} catch (NotFoundException $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong path, file/folder does not exist'));
-		}
-
-		// a user can have access to a file through different paths, with differing permissions
-		// combine all permissions to determine if the user can share this file
-		$nodes = $userFolder->getById($node->getId());
-		foreach ($nodes as $nodeById) {
-			/** @var FileInfo $fileInfo */
-			$fileInfo = $node->getFileInfo();
-			$fileInfo['permissions'] |= $nodeById->getPermissions();
-		}
-
-		$share->setNode($node);
-
-		try {
-			$this->lock($share->getNode());
-		} catch (LockedException $e) {
-			throw new OCSNotFoundException($this->l->t('Could not create share'));
-		}
-
-		// Set permissions
-		if ($shareType === IShare::TYPE_LINK || $shareType === IShare::TYPE_EMAIL) {
-			$permissions = $this->getLinkSharePermissions($permissions, $hasPublicUpload);
-			$this->validateLinkSharePermissions($node, $permissions, $hasPublicUpload);
-		} else {
-			// Use default permissions only for non-link shares to keep legacy behavior
-			if ($permissions === null) {
-				$permissions = (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL);
-			}
-			// Non-link shares always require read permissions (link shares could be file drop)
-			$permissions |= Constants::PERMISSION_READ;
-		}
-
-		// For legacy reasons the API allows to pass PERMISSIONS_ALL even for single file shares (I look at you Talk)
-		if ($node instanceof File) {
-			// if this is a single file share we remove the DELETE and CREATE permissions
-			$permissions = $permissions & ~(Constants::PERMISSION_DELETE | Constants::PERMISSION_CREATE);
-		}
-
-		/**
-		 * Hack for https://github.com/owncloud/core/issues/22587
-		 * We check the permissions via webdav. But the permissions of the mount point
-		 * do not equal the share permissions. Here we fix that for federated mounts.
-		 */
-		if ($node->getStorage()->instanceOfStorage(Storage::class)) {
-			$permissions &= ~($permissions & ~$node->getPermissions());
-		}
-
-		if ($attributes !== null) {
-			$share = $this->setShareAttributes($share, $attributes);
-		}
-
-		// Expire date checks
-		// Normally, null means no expiration date but we still set the default for backwards compatibility
-		// If the client sends an empty string, we set noExpirationDate to true
-		if ($expireDate !== null) {
-			if ($expireDate !== '') {
-				try {
-					$expireDateTime = $this->parseDate($expireDate);
-					$share->setExpirationDate($expireDateTime);
-				} catch (\Exception $e) {
-					throw new OCSNotFoundException($e->getMessage(), $e);
-				}
-			} else {
-				// Client sent empty string for expire date.
-				// Set noExpirationDate to true so overwrite is prevented.
-				$share->setNoExpirationDate(true);
-			}
-		}
-
-		$share->setSharedBy($this->userId);
-
-		// Handle mail send
-		if (is_null($sendMail)) {
-			$allowSendMail = $this->config->getSystemValueBool('sharing.enable_share_mail', true);
-			if ($allowSendMail !== true || $shareType === IShare::TYPE_EMAIL) {
-				// Define a default behavior when sendMail is not provided
-				// For email shares with a valid recipient, the default is to send the mail
-				// For all other share types, the default is to not send the mail
-				$allowSendMail = ($shareType === IShare::TYPE_EMAIL && $shareWith !== null && $shareWith !== '');
-			}
-			$share->setMailSend($allowSendMail);
-		} else {
-			$share->setMailSend($sendMail === 'true');
-		}
-
-		if ($shareType === IShare::TYPE_USER) {
-			// Valid user is required to share
-			if ($shareWith === null || !$this->userManager->userExists($shareWith)) {
-				throw new OCSNotFoundException($this->l->t('Please specify a valid account to share with'));
-			}
-			$share->setSharedWith($shareWith);
-			$share->setPermissions($permissions);
-		} elseif ($shareType === IShare::TYPE_GROUP) {
-			if (!$this->shareManager->allowGroupSharing()) {
-				throw new OCSNotFoundException($this->l->t('Group sharing is disabled by the administrator'));
-			}
-
-			// Valid group is required to share
-			if ($shareWith === null || !$this->groupManager->groupExists($shareWith)) {
-				throw new OCSNotFoundException($this->l->t('Please specify a valid group'));
-			}
-			$share->setSharedWith($shareWith);
-			$share->setPermissions($permissions);
-		} elseif ($shareType === IShare::TYPE_LINK
-			|| $shareType === IShare::TYPE_EMAIL) {
-
-			// Can we even share links?
-			if (!$this->shareManager->shareApiAllowLinks()) {
-				throw new OCSNotFoundException($this->l->t('Public link sharing is disabled by the administrator'));
-			}
-
-			$this->validateLinkSharePermissions($node, $permissions, $hasPublicUpload);
-			$share->setPermissions($permissions);
-
-			// Set password
-			if ($password !== '') {
-				$share->setPassword($password);
-			}
-
-			// Only share by mail have a recipient
-			if (is_string($shareWith) && $shareType === IShare::TYPE_EMAIL) {
-				// If sending a mail have been requested, validate the mail address
-				if ($share->getMailSend() && !$this->mailer->validateMailAddress($shareWith)) {
-					throw new OCSNotFoundException($this->l->t('Please specify a valid email address'));
-				}
-				$share->setSharedWith($shareWith);
-			}
-
-			// If we have a label, use it
-			if ($label !== '') {
-				if (strlen($label) > 255) {
-					throw new OCSBadRequestException('Maximum label length is 255');
-				}
-				$share->setLabel($label);
-			}
-
-			if ($sendPasswordByTalk === 'true') {
-				if (!$this->appManager->isEnabledForUser('spreed')) {
-					throw new OCSForbiddenException($this->l->t('Sharing %s sending the password by Nextcloud Talk failed because Nextcloud Talk is not enabled', [$node->getPath()]));
-				}
-
-				$share->setSendPasswordByTalk(true);
-			}
-		} elseif ($shareType === IShare::TYPE_REMOTE) {
-			if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
-				throw new OCSForbiddenException($this->l->t('Sharing %1$s failed because the back end does not allow shares from type %2$s', [$node->getPath(), $shareType]));
-			}
-
-			if ($shareWith === null) {
-				throw new OCSNotFoundException($this->l->t('Please specify a valid federated account ID'));
-			}
-
-			$share->setSharedWith($shareWith);
-			$share->setPermissions($permissions);
-			$share->setSharedWithDisplayName($this->getCachedFederatedDisplayName($shareWith, false));
-		} elseif ($shareType === IShare::TYPE_REMOTE_GROUP) {
-			if (!$this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
-				throw new OCSForbiddenException($this->l->t('Sharing %1$s failed because the back end does not allow shares from type %2$s', [$node->getPath(), $shareType]));
-			}
-
-			if ($shareWith === null) {
-				throw new OCSNotFoundException($this->l->t('Please specify a valid federated group ID'));
-			}
-
-			$share->setSharedWith($shareWith);
-			$share->setPermissions($permissions);
-		} elseif ($shareType === IShare::TYPE_CIRCLE) {
-			if (!Server::get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) {
-				throw new OCSNotFoundException($this->l->t('You cannot share to a Team if the app is not enabled'));
-			}
-
-			$circle = Circles::detailsCircle($shareWith);
-
-			// Valid team is required to share
-			if ($circle === null) {
-				throw new OCSNotFoundException($this->l->t('Please specify a valid team'));
-			}
-			$share->setSharedWith($shareWith);
-			$share->setPermissions($permissions);
-		} elseif ($shareType === IShare::TYPE_ROOM) {
-			try {
-				$this->getRoomShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
-			} catch (ContainerExceptionInterface $e) {
-				throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support room shares', [$node->getPath()]));
-			}
-		} elseif ($shareType === IShare::TYPE_DECK) {
-			try {
-				$this->getDeckShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
-			} catch (ContainerExceptionInterface $e) {
-				throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support room shares', [$node->getPath()]));
-			}
-		} elseif ($shareType === IShare::TYPE_SCIENCEMESH) {
-			try {
-				$this->getSciencemeshShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
-			} catch (ContainerExceptionInterface $e) {
-				throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support ScienceMesh shares', [$node->getPath()]));
-			}
-		} else {
-			throw new OCSBadRequestException($this->l->t('Unknown share type'));
-		}
-
-		$share->setShareType($shareType);
-		$this->checkInheritedAttributes($share);
-
-		if ($note !== '') {
-			$share->setNote($note);
-		}
-
-		try {
-			$share = $this->shareManager->createShare($share);
-		} catch (HintException $e) {
-			$code = $e->getCode() === 0 ? 403 : $e->getCode();
-			throw new OCSException($e->getHint(), $code);
-		} catch (GenericShareException|\InvalidArgumentException $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSForbiddenException($e->getMessage(), $e);
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSForbiddenException('Failed to create share.', $e);
-		}
-
-		$output = $this->formatShare($share);
-
-		return new DataResponse($output);
-	}
-
-	/**
-	 * @param null|Node $node
-	 * @param boolean $includeTags
-	 *
-	 * @return list<Files_SharingShare>
-	 */
-	private function getSharedWithMe($node, bool $includeTags): array {
-		$userShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_USER, $node, -1, 0);
-		$groupShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_GROUP, $node, -1, 0);
-		$circleShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_CIRCLE, $node, -1, 0);
-		$roomShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_ROOM, $node, -1, 0);
-		$deckShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_DECK, $node, -1, 0);
-		$sciencemeshShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_SCIENCEMESH, $node, -1, 0);
-
-		$shares = array_merge($userShares, $groupShares, $circleShares, $roomShares, $deckShares, $sciencemeshShares);
-
-		$filteredShares = array_filter($shares, function (IShare $share) {
-			return $share->getShareOwner() !== $this->userId;
-		});
-
-		$formatted = [];
-		foreach ($filteredShares as $share) {
-			if ($this->canAccessShare($share)) {
-				try {
-					$formatted[] = $this->formatShare($share);
-				} catch (NotFoundException $e) {
-					// Ignore this share
-				}
-			}
-		}
-
-		if ($includeTags) {
-			$formatted = $this->populateTags($formatted);
-		}
-
-		return $formatted;
-	}
-
-	/**
-	 * @param Node $folder
-	 *
-	 * @return list<Files_SharingShare>
-	 * @throws OCSBadRequestException
-	 * @throws NotFoundException
-	 */
-	private function getSharesInDir(Node $folder): array {
-		if (!($folder instanceof Folder)) {
-			throw new OCSBadRequestException($this->l->t('Not a directory'));
-		}
-
-		$nodes = $folder->getDirectoryListing();
-
-		/** @var IShare[] $shares */
-		$shares = array_reduce($nodes, function ($carry, $node) {
-			$carry = array_merge($carry, $this->getAllShares($node, true));
-			return $carry;
-		}, []);
-
-		// filter out duplicate shares
-		$known = [];
-
-		$formatted = $miniFormatted = [];
-		$resharingRight = false;
-		$known = [];
-		foreach ($shares as $share) {
-			if (in_array($share->getId(), $known) || $share->getSharedWith() === $this->userId) {
-				continue;
-			}
-
-			try {
-				$format = $this->formatShare($share);
-
-				$known[] = $share->getId();
-				$formatted[] = $format;
-				if ($share->getSharedBy() === $this->userId) {
-					$miniFormatted[] = $format;
-				}
-				if (!$resharingRight && $this->shareProviderResharingRights($this->userId, $share, $folder)) {
-					$resharingRight = true;
-				}
-			} catch (\Exception $e) {
-				//Ignore this share
-			}
-		}
-
-		if (!$resharingRight) {
-			$formatted = $miniFormatted;
-		}
-
-		return $formatted;
-	}
-
-	/**
-	 * Get shares of the current user
-	 *
-	 * @param string $shared_with_me Only get shares with the current user
-	 * @param string $reshares Only get shares by the current user and reshares
-	 * @param string $subfiles Only get all shares in a folder
-	 * @param string $path Get shares for a specific path
-	 * @param string $include_tags Include tags in the share
-	 *
-	 * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
-	 * @throws OCSNotFoundException The folder was not found or is inaccessible
-	 *
-	 * 200: Shares returned
-	 */
-	#[NoAdminRequired]
-	public function getShares(
-		string $shared_with_me = 'false',
-		string $reshares = 'false',
-		string $subfiles = 'false',
-		string $path = '',
-		string $include_tags = 'false',
-	): DataResponse {
-		$node = null;
-		if ($path !== '') {
-			$userFolder = $this->rootFolder->getUserFolder($this->userId);
-			try {
-				$node = $userFolder->get($path);
-				$this->lock($node);
-			} catch (NotFoundException $e) {
-				throw new OCSNotFoundException(
-					$this->l->t('Wrong path, file/folder does not exist')
-				);
-			} catch (LockedException $e) {
-				throw new OCSNotFoundException($this->l->t('Could not lock node'));
-			}
-		}
-
-		$shares = $this->getFormattedShares(
-			$this->userId,
-			$node,
-			($shared_with_me === 'true'),
-			($reshares === 'true'),
-			($subfiles === 'true'),
-			($include_tags === 'true')
-		);
-
-		return new DataResponse($shares);
-	}
-
-	private function getLinkSharePermissions(?int $permissions, ?bool $legacyPublicUpload): int {
-		$permissions = $permissions ?? Constants::PERMISSION_READ;
-
-		// Legacy option handling
-		if ($legacyPublicUpload !== null) {
-			$permissions = $legacyPublicUpload
-				? (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE)
-				: Constants::PERMISSION_READ;
-		}
-
-		// TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones
-		if ($this->hasPermission($permissions, Constants::PERMISSION_READ)
-			&& $this->shareManager->outgoingServer2ServerSharesAllowed()) {
-			$permissions |= Constants::PERMISSION_SHARE;
-		}
-
-		return $permissions;
-	}
-
-	/**
-	 * Helper to check for legacy "publicUpload" handling.
-	 * If the value is set to `true` or `false` then true or false are returned.
-	 * Otherwise null is returned to indicate that the option was not (or wrong) set.
-	 *
-	 * @param null|string $legacyPublicUpload The value of `publicUpload`
-	 */
-	private function getLegacyPublicUpload(?string $legacyPublicUpload): ?bool {
-		if ($legacyPublicUpload === 'true') {
-			return true;
-		} elseif ($legacyPublicUpload === 'false') {
-			return false;
-		}
-		// Not set at all
-		return null;
-	}
-
-	/**
-	 * For link and email shares validate that only allowed combinations are set.
-	 *
-	 * @throw OCSBadRequestException If permission combination is invalid.
-	 * @throw OCSForbiddenException If public upload was forbidden by the administrator.
-	 */
-	private function validateLinkSharePermissions(Node $node, int $permissions, ?bool $legacyPublicUpload): void {
-		if ($legacyPublicUpload && ($node instanceof File)) {
-			throw new OCSBadRequestException($this->l->t('Public upload is only possible for publicly shared folders'));
-		}
-
-		// We need at least READ or CREATE (file drop)
-		if (!$this->hasPermission($permissions, Constants::PERMISSION_READ)
-			&& !$this->hasPermission($permissions, Constants::PERMISSION_CREATE)) {
-			throw new OCSBadRequestException($this->l->t('Share must at least have READ or CREATE permissions'));
-		}
-
-		// UPDATE and DELETE require a READ permission
-		if (!$this->hasPermission($permissions, Constants::PERMISSION_READ)
-			&& ($this->hasPermission($permissions, Constants::PERMISSION_UPDATE) || $this->hasPermission($permissions, Constants::PERMISSION_DELETE))) {
-			throw new OCSBadRequestException($this->l->t('Share must have READ permission if UPDATE or DELETE permission is set'));
-		}
-
-		// Check if public uploading was disabled
-		if ($this->hasPermission($permissions, Constants::PERMISSION_CREATE)
-			&& !$this->shareManager->shareApiLinkAllowPublicUpload()) {
-			throw new OCSForbiddenException($this->l->t('Public upload disabled by the administrator'));
-		}
-	}
-
-	/**
-	 * @param string $viewer
-	 * @param Node $node
-	 * @param bool $sharedWithMe
-	 * @param bool $reShares
-	 * @param bool $subFiles
-	 * @param bool $includeTags
-	 *
-	 * @return list<Files_SharingShare>
-	 * @throws NotFoundException
-	 * @throws OCSBadRequestException
-	 */
-	private function getFormattedShares(
-		string $viewer,
-		$node = null,
-		bool $sharedWithMe = false,
-		bool $reShares = false,
-		bool $subFiles = false,
-		bool $includeTags = false,
-	): array {
-		if ($sharedWithMe) {
-			return $this->getSharedWithMe($node, $includeTags);
-		}
-
-		if ($subFiles) {
-			return $this->getSharesInDir($node);
-		}
-
-		$shares = $this->getSharesFromNode($viewer, $node, $reShares);
-
-		$known = $formatted = $miniFormatted = [];
-		$resharingRight = false;
-		foreach ($shares as $share) {
-			try {
-				$share->getNode();
-			} catch (NotFoundException $e) {
-				/*
+    private ?Node $lockedNode = null;
+
+    /**
+     * Share20OCS constructor.
+     */
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private IManager $shareManager,
+        private IGroupManager $groupManager,
+        private IUserManager $userManager,
+        private IRootFolder $rootFolder,
+        private IURLGenerator $urlGenerator,
+        private IL10N $l,
+        private IConfig $config,
+        private IAppManager $appManager,
+        private ContainerInterface $serverContainer,
+        private IUserStatusManager $userStatusManager,
+        private IPreview $previewManager,
+        private IDateTimeZone $dateTimeZone,
+        private LoggerInterface $logger,
+        private IProviderFactory $factory,
+        private IMailer $mailer,
+        private ITagManager $tagManager,
+        private ?string $userId = null,
+    ) {
+        parent::__construct($appName, $request);
+    }
+
+    /**
+     * Convert an IShare to an array for OCS output
+     *
+     * @param IShare $share
+     * @param Node|null $recipientNode
+     * @return Files_SharingShare
+     * @throws NotFoundException In case the node can't be resolved.
+     *
+     * @suppress PhanUndeclaredClassMethod
+     */
+    protected function formatShare(IShare $share, ?Node $recipientNode = null): array {
+        $sharedBy = $this->userManager->get($share->getSharedBy());
+        $shareOwner = $this->userManager->get($share->getShareOwner());
+
+        $isOwnShare = false;
+        if ($shareOwner !== null) {
+            $isOwnShare = $shareOwner->getUID() === $this->userId;
+        }
+
+        $result = [
+            'id' => $share->getId(),
+            'share_type' => $share->getShareType(),
+            'uid_owner' => $share->getSharedBy(),
+            'displayname_owner' => $sharedBy !== null ? $sharedBy->getDisplayName() : $share->getSharedBy(),
+            // recipient permissions
+            'permissions' => $share->getPermissions(),
+            // current user permissions on this share
+            'can_edit' => $this->canEditShare($share),
+            'can_delete' => $this->canDeleteShare($share),
+            'stime' => $share->getShareTime()->getTimestamp(),
+            'parent' => null,
+            'expiration' => null,
+            'token' => null,
+            'uid_file_owner' => $share->getShareOwner(),
+            'note' => $share->getNote(),
+            'label' => $share->getLabel(),
+            'displayname_file_owner' => $shareOwner !== null ? $shareOwner->getDisplayName() : $share->getShareOwner(),
+        ];
+
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        if ($recipientNode) {
+            $node = $recipientNode;
+        } else {
+            $node = $userFolder->getFirstNodeById($share->getNodeId());
+            if (!$node) {
+                // fallback to guessing the path
+                $node = $userFolder->get($share->getTarget());
+                if ($node === null || $share->getTarget() === '') {
+                    throw new NotFoundException();
+                }
+            }
+        }
+
+        $result['path'] = $userFolder->getRelativePath($node->getPath());
+        if ($node instanceof Folder) {
+            $result['item_type'] = 'folder';
+        } else {
+            $result['item_type'] = 'file';
+        }
+
+        // Get the original node permission if the share owner is the current user
+        if ($isOwnShare) {
+            $result['item_permissions'] = $node->getPermissions();
+        }
+
+        // If we're on the recipient side, the node permissions
+        // are bound to the share permissions. So we need to
+        // adjust the permissions to the share permissions if necessary.
+        if (!$isOwnShare) {
+            $result['item_permissions'] = $share->getPermissions();
+
+            // For some reason, single files share are forbidden to have the delete permission
+            // since we have custom methods to check those, let's adjust straight away.
+            // DAV permissions does not have that issue though.
+            if ($this->canDeleteShare($share) || $this->canDeleteShareFromSelf($share)) {
+                $result['item_permissions'] |= Constants::PERMISSION_DELETE;
+            }
+            if ($this->canEditShare($share)) {
+                $result['item_permissions'] |= Constants::PERMISSION_UPDATE;
+            }
+        }
+
+        // See MOUNT_ROOT_PROPERTYNAME dav property
+        $result['is-mount-root'] = $node->getInternalPath() === '';
+        $result['mount-type'] = $node->getMountPoint()->getMountType();
+
+        $result['mimetype'] = $node->getMimetype();
+        $result['has_preview'] = $this->previewManager->isAvailable($node);
+        $result['storage_id'] = $node->getStorage()->getId();
+        $result['storage'] = $node->getStorage()->getCache()->getNumericStorageId();
+        $result['item_source'] = $node->getId();
+        $result['file_source'] = $node->getId();
+        $result['file_parent'] = $node->getParent()->getId();
+        $result['file_target'] = $share->getTarget();
+        $result['item_size'] = $node->getSize();
+        $result['item_mtime'] = $node->getMTime();
+
+        $expiration = $share->getExpirationDate();
+        if ($expiration !== null) {
+            $expiration->setTimezone($this->dateTimeZone->getTimeZone());
+            $result['expiration'] = $expiration->format('Y-m-d 00:00:00');
+        }
+
+        if ($share->getShareType() === IShare::TYPE_USER) {
+            $sharedWith = $this->userManager->get($share->getSharedWith());
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = $sharedWith !== null ? $sharedWith->getDisplayName() : $share->getSharedWith();
+            $result['share_with_displayname_unique'] = $sharedWith !== null ? (
+                !empty($sharedWith->getSystemEMailAddress()) ? $sharedWith->getSystemEMailAddress() : $sharedWith->getUID()
+            ) : $share->getSharedWith();
+
+            $userStatuses = $this->userStatusManager->getUserStatuses([$share->getSharedWith()]);
+            $userStatus = array_shift($userStatuses);
+            if ($userStatus) {
+                $result['status'] = [
+                    'status' => $userStatus->getStatus(),
+                    'message' => $userStatus->getMessage(),
+                    'icon' => $userStatus->getIcon(),
+                    'clearAt' => $userStatus->getClearAt()
+                        ? (int)$userStatus->getClearAt()->format('U')
+                        : null,
+                ];
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+            $group = $this->groupManager->get($share->getSharedWith());
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = $group !== null ? $group->getDisplayName() : $share->getSharedWith();
+        } elseif ($share->getShareType() === IShare::TYPE_LINK) {
+
+            // "share_with" and "share_with_displayname" for passwords of link
+            // shares was deprecated in Nextcloud 15, use "password" instead.
+            $result['share_with'] = $share->getPassword();
+            $result['share_with_displayname'] = '(' . $this->l->t('Shared link') . ')';
+
+            $result['password'] = $share->getPassword();
+
+            $result['send_password_by_talk'] = $share->getSendPasswordByTalk();
+
+            $result['token'] = $share->getToken();
+            $result['url'] = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.showShare', ['token' => $share->getToken()]);
+        } elseif ($share->getShareType() === IShare::TYPE_REMOTE) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = $this->getCachedFederatedDisplayName($share->getSharedWith());
+            $result['token'] = $share->getToken();
+        } elseif ($share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = $this->getDisplayNameFromAddressBook($share->getSharedWith(), 'CLOUD');
+            $result['token'] = $share->getToken();
+        } elseif ($share->getShareType() === IShare::TYPE_EMAIL) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['password'] = $share->getPassword();
+            $result['password_expiration_time'] = $share->getPasswordExpirationTime() !== null ? $share->getPasswordExpirationTime()->format(\DateTime::ATOM) : null;
+            $result['send_password_by_talk'] = $share->getSendPasswordByTalk();
+            $result['share_with_displayname'] = $this->getDisplayNameFromAddressBook($share->getSharedWith(), 'EMAIL');
+            $result['token'] = $share->getToken();
+        } elseif ($share->getShareType() === IShare::TYPE_CIRCLE) {
+            // getSharedWith() returns either "name (type, owner)" or
+            // "name (type, owner) [id]", depending on the Teams app version.
+            $hasCircleId = (substr($share->getSharedWith(), -1) === ']');
+
+            $result['share_with_displayname'] = $share->getSharedWithDisplayName();
+            if (empty($result['share_with_displayname'])) {
+                $displayNameLength = ($hasCircleId ? strrpos($share->getSharedWith(), ' ') : strlen($share->getSharedWith()));
+                $result['share_with_displayname'] = substr($share->getSharedWith(), 0, $displayNameLength);
+            }
+
+            $result['share_with_avatar'] = $share->getSharedWithAvatar();
+
+            $shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
+            $shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
+            if ($shareWithLength === false) {
+                $result['share_with'] = substr($share->getSharedWith(), $shareWithStart);
+            } else {
+                $result['share_with'] = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_ROOM) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                /** @var array{share_with_displayname: string, share_with_link: string, share_with?: string, token?: string} $roomShare */
+                $roomShare = $this->getRoomShareHelper()->formatShare($share);
+                $result = array_merge($result, $roomShare);
+            } catch (ContainerExceptionInterface $e) {
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_DECK) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                /** @var array{share_with: string, share_with_displayname: string, share_with_link: string} $deckShare */
+                $deckShare = $this->getDeckShareHelper()->formatShare($share);
+                $result = array_merge($result, $deckShare);
+            } catch (ContainerExceptionInterface $e) {
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
+            $result['share_with'] = $share->getSharedWith();
+            $result['share_with_displayname'] = '';
+
+            try {
+                /** @var array{share_with: string, share_with_displayname: string, token: string} $scienceMeshShare */
+                $scienceMeshShare = $this->getSciencemeshShareHelper()->formatShare($share);
+                $result = array_merge($result, $scienceMeshShare);
+            } catch (ContainerExceptionInterface $e) {
+            }
+        }
+
+
+        $result['mail_send'] = $share->getMailSend() ? 1 : 0;
+        $result['hide_download'] = $share->getHideDownload() ? 1 : 0;
+
+        $result['attributes'] = null;
+        if ($attributes = $share->getAttributes()) {
+            $result['attributes'] = (string)\json_encode($attributes->toArray());
+        }
+
+        return $result;
+    }
+
+    /**
+     * Check if one of the users address books knows the exact property, if
+     * not we return the full name.
+     *
+     * @param string $query
+     * @param string $property
+     * @return string
+     */
+    private function getDisplayNameFromAddressBook(string $query, string $property): string {
+        // FIXME: If we inject the contacts manager it gets initialized before any address books are registered
+        try {
+            $result = Server::get(\OCP\Contacts\IManager::class)->search($query, [$property], [
+                'limit' => 1,
+                'enumeration' => false,
+                'strict_search' => true,
+            ]);
+        } catch (Exception $e) {
+            $this->logger->error(
+                $e->getMessage(),
+                ['exception' => $e]
+            );
+            return $query;
+        }
+
+        foreach ($result as $r) {
+            foreach ($r[$property] as $value) {
+                if ($value === $query && $r['FN']) {
+                    return $r['FN'];
+                }
+            }
+        }
+
+        return $query;
+    }
+
+
+    /**
+     * @param list<Files_SharingShare> $shares
+     * @param array<string, string>|null $updatedDisplayName
+     *
+     * @return list<Files_SharingShare>
+     */
+    private function fixMissingDisplayName(array $shares, ?array $updatedDisplayName = null): array {
+        $userIds = $updated = [];
+        foreach ($shares as $share) {
+            // share is federated and share have no display name yet
+            if ($share['share_type'] === IShare::TYPE_REMOTE
+                && ($share['share_with'] ?? '') !== ''
+                && ($share['share_with_displayname'] ?? '') === '') {
+                $userIds[] = $userId = $share['share_with'];
+
+                if ($updatedDisplayName !== null && array_key_exists($userId, $updatedDisplayName)) {
+                    $share['share_with_displayname'] = $updatedDisplayName[$userId];
+                }
+            }
+
+            // prepping userIds with displayName to be updated
+            $updated[] = $share;
+        }
+
+        // if $updatedDisplayName is not null, it means we should have already fixed displayNames of the shares
+        if ($updatedDisplayName !== null) {
+            return $updated;
+        }
+
+        // get displayName for the generated list of userId with no displayName
+        $displayNames = $this->retrieveFederatedDisplayName($userIds);
+
+        // if no displayName are updated, we exit
+        if (empty($displayNames)) {
+            return $updated;
+        }
+
+        // let's fix missing display name and returns all shares
+        return $this->fixMissingDisplayName($shares, $displayNames);
+    }
+
+
+    /**
+     * get displayName of a list of userIds from the lookup-server; through the globalsiteselector app.
+     * returns an array with userIds as keys and displayName as values.
+     *
+     * @param array $userIds
+     * @param bool $cacheOnly - do not reach LUS, get data from cache.
+     *
+     * @return array
+     * @throws ContainerExceptionInterface
+     */
+    private function retrieveFederatedDisplayName(array $userIds, bool $cacheOnly = false): array {
+        // check if gss is enabled and available
+        if (count($userIds) === 0
+            || !$this->appManager->isEnabledForAnyone('globalsiteselector')
+            || !class_exists('\OCA\GlobalSiteSelector\Service\SlaveService')) {
+            return [];
+        }
+
+        try {
+            $slaveService = Server::get(SlaveService::class);
+        } catch (\Throwable $e) {
+            $this->logger->error(
+                $e->getMessage(),
+                ['exception' => $e]
+            );
+            return [];
+        }
+
+        return $slaveService->getUsersDisplayName($userIds, $cacheOnly);
+    }
+
+
+    /**
+     * retrieve displayName from cache if available (should be used on federated shares)
+     * if not available in cache/lus, try for get from address-book, else returns empty string.
+     *
+     * @param string $userId
+     * @param bool $cacheOnly if true will not reach the lus but will only get data from cache
+     *
+     * @return string
+     */
+    private function getCachedFederatedDisplayName(string $userId, bool $cacheOnly = true): string {
+        $details = $this->retrieveFederatedDisplayName([$userId], $cacheOnly);
+        if (array_key_exists($userId, $details)) {
+            return $details[$userId];
+        }
+
+        $displayName = $this->getDisplayNameFromAddressBook($userId, 'CLOUD');
+        return ($displayName === $userId) ? '' : $displayName;
+    }
+
+
+
+    /**
+     * Get a specific share by id
+     *
+     * @param string $id ID of the share
+     * @param bool $include_tags Include tags in the share
+     * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
+     * @throws OCSNotFoundException Share not found
+     *
+     * 200: Share returned
+     */
+    #[NoAdminRequired]
+    public function getShare(string $id, bool $include_tags = false): DataResponse {
+        try {
+            $share = $this->getShareById($id);
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        try {
+            if ($this->canAccessShare($share)) {
+                $share = $this->formatShare($share);
+
+                if ($include_tags) {
+                    $share = $this->populateTags([$share]);
+                } else {
+                    $share = [$share];
+                }
+
+                return new DataResponse($share);
+            }
+        } catch (NotFoundException $e) {
+            // Fall through
+        }
+
+        throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+    }
+
+    /**
+     * Delete a share
+     *
+     * @param string $id ID of the share
+     * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
+     * @throws OCSNotFoundException Share not found
+     * @throws OCSForbiddenException Missing permissions to delete the share
+     *
+     * 200: Share deleted successfully
+     */
+    #[NoAdminRequired]
+    public function deleteShare(string $id): DataResponse {
+        try {
+            $share = $this->getShareById($id);
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        try {
+            $this->lock($share->getNode());
+        } catch (LockedException $e) {
+            throw new OCSNotFoundException($this->l->t('Could not delete share'));
+        }
+
+        if (!$this->canAccessShare($share)) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        // if it's a group share or a room share
+        // we don't delete the share, but only the
+        // mount point. Allowing it to be restored
+        // from the deleted shares
+        if ($this->canDeleteShareFromSelf($share)) {
+            $this->shareManager->deleteFromSelf($share, $this->userId);
+        } else {
+            if (!$this->canDeleteShare($share)) {
+                throw new OCSForbiddenException($this->l->t('Could not delete share'));
+            }
+
+            $this->shareManager->deleteShare($share);
+        }
+
+        return new DataResponse();
+    }
+
+    /**
+     * Create a share
+     *
+     * @param string|null $path Path of the share
+     * @param int|null $permissions Permissions for the share
+     * @param int $shareType Type of the share
+     * @param ?string $shareWith The entity this should be shared with
+     * @param 'true'|'false'|null $publicUpload If public uploading is allowed (deprecated)
+     * @param string $password Password for the share
+     * @param string|null $sendPasswordByTalk Send the password for the share over Talk
+     * @param ?string $expireDate The expiry date of the share in the user's timezone at 00:00.
+     *                            If $expireDate is not supplied or set to `null`, the system default will be used.
+     * @param string $note Note for the share
+     * @param string $label Label for the share (only used in link and email)
+     * @param string|null $attributes Additional attributes for the share
+     * @param 'false'|'true'|null $sendMail Send a mail to the recipient
+     *
+     * @return DataResponse<Http::STATUS_OK, Files_SharingShare, array{}>
+     * @throws OCSBadRequestException Unknown share type
+     * @throws OCSException
+     * @throws OCSForbiddenException Creating the share is not allowed
+     * @throws OCSNotFoundException Creating the share failed
+     * @suppress PhanUndeclaredClassMethod
+     *
+     * 200: Share created
+     */
+    #[NoAdminRequired]
+    #[UserRateLimit(limit: 20, period: 600)]
+    public function createShare(
+        ?string $path = null,
+        ?int $permissions = null,
+        int $shareType = -1,
+        ?string $shareWith = null,
+        ?string $publicUpload = null,
+        string $password = '',
+        ?string $sendPasswordByTalk = null,
+        ?string $expireDate = null,
+        string $note = '',
+        string $label = '',
+        ?string $attributes = null,
+        ?string $sendMail = null,
+    ): DataResponse {
+        assert($this->userId !== null);
+
+        $share = $this->shareManager->newShare();
+        $hasPublicUpload = $this->getLegacyPublicUpload($publicUpload);
+
+        // Verify path
+        if ($path === null) {
+            throw new OCSNotFoundException($this->l->t('Please specify a file or folder path'));
+        }
+
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        try {
+            /** @var \OC\Files\Node\Node $node */
+            $node = $userFolder->get($path);
+        } catch (NotFoundException $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong path, file/folder does not exist'));
+        }
+
+        // a user can have access to a file through different paths, with differing permissions
+        // combine all permissions to determine if the user can share this file
+        $nodes = $userFolder->getById($node->getId());
+        foreach ($nodes as $nodeById) {
+            /** @var FileInfo $fileInfo */
+            $fileInfo = $node->getFileInfo();
+            $fileInfo['permissions'] |= $nodeById->getPermissions();
+        }
+
+        $share->setNode($node);
+
+        try {
+            $this->lock($share->getNode());
+        } catch (LockedException $e) {
+            throw new OCSNotFoundException($this->l->t('Could not create share'));
+        }
+
+        // Set permissions
+        if ($shareType === IShare::TYPE_LINK || $shareType === IShare::TYPE_EMAIL) {
+            $permissions = $this->getLinkSharePermissions($permissions, $hasPublicUpload);
+            $this->validateLinkSharePermissions($node, $permissions, $hasPublicUpload);
+        } else {
+            // Use default permissions only for non-link shares to keep legacy behavior
+            if ($permissions === null) {
+                $permissions = (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL);
+            }
+            // Non-link shares always require read permissions (link shares could be file drop)
+            $permissions |= Constants::PERMISSION_READ;
+        }
+
+        // For legacy reasons the API allows to pass PERMISSIONS_ALL even for single file shares (I look at you Talk)
+        if ($node instanceof File) {
+            // if this is a single file share we remove the DELETE and CREATE permissions
+            $permissions = $permissions & ~(Constants::PERMISSION_DELETE | Constants::PERMISSION_CREATE);
+        }
+
+        /**
+         * Hack for https://github.com/owncloud/core/issues/22587
+         * We check the permissions via webdav. But the permissions of the mount point
+         * do not equal the share permissions. Here we fix that for federated mounts.
+         */
+        if ($node->getStorage()->instanceOfStorage(Storage::class)) {
+            $permissions &= ~($permissions & ~$node->getPermissions());
+        }
+
+        if ($attributes !== null) {
+            $share = $this->setShareAttributes($share, $attributes);
+        }
+
+        // Expire date checks
+        // Normally, null means no expiration date but we still set the default for backwards compatibility
+        // If the client sends an empty string, we set noExpirationDate to true
+        if ($expireDate !== null) {
+            if ($expireDate !== '') {
+                try {
+                    $expireDateTime = $this->parseDate($expireDate);
+                    $share->setExpirationDate($expireDateTime);
+                } catch (\Exception $e) {
+                    throw new OCSNotFoundException($e->getMessage(), $e);
+                }
+            } else {
+                // Client sent empty string for expire date.
+                // Set noExpirationDate to true so overwrite is prevented.
+                $share->setNoExpirationDate(true);
+            }
+        }
+
+        $share->setSharedBy($this->userId);
+
+        // Handle mail send
+        if (is_null($sendMail)) {
+            $allowSendMail = $this->config->getSystemValueBool('sharing.enable_share_mail', true);
+            if ($allowSendMail !== true || $shareType === IShare::TYPE_EMAIL) {
+                // Define a default behavior when sendMail is not provided
+                // For email shares with a valid recipient, the default is to send the mail
+                // For all other share types, the default is to not send the mail
+                $allowSendMail = ($shareType === IShare::TYPE_EMAIL && $shareWith !== null && $shareWith !== '');
+            }
+            $share->setMailSend($allowSendMail);
+        } else {
+            $share->setMailSend($sendMail === 'true');
+        }
+
+        if ($shareType === IShare::TYPE_USER) {
+            // Valid user is required to share
+            if ($shareWith === null || !$this->userManager->userExists($shareWith)) {
+                throw new OCSNotFoundException($this->l->t('Please specify a valid account to share with'));
+            }
+            $share->setSharedWith($shareWith);
+            $share->setPermissions($permissions);
+        } elseif ($shareType === IShare::TYPE_GROUP) {
+            if (!$this->shareManager->allowGroupSharing()) {
+                throw new OCSNotFoundException($this->l->t('Group sharing is disabled by the administrator'));
+            }
+
+            // Valid group is required to share
+            if ($shareWith === null || !$this->groupManager->groupExists($shareWith)) {
+                throw new OCSNotFoundException($this->l->t('Please specify a valid group'));
+            }
+            $share->setSharedWith($shareWith);
+            $share->setPermissions($permissions);
+        } elseif ($shareType === IShare::TYPE_LINK
+            || $shareType === IShare::TYPE_EMAIL) {
+
+            // Can we even share links?
+            if (!$this->shareManager->shareApiAllowLinks()) {
+                throw new OCSNotFoundException($this->l->t('Public link sharing is disabled by the administrator'));
+            }
+
+            $this->validateLinkSharePermissions($node, $permissions, $hasPublicUpload);
+            $share->setPermissions($permissions);
+
+            // Set password
+            if ($password !== '') {
+                $share->setPassword($password);
+            }
+
+            // Only share by mail have a recipient
+            if (is_string($shareWith) && $shareType === IShare::TYPE_EMAIL) {
+                // If sending a mail have been requested, validate the mail address
+                if ($share->getMailSend() && !$this->mailer->validateMailAddress($shareWith)) {
+                    throw new OCSNotFoundException($this->l->t('Please specify a valid email address'));
+                }
+                $share->setSharedWith($shareWith);
+            }
+
+            // If we have a label, use it
+            if ($label !== '') {
+                if (strlen($label) > 255) {
+                    throw new OCSBadRequestException('Maximum label length is 255');
+                }
+                $share->setLabel($label);
+            }
+
+            if ($sendPasswordByTalk === 'true') {
+                if (!$this->appManager->isEnabledForUser('spreed')) {
+                    throw new OCSForbiddenException($this->l->t('Sharing %s sending the password by Nextcloud Talk failed because Nextcloud Talk is not enabled', [$node->getPath()]));
+                }
+
+                $share->setSendPasswordByTalk(true);
+            }
+        } elseif ($shareType === IShare::TYPE_REMOTE) {
+            if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
+                throw new OCSForbiddenException($this->l->t('Sharing %1$s failed because the back end does not allow shares from type %2$s', [$node->getPath(), $shareType]));
+            }
+
+            if ($shareWith === null) {
+                throw new OCSNotFoundException($this->l->t('Please specify a valid federated account ID'));
+            }
+
+            $share->setSharedWith($shareWith);
+            $share->setPermissions($permissions);
+            $share->setSharedWithDisplayName($this->getCachedFederatedDisplayName($shareWith, false));
+        } elseif ($shareType === IShare::TYPE_REMOTE_GROUP) {
+            if (!$this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
+                throw new OCSForbiddenException($this->l->t('Sharing %1$s failed because the back end does not allow shares from type %2$s', [$node->getPath(), $shareType]));
+            }
+
+            if ($shareWith === null) {
+                throw new OCSNotFoundException($this->l->t('Please specify a valid federated group ID'));
+            }
+
+            $share->setSharedWith($shareWith);
+            $share->setPermissions($permissions);
+        } elseif ($shareType === IShare::TYPE_CIRCLE) {
+            if (!Server::get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) {
+                throw new OCSNotFoundException($this->l->t('You cannot share to a Team if the app is not enabled'));
+            }
+
+            $circle = Circles::detailsCircle($shareWith);
+
+            // Valid team is required to share
+            if ($circle === null) {
+                throw new OCSNotFoundException($this->l->t('Please specify a valid team'));
+            }
+            $share->setSharedWith($shareWith);
+            $share->setPermissions($permissions);
+        } elseif ($shareType === IShare::TYPE_ROOM) {
+            try {
+                $this->getRoomShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
+            } catch (ContainerExceptionInterface $e) {
+                throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support room shares', [$node->getPath()]));
+            }
+        } elseif ($shareType === IShare::TYPE_DECK) {
+            try {
+                $this->getDeckShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
+            } catch (ContainerExceptionInterface $e) {
+                throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support room shares', [$node->getPath()]));
+            }
+        } elseif ($shareType === IShare::TYPE_SCIENCEMESH) {
+            try {
+                $this->getSciencemeshShareHelper()->createShare($share, $shareWith, $permissions, $expireDate ?? '');
+            } catch (ContainerExceptionInterface $e) {
+                throw new OCSForbiddenException($this->l->t('Sharing %s failed because the back end does not support ScienceMesh shares', [$node->getPath()]));
+            }
+        } else {
+            throw new OCSBadRequestException($this->l->t('Unknown share type'));
+        }
+
+        $share->setShareType($shareType);
+        $this->checkInheritedAttributes($share);
+
+        if ($note !== '') {
+            $share->setNote($note);
+        }
+
+        try {
+            $share = $this->shareManager->createShare($share);
+        } catch (HintException $e) {
+            $code = $e->getCode() === 0 ? 403 : $e->getCode();
+            throw new OCSException($e->getHint(), $code);
+        } catch (GenericShareException|\InvalidArgumentException $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSForbiddenException($e->getMessage(), $e);
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSForbiddenException('Failed to create share.', $e);
+        }
+
+        $output = $this->formatShare($share);
+
+        return new DataResponse($output);
+    }
+
+    /**
+     * @param null|Node $node
+     * @param boolean $includeTags
+     *
+     * @return list<Files_SharingShare>
+     */
+    private function getSharedWithMe($node, bool $includeTags): array {
+        $userShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_USER, $node, -1, 0);
+        $groupShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_GROUP, $node, -1, 0);
+        $circleShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_CIRCLE, $node, -1, 0);
+        $roomShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_ROOM, $node, -1, 0);
+        $deckShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_DECK, $node, -1, 0);
+        $sciencemeshShares = $this->shareManager->getSharedWith($this->userId, IShare::TYPE_SCIENCEMESH, $node, -1, 0);
+
+        $shares = array_merge($userShares, $groupShares, $circleShares, $roomShares, $deckShares, $sciencemeshShares);
+
+        $filteredShares = array_filter($shares, function (IShare $share) {
+            return $share->getShareOwner() !== $this->userId;
+        });
+
+        $formatted = [];
+        foreach ($filteredShares as $share) {
+            if ($this->canAccessShare($share)) {
+                try {
+                    $formatted[] = $this->formatShare($share);
+                } catch (NotFoundException $e) {
+                    // Ignore this share
+                }
+            }
+        }
+
+        if ($includeTags) {
+            $formatted = $this->populateTags($formatted);
+        }
+
+        return $formatted;
+    }
+
+    /**
+     * @param Node $folder
+     *
+     * @return list<Files_SharingShare>
+     * @throws OCSBadRequestException
+     * @throws NotFoundException
+     */
+    private function getSharesInDir(Node $folder): array {
+        if (!($folder instanceof Folder)) {
+            throw new OCSBadRequestException($this->l->t('Not a directory'));
+        }
+
+        $nodes = $folder->getDirectoryListing();
+
+        /** @var IShare[] $shares */
+        $shares = array_reduce($nodes, function ($carry, $node) {
+            $carry = array_merge($carry, $this->getAllShares($node, true));
+            return $carry;
+        }, []);
+
+        // filter out duplicate shares
+        $known = [];
+
+        $formatted = $miniFormatted = [];
+        $resharingRight = false;
+        $known = [];
+        foreach ($shares as $share) {
+            if (in_array($share->getId(), $known) || $share->getSharedWith() === $this->userId) {
+                continue;
+            }
+
+            try {
+                $format = $this->formatShare($share);
+
+                $known[] = $share->getId();
+                $formatted[] = $format;
+                if ($share->getSharedBy() === $this->userId) {
+                    $miniFormatted[] = $format;
+                }
+                if (!$resharingRight && $this->shareProviderResharingRights($this->userId, $share, $folder)) {
+                    $resharingRight = true;
+                }
+            } catch (\Exception $e) {
+                //Ignore this share
+            }
+        }
+
+        if (!$resharingRight) {
+            $formatted = $miniFormatted;
+        }
+
+        return $formatted;
+    }
+
+    /**
+     * Get shares of the current user
+     *
+     * @param string $shared_with_me Only get shares with the current user
+     * @param string $reshares Only get shares by the current user and reshares
+     * @param string $subfiles Only get all shares in a folder
+     * @param string $path Get shares for a specific path
+     * @param string $include_tags Include tags in the share
+     *
+     * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
+     * @throws OCSNotFoundException The folder was not found or is inaccessible
+     *
+     * 200: Shares returned
+     */
+    #[NoAdminRequired]
+    public function getShares(
+        string $shared_with_me = 'false',
+        string $reshares = 'false',
+        string $subfiles = 'false',
+        string $path = '',
+        string $include_tags = 'false',
+    ): DataResponse {
+        $node = null;
+        if ($path !== '') {
+            $userFolder = $this->rootFolder->getUserFolder($this->userId);
+            try {
+                $node = $userFolder->get($path);
+                $this->lock($node);
+            } catch (NotFoundException $e) {
+                throw new OCSNotFoundException(
+                    $this->l->t('Wrong path, file/folder does not exist')
+                );
+            } catch (LockedException $e) {
+                throw new OCSNotFoundException($this->l->t('Could not lock node'));
+            }
+        }
+
+        $shares = $this->getFormattedShares(
+            $this->userId,
+            $node,
+            ($shared_with_me === 'true'),
+            ($reshares === 'true'),
+            ($subfiles === 'true'),
+            ($include_tags === 'true')
+        );
+
+        return new DataResponse($shares);
+    }
+
+    private function getLinkSharePermissions(?int $permissions, ?bool $legacyPublicUpload): int {
+        $permissions = $permissions ?? Constants::PERMISSION_READ;
+
+        // Legacy option handling
+        if ($legacyPublicUpload !== null) {
+            $permissions = $legacyPublicUpload
+                ? (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE)
+                : Constants::PERMISSION_READ;
+        }
+
+        // TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones
+        if ($this->hasPermission($permissions, Constants::PERMISSION_READ)
+            && $this->shareManager->outgoingServer2ServerSharesAllowed()) {
+            $permissions |= Constants::PERMISSION_SHARE;
+        }
+
+        return $permissions;
+    }
+
+    /**
+     * Helper to check for legacy "publicUpload" handling.
+     * If the value is set to `true` or `false` then true or false are returned.
+     * Otherwise null is returned to indicate that the option was not (or wrong) set.
+     *
+     * @param null|string $legacyPublicUpload The value of `publicUpload`
+     */
+    private function getLegacyPublicUpload(?string $legacyPublicUpload): ?bool {
+        if ($legacyPublicUpload === 'true') {
+            return true;
+        } elseif ($legacyPublicUpload === 'false') {
+            return false;
+        }
+        // Not set at all
+        return null;
+    }
+
+    /**
+     * For link and email shares validate that only allowed combinations are set.
+     *
+     * @throw OCSBadRequestException If permission combination is invalid.
+     * @throw OCSForbiddenException If public upload was forbidden by the administrator.
+     */
+    private function validateLinkSharePermissions(Node $node, int $permissions, ?bool $legacyPublicUpload): void {
+        if ($legacyPublicUpload && ($node instanceof File)) {
+            throw new OCSBadRequestException($this->l->t('Public upload is only possible for publicly shared folders'));
+        }
+
+        // We need at least READ or CREATE (file drop)
+        if (!$this->hasPermission($permissions, Constants::PERMISSION_READ)
+            && !$this->hasPermission($permissions, Constants::PERMISSION_CREATE)) {
+            throw new OCSBadRequestException($this->l->t('Share must at least have READ or CREATE permissions'));
+        }
+
+        // UPDATE and DELETE require a READ permission
+        if (!$this->hasPermission($permissions, Constants::PERMISSION_READ)
+            && ($this->hasPermission($permissions, Constants::PERMISSION_UPDATE) || $this->hasPermission($permissions, Constants::PERMISSION_DELETE))) {
+            throw new OCSBadRequestException($this->l->t('Share must have READ permission if UPDATE or DELETE permission is set'));
+        }
+
+        // Check if public uploading was disabled
+        if ($this->hasPermission($permissions, Constants::PERMISSION_CREATE)
+            && !$this->shareManager->shareApiLinkAllowPublicUpload()) {
+            throw new OCSForbiddenException($this->l->t('Public upload disabled by the administrator'));
+        }
+    }
+
+    /**
+     * @param string $viewer
+     * @param Node $node
+     * @param bool $sharedWithMe
+     * @param bool $reShares
+     * @param bool $subFiles
+     * @param bool $includeTags
+     *
+     * @return list<Files_SharingShare>
+     * @throws NotFoundException
+     * @throws OCSBadRequestException
+     */
+    private function getFormattedShares(
+        string $viewer,
+        $node = null,
+        bool $sharedWithMe = false,
+        bool $reShares = false,
+        bool $subFiles = false,
+        bool $includeTags = false,
+    ): array {
+        if ($sharedWithMe) {
+            return $this->getSharedWithMe($node, $includeTags);
+        }
+
+        if ($subFiles) {
+            return $this->getSharesInDir($node);
+        }
+
+        $shares = $this->getSharesFromNode($viewer, $node, $reShares);
+
+        $known = $formatted = $miniFormatted = [];
+        $resharingRight = false;
+        foreach ($shares as $share) {
+            try {
+                $share->getNode();
+            } catch (NotFoundException $e) {
+                /*
 				 * Ignore shares where we can't get the node
 				 * For example deleted shares
 				 */
-				continue;
-			}
-
-			if (in_array($share->getId(), $known)
-				|| ($share->getSharedWith() === $this->userId && $share->getShareType() === IShare::TYPE_USER)) {
-				continue;
-			}
-
-			$known[] = $share->getId();
-			try {
-				/** @var IShare $share */
-				$format = $this->formatShare($share, $node);
-				$formatted[] = $format;
-
-				// let's also build a list of shares created
-				// by the current user only, in case
-				// there is no resharing rights
-				if ($share->getSharedBy() === $this->userId) {
-					$miniFormatted[] = $format;
-				}
-
-				// check if one of those share is shared with me
-				// and if I have resharing rights on it
-				if (!$resharingRight && $this->shareProviderResharingRights($this->userId, $share, $node)) {
-					$resharingRight = true;
-				}
-			} catch (InvalidPathException|NotFoundException $e) {
-			}
-		}
-
-		if (!$resharingRight) {
-			$formatted = $miniFormatted;
-		}
-
-		// fix eventual missing display name from federated shares
-		$formatted = $this->fixMissingDisplayName($formatted);
-
-		if ($includeTags) {
-			$formatted = $this->populateTags($formatted);
-		}
-
-		return $formatted;
-	}
-
-
-	/**
-	 * Get all shares relative to a file, including parent folders shares rights
-	 *
-	 * @param string $path Path all shares will be relative to
-	 *
-	 * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
-	 * @throws InvalidPathException
-	 * @throws NotFoundException
-	 * @throws OCSNotFoundException The given path is invalid
-	 * @throws SharingRightsException
-	 *
-	 * 200: Shares returned
-	 */
-	#[NoAdminRequired]
-	public function getInheritedShares(string $path): DataResponse {
-		// get Node from (string) path.
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		try {
-			$node = $userFolder->get($path);
-			$this->lock($node);
-		} catch (NotFoundException $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong path, file/folder does not exist'));
-		} catch (LockedException $e) {
-			throw new OCSNotFoundException($this->l->t('Could not lock path'));
-		}
-
-		if (!($node->getPermissions() & Constants::PERMISSION_SHARE)) {
-			throw new SharingRightsException($this->l->t('no sharing rights on this item'));
-		}
-
-		// The current top parent we have access to
-		$parent = $node;
-
-		// initiate real owner.
-		$owner = $node->getOwner()
-			->getUID();
-		if (!$this->userManager->userExists($owner)) {
-			return new DataResponse([]);
-		}
-
-		// get node based on the owner, fix owner in case of external storage
-		$userFolder = $this->rootFolder->getUserFolder($owner);
-		if ($node->getId() !== $userFolder->getId() && !$userFolder->isSubNode($node)) {
-			$owner = $node->getOwner()
-				->getUID();
-			$userFolder = $this->rootFolder->getUserFolder($owner);
-			$node = $userFolder->getFirstNodeById($node->getId());
-		}
-		$basePath = $userFolder->getPath();
-
-		// generate node list for each parent folders
-		/** @var Node[] $nodes */
-		$nodes = [];
-		while (true) {
-			$node = $node->getParent();
-			if ($node->getPath() === $basePath) {
-				break;
-			}
-			$nodes[] = $node;
-		}
-
-		// The user that is requesting this list
-		$currentUserFolder = $this->rootFolder->getUserFolder($this->userId);
-
-		// for each nodes, retrieve shares.
-		$shares = [];
-
-		foreach ($nodes as $node) {
-			$getShares = $this->getFormattedShares($owner, $node, false, true);
-
-			$currentUserNode = $currentUserFolder->getFirstNodeById($node->getId());
-			if ($currentUserNode) {
-				$parent = $currentUserNode;
-			}
-
-			$subPath = $currentUserFolder->getRelativePath($parent->getPath());
-			foreach ($getShares as &$share) {
-				$share['via_fileid'] = $parent->getId();
-				$share['via_path'] = $subPath;
-			}
-			$this->mergeFormattedShares($shares, $getShares);
-		}
-
-		return new DataResponse(array_values($shares));
-	}
-
-	/**
-	 * Check whether a set of permissions contains the permissions to check.
-	 */
-	private function hasPermission(int $permissionsSet, int $permissionsToCheck): bool {
-		return ($permissionsSet & $permissionsToCheck) === $permissionsToCheck;
-	}
-
-	/**
-	 * Update a share
-	 *
-	 * @param string $id ID of the share
-	 * @param int|null $permissions New permissions
-	 * @param string|null $password New password
-	 * @param string|null $sendPasswordByTalk New condition if the password should be send over Talk
-	 * @param string|null $publicUpload New condition if public uploading is allowed
-	 * @param string|null $expireDate New expiry date
-	 * @param string|null $note New note
-	 * @param string|null $label New label
-	 * @param string|null $hideDownload New condition if the download should be hidden
-	 * @param string|null $attributes New additional attributes
-	 * @param string|null $sendMail if the share should be send by mail.
-	 *                              Considering the share already exists, no mail will be send after the share is updated.
-	 *                              You will have to use the sendMail action to send the mail.
-	 * @param string|null $shareWith New recipient for email shares
-	 * @param string|null $token New token
-	 * @return DataResponse<Http::STATUS_OK, Files_SharingShare, array{}>
-	 * @throws OCSBadRequestException Share could not be updated because the requested changes are invalid
-	 * @throws OCSForbiddenException Missing permissions to update the share
-	 * @throws OCSNotFoundException Share not found
-	 *
-	 * 200: Share updated successfully
-	 */
-	#[NoAdminRequired]
-	public function updateShare(
-		string $id,
-		?int $permissions = null,
-		?string $password = null,
-		?string $sendPasswordByTalk = null,
-		?string $publicUpload = null,
-		?string $expireDate = null,
-		?string $note = null,
-		?string $label = null,
-		?string $hideDownload = null,
-		?string $attributes = null,
-		?string $sendMail = null,
-		?string $token = null,
-	): DataResponse {
-		try {
-			$share = $this->getShareById($id);
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		$this->lock($share->getNode());
-
-		if (!$this->canAccessShare($share, false)) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		if (!$this->canEditShare($share)) {
-			throw new OCSForbiddenException($this->l->t('You are not allowed to edit incoming shares'));
-		}
-
-		if (
-			$permissions === null
-			&& $password === null
-			&& $sendPasswordByTalk === null
-			&& $publicUpload === null
-			&& $expireDate === null
-			&& $note === null
-			&& $label === null
-			&& $hideDownload === null
-			&& $attributes === null
-			&& $sendMail === null
-			&& $token === null
-		) {
-			throw new OCSBadRequestException($this->l->t('Wrong or no update parameter given'));
-		}
-
-		if ($note !== null) {
-			$share->setNote($note);
-		}
-
-		if ($attributes !== null) {
-			$share = $this->setShareAttributes($share, $attributes);
-		}
-
-		// Handle mail send
-		if ($sendMail === 'true' || $sendMail === 'false') {
-			$share->setMailSend($sendMail === 'true');
-		}
-
-		/**
-		 * expiration date, password and publicUpload only make sense for link shares
-		 */
-		if ($share->getShareType() === IShare::TYPE_LINK
-			|| $share->getShareType() === IShare::TYPE_EMAIL) {
-
-			// Update hide download state
-			if ($hideDownload === 'true') {
-				$share->setHideDownload(true);
-			} elseif ($hideDownload === 'false') {
-				$share->setHideDownload(false);
-			}
-
-			// If either manual permissions are specified or publicUpload
-			// then we need to also update the permissions of the share
-			if ($permissions !== null || $publicUpload !== null) {
-				$hasPublicUpload = $this->getLegacyPublicUpload($publicUpload);
-				$permissions = $this->getLinkSharePermissions($permissions ?? Constants::PERMISSION_READ, $hasPublicUpload);
-				$this->validateLinkSharePermissions($share->getNode(), $permissions, $hasPublicUpload);
-				$share->setPermissions($permissions);
-			}
-
-			if ($password === '') {
-				$share->setPassword(null);
-			} elseif ($password !== null) {
-				$share->setPassword($password);
-			}
-
-			if ($label !== null) {
-				if (strlen($label) > 255) {
-					throw new OCSBadRequestException('Maximum label length is 255');
-				}
-				$share->setLabel($label);
-			}
-
-			if ($sendPasswordByTalk === 'true') {
-				if (!$this->appManager->isEnabledForUser('spreed')) {
-					throw new OCSForbiddenException($this->l->t('"Sending the password by Nextcloud Talk" for sharing a file or folder failed because Nextcloud Talk is not enabled.'));
-				}
-
-				$share->setSendPasswordByTalk(true);
-			} elseif ($sendPasswordByTalk !== null) {
-				$share->setSendPasswordByTalk(false);
-			}
-
-			if ($token !== null) {
-				if (!$this->shareManager->allowCustomTokens()) {
-					throw new OCSForbiddenException($this->l->t('Custom share link tokens have been disabled by the administrator'));
-				}
-				if (!$this->validateToken($token)) {
-					throw new OCSBadRequestException($this->l->t('Tokens must contain at least 1 character and may only contain letters, numbers, or a hyphen'));
-				}
-				$share->setToken($token);
-			}
-		}
-
-		// NOT A LINK SHARE
-		else {
-			if ($permissions !== null) {
-				$share->setPermissions($permissions);
-			}
-		}
-
-		if ($expireDate === '') {
-			$share->setExpirationDate(null);
-		} elseif ($expireDate !== null) {
-			try {
-				$expireDateTime = $this->parseDate($expireDate);
-				$share->setExpirationDate($expireDateTime);
-			} catch (\Exception $e) {
-				throw new OCSBadRequestException($e->getMessage(), $e);
-			}
-		}
-
-		try {
-			$this->checkInheritedAttributes($share);
-			$share = $this->shareManager->updateShare($share);
-		} catch (HintException $e) {
-			$code = $e->getCode() === 0 ? 403 : $e->getCode();
-			throw new OCSException($e->getHint(), (int)$code);
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSBadRequestException('Failed to update share.', $e);
-		}
-
-		return new DataResponse($this->formatShare($share));
-	}
-
-	private function validateToken(string $token): bool {
-		if (mb_strlen($token) === 0) {
-			return false;
-		}
-		if (!preg_match('/^[a-z0-9-]+$/i', $token)) {
-			return false;
-		}
-		return true;
-	}
-
-	/**
-	 * Get all shares that are still pending
-	 *
-	 * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
-	 *
-	 * 200: Pending shares returned
-	 */
-	#[NoAdminRequired]
-	public function pendingShares(): DataResponse {
-		$pendingShares = [];
-
-		$shareTypes = [
-			IShare::TYPE_USER,
-			IShare::TYPE_GROUP
-		];
-
-		foreach ($shareTypes as $shareType) {
-			$shares = $this->shareManager->getSharedWith($this->userId, $shareType, null, -1, 0);
-
-			foreach ($shares as $share) {
-				if ($share->getStatus() === IShare::STATUS_PENDING || $share->getStatus() === IShare::STATUS_REJECTED) {
-					$pendingShares[] = $share;
-				}
-			}
-		}
-
-		$result = array_values(array_filter(array_map(function (IShare $share) {
-			$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
-			$node = $userFolder->getFirstNodeById($share->getNodeId());
-			if (!$node) {
-				// fallback to guessing the path
-				$node = $userFolder->get($share->getTarget());
-				if ($node === null || $share->getTarget() === '') {
-					return null;
-				}
-			}
-
-			try {
-				$formattedShare = $this->formatShare($share, $node);
-				$formattedShare['path'] = '/' . $share->getNode()->getName();
-				$formattedShare['permissions'] = 0;
-				return $formattedShare;
-			} catch (NotFoundException $e) {
-				return null;
-			}
-		}, $pendingShares), function ($entry) {
-			return $entry !== null;
-		}));
-
-		return new DataResponse($result);
-	}
-
-	/**
-	 * Accept a share
-	 *
-	 * @param string $id ID of the share
-	 * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
-	 * @throws OCSNotFoundException Share not found
-	 * @throws OCSException
-	 * @throws OCSBadRequestException Share could not be accepted
-	 *
-	 * 200: Share accepted successfully
-	 */
-	#[NoAdminRequired]
-	public function acceptShare(string $id): DataResponse {
-		try {
-			$share = $this->getShareById($id);
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		if (!$this->canAccessShare($share)) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-
-		try {
-			$this->shareManager->acceptShare($share, $this->userId);
-		} catch (HintException $e) {
-			$code = $e->getCode() === 0 ? 403 : $e->getCode();
-			throw new OCSException($e->getHint(), (int)$code);
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSBadRequestException('Failed to accept share.', $e);
-		}
-
-		return new DataResponse();
-	}
-
-	/**
-	 * Does the user have read permission on the share
-	 *
-	 * @param IShare $share the share to check
-	 * @param boolean $checkGroups check groups as well?
-	 * @return boolean
-	 * @throws NotFoundException
-	 *
-	 * @suppress PhanUndeclaredClassMethod
-	 */
-	protected function canAccessShare(IShare $share, bool $checkGroups = true): bool {
-		// A file with permissions 0 can't be accessed by us. So Don't show it
-		if ($share->getPermissions() === 0) {
-			return false;
-		}
-
-		// Owner of the file and the sharer of the file can always get share
-		if ($share->getShareOwner() === $this->userId
-			|| $share->getSharedBy() === $this->userId) {
-			return true;
-		}
-
-		// If the share is shared with you, you can access it!
-		if ($share->getShareType() === IShare::TYPE_USER
-			&& $share->getSharedWith() === $this->userId) {
-			return true;
-		}
-
-		// Have reshare rights on the shared file/folder ?
-		// Does the currentUser have access to the shared file?
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		$file = $userFolder->getFirstNodeById($share->getNodeId());
-		if ($file && $this->shareProviderResharingRights($this->userId, $share, $file)) {
-			return true;
-		}
-
-		// If in the recipient group, you can see the share
-		if ($checkGroups && $share->getShareType() === IShare::TYPE_GROUP) {
-			$sharedWith = $this->groupManager->get($share->getSharedWith());
-			$user = $this->userManager->get($this->userId);
-			if ($user !== null && $sharedWith !== null && $sharedWith->inGroup($user)) {
-				return true;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_CIRCLE) {
-			// TODO: have a sanity check like above?
-			return true;
-		}
-
-		if ($share->getShareType() === IShare::TYPE_ROOM) {
-			try {
-				return $this->getRoomShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_DECK) {
-			try {
-				return $this->getDeckShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
-			try {
-				return $this->getSciencemeshShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Does the user have edit permission on the share
-	 *
-	 * @param IShare $share the share to check
-	 * @return boolean
-	 */
-	protected function canEditShare(IShare $share): bool {
-		// A file with permissions 0 can't be accessed by us. So Don't show it
-		if ($share->getPermissions() === 0) {
-			return false;
-		}
-
-		// The owner of the file and the creator of the share
-		// can always edit the share
-		if ($share->getShareOwner() === $this->userId
-			|| $share->getSharedBy() === $this->userId
-		) {
-			return true;
-		}
-
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		$file = $userFolder->getFirstNodeById($share->getNodeId());
-		if ($file?->getMountPoint() instanceof IShareOwnerlessMount && $this->shareProviderResharingRights($this->userId, $share, $file)) {
-			return true;
-		}
-
-		//! we do NOT support some kind of `admin` in groups.
-		//! You cannot edit shares shared to a group you're
-		//! a member of if you're not the share owner or the file owner!
-
-		return false;
-	}
-
-	/**
-	 * Does the user have delete permission on the share
-	 *
-	 * @param IShare $share the share to check
-	 * @return boolean
-	 */
-	protected function canDeleteShare(IShare $share): bool {
-		// A file with permissions 0 can't be accessed by us. So Don't show it
-		if ($share->getPermissions() === 0) {
-			return false;
-		}
-
-		// if the user is the recipient, i can unshare
-		// the share with self
-		if ($share->getShareType() === IShare::TYPE_USER
-			&& $share->getSharedWith() === $this->userId
-		) {
-			return true;
-		}
-
-		// The owner of the file and the creator of the share
-		// can always delete the share
-		if ($share->getShareOwner() === $this->userId
-			|| $share->getSharedBy() === $this->userId
-		) {
-			return true;
-		}
-
-		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		$file = $userFolder->getFirstNodeById($share->getNodeId());
-		if ($file?->getMountPoint() instanceof IShareOwnerlessMount && $this->shareProviderResharingRights($this->userId, $share, $file)) {
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Does the user have delete permission on the share
-	 * This differs from the canDeleteShare function as it only
-	 * remove the share for the current user. It does NOT
-	 * completely delete the share but only the mount point.
-	 * It can then be restored from the deleted shares section.
-	 *
-	 * @param IShare $share the share to check
-	 * @return boolean
-	 *
-	 * @suppress PhanUndeclaredClassMethod
-	 */
-	protected function canDeleteShareFromSelf(IShare $share): bool {
-		if ($share->getShareType() !== IShare::TYPE_GROUP
-			&& $share->getShareType() !== IShare::TYPE_ROOM
-			&& $share->getShareType() !== IShare::TYPE_DECK
-			&& $share->getShareType() !== IShare::TYPE_SCIENCEMESH
-		) {
-			return false;
-		}
-
-		if ($share->getShareOwner() === $this->userId
-			|| $share->getSharedBy() === $this->userId
-		) {
-			// Delete the whole share, not just for self
-			return false;
-		}
-
-		// If in the recipient group, you can delete the share from self
-		if ($share->getShareType() === IShare::TYPE_GROUP) {
-			$sharedWith = $this->groupManager->get($share->getSharedWith());
-			$user = $this->userManager->get($this->userId);
-			if ($user !== null && $sharedWith !== null && $sharedWith->inGroup($user)) {
-				return true;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_ROOM) {
-			try {
-				return $this->getRoomShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_DECK) {
-			try {
-				return $this->getDeckShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		if ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
-			try {
-				return $this->getSciencemeshShareHelper()->canAccessShare($share, $this->userId);
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Make sure that the passed date is valid ISO 8601
-	 * So YYYY-MM-DD
-	 * If not throw an exception
-	 *
-	 * @param string $expireDate
-	 *
-	 * @throws \Exception
-	 * @return \DateTime
-	 */
-	private function parseDate(string $expireDate): \DateTime {
-		try {
-			$date = new \DateTime(trim($expireDate, '"'), $this->dateTimeZone->getTimeZone());
-			// Make sure it expires at midnight in owner timezone
-			$date->setTime(0, 0, 0);
-		} catch (\Exception $e) {
-			throw new \Exception($this->l->t('Invalid date. Format must be YYYY-MM-DD'));
-		}
-
-		return $date;
-	}
-
-	/**
-	 * Since we have multiple providers but the OCS Share API v1 does
-	 * not support this we need to check all backends.
-	 *
-	 * @param string $id
-	 * @return IShare
-	 * @throws ShareNotFound
-	 */
-	private function getShareById(string $id): IShare {
-		$share = null;
-
-		// First check if it is an internal share.
-		try {
-			$share = $this->shareManager->getShareById('ocinternal:' . $id, $this->userId);
-			return $share;
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-
-		try {
-			if ($this->shareManager->shareProviderExists(IShare::TYPE_CIRCLE)) {
-				$share = $this->shareManager->getShareById('ocCircleShare:' . $id, $this->userId);
-				return $share;
-			}
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-		try {
-			if ($this->shareManager->shareProviderExists(IShare::TYPE_EMAIL)) {
-				$share = $this->shareManager->getShareById('ocMailShare:' . $id, $this->userId);
-				return $share;
-			}
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-		try {
-			$share = $this->shareManager->getShareById('ocRoomShare:' . $id, $this->userId);
-			return $share;
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-		try {
-			if ($this->shareManager->shareProviderExists(IShare::TYPE_DECK)) {
-				$share = $this->shareManager->getShareById('deck:' . $id, $this->userId);
-				return $share;
-			}
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-		try {
-			if ($this->shareManager->shareProviderExists(IShare::TYPE_SCIENCEMESH)) {
-				$share = $this->shareManager->getShareById('sciencemesh:' . $id, $this->userId);
-				return $share;
-			}
-		} catch (ShareNotFound $e) {
-			// Do nothing, just try the other share type
-		}
-
-		if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
-			throw new ShareNotFound();
-		}
-		$share = $this->shareManager->getShareById('ocFederatedSharing:' . $id, $this->userId);
-
-		return $share;
-	}
-
-	/**
-	 * Lock a Node
-	 *
-	 * @param Node $node
-	 * @throws LockedException
-	 */
-	private function lock(Node $node) {
-		$node->lock(ILockingProvider::LOCK_SHARED);
-		$this->lockedNode = $node;
-	}
-
-	/**
-	 * Cleanup the remaining locks
-	 * @throws LockedException
-	 */
-	public function cleanup() {
-		if ($this->lockedNode !== null) {
-			$this->lockedNode->unlock(ILockingProvider::LOCK_SHARED);
-		}
-	}
-
-	/**
-	 * Returns the helper of ShareAPIController for room shares.
-	 *
-	 * If the Talk application is not enabled or the helper is not available
-	 * a ContainerExceptionInterface is thrown instead.
-	 *
-	 * @return \OCA\Talk\Share\Helper\ShareAPIController
-	 * @throws ContainerExceptionInterface
-	 */
-	private function getRoomShareHelper() {
-		if (!$this->appManager->isEnabledForUser('spreed')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\Talk\Share\Helper\ShareAPIController');
-	}
-
-	/**
-	 * Returns the helper of ShareAPIHelper for deck shares.
-	 *
-	 * If the Deck application is not enabled or the helper is not available
-	 * a ContainerExceptionInterface is thrown instead.
-	 *
-	 * @return ShareAPIHelper
-	 * @throws ContainerExceptionInterface
-	 */
-	private function getDeckShareHelper() {
-		if (!$this->appManager->isEnabledForUser('deck')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\Deck\Sharing\ShareAPIHelper');
-	}
-
-	/**
-	 * Returns the helper of ShareAPIHelper for sciencemesh shares.
-	 *
-	 * If the sciencemesh application is not enabled or the helper is not available
-	 * a ContainerExceptionInterface is thrown instead.
-	 *
-	 * @return ShareAPIHelper
-	 * @throws ContainerExceptionInterface
-	 */
-	private function getSciencemeshShareHelper() {
-		if (!$this->appManager->isEnabledForUser('sciencemesh')) {
-			throw new QueryException();
-		}
-
-		return $this->serverContainer->get('\OCA\ScienceMesh\Sharing\ShareAPIHelper');
-	}
-
-	/**
-	 * @param string $viewer
-	 * @param Node $node
-	 * @param bool $reShares
-	 *
-	 * @return IShare[]
-	 */
-	private function getSharesFromNode(string $viewer, $node, bool $reShares): array {
-		$providers = [
-			IShare::TYPE_USER,
-			IShare::TYPE_GROUP,
-			IShare::TYPE_LINK,
-			IShare::TYPE_EMAIL,
-			IShare::TYPE_CIRCLE,
-			IShare::TYPE_ROOM,
-			IShare::TYPE_DECK,
-			IShare::TYPE_SCIENCEMESH
-		];
-
-		// Should we assume that the (currentUser) viewer is the owner of the node !?
-		$shares = [];
-		foreach ($providers as $provider) {
-			if (!$this->shareManager->shareProviderExists($provider)) {
-				continue;
-			}
-
-			$providerShares
-				= $this->shareManager->getSharesBy($viewer, $provider, $node, $reShares, -1, 0);
-			$shares = array_merge($shares, $providerShares);
-		}
-
-		if ($this->shareManager->outgoingServer2ServerSharesAllowed()) {
-			$federatedShares = $this->shareManager->getSharesBy(
-				$this->userId, IShare::TYPE_REMOTE, $node, $reShares, -1, 0
-			);
-			$shares = array_merge($shares, $federatedShares);
-		}
-
-		if ($this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
-			$federatedShares = $this->shareManager->getSharesBy(
-				$this->userId, IShare::TYPE_REMOTE_GROUP, $node, $reShares, -1, 0
-			);
-			$shares = array_merge($shares, $federatedShares);
-		}
-
-		return $shares;
-	}
-
-
-	/**
-	 * @param Node $node
-	 *
-	 * @throws SharingRightsException
-	 */
-	private function confirmSharingRights(Node $node): void {
-		if (!$this->hasResharingRights($this->userId, $node)) {
-			throw new SharingRightsException($this->l->t('No sharing rights on this item'));
-		}
-	}
-
-
-	/**
-	 * @param string $viewer
-	 * @param Node $node
-	 *
-	 * @return bool
-	 */
-	private function hasResharingRights($viewer, $node): bool {
-		if ($viewer === $node->getOwner()->getUID()) {
-			return true;
-		}
-
-		foreach ([$node, $node->getParent()] as $node) {
-			$shares = $this->getSharesFromNode($viewer, $node, true);
-			foreach ($shares as $share) {
-				try {
-					if ($this->shareProviderResharingRights($viewer, $share, $node)) {
-						return true;
-					}
-				} catch (InvalidPathException|NotFoundException $e) {
-				}
-			}
-		}
-
-		return false;
-	}
-
-
-	/**
-	 * Returns if we can find resharing rights in an IShare object for a specific user.
-	 *
-	 * @suppress PhanUndeclaredClassMethod
-	 *
-	 * @param string $userId
-	 * @param IShare $share
-	 * @param Node $node
-	 *
-	 * @return bool
-	 * @throws NotFoundException
-	 * @throws InvalidPathException
-	 */
-	private function shareProviderResharingRights(string $userId, IShare $share, $node): bool {
-		if ($share->getShareOwner() === $userId) {
-			return true;
-		}
-
-		// we check that current user have parent resharing rights on the current file
-		if ($node !== null && ($node->getPermissions() & Constants::PERMISSION_SHARE) !== 0) {
-			return true;
-		}
-
-		if ((Constants::PERMISSION_SHARE & $share->getPermissions()) === 0) {
-			return false;
-		}
-
-		if ($share->getShareType() === IShare::TYPE_USER && $share->getSharedWith() === $userId) {
-			return true;
-		}
-
-		if ($share->getShareType() === IShare::TYPE_GROUP && $this->groupManager->isInGroup($userId, $share->getSharedWith())) {
-			return true;
-		}
-
-		if ($share->getShareType() === IShare::TYPE_CIRCLE && Server::get(IAppManager::class)->isEnabledForUser('circles')
-			&& class_exists('\OCA\Circles\Api\v1\Circles')) {
-			$hasCircleId = (str_ends_with($share->getSharedWith(), ']'));
-			$shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
-			$shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
-			if ($shareWithLength === false) {
-				$sharedWith = substr($share->getSharedWith(), $shareWithStart);
-			} else {
-				$sharedWith = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
-			}
-			try {
-				$member = Circles::getMember($sharedWith, $userId, 1);
-				if ($member->getLevel() >= 4) {
-					return true;
-				}
-				return false;
-			} catch (ContainerExceptionInterface $e) {
-				return false;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Get all the shares for the current user
-	 *
-	 * @param Node|null $path
-	 * @param boolean $reshares
-	 * @return IShare[]
-	 */
-	private function getAllShares(?Node $path = null, bool $reshares = false) {
-		// Get all shares
-		$userShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_USER, $path, $reshares, -1, 0);
-		$groupShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_GROUP, $path, $reshares, -1, 0);
-		$linkShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_LINK, $path, $reshares, -1, 0);
-
-		// EMAIL SHARES
-		$mailShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_EMAIL, $path, $reshares, -1, 0);
-
-		// TEAM SHARES
-		$circleShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_CIRCLE, $path, $reshares, -1, 0);
-
-		// TALK SHARES
-		$roomShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_ROOM, $path, $reshares, -1, 0);
-
-		// DECK SHARES
-		$deckShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_DECK, $path, $reshares, -1, 0);
-
-		// SCIENCEMESH SHARES
-		$sciencemeshShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_SCIENCEMESH, $path, $reshares, -1, 0);
-
-		// FEDERATION
-		if ($this->shareManager->outgoingServer2ServerSharesAllowed()) {
-			$federatedShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_REMOTE, $path, $reshares, -1, 0);
-		} else {
-			$federatedShares = [];
-		}
-		if ($this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
-			$federatedGroupShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_REMOTE_GROUP, $path, $reshares, -1, 0);
-		} else {
-			$federatedGroupShares = [];
-		}
-
-		return array_merge($userShares, $groupShares, $linkShares, $mailShares, $circleShares, $roomShares, $deckShares, $sciencemeshShares, $federatedShares, $federatedGroupShares);
-	}
-
-
-	/**
-	 * merging already formatted shares.
-	 * We'll make an associative array to easily detect duplicate Ids.
-	 * Keys _needs_ to be removed after all shares are retrieved and merged.
-	 *
-	 * @param array $shares
-	 * @param array $newShares
-	 */
-	private function mergeFormattedShares(array &$shares, array $newShares) {
-		foreach ($newShares as $newShare) {
-			if (!array_key_exists($newShare['id'], $shares)) {
-				$shares[$newShare['id']] = $newShare;
-			}
-		}
-	}
-
-	/**
-	 * @param IShare $share
-	 * @param string|null $attributesString
-	 * @return IShare modified share
-	 */
-	private function setShareAttributes(IShare $share, ?string $attributesString) {
-		$newShareAttributes = null;
-		if ($attributesString !== null) {
-			$newShareAttributes = $this->shareManager->newShare()->newAttributes();
-			$formattedShareAttributes = \json_decode($attributesString, true);
-			if (is_array($formattedShareAttributes)) {
-				foreach ($formattedShareAttributes as $formattedAttr) {
-					$newShareAttributes->setAttribute(
-						$formattedAttr['scope'],
-						$formattedAttr['key'],
-						$formattedAttr['value'],
-					);
-				}
-			} else {
-				throw new OCSBadRequestException($this->l->t('Invalid share attributes provided: "%s"', [$attributesString]));
-			}
-		}
-		$share->setAttributes($newShareAttributes);
-
-		return $share;
-	}
-
-	private function checkInheritedAttributes(IShare $share): void {
-		if (!$share->getSharedBy()) {
-			return; // Probably in a test
-		}
-
-		$canDownload = false;
-		$hideDownload = true;
-
-		$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
-		$nodes = $userFolder->getById($share->getNodeId());
-		foreach ($nodes as $node) {
-			// Owner always can download it - so allow it and break
-			if ($node->getOwner()?->getUID() === $share->getSharedBy()) {
-				$canDownload = true;
-				$hideDownload = false;
-				break;
-			}
-
-			if ($node->getStorage()->instanceOfStorage(SharedStorage::class)) {
-				$storage = $node->getStorage();
-				if ($storage instanceof Wrapper) {
-					$storage = $storage->getInstanceOfStorage(SharedStorage::class);
-					if ($storage === null) {
-						throw new \RuntimeException('Should not happen, instanceOfStorage but getInstanceOfStorage return null');
-					}
-				} else {
-					throw new \RuntimeException('Should not happen, instanceOfStorage but not a wrapper');
-				}
-
-				/** @var SharedStorage $storage */
-				$originalShare = $storage->getShare();
-				$inheritedAttributes = $originalShare->getAttributes();
-				// hide if hidden and also the current share enforces hide (can only be false if one share is false or user is owner)
-				$hideDownload = $hideDownload && $originalShare->getHideDownload();
-				// allow download if already allowed by previous share or when the current share allows downloading
-				$canDownload = $canDownload || $inheritedAttributes === null || $inheritedAttributes->getAttribute('permissions', 'download') !== false;
-			} elseif ($node->getStorage()->instanceOfStorage(Storage::class)) {
-				$canDownload = true; // in case of federation storage, we can expect the download to be activated by default
-			}
-		}
-
-		if ($hideDownload || !$canDownload) {
-			$share->setHideDownload(true);
-
-			if (!$canDownload) {
-				$attributes = $share->getAttributes() ?? $share->newAttributes();
-				$attributes->setAttribute('permissions', 'download', false);
-				$share->setAttributes($attributes);
-			}
-		}
-	}
-
-	/**
-	 * Send a mail notification again for a share.
-	 * The mail_send option must be enabled for the given share.
-	 * @param string $id the share ID
-	 * @param string $password the password to check against. Necessary for password protected shares.
-	 * @throws OCSNotFoundException Share not found
-	 * @throws OCSForbiddenException You are not allowed to send mail notifications
-	 * @throws OCSBadRequestException Invalid request or wrong password
-	 * @throws OCSException Error while sending mail notification
-	 * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
-	 *
-	 * 200: The email notification was sent successfully
-	 */
-	#[NoAdminRequired]
-	#[UserRateLimit(limit: 10, period: 600)]
-	public function sendShareEmail(string $id, $password = ''): DataResponse {
-		try {
-			$share = $this->getShareById($id);
-
-			if (!$this->canAccessShare($share, false)) {
-				throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-			}
-
-			if (!$this->canEditShare($share)) {
-				throw new OCSForbiddenException($this->l->t('You are not allowed to send mail notifications'));
-			}
-
-			// For mail and link shares, the user must be
-			// the owner of the share, not only the file owner.
-			if ($share->getShareType() === IShare::TYPE_EMAIL
-				|| $share->getShareType() === IShare::TYPE_LINK) {
-				if ($share->getSharedBy() !== $this->userId) {
-					throw new OCSForbiddenException($this->l->t('You are not allowed to send mail notifications'));
-				}
-			}
-
-			try {
-				$provider = $this->factory->getProviderForType($share->getShareType());
-				if (!($provider instanceof IShareProviderWithNotification)) {
-					throw new OCSBadRequestException($this->l->t('No mail notification configured for this share type'));
-				}
-
-				// Circumvent the password encrypted data by
-				// setting the password clear. We're not storing
-				// the password clear, it is just a temporary
-				// object manipulation. The password will stay
-				// encrypted in the database.
-				if ($share->getPassword() !== null && $share->getPassword() !== $password) {
-					if (!$this->shareManager->checkPassword($share, $password)) {
-						throw new OCSBadRequestException($this->l->t('Wrong password'));
-					}
-					$share = $share->setPassword($password);
-				}
-
-				$provider->sendMailNotification($share);
-				return new DataResponse();
-			} catch (Exception $e) {
-				$this->logger->error($e->getMessage(), ['exception' => $e]);
-				throw new OCSException($this->l->t('Error while sending mail notification'));
-			}
-
-		} catch (ShareNotFound $e) {
-			throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
-		}
-	}
-
-	/**
-	 * Get a unique share token
-	 *
-	 * @throws OCSException Failed to generate a unique token
-	 *
-	 * @return DataResponse<Http::STATUS_OK, array{token: string}, array{}>
-	 *
-	 * 200: Token generated successfully
-	 */
-	#[ApiRoute(verb: 'GET', url: '/api/v1/token')]
-	#[NoAdminRequired]
-	public function generateToken(): DataResponse {
-		try {
-			$token = $this->shareManager->generateToken();
-			return new DataResponse([
-				'token' => $token,
-			]);
-		} catch (ShareTokenException $e) {
-			throw new OCSException($this->l->t('Failed to generate a unique token'));
-		}
-	}
-
-	/**
-	 * Populate the result set with file tags
-	 *
-	 * @psalm-template T of array{tags?: list<string>, file_source: int, ...array<string, mixed>}
-	 * @param list<T> $fileList
-	 * @return list<T> file list populated with tags
-	 */
-	private function populateTags(array $fileList): array {
-		$tagger = $this->tagManager->load('files');
-		$tags = $tagger->getTagsForObjects(array_map(static fn (array $fileData) => $fileData['file_source'], $fileList));
-
-		if (!is_array($tags)) {
-			throw new \UnexpectedValueException('$tags must be an array');
-		}
-
-		// Set empty tag array
-		foreach ($fileList as &$fileData) {
-			$fileData['tags'] = [];
-		}
-		unset($fileData);
-
-		if (!empty($tags)) {
-			foreach ($tags as $fileId => $fileTags) {
-				foreach ($fileList as &$fileData) {
-					if ($fileId !== $fileData['file_source']) {
-						continue;
-					}
-
-					$fileData['tags'] = $fileTags;
-				}
-				unset($fileData);
-			}
-		}
-
-		return $fileList;
-	}
+                continue;
+            }
+
+            if (in_array($share->getId(), $known)
+                || ($share->getSharedWith() === $this->userId && $share->getShareType() === IShare::TYPE_USER)) {
+                continue;
+            }
+
+            $known[] = $share->getId();
+            try {
+                /** @var IShare $share */
+                $format = $this->formatShare($share, $node);
+                $formatted[] = $format;
+
+                // let's also build a list of shares created
+                // by the current user only, in case
+                // there is no resharing rights
+                if ($share->getSharedBy() === $this->userId) {
+                    $miniFormatted[] = $format;
+                }
+
+                // check if one of those share is shared with me
+                // and if I have resharing rights on it
+                if (!$resharingRight && $this->shareProviderResharingRights($this->userId, $share, $node)) {
+                    $resharingRight = true;
+                }
+            } catch (InvalidPathException|NotFoundException $e) {
+            }
+        }
+
+        if (!$resharingRight) {
+            $formatted = $miniFormatted;
+        }
+
+        // fix eventual missing display name from federated shares
+        $formatted = $this->fixMissingDisplayName($formatted);
+
+        if ($includeTags) {
+            $formatted = $this->populateTags($formatted);
+        }
+
+        return $formatted;
+    }
+
+
+    /**
+     * Get all shares relative to a file, including parent folders shares rights
+     *
+     * @param string $path Path all shares will be relative to
+     *
+     * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
+     * @throws InvalidPathException
+     * @throws NotFoundException
+     * @throws OCSNotFoundException The given path is invalid
+     * @throws SharingRightsException
+     *
+     * 200: Shares returned
+     */
+    #[NoAdminRequired]
+    public function getInheritedShares(string $path): DataResponse {
+        // get Node from (string) path.
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        try {
+            $node = $userFolder->get($path);
+            $this->lock($node);
+        } catch (NotFoundException $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong path, file/folder does not exist'));
+        } catch (LockedException $e) {
+            throw new OCSNotFoundException($this->l->t('Could not lock path'));
+        }
+
+        if (!($node->getPermissions() & Constants::PERMISSION_SHARE)) {
+            throw new SharingRightsException($this->l->t('no sharing rights on this item'));
+        }
+
+        // The current top parent we have access to
+        $parent = $node;
+
+        // initiate real owner.
+        $owner = $node->getOwner()
+            ->getUID();
+        if (!$this->userManager->userExists($owner)) {
+            return new DataResponse([]);
+        }
+
+        // get node based on the owner, fix owner in case of external storage
+        $userFolder = $this->rootFolder->getUserFolder($owner);
+        if ($node->getId() !== $userFolder->getId() && !$userFolder->isSubNode($node)) {
+            $owner = $node->getOwner()
+                ->getUID();
+            $userFolder = $this->rootFolder->getUserFolder($owner);
+            $node = $userFolder->getFirstNodeById($node->getId());
+        }
+        $basePath = $userFolder->getPath();
+
+        // generate node list for each parent folders
+        /** @var Node[] $nodes */
+        $nodes = [];
+        while (true) {
+            $node = $node->getParent();
+            if ($node->getPath() === $basePath) {
+                break;
+            }
+            $nodes[] = $node;
+        }
+
+        // The user that is requesting this list
+        $currentUserFolder = $this->rootFolder->getUserFolder($this->userId);
+
+        // for each nodes, retrieve shares.
+        $shares = [];
+
+        foreach ($nodes as $node) {
+            $getShares = $this->getFormattedShares($owner, $node, false, true);
+
+            $currentUserNode = $currentUserFolder->getFirstNodeById($node->getId());
+            if ($currentUserNode) {
+                $parent = $currentUserNode;
+            }
+
+            $subPath = $currentUserFolder->getRelativePath($parent->getPath());
+            foreach ($getShares as &$share) {
+                $share['via_fileid'] = $parent->getId();
+                $share['via_path'] = $subPath;
+            }
+            $this->mergeFormattedShares($shares, $getShares);
+        }
+
+        return new DataResponse(array_values($shares));
+    }
+
+    /**
+     * Check whether a set of permissions contains the permissions to check.
+     */
+    private function hasPermission(int $permissionsSet, int $permissionsToCheck): bool {
+        return ($permissionsSet & $permissionsToCheck) === $permissionsToCheck;
+    }
+
+    /**
+     * Update a share
+     *
+     * @param string $id ID of the share
+     * @param int|null $permissions New permissions
+     * @param string|null $password New password
+     * @param string|null $sendPasswordByTalk New condition if the password should be send over Talk
+     * @param string|null $publicUpload New condition if public uploading is allowed
+     * @param string|null $expireDate New expiry date
+     * @param string|null $note New note
+     * @param string|null $label New label
+     * @param string|null $hideDownload New condition if the download should be hidden
+     * @param string|null $attributes New additional attributes
+     * @param string|null $sendMail if the share should be send by mail.
+     *                              Considering the share already exists, no mail will be send after the share is updated.
+     *                              You will have to use the sendMail action to send the mail.
+     * @param string|null $shareWith New recipient for email shares
+     * @param string|null $token New token
+     * @return DataResponse<Http::STATUS_OK, Files_SharingShare, array{}>
+     * @throws OCSBadRequestException Share could not be updated because the requested changes are invalid
+     * @throws OCSForbiddenException Missing permissions to update the share
+     * @throws OCSNotFoundException Share not found
+     *
+     * 200: Share updated successfully
+     */
+    #[NoAdminRequired]
+    public function updateShare(
+        string $id,
+        ?int $permissions = null,
+        ?string $password = null,
+        ?string $sendPasswordByTalk = null,
+        ?string $publicUpload = null,
+        ?string $expireDate = null,
+        ?string $note = null,
+        ?string $label = null,
+        ?string $hideDownload = null,
+        ?string $attributes = null,
+        ?string $sendMail = null,
+        ?string $token = null,
+    ): DataResponse {
+        try {
+            $share = $this->getShareById($id);
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        $this->lock($share->getNode());
+
+        if (!$this->canAccessShare($share, false)) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        if (!$this->canEditShare($share)) {
+            throw new OCSForbiddenException($this->l->t('You are not allowed to edit incoming shares'));
+        }
+
+        if (
+            $permissions === null
+            && $password === null
+            && $sendPasswordByTalk === null
+            && $publicUpload === null
+            && $expireDate === null
+            && $note === null
+            && $label === null
+            && $hideDownload === null
+            && $attributes === null
+            && $sendMail === null
+            && $token === null
+        ) {
+            throw new OCSBadRequestException($this->l->t('Wrong or no update parameter given'));
+        }
+
+        if ($note !== null) {
+            $share->setNote($note);
+        }
+
+        if ($attributes !== null) {
+            $share = $this->setShareAttributes($share, $attributes);
+        }
+
+        // Handle mail send
+        if ($sendMail === 'true' || $sendMail === 'false') {
+            $share->setMailSend($sendMail === 'true');
+        }
+
+        /**
+         * expiration date, password and publicUpload only make sense for link shares
+         */
+        if ($share->getShareType() === IShare::TYPE_LINK
+            || $share->getShareType() === IShare::TYPE_EMAIL) {
+
+            // Update hide download state
+            if ($hideDownload === 'true') {
+                $share->setHideDownload(true);
+            } elseif ($hideDownload === 'false') {
+                $share->setHideDownload(false);
+            }
+
+            // If either manual permissions are specified or publicUpload
+            // then we need to also update the permissions of the share
+            if ($permissions !== null || $publicUpload !== null) {
+                $hasPublicUpload = $this->getLegacyPublicUpload($publicUpload);
+                $permissions = $this->getLinkSharePermissions($permissions ?? Constants::PERMISSION_READ, $hasPublicUpload);
+                $this->validateLinkSharePermissions($share->getNode(), $permissions, $hasPublicUpload);
+                $share->setPermissions($permissions);
+            }
+
+            if ($password === '') {
+                $share->setPassword(null);
+            } elseif ($password !== null) {
+                $share->setPassword($password);
+            }
+
+            if ($label !== null) {
+                if (strlen($label) > 255) {
+                    throw new OCSBadRequestException('Maximum label length is 255');
+                }
+                $share->setLabel($label);
+            }
+
+            if ($sendPasswordByTalk === 'true') {
+                if (!$this->appManager->isEnabledForUser('spreed')) {
+                    throw new OCSForbiddenException($this->l->t('"Sending the password by Nextcloud Talk" for sharing a file or folder failed because Nextcloud Talk is not enabled.'));
+                }
+
+                $share->setSendPasswordByTalk(true);
+            } elseif ($sendPasswordByTalk !== null) {
+                $share->setSendPasswordByTalk(false);
+            }
+
+            if ($token !== null) {
+                if (!$this->shareManager->allowCustomTokens()) {
+                    throw new OCSForbiddenException($this->l->t('Custom share link tokens have been disabled by the administrator'));
+                }
+                if (!$this->validateToken($token)) {
+                    throw new OCSBadRequestException($this->l->t('Tokens must contain at least 1 character and may only contain letters, numbers, or a hyphen'));
+                }
+                $share->setToken($token);
+            }
+        }
+
+        // NOT A LINK SHARE
+        else {
+            if ($permissions !== null) {
+                $share->setPermissions($permissions);
+            }
+        }
+
+        if ($expireDate === '') {
+            $share->setExpirationDate(null);
+        } elseif ($expireDate !== null) {
+            try {
+                $expireDateTime = $this->parseDate($expireDate);
+                $share->setExpirationDate($expireDateTime);
+            } catch (\Exception $e) {
+                throw new OCSBadRequestException($e->getMessage(), $e);
+            }
+        }
+
+        try {
+            $this->checkInheritedAttributes($share);
+            $share = $this->shareManager->updateShare($share);
+        } catch (HintException $e) {
+            $code = $e->getCode() === 0 ? 403 : $e->getCode();
+            throw new OCSException($e->getHint(), (int)$code);
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSBadRequestException('Failed to update share.', $e);
+        }
+
+        return new DataResponse($this->formatShare($share));
+    }
+
+    private function validateToken(string $token): bool {
+        if (mb_strlen($token) === 0) {
+            return false;
+        }
+        if (!preg_match('/^[a-z0-9-]+$/i', $token)) {
+            return false;
+        }
+        return true;
+    }
+
+    /**
+     * Get all shares that are still pending
+     *
+     * @return DataResponse<Http::STATUS_OK, list<Files_SharingShare>, array{}>
+     *
+     * 200: Pending shares returned
+     */
+    #[NoAdminRequired]
+    public function pendingShares(): DataResponse {
+        $pendingShares = [];
+
+        $shareTypes = [
+            IShare::TYPE_USER,
+            IShare::TYPE_GROUP
+        ];
+
+        foreach ($shareTypes as $shareType) {
+            $shares = $this->shareManager->getSharedWith($this->userId, $shareType, null, -1, 0);
+
+            foreach ($shares as $share) {
+                if ($share->getStatus() === IShare::STATUS_PENDING || $share->getStatus() === IShare::STATUS_REJECTED) {
+                    $pendingShares[] = $share;
+                }
+            }
+        }
+
+        $result = array_values(array_filter(array_map(function (IShare $share) {
+            $userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
+            $node = $userFolder->getFirstNodeById($share->getNodeId());
+            if (!$node) {
+                // fallback to guessing the path
+                $node = $userFolder->get($share->getTarget());
+                if ($node === null || $share->getTarget() === '') {
+                    return null;
+                }
+            }
+
+            try {
+                $formattedShare = $this->formatShare($share, $node);
+                $formattedShare['path'] = '/' . $share->getNode()->getName();
+                $formattedShare['permissions'] = 0;
+                return $formattedShare;
+            } catch (NotFoundException $e) {
+                return null;
+            }
+        }, $pendingShares), function ($entry) {
+            return $entry !== null;
+        }));
+
+        return new DataResponse($result);
+    }
+
+    /**
+     * Accept a share
+     *
+     * @param string $id ID of the share
+     * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
+     * @throws OCSNotFoundException Share not found
+     * @throws OCSException
+     * @throws OCSBadRequestException Share could not be accepted
+     *
+     * 200: Share accepted successfully
+     */
+    #[NoAdminRequired]
+    public function acceptShare(string $id): DataResponse {
+        try {
+            $share = $this->getShareById($id);
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        if (!$this->canAccessShare($share)) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+
+        try {
+            $this->shareManager->acceptShare($share, $this->userId);
+        } catch (HintException $e) {
+            $code = $e->getCode() === 0 ? 403 : $e->getCode();
+            throw new OCSException($e->getHint(), (int)$code);
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSBadRequestException('Failed to accept share.', $e);
+        }
+
+        return new DataResponse();
+    }
+
+    /**
+     * Does the user have read permission on the share
+     *
+     * @param IShare $share the share to check
+     * @param boolean $checkGroups check groups as well?
+     * @return boolean
+     * @throws NotFoundException
+     *
+     * @suppress PhanUndeclaredClassMethod
+     */
+    protected function canAccessShare(IShare $share, bool $checkGroups = true): bool {
+        // A file with permissions 0 can't be accessed by us. So Don't show it
+        if ($share->getPermissions() === 0) {
+            return false;
+        }
+
+        // Owner of the file and the sharer of the file can always get share
+        if ($share->getShareOwner() === $this->userId
+            || $share->getSharedBy() === $this->userId) {
+            return true;
+        }
+
+        // If the share is shared with you, you can access it!
+        if ($share->getShareType() === IShare::TYPE_USER
+            && $share->getSharedWith() === $this->userId) {
+            return true;
+        }
+
+        // Have reshare rights on the shared file/folder ?
+        // Does the currentUser have access to the shared file?
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        $file = $userFolder->getFirstNodeById($share->getNodeId());
+        if ($file && $this->shareProviderResharingRights($this->userId, $share, $file)) {
+            return true;
+        }
+
+        // If in the recipient group, you can see the share
+        if ($checkGroups && $share->getShareType() === IShare::TYPE_GROUP) {
+            $sharedWith = $this->groupManager->get($share->getSharedWith());
+            $user = $this->userManager->get($this->userId);
+            if ($user !== null && $sharedWith !== null && $sharedWith->inGroup($user)) {
+                return true;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_CIRCLE) {
+            // TODO: have a sanity check like above?
+            return true;
+        }
+
+        if ($share->getShareType() === IShare::TYPE_ROOM) {
+            try {
+                return $this->getRoomShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_DECK) {
+            try {
+                return $this->getDeckShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
+            try {
+                return $this->getSciencemeshShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Does the user have edit permission on the share
+     *
+     * @param IShare $share the share to check
+     * @return boolean
+     */
+    protected function canEditShare(IShare $share): bool {
+        // A file with permissions 0 can't be accessed by us. So Don't show it
+        if ($share->getPermissions() === 0) {
+            return false;
+        }
+
+        // The owner of the file and the creator of the share
+        // can always edit the share
+        if ($share->getShareOwner() === $this->userId
+            || $share->getSharedBy() === $this->userId
+        ) {
+            return true;
+        }
+
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        $file = $userFolder->getFirstNodeById($share->getNodeId());
+        if ($file?->getMountPoint() instanceof IShareOwnerlessMount && $this->shareProviderResharingRights($this->userId, $share, $file)) {
+            return true;
+        }
+
+        //! we do NOT support some kind of `admin` in groups.
+        //! You cannot edit shares shared to a group you're
+        //! a member of if you're not the share owner or the file owner!
+
+        return false;
+    }
+
+    /**
+     * Does the user have delete permission on the share
+     *
+     * @param IShare $share the share to check
+     * @return boolean
+     */
+    protected function canDeleteShare(IShare $share): bool {
+        // A file with permissions 0 can't be accessed by us. So Don't show it
+        if ($share->getPermissions() === 0) {
+            return false;
+        }
+
+        // if the user is the recipient, i can unshare
+        // the share with self
+        if ($share->getShareType() === IShare::TYPE_USER
+            && $share->getSharedWith() === $this->userId
+        ) {
+            return true;
+        }
+
+        // The owner of the file and the creator of the share
+        // can always delete the share
+        if ($share->getShareOwner() === $this->userId
+            || $share->getSharedBy() === $this->userId
+        ) {
+            return true;
+        }
+
+        $userFolder = $this->rootFolder->getUserFolder($this->userId);
+        $file = $userFolder->getFirstNodeById($share->getNodeId());
+        if ($file?->getMountPoint() instanceof IShareOwnerlessMount && $this->shareProviderResharingRights($this->userId, $share, $file)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Does the user have delete permission on the share
+     * This differs from the canDeleteShare function as it only
+     * remove the share for the current user. It does NOT
+     * completely delete the share but only the mount point.
+     * It can then be restored from the deleted shares section.
+     *
+     * @param IShare $share the share to check
+     * @return boolean
+     *
+     * @suppress PhanUndeclaredClassMethod
+     */
+    protected function canDeleteShareFromSelf(IShare $share): bool {
+        if ($share->getShareType() !== IShare::TYPE_GROUP
+            && $share->getShareType() !== IShare::TYPE_ROOM
+            && $share->getShareType() !== IShare::TYPE_DECK
+            && $share->getShareType() !== IShare::TYPE_SCIENCEMESH
+        ) {
+            return false;
+        }
+
+        if ($share->getShareOwner() === $this->userId
+            || $share->getSharedBy() === $this->userId
+        ) {
+            // Delete the whole share, not just for self
+            return false;
+        }
+
+        // If in the recipient group, you can delete the share from self
+        if ($share->getShareType() === IShare::TYPE_GROUP) {
+            $sharedWith = $this->groupManager->get($share->getSharedWith());
+            $user = $this->userManager->get($this->userId);
+            if ($user !== null && $sharedWith !== null && $sharedWith->inGroup($user)) {
+                return true;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_ROOM) {
+            try {
+                return $this->getRoomShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_DECK) {
+            try {
+                return $this->getDeckShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        if ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
+            try {
+                return $this->getSciencemeshShareHelper()->canAccessShare($share, $this->userId);
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Make sure that the passed date is valid ISO 8601
+     * So YYYY-MM-DD
+     * If not throw an exception
+     *
+     * @param string $expireDate
+     *
+     * @throws \Exception
+     * @return \DateTime
+     */
+    private function parseDate(string $expireDate): \DateTime {
+        try {
+            $date = new \DateTime(trim($expireDate, '"'), $this->dateTimeZone->getTimeZone());
+            // Make sure it expires at midnight in owner timezone
+            $date->setTime(0, 0, 0);
+        } catch (\Exception $e) {
+            throw new \Exception($this->l->t('Invalid date. Format must be YYYY-MM-DD'));
+        }
+
+        return $date;
+    }
+
+    /**
+     * Since we have multiple providers but the OCS Share API v1 does
+     * not support this we need to check all backends.
+     *
+     * @param string $id
+     * @return IShare
+     * @throws ShareNotFound
+     */
+    private function getShareById(string $id): IShare {
+        $share = null;
+
+        // First check if it is an internal share.
+        try {
+            $share = $this->shareManager->getShareById('ocinternal:' . $id, $this->userId);
+            return $share;
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+
+        try {
+            if ($this->shareManager->shareProviderExists(IShare::TYPE_CIRCLE)) {
+                $share = $this->shareManager->getShareById('ocCircleShare:' . $id, $this->userId);
+                return $share;
+            }
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+        try {
+            if ($this->shareManager->shareProviderExists(IShare::TYPE_EMAIL)) {
+                $share = $this->shareManager->getShareById('ocMailShare:' . $id, $this->userId);
+                return $share;
+            }
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+        try {
+            $share = $this->shareManager->getShareById('ocRoomShare:' . $id, $this->userId);
+            return $share;
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+        try {
+            if ($this->shareManager->shareProviderExists(IShare::TYPE_DECK)) {
+                $share = $this->shareManager->getShareById('deck:' . $id, $this->userId);
+                return $share;
+            }
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+        try {
+            if ($this->shareManager->shareProviderExists(IShare::TYPE_SCIENCEMESH)) {
+                $share = $this->shareManager->getShareById('sciencemesh:' . $id, $this->userId);
+                return $share;
+            }
+        } catch (ShareNotFound $e) {
+            // Do nothing, just try the other share type
+        }
+
+        if (!$this->shareManager->outgoingServer2ServerSharesAllowed()) {
+            throw new ShareNotFound();
+        }
+        $share = $this->shareManager->getShareById('ocFederatedSharing:' . $id, $this->userId);
+
+        return $share;
+    }
+
+    /**
+     * Lock a Node
+     *
+     * @param Node $node
+     * @throws LockedException
+     */
+    private function lock(Node $node) {
+        $node->lock(ILockingProvider::LOCK_SHARED);
+        $this->lockedNode = $node;
+    }
+
+    /**
+     * Cleanup the remaining locks
+     * @throws LockedException
+     */
+    public function cleanup() {
+        if ($this->lockedNode !== null) {
+            $this->lockedNode->unlock(ILockingProvider::LOCK_SHARED);
+        }
+    }
+
+    /**
+     * Returns the helper of ShareAPIController for room shares.
+     *
+     * If the Talk application is not enabled or the helper is not available
+     * a ContainerExceptionInterface is thrown instead.
+     *
+     * @return \OCA\Talk\Share\Helper\ShareAPIController
+     * @throws ContainerExceptionInterface
+     */
+    private function getRoomShareHelper() {
+        if (!$this->appManager->isEnabledForUser('spreed')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\Talk\Share\Helper\ShareAPIController');
+    }
+
+    /**
+     * Returns the helper of ShareAPIHelper for deck shares.
+     *
+     * If the Deck application is not enabled or the helper is not available
+     * a ContainerExceptionInterface is thrown instead.
+     *
+     * @return ShareAPIHelper
+     * @throws ContainerExceptionInterface
+     */
+    private function getDeckShareHelper() {
+        if (!$this->appManager->isEnabledForUser('deck')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\Deck\Sharing\ShareAPIHelper');
+    }
+
+    /**
+     * Returns the helper of ShareAPIHelper for sciencemesh shares.
+     *
+     * If the sciencemesh application is not enabled or the helper is not available
+     * a ContainerExceptionInterface is thrown instead.
+     *
+     * @return ShareAPIHelper
+     * @throws ContainerExceptionInterface
+     */
+    private function getSciencemeshShareHelper() {
+        if (!$this->appManager->isEnabledForUser('sciencemesh')) {
+            throw new QueryException();
+        }
+
+        return $this->serverContainer->get('\OCA\ScienceMesh\Sharing\ShareAPIHelper');
+    }
+
+    /**
+     * @param string $viewer
+     * @param Node $node
+     * @param bool $reShares
+     *
+     * @return IShare[]
+     */
+    private function getSharesFromNode(string $viewer, $node, bool $reShares): array {
+        $providers = [
+            IShare::TYPE_USER,
+            IShare::TYPE_GROUP,
+            IShare::TYPE_LINK,
+            IShare::TYPE_EMAIL,
+            IShare::TYPE_CIRCLE,
+            IShare::TYPE_ROOM,
+            IShare::TYPE_DECK,
+            IShare::TYPE_SCIENCEMESH
+        ];
+
+        // Should we assume that the (currentUser) viewer is the owner of the node !?
+        $shares = [];
+        foreach ($providers as $provider) {
+            if (!$this->shareManager->shareProviderExists($provider)) {
+                continue;
+            }
+
+            $providerShares
+                = $this->shareManager->getSharesBy($viewer, $provider, $node, $reShares, -1, 0);
+            $shares = array_merge($shares, $providerShares);
+        }
+
+        if ($this->shareManager->outgoingServer2ServerSharesAllowed()) {
+            $federatedShares = $this->shareManager->getSharesBy(
+                $this->userId, IShare::TYPE_REMOTE, $node, $reShares, -1, 0
+            );
+            $shares = array_merge($shares, $federatedShares);
+        }
+
+        if ($this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
+            $federatedShares = $this->shareManager->getSharesBy(
+                $this->userId, IShare::TYPE_REMOTE_GROUP, $node, $reShares, -1, 0
+            );
+            $shares = array_merge($shares, $federatedShares);
+        }
+
+        return $shares;
+    }
+
+
+    /**
+     * @param Node $node
+     *
+     * @throws SharingRightsException
+     */
+    private function confirmSharingRights(Node $node): void {
+        if (!$this->hasResharingRights($this->userId, $node)) {
+            throw new SharingRightsException($this->l->t('No sharing rights on this item'));
+        }
+    }
+
+
+    /**
+     * @param string $viewer
+     * @param Node $node
+     *
+     * @return bool
+     */
+    private function hasResharingRights($viewer, $node): bool {
+        if ($viewer === $node->getOwner()->getUID()) {
+            return true;
+        }
+
+        foreach ([$node, $node->getParent()] as $node) {
+            $shares = $this->getSharesFromNode($viewer, $node, true);
+            foreach ($shares as $share) {
+                try {
+                    if ($this->shareProviderResharingRights($viewer, $share, $node)) {
+                        return true;
+                    }
+                } catch (InvalidPathException|NotFoundException $e) {
+                }
+            }
+        }
+
+        return false;
+    }
+
+
+    /**
+     * Returns if we can find resharing rights in an IShare object for a specific user.
+     *
+     * @suppress PhanUndeclaredClassMethod
+     *
+     * @param string $userId
+     * @param IShare $share
+     * @param Node $node
+     *
+     * @return bool
+     * @throws NotFoundException
+     * @throws InvalidPathException
+     */
+    private function shareProviderResharingRights(string $userId, IShare $share, $node): bool {
+        if ($share->getShareOwner() === $userId) {
+            return true;
+        }
+
+        // we check that current user have parent resharing rights on the current file
+        if ($node !== null && ($node->getPermissions() & Constants::PERMISSION_SHARE) !== 0) {
+            return true;
+        }
+
+        if ((Constants::PERMISSION_SHARE & $share->getPermissions()) === 0) {
+            return false;
+        }
+
+        if ($share->getShareType() === IShare::TYPE_USER && $share->getSharedWith() === $userId) {
+            return true;
+        }
+
+        if ($share->getShareType() === IShare::TYPE_GROUP && $this->groupManager->isInGroup($userId, $share->getSharedWith())) {
+            return true;
+        }
+
+        if ($share->getShareType() === IShare::TYPE_CIRCLE && Server::get(IAppManager::class)->isEnabledForUser('circles')
+            && class_exists('\OCA\Circles\Api\v1\Circles')) {
+            $hasCircleId = (str_ends_with($share->getSharedWith(), ']'));
+            $shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
+            $shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
+            if ($shareWithLength === false) {
+                $sharedWith = substr($share->getSharedWith(), $shareWithStart);
+            } else {
+                $sharedWith = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
+            }
+            try {
+                $member = Circles::getMember($sharedWith, $userId, 1);
+                if ($member->getLevel() >= 4) {
+                    return true;
+                }
+                return false;
+            } catch (ContainerExceptionInterface $e) {
+                return false;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Get all the shares for the current user
+     *
+     * @param Node|null $path
+     * @param boolean $reshares
+     * @return IShare[]
+     */
+    private function getAllShares(?Node $path = null, bool $reshares = false) {
+        // Get all shares
+        $userShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_USER, $path, $reshares, -1, 0);
+        $groupShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_GROUP, $path, $reshares, -1, 0);
+        $linkShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_LINK, $path, $reshares, -1, 0);
+
+        // EMAIL SHARES
+        $mailShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_EMAIL, $path, $reshares, -1, 0);
+
+        // TEAM SHARES
+        $circleShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_CIRCLE, $path, $reshares, -1, 0);
+
+        // TALK SHARES
+        $roomShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_ROOM, $path, $reshares, -1, 0);
+
+        // DECK SHARES
+        $deckShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_DECK, $path, $reshares, -1, 0);
+
+        // SCIENCEMESH SHARES
+        $sciencemeshShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_SCIENCEMESH, $path, $reshares, -1, 0);
+
+        // FEDERATION
+        if ($this->shareManager->outgoingServer2ServerSharesAllowed()) {
+            $federatedShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_REMOTE, $path, $reshares, -1, 0);
+        } else {
+            $federatedShares = [];
+        }
+        if ($this->shareManager->outgoingServer2ServerGroupSharesAllowed()) {
+            $federatedGroupShares = $this->shareManager->getSharesBy($this->userId, IShare::TYPE_REMOTE_GROUP, $path, $reshares, -1, 0);
+        } else {
+            $federatedGroupShares = [];
+        }
+
+        return array_merge($userShares, $groupShares, $linkShares, $mailShares, $circleShares, $roomShares, $deckShares, $sciencemeshShares, $federatedShares, $federatedGroupShares);
+    }
+
+
+    /**
+     * merging already formatted shares.
+     * We'll make an associative array to easily detect duplicate Ids.
+     * Keys _needs_ to be removed after all shares are retrieved and merged.
+     *
+     * @param array $shares
+     * @param array $newShares
+     */
+    private function mergeFormattedShares(array &$shares, array $newShares) {
+        foreach ($newShares as $newShare) {
+            if (!array_key_exists($newShare['id'], $shares)) {
+                $shares[$newShare['id']] = $newShare;
+            }
+        }
+    }
+
+    /**
+     * @param IShare $share
+     * @param string|null $attributesString
+     * @return IShare modified share
+     */
+    private function setShareAttributes(IShare $share, ?string $attributesString) {
+        $newShareAttributes = null;
+        if ($attributesString !== null) {
+            $newShareAttributes = $this->shareManager->newShare()->newAttributes();
+            $formattedShareAttributes = \json_decode($attributesString, true);
+            if (is_array($formattedShareAttributes)) {
+                foreach ($formattedShareAttributes as $formattedAttr) {
+                    $newShareAttributes->setAttribute(
+                        $formattedAttr['scope'],
+                        $formattedAttr['key'],
+                        $formattedAttr['value'],
+                    );
+                }
+            } else {
+                throw new OCSBadRequestException($this->l->t('Invalid share attributes provided: "%s"', [$attributesString]));
+            }
+        }
+        $share->setAttributes($newShareAttributes);
+
+        return $share;
+    }
+
+    private function checkInheritedAttributes(IShare $share): void {
+        if (!$share->getSharedBy()) {
+            return; // Probably in a test
+        }
+
+        $canDownload = false;
+        $hideDownload = true;
+
+        $userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
+        $nodes = $userFolder->getById($share->getNodeId());
+        foreach ($nodes as $node) {
+            // Owner always can download it - so allow it and break
+            if ($node->getOwner()?->getUID() === $share->getSharedBy()) {
+                $canDownload = true;
+                $hideDownload = false;
+                break;
+            }
+
+            if ($node->getStorage()->instanceOfStorage(SharedStorage::class)) {
+                $storage = $node->getStorage();
+                if ($storage instanceof Wrapper) {
+                    $storage = $storage->getInstanceOfStorage(SharedStorage::class);
+                    if ($storage === null) {
+                        throw new \RuntimeException('Should not happen, instanceOfStorage but getInstanceOfStorage return null');
+                    }
+                } else {
+                    throw new \RuntimeException('Should not happen, instanceOfStorage but not a wrapper');
+                }
+
+                /** @var SharedStorage $storage */
+                $originalShare = $storage->getShare();
+                $inheritedAttributes = $originalShare->getAttributes();
+                // hide if hidden and also the current share enforces hide (can only be false if one share is false or user is owner)
+                $hideDownload = $hideDownload && $originalShare->getHideDownload();
+                // allow download if already allowed by previous share or when the current share allows downloading
+                $canDownload = $canDownload || $inheritedAttributes === null || $inheritedAttributes->getAttribute('permissions', 'download') !== false;
+            } elseif ($node->getStorage()->instanceOfStorage(Storage::class)) {
+                $canDownload = true; // in case of federation storage, we can expect the download to be activated by default
+            }
+        }
+
+        if ($hideDownload || !$canDownload) {
+            $share->setHideDownload(true);
+
+            if (!$canDownload) {
+                $attributes = $share->getAttributes() ?? $share->newAttributes();
+                $attributes->setAttribute('permissions', 'download', false);
+                $share->setAttributes($attributes);
+            }
+        }
+    }
+
+    /**
+     * Send a mail notification again for a share.
+     * The mail_send option must be enabled for the given share.
+     * @param string $id the share ID
+     * @param string $password the password to check against. Necessary for password protected shares.
+     * @throws OCSNotFoundException Share not found
+     * @throws OCSForbiddenException You are not allowed to send mail notifications
+     * @throws OCSBadRequestException Invalid request or wrong password
+     * @throws OCSException Error while sending mail notification
+     * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
+     *
+     * 200: The email notification was sent successfully
+     */
+    #[NoAdminRequired]
+    #[UserRateLimit(limit: 10, period: 600)]
+    public function sendShareEmail(string $id, $password = ''): DataResponse {
+        try {
+            $share = $this->getShareById($id);
+
+            if (!$this->canAccessShare($share, false)) {
+                throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+            }
+
+            if (!$this->canEditShare($share)) {
+                throw new OCSForbiddenException($this->l->t('You are not allowed to send mail notifications'));
+            }
+
+            // For mail and link shares, the user must be
+            // the owner of the share, not only the file owner.
+            if ($share->getShareType() === IShare::TYPE_EMAIL
+                || $share->getShareType() === IShare::TYPE_LINK) {
+                if ($share->getSharedBy() !== $this->userId) {
+                    throw new OCSForbiddenException($this->l->t('You are not allowed to send mail notifications'));
+                }
+            }
+
+            try {
+                $provider = $this->factory->getProviderForType($share->getShareType());
+                if (!($provider instanceof IShareProviderWithNotification)) {
+                    throw new OCSBadRequestException($this->l->t('No mail notification configured for this share type'));
+                }
+
+                // Circumvent the password encrypted data by
+                // setting the password clear. We're not storing
+                // the password clear, it is just a temporary
+                // object manipulation. The password will stay
+                // encrypted in the database.
+                if ($share->getPassword() !== null && $share->getPassword() !== $password) {
+                    if (!$this->shareManager->checkPassword($share, $password)) {
+                        throw new OCSBadRequestException($this->l->t('Wrong password'));
+                    }
+                    $share = $share->setPassword($password);
+                }
+
+                $provider->sendMailNotification($share);
+                return new DataResponse();
+            } catch (Exception $e) {
+                $this->logger->error($e->getMessage(), ['exception' => $e]);
+                throw new OCSException($this->l->t('Error while sending mail notification'));
+            }
+
+        } catch (ShareNotFound $e) {
+            throw new OCSNotFoundException($this->l->t('Wrong share ID, share does not exist'));
+        }
+    }
+
+    /**
+     * Get a unique share token
+     *
+     * @throws OCSException Failed to generate a unique token
+     *
+     * @return DataResponse<Http::STATUS_OK, array{token: string}, array{}>
+     *
+     * 200: Token generated successfully
+     */
+    #[ApiRoute(verb: 'GET', url: '/api/v1/token')]
+    #[NoAdminRequired]
+    public function generateToken(): DataResponse {
+        try {
+            $token = $this->shareManager->generateToken();
+            return new DataResponse([
+                'token' => $token,
+            ]);
+        } catch (ShareTokenException $e) {
+            throw new OCSException($this->l->t('Failed to generate a unique token'));
+        }
+    }
+
+    /**
+     * Populate the result set with file tags
+     *
+     * @psalm-template T of array{tags?: list<string>, file_source: int, ...array<string, mixed>}
+     * @param list<T> $fileList
+     * @return list<T> file list populated with tags
+     */
+    private function populateTags(array $fileList): array {
+        $tagger = $this->tagManager->load('files');
+        $tags = $tagger->getTagsForObjects(array_map(static fn (array $fileData) => $fileData['file_source'], $fileList));
+
+        if (!is_array($tags)) {
+            throw new \UnexpectedValueException('$tags must be an array');
+        }
+
+        // Set empty tag array
+        foreach ($fileList as &$fileData) {
+            $fileData['tags'] = [];
+        }
+        unset($fileData);
+
+        if (!empty($tags)) {
+            foreach ($tags as $fileId => $fileTags) {
+                foreach ($fileList as &$fileData) {
+                    if ($fileId !== $fileData['file_source']) {
+                        continue;
+                    }
+
+                    $fileData['tags'] = $fileTags;
+                }
+                unset($fileData);
+            }
+        }
+
+        return $fileList;
+    }
 }

apps/files_sharing/lib/External/Manager.php

Indentation +752 added lines, -752 removed lines

@@ -36,803 +36,803 @@
  * @psalm-import-type Files_SharingRemoteShare from ResponseDefinitions
  */
 class Manager {
-	public const STORAGE = '\OCA\Files_Sharing\External\Storage';
-
-	/** @var string|null */
-	private $uid;
-
-	public function __construct(
-		private IDBConnection $connection,
-		private \OC\Files\Mount\Manager $mountManager,
-		private IStorageFactory $storageLoader,
-		private IClientService $clientService,
-		private IManager $notificationManager,
-		private IDiscoveryService $discoveryService,
-		private ICloudFederationProviderManager $cloudFederationProviderManager,
-		private ICloudFederationFactory $cloudFederationFactory,
-		private IGroupManager $groupManager,
-		private IUserManager $userManager,
-		IUserSession $userSession,
-		private IEventDispatcher $eventDispatcher,
-		private LoggerInterface $logger,
-	) {
-		$user = $userSession->getUser();
-		$this->uid = $user ? $user->getUID() : null;
-	}
-
-	/**
-	 * add new server-to-server share
-	 *
-	 * @param string $remote
-	 * @param string $token
-	 * @param string $password
-	 * @param string $name
-	 * @param string $owner
-	 * @param int $shareType
-	 * @param boolean $accepted
-	 * @param string $user
-	 * @param string $remoteId
-	 * @param int $parent
-	 * @return Mount|null
-	 * @throws \Doctrine\DBAL\Exception
-	 */
-	public function addShare($remote, $token, $password, $name, $owner, $shareType, $accepted = false, $user = null, $remoteId = '', $parent = -1) {
-		$user = $user ?? $this->uid;
-		$accepted = $accepted ? IShare::STATUS_ACCEPTED : IShare::STATUS_PENDING;
-		$name = Filesystem::normalizePath('/' . $name);
-
-		if ($accepted !== IShare::STATUS_ACCEPTED) {
-			// To avoid conflicts with the mount point generation later,
-			// we only use a temporary mount point name here. The real
-			// mount point name will be generated when accepting the share,
-			// using the original share item name.
-			$tmpMountPointName = '{{TemporaryMountPointName#' . $name . '}}';
-			$mountPoint = $tmpMountPointName;
-			$hash = md5($tmpMountPointName);
-			$data = [
-				'remote' => $remote,
-				'share_token' => $token,
-				'password' => $password,
-				'name' => $name,
-				'owner' => $owner,
-				'user' => $user,
-				'mountpoint' => $mountPoint,
-				'mountpoint_hash' => $hash,
-				'accepted' => $accepted,
-				'remote_id' => $remoteId,
-				'share_type' => $shareType,
-			];
-
-			$i = 1;
-			while (!$this->connection->insertIfNotExist('*PREFIX*share_external', $data, ['user', 'mountpoint_hash'])) {
-				// The external share already exists for the user
-				$data['mountpoint'] = $tmpMountPointName . '-' . $i;
-				$data['mountpoint_hash'] = md5($data['mountpoint']);
-				$i++;
-			}
-			return null;
-		}
-
-		$mountPoint = Files::buildNotExistingFileName('/', $name);
-		$mountPoint = Filesystem::normalizePath('/' . $mountPoint);
-		$hash = md5($mountPoint);
-
-		$this->writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType);
-
-		$options = [
-			'remote' => $remote,
-			'token' => $token,
-			'password' => $password,
-			'mountpoint' => $mountPoint,
-			'owner' => $owner
-		];
-		return $this->mountShare($options, $user);
-	}
-
-	/**
-	 * write remote share to the database
-	 *
-	 * @param $remote
-	 * @param $token
-	 * @param $password
-	 * @param $name
-	 * @param $owner
-	 * @param $user
-	 * @param $mountPoint
-	 * @param $hash
-	 * @param $accepted
-	 * @param $remoteId
-	 * @param $parent
-	 * @param $shareType
-	 *
-	 * @return void
-	 * @throws \Doctrine\DBAL\Driver\Exception
-	 */
-	private function writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType): void {
-		$query = $this->connection->prepare('
+    public const STORAGE = '\OCA\Files_Sharing\External\Storage';
+
+    /** @var string|null */
+    private $uid;
+
+    public function __construct(
+        private IDBConnection $connection,
+        private \OC\Files\Mount\Manager $mountManager,
+        private IStorageFactory $storageLoader,
+        private IClientService $clientService,
+        private IManager $notificationManager,
+        private IDiscoveryService $discoveryService,
+        private ICloudFederationProviderManager $cloudFederationProviderManager,
+        private ICloudFederationFactory $cloudFederationFactory,
+        private IGroupManager $groupManager,
+        private IUserManager $userManager,
+        IUserSession $userSession,
+        private IEventDispatcher $eventDispatcher,
+        private LoggerInterface $logger,
+    ) {
+        $user = $userSession->getUser();
+        $this->uid = $user ? $user->getUID() : null;
+    }
+
+    /**
+     * add new server-to-server share
+     *
+     * @param string $remote
+     * @param string $token
+     * @param string $password
+     * @param string $name
+     * @param string $owner
+     * @param int $shareType
+     * @param boolean $accepted
+     * @param string $user
+     * @param string $remoteId
+     * @param int $parent
+     * @return Mount|null
+     * @throws \Doctrine\DBAL\Exception
+     */
+    public function addShare($remote, $token, $password, $name, $owner, $shareType, $accepted = false, $user = null, $remoteId = '', $parent = -1) {
+        $user = $user ?? $this->uid;
+        $accepted = $accepted ? IShare::STATUS_ACCEPTED : IShare::STATUS_PENDING;
+        $name = Filesystem::normalizePath('/' . $name);
+
+        if ($accepted !== IShare::STATUS_ACCEPTED) {
+            // To avoid conflicts with the mount point generation later,
+            // we only use a temporary mount point name here. The real
+            // mount point name will be generated when accepting the share,
+            // using the original share item name.
+            $tmpMountPointName = '{{TemporaryMountPointName#' . $name . '}}';
+            $mountPoint = $tmpMountPointName;
+            $hash = md5($tmpMountPointName);
+            $data = [
+                'remote' => $remote,
+                'share_token' => $token,
+                'password' => $password,
+                'name' => $name,
+                'owner' => $owner,
+                'user' => $user,
+                'mountpoint' => $mountPoint,
+                'mountpoint_hash' => $hash,
+                'accepted' => $accepted,
+                'remote_id' => $remoteId,
+                'share_type' => $shareType,
+            ];
+
+            $i = 1;
+            while (!$this->connection->insertIfNotExist('*PREFIX*share_external', $data, ['user', 'mountpoint_hash'])) {
+                // The external share already exists for the user
+                $data['mountpoint'] = $tmpMountPointName . '-' . $i;
+                $data['mountpoint_hash'] = md5($data['mountpoint']);
+                $i++;
+            }
+            return null;
+        }
+
+        $mountPoint = Files::buildNotExistingFileName('/', $name);
+        $mountPoint = Filesystem::normalizePath('/' . $mountPoint);
+        $hash = md5($mountPoint);
+
+        $this->writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType);
+
+        $options = [
+            'remote' => $remote,
+            'token' => $token,
+            'password' => $password,
+            'mountpoint' => $mountPoint,
+            'owner' => $owner
+        ];
+        return $this->mountShare($options, $user);
+    }
+
+    /**
+     * write remote share to the database
+     *
+     * @param $remote
+     * @param $token
+     * @param $password
+     * @param $name
+     * @param $owner
+     * @param $user
+     * @param $mountPoint
+     * @param $hash
+     * @param $accepted
+     * @param $remoteId
+     * @param $parent
+     * @param $shareType
+     *
+     * @return void
+     * @throws \Doctrine\DBAL\Driver\Exception
+     */
+    private function writeShareToDb($remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType): void {
+        $query = $this->connection->prepare('
 				INSERT INTO `*PREFIX*share_external`
 					(`remote`, `share_token`, `password`, `name`, `owner`, `user`, `mountpoint`, `mountpoint_hash`, `accepted`, `remote_id`, `parent`, `share_type`)
 				VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
 			');
-		$query->execute([$remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType]);
-	}
+        $query->execute([$remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType]);
+    }
 
-	private function fetchShare(int $id): array|false {
-		$getShare = $this->connection->prepare('
+    private function fetchShare(int $id): array|false {
+        $getShare = $this->connection->prepare('
 			SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted`, `parent`, `share_type`, `password`, `mountpoint_hash`
 			FROM  `*PREFIX*share_external`
 			WHERE `id` = ?');
-		$result = $getShare->execute([$id]);
-		$share = $result->fetch();
-		$result->closeCursor();
-		return $share;
-	}
-
-	/**
-	 * get share by token
-	 *
-	 * @param string $token
-	 * @return mixed share of false
-	 */
-	private function fetchShareByToken($token) {
-		$getShare = $this->connection->prepare('
+        $result = $getShare->execute([$id]);
+        $share = $result->fetch();
+        $result->closeCursor();
+        return $share;
+    }
+
+    /**
+     * get share by token
+     *
+     * @param string $token
+     * @return mixed share of false
+     */
+    private function fetchShareByToken($token) {
+        $getShare = $this->connection->prepare('
 			SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted`, `parent`, `share_type`, `password`, `mountpoint_hash`
 			FROM  `*PREFIX*share_external`
 			WHERE `share_token` = ?');
-		$result = $getShare->execute([$token]);
-		$share = $result->fetch();
-		$result->closeCursor();
-		return $share;
-	}
-
-	private function fetchUserShare($parentId, $uid) {
-		$getShare = $this->connection->prepare('
+        $result = $getShare->execute([$token]);
+        $share = $result->fetch();
+        $result->closeCursor();
+        return $share;
+    }
+
+    private function fetchUserShare($parentId, $uid) {
+        $getShare = $this->connection->prepare('
 			SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted`, `parent`, `share_type`, `password`, `mountpoint_hash`
 			FROM  `*PREFIX*share_external`
 			WHERE `parent` = ? AND `user` = ?');
-		$result = $getShare->execute([$parentId, $uid]);
-		$share = $result->fetch();
-		$result->closeCursor();
-		if ($share !== false) {
-			return $share;
-		}
-		return null;
-	}
-
-	public function getShare(int $id, ?string $user = null): array|false {
-		$user = $user ?? $this->uid;
-		$share = $this->fetchShare($id);
-		if ($share === false) {
-			return false;
-		}
-
-		// check if the user is allowed to access it
-		if ($this->canAccessShare($share, $user)) {
-			return $share;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Get share by token
-	 *
-	 * @param string $token
-	 * @return array|false
-	 */
-	public function getShareByToken(string $token): array|false {
-		$share = $this->fetchShareByToken($token);
-
-		// We do not check if the user is allowed to access it here,
-		// as this is not used from a user context.
-		if ($share === false) {
-			return false;
-		}
-
-		return $share;
-	}
-
-	private function canAccessShare(array $share, string $user): bool {
-		$validShare = isset($share['share_type']) && isset($share['user']);
-
-		if (!$validShare) {
-			return false;
-		}
-
-		// If the share is a user share, check if the user is the recipient
-		if ((int)$share['share_type'] === IShare::TYPE_USER
-			&& $share['user'] === $user) {
-			return true;
-		}
-
-		// If the share is a group share, check if the user is in the group
-		if ((int)$share['share_type'] === IShare::TYPE_GROUP) {
-			$parentId = (int)$share['parent'];
-			if ($parentId !== -1) {
-				// we just retrieved a sub-share, switch to the parent entry for verification
-				$groupShare = $this->fetchShare($parentId);
-			} else {
-				$groupShare = $share;
-			}
-
-			$user = $this->userManager->get($user);
-			if ($this->groupManager->get($groupShare['user'])->inGroup($user)) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Updates accepted flag in the database
-	 *
-	 * @param int $id
-	 */
-	private function updateAccepted(int $shareId, bool $accepted) : void {
-		$query = $this->connection->prepare('
+        $result = $getShare->execute([$parentId, $uid]);
+        $share = $result->fetch();
+        $result->closeCursor();
+        if ($share !== false) {
+            return $share;
+        }
+        return null;
+    }
+
+    public function getShare(int $id, ?string $user = null): array|false {
+        $user = $user ?? $this->uid;
+        $share = $this->fetchShare($id);
+        if ($share === false) {
+            return false;
+        }
+
+        // check if the user is allowed to access it
+        if ($this->canAccessShare($share, $user)) {
+            return $share;
+        }
+
+        return false;
+    }
+
+    /**
+     * Get share by token
+     *
+     * @param string $token
+     * @return array|false
+     */
+    public function getShareByToken(string $token): array|false {
+        $share = $this->fetchShareByToken($token);
+
+        // We do not check if the user is allowed to access it here,
+        // as this is not used from a user context.
+        if ($share === false) {
+            return false;
+        }
+
+        return $share;
+    }
+
+    private function canAccessShare(array $share, string $user): bool {
+        $validShare = isset($share['share_type']) && isset($share['user']);
+
+        if (!$validShare) {
+            return false;
+        }
+
+        // If the share is a user share, check if the user is the recipient
+        if ((int)$share['share_type'] === IShare::TYPE_USER
+            && $share['user'] === $user) {
+            return true;
+        }
+
+        // If the share is a group share, check if the user is in the group
+        if ((int)$share['share_type'] === IShare::TYPE_GROUP) {
+            $parentId = (int)$share['parent'];
+            if ($parentId !== -1) {
+                // we just retrieved a sub-share, switch to the parent entry for verification
+                $groupShare = $this->fetchShare($parentId);
+            } else {
+                $groupShare = $share;
+            }
+
+            $user = $this->userManager->get($user);
+            if ($this->groupManager->get($groupShare['user'])->inGroup($user)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Updates accepted flag in the database
+     *
+     * @param int $id
+     */
+    private function updateAccepted(int $shareId, bool $accepted) : void {
+        $query = $this->connection->prepare('
 			UPDATE `*PREFIX*share_external`
 			SET `accepted` = ?
 			WHERE `id` = ?');
-		$updateResult = $query->execute([$accepted ? 1 : 0, $shareId]);
-		$updateResult->closeCursor();
-	}
-
-	/**
-	 * accept server-to-server share
-	 *
-	 * @param int $id
-	 * @return bool True if the share could be accepted, false otherwise
-	 */
-	public function acceptShare(int $id, ?string $user = null) {
-		// If we're auto-accepting a share, we need to know the user id
-		// as there is no session available while processing the share
-		// from the remote server request.
-		$user = $user ?? $this->uid;
-		if ($user === null) {
-			$this->logger->error('No user specified for accepting share');
-			return false;
-		}
-
-		$share = $this->getShare($id, $user);
-		$result = false;
-
-		if ($share) {
-			\OC_Util::setupFS($user);
-			$shareFolder = Helper::getShareFolder(null, $user);
-			$mountPoint = Files::buildNotExistingFileName($shareFolder, $share['name']);
-			$mountPoint = Filesystem::normalizePath($mountPoint);
-			$hash = md5($mountPoint);
-			$userShareAccepted = false;
-
-			if ((int)$share['share_type'] === IShare::TYPE_USER) {
-				$acceptShare = $this->connection->prepare('
+        $updateResult = $query->execute([$accepted ? 1 : 0, $shareId]);
+        $updateResult->closeCursor();
+    }
+
+    /**
+     * accept server-to-server share
+     *
+     * @param int $id
+     * @return bool True if the share could be accepted, false otherwise
+     */
+    public function acceptShare(int $id, ?string $user = null) {
+        // If we're auto-accepting a share, we need to know the user id
+        // as there is no session available while processing the share
+        // from the remote server request.
+        $user = $user ?? $this->uid;
+        if ($user === null) {
+            $this->logger->error('No user specified for accepting share');
+            return false;
+        }
+
+        $share = $this->getShare($id, $user);
+        $result = false;
+
+        if ($share) {
+            \OC_Util::setupFS($user);
+            $shareFolder = Helper::getShareFolder(null, $user);
+            $mountPoint = Files::buildNotExistingFileName($shareFolder, $share['name']);
+            $mountPoint = Filesystem::normalizePath($mountPoint);
+            $hash = md5($mountPoint);
+            $userShareAccepted = false;
+
+            if ((int)$share['share_type'] === IShare::TYPE_USER) {
+                $acceptShare = $this->connection->prepare('
 				UPDATE `*PREFIX*share_external`
 				SET `accepted` = ?,
 					`mountpoint` = ?,
 					`mountpoint_hash` = ?
 				WHERE `id` = ? AND `user` = ?');
-				$userShareAccepted = $acceptShare->execute([1, $mountPoint, $hash, $id, $user]);
-			} else {
-				$parentId = (int)$share['parent'];
-				if ($parentId !== -1) {
-					// this is the sub-share
-					$subshare = $share;
-				} else {
-					$subshare = $this->fetchUserShare($id, $user);
-				}
-
-				if ($subshare !== null) {
-					try {
-						$acceptShare = $this->connection->prepare('
+                $userShareAccepted = $acceptShare->execute([1, $mountPoint, $hash, $id, $user]);
+            } else {
+                $parentId = (int)$share['parent'];
+                if ($parentId !== -1) {
+                    // this is the sub-share
+                    $subshare = $share;
+                } else {
+                    $subshare = $this->fetchUserShare($id, $user);
+                }
+
+                if ($subshare !== null) {
+                    try {
+                        $acceptShare = $this->connection->prepare('
 						UPDATE `*PREFIX*share_external`
 						SET `accepted` = ?,
 							`mountpoint` = ?,
 							`mountpoint_hash` = ?
 						WHERE `id` = ? AND `user` = ?');
-						$acceptShare->execute([1, $mountPoint, $hash, $subshare['id'], $user]);
-						$result = true;
-					} catch (Exception $e) {
-						$this->logger->emergency('Could not update share', ['exception' => $e]);
-						$result = false;
-					}
-				} else {
-					try {
-						$this->writeShareToDb(
-							$share['remote'],
-							$share['share_token'],
-							$share['password'],
-							$share['name'],
-							$share['owner'],
-							$user,
-							$mountPoint, $hash, 1,
-							$share['remote_id'],
-							$id,
-							$share['share_type']);
-						$result = true;
-					} catch (Exception $e) {
-						$this->logger->emergency('Could not create share', ['exception' => $e]);
-						$result = false;
-					}
-				}
-			}
-
-			if ($userShareAccepted !== false) {
-				$this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'accept');
-				$event = new FederatedShareAddedEvent($share['remote']);
-				$this->eventDispatcher->dispatchTyped($event);
-				$this->eventDispatcher->dispatchTyped(new InvalidateMountCacheEvent($this->userManager->get($user)));
-				$result = true;
-			}
-		}
-
-		// Make sure the user has no notification for something that does not exist anymore.
-		$this->processNotification($id, $user);
-
-		return $result;
-	}
-
-	/**
-	 * decline server-to-server share
-	 *
-	 * @param int $id
-	 * @return bool True if the share could be declined, false otherwise
-	 */
-	public function declineShare(int $id, ?string $user = null) {
-		$user = $user ?? $this->uid;
-		if ($user === null) {
-			$this->logger->error('No user specified for declining share');
-			return false;
-		}
-
-		$share = $this->getShare($id, $user);
-		$result = false;
-
-		if ($share && (int)$share['share_type'] === IShare::TYPE_USER) {
-			$removeShare = $this->connection->prepare('
+                        $acceptShare->execute([1, $mountPoint, $hash, $subshare['id'], $user]);
+                        $result = true;
+                    } catch (Exception $e) {
+                        $this->logger->emergency('Could not update share', ['exception' => $e]);
+                        $result = false;
+                    }
+                } else {
+                    try {
+                        $this->writeShareToDb(
+                            $share['remote'],
+                            $share['share_token'],
+                            $share['password'],
+                            $share['name'],
+                            $share['owner'],
+                            $user,
+                            $mountPoint, $hash, 1,
+                            $share['remote_id'],
+                            $id,
+                            $share['share_type']);
+                        $result = true;
+                    } catch (Exception $e) {
+                        $this->logger->emergency('Could not create share', ['exception' => $e]);
+                        $result = false;
+                    }
+                }
+            }
+
+            if ($userShareAccepted !== false) {
+                $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'accept');
+                $event = new FederatedShareAddedEvent($share['remote']);
+                $this->eventDispatcher->dispatchTyped($event);
+                $this->eventDispatcher->dispatchTyped(new InvalidateMountCacheEvent($this->userManager->get($user)));
+                $result = true;
+            }
+        }
+
+        // Make sure the user has no notification for something that does not exist anymore.
+        $this->processNotification($id, $user);
+
+        return $result;
+    }
+
+    /**
+     * decline server-to-server share
+     *
+     * @param int $id
+     * @return bool True if the share could be declined, false otherwise
+     */
+    public function declineShare(int $id, ?string $user = null) {
+        $user = $user ?? $this->uid;
+        if ($user === null) {
+            $this->logger->error('No user specified for declining share');
+            return false;
+        }
+
+        $share = $this->getShare($id, $user);
+        $result = false;
+
+        if ($share && (int)$share['share_type'] === IShare::TYPE_USER) {
+            $removeShare = $this->connection->prepare('
 				DELETE FROM `*PREFIX*share_external` WHERE `id` = ? AND `user` = ?');
-			$removeShare->execute([$id, $user]);
-			$this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
-
-			$this->processNotification($id, $user);
-			$result = true;
-		} elseif ($share && (int)$share['share_type'] === IShare::TYPE_GROUP) {
-			$parentId = (int)$share['parent'];
-			if ($parentId !== -1) {
-				// this is the sub-share
-				$subshare = $share;
-			} else {
-				$subshare = $this->fetchUserShare($id, $user);
-			}
-
-			if ($subshare !== null) {
-				try {
-					$this->updateAccepted((int)$subshare['id'], false);
-					$result = true;
-				} catch (Exception $e) {
-					$this->logger->emergency('Could not update share', ['exception' => $e]);
-					$result = false;
-				}
-			} else {
-				try {
-					$this->writeShareToDb(
-						$share['remote'],
-						$share['share_token'],
-						$share['password'],
-						$share['name'],
-						$share['owner'],
-						$user,
-						$share['mountpoint'],
-						$share['mountpoint_hash'],
-						0,
-						$share['remote_id'],
-						$id,
-						$share['share_type']);
-					$result = true;
-				} catch (Exception $e) {
-					$this->logger->emergency('Could not create share', ['exception' => $e]);
-					$result = false;
-				}
-			}
-			$this->processNotification($id, $user);
-		}
-
-		return $result;
-	}
-
-	public function processNotification(int $remoteShare, ?string $user = null): void {
-		$user = $user ?? $this->uid;
-		if ($user === null) {
-			$this->logger->error('No user specified for processing notification');
-			return;
-		}
-
-		$share = $this->fetchShare($remoteShare);
-		if ($share === false) {
-			return;
-		}
-
-		$filter = $this->notificationManager->createNotification();
-		$filter->setApp('files_sharing')
-			->setUser($user)
-			->setObject('remote_share', (string)$remoteShare);
-		$this->notificationManager->markProcessed($filter);
-	}
-
-	/**
-	 * inform remote server whether server-to-server share was accepted/declined
-	 *
-	 * @param string $remote
-	 * @param string $token
-	 * @param string $remoteId Share id on the remote host
-	 * @param string $feedback
-	 * @return boolean
-	 */
-	private function sendFeedbackToRemote($remote, $token, $remoteId, $feedback) {
-		$result = $this->tryOCMEndPoint($remote, $token, $remoteId, $feedback);
-
-		if (is_array($result)) {
-			return true;
-		}
-
-		$federationEndpoints = $this->discoveryService->discover($remote, 'FEDERATED_SHARING');
-		$endpoint = $federationEndpoints['share'] ?? '/ocs/v2.php/cloud/shares';
-
-		$url = rtrim($remote, '/') . $endpoint . '/' . $remoteId . '/' . $feedback . '?format=' . Share::RESPONSE_FORMAT;
-		$fields = ['token' => $token];
-
-		$client = $this->clientService->newClient();
-
-		try {
-			$response = $client->post(
-				$url,
-				[
-					'body' => $fields,
-					'connect_timeout' => 10,
-				]
-			);
-		} catch (\Exception $e) {
-			return false;
-		}
-
-		$status = json_decode($response->getBody(), true);
-
-		return ($status['ocs']['meta']['statuscode'] === 100 || $status['ocs']['meta']['statuscode'] === 200);
-	}
-
-	/**
-	 * try send accept message to ocm end-point
-	 *
-	 * @param string $remoteDomain
-	 * @param string $token
-	 * @param string $remoteId id of the share
-	 * @param string $feedback
-	 * @return array|false
-	 */
-	protected function tryOCMEndPoint($remoteDomain, $token, $remoteId, $feedback) {
-		switch ($feedback) {
-			case 'accept':
-				$notification = $this->cloudFederationFactory->getCloudFederationNotification();
-				$notification->setMessage(
-					'SHARE_ACCEPTED',
-					'file',
-					$remoteId,
-					[
-						'sharedSecret' => $token,
-						'message' => 'Recipient accept the share'
-					]
-
-				);
-				return $this->cloudFederationProviderManager->sendNotification($remoteDomain, $notification);
-			case 'decline':
-				$notification = $this->cloudFederationFactory->getCloudFederationNotification();
-				$notification->setMessage(
-					'SHARE_DECLINED',
-					'file',
-					$remoteId,
-					[
-						'sharedSecret' => $token,
-						'message' => 'Recipient declined the share'
-					]
-
-				);
-				return $this->cloudFederationProviderManager->sendNotification($remoteDomain, $notification);
-		}
-
-		return false;
-	}
-
-
-	/**
-	 * remove '/user/files' from the path and trailing slashes
-	 *
-	 * @param string $path
-	 * @return string
-	 */
-	protected function stripPath($path) {
-		$prefix = '/' . $this->uid . '/files';
-		return rtrim(substr($path, strlen($prefix)), '/');
-	}
-
-	public function getMount($data, ?string $user = null) {
-		$user = $user ?? $this->uid;
-		$data['manager'] = $this;
-		$mountPoint = '/' . $user . '/files' . $data['mountpoint'];
-		$data['mountpoint'] = $mountPoint;
-		$data['certificateManager'] = \OC::$server->getCertificateManager();
-		return new Mount(self::STORAGE, $mountPoint, $data, $this, $this->storageLoader);
-	}
-
-	/**
-	 * @param array $data
-	 * @return Mount
-	 */
-	protected function mountShare($data, ?string $user = null) {
-		$mount = $this->getMount($data, $user);
-		$this->mountManager->addMount($mount);
-		return $mount;
-	}
-
-	/**
-	 * @return \OC\Files\Mount\Manager
-	 */
-	public function getMountManager() {
-		return $this->mountManager;
-	}
-
-	/**
-	 * @param string $source
-	 * @param string $target
-	 * @return bool
-	 */
-	public function setMountPoint($source, $target) {
-		$source = $this->stripPath($source);
-		$target = $this->stripPath($target);
-		$sourceHash = md5($source);
-		$targetHash = md5($target);
-
-		$query = $this->connection->prepare('
+            $removeShare->execute([$id, $user]);
+            $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
+
+            $this->processNotification($id, $user);
+            $result = true;
+        } elseif ($share && (int)$share['share_type'] === IShare::TYPE_GROUP) {
+            $parentId = (int)$share['parent'];
+            if ($parentId !== -1) {
+                // this is the sub-share
+                $subshare = $share;
+            } else {
+                $subshare = $this->fetchUserShare($id, $user);
+            }
+
+            if ($subshare !== null) {
+                try {
+                    $this->updateAccepted((int)$subshare['id'], false);
+                    $result = true;
+                } catch (Exception $e) {
+                    $this->logger->emergency('Could not update share', ['exception' => $e]);
+                    $result = false;
+                }
+            } else {
+                try {
+                    $this->writeShareToDb(
+                        $share['remote'],
+                        $share['share_token'],
+                        $share['password'],
+                        $share['name'],
+                        $share['owner'],
+                        $user,
+                        $share['mountpoint'],
+                        $share['mountpoint_hash'],
+                        0,
+                        $share['remote_id'],
+                        $id,
+                        $share['share_type']);
+                    $result = true;
+                } catch (Exception $e) {
+                    $this->logger->emergency('Could not create share', ['exception' => $e]);
+                    $result = false;
+                }
+            }
+            $this->processNotification($id, $user);
+        }
+
+        return $result;
+    }
+
+    public function processNotification(int $remoteShare, ?string $user = null): void {
+        $user = $user ?? $this->uid;
+        if ($user === null) {
+            $this->logger->error('No user specified for processing notification');
+            return;
+        }
+
+        $share = $this->fetchShare($remoteShare);
+        if ($share === false) {
+            return;
+        }
+
+        $filter = $this->notificationManager->createNotification();
+        $filter->setApp('files_sharing')
+            ->setUser($user)
+            ->setObject('remote_share', (string)$remoteShare);
+        $this->notificationManager->markProcessed($filter);
+    }
+
+    /**
+     * inform remote server whether server-to-server share was accepted/declined
+     *
+     * @param string $remote
+     * @param string $token
+     * @param string $remoteId Share id on the remote host
+     * @param string $feedback
+     * @return boolean
+     */
+    private function sendFeedbackToRemote($remote, $token, $remoteId, $feedback) {
+        $result = $this->tryOCMEndPoint($remote, $token, $remoteId, $feedback);
+
+        if (is_array($result)) {
+            return true;
+        }
+
+        $federationEndpoints = $this->discoveryService->discover($remote, 'FEDERATED_SHARING');
+        $endpoint = $federationEndpoints['share'] ?? '/ocs/v2.php/cloud/shares';
+
+        $url = rtrim($remote, '/') . $endpoint . '/' . $remoteId . '/' . $feedback . '?format=' . Share::RESPONSE_FORMAT;
+        $fields = ['token' => $token];
+
+        $client = $this->clientService->newClient();
+
+        try {
+            $response = $client->post(
+                $url,
+                [
+                    'body' => $fields,
+                    'connect_timeout' => 10,
+                ]
+            );
+        } catch (\Exception $e) {
+            return false;
+        }
+
+        $status = json_decode($response->getBody(), true);
+
+        return ($status['ocs']['meta']['statuscode'] === 100 || $status['ocs']['meta']['statuscode'] === 200);
+    }
+
+    /**
+     * try send accept message to ocm end-point
+     *
+     * @param string $remoteDomain
+     * @param string $token
+     * @param string $remoteId id of the share
+     * @param string $feedback
+     * @return array|false
+     */
+    protected function tryOCMEndPoint($remoteDomain, $token, $remoteId, $feedback) {
+        switch ($feedback) {
+            case 'accept':
+                $notification = $this->cloudFederationFactory->getCloudFederationNotification();
+                $notification->setMessage(
+                    'SHARE_ACCEPTED',
+                    'file',
+                    $remoteId,
+                    [
+                        'sharedSecret' => $token,
+                        'message' => 'Recipient accept the share'
+                    ]
+
+                );
+                return $this->cloudFederationProviderManager->sendNotification($remoteDomain, $notification);
+            case 'decline':
+                $notification = $this->cloudFederationFactory->getCloudFederationNotification();
+                $notification->setMessage(
+                    'SHARE_DECLINED',
+                    'file',
+                    $remoteId,
+                    [
+                        'sharedSecret' => $token,
+                        'message' => 'Recipient declined the share'
+                    ]
+
+                );
+                return $this->cloudFederationProviderManager->sendNotification($remoteDomain, $notification);
+        }
+
+        return false;
+    }
+
+
+    /**
+     * remove '/user/files' from the path and trailing slashes
+     *
+     * @param string $path
+     * @return string
+     */
+    protected function stripPath($path) {
+        $prefix = '/' . $this->uid . '/files';
+        return rtrim(substr($path, strlen($prefix)), '/');
+    }
+
+    public function getMount($data, ?string $user = null) {
+        $user = $user ?? $this->uid;
+        $data['manager'] = $this;
+        $mountPoint = '/' . $user . '/files' . $data['mountpoint'];
+        $data['mountpoint'] = $mountPoint;
+        $data['certificateManager'] = \OC::$server->getCertificateManager();
+        return new Mount(self::STORAGE, $mountPoint, $data, $this, $this->storageLoader);
+    }
+
+    /**
+     * @param array $data
+     * @return Mount
+     */
+    protected function mountShare($data, ?string $user = null) {
+        $mount = $this->getMount($data, $user);
+        $this->mountManager->addMount($mount);
+        return $mount;
+    }
+
+    /**
+     * @return \OC\Files\Mount\Manager
+     */
+    public function getMountManager() {
+        return $this->mountManager;
+    }
+
+    /**
+     * @param string $source
+     * @param string $target
+     * @return bool
+     */
+    public function setMountPoint($source, $target) {
+        $source = $this->stripPath($source);
+        $target = $this->stripPath($target);
+        $sourceHash = md5($source);
+        $targetHash = md5($target);
+
+        $query = $this->connection->prepare('
 			UPDATE `*PREFIX*share_external`
 			SET `mountpoint` = ?, `mountpoint_hash` = ?
 			WHERE `mountpoint_hash` = ?
 			AND `user` = ?
 		');
-		$result = (bool)$query->execute([$target, $targetHash, $sourceHash, $this->uid]);
-
-		$this->eventDispatcher->dispatchTyped(new InvalidateMountCacheEvent($this->userManager->get($this->uid)));
-
-		return $result;
-	}
-
-	public function removeShare($mountPoint): bool {
-		try {
-			$mountPointObj = $this->mountManager->find($mountPoint);
-		} catch (NotFoundException $e) {
-			$this->logger->error('Mount point to remove share not found', ['mountPoint' => $mountPoint]);
-			return false;
-		}
-		if (!$mountPointObj instanceof Mount) {
-			$this->logger->error('Mount point to remove share is not an external share, share probably doesn\'t exist', ['mountPoint' => $mountPoint]);
-			return false;
-		}
-		$id = $mountPointObj->getStorage()->getCache()->getId('');
-
-		$mountPoint = $this->stripPath($mountPoint);
-		$hash = md5($mountPoint);
-
-		try {
-			$getShare = $this->connection->prepare('
+        $result = (bool)$query->execute([$target, $targetHash, $sourceHash, $this->uid]);
+
+        $this->eventDispatcher->dispatchTyped(new InvalidateMountCacheEvent($this->userManager->get($this->uid)));
+
+        return $result;
+    }
+
+    public function removeShare($mountPoint): bool {
+        try {
+            $mountPointObj = $this->mountManager->find($mountPoint);
+        } catch (NotFoundException $e) {
+            $this->logger->error('Mount point to remove share not found', ['mountPoint' => $mountPoint]);
+            return false;
+        }
+        if (!$mountPointObj instanceof Mount) {
+            $this->logger->error('Mount point to remove share is not an external share, share probably doesn\'t exist', ['mountPoint' => $mountPoint]);
+            return false;
+        }
+        $id = $mountPointObj->getStorage()->getCache()->getId('');
+
+        $mountPoint = $this->stripPath($mountPoint);
+        $hash = md5($mountPoint);
+
+        try {
+            $getShare = $this->connection->prepare('
 				SELECT `remote`, `share_token`, `remote_id`, `share_type`, `id`
 				FROM  `*PREFIX*share_external`
 				WHERE `mountpoint_hash` = ? AND `user` = ?');
-			$result = $getShare->execute([$hash, $this->uid]);
-			$share = $result->fetch();
-			$result->closeCursor();
-			if ($share !== false && (int)$share['share_type'] === IShare::TYPE_USER) {
-				try {
-					$this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
-				} catch (\Throwable $e) {
-					// if we fail to notify the remote (probably cause the remote is down)
-					// we still want the share to be gone to prevent undeletable remotes
-				}
-
-				$query = $this->connection->prepare('
+            $result = $getShare->execute([$hash, $this->uid]);
+            $share = $result->fetch();
+            $result->closeCursor();
+            if ($share !== false && (int)$share['share_type'] === IShare::TYPE_USER) {
+                try {
+                    $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
+                } catch (\Throwable $e) {
+                    // if we fail to notify the remote (probably cause the remote is down)
+                    // we still want the share to be gone to prevent undeletable remotes
+                }
+
+                $query = $this->connection->prepare('
 					DELETE FROM `*PREFIX*share_external`
 					WHERE `id` = ?
 				');
-				$deleteResult = $query->execute([(int)$share['id']]);
-				$deleteResult->closeCursor();
-			} elseif ($share !== false && (int)$share['share_type'] === IShare::TYPE_GROUP) {
-				$this->updateAccepted((int)$share['id'], false);
-			}
-
-			$this->removeReShares($id);
-		} catch (\Doctrine\DBAL\Exception $ex) {
-			$this->logger->emergency('Could not update share', ['exception' => $ex]);
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * remove re-shares from share table and mapping in the federated_reshares table
-	 *
-	 * @param $mountPointId
-	 */
-	protected function removeReShares($mountPointId) {
-		$selectQuery = $this->connection->getQueryBuilder();
-		$query = $this->connection->getQueryBuilder();
-		$selectQuery->select('id')->from('share')
-			->where($selectQuery->expr()->eq('file_source', $query->createNamedParameter($mountPointId)));
-		$select = $selectQuery->getSQL();
-
-
-		$query->delete('federated_reshares')
-			->where($query->expr()->in('share_id', $query->createFunction($select)));
-		$query->execute();
-
-		$deleteReShares = $this->connection->getQueryBuilder();
-		$deleteReShares->delete('share')
-			->where($deleteReShares->expr()->eq('file_source', $deleteReShares->createNamedParameter($mountPointId)));
-		$deleteReShares->execute();
-	}
-
-	/**
-	 * remove all shares for user $uid if the user was deleted
-	 *
-	 * @param string $uid
-	 */
-	public function removeUserShares($uid): bool {
-		try {
-			// TODO: use query builder
-			$getShare = $this->connection->prepare('
+                $deleteResult = $query->execute([(int)$share['id']]);
+                $deleteResult->closeCursor();
+            } elseif ($share !== false && (int)$share['share_type'] === IShare::TYPE_GROUP) {
+                $this->updateAccepted((int)$share['id'], false);
+            }
+
+            $this->removeReShares($id);
+        } catch (\Doctrine\DBAL\Exception $ex) {
+            $this->logger->emergency('Could not update share', ['exception' => $ex]);
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * remove re-shares from share table and mapping in the federated_reshares table
+     *
+     * @param $mountPointId
+     */
+    protected function removeReShares($mountPointId) {
+        $selectQuery = $this->connection->getQueryBuilder();
+        $query = $this->connection->getQueryBuilder();
+        $selectQuery->select('id')->from('share')
+            ->where($selectQuery->expr()->eq('file_source', $query->createNamedParameter($mountPointId)));
+        $select = $selectQuery->getSQL();
+
+
+        $query->delete('federated_reshares')
+            ->where($query->expr()->in('share_id', $query->createFunction($select)));
+        $query->execute();
+
+        $deleteReShares = $this->connection->getQueryBuilder();
+        $deleteReShares->delete('share')
+            ->where($deleteReShares->expr()->eq('file_source', $deleteReShares->createNamedParameter($mountPointId)));
+        $deleteReShares->execute();
+    }
+
+    /**
+     * remove all shares for user $uid if the user was deleted
+     *
+     * @param string $uid
+     */
+    public function removeUserShares($uid): bool {
+        try {
+            // TODO: use query builder
+            $getShare = $this->connection->prepare('
 				SELECT `id`, `remote`, `share_type`, `share_token`, `remote_id`
 				FROM  `*PREFIX*share_external`
 				WHERE `user` = ?
 				AND `share_type` = ?');
-			$result = $getShare->execute([$uid, IShare::TYPE_USER]);
-			$shares = $result->fetchAll();
-			$result->closeCursor();
-
-			foreach ($shares as $share) {
-				$this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
-			}
-
-			$qb = $this->connection->getQueryBuilder();
-			$qb->delete('share_external')
-				// user field can specify a user or a group
-				->where($qb->expr()->eq('user', $qb->createNamedParameter($uid)))
-				->andWhere(
-					$qb->expr()->orX(
-						// delete direct shares
-						$qb->expr()->eq('share_type', $qb->expr()->literal(IShare::TYPE_USER)),
-						// delete sub-shares of group shares for that user
-						$qb->expr()->andX(
-							$qb->expr()->eq('share_type', $qb->expr()->literal(IShare::TYPE_GROUP)),
-							$qb->expr()->neq('parent', $qb->expr()->literal(-1)),
-						)
-					)
-				);
-			$qb->execute();
-		} catch (\Doctrine\DBAL\Exception $ex) {
-			$this->logger->emergency('Could not delete user shares', ['exception' => $ex]);
-			return false;
-		}
-
-		return true;
-	}
-
-	public function removeGroupShares($gid): bool {
-		try {
-			$getShare = $this->connection->prepare('
+            $result = $getShare->execute([$uid, IShare::TYPE_USER]);
+            $shares = $result->fetchAll();
+            $result->closeCursor();
+
+            foreach ($shares as $share) {
+                $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
+            }
+
+            $qb = $this->connection->getQueryBuilder();
+            $qb->delete('share_external')
+                // user field can specify a user or a group
+                ->where($qb->expr()->eq('user', $qb->createNamedParameter($uid)))
+                ->andWhere(
+                    $qb->expr()->orX(
+                        // delete direct shares
+                        $qb->expr()->eq('share_type', $qb->expr()->literal(IShare::TYPE_USER)),
+                        // delete sub-shares of group shares for that user
+                        $qb->expr()->andX(
+                            $qb->expr()->eq('share_type', $qb->expr()->literal(IShare::TYPE_GROUP)),
+                            $qb->expr()->neq('parent', $qb->expr()->literal(-1)),
+                        )
+                    )
+                );
+            $qb->execute();
+        } catch (\Doctrine\DBAL\Exception $ex) {
+            $this->logger->emergency('Could not delete user shares', ['exception' => $ex]);
+            return false;
+        }
+
+        return true;
+    }
+
+    public function removeGroupShares($gid): bool {
+        try {
+            $getShare = $this->connection->prepare('
 				SELECT `id`, `remote`, `share_type`, `share_token`, `remote_id`
 				FROM  `*PREFIX*share_external`
 				WHERE `user` = ?
 				AND `share_type` = ?');
-			$result = $getShare->execute([$gid, IShare::TYPE_GROUP]);
-			$shares = $result->fetchAll();
-			$result->closeCursor();
-
-			$deletedGroupShares = [];
-			$qb = $this->connection->getQueryBuilder();
-			// delete group share entry and matching sub-entries
-			$qb->delete('share_external')
-				->where(
-					$qb->expr()->orX(
-						$qb->expr()->eq('id', $qb->createParameter('share_id')),
-						$qb->expr()->eq('parent', $qb->createParameter('share_parent_id'))
-					)
-				);
-
-			foreach ($shares as $share) {
-				$qb->setParameter('share_id', $share['id']);
-				$qb->setParameter('share_parent_id', $share['id']);
-				$qb->execute();
-			}
-		} catch (\Doctrine\DBAL\Exception $ex) {
-			$this->logger->emergency('Could not delete user shares', ['exception' => $ex]);
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * return a list of shares which are not yet accepted by the user
-	 *
-	 * @return list<Files_SharingRemoteShare> list of open server-to-server shares
-	 */
-	public function getOpenShares() {
-		return $this->getShares(false);
-	}
-
-	/**
-	 * return a list of shares which are accepted by the user
-	 *
-	 * @return list<Files_SharingRemoteShare> list of accepted server-to-server shares
-	 */
-	public function getAcceptedShares() {
-		return $this->getShares(true);
-	}
-
-	/**
-	 * return a list of shares for the user
-	 *
-	 * @param bool|null $accepted True for accepted only,
-	 *                            false for not accepted,
-	 *                            null for all shares of the user
-	 * @return list<Files_SharingRemoteShare> list of open server-to-server shares
-	 */
-	private function getShares($accepted) {
-		// Not allowing providing a user here,
-		// as we only want to retrieve shares for the current user.
-		$user = $this->userManager->get($this->uid);
-		$groups = $this->groupManager->getUserGroups($user);
-		$userGroups = [];
-		foreach ($groups as $group) {
-			$userGroups[] = $group->getGID();
-		}
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->select('id', 'share_type', 'parent', 'remote', 'remote_id', 'share_token', 'name', 'owner', 'user', 'mountpoint', 'accepted')
-			->from('share_external')
-			->where(
-				$qb->expr()->orX(
-					$qb->expr()->eq('user', $qb->createNamedParameter($this->uid)),
-					$qb->expr()->in(
-						'user',
-						$qb->createNamedParameter($userGroups, IQueryBuilder::PARAM_STR_ARRAY)
-					)
-				)
-			)
-			->orderBy('id', 'ASC');
-
-		try {
-			$result = $qb->execute();
-			$shares = $result->fetchAll();
-			$result->closeCursor();
-
-			// remove parent group share entry if we have a specific user share entry for the user
-			$toRemove = [];
-			foreach ($shares as $share) {
-				if ((int)$share['share_type'] === IShare::TYPE_GROUP && (int)$share['parent'] > 0) {
-					$toRemove[] = $share['parent'];
-				}
-			}
-			$shares = array_filter($shares, function ($share) use ($toRemove) {
-				return !in_array($share['id'], $toRemove, true);
-			});
-
-			if (!is_null($accepted)) {
-				$shares = array_filter($shares, function ($share) use ($accepted) {
-					return (bool)$share['accepted'] === $accepted;
-				});
-			}
-			return array_values($shares);
-		} catch (\Doctrine\DBAL\Exception $e) {
-			$this->logger->emergency('Error when retrieving shares', ['exception' => $e]);
-			return [];
-		}
-	}
+            $result = $getShare->execute([$gid, IShare::TYPE_GROUP]);
+            $shares = $result->fetchAll();
+            $result->closeCursor();
+
+            $deletedGroupShares = [];
+            $qb = $this->connection->getQueryBuilder();
+            // delete group share entry and matching sub-entries
+            $qb->delete('share_external')
+                ->where(
+                    $qb->expr()->orX(
+                        $qb->expr()->eq('id', $qb->createParameter('share_id')),
+                        $qb->expr()->eq('parent', $qb->createParameter('share_parent_id'))
+                    )
+                );
+
+            foreach ($shares as $share) {
+                $qb->setParameter('share_id', $share['id']);
+                $qb->setParameter('share_parent_id', $share['id']);
+                $qb->execute();
+            }
+        } catch (\Doctrine\DBAL\Exception $ex) {
+            $this->logger->emergency('Could not delete user shares', ['exception' => $ex]);
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * return a list of shares which are not yet accepted by the user
+     *
+     * @return list<Files_SharingRemoteShare> list of open server-to-server shares
+     */
+    public function getOpenShares() {
+        return $this->getShares(false);
+    }
+
+    /**
+     * return a list of shares which are accepted by the user
+     *
+     * @return list<Files_SharingRemoteShare> list of accepted server-to-server shares
+     */
+    public function getAcceptedShares() {
+        return $this->getShares(true);
+    }
+
+    /**
+     * return a list of shares for the user
+     *
+     * @param bool|null $accepted True for accepted only,
+     *                            false for not accepted,
+     *                            null for all shares of the user
+     * @return list<Files_SharingRemoteShare> list of open server-to-server shares
+     */
+    private function getShares($accepted) {
+        // Not allowing providing a user here,
+        // as we only want to retrieve shares for the current user.
+        $user = $this->userManager->get($this->uid);
+        $groups = $this->groupManager->getUserGroups($user);
+        $userGroups = [];
+        foreach ($groups as $group) {
+            $userGroups[] = $group->getGID();
+        }
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->select('id', 'share_type', 'parent', 'remote', 'remote_id', 'share_token', 'name', 'owner', 'user', 'mountpoint', 'accepted')
+            ->from('share_external')
+            ->where(
+                $qb->expr()->orX(
+                    $qb->expr()->eq('user', $qb->createNamedParameter($this->uid)),
+                    $qb->expr()->in(
+                        'user',
+                        $qb->createNamedParameter($userGroups, IQueryBuilder::PARAM_STR_ARRAY)
+                    )
+                )
+            )
+            ->orderBy('id', 'ASC');
+
+        try {
+            $result = $qb->execute();
+            $shares = $result->fetchAll();
+            $result->closeCursor();
+
+            // remove parent group share entry if we have a specific user share entry for the user
+            $toRemove = [];
+            foreach ($shares as $share) {
+                if ((int)$share['share_type'] === IShare::TYPE_GROUP && (int)$share['parent'] > 0) {
+                    $toRemove[] = $share['parent'];
+                }
+            }
+            $shares = array_filter($shares, function ($share) use ($toRemove) {
+                return !in_array($share['id'], $toRemove, true);
+            });
+
+            if (!is_null($accepted)) {
+                $shares = array_filter($shares, function ($share) use ($accepted) {
+                    return (bool)$share['accepted'] === $accepted;
+                });
+            }
+            return array_values($shares);
+        } catch (\Doctrine\DBAL\Exception $e) {
+            $this->logger->emergency('Error when retrieving shares', ['exception' => $e]);
+            return [];
+        }
+    }
 }

apps/files_sharing/tests/ApiTest.php

Indentation +1417 added lines, -1417 removed lines

@@ -45,1434 +45,1434 @@
  * TODO: convert to real integration tests
  */
 class ApiTest extends TestCase {
-	public const TEST_FOLDER_NAME = '/folder_share_api_test';
-	public const APP_NAME = 'files_sharing';
-
-	private static $tempStorage;
-
-	/** @var Folder */
-	private $userFolder;
-
-	/** @var string */
-	private $subsubfolder;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_expire_after_n_days', '7');
-
-		Filesystem::getLoader()->removeStorageWrapper('sharing_mask');
-
-		$this->folder = self::TEST_FOLDER_NAME;
-		$this->subfolder = '/subfolder_share_api_test';
-		$this->subsubfolder = '/subsubfolder_share_api_test';
-
-		$this->filename = '/share-api-test.txt';
-
-		// save file with content
-		$this->view->file_put_contents($this->filename, $this->data);
-		$this->view->mkdir($this->folder);
-		$this->view->mkdir($this->folder . $this->subfolder);
-		$this->view->mkdir($this->folder . $this->subfolder . $this->subsubfolder);
-		$this->view->file_put_contents($this->folder . $this->filename, $this->data);
-		$this->view->file_put_contents($this->folder . $this->subfolder . $this->filename, $this->data);
-		$mount = $this->view->getMount($this->filename);
-		$mount->getStorage()->getScanner()->scan('', Scanner::SCAN_RECURSIVE);
-
-		$this->userFolder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER1);
-	}
-
-	protected function tearDown(): void {
-		if ($this->view instanceof View) {
-			$this->view->unlink($this->filename);
-			$this->view->deleteAll($this->folder);
-		}
-
-		self::$tempStorage = null;
-
-		parent::tearDown();
-	}
-
-	/**
-	 * @param string $userId The userId of the caller
-	 * @return ShareAPIController
-	 */
-	private function createOCS($userId) {
-		$l = $this->getMockBuilder(IL10N::class)->getMock();
-		$l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-		$config = $this->createMock(IConfig::class);
-		$appManager = $this->createMock(IAppManager::class);
-		$serverContainer = $this->createMock(ContainerInterface::class);
-		$userStatusManager = $this->createMock(IUserStatusManager::class);
-		$previewManager = $this->createMock(IPreview::class);
-		$dateTimeZone = $this->createMock(IDateTimeZone::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$providerFactory = $this->createMock(IProviderFactory::class);
-		$mailer = $this->createMock(IMailer::class);
-		$tagManager = $this->createMock(ITagManager::class);
-		$dateTimeZone->method('getTimeZone')->willReturn(new \DateTimeZone(date_default_timezone_get()));
-
-		return new ShareAPIController(
-			self::APP_NAME,
-			$this->getMockBuilder(IRequest::class)->getMock(),
-			$this->shareManager,
-			Server::get(IGroupManager::class),
-			Server::get(IUserManager::class),
-			Server::get(IRootFolder::class),
-			Server::get(IURLGenerator::class),
-			$l,
-			$config,
-			$appManager,
-			$serverContainer,
-			$userStatusManager,
-			$previewManager,
-			$dateTimeZone,
-			$logger,
-			$providerFactory,
-			$mailer,
-			$tagManager,
-			$userId,
-		);
-	}
-
-	public function testCreateShareUserFile(): void {
-		$this->setUp(); // for some reasons phpunit refuses to do this for us only for this test
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(19, $data['permissions']);
-		$this->assertEmpty($data['expiration']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-
-		$ocs->cleanup();
-	}
-
-	public function testCreateShareUserFolder(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(31, $data['permissions']);
-		$this->assertEmpty($data['expiration']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-	}
-
-
-	public function testCreateShareGroupFile(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(19, $data['permissions']);
-		$this->assertEmpty($data['expiration']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-	}
-
-	public function testCreateShareGroupFolder(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(31, $data['permissions']);
-		$this->assertEmpty($data['expiration']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-	}
-
-	/**
-	 * @group RoutingWeirdness
-	 */
-	public function testCreateShareLink(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(Constants::PERMISSION_ALL,
-			$data['permissions']);
-		$this->assertEmpty($data['expiration']);
-		$this->assertTrue(is_string($data['token']));
-
-		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
-		$this->assertEquals($url, $data['url']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-	}
-
-	/**
-	 * @group RoutingWeirdness
-	 */
-	public function testCreateShareLinkPublicUpload(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals(
-			Constants::PERMISSION_READ
-			| Constants::PERMISSION_CREATE
-			| Constants::PERMISSION_UPDATE
-			| Constants::PERMISSION_DELETE
-			| Constants::PERMISSION_SHARE,
-			$data['permissions']
-		);
-		$this->assertEmpty($data['expiration']);
-		$this->assertTrue(is_string($data['token']));
-
-		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
-		$this->assertEquals($url, $data['url']);
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-	}
-
-	public function testEnforceLinkPassword(): void {
-		$password = md5(time());
-		$config = Server::get(IConfig::class);
-		$config->setAppValue('core', 'shareapi_enforce_links_password', 'yes');
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-			$this->fail();
-		} catch (OCSForbiddenException $e) {
-		}
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '');
-			$this->fail();
-		} catch (OCSForbiddenException $e) {
-		}
-		$ocs->cleanup();
-
-		// share with password should succeed
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', $password);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-
-		// setting new password should succeed
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare($data['id'], null, $password);
-		$ocs->cleanup();
-
-		// removing password should fail
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->updateShare($data['id']);
-			$this->fail();
-		} catch (OCSBadRequestException $e) {
-		}
-		$ocs->cleanup();
-
-		// cleanup
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-
-		$config->setAppValue('core', 'shareapi_enforce_links_password', 'no');
-		$this->addToAssertionCount(1);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testSharePermissions(): void {
-		// sharing file to a user should work if shareapi_exclude_groups is set
-		// to no
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-
-		// exclude groups, but not the group the user belongs to. Sharing should still work
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'yes');
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', 'admin,group1,group2');
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($data['id']);
-		$ocs->cleanup();
-
-		// now we exclude the group the user belongs to ('group'), sharing should fail now
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', 'admin,group');
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-
-		// cleanup
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
-		Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', '');
-
-		$this->addToAssertionCount(1);
-	}
-
-
-	/**
-	 * @medium
-	 */
-	public function testGetAllShares(): void {
-		$node = $this->userFolder->get($this->filename);
-
-		$share = $this->shareManager->newShare();
-		$share->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-
-		$share = $this->shareManager->createShare($share);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		$this->assertTrue(count($result->getData()) === 1);
-
-		$this->shareManager->deleteShare($share);
-	}
-
-	public function testGetAllSharesWithMe(): void {
-		$this->loginAsUser(self::TEST_FILES_SHARING_API_USER2);
-		$this->logout();
-
-		$node1 = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$node2 = $this->userFolder->get($this->folder);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result = $ocs->getShares('true');
-		$ocs->cleanup();
-
-		$this->assertCount(2, $result->getData());
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-	}
-
-	/**
-	 * @medium
-	 * @group RoutingWeirdness
-	 */
-	public function testPublicLinkUrl(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-
-		// check if we have a token
-		$this->assertTrue(is_string($data['token']));
-		$id = $data['id'];
-
-		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
-		$this->assertEquals($url, $data['url']);
-
-		// check for link in getall shares
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals($url, current($data)['url']);
-
-		// check for path
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals($url, current($data)['url']);
-
-		// check in share id
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShare($id);
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertEquals($url, current($data)['url']);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($id);
-		$ocs->cleanup();
-	}
-
-	/**
-	 * @medium
-	 * @depends testCreateShareUserFile
-	 * @depends testCreateShareLink
-	 */
-	public function testGetShareFromSource(): void {
-		$node = $this->userFolder->get($this->filename);
-		$share = $this->shareManager->newShare();
-		$share->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share);
-
-		$share = $this->shareManager->newShare();
-		$share->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		// test should return one share created from testCreateShare()
-		$this->assertTrue(count($result->getData()) === 2);
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-	}
-
-	/**
-	 * @medium
-	 * @depends testCreateShareUserFile
-	 * @depends testCreateShareLink
-	 */
-	public function testGetShareFromSourceWithReshares(): void {
-		$node = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share2 = $this->shareManager->createShare($share2);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		// test should return one share
-		$this->assertTrue(count($result->getData()) === 1);
-
-		// now also ask for the reshares
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares('false', 'true', 'false', $this->filename);
-		$ocs->cleanup();
-
-		// now we should get two shares, the initial share and the reshare
-		$this->assertCount(2, $result->getData());
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-	}
-
-	/**
-	 * @medium
-	 * @depends testCreateShareUserFile
-	 */
-	public function testGetShareFromId(): void {
-		$node = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-
-		// call getShare() with share ID
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShare($share1->getId());
-		$ocs->cleanup();
-
-		// test should return one share created from testCreateShare()
-		$this->assertEquals(1, count($result->getData()));
-
-		$this->shareManager->deleteShare($share1);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testGetShareFromFolder(): void {
-		$node1 = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-
-		$node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares('false', 'false', 'true', $this->folder);
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$this->assertTrue(count($result->getData()) === 1);
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-	}
-
-	public function testGetShareFromFolderWithFile(): void {
-		$node1 = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->getShares('false', 'false', 'true', $this->filename);
-			$this->fail();
-		} catch (OCSBadRequestException $e) {
-			$this->assertEquals('Not a directory', $e->getMessage());
-		}
-		$ocs->cleanup();
-
-		$this->shareManager->deleteShare($share1);
-	}
-
-	/**
-	 * share a folder, than reshare a file within the shared folder and check if we construct the correct path
-	 * @medium
-	 */
-	public function testGetShareFromFolderReshares(): void {
-		$node1 = $this->userFolder->get($this->folder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		$node3 = $this->userFolder->get($this->folder . '/' . $this->subfolder . '/' . $this->filename);
-		$share3 = $this->shareManager->newShare();
-		$share3->setNode($node3)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share3 = $this->shareManager->createShare($share3);
-		$share3->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share3);
-
-		$testValues = [
-			['query' => $this->folder,
-				'expectedResult' => $this->folder . $this->filename],
-			['query' => $this->folder . $this->subfolder,
-				'expectedResult' => $this->folder . $this->subfolder . $this->filename],
-		];
-
-		foreach ($testValues as $value) {
-			$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-			$result = $ocs->getShares('false', 'false', 'true', $value['query']);
-			$ocs->cleanup();
-
-			// test should return one share within $this->folder
-			$data = $result->getData();
-
-			$this->assertEquals($value['expectedResult'], $data[0]['path']);
-		}
-
-		// cleanup
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-		$this->shareManager->deleteShare($share3);
-	}
-
-	/**
-	 * reshare a sub folder and check if we get the correct path
-	 * @medium
-	 */
-	public function testGetShareFromSubFolderReShares(): void {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$node2 = Server::get(IRootFolder::class)->getUserFolder(self::TEST_FILES_SHARING_API_USER2)->get($this->subfolder);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$data = $result->getData();
-
-		// we should get exactly one result
-		$this->assertCount(1, $data);
-
-		$this->assertEquals($this->subfolder, $data[0]['path']);
-
-		$this->shareManager->deleteShare($share2);
-		$this->shareManager->deleteShare($share1);
-	}
-
-	/**
-	 * test re-re-share of folder if the path gets constructed correctly
-	 * @medium
-	 */
-	public function XtestGetShareFromFolderReReShares() {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-
-		$node2 = $this->userFolder->get($this->folder . $this->subfolder . $this->subsubfolder);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share2 = $this->shareManager->createShare($share2);
-
-		$share3 = $this->shareManager->newShare();
-		$share3->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER3)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share3 = $this->shareManager->createShare($share3);
-
-		/*
+    public const TEST_FOLDER_NAME = '/folder_share_api_test';
+    public const APP_NAME = 'files_sharing';
+
+    private static $tempStorage;
+
+    /** @var Folder */
+    private $userFolder;
+
+    /** @var string */
+    private $subsubfolder;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_expire_after_n_days', '7');
+
+        Filesystem::getLoader()->removeStorageWrapper('sharing_mask');
+
+        $this->folder = self::TEST_FOLDER_NAME;
+        $this->subfolder = '/subfolder_share_api_test';
+        $this->subsubfolder = '/subsubfolder_share_api_test';
+
+        $this->filename = '/share-api-test.txt';
+
+        // save file with content
+        $this->view->file_put_contents($this->filename, $this->data);
+        $this->view->mkdir($this->folder);
+        $this->view->mkdir($this->folder . $this->subfolder);
+        $this->view->mkdir($this->folder . $this->subfolder . $this->subsubfolder);
+        $this->view->file_put_contents($this->folder . $this->filename, $this->data);
+        $this->view->file_put_contents($this->folder . $this->subfolder . $this->filename, $this->data);
+        $mount = $this->view->getMount($this->filename);
+        $mount->getStorage()->getScanner()->scan('', Scanner::SCAN_RECURSIVE);
+
+        $this->userFolder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER1);
+    }
+
+    protected function tearDown(): void {
+        if ($this->view instanceof View) {
+            $this->view->unlink($this->filename);
+            $this->view->deleteAll($this->folder);
+        }
+
+        self::$tempStorage = null;
+
+        parent::tearDown();
+    }
+
+    /**
+     * @param string $userId The userId of the caller
+     * @return ShareAPIController
+     */
+    private function createOCS($userId) {
+        $l = $this->getMockBuilder(IL10N::class)->getMock();
+        $l->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+        $config = $this->createMock(IConfig::class);
+        $appManager = $this->createMock(IAppManager::class);
+        $serverContainer = $this->createMock(ContainerInterface::class);
+        $userStatusManager = $this->createMock(IUserStatusManager::class);
+        $previewManager = $this->createMock(IPreview::class);
+        $dateTimeZone = $this->createMock(IDateTimeZone::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $providerFactory = $this->createMock(IProviderFactory::class);
+        $mailer = $this->createMock(IMailer::class);
+        $tagManager = $this->createMock(ITagManager::class);
+        $dateTimeZone->method('getTimeZone')->willReturn(new \DateTimeZone(date_default_timezone_get()));
+
+        return new ShareAPIController(
+            self::APP_NAME,
+            $this->getMockBuilder(IRequest::class)->getMock(),
+            $this->shareManager,
+            Server::get(IGroupManager::class),
+            Server::get(IUserManager::class),
+            Server::get(IRootFolder::class),
+            Server::get(IURLGenerator::class),
+            $l,
+            $config,
+            $appManager,
+            $serverContainer,
+            $userStatusManager,
+            $previewManager,
+            $dateTimeZone,
+            $logger,
+            $providerFactory,
+            $mailer,
+            $tagManager,
+            $userId,
+        );
+    }
+
+    public function testCreateShareUserFile(): void {
+        $this->setUp(); // for some reasons phpunit refuses to do this for us only for this test
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(19, $data['permissions']);
+        $this->assertEmpty($data['expiration']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+
+        $ocs->cleanup();
+    }
+
+    public function testCreateShareUserFolder(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(31, $data['permissions']);
+        $this->assertEmpty($data['expiration']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+    }
+
+
+    public function testCreateShareGroupFile(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(19, $data['permissions']);
+        $this->assertEmpty($data['expiration']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+    }
+
+    public function testCreateShareGroupFolder(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(31, $data['permissions']);
+        $this->assertEmpty($data['expiration']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+    }
+
+    /**
+     * @group RoutingWeirdness
+     */
+    public function testCreateShareLink(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(Constants::PERMISSION_ALL,
+            $data['permissions']);
+        $this->assertEmpty($data['expiration']);
+        $this->assertTrue(is_string($data['token']));
+
+        // check for correct link
+        $url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+        $this->assertEquals($url, $data['url']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+    }
+
+    /**
+     * @group RoutingWeirdness
+     */
+    public function testCreateShareLinkPublicUpload(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals(
+            Constants::PERMISSION_READ
+            | Constants::PERMISSION_CREATE
+            | Constants::PERMISSION_UPDATE
+            | Constants::PERMISSION_DELETE
+            | Constants::PERMISSION_SHARE,
+            $data['permissions']
+        );
+        $this->assertEmpty($data['expiration']);
+        $this->assertTrue(is_string($data['token']));
+
+        // check for correct link
+        $url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+        $this->assertEquals($url, $data['url']);
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+    }
+
+    public function testEnforceLinkPassword(): void {
+        $password = md5(time());
+        $config = Server::get(IConfig::class);
+        $config->setAppValue('core', 'shareapi_enforce_links_password', 'yes');
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+            $this->fail();
+        } catch (OCSForbiddenException $e) {
+        }
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '');
+            $this->fail();
+        } catch (OCSForbiddenException $e) {
+        }
+        $ocs->cleanup();
+
+        // share with password should succeed
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', $password);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+
+        // setting new password should succeed
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare($data['id'], null, $password);
+        $ocs->cleanup();
+
+        // removing password should fail
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->updateShare($data['id']);
+            $this->fail();
+        } catch (OCSBadRequestException $e) {
+        }
+        $ocs->cleanup();
+
+        // cleanup
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+
+        $config->setAppValue('core', 'shareapi_enforce_links_password', 'no');
+        $this->addToAssertionCount(1);
+    }
+
+    /**
+     * @medium
+     */
+    public function testSharePermissions(): void {
+        // sharing file to a user should work if shareapi_exclude_groups is set
+        // to no
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+
+        // exclude groups, but not the group the user belongs to. Sharing should still work
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'yes');
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', 'admin,group1,group2');
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+
+        $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($data['id']);
+        $ocs->cleanup();
+
+        // now we exclude the group the user belongs to ('group'), sharing should fail now
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', 'admin,group');
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+
+        // cleanup
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups', 'no');
+        Server::get(IConfig::class)->setAppValue('core', 'shareapi_exclude_groups_list', '');
+
+        $this->addToAssertionCount(1);
+    }
+
+
+    /**
+     * @medium
+     */
+    public function testGetAllShares(): void {
+        $node = $this->userFolder->get($this->filename);
+
+        $share = $this->shareManager->newShare();
+        $share->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+
+        $share = $this->shareManager->createShare($share);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        $this->assertTrue(count($result->getData()) === 1);
+
+        $this->shareManager->deleteShare($share);
+    }
+
+    public function testGetAllSharesWithMe(): void {
+        $this->loginAsUser(self::TEST_FILES_SHARING_API_USER2);
+        $this->logout();
+
+        $node1 = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $node2 = $this->userFolder->get($this->folder);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $result = $ocs->getShares('true');
+        $ocs->cleanup();
+
+        $this->assertCount(2, $result->getData());
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+    }
+
+    /**
+     * @medium
+     * @group RoutingWeirdness
+     */
+    public function testPublicLinkUrl(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+
+        // check if we have a token
+        $this->assertTrue(is_string($data['token']));
+        $id = $data['id'];
+
+        // check for correct link
+        $url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+        $this->assertEquals($url, $data['url']);
+
+        // check for link in getall shares
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals($url, current($data)['url']);
+
+        // check for path
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals($url, current($data)['url']);
+
+        // check in share id
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShare($id);
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertEquals($url, current($data)['url']);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($id);
+        $ocs->cleanup();
+    }
+
+    /**
+     * @medium
+     * @depends testCreateShareUserFile
+     * @depends testCreateShareLink
+     */
+    public function testGetShareFromSource(): void {
+        $node = $this->userFolder->get($this->filename);
+        $share = $this->shareManager->newShare();
+        $share->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share);
+
+        $share = $this->shareManager->newShare();
+        $share->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        // test should return one share created from testCreateShare()
+        $this->assertTrue(count($result->getData()) === 2);
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+    }
+
+    /**
+     * @medium
+     * @depends testCreateShareUserFile
+     * @depends testCreateShareLink
+     */
+    public function testGetShareFromSourceWithReshares(): void {
+        $node = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share2 = $this->shareManager->createShare($share2);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        // test should return one share
+        $this->assertTrue(count($result->getData()) === 1);
+
+        // now also ask for the reshares
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares('false', 'true', 'false', $this->filename);
+        $ocs->cleanup();
+
+        // now we should get two shares, the initial share and the reshare
+        $this->assertCount(2, $result->getData());
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+    }
+
+    /**
+     * @medium
+     * @depends testCreateShareUserFile
+     */
+    public function testGetShareFromId(): void {
+        $node = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+
+        // call getShare() with share ID
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShare($share1->getId());
+        $ocs->cleanup();
+
+        // test should return one share created from testCreateShare()
+        $this->assertEquals(1, count($result->getData()));
+
+        $this->shareManager->deleteShare($share1);
+    }
+
+    /**
+     * @medium
+     */
+    public function testGetShareFromFolder(): void {
+        $node1 = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+
+        $node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares('false', 'false', 'true', $this->folder);
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $this->assertTrue(count($result->getData()) === 1);
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+    }
+
+    public function testGetShareFromFolderWithFile(): void {
+        $node1 = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->getShares('false', 'false', 'true', $this->filename);
+            $this->fail();
+        } catch (OCSBadRequestException $e) {
+            $this->assertEquals('Not a directory', $e->getMessage());
+        }
+        $ocs->cleanup();
+
+        $this->shareManager->deleteShare($share1);
+    }
+
+    /**
+     * share a folder, than reshare a file within the shared folder and check if we construct the correct path
+     * @medium
+     */
+    public function testGetShareFromFolderReshares(): void {
+        $node1 = $this->userFolder->get($this->folder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        $node3 = $this->userFolder->get($this->folder . '/' . $this->subfolder . '/' . $this->filename);
+        $share3 = $this->shareManager->newShare();
+        $share3->setNode($node3)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share3 = $this->shareManager->createShare($share3);
+        $share3->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share3);
+
+        $testValues = [
+            ['query' => $this->folder,
+                'expectedResult' => $this->folder . $this->filename],
+            ['query' => $this->folder . $this->subfolder,
+                'expectedResult' => $this->folder . $this->subfolder . $this->filename],
+        ];
+
+        foreach ($testValues as $value) {
+            $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+            $result = $ocs->getShares('false', 'false', 'true', $value['query']);
+            $ocs->cleanup();
+
+            // test should return one share within $this->folder
+            $data = $result->getData();
+
+            $this->assertEquals($value['expectedResult'], $data[0]['path']);
+        }
+
+        // cleanup
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+        $this->shareManager->deleteShare($share3);
+    }
+
+    /**
+     * reshare a sub folder and check if we get the correct path
+     * @medium
+     */
+    public function testGetShareFromSubFolderReShares(): void {
+        $node1 = $this->userFolder->get($this->folder . $this->subfolder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $node2 = Server::get(IRootFolder::class)->getUserFolder(self::TEST_FILES_SHARING_API_USER2)->get($this->subfolder);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $data = $result->getData();
+
+        // we should get exactly one result
+        $this->assertCount(1, $data);
+
+        $this->assertEquals($this->subfolder, $data[0]['path']);
+
+        $this->shareManager->deleteShare($share2);
+        $this->shareManager->deleteShare($share1);
+    }
+
+    /**
+     * test re-re-share of folder if the path gets constructed correctly
+     * @medium
+     */
+    public function XtestGetShareFromFolderReReShares() {
+        $node1 = $this->userFolder->get($this->folder . $this->subfolder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+
+        $node2 = $this->userFolder->get($this->folder . $this->subfolder . $this->subsubfolder);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share2 = $this->shareManager->createShare($share2);
+
+        $share3 = $this->shareManager->newShare();
+        $share3->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER3)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share3 = $this->shareManager->createShare($share3);
+
+        /*
 		 * Test as recipient
 		 */
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
 
-		// test should return one share within $this->folder
-		$data = $result->getData();
+        // test should return one share within $this->folder
+        $data = $result->getData();
 
-		// we should get exactly one result
-		$this->assertCount(1, $data);
-		$this->assertEquals($this->subsubfolder, $data[0]['path']);
+        // we should get exactly one result
+        $this->assertCount(1, $data);
+        $this->assertEquals($this->subsubfolder, $data[0]['path']);
 
-		/*
+        /*
 		 * Test for first owner/initiator
 		 */
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
 
-		// test should return one share within $this->folder
-		$data = $result->getData();
+        // test should return one share within $this->folder
+        $data = $result->getData();
 
-		// we should get exactly one result
-		$this->assertCount(1, $data);
-		$this->assertEquals($this->folder . $this->subfolder, $data[0]['path']);
+        // we should get exactly one result
+        $this->assertCount(1, $data);
+        $this->assertEquals($this->folder . $this->subfolder, $data[0]['path']);
 
-		/*
+        /*
 		 * Test for second initiator
 		 */
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$data = $result->getData();
-
-		// we should get exactly one result
-		$this->assertCount(1, $data);
-		$this->assertEquals($this->subfolder . $this->subsubfolder, $data[0]['path']);
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-		$this->shareManager->deleteShare($share3);
-	}
-
-	/**
-	 * test multiple shared folder if the path gets constructed correctly
-	 * @medium
-	 */
-	public function testGetShareMultipleSharedFolder(): void {
-		$this->setUp();
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$node2 = $this->userFolder->get($this->folder);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		$share3 = $this->shareManager->newShare();
-		$share3->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share3 = $this->shareManager->createShare($share3);
-		$share3->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share3);
-
-		// $request = $this->createRequest(['path' => $this->subfolder]);
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result1 = $ocs->getShares('false', 'false', 'false', $this->subfolder);
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$data1 = $result1->getData();
-		$this->assertCount(1, $data1);
-		$s1 = reset($data1);
-
-		//$request = $this->createRequest(['path' => $this->folder.$this->subfolder]);
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result2 = $ocs->getShares('false', 'false', 'false', $this->folder . $this->subfolder);
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$data2 = $result2->getData();
-		$this->assertCount(1, $data2);
-		$s2 = reset($data2);
-
-		$this->assertEquals($this->subfolder, $s1['path']);
-		$this->assertEquals($this->folder . $this->subfolder, $s2['path']);
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-		$this->shareManager->deleteShare($share3);
-	}
-
-	/**
-	 * test re-re-share of folder if the path gets constructed correctly
-	 * @medium
-	 */
-	public function testGetShareFromFileReReShares(): void {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$user2Folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
-		$node2 = $user2Folder->get($this->subfolder . $this->filename);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		$user3Folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER3);
-		$node3 = $user3Folder->get($this->filename);
-		$share3 = $this->shareManager->newShare();
-		$share3->setNode($node3)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER3)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share3 = $this->shareManager->createShare($share3);
-		$share3->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share3);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		// test should return one share within $this->folder
-		$data = $result->getData();
-
-		// we should get exactly one result
-		$this->assertCount(1, $data);
-
-		$this->assertEquals($this->filename, $data[0]['path']);
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-		$this->shareManager->deleteShare($share3);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testGetShareFromUnknownId(): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
-		try {
-			$ocs->getShare(0);
-			$this->fail();
-		} catch (OCSNotFoundException $e) {
-			$this->assertEquals('Wrong share ID, share does not exist', $e->getMessage());
-		}
-		$ocs->cleanup();
-	}
-
-	/**
-	 * @medium
-	 * @depends testCreateShareUserFile
-	 * @depends testCreateShareLink
-	 */
-	public function testUpdateShare(): void {
-		$password = md5(time());
-
-		$node1 = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19)
-			->setAttributes($this->shareManager->newShare()->newAttributes());
-
-		$this->assertNotNull($share1->getAttributes());
-		$share1 = $this->shareManager->createShare($share1);
-		$this->assertEquals(19, $share1->getPermissions());
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-		$this->assertEquals(1, $share2->getPermissions());
-
-		// update permissions
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare(
-			$share1->getId(), 1, null, null, null, null, null, null, null,
-			'[{"scope": "app1", "key": "attr1", "value": true}]'
-		);
-		$ocs->cleanup();
-
-		$share1 = $this->shareManager->getShareById('ocinternal:' . $share1->getId());
-		$this->assertEquals(1, $share1->getPermissions());
-		$this->assertEquals(true, $share1->getAttributes()->getAttribute('app1', 'attr1'));
-
-		// update password for link share
-		$this->assertNull($share2->getPassword());
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare($share2->getId(), null, $password);
-		$ocs->cleanup();
-
-		$share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
-		$this->assertNotNull($share2->getPassword());
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare($share2->getId(), null, '');
-		$ocs->cleanup();
-
-		$share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
-		$this->assertNull($share2->getPassword());
-
-		$this->shareManager->deleteShare($share1);
-		$this->shareManager->deleteShare($share2);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testUpdateShareUpload(): void {
-		$node1 = $this->userFolder->get($this->folder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share1 = $this->shareManager->createShare($share1);
-
-		// update public upload
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare($share1->getId(), null, null, null, 'true');
-		$ocs->cleanup();
-
-		$share1 = $this->shareManager->getShareById($share1->getFullId());
-		$this->assertEquals(
-			Constants::PERMISSION_READ
-			| Constants::PERMISSION_CREATE
-			| Constants::PERMISSION_UPDATE
-			| Constants::PERMISSION_DELETE
-			| Constants::PERMISSION_SHARE,
-			$share1->getPermissions()
-		);
-
-		// cleanup
-		$this->shareManager->deleteShare($share1);
-	}
-
-	/**
-	 * @medium
-	 */
-	public function testUpdateShareExpireDate(): void {
-		$node1 = $this->userFolder->get($this->folder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$config = Server::get(IConfig::class);
-
-		// enforce expire date, by default 7 days after the file was shared
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
-
-		$dateWithinRange = new \DateTime();
-		$dateWithinRange->add(new \DateInterval('P6D'));
-
-		$dateOutOfRange = new \DateTime();
-		$dateOutOfRange->add(new \DateInterval('P8D'));
-
-		// update expire date to a valid value
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->updateShare($share1->getId(), null, null, null, null, $dateWithinRange->format('Y-m-d'));
-		$ocs->cleanup();
-
-		$share1 = $this->shareManager->getShareById($share1->getFullId());
-
-		// date should be changed
-		$dateWithinRange->setTime(0, 0, 0);
-		$dateWithinRange->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-		$this->assertEquals($dateWithinRange, $share1->getExpirationDate());
-
-		// update expire date to a value out of range
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->updateShare($share1->getId());
-			$this->fail();
-		} catch (OCSBadRequestException $e) {
-		}
-		$ocs->cleanup();
-
-		$share1 = $this->shareManager->getShareById($share1->getFullId());
-
-		// date shouldn't be changed
-		$this->assertEquals($dateWithinRange, $share1->getExpirationDate());
-
-		// Try to remove expire date
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		try {
-			$ocs->updateShare($share1->getId());
-			$this->fail();
-		} catch (OCSBadRequestException $e) {
-		}
-		$ocs->cleanup();
-
-		$share1 = $this->shareManager->getShareById($share1->getFullId());
-
-
-		// date shouldn't be changed
-		$this->assertEquals($dateWithinRange, $share1->getExpirationDate());
-		// cleanup
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'no');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
-		$this->shareManager->deleteShare($share1);
-	}
-
-	/**
-	 * @medium
-	 * @depends testCreateShareUserFile
-	 */
-	public function testDeleteShare(): void {
-		$node1 = $this->userFolder->get($this->filename);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(19);
-		$share1 = $this->shareManager->createShare($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($share1->getId());
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($share2->getId());
-		$ocs->cleanup();
-
-		$this->assertEmpty($this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER2, IShare::TYPE_USER));
-		$this->assertEmpty($this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER2, IShare::TYPE_LINK));
-	}
-
-	/**
-	 * test unshare of a reshared file
-	 */
-	public function testDeleteReshare(): void {
-		$node1 = $this->userFolder->get($this->folder);
-		$share1 = $this->shareManager->newShare();
-		$share1->setNode($node1)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
-			->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(31);
-		$share1 = $this->shareManager->createShare($share1);
-		$share1->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share1);
-
-		$user2folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
-		$node2 = $user2folder->get($this->folder . '/' . $this->filename);
-		$share2 = $this->shareManager->newShare();
-		$share2->setNode($node2)
-			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
-			->setShareType(IShare::TYPE_LINK)
-			->setPermissions(1);
-		$share2 = $this->shareManager->createShare($share2);
-		$share2->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share2);
-
-		// test if we can unshare the link again
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$ocs->deleteShare($share2->getId());
-		$ocs->cleanup();
-
-		$this->shareManager->deleteShare($share1);
-		$this->addToAssertionCount(1);
-	}
-
-	/**
-	 * share a folder which contains a share mount point, should be forbidden
-	 */
-	public function testShareFolderWithAMountPoint(): void {
-		// user 1 shares a folder with user2
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-		$share->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share);
-
-		// user2 shares a file from the folder as link
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
-		$view->mkdir('localDir');
-
-		// move mount point to the folder "localDir"
-		$result = $view->rename($this->folder, 'localDir/' . $this->folder);
-		$this->assertTrue($result !== false);
-
-		// try to share "localDir"
-		$fileInfo2 = $view->getFileInfo('localDir');
-
-		$this->assertTrue($fileInfo2 instanceof FileInfo);
-
-		$pass = true;
-		try {
-			$this->share(
-				IShare::TYPE_USER,
-				'localDir',
-				self::TEST_FILES_SHARING_API_USER2,
-				self::TEST_FILES_SHARING_API_USER3,
-				Constants::PERMISSION_ALL
-			);
-		} catch (\Exception $e) {
-			$pass = false;
-		}
-
-		$this->assertFalse($pass);
-
-		//cleanup
-
-		$result = $view->rename('localDir/' . $this->folder, $this->folder);
-		$this->assertTrue($result !== false);
-		$view->unlink('localDir');
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		$this->shareManager->deleteShare($share);
-	}
-
-	/**
-	 * Post init mount points hook for mounting simulated ext storage
-	 */
-	public static function initTestMountPointsHook($data) {
-		if ($data['user'] === self::TEST_FILES_SHARING_API_USER1) {
-			Filesystem::mount(self::$tempStorage, [], '/' . self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
-		}
-	}
-
-	/**
-	 * Tests mounting a folder that is an external storage mount point.
-	 */
-	public function testShareStorageMountPoint(): void {
-		$tempStorage = new Temporary([]);
-		$tempStorage->file_put_contents('test.txt', 'abcdef');
-		$tempStorage->getScanner()->scan('');
-
-		$this->registerMount(self::TEST_FILES_SHARING_API_USER1, $tempStorage, self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
-
-		// logging in will auto-mount the temp storage for user1 as well
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		// user 1 shares the mount point folder with user2
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-		$share->setStatus(IShare::STATUS_ACCEPTED);
-		$this->shareManager->updateShare($share);
-
-		// user2: check that mount point name appears correctly
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
-
-		$this->assertTrue($view->file_exists($this->folder));
-		$this->assertTrue($view->file_exists($this->folder . '/test.txt'));
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		$this->shareManager->deleteShare($share);
-
-		\OC_Hook::clear('OC_Filesystem', 'post_initMountPoints');
-		\OC_Hook::clear('\OCA\Files_Sharing\Tests\ApiTest', 'initTestMountPointsHook');
-	}
-
-	public static function datesProvider() {
-		$date = new \DateTime();
-		$date->setTime(0, 0);
-		$date->add(new \DateInterval('P5D'));
-		$date->setTimezone(new \DateTimeZone(date_default_timezone_get()));
-
-		return [
-			[$date->format('Y-m-d H:i:s'), true],
-			['abc', false],
-			[$date->format('Y-m-d H:i:s') . 'xyz', false],
-		];
-	}
-
-	/**
-	 * Make sure only ISO 8601 dates are accepted
-	 *
-	 * @group RoutingWeirdness
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('datesProvider')]
-	public function testPublicLinkExpireDate($date, $valid): void {
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-
-		try {
-			$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date);
-			$this->assertTrue($valid);
-		} catch (OCSNotFoundException $e) {
-			$this->assertFalse($valid);
-			$this->assertEquals('Invalid date. Format must be YYYY-MM-DD', $e->getMessage());
-			$ocs->cleanup();
-			return;
-		}
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertTrue(is_string($data['token']));
-		$this->assertEquals(substr($date, 0, 10), substr($data['expiration'], 0, 10));
-
-		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
-		$this->assertEquals($url, $data['url']);
-
-		$share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
-
-		$this->assertEquals($date, $share->getExpirationDate()->format('Y-m-d H:i:s'));
-
-		$this->shareManager->deleteShare($share);
-	}
-
-	/**
-	 * @group RoutingWeirdness
-	 */
-	public function testCreatePublicLinkExpireDateValid(): void {
-		$config = Server::get(IConfig::class);
-
-		// enforce expire date, by default 7 days after the file was shared
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
-
-		$date = new \DateTime();
-		$date->add(new \DateInterval('P5D'));
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
-		$ocs->cleanup();
-
-		$data = $result->getData();
-		$this->assertTrue(is_string($data['token']));
-		$this->assertEquals($date->format('Y-m-d 00:00:00'), $data['expiration']);
-
-		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
-		$this->assertEquals($url, $data['url']);
-
-		$share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
-		$date->setTime(0, 0, 0);
-		$this->assertEquals($date, $share->getExpirationDate());
-
-		$this->shareManager->deleteShare($share);
-
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'no');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
-	}
-
-	public function testCreatePublicLinkExpireDateInvalidFuture(): void {
-		$config = Server::get(IConfig::class);
-
-		// enforce expire date, by default 7 days after the file was shared
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
-
-		$date = new \DateTime();
-		$date->add(new \DateInterval('P8D'));
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-
-		try {
-			$ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
-			$this->fail();
-		} catch (OCSException $e) {
-			$this->assertEquals(404, $e->getCode());
-			$this->assertEquals('Cannot set expiration date more than 7 days in the future', $e->getMessage());
-		}
-		$ocs->cleanup();
-
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'no');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
-	}
-
-	public function XtestCreatePublicLinkExpireDateInvalidPast() {
-		$config = Server::get(IConfig::class);
-
-		$date = new \DateTime();
-		$date->sub(new \DateInterval('P8D'));
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-
-		try {
-			$ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
-			$this->fail();
-		} catch (OCSException $e) {
-			$this->assertEquals(404, $e->getCode());
-			$this->assertEquals('Expiration date is in the past', $e->getMessage());
-		}
-		$ocs->cleanup();
-
-		$config->setAppValue('core', 'shareapi_default_expire_date', 'no');
-		$config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
-	}
-
-	/**
-	 * test for no invisible shares
-	 * See: https://github.com/owncloud/core/issues/22295
-	 */
-	public function testInvisibleSharesUser(): void {
-		// simulate a post request
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
-		$ocs->cleanup();
-		$data = $result->getData();
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $data = $result->getData();
+
+        // we should get exactly one result
+        $this->assertCount(1, $data);
+        $this->assertEquals($this->subfolder . $this->subsubfolder, $data[0]['path']);
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+        $this->shareManager->deleteShare($share3);
+    }
+
+    /**
+     * test multiple shared folder if the path gets constructed correctly
+     * @medium
+     */
+    public function testGetShareMultipleSharedFolder(): void {
+        $this->setUp();
+        $node1 = $this->userFolder->get($this->folder . $this->subfolder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $node2 = $this->userFolder->get($this->folder);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        $share3 = $this->shareManager->newShare();
+        $share3->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share3 = $this->shareManager->createShare($share3);
+        $share3->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share3);
+
+        // $request = $this->createRequest(['path' => $this->subfolder]);
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $result1 = $ocs->getShares('false', 'false', 'false', $this->subfolder);
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $data1 = $result1->getData();
+        $this->assertCount(1, $data1);
+        $s1 = reset($data1);
+
+        //$request = $this->createRequest(['path' => $this->folder.$this->subfolder]);
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $result2 = $ocs->getShares('false', 'false', 'false', $this->folder . $this->subfolder);
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $data2 = $result2->getData();
+        $this->assertCount(1, $data2);
+        $s2 = reset($data2);
+
+        $this->assertEquals($this->subfolder, $s1['path']);
+        $this->assertEquals($this->folder . $this->subfolder, $s2['path']);
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+        $this->shareManager->deleteShare($share3);
+    }
+
+    /**
+     * test re-re-share of folder if the path gets constructed correctly
+     * @medium
+     */
+    public function testGetShareFromFileReReShares(): void {
+        $node1 = $this->userFolder->get($this->folder . $this->subfolder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $user2Folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
+        $node2 = $user2Folder->get($this->subfolder . $this->filename);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER3)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        $user3Folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER3);
+        $node3 = $user3Folder->get($this->filename);
+        $share3 = $this->shareManager->newShare();
+        $share3->setNode($node3)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER3)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share3 = $this->shareManager->createShare($share3);
+        $share3->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share3);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        // test should return one share within $this->folder
+        $data = $result->getData();
+
+        // we should get exactly one result
+        $this->assertCount(1, $data);
+
+        $this->assertEquals($this->filename, $data[0]['path']);
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+        $this->shareManager->deleteShare($share3);
+    }
+
+    /**
+     * @medium
+     */
+    public function testGetShareFromUnknownId(): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER3);
+        try {
+            $ocs->getShare(0);
+            $this->fail();
+        } catch (OCSNotFoundException $e) {
+            $this->assertEquals('Wrong share ID, share does not exist', $e->getMessage());
+        }
+        $ocs->cleanup();
+    }
+
+    /**
+     * @medium
+     * @depends testCreateShareUserFile
+     * @depends testCreateShareLink
+     */
+    public function testUpdateShare(): void {
+        $password = md5(time());
+
+        $node1 = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19)
+            ->setAttributes($this->shareManager->newShare()->newAttributes());
+
+        $this->assertNotNull($share1->getAttributes());
+        $share1 = $this->shareManager->createShare($share1);
+        $this->assertEquals(19, $share1->getPermissions());
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+        $this->assertEquals(1, $share2->getPermissions());
+
+        // update permissions
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare(
+            $share1->getId(), 1, null, null, null, null, null, null, null,
+            '[{"scope": "app1", "key": "attr1", "value": true}]'
+        );
+        $ocs->cleanup();
+
+        $share1 = $this->shareManager->getShareById('ocinternal:' . $share1->getId());
+        $this->assertEquals(1, $share1->getPermissions());
+        $this->assertEquals(true, $share1->getAttributes()->getAttribute('app1', 'attr1'));
+
+        // update password for link share
+        $this->assertNull($share2->getPassword());
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare($share2->getId(), null, $password);
+        $ocs->cleanup();
+
+        $share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
+        $this->assertNotNull($share2->getPassword());
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare($share2->getId(), null, '');
+        $ocs->cleanup();
+
+        $share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
+        $this->assertNull($share2->getPassword());
+
+        $this->shareManager->deleteShare($share1);
+        $this->shareManager->deleteShare($share2);
+    }
+
+    /**
+     * @medium
+     */
+    public function testUpdateShareUpload(): void {
+        $node1 = $this->userFolder->get($this->folder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share1 = $this->shareManager->createShare($share1);
+
+        // update public upload
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare($share1->getId(), null, null, null, 'true');
+        $ocs->cleanup();
+
+        $share1 = $this->shareManager->getShareById($share1->getFullId());
+        $this->assertEquals(
+            Constants::PERMISSION_READ
+            | Constants::PERMISSION_CREATE
+            | Constants::PERMISSION_UPDATE
+            | Constants::PERMISSION_DELETE
+            | Constants::PERMISSION_SHARE,
+            $share1->getPermissions()
+        );
+
+        // cleanup
+        $this->shareManager->deleteShare($share1);
+    }
+
+    /**
+     * @medium
+     */
+    public function testUpdateShareExpireDate(): void {
+        $node1 = $this->userFolder->get($this->folder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $config = Server::get(IConfig::class);
+
+        // enforce expire date, by default 7 days after the file was shared
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
+
+        $dateWithinRange = new \DateTime();
+        $dateWithinRange->add(new \DateInterval('P6D'));
+
+        $dateOutOfRange = new \DateTime();
+        $dateOutOfRange->add(new \DateInterval('P8D'));
+
+        // update expire date to a valid value
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->updateShare($share1->getId(), null, null, null, null, $dateWithinRange->format('Y-m-d'));
+        $ocs->cleanup();
+
+        $share1 = $this->shareManager->getShareById($share1->getFullId());
+
+        // date should be changed
+        $dateWithinRange->setTime(0, 0, 0);
+        $dateWithinRange->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+        $this->assertEquals($dateWithinRange, $share1->getExpirationDate());
+
+        // update expire date to a value out of range
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->updateShare($share1->getId());
+            $this->fail();
+        } catch (OCSBadRequestException $e) {
+        }
+        $ocs->cleanup();
+
+        $share1 = $this->shareManager->getShareById($share1->getFullId());
+
+        // date shouldn't be changed
+        $this->assertEquals($dateWithinRange, $share1->getExpirationDate());
+
+        // Try to remove expire date
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        try {
+            $ocs->updateShare($share1->getId());
+            $this->fail();
+        } catch (OCSBadRequestException $e) {
+        }
+        $ocs->cleanup();
+
+        $share1 = $this->shareManager->getShareById($share1->getFullId());
+
+
+        // date shouldn't be changed
+        $this->assertEquals($dateWithinRange, $share1->getExpirationDate());
+        // cleanup
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'no');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
+        $this->shareManager->deleteShare($share1);
+    }
+
+    /**
+     * @medium
+     * @depends testCreateShareUserFile
+     */
+    public function testDeleteShare(): void {
+        $node1 = $this->userFolder->get($this->filename);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(19);
+        $share1 = $this->shareManager->createShare($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($share1->getId());
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($share2->getId());
+        $ocs->cleanup();
+
+        $this->assertEmpty($this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER2, IShare::TYPE_USER));
+        $this->assertEmpty($this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER2, IShare::TYPE_LINK));
+    }
+
+    /**
+     * test unshare of a reshared file
+     */
+    public function testDeleteReshare(): void {
+        $node1 = $this->userFolder->get($this->folder);
+        $share1 = $this->shareManager->newShare();
+        $share1->setNode($node1)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
+            ->setSharedWith(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(31);
+        $share1 = $this->shareManager->createShare($share1);
+        $share1->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share1);
+
+        $user2folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
+        $node2 = $user2folder->get($this->folder . '/' . $this->filename);
+        $share2 = $this->shareManager->newShare();
+        $share2->setNode($node2)
+            ->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPermissions(1);
+        $share2 = $this->shareManager->createShare($share2);
+        $share2->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share2);
+
+        // test if we can unshare the link again
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $ocs->deleteShare($share2->getId());
+        $ocs->cleanup();
+
+        $this->shareManager->deleteShare($share1);
+        $this->addToAssertionCount(1);
+    }
+
+    /**
+     * share a folder which contains a share mount point, should be forbidden
+     */
+    public function testShareFolderWithAMountPoint(): void {
+        // user 1 shares a folder with user2
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+        $share->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share);
+
+        // user2 shares a file from the folder as link
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+        $view->mkdir('localDir');
+
+        // move mount point to the folder "localDir"
+        $result = $view->rename($this->folder, 'localDir/' . $this->folder);
+        $this->assertTrue($result !== false);
+
+        // try to share "localDir"
+        $fileInfo2 = $view->getFileInfo('localDir');
+
+        $this->assertTrue($fileInfo2 instanceof FileInfo);
+
+        $pass = true;
+        try {
+            $this->share(
+                IShare::TYPE_USER,
+                'localDir',
+                self::TEST_FILES_SHARING_API_USER2,
+                self::TEST_FILES_SHARING_API_USER3,
+                Constants::PERMISSION_ALL
+            );
+        } catch (\Exception $e) {
+            $pass = false;
+        }
+
+        $this->assertFalse($pass);
+
+        //cleanup
+
+        $result = $view->rename('localDir/' . $this->folder, $this->folder);
+        $this->assertTrue($result !== false);
+        $view->unlink('localDir');
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        $this->shareManager->deleteShare($share);
+    }
+
+    /**
+     * Post init mount points hook for mounting simulated ext storage
+     */
+    public static function initTestMountPointsHook($data) {
+        if ($data['user'] === self::TEST_FILES_SHARING_API_USER1) {
+            Filesystem::mount(self::$tempStorage, [], '/' . self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
+        }
+    }
+
+    /**
+     * Tests mounting a folder that is an external storage mount point.
+     */
+    public function testShareStorageMountPoint(): void {
+        $tempStorage = new Temporary([]);
+        $tempStorage->file_put_contents('test.txt', 'abcdef');
+        $tempStorage->getScanner()->scan('');
+
+        $this->registerMount(self::TEST_FILES_SHARING_API_USER1, $tempStorage, self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
+
+        // logging in will auto-mount the temp storage for user1 as well
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        // user 1 shares the mount point folder with user2
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+        $share->setStatus(IShare::STATUS_ACCEPTED);
+        $this->shareManager->updateShare($share);
+
+        // user2: check that mount point name appears correctly
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+
+        $this->assertTrue($view->file_exists($this->folder));
+        $this->assertTrue($view->file_exists($this->folder . '/test.txt'));
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        $this->shareManager->deleteShare($share);
+
+        \OC_Hook::clear('OC_Filesystem', 'post_initMountPoints');
+        \OC_Hook::clear('\OCA\Files_Sharing\Tests\ApiTest', 'initTestMountPointsHook');
+    }
+
+    public static function datesProvider() {
+        $date = new \DateTime();
+        $date->setTime(0, 0);
+        $date->add(new \DateInterval('P5D'));
+        $date->setTimezone(new \DateTimeZone(date_default_timezone_get()));
+
+        return [
+            [$date->format('Y-m-d H:i:s'), true],
+            ['abc', false],
+            [$date->format('Y-m-d H:i:s') . 'xyz', false],
+        ];
+    }
+
+    /**
+     * Make sure only ISO 8601 dates are accepted
+     *
+     * @group RoutingWeirdness
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('datesProvider')]
+    public function testPublicLinkExpireDate($date, $valid): void {
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+
+        try {
+            $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date);
+            $this->assertTrue($valid);
+        } catch (OCSNotFoundException $e) {
+            $this->assertFalse($valid);
+            $this->assertEquals('Invalid date. Format must be YYYY-MM-DD', $e->getMessage());
+            $ocs->cleanup();
+            return;
+        }
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertTrue(is_string($data['token']));
+        $this->assertEquals(substr($date, 0, 10), substr($data['expiration'], 0, 10));
+
+        // check for correct link
+        $url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+        $this->assertEquals($url, $data['url']);
+
+        $share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
+
+        $this->assertEquals($date, $share->getExpirationDate()->format('Y-m-d H:i:s'));
+
+        $this->shareManager->deleteShare($share);
+    }
+
+    /**
+     * @group RoutingWeirdness
+     */
+    public function testCreatePublicLinkExpireDateValid(): void {
+        $config = Server::get(IConfig::class);
+
+        // enforce expire date, by default 7 days after the file was shared
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
+
+        $date = new \DateTime();
+        $date->add(new \DateInterval('P5D'));
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
+        $ocs->cleanup();
+
+        $data = $result->getData();
+        $this->assertTrue(is_string($data['token']));
+        $this->assertEquals($date->format('Y-m-d 00:00:00'), $data['expiration']);
+
+        // check for correct link
+        $url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+        $this->assertEquals($url, $data['url']);
+
+        $share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
+        $date->setTime(0, 0, 0);
+        $this->assertEquals($date, $share->getExpirationDate());
+
+        $this->shareManager->deleteShare($share);
+
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'no');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
+    }
+
+    public function testCreatePublicLinkExpireDateInvalidFuture(): void {
+        $config = Server::get(IConfig::class);
+
+        // enforce expire date, by default 7 days after the file was shared
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'yes');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'yes');
+
+        $date = new \DateTime();
+        $date->add(new \DateInterval('P8D'));
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+
+        try {
+            $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
+            $this->fail();
+        } catch (OCSException $e) {
+            $this->assertEquals(404, $e->getCode());
+            $this->assertEquals('Cannot set expiration date more than 7 days in the future', $e->getMessage());
+        }
+        $ocs->cleanup();
+
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'no');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
+    }
+
+    public function XtestCreatePublicLinkExpireDateInvalidPast() {
+        $config = Server::get(IConfig::class);
+
+        $date = new \DateTime();
+        $date->sub(new \DateInterval('P8D'));
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+
+        try {
+            $ocs->createShare($this->filename, Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, $date->format('Y-m-d'));
+            $this->fail();
+        } catch (OCSException $e) {
+            $this->assertEquals(404, $e->getCode());
+            $this->assertEquals('Expiration date is in the past', $e->getMessage());
+        }
+        $ocs->cleanup();
+
+        $config->setAppValue('core', 'shareapi_default_expire_date', 'no');
+        $config->setAppValue('core', 'shareapi_enforce_expire_date', 'no');
+    }
+
+    /**
+     * test for no invisible shares
+     * See: https://github.com/owncloud/core/issues/22295
+     */
+    public function testInvisibleSharesUser(): void {
+        // simulate a post request
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_USER, self::TEST_FILES_SHARING_API_USER2);
+        $ocs->cleanup();
+        $data = $result->getData();
 
-		$topId = $data['id'];
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$ocs->acceptShare($topId);
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($topId);
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		$this->assertEmpty($result->getData());
-	}
-
-	/**
-	 * test for no invisible shares
-	 * See: https://github.com/owncloud/core/issues/22295
-	 */
-	public function testInvisibleSharesGroup(): void {
-		// simulate a post request
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
-		$ocs->cleanup();
-		$data = $result->getData();
-
-		$topId = $data['id'];
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$ocs->acceptShare($topId);
-		$ocs->cleanup();
-
-		\OC_Util::tearDownFS();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$ocs->deleteShare($topId);
-		$ocs->cleanup();
-
-		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
-		$result = $ocs->getShares();
-		$ocs->cleanup();
-
-		$this->assertEmpty($result->getData());
-	}
+        $topId = $data['id'];
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $ocs->acceptShare($topId);
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($topId);
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        $this->assertEmpty($result->getData());
+    }
+
+    /**
+     * test for no invisible shares
+     * See: https://github.com/owncloud/core/issues/22295
+     */
+    public function testInvisibleSharesGroup(): void {
+        // simulate a post request
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_GROUP, self::TEST_FILES_SHARING_API_GROUP1);
+        $ocs->cleanup();
+        $data = $result->getData();
+
+        $topId = $data['id'];
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $ocs->acceptShare($topId);
+        $ocs->cleanup();
+
+        \OC_Util::tearDownFS();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
+        $ocs->createShare($this->folder, Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $ocs->deleteShare($topId);
+        $ocs->cleanup();
+
+        $ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
+        $result = $ocs->getShares();
+        $ocs->cleanup();
+
+        $this->assertEmpty($result->getData());
+    }
 }

apps/files_sharing/tests/ApplicationTest.php

Indentation +180 added lines, -180 removed lines

@@ -23,184 +23,184 @@
 use Test\TestCase;
 
 class ApplicationTest extends TestCase {
-	private Application $application;
-
-	/** @var IUserSession */
-	private $userSession;
-
-	/** @var IRootFolder */
-	private $rootFolder;
-
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->application = new Application([]);
-
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-	}
-
-	public function providesDataForCanGet(): array {
-		// normal file (sender) - can download directly
-		$senderFileStorage = $this->createMock(IStorage::class);
-		$senderFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(false);
-		$senderFile = $this->createMock(File::class);
-		$senderFile->method('getStorage')->willReturn($senderFileStorage);
-		$senderUserFolder = $this->createMock(Folder::class);
-		$senderUserFolder->method('get')->willReturn($senderFile);
-
-		$result[] = [ '/bar.txt', $senderUserFolder, true ];
-
-		// shared file (receiver) with attribute secure-view-enabled set false -
-		// can download directly
-		$receiverFileShareAttributes = $this->createMock(IAttributes::class);
-		$receiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(true);
-		$receiverFileShare = $this->createMock(IShare::class);
-		$receiverFileShare->method('getAttributes')->willReturn($receiverFileShareAttributes);
-		$receiverFileStorage = $this->createMock(SharedStorage::class);
-		$receiverFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
-		$receiverFileStorage->method('getShare')->willReturn($receiverFileShare);
-		$receiverFile = $this->createMock(File::class);
-		$receiverFile->method('getStorage')->willReturn($receiverFileStorage);
-		$receiverUserFolder = $this->createMock(Folder::class);
-		$receiverUserFolder->method('get')->willReturn($receiverFile);
-
-		$result[] = [ '/share-bar.txt', $receiverUserFolder, true ];
-
-		// shared file (receiver) with attribute secure-view-enabled set true -
-		// cannot download directly
-		$secureReceiverFileShareAttributes = $this->createMock(IAttributes::class);
-		$secureReceiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(false);
-		$secureReceiverFileShare = $this->createMock(IShare::class);
-		$secureReceiverFileShare->method('getAttributes')->willReturn($secureReceiverFileShareAttributes);
-		$secureReceiverFileStorage = $this->createMock(SharedStorage::class);
-		$secureReceiverFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
-		$secureReceiverFileStorage->method('getShare')->willReturn($secureReceiverFileShare);
-		$secureReceiverFile = $this->createMock(File::class);
-		$secureReceiverFile->method('getStorage')->willReturn($secureReceiverFileStorage);
-		$secureReceiverUserFolder = $this->createMock(Folder::class);
-		$secureReceiverUserFolder->method('get')->willReturn($secureReceiverFile);
-
-		$result[] = [ '/secure-share-bar.txt', $secureReceiverUserFolder, false ];
-
-		return $result;
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanGet')]
-	public function testCheckDirectCanBeDownloaded(string $path, Folder $userFolder, bool $run): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('test');
-		$this->userSession->method('getUser')->willReturn($user);
-		$this->userSession->method('isLoggedIn')->willReturn(true);
-		$this->rootFolder->method('getUserFolder')->willReturn($userFolder);
-
-		// Simulate direct download of file
-		$event = new BeforeDirectFileDownloadEvent($path);
-		$listener = new BeforeDirectFileDownloadListener(
-			$this->userSession,
-			$this->rootFolder
-		);
-		$listener->handle($event);
-
-		$this->assertEquals($run, $event->isSuccessful());
-	}
-
-	public function providesDataForCanZip(): array {
-		// Mock: Normal file/folder storage
-		$nonSharedStorage = $this->createMock(IStorage::class);
-		$nonSharedStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(false);
-
-		// Mock: Secure-view file/folder shared storage
-		$secureReceiverFileShareAttributes = $this->createMock(IAttributes::class);
-		$secureReceiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(false);
-		$secureReceiverFileShare = $this->createMock(IShare::class);
-		$secureReceiverFileShare->method('getAttributes')->willReturn($secureReceiverFileShareAttributes);
-		$secureSharedStorage = $this->createMock(SharedStorage::class);
-		$secureSharedStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
-		$secureSharedStorage->method('getShare')->willReturn($secureReceiverFileShare);
-
-		// 1. can download zipped 2 non-shared files inside non-shared folder
-		// 2. can download zipped non-shared folder
-		$sender1File = $this->createMock(File::class);
-		$sender1File->method('getStorage')->willReturn($nonSharedStorage);
-		$sender1Folder = $this->createMock(Folder::class);
-		$sender1Folder->method('getStorage')->willReturn($nonSharedStorage);
-		$sender1Folder->method('getDirectoryListing')->willReturn([$sender1File, $sender1File]);
-		$sender1RootFolder = $this->createMock(Folder::class);
-		$sender1RootFolder->method('getStorage')->willReturn($nonSharedStorage);
-		$sender1RootFolder->method('getDirectoryListing')->willReturn([$sender1Folder]);
-		$sender1UserFolder = $this->createMock(Folder::class);
-		$sender1UserFolder->method('get')->willReturn($sender1RootFolder);
-
-		$return[] = [ '/folder', ['bar1.txt', 'bar2.txt'], $sender1UserFolder, true ];
-		$return[] = [ '/', ['folder'], $sender1UserFolder, true ];
-
-		// 3. cannot download zipped 1 non-shared file and 1 secure-shared inside non-shared folder
-		$receiver1File = $this->createMock(File::class);
-		$receiver1File->method('getStorage')->willReturn($nonSharedStorage);
-		$receiver1SecureFile = $this->createMock(File::class);
-		$receiver1SecureFile->method('getStorage')->willReturn($secureSharedStorage);
-		$receiver1Folder = $this->createMock(Folder::class);
-		$receiver1Folder->method('getStorage')->willReturn($nonSharedStorage);
-		$receiver1Folder->method('getDirectoryListing')->willReturn([$receiver1File, $receiver1SecureFile]);
-		$receiver1RootFolder = $this->createMock(Folder::class);
-		$receiver1RootFolder->method('getStorage')->willReturn($nonSharedStorage);
-		$receiver1RootFolder->method('getDirectoryListing')->willReturn([$receiver1Folder]);
-		$receiver1UserFolder = $this->createMock(Folder::class);
-		$receiver1UserFolder->method('get')->willReturn($receiver1RootFolder);
-
-		$return[] = [ '/folder', ['secured-bar1.txt', 'bar2.txt'], $receiver1UserFolder, false ];
-
-		// 4. cannot download zipped secure-shared folder
-		$receiver2Folder = $this->createMock(Folder::class);
-		$receiver2Folder->method('getStorage')->willReturn($secureSharedStorage);
-		$receiver2RootFolder = $this->createMock(Folder::class);
-		$receiver2RootFolder->method('getStorage')->willReturn($nonSharedStorage);
-		$receiver2RootFolder->method('getDirectoryListing')->willReturn([$receiver2Folder]);
-		$receiver2UserFolder = $this->createMock(Folder::class);
-		$receiver2UserFolder->method('get')->willReturn($receiver2RootFolder);
-
-		$return[] = [ '/', ['secured-folder'], $receiver2UserFolder, false ];
-
-		return $return;
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanZip')]
-	public function testCheckZipCanBeDownloaded(string $dir, array $files, Folder $userFolder, bool $run): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('test');
-		$this->userSession->method('getUser')->willReturn($user);
-		$this->userSession->method('isLoggedIn')->willReturn(true);
-
-		$this->rootFolder->method('getUserFolder')->with('test')->willReturn($userFolder);
-
-		// Simulate zip download of folder folder
-		$event = new BeforeZipCreatedEvent($dir, $files);
-		$listener = new BeforeZipCreatedListener(
-			$this->userSession,
-			$this->rootFolder
-		);
-		$listener->handle($event);
-
-
-		$this->assertEquals($run, $event->isSuccessful());
-		$this->assertEquals($run, $event->getErrorMessage() === null);
-	}
-
-	public function testCheckFileUserNotFound(): void {
-		$this->userSession->method('isLoggedIn')->willReturn(false);
-
-		// Simulate zip download of folder folder
-		$event = new BeforeZipCreatedEvent('/test', ['test.txt']);
-		$listener = new BeforeZipCreatedListener(
-			$this->userSession,
-			$this->rootFolder
-		);
-		$listener->handle($event);
-
-		// It should run as this would restrict e.g. share links otherwise
-		$this->assertTrue($event->isSuccessful());
-		$this->assertEquals(null, $event->getErrorMessage());
-	}
+    private Application $application;
+
+    /** @var IUserSession */
+    private $userSession;
+
+    /** @var IRootFolder */
+    private $rootFolder;
+
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->application = new Application([]);
+
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+    }
+
+    public function providesDataForCanGet(): array {
+        // normal file (sender) - can download directly
+        $senderFileStorage = $this->createMock(IStorage::class);
+        $senderFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(false);
+        $senderFile = $this->createMock(File::class);
+        $senderFile->method('getStorage')->willReturn($senderFileStorage);
+        $senderUserFolder = $this->createMock(Folder::class);
+        $senderUserFolder->method('get')->willReturn($senderFile);
+
+        $result[] = [ '/bar.txt', $senderUserFolder, true ];
+
+        // shared file (receiver) with attribute secure-view-enabled set false -
+        // can download directly
+        $receiverFileShareAttributes = $this->createMock(IAttributes::class);
+        $receiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(true);
+        $receiverFileShare = $this->createMock(IShare::class);
+        $receiverFileShare->method('getAttributes')->willReturn($receiverFileShareAttributes);
+        $receiverFileStorage = $this->createMock(SharedStorage::class);
+        $receiverFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
+        $receiverFileStorage->method('getShare')->willReturn($receiverFileShare);
+        $receiverFile = $this->createMock(File::class);
+        $receiverFile->method('getStorage')->willReturn($receiverFileStorage);
+        $receiverUserFolder = $this->createMock(Folder::class);
+        $receiverUserFolder->method('get')->willReturn($receiverFile);
+
+        $result[] = [ '/share-bar.txt', $receiverUserFolder, true ];
+
+        // shared file (receiver) with attribute secure-view-enabled set true -
+        // cannot download directly
+        $secureReceiverFileShareAttributes = $this->createMock(IAttributes::class);
+        $secureReceiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(false);
+        $secureReceiverFileShare = $this->createMock(IShare::class);
+        $secureReceiverFileShare->method('getAttributes')->willReturn($secureReceiverFileShareAttributes);
+        $secureReceiverFileStorage = $this->createMock(SharedStorage::class);
+        $secureReceiverFileStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
+        $secureReceiverFileStorage->method('getShare')->willReturn($secureReceiverFileShare);
+        $secureReceiverFile = $this->createMock(File::class);
+        $secureReceiverFile->method('getStorage')->willReturn($secureReceiverFileStorage);
+        $secureReceiverUserFolder = $this->createMock(Folder::class);
+        $secureReceiverUserFolder->method('get')->willReturn($secureReceiverFile);
+
+        $result[] = [ '/secure-share-bar.txt', $secureReceiverUserFolder, false ];
+
+        return $result;
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanGet')]
+    public function testCheckDirectCanBeDownloaded(string $path, Folder $userFolder, bool $run): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('test');
+        $this->userSession->method('getUser')->willReturn($user);
+        $this->userSession->method('isLoggedIn')->willReturn(true);
+        $this->rootFolder->method('getUserFolder')->willReturn($userFolder);
+
+        // Simulate direct download of file
+        $event = new BeforeDirectFileDownloadEvent($path);
+        $listener = new BeforeDirectFileDownloadListener(
+            $this->userSession,
+            $this->rootFolder
+        );
+        $listener->handle($event);
+
+        $this->assertEquals($run, $event->isSuccessful());
+    }
+
+    public function providesDataForCanZip(): array {
+        // Mock: Normal file/folder storage
+        $nonSharedStorage = $this->createMock(IStorage::class);
+        $nonSharedStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(false);
+
+        // Mock: Secure-view file/folder shared storage
+        $secureReceiverFileShareAttributes = $this->createMock(IAttributes::class);
+        $secureReceiverFileShareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(false);
+        $secureReceiverFileShare = $this->createMock(IShare::class);
+        $secureReceiverFileShare->method('getAttributes')->willReturn($secureReceiverFileShareAttributes);
+        $secureSharedStorage = $this->createMock(SharedStorage::class);
+        $secureSharedStorage->method('instanceOfStorage')->with(SharedStorage::class)->willReturn(true);
+        $secureSharedStorage->method('getShare')->willReturn($secureReceiverFileShare);
+
+        // 1. can download zipped 2 non-shared files inside non-shared folder
+        // 2. can download zipped non-shared folder
+        $sender1File = $this->createMock(File::class);
+        $sender1File->method('getStorage')->willReturn($nonSharedStorage);
+        $sender1Folder = $this->createMock(Folder::class);
+        $sender1Folder->method('getStorage')->willReturn($nonSharedStorage);
+        $sender1Folder->method('getDirectoryListing')->willReturn([$sender1File, $sender1File]);
+        $sender1RootFolder = $this->createMock(Folder::class);
+        $sender1RootFolder->method('getStorage')->willReturn($nonSharedStorage);
+        $sender1RootFolder->method('getDirectoryListing')->willReturn([$sender1Folder]);
+        $sender1UserFolder = $this->createMock(Folder::class);
+        $sender1UserFolder->method('get')->willReturn($sender1RootFolder);
+
+        $return[] = [ '/folder', ['bar1.txt', 'bar2.txt'], $sender1UserFolder, true ];
+        $return[] = [ '/', ['folder'], $sender1UserFolder, true ];
+
+        // 3. cannot download zipped 1 non-shared file and 1 secure-shared inside non-shared folder
+        $receiver1File = $this->createMock(File::class);
+        $receiver1File->method('getStorage')->willReturn($nonSharedStorage);
+        $receiver1SecureFile = $this->createMock(File::class);
+        $receiver1SecureFile->method('getStorage')->willReturn($secureSharedStorage);
+        $receiver1Folder = $this->createMock(Folder::class);
+        $receiver1Folder->method('getStorage')->willReturn($nonSharedStorage);
+        $receiver1Folder->method('getDirectoryListing')->willReturn([$receiver1File, $receiver1SecureFile]);
+        $receiver1RootFolder = $this->createMock(Folder::class);
+        $receiver1RootFolder->method('getStorage')->willReturn($nonSharedStorage);
+        $receiver1RootFolder->method('getDirectoryListing')->willReturn([$receiver1Folder]);
+        $receiver1UserFolder = $this->createMock(Folder::class);
+        $receiver1UserFolder->method('get')->willReturn($receiver1RootFolder);
+
+        $return[] = [ '/folder', ['secured-bar1.txt', 'bar2.txt'], $receiver1UserFolder, false ];
+
+        // 4. cannot download zipped secure-shared folder
+        $receiver2Folder = $this->createMock(Folder::class);
+        $receiver2Folder->method('getStorage')->willReturn($secureSharedStorage);
+        $receiver2RootFolder = $this->createMock(Folder::class);
+        $receiver2RootFolder->method('getStorage')->willReturn($nonSharedStorage);
+        $receiver2RootFolder->method('getDirectoryListing')->willReturn([$receiver2Folder]);
+        $receiver2UserFolder = $this->createMock(Folder::class);
+        $receiver2UserFolder->method('get')->willReturn($receiver2RootFolder);
+
+        $return[] = [ '/', ['secured-folder'], $receiver2UserFolder, false ];
+
+        return $return;
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanZip')]
+    public function testCheckZipCanBeDownloaded(string $dir, array $files, Folder $userFolder, bool $run): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('test');
+        $this->userSession->method('getUser')->willReturn($user);
+        $this->userSession->method('isLoggedIn')->willReturn(true);
+
+        $this->rootFolder->method('getUserFolder')->with('test')->willReturn($userFolder);
+
+        // Simulate zip download of folder folder
+        $event = new BeforeZipCreatedEvent($dir, $files);
+        $listener = new BeforeZipCreatedListener(
+            $this->userSession,
+            $this->rootFolder
+        );
+        $listener->handle($event);
+
+
+        $this->assertEquals($run, $event->isSuccessful());
+        $this->assertEquals($run, $event->getErrorMessage() === null);
+    }
+
+    public function testCheckFileUserNotFound(): void {
+        $this->userSession->method('isLoggedIn')->willReturn(false);
+
+        // Simulate zip download of folder folder
+        $event = new BeforeZipCreatedEvent('/test', ['test.txt']);
+        $listener = new BeforeZipCreatedListener(
+            $this->userSession,
+            $this->rootFolder
+        );
+        $listener->handle($event);
+
+        // It should run as this would restrict e.g. share links otherwise
+        $this->assertTrue($event->isSuccessful());
+        $this->assertEquals(null, $event->getErrorMessage());
+    }
 }

apps/files_sharing/tests/MountProviderTest.php

Indentation +354 added lines, -354 removed lines

@@ -30,380 +30,380 @@
  */
 class MountProviderTest extends \Test\TestCase {
 
-	protected MountProvider $provider;
+    protected MountProvider $provider;
 
-	protected IUser&MockObject $user;
-	protected IConfig&MockObject $config;
-	protected IManager&MockObject $shareManager;
-	protected IStorageFactory&MockObject $loader;
-	protected LoggerInterface&MockObject $logger;
+    protected IUser&MockObject $user;
+    protected IConfig&MockObject $config;
+    protected IManager&MockObject $shareManager;
+    protected IStorageFactory&MockObject $loader;
+    protected LoggerInterface&MockObject $logger;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->getMockBuilder(IConfig::class)->getMock();
-		$this->user = $this->getMockBuilder(IUser::class)->getMock();
-		$this->loader = $this->getMockBuilder('OCP\Files\Storage\IStorageFactory')->getMock();
-		$this->shareManager = $this->getMockBuilder(IManager::class)->getMock();
-		$this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
-		$eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$cacheFactory = $this->createMock(ICacheFactory::class);
-		$cacheFactory->method('createLocal')
-			->willReturn(new NullCache());
-		$mountManager = $this->createMock(IMountManager::class);
+        $this->config = $this->getMockBuilder(IConfig::class)->getMock();
+        $this->user = $this->getMockBuilder(IUser::class)->getMock();
+        $this->loader = $this->getMockBuilder('OCP\Files\Storage\IStorageFactory')->getMock();
+        $this->shareManager = $this->getMockBuilder(IManager::class)->getMock();
+        $this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
+        $eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $cacheFactory = $this->createMock(ICacheFactory::class);
+        $cacheFactory->method('createLocal')
+            ->willReturn(new NullCache());
+        $mountManager = $this->createMock(IMountManager::class);
 
-		$this->provider = new MountProvider($this->config, $this->shareManager, $this->logger, $eventDispatcher, $cacheFactory, $mountManager);
-	}
+        $this->provider = new MountProvider($this->config, $this->shareManager, $this->logger, $eventDispatcher, $cacheFactory, $mountManager);
+    }
 
-	private function makeMockShareAttributes($attrs) {
-		if ($attrs === null) {
-			return null;
-		}
+    private function makeMockShareAttributes($attrs) {
+        if ($attrs === null) {
+            return null;
+        }
 
-		$shareAttributes = $this->createMock(IShareAttributes::class);
-		$shareAttributes->method('toArray')->willReturn($attrs);
-		$shareAttributes->method('getAttribute')->willReturnCallback(
-			function ($scope, $key) use ($attrs) {
-				$result = null;
-				foreach ($attrs as $attr) {
-					if ($attr['key'] === $key && $attr['scope'] === $scope) {
-						$result = $attr['value'];
-					}
-				}
-				return $result;
-			}
-		);
-		return $shareAttributes;
-	}
+        $shareAttributes = $this->createMock(IShareAttributes::class);
+        $shareAttributes->method('toArray')->willReturn($attrs);
+        $shareAttributes->method('getAttribute')->willReturnCallback(
+            function ($scope, $key) use ($attrs) {
+                $result = null;
+                foreach ($attrs as $attr) {
+                    if ($attr['key'] === $key && $attr['scope'] === $scope) {
+                        $result = $attr['value'];
+                    }
+                }
+                return $result;
+            }
+        );
+        return $shareAttributes;
+    }
 
-	private function makeMockShare($id, $nodeId, $owner = 'user2', $target = null, $permissions = 31, $attributes = null) {
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())
-			->method('getPermissions')
-			->willReturn($permissions);
-		$share->expects($this->any())
-			->method('getAttributes')
-			->willReturn($this->makeMockShareAttributes($attributes));
-		$share->expects($this->any())
-			->method('getShareOwner')
-			->willReturn($owner);
-		$share->expects($this->any())
-			->method('getTarget')
-			->willReturn($target);
-		$share->expects($this->any())
-			->method('getId')
-			->willReturn($id);
-		$share->expects($this->any())
-			->method('getNodeId')
-			->willReturn($nodeId);
-		$share->expects($this->any())
-			->method('getShareTime')
-			->willReturn(
-				// compute share time based on id, simulating share order
-				new \DateTime('@' . (1469193980 + 1000 * $id))
-			);
-		return $share;
-	}
+    private function makeMockShare($id, $nodeId, $owner = 'user2', $target = null, $permissions = 31, $attributes = null) {
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())
+            ->method('getPermissions')
+            ->willReturn($permissions);
+        $share->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn($this->makeMockShareAttributes($attributes));
+        $share->expects($this->any())
+            ->method('getShareOwner')
+            ->willReturn($owner);
+        $share->expects($this->any())
+            ->method('getTarget')
+            ->willReturn($target);
+        $share->expects($this->any())
+            ->method('getId')
+            ->willReturn($id);
+        $share->expects($this->any())
+            ->method('getNodeId')
+            ->willReturn($nodeId);
+        $share->expects($this->any())
+            ->method('getShareTime')
+            ->willReturn(
+                // compute share time based on id, simulating share order
+                new \DateTime('@' . (1469193980 + 1000 * $id))
+            );
+        return $share;
+    }
 
-	/**
-	 * Tests excluding shares from the current view. This includes:
-	 * - shares that were opted out of (permissions === 0)
-	 * - shares with a group in which the owner is already in
-	 */
-	public function testExcludeShares(): void {
-		$rootFolder = $this->createMock(IRootFolder::class);
-		$userManager = $this->createMock(IUserManager::class);
-		$attr1 = [];
-		$attr2 = [['scope' => 'permission', 'key' => 'download', 'value' => true]];
-		$userShares = [
-			$this->makeMockShare(1, 100, 'user2', '/share2', 0, $attr1),
-			$this->makeMockShare(2, 100, 'user2', '/share2', 31, $attr2),
-		];
-		$groupShares = [
-			$this->makeMockShare(3, 100, 'user2', '/share2', 0, $attr1),
-			$this->makeMockShare(4, 101, 'user2', '/share4', 31, $attr2),
-			$this->makeMockShare(5, 100, 'user1', '/share4', 31, $attr2),
-		];
-		$roomShares = [
-			$this->makeMockShare(6, 102, 'user2', '/share6', 0),
-			$this->makeMockShare(7, 102, 'user1', '/share6', 31),
-			$this->makeMockShare(8, 102, 'user2', '/share6', 31),
-			$this->makeMockShare(9, 102, 'user2', '/share6', 31),
-		];
-		$deckShares = [
-			$this->makeMockShare(10, 103, 'user2', '/share7', 0),
-			$this->makeMockShare(11, 103, 'user1', '/share7', 31),
-			$this->makeMockShare(12, 103, 'user2', '/share7', 31),
-			$this->makeMockShare(13, 103, 'user2', '/share7', 31),
-		];
-		// tests regarding circles and sciencemesh are made in the apps themselves.
-		$circleShares = [];
-		$scienceMeshShares = [];
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('user1');
-		$this->shareManager->expects($this->exactly(6))
-			->method('getSharedWith')
-			->willReturnMap([
-				['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
-				['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
-				['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
-				['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
-				['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
-				['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
-			]);
+    /**
+     * Tests excluding shares from the current view. This includes:
+     * - shares that were opted out of (permissions === 0)
+     * - shares with a group in which the owner is already in
+     */
+    public function testExcludeShares(): void {
+        $rootFolder = $this->createMock(IRootFolder::class);
+        $userManager = $this->createMock(IUserManager::class);
+        $attr1 = [];
+        $attr2 = [['scope' => 'permission', 'key' => 'download', 'value' => true]];
+        $userShares = [
+            $this->makeMockShare(1, 100, 'user2', '/share2', 0, $attr1),
+            $this->makeMockShare(2, 100, 'user2', '/share2', 31, $attr2),
+        ];
+        $groupShares = [
+            $this->makeMockShare(3, 100, 'user2', '/share2', 0, $attr1),
+            $this->makeMockShare(4, 101, 'user2', '/share4', 31, $attr2),
+            $this->makeMockShare(5, 100, 'user1', '/share4', 31, $attr2),
+        ];
+        $roomShares = [
+            $this->makeMockShare(6, 102, 'user2', '/share6', 0),
+            $this->makeMockShare(7, 102, 'user1', '/share6', 31),
+            $this->makeMockShare(8, 102, 'user2', '/share6', 31),
+            $this->makeMockShare(9, 102, 'user2', '/share6', 31),
+        ];
+        $deckShares = [
+            $this->makeMockShare(10, 103, 'user2', '/share7', 0),
+            $this->makeMockShare(11, 103, 'user1', '/share7', 31),
+            $this->makeMockShare(12, 103, 'user2', '/share7', 31),
+            $this->makeMockShare(13, 103, 'user2', '/share7', 31),
+        ];
+        // tests regarding circles and sciencemesh are made in the apps themselves.
+        $circleShares = [];
+        $scienceMeshShares = [];
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user1');
+        $this->shareManager->expects($this->exactly(6))
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
+                ['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
+                ['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
+                ['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
+                ['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
+                ['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
+            ]);
 
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
-				return new Share($rootFolder, $userManager);
-			});
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturnCallback(function () use ($rootFolder, $userManager) {
+                return new Share($rootFolder, $userManager);
+            });
 
-		$mounts = $this->provider->getMountsForUser($this->user, $this->loader);
-		$this->assertCount(4, $mounts);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[0]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[1]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[2]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[3]);
-		/** @var SharedMount[] $mounts */
-		$mountedShare1 = $mounts[0]->getShare();
-		$this->assertEquals('2', $mountedShare1->getId());
-		$this->assertEquals('user2', $mountedShare1->getShareOwner());
-		$this->assertEquals(100, $mountedShare1->getNodeId());
-		$this->assertEquals('/share2', $mountedShare1->getTarget());
-		$this->assertEquals(31, $mountedShare1->getPermissions());
-		$this->assertEquals(true, $mountedShare1->getAttributes()->getAttribute('permission', 'download'));
-		$mountedShare2 = $mounts[1]->getShare();
-		$this->assertEquals('4', $mountedShare2->getId());
-		$this->assertEquals('user2', $mountedShare2->getShareOwner());
-		$this->assertEquals(101, $mountedShare2->getNodeId());
-		$this->assertEquals('/share4', $mountedShare2->getTarget());
-		$this->assertEquals(31, $mountedShare2->getPermissions());
-		$this->assertEquals(true, $mountedShare2->getAttributes()->getAttribute('permission', 'download'));
-		$mountedShare3 = $mounts[2]->getShare();
-		$this->assertEquals('8', $mountedShare3->getId());
-		$this->assertEquals('user2', $mountedShare3->getShareOwner());
-		$this->assertEquals(102, $mountedShare3->getNodeId());
-		$this->assertEquals('/share6', $mountedShare3->getTarget());
-		$this->assertEquals(31, $mountedShare3->getPermissions());
-		$mountedShare4 = $mounts[3]->getShare();
-		$this->assertEquals('12', $mountedShare4->getId());
-		$this->assertEquals('user2', $mountedShare4->getShareOwner());
-		$this->assertEquals(103, $mountedShare4->getNodeId());
-		$this->assertEquals('/share7', $mountedShare4->getTarget());
-		$this->assertEquals(31, $mountedShare4->getPermissions());
-	}
+        $mounts = $this->provider->getMountsForUser($this->user, $this->loader);
+        $this->assertCount(4, $mounts);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[0]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[1]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[2]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[3]);
+        /** @var SharedMount[] $mounts */
+        $mountedShare1 = $mounts[0]->getShare();
+        $this->assertEquals('2', $mountedShare1->getId());
+        $this->assertEquals('user2', $mountedShare1->getShareOwner());
+        $this->assertEquals(100, $mountedShare1->getNodeId());
+        $this->assertEquals('/share2', $mountedShare1->getTarget());
+        $this->assertEquals(31, $mountedShare1->getPermissions());
+        $this->assertEquals(true, $mountedShare1->getAttributes()->getAttribute('permission', 'download'));
+        $mountedShare2 = $mounts[1]->getShare();
+        $this->assertEquals('4', $mountedShare2->getId());
+        $this->assertEquals('user2', $mountedShare2->getShareOwner());
+        $this->assertEquals(101, $mountedShare2->getNodeId());
+        $this->assertEquals('/share4', $mountedShare2->getTarget());
+        $this->assertEquals(31, $mountedShare2->getPermissions());
+        $this->assertEquals(true, $mountedShare2->getAttributes()->getAttribute('permission', 'download'));
+        $mountedShare3 = $mounts[2]->getShare();
+        $this->assertEquals('8', $mountedShare3->getId());
+        $this->assertEquals('user2', $mountedShare3->getShareOwner());
+        $this->assertEquals(102, $mountedShare3->getNodeId());
+        $this->assertEquals('/share6', $mountedShare3->getTarget());
+        $this->assertEquals(31, $mountedShare3->getPermissions());
+        $mountedShare4 = $mounts[3]->getShare();
+        $this->assertEquals('12', $mountedShare4->getId());
+        $this->assertEquals('user2', $mountedShare4->getShareOwner());
+        $this->assertEquals(103, $mountedShare4->getNodeId());
+        $this->assertEquals('/share7', $mountedShare4->getTarget());
+        $this->assertEquals(31, $mountedShare4->getPermissions());
+    }
 
-	public static function mergeSharesDataProvider(): array {
-		// note: the user in the specs here is the shareOwner not recipient
-		// the recipient is always "user1"
-		return [
-			// #0: share as outsider with "group1" and "user1" with same permissions
-			[
-				[
-					[1, 100, 'user2', '/share2', 31, null],
-				],
-				[
-					[2, 100, 'user2', '/share2', 31, null],
-				],
-				[
-					// combined, user share has higher priority
-					['1', 100, 'user2', '/share2', 31, []],
-				],
-			],
-			// #1: share as outsider with "group1" and "user1" with different permissions
-			[
-				[
-					[1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true]]],
-				],
-				[
-					[2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
-				],
-				[
-					// use highest permissions
-					['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
-				],
-			],
-			// #2: share as outsider with "group1" and "group2" with same permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 31, null],
-					[2, 100, 'user2', '/share', 31, []],
-				],
-				[
-					// combined, first group share has higher priority
-					['1', 100, 'user2', '/share', 31, []],
-				],
-			],
-			// #3: share as outsider with "group1" and "group2" with different permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
-					[2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-				],
-				[
-					// use higher permissions (most permissive)
-					['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-				],
-			],
-			// #4: share as insider with "group1"
-			[
-				[
-				],
-				[
-					[1, 100, 'user1', '/share', 31, []],
-				],
-				[
-					// no received share since "user1" is the sharer/owner
-				],
-			],
-			// #5: share as insider with "group1" and "group2" with different permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user1', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-					[2, 100, 'user1', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
-				],
-				[
-					// no received share since "user1" is the sharer/owner
-				],
-			],
-			// #6: share as outside with "group1", recipient opted out
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 0, []],
-				],
-				[
-					// no received share since "user1" opted out
-				],
-			],
-			// #7: share as outsider with "group1" and "user1" where recipient renamed in between
-			[
-				[
-					[1, 100, 'user2', '/share2-renamed', 31, []],
-				],
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'user2', '/share2-renamed', 31, []],
-				],
-			],
-			// #8: share as outsider with "group1" and "user1" where recipient renamed in between
-			[
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					[1, 100, 'user2', '/share2-renamed', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'user2', '/share2-renamed', 31, []],
-				],
-			],
-			// #9: share as outsider with "nullgroup" and "user1" where recipient renamed in between
-			[
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					[1, 100, 'nullgroup', '/share2-renamed', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'nullgroup', '/share2-renamed', 31, []],
-				],
-				true
-			],
-		];
-	}
+    public static function mergeSharesDataProvider(): array {
+        // note: the user in the specs here is the shareOwner not recipient
+        // the recipient is always "user1"
+        return [
+            // #0: share as outsider with "group1" and "user1" with same permissions
+            [
+                [
+                    [1, 100, 'user2', '/share2', 31, null],
+                ],
+                [
+                    [2, 100, 'user2', '/share2', 31, null],
+                ],
+                [
+                    // combined, user share has higher priority
+                    ['1', 100, 'user2', '/share2', 31, []],
+                ],
+            ],
+            // #1: share as outsider with "group1" and "user1" with different permissions
+            [
+                [
+                    [1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true]]],
+                ],
+                [
+                    [2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
+                ],
+                [
+                    // use highest permissions
+                    ['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
+                ],
+            ],
+            // #2: share as outsider with "group1" and "group2" with same permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 31, null],
+                    [2, 100, 'user2', '/share', 31, []],
+                ],
+                [
+                    // combined, first group share has higher priority
+                    ['1', 100, 'user2', '/share', 31, []],
+                ],
+            ],
+            // #3: share as outsider with "group1" and "group2" with different permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
+                    [2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                ],
+                [
+                    // use higher permissions (most permissive)
+                    ['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                ],
+            ],
+            // #4: share as insider with "group1"
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user1', '/share', 31, []],
+                ],
+                [
+                    // no received share since "user1" is the sharer/owner
+                ],
+            ],
+            // #5: share as insider with "group1" and "group2" with different permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user1', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                    [2, 100, 'user1', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
+                ],
+                [
+                    // no received share since "user1" is the sharer/owner
+                ],
+            ],
+            // #6: share as outside with "group1", recipient opted out
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 0, []],
+                ],
+                [
+                    // no received share since "user1" opted out
+                ],
+            ],
+            // #7: share as outsider with "group1" and "user1" where recipient renamed in between
+            [
+                [
+                    [1, 100, 'user2', '/share2-renamed', 31, []],
+                ],
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'user2', '/share2-renamed', 31, []],
+                ],
+            ],
+            // #8: share as outsider with "group1" and "user1" where recipient renamed in between
+            [
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    [1, 100, 'user2', '/share2-renamed', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'user2', '/share2-renamed', 31, []],
+                ],
+            ],
+            // #9: share as outsider with "nullgroup" and "user1" where recipient renamed in between
+            [
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    [1, 100, 'nullgroup', '/share2-renamed', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'nullgroup', '/share2-renamed', 31, []],
+                ],
+                true
+            ],
+        ];
+    }
 
-	/**
-	 * Tests merging shares.
-	 *
-	 * Happens when sharing the same entry to a user through multiple ways,
-	 * like several groups and also direct shares at the same time.
-	 *
-	 *
-	 * @param array $userShares array of user share specs
-	 * @param array $groupShares array of group share specs
-	 * @param array $expectedShares array of expected supershare specs
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('mergeSharesDataProvider')]
-	public function testMergeShares($userShares, $groupShares, $expectedShares, $moveFails = false): void {
-		$rootFolder = $this->createMock(IRootFolder::class);
-		$userManager = $this->createMock(IUserManager::class);
+    /**
+     * Tests merging shares.
+     *
+     * Happens when sharing the same entry to a user through multiple ways,
+     * like several groups and also direct shares at the same time.
+     *
+     *
+     * @param array $userShares array of user share specs
+     * @param array $groupShares array of group share specs
+     * @param array $expectedShares array of expected supershare specs
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('mergeSharesDataProvider')]
+    public function testMergeShares($userShares, $groupShares, $expectedShares, $moveFails = false): void {
+        $rootFolder = $this->createMock(IRootFolder::class);
+        $userManager = $this->createMock(IUserManager::class);
 
-		$userShares = array_map(function ($shareSpec) {
-			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
-		}, $userShares);
-		$groupShares = array_map(function ($shareSpec) {
-			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
-		}, $groupShares);
+        $userShares = array_map(function ($shareSpec) {
+            return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
+        }, $userShares);
+        $groupShares = array_map(function ($shareSpec) {
+            return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
+        }, $groupShares);
 
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('user1');
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user1');
 
-		// tests regarding circles are made in the app itself.
-		$circleShares = [];
-		$roomShares = [];
-		$deckShares = [];
-		$scienceMeshShares = [];
-		$this->shareManager->expects($this->exactly(6))
-			->method('getSharedWith')
-			->willReturnMap([
-				['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
-				['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
-				['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
-				['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
-				['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
-				['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
-			]);
+        // tests regarding circles are made in the app itself.
+        $circleShares = [];
+        $roomShares = [];
+        $deckShares = [];
+        $scienceMeshShares = [];
+        $this->shareManager->expects($this->exactly(6))
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
+                ['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
+                ['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
+                ['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
+                ['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
+                ['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
+            ]);
 
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
-				return new Share($rootFolder, $userManager);
-			});
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturnCallback(function () use ($rootFolder, $userManager) {
+                return new Share($rootFolder, $userManager);
+            });
 
-		if ($moveFails) {
-			$this->shareManager->expects($this->any())
-				->method('moveShare')
-				->willThrowException(new \InvalidArgumentException());
-		}
+        if ($moveFails) {
+            $this->shareManager->expects($this->any())
+                ->method('moveShare')
+                ->willThrowException(new \InvalidArgumentException());
+        }
 
-		$mounts = $this->provider->getMountsForUser($this->user, $this->loader);
+        $mounts = $this->provider->getMountsForUser($this->user, $this->loader);
 
-		$this->assertCount(count($expectedShares), $mounts);
+        $this->assertCount(count($expectedShares), $mounts);
 
-		foreach ($mounts as $index => $mount) {
-			$expectedShare = $expectedShares[$index];
-			$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mount);
+        foreach ($mounts as $index => $mount) {
+            $expectedShare = $expectedShares[$index];
+            $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mount);
 
-			// supershare
-			/** @var SharedMount $mount */
-			$share = $mount->getShare();
+            // supershare
+            /** @var SharedMount $mount */
+            $share = $mount->getShare();
 
-			$this->assertEquals($expectedShare[0], $share->getId());
-			$this->assertEquals($expectedShare[1], $share->getNodeId());
-			$this->assertEquals($expectedShare[2], $share->getShareOwner());
-			$this->assertEquals($expectedShare[3], $share->getTarget());
-			$this->assertEquals($expectedShare[4], $share->getPermissions());
-			if ($expectedShare[5] === null) {
-				$this->assertNull($share->getAttributes());
-			} else {
-				$this->assertEquals($expectedShare[5], $share->getAttributes()->toArray());
-			}
-		}
-	}
+            $this->assertEquals($expectedShare[0], $share->getId());
+            $this->assertEquals($expectedShare[1], $share->getNodeId());
+            $this->assertEquals($expectedShare[2], $share->getShareOwner());
+            $this->assertEquals($expectedShare[3], $share->getTarget());
+            $this->assertEquals($expectedShare[4], $share->getPermissions());
+            if ($expectedShare[5] === null) {
+                $this->assertNull($share->getAttributes());
+            } else {
+                $this->assertEquals($expectedShare[5], $share->getAttributes()->toArray());
+            }
+        }
+    }
 }

Spacing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
 		$shareAttributes = $this->createMock(IShareAttributes::class);
 		$shareAttributes->method('toArray')->willReturn($attrs);
 		$shareAttributes->method('getAttribute')->willReturnCallback(
-			function ($scope, $key) use ($attrs) {
+			function($scope, $key) use ($attrs) {
 				$result = null;
 				foreach ($attrs as $attr) {
 					if ($attr['key'] === $key && $attr['scope'] === $scope) {
@@ -100,7 +100,7 @@ 
 			->method('getShareTime')
 			->willReturn(
 				// compute share time based on id, simulating share order
-				new \DateTime('@' . (1469193980 + 1000 * $id))
+				new \DateTime('@'.(1469193980 + 1000 * $id))
 			);
 		return $share;
 	}
@@ -155,7 +155,7 @@ 
 
 		$this->shareManager->expects($this->any())
 			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
+			->willReturnCallback(function() use ($rootFolder, $userManager) {
 				return new Share($rootFolder, $userManager);
 			});
 
@@ -343,10 +343,10 @@ 
 		$rootFolder = $this->createMock(IRootFolder::class);
 		$userManager = $this->createMock(IUserManager::class);
 
-		$userShares = array_map(function ($shareSpec) {
+		$userShares = array_map(function($shareSpec) {
 			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
 		}, $userShares);
-		$groupShares = array_map(function ($shareSpec) {
+		$groupShares = array_map(function($shareSpec) {
 			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
 		}, $groupShares);
 
@@ -372,7 +372,7 @@ 
 
 		$this->shareManager->expects($this->any())
 			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
+			->willReturnCallback(function() use ($rootFolder, $userManager) {
 				return new Share($rootFolder, $userManager);
 			});
 

apps/files_sharing/tests/Collaboration/ShareRecipientSorterTest.php

Indentation +215 added lines, -215 removed lines

@@ -16,219 +16,219 @@
 use Test\TestCase;
 
 class ShareRecipientSorterTest extends TestCase {
-	/** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $shareManager;
-	/** @var IRootFolder|\PHPUnit\Framework\MockObject\MockObject */
-	protected $rootFolder;
-	/** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
-	protected $userSession;
-	/** @var ShareRecipientSorter */
-	protected $sorter;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-
-		$this->sorter = new ShareRecipientSorter($this->shareManager, $this->rootFolder, $this->userSession);
-	}
-
-	/**
-	 * @param $data
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('sortDataProvider')]
-	public function testSort($data): void {
-		$node = $this->createMock(Node::class);
-
-		/** @var Folder|\PHPUnit\Framework\MockObject\MockObject $folder */
-		$folder = $this->createMock(Folder::class);
-		$this->rootFolder->expects($this->any())
-			->method('getUserFolder')
-			->willReturn($folder);
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('yvonne');
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		if ($data['context']['itemType'] === 'files') {
-			$folder->expects($this->once())
-				->method('getFirstNodeById')
-				->with($data['context']['itemId'])
-				->willReturn($node);
-
-			$this->shareManager->expects($this->once())
-				->method('getAccessList')
-				->with($node)
-				->willReturn($data['accessList']);
-		} else {
-			$folder->expects($this->never())
-				->method('getFirstNodeById');
-			$this->shareManager->expects($this->never())
-				->method('getAccessList');
-		}
-
-		$workArray = $data['input'];
-		$this->sorter->sort($workArray, $data['context']);
-
-		$this->assertEquals($data['expected'], $workArray);
-	}
-
-	public function testSortNoNodes(): void {
-		/** @var Folder|\PHPUnit\Framework\MockObject\MockObject $folder */
-		$folder = $this->createMock(Folder::class);
-		$this->rootFolder->expects($this->any())
-			->method('getUserFolder')
-			->willReturn($folder);
-
-		$folder->expects($this->once())
-			->method('getFirstNodeById')
-			->willReturn(null);
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('yvonne');
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->shareManager->expects($this->never())
-			->method('getAccessList');
-
-		$originalArray = [
-			'users' => [
-				['value' => ['shareWith' => 'alice']],
-				['value' => ['shareWith' => 'bob']],
-			]
-		];
-		$workArray = $originalArray;
-		$this->sorter->sort($workArray, ['itemType' => 'files', 'itemId' => '404']);
-
-		$this->assertEquals($originalArray, $workArray);
-	}
-
-	public static function sortDataProvider() {
-		return [[
-			[
-				#0 – sort properly and otherwise keep existing order
-				'context' => ['itemType' => 'files', 'itemId' => '42'],
-				'accessList' => ['users' => ['celia', 'darius', 'faruk', 'gail'], 'bots' => ['r2-d2']],
-				'input' => [
-					'users' => [
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'elena']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'c-3po']],
-						['value' => ['shareWith' => 'r2-d2']],
-					]
-				],
-				'expected' => [
-					'users' => [
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'elena']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'r2-d2']],
-						['value' => ['shareWith' => 'c-3po']],
-					]
-				],
-			],
-			[
-				#1 – no recipients
-				'context' => ['itemType' => 'files', 'itemId' => '42'],
-				'accessList' => ['users' => false],
-				'input' => [
-					'users' => [
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'elena']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'c-3po']],
-						['value' => ['shareWith' => 'r2-d2']],
-					]
-				],
-				'expected' => [
-					'users' => [
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'elena']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'c-3po']],
-						['value' => ['shareWith' => 'r2-d2']],
-					]
-				],
-			],
-			[
-				#2 – unsupported item  type
-				'context' => ['itemType' => 'announcements', 'itemId' => '42'],
-				'accessList' => null, // not needed
-				'input' => [
-					'users' => [
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'elena']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'c-3po']],
-						['value' => ['shareWith' => 'r2-d2']],
-					]
-				],
-				'expected' => [
-					'users' => [
-						['value' => ['shareWith' => 'alice']],
-						['value' => ['shareWith' => 'bob']],
-						['value' => ['shareWith' => 'celia']],
-						['value' => ['shareWith' => 'darius']],
-						['value' => ['shareWith' => 'elena']],
-						['value' => ['shareWith' => 'faruk']],
-						['value' => ['shareWith' => 'gail']],
-					],
-					'bots' => [
-						['value' => ['shareWith' => 'c-3po']],
-						['value' => ['shareWith' => 'r2-d2']],
-					]
-				],
-			],
-			[
-				#3 – no nothing
-				'context' => ['itemType' => 'files', 'itemId' => '42'],
-				'accessList' => [],
-				'input' => [],
-				'expected' => [],
-			],
-		]];
-	}
+    /** @var IManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $shareManager;
+    /** @var IRootFolder|\PHPUnit\Framework\MockObject\MockObject */
+    protected $rootFolder;
+    /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
+    protected $userSession;
+    /** @var ShareRecipientSorter */
+    protected $sorter;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+
+        $this->sorter = new ShareRecipientSorter($this->shareManager, $this->rootFolder, $this->userSession);
+    }
+
+    /**
+     * @param $data
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('sortDataProvider')]
+    public function testSort($data): void {
+        $node = $this->createMock(Node::class);
+
+        /** @var Folder|\PHPUnit\Framework\MockObject\MockObject $folder */
+        $folder = $this->createMock(Folder::class);
+        $this->rootFolder->expects($this->any())
+            ->method('getUserFolder')
+            ->willReturn($folder);
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('yvonne');
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        if ($data['context']['itemType'] === 'files') {
+            $folder->expects($this->once())
+                ->method('getFirstNodeById')
+                ->with($data['context']['itemId'])
+                ->willReturn($node);
+
+            $this->shareManager->expects($this->once())
+                ->method('getAccessList')
+                ->with($node)
+                ->willReturn($data['accessList']);
+        } else {
+            $folder->expects($this->never())
+                ->method('getFirstNodeById');
+            $this->shareManager->expects($this->never())
+                ->method('getAccessList');
+        }
+
+        $workArray = $data['input'];
+        $this->sorter->sort($workArray, $data['context']);
+
+        $this->assertEquals($data['expected'], $workArray);
+    }
+
+    public function testSortNoNodes(): void {
+        /** @var Folder|\PHPUnit\Framework\MockObject\MockObject $folder */
+        $folder = $this->createMock(Folder::class);
+        $this->rootFolder->expects($this->any())
+            ->method('getUserFolder')
+            ->willReturn($folder);
+
+        $folder->expects($this->once())
+            ->method('getFirstNodeById')
+            ->willReturn(null);
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('yvonne');
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->shareManager->expects($this->never())
+            ->method('getAccessList');
+
+        $originalArray = [
+            'users' => [
+                ['value' => ['shareWith' => 'alice']],
+                ['value' => ['shareWith' => 'bob']],
+            ]
+        ];
+        $workArray = $originalArray;
+        $this->sorter->sort($workArray, ['itemType' => 'files', 'itemId' => '404']);
+
+        $this->assertEquals($originalArray, $workArray);
+    }
+
+    public static function sortDataProvider() {
+        return [[
+            [
+                #0 – sort properly and otherwise keep existing order
+                'context' => ['itemType' => 'files', 'itemId' => '42'],
+                'accessList' => ['users' => ['celia', 'darius', 'faruk', 'gail'], 'bots' => ['r2-d2']],
+                'input' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'elena']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'c-3po']],
+                        ['value' => ['shareWith' => 'r2-d2']],
+                    ]
+                ],
+                'expected' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'elena']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'r2-d2']],
+                        ['value' => ['shareWith' => 'c-3po']],
+                    ]
+                ],
+            ],
+            [
+                #1 – no recipients
+                'context' => ['itemType' => 'files', 'itemId' => '42'],
+                'accessList' => ['users' => false],
+                'input' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'elena']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'c-3po']],
+                        ['value' => ['shareWith' => 'r2-d2']],
+                    ]
+                ],
+                'expected' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'elena']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'c-3po']],
+                        ['value' => ['shareWith' => 'r2-d2']],
+                    ]
+                ],
+            ],
+            [
+                #2 – unsupported item  type
+                'context' => ['itemType' => 'announcements', 'itemId' => '42'],
+                'accessList' => null, // not needed
+                'input' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'elena']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'c-3po']],
+                        ['value' => ['shareWith' => 'r2-d2']],
+                    ]
+                ],
+                'expected' => [
+                    'users' => [
+                        ['value' => ['shareWith' => 'alice']],
+                        ['value' => ['shareWith' => 'bob']],
+                        ['value' => ['shareWith' => 'celia']],
+                        ['value' => ['shareWith' => 'darius']],
+                        ['value' => ['shareWith' => 'elena']],
+                        ['value' => ['shareWith' => 'faruk']],
+                        ['value' => ['shareWith' => 'gail']],
+                    ],
+                    'bots' => [
+                        ['value' => ['shareWith' => 'c-3po']],
+                        ['value' => ['shareWith' => 'r2-d2']],
+                    ]
+                ],
+            ],
+            [
+                #3 – no nothing
+                'context' => ['itemType' => 'files', 'itemId' => '42'],
+                'accessList' => [],
+                'input' => [],
+                'expected' => [],
+            ],
+        ]];
+    }
 }

apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php

Indentation +176 added lines, -176 removed lines

@@ -26,180 +26,180 @@
  */
 class CleanupRemoteStoragesTest extends TestCase {
 
-	protected IDBConnection $connection;
-	protected CleanupRemoteStorages $command;
-	private ICloudIdManager&MockObject $cloudIdManager;
-
-	private $storages = [
-		['id' => 'shared::7b4a322b22f9d0047c38d77d471ce3cf', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e1', 'remote' => 'https://hostname.tld/owncloud1', 'user' => 'user1'],
-		['id' => 'shared::efe3b456112c3780da6155d3a9b9141c', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e2', 'remote' => 'https://hostname.tld/owncloud2', 'user' => 'user2'],
-		['notExistingId' => 'shared::33323d9f4ca416a9e3525b435354bc6f', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e3', 'remote' => 'https://hostname.tld/owncloud3', 'user' => 'user3'],
-		['id' => 'shared::7fe41a07d3f517a923f4b2b599e72cbb', 'files_count' => 2],
-		['id' => 'shared::de4aeb2f378d222b6d2c5fd8f4e42f8e', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e5', 'remote' => 'https://hostname.tld/owncloud5', 'user' => 'user5'],
-		['id' => 'shared::af712293ab5eb9e6a1745a13818b99fe', 'files_count' => 3],
-		['notExistingId' => 'shared::c34568c143cdac7d2f06e0800b5280f9', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e7', 'remote' => 'https://hostname.tld/owncloud7', 'user' => 'user7'],
-	];
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-
-		$storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$storageQuery->insert('storages')
-			->setValue('id', $storageQuery->createParameter('id'));
-
-		$shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$shareExternalQuery->insert('share_external')
-			->setValue('share_token', $shareExternalQuery->createParameter('share_token'))
-			->setValue('remote', $shareExternalQuery->createParameter('remote'))
-			->setValue('name', $shareExternalQuery->createParameter('name'))
-			->setValue('owner', $shareExternalQuery->createParameter('owner'))
-			->setValue('user', $shareExternalQuery->createParameter('user'))
-			->setValue('mountpoint', $shareExternalQuery->createParameter('mountpoint'))
-			->setValue('mountpoint_hash', $shareExternalQuery->createParameter('mountpoint_hash'));
-
-		$filesQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$filesQuery->insert('filecache')
-			->setValue('storage', $filesQuery->createParameter('storage'))
-			->setValue('path', $filesQuery->createParameter('path'))
-			->setValue('path_hash', $filesQuery->createParameter('path_hash'));
-
-		foreach ($this->storages as &$storage) {
-			if (isset($storage['id'])) {
-				$storageQuery->setParameter('id', $storage['id']);
-				$storageQuery->executeStatement();
-				$storage['numeric_id'] = $storageQuery->getLastInsertId();
-			}
-
-			if (isset($storage['share_token'])) {
-				$shareExternalQuery
-					->setParameter('share_token', $storage['share_token'])
-					->setParameter('remote', $storage['remote'])
-					->setParameter('name', 'irrelevant')
-					->setParameter('owner', 'irrelevant')
-					->setParameter('user', $storage['user'])
-					->setParameter('mountpoint', 'irrelevant')
-					->setParameter('mountpoint_hash', 'irrelevant');
-				$shareExternalQuery->executeStatement();
-			}
-
-			if (isset($storage['files_count'])) {
-				for ($i = 0; $i < $storage['files_count']; $i++) {
-					$filesQuery->setParameter('storage', $storage['numeric_id']);
-					$filesQuery->setParameter('path', 'file' . $i);
-					$filesQuery->setParameter('path_hash', md5('file' . $i));
-					$filesQuery->executeStatement();
-				}
-			}
-		}
-
-		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
-
-		$this->command = new CleanupRemoteStorages($this->connection, $this->cloudIdManager);
-	}
-
-	protected function tearDown(): void {
-		$storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$storageQuery->delete('storages')
-			->where($storageQuery->expr()->eq('id', $storageQuery->createParameter('id')));
-
-		$shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$shareExternalQuery->delete('share_external')
-			->where($shareExternalQuery->expr()->eq('share_token', $shareExternalQuery->createParameter('share_token')))
-			->andWhere($shareExternalQuery->expr()->eq('remote', $shareExternalQuery->createParameter('remote')));
-
-		foreach ($this->storages as $storage) {
-			if (isset($storage['id'])) {
-				$storageQuery->setParameter('id', $storage['id']);
-				$storageQuery->executeStatement();
-			}
-
-			if (isset($storage['share_token'])) {
-				$shareExternalQuery->setParameter('share_token', $storage['share_token']);
-				$shareExternalQuery->setParameter('remote', $storage['remote']);
-				$shareExternalQuery->executeStatement();
-			}
-		}
-
-		parent::tearDown();
-	}
-
-	private function doesStorageExist($numericId) {
-		$qb = Server::get(IDBConnection::class)->getQueryBuilder();
-		$qb->select('*')
-			->from('storages')
-			->where($qb->expr()->eq('numeric_id', $qb->createNamedParameter($numericId)));
-
-		$qResult = $qb->executeQuery();
-		$result = $qResult->fetch();
-		$qResult->closeCursor();
-		if (!empty($result)) {
-			return true;
-		}
-
-		$qb = Server::get(IDBConnection::class)->getQueryBuilder();
-		$qb->select('*')
-			->from('filecache')
-			->where($qb->expr()->eq('storage', $qb->createNamedParameter($numericId)));
-
-		$qResult = $qb->executeQuery();
-		$result = $qResult->fetch();
-		$qResult->closeCursor();
-		if (!empty($result)) {
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Test cleanup of orphaned storages
-	 */
-	public function testCleanup(): void {
-		$input = $this->getMockBuilder(InputInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$output = $this->getMockBuilder(OutputInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		// parent folder, `files`, ´test` and `welcome.txt` => 4 elements
-		$outputCalls = [];
-		$output
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $text) use (&$outputCalls): void {
-				$outputCalls[] = $text;
-			});
-
-		$this->cloudIdManager
-			->expects($this->any())
-			->method('getCloudId')
-			->willReturnCallback(function (string $user, string $remote) {
-				$cloudIdMock = $this->createMock(ICloudId::class);
-
-				// The remotes are already sanitized in the original data, so
-				// they can be directly returned.
-				$cloudIdMock
-					->expects($this->any())
-					->method('getRemote')
-					->willReturn($remote);
-
-				return $cloudIdMock;
-			});
-
-		$this->command->execute($input, $output);
-
-		$this->assertTrue($this->doesStorageExist($this->storages[0]['numeric_id']));
-		$this->assertTrue($this->doesStorageExist($this->storages[1]['numeric_id']));
-		$this->assertFalse($this->doesStorageExist($this->storages[3]['numeric_id']));
-		$this->assertTrue($this->doesStorageExist($this->storages[4]['numeric_id']));
-		$this->assertFalse($this->doesStorageExist($this->storages[5]['numeric_id']));
-
-		$this->assertEquals([
-			'5 remote storage(s) need(s) to be checked',
-			'5 remote share(s) exist',
-		], array_slice($outputCalls, 0, 2));
-	}
+    protected IDBConnection $connection;
+    protected CleanupRemoteStorages $command;
+    private ICloudIdManager&MockObject $cloudIdManager;
+
+    private $storages = [
+        ['id' => 'shared::7b4a322b22f9d0047c38d77d471ce3cf', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e1', 'remote' => 'https://hostname.tld/owncloud1', 'user' => 'user1'],
+        ['id' => 'shared::efe3b456112c3780da6155d3a9b9141c', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e2', 'remote' => 'https://hostname.tld/owncloud2', 'user' => 'user2'],
+        ['notExistingId' => 'shared::33323d9f4ca416a9e3525b435354bc6f', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e3', 'remote' => 'https://hostname.tld/owncloud3', 'user' => 'user3'],
+        ['id' => 'shared::7fe41a07d3f517a923f4b2b599e72cbb', 'files_count' => 2],
+        ['id' => 'shared::de4aeb2f378d222b6d2c5fd8f4e42f8e', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e5', 'remote' => 'https://hostname.tld/owncloud5', 'user' => 'user5'],
+        ['id' => 'shared::af712293ab5eb9e6a1745a13818b99fe', 'files_count' => 3],
+        ['notExistingId' => 'shared::c34568c143cdac7d2f06e0800b5280f9', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e7', 'remote' => 'https://hostname.tld/owncloud7', 'user' => 'user7'],
+    ];
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+
+        $storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $storageQuery->insert('storages')
+            ->setValue('id', $storageQuery->createParameter('id'));
+
+        $shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $shareExternalQuery->insert('share_external')
+            ->setValue('share_token', $shareExternalQuery->createParameter('share_token'))
+            ->setValue('remote', $shareExternalQuery->createParameter('remote'))
+            ->setValue('name', $shareExternalQuery->createParameter('name'))
+            ->setValue('owner', $shareExternalQuery->createParameter('owner'))
+            ->setValue('user', $shareExternalQuery->createParameter('user'))
+            ->setValue('mountpoint', $shareExternalQuery->createParameter('mountpoint'))
+            ->setValue('mountpoint_hash', $shareExternalQuery->createParameter('mountpoint_hash'));
+
+        $filesQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $filesQuery->insert('filecache')
+            ->setValue('storage', $filesQuery->createParameter('storage'))
+            ->setValue('path', $filesQuery->createParameter('path'))
+            ->setValue('path_hash', $filesQuery->createParameter('path_hash'));
+
+        foreach ($this->storages as &$storage) {
+            if (isset($storage['id'])) {
+                $storageQuery->setParameter('id', $storage['id']);
+                $storageQuery->executeStatement();
+                $storage['numeric_id'] = $storageQuery->getLastInsertId();
+            }
+
+            if (isset($storage['share_token'])) {
+                $shareExternalQuery
+                    ->setParameter('share_token', $storage['share_token'])
+                    ->setParameter('remote', $storage['remote'])
+                    ->setParameter('name', 'irrelevant')
+                    ->setParameter('owner', 'irrelevant')
+                    ->setParameter('user', $storage['user'])
+                    ->setParameter('mountpoint', 'irrelevant')
+                    ->setParameter('mountpoint_hash', 'irrelevant');
+                $shareExternalQuery->executeStatement();
+            }
+
+            if (isset($storage['files_count'])) {
+                for ($i = 0; $i < $storage['files_count']; $i++) {
+                    $filesQuery->setParameter('storage', $storage['numeric_id']);
+                    $filesQuery->setParameter('path', 'file' . $i);
+                    $filesQuery->setParameter('path_hash', md5('file' . $i));
+                    $filesQuery->executeStatement();
+                }
+            }
+        }
+
+        $this->cloudIdManager = $this->createMock(ICloudIdManager::class);
+
+        $this->command = new CleanupRemoteStorages($this->connection, $this->cloudIdManager);
+    }
+
+    protected function tearDown(): void {
+        $storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $storageQuery->delete('storages')
+            ->where($storageQuery->expr()->eq('id', $storageQuery->createParameter('id')));
+
+        $shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $shareExternalQuery->delete('share_external')
+            ->where($shareExternalQuery->expr()->eq('share_token', $shareExternalQuery->createParameter('share_token')))
+            ->andWhere($shareExternalQuery->expr()->eq('remote', $shareExternalQuery->createParameter('remote')));
+
+        foreach ($this->storages as $storage) {
+            if (isset($storage['id'])) {
+                $storageQuery->setParameter('id', $storage['id']);
+                $storageQuery->executeStatement();
+            }
+
+            if (isset($storage['share_token'])) {
+                $shareExternalQuery->setParameter('share_token', $storage['share_token']);
+                $shareExternalQuery->setParameter('remote', $storage['remote']);
+                $shareExternalQuery->executeStatement();
+            }
+        }
+
+        parent::tearDown();
+    }
+
+    private function doesStorageExist($numericId) {
+        $qb = Server::get(IDBConnection::class)->getQueryBuilder();
+        $qb->select('*')
+            ->from('storages')
+            ->where($qb->expr()->eq('numeric_id', $qb->createNamedParameter($numericId)));
+
+        $qResult = $qb->executeQuery();
+        $result = $qResult->fetch();
+        $qResult->closeCursor();
+        if (!empty($result)) {
+            return true;
+        }
+
+        $qb = Server::get(IDBConnection::class)->getQueryBuilder();
+        $qb->select('*')
+            ->from('filecache')
+            ->where($qb->expr()->eq('storage', $qb->createNamedParameter($numericId)));
+
+        $qResult = $qb->executeQuery();
+        $result = $qResult->fetch();
+        $qResult->closeCursor();
+        if (!empty($result)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Test cleanup of orphaned storages
+     */
+    public function testCleanup(): void {
+        $input = $this->getMockBuilder(InputInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $output = $this->getMockBuilder(OutputInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        // parent folder, `files`, ´test` and `welcome.txt` => 4 elements
+        $outputCalls = [];
+        $output
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $text) use (&$outputCalls): void {
+                $outputCalls[] = $text;
+            });
+
+        $this->cloudIdManager
+            ->expects($this->any())
+            ->method('getCloudId')
+            ->willReturnCallback(function (string $user, string $remote) {
+                $cloudIdMock = $this->createMock(ICloudId::class);
+
+                // The remotes are already sanitized in the original data, so
+                // they can be directly returned.
+                $cloudIdMock
+                    ->expects($this->any())
+                    ->method('getRemote')
+                    ->willReturn($remote);
+
+                return $cloudIdMock;
+            });
+
+        $this->command->execute($input, $output);
+
+        $this->assertTrue($this->doesStorageExist($this->storages[0]['numeric_id']));
+        $this->assertTrue($this->doesStorageExist($this->storages[1]['numeric_id']));
+        $this->assertFalse($this->doesStorageExist($this->storages[3]['numeric_id']));
+        $this->assertTrue($this->doesStorageExist($this->storages[4]['numeric_id']));
+        $this->assertFalse($this->doesStorageExist($this->storages[5]['numeric_id']));
+
+        $this->assertEquals([
+            '5 remote storage(s) need(s) to be checked',
+            '5 remote share(s) exist',
+        ], array_slice($outputCalls, 0, 2));
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -87,8 +87,8 @@ 
 			if (isset($storage['files_count'])) {
 				for ($i = 0; $i < $storage['files_count']; $i++) {
 					$filesQuery->setParameter('storage', $storage['numeric_id']);
-					$filesQuery->setParameter('path', 'file' . $i);
-					$filesQuery->setParameter('path_hash', md5('file' . $i));
+					$filesQuery->setParameter('path', 'file'.$i);
+					$filesQuery->setParameter('path_hash', md5('file'.$i));
 					$filesQuery->executeStatement();
 				}
 			}
@@ -169,14 +169,14 @@ 
 		$output
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $text) use (&$outputCalls): void {
+			->willReturnCallback(function(string $text) use (&$outputCalls): void {
 				$outputCalls[] = $text;
 			});
 
 		$this->cloudIdManager
 			->expects($this->any())
 			->method('getCloudId')
-			->willReturnCallback(function (string $user, string $remote) {
+			->willReturnCallback(function(string $user, string $remote) {
 				$cloudIdMock = $this->createMock(ICloudId::class);
 
 				// The remotes are already sanitized in the original data, so

apps/files_sharing/tests/UpdaterTest.php

Indentation +311 added lines, -311 removed lines

@@ -25,321 +25,321 @@
  * @group DB
  */
 class UpdaterTest extends TestCase {
-	public const TEST_FOLDER_NAME = '/folder_share_updater_test';
+    public const TEST_FOLDER_NAME = '/folder_share_updater_test';
 
-	public static function setUpBeforeClass(): void {
-		parent::setUpBeforeClass();
-		Helper::registerHooks();
-	}
+    public static function setUpBeforeClass(): void {
+        parent::setUpBeforeClass();
+        Helper::registerHooks();
+    }
 
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->folder = self::TEST_FOLDER_NAME;
-
-		$this->filename = '/share-updater-test.txt';
-
-		// save file with content
-		$this->view->file_put_contents($this->filename, $this->data);
-		$this->view->mkdir($this->folder);
-		$this->view->file_put_contents($this->folder . '/' . $this->filename, $this->data);
-	}
-
-	protected function tearDown(): void {
-		if ($this->view) {
-			$this->view->unlink($this->filename);
-			$this->view->deleteAll($this->folder);
-		}
-
-		parent::tearDown();
-	}
-
-	/**
-	 * test deletion of a folder which contains share mount points. Share mount
-	 * points should be unshared before the folder gets deleted so
-	 * that the mount point doesn't end up at the trash bin
-	 */
-	public function testDeleteParentFolder(): void {
-		$appManager = Server::get(IAppManager::class);
-		$status = $appManager->isEnabledForUser('files_trashbin');
-		$appManager->enableApp('files_trashbin');
-
-		// register trashbin hooks
-		$trashbinApp = new Application();
-		$trashbinApp->boot($this->createMock(IBootContext::class));
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->folder = self::TEST_FOLDER_NAME;
+
+        $this->filename = '/share-updater-test.txt';
+
+        // save file with content
+        $this->view->file_put_contents($this->filename, $this->data);
+        $this->view->mkdir($this->folder);
+        $this->view->file_put_contents($this->folder . '/' . $this->filename, $this->data);
+    }
+
+    protected function tearDown(): void {
+        if ($this->view) {
+            $this->view->unlink($this->filename);
+            $this->view->deleteAll($this->folder);
+        }
+
+        parent::tearDown();
+    }
+
+    /**
+     * test deletion of a folder which contains share mount points. Share mount
+     * points should be unshared before the folder gets deleted so
+     * that the mount point doesn't end up at the trash bin
+     */
+    public function testDeleteParentFolder(): void {
+        $appManager = Server::get(IAppManager::class);
+        $status = $appManager->isEnabledForUser('files_trashbin');
+        $appManager->enableApp('files_trashbin');
+
+        // register trashbin hooks
+        $trashbinApp = new Application();
+        $trashbinApp->boot($this->createMock(IBootContext::class));
 
-		$fileinfo = Filesystem::getFileInfo($this->folder);
-		$this->assertTrue($fileinfo instanceof FileInfo);
+        $fileinfo = Filesystem::getFileInfo($this->folder);
+        $this->assertTrue($fileinfo instanceof FileInfo);
 
-		$this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
-
-		// check if user2 can see the shared folder
-		$this->assertTrue($view->file_exists($this->folder));
-
-		$foldersShared = $this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER1, IShare::TYPE_USER);
-		$this->assertCount(1, $foldersShared);
-
-		$view->mkdir('localFolder');
-		$view->file_put_contents('localFolder/localFile.txt', 'local file');
-
-		$view->rename($this->folder, 'localFolder/' . $this->folder);
-
-		// share mount point should now be moved to the subfolder
-		$this->assertFalse($view->file_exists($this->folder));
-		$this->assertTrue($view->file_exists('localFolder/' . $this->folder));
-
-		$view->unlink('localFolder');
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		// shared folder should be unshared
-		$foldersShared = $this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER1, IShare::TYPE_USER);
-		$this->assertCount(0, $foldersShared);
-
-		// trashbin should contain the local file but not the mount point
-		$rootView = new View('/' . self::TEST_FILES_SHARING_API_USER2);
-		$trashContent = \OCA\Files_Trashbin\Helper::getTrashFiles('/', self::TEST_FILES_SHARING_API_USER2);
-		$this->assertSame(1, count($trashContent));
-		$firstElement = reset($trashContent);
-		$timestamp = $firstElement['mtime'];
-		$this->assertTrue($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/localFile.txt'));
-		$this->assertFalse($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/' . $this->folder));
-
-		//cleanup
-		$rootView->deleteAll('files_trashin');
-
-		if ($status === false) {
-			$appManager->disableApp('files_trashbin');
-		}
+        $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+
+        // check if user2 can see the shared folder
+        $this->assertTrue($view->file_exists($this->folder));
+
+        $foldersShared = $this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER1, IShare::TYPE_USER);
+        $this->assertCount(1, $foldersShared);
+
+        $view->mkdir('localFolder');
+        $view->file_put_contents('localFolder/localFile.txt', 'local file');
+
+        $view->rename($this->folder, 'localFolder/' . $this->folder);
+
+        // share mount point should now be moved to the subfolder
+        $this->assertFalse($view->file_exists($this->folder));
+        $this->assertTrue($view->file_exists('localFolder/' . $this->folder));
+
+        $view->unlink('localFolder');
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        // shared folder should be unshared
+        $foldersShared = $this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER1, IShare::TYPE_USER);
+        $this->assertCount(0, $foldersShared);
+
+        // trashbin should contain the local file but not the mount point
+        $rootView = new View('/' . self::TEST_FILES_SHARING_API_USER2);
+        $trashContent = \OCA\Files_Trashbin\Helper::getTrashFiles('/', self::TEST_FILES_SHARING_API_USER2);
+        $this->assertSame(1, count($trashContent));
+        $firstElement = reset($trashContent);
+        $timestamp = $firstElement['mtime'];
+        $this->assertTrue($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/localFile.txt'));
+        $this->assertFalse($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/' . $this->folder));
+
+        //cleanup
+        $rootView->deleteAll('files_trashin');
+
+        if ($status === false) {
+            $appManager->disableApp('files_trashbin');
+        }
 
-		Filesystem::getLoader()->removeStorageWrapper('oc_trashbin');
-	}
+        Filesystem::getLoader()->removeStorageWrapper('oc_trashbin');
+    }
 
-	public static function shareFolderProvider() {
-		return [
-			['/'],
-			['/my_shares'],
-		];
-	}
-
-	/**
-	 * if a file gets shared the etag for the recipients root should change
-	 *
-	 *
-	 * @param string $shareFolder share folder to use
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('shareFolderProvider')]
-	public function testShareFile($shareFolder): void {
-		$config = Server::get(IConfig::class);
-		$oldShareFolder = $config->getSystemValue('share_folder');
-		$config->setSystemValue('share_folder', $shareFolder);
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$beforeShareRoot = Filesystem::getFileInfo('');
-		$etagBeforeShareRoot = $beforeShareRoot->getEtag();
-
-		Filesystem::mkdir($shareFolder);
-
-		$beforeShareDir = Filesystem::getFileInfo($shareFolder);
-		$etagBeforeShareDir = $beforeShareDir->getEtag();
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$afterShareRoot = Filesystem::getFileInfo('');
-		$etagAfterShareRoot = $afterShareRoot->getEtag();
-
-		$afterShareDir = Filesystem::getFileInfo($shareFolder);
-		$etagAfterShareDir = $afterShareDir->getEtag();
-
-		$this->assertTrue(is_string($etagBeforeShareRoot));
-		$this->assertTrue(is_string($etagBeforeShareDir));
-		$this->assertTrue(is_string($etagAfterShareRoot));
-		$this->assertTrue(is_string($etagAfterShareDir));
-		$this->assertTrue($etagBeforeShareRoot !== $etagAfterShareRoot);
-		$this->assertTrue($etagBeforeShareDir !== $etagAfterShareDir);
-
-		// cleanup
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->shareManager->deleteShare($share);
-
-		$config->setSystemValue('share_folder', $oldShareFolder);
-	}
-
-	/**
-	 * if a folder gets renamed all children mount points should be renamed too
-	 */
-	public function testRename(): void {
-		$fileinfo = Filesystem::getFileInfo($this->folder);
-
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		// make sure that the shared folder exists
-		$this->assertTrue(Filesystem::file_exists($this->folder));
-
-		Filesystem::mkdir('oldTarget');
-		Filesystem::mkdir('oldTarget/subfolder');
-		Filesystem::mkdir('newTarget');
-
-		Filesystem::rename($this->folder, 'oldTarget/subfolder/' . $this->folder);
-
-		// re-login to make sure that the new mount points are initialized
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		Filesystem::rename('/oldTarget', '/newTarget/oldTarget');
-
-		// re-login to make sure that the new mount points are initialized
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$this->assertTrue(Filesystem::file_exists('/newTarget/oldTarget/subfolder/' . $this->folder));
-
-		// cleanup
-		$this->shareManager->deleteShare($share);
-	}
-
-	/**
-	 * If a folder gets moved into shared folder, children shares should have their uid_owner and permissions adjusted
-	 * user1
-	 * 	|-folder1 --> shared with user2
-	 * user2
-	 * 	|-folder2 --> shared with user3 and moved into folder1
-	 * 	  |-subfolder1 --> shared with user3
-	 * 	  |-file1.txt --> shared with user3
-	 * 	  |-subfolder2
-	 * 	    |-file2.txt --> shared with user3
-	 */
-	public function testMovedIntoShareChangeOwner(): void {
-		$this->markTestSkipped('Skipped because this is failing with S3 as primary as file id are change when moved.');
-
-		// user1 creates folder1
-		$viewUser1 = new View('/' . self::TEST_FILES_SHARING_API_USER1 . '/files');
-		$folder1 = 'folder1';
-		$viewUser1->mkdir($folder1);
-
-		// user1 shares folder1 to user2
-		$folder1Share = $this->share(
-			IShare::TYPE_USER,
-			$folder1,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
-		);
-
-		$this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$viewUser2 = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
-		// Create user2 files
-		$folder2 = 'folder2';
-		$viewUser2->mkdir($folder2);
-		$file1 = 'folder2/file1.txt';
-		$viewUser2->touch($file1);
-		$subfolder1 = 'folder2/subfolder1';
-		$viewUser2->mkdir($subfolder1);
-		$subfolder2 = 'folder2/subfolder2';
-		$viewUser2->mkdir($subfolder2);
-		$file2 = 'folder2/subfolder2/file2.txt';
-		$viewUser2->touch($file2);
-
-		// user2 shares folder2 to user3
-		$folder2Share = $this->share(
-			IShare::TYPE_USER,
-			$folder2,
-			self::TEST_FILES_SHARING_API_USER2,
-			self::TEST_FILES_SHARING_API_USER3,
-			Constants::PERMISSION_ALL
-		);
-		// user2 shares folder2/file1 to user3
-		$file1Share = $this->share(
-			IShare::TYPE_USER,
-			$file1,
-			self::TEST_FILES_SHARING_API_USER2,
-			self::TEST_FILES_SHARING_API_USER3,
-			Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
-		);
-		// user2 shares subfolder1 to user3
-		$subfolder1Share = $this->share(
-			IShare::TYPE_USER,
-			$subfolder1,
-			self::TEST_FILES_SHARING_API_USER2,
-			self::TEST_FILES_SHARING_API_USER3,
-			Constants::PERMISSION_ALL
-		);
-		// user2 shares subfolder2/file2.txt to user3
-		$file2Share = $this->share(
-			IShare::TYPE_USER,
-			$file2,
-			self::TEST_FILES_SHARING_API_USER2,
-			self::TEST_FILES_SHARING_API_USER3,
-			Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
-		);
-
-		// user2 moves folder2 into folder1
-		$viewUser2->rename($folder2, $folder1 . '/' . $folder2);
-		$folder2Share = $this->shareManager->getShareById($folder2Share->getFullId());
-		$file1Share = $this->shareManager->getShareById($file1Share->getFullId());
-		$subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId());
-		$file2Share = $this->shareManager->getShareById($file2Share->getFullId());
-
-		// Expect uid_owner of both shares to be user1
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $folder2Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file1Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $subfolder1Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file2Share->getShareOwner());
-		// Expect permissions to be limited by the permissions of the destination share
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $folder2Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file1Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file2Share->getPermissions());
-
-		// user2 moves folder2 out of folder1
-		$viewUser2->rename($folder1 . '/' . $folder2, $folder2);
-		$folder2Share = $this->shareManager->getShareById($folder2Share->getFullId());
-		$file1Share = $this->shareManager->getShareById($file1Share->getFullId());
-		$subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId());
-		$file2Share = $this->shareManager->getShareById($file2Share->getFullId());
-
-		// Expect uid_owner of both shares to be user2
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $folder2Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file1Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $subfolder1Share->getShareOwner());
-		$this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file2Share->getShareOwner());
-		// Expect permissions to not change
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $folder2Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file1Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions());
-		$this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file2Share->getPermissions());
-
-		// cleanup
-		$this->shareManager->deleteShare($folder1Share);
-		$this->shareManager->deleteShare($folder2Share);
-		$this->shareManager->deleteShare($file1Share);
-		$this->shareManager->deleteShare($subfolder1Share);
-		$this->shareManager->deleteShare($file2Share);
-	}
+    public static function shareFolderProvider() {
+        return [
+            ['/'],
+            ['/my_shares'],
+        ];
+    }
+
+    /**
+     * if a file gets shared the etag for the recipients root should change
+     *
+     *
+     * @param string $shareFolder share folder to use
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('shareFolderProvider')]
+    public function testShareFile($shareFolder): void {
+        $config = Server::get(IConfig::class);
+        $oldShareFolder = $config->getSystemValue('share_folder');
+        $config->setSystemValue('share_folder', $shareFolder);
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $beforeShareRoot = Filesystem::getFileInfo('');
+        $etagBeforeShareRoot = $beforeShareRoot->getEtag();
+
+        Filesystem::mkdir($shareFolder);
+
+        $beforeShareDir = Filesystem::getFileInfo($shareFolder);
+        $etagBeforeShareDir = $beforeShareDir->getEtag();
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $afterShareRoot = Filesystem::getFileInfo('');
+        $etagAfterShareRoot = $afterShareRoot->getEtag();
+
+        $afterShareDir = Filesystem::getFileInfo($shareFolder);
+        $etagAfterShareDir = $afterShareDir->getEtag();
+
+        $this->assertTrue(is_string($etagBeforeShareRoot));
+        $this->assertTrue(is_string($etagBeforeShareDir));
+        $this->assertTrue(is_string($etagAfterShareRoot));
+        $this->assertTrue(is_string($etagAfterShareDir));
+        $this->assertTrue($etagBeforeShareRoot !== $etagAfterShareRoot);
+        $this->assertTrue($etagBeforeShareDir !== $etagAfterShareDir);
+
+        // cleanup
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->shareManager->deleteShare($share);
+
+        $config->setSystemValue('share_folder', $oldShareFolder);
+    }
+
+    /**
+     * if a folder gets renamed all children mount points should be renamed too
+     */
+    public function testRename(): void {
+        $fileinfo = Filesystem::getFileInfo($this->folder);
+
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        // make sure that the shared folder exists
+        $this->assertTrue(Filesystem::file_exists($this->folder));
+
+        Filesystem::mkdir('oldTarget');
+        Filesystem::mkdir('oldTarget/subfolder');
+        Filesystem::mkdir('newTarget');
+
+        Filesystem::rename($this->folder, 'oldTarget/subfolder/' . $this->folder);
+
+        // re-login to make sure that the new mount points are initialized
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        Filesystem::rename('/oldTarget', '/newTarget/oldTarget');
+
+        // re-login to make sure that the new mount points are initialized
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $this->assertTrue(Filesystem::file_exists('/newTarget/oldTarget/subfolder/' . $this->folder));
+
+        // cleanup
+        $this->shareManager->deleteShare($share);
+    }
+
+    /**
+     * If a folder gets moved into shared folder, children shares should have their uid_owner and permissions adjusted
+     * user1
+     * 	|-folder1 --> shared with user2
+     * user2
+     * 	|-folder2 --> shared with user3 and moved into folder1
+     * 	  |-subfolder1 --> shared with user3
+     * 	  |-file1.txt --> shared with user3
+     * 	  |-subfolder2
+     * 	    |-file2.txt --> shared with user3
+     */
+    public function testMovedIntoShareChangeOwner(): void {
+        $this->markTestSkipped('Skipped because this is failing with S3 as primary as file id are change when moved.');
+
+        // user1 creates folder1
+        $viewUser1 = new View('/' . self::TEST_FILES_SHARING_API_USER1 . '/files');
+        $folder1 = 'folder1';
+        $viewUser1->mkdir($folder1);
+
+        // user1 shares folder1 to user2
+        $folder1Share = $this->share(
+            IShare::TYPE_USER,
+            $folder1,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
+        );
+
+        $this->loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $viewUser2 = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+        // Create user2 files
+        $folder2 = 'folder2';
+        $viewUser2->mkdir($folder2);
+        $file1 = 'folder2/file1.txt';
+        $viewUser2->touch($file1);
+        $subfolder1 = 'folder2/subfolder1';
+        $viewUser2->mkdir($subfolder1);
+        $subfolder2 = 'folder2/subfolder2';
+        $viewUser2->mkdir($subfolder2);
+        $file2 = 'folder2/subfolder2/file2.txt';
+        $viewUser2->touch($file2);
+
+        // user2 shares folder2 to user3
+        $folder2Share = $this->share(
+            IShare::TYPE_USER,
+            $folder2,
+            self::TEST_FILES_SHARING_API_USER2,
+            self::TEST_FILES_SHARING_API_USER3,
+            Constants::PERMISSION_ALL
+        );
+        // user2 shares folder2/file1 to user3
+        $file1Share = $this->share(
+            IShare::TYPE_USER,
+            $file1,
+            self::TEST_FILES_SHARING_API_USER2,
+            self::TEST_FILES_SHARING_API_USER3,
+            Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
+        );
+        // user2 shares subfolder1 to user3
+        $subfolder1Share = $this->share(
+            IShare::TYPE_USER,
+            $subfolder1,
+            self::TEST_FILES_SHARING_API_USER2,
+            self::TEST_FILES_SHARING_API_USER3,
+            Constants::PERMISSION_ALL
+        );
+        // user2 shares subfolder2/file2.txt to user3
+        $file2Share = $this->share(
+            IShare::TYPE_USER,
+            $file2,
+            self::TEST_FILES_SHARING_API_USER2,
+            self::TEST_FILES_SHARING_API_USER3,
+            Constants::PERMISSION_READ | Constants::PERMISSION_SHARE
+        );
+
+        // user2 moves folder2 into folder1
+        $viewUser2->rename($folder2, $folder1 . '/' . $folder2);
+        $folder2Share = $this->shareManager->getShareById($folder2Share->getFullId());
+        $file1Share = $this->shareManager->getShareById($file1Share->getFullId());
+        $subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId());
+        $file2Share = $this->shareManager->getShareById($file2Share->getFullId());
+
+        // Expect uid_owner of both shares to be user1
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $folder2Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file1Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $subfolder1Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file2Share->getShareOwner());
+        // Expect permissions to be limited by the permissions of the destination share
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $folder2Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file1Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file2Share->getPermissions());
+
+        // user2 moves folder2 out of folder1
+        $viewUser2->rename($folder1 . '/' . $folder2, $folder2);
+        $folder2Share = $this->shareManager->getShareById($folder2Share->getFullId());
+        $file1Share = $this->shareManager->getShareById($file1Share->getFullId());
+        $subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId());
+        $file2Share = $this->shareManager->getShareById($file2Share->getFullId());
+
+        // Expect uid_owner of both shares to be user2
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $folder2Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file1Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $subfolder1Share->getShareOwner());
+        $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file2Share->getShareOwner());
+        // Expect permissions to not change
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $folder2Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file1Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions());
+        $this->assertEquals(Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, $file2Share->getPermissions());
+
+        // cleanup
+        $this->shareManager->deleteShare($folder1Share);
+        $this->shareManager->deleteShare($folder2Share);
+        $this->shareManager->deleteShare($file1Share);
+        $this->shareManager->deleteShare($subfolder1Share);
+        $this->shareManager->deleteShare($file2Share);
+    }
 }