nextcloud / server

apps/user_ldap/tests/LDAPTest.php

Indentation +48 added lines, -48 removed lines

@@ -12,61 +12,61 @@
 use Test\TestCase;
 
 class LDAPTest extends TestCase {
-	private LDAP&MockObject $ldap;
+    private LDAP&MockObject $ldap;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->ldap = $this->getMockBuilder(LDAP::class)
-			->onlyMethods(['invokeLDAPMethod'])
-			->getMock();
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->ldap = $this->getMockBuilder(LDAP::class)
+            ->onlyMethods(['invokeLDAPMethod'])
+            ->getMock();
+    }
 
-	public static function errorProvider(): array {
-		return [
-			[
-				'ldap_search(): Partial search results returned: Sizelimit exceeded at /srv/http/nextcloud/master/apps/user_ldap/lib/LDAP.php#292',
-				false
-			],
-			[
-				'Some other error', true
-			]
-		];
-	}
+    public static function errorProvider(): array {
+        return [
+            [
+                'ldap_search(): Partial search results returned: Sizelimit exceeded at /srv/http/nextcloud/master/apps/user_ldap/lib/LDAP.php#292',
+                false
+            ],
+            [
+                'Some other error', true
+            ]
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('errorProvider')]
-	public function testSearchWithErrorHandler(string $errorMessage, bool $passThrough): void {
-		$wasErrorHandlerCalled = false;
-		$errorHandler = function ($number, $message, $file, $line) use (&$wasErrorHandlerCalled): void {
-			$wasErrorHandlerCalled = true;
-		};
+    #[\PHPUnit\Framework\Attributes\DataProvider('errorProvider')]
+    public function testSearchWithErrorHandler(string $errorMessage, bool $passThrough): void {
+        $wasErrorHandlerCalled = false;
+        $errorHandler = function ($number, $message, $file, $line) use (&$wasErrorHandlerCalled): void {
+            $wasErrorHandlerCalled = true;
+        };
 
-		set_error_handler($errorHandler);
+        set_error_handler($errorHandler);
 
-		$this->ldap
-			->expects($this->once())
-			->method('invokeLDAPMethod')
-			->with('search', $this->anything(), $this->anything(), $this->anything(), $this->anything(), $this->anything())
-			->willReturnCallback(function () use ($errorMessage): void {
-				trigger_error($errorMessage);
-			});
+        $this->ldap
+            ->expects($this->once())
+            ->method('invokeLDAPMethod')
+            ->with('search', $this->anything(), $this->anything(), $this->anything(), $this->anything(), $this->anything())
+            ->willReturnCallback(function () use ($errorMessage): void {
+                trigger_error($errorMessage);
+            });
 
-		$fakeResource = ldap_connect();
-		$this->ldap->search($fakeResource, 'base', 'filter', []);
-		$this->assertSame($wasErrorHandlerCalled, $passThrough);
+        $fakeResource = ldap_connect();
+        $this->ldap->search($fakeResource, 'base', 'filter', []);
+        $this->assertSame($wasErrorHandlerCalled, $passThrough);
 
-		restore_error_handler();
-	}
+        restore_error_handler();
+    }
 
-	public function testModReplace(): void {
-		$link = $this->createMock(LDAP::class);
-		$userDN = 'CN=user';
-		$password = 'MyPassword';
-		$this->ldap
-			->expects($this->once())
-			->method('invokeLDAPMethod')
-			->with('mod_replace', $link, $userDN, ['userPassword' => $password])
-			->willReturn(true);
+    public function testModReplace(): void {
+        $link = $this->createMock(LDAP::class);
+        $userDN = 'CN=user';
+        $password = 'MyPassword';
+        $this->ldap
+            ->expects($this->once())
+            ->method('invokeLDAPMethod')
+            ->with('mod_replace', $link, $userDN, ['userPassword' => $password])
+            ->willReturn(true);
 
-		$this->assertTrue($this->ldap->modReplace($link, $userDN, $password));
-	}
+        $this->assertTrue($this->ldap->modReplace($link, $userDN, $password));
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('errorProvider')]
 	public function testSearchWithErrorHandler(string $errorMessage, bool $passThrough): void {
 		$wasErrorHandlerCalled = false;
-		$errorHandler = function ($number, $message, $file, $line) use (&$wasErrorHandlerCalled): void {
+		$errorHandler = function($number, $message, $file, $line) use (&$wasErrorHandlerCalled): void {
 			$wasErrorHandlerCalled = true;
 		};
 
@@ -46,7 +46,7 @@ 
 			->expects($this->once())
 			->method('invokeLDAPMethod')
 			->with('search', $this->anything(), $this->anything(), $this->anything(), $this->anything(), $this->anything())
-			->willReturnCallback(function () use ($errorMessage): void {
+			->willReturnCallback(function() use ($errorMessage): void {
 				trigger_error($errorMessage);
 			});
 

apps/user_ldap/tests/User/ManagerTest.php

Indentation +171 added lines, -171 removed lines

@@ -31,175 +31,175 @@
  * @package OCA\User_LDAP\Tests\User
  */
 class ManagerTest extends \Test\TestCase {
-	protected Access&MockObject $access;
-	protected IConfig&MockObject $config;
-	protected LoggerInterface&MockObject $logger;
-	protected IAvatarManager&MockObject $avatarManager;
-	protected Image&MockObject $image;
-	protected IDBConnection&MockObject $dbc;
-	protected IUserManager&MockObject $ncUserManager;
-	protected INotificationManager&MockObject $notificationManager;
-	protected ILDAPWrapper&MockObject $ldapWrapper;
-	protected Connection $connection;
-	protected IManager&MockObject $shareManager;
-	protected Manager $manager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->access = $this->createMock(Access::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->avatarManager = $this->createMock(IAvatarManager::class);
-		$this->image = $this->createMock(Image::class);
-		$this->ncUserManager = $this->createMock(IUserManager::class);
-		$this->notificationManager = $this->createMock(INotificationManager::class);
-		$this->ldapWrapper = $this->createMock(ILDAPWrapper::class);
-		$this->shareManager = $this->createMock(IManager::class);
-
-		$this->connection = new Connection($this->ldapWrapper, '', null);
-
-		$this->access->expects($this->any())
-			->method('getConnection')
-			->willReturn($this->connection);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->manager = new Manager(
-			$this->config,
-			$this->logger,
-			$this->avatarManager,
-			$this->image,
-			$this->ncUserManager,
-			$this->notificationManager,
-			$this->shareManager
-		);
-
-		$this->manager->setLdapAccess($this->access);
-	}
-
-	public static function dnProvider(): array {
-		return [
-			['cn=foo,dc=foobar,dc=bar'],
-			['uid=foo,o=foobar,c=bar'],
-			['ab=cde,f=ghei,mno=pq'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dnProvider')]
-	public function testGetByDNExisting(string $inputDN): void {
-		$uid = '563418fc-423b-1033-8d1c-ad5f418ee02e';
-
-		$this->access->expects($this->once())
-			->method('stringResemblesDN')
-			->with($this->equalTo($inputDN))
-			->willReturn(true);
-		$this->access->expects($this->once())
-			->method('dn2username')
-			->with($this->equalTo($inputDN))
-			->willReturn($uid);
-		$this->access->expects($this->never())
-			->method('username2dn');
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->manager->get($inputDN);
-
-		// Now we fetch the user again. If this leads to a failing test,
-		// runtime caching the manager is broken.
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$user = $this->manager->get($inputDN);
-
-		$this->assertInstanceOf(User::class, $user);
-	}
-
-	public function testGetByDNNotExisting(): void {
-		$inputDN = 'cn=gone,dc=foobar,dc=bar';
-
-		$this->access->expects($this->once())
-			->method('stringResemblesDN')
-			->with($this->equalTo($inputDN))
-			->willReturn(true);
-		$this->access->expects($this->once())
-			->method('dn2username')
-			->with($this->equalTo($inputDN))
-			->willReturn(false);
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->with($this->equalTo($inputDN))
-			->willReturn(false);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$user = $this->manager->get($inputDN);
-
-		$this->assertNull($user);
-	}
-
-	public function testGetByUidExisting(): void {
-		$dn = 'cn=foo,dc=foobar,dc=bar';
-		$uid = '563418fc-423b-1033-8d1c-ad5f418ee02e';
-
-		$this->access->expects($this->never())
-			->method('dn2username');
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->with($this->equalTo($uid))
-			->willReturn($dn);
-		$this->access->expects($this->once())
-			->method('stringResemblesDN')
-			->with($this->equalTo($uid))
-			->willReturn(false);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->manager->get($uid);
-
-		// Now we fetch the user again. If this leads to a failing test,
-		// runtime caching the manager is broken.
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$user = $this->manager->get($uid);
-
-		$this->assertInstanceOf(User::class, $user);
-	}
-
-	public function testGetByUidNotExisting(): void {
-		$uid = 'gone';
-
-		$this->access->expects($this->never())
-			->method('dn2username');
-		$this->access->expects($this->exactly(1))
-			->method('username2dn')
-			->with($this->equalTo($uid))
-			->willReturn(false);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$user = $this->manager->get($uid);
-
-		$this->assertNull($user);
-	}
-
-	public static function attributeRequestProvider(): array {
-		return [
-			[false],
-			[true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attributeRequestProvider')]
-	public function testGetAttributes($minimal): void {
-		$this->connection->setConfiguration([
-			'ldapEmailAttribute' => 'MAIL',
-			'ldapUserAvatarRule' => 'default',
-			'ldapQuotaAttribute' => '',
-			'ldapUserDisplayName2' => 'Mail',
-		]);
-
-		$attributes = $this->manager->getAttributes($minimal);
-
-		$this->assertContains('dn', $attributes);
-		$this->assertContains(strtolower($this->access->getConnection()->ldapEmailAttribute), $attributes);
-		$this->assertNotContains($this->access->getConnection()->ldapEmailAttribute, $attributes); #cases check
-		$this->assertNotContains('', $attributes);
-		$this->assertSame(!$minimal, in_array('jpegphoto', $attributes));
-		$this->assertSame(!$minimal, in_array('thumbnailphoto', $attributes));
-		$valueCounts = array_count_values($attributes);
-		$this->assertSame(1, $valueCounts['mail']);
-	}
+    protected Access&MockObject $access;
+    protected IConfig&MockObject $config;
+    protected LoggerInterface&MockObject $logger;
+    protected IAvatarManager&MockObject $avatarManager;
+    protected Image&MockObject $image;
+    protected IDBConnection&MockObject $dbc;
+    protected IUserManager&MockObject $ncUserManager;
+    protected INotificationManager&MockObject $notificationManager;
+    protected ILDAPWrapper&MockObject $ldapWrapper;
+    protected Connection $connection;
+    protected IManager&MockObject $shareManager;
+    protected Manager $manager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->access = $this->createMock(Access::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->avatarManager = $this->createMock(IAvatarManager::class);
+        $this->image = $this->createMock(Image::class);
+        $this->ncUserManager = $this->createMock(IUserManager::class);
+        $this->notificationManager = $this->createMock(INotificationManager::class);
+        $this->ldapWrapper = $this->createMock(ILDAPWrapper::class);
+        $this->shareManager = $this->createMock(IManager::class);
+
+        $this->connection = new Connection($this->ldapWrapper, '', null);
+
+        $this->access->expects($this->any())
+            ->method('getConnection')
+            ->willReturn($this->connection);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->manager = new Manager(
+            $this->config,
+            $this->logger,
+            $this->avatarManager,
+            $this->image,
+            $this->ncUserManager,
+            $this->notificationManager,
+            $this->shareManager
+        );
+
+        $this->manager->setLdapAccess($this->access);
+    }
+
+    public static function dnProvider(): array {
+        return [
+            ['cn=foo,dc=foobar,dc=bar'],
+            ['uid=foo,o=foobar,c=bar'],
+            ['ab=cde,f=ghei,mno=pq'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dnProvider')]
+    public function testGetByDNExisting(string $inputDN): void {
+        $uid = '563418fc-423b-1033-8d1c-ad5f418ee02e';
+
+        $this->access->expects($this->once())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo($inputDN))
+            ->willReturn(true);
+        $this->access->expects($this->once())
+            ->method('dn2username')
+            ->with($this->equalTo($inputDN))
+            ->willReturn($uid);
+        $this->access->expects($this->never())
+            ->method('username2dn');
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->manager->get($inputDN);
+
+        // Now we fetch the user again. If this leads to a failing test,
+        // runtime caching the manager is broken.
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $user = $this->manager->get($inputDN);
+
+        $this->assertInstanceOf(User::class, $user);
+    }
+
+    public function testGetByDNNotExisting(): void {
+        $inputDN = 'cn=gone,dc=foobar,dc=bar';
+
+        $this->access->expects($this->once())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo($inputDN))
+            ->willReturn(true);
+        $this->access->expects($this->once())
+            ->method('dn2username')
+            ->with($this->equalTo($inputDN))
+            ->willReturn(false);
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->with($this->equalTo($inputDN))
+            ->willReturn(false);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $user = $this->manager->get($inputDN);
+
+        $this->assertNull($user);
+    }
+
+    public function testGetByUidExisting(): void {
+        $dn = 'cn=foo,dc=foobar,dc=bar';
+        $uid = '563418fc-423b-1033-8d1c-ad5f418ee02e';
+
+        $this->access->expects($this->never())
+            ->method('dn2username');
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->with($this->equalTo($uid))
+            ->willReturn($dn);
+        $this->access->expects($this->once())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo($uid))
+            ->willReturn(false);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->manager->get($uid);
+
+        // Now we fetch the user again. If this leads to a failing test,
+        // runtime caching the manager is broken.
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $user = $this->manager->get($uid);
+
+        $this->assertInstanceOf(User::class, $user);
+    }
+
+    public function testGetByUidNotExisting(): void {
+        $uid = 'gone';
+
+        $this->access->expects($this->never())
+            ->method('dn2username');
+        $this->access->expects($this->exactly(1))
+            ->method('username2dn')
+            ->with($this->equalTo($uid))
+            ->willReturn(false);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $user = $this->manager->get($uid);
+
+        $this->assertNull($user);
+    }
+
+    public static function attributeRequestProvider(): array {
+        return [
+            [false],
+            [true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attributeRequestProvider')]
+    public function testGetAttributes($minimal): void {
+        $this->connection->setConfiguration([
+            'ldapEmailAttribute' => 'MAIL',
+            'ldapUserAvatarRule' => 'default',
+            'ldapQuotaAttribute' => '',
+            'ldapUserDisplayName2' => 'Mail',
+        ]);
+
+        $attributes = $this->manager->getAttributes($minimal);
+
+        $this->assertContains('dn', $attributes);
+        $this->assertContains(strtolower($this->access->getConnection()->ldapEmailAttribute), $attributes);
+        $this->assertNotContains($this->access->getConnection()->ldapEmailAttribute, $attributes); #cases check
+        $this->assertNotContains('', $attributes);
+        $this->assertSame(!$minimal, in_array('jpegphoto', $attributes));
+        $this->assertSame(!$minimal, in_array('thumbnailphoto', $attributes));
+        $valueCounts = array_count_values($attributes);
+        $this->assertSame(1, $valueCounts['mail']);
+    }
 }

apps/user_ldap/tests/User/UserTest.php

Indentation +1144 added lines, -1144 removed lines

@@ -32,1148 +32,1148 @@
  * @package OCA\User_LDAP\Tests\User
  */
 class UserTest extends \Test\TestCase {
-	protected Access&MockObject $access;
-	protected Connection&MockObject $connection;
-	protected IConfig&MockObject $config;
-	protected INotificationManager&MockObject $notificationManager;
-	protected IUserManager&MockObject $userManager;
-	protected Image&MockObject $image;
-	protected IAvatarManager&MockObject $avatarManager;
-	protected LoggerInterface&MockObject $logger;
-	protected string $uid = 'alice';
-	protected string $dn = 'uid=alice,dc=foo,dc=bar';
-	protected User $user;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = $this->getMockBuilder(Connection::class)
-			->setConstructorArgs([$this->createMock(ILDAPWrapper::class)])
-			->getMock();
-
-		$this->access = $this->createMock(Access::class);
-		$this->access->connection = $this->connection;
-		$this->access->expects($this->any())
-			->method('getConnection')
-			->willReturn($this->connection);
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->avatarManager = $this->createMock(IAvatarManager::class);
-		$this->image = $this->createMock(Image::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->notificationManager = $this->createMock(INotificationManager::class);
-
-		$this->user = new User(
-			$this->uid,
-			$this->dn,
-			$this->access,
-			$this->config,
-			$this->image,
-			$this->logger,
-			$this->avatarManager,
-			$this->userManager,
-			$this->notificationManager
-		);
-	}
-
-	public function testGetDNandUsername(): void {
-		$this->assertSame($this->dn, $this->user->getDN());
-		$this->assertSame($this->uid, $this->user->getUsername());
-	}
-
-	public function testUpdateEmailProvided(): void {
-		$this->connection->expects($this->once())
-			->method('__get')
-			->with($this->equalTo('ldapEmailAttribute'))
-			->willReturn('email');
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('email'))
-			->willReturn(['alice@foo.bar']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setSystemEMailAddress')
-			->with('alice@foo.bar');
-
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($coreUser);
-
-		$this->user->updateEmail();
-	}
-
-	public function testUpdateEmailNotProvided(): void {
-		$this->connection->expects($this->once())
-			->method('__get')
-			->with($this->equalTo('ldapEmailAttribute'))
-			->willReturn('email');
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('email'))
-			->willReturn(false);
-
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$this->user->updateEmail();
-	}
-
-	public function testUpdateEmailNotConfigured(): void {
-		$this->connection->expects($this->once())
-			->method('__get')
-			->with($this->equalTo('ldapEmailAttribute'))
-			->willReturn('');
-
-		$this->access->expects($this->never())
-			->method('readAttribute');
-
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$this->user->updateEmail();
-	}
-
-	public function testUpdateQuotaAllProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['42 GB']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('42 GB');
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaToDefaultAllProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['default']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('default');
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaToNoneAllProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['none']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('none');
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaDefaultProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '25 GB'],
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(false);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('25 GB');
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaIndividualProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['27 GB']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('27 GB');
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaNoneProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(false);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->never())
-			->method('setQuota');
-
-		$this->userManager->expects($this->never())
-			->method('get')
-			->with($this->uid);
-
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaNoneConfigured(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', ''],
-				['ldapQuotaDefault', '']
-			]);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->never())
-			->method('setQuota');
-
-		$this->userManager->expects($this->never())
-			->method('get');
-
-		$this->access->expects($this->never())
-			->method('readAttribute');
-
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$this->user->updateQuota();
-	}
-
-	public function testUpdateQuotaFromValue(): void {
-		$readQuota = '19 GB';
-
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '']
-			]);
-
-		$this->access->expects($this->never())
-			->method('readAttribute');
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('setQuota')
-			->with($readQuota);
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($user);
-
-		$this->user->updateQuota($readQuota);
-	}
-
-	/**
-	 * Unparseable quota will fallback to use the LDAP default
-	 */
-	public function testUpdateWrongQuotaAllProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '23 GB']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['42 GBwos']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->once())
-			->method('setQuota')
-			->with('23 GB');
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with($this->uid)
-			->willReturn($coreUser);
-
-		$this->user->updateQuota();
-	}
-
-	/**
-	 * No user quota and wrong default will set 'default' as quota
-	 */
-	public function testUpdateWrongDefaultQuotaProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '23 GBwowowo']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(false);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->never())
-			->method('setQuota');
-
-		$this->userManager->expects($this->never())
-			->method('get');
-
-		$this->user->updateQuota();
-	}
-
-	/**
-	 * Wrong user quota and wrong default will set 'default' as quota
-	 */
-	public function testUpdateWrongQuotaAndDefaultAllProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', 'myquota'],
-				['ldapQuotaDefault', '23 GBwowowo']
-			]);
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('myquota'))
-			->willReturn(['23 flush']);
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->never())
-			->method('setQuota');
-
-		$this->userManager->expects($this->never())
-			->method('get');
-
-		$this->user->updateQuota();
-	}
-
-	/**
-	 * No quota attribute set and wrong default will set 'default' as quota
-	 */
-	public function testUpdateWrongDefaultQuotaNotProvided(): void {
-		$this->connection->expects($this->exactly(2))
-			->method('__get')
-			->willReturnMap([
-				['ldapQuotaAttribute', ''],
-				['ldapQuotaDefault', '23 GBwowowo']
-			]);
-
-		$this->access->expects($this->never())
-			->method('readAttribute');
-
-		$coreUser = $this->createMock(IUser::class);
-		$coreUser->expects($this->never())
-			->method('setQuota');
-
-		$this->userManager->expects($this->never())
-			->method('get');
-
-		$this->user->updateQuota();
-	}
-
-	//the testUpdateAvatar series also implicitly tests getAvatarImage
-	public function XtestUpdateAvatarJpegPhotoProvided() {
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('jpegphoto'))
-			->willReturn(['this is a photo']);
-
-		$this->image->expects($this->once())
-			->method('loadFromBase64')
-			->willReturn('imageResource');
-		$this->image->expects($this->once())
-			->method('valid')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('width')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('height')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('centerCrop')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('data')
-			->willReturn('this is a photo');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
-			->willReturn('');
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', md5('this is a photo'));
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->once())
-			->method('set')
-			->with($this->image);
-
-		$this->avatarManager->expects($this->once())
-			->method('getAvatar')
-			->with($this->equalTo($this->uid))
-			->willReturn($avatar);
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->user->updateAvatar();
-	}
-
-	public function testUpdateAvatarKnownJpegPhotoProvided(): void {
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('jpegphoto'))
-			->willReturn(['this is a photo']);
-
-		$this->image->expects($this->once())
-			->method('loadFromBase64')
-			->willReturn('imageResource');
-		$this->image->expects($this->never())
-			->method('valid');
-		$this->image->expects($this->never())
-			->method('width');
-		$this->image->expects($this->never())
-			->method('height');
-		$this->image->expects($this->never())
-			->method('centerCrop');
-		$this->image->expects($this->once())
-			->method('data')
-			->willReturn('this is a photo');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
-			->willReturn(md5('this is a photo'));
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->never())
-			->method('set');
-		$avatar->expects($this->any())
-			->method('exists')
-			->willReturn(true);
-		$avatar->expects($this->any())
-			->method('isCustomAvatar')
-			->willReturn(true);
-
-		$this->avatarManager->expects($this->any())
-			->method('getAvatar')
-			->with($this->uid)
-			->willReturn($avatar);
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->assertTrue($this->user->updateAvatar());
-	}
-
-	public function XtestUpdateAvatarThumbnailPhotoProvided() {
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($dn === $this->dn
-					&& $attr === 'jpegphoto') {
-					return false;
-				} elseif ($dn === $this->dn
-					&& $attr === 'thumbnailphoto') {
-					return ['this is a photo'];
-				}
-				return null;
-			});
-
-		$this->image->expects($this->once())
-			->method('loadFromBase64')
-			->willReturn('imageResource');
-		$this->image->expects($this->once())
-			->method('valid')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('width')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('height')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('centerCrop')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('data')
-			->willReturn('this is a photo');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
-			->willReturn('');
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', md5('this is a photo'));
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->once())
-			->method('set')
-			->with($this->image);
-
-		$this->avatarManager->expects($this->once())
-			->method('getAvatar')
-			->with($this->equalTo($this->uid))
-			->willReturn($avatar);
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->user->updateAvatar();
-	}
-
-	public function testUpdateAvatarCorruptPhotoProvided(): void {
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($dn === $this->dn
-					&& $attr === 'jpegphoto') {
-					return false;
-				} elseif ($dn === $this->dn
-					&& $attr === 'thumbnailphoto') {
-					return ['this is a photo'];
-				}
-				return null;
-			});
-
-		$this->image->expects($this->once())
-			->method('loadFromBase64')
-			->willReturn(false);
-		$this->image->expects($this->never())
-			->method('valid');
-		$this->image->expects($this->never())
-			->method('width');
-		$this->image->expects($this->never())
-			->method('height');
-		$this->image->expects($this->never())
-			->method('centerCrop');
-		$this->image->expects($this->never())
-			->method('data');
-
-		$this->config->expects($this->never())
-			->method('getUserValue');
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->never())
-			->method('set');
-
-		$this->avatarManager->expects($this->never())
-			->method('getAvatar');
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->user->updateAvatar();
-	}
-
-	public function XtestUpdateAvatarUnsupportedThumbnailPhotoProvided() {
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($dn === $this->dn
-					&& $attr === 'jpegphoto') {
-					return false;
-				} elseif ($dn === $this->dn
-					&& $attr === 'thumbnailphoto') {
-					return ['this is a photo'];
-				}
-				return null;
-			});
-
-		$this->image->expects($this->once())
-			->method('loadFromBase64')
-			->willReturn('imageResource');
-		$this->image->expects($this->once())
-			->method('valid')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('width')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('height')
-			->willReturn(128);
-		$this->image->expects($this->once())
-			->method('centerCrop')
-			->willReturn(true);
-		$this->image->expects($this->once())
-			->method('data')
-			->willReturn('this is a photo');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
-			->willReturn('');
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->once())
-			->method('set')
-			->with($this->image)
-			->willThrowException(new \Exception());
-
-		$this->avatarManager->expects($this->once())
-			->method('getAvatar')
-			->with($this->equalTo($this->uid))
-			->willReturn($avatar);
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->assertFalse($this->user->updateAvatar());
-	}
-
-	public function testUpdateAvatarNotProvided(): void {
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($dn === $this->dn
-					&& $attr === 'jpegPhoto') {
-					return false;
-				} elseif ($dn === $this->dn
-					&& $attr === 'thumbnailPhoto') {
-					return false;
-				}
-				return null;
-			});
-
-		$this->image->expects($this->never())
-			->method('valid');
-		$this->image->expects($this->never())
-			->method('width');
-		$this->image->expects($this->never())
-			->method('height');
-		$this->image->expects($this->never())
-			->method('centerCrop');
-		$this->image->expects($this->never())
-			->method('data');
-
-		$this->config->expects($this->never())
-			->method('getUserValue');
-		$this->config->expects($this->never())
-			->method('setUserValue');
-
-		$this->avatarManager->expects($this->never())
-			->method('getAvatar');
-
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$this->user->updateAvatar();
-	}
-
-	public static function extStorageHomeDataProvider(): array {
-		return [
-			[ 'myFolder', null ],
-			[ '', null, false ],
-			[ 'myFolder', 'myFolder' ],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('extStorageHomeDataProvider')]
-	public function testUpdateExtStorageHome(string $expected, ?string $valueFromLDAP = null, bool $isSet = true): void {
-		if ($valueFromLDAP === null) {
-			$this->connection->expects($this->once())
-				->method('__get')
-				->willReturnMap([
-					['ldapExtStorageHomeAttribute', 'homeDirectory'],
-				]);
-
-			$return = [];
-			if ($isSet) {
-				$return[] = $expected;
-			}
-			$this->access->expects($this->once())
-				->method('readAttribute')
-				->with($this->dn, 'homeDirectory')
-				->willReturn($return);
-		}
-
-		if ($expected !== '') {
-			$this->config->expects($this->once())
-				->method('setUserValue')
-				->with($this->uid, 'user_ldap', 'extStorageHome', $expected);
-		} else {
-			$this->config->expects($this->once())
-				->method('deleteUserValue')
-				->with($this->uid, 'user_ldap', 'extStorageHome');
-		}
-
-		$actual = $this->user->updateExtStorageHome($valueFromLDAP);
-		$this->assertSame($expected, $actual);
-	}
-
-	public function testMarkLogin(): void {
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with($this->equalTo($this->uid),
-				$this->equalTo('user_ldap'),
-				$this->equalTo(User::USER_PREFKEY_FIRSTLOGIN),
-				$this->equalTo(1))
-			->willReturn(true);
-
-		$this->user->markLogin();
-	}
-
-	public function testGetAvatarImageProvided(): void {
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn),
-				$this->equalTo('jpegphoto'))
-			->willReturn(['this is a photo']);
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$photo = $this->user->getAvatarImage();
-		$this->assertSame('this is a photo', $photo);
-		//make sure readAttribute is not called again but the already fetched
-		//photo is returned
-		$this->user->getAvatarImage();
-	}
-
-	public function testGetAvatarImageDisabled(): void {
-		$this->access->expects($this->never())
-			->method('readAttribute')
-			->with($this->equalTo($this->dn), $this->anything());
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn([]);
-
-		$this->assertFalse($this->user->getAvatarImage());
-	}
-
-	public static function imageDataProvider(): array {
-		return [
-			[ false, false ],
-			[ 'corruptData', false ],
-			[ 'validData', true ],
-		];
-	}
-
-	public function testProcessAttributes(): void {
-		$requiredMethods = [
-			'updateQuota',
-			'updateEmail',
-			'composeAndStoreDisplayName',
-			'storeLDAPUserName',
-			'getHomePath',
-			'updateAvatar',
-			'updateExtStorageHome',
-		];
-
-		/** @var User&MockObject $userMock */
-		$userMock = $this->getMockBuilder(User::class)
-			->setConstructorArgs([
-				$this->uid,
-				$this->dn,
-				$this->access,
-				$this->config,
-				$this->image,
-				$this->logger,
-				$this->avatarManager,
-				$this->userManager,
-				$this->notificationManager
-			])
-			->onlyMethods($requiredMethods)
-			->getMock();
-
-		$this->connection->setConfiguration([
-			'homeFolderNamingRule' => 'homeDirectory'
-		]);
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'homeFolderNamingRule') {
-					return 'attr:homeDirectory';
-				}
-				return $name;
-			});
-		$this->connection->expects($this->any())
-			->method('resolveRule')
-			->with('avatar')
-			->willReturn(['jpegphoto', 'thumbnailphoto']);
-
-		$record = [
-			strtolower($this->connection->ldapQuotaAttribute) => ['4096'],
-			strtolower($this->connection->ldapEmailAttribute) => ['alice@wonderland.org'],
-			strtolower($this->connection->ldapUserDisplayName) => ['Aaaaalice'],
-			strtolower($this->connection->ldapExtStorageHomeAttribute) => ['homeDirectory'],
-			'uid' => [$this->uid],
-			'homedirectory' => ['Alice\'s Folder'],
-			'memberof' => ['cn=groupOne', 'cn=groupTwo'],
-			'jpegphoto' => ['here be an image']
-		];
-
-		foreach ($requiredMethods as $method) {
-			$userMock->expects($this->once())
-				->method($method);
-		}
-		\OC_Hook::clear();//disconnect irrelevant hooks
-		$userMock->processAttributes($record);
-		/** @noinspection PhpUnhandledExceptionInspection */
-		\OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
-	}
-
-	public static function emptyHomeFolderAttributeValueProvider(): array {
-		return [
-			'empty' => [''],
-			'prefixOnly' => ['attr:'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('emptyHomeFolderAttributeValueProvider')]
-	public function testGetHomePathNotConfigured(string $attributeValue): void {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->with($this->equalTo('homeFolderNamingRule'))
-			->willReturn($attributeValue);
-
-		$this->access->expects($this->never())
-			->method('readAttribute');
-
-		$this->config->expects($this->never())
-			->method('getAppValue');
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertFalse($this->user->getHomePath());
-	}
-
-	public function testGetHomePathConfiguredNotAvailableAllowed(): void {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->with($this->equalTo('homeFolderNamingRule'))
-			->willReturn('attr:foobar');
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->willReturn(false);
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->willReturn($this->dn);
-
-		// asks for "enforce_home_folder_naming_rule"
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->willReturn(false);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertFalse($this->user->getHomePath());
-	}
-
-
-	public function testGetHomePathConfiguredNotAvailableNotAllowed(): void {
-		$this->expectException(\Exception::class);
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->with($this->equalTo('homeFolderNamingRule'))
-			->willReturn('attr:foobar');
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->willReturn(false);
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->willReturn($this->dn);
-
-		// asks for "enforce_home_folder_naming_rule"
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->willReturn(true);
-
-		$this->user->getHomePath();
-	}
-
-	public static function displayNameProvider(): array {
-		return [
-			['Roland Deschain', '', 'Roland Deschain', false],
-			['Roland Deschain', '', 'Roland Deschain', true],
-			['Roland Deschain', 'gunslinger@darktower.com', 'Roland Deschain (gunslinger@darktower.com)', false],
-			['Roland Deschain', 'gunslinger@darktower.com', 'Roland Deschain (gunslinger@darktower.com)', true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('displayNameProvider')]
-	public function testComposeAndStoreDisplayName(string $part1, string $part2, string $expected, bool $expectTriggerChange): void {
-		$this->config->expects($this->once())
-			->method('setUserValue');
-		$oldName = $expectTriggerChange ? 'xxGunslingerxx' : null;
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with($this->user->getUsername(), 'user_ldap', 'displayName', null)
-			->willReturn($oldName);
-
-		$ncUserObj = $this->createMock(\OC\User\User::class);
-		if ($expectTriggerChange) {
-			$ncUserObj->expects($this->once())
-				->method('triggerChange')
-				->with('displayName', $expected);
-		} else {
-			$ncUserObj->expects($this->never())
-				->method('triggerChange');
-		}
-		$this->userManager->expects($this->once())
-			->method('get')
-			->willReturn($ncUserObj);
-
-		$displayName = $this->user->composeAndStoreDisplayName($part1, $part2);
-		$this->assertSame($expected, $displayName);
-	}
-
-	public function testComposeAndStoreDisplayNameNoOverwrite(): void {
-		$displayName = 'Randall Flagg';
-		$this->config->expects($this->never())
-			->method('setUserValue');
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->willReturn($displayName);
-
-		$this->userManager->expects($this->never())
-			->method('get'); // Implicit: no triggerChange can be called
-
-		$composedDisplayName = $this->user->composeAndStoreDisplayName($displayName);
-		$this->assertSame($composedDisplayName, $displayName);
-	}
-
-	public function testHandlePasswordExpiryWarningDefaultPolicy(): void {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapDefaultPPolicyDN') {
-					return 'cn=default,ou=policies,dc=foo,dc=bar';
-				}
-				if ($name === 'turnOnPasswordChange') {
-					return '1';
-				}
-				return $name;
-			});
-
-		$this->access->expects($this->any())
-			->method('search')
-			->willReturnCallback(function ($filter, $base) {
-				if ($base === $this->dn) {
-					return [
-						[
-							'pwdchangedtime' => [(new \DateTime())->sub(new \DateInterval('P28D'))->format('Ymdhis') . 'Z'],
-							'pwdgraceusetime' => [],
-						],
-					];
-				}
-				if ($base === 'cn=default,ou=policies,dc=foo,dc=bar') {
-					return [
-						[
-							'pwdmaxage' => ['2592000'],
-							'pwdexpirewarning' => ['2591999'],
-						],
-					];
-				}
-				return [];
-			});
-
-		$notification = $this->getMockBuilder(INotification::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$notification->expects($this->any())
-			->method('setApp')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setUser')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setObject')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setDateTime')
-			->willReturn($notification);
-
-		$this->notificationManager->expects($this->exactly(2))
-			->method('createNotification')
-			->willReturn($notification);
-		$this->notificationManager->expects($this->exactly(1))
-			->method('notify');
-
-		\OC_Hook::clear();//disconnect irrelevant hooks
-		Util::connectHook('OC_User', 'post_login', $this->user, 'handlePasswordExpiry');
-		/** @noinspection PhpUnhandledExceptionInspection */
-		\OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
-	}
-
-	public function testHandlePasswordExpiryWarningCustomPolicy(): void {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapDefaultPPolicyDN') {
-					return 'cn=default,ou=policies,dc=foo,dc=bar';
-				}
-				if ($name === 'turnOnPasswordChange') {
-					return '1';
-				}
-				return $name;
-			});
-
-		$this->access->expects($this->any())
-			->method('search')
-			->willReturnCallback(function ($filter, $base) {
-				if ($base === $this->dn) {
-					return [
-						[
-							'pwdpolicysubentry' => ['cn=custom,ou=policies,dc=foo,dc=bar'],
-							'pwdchangedtime' => [(new \DateTime())->sub(new \DateInterval('P28D'))->format('Ymdhis') . 'Z'],
-							'pwdgraceusetime' => [],
-						]
-					];
-				}
-				if ($base === 'cn=custom,ou=policies,dc=foo,dc=bar') {
-					return [
-						[
-							'pwdmaxage' => ['2592000'],
-							'pwdexpirewarning' => ['2591999'],
-						]
-					];
-				}
-				return [];
-			});
-
-		$notification = $this->getMockBuilder(INotification::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$notification->expects($this->any())
-			->method('setApp')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setUser')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setObject')
-			->willReturn($notification);
-		$notification->expects($this->any())
-			->method('setDateTime')
-			->willReturn($notification);
-
-		$this->notificationManager->expects($this->exactly(2))
-			->method('createNotification')
-			->willReturn($notification);
-		$this->notificationManager->expects($this->exactly(1))
-			->method('notify');
-
-		\OC_Hook::clear();//disconnect irrelevant hooks
-		Util::connectHook('OC_User', 'post_login', $this->user, 'handlePasswordExpiry');
-		/** @noinspection PhpUnhandledExceptionInspection */
-		\OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
-	}
+    protected Access&MockObject $access;
+    protected Connection&MockObject $connection;
+    protected IConfig&MockObject $config;
+    protected INotificationManager&MockObject $notificationManager;
+    protected IUserManager&MockObject $userManager;
+    protected Image&MockObject $image;
+    protected IAvatarManager&MockObject $avatarManager;
+    protected LoggerInterface&MockObject $logger;
+    protected string $uid = 'alice';
+    protected string $dn = 'uid=alice,dc=foo,dc=bar';
+    protected User $user;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = $this->getMockBuilder(Connection::class)
+            ->setConstructorArgs([$this->createMock(ILDAPWrapper::class)])
+            ->getMock();
+
+        $this->access = $this->createMock(Access::class);
+        $this->access->connection = $this->connection;
+        $this->access->expects($this->any())
+            ->method('getConnection')
+            ->willReturn($this->connection);
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->avatarManager = $this->createMock(IAvatarManager::class);
+        $this->image = $this->createMock(Image::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->notificationManager = $this->createMock(INotificationManager::class);
+
+        $this->user = new User(
+            $this->uid,
+            $this->dn,
+            $this->access,
+            $this->config,
+            $this->image,
+            $this->logger,
+            $this->avatarManager,
+            $this->userManager,
+            $this->notificationManager
+        );
+    }
+
+    public function testGetDNandUsername(): void {
+        $this->assertSame($this->dn, $this->user->getDN());
+        $this->assertSame($this->uid, $this->user->getUsername());
+    }
+
+    public function testUpdateEmailProvided(): void {
+        $this->connection->expects($this->once())
+            ->method('__get')
+            ->with($this->equalTo('ldapEmailAttribute'))
+            ->willReturn('email');
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('email'))
+            ->willReturn(['alice@foo.bar']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setSystemEMailAddress')
+            ->with('alice@foo.bar');
+
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($coreUser);
+
+        $this->user->updateEmail();
+    }
+
+    public function testUpdateEmailNotProvided(): void {
+        $this->connection->expects($this->once())
+            ->method('__get')
+            ->with($this->equalTo('ldapEmailAttribute'))
+            ->willReturn('email');
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('email'))
+            ->willReturn(false);
+
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $this->user->updateEmail();
+    }
+
+    public function testUpdateEmailNotConfigured(): void {
+        $this->connection->expects($this->once())
+            ->method('__get')
+            ->with($this->equalTo('ldapEmailAttribute'))
+            ->willReturn('');
+
+        $this->access->expects($this->never())
+            ->method('readAttribute');
+
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $this->user->updateEmail();
+    }
+
+    public function testUpdateQuotaAllProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['42 GB']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('42 GB');
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaToDefaultAllProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['default']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('default');
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaToNoneAllProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['none']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('none');
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaDefaultProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '25 GB'],
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(false);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('25 GB');
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaIndividualProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['27 GB']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('27 GB');
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaNoneProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(false);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->never())
+            ->method('setQuota');
+
+        $this->userManager->expects($this->never())
+            ->method('get')
+            ->with($this->uid);
+
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaNoneConfigured(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', ''],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->never())
+            ->method('setQuota');
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+
+        $this->access->expects($this->never())
+            ->method('readAttribute');
+
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $this->user->updateQuota();
+    }
+
+    public function testUpdateQuotaFromValue(): void {
+        $readQuota = '19 GB';
+
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '']
+            ]);
+
+        $this->access->expects($this->never())
+            ->method('readAttribute');
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('setQuota')
+            ->with($readQuota);
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($user);
+
+        $this->user->updateQuota($readQuota);
+    }
+
+    /**
+     * Unparseable quota will fallback to use the LDAP default
+     */
+    public function testUpdateWrongQuotaAllProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '23 GB']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['42 GBwos']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->once())
+            ->method('setQuota')
+            ->with('23 GB');
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with($this->uid)
+            ->willReturn($coreUser);
+
+        $this->user->updateQuota();
+    }
+
+    /**
+     * No user quota and wrong default will set 'default' as quota
+     */
+    public function testUpdateWrongDefaultQuotaProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '23 GBwowowo']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(false);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->never())
+            ->method('setQuota');
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+
+        $this->user->updateQuota();
+    }
+
+    /**
+     * Wrong user quota and wrong default will set 'default' as quota
+     */
+    public function testUpdateWrongQuotaAndDefaultAllProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', 'myquota'],
+                ['ldapQuotaDefault', '23 GBwowowo']
+            ]);
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('myquota'))
+            ->willReturn(['23 flush']);
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->never())
+            ->method('setQuota');
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+
+        $this->user->updateQuota();
+    }
+
+    /**
+     * No quota attribute set and wrong default will set 'default' as quota
+     */
+    public function testUpdateWrongDefaultQuotaNotProvided(): void {
+        $this->connection->expects($this->exactly(2))
+            ->method('__get')
+            ->willReturnMap([
+                ['ldapQuotaAttribute', ''],
+                ['ldapQuotaDefault', '23 GBwowowo']
+            ]);
+
+        $this->access->expects($this->never())
+            ->method('readAttribute');
+
+        $coreUser = $this->createMock(IUser::class);
+        $coreUser->expects($this->never())
+            ->method('setQuota');
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+
+        $this->user->updateQuota();
+    }
+
+    //the testUpdateAvatar series also implicitly tests getAvatarImage
+    public function XtestUpdateAvatarJpegPhotoProvided() {
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('jpegphoto'))
+            ->willReturn(['this is a photo']);
+
+        $this->image->expects($this->once())
+            ->method('loadFromBase64')
+            ->willReturn('imageResource');
+        $this->image->expects($this->once())
+            ->method('valid')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('width')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('height')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('centerCrop')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('data')
+            ->willReturn('this is a photo');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
+            ->willReturn('');
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', md5('this is a photo'));
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->once())
+            ->method('set')
+            ->with($this->image);
+
+        $this->avatarManager->expects($this->once())
+            ->method('getAvatar')
+            ->with($this->equalTo($this->uid))
+            ->willReturn($avatar);
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->user->updateAvatar();
+    }
+
+    public function testUpdateAvatarKnownJpegPhotoProvided(): void {
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('jpegphoto'))
+            ->willReturn(['this is a photo']);
+
+        $this->image->expects($this->once())
+            ->method('loadFromBase64')
+            ->willReturn('imageResource');
+        $this->image->expects($this->never())
+            ->method('valid');
+        $this->image->expects($this->never())
+            ->method('width');
+        $this->image->expects($this->never())
+            ->method('height');
+        $this->image->expects($this->never())
+            ->method('centerCrop');
+        $this->image->expects($this->once())
+            ->method('data')
+            ->willReturn('this is a photo');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
+            ->willReturn(md5('this is a photo'));
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->never())
+            ->method('set');
+        $avatar->expects($this->any())
+            ->method('exists')
+            ->willReturn(true);
+        $avatar->expects($this->any())
+            ->method('isCustomAvatar')
+            ->willReturn(true);
+
+        $this->avatarManager->expects($this->any())
+            ->method('getAvatar')
+            ->with($this->uid)
+            ->willReturn($avatar);
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->assertTrue($this->user->updateAvatar());
+    }
+
+    public function XtestUpdateAvatarThumbnailPhotoProvided() {
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($dn === $this->dn
+                    && $attr === 'jpegphoto') {
+                    return false;
+                } elseif ($dn === $this->dn
+                    && $attr === 'thumbnailphoto') {
+                    return ['this is a photo'];
+                }
+                return null;
+            });
+
+        $this->image->expects($this->once())
+            ->method('loadFromBase64')
+            ->willReturn('imageResource');
+        $this->image->expects($this->once())
+            ->method('valid')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('width')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('height')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('centerCrop')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('data')
+            ->willReturn('this is a photo');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
+            ->willReturn('');
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', md5('this is a photo'));
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->once())
+            ->method('set')
+            ->with($this->image);
+
+        $this->avatarManager->expects($this->once())
+            ->method('getAvatar')
+            ->with($this->equalTo($this->uid))
+            ->willReturn($avatar);
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->user->updateAvatar();
+    }
+
+    public function testUpdateAvatarCorruptPhotoProvided(): void {
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($dn === $this->dn
+                    && $attr === 'jpegphoto') {
+                    return false;
+                } elseif ($dn === $this->dn
+                    && $attr === 'thumbnailphoto') {
+                    return ['this is a photo'];
+                }
+                return null;
+            });
+
+        $this->image->expects($this->once())
+            ->method('loadFromBase64')
+            ->willReturn(false);
+        $this->image->expects($this->never())
+            ->method('valid');
+        $this->image->expects($this->never())
+            ->method('width');
+        $this->image->expects($this->never())
+            ->method('height');
+        $this->image->expects($this->never())
+            ->method('centerCrop');
+        $this->image->expects($this->never())
+            ->method('data');
+
+        $this->config->expects($this->never())
+            ->method('getUserValue');
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->never())
+            ->method('set');
+
+        $this->avatarManager->expects($this->never())
+            ->method('getAvatar');
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->user->updateAvatar();
+    }
+
+    public function XtestUpdateAvatarUnsupportedThumbnailPhotoProvided() {
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($dn === $this->dn
+                    && $attr === 'jpegphoto') {
+                    return false;
+                } elseif ($dn === $this->dn
+                    && $attr === 'thumbnailphoto') {
+                    return ['this is a photo'];
+                }
+                return null;
+            });
+
+        $this->image->expects($this->once())
+            ->method('loadFromBase64')
+            ->willReturn('imageResource');
+        $this->image->expects($this->once())
+            ->method('valid')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('width')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('height')
+            ->willReturn(128);
+        $this->image->expects($this->once())
+            ->method('centerCrop')
+            ->willReturn(true);
+        $this->image->expects($this->once())
+            ->method('data')
+            ->willReturn('this is a photo');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with($this->uid, 'user_ldap', 'lastAvatarChecksum', '')
+            ->willReturn('');
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->once())
+            ->method('set')
+            ->with($this->image)
+            ->willThrowException(new \Exception());
+
+        $this->avatarManager->expects($this->once())
+            ->method('getAvatar')
+            ->with($this->equalTo($this->uid))
+            ->willReturn($avatar);
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->assertFalse($this->user->updateAvatar());
+    }
+
+    public function testUpdateAvatarNotProvided(): void {
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($dn === $this->dn
+                    && $attr === 'jpegPhoto') {
+                    return false;
+                } elseif ($dn === $this->dn
+                    && $attr === 'thumbnailPhoto') {
+                    return false;
+                }
+                return null;
+            });
+
+        $this->image->expects($this->never())
+            ->method('valid');
+        $this->image->expects($this->never())
+            ->method('width');
+        $this->image->expects($this->never())
+            ->method('height');
+        $this->image->expects($this->never())
+            ->method('centerCrop');
+        $this->image->expects($this->never())
+            ->method('data');
+
+        $this->config->expects($this->never())
+            ->method('getUserValue');
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+
+        $this->avatarManager->expects($this->never())
+            ->method('getAvatar');
+
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $this->user->updateAvatar();
+    }
+
+    public static function extStorageHomeDataProvider(): array {
+        return [
+            [ 'myFolder', null ],
+            [ '', null, false ],
+            [ 'myFolder', 'myFolder' ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('extStorageHomeDataProvider')]
+    public function testUpdateExtStorageHome(string $expected, ?string $valueFromLDAP = null, bool $isSet = true): void {
+        if ($valueFromLDAP === null) {
+            $this->connection->expects($this->once())
+                ->method('__get')
+                ->willReturnMap([
+                    ['ldapExtStorageHomeAttribute', 'homeDirectory'],
+                ]);
+
+            $return = [];
+            if ($isSet) {
+                $return[] = $expected;
+            }
+            $this->access->expects($this->once())
+                ->method('readAttribute')
+                ->with($this->dn, 'homeDirectory')
+                ->willReturn($return);
+        }
+
+        if ($expected !== '') {
+            $this->config->expects($this->once())
+                ->method('setUserValue')
+                ->with($this->uid, 'user_ldap', 'extStorageHome', $expected);
+        } else {
+            $this->config->expects($this->once())
+                ->method('deleteUserValue')
+                ->with($this->uid, 'user_ldap', 'extStorageHome');
+        }
+
+        $actual = $this->user->updateExtStorageHome($valueFromLDAP);
+        $this->assertSame($expected, $actual);
+    }
+
+    public function testMarkLogin(): void {
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with($this->equalTo($this->uid),
+                $this->equalTo('user_ldap'),
+                $this->equalTo(User::USER_PREFKEY_FIRSTLOGIN),
+                $this->equalTo(1))
+            ->willReturn(true);
+
+        $this->user->markLogin();
+    }
+
+    public function testGetAvatarImageProvided(): void {
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn),
+                $this->equalTo('jpegphoto'))
+            ->willReturn(['this is a photo']);
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $photo = $this->user->getAvatarImage();
+        $this->assertSame('this is a photo', $photo);
+        //make sure readAttribute is not called again but the already fetched
+        //photo is returned
+        $this->user->getAvatarImage();
+    }
+
+    public function testGetAvatarImageDisabled(): void {
+        $this->access->expects($this->never())
+            ->method('readAttribute')
+            ->with($this->equalTo($this->dn), $this->anything());
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn([]);
+
+        $this->assertFalse($this->user->getAvatarImage());
+    }
+
+    public static function imageDataProvider(): array {
+        return [
+            [ false, false ],
+            [ 'corruptData', false ],
+            [ 'validData', true ],
+        ];
+    }
+
+    public function testProcessAttributes(): void {
+        $requiredMethods = [
+            'updateQuota',
+            'updateEmail',
+            'composeAndStoreDisplayName',
+            'storeLDAPUserName',
+            'getHomePath',
+            'updateAvatar',
+            'updateExtStorageHome',
+        ];
+
+        /** @var User&MockObject $userMock */
+        $userMock = $this->getMockBuilder(User::class)
+            ->setConstructorArgs([
+                $this->uid,
+                $this->dn,
+                $this->access,
+                $this->config,
+                $this->image,
+                $this->logger,
+                $this->avatarManager,
+                $this->userManager,
+                $this->notificationManager
+            ])
+            ->onlyMethods($requiredMethods)
+            ->getMock();
+
+        $this->connection->setConfiguration([
+            'homeFolderNamingRule' => 'homeDirectory'
+        ]);
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'homeFolderNamingRule') {
+                    return 'attr:homeDirectory';
+                }
+                return $name;
+            });
+        $this->connection->expects($this->any())
+            ->method('resolveRule')
+            ->with('avatar')
+            ->willReturn(['jpegphoto', 'thumbnailphoto']);
+
+        $record = [
+            strtolower($this->connection->ldapQuotaAttribute) => ['4096'],
+            strtolower($this->connection->ldapEmailAttribute) => ['alice@wonderland.org'],
+            strtolower($this->connection->ldapUserDisplayName) => ['Aaaaalice'],
+            strtolower($this->connection->ldapExtStorageHomeAttribute) => ['homeDirectory'],
+            'uid' => [$this->uid],
+            'homedirectory' => ['Alice\'s Folder'],
+            'memberof' => ['cn=groupOne', 'cn=groupTwo'],
+            'jpegphoto' => ['here be an image']
+        ];
+
+        foreach ($requiredMethods as $method) {
+            $userMock->expects($this->once())
+                ->method($method);
+        }
+        \OC_Hook::clear();//disconnect irrelevant hooks
+        $userMock->processAttributes($record);
+        /** @noinspection PhpUnhandledExceptionInspection */
+        \OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
+    }
+
+    public static function emptyHomeFolderAttributeValueProvider(): array {
+        return [
+            'empty' => [''],
+            'prefixOnly' => ['attr:'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('emptyHomeFolderAttributeValueProvider')]
+    public function testGetHomePathNotConfigured(string $attributeValue): void {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->with($this->equalTo('homeFolderNamingRule'))
+            ->willReturn($attributeValue);
+
+        $this->access->expects($this->never())
+            ->method('readAttribute');
+
+        $this->config->expects($this->never())
+            ->method('getAppValue');
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertFalse($this->user->getHomePath());
+    }
+
+    public function testGetHomePathConfiguredNotAvailableAllowed(): void {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->with($this->equalTo('homeFolderNamingRule'))
+            ->willReturn('attr:foobar');
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->willReturn(false);
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->willReturn($this->dn);
+
+        // asks for "enforce_home_folder_naming_rule"
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->willReturn(false);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertFalse($this->user->getHomePath());
+    }
+
+
+    public function testGetHomePathConfiguredNotAvailableNotAllowed(): void {
+        $this->expectException(\Exception::class);
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->with($this->equalTo('homeFolderNamingRule'))
+            ->willReturn('attr:foobar');
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->willReturn(false);
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->willReturn($this->dn);
+
+        // asks for "enforce_home_folder_naming_rule"
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->willReturn(true);
+
+        $this->user->getHomePath();
+    }
+
+    public static function displayNameProvider(): array {
+        return [
+            ['Roland Deschain', '', 'Roland Deschain', false],
+            ['Roland Deschain', '', 'Roland Deschain', true],
+            ['Roland Deschain', 'gunslinger@darktower.com', 'Roland Deschain (gunslinger@darktower.com)', false],
+            ['Roland Deschain', 'gunslinger@darktower.com', 'Roland Deschain (gunslinger@darktower.com)', true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('displayNameProvider')]
+    public function testComposeAndStoreDisplayName(string $part1, string $part2, string $expected, bool $expectTriggerChange): void {
+        $this->config->expects($this->once())
+            ->method('setUserValue');
+        $oldName = $expectTriggerChange ? 'xxGunslingerxx' : null;
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with($this->user->getUsername(), 'user_ldap', 'displayName', null)
+            ->willReturn($oldName);
+
+        $ncUserObj = $this->createMock(\OC\User\User::class);
+        if ($expectTriggerChange) {
+            $ncUserObj->expects($this->once())
+                ->method('triggerChange')
+                ->with('displayName', $expected);
+        } else {
+            $ncUserObj->expects($this->never())
+                ->method('triggerChange');
+        }
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->willReturn($ncUserObj);
+
+        $displayName = $this->user->composeAndStoreDisplayName($part1, $part2);
+        $this->assertSame($expected, $displayName);
+    }
+
+    public function testComposeAndStoreDisplayNameNoOverwrite(): void {
+        $displayName = 'Randall Flagg';
+        $this->config->expects($this->never())
+            ->method('setUserValue');
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->willReturn($displayName);
+
+        $this->userManager->expects($this->never())
+            ->method('get'); // Implicit: no triggerChange can be called
+
+        $composedDisplayName = $this->user->composeAndStoreDisplayName($displayName);
+        $this->assertSame($composedDisplayName, $displayName);
+    }
+
+    public function testHandlePasswordExpiryWarningDefaultPolicy(): void {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapDefaultPPolicyDN') {
+                    return 'cn=default,ou=policies,dc=foo,dc=bar';
+                }
+                if ($name === 'turnOnPasswordChange') {
+                    return '1';
+                }
+                return $name;
+            });
+
+        $this->access->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function ($filter, $base) {
+                if ($base === $this->dn) {
+                    return [
+                        [
+                            'pwdchangedtime' => [(new \DateTime())->sub(new \DateInterval('P28D'))->format('Ymdhis') . 'Z'],
+                            'pwdgraceusetime' => [],
+                        ],
+                    ];
+                }
+                if ($base === 'cn=default,ou=policies,dc=foo,dc=bar') {
+                    return [
+                        [
+                            'pwdmaxage' => ['2592000'],
+                            'pwdexpirewarning' => ['2591999'],
+                        ],
+                    ];
+                }
+                return [];
+            });
+
+        $notification = $this->getMockBuilder(INotification::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $notification->expects($this->any())
+            ->method('setApp')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setUser')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setObject')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setDateTime')
+            ->willReturn($notification);
+
+        $this->notificationManager->expects($this->exactly(2))
+            ->method('createNotification')
+            ->willReturn($notification);
+        $this->notificationManager->expects($this->exactly(1))
+            ->method('notify');
+
+        \OC_Hook::clear();//disconnect irrelevant hooks
+        Util::connectHook('OC_User', 'post_login', $this->user, 'handlePasswordExpiry');
+        /** @noinspection PhpUnhandledExceptionInspection */
+        \OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
+    }
+
+    public function testHandlePasswordExpiryWarningCustomPolicy(): void {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapDefaultPPolicyDN') {
+                    return 'cn=default,ou=policies,dc=foo,dc=bar';
+                }
+                if ($name === 'turnOnPasswordChange') {
+                    return '1';
+                }
+                return $name;
+            });
+
+        $this->access->expects($this->any())
+            ->method('search')
+            ->willReturnCallback(function ($filter, $base) {
+                if ($base === $this->dn) {
+                    return [
+                        [
+                            'pwdpolicysubentry' => ['cn=custom,ou=policies,dc=foo,dc=bar'],
+                            'pwdchangedtime' => [(new \DateTime())->sub(new \DateInterval('P28D'))->format('Ymdhis') . 'Z'],
+                            'pwdgraceusetime' => [],
+                        ]
+                    ];
+                }
+                if ($base === 'cn=custom,ou=policies,dc=foo,dc=bar') {
+                    return [
+                        [
+                            'pwdmaxage' => ['2592000'],
+                            'pwdexpirewarning' => ['2591999'],
+                        ]
+                    ];
+                }
+                return [];
+            });
+
+        $notification = $this->getMockBuilder(INotification::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $notification->expects($this->any())
+            ->method('setApp')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setUser')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setObject')
+            ->willReturn($notification);
+        $notification->expects($this->any())
+            ->method('setDateTime')
+            ->willReturn($notification);
+
+        $this->notificationManager->expects($this->exactly(2))
+            ->method('createNotification')
+            ->willReturn($notification);
+        $this->notificationManager->expects($this->exactly(1))
+            ->method('notify');
+
+        \OC_Hook::clear();//disconnect irrelevant hooks
+        Util::connectHook('OC_User', 'post_login', $this->user, 'handlePasswordExpiry');
+        /** @noinspection PhpUnhandledExceptionInspection */
+        \OC_Hook::emit('OC_User', 'post_login', ['uid' => $this->uid]);
+    }
 }

apps/user_ldap/tests/User/OfflineUserTest.php

Indentation +39 added lines, -39 removed lines

@@ -17,49 +17,49 @@
 use Test\TestCase;
 
 class OfflineUserTest extends TestCase {
-	protected UserMapping&MockObject $mapping;
-	protected string $uid;
-	protected IConfig&MockObject $config;
-	protected IManager&MockObject $shareManager;
-	protected OfflineUser $offlineUser;
+    protected UserMapping&MockObject $mapping;
+    protected string $uid;
+    protected IConfig&MockObject $config;
+    protected IManager&MockObject $shareManager;
+    protected OfflineUser $offlineUser;
 
-	public function setUp(): void {
-		$this->uid = 'deborah';
-		$this->config = $this->createMock(IConfig::class);
-		$this->mapping = $this->createMock(UserMapping::class);
-		$this->shareManager = $this->createMock(IManager::class);
+    public function setUp(): void {
+        $this->uid = 'deborah';
+        $this->config = $this->createMock(IConfig::class);
+        $this->mapping = $this->createMock(UserMapping::class);
+        $this->shareManager = $this->createMock(IManager::class);
 
-		$this->offlineUser = new OfflineUser(
-			$this->uid,
-			$this->config,
-			$this->mapping,
-			$this->shareManager
-		);
-	}
+        $this->offlineUser = new OfflineUser(
+            $this->uid,
+            $this->config,
+            $this->mapping,
+            $this->shareManager
+        );
+    }
 
-	public static function shareOwnerProvider(): array {
-		return [
-			[[], false],
-			[[IShare::TYPE_USER], true],
-			[[IShare::TYPE_GROUP, IShare::TYPE_LINK], true],
-			[[IShare::TYPE_EMAIL, IShare::TYPE_REMOTE, IShare::TYPE_CIRCLE], true],
-			[[IShare::TYPE_GUEST, IShare::TYPE_REMOTE_GROUP, IShare::TYPE_ROOM], true],
-		];
-	}
+    public static function shareOwnerProvider(): array {
+        return [
+            [[], false],
+            [[IShare::TYPE_USER], true],
+            [[IShare::TYPE_GROUP, IShare::TYPE_LINK], true],
+            [[IShare::TYPE_EMAIL, IShare::TYPE_REMOTE, IShare::TYPE_CIRCLE], true],
+            [[IShare::TYPE_GUEST, IShare::TYPE_REMOTE_GROUP, IShare::TYPE_ROOM], true],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('shareOwnerProvider')]
-	public function testHasActiveShares(array $existingShareTypes, bool $expected): void {
-		$shareMock = $this->createMock(IShare::class);
+    #[\PHPUnit\Framework\Attributes\DataProvider('shareOwnerProvider')]
+    public function testHasActiveShares(array $existingShareTypes, bool $expected): void {
+        $shareMock = $this->createMock(IShare::class);
 
-		$this->shareManager->expects($this->atLeastOnce())
-			->method('getSharesBy')
-			->willReturnCallback(function (string $uid, int $shareType) use ($existingShareTypes, $shareMock) {
-				if (in_array($shareType, $existingShareTypes)) {
-					return [$shareMock];
-				}
-				return [];
-			});
+        $this->shareManager->expects($this->atLeastOnce())
+            ->method('getSharesBy')
+            ->willReturnCallback(function (string $uid, int $shareType) use ($existingShareTypes, $shareMock) {
+                if (in_array($shareType, $existingShareTypes)) {
+                    return [$shareMock];
+                }
+                return [];
+            });
 
-		$this->assertSame($expected, $this->offlineUser->getHasActiveShares());
-	}
+        $this->assertSame($expected, $this->offlineUser->getHasActiveShares());
+    }
 }

apps/user_ldap/tests/ConfigurationTest.php

Indentation +104 added lines, -104 removed lines

@@ -11,108 +11,108 @@
 use OCA\User_LDAP\Configuration;
 
 class ConfigurationTest extends \Test\TestCase {
-	protected Configuration $configuration;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->configuration = new Configuration('t01', false);
-	}
-
-	public static function configurationDataProvider(): array {
-		$inputWithDN = [
-			'cn=someUsers,dc=example,dc=org',
-			'  ',
-			' cn=moreUsers,dc=example,dc=org '
-		];
-		$expectWithDN = [
-			'cn=someUsers,dc=example,dc=org',
-			'cn=moreUsers,dc=example,dc=org'
-		];
-
-		$inputNames = [
-			'  uid  ',
-			'cn ',
-			' ',
-			'',
-			' whats my name',
-			'	'
-		];
-		$expectedNames = ['uid', 'cn', 'whats my name'];
-
-		$inputString = ' alea iacta est ';
-		$expectedString = 'alea iacta est';
-
-		$inputHomeFolder = [
-			' homeDirectory ',
-			' attr:homeDirectory ',
-			' '
-		];
-
-		$expectedHomeFolder = [
-			'attr:homeDirectory', 'attr:homeDirectory', ''
-		];
-
-		$password = ' such a passw0rd ';
-
-		return [
-			'set general base' => ['ldapBase', $inputWithDN, $expectWithDN],
-			'set user base' => ['ldapBaseUsers', $inputWithDN, $expectWithDN],
-			'set group base' => ['ldapBaseGroups', $inputWithDN, $expectWithDN],
-
-			'set search attributes users' => ['ldapAttributesForUserSearch', $inputNames, $expectedNames],
-			'set search attributes groups' => ['ldapAttributesForGroupSearch', $inputNames, $expectedNames],
-
-			'set user filter objectclasses' => ['ldapUserFilterObjectclass', $inputNames, $expectedNames],
-			'set user filter groups' => ['ldapUserFilterGroups', $inputNames, $expectedNames],
-			'set group filter objectclasses' => ['ldapGroupFilterObjectclass', $inputNames, $expectedNames],
-			'set group filter groups' => ['ldapGroupFilterGroups', $inputNames, $expectedNames],
-			'set login filter attributes' => ['ldapLoginFilterAttributes', $inputNames, $expectedNames],
-
-			'set agent password' => ['ldapAgentPassword', $password, $password],
-
-			'set home folder, variant 1' => ['homeFolderNamingRule', $inputHomeFolder[0], $expectedHomeFolder[0]],
-			'set home folder, variant 2' => ['homeFolderNamingRule', $inputHomeFolder[1], $expectedHomeFolder[1]],
-			'set home folder, empty' => ['homeFolderNamingRule', $inputHomeFolder[2], $expectedHomeFolder[2]],
-
-			// default behaviour, one case is enough, special needs must be tested
-			// individually
-			'set string value' => ['ldapHost', $inputString, $expectedString],
-
-			'set avatar rule, default' => ['ldapUserAvatarRule', 'default', 'default'],
-			'set avatar rule, none' => ['ldapUserAvatarRule', 'none', 'none'],
-			'set avatar rule, data attribute' => ['ldapUserAvatarRule', 'data:jpegPhoto', 'data:jpegPhoto'],
-
-			'set external storage home attribute' => ['ldapExtStorageHomeAttribute', 'homePath', 'homePath'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('configurationDataProvider')]
-	public function testSetValue(string $key, string|array $input, string|array $expected): void {
-		$this->configuration->setConfiguration([$key => $input]);
-		$this->assertSame($this->configuration->$key, $expected);
-	}
-
-	public static function avatarRuleValueProvider(): array {
-		return [
-			['none', []],
-			['data:selfie', ['selfie']],
-			['data:sELFie', ['selfie']],
-			['data:', ['jpegphoto', 'thumbnailphoto']],
-			['default', ['jpegphoto', 'thumbnailphoto']],
-			['invalid#', ['jpegphoto', 'thumbnailphoto']],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('avatarRuleValueProvider')]
-	public function testGetAvatarAttributes(string $setting, array $expected): void {
-		$this->configuration->setConfiguration(['ldapUserAvatarRule' => $setting]);
-		$this->assertSame($expected, $this->configuration->getAvatarAttributes());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('avatarRuleValueProvider')]
-	public function testResolveRule(string $setting, array $expected): void {
-		$this->configuration->setConfiguration(['ldapUserAvatarRule' => $setting]);
-		// so far the only thing that can get resolved :)
-		$this->assertSame($expected, $this->configuration->resolveRule('avatar'));
-	}
+    protected Configuration $configuration;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->configuration = new Configuration('t01', false);
+    }
+
+    public static function configurationDataProvider(): array {
+        $inputWithDN = [
+            'cn=someUsers,dc=example,dc=org',
+            '  ',
+            ' cn=moreUsers,dc=example,dc=org '
+        ];
+        $expectWithDN = [
+            'cn=someUsers,dc=example,dc=org',
+            'cn=moreUsers,dc=example,dc=org'
+        ];
+
+        $inputNames = [
+            '  uid  ',
+            'cn ',
+            ' ',
+            '',
+            ' whats my name',
+            '	'
+        ];
+        $expectedNames = ['uid', 'cn', 'whats my name'];
+
+        $inputString = ' alea iacta est ';
+        $expectedString = 'alea iacta est';
+
+        $inputHomeFolder = [
+            ' homeDirectory ',
+            ' attr:homeDirectory ',
+            ' '
+        ];
+
+        $expectedHomeFolder = [
+            'attr:homeDirectory', 'attr:homeDirectory', ''
+        ];
+
+        $password = ' such a passw0rd ';
+
+        return [
+            'set general base' => ['ldapBase', $inputWithDN, $expectWithDN],
+            'set user base' => ['ldapBaseUsers', $inputWithDN, $expectWithDN],
+            'set group base' => ['ldapBaseGroups', $inputWithDN, $expectWithDN],
+
+            'set search attributes users' => ['ldapAttributesForUserSearch', $inputNames, $expectedNames],
+            'set search attributes groups' => ['ldapAttributesForGroupSearch', $inputNames, $expectedNames],
+
+            'set user filter objectclasses' => ['ldapUserFilterObjectclass', $inputNames, $expectedNames],
+            'set user filter groups' => ['ldapUserFilterGroups', $inputNames, $expectedNames],
+            'set group filter objectclasses' => ['ldapGroupFilterObjectclass', $inputNames, $expectedNames],
+            'set group filter groups' => ['ldapGroupFilterGroups', $inputNames, $expectedNames],
+            'set login filter attributes' => ['ldapLoginFilterAttributes', $inputNames, $expectedNames],
+
+            'set agent password' => ['ldapAgentPassword', $password, $password],
+
+            'set home folder, variant 1' => ['homeFolderNamingRule', $inputHomeFolder[0], $expectedHomeFolder[0]],
+            'set home folder, variant 2' => ['homeFolderNamingRule', $inputHomeFolder[1], $expectedHomeFolder[1]],
+            'set home folder, empty' => ['homeFolderNamingRule', $inputHomeFolder[2], $expectedHomeFolder[2]],
+
+            // default behaviour, one case is enough, special needs must be tested
+            // individually
+            'set string value' => ['ldapHost', $inputString, $expectedString],
+
+            'set avatar rule, default' => ['ldapUserAvatarRule', 'default', 'default'],
+            'set avatar rule, none' => ['ldapUserAvatarRule', 'none', 'none'],
+            'set avatar rule, data attribute' => ['ldapUserAvatarRule', 'data:jpegPhoto', 'data:jpegPhoto'],
+
+            'set external storage home attribute' => ['ldapExtStorageHomeAttribute', 'homePath', 'homePath'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('configurationDataProvider')]
+    public function testSetValue(string $key, string|array $input, string|array $expected): void {
+        $this->configuration->setConfiguration([$key => $input]);
+        $this->assertSame($this->configuration->$key, $expected);
+    }
+
+    public static function avatarRuleValueProvider(): array {
+        return [
+            ['none', []],
+            ['data:selfie', ['selfie']],
+            ['data:sELFie', ['selfie']],
+            ['data:', ['jpegphoto', 'thumbnailphoto']],
+            ['default', ['jpegphoto', 'thumbnailphoto']],
+            ['invalid#', ['jpegphoto', 'thumbnailphoto']],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('avatarRuleValueProvider')]
+    public function testGetAvatarAttributes(string $setting, array $expected): void {
+        $this->configuration->setConfiguration(['ldapUserAvatarRule' => $setting]);
+        $this->assertSame($expected, $this->configuration->getAvatarAttributes());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('avatarRuleValueProvider')]
+    public function testResolveRule(string $setting, array $expected): void {
+        $this->configuration->setConfiguration(['ldapUserAvatarRule' => $setting]);
+        // so far the only thing that can get resolved :)
+        $this->assertSame($expected, $this->configuration->resolveRule('avatar'));
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('configurationDataProvider')]
-	public function testSetValue(string $key, string|array $input, string|array $expected): void {
+	public function testSetValue(string $key, string | array $input, string | array $expected): void {
 		$this->configuration->setConfiguration([$key => $input]);
 		$this->assertSame($this->configuration->$key, $expected);
 	}

apps/user_ldap/tests/Service/BirthdateParserServiceTest.php

Indentation +35 added lines, -35 removed lines

@@ -13,39 +13,39 @@
 use PHPUnit\Framework\TestCase;
 
 class BirthdateParserServiceTest extends TestCase {
-	private BirthdateParserService $service;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->service = new BirthdateParserService();
-	}
-
-	public static function parseBirthdateDataProvider(): array {
-		return [
-			['2024-01-01', new DateTimeImmutable('2024-01-01'), false],
-			['20240101', new DateTimeImmutable('2024-01-01'), false],
-			['199412161032Z', new DateTimeImmutable('1994-12-16'), false], // LDAP generalized time
-			['199412160532-0500', new DateTimeImmutable('1994-12-16'), false], // LDAP generalized time
-			['2023-07-31T00:60:59.000Z', null, true],
-			['01.01.2024', null, true],
-			['01/01/2024', null, true],
-			['01 01 2024', null, true],
-			['foobar', null, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('parseBirthdateDataProvider')]
-	public function testParseBirthdate(
-		string $value,
-		?DateTimeImmutable $expected,
-		bool $shouldThrow,
-	): void {
-		if ($shouldThrow) {
-			$this->expectException(\InvalidArgumentException::class);
-		}
-
-		$actual = $this->service->parseBirthdate($value);
-		$this->assertEquals($expected, $actual);
-	}
+    private BirthdateParserService $service;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->service = new BirthdateParserService();
+    }
+
+    public static function parseBirthdateDataProvider(): array {
+        return [
+            ['2024-01-01', new DateTimeImmutable('2024-01-01'), false],
+            ['20240101', new DateTimeImmutable('2024-01-01'), false],
+            ['199412161032Z', new DateTimeImmutable('1994-12-16'), false], // LDAP generalized time
+            ['199412160532-0500', new DateTimeImmutable('1994-12-16'), false], // LDAP generalized time
+            ['2023-07-31T00:60:59.000Z', null, true],
+            ['01.01.2024', null, true],
+            ['01/01/2024', null, true],
+            ['01 01 2024', null, true],
+            ['foobar', null, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('parseBirthdateDataProvider')]
+    public function testParseBirthdate(
+        string $value,
+        ?DateTimeImmutable $expected,
+        bool $shouldThrow,
+    ): void {
+        if ($shouldThrow) {
+            $this->expectException(\InvalidArgumentException::class);
+        }
+
+        $actual = $this->service->parseBirthdate($value);
+        $this->assertEquals($expected, $actual);
+    }
 }

apps/user_ldap/tests/User_LDAPTest.php

Indentation +1424 added lines, -1424 removed lines

@@ -40,1428 +40,1428 @@
  * @package OCA\User_LDAP\Tests
  */
 class User_LDAPTest extends TestCase {
-	protected Access&MockObject $access;
-	protected OfflineUser&MockObject $offlineUser;
-	protected INotificationManager&MockObject $notificationManager;
-	protected UserPluginManager&MockObject $pluginManager;
-	protected Connection&MockObject $connection;
-	protected Manager&MockObject $userManager;
-	protected LoggerInterface&MockObject $logger;
-	protected DeletedUsersIndex&MockObject $deletedUsersIndex;
-	protected User_LDAP $backend;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		Server::get(IUserManager::class)->clearBackends();
-		Server::get(IGroupManager::class)->clearBackends();
-
-		$this->connection = $this->getMockBuilder(Connection::class)
-			->setConstructorArgs([$this->createMock(ILDAPWrapper::class)])
-			->getMock();
-		$this->userManager = $this->createMock(Manager::class);
-
-		$this->access = $this->createMock(Access::class);
-		$this->access->connection = $this->connection;
-		$this->access->userManager = $this->userManager;
-
-		$this->notificationManager = $this->createMock(INotificationManager::class);
-		$this->pluginManager = $this->createMock(UserPluginManager::class);
-
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->deletedUsersIndex = $this->createMock(DeletedUsersIndex::class);
-
-		$this->backend = new User_LDAP(
-			$this->access,
-			$this->notificationManager,
-			$this->pluginManager,
-			$this->logger,
-			$this->deletedUsersIndex,
-		);
-	}
-
-	private function prepareMockForUserExists(): void {
-		$this->access->expects($this->any())
-			->method('username2dn')
-			->willReturnCallback(function ($uid) {
-				switch ($uid) {
-					case 'gunslinger':
-						return 'dnOfRoland,dc=test';
-						break;
-					case 'formerUser':
-						return 'dnOfFormerUser,dc=test';
-						break;
-					case 'newyorker':
-						return 'dnOfNewYorker,dc=test';
-						break;
-					case 'ladyofshadows':
-						return 'dnOfLadyOfShadows,dc=test';
-						break;
-					default:
-						return false;
-				}
-			});
-
-		$this->access->method('fetchUsersByLoginName')
-			->willReturn([]);
-	}
-
-	/**
-	 * Prepares the Access mock for checkPassword tests
-	 */
-	private function prepareAccessForCheckPassword(bool $noDisplayName = false): void {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapLoginFilter') {
-					return '%uid';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
-				if ($filter === 'roland') {
-					return [['dn' => ['dnOfRoland,dc=test']]];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'roland') {
-					return [['dn' => ['dnOfRoland,dc=test']]];
-				}
-				return [];
-			});
-
-		$retVal = 'gunslinger';
-		if ($noDisplayName === true) {
-			$retVal = false;
-		}
-		$this->access->expects($this->any())
-			->method('dn2username')
-			->with($this->equalTo('dnOfRoland,dc=test'))
-			->willReturn($retVal);
-		$this->access->expects($this->any())
-			->method('username2dn')
-			->with($this->equalTo('gunslinger'))
-			->willReturn('dnOfRoland,dc=test');
-		$this->access->expects($this->any())
-			->method('stringResemblesDN')
-			->with($this->equalTo('dnOfRoland,dc=test'))
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('areCredentialsValid')
-			->willReturnCallback(function ($dn, $pwd) {
-				if ($pwd === 'dt19') {
-					return true;
-				}
-				return false;
-			});
-
-		$this->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['dn', 'uid', 'mail', 'displayname']);
-	}
-
-	public function testCheckPasswordUidReturn(): void {
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('gunslinger');
-
-		$this->prepareAccessForCheckPassword();
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($user);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $backend->checkPassword('roland', 'dt19');
-		$this->assertEquals('gunslinger', $result);
-	}
-
-	public function testCheckPasswordWrongPassword(): void {
-		$this->prepareAccessForCheckPassword();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $backend->checkPassword('roland', 'wrong');
-		$this->assertFalse($result);
-	}
-
-	public function testCheckPasswordWrongUser(): void {
-		$this->prepareAccessForCheckPassword();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $backend->checkPassword('mallory', 'evil');
-		$this->assertFalse($result);
-	}
-
-	public function testCheckPasswordNoDisplayName(): void {
-		$this->prepareAccessForCheckPassword(true);
-
-		$this->prepareAccessForCheckPassword();
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->willReturn(null);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $backend->checkPassword('roland', 'dt19');
-		$this->assertFalse($result);
-	}
-
-	public function testCheckPasswordPublicAPI(): void {
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('gunslinger');
-
-		$this->prepareAccessForCheckPassword();
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($user);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$user = Server::get(IUserManager::class)->checkPassword('roland', 'dt19');
-		$result = false;
-		if ($user !== false) {
-			$result = $user->getUID();
-		}
-		$this->assertEquals('gunslinger', $result);
-	}
-
-	public function testCheckPasswordPublicAPIWrongPassword(): void {
-		$this->prepareAccessForCheckPassword();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$user = Server::get(IUserManager::class)->checkPassword('roland', 'wrong');
-		$result = false;
-		if ($user !== false) {
-			$result = $user->getUID();
-		}
-		$this->assertFalse($result);
-	}
-
-	public function testCheckPasswordPublicAPIWrongUser(): void {
-		$this->prepareAccessForCheckPassword();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$user = Server::get(IUserManager::class)->checkPassword('mallory', 'evil');
-		$result = false;
-		if ($user !== false) {
-			$result = $user->getUID();
-		}
-		$this->assertFalse($result);
-	}
-
-	public function testDeleteUserCancel(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$result = $backend->deleteUser('notme');
-		$this->assertFalse($result);
-	}
-
-	public function testDeleteUserSuccess(): void {
-		$uid = 'jeremy';
-		$home = '/var/vhome/jdings/';
-
-		$mapping = $this->createMock(UserMapping::class);
-		$mapping->expects($this->once())
-			->method('unmap')
-			->willReturn(true);
-		$this->access->expects($this->once())
-			->method('getUserMapper')
-			->willReturn($mapping);
-		$this->connection->expects($this->any())
-			->method('getConnectionResource')
-			->willReturn(ldap_connect('ldap://example.com'));
-
-		$this->deletedUsersIndex->expects($this->once())
-			->method('isUserMarked')
-			->with($uid)
-			->willReturn(true);
-
-		$offlineUser = $this->createMock(OfflineUser::class);
-		$offlineUser->expects($this->once())
-			->method('getHomePath')
-			->willReturn($home);
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->willReturn($offlineUser);
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with($uid)
-			->willReturn(true);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->deleteUser($uid);
-		$this->assertTrue($result);
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertSame($backend->getHome($uid), $home);
-	}
-
-	public function testDeleteUserWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('canDeleteUser')
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('deleteUser')
-			->with('uid')
-			->willReturn(true);
-
-		$this->deletedUsersIndex->expects($this->once())
-			->method('isUserMarked')
-			->with('uid')
-			->willReturn(true);
-
-		$mapper = $this->createMock(UserMapping::class);
-		$mapper->expects($this->once())
-			->method('unmap')
-			->with('uid');
-
-		$this->access->expects($this->atLeastOnce())
-			->method('getUserMapper')
-			->willReturn($mapper);
-
-		$this->userManager->expects($this->once())
-			->method('invalidate')
-			->with('uid');
-
-		$this->assertTrue($this->backend->deleteUser('uid'));
-	}
-
-	/**
-	 * Prepares the Access mock for getUsers tests
-	 */
-	private function prepareAccessForGetUsers() {
-		$this->access->expects($this->once())
-			->method('escapeFilterPart')
-			->willReturnCallback(function ($search) {
-				return $search;
-			});
-		$this->access->expects($this->any())
-			->method('getFilterPartForUserSearch')
-			->willReturnCallback(function ($search) {
-				return $search;
-			});
-		$this->access->expects($this->any())
-			->method('combineFilterWithAnd')
-			->willReturnCallback(function ($param) {
-				return $param[2];
-			});
-		$this->access->expects($this->any())
-			->method('fetchListOfUsers')
-			->willReturnCallback(function ($search, $a, $l, $o) {
-				$users = ['gunslinger', 'newyorker', 'ladyofshadows'];
-				if (empty($search)) {
-					$result = $users;
-				} else {
-					$result = [];
-					foreach ($users as $user) {
-						if (stripos($user, $search) !== false) {
-							$result[] = $user;
-						}
-					}
-				}
-				if (!is_null($l) || !is_null($o)) {
-					$result = array_slice($result, $o, $l);
-				}
-				return $result;
-			});
-		$this->access->expects($this->any())
-			->method('nextcloudUserNames')
-			->willReturnArgument(0);
-		$this->access->method('fetchUsersByLoginName')
-			->willReturn([]);
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['dn', 'uid', 'mail', 'displayname']);
-	}
-
-	public function testGetUsersNoParam(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->getUsers();
-		$this->assertCount(3, $result);
-	}
-
-	public function testGetUsersLimitOffset(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->getUsers('', 1, 2);
-		$this->assertCount(1, $result);
-	}
-
-	public function testGetUsersLimitOffset2(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->getUsers('', 2, 1);
-		$this->assertCount(2, $result);
-	}
-
-	public function testGetUsersSearchWithResult(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->getUsers('yo');
-		$this->assertCount(2, $result);
-	}
-
-	public function testGetUsersSearchEmptyResult(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->getUsers('nix');
-		$this->assertCount(0, $result);
-	}
-
-	private function getUsers($search = '', $limit = null, $offset = null) {
-		$users = Server::get(IUserManager::class)->search($search, $limit, $offset);
-		$uids = array_map(function (IUser $user) {
-			return $user->getUID();
-		}, $users);
-		return $uids;
-	}
-
-	public function testGetUsersViaAPINoParam(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $this->getUsers();
-		$this->assertCount(3, $result);
-	}
-
-	public function testGetUsersViaAPILimitOffset(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $this->getUsers('', 1, 2);
-		$this->assertCount(1, $result);
-	}
-
-	public function testGetUsersViaAPILimitOffset2(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $this->getUsers('', 2, 1);
-		$this->assertCount(2, $result);
-	}
-
-	public function testGetUsersViaAPISearchWithResult(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $this->getUsers('yo');
-		$this->assertCount(2, $result);
-	}
-
-	public function testGetUsersViaAPISearchEmptyResult(): void {
-		$this->prepareAccessForGetUsers();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$result = $this->getUsers('nix');
-		$this->assertCount(0, $result);
-	}
-
-	public function testUserExists(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->userManager->expects($this->never())
-			->method('get');
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('gunslinger')
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($this->createMock(UserMapping::class));
-
-		//test for existing user
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$result = $backend->userExists('gunslinger');
-		$this->assertTrue($result);
-	}
-
-	public function testUserExistsForDeleted(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$mapper = $this->createMock(UserMapping::class);
-		$mapper->expects($this->any())
-			->method('getUUIDByDN')
-			->with('dnOfFormerUser,dc=test')
-			->willReturn('45673458748');
-
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($mapper);
-
-		$this->userManager->expects($this->never())
-			->method('get');
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('formerUser')
-			->willReturn(true);
-
-		//test for deleted user – always returns true as long as we have the user in DB
-		$this->assertTrue($backend->userExists('formerUser'));
-	}
-
-	public function testUserExistsForNeverExisting(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
-				if ($dn === 'dnOfRoland,dc=test') {
-					return [];
-				}
-				return false;
-			});
-
-		//test for never-existing user
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$result = $backend->userExists('mallory');
-		$this->assertFalse($result);
-	}
-
-	public function testUserExistsPublicAPI(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getDN')
-			->willReturn('dnOfRoland,dc=test');
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
-				if ($dn === 'dnOfRoland,dc=test') {
-					return [];
-				}
-				return false;
-			});
-		$this->userManager->expects($this->never())
-			->method('get');
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('gunslinger')
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($this->createMock(UserMapping::class));
-
-		//test for existing user
-		$result = Server::get(IUserManager::class)->userExists('gunslinger');
-		$this->assertTrue($result);
-	}
-
-	public function testDeleteUserExisting(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		//we do not support deleting existing users at all
-		$result = $backend->deleteUser('gunslinger');
-		$this->assertFalse($result);
-	}
-
-	public function testGetHomeAbsolutePath(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'homeFolderNamingRule') {
-					return 'attr:testAttribute';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				switch ($dn) {
-					case 'dnOfRoland,dc=test':
-						if ($attr === 'testAttribute') {
-							return ['/tmp/rolandshome/'];
-						}
-						return [];
-						break;
-					default:
-						return false;
-				}
-			});
-
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('gunslinger');
-		$user->expects($this->any())
-			->method('getDN')
-			->willReturn('dnOfRoland,dc=test');
-		$user->expects($this->any())
-			->method('getHomePath')
-			->willReturn('/tmp/rolandshome/');
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->with('gunslinger')
-			->willReturn($user);
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('gunslinger')
-			->willReturn(true);
-
-		//absolute path
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$result = $backend->getHome('gunslinger');
-		$this->assertEquals('/tmp/rolandshome/', $result);
-	}
-
-	public function testGetHomeRelative(): void {
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$dataDir = Server::get(IConfig::class)->getSystemValue(
-			'datadirectory', \OC::$SERVERROOT . '/data');
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'homeFolderNamingRule') {
-					return 'attr:testAttribute';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				switch ($dn) {
-					case 'dnOfLadyOfShadows,dc=test':
-						if ($attr === 'testAttribute') {
-							return ['susannah/'];
-						}
-						return [];
-						break;
-					default:
-						return false;
-				}
-			});
-
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('ladyofshadows');
-		$user->expects($this->any())
-			->method('getDN')
-			->willReturn('dnOfLadyOfShadows,dc=test');
-		$user->expects($this->any())
-			->method('getHomePath')
-			->willReturn($dataDir . '/susannah/');
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->willReturn($user);
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('ladyofshadows')
-			->willReturn(true);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$result = $backend->getHome('ladyofshadows');
-		$this->assertEquals($dataDir . '/susannah/', $result);
-	}
-
-
-	public function testGetHomeNoPath(): void {
-		$this->expectException(\Exception::class);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'homeFolderNamingRule') {
-					return 'attr:testAttribute';
-				}
-				return null;
-			});
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				switch ($dn) {
-					default:
-						return false;
-				}
-			});
-
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('newyorker');
-		$user->expects($this->any())
-			->method('getHomePath')
-			->willThrowException(new \Exception());
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->with('newyorker')
-			->willReturn($user);
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with('newyorker')
-			->willReturn(true);
-
-		//no path at all – triggers OC default behaviour
-		$result = $backend->getHome('newyorker');
-		$this->assertFalse($result);
-	}
-
-	public function testGetHomeDeletedUser(): void {
-		$uid = 'newyorker';
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'homeFolderNamingRule') {
-					return 'attr:testAttribute';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturn([]);
-
-		$userMapper = $this->createMock(UserMapping::class);
-
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($userMapper);
-
-		$offlineUser = $this->createMock(OfflineUser::class);
-		$offlineUser->expects($this->atLeastOnce())
-			->method('getHomePath')
-			->willReturn('');
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->with($uid)
-			->willReturn($offlineUser);
-		$this->userManager->expects($this->once())
-			->method('exists')
-			->with($uid)
-			->willReturn(true);
-
-		$result = $backend->getHome($uid);
-		$this->assertFalse($result);
-	}
-
-	public function testGetHomeWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::GET_HOME)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('getHome')
-			->with('uid')
-			->willReturn('result');
-
-		$this->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
-				return true;
-			});
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertEquals($this->backend->getHome('uid'), 'result');
-	}
-
-	private function prepareAccessForGetDisplayName() {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapUserDisplayName') {
-					return 'displayname';
-				} elseif ($name === 'ldapUserDisplayName2') {
-					return 'displayname2';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				switch ($dn) {
-					case 'dnOfRoland,dc=test':
-						if ($attr === 'displayname') {
-							return ['Roland Deschain'];
-						}
-						return [];
-						break;
-
-					default:
-						return false;
-				}
-			});
-		$this->access->method('fetchUsersByLoginName')
-			->willReturn([]);
-	}
-
-	public function testGetDisplayName(): void {
-		$this->prepareAccessForGetDisplayName();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->connection->expects($this->any())
-			->method('getConnectionResource')
-			->willReturnCallback(function () {
-				return true;
-			});
-
-		$user1 = $this->createMock(User::class);
-		$user1->expects($this->once())
-			->method('composeAndStoreDisplayName')
-			->willReturn('Roland Deschain');
-		$user1->expects($this->any())
-			->method('getDN')
-			->willReturn('dnOfRoland,dc=test');
-
-		$user2 = $this->createMock(User::class);
-		$user2->expects($this->never())
-			->method('composeAndStoreDisplayName');
-		$user2->expects($this->any())
-			->method('getDN')
-			->willReturn('another DN');
-
-		$mapper = $this->createMock(UserMapping::class);
-		$mapper->expects($this->any())
-			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
-				return $dn;
-			});
-
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
-				if ($uid === 'gunslinger') {
-					return $user1;
-				} elseif ($uid === 'newyorker') {
-					return $user2;
-				}
-				return null;
-			});
-		$this->userManager->expects($this->any())
-			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
-				if ($uid === 'gunslinger') {
-					return true;
-				} elseif ($uid === 'newyorker') {
-					return true;
-				}
-				return false;
-			});
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($mapper);
-		$this->access->expects($this->any())
-			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
-			});
-
-		//with displayName
-		$result = $backend->getDisplayName('gunslinger');
-		$this->assertEquals('Roland Deschain', $result);
-
-		//empty displayname retrieved
-		$result = $backend->getDisplayName('newyorker');
-		$this->assertEquals(null, $result);
-	}
-
-	public function testGetDisplayNamePublicAPI(): void {
-		$this->access->expects($this->any())
-			->method('username2dn')
-			->willReturnCallback(function ($uid) {
-				switch ($uid) {
-					case 'gunslinger':
-						return 'dnOfRoland,dc=test';
-						break;
-					case 'formerUser':
-						return 'dnOfFormerUser,dc=test';
-						break;
-					case 'newyorker':
-						return 'dnOfNewYorker,dc=test';
-						break;
-					case 'ladyofshadows':
-						return 'dnOfLadyOfShadows,dc=test';
-						break;
-					default:
-						return false;
-				}
-			});
-		$this->prepareAccessForGetDisplayName();
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->prepareMockForUserExists();
-
-		$this->connection->expects($this->any())
-			->method('getConnectionResource')
-			->willReturnCallback(function () {
-				return true;
-			});
-
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$user1 = $this->createMock(User::class);
-		$user1->expects($this->once())
-			->method('composeAndStoreDisplayName')
-			->willReturn('Roland Deschain');
-		$user1->expects($this->any())
-			->method('getDN')
-			->willReturn('dnOfRoland,dc=test');
-
-		$user2 = $this->createMock(User::class);
-		$user2->expects($this->never())
-			->method('composeAndStoreDisplayName');
-		$user2->expects($this->any())
-			->method('getDN')
-			->willReturn('another DN');
-
-		$mapper = $this->createMock(UserMapping::class);
-		$mapper->expects($this->any())
-			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
-				return $dn;
-			});
-
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
-				if ($uid === 'gunslinger') {
-					return $user1;
-				} elseif ($uid === 'newyorker') {
-					return $user2;
-				}
-				return null;
-			});
-		$this->userManager->expects($this->any())
-			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
-				if ($uid === 'gunslinger') {
-					return true;
-				} elseif ($uid === 'newyorker') {
-					return true;
-				}
-				return false;
-			});
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($mapper);
-		$this->access->expects($this->any())
-			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
-			});
-
-		//with displayName
-		$result = Server::get(IUserManager::class)->get('gunslinger')?->getDisplayName();
-		$this->assertEquals('Roland Deschain', $result);
-
-		//empty displayname retrieved
-		$result = Server::get(IUserManager::class)->get('newyorker') === null ? 'newyorker' : Server::get(IUserManager::class)->get('newyorker')->getDisplayName();
-		$this->assertEquals('newyorker', $result);
-	}
-
-	public function testGetDisplayNameWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::GET_DISPLAYNAME)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('getDisplayName')
-			->with('uid')
-			->willReturn('result');
-
-		$this->assertEquals($this->backend->getDisplayName('uid'), 'result');
-	}
-
-	//no test for getDisplayNames, because it just invokes getUsers and
-	//getDisplayName
-
-	public function testCountUsers(): void {
-		$this->access->expects($this->once())
-			->method('countUsers')
-			->willReturn(5);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->countUsers();
-		$this->assertEquals(5, $result);
-	}
-
-	public function testCountUsersFailing(): void {
-		$this->access->expects($this->once())
-			->method('countUsers')
-			->willReturn(false);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-
-		$result = $backend->countUsers();
-		$this->assertFalse($result);
-	}
-
-	public function testCountUsersWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::COUNT_USERS)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('countUsers')
-			->willReturn(42);
-
-		$this->assertEquals($this->backend->countUsers(), 42);
-	}
-
-	public function testLoginName2UserNameSuccess(): void {
-		$loginName = 'Alice';
-		$username = 'alice';
-		$dn = 'uid=alice,dc=what,dc=ever';
-
-		$this->access->expects($this->once())
-			->method('fetchUsersByLoginName')
-			->with($this->equalTo($loginName))
-			->willReturn([['dn' => [$dn]]]);
-		$this->access->expects($this->any())
-			->method('stringResemblesDN')
-			->with($this->equalTo($dn))
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('dn2username')
-			->with($this->equalTo($dn))
-			->willReturn($username);
-
-		$this->connection->expects($this->exactly(2))
-			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
-			->willReturnOnConsecutiveCalls(null, $username);
-		$this->connection->expects($this->once())
-			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo($username));
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$user = $this->createMock(User::class);
-		$user->expects($this->any())
-			->method('getUsername')
-			->willReturn('alice');
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->with($dn)
-			->willReturn($user);
-		$this->userManager->expects($this->never())
-			->method('exists');
-		$this->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['dn', 'uid', 'mail', 'displayname']);
-
-		$name = $backend->loginName2UserName($loginName);
-		$this->assertSame($username, $name);
-
-		// and once again to verify that caching works
-		$backend->loginName2UserName($loginName);
-	}
-
-	public function testLoginName2UserNameNoUsersOnLDAP(): void {
-		$loginName = 'Loki';
-
-		$this->access->expects($this->once())
-			->method('fetchUsersByLoginName')
-			->with($this->equalTo($loginName))
-			->willReturn([]);
-		$this->access->expects($this->never())
-			->method('stringResemblesDN');
-		$this->access->expects($this->never())
-			->method('dn2username');
-
-		$this->connection->expects($this->exactly(2))
-			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
-			->willReturnOnConsecutiveCalls(null, false);
-		$this->connection->expects($this->once())
-			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), false);
-
-		$this->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['dn', 'uid', 'mail', 'displayname']);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$name = $backend->loginName2UserName($loginName);
-		$this->assertSame(false, $name);
-
-		// and once again to verify that caching works
-		$backend->loginName2UserName($loginName);
-	}
-
-	public function testLoginName2UserNameOfflineUser(): void {
-		$loginName = 'Alice';
-		$dn = 'uid=alice,dc=what,dc=ever';
-
-		$offlineUser = $this->getMockBuilder(OfflineUser::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->access->expects($this->once())
-			->method('fetchUsersByLoginName')
-			->with($this->equalTo($loginName))
-			->willReturn([['dn' => [$dn]]]);
-
-		$this->connection->expects($this->exactly(2))
-			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
-			->willReturnOnConsecutiveCalls(null, false);
-		$this->connection->expects($this->once())
-			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo(false));
-
-		$this->userManager->expects($this->any())
-			->method('get')
-			->with($dn)
-			->willReturn($offlineUser);
-		$this->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['dn', 'uid', 'mail', 'displayname']);
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$name = $backend->loginName2UserName($loginName);
-		$this->assertSame(false, $name);
-
-		// and once again to verify that caching works
-		$backend->loginName2UserName($loginName);
-	}
-
-	/**
-	 * Prepares the Access mock for setPassword tests
-	 */
-	private function prepareAccessForSetPassword($enablePasswordChange = true) {
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) use (&$enablePasswordChange) {
-				if ($name === 'ldapLoginFilter') {
-					return '%uid';
-				}
-				if ($name === 'turnOnPasswordChange') {
-					return $enablePasswordChange?1:0;
-				}
-				return null;
-			});
-		$this->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'userExists' . 'roland') {
-					return true;
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
-				if ($filter === 'roland') {
-					return [['dn' => ['dnOfRoland,dc=test']]];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'roland') {
-					return [['dn' => ['dnOfRoland,dc=test']]];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('dn2username')
-			->with($this->equalTo('dnOfRoland,dc=test'))
-			->willReturn('roland');
-		$this->access->expects($this->any())
-			->method('stringResemblesDN')
-			->with($this->equalTo('dnOfRoland,dc=test'))
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('setPassword')
-			->willReturnCallback(function ($uid, $password) {
-				if (strlen($password) <= 5) {
-					throw new HintException('Password fails quality checking policy', '', 19);
-				}
-				return true;
-			});
-	}
-
-
-	public function testSetPasswordInvalid(): void {
-		$this->expectException(HintException::class);
-		$this->expectExceptionMessage('Password fails quality checking policy');
-
-		$this->prepareAccessForSetPassword($this->access);
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->willReturn($this->createMock(User::class));
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$this->assertTrue(\OC_User::setPassword('roland', 'dt'));
-	}
-
-	public function testSetPasswordValid(): void {
-		$this->prepareAccessForSetPassword($this->access);
-
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($this->createMock(User::class));
-
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($this->createMock(User::class));
-
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$this->assertTrue(\OC_User::setPassword('roland', 'dt12234$'));
-	}
-
-	public function testSetPasswordValidDisabled(): void {
-		$this->userManager->expects($this->any())
-			->method('get')
-			->willReturn($this->createMock(User::class));
-
-		$this->prepareAccessForSetPassword(false);
-		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
-		Server::get(IUserManager::class)->registerBackend($backend);
-
-		$this->assertFalse(\OC_User::setPassword('roland', 'dt12234$'));
-	}
-
-
-	public function testSetPasswordWithInvalidUser(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('LDAP setPassword: Could not get user object for uid NotExistingUser. Maybe the LDAP entry has no set display name attribute?');
-
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('NotExistingUser')
-			->willReturn(null);
-
-		$this->backend->setPassword('NotExistingUser', 'Password');
-	}
-
-	public function testSetPasswordWithUsernameFalse(): void {
-		$user = $this->createMock(User::class);
-		$user
-			->expects($this->once())
-			->method('getUsername')
-			->willReturn(false);
-		$this->userManager
-			->expects($this->once())
-			->method('get')
-			->with('NotExistingUser')
-			->willReturn($user);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertFalse($this->backend->setPassword('NotExistingUser', 'Password'));
-	}
-
-	public function testSetPasswordWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::SET_PASSWORD)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('setPassword')
-			->with('uid', 'password')
-			->willReturn('result');
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertEquals($this->backend->setPassword('uid', 'password'), 'result');
-	}
-
-	public static function avatarDataProvider(): array {
-		return [
-			[ 'validImageData', false ],
-			[ 'corruptImageData', true ],
-			[ false, true]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('avatarDataProvider')]
-	public function testCanChangeAvatar(string|bool $imageData, bool $expected): void {
-		$isValidImage = str_starts_with((string)$imageData, 'valid');
-
-		$user = $this->createMock(User::class);
-		$user->expects($this->once())
-			->method('getAvatarImage')
-			->willReturn($imageData);
-		$user->expects($this->atMost(1))
-			->method('updateAvatar')
-			->willReturn($isValidImage);
-
-		$this->userManager->expects($this->atLeastOnce())
-			->method('get')
-			->willReturn($user);
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->assertSame($expected, $this->backend->canChangeAvatar('uid'));
-	}
-
-	public function testCanChangeAvatarWithPlugin(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::PROVIDE_AVATAR)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('canChangeAvatar')
-			->with('uid')
-			->willReturn('result');
-
-		$this->assertEquals($this->backend->canChangeAvatar('uid'), 'result');
-	}
-
-	public function testSetDisplayNameWithPlugin(): void {
-		$newDisplayName = 'J. Baker';
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::SET_DISPLAYNAME)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('setDisplayName')
-			->with('uid', $newDisplayName)
-			->willReturn($newDisplayName);
-		$this->access->expects($this->once())
-			->method('cacheUserDisplayName');
-
-		$this->assertEquals($newDisplayName, $this->backend->setDisplayName('uid', $newDisplayName));
-	}
-
-
-	public function testSetDisplayNameErrorWithPlugin(): void {
-		$this->expectException(HintException::class);
-
-		$newDisplayName = 'J. Baker';
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::SET_DISPLAYNAME)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('setDisplayName')
-			->with('uid', $newDisplayName)
-			->willThrowException(new HintException('something happned'));
-		$this->access->expects($this->never())
-			->method('cacheUserDisplayName');
-
-		$this->backend->setDisplayName('uid', $newDisplayName);
-	}
-
-	public function testSetDisplayNameFailing(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::SET_DISPLAYNAME)
-			->willReturn(false);
-		$this->access->expects($this->never())
-			->method('cacheUserDisplayName');
-
-		$this->assertFalse($this->backend->setDisplayName('uid', 'displayName'));
-	}
-
-	public function testCreateUserWithPlugin(): void {
-		$uid = 'alien6372';
-		$uuid = '123-2345-36756-123-2345234-4431';
-		$pwd = 'passwørd';
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::CREATE_USER)
-			->willReturn(true);
-		$this->pluginManager->expects($this->once())
-			->method('createUser')
-			->with($uid, $pwd)
-			->willReturn('result');
-
-		$this->access->expects($this->atLeastOnce())
-			->method('getUUID')
-			->willReturn($uuid);
-		$this->access->expects($this->once())
-			->method('mapAndAnnounceIfApplicable')
-			->with($this->isInstanceOf(AbstractMapping::class), $this->anything(), $uid, $uuid, true);
-		$this->access->expects($this->any())
-			->method('getUserMapper')
-			->willReturn($this->createMock(UserMapping::class));
-
-		$this->assertEquals($this->backend->createUser($uid, $pwd), true);
-	}
-
-	public function testCreateUserFailing(): void {
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(Backend::CREATE_USER)
-			->willReturn(false);
-
-		$this->assertFalse($this->backend->createUser('uid', 'password'));
-	}
-
-	public static function actionProvider(): array {
-		return [
-			[ 'ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
-			[ 'turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
-			[ 'turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('actionProvider')]
-	public function testImplementsAction(string $configurable, string|int $value, int $actionCode, bool $expected): void {
-		$this->pluginManager->expects($this->once())
-			->method('getImplementedActions')
-			->willReturn(0);
-
-		$this->connection->expects($this->any())
-			->method('__get')
-			->willReturnMap([
-				[$configurable, $value],
-			]);
-
-		$this->assertSame($expected, $this->backend->implementsActions($actionCode));
-	}
+    protected Access&MockObject $access;
+    protected OfflineUser&MockObject $offlineUser;
+    protected INotificationManager&MockObject $notificationManager;
+    protected UserPluginManager&MockObject $pluginManager;
+    protected Connection&MockObject $connection;
+    protected Manager&MockObject $userManager;
+    protected LoggerInterface&MockObject $logger;
+    protected DeletedUsersIndex&MockObject $deletedUsersIndex;
+    protected User_LDAP $backend;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        Server::get(IUserManager::class)->clearBackends();
+        Server::get(IGroupManager::class)->clearBackends();
+
+        $this->connection = $this->getMockBuilder(Connection::class)
+            ->setConstructorArgs([$this->createMock(ILDAPWrapper::class)])
+            ->getMock();
+        $this->userManager = $this->createMock(Manager::class);
+
+        $this->access = $this->createMock(Access::class);
+        $this->access->connection = $this->connection;
+        $this->access->userManager = $this->userManager;
+
+        $this->notificationManager = $this->createMock(INotificationManager::class);
+        $this->pluginManager = $this->createMock(UserPluginManager::class);
+
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->deletedUsersIndex = $this->createMock(DeletedUsersIndex::class);
+
+        $this->backend = new User_LDAP(
+            $this->access,
+            $this->notificationManager,
+            $this->pluginManager,
+            $this->logger,
+            $this->deletedUsersIndex,
+        );
+    }
+
+    private function prepareMockForUserExists(): void {
+        $this->access->expects($this->any())
+            ->method('username2dn')
+            ->willReturnCallback(function ($uid) {
+                switch ($uid) {
+                    case 'gunslinger':
+                        return 'dnOfRoland,dc=test';
+                        break;
+                    case 'formerUser':
+                        return 'dnOfFormerUser,dc=test';
+                        break;
+                    case 'newyorker':
+                        return 'dnOfNewYorker,dc=test';
+                        break;
+                    case 'ladyofshadows':
+                        return 'dnOfLadyOfShadows,dc=test';
+                        break;
+                    default:
+                        return false;
+                }
+            });
+
+        $this->access->method('fetchUsersByLoginName')
+            ->willReturn([]);
+    }
+
+    /**
+     * Prepares the Access mock for checkPassword tests
+     */
+    private function prepareAccessForCheckPassword(bool $noDisplayName = false): void {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapLoginFilter') {
+                    return '%uid';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('fetchListOfUsers')
+            ->willReturnCallback(function ($filter) {
+                if ($filter === 'roland') {
+                    return [['dn' => ['dnOfRoland,dc=test']]];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('fetchUsersByLoginName')
+            ->willReturnCallback(function ($uid) {
+                if ($uid === 'roland') {
+                    return [['dn' => ['dnOfRoland,dc=test']]];
+                }
+                return [];
+            });
+
+        $retVal = 'gunslinger';
+        if ($noDisplayName === true) {
+            $retVal = false;
+        }
+        $this->access->expects($this->any())
+            ->method('dn2username')
+            ->with($this->equalTo('dnOfRoland,dc=test'))
+            ->willReturn($retVal);
+        $this->access->expects($this->any())
+            ->method('username2dn')
+            ->with($this->equalTo('gunslinger'))
+            ->willReturn('dnOfRoland,dc=test');
+        $this->access->expects($this->any())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo('dnOfRoland,dc=test'))
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('areCredentialsValid')
+            ->willReturnCallback(function ($dn, $pwd) {
+                if ($pwd === 'dt19') {
+                    return true;
+                }
+                return false;
+            });
+
+        $this->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['dn', 'uid', 'mail', 'displayname']);
+    }
+
+    public function testCheckPasswordUidReturn(): void {
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('gunslinger');
+
+        $this->prepareAccessForCheckPassword();
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($user);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $backend->checkPassword('roland', 'dt19');
+        $this->assertEquals('gunslinger', $result);
+    }
+
+    public function testCheckPasswordWrongPassword(): void {
+        $this->prepareAccessForCheckPassword();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $backend->checkPassword('roland', 'wrong');
+        $this->assertFalse($result);
+    }
+
+    public function testCheckPasswordWrongUser(): void {
+        $this->prepareAccessForCheckPassword();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $backend->checkPassword('mallory', 'evil');
+        $this->assertFalse($result);
+    }
+
+    public function testCheckPasswordNoDisplayName(): void {
+        $this->prepareAccessForCheckPassword(true);
+
+        $this->prepareAccessForCheckPassword();
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturn(null);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $backend->checkPassword('roland', 'dt19');
+        $this->assertFalse($result);
+    }
+
+    public function testCheckPasswordPublicAPI(): void {
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('gunslinger');
+
+        $this->prepareAccessForCheckPassword();
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($user);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $user = Server::get(IUserManager::class)->checkPassword('roland', 'dt19');
+        $result = false;
+        if ($user !== false) {
+            $result = $user->getUID();
+        }
+        $this->assertEquals('gunslinger', $result);
+    }
+
+    public function testCheckPasswordPublicAPIWrongPassword(): void {
+        $this->prepareAccessForCheckPassword();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $user = Server::get(IUserManager::class)->checkPassword('roland', 'wrong');
+        $result = false;
+        if ($user !== false) {
+            $result = $user->getUID();
+        }
+        $this->assertFalse($result);
+    }
+
+    public function testCheckPasswordPublicAPIWrongUser(): void {
+        $this->prepareAccessForCheckPassword();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $user = Server::get(IUserManager::class)->checkPassword('mallory', 'evil');
+        $result = false;
+        if ($user !== false) {
+            $result = $user->getUID();
+        }
+        $this->assertFalse($result);
+    }
+
+    public function testDeleteUserCancel(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $result = $backend->deleteUser('notme');
+        $this->assertFalse($result);
+    }
+
+    public function testDeleteUserSuccess(): void {
+        $uid = 'jeremy';
+        $home = '/var/vhome/jdings/';
+
+        $mapping = $this->createMock(UserMapping::class);
+        $mapping->expects($this->once())
+            ->method('unmap')
+            ->willReturn(true);
+        $this->access->expects($this->once())
+            ->method('getUserMapper')
+            ->willReturn($mapping);
+        $this->connection->expects($this->any())
+            ->method('getConnectionResource')
+            ->willReturn(ldap_connect('ldap://example.com'));
+
+        $this->deletedUsersIndex->expects($this->once())
+            ->method('isUserMarked')
+            ->with($uid)
+            ->willReturn(true);
+
+        $offlineUser = $this->createMock(OfflineUser::class);
+        $offlineUser->expects($this->once())
+            ->method('getHomePath')
+            ->willReturn($home);
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturn($offlineUser);
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with($uid)
+            ->willReturn(true);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->deleteUser($uid);
+        $this->assertTrue($result);
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertSame($backend->getHome($uid), $home);
+    }
+
+    public function testDeleteUserWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('canDeleteUser')
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('deleteUser')
+            ->with('uid')
+            ->willReturn(true);
+
+        $this->deletedUsersIndex->expects($this->once())
+            ->method('isUserMarked')
+            ->with('uid')
+            ->willReturn(true);
+
+        $mapper = $this->createMock(UserMapping::class);
+        $mapper->expects($this->once())
+            ->method('unmap')
+            ->with('uid');
+
+        $this->access->expects($this->atLeastOnce())
+            ->method('getUserMapper')
+            ->willReturn($mapper);
+
+        $this->userManager->expects($this->once())
+            ->method('invalidate')
+            ->with('uid');
+
+        $this->assertTrue($this->backend->deleteUser('uid'));
+    }
+
+    /**
+     * Prepares the Access mock for getUsers tests
+     */
+    private function prepareAccessForGetUsers() {
+        $this->access->expects($this->once())
+            ->method('escapeFilterPart')
+            ->willReturnCallback(function ($search) {
+                return $search;
+            });
+        $this->access->expects($this->any())
+            ->method('getFilterPartForUserSearch')
+            ->willReturnCallback(function ($search) {
+                return $search;
+            });
+        $this->access->expects($this->any())
+            ->method('combineFilterWithAnd')
+            ->willReturnCallback(function ($param) {
+                return $param[2];
+            });
+        $this->access->expects($this->any())
+            ->method('fetchListOfUsers')
+            ->willReturnCallback(function ($search, $a, $l, $o) {
+                $users = ['gunslinger', 'newyorker', 'ladyofshadows'];
+                if (empty($search)) {
+                    $result = $users;
+                } else {
+                    $result = [];
+                    foreach ($users as $user) {
+                        if (stripos($user, $search) !== false) {
+                            $result[] = $user;
+                        }
+                    }
+                }
+                if (!is_null($l) || !is_null($o)) {
+                    $result = array_slice($result, $o, $l);
+                }
+                return $result;
+            });
+        $this->access->expects($this->any())
+            ->method('nextcloudUserNames')
+            ->willReturnArgument(0);
+        $this->access->method('fetchUsersByLoginName')
+            ->willReturn([]);
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['dn', 'uid', 'mail', 'displayname']);
+    }
+
+    public function testGetUsersNoParam(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->getUsers();
+        $this->assertCount(3, $result);
+    }
+
+    public function testGetUsersLimitOffset(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->getUsers('', 1, 2);
+        $this->assertCount(1, $result);
+    }
+
+    public function testGetUsersLimitOffset2(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->getUsers('', 2, 1);
+        $this->assertCount(2, $result);
+    }
+
+    public function testGetUsersSearchWithResult(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->getUsers('yo');
+        $this->assertCount(2, $result);
+    }
+
+    public function testGetUsersSearchEmptyResult(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->getUsers('nix');
+        $this->assertCount(0, $result);
+    }
+
+    private function getUsers($search = '', $limit = null, $offset = null) {
+        $users = Server::get(IUserManager::class)->search($search, $limit, $offset);
+        $uids = array_map(function (IUser $user) {
+            return $user->getUID();
+        }, $users);
+        return $uids;
+    }
+
+    public function testGetUsersViaAPINoParam(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $this->getUsers();
+        $this->assertCount(3, $result);
+    }
+
+    public function testGetUsersViaAPILimitOffset(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $this->getUsers('', 1, 2);
+        $this->assertCount(1, $result);
+    }
+
+    public function testGetUsersViaAPILimitOffset2(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $this->getUsers('', 2, 1);
+        $this->assertCount(2, $result);
+    }
+
+    public function testGetUsersViaAPISearchWithResult(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $this->getUsers('yo');
+        $this->assertCount(2, $result);
+    }
+
+    public function testGetUsersViaAPISearchEmptyResult(): void {
+        $this->prepareAccessForGetUsers();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $result = $this->getUsers('nix');
+        $this->assertCount(0, $result);
+    }
+
+    public function testUserExists(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('gunslinger')
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($this->createMock(UserMapping::class));
+
+        //test for existing user
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $result = $backend->userExists('gunslinger');
+        $this->assertTrue($result);
+    }
+
+    public function testUserExistsForDeleted(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $mapper = $this->createMock(UserMapping::class);
+        $mapper->expects($this->any())
+            ->method('getUUIDByDN')
+            ->with('dnOfFormerUser,dc=test')
+            ->willReturn('45673458748');
+
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($mapper);
+
+        $this->userManager->expects($this->never())
+            ->method('get');
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('formerUser')
+            ->willReturn(true);
+
+        //test for deleted user – always returns true as long as we have the user in DB
+        $this->assertTrue($backend->userExists('formerUser'));
+    }
+
+    public function testUserExistsForNeverExisting(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn) {
+                if ($dn === 'dnOfRoland,dc=test') {
+                    return [];
+                }
+                return false;
+            });
+
+        //test for never-existing user
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $result = $backend->userExists('mallory');
+        $this->assertFalse($result);
+    }
+
+    public function testUserExistsPublicAPI(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getDN')
+            ->willReturn('dnOfRoland,dc=test');
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn) {
+                if ($dn === 'dnOfRoland,dc=test') {
+                    return [];
+                }
+                return false;
+            });
+        $this->userManager->expects($this->never())
+            ->method('get');
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('gunslinger')
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($this->createMock(UserMapping::class));
+
+        //test for existing user
+        $result = Server::get(IUserManager::class)->userExists('gunslinger');
+        $this->assertTrue($result);
+    }
+
+    public function testDeleteUserExisting(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        //we do not support deleting existing users at all
+        $result = $backend->deleteUser('gunslinger');
+        $this->assertFalse($result);
+    }
+
+    public function testGetHomeAbsolutePath(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'homeFolderNamingRule') {
+                    return 'attr:testAttribute';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                switch ($dn) {
+                    case 'dnOfRoland,dc=test':
+                        if ($attr === 'testAttribute') {
+                            return ['/tmp/rolandshome/'];
+                        }
+                        return [];
+                        break;
+                    default:
+                        return false;
+                }
+            });
+
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('gunslinger');
+        $user->expects($this->any())
+            ->method('getDN')
+            ->willReturn('dnOfRoland,dc=test');
+        $user->expects($this->any())
+            ->method('getHomePath')
+            ->willReturn('/tmp/rolandshome/');
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('gunslinger')
+            ->willReturn($user);
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('gunslinger')
+            ->willReturn(true);
+
+        //absolute path
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $result = $backend->getHome('gunslinger');
+        $this->assertEquals('/tmp/rolandshome/', $result);
+    }
+
+    public function testGetHomeRelative(): void {
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $dataDir = Server::get(IConfig::class)->getSystemValue(
+            'datadirectory', \OC::$SERVERROOT . '/data');
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'homeFolderNamingRule') {
+                    return 'attr:testAttribute';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                switch ($dn) {
+                    case 'dnOfLadyOfShadows,dc=test':
+                        if ($attr === 'testAttribute') {
+                            return ['susannah/'];
+                        }
+                        return [];
+                        break;
+                    default:
+                        return false;
+                }
+            });
+
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('ladyofshadows');
+        $user->expects($this->any())
+            ->method('getDN')
+            ->willReturn('dnOfLadyOfShadows,dc=test');
+        $user->expects($this->any())
+            ->method('getHomePath')
+            ->willReturn($dataDir . '/susannah/');
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturn($user);
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('ladyofshadows')
+            ->willReturn(true);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $result = $backend->getHome('ladyofshadows');
+        $this->assertEquals($dataDir . '/susannah/', $result);
+    }
+
+
+    public function testGetHomeNoPath(): void {
+        $this->expectException(\Exception::class);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'homeFolderNamingRule') {
+                    return 'attr:testAttribute';
+                }
+                return null;
+            });
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                switch ($dn) {
+                    default:
+                        return false;
+                }
+            });
+
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('newyorker');
+        $user->expects($this->any())
+            ->method('getHomePath')
+            ->willThrowException(new \Exception());
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('newyorker')
+            ->willReturn($user);
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with('newyorker')
+            ->willReturn(true);
+
+        //no path at all – triggers OC default behaviour
+        $result = $backend->getHome('newyorker');
+        $this->assertFalse($result);
+    }
+
+    public function testGetHomeDeletedUser(): void {
+        $uid = 'newyorker';
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'homeFolderNamingRule') {
+                    return 'attr:testAttribute';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturn([]);
+
+        $userMapper = $this->createMock(UserMapping::class);
+
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($userMapper);
+
+        $offlineUser = $this->createMock(OfflineUser::class);
+        $offlineUser->expects($this->atLeastOnce())
+            ->method('getHomePath')
+            ->willReturn('');
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->with($uid)
+            ->willReturn($offlineUser);
+        $this->userManager->expects($this->once())
+            ->method('exists')
+            ->with($uid)
+            ->willReturn(true);
+
+        $result = $backend->getHome($uid);
+        $this->assertFalse($result);
+    }
+
+    public function testGetHomeWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::GET_HOME)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('getHome')
+            ->with('uid')
+            ->willReturn('result');
+
+        $this->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturnCallback(function ($uid) {
+                return true;
+            });
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertEquals($this->backend->getHome('uid'), 'result');
+    }
+
+    private function prepareAccessForGetDisplayName() {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapUserDisplayName') {
+                    return 'displayname';
+                } elseif ($name === 'ldapUserDisplayName2') {
+                    return 'displayname2';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                switch ($dn) {
+                    case 'dnOfRoland,dc=test':
+                        if ($attr === 'displayname') {
+                            return ['Roland Deschain'];
+                        }
+                        return [];
+                        break;
+
+                    default:
+                        return false;
+                }
+            });
+        $this->access->method('fetchUsersByLoginName')
+            ->willReturn([]);
+    }
+
+    public function testGetDisplayName(): void {
+        $this->prepareAccessForGetDisplayName();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->connection->expects($this->any())
+            ->method('getConnectionResource')
+            ->willReturnCallback(function () {
+                return true;
+            });
+
+        $user1 = $this->createMock(User::class);
+        $user1->expects($this->once())
+            ->method('composeAndStoreDisplayName')
+            ->willReturn('Roland Deschain');
+        $user1->expects($this->any())
+            ->method('getDN')
+            ->willReturn('dnOfRoland,dc=test');
+
+        $user2 = $this->createMock(User::class);
+        $user2->expects($this->never())
+            ->method('composeAndStoreDisplayName');
+        $user2->expects($this->any())
+            ->method('getDN')
+            ->willReturn('another DN');
+
+        $mapper = $this->createMock(UserMapping::class);
+        $mapper->expects($this->any())
+            ->method('getUUIDByDN')
+            ->willReturnCallback(function ($dn) {
+                return $dn;
+            });
+
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturnCallback(function ($uid) use ($user1, $user2) {
+                if ($uid === 'gunslinger') {
+                    return $user1;
+                } elseif ($uid === 'newyorker') {
+                    return $user2;
+                }
+                return null;
+            });
+        $this->userManager->expects($this->any())
+            ->method('exists')
+            ->willReturnCallback(function ($uid) use ($user1, $user2) {
+                if ($uid === 'gunslinger') {
+                    return true;
+                } elseif ($uid === 'newyorker') {
+                    return true;
+                }
+                return false;
+            });
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($mapper);
+        $this->access->expects($this->any())
+            ->method('getUserDnByUuid')
+            ->willReturnCallback(function ($uuid) {
+                return $uuid . '1';
+            });
+
+        //with displayName
+        $result = $backend->getDisplayName('gunslinger');
+        $this->assertEquals('Roland Deschain', $result);
+
+        //empty displayname retrieved
+        $result = $backend->getDisplayName('newyorker');
+        $this->assertEquals(null, $result);
+    }
+
+    public function testGetDisplayNamePublicAPI(): void {
+        $this->access->expects($this->any())
+            ->method('username2dn')
+            ->willReturnCallback(function ($uid) {
+                switch ($uid) {
+                    case 'gunslinger':
+                        return 'dnOfRoland,dc=test';
+                        break;
+                    case 'formerUser':
+                        return 'dnOfFormerUser,dc=test';
+                        break;
+                    case 'newyorker':
+                        return 'dnOfNewYorker,dc=test';
+                        break;
+                    case 'ladyofshadows':
+                        return 'dnOfLadyOfShadows,dc=test';
+                        break;
+                    default:
+                        return false;
+                }
+            });
+        $this->prepareAccessForGetDisplayName();
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->prepareMockForUserExists();
+
+        $this->connection->expects($this->any())
+            ->method('getConnectionResource')
+            ->willReturnCallback(function () {
+                return true;
+            });
+
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $user1 = $this->createMock(User::class);
+        $user1->expects($this->once())
+            ->method('composeAndStoreDisplayName')
+            ->willReturn('Roland Deschain');
+        $user1->expects($this->any())
+            ->method('getDN')
+            ->willReturn('dnOfRoland,dc=test');
+
+        $user2 = $this->createMock(User::class);
+        $user2->expects($this->never())
+            ->method('composeAndStoreDisplayName');
+        $user2->expects($this->any())
+            ->method('getDN')
+            ->willReturn('another DN');
+
+        $mapper = $this->createMock(UserMapping::class);
+        $mapper->expects($this->any())
+            ->method('getUUIDByDN')
+            ->willReturnCallback(function ($dn) {
+                return $dn;
+            });
+
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturnCallback(function ($uid) use ($user1, $user2) {
+                if ($uid === 'gunslinger') {
+                    return $user1;
+                } elseif ($uid === 'newyorker') {
+                    return $user2;
+                }
+                return null;
+            });
+        $this->userManager->expects($this->any())
+            ->method('exists')
+            ->willReturnCallback(function ($uid) use ($user1, $user2) {
+                if ($uid === 'gunslinger') {
+                    return true;
+                } elseif ($uid === 'newyorker') {
+                    return true;
+                }
+                return false;
+            });
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($mapper);
+        $this->access->expects($this->any())
+            ->method('getUserDnByUuid')
+            ->willReturnCallback(function ($uuid) {
+                return $uuid . '1';
+            });
+
+        //with displayName
+        $result = Server::get(IUserManager::class)->get('gunslinger')?->getDisplayName();
+        $this->assertEquals('Roland Deschain', $result);
+
+        //empty displayname retrieved
+        $result = Server::get(IUserManager::class)->get('newyorker') === null ? 'newyorker' : Server::get(IUserManager::class)->get('newyorker')->getDisplayName();
+        $this->assertEquals('newyorker', $result);
+    }
+
+    public function testGetDisplayNameWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::GET_DISPLAYNAME)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('getDisplayName')
+            ->with('uid')
+            ->willReturn('result');
+
+        $this->assertEquals($this->backend->getDisplayName('uid'), 'result');
+    }
+
+    //no test for getDisplayNames, because it just invokes getUsers and
+    //getDisplayName
+
+    public function testCountUsers(): void {
+        $this->access->expects($this->once())
+            ->method('countUsers')
+            ->willReturn(5);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->countUsers();
+        $this->assertEquals(5, $result);
+    }
+
+    public function testCountUsersFailing(): void {
+        $this->access->expects($this->once())
+            ->method('countUsers')
+            ->willReturn(false);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+
+        $result = $backend->countUsers();
+        $this->assertFalse($result);
+    }
+
+    public function testCountUsersWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::COUNT_USERS)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('countUsers')
+            ->willReturn(42);
+
+        $this->assertEquals($this->backend->countUsers(), 42);
+    }
+
+    public function testLoginName2UserNameSuccess(): void {
+        $loginName = 'Alice';
+        $username = 'alice';
+        $dn = 'uid=alice,dc=what,dc=ever';
+
+        $this->access->expects($this->once())
+            ->method('fetchUsersByLoginName')
+            ->with($this->equalTo($loginName))
+            ->willReturn([['dn' => [$dn]]]);
+        $this->access->expects($this->any())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo($dn))
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('dn2username')
+            ->with($this->equalTo($dn))
+            ->willReturn($username);
+
+        $this->connection->expects($this->exactly(2))
+            ->method('getFromCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName))
+            ->willReturnOnConsecutiveCalls(null, $username);
+        $this->connection->expects($this->once())
+            ->method('writeToCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo($username));
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $user = $this->createMock(User::class);
+        $user->expects($this->any())
+            ->method('getUsername')
+            ->willReturn('alice');
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->with($dn)
+            ->willReturn($user);
+        $this->userManager->expects($this->never())
+            ->method('exists');
+        $this->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['dn', 'uid', 'mail', 'displayname']);
+
+        $name = $backend->loginName2UserName($loginName);
+        $this->assertSame($username, $name);
+
+        // and once again to verify that caching works
+        $backend->loginName2UserName($loginName);
+    }
+
+    public function testLoginName2UserNameNoUsersOnLDAP(): void {
+        $loginName = 'Loki';
+
+        $this->access->expects($this->once())
+            ->method('fetchUsersByLoginName')
+            ->with($this->equalTo($loginName))
+            ->willReturn([]);
+        $this->access->expects($this->never())
+            ->method('stringResemblesDN');
+        $this->access->expects($this->never())
+            ->method('dn2username');
+
+        $this->connection->expects($this->exactly(2))
+            ->method('getFromCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName))
+            ->willReturnOnConsecutiveCalls(null, false);
+        $this->connection->expects($this->once())
+            ->method('writeToCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName), false);
+
+        $this->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['dn', 'uid', 'mail', 'displayname']);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $name = $backend->loginName2UserName($loginName);
+        $this->assertSame(false, $name);
+
+        // and once again to verify that caching works
+        $backend->loginName2UserName($loginName);
+    }
+
+    public function testLoginName2UserNameOfflineUser(): void {
+        $loginName = 'Alice';
+        $dn = 'uid=alice,dc=what,dc=ever';
+
+        $offlineUser = $this->getMockBuilder(OfflineUser::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->access->expects($this->once())
+            ->method('fetchUsersByLoginName')
+            ->with($this->equalTo($loginName))
+            ->willReturn([['dn' => [$dn]]]);
+
+        $this->connection->expects($this->exactly(2))
+            ->method('getFromCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName))
+            ->willReturnOnConsecutiveCalls(null, false);
+        $this->connection->expects($this->once())
+            ->method('writeToCache')
+            ->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo(false));
+
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->with($dn)
+            ->willReturn($offlineUser);
+        $this->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['dn', 'uid', 'mail', 'displayname']);
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $name = $backend->loginName2UserName($loginName);
+        $this->assertSame(false, $name);
+
+        // and once again to verify that caching works
+        $backend->loginName2UserName($loginName);
+    }
+
+    /**
+     * Prepares the Access mock for setPassword tests
+     */
+    private function prepareAccessForSetPassword($enablePasswordChange = true) {
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) use (&$enablePasswordChange) {
+                if ($name === 'ldapLoginFilter') {
+                    return '%uid';
+                }
+                if ($name === 'turnOnPasswordChange') {
+                    return $enablePasswordChange?1:0;
+                }
+                return null;
+            });
+        $this->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturnCallback(function ($uid) {
+                if ($uid === 'userExists' . 'roland') {
+                    return true;
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('fetchListOfUsers')
+            ->willReturnCallback(function ($filter) {
+                if ($filter === 'roland') {
+                    return [['dn' => ['dnOfRoland,dc=test']]];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('fetchUsersByLoginName')
+            ->willReturnCallback(function ($uid) {
+                if ($uid === 'roland') {
+                    return [['dn' => ['dnOfRoland,dc=test']]];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('dn2username')
+            ->with($this->equalTo('dnOfRoland,dc=test'))
+            ->willReturn('roland');
+        $this->access->expects($this->any())
+            ->method('stringResemblesDN')
+            ->with($this->equalTo('dnOfRoland,dc=test'))
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('setPassword')
+            ->willReturnCallback(function ($uid, $password) {
+                if (strlen($password) <= 5) {
+                    throw new HintException('Password fails quality checking policy', '', 19);
+                }
+                return true;
+            });
+    }
+
+
+    public function testSetPasswordInvalid(): void {
+        $this->expectException(HintException::class);
+        $this->expectExceptionMessage('Password fails quality checking policy');
+
+        $this->prepareAccessForSetPassword($this->access);
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturn($this->createMock(User::class));
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $this->assertTrue(\OC_User::setPassword('roland', 'dt'));
+    }
+
+    public function testSetPasswordValid(): void {
+        $this->prepareAccessForSetPassword($this->access);
+
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($this->createMock(User::class));
+
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($this->createMock(User::class));
+
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $this->assertTrue(\OC_User::setPassword('roland', 'dt12234$'));
+    }
+
+    public function testSetPasswordValidDisabled(): void {
+        $this->userManager->expects($this->any())
+            ->method('get')
+            ->willReturn($this->createMock(User::class));
+
+        $this->prepareAccessForSetPassword(false);
+        $backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
+        Server::get(IUserManager::class)->registerBackend($backend);
+
+        $this->assertFalse(\OC_User::setPassword('roland', 'dt12234$'));
+    }
+
+
+    public function testSetPasswordWithInvalidUser(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('LDAP setPassword: Could not get user object for uid NotExistingUser. Maybe the LDAP entry has no set display name attribute?');
+
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('NotExistingUser')
+            ->willReturn(null);
+
+        $this->backend->setPassword('NotExistingUser', 'Password');
+    }
+
+    public function testSetPasswordWithUsernameFalse(): void {
+        $user = $this->createMock(User::class);
+        $user
+            ->expects($this->once())
+            ->method('getUsername')
+            ->willReturn(false);
+        $this->userManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('NotExistingUser')
+            ->willReturn($user);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertFalse($this->backend->setPassword('NotExistingUser', 'Password'));
+    }
+
+    public function testSetPasswordWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::SET_PASSWORD)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('setPassword')
+            ->with('uid', 'password')
+            ->willReturn('result');
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertEquals($this->backend->setPassword('uid', 'password'), 'result');
+    }
+
+    public static function avatarDataProvider(): array {
+        return [
+            [ 'validImageData', false ],
+            [ 'corruptImageData', true ],
+            [ false, true]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('avatarDataProvider')]
+    public function testCanChangeAvatar(string|bool $imageData, bool $expected): void {
+        $isValidImage = str_starts_with((string)$imageData, 'valid');
+
+        $user = $this->createMock(User::class);
+        $user->expects($this->once())
+            ->method('getAvatarImage')
+            ->willReturn($imageData);
+        $user->expects($this->atMost(1))
+            ->method('updateAvatar')
+            ->willReturn($isValidImage);
+
+        $this->userManager->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturn($user);
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->assertSame($expected, $this->backend->canChangeAvatar('uid'));
+    }
+
+    public function testCanChangeAvatarWithPlugin(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::PROVIDE_AVATAR)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('canChangeAvatar')
+            ->with('uid')
+            ->willReturn('result');
+
+        $this->assertEquals($this->backend->canChangeAvatar('uid'), 'result');
+    }
+
+    public function testSetDisplayNameWithPlugin(): void {
+        $newDisplayName = 'J. Baker';
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::SET_DISPLAYNAME)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('setDisplayName')
+            ->with('uid', $newDisplayName)
+            ->willReturn($newDisplayName);
+        $this->access->expects($this->once())
+            ->method('cacheUserDisplayName');
+
+        $this->assertEquals($newDisplayName, $this->backend->setDisplayName('uid', $newDisplayName));
+    }
+
+
+    public function testSetDisplayNameErrorWithPlugin(): void {
+        $this->expectException(HintException::class);
+
+        $newDisplayName = 'J. Baker';
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::SET_DISPLAYNAME)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('setDisplayName')
+            ->with('uid', $newDisplayName)
+            ->willThrowException(new HintException('something happned'));
+        $this->access->expects($this->never())
+            ->method('cacheUserDisplayName');
+
+        $this->backend->setDisplayName('uid', $newDisplayName);
+    }
+
+    public function testSetDisplayNameFailing(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::SET_DISPLAYNAME)
+            ->willReturn(false);
+        $this->access->expects($this->never())
+            ->method('cacheUserDisplayName');
+
+        $this->assertFalse($this->backend->setDisplayName('uid', 'displayName'));
+    }
+
+    public function testCreateUserWithPlugin(): void {
+        $uid = 'alien6372';
+        $uuid = '123-2345-36756-123-2345234-4431';
+        $pwd = 'passwørd';
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::CREATE_USER)
+            ->willReturn(true);
+        $this->pluginManager->expects($this->once())
+            ->method('createUser')
+            ->with($uid, $pwd)
+            ->willReturn('result');
+
+        $this->access->expects($this->atLeastOnce())
+            ->method('getUUID')
+            ->willReturn($uuid);
+        $this->access->expects($this->once())
+            ->method('mapAndAnnounceIfApplicable')
+            ->with($this->isInstanceOf(AbstractMapping::class), $this->anything(), $uid, $uuid, true);
+        $this->access->expects($this->any())
+            ->method('getUserMapper')
+            ->willReturn($this->createMock(UserMapping::class));
+
+        $this->assertEquals($this->backend->createUser($uid, $pwd), true);
+    }
+
+    public function testCreateUserFailing(): void {
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(Backend::CREATE_USER)
+            ->willReturn(false);
+
+        $this->assertFalse($this->backend->createUser('uid', 'password'));
+    }
+
+    public static function actionProvider(): array {
+        return [
+            [ 'ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
+            [ 'ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
+            [ 'ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
+            [ 'turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
+            [ 'turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('actionProvider')]
+    public function testImplementsAction(string $configurable, string|int $value, int $actionCode, bool $expected): void {
+        $this->pluginManager->expects($this->once())
+            ->method('getImplementedActions')
+            ->willReturn(0);
+
+        $this->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnMap([
+                [$configurable, $value],
+            ]);
+
+        $this->assertSame($expected, $this->backend->implementsActions($actionCode));
+    }
 }

Spacing +62 added lines, -62 removed lines

@@ -84,7 +84,7 @@ 
 	private function prepareMockForUserExists(): void {
 		$this->access->expects($this->any())
 			->method('username2dn')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				switch ($uid) {
 					case 'gunslinger':
 						return 'dnOfRoland,dc=test';
@@ -113,7 +113,7 @@ 
 	private function prepareAccessForCheckPassword(bool $noDisplayName = false): void {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapLoginFilter') {
 					return '%uid';
 				}
@@ -122,7 +122,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
+			->willReturnCallback(function($filter) {
 				if ($filter === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -130,7 +130,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				if ($uid === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -155,7 +155,7 @@ 
 			->willReturn(true);
 		$this->access->expects($this->any())
 			->method('areCredentialsValid')
-			->willReturnCallback(function ($dn, $pwd) {
+			->willReturnCallback(function($dn, $pwd) {
 				if ($pwd === 'dt19') {
 					return true;
 				}
@@ -349,22 +349,22 @@ 
 	private function prepareAccessForGetUsers() {
 		$this->access->expects($this->once())
 			->method('escapeFilterPart')
-			->willReturnCallback(function ($search) {
+			->willReturnCallback(function($search) {
 				return $search;
 			});
 		$this->access->expects($this->any())
 			->method('getFilterPartForUserSearch')
-			->willReturnCallback(function ($search) {
+			->willReturnCallback(function($search) {
 				return $search;
 			});
 		$this->access->expects($this->any())
 			->method('combineFilterWithAnd')
-			->willReturnCallback(function ($param) {
+			->willReturnCallback(function($param) {
 				return $param[2];
 			});
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($search, $a, $l, $o) {
+			->willReturnCallback(function($search, $a, $l, $o) {
 				$users = ['gunslinger', 'newyorker', 'ladyofshadows'];
 				if (empty($search)) {
 					$result = $users;
@@ -434,7 +434,7 @@ 
 
 	private function getUsers($search = '', $limit = null, $offset = null) {
 		$users = Server::get(IUserManager::class)->search($search, $limit, $offset);
-		$uids = array_map(function (IUser $user) {
+		$uids = array_map(function(IUser $user) {
 			return $user->getUID();
 		}, $users);
 		return $uids;
@@ -536,7 +536,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				if ($dn === 'dnOfRoland,dc=test') {
 					return [];
 				}
@@ -561,7 +561,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				if ($dn === 'dnOfRoland,dc=test') {
 					return [];
 				}
@@ -596,7 +596,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -605,7 +605,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfRoland,dc=test':
 						if ($attr === 'testAttribute') {
@@ -649,11 +649,11 @@ 
 		$this->prepareMockForUserExists();
 
 		$dataDir = Server::get(IConfig::class)->getSystemValue(
-			'datadirectory', \OC::$SERVERROOT . '/data');
+			'datadirectory', \OC::$SERVERROOT.'/data');
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -662,7 +662,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfLadyOfShadows,dc=test':
 						if ($attr === 'testAttribute') {
@@ -684,7 +684,7 @@ 
 			->willReturn('dnOfLadyOfShadows,dc=test');
 		$user->expects($this->any())
 			->method('getHomePath')
-			->willReturn($dataDir . '/susannah/');
+			->willReturn($dataDir.'/susannah/');
 
 		$this->userManager->expects($this->atLeastOnce())
 			->method('get')
@@ -696,7 +696,7 @@ 
 
 		/** @noinspection PhpUnhandledExceptionInspection */
 		$result = $backend->getHome('ladyofshadows');
-		$this->assertEquals($dataDir . '/susannah/', $result);
+		$this->assertEquals($dataDir.'/susannah/', $result);
 	}
 
 
@@ -708,7 +708,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -716,7 +716,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					default:
 						return false;
@@ -753,7 +753,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -800,7 +800,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				return true;
 			});
 
@@ -811,7 +811,7 @@ 
 	private function prepareAccessForGetDisplayName() {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapUserDisplayName') {
 					return 'displayname';
 				} elseif ($name === 'ldapUserDisplayName2') {
@@ -822,7 +822,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfRoland,dc=test':
 						if ($attr === 'displayname') {
@@ -846,7 +846,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getConnectionResource')
-			->willReturnCallback(function () {
+			->willReturnCallback(function() {
 				return true;
 			});
 
@@ -868,13 +868,13 @@ 
 		$mapper = $this->createMock(UserMapping::class);
 		$mapper->expects($this->any())
 			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				return $dn;
 			});
 
 		$this->userManager->expects($this->any())
 			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return $user1;
 				} elseif ($uid === 'newyorker') {
@@ -884,7 +884,7 @@ 
 			});
 		$this->userManager->expects($this->any())
 			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return true;
 				} elseif ($uid === 'newyorker') {
@@ -897,8 +897,8 @@ 
 			->willReturn($mapper);
 		$this->access->expects($this->any())
 			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
+			->willReturnCallback(function($uuid) {
+				return $uuid.'1';
 			});
 
 		//with displayName
@@ -913,7 +913,7 @@ 
 	public function testGetDisplayNamePublicAPI(): void {
 		$this->access->expects($this->any())
 			->method('username2dn')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				switch ($uid) {
 					case 'gunslinger':
 						return 'dnOfRoland,dc=test';
@@ -937,7 +937,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getConnectionResource')
-			->willReturnCallback(function () {
+			->willReturnCallback(function() {
 				return true;
 			});
 
@@ -961,13 +961,13 @@ 
 		$mapper = $this->createMock(UserMapping::class);
 		$mapper->expects($this->any())
 			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				return $dn;
 			});
 
 		$this->userManager->expects($this->any())
 			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return $user1;
 				} elseif ($uid === 'newyorker') {
@@ -977,7 +977,7 @@ 
 			});
 		$this->userManager->expects($this->any())
 			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return true;
 				} elseif ($uid === 'newyorker') {
@@ -990,8 +990,8 @@ 
 			->willReturn($mapper);
 		$this->access->expects($this->any())
 			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
+			->willReturnCallback(function($uuid) {
+				return $uuid.'1';
 			});
 
 		//with displayName
@@ -1073,11 +1073,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, $username);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo($username));
+			->with($this->equalTo('loginName2UserName-'.$loginName), $this->equalTo($username));
 
 		$backend = new UserLDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
 		$user = $this->createMock(User::class);
@@ -1116,11 +1116,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, false);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), false);
+			->with($this->equalTo('loginName2UserName-'.$loginName), false);
 
 		$this->userManager->expects($this->any())
 			->method('getAttributes')
@@ -1149,11 +1149,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, false);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo(false));
+			->with($this->equalTo('loginName2UserName-'.$loginName), $this->equalTo(false));
 
 		$this->userManager->expects($this->any())
 			->method('get')
@@ -1177,19 +1177,19 @@ 
 	private function prepareAccessForSetPassword($enablePasswordChange = true) {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) use (&$enablePasswordChange) {
+			->willReturnCallback(function($name) use (&$enablePasswordChange) {
 				if ($name === 'ldapLoginFilter') {
 					return '%uid';
 				}
 				if ($name === 'turnOnPasswordChange') {
-					return $enablePasswordChange?1:0;
+					return $enablePasswordChange ? 1 : 0;
 				}
 				return null;
 			});
 		$this->connection->expects($this->any())
 			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'userExists' . 'roland') {
+			->willReturnCallback(function($uid) {
+				if ($uid === 'userExists'.'roland') {
 					return true;
 				}
 				return null;
@@ -1197,7 +1197,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
+			->willReturnCallback(function($filter) {
 				if ($filter === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -1205,7 +1205,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				if ($uid === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -1221,7 +1221,7 @@ 
 			->willReturn(true);
 		$this->access->expects($this->any())
 			->method('setPassword')
-			->willReturnCallback(function ($uid, $password) {
+			->willReturnCallback(function($uid, $password) {
 				if (strlen($password) <= 5) {
 					throw new HintException('Password fails quality checking policy', '', 19);
 				}
@@ -1319,15 +1319,15 @@ 
 
 	public static function avatarDataProvider(): array {
 		return [
-			[ 'validImageData', false ],
-			[ 'corruptImageData', true ],
-			[ false, true]
+			['validImageData', false],
+			['corruptImageData', true],
+			[false, true]
 		];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('avatarDataProvider')]
-	public function testCanChangeAvatar(string|bool $imageData, bool $expected): void {
-		$isValidImage = str_starts_with((string)$imageData, 'valid');
+	public function testCanChangeAvatar(string | bool $imageData, bool $expected): void {
+		$isValidImage = str_starts_with((string) $imageData, 'valid');
 
 		$user = $this->createMock(User::class);
 		$user->expects($this->once())
@@ -1442,16 +1442,16 @@ 
 
 	public static function actionProvider(): array {
 		return [
-			[ 'ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
-			[ 'turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
-			[ 'turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
+			['ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
+			['ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
+			['ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
+			['turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
+			['turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
 		];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('actionProvider')]
-	public function testImplementsAction(string $configurable, string|int $value, int $actionCode, bool $expected): void {
+	public function testImplementsAction(string $configurable, string | int $value, int $actionCode, bool $expected): void {
 		$this->pluginManager->expects($this->once())
 			->method('getImplementedActions')
 			->willReturn(0);

apps/user_ldap/tests/Migration/UUIDFixInsertTest.php

Indentation +150 added lines, -150 removed lines

@@ -17,154 +17,154 @@
 use Test\TestCase;
 
 class UUIDFixInsertTest extends TestCase {
-	protected IConfig&MockObject $config;
-	protected UserMapping&MockObject $userMapper;
-	protected GroupMapping&MockObject $groupMapper;
-	protected IJobList&MockObject $jobList;
-	protected UUIDFixInsert $job;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->userMapper = $this->createMock(UserMapping::class);
-		$this->groupMapper = $this->createMock(GroupMapping::class);
-		$this->job = new UUIDFixInsert(
-			$this->config,
-			$this->userMapper,
-			$this->groupMapper,
-			$this->jobList
-		);
-	}
-
-	public function testGetName(): void {
-		$this->assertSame('Insert UUIDFix background job for user and group in batches', $this->job->getName());
-	}
-
-	public static function recordProvider(): array {
-		$record = [
-			'dn' => 'cn=somerecord,dc=somewhere',
-			'name' => 'Something',
-			'uuid' => 'AB12-3456-CDEF7-8GH9'
-		];
-
-		$userBatches = [
-			0 => array_fill(0, 50, $record),
-			1 => array_fill(0, 50, $record),
-			2 => array_fill(0, 13, $record),
-		];
-
-		$groupBatches = [
-			0 => array_fill(0, 7, $record),
-		];
-
-		return [
-			['userBatches' => $userBatches, 'groupBatches' => $groupBatches]
-		];
-	}
-
-	public static function recordProviderTooLongAndNone(): array {
-		$record = [
-			'dn' => 'cn=somerecord,dc=somewhere',
-			'name' => 'Something',
-			'uuid' => 'AB12-3456-CDEF7-8GH9'
-		];
-
-		$userBatches = [
-			0 => array_fill(0, 50, $record),
-			1 => array_fill(0, 40, $record),
-			2 => array_fill(0, 32, $record),
-			3 => array_fill(0, 32, $record),
-			4 => array_fill(0, 23, $record),
-		];
-
-		$groupBatches = [0 => []];
-
-		return [
-			['userBatches' => $userBatches, 'groupBatches' => $groupBatches]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('recordProvider')]
-	public function testRun(array $userBatches, array $groupBatches): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('user_ldap', 'installed_version', '1.2.1')
-			->willReturn('1.2.0');
-
-		$this->userMapper->expects($this->exactly(3))
-			->method('getList')
-			->willReturnMap([
-				[0, 50, false, $userBatches[0]],
-				[50, 50, false, $userBatches[1]],
-				[100, 50, false, $userBatches[2]],
-			]);
-
-		$this->groupMapper->expects($this->exactly(1))
-			->method('getList')
-			->with(0, 50)
-			->willReturn($groupBatches[0]);
-
-		$this->jobList->expects($this->exactly(4))
-			->method('add');
-
-		/** @var IOutput $out */
-		$out = $this->createMock(IOutput::class);
-		$this->job->run($out);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('recordProviderTooLongAndNone')]
-	public function testRunWithManyAndNone(array $userBatches, array $groupBatches): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('user_ldap', 'installed_version', '1.2.1')
-			->willReturn('1.2.0');
-
-		$this->userMapper->expects($this->exactly(5))
-			->method('getList')
-			->willReturnMap([
-				[0, 50, false, $userBatches[0]],
-				[0, 40, false, $userBatches[1]],
-				[0, 32, false, $userBatches[2]],
-				[32, 32, false, $userBatches[3]],
-				[64, 32, false, $userBatches[4]],
-			]);
-
-		$this->groupMapper->expects($this->once())
-			->method('getList')
-			->with(0, 50)
-			->willReturn($groupBatches[0]);
-
-		$this->jobList->expects($this->exactly(5))
-			->method('add')
-			->willReturnOnConsecutiveCalls(
-				$this->throwException(new \InvalidArgumentException('Background job arguments can\'t exceed 4000 etc')),
-				$this->throwException(new \InvalidArgumentException('Background job arguments can\'t exceed 4000 etc')),
-				null,
-				null,
-				null,
-			);
-
-		/** @var IOutput $out */
-		$out = $this->createMock(IOutput::class);
-		$this->job->run($out);
-	}
-
-	public function testDonNotRun(): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('user_ldap', 'installed_version', '1.2.1')
-			->willReturn('1.2.1');
-		$this->userMapper->expects($this->never())
-			->method('getList');
-		$this->groupMapper->expects($this->never())
-			->method('getList');
-		$this->jobList->expects($this->never())
-			->method('add');
-
-		/** @var IOutput $out */
-		$out = $this->createMock(IOutput::class);
-		$this->job->run($out);
-	}
+    protected IConfig&MockObject $config;
+    protected UserMapping&MockObject $userMapper;
+    protected GroupMapping&MockObject $groupMapper;
+    protected IJobList&MockObject $jobList;
+    protected UUIDFixInsert $job;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->userMapper = $this->createMock(UserMapping::class);
+        $this->groupMapper = $this->createMock(GroupMapping::class);
+        $this->job = new UUIDFixInsert(
+            $this->config,
+            $this->userMapper,
+            $this->groupMapper,
+            $this->jobList
+        );
+    }
+
+    public function testGetName(): void {
+        $this->assertSame('Insert UUIDFix background job for user and group in batches', $this->job->getName());
+    }
+
+    public static function recordProvider(): array {
+        $record = [
+            'dn' => 'cn=somerecord,dc=somewhere',
+            'name' => 'Something',
+            'uuid' => 'AB12-3456-CDEF7-8GH9'
+        ];
+
+        $userBatches = [
+            0 => array_fill(0, 50, $record),
+            1 => array_fill(0, 50, $record),
+            2 => array_fill(0, 13, $record),
+        ];
+
+        $groupBatches = [
+            0 => array_fill(0, 7, $record),
+        ];
+
+        return [
+            ['userBatches' => $userBatches, 'groupBatches' => $groupBatches]
+        ];
+    }
+
+    public static function recordProviderTooLongAndNone(): array {
+        $record = [
+            'dn' => 'cn=somerecord,dc=somewhere',
+            'name' => 'Something',
+            'uuid' => 'AB12-3456-CDEF7-8GH9'
+        ];
+
+        $userBatches = [
+            0 => array_fill(0, 50, $record),
+            1 => array_fill(0, 40, $record),
+            2 => array_fill(0, 32, $record),
+            3 => array_fill(0, 32, $record),
+            4 => array_fill(0, 23, $record),
+        ];
+
+        $groupBatches = [0 => []];
+
+        return [
+            ['userBatches' => $userBatches, 'groupBatches' => $groupBatches]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('recordProvider')]
+    public function testRun(array $userBatches, array $groupBatches): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('user_ldap', 'installed_version', '1.2.1')
+            ->willReturn('1.2.0');
+
+        $this->userMapper->expects($this->exactly(3))
+            ->method('getList')
+            ->willReturnMap([
+                [0, 50, false, $userBatches[0]],
+                [50, 50, false, $userBatches[1]],
+                [100, 50, false, $userBatches[2]],
+            ]);
+
+        $this->groupMapper->expects($this->exactly(1))
+            ->method('getList')
+            ->with(0, 50)
+            ->willReturn($groupBatches[0]);
+
+        $this->jobList->expects($this->exactly(4))
+            ->method('add');
+
+        /** @var IOutput $out */
+        $out = $this->createMock(IOutput::class);
+        $this->job->run($out);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('recordProviderTooLongAndNone')]
+    public function testRunWithManyAndNone(array $userBatches, array $groupBatches): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('user_ldap', 'installed_version', '1.2.1')
+            ->willReturn('1.2.0');
+
+        $this->userMapper->expects($this->exactly(5))
+            ->method('getList')
+            ->willReturnMap([
+                [0, 50, false, $userBatches[0]],
+                [0, 40, false, $userBatches[1]],
+                [0, 32, false, $userBatches[2]],
+                [32, 32, false, $userBatches[3]],
+                [64, 32, false, $userBatches[4]],
+            ]);
+
+        $this->groupMapper->expects($this->once())
+            ->method('getList')
+            ->with(0, 50)
+            ->willReturn($groupBatches[0]);
+
+        $this->jobList->expects($this->exactly(5))
+            ->method('add')
+            ->willReturnOnConsecutiveCalls(
+                $this->throwException(new \InvalidArgumentException('Background job arguments can\'t exceed 4000 etc')),
+                $this->throwException(new \InvalidArgumentException('Background job arguments can\'t exceed 4000 etc')),
+                null,
+                null,
+                null,
+            );
+
+        /** @var IOutput $out */
+        $out = $this->createMock(IOutput::class);
+        $this->job->run($out);
+    }
+
+    public function testDonNotRun(): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('user_ldap', 'installed_version', '1.2.1')
+            ->willReturn('1.2.1');
+        $this->userMapper->expects($this->never())
+            ->method('getList');
+        $this->groupMapper->expects($this->never())
+            ->method('getList');
+        $this->jobList->expects($this->never())
+            ->method('add');
+
+        /** @var IOutput $out */
+        $out = $this->createMock(IOutput::class);
+        $this->job->run($out);
+    }
 }

apps/user_ldap/tests/Jobs/CleanUpTest.php

Indentation +98 added lines, -98 removed lines

@@ -19,102 +19,102 @@
 use Test\TestCase;
 
 class CleanUpTest extends TestCase {
-	protected CleanUp $bgJob;
-	protected array $mocks;
-
-	public function setUp(): void {
-		parent::setUp();
-		$this->createMocks();
-		$this->bgJob = new CleanUp($this->mocks['timeFactory'], $this->mocks['userBackend'], $this->mocks['deletedUsersIndex']);
-		$this->bgJob->setArguments($this->mocks);
-	}
-
-	protected function createMocks(): void {
-		$this->mocks = [];
-		$this->mocks['userBackend'] = $this->createMock(User_Proxy::class);
-		$this->mocks['deletedUsersIndex'] = $this->createMock(DeletedUsersIndex::class);
-		$this->mocks['ocConfig'] = $this->createMock(IConfig::class);
-		$this->mocks['db'] = $this->createMock(IDBConnection::class);
-		$this->mocks['helper'] = $this->createMock(Helper::class);
-		$this->mocks['timeFactory'] = $this->createMock(ITimeFactory::class);
-	}
-
-	/**
-	 * clean up job must not run when there are disabled configurations
-	 */
-	public function test_runNotAllowedByDisabledConfigurations(): void {
-		$this->mocks['helper']->expects($this->once())
-			->method('haveDisabledConfigurations')
-			->willReturn(true);
-
-		$this->mocks['ocConfig']->expects($this->never())
-			->method('getSystemValue');
-
-		$result = $this->bgJob->isCleanUpAllowed();
-		$this->assertSame(false, $result);
-	}
-
-	/**
-	 * clean up job must not run when LDAP Helper is broken i.e.
-	 * returning unexpected results
-	 */
-	public function test_runNotAllowedByBrokenHelper(): void {
-		$this->mocks['helper']->expects($this->once())
-			->method('haveDisabledConfigurations')
-			->willThrowException(new Exception());
-
-		$this->mocks['ocConfig']->expects($this->never())
-			->method('getSystemValue');
-
-		$result = $this->bgJob->isCleanUpAllowed();
-		$this->assertSame(false, $result);
-	}
-
-	/**
-	 * clean up job must not run when it is not enabled
-	 */
-	public function test_runNotAllowedBySysConfig(): void {
-		$this->mocks['helper']->expects($this->once())
-			->method('haveDisabledConfigurations')
-			->willReturn(false);
-
-		$this->mocks['ocConfig']->expects($this->once())
-			->method('getSystemValue')
-			->willReturn(false);
-
-		$result = $this->bgJob->isCleanUpAllowed();
-		$this->assertSame(false, $result);
-	}
-
-	/**
-	 * clean up job is allowed to run
-	 */
-	public function test_runIsAllowed(): void {
-		$this->mocks['helper']->expects($this->once())
-			->method('haveDisabledConfigurations')
-			->willReturn(false);
-
-		$this->mocks['ocConfig']->expects($this->once())
-			->method('getSystemValue')
-			->willReturn(true);
-
-		$result = $this->bgJob->isCleanUpAllowed();
-		$this->assertSame(true, $result);
-	}
-
-	/**
-	 * check whether offset will be reset when it needs to
-	 */
-	public function test_OffsetResetIsNecessary(): void {
-		$result = $this->bgJob->isOffsetResetNecessary($this->bgJob->getChunkSize() - 1);
-		$this->assertSame(true, $result);
-	}
-
-	/**
-	 * make sure offset is not reset when it is not due
-	 */
-	public function test_OffsetResetIsNotNecessary(): void {
-		$result = $this->bgJob->isOffsetResetNecessary($this->bgJob->getChunkSize());
-		$this->assertSame(false, $result);
-	}
+    protected CleanUp $bgJob;
+    protected array $mocks;
+
+    public function setUp(): void {
+        parent::setUp();
+        $this->createMocks();
+        $this->bgJob = new CleanUp($this->mocks['timeFactory'], $this->mocks['userBackend'], $this->mocks['deletedUsersIndex']);
+        $this->bgJob->setArguments($this->mocks);
+    }
+
+    protected function createMocks(): void {
+        $this->mocks = [];
+        $this->mocks['userBackend'] = $this->createMock(User_Proxy::class);
+        $this->mocks['deletedUsersIndex'] = $this->createMock(DeletedUsersIndex::class);
+        $this->mocks['ocConfig'] = $this->createMock(IConfig::class);
+        $this->mocks['db'] = $this->createMock(IDBConnection::class);
+        $this->mocks['helper'] = $this->createMock(Helper::class);
+        $this->mocks['timeFactory'] = $this->createMock(ITimeFactory::class);
+    }
+
+    /**
+     * clean up job must not run when there are disabled configurations
+     */
+    public function test_runNotAllowedByDisabledConfigurations(): void {
+        $this->mocks['helper']->expects($this->once())
+            ->method('haveDisabledConfigurations')
+            ->willReturn(true);
+
+        $this->mocks['ocConfig']->expects($this->never())
+            ->method('getSystemValue');
+
+        $result = $this->bgJob->isCleanUpAllowed();
+        $this->assertSame(false, $result);
+    }
+
+    /**
+     * clean up job must not run when LDAP Helper is broken i.e.
+     * returning unexpected results
+     */
+    public function test_runNotAllowedByBrokenHelper(): void {
+        $this->mocks['helper']->expects($this->once())
+            ->method('haveDisabledConfigurations')
+            ->willThrowException(new Exception());
+
+        $this->mocks['ocConfig']->expects($this->never())
+            ->method('getSystemValue');
+
+        $result = $this->bgJob->isCleanUpAllowed();
+        $this->assertSame(false, $result);
+    }
+
+    /**
+     * clean up job must not run when it is not enabled
+     */
+    public function test_runNotAllowedBySysConfig(): void {
+        $this->mocks['helper']->expects($this->once())
+            ->method('haveDisabledConfigurations')
+            ->willReturn(false);
+
+        $this->mocks['ocConfig']->expects($this->once())
+            ->method('getSystemValue')
+            ->willReturn(false);
+
+        $result = $this->bgJob->isCleanUpAllowed();
+        $this->assertSame(false, $result);
+    }
+
+    /**
+     * clean up job is allowed to run
+     */
+    public function test_runIsAllowed(): void {
+        $this->mocks['helper']->expects($this->once())
+            ->method('haveDisabledConfigurations')
+            ->willReturn(false);
+
+        $this->mocks['ocConfig']->expects($this->once())
+            ->method('getSystemValue')
+            ->willReturn(true);
+
+        $result = $this->bgJob->isCleanUpAllowed();
+        $this->assertSame(true, $result);
+    }
+
+    /**
+     * check whether offset will be reset when it needs to
+     */
+    public function test_OffsetResetIsNecessary(): void {
+        $result = $this->bgJob->isOffsetResetNecessary($this->bgJob->getChunkSize() - 1);
+        $this->assertSame(true, $result);
+    }
+
+    /**
+     * make sure offset is not reset when it is not due
+     */
+    public function test_OffsetResetIsNotNecessary(): void {
+        $result = $this->bgJob->isOffsetResetNecessary($this->bgJob->getChunkSize());
+        $this->assertSame(false, $result);
+    }
 }