nextcloud / server

apps/federatedfilesharing/tests/NotificationsTest.php

Indentation +101 added lines, -101 removed lines

@@ -21,117 +21,117 @@
 use Psr\Log\LoggerInterface;
 
 class NotificationsTest extends \Test\TestCase {
-	private AddressHandler&MockObject $addressHandler;
-	private IClientService&MockObject $httpClientService;
-	private IDiscoveryService&MockObject $discoveryService;
-	private IJobList&MockObject $jobList;
-	private ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
-	private ICloudFederationFactory&MockObject $cloudFederationFactory;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private LoggerInterface&MockObject $logger;
+    private AddressHandler&MockObject $addressHandler;
+    private IClientService&MockObject $httpClientService;
+    private IDiscoveryService&MockObject $discoveryService;
+    private IJobList&MockObject $jobList;
+    private ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
+    private ICloudFederationFactory&MockObject $cloudFederationFactory;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private LoggerInterface&MockObject $logger;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->discoveryService = $this->createMock(IDiscoveryService::class);
-		$this->httpClientService = $this->createMock(IClientService::class);
-		$this->addressHandler = $this->createMock(AddressHandler::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
-		$this->cloudFederationFactory = $this->createMock(ICloudFederationFactory::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-	}
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->discoveryService = $this->createMock(IDiscoveryService::class);
+        $this->httpClientService = $this->createMock(IClientService::class);
+        $this->addressHandler = $this->createMock(AddressHandler::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
+        $this->cloudFederationFactory = $this->createMock(ICloudFederationFactory::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+    }
 
-	/**
-	 * @return Notifications|MockObject
-	 */
-	private function getInstance(array $mockedMethods = []) {
-		if (empty($mockedMethods)) {
-			return new Notifications(
-				$this->addressHandler,
-				$this->httpClientService,
-				$this->discoveryService,
-				$this->jobList,
-				$this->cloudFederationProviderManager,
-				$this->cloudFederationFactory,
-				$this->eventDispatcher,
-				$this->logger,
-			);
-		}
+    /**
+     * @return Notifications|MockObject
+     */
+    private function getInstance(array $mockedMethods = []) {
+        if (empty($mockedMethods)) {
+            return new Notifications(
+                $this->addressHandler,
+                $this->httpClientService,
+                $this->discoveryService,
+                $this->jobList,
+                $this->cloudFederationProviderManager,
+                $this->cloudFederationFactory,
+                $this->eventDispatcher,
+                $this->logger,
+            );
+        }
 
-		return $this->getMockBuilder(Notifications::class)
-			->setConstructorArgs(
-				[
-					$this->addressHandler,
-					$this->httpClientService,
-					$this->discoveryService,
-					$this->jobList,
-					$this->cloudFederationProviderManager,
-					$this->cloudFederationFactory,
-					$this->eventDispatcher,
-					$this->logger,
-				]
-			)
-			->onlyMethods($mockedMethods)
-			->getMock();
-	}
+        return $this->getMockBuilder(Notifications::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressHandler,
+                    $this->httpClientService,
+                    $this->discoveryService,
+                    $this->jobList,
+                    $this->cloudFederationProviderManager,
+                    $this->cloudFederationFactory,
+                    $this->eventDispatcher,
+                    $this->logger,
+                ]
+            )
+            ->onlyMethods($mockedMethods)
+            ->getMock();
+    }
 
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSendUpdateToRemote')]
-	public function testSendUpdateToRemote(int $try, array $httpRequestResult, bool $expected): void {
-		$remote = 'http://remote';
-		$id = 42;
-		$timestamp = 63576;
-		$token = 'token';
-		$action = 'unshare';
-		$instance = $this->getInstance(['tryHttpPostToShareEndpoint', 'getTimestamp']);
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSendUpdateToRemote')]
+    public function testSendUpdateToRemote(int $try, array $httpRequestResult, bool $expected): void {
+        $remote = 'http://remote';
+        $id = 42;
+        $timestamp = 63576;
+        $token = 'token';
+        $action = 'unshare';
+        $instance = $this->getInstance(['tryHttpPostToShareEndpoint', 'getTimestamp']);
 
-		$instance->expects($this->any())->method('getTimestamp')->willReturn($timestamp);
+        $instance->expects($this->any())->method('getTimestamp')->willReturn($timestamp);
 
-		$instance->expects($this->once())->method('tryHttpPostToShareEndpoint')
-			->with($remote, '/' . $id . '/unshare', ['token' => $token, 'data1Key' => 'data1Value', 'remoteId' => $id], $action)
-			->willReturn($httpRequestResult);
+        $instance->expects($this->once())->method('tryHttpPostToShareEndpoint')
+            ->with($remote, '/' . $id . '/unshare', ['token' => $token, 'data1Key' => 'data1Value', 'remoteId' => $id], $action)
+            ->willReturn($httpRequestResult);
 
-		// only add background job on first try
-		if ($try === 0 && $expected === false) {
-			$this->jobList->expects($this->once())->method('add')
-				->with(
-					RetryJob::class,
-					[
-						'remote' => $remote,
-						'remoteId' => $id,
-						'action' => 'unshare',
-						'data' => json_encode(['data1Key' => 'data1Value']),
-						'token' => $token,
-						'try' => $try,
-						'lastRun' => $timestamp
-					]
-				);
-		} else {
-			$this->jobList->expects($this->never())->method('add');
-		}
+        // only add background job on first try
+        if ($try === 0 && $expected === false) {
+            $this->jobList->expects($this->once())->method('add')
+                ->with(
+                    RetryJob::class,
+                    [
+                        'remote' => $remote,
+                        'remoteId' => $id,
+                        'action' => 'unshare',
+                        'data' => json_encode(['data1Key' => 'data1Value']),
+                        'token' => $token,
+                        'try' => $try,
+                        'lastRun' => $timestamp
+                    ]
+                );
+        } else {
+            $this->jobList->expects($this->never())->method('add');
+        }
 
-		$this->assertSame($expected,
-			$instance->sendUpdateToRemote($remote, $id, $token, $action, ['data1Key' => 'data1Value'], $try)
-		);
-	}
+        $this->assertSame($expected,
+            $instance->sendUpdateToRemote($remote, $id, $token, $action, ['data1Key' => 'data1Value'], $try)
+        );
+    }
 
 
-	public static function dataTestSendUpdateToRemote(): array {
-		return [
-			// test if background job is added correctly
-			[0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
-			[1, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
-			[0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
-			[1, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
-			// test all combinations of 'statuscode' and 'success'
-			[0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
-			[0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 100]]])], true],
-			[0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 400]]])], false],
-			[0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
-			[0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 100]]])], false],
-			[0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 400]]])], false],
-		];
-	}
+    public static function dataTestSendUpdateToRemote(): array {
+        return [
+            // test if background job is added correctly
+            [0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
+            [1, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
+            [0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
+            [1, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
+            // test all combinations of 'statuscode' and 'success'
+            [0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], true],
+            [0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 100]]])], true],
+            [0, ['success' => true, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 400]]])], false],
+            [0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 200]]])], false],
+            [0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 100]]])], false],
+            [0, ['success' => false, 'result' => json_encode(['ocs' => ['meta' => ['statuscode' => 400]]])], false],
+        ];
+    }
 }

apps/federatedfilesharing/tests/FederatedShareProviderTest.php

Indentation +912 added lines, -912 removed lines

@@ -39,916 +39,916 @@
  * @group DB
  */
 class FederatedShareProviderTest extends \Test\TestCase {
-	protected IDBConnection $connection;
-	protected AddressHandler&MockObject $addressHandler;
-	protected Notifications&MockObject $notifications;
-	protected TokenHandler&MockObject $tokenHandler;
-	protected IL10N $l;
-	protected LoggerInterface $logger;
-	protected IRootFolder&MockObject $rootFolder;
-	protected IConfig&MockObject $config;
-	protected IUserManager&MockObject $userManager;
-	protected \OCP\GlobalScale\IConfig&MockObject $gsConfig;
-	protected IManager $shareManager;
-	protected FederatedShareProvider $provider;
-	protected IContactsManager&MockObject $contactsManager;
-	private ICloudIdManager $cloudIdManager;
-	private ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-		$this->notifications = $this->createMock(Notifications::class);
-		$this->tokenHandler = $this->createMock(TokenHandler::class);
-		$this->l = $this->createMock(IL10N::class);
-		$this->l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		//$this->addressHandler = new AddressHandler(\OC::$server->getURLGenerator(), $this->l);
-		$this->addressHandler = $this->createMock(AddressHandler::class);
-		$this->contactsManager = $this->createMock(IContactsManager::class);
-		$this->cloudIdManager = new CloudIdManager(
-			$this->contactsManager,
-			$this->createMock(IURLGenerator::class),
-			$this->userManager,
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		);
-		$this->gsConfig = $this->createMock(\OCP\GlobalScale\IConfig::class);
-
-		$this->userManager->expects($this->any())->method('userExists')->willReturn(true);
-
-		$this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
-
-		$this->provider = new FederatedShareProvider(
-			$this->connection,
-			$this->addressHandler,
-			$this->notifications,
-			$this->tokenHandler,
-			$this->l,
-			$this->rootFolder,
-			$this->config,
-			$this->userManager,
-			$this->cloudIdManager,
-			$this->gsConfig,
-			$this->cloudFederationProviderManager,
-			$this->logger,
-		);
-
-		$this->shareManager = Server::get(IManager::class);
-	}
-
-	protected function tearDown(): void {
-		$this->connection->getQueryBuilder()->delete('share')->executeStatement();
-
-		parent::tearDown();
-	}
-
-	public static function dataTestCreate(): array {
-		return [
-			[null, null],
-			[new \DateTime('2020-03-01T01:02:03'), '2020-03-01 01:02:03'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreate')]
-	public function testCreate(?\DateTime $expirationDate, ?string $expectedDataDate): void {
-		$share = $this->shareManager->newShare();
-
-		/** @var File&MockObject $node */
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setExpirationDate($expirationDate)
-			->setNode($node);
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-
-		$this->addressHandler->expects($this->any())->method('generateRemoteURL')
-			->willReturn('http://localhost/');
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturn(['user', 'server.com']);
-
-		$this->notifications->expects($this->once())
-			->method('sendRemoteShare')
-			->with(
-				$this->equalTo('token'),
-				$this->equalTo('user@server.com'),
-				$this->equalTo('myFile'),
-				$this->anything(),
-				'shareOwner',
-				'shareOwner@http://localhost',
-				'sharedBy',
-				'sharedBy@http://localhost'
-			)
-			->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->provider->create($share);
-
-		$qb = $this->connection->getQueryBuilder();
-		$stmt = $qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
-			->executeQuery();
-
-		$data = $stmt->fetch();
-		$stmt->closeCursor();
-
-		$expected = [
-			'share_type' => IShare::TYPE_REMOTE,
-			'share_with' => 'user@server.com',
-			'uid_owner' => 'shareOwner',
-			'uid_initiator' => 'sharedBy',
-			'item_type' => 'file',
-			'item_source' => 42,
-			'file_source' => 42,
-			'permissions' => 19,
-			'accepted' => 0,
-			'token' => 'token',
-			'expiration' => $expectedDataDate,
-		];
-		foreach (array_keys($expected) as $key) {
-			$this->assertEquals($expected[$key], $data[$key], "Assert that value for key '$key' is the same");
-		}
-
-		$this->assertEquals($data['id'], $share->getId());
-		$this->assertEquals(IShare::TYPE_REMOTE, $share->getShareType());
-		$this->assertEquals('user@server.com', $share->getSharedWith());
-		$this->assertEquals('sharedBy', $share->getSharedBy());
-		$this->assertEquals('shareOwner', $share->getShareOwner());
-		$this->assertEquals('file', $share->getNodeType());
-		$this->assertEquals(42, $share->getNodeId());
-		$this->assertEquals(19, $share->getPermissions());
-		$this->assertEquals('token', $share->getToken());
-		$this->assertEquals($expirationDate, $share->getExpirationDate());
-	}
-
-	public function testCreateCouldNotFindServer(): void {
-		$share = $this->shareManager->newShare();
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-
-		$this->addressHandler->expects($this->any())->method('generateRemoteURL')
-			->willReturn('http://localhost/');
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturn(['user', 'server.com']);
-
-		$this->notifications->expects($this->once())
-			->method('sendRemoteShare')
-			->with(
-				$this->equalTo('token'),
-				$this->equalTo('user@server.com'),
-				$this->equalTo('myFile'),
-				$this->anything(),
-				'shareOwner',
-				'shareOwner@http://localhost',
-				'sharedBy',
-				'sharedBy@http://localhost'
-			)->willReturn(false);
-
-		$this->rootFolder->method('getById')
-			->with('42')
-			->willReturn([$node]);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		try {
-			$share = $this->provider->create($share);
-			$this->fail();
-		} catch (\Exception $e) {
-			$this->assertEquals('Sharing myFile failed, could not find user@server.com, maybe the server is currently unreachable or uses a self-signed certificate.', $e->getMessage());
-		}
-
-		$qb = $this->connection->getQueryBuilder();
-		$stmt = $qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
-			->executeQuery();
-
-		$data = $stmt->fetch();
-		$stmt->closeCursor();
-
-		$this->assertFalse($data);
-	}
-
-	public function testCreateException(): void {
-		$share = $this->shareManager->newShare();
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-
-		$this->addressHandler->expects($this->any())->method('generateRemoteURL')
-			->willReturn('http://localhost/');
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturn(['user', 'server.com']);
-
-		$this->notifications->expects($this->once())
-			->method('sendRemoteShare')
-			->with(
-				$this->equalTo('token'),
-				$this->equalTo('user@server.com'),
-				$this->equalTo('myFile'),
-				$this->anything(),
-				'shareOwner',
-				'shareOwner@http://localhost',
-				'sharedBy',
-				'sharedBy@http://localhost'
-			)->willThrowException(new \Exception('dummy'));
-
-		$this->rootFolder->method('getById')
-			->with('42')
-			->willReturn([$node]);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		try {
-			$share = $this->provider->create($share);
-			$this->fail();
-		} catch (\Exception $e) {
-			$this->assertEquals('Sharing myFile failed, could not find user@server.com, maybe the server is currently unreachable or uses a self-signed certificate.', $e->getMessage());
-		}
-
-		$qb = $this->connection->getQueryBuilder();
-		$stmt = $qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
-			->executeQuery();
-
-		$data = $stmt->fetch();
-		$stmt->closeCursor();
-
-		$this->assertFalse($data);
-	}
-
-	public function testCreateShareWithSelf(): void {
-		$share = $this->shareManager->newShare();
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->addressHandler->expects($this->any())->method('compareAddresses')
-			->willReturn(true);
-
-		$shareWith = 'sharedBy@localhost';
-
-		$share->setSharedWith($shareWith)
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setNode($node);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		try {
-			$share = $this->provider->create($share);
-			$this->fail();
-		} catch (\Exception $e) {
-			$this->assertEquals('Not allowed to create a federated share to the same account', $e->getMessage());
-		}
-
-		$qb = $this->connection->getQueryBuilder();
-		$stmt = $qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
-			->executeQuery();
-
-		$data = $stmt->fetch();
-		$stmt->closeCursor();
-
-		$this->assertFalse($data);
-	}
-
-	public function testCreateAlreadyShared(): void {
-		$share = $this->shareManager->newShare();
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturn(['user', 'server.com']);
-
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-
-		$this->addressHandler->expects($this->any())->method('generateRemoteURL')
-			->willReturn('http://localhost/');
-
-		$this->notifications->expects($this->once())
-			->method('sendRemoteShare')
-			->with(
-				$this->equalTo('token'),
-				$this->equalTo('user@server.com'),
-				$this->equalTo('myFile'),
-				$this->anything(),
-				'shareOwner',
-				'shareOwner@http://localhost',
-				'sharedBy',
-				'sharedBy@http://localhost'
-			)->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$this->provider->create($share);
-
-		try {
-			$this->provider->create($share);
-		} catch (\Exception $e) {
-			$this->assertEquals('Sharing myFile failed, because this item is already shared with the account user@server.com', $e->getMessage());
-		}
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestUpdate')]
-	public function testUpdate(string $owner, string $sharedBy, ?\DateTime $expirationDate): void {
-		$this->provider = $this->getMockBuilder(FederatedShareProvider::class)
-			->setConstructorArgs(
-				[
-					$this->connection,
-					$this->addressHandler,
-					$this->notifications,
-					$this->tokenHandler,
-					$this->l,
-					$this->rootFolder,
-					$this->config,
-					$this->userManager,
-					$this->cloudIdManager,
-					$this->gsConfig,
-					$this->cloudFederationProviderManager,
-					$this->logger,
-				]
-			)
-			->onlyMethods(['sendPermissionUpdate'])
-			->getMock();
-
-		$share = $this->shareManager->newShare();
-
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturn(['user', 'server.com']);
-
-		$share->setSharedWith('user@server.com')
-			->setSharedBy($sharedBy)
-			->setShareOwner($owner)
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setExpirationDate(new \DateTime('2019-02-01T01:02:03'))
-			->setNode($node);
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->addressHandler->expects($this->any())->method('generateRemoteURL')
-			->willReturn('http://localhost/');
-
-		$this->notifications->expects($this->once())
-			->method('sendRemoteShare')
-			->with(
-				$this->equalTo('token'),
-				$this->equalTo('user@server.com'),
-				$this->equalTo('myFile'),
-				$this->anything(),
-				$owner,
-				$owner . '@http://localhost',
-				$sharedBy,
-				$sharedBy . '@http://localhost'
-			)->willReturn(true);
-
-		if ($owner === $sharedBy) {
-			$this->provider->expects($this->never())->method('sendPermissionUpdate');
-		} else {
-			$this->provider->expects($this->once())->method('sendPermissionUpdate');
-		}
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->provider->create($share);
-
-		$share->setPermissions(1);
-		$share->setExpirationDate($expirationDate);
-		$this->provider->update($share);
-
-		$share = $this->provider->getShareById($share->getId());
-
-		$this->assertEquals(1, $share->getPermissions());
-		$this->assertEquals($expirationDate, $share->getExpirationDate());
-	}
-
-	public static function dataTestUpdate(): array {
-		return [
-			['sharedBy', 'shareOwner', new \DateTime('2020-03-01T01:02:03')],
-			['shareOwner', 'shareOwner', null],
-		];
-	}
-
-	public function testGetSharedBy(): void {
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->addressHandler->expects($this->never())->method('splitUserRemote');
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->notifications
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->shareManager->newShare();
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user2@server.com')
-			->setSharedBy('sharedBy2')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share2);
-
-		$shares = $this->provider->getSharesBy('sharedBy', IShare::TYPE_REMOTE, null, false, -1, 0);
-
-		$this->assertCount(1, $shares);
-		$this->assertEquals('user@server.com', $shares[0]->getSharedWith());
-		$this->assertEquals('sharedBy', $shares[0]->getSharedBy());
-	}
-
-	public function testGetSharedByWithNode(): void {
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->notifications
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->shareManager->newShare();
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share);
-
-		$node2 = $this->getMockBuilder(File::class)->getMock();
-		$node2->method('getId')->willReturn(43);
-		$node2->method('getName')->willReturn('myOtherFile');
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node2);
-		$this->provider->create($share2);
-
-		$shares = $this->provider->getSharesBy('sharedBy', IShare::TYPE_REMOTE, $node2, false, -1, 0);
-
-		$this->assertCount(1, $shares);
-		$this->assertEquals(43, $shares[0]->getNodeId());
-	}
-
-	public function testGetSharedByWithReshares(): void {
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->notifications
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->shareManager->newShare();
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('shareOwner')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user2@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share2);
-
-		$shares = $this->provider->getSharesBy('shareOwner', IShare::TYPE_REMOTE, null, true, -1, 0);
-
-		$this->assertCount(2, $shares);
-	}
-
-	public function testGetSharedByWithLimit(): void {
-		$node = $this->createMock(File::class);
-		$node->method('getId')->willReturn(42);
-		$node->method('getName')->willReturn('myFile');
-
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'user@server.com') {
-					return ['user', 'server.com'];
-				}
-				return ['user2', 'server.com'];
-			});
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->notifications
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->rootFolder->expects($this->never())->method($this->anything());
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share = $this->shareManager->newShare();
-		$share->setSharedWith('user@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user2@server.com')
-			->setSharedBy('sharedBy')
-			->setShareOwner('shareOwner')
-			->setPermissions(19)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($node);
-		$this->provider->create($share2);
-
-		$shares = $this->provider->getSharesBy('shareOwner', IShare::TYPE_REMOTE, null, true, 1, 1);
-
-		$this->assertCount(1, $shares);
-		$this->assertEquals('user2@server.com', $shares[0]->getSharedWith());
-	}
-
-	public static function dataDeleteUser(): array {
-		return [
-			['a', 'b', 'c', 'a', true],
-			['a', 'b', 'c', 'b', false],
-			// The recipient is non local.
-			['a', 'b', 'c', 'c', false],
-			['a', 'b', 'c', 'd', false],
-		];
-	}
-
-	/**
-	 *
-	 * @param string $owner The owner of the share (uid)
-	 * @param string $initiator The initiator of the share (uid)
-	 * @param string $recipient The recipient of the share (uid/gid/pass)
-	 * @param string $deletedUser The user that is deleted
-	 * @param bool $rowDeleted Is the row deleted in this setup
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataDeleteUser')]
-	public function testDeleteUser(string $owner, string $initiator, string $recipient, string $deletedUser, bool $rowDeleted): void {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->setValue('share_type', $qb->createNamedParameter(IShare::TYPE_REMOTE))
-			->setValue('uid_owner', $qb->createNamedParameter($owner))
-			->setValue('uid_initiator', $qb->createNamedParameter($initiator))
-			->setValue('share_with', $qb->createNamedParameter($recipient))
-			->setValue('item_type', $qb->createNamedParameter('file'))
-			->setValue('item_source', $qb->createNamedParameter(42))
-			->setValue('file_source', $qb->createNamedParameter(42))
-			->executeStatement();
-
-		$id = $qb->getLastInsertId();
-
-		$this->provider->userDeleted($deletedUser, IShare::TYPE_REMOTE);
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->select('*')
-			->from('share')
-			->where(
-				$qb->expr()->eq('id', $qb->createNamedParameter($id))
-			);
-		$cursor = $qb->executeQuery();
-		$data = $cursor->fetchAll();
-		$cursor->closeCursor();
-
-		$this->assertCount($rowDeleted ? 0 : 1, $data);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsOutgoingServer2serverShareEnabled')]
-	public function testIsOutgoingServer2serverShareEnabled(bool $internalOnly, string $isEnabled, bool $expected): void {
-		$this->gsConfig->expects($this->once())->method('onlyInternalFederation')
-			->willReturn($internalOnly);
-		$this->config->expects($this->any())->method('getAppValue')
-			->with('files_sharing', 'outgoing_server2server_share_enabled', 'yes')
-			->willReturn($isEnabled);
-
-		$this->assertSame($expected,
-			$this->provider->isOutgoingServer2serverShareEnabled()
-		);
-	}
-
-	public static function dataTestIsOutgoingServer2serverShareEnabled(): array {
-		return [
-			[false, 'yes', true],
-			[false, 'no', false],
-			[true, 'yes', false],
-			[true, 'no', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsIncomingServer2serverShareEnabled')]
-	public function testIsIncomingServer2serverShareEnabled(bool $onlyInternal, string $isEnabled, bool $expected): void {
-		$this->gsConfig->expects($this->once())->method('onlyInternalFederation')
-			->willReturn($onlyInternal);
-		$this->config->expects($this->any())->method('getAppValue')
-			->with('files_sharing', 'incoming_server2server_share_enabled', 'yes')
-			->willReturn($isEnabled);
-
-		$this->assertSame($expected,
-			$this->provider->isIncomingServer2serverShareEnabled()
-		);
-	}
-
-	public static function dataTestIsIncomingServer2serverShareEnabled(): array {
-		return [
-			[false, 'yes', true],
-			[false, 'no', false],
-			[true, 'yes', false],
-			[true, 'no', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsLookupServerQueriesEnabled')]
-	public function testIsLookupServerQueriesEnabled(bool $gsEnabled, string $isEnabled, bool $expected): void {
-		$this->gsConfig->expects($this->once())->method('isGlobalScaleEnabled')
-			->willReturn($gsEnabled);
-		$this->config->expects($this->any())->method('getAppValue')
-			->with('files_sharing', 'lookupServerEnabled', 'no')
-			->willReturn($isEnabled);
-
-		$this->assertSame($expected,
-			$this->provider->isLookupServerQueriesEnabled()
-		);
-	}
-
-
-	public static function dataTestIsLookupServerQueriesEnabled(): array {
-		return [
-			[true, 'yes', true],
-			[true, 'no', true],
-			// TODO: reenable if we use the lookup server for non-global scale
-			// [false, 'yes', true],
-			// [false, 'no', false],
-			[false, 'no', false],
-			[false, 'yes', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsLookupServerUploadEnabled')]
-	public function testIsLookupServerUploadEnabled(bool $gsEnabled, string $isEnabled, bool $expected): void {
-		$this->gsConfig->expects($this->once())->method('isGlobalScaleEnabled')
-			->willReturn($gsEnabled);
-		$this->config->expects($this->any())->method('getAppValue')
-			->with('files_sharing', 'lookupServerUploadEnabled', 'no')
-			->willReturn($isEnabled);
-
-		$this->assertSame($expected,
-			$this->provider->isLookupServerUploadEnabled()
-		);
-	}
-
-	public static function dataTestIsLookupServerUploadEnabled(): array {
-		return [
-			[true, 'yes', false],
-			[true, 'no', false],
-			// TODO: reenable if we use the lookup server again
-			// [false, 'yes', true],
-			// [false, 'no', false],
-			[false, 'yes', false],
-			[false, 'no', false],
-		];
-	}
-
-	public function testGetSharesInFolder(): void {
-		$userManager = Server::get(IUserManager::class);
-		$rootFolder = Server::get(IRootFolder::class);
-
-		$u1 = $userManager->createUser('testFed', md5((string)time()));
-		$u2 = $userManager->createUser('testFed2', md5((string)time()));
-
-		$folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
-		$file1 = $folder1->newFile('bar1');
-		$file2 = $folder1->newFile('bar2');
-
-		$this->tokenHandler->method('generateToken')->willReturn('token');
-		$this->notifications
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$share1 = $this->shareManager->newShare();
-		$share1->setSharedWith('user@server.com')
-			->setSharedBy($u1->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($file1);
-		$this->provider->create($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('user@server.com')
-			->setSharedBy($u2->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($file2);
-		$this->provider->create($share2);
-
-		$result = $this->provider->getSharesInFolder($u1->getUID(), $folder1, false);
-		$this->assertCount(1, $result);
-		$this->assertCount(1, $result[$file1->getId()]);
-
-		$result = $this->provider->getSharesInFolder($u1->getUID(), $folder1, true);
-		$this->assertCount(2, $result);
-		$this->assertCount(1, $result[$file1->getId()]);
-		$this->assertCount(1, $result[$file2->getId()]);
-
-		$u1->delete();
-		$u2->delete();
-	}
-
-	public function testGetAccessList(): void {
-		$userManager = Server::get(IUserManager::class);
-		$rootFolder = Server::get(IRootFolder::class);
-
-		$u1 = $userManager->createUser('testFed', md5((string)time()));
-
-		$folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
-		$file1 = $folder1->newFile('bar1');
-
-		$this->tokenHandler->expects($this->exactly(2))
-			->method('generateToken')
-			->willReturnOnConsecutiveCalls('token1', 'token2');
-		$this->notifications->expects($this->atLeastOnce())
-			->method('sendRemoteShare')
-			->willReturn(true);
-
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$result = $this->provider->getAccessList([$file1], true);
-		$this->assertEquals(['remote' => []], $result);
-
-		$result = $this->provider->getAccessList([$file1], false);
-		$this->assertEquals(['remote' => false], $result);
-
-		$this->addressHandler->method('generateRemoteURL')
-			->willReturn('remoteurl.com');
-
-		$share1 = $this->shareManager->newShare();
-		$share1->setSharedWith('user@server.com')
-			->setSharedBy($u1->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($file1);
-		$this->provider->create($share1);
-
-		$share2 = $this->shareManager->newShare();
-		$share2->setSharedWith('foobar@localhost')
-			->setSharedBy($u1->getUID())
-			->setShareOwner($u1->getUID())
-			->setPermissions(Constants::PERMISSION_READ)
-			->setShareType(IShare::TYPE_REMOTE)
-			->setNode($file1);
-		$this->provider->create($share2);
-
-		$result = $this->provider->getAccessList([$file1], true);
-		$this->assertEquals(['remote' => [
-			'user@server.com' => [
-				'token' => 'token1',
-				'node_id' => $file1->getId(),
-			],
-			'foobar@localhost' => [
-				'token' => 'token2',
-				'node_id' => $file1->getId(),
-			],
-		]], $result);
-
-		$result = $this->provider->getAccessList([$file1], false);
-		$this->assertEquals(['remote' => true], $result);
-
-		$u1->delete();
-	}
+    protected IDBConnection $connection;
+    protected AddressHandler&MockObject $addressHandler;
+    protected Notifications&MockObject $notifications;
+    protected TokenHandler&MockObject $tokenHandler;
+    protected IL10N $l;
+    protected LoggerInterface $logger;
+    protected IRootFolder&MockObject $rootFolder;
+    protected IConfig&MockObject $config;
+    protected IUserManager&MockObject $userManager;
+    protected \OCP\GlobalScale\IConfig&MockObject $gsConfig;
+    protected IManager $shareManager;
+    protected FederatedShareProvider $provider;
+    protected IContactsManager&MockObject $contactsManager;
+    private ICloudIdManager $cloudIdManager;
+    private ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+        $this->notifications = $this->createMock(Notifications::class);
+        $this->tokenHandler = $this->createMock(TokenHandler::class);
+        $this->l = $this->createMock(IL10N::class);
+        $this->l->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        //$this->addressHandler = new AddressHandler(\OC::$server->getURLGenerator(), $this->l);
+        $this->addressHandler = $this->createMock(AddressHandler::class);
+        $this->contactsManager = $this->createMock(IContactsManager::class);
+        $this->cloudIdManager = new CloudIdManager(
+            $this->contactsManager,
+            $this->createMock(IURLGenerator::class),
+            $this->userManager,
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        );
+        $this->gsConfig = $this->createMock(\OCP\GlobalScale\IConfig::class);
+
+        $this->userManager->expects($this->any())->method('userExists')->willReturn(true);
+
+        $this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
+
+        $this->provider = new FederatedShareProvider(
+            $this->connection,
+            $this->addressHandler,
+            $this->notifications,
+            $this->tokenHandler,
+            $this->l,
+            $this->rootFolder,
+            $this->config,
+            $this->userManager,
+            $this->cloudIdManager,
+            $this->gsConfig,
+            $this->cloudFederationProviderManager,
+            $this->logger,
+        );
+
+        $this->shareManager = Server::get(IManager::class);
+    }
+
+    protected function tearDown(): void {
+        $this->connection->getQueryBuilder()->delete('share')->executeStatement();
+
+        parent::tearDown();
+    }
+
+    public static function dataTestCreate(): array {
+        return [
+            [null, null],
+            [new \DateTime('2020-03-01T01:02:03'), '2020-03-01 01:02:03'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreate')]
+    public function testCreate(?\DateTime $expirationDate, ?string $expectedDataDate): void {
+        $share = $this->shareManager->newShare();
+
+        /** @var File&MockObject $node */
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setExpirationDate($expirationDate)
+            ->setNode($node);
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+
+        $this->addressHandler->expects($this->any())->method('generateRemoteURL')
+            ->willReturn('http://localhost/');
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturn(['user', 'server.com']);
+
+        $this->notifications->expects($this->once())
+            ->method('sendRemoteShare')
+            ->with(
+                $this->equalTo('token'),
+                $this->equalTo('user@server.com'),
+                $this->equalTo('myFile'),
+                $this->anything(),
+                'shareOwner',
+                'shareOwner@http://localhost',
+                'sharedBy',
+                'sharedBy@http://localhost'
+            )
+            ->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->provider->create($share);
+
+        $qb = $this->connection->getQueryBuilder();
+        $stmt = $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
+            ->executeQuery();
+
+        $data = $stmt->fetch();
+        $stmt->closeCursor();
+
+        $expected = [
+            'share_type' => IShare::TYPE_REMOTE,
+            'share_with' => 'user@server.com',
+            'uid_owner' => 'shareOwner',
+            'uid_initiator' => 'sharedBy',
+            'item_type' => 'file',
+            'item_source' => 42,
+            'file_source' => 42,
+            'permissions' => 19,
+            'accepted' => 0,
+            'token' => 'token',
+            'expiration' => $expectedDataDate,
+        ];
+        foreach (array_keys($expected) as $key) {
+            $this->assertEquals($expected[$key], $data[$key], "Assert that value for key '$key' is the same");
+        }
+
+        $this->assertEquals($data['id'], $share->getId());
+        $this->assertEquals(IShare::TYPE_REMOTE, $share->getShareType());
+        $this->assertEquals('user@server.com', $share->getSharedWith());
+        $this->assertEquals('sharedBy', $share->getSharedBy());
+        $this->assertEquals('shareOwner', $share->getShareOwner());
+        $this->assertEquals('file', $share->getNodeType());
+        $this->assertEquals(42, $share->getNodeId());
+        $this->assertEquals(19, $share->getPermissions());
+        $this->assertEquals('token', $share->getToken());
+        $this->assertEquals($expirationDate, $share->getExpirationDate());
+    }
+
+    public function testCreateCouldNotFindServer(): void {
+        $share = $this->shareManager->newShare();
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+
+        $this->addressHandler->expects($this->any())->method('generateRemoteURL')
+            ->willReturn('http://localhost/');
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturn(['user', 'server.com']);
+
+        $this->notifications->expects($this->once())
+            ->method('sendRemoteShare')
+            ->with(
+                $this->equalTo('token'),
+                $this->equalTo('user@server.com'),
+                $this->equalTo('myFile'),
+                $this->anything(),
+                'shareOwner',
+                'shareOwner@http://localhost',
+                'sharedBy',
+                'sharedBy@http://localhost'
+            )->willReturn(false);
+
+        $this->rootFolder->method('getById')
+            ->with('42')
+            ->willReturn([$node]);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        try {
+            $share = $this->provider->create($share);
+            $this->fail();
+        } catch (\Exception $e) {
+            $this->assertEquals('Sharing myFile failed, could not find user@server.com, maybe the server is currently unreachable or uses a self-signed certificate.', $e->getMessage());
+        }
+
+        $qb = $this->connection->getQueryBuilder();
+        $stmt = $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
+            ->executeQuery();
+
+        $data = $stmt->fetch();
+        $stmt->closeCursor();
+
+        $this->assertFalse($data);
+    }
+
+    public function testCreateException(): void {
+        $share = $this->shareManager->newShare();
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+
+        $this->addressHandler->expects($this->any())->method('generateRemoteURL')
+            ->willReturn('http://localhost/');
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturn(['user', 'server.com']);
+
+        $this->notifications->expects($this->once())
+            ->method('sendRemoteShare')
+            ->with(
+                $this->equalTo('token'),
+                $this->equalTo('user@server.com'),
+                $this->equalTo('myFile'),
+                $this->anything(),
+                'shareOwner',
+                'shareOwner@http://localhost',
+                'sharedBy',
+                'sharedBy@http://localhost'
+            )->willThrowException(new \Exception('dummy'));
+
+        $this->rootFolder->method('getById')
+            ->with('42')
+            ->willReturn([$node]);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        try {
+            $share = $this->provider->create($share);
+            $this->fail();
+        } catch (\Exception $e) {
+            $this->assertEquals('Sharing myFile failed, could not find user@server.com, maybe the server is currently unreachable or uses a self-signed certificate.', $e->getMessage());
+        }
+
+        $qb = $this->connection->getQueryBuilder();
+        $stmt = $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
+            ->executeQuery();
+
+        $data = $stmt->fetch();
+        $stmt->closeCursor();
+
+        $this->assertFalse($data);
+    }
+
+    public function testCreateShareWithSelf(): void {
+        $share = $this->shareManager->newShare();
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->addressHandler->expects($this->any())->method('compareAddresses')
+            ->willReturn(true);
+
+        $shareWith = 'sharedBy@localhost';
+
+        $share->setSharedWith($shareWith)
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setNode($node);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        try {
+            $share = $this->provider->create($share);
+            $this->fail();
+        } catch (\Exception $e) {
+            $this->assertEquals('Not allowed to create a federated share to the same account', $e->getMessage());
+        }
+
+        $qb = $this->connection->getQueryBuilder();
+        $stmt = $qb->select('*')
+            ->from('share')
+            ->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId())))
+            ->executeQuery();
+
+        $data = $stmt->fetch();
+        $stmt->closeCursor();
+
+        $this->assertFalse($data);
+    }
+
+    public function testCreateAlreadyShared(): void {
+        $share = $this->shareManager->newShare();
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturn(['user', 'server.com']);
+
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+
+        $this->addressHandler->expects($this->any())->method('generateRemoteURL')
+            ->willReturn('http://localhost/');
+
+        $this->notifications->expects($this->once())
+            ->method('sendRemoteShare')
+            ->with(
+                $this->equalTo('token'),
+                $this->equalTo('user@server.com'),
+                $this->equalTo('myFile'),
+                $this->anything(),
+                'shareOwner',
+                'shareOwner@http://localhost',
+                'sharedBy',
+                'sharedBy@http://localhost'
+            )->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $this->provider->create($share);
+
+        try {
+            $this->provider->create($share);
+        } catch (\Exception $e) {
+            $this->assertEquals('Sharing myFile failed, because this item is already shared with the account user@server.com', $e->getMessage());
+        }
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestUpdate')]
+    public function testUpdate(string $owner, string $sharedBy, ?\DateTime $expirationDate): void {
+        $this->provider = $this->getMockBuilder(FederatedShareProvider::class)
+            ->setConstructorArgs(
+                [
+                    $this->connection,
+                    $this->addressHandler,
+                    $this->notifications,
+                    $this->tokenHandler,
+                    $this->l,
+                    $this->rootFolder,
+                    $this->config,
+                    $this->userManager,
+                    $this->cloudIdManager,
+                    $this->gsConfig,
+                    $this->cloudFederationProviderManager,
+                    $this->logger,
+                ]
+            )
+            ->onlyMethods(['sendPermissionUpdate'])
+            ->getMock();
+
+        $share = $this->shareManager->newShare();
+
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturn(['user', 'server.com']);
+
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy($sharedBy)
+            ->setShareOwner($owner)
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setExpirationDate(new \DateTime('2019-02-01T01:02:03'))
+            ->setNode($node);
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->addressHandler->expects($this->any())->method('generateRemoteURL')
+            ->willReturn('http://localhost/');
+
+        $this->notifications->expects($this->once())
+            ->method('sendRemoteShare')
+            ->with(
+                $this->equalTo('token'),
+                $this->equalTo('user@server.com'),
+                $this->equalTo('myFile'),
+                $this->anything(),
+                $owner,
+                $owner . '@http://localhost',
+                $sharedBy,
+                $sharedBy . '@http://localhost'
+            )->willReturn(true);
+
+        if ($owner === $sharedBy) {
+            $this->provider->expects($this->never())->method('sendPermissionUpdate');
+        } else {
+            $this->provider->expects($this->once())->method('sendPermissionUpdate');
+        }
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->provider->create($share);
+
+        $share->setPermissions(1);
+        $share->setExpirationDate($expirationDate);
+        $this->provider->update($share);
+
+        $share = $this->provider->getShareById($share->getId());
+
+        $this->assertEquals(1, $share->getPermissions());
+        $this->assertEquals($expirationDate, $share->getExpirationDate());
+    }
+
+    public static function dataTestUpdate(): array {
+        return [
+            ['sharedBy', 'shareOwner', new \DateTime('2020-03-01T01:02:03')],
+            ['shareOwner', 'shareOwner', null],
+        ];
+    }
+
+    public function testGetSharedBy(): void {
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->addressHandler->expects($this->never())->method('splitUserRemote');
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->notifications
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->shareManager->newShare();
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user2@server.com')
+            ->setSharedBy('sharedBy2')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share2);
+
+        $shares = $this->provider->getSharesBy('sharedBy', IShare::TYPE_REMOTE, null, false, -1, 0);
+
+        $this->assertCount(1, $shares);
+        $this->assertEquals('user@server.com', $shares[0]->getSharedWith());
+        $this->assertEquals('sharedBy', $shares[0]->getSharedBy());
+    }
+
+    public function testGetSharedByWithNode(): void {
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->notifications
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->shareManager->newShare();
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share);
+
+        $node2 = $this->getMockBuilder(File::class)->getMock();
+        $node2->method('getId')->willReturn(43);
+        $node2->method('getName')->willReturn('myOtherFile');
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node2);
+        $this->provider->create($share2);
+
+        $shares = $this->provider->getSharesBy('sharedBy', IShare::TYPE_REMOTE, $node2, false, -1, 0);
+
+        $this->assertCount(1, $shares);
+        $this->assertEquals(43, $shares[0]->getNodeId());
+    }
+
+    public function testGetSharedByWithReshares(): void {
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->notifications
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->shareManager->newShare();
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('shareOwner')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user2@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share2);
+
+        $shares = $this->provider->getSharesBy('shareOwner', IShare::TYPE_REMOTE, null, true, -1, 0);
+
+        $this->assertCount(2, $shares);
+    }
+
+    public function testGetSharedByWithLimit(): void {
+        $node = $this->createMock(File::class);
+        $node->method('getId')->willReturn(42);
+        $node->method('getName')->willReturn('myFile');
+
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->willReturnCallback(function ($uid) {
+                if ($uid === 'user@server.com') {
+                    return ['user', 'server.com'];
+                }
+                return ['user2', 'server.com'];
+            });
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->notifications
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->rootFolder->expects($this->never())->method($this->anything());
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share = $this->shareManager->newShare();
+        $share->setSharedWith('user@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user2@server.com')
+            ->setSharedBy('sharedBy')
+            ->setShareOwner('shareOwner')
+            ->setPermissions(19)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($node);
+        $this->provider->create($share2);
+
+        $shares = $this->provider->getSharesBy('shareOwner', IShare::TYPE_REMOTE, null, true, 1, 1);
+
+        $this->assertCount(1, $shares);
+        $this->assertEquals('user2@server.com', $shares[0]->getSharedWith());
+    }
+
+    public static function dataDeleteUser(): array {
+        return [
+            ['a', 'b', 'c', 'a', true],
+            ['a', 'b', 'c', 'b', false],
+            // The recipient is non local.
+            ['a', 'b', 'c', 'c', false],
+            ['a', 'b', 'c', 'd', false],
+        ];
+    }
+
+    /**
+     *
+     * @param string $owner The owner of the share (uid)
+     * @param string $initiator The initiator of the share (uid)
+     * @param string $recipient The recipient of the share (uid/gid/pass)
+     * @param string $deletedUser The user that is deleted
+     * @param bool $rowDeleted Is the row deleted in this setup
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataDeleteUser')]
+    public function testDeleteUser(string $owner, string $initiator, string $recipient, string $deletedUser, bool $rowDeleted): void {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->setValue('share_type', $qb->createNamedParameter(IShare::TYPE_REMOTE))
+            ->setValue('uid_owner', $qb->createNamedParameter($owner))
+            ->setValue('uid_initiator', $qb->createNamedParameter($initiator))
+            ->setValue('share_with', $qb->createNamedParameter($recipient))
+            ->setValue('item_type', $qb->createNamedParameter('file'))
+            ->setValue('item_source', $qb->createNamedParameter(42))
+            ->setValue('file_source', $qb->createNamedParameter(42))
+            ->executeStatement();
+
+        $id = $qb->getLastInsertId();
+
+        $this->provider->userDeleted($deletedUser, IShare::TYPE_REMOTE);
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->select('*')
+            ->from('share')
+            ->where(
+                $qb->expr()->eq('id', $qb->createNamedParameter($id))
+            );
+        $cursor = $qb->executeQuery();
+        $data = $cursor->fetchAll();
+        $cursor->closeCursor();
+
+        $this->assertCount($rowDeleted ? 0 : 1, $data);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsOutgoingServer2serverShareEnabled')]
+    public function testIsOutgoingServer2serverShareEnabled(bool $internalOnly, string $isEnabled, bool $expected): void {
+        $this->gsConfig->expects($this->once())->method('onlyInternalFederation')
+            ->willReturn($internalOnly);
+        $this->config->expects($this->any())->method('getAppValue')
+            ->with('files_sharing', 'outgoing_server2server_share_enabled', 'yes')
+            ->willReturn($isEnabled);
+
+        $this->assertSame($expected,
+            $this->provider->isOutgoingServer2serverShareEnabled()
+        );
+    }
+
+    public static function dataTestIsOutgoingServer2serverShareEnabled(): array {
+        return [
+            [false, 'yes', true],
+            [false, 'no', false],
+            [true, 'yes', false],
+            [true, 'no', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsIncomingServer2serverShareEnabled')]
+    public function testIsIncomingServer2serverShareEnabled(bool $onlyInternal, string $isEnabled, bool $expected): void {
+        $this->gsConfig->expects($this->once())->method('onlyInternalFederation')
+            ->willReturn($onlyInternal);
+        $this->config->expects($this->any())->method('getAppValue')
+            ->with('files_sharing', 'incoming_server2server_share_enabled', 'yes')
+            ->willReturn($isEnabled);
+
+        $this->assertSame($expected,
+            $this->provider->isIncomingServer2serverShareEnabled()
+        );
+    }
+
+    public static function dataTestIsIncomingServer2serverShareEnabled(): array {
+        return [
+            [false, 'yes', true],
+            [false, 'no', false],
+            [true, 'yes', false],
+            [true, 'no', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsLookupServerQueriesEnabled')]
+    public function testIsLookupServerQueriesEnabled(bool $gsEnabled, string $isEnabled, bool $expected): void {
+        $this->gsConfig->expects($this->once())->method('isGlobalScaleEnabled')
+            ->willReturn($gsEnabled);
+        $this->config->expects($this->any())->method('getAppValue')
+            ->with('files_sharing', 'lookupServerEnabled', 'no')
+            ->willReturn($isEnabled);
+
+        $this->assertSame($expected,
+            $this->provider->isLookupServerQueriesEnabled()
+        );
+    }
+
+
+    public static function dataTestIsLookupServerQueriesEnabled(): array {
+        return [
+            [true, 'yes', true],
+            [true, 'no', true],
+            // TODO: reenable if we use the lookup server for non-global scale
+            // [false, 'yes', true],
+            // [false, 'no', false],
+            [false, 'no', false],
+            [false, 'yes', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestIsLookupServerUploadEnabled')]
+    public function testIsLookupServerUploadEnabled(bool $gsEnabled, string $isEnabled, bool $expected): void {
+        $this->gsConfig->expects($this->once())->method('isGlobalScaleEnabled')
+            ->willReturn($gsEnabled);
+        $this->config->expects($this->any())->method('getAppValue')
+            ->with('files_sharing', 'lookupServerUploadEnabled', 'no')
+            ->willReturn($isEnabled);
+
+        $this->assertSame($expected,
+            $this->provider->isLookupServerUploadEnabled()
+        );
+    }
+
+    public static function dataTestIsLookupServerUploadEnabled(): array {
+        return [
+            [true, 'yes', false],
+            [true, 'no', false],
+            // TODO: reenable if we use the lookup server again
+            // [false, 'yes', true],
+            // [false, 'no', false],
+            [false, 'yes', false],
+            [false, 'no', false],
+        ];
+    }
+
+    public function testGetSharesInFolder(): void {
+        $userManager = Server::get(IUserManager::class);
+        $rootFolder = Server::get(IRootFolder::class);
+
+        $u1 = $userManager->createUser('testFed', md5((string)time()));
+        $u2 = $userManager->createUser('testFed2', md5((string)time()));
+
+        $folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
+        $file1 = $folder1->newFile('bar1');
+        $file2 = $folder1->newFile('bar2');
+
+        $this->tokenHandler->method('generateToken')->willReturn('token');
+        $this->notifications
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $share1 = $this->shareManager->newShare();
+        $share1->setSharedWith('user@server.com')
+            ->setSharedBy($u1->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($file1);
+        $this->provider->create($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('user@server.com')
+            ->setSharedBy($u2->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($file2);
+        $this->provider->create($share2);
+
+        $result = $this->provider->getSharesInFolder($u1->getUID(), $folder1, false);
+        $this->assertCount(1, $result);
+        $this->assertCount(1, $result[$file1->getId()]);
+
+        $result = $this->provider->getSharesInFolder($u1->getUID(), $folder1, true);
+        $this->assertCount(2, $result);
+        $this->assertCount(1, $result[$file1->getId()]);
+        $this->assertCount(1, $result[$file2->getId()]);
+
+        $u1->delete();
+        $u2->delete();
+    }
+
+    public function testGetAccessList(): void {
+        $userManager = Server::get(IUserManager::class);
+        $rootFolder = Server::get(IRootFolder::class);
+
+        $u1 = $userManager->createUser('testFed', md5((string)time()));
+
+        $folder1 = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');
+        $file1 = $folder1->newFile('bar1');
+
+        $this->tokenHandler->expects($this->exactly(2))
+            ->method('generateToken')
+            ->willReturnOnConsecutiveCalls('token1', 'token2');
+        $this->notifications->expects($this->atLeastOnce())
+            ->method('sendRemoteShare')
+            ->willReturn(true);
+
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $result = $this->provider->getAccessList([$file1], true);
+        $this->assertEquals(['remote' => []], $result);
+
+        $result = $this->provider->getAccessList([$file1], false);
+        $this->assertEquals(['remote' => false], $result);
+
+        $this->addressHandler->method('generateRemoteURL')
+            ->willReturn('remoteurl.com');
+
+        $share1 = $this->shareManager->newShare();
+        $share1->setSharedWith('user@server.com')
+            ->setSharedBy($u1->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($file1);
+        $this->provider->create($share1);
+
+        $share2 = $this->shareManager->newShare();
+        $share2->setSharedWith('foobar@localhost')
+            ->setSharedBy($u1->getUID())
+            ->setShareOwner($u1->getUID())
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setShareType(IShare::TYPE_REMOTE)
+            ->setNode($file1);
+        $this->provider->create($share2);
+
+        $result = $this->provider->getAccessList([$file1], true);
+        $this->assertEquals(['remote' => [
+            'user@server.com' => [
+                'token' => 'token1',
+                'node_id' => $file1->getId(),
+            ],
+            'foobar@localhost' => [
+                'token' => 'token2',
+                'node_id' => $file1->getId(),
+            ],
+        ]], $result);
+
+        $result = $this->provider->getAccessList([$file1], false);
+        $this->assertEquals(['remote' => true], $result);
+
+        $u1->delete();
+    }
 }

apps/federatedfilesharing/tests/Controller/MountPublicLinkControllerTest.php

Indentation +122 added lines, -122 removed lines

@@ -33,138 +33,138 @@
 use Psr\Log\LoggerInterface;
 
 class MountPublicLinkControllerTest extends \Test\TestCase {
-	protected IContactsManager&MockObject $contactsManager;
-	private IRequest&MockObject $request;
-	private FederatedShareProvider&MockObject $federatedShareProvider;
-	private IManager&MockObject $shareManager;
-	private AddressHandler&MockObject $addressHandler;
-	private IRootFolder&MockObject $rootFolder;
-	private IUserManager&MockObject $userManager;
-	private ISession&MockObject $session;
-	private IL10N&MockObject $l10n;
-	private IUserSession&MockObject $userSession;
-	private IClientService&MockObject $clientService;
-	private IShare $share;
-	private ICloudIdManager $cloudIdManager;
-	private MountPublicLinkController $controller;
+    protected IContactsManager&MockObject $contactsManager;
+    private IRequest&MockObject $request;
+    private FederatedShareProvider&MockObject $federatedShareProvider;
+    private IManager&MockObject $shareManager;
+    private AddressHandler&MockObject $addressHandler;
+    private IRootFolder&MockObject $rootFolder;
+    private IUserManager&MockObject $userManager;
+    private ISession&MockObject $session;
+    private IL10N&MockObject $l10n;
+    private IUserSession&MockObject $userSession;
+    private IClientService&MockObject $clientService;
+    private IShare $share;
+    private ICloudIdManager $cloudIdManager;
+    private MountPublicLinkController $controller;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->request = $this->createMock(IRequest::class);
-		$this->federatedShareProvider = $this->createMock(FederatedShareProvider::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->addressHandler = $this->createMock(AddressHandler::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->share = new Share($this->rootFolder, $this->userManager);
-		$this->session = $this->createMock(ISession::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->contactsManager = $this->createMock(IContactsManager::class);
-		$this->cloudIdManager = new CloudIdManager(
-			$this->contactsManager,
-			$this->createMock(IURLGenerator::class),
-			$this->userManager,
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		);
+        $this->request = $this->createMock(IRequest::class);
+        $this->federatedShareProvider = $this->createMock(FederatedShareProvider::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->addressHandler = $this->createMock(AddressHandler::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->share = new Share($this->rootFolder, $this->userManager);
+        $this->session = $this->createMock(ISession::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->contactsManager = $this->createMock(IContactsManager::class);
+        $this->cloudIdManager = new CloudIdManager(
+            $this->contactsManager,
+            $this->createMock(IURLGenerator::class),
+            $this->userManager,
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        );
 
-		$this->controller = new MountPublicLinkController(
-			'federatedfilesharing', $this->request,
-			$this->federatedShareProvider,
-			$this->shareManager,
-			$this->addressHandler,
-			$this->session,
-			$this->l10n,
-			$this->userSession,
-			$this->clientService,
-			$this->cloudIdManager,
-			$this->createMock(LoggerInterface::class),
-		);
-	}
+        $this->controller = new MountPublicLinkController(
+            'federatedfilesharing', $this->request,
+            $this->federatedShareProvider,
+            $this->shareManager,
+            $this->addressHandler,
+            $this->session,
+            $this->l10n,
+            $this->userSession,
+            $this->clientService,
+            $this->cloudIdManager,
+            $this->createMock(LoggerInterface::class),
+        );
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreateFederatedShare')]
-	public function testCreateFederatedShare(
-		string $shareWith,
-		bool $outgoingSharesAllowed,
-		bool $validShareWith,
-		string $token,
-		bool $validToken,
-		bool $createSuccessful,
-		string $expectedReturnData,
-		int $permissions,
-	): void {
-		$this->federatedShareProvider->expects($this->any())
-			->method('isOutgoingServer2serverShareEnabled')
-			->willReturn($outgoingSharesAllowed);
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreateFederatedShare')]
+    public function testCreateFederatedShare(
+        string $shareWith,
+        bool $outgoingSharesAllowed,
+        bool $validShareWith,
+        string $token,
+        bool $validToken,
+        bool $createSuccessful,
+        string $expectedReturnData,
+        int $permissions,
+    ): void {
+        $this->federatedShareProvider->expects($this->any())
+            ->method('isOutgoingServer2serverShareEnabled')
+            ->willReturn($outgoingSharesAllowed);
 
-		$this->addressHandler->expects($this->any())->method('splitUserRemote')
-			->with($shareWith)
-			->willReturnCallback(
-				function ($shareWith) use ($validShareWith, $expectedReturnData) {
-					if ($validShareWith) {
-						return ['user', 'server'];
-					}
-					throw new HintException($expectedReturnData, $expectedReturnData);
-				}
-			);
+        $this->addressHandler->expects($this->any())->method('splitUserRemote')
+            ->with($shareWith)
+            ->willReturnCallback(
+                function ($shareWith) use ($validShareWith, $expectedReturnData) {
+                    if ($validShareWith) {
+                        return ['user', 'server'];
+                    }
+                    throw new HintException($expectedReturnData, $expectedReturnData);
+                }
+            );
 
-		$share = $this->share;
-		$share->setPermissions($permissions);
+        $share = $this->share;
+        $share->setPermissions($permissions);
 
-		$this->shareManager->expects($this->any())->method('getShareByToken')
-			->with($token)
-			->willReturnCallback(
-				function ($token) use ($validToken, $share, $expectedReturnData) {
-					if ($validToken) {
-						return $share;
-					}
-					throw new HintException($expectedReturnData, $expectedReturnData);
-				}
-			);
+        $this->shareManager->expects($this->any())->method('getShareByToken')
+            ->with($token)
+            ->willReturnCallback(
+                function ($token) use ($validToken, $share, $expectedReturnData) {
+                    if ($validToken) {
+                        return $share;
+                    }
+                    throw new HintException($expectedReturnData, $expectedReturnData);
+                }
+            );
 
-		$this->federatedShareProvider->expects($this->any())->method('create')
-			->with($share)
-			->willReturnCallback(
-				function (IShare $share) use ($createSuccessful, $shareWith, $expectedReturnData) {
-					$this->assertEquals($shareWith, $share->getSharedWith());
-					if ($createSuccessful) {
-						return $share;
-					}
-					throw new HintException($expectedReturnData, $expectedReturnData);
-				}
-			);
+        $this->federatedShareProvider->expects($this->any())->method('create')
+            ->with($share)
+            ->willReturnCallback(
+                function (IShare $share) use ($createSuccessful, $shareWith, $expectedReturnData) {
+                    $this->assertEquals($shareWith, $share->getSharedWith());
+                    if ($createSuccessful) {
+                        return $share;
+                    }
+                    throw new HintException($expectedReturnData, $expectedReturnData);
+                }
+            );
 
-		$result = $this->controller->createFederatedShare($shareWith, $token);
+        $result = $this->controller->createFederatedShare($shareWith, $token);
 
-		$errorCase = !$validShareWith || !$validToken || !$createSuccessful || !$outgoingSharesAllowed;
+        $errorCase = !$validShareWith || !$validToken || !$createSuccessful || !$outgoingSharesAllowed;
 
-		if ($errorCase) {
-			$this->assertSame(Http::STATUS_BAD_REQUEST, $result->getStatus());
-			$this->assertTrue(isset($result->getData()['message']));
-			$this->assertSame($expectedReturnData, $result->getData()['message']);
-		} else {
-			$this->assertSame(Http::STATUS_OK, $result->getStatus());
-			$this->assertTrue(isset($result->getData()['remoteUrl']));
-			$this->assertSame($expectedReturnData, $result->getData()['remoteUrl']);
-		}
-	}
+        if ($errorCase) {
+            $this->assertSame(Http::STATUS_BAD_REQUEST, $result->getStatus());
+            $this->assertTrue(isset($result->getData()['message']));
+            $this->assertSame($expectedReturnData, $result->getData()['message']);
+        } else {
+            $this->assertSame(Http::STATUS_OK, $result->getStatus());
+            $this->assertTrue(isset($result->getData()['remoteUrl']));
+            $this->assertSame($expectedReturnData, $result->getData()['remoteUrl']);
+        }
+    }
 
-	public static function dataTestCreateFederatedShare(): array {
-		return [
-			//shareWith, outgoingSharesAllowed, validShareWith, token, validToken, createSuccessful, expectedReturnData
-			['user@server', true, true, 'token', true, true, 'server', 31],
-			['user@server', true, true, 'token', false, false, 'server', 4],
-			['user@server', true, false, 'token', true, true, 'invalid federated cloud id', 31],
-			['user@server', true, false, 'token', false, true, 'invalid federated cloud id', 31],
-			['user@server', true, false, 'token', false, false, 'invalid federated cloud id', 31],
-			['user@server', true, false, 'token', true, false, 'invalid federated cloud id', 31],
-			['user@server', true, true, 'token', false, true, 'invalid token', 31],
-			['user@server', true, true, 'token', false, false, 'invalid token', 31],
-			['user@server', true, true, 'token', true, false, 'can not create share', 31],
-			['user@server', false, true, 'token', true, true, 'This server doesn\'t support outgoing federated shares', 31],
-		];
-	}
+    public static function dataTestCreateFederatedShare(): array {
+        return [
+            //shareWith, outgoingSharesAllowed, validShareWith, token, validToken, createSuccessful, expectedReturnData
+            ['user@server', true, true, 'token', true, true, 'server', 31],
+            ['user@server', true, true, 'token', false, false, 'server', 4],
+            ['user@server', true, false, 'token', true, true, 'invalid federated cloud id', 31],
+            ['user@server', true, false, 'token', false, true, 'invalid federated cloud id', 31],
+            ['user@server', true, false, 'token', false, false, 'invalid federated cloud id', 31],
+            ['user@server', true, false, 'token', true, false, 'invalid federated cloud id', 31],
+            ['user@server', true, true, 'token', false, true, 'invalid token', 31],
+            ['user@server', true, true, 'token', false, false, 'invalid token', 31],
+            ['user@server', true, true, 'token', true, false, 'can not create share', 31],
+            ['user@server', false, true, 'token', true, true, 'This server doesn\'t support outgoing federated shares', 31],
+        ];
+    }
 }

apps/federatedfilesharing/tests/Settings/AdminTest.php

Indentation +98 added lines, -98 removed lines

@@ -18,110 +18,110 @@
 use Test\TestCase;
 
 class AdminTest extends TestCase {
-	private FederatedShareProvider&MockObject $federatedShareProvider;
-	private IConfig $gsConfig;
-	private IInitialState&MockObject $initialState;
-	private Admin $admin;
+    private FederatedShareProvider&MockObject $federatedShareProvider;
+    private IConfig $gsConfig;
+    private IInitialState&MockObject $initialState;
+    private Admin $admin;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->federatedShareProvider = $this->createMock(FederatedShareProvider::class);
-		$this->gsConfig = $this->createMock(IConfig::class);
-		$this->initialState = $this->createMock(IInitialState::class);
-		$urlGenerator = $this->createMock(IURLGenerator::class);
-		$urlGenerator->expects($this->any())
-			->method('linkToDocs')
-			->willReturn('doc-link');
+    protected function setUp(): void {
+        parent::setUp();
+        $this->federatedShareProvider = $this->createMock(FederatedShareProvider::class);
+        $this->gsConfig = $this->createMock(IConfig::class);
+        $this->initialState = $this->createMock(IInitialState::class);
+        $urlGenerator = $this->createMock(IURLGenerator::class);
+        $urlGenerator->expects($this->any())
+            ->method('linkToDocs')
+            ->willReturn('doc-link');
 
-		$this->admin = new Admin(
-			$this->federatedShareProvider,
-			$this->gsConfig,
-			$this->createMock(IL10N::class),
-			$urlGenerator,
-			$this->initialState
-		);
-	}
+        $this->admin = new Admin(
+            $this->federatedShareProvider,
+            $this->gsConfig,
+            $this->createMock(IL10N::class),
+            $urlGenerator,
+            $this->initialState
+        );
+    }
 
-	public static function sharingStateProvider(): array {
-		return [
-			[
-				true,
-			],
-			[
-				false,
-			]
-		];
-	}
+    public static function sharingStateProvider(): array {
+        return [
+            [
+                true,
+            ],
+            [
+                false,
+            ]
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('sharingStateProvider')]
-	public function testGetForm(bool $state): void {
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isOutgoingServer2serverShareEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isIncomingServer2serverShareEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isIncomingServer2serverShareEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isLookupServerQueriesEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isLookupServerUploadEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isFederatedGroupSharingSupported')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isOutgoingServer2serverGroupShareEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isIncomingServer2serverGroupShareEnabled')
-			->willReturn($state);
-		$this->federatedShareProvider
-			->expects($this->once())
-			->method('isFederatedTrustedShareAutoAccept')
-			->willReturn($state);
-		$this->gsConfig->expects($this->once())->method('onlyInternalFederation')
-			->willReturn($state);
+    #[\PHPUnit\Framework\Attributes\DataProvider('sharingStateProvider')]
+    public function testGetForm(bool $state): void {
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isOutgoingServer2serverShareEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isIncomingServer2serverShareEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isIncomingServer2serverShareEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isLookupServerQueriesEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isLookupServerUploadEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isFederatedGroupSharingSupported')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isOutgoingServer2serverGroupShareEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isIncomingServer2serverGroupShareEnabled')
+            ->willReturn($state);
+        $this->federatedShareProvider
+            ->expects($this->once())
+            ->method('isFederatedTrustedShareAutoAccept')
+            ->willReturn($state);
+        $this->gsConfig->expects($this->once())->method('onlyInternalFederation')
+            ->willReturn($state);
 
-		$calls = [
-			['internalOnly', $state],
-			['sharingFederatedDocUrl', 'doc-link'],
-			['outgoingServer2serverShareEnabled', $state],
-			['incomingServer2serverShareEnabled', $state],
-			['federatedGroupSharingSupported', $state],
-			['outgoingServer2serverGroupShareEnabled', $state],
-			['incomingServer2serverGroupShareEnabled', $state],
-			['lookupServerEnabled', $state],
-			['lookupServerUploadEnabled', $state],
-			['federatedTrustedShareAutoAccept', $state],
-		];
-		$this->initialState->expects($this->exactly(10))
-			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertSame($expected, func_get_args());
-			});
+        $calls = [
+            ['internalOnly', $state],
+            ['sharingFederatedDocUrl', 'doc-link'],
+            ['outgoingServer2serverShareEnabled', $state],
+            ['incomingServer2serverShareEnabled', $state],
+            ['federatedGroupSharingSupported', $state],
+            ['outgoingServer2serverGroupShareEnabled', $state],
+            ['incomingServer2serverGroupShareEnabled', $state],
+            ['lookupServerEnabled', $state],
+            ['lookupServerUploadEnabled', $state],
+            ['federatedTrustedShareAutoAccept', $state],
+        ];
+        $this->initialState->expects($this->exactly(10))
+            ->method('provideInitialState')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertSame($expected, func_get_args());
+            });
 
-		$expected = new TemplateResponse('federatedfilesharing', 'settings-admin', [], '');
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
+        $expected = new TemplateResponse('federatedfilesharing', 'settings-admin', [], '');
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
 
-	public function testGetSection(): void {
-		$this->assertSame('sharing', $this->admin->getSection());
-	}
+    public function testGetSection(): void {
+        $this->assertSame('sharing', $this->admin->getSection());
+    }
 
-	public function testGetPriority(): void {
-		$this->assertSame(20, $this->admin->getPriority());
-	}
+    public function testGetPriority(): void {
+        $this->assertSame(20, $this->admin->getPriority());
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 		];
 		$this->initialState->expects($this->exactly(10))
 			->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertSame($expected, func_get_args());
 			});

apps/federatedfilesharing/tests/AddressHandlerTest.php

Indentation +151 added lines, -151 removed lines

@@ -20,155 +20,155 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class AddressHandlerTest extends \Test\TestCase {
-	protected IManager&MockObject $contactsManager;
-	private IURLGenerator&MockObject $urlGenerator;
-	private IL10N&MockObject $il10n;
-	private CloudIdManager $cloudIdManager;
-	private AddressHandler $addressHandler;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->il10n = $this->createMock(IL10N::class);
-		$this->contactsManager = $this->createMock(IManager::class);
-
-		$this->cloudIdManager = new CloudIdManager(
-			$this->contactsManager,
-			$this->urlGenerator,
-			$this->createMock(IUserManager::class),
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		);
-
-		$this->addressHandler = new AddressHandler($this->urlGenerator, $this->il10n, $this->cloudIdManager);
-	}
-
-	public static function dataTestSplitUserRemote(): array {
-		$userPrefix = ['user@name', 'username'];
-		$protocols = ['', 'http://', 'https://'];
-		$remotes = [
-			'localhost',
-			'local.host',
-			'dev.local.host',
-			'dev.local.host/path',
-			'dev.local.host/at@inpath',
-			'127.0.0.1',
-			'::1',
-			'::192.0.2.128',
-			'::192.0.2.128/at@inpath',
-		];
-
-		$testCases = [];
-		foreach ($userPrefix as $user) {
-			foreach ($remotes as $remote) {
-				foreach ($protocols as $protocol) {
-					$baseUrl = $user . '@' . $protocol . $remote;
-
-					if ($protocol === '') {
-						// https:// protocol is expected in the final result
-						$protocol = 'https://';
-					}
-
-					$testCases[] = [$baseUrl, $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
-				}
-			}
-		}
-		return $testCases;
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSplitUserRemote')]
-	public function testSplitUserRemote(string $remote, string $expectedUser, string $expectedUrl): void {
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		[$remoteUser, $remoteUrl] = $this->addressHandler->splitUserRemote($remote);
-		$this->assertSame($expectedUser, $remoteUser);
-		$this->assertSame($expectedUrl, $remoteUrl);
-	}
-
-	public static function dataTestSplitUserRemoteError(): array {
-		return [
-			// Invalid path
-			['user@'],
-
-			// Invalid user
-			['@server'],
-			['us/er@server'],
-			['us:er@server'],
-
-			// Invalid splitting
-			['user'],
-			[''],
-			['us/erserver'],
-			['us:erserver'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSplitUserRemoteError')]
-	public function testSplitUserRemoteError(string $id): void {
-		$this->expectException(HintException::class);
-
-		$this->addressHandler->splitUserRemote($id);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCompareAddresses')]
-	public function testCompareAddresses(string $user1, string $server1, string $user2, string $server2, bool $expected): void {
-		$this->assertSame($expected,
-			$this->addressHandler->compareAddresses($user1, $server1, $user2, $server2)
-		);
-	}
-
-	public static function dataTestCompareAddresses(): array {
-		return [
-			['user1', 'http://server1', 'user1', 'http://server1', true],
-			['user1', 'https://server1', 'user1', 'http://server1', true],
-			['user1', 'http://serVer1', 'user1', 'http://server1', true],
-			['user1', 'http://server1/',  'user1', 'http://server1', true],
-			['user1', 'server1', 'user1', 'http://server1', true],
-			['user1', 'http://server1', 'user1', 'http://server2', false],
-			['user1', 'https://server1', 'user1', 'http://server2', false],
-			['user1', 'http://serVer1', 'user1', 'http://serer2', false],
-			['user1', 'http://server1/', 'user1', 'http://server2', false],
-			['user1', 'server1', 'user1', 'http://server2', false],
-			['user1', 'http://server1', 'user2', 'http://server1', false],
-			['user1', 'https://server1', 'user2', 'http://server1', false],
-			['user1', 'http://serVer1', 'user2', 'http://server1', false],
-			['user1', 'http://server1/',  'user2', 'http://server1', false],
-			['user1', 'server1', 'user2', 'http://server1', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRemoveProtocolFromUrl')]
-	public function testRemoveProtocolFromUrl(string $url, string $expectedResult): void {
-		$result = $this->addressHandler->removeProtocolFromUrl($url);
-		$this->assertSame($expectedResult, $result);
-	}
-
-	public static function dataTestRemoveProtocolFromUrl(): array {
-		return [
-			['http://example.tld', 'example.tld'],
-			['https://example.tld', 'example.tld'],
-			['example.tld', 'example.tld'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestUrlContainProtocol')]
-	public function testUrlContainProtocol(string $url, bool $expectedResult): void {
-		$result = $this->addressHandler->urlContainProtocol($url);
-		$this->assertSame($expectedResult, $result);
-	}
-
-	public static function dataTestUrlContainProtocol(): array {
-		return [
-			['http://nextcloud.com', true],
-			['https://nextcloud.com', true],
-			['nextcloud.com', false],
-			['httpserver.com', false],
-		];
-	}
+    protected IManager&MockObject $contactsManager;
+    private IURLGenerator&MockObject $urlGenerator;
+    private IL10N&MockObject $il10n;
+    private CloudIdManager $cloudIdManager;
+    private AddressHandler $addressHandler;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->il10n = $this->createMock(IL10N::class);
+        $this->contactsManager = $this->createMock(IManager::class);
+
+        $this->cloudIdManager = new CloudIdManager(
+            $this->contactsManager,
+            $this->urlGenerator,
+            $this->createMock(IUserManager::class),
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        );
+
+        $this->addressHandler = new AddressHandler($this->urlGenerator, $this->il10n, $this->cloudIdManager);
+    }
+
+    public static function dataTestSplitUserRemote(): array {
+        $userPrefix = ['user@name', 'username'];
+        $protocols = ['', 'http://', 'https://'];
+        $remotes = [
+            'localhost',
+            'local.host',
+            'dev.local.host',
+            'dev.local.host/path',
+            'dev.local.host/at@inpath',
+            '127.0.0.1',
+            '::1',
+            '::192.0.2.128',
+            '::192.0.2.128/at@inpath',
+        ];
+
+        $testCases = [];
+        foreach ($userPrefix as $user) {
+            foreach ($remotes as $remote) {
+                foreach ($protocols as $protocol) {
+                    $baseUrl = $user . '@' . $protocol . $remote;
+
+                    if ($protocol === '') {
+                        // https:// protocol is expected in the final result
+                        $protocol = 'https://';
+                    }
+
+                    $testCases[] = [$baseUrl, $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
+                    $testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
+                }
+            }
+        }
+        return $testCases;
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSplitUserRemote')]
+    public function testSplitUserRemote(string $remote, string $expectedUser, string $expectedUrl): void {
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        [$remoteUser, $remoteUrl] = $this->addressHandler->splitUserRemote($remote);
+        $this->assertSame($expectedUser, $remoteUser);
+        $this->assertSame($expectedUrl, $remoteUrl);
+    }
+
+    public static function dataTestSplitUserRemoteError(): array {
+        return [
+            // Invalid path
+            ['user@'],
+
+            // Invalid user
+            ['@server'],
+            ['us/er@server'],
+            ['us:er@server'],
+
+            // Invalid splitting
+            ['user'],
+            [''],
+            ['us/erserver'],
+            ['us:erserver'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSplitUserRemoteError')]
+    public function testSplitUserRemoteError(string $id): void {
+        $this->expectException(HintException::class);
+
+        $this->addressHandler->splitUserRemote($id);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCompareAddresses')]
+    public function testCompareAddresses(string $user1, string $server1, string $user2, string $server2, bool $expected): void {
+        $this->assertSame($expected,
+            $this->addressHandler->compareAddresses($user1, $server1, $user2, $server2)
+        );
+    }
+
+    public static function dataTestCompareAddresses(): array {
+        return [
+            ['user1', 'http://server1', 'user1', 'http://server1', true],
+            ['user1', 'https://server1', 'user1', 'http://server1', true],
+            ['user1', 'http://serVer1', 'user1', 'http://server1', true],
+            ['user1', 'http://server1/',  'user1', 'http://server1', true],
+            ['user1', 'server1', 'user1', 'http://server1', true],
+            ['user1', 'http://server1', 'user1', 'http://server2', false],
+            ['user1', 'https://server1', 'user1', 'http://server2', false],
+            ['user1', 'http://serVer1', 'user1', 'http://serer2', false],
+            ['user1', 'http://server1/', 'user1', 'http://server2', false],
+            ['user1', 'server1', 'user1', 'http://server2', false],
+            ['user1', 'http://server1', 'user2', 'http://server1', false],
+            ['user1', 'https://server1', 'user2', 'http://server1', false],
+            ['user1', 'http://serVer1', 'user2', 'http://server1', false],
+            ['user1', 'http://server1/',  'user2', 'http://server1', false],
+            ['user1', 'server1', 'user2', 'http://server1', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRemoveProtocolFromUrl')]
+    public function testRemoveProtocolFromUrl(string $url, string $expectedResult): void {
+        $result = $this->addressHandler->removeProtocolFromUrl($url);
+        $this->assertSame($expectedResult, $result);
+    }
+
+    public static function dataTestRemoveProtocolFromUrl(): array {
+        return [
+            ['http://example.tld', 'example.tld'],
+            ['https://example.tld', 'example.tld'],
+            ['example.tld', 'example.tld'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestUrlContainProtocol')]
+    public function testUrlContainProtocol(string $url, bool $expectedResult): void {
+        $result = $this->addressHandler->urlContainProtocol($url);
+        $this->assertSame($expectedResult, $result);
+    }
+
+    public static function dataTestUrlContainProtocol(): array {
+        return [
+            ['http://nextcloud.com', true],
+            ['https://nextcloud.com', true],
+            ['nextcloud.com', false],
+            ['httpserver.com', false],
+        ];
+    }
 }

apps/federatedfilesharing/tests/TestCase.php

Indentation +73 added lines, -73 removed lines

@@ -24,77 +24,77 @@
  * Base class for sharing tests.
  */
 abstract class TestCase extends \Test\TestCase {
-	public const TEST_FILES_SHARING_API_USER1 = 'test-share-user1';
-	public const TEST_FILES_SHARING_API_USER2 = 'test-share-user2';
-
-	public static function setUpBeforeClass(): void {
-		parent::setUpBeforeClass();
-
-		// reset backend
-		Server::get(IUserManager::class)->clearBackends();
-		Server::get(IGroupManager::class)->clearBackends();
-
-		// create users
-		$backend = new \Test\Util\User\Dummy();
-		Server::get(IUserManager::class)->registerBackend($backend);
-		$backend->createUser(self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER1);
-		$backend->createUser(self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER2);
-	}
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		//login as user1
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-	}
-
-	public static function tearDownAfterClass(): void {
-		// cleanup users
-		$user = Server::get(IUserManager::class)->get(self::TEST_FILES_SHARING_API_USER1);
-		if ($user !== null) {
-			$user->delete();
-		}
-		$user = Server::get(IUserManager::class)->get(self::TEST_FILES_SHARING_API_USER2);
-		if ($user !== null) {
-			$user->delete();
-		}
-
-		\OC_Util::tearDownFS();
-		\OC_User::setUserId('');
-		Filesystem::tearDown();
-
-		// reset backend
-		Server::get(IUserManager::class)->clearBackends();
-		Server::get(IUserManager::class)->registerBackend(new \OC\User\Database());
-		Server::get(IGroupManager::class)->clearBackends();
-		Server::get(IGroupManager::class)->addBackend(new Database());
-
-		parent::tearDownAfterClass();
-	}
-
-	protected static function loginHelper(string $user, bool $create = false, bool $password = false) {
-		if ($password === false) {
-			$password = $user;
-		}
-
-		if ($create) {
-			$userManager = Server::get(IUserManager::class);
-			$groupManager = Server::get(IGroupManager::class);
-
-			$userObject = $userManager->createUser($user, $password);
-			$group = $groupManager->createGroup('group');
-
-			if ($group and $userObject) {
-				$group->addUser($userObject);
-			}
-		}
-
-		\OC_Util::tearDownFS();
-		Server::get(IUserSession::class)->setUser(null);
-		Filesystem::tearDown();
-		Server::get(IUserSession::class)->login($user, $password);
-		Server::get(IRootFolder::class)->getUserFolder($user);
-
-		\OC_Util::setupFS($user);
-	}
+    public const TEST_FILES_SHARING_API_USER1 = 'test-share-user1';
+    public const TEST_FILES_SHARING_API_USER2 = 'test-share-user2';
+
+    public static function setUpBeforeClass(): void {
+        parent::setUpBeforeClass();
+
+        // reset backend
+        Server::get(IUserManager::class)->clearBackends();
+        Server::get(IGroupManager::class)->clearBackends();
+
+        // create users
+        $backend = new \Test\Util\User\Dummy();
+        Server::get(IUserManager::class)->registerBackend($backend);
+        $backend->createUser(self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER1);
+        $backend->createUser(self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER2);
+    }
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        //login as user1
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+    }
+
+    public static function tearDownAfterClass(): void {
+        // cleanup users
+        $user = Server::get(IUserManager::class)->get(self::TEST_FILES_SHARING_API_USER1);
+        if ($user !== null) {
+            $user->delete();
+        }
+        $user = Server::get(IUserManager::class)->get(self::TEST_FILES_SHARING_API_USER2);
+        if ($user !== null) {
+            $user->delete();
+        }
+
+        \OC_Util::tearDownFS();
+        \OC_User::setUserId('');
+        Filesystem::tearDown();
+
+        // reset backend
+        Server::get(IUserManager::class)->clearBackends();
+        Server::get(IUserManager::class)->registerBackend(new \OC\User\Database());
+        Server::get(IGroupManager::class)->clearBackends();
+        Server::get(IGroupManager::class)->addBackend(new Database());
+
+        parent::tearDownAfterClass();
+    }
+
+    protected static function loginHelper(string $user, bool $create = false, bool $password = false) {
+        if ($password === false) {
+            $password = $user;
+        }
+
+        if ($create) {
+            $userManager = Server::get(IUserManager::class);
+            $groupManager = Server::get(IGroupManager::class);
+
+            $userObject = $userManager->createUser($user, $password);
+            $group = $groupManager->createGroup('group');
+
+            if ($group and $userObject) {
+                $group->addUser($userObject);
+            }
+        }
+
+        \OC_Util::tearDownFS();
+        Server::get(IUserSession::class)->setUser(null);
+        Filesystem::tearDown();
+        Server::get(IUserSession::class)->login($user, $password);
+        Server::get(IRootFolder::class)->getUserFolder($user);
+
+        \OC_Util::setupFS($user);
+    }
 }

apps/testing/lib/HiddenGroupBackend.php

Indentation +28 added lines, -28 removed lines

@@ -13,32 +13,32 @@
 use OCP\Group\Backend\IHideFromCollaborationBackend;
 
 class HiddenGroupBackend extends ABackend implements IHideFromCollaborationBackend {
-	public function __construct(
-		private string $groupName = 'hidden_group',
-	) {
-	}
-
-	public function inGroup($uid, $gid): bool {
-		return false;
-	}
-
-	public function getUserGroups($uid): array {
-		return [];
-	}
-
-	public function getGroups($search = '', $limit = -1, $offset = 0): array {
-		return $offset === 0 ? [$this->groupName] : [];
-	}
-
-	public function groupExists($gid): bool {
-		return $gid === $this->groupName;
-	}
-
-	public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0): array {
-		return [];
-	}
-
-	public function hideGroup(string $groupId): bool {
-		return true;
-	}
+    public function __construct(
+        private string $groupName = 'hidden_group',
+    ) {
+    }
+
+    public function inGroup($uid, $gid): bool {
+        return false;
+    }
+
+    public function getUserGroups($uid): array {
+        return [];
+    }
+
+    public function getGroups($search = '', $limit = -1, $offset = 0): array {
+        return $offset === 0 ? [$this->groupName] : [];
+    }
+
+    public function groupExists($gid): bool {
+        return $gid === $this->groupName;
+    }
+
+    public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0): array {
+        return [];
+    }
+
+    public function hideGroup(string $groupId): bool {
+        return true;
+    }
 }

apps/user_ldap/tests/ConnectionTest.php

Indentation +243 added lines, -243 removed lines

@@ -21,247 +21,247 @@
  * @package OCA\User_LDAP\Tests
  */
 class ConnectionTest extends \Test\TestCase {
-	protected ILDAPWrapper&MockObject $ldap;
-	protected Connection $connection;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->ldap = $this->createMock(ILDAPWrapper::class);
-		// we use a mock here to replace the cache mechanism, due to missing DI in LDAP backend.
-		$this->connection = $this->getMockBuilder(Connection::class)
-			->onlyMethods(['getFromCache', 'writeToCache'])
-			->setConstructorArgs([$this->ldap, '', null])
-			->getMock();
-
-		$this->ldap->expects($this->any())
-			->method('areLDAPFunctionsAvailable')
-			->willReturn(true);
-	}
-
-	public function testOriginalAgentUnchangedOnClone(): void {
-		//background: upon login a bind is done with the user credentials
-		//which is valid for the whole LDAP resource. It needs to be reset
-		//to the agent's credentials
-		$lw = $this->createMock(ILDAPWrapper::class);
-
-		$connection = new Connection($lw, '', null);
-		$agent = [
-			'ldapAgentName' => 'agent',
-			'ldapAgentPassword' => '123456',
-		];
-		$connection->setConfiguration($agent);
-
-		$testConnection = clone $connection;
-		$user = [
-			'ldapAgentName' => 'user',
-			'ldapAgentPassword' => 'password',
-		];
-		$testConnection->setConfiguration($user);
-
-		$agentName = $connection->ldapAgentName;
-		$agentPawd = $connection->ldapAgentPassword;
-
-		$this->assertSame($agentName, $agent['ldapAgentName']);
-		$this->assertSame($agentPawd, $agent['ldapAgentPassword']);
-	}
-
-	public function testUseBackupServer(): void {
-		$mainHost = 'ldap://nixda.ldap';
-		$backupHost = 'ldap://fallback.ldap';
-		$config = [
-			'ldapConfigurationActive' => true,
-			'ldapHost' => $mainHost,
-			'ldapPort' => 389,
-			'ldapBackupHost' => $backupHost,
-			'ldapBackupPort' => 389,
-			'ldapAgentName' => 'uid=agent',
-			'ldapAgentPassword' => 'SuchASecret'
-		];
-
-		$this->connection->setIgnoreValidation(true);
-		$this->connection->setConfiguration($config);
-
-		$this->ldap->expects($this->any())
-			->method('isResource')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('setOption')
-			->willReturn(true);
-
-		$this->ldap->expects($this->exactly(3))
-			->method('connect')
-			->willReturn(ldap_connect('ldap://example.com'));
-
-		$this->ldap->expects($this->any())
-			->method('errno')
-			->willReturn(0);
-
-		// Not called often enough? Then, the fallback to the backup server is broken.
-		$this->connection->expects($this->exactly(2))
-			->method('getFromCache')
-			->with('overrideMainServer')->willReturnOnConsecutiveCalls(false, false, true, true);
-
-		$this->connection->expects($this->once())
-			->method('writeToCache')
-			->with('overrideMainServer', true);
-
-		$isThrown = false;
-		$this->ldap->expects($this->exactly(3))
-			->method('bind')
-			->willReturnCallback(function () use (&$isThrown) {
-				if (!$isThrown) {
-					$isThrown = true;
-					throw new ServerNotAvailableException();
-				}
-				return true;
-			});
-
-		$this->connection->init();
-		$this->connection->resetConnectionResource();
-		// with the second init() we test whether caching works
-		$this->connection->init();
-	}
-
-	public function testDontUseBackupServerOnFailedAuth(): void {
-		$mainHost = 'ldap://nixda.ldap';
-		$backupHost = 'ldap://fallback.ldap';
-		$config = [
-			'ldapConfigurationActive' => true,
-			'ldapHost' => $mainHost,
-			'ldapPort' => 389,
-			'ldapBackupHost' => $backupHost,
-			'ldapBackupPort' => 389,
-			'ldapAgentName' => 'uid=agent',
-			'ldapAgentPassword' => 'SuchASecret'
-		];
-
-		$this->connection->setIgnoreValidation(true);
-		$this->connection->setConfiguration($config);
-
-		$this->ldap->expects($this->any())
-			->method('isResource')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('setOption')
-			->willReturn(true);
-
-		$this->ldap->expects($this->once())
-			->method('connect')
-			->willReturn(ldap_connect('ldap://example.com'));
-
-		$this->ldap->expects($this->any())
-			->method('errno')
-			->willReturn(49);
-
-		$this->connection->expects($this->any())
-			->method('getFromCache')
-			->with('overrideMainServer')
-			->willReturn(false);
-
-		$this->connection->expects($this->never())
-			->method('writeToCache');
-
-		$this->ldap->expects($this->exactly(1))
-			->method('bind')
-			->willReturn(false);
-
-		$this->connection->init();
-	}
-
-	public function testBindWithInvalidCredentials(): void {
-		// background: Bind with invalid credentials should return false
-		// and not throw a ServerNotAvailableException.
-
-		$host = 'ldap://nixda.ldap';
-		$config = [
-			'ldapConfigurationActive' => true,
-			'ldapHost' => $host,
-			'ldapPort' => 389,
-			'ldapBackupHost' => '',
-			'ldapAgentName' => 'user',
-			'ldapAgentPassword' => 'password'
-		];
-
-		$this->connection->setIgnoreValidation(true);
-		$this->connection->setConfiguration($config);
-
-		$this->ldap->expects($this->any())
-			->method('isResource')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('setOption')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('connect')
-			->willReturn(ldap_connect('ldap://example.com'));
-
-		$this->ldap->expects($this->once())
-			->method('bind')
-			->willReturn(false);
-
-		// LDAP_INVALID_CREDENTIALS
-		$this->ldap->expects($this->any())
-			->method('errno')
-			->willReturn(0x31);
-
-		try {
-			$this->assertFalse($this->connection->bind(), 'Connection::bind() should not return true with invalid credentials.');
-		} catch (ServerNotAvailableException $e) {
-			$this->fail('Failed asserting that exception of type "OC\ServerNotAvailableException" is not thrown.');
-		}
-	}
-
-	public function testStartTlsNegotiationFailure(): void {
-		// background: If Start TLS negotiation fails,
-		// a ServerNotAvailableException should be thrown.
-
-		$host = 'ldap://nixda.ldap';
-		$port = 389;
-		$config = [
-			'ldapConfigurationActive' => true,
-			'ldapHost' => $host,
-			'ldapPort' => $port,
-			'ldapTLS' => true,
-			'ldapBackupHost' => '',
-			'ldapAgentName' => 'user',
-			'ldapAgentPassword' => 'password'
-		];
-
-		$this->connection->setIgnoreValidation(true);
-		$this->connection->setConfiguration($config);
-
-		$this->ldap->expects($this->any())
-			->method('isResource')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('connect')
-			->willReturn(ldap_connect('ldap://example.com'));
-
-		$this->ldap->expects($this->any())
-			->method('setOption')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('bind')
-			->willReturn(true);
-
-		$this->ldap->expects($this->any())
-			->method('errno')
-			->willReturn(0);
-
-		$this->ldap->expects($this->any())
-			->method('startTls')
-			->willReturn(false);
-
-		$this->expectException(ServerNotAvailableException::class);
-		$this->expectExceptionMessage('Start TLS failed, when connecting to LDAP host ' . $host . '.');
-
-		$this->connection->init();
-	}
+    protected ILDAPWrapper&MockObject $ldap;
+    protected Connection $connection;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->ldap = $this->createMock(ILDAPWrapper::class);
+        // we use a mock here to replace the cache mechanism, due to missing DI in LDAP backend.
+        $this->connection = $this->getMockBuilder(Connection::class)
+            ->onlyMethods(['getFromCache', 'writeToCache'])
+            ->setConstructorArgs([$this->ldap, '', null])
+            ->getMock();
+
+        $this->ldap->expects($this->any())
+            ->method('areLDAPFunctionsAvailable')
+            ->willReturn(true);
+    }
+
+    public function testOriginalAgentUnchangedOnClone(): void {
+        //background: upon login a bind is done with the user credentials
+        //which is valid for the whole LDAP resource. It needs to be reset
+        //to the agent's credentials
+        $lw = $this->createMock(ILDAPWrapper::class);
+
+        $connection = new Connection($lw, '', null);
+        $agent = [
+            'ldapAgentName' => 'agent',
+            'ldapAgentPassword' => '123456',
+        ];
+        $connection->setConfiguration($agent);
+
+        $testConnection = clone $connection;
+        $user = [
+            'ldapAgentName' => 'user',
+            'ldapAgentPassword' => 'password',
+        ];
+        $testConnection->setConfiguration($user);
+
+        $agentName = $connection->ldapAgentName;
+        $agentPawd = $connection->ldapAgentPassword;
+
+        $this->assertSame($agentName, $agent['ldapAgentName']);
+        $this->assertSame($agentPawd, $agent['ldapAgentPassword']);
+    }
+
+    public function testUseBackupServer(): void {
+        $mainHost = 'ldap://nixda.ldap';
+        $backupHost = 'ldap://fallback.ldap';
+        $config = [
+            'ldapConfigurationActive' => true,
+            'ldapHost' => $mainHost,
+            'ldapPort' => 389,
+            'ldapBackupHost' => $backupHost,
+            'ldapBackupPort' => 389,
+            'ldapAgentName' => 'uid=agent',
+            'ldapAgentPassword' => 'SuchASecret'
+        ];
+
+        $this->connection->setIgnoreValidation(true);
+        $this->connection->setConfiguration($config);
+
+        $this->ldap->expects($this->any())
+            ->method('isResource')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('setOption')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->exactly(3))
+            ->method('connect')
+            ->willReturn(ldap_connect('ldap://example.com'));
+
+        $this->ldap->expects($this->any())
+            ->method('errno')
+            ->willReturn(0);
+
+        // Not called often enough? Then, the fallback to the backup server is broken.
+        $this->connection->expects($this->exactly(2))
+            ->method('getFromCache')
+            ->with('overrideMainServer')->willReturnOnConsecutiveCalls(false, false, true, true);
+
+        $this->connection->expects($this->once())
+            ->method('writeToCache')
+            ->with('overrideMainServer', true);
+
+        $isThrown = false;
+        $this->ldap->expects($this->exactly(3))
+            ->method('bind')
+            ->willReturnCallback(function () use (&$isThrown) {
+                if (!$isThrown) {
+                    $isThrown = true;
+                    throw new ServerNotAvailableException();
+                }
+                return true;
+            });
+
+        $this->connection->init();
+        $this->connection->resetConnectionResource();
+        // with the second init() we test whether caching works
+        $this->connection->init();
+    }
+
+    public function testDontUseBackupServerOnFailedAuth(): void {
+        $mainHost = 'ldap://nixda.ldap';
+        $backupHost = 'ldap://fallback.ldap';
+        $config = [
+            'ldapConfigurationActive' => true,
+            'ldapHost' => $mainHost,
+            'ldapPort' => 389,
+            'ldapBackupHost' => $backupHost,
+            'ldapBackupPort' => 389,
+            'ldapAgentName' => 'uid=agent',
+            'ldapAgentPassword' => 'SuchASecret'
+        ];
+
+        $this->connection->setIgnoreValidation(true);
+        $this->connection->setConfiguration($config);
+
+        $this->ldap->expects($this->any())
+            ->method('isResource')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('setOption')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->once())
+            ->method('connect')
+            ->willReturn(ldap_connect('ldap://example.com'));
+
+        $this->ldap->expects($this->any())
+            ->method('errno')
+            ->willReturn(49);
+
+        $this->connection->expects($this->any())
+            ->method('getFromCache')
+            ->with('overrideMainServer')
+            ->willReturn(false);
+
+        $this->connection->expects($this->never())
+            ->method('writeToCache');
+
+        $this->ldap->expects($this->exactly(1))
+            ->method('bind')
+            ->willReturn(false);
+
+        $this->connection->init();
+    }
+
+    public function testBindWithInvalidCredentials(): void {
+        // background: Bind with invalid credentials should return false
+        // and not throw a ServerNotAvailableException.
+
+        $host = 'ldap://nixda.ldap';
+        $config = [
+            'ldapConfigurationActive' => true,
+            'ldapHost' => $host,
+            'ldapPort' => 389,
+            'ldapBackupHost' => '',
+            'ldapAgentName' => 'user',
+            'ldapAgentPassword' => 'password'
+        ];
+
+        $this->connection->setIgnoreValidation(true);
+        $this->connection->setConfiguration($config);
+
+        $this->ldap->expects($this->any())
+            ->method('isResource')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('setOption')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('connect')
+            ->willReturn(ldap_connect('ldap://example.com'));
+
+        $this->ldap->expects($this->once())
+            ->method('bind')
+            ->willReturn(false);
+
+        // LDAP_INVALID_CREDENTIALS
+        $this->ldap->expects($this->any())
+            ->method('errno')
+            ->willReturn(0x31);
+
+        try {
+            $this->assertFalse($this->connection->bind(), 'Connection::bind() should not return true with invalid credentials.');
+        } catch (ServerNotAvailableException $e) {
+            $this->fail('Failed asserting that exception of type "OC\ServerNotAvailableException" is not thrown.');
+        }
+    }
+
+    public function testStartTlsNegotiationFailure(): void {
+        // background: If Start TLS negotiation fails,
+        // a ServerNotAvailableException should be thrown.
+
+        $host = 'ldap://nixda.ldap';
+        $port = 389;
+        $config = [
+            'ldapConfigurationActive' => true,
+            'ldapHost' => $host,
+            'ldapPort' => $port,
+            'ldapTLS' => true,
+            'ldapBackupHost' => '',
+            'ldapAgentName' => 'user',
+            'ldapAgentPassword' => 'password'
+        ];
+
+        $this->connection->setIgnoreValidation(true);
+        $this->connection->setConfiguration($config);
+
+        $this->ldap->expects($this->any())
+            ->method('isResource')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('connect')
+            ->willReturn(ldap_connect('ldap://example.com'));
+
+        $this->ldap->expects($this->any())
+            ->method('setOption')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('bind')
+            ->willReturn(true);
+
+        $this->ldap->expects($this->any())
+            ->method('errno')
+            ->willReturn(0);
+
+        $this->ldap->expects($this->any())
+            ->method('startTls')
+            ->willReturn(false);
+
+        $this->expectException(ServerNotAvailableException::class);
+        $this->expectExceptionMessage('Start TLS failed, when connecting to LDAP host ' . $host . '.');
+
+        $this->connection->init();
+    }
 }

apps/user_ldap/tests/Group_LDAPTest.php

Indentation +1292 added lines, -1292 removed lines

@@ -35,1348 +35,1348 @@
  * @package OCA\User_LDAP\Tests
  */
 class Group_LDAPTest extends TestCase {
-	private Access&MockObject $access;
-	private GroupPluginManager&MockObject $pluginManager;
-	private IConfig&MockObject $config;
-	private IUserManager&MockObject $ncUserManager;
-	private GroupLDAP $groupBackend;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$this->access = $this->getAccessMock();
-		$this->pluginManager = $this->createMock(GroupPluginManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->ncUserManager = $this->createMock(IUserManager::class);
-	}
-
-	public function initBackend(): void {
-		$this->groupBackend = new GroupLDAP($this->access, $this->pluginManager, $this->config, $this->ncUserManager);
-	}
-
-	public function testCountEmptySearchString(): void {
-		$groupDN = 'cn=group,dc=foo,dc=bar';
-
-		$this->enableGroups();
-
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn($groupDN);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn) use ($groupDN) {
-				if ($dn === $groupDN) {
-					return [
-						'uid=u11,ou=users,dc=foo,dc=bar',
-						'uid=u22,ou=users,dc=foo,dc=bar',
-						'uid=u33,ou=users,dc=foo,dc=bar',
-						'uid=u34,ou=users,dc=foo,dc=bar'
-					];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-		// for primary groups
-		$this->access->expects($this->once())
-			->method('countUsers')
-			->willReturn(2);
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['displayName', 'mail']);
-
-		$this->initBackend();
-		$users = $this->groupBackend->countUsersInGroup('group');
-
-		$this->assertSame(6, $users);
-	}
-
-	/**
-	 * @return MockObject|Access
-	 */
-	private function getAccessMock() {
-		$lw = $this->createMock(ILDAPWrapper::class);
-		$connector = $this->getMockBuilder(Connection::class)
-			->setConstructorArgs([$lw, '', null])
-			->getMock();
-
-		$this->access = $this->createMock(Access::class);
-		$this->access->connection = $connector;
-		$this->access->userManager = $this->createMock(Manager::class);
-
-		return $this->access;
-	}
-
-	private function enableGroups(): void {
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapDynamicGroupMemberURL') {
-					return '';
-				} elseif ($name === 'ldapBaseGroups') {
-					return [];
-				}
-				return 1;
-			});
-	}
-
-	public function testCountWithSearchString(): void {
-		$this->enableGroups();
-
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn('cn=group,dc=foo,dc=bar');
-		$this->access->expects($this->any())
-			->method('fetchListOfUsers')
-			->willReturn([]);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($name) {
-				//the search operation will call readAttribute, thus we need
-				//to analyze the "dn". All other times we just need to return
-				//something that is neither null or false, but once an array
-				//with the users in the group – so we do so all other times for
-				//simplicity.
-				if (str_starts_with($name, 'u')) {
-					return strpos($name, '3');
-				}
-				return ['u11', 'u22', 'u33', 'u34'];
-			});
-		$this->access->expects($this->any())
-			->method('dn2username')
-			->willReturnCallback(function () {
-				return 'foobar' . Server::get(ISecureRandom::class)->generate(7);
-			});
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('escapeFilterPart')
-			->willReturnArgument(0);
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['displayName', 'mail']);
-
-		$this->initBackend();
-		$users = $this->groupBackend->countUsersInGroup('group', '3');
-
-		$this->assertSame(2, $users);
-	}
-
-	public function testCountUsersWithPlugin(): void {
-		/** @var GroupPluginManager|MockObject $pluginManager */
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'countUsersInGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::COUNT_USERS)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('countUsersInGroup')
-			->with('gid', 'search')
-			->willReturn(42);
-
-		$this->initBackend();
-		$this->assertEquals($this->groupBackend->countUsersInGroup('gid', 'search'), 42);
-	}
-
-	public function testGidNumber2NameSuccess(): void {
-		$this->enableGroups();
-
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
-
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
-
-		$this->access->expects($this->once())
-			->method('dn2groupname')
-			->with('cn=foo,dc=barfoo,dc=bar')
-			->willReturn('MyGroup');
-
-		$this->initBackend();
-		$group = $this->groupBackend->gidNumber2Name('3117', $userDN);
-
-		$this->assertSame('MyGroup', $group);
-	}
-
-	public function testGidNumberID2NameNoGroup(): void {
-		$this->enableGroups();
-
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
-
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([]);
-
-		$this->access->expects($this->never())
-			->method('dn2groupname');
-
-		$this->initBackend();
-		$group = $this->groupBackend->gidNumber2Name('3117', $userDN);
+    private Access&MockObject $access;
+    private GroupPluginManager&MockObject $pluginManager;
+    private IConfig&MockObject $config;
+    private IUserManager&MockObject $ncUserManager;
+    private GroupLDAP $groupBackend;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->access = $this->getAccessMock();
+        $this->pluginManager = $this->createMock(GroupPluginManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->ncUserManager = $this->createMock(IUserManager::class);
+    }
+
+    public function initBackend(): void {
+        $this->groupBackend = new GroupLDAP($this->access, $this->pluginManager, $this->config, $this->ncUserManager);
+    }
+
+    public function testCountEmptySearchString(): void {
+        $groupDN = 'cn=group,dc=foo,dc=bar';
+
+        $this->enableGroups();
+
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn($groupDN);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn) use ($groupDN) {
+                if ($dn === $groupDN) {
+                    return [
+                        'uid=u11,ou=users,dc=foo,dc=bar',
+                        'uid=u22,ou=users,dc=foo,dc=bar',
+                        'uid=u33,ou=users,dc=foo,dc=bar',
+                        'uid=u34,ou=users,dc=foo,dc=bar'
+                    ];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+        // for primary groups
+        $this->access->expects($this->once())
+            ->method('countUsers')
+            ->willReturn(2);
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['displayName', 'mail']);
+
+        $this->initBackend();
+        $users = $this->groupBackend->countUsersInGroup('group');
+
+        $this->assertSame(6, $users);
+    }
+
+    /**
+     * @return MockObject|Access
+     */
+    private function getAccessMock() {
+        $lw = $this->createMock(ILDAPWrapper::class);
+        $connector = $this->getMockBuilder(Connection::class)
+            ->setConstructorArgs([$lw, '', null])
+            ->getMock();
+
+        $this->access = $this->createMock(Access::class);
+        $this->access->connection = $connector;
+        $this->access->userManager = $this->createMock(Manager::class);
+
+        return $this->access;
+    }
+
+    private function enableGroups(): void {
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapDynamicGroupMemberURL') {
+                    return '';
+                } elseif ($name === 'ldapBaseGroups') {
+                    return [];
+                }
+                return 1;
+            });
+    }
+
+    public function testCountWithSearchString(): void {
+        $this->enableGroups();
+
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn('cn=group,dc=foo,dc=bar');
+        $this->access->expects($this->any())
+            ->method('fetchListOfUsers')
+            ->willReturn([]);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($name) {
+                //the search operation will call readAttribute, thus we need
+                //to analyze the "dn". All other times we just need to return
+                //something that is neither null or false, but once an array
+                //with the users in the group – so we do so all other times for
+                //simplicity.
+                if (str_starts_with($name, 'u')) {
+                    return strpos($name, '3');
+                }
+                return ['u11', 'u22', 'u33', 'u34'];
+            });
+        $this->access->expects($this->any())
+            ->method('dn2username')
+            ->willReturnCallback(function () {
+                return 'foobar' . Server::get(ISecureRandom::class)->generate(7);
+            });
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('escapeFilterPart')
+            ->willReturnArgument(0);
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['displayName', 'mail']);
+
+        $this->initBackend();
+        $users = $this->groupBackend->countUsersInGroup('group', '3');
+
+        $this->assertSame(2, $users);
+    }
+
+    public function testCountUsersWithPlugin(): void {
+        /** @var GroupPluginManager|MockObject $pluginManager */
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'countUsersInGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::COUNT_USERS)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('countUsersInGroup')
+            ->with('gid', 'search')
+            ->willReturn(42);
+
+        $this->initBackend();
+        $this->assertEquals($this->groupBackend->countUsersInGroup('gid', 'search'), 42);
+    }
+
+    public function testGidNumber2NameSuccess(): void {
+        $this->enableGroups();
+
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
+
+        $this->access->expects($this->once())
+            ->method('dn2groupname')
+            ->with('cn=foo,dc=barfoo,dc=bar')
+            ->willReturn('MyGroup');
+
+        $this->initBackend();
+        $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
+
+        $this->assertSame('MyGroup', $group);
+    }
+
+    public function testGidNumberID2NameNoGroup(): void {
+        $this->enableGroups();
+
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([]);
+
+        $this->access->expects($this->never())
+            ->method('dn2groupname');
+
+        $this->initBackend();
+        $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
 
-		$this->assertSame(false, $group);
-	}
+        $this->assertSame(false, $group);
+    }
 
-	public function testGidNumberID2NameNoName(): void {
-		$this->enableGroups();
+    public function testGidNumberID2NameNoName(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
 
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
 
-		$this->access->expects($this->once())
-			->method('dn2groupname')
-			->willReturn(false);
+        $this->access->expects($this->once())
+            ->method('dn2groupname')
+            ->willReturn(false);
 
-		$this->initBackend();
-		$group = $this->groupBackend->gidNumber2Name('3117', $userDN);
+        $this->initBackend();
+        $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
 
-		$this->assertSame(false, $group);
-	}
+        $this->assertSame(false, $group);
+    }
 
-	public function testGetEntryGidNumberValue(): void {
-		$this->enableGroups();
+    public function testGetEntryGidNumberValue(): void {
+        $this->enableGroups();
 
-		$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
-		$attr = 'gidNumber';
+        $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
+        $attr = 'gidNumber';
 
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($dn, $attr)
-			->willReturn(['3117']);
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($dn, $attr)
+            ->willReturn(['3117']);
 
-		$this->initBackend();
-		$gid = $this->groupBackend->getGroupGidNumber($dn);
+        $this->initBackend();
+        $gid = $this->groupBackend->getGroupGidNumber($dn);
 
-		$this->assertSame('3117', $gid);
-	}
+        $this->assertSame('3117', $gid);
+    }
 
-	public function testGetEntryGidNumberNoValue(): void {
-		$this->enableGroups();
+    public function testGetEntryGidNumberNoValue(): void {
+        $this->enableGroups();
 
-		$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
-		$attr = 'gidNumber';
+        $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
+        $attr = 'gidNumber';
 
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($dn, $attr)
-			->willReturn(false);
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($dn, $attr)
+            ->willReturn(false);
 
-		$this->initBackend();
-		$gid = $this->groupBackend->getGroupGidNumber($dn);
+        $this->initBackend();
+        $gid = $this->groupBackend->getGroupGidNumber($dn);
 
-		$this->assertSame(false, $gid);
-	}
+        $this->assertSame(false, $gid);
+    }
 
-	public function testPrimaryGroupID2NameSuccessCache(): void {
-		$this->enableGroups();
+    public function testPrimaryGroupID2NameSuccessCache(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
-		$gid = '3117';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $gid = '3117';
 
-		/** @var MockObject $connection */
-		$connection = $this->access->connection;
-		$connection->expects($this->once())
-			->method('getFromCache')
-			->with('primaryGroupIDtoName_' . $gid)
-			->willReturn('MyGroup');
+        /** @var MockObject $connection */
+        $connection = $this->access->connection;
+        $connection->expects($this->once())
+            ->method('getFromCache')
+            ->with('primaryGroupIDtoName_' . $gid)
+            ->willReturn('MyGroup');
 
-		$this->access->expects($this->never())
-			->method('getSID');
+        $this->access->expects($this->never())
+            ->method('getSID');
 
-		$this->access->expects($this->never())
-			->method('searchGroups');
+        $this->access->expects($this->never())
+            ->method('searchGroups');
 
-		$this->access->expects($this->never())
-			->method('dn2groupname');
+        $this->access->expects($this->never())
+            ->method('dn2groupname');
 
-		$this->initBackend();
-		$group = $this->groupBackend->primaryGroupID2Name($gid, $userDN);
+        $this->initBackend();
+        $group = $this->groupBackend->primaryGroupID2Name($gid, $userDN);
 
-		$this->assertSame('MyGroup', $group);
-	}
+        $this->assertSame('MyGroup', $group);
+    }
 
-	public function testPrimaryGroupID2NameSuccess(): void {
-		$this->enableGroups();
+    public function testPrimaryGroupID2NameSuccess(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
 
-		$this->access->expects($this->once())
-			->method('getSID')
-			->with($userDN)
-			->willReturn('S-1-5-21-249921958-728525901-1594176202');
+        $this->access->expects($this->once())
+            ->method('getSID')
+            ->with($userDN)
+            ->willReturn('S-1-5-21-249921958-728525901-1594176202');
 
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
 
-		$this->access->expects($this->once())
-			->method('dn2groupname')
-			->with('cn=foo,dc=barfoo,dc=bar')
-			->willReturn('MyGroup');
+        $this->access->expects($this->once())
+            ->method('dn2groupname')
+            ->with('cn=foo,dc=barfoo,dc=bar')
+            ->willReturn('MyGroup');
 
-		$this->initBackend();
-		$group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
+        $this->initBackend();
+        $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
 
-		$this->assertSame('MyGroup', $group);
-	}
+        $this->assertSame('MyGroup', $group);
+    }
 
-	public function testPrimaryGroupID2NameNoSID(): void {
-		$this->enableGroups();
+    public function testPrimaryGroupID2NameNoSID(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
 
-		$this->access->expects($this->once())
-			->method('getSID')
-			->with($userDN)
-			->willReturn(false);
+        $this->access->expects($this->once())
+            ->method('getSID')
+            ->with($userDN)
+            ->willReturn(false);
 
-		$this->access->expects($this->never())
-			->method('searchGroups');
+        $this->access->expects($this->never())
+            ->method('searchGroups');
 
-		$this->access->expects($this->never())
-			->method('dn2groupname');
+        $this->access->expects($this->never())
+            ->method('dn2groupname');
 
-		$this->initBackend();
-		$group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
+        $this->initBackend();
+        $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
 
-		$this->assertSame(false, $group);
-	}
+        $this->assertSame(false, $group);
+    }
 
-	public function testPrimaryGroupID2NameNoGroup(): void {
-		$this->enableGroups();
+    public function testPrimaryGroupID2NameNoGroup(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
 
-		$this->access->expects($this->once())
-			->method('getSID')
-			->with($userDN)
-			->willReturn('S-1-5-21-249921958-728525901-1594176202');
+        $this->access->expects($this->once())
+            ->method('getSID')
+            ->with($userDN)
+            ->willReturn('S-1-5-21-249921958-728525901-1594176202');
 
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([]);
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([]);
 
-		$this->access->expects($this->never())
-			->method('dn2groupname');
+        $this->access->expects($this->never())
+            ->method('dn2groupname');
 
-		$this->initBackend();
-		$group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
+        $this->initBackend();
+        $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
 
-		$this->assertSame(false, $group);
-	}
+        $this->assertSame(false, $group);
+    }
 
-	public function testPrimaryGroupID2NameNoName(): void {
-		$this->enableGroups();
+    public function testPrimaryGroupID2NameNoName(): void {
+        $this->enableGroups();
 
-		$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
+        $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
 
-		$this->access->expects($this->once())
-			->method('getSID')
-			->with($userDN)
-			->willReturn('S-1-5-21-249921958-728525901-1594176202');
+        $this->access->expects($this->once())
+            ->method('getSID')
+            ->with($userDN)
+            ->willReturn('S-1-5-21-249921958-728525901-1594176202');
 
-		$this->access->expects($this->once())
-			->method('searchGroups')
-			->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
+        $this->access->expects($this->once())
+            ->method('searchGroups')
+            ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
 
-		$this->access->expects($this->once())
-			->method('dn2groupname')
-			->willReturn(false);
+        $this->access->expects($this->once())
+            ->method('dn2groupname')
+            ->willReturn(false);
 
-		$this->initBackend();
-		$group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
-
-		$this->assertSame(false, $group);
-	}
-
-	public function testGetEntryGroupIDValue(): void {
-		//tests getEntryGroupID via getGroupPrimaryGroupID
-		//which is basically identical to getUserPrimaryGroupIDs
-		$this->enableGroups();
-
-		$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
-		$attr = 'primaryGroupToken';
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($dn, $attr)
-			->willReturn(['3117']);
-
-		$this->initBackend();
-		$gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
-
-		$this->assertSame('3117', $gid);
-	}
-
-	public function testGetEntryGroupIDNoValue(): void {
-		//tests getEntryGroupID via getGroupPrimaryGroupID
-		//which is basically identical to getUserPrimaryGroupIDs
-		$this->enableGroups();
-
-		$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
-		$attr = 'primaryGroupToken';
-
-		$this->access->expects($this->once())
-			->method('readAttribute')
-			->with($dn, $attr)
-			->willReturn(false);
-
-		$this->initBackend();
-		$gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
-
-		$this->assertSame(false, $gid);
-	}
-
-	/**
-	 * tests whether Group Backend behaves correctly when cache with uid and gid
-	 * is hit
-	 */
-	public function testInGroupHitsUidGidCache(): void {
-		$this->enableGroups();
-
-		$uid = 'someUser';
-		$gid = 'someGroup';
-		$cacheKey = 'inGroup' . $uid . ':' . $gid;
-
-		$this->access->connection->expects($this->once())
-			->method('getFromCache')
-			->with($cacheKey)
-			->willReturn(true);
-
-		$this->access->expects($this->never())
-			->method('username2dn');
-
-		$this->initBackend();
-		$this->groupBackend->inGroup($uid, $gid);
-	}
-
-	public static function groupWithMembersProvider(): array {
-		return [
-			[
-				'someGroup',
-				'cn=someGroup,ou=allTheGroups,ou=someDepartment,dc=someDomain,dc=someTld',
-				[
-					'uid=oneUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
-					'uid=someUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
-					'uid=anotherUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
-					'uid=differentUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
-				],
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
-	public function testInGroupMember(string $gid, string $groupDn, array $memberDNs): void {
-		$uid = 'someUser';
-		$userDn = $memberDNs[0];
-
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				switch ($name) {
-					case 'ldapGroupMemberAssocAttr':
-						return 'member';
-					case 'ldapDynamicGroupMemberURL':
-						return '';
-					case 'hasPrimaryGroups':
-					case 'ldapNestedGroups':
-						return 0;
-					default:
-						return 1;
-				}
-			});
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->with($uid)
-			->willReturn($userDn);
-		$this->access->expects($this->once())
-			->method('groupname2dn')
-			->willReturn($groupDn);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturn($memberDNs);
-
-		$this->initBackend();
-		$this->assertTrue($this->groupBackend->inGroup($uid, $gid));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
-	public function testInGroupMemberNot(string $gid, string $groupDn, array $memberDNs): void {
-		$uid = 'unelatedUser';
-		$userDn = 'uid=unrelatedUser,ou=unrelatedTeam,ou=unrelatedDepartment,dc=someDomain,dc=someTld';
-
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				switch ($name) {
-					case 'ldapGroupMemberAssocAttr':
-						return 'member';
-					case 'ldapDynamicGroupMemberURL':
-						return '';
-					case 'hasPrimaryGroups':
-					case 'ldapNestedGroups':
-						return 0;
-					default:
-						return 1;
-				}
-			});
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->with($uid)
-			->willReturn($userDn);
-		$this->access->expects($this->once())
-			->method('groupname2dn')
-			->willReturn($groupDn);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturn($memberDNs);
-
-		$this->initBackend();
-		$this->assertFalse($this->groupBackend->inGroup($uid, $gid));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
-	public function testInGroupMemberUid(string $gid, string $groupDn, array $memberDNs): void {
-		$memberUids = [];
-		$userRecords = [];
-		foreach ($memberDNs as $dn) {
-			$memberUids[] = ldap_explode_dn($dn, 0)[0];
-			$userRecords[] = ['dn' => [$dn]];
-		}
-
-		$uid = 'someUser';
-		$userDn = $memberDNs[0];
-
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				switch ($name) {
-					case 'ldapGroupMemberAssocAttr':
-						return 'memberUid';
-					case 'ldapDynamicGroupMemberURL':
-						return '';
-					case 'ldapLoginFilter':
-						return 'uid=%uid';
-					case 'hasPrimaryGroups':
-					case 'ldapNestedGroups':
-						return 0;
-					default:
-						return 1;
-				}
-			});
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['uid', 'mail', 'displayname']);
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->with($uid)
-			->willReturn($userDn);
-		$this->access->expects($this->once())
-			->method('groupname2dn')
-			->willReturn($groupDn);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturn($memberUids);
-		$this->access->expects($this->any())
-			->method('fetchListOfUsers')
-			->willReturn($userRecords);
-		$this->access->expects($this->any())
-			->method('combineFilterWithOr')
-			->willReturn('(|(pseudo=filter)(filter=pseudo))');
-
-		$this->initBackend();
-		$this->assertTrue($this->groupBackend->inGroup($uid, $gid));
-	}
-
-	public function testGetGroupsWithOffset(): void {
-		$this->enableGroups();
-
-		$this->access->expects($this->once())
-			->method('nextcloudGroupNames')
-			->willReturn(['group1', 'group2']);
-
-		$this->initBackend();
-		$groups = $this->groupBackend->getGroups('', 2, 2);
-
-		$this->assertSame(2, count($groups));
-	}
-
-	/**
-	 * tests that a user listing is complete, if all its members have the group
-	 * as their primary.
-	 */
-	public function testUsersInGroupPrimaryMembersOnly(): void {
-		$this->enableGroups();
-
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($attr === 'primaryGroupToken') {
-					return [1337];
-				} elseif ($attr === 'gidNumber') {
-					return [4211];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn('cn=foobar,dc=foo,dc=bar');
-		$this->access->expects($this->exactly(2))
-			->method('nextcloudUserNames')
-			->willReturnOnConsecutiveCalls(['lisa', 'bart', 'kira', 'brad'], ['walle', 'dino', 'xenia']);
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('combineFilterWithAnd')
-			->willReturn('pseudo=filter');
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['displayName', 'mail']);
-
-		$this->initBackend();
-		$users = $this->groupBackend->usersInGroup('foobar');
-
-		$this->assertSame(7, count($users));
-	}
-
-	/**
-	 * tests that a user listing is complete, if all its members have the group
-	 * as their primary.
-	 */
-	public function testUsersInGroupPrimaryAndUnixMembers(): void {
-		$this->enableGroups();
-
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($attr === 'primaryGroupToken') {
-					return [1337];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn('cn=foobar,dc=foo,dc=bar');
-		$this->access->expects($this->once())
-			->method('nextcloudUserNames')
-			->willReturn(['lisa', 'bart', 'kira', 'brad']);
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-		$this->access->expects($this->any())
-			->method('combineFilterWithAnd')
-			->willReturn('pseudo=filter');
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['displayName', 'mail']);
-
-		$this->initBackend();
-		$users = $this->groupBackend->usersInGroup('foobar');
-
-		$this->assertSame(4, count($users));
-	}
-
-	/**
-	 * tests that a user counting is complete, if all its members have the group
-	 * as their primary.
-	 */
-	public function testCountUsersInGroupPrimaryMembersOnly(): void {
-		$this->enableGroups();
-
-		$this->access->connection->expects($this->any())
-			->method('getFromCache')
-			->willReturn(null);
-
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
-				if ($attr === 'primaryGroupToken') {
-					return [1337];
-				}
-				return [];
-			});
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn('cn=foobar,dc=foo,dc=bar');
-		$this->access->expects($this->once())
-			->method('countUsers')
-			->willReturn(4);
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-
-		$this->access->userManager->expects($this->any())
-			->method('getAttributes')
-			->willReturn(['displayName', 'mail']);
-
-		$this->initBackend();
-		$users = $this->groupBackend->countUsersInGroup('foobar');
-
-		$this->assertSame(4, $users);
-	}
-
-	public function testGetUserGroupsMemberOf(): void {
-		$this->enableGroups();
-
-		$dn = 'cn=userX,dc=foobar';
-
-		$this->access->connection->hasPrimaryGroups = false;
-		$this->access->connection->hasGidNumber = false;
-
-		$expectedGroups = ['cn=groupA,dc=foobar', 'cn=groupB,dc=foobar'];
-
-		$this->access->expects($this->any())
-			->method('username2dn')
-			->willReturn($dn);
-		$this->access->expects($this->exactly(5))
-			->method('readAttribute')->willReturnOnConsecutiveCalls($expectedGroups, [], [], [], []);
-		$this->access->expects($this->any())
-			->method('dn2groupname')
-			->willReturnArgument(0);
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturnArgument(0);
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with('userX', 'user_ldap', 'cached-group-memberships-', \json_encode($expectedGroups));
-
-		$this->initBackend();
-		$groups = $this->groupBackend->getUserGroups('userX');
-
-		$this->assertSame(2, count($groups));
-	}
-
-	public function testGetUserGroupsMemberOfDisabled(): void {
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'useMemberOfToDetectMembership') {
-					return 0;
-				} elseif ($name === 'ldapDynamicGroupMemberURL') {
-					return '';
-				}
-				return 1;
-			});
-
-		$dn = 'cn=userX,dc=foobar';
-
-		$this->access->connection->hasPrimaryGroups = false;
-		$this->access->connection->hasGidNumber = false;
-
-		$this->access->expects($this->once())
-			->method('username2dn')
-			->willReturn($dn);
-		$this->access->expects($this->never())
-			->method('readAttribute')
-			->with($dn, 'memberOf');
-		$this->access->expects($this->once())
-			->method('nextcloudGroupNames')
-			->willReturn([]);
-
-		// empty group result should not be oer
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with('userX', 'user_ldap', 'cached-group-memberships-', '[]');
-
-		$ldapUser = $this->createMock(User::class);
-
-		$this->access->userManager->expects($this->any())
-			->method('get')
-			->with('userX')
-			->willReturn($ldapUser);
-
-		$userBackend = $this->createMock(User_Proxy::class);
-		$userBackend->expects($this->once())
-			->method('userExistsOnLDAP')
-			->with('userX', true)
-			->willReturn(true);
-
-		$ncUser = $this->createMock(IUser::class);
-		$ncUser->expects($this->any())
-			->method('getBackend')
-			->willReturn($userBackend);
-
-		$this->ncUserManager->expects($this->once())
-			->method('get')
-			->with('userX')
-			->willReturn($ncUser);
-
-		$this->initBackend();
-		$this->groupBackend->getUserGroups('userX');
-	}
-
-	public function testGetUserGroupsOfflineUser(): void {
-		$this->enableGroups();
-
-		$offlineUser = $this->createMock(OfflineUser::class);
-
-		$this->config->expects($this->any())
-			->method('getUserValue')
-			->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
-			->willReturn(\json_encode(['groupB', 'groupF']));
-
-		$this->access->userManager->expects($this->any())
-			->method('get')
-			->with('userX')
-			->willReturn($offlineUser);
-
-		$this->initBackend();
-		$returnedGroups = $this->groupBackend->getUserGroups('userX');
-		$this->assertCount(2, $returnedGroups);
-		$this->assertContains('groupB', $returnedGroups);
-		$this->assertContains('groupF', $returnedGroups);
-	}
-
-	/**
-	 * regression tests against a case where a json object was stored instead of expected list
-	 * @see https://github.com/nextcloud/server/issues/42374
-	 */
-	public function testGetUserGroupsOfflineUserUnexpectedJson(): void {
-		$this->enableGroups();
-
-		$offlineUser = $this->createMock(OfflineUser::class);
-
-		$this->config->expects($this->any())
-			->method('getUserValue')
-			->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
-			// results in a json object: {"0":"groupB","2":"groupF"}
-			->willReturn(\json_encode([0 => 'groupB', 2 => 'groupF']));
-
-		$this->access->userManager->expects($this->any())
-			->method('get')
-			->with('userX')
-			->willReturn($offlineUser);
-
-		$this->initBackend();
-		$returnedGroups = $this->groupBackend->getUserGroups('userX');
-		$this->assertCount(2, $returnedGroups);
-		$this->assertContains('groupB', $returnedGroups);
-		$this->assertContains('groupF', $returnedGroups);
-	}
-
-	public function testGetUserGroupsUnrecognizedOfflineUser(): void {
-		$this->enableGroups();
-		$dn = 'cn=userX,dc=foobar';
-
-		$ldapUser = $this->createMock(User::class);
-
-		$userBackend = $this->createMock(User_Proxy::class);
-		$userBackend->expects($this->once())
-			->method('userExistsOnLDAP')
-			->with('userX', true)
-			->willReturn(false);
-
-		$ncUser = $this->createMock(IUser::class);
-		$ncUser->expects($this->any())
-			->method('getBackend')
-			->willReturn($userBackend);
-
-		$this->config->expects($this->atLeastOnce())
-			->method('getUserValue')
-			->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
-			->willReturn(\json_encode(['groupB', 'groupF']));
-
-		$this->access->expects($this->any())
-			->method('username2dn')
-			->willReturn($dn);
-
-		$this->access->userManager->expects($this->any())
-			->method('get')
-			->with('userX')
-			->willReturn($ldapUser);
-
-		$this->ncUserManager->expects($this->once())
-			->method('get')
-			->with('userX')
-			->willReturn($ncUser);
-
-		$this->initBackend();
-		$returnedGroups = $this->groupBackend->getUserGroups('userX');
-		$this->assertCount(2, $returnedGroups);
-		$this->assertContains('groupB', $returnedGroups);
-		$this->assertContains('groupF', $returnedGroups);
-	}
-
-	public static function nestedGroupsProvider(): array {
-		return [
-			[true],
-			[false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('nestedGroupsProvider')]
-	public function testGetGroupsByMember(bool $nestedGroups): void {
-		$groupFilter = '(&(objectclass=nextcloudGroup)(nextcloudEnabled=TRUE))';
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function (string $name) use ($nestedGroups, $groupFilter) {
-				switch ($name) {
-					case 'useMemberOfToDetectMembership':
-						return 0;
-					case 'ldapDynamicGroupMemberURL':
-						return '';
-					case 'ldapNestedGroups':
-						return (int)$nestedGroups;
-					case 'ldapGroupMemberAssocAttr':
-						return 'member';
-					case 'ldapGroupFilter':
-						return $groupFilter;
-					case 'ldapBaseGroups':
-						return [];
-					case 'ldapGroupDisplayName':
-						return 'cn';
-				}
-				return 1;
-			});
-
-		$dn = 'cn=userX,dc=foobar';
-
-		$this->access->connection->hasPrimaryGroups = false;
-		$this->access->connection->hasGidNumber = false;
-
-		$this->access->expects($this->exactly(2))
-			->method('username2dn')
-			->willReturn($dn);
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturn([]);
-		$this->access->expects($this->any())
-			->method('combineFilterWithAnd')
-			->willReturnCallback(function (array $filterParts) {
-				// ⚠ returns a pseudo-filter only, not real LDAP Filter syntax
-				return implode('&', $filterParts);
-			});
-
-		$group1 = [
-			'cn' => 'group1',
-			'dn' => ['cn=group1,ou=groups,dc=domain,dc=com'],
-			'member' => [$dn],
-		];
-		$group2 = [
-			'cn' => 'group2',
-			'dn' => ['cn=group2,ou=groups,dc=domain,dc=com'],
-			'member' => [$dn],
-		];
-		$group3 = [
-			'cn' => 'group3',
-			'dn' => ['cn=group3,ou=groups,dc=domain,dc=com'],
-			'member' => [$group2['dn'][0]],
-		];
-
-		$expectedGroups = ($nestedGroups ? [$group1, $group2, $group3] : [$group1, $group2]);
-		$expectedGroupsNames = ($nestedGroups ? ['group1', 'group2', 'group3'] : ['group1', 'group2']);
-
-		$this->access->expects($this->any())
-			->method('nextcloudGroupNames')
-			->with($expectedGroups)
-			->willReturn($expectedGroupsNames);
-		$this->access->expects($nestedGroups ? $this->atLeastOnce() : $this->once())
-			->method('fetchListOfGroups')
-			->willReturnCallback(function ($filter, $attr, $limit, $offset) use ($nestedGroups, $groupFilter, $group1, $group2, $group3, $dn) {
-				static $firstRun = true;
-				if (!$nestedGroups) {
-					// When nested groups are enabled, groups cannot be filtered early as it would
-					// exclude intermediate groups. But we can, and should, when working with flat groups.
-					$this->assertTrue(str_contains($filter, $groupFilter));
-				}
-				[$memberFilter] = explode('&', $filter);
-				if ($memberFilter === 'member=' . $dn) {
-					return [$group1, $group2];
-					return [];
-				} elseif ($memberFilter === 'member=' . $group2['dn'][0]) {
-					return [$group3];
-				} else {
-					return [];
-				}
-			});
-		$this->access->expects($this->any())
-			->method('dn2groupname')
-			->willReturnCallback(function (string $dn) {
-				return ldap_explode_dn($dn, 1)[0];
-			});
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturnCallback(function (string $gid) use ($group1, $group2, $group3) {
-				if ($gid === $group1['cn']) {
-					return $group1['dn'][0];
-				}
-				if ($gid === $group2['cn']) {
-					return $group2['dn'][0];
-				}
-				if ($gid === $group3['cn']) {
-					return $group3['dn'][0];
-				}
-			});
-		$this->access->expects($this->any())
-			->method('isDNPartOfBase')
-			->willReturn(true);
-
-		$this->initBackend();
-		$groups = $this->groupBackend->getUserGroups('userX');
-		$this->assertEquals($expectedGroupsNames, $groups);
-
-		$groupsAgain = $this->groupBackend->getUserGroups('userX');
-		$this->assertEquals($expectedGroupsNames, $groupsAgain);
-	}
-
-	public function testCreateGroupWithPlugin(): void {
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'createGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::CREATE_GROUP)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('createGroup')
-			->with('gid')
-			->willReturn('result');
-
-		$this->initBackend();
-		$this->assertTrue($this->groupBackend->createGroup('gid'));
-	}
-
-
-	public function testCreateGroupFailing(): void {
-		$this->expectException(\Exception::class);
-
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'createGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::CREATE_GROUP)
-			->willReturn(false);
-
-		$this->initBackend();
-		$this->groupBackend->createGroup('gid');
-	}
-
-	public function testDeleteGroupWithPlugin(): void {
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'deleteGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::DELETE_GROUP)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('deleteGroup')
-			->with('gid')
-			->willReturn(true);
-
-		$mapper = $this->getMockBuilder(GroupMapping::class)
-			->onlyMethods(['unmap'])
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->access->expects($this->any())
-			->method('getGroupMapper')
-			->willReturn($mapper);
-
-		$this->initBackend();
-		$this->assertTrue($this->groupBackend->deleteGroup('gid'));
-	}
-
-
-	public function testDeleteGroupFailing(): void {
-		$this->expectException(\Exception::class);
-
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'deleteGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::DELETE_GROUP)
-			->willReturn(false);
-
-		$this->initBackend();
-		$this->groupBackend->deleteGroup('gid');
-	}
-
-	public function testAddToGroupWithPlugin(): void {
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'addToGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::ADD_TO_GROUP)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('addToGroup')
-			->with('uid', 'gid')
-			->willReturn('result');
-
-		$this->initBackend();
-		$this->assertEquals('result', $this->groupBackend->addToGroup('uid', 'gid'));
-	}
-
-
-	public function testAddToGroupFailing(): void {
-		$this->expectException(\Exception::class);
-
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'addToGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::ADD_TO_GROUP)
-			->willReturn(false);
-
-		$this->initBackend();
-		$this->groupBackend->addToGroup('uid', 'gid');
-	}
-
-	public function testRemoveFromGroupWithPlugin(): void {
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'removeFromGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::REMOVE_FROM_GROUP)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('removeFromGroup')
-			->with('uid', 'gid')
-			->willReturn('result');
-
-		$this->initBackend();
-		$this->assertEquals('result', $this->groupBackend->removeFromGroup('uid', 'gid'));
-	}
-
-
-	public function testRemoveFromGroupFailing(): void {
-		$this->expectException(\Exception::class);
-
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'removeFromGroup'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::REMOVE_FROM_GROUP)
-			->willReturn(false);
-
-		$this->initBackend();
-		$this->groupBackend->removeFromGroup('uid', 'gid');
-	}
-
-	public function testGetGroupDetailsWithPlugin(): void {
-		/** @var GroupPluginManager|MockObject $pluginManager */
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'getGroupDetails'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::GROUP_DETAILS)
-			->willReturn(true);
-
-		$this->pluginManager->expects($this->once())
-			->method('getGroupDetails')
-			->with('gid')
-			->willReturn('result');
-
-		$this->initBackend();
-		$this->assertEquals('result', $this->groupBackend->getGroupDetails('gid'));
-	}
-
-	public function testGetGroupDetailsFailing(): void {
-		$this->expectException(\Exception::class);
-
-		$this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
-			->onlyMethods(['implementsActions', 'getGroupDetails'])
-			->getMock();
-
-		$this->pluginManager->expects($this->once())
-			->method('implementsActions')
-			->with(GroupInterface::GROUP_DETAILS)
-			->willReturn(false);
-
-		$this->initBackend();
-		$this->groupBackend->getGroupDetails('gid');
-	}
-
-	public static function groupMemberProvider(): array {
-		$base = 'dc=species,dc=earth';
-
-		$birdsDn = [
-			'uid=3723,' . $base,
-			'uid=8372,' . $base,
-			'uid=8427,' . $base,
-			'uid=2333,' . $base,
-			'uid=4754,' . $base,
-		];
-		$birdsUid = [
-			'3723',
-			'8372',
-			'8427',
-			'2333',
-			'4754',
-		];
-		$animalsDn = [
-			'uid=lion,' . $base,
-			'uid=tiger,' . $base,
-		];
-		$plantsDn = [
-			'uid=flower,' . $base,
-			'uid=tree,' . $base,
-		];
-		$thingsDn = [
-			'uid=thing1,' . $base,
-			'uid=thing2,' . $base,
-		];
-
-		return [
-			[ #0 – test DNs
-				['cn=Birds,' . $base => $birdsDn],
-				['cn=Birds,' . $base => $birdsDn]
-			],
-			[ #1 – test uids
-				['cn=Birds,' . $base => $birdsUid],
-				['cn=Birds,' . $base => $birdsUid]
-			],
-			[ #2 – test simple nested group
-				['cn=Animals,' . $base => array_merge($birdsDn, $animalsDn)],
-				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
-					'cn=Birds,' . $base => $birdsDn,
-				]
-			],
-			[ #3 – test recursive nested group
-				[
-					'cn=Animals,' . $base => array_merge($birdsDn, $animalsDn),
-					'cn=Birds,' . $base => array_merge($birdsDn, $animalsDn),
-				],
-				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base,'cn=Birds,' . $base,'cn=Animals,' . $base], $animalsDn),
-					'cn=Birds,' . $base => array_merge(['cn=Animals,' . $base,'cn=Birds,' . $base], $birdsDn),
-				]
-			],
-			[ #4 – Complicated nested group
-				['cn=Things,' . $base => array_merge($birdsDn, $animalsDn, $thingsDn, $plantsDn)],
-				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
-					'cn=Birds,' . $base => $birdsDn,
-					'cn=Plants,' . $base => $plantsDn,
-					'cn=Things,' . $base => array_merge(['cn=Animals,' . $base,'cn=Plants,' . $base], $thingsDn),
-				]
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('groupMemberProvider')]
-	public function testGroupMembers(array $expectedResult, array $groupsInfo): void {
-		$this->access->expects($this->any())
-			->method('readAttribute')
-			->willReturnCallback(function ($group) use ($groupsInfo) {
-				if (isset($groupsInfo[$group])) {
-					return $groupsInfo[$group];
-				}
-				return [];
-			});
-
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function (string $name) {
-				if ($name === 'ldapNestedGroups') {
-					return 1;
-				} elseif ($name === 'ldapGroupMemberAssocAttr') {
-					return 'attr';
-				}
-				return null;
-			});
-
-		$this->initBackend();
-		foreach ($expectedResult as $groupDN => $expectedMembers) {
-			$resultingMembers = $this->invokePrivate($this->groupBackend, '_groupMembers', [$groupDN]);
-
-			sort($expectedMembers);
-			sort($resultingMembers);
-			$this->assertEquals($expectedMembers, $resultingMembers);
-		}
-	}
-
-	public static function displayNameProvider(): array {
-		return [
-			['Graphic Novelists', ['Graphic Novelists']],
-			['', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('displayNameProvider')]
-	public function testGetDisplayName(string $expected, bool|array $ldapResult): void {
-		$gid = 'graphic_novelists';
-
-		$this->access->expects($this->atLeastOnce())
-			->method('readAttribute')
-			->willReturn($ldapResult);
-
-		$this->access->connection->expects($this->any())
-			->method('__get')
-			->willReturnCallback(function ($name) {
-				if ($name === 'ldapGroupMemberAssocAttr') {
-					return 'member';
-				} elseif ($name === 'ldapGroupFilter') {
-					return 'objectclass=nextcloudGroup';
-				} elseif ($name === 'ldapGroupDisplayName') {
-					return 'cn';
-				}
-				return null;
-			});
-
-		$this->access->expects($this->any())
-			->method('groupname2dn')
-			->willReturn('fakedn');
-
-		$this->initBackend();
-		$this->assertSame($expected, $this->groupBackend->getDisplayName($gid));
-	}
+        $this->initBackend();
+        $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
+
+        $this->assertSame(false, $group);
+    }
+
+    public function testGetEntryGroupIDValue(): void {
+        //tests getEntryGroupID via getGroupPrimaryGroupID
+        //which is basically identical to getUserPrimaryGroupIDs
+        $this->enableGroups();
+
+        $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
+        $attr = 'primaryGroupToken';
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($dn, $attr)
+            ->willReturn(['3117']);
+
+        $this->initBackend();
+        $gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
+
+        $this->assertSame('3117', $gid);
+    }
+
+    public function testGetEntryGroupIDNoValue(): void {
+        //tests getEntryGroupID via getGroupPrimaryGroupID
+        //which is basically identical to getUserPrimaryGroupIDs
+        $this->enableGroups();
+
+        $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
+        $attr = 'primaryGroupToken';
+
+        $this->access->expects($this->once())
+            ->method('readAttribute')
+            ->with($dn, $attr)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
+
+        $this->assertSame(false, $gid);
+    }
+
+    /**
+     * tests whether Group Backend behaves correctly when cache with uid and gid
+     * is hit
+     */
+    public function testInGroupHitsUidGidCache(): void {
+        $this->enableGroups();
+
+        $uid = 'someUser';
+        $gid = 'someGroup';
+        $cacheKey = 'inGroup' . $uid . ':' . $gid;
+
+        $this->access->connection->expects($this->once())
+            ->method('getFromCache')
+            ->with($cacheKey)
+            ->willReturn(true);
+
+        $this->access->expects($this->never())
+            ->method('username2dn');
+
+        $this->initBackend();
+        $this->groupBackend->inGroup($uid, $gid);
+    }
+
+    public static function groupWithMembersProvider(): array {
+        return [
+            [
+                'someGroup',
+                'cn=someGroup,ou=allTheGroups,ou=someDepartment,dc=someDomain,dc=someTld',
+                [
+                    'uid=oneUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
+                    'uid=someUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
+                    'uid=anotherUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
+                    'uid=differentUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
+                ],
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
+    public function testInGroupMember(string $gid, string $groupDn, array $memberDNs): void {
+        $uid = 'someUser';
+        $userDn = $memberDNs[0];
+
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                switch ($name) {
+                    case 'ldapGroupMemberAssocAttr':
+                        return 'member';
+                    case 'ldapDynamicGroupMemberURL':
+                        return '';
+                    case 'hasPrimaryGroups':
+                    case 'ldapNestedGroups':
+                        return 0;
+                    default:
+                        return 1;
+                }
+            });
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->with($uid)
+            ->willReturn($userDn);
+        $this->access->expects($this->once())
+            ->method('groupname2dn')
+            ->willReturn($groupDn);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturn($memberDNs);
+
+        $this->initBackend();
+        $this->assertTrue($this->groupBackend->inGroup($uid, $gid));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
+    public function testInGroupMemberNot(string $gid, string $groupDn, array $memberDNs): void {
+        $uid = 'unelatedUser';
+        $userDn = 'uid=unrelatedUser,ou=unrelatedTeam,ou=unrelatedDepartment,dc=someDomain,dc=someTld';
+
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                switch ($name) {
+                    case 'ldapGroupMemberAssocAttr':
+                        return 'member';
+                    case 'ldapDynamicGroupMemberURL':
+                        return '';
+                    case 'hasPrimaryGroups':
+                    case 'ldapNestedGroups':
+                        return 0;
+                    default:
+                        return 1;
+                }
+            });
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->with($uid)
+            ->willReturn($userDn);
+        $this->access->expects($this->once())
+            ->method('groupname2dn')
+            ->willReturn($groupDn);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturn($memberDNs);
+
+        $this->initBackend();
+        $this->assertFalse($this->groupBackend->inGroup($uid, $gid));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('groupWithMembersProvider')]
+    public function testInGroupMemberUid(string $gid, string $groupDn, array $memberDNs): void {
+        $memberUids = [];
+        $userRecords = [];
+        foreach ($memberDNs as $dn) {
+            $memberUids[] = ldap_explode_dn($dn, 0)[0];
+            $userRecords[] = ['dn' => [$dn]];
+        }
+
+        $uid = 'someUser';
+        $userDn = $memberDNs[0];
+
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                switch ($name) {
+                    case 'ldapGroupMemberAssocAttr':
+                        return 'memberUid';
+                    case 'ldapDynamicGroupMemberURL':
+                        return '';
+                    case 'ldapLoginFilter':
+                        return 'uid=%uid';
+                    case 'hasPrimaryGroups':
+                    case 'ldapNestedGroups':
+                        return 0;
+                    default:
+                        return 1;
+                }
+            });
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['uid', 'mail', 'displayname']);
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->with($uid)
+            ->willReturn($userDn);
+        $this->access->expects($this->once())
+            ->method('groupname2dn')
+            ->willReturn($groupDn);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturn($memberUids);
+        $this->access->expects($this->any())
+            ->method('fetchListOfUsers')
+            ->willReturn($userRecords);
+        $this->access->expects($this->any())
+            ->method('combineFilterWithOr')
+            ->willReturn('(|(pseudo=filter)(filter=pseudo))');
+
+        $this->initBackend();
+        $this->assertTrue($this->groupBackend->inGroup($uid, $gid));
+    }
+
+    public function testGetGroupsWithOffset(): void {
+        $this->enableGroups();
+
+        $this->access->expects($this->once())
+            ->method('nextcloudGroupNames')
+            ->willReturn(['group1', 'group2']);
+
+        $this->initBackend();
+        $groups = $this->groupBackend->getGroups('', 2, 2);
+
+        $this->assertSame(2, count($groups));
+    }
+
+    /**
+     * tests that a user listing is complete, if all its members have the group
+     * as their primary.
+     */
+    public function testUsersInGroupPrimaryMembersOnly(): void {
+        $this->enableGroups();
+
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($attr === 'primaryGroupToken') {
+                    return [1337];
+                } elseif ($attr === 'gidNumber') {
+                    return [4211];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn('cn=foobar,dc=foo,dc=bar');
+        $this->access->expects($this->exactly(2))
+            ->method('nextcloudUserNames')
+            ->willReturnOnConsecutiveCalls(['lisa', 'bart', 'kira', 'brad'], ['walle', 'dino', 'xenia']);
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('combineFilterWithAnd')
+            ->willReturn('pseudo=filter');
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['displayName', 'mail']);
+
+        $this->initBackend();
+        $users = $this->groupBackend->usersInGroup('foobar');
+
+        $this->assertSame(7, count($users));
+    }
+
+    /**
+     * tests that a user listing is complete, if all its members have the group
+     * as their primary.
+     */
+    public function testUsersInGroupPrimaryAndUnixMembers(): void {
+        $this->enableGroups();
+
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($attr === 'primaryGroupToken') {
+                    return [1337];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn('cn=foobar,dc=foo,dc=bar');
+        $this->access->expects($this->once())
+            ->method('nextcloudUserNames')
+            ->willReturn(['lisa', 'bart', 'kira', 'brad']);
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+        $this->access->expects($this->any())
+            ->method('combineFilterWithAnd')
+            ->willReturn('pseudo=filter');
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['displayName', 'mail']);
+
+        $this->initBackend();
+        $users = $this->groupBackend->usersInGroup('foobar');
+
+        $this->assertSame(4, count($users));
+    }
+
+    /**
+     * tests that a user counting is complete, if all its members have the group
+     * as their primary.
+     */
+    public function testCountUsersInGroupPrimaryMembersOnly(): void {
+        $this->enableGroups();
+
+        $this->access->connection->expects($this->any())
+            ->method('getFromCache')
+            ->willReturn(null);
+
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($dn, $attr) {
+                if ($attr === 'primaryGroupToken') {
+                    return [1337];
+                }
+                return [];
+            });
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn('cn=foobar,dc=foo,dc=bar');
+        $this->access->expects($this->once())
+            ->method('countUsers')
+            ->willReturn(4);
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+
+        $this->access->userManager->expects($this->any())
+            ->method('getAttributes')
+            ->willReturn(['displayName', 'mail']);
+
+        $this->initBackend();
+        $users = $this->groupBackend->countUsersInGroup('foobar');
+
+        $this->assertSame(4, $users);
+    }
+
+    public function testGetUserGroupsMemberOf(): void {
+        $this->enableGroups();
+
+        $dn = 'cn=userX,dc=foobar';
+
+        $this->access->connection->hasPrimaryGroups = false;
+        $this->access->connection->hasGidNumber = false;
+
+        $expectedGroups = ['cn=groupA,dc=foobar', 'cn=groupB,dc=foobar'];
+
+        $this->access->expects($this->any())
+            ->method('username2dn')
+            ->willReturn($dn);
+        $this->access->expects($this->exactly(5))
+            ->method('readAttribute')->willReturnOnConsecutiveCalls($expectedGroups, [], [], [], []);
+        $this->access->expects($this->any())
+            ->method('dn2groupname')
+            ->willReturnArgument(0);
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturnArgument(0);
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with('userX', 'user_ldap', 'cached-group-memberships-', \json_encode($expectedGroups));
+
+        $this->initBackend();
+        $groups = $this->groupBackend->getUserGroups('userX');
+
+        $this->assertSame(2, count($groups));
+    }
+
+    public function testGetUserGroupsMemberOfDisabled(): void {
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'useMemberOfToDetectMembership') {
+                    return 0;
+                } elseif ($name === 'ldapDynamicGroupMemberURL') {
+                    return '';
+                }
+                return 1;
+            });
+
+        $dn = 'cn=userX,dc=foobar';
+
+        $this->access->connection->hasPrimaryGroups = false;
+        $this->access->connection->hasGidNumber = false;
+
+        $this->access->expects($this->once())
+            ->method('username2dn')
+            ->willReturn($dn);
+        $this->access->expects($this->never())
+            ->method('readAttribute')
+            ->with($dn, 'memberOf');
+        $this->access->expects($this->once())
+            ->method('nextcloudGroupNames')
+            ->willReturn([]);
+
+        // empty group result should not be oer
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with('userX', 'user_ldap', 'cached-group-memberships-', '[]');
+
+        $ldapUser = $this->createMock(User::class);
+
+        $this->access->userManager->expects($this->any())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($ldapUser);
+
+        $userBackend = $this->createMock(User_Proxy::class);
+        $userBackend->expects($this->once())
+            ->method('userExistsOnLDAP')
+            ->with('userX', true)
+            ->willReturn(true);
+
+        $ncUser = $this->createMock(IUser::class);
+        $ncUser->expects($this->any())
+            ->method('getBackend')
+            ->willReturn($userBackend);
+
+        $this->ncUserManager->expects($this->once())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($ncUser);
+
+        $this->initBackend();
+        $this->groupBackend->getUserGroups('userX');
+    }
+
+    public function testGetUserGroupsOfflineUser(): void {
+        $this->enableGroups();
+
+        $offlineUser = $this->createMock(OfflineUser::class);
+
+        $this->config->expects($this->any())
+            ->method('getUserValue')
+            ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
+            ->willReturn(\json_encode(['groupB', 'groupF']));
+
+        $this->access->userManager->expects($this->any())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($offlineUser);
+
+        $this->initBackend();
+        $returnedGroups = $this->groupBackend->getUserGroups('userX');
+        $this->assertCount(2, $returnedGroups);
+        $this->assertContains('groupB', $returnedGroups);
+        $this->assertContains('groupF', $returnedGroups);
+    }
+
+    /**
+     * regression tests against a case where a json object was stored instead of expected list
+     * @see https://github.com/nextcloud/server/issues/42374
+     */
+    public function testGetUserGroupsOfflineUserUnexpectedJson(): void {
+        $this->enableGroups();
+
+        $offlineUser = $this->createMock(OfflineUser::class);
+
+        $this->config->expects($this->any())
+            ->method('getUserValue')
+            ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
+            // results in a json object: {"0":"groupB","2":"groupF"}
+            ->willReturn(\json_encode([0 => 'groupB', 2 => 'groupF']));
+
+        $this->access->userManager->expects($this->any())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($offlineUser);
+
+        $this->initBackend();
+        $returnedGroups = $this->groupBackend->getUserGroups('userX');
+        $this->assertCount(2, $returnedGroups);
+        $this->assertContains('groupB', $returnedGroups);
+        $this->assertContains('groupF', $returnedGroups);
+    }
+
+    public function testGetUserGroupsUnrecognizedOfflineUser(): void {
+        $this->enableGroups();
+        $dn = 'cn=userX,dc=foobar';
+
+        $ldapUser = $this->createMock(User::class);
+
+        $userBackend = $this->createMock(User_Proxy::class);
+        $userBackend->expects($this->once())
+            ->method('userExistsOnLDAP')
+            ->with('userX', true)
+            ->willReturn(false);
+
+        $ncUser = $this->createMock(IUser::class);
+        $ncUser->expects($this->any())
+            ->method('getBackend')
+            ->willReturn($userBackend);
+
+        $this->config->expects($this->atLeastOnce())
+            ->method('getUserValue')
+            ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
+            ->willReturn(\json_encode(['groupB', 'groupF']));
+
+        $this->access->expects($this->any())
+            ->method('username2dn')
+            ->willReturn($dn);
+
+        $this->access->userManager->expects($this->any())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($ldapUser);
+
+        $this->ncUserManager->expects($this->once())
+            ->method('get')
+            ->with('userX')
+            ->willReturn($ncUser);
+
+        $this->initBackend();
+        $returnedGroups = $this->groupBackend->getUserGroups('userX');
+        $this->assertCount(2, $returnedGroups);
+        $this->assertContains('groupB', $returnedGroups);
+        $this->assertContains('groupF', $returnedGroups);
+    }
+
+    public static function nestedGroupsProvider(): array {
+        return [
+            [true],
+            [false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('nestedGroupsProvider')]
+    public function testGetGroupsByMember(bool $nestedGroups): void {
+        $groupFilter = '(&(objectclass=nextcloudGroup)(nextcloudEnabled=TRUE))';
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function (string $name) use ($nestedGroups, $groupFilter) {
+                switch ($name) {
+                    case 'useMemberOfToDetectMembership':
+                        return 0;
+                    case 'ldapDynamicGroupMemberURL':
+                        return '';
+                    case 'ldapNestedGroups':
+                        return (int)$nestedGroups;
+                    case 'ldapGroupMemberAssocAttr':
+                        return 'member';
+                    case 'ldapGroupFilter':
+                        return $groupFilter;
+                    case 'ldapBaseGroups':
+                        return [];
+                    case 'ldapGroupDisplayName':
+                        return 'cn';
+                }
+                return 1;
+            });
+
+        $dn = 'cn=userX,dc=foobar';
+
+        $this->access->connection->hasPrimaryGroups = false;
+        $this->access->connection->hasGidNumber = false;
+
+        $this->access->expects($this->exactly(2))
+            ->method('username2dn')
+            ->willReturn($dn);
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturn([]);
+        $this->access->expects($this->any())
+            ->method('combineFilterWithAnd')
+            ->willReturnCallback(function (array $filterParts) {
+                // ⚠ returns a pseudo-filter only, not real LDAP Filter syntax
+                return implode('&', $filterParts);
+            });
+
+        $group1 = [
+            'cn' => 'group1',
+            'dn' => ['cn=group1,ou=groups,dc=domain,dc=com'],
+            'member' => [$dn],
+        ];
+        $group2 = [
+            'cn' => 'group2',
+            'dn' => ['cn=group2,ou=groups,dc=domain,dc=com'],
+            'member' => [$dn],
+        ];
+        $group3 = [
+            'cn' => 'group3',
+            'dn' => ['cn=group3,ou=groups,dc=domain,dc=com'],
+            'member' => [$group2['dn'][0]],
+        ];
+
+        $expectedGroups = ($nestedGroups ? [$group1, $group2, $group3] : [$group1, $group2]);
+        $expectedGroupsNames = ($nestedGroups ? ['group1', 'group2', 'group3'] : ['group1', 'group2']);
+
+        $this->access->expects($this->any())
+            ->method('nextcloudGroupNames')
+            ->with($expectedGroups)
+            ->willReturn($expectedGroupsNames);
+        $this->access->expects($nestedGroups ? $this->atLeastOnce() : $this->once())
+            ->method('fetchListOfGroups')
+            ->willReturnCallback(function ($filter, $attr, $limit, $offset) use ($nestedGroups, $groupFilter, $group1, $group2, $group3, $dn) {
+                static $firstRun = true;
+                if (!$nestedGroups) {
+                    // When nested groups are enabled, groups cannot be filtered early as it would
+                    // exclude intermediate groups. But we can, and should, when working with flat groups.
+                    $this->assertTrue(str_contains($filter, $groupFilter));
+                }
+                [$memberFilter] = explode('&', $filter);
+                if ($memberFilter === 'member=' . $dn) {
+                    return [$group1, $group2];
+                    return [];
+                } elseif ($memberFilter === 'member=' . $group2['dn'][0]) {
+                    return [$group3];
+                } else {
+                    return [];
+                }
+            });
+        $this->access->expects($this->any())
+            ->method('dn2groupname')
+            ->willReturnCallback(function (string $dn) {
+                return ldap_explode_dn($dn, 1)[0];
+            });
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturnCallback(function (string $gid) use ($group1, $group2, $group3) {
+                if ($gid === $group1['cn']) {
+                    return $group1['dn'][0];
+                }
+                if ($gid === $group2['cn']) {
+                    return $group2['dn'][0];
+                }
+                if ($gid === $group3['cn']) {
+                    return $group3['dn'][0];
+                }
+            });
+        $this->access->expects($this->any())
+            ->method('isDNPartOfBase')
+            ->willReturn(true);
+
+        $this->initBackend();
+        $groups = $this->groupBackend->getUserGroups('userX');
+        $this->assertEquals($expectedGroupsNames, $groups);
+
+        $groupsAgain = $this->groupBackend->getUserGroups('userX');
+        $this->assertEquals($expectedGroupsNames, $groupsAgain);
+    }
+
+    public function testCreateGroupWithPlugin(): void {
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'createGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::CREATE_GROUP)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('createGroup')
+            ->with('gid')
+            ->willReturn('result');
+
+        $this->initBackend();
+        $this->assertTrue($this->groupBackend->createGroup('gid'));
+    }
+
+
+    public function testCreateGroupFailing(): void {
+        $this->expectException(\Exception::class);
+
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'createGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::CREATE_GROUP)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $this->groupBackend->createGroup('gid');
+    }
+
+    public function testDeleteGroupWithPlugin(): void {
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'deleteGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::DELETE_GROUP)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('deleteGroup')
+            ->with('gid')
+            ->willReturn(true);
+
+        $mapper = $this->getMockBuilder(GroupMapping::class)
+            ->onlyMethods(['unmap'])
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->access->expects($this->any())
+            ->method('getGroupMapper')
+            ->willReturn($mapper);
+
+        $this->initBackend();
+        $this->assertTrue($this->groupBackend->deleteGroup('gid'));
+    }
+
+
+    public function testDeleteGroupFailing(): void {
+        $this->expectException(\Exception::class);
+
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'deleteGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::DELETE_GROUP)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $this->groupBackend->deleteGroup('gid');
+    }
+
+    public function testAddToGroupWithPlugin(): void {
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'addToGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::ADD_TO_GROUP)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('addToGroup')
+            ->with('uid', 'gid')
+            ->willReturn('result');
+
+        $this->initBackend();
+        $this->assertEquals('result', $this->groupBackend->addToGroup('uid', 'gid'));
+    }
+
+
+    public function testAddToGroupFailing(): void {
+        $this->expectException(\Exception::class);
+
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'addToGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::ADD_TO_GROUP)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $this->groupBackend->addToGroup('uid', 'gid');
+    }
+
+    public function testRemoveFromGroupWithPlugin(): void {
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'removeFromGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::REMOVE_FROM_GROUP)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('removeFromGroup')
+            ->with('uid', 'gid')
+            ->willReturn('result');
+
+        $this->initBackend();
+        $this->assertEquals('result', $this->groupBackend->removeFromGroup('uid', 'gid'));
+    }
+
+
+    public function testRemoveFromGroupFailing(): void {
+        $this->expectException(\Exception::class);
+
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'removeFromGroup'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::REMOVE_FROM_GROUP)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $this->groupBackend->removeFromGroup('uid', 'gid');
+    }
+
+    public function testGetGroupDetailsWithPlugin(): void {
+        /** @var GroupPluginManager|MockObject $pluginManager */
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'getGroupDetails'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::GROUP_DETAILS)
+            ->willReturn(true);
+
+        $this->pluginManager->expects($this->once())
+            ->method('getGroupDetails')
+            ->with('gid')
+            ->willReturn('result');
+
+        $this->initBackend();
+        $this->assertEquals('result', $this->groupBackend->getGroupDetails('gid'));
+    }
+
+    public function testGetGroupDetailsFailing(): void {
+        $this->expectException(\Exception::class);
+
+        $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
+            ->onlyMethods(['implementsActions', 'getGroupDetails'])
+            ->getMock();
+
+        $this->pluginManager->expects($this->once())
+            ->method('implementsActions')
+            ->with(GroupInterface::GROUP_DETAILS)
+            ->willReturn(false);
+
+        $this->initBackend();
+        $this->groupBackend->getGroupDetails('gid');
+    }
+
+    public static function groupMemberProvider(): array {
+        $base = 'dc=species,dc=earth';
+
+        $birdsDn = [
+            'uid=3723,' . $base,
+            'uid=8372,' . $base,
+            'uid=8427,' . $base,
+            'uid=2333,' . $base,
+            'uid=4754,' . $base,
+        ];
+        $birdsUid = [
+            '3723',
+            '8372',
+            '8427',
+            '2333',
+            '4754',
+        ];
+        $animalsDn = [
+            'uid=lion,' . $base,
+            'uid=tiger,' . $base,
+        ];
+        $plantsDn = [
+            'uid=flower,' . $base,
+            'uid=tree,' . $base,
+        ];
+        $thingsDn = [
+            'uid=thing1,' . $base,
+            'uid=thing2,' . $base,
+        ];
+
+        return [
+            [ #0 – test DNs
+                ['cn=Birds,' . $base => $birdsDn],
+                ['cn=Birds,' . $base => $birdsDn]
+            ],
+            [ #1 – test uids
+                ['cn=Birds,' . $base => $birdsUid],
+                ['cn=Birds,' . $base => $birdsUid]
+            ],
+            [ #2 – test simple nested group
+                ['cn=Animals,' . $base => array_merge($birdsDn, $animalsDn)],
+                [
+                    'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
+                    'cn=Birds,' . $base => $birdsDn,
+                ]
+            ],
+            [ #3 – test recursive nested group
+                [
+                    'cn=Animals,' . $base => array_merge($birdsDn, $animalsDn),
+                    'cn=Birds,' . $base => array_merge($birdsDn, $animalsDn),
+                ],
+                [
+                    'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base,'cn=Birds,' . $base,'cn=Animals,' . $base], $animalsDn),
+                    'cn=Birds,' . $base => array_merge(['cn=Animals,' . $base,'cn=Birds,' . $base], $birdsDn),
+                ]
+            ],
+            [ #4 – Complicated nested group
+                ['cn=Things,' . $base => array_merge($birdsDn, $animalsDn, $thingsDn, $plantsDn)],
+                [
+                    'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
+                    'cn=Birds,' . $base => $birdsDn,
+                    'cn=Plants,' . $base => $plantsDn,
+                    'cn=Things,' . $base => array_merge(['cn=Animals,' . $base,'cn=Plants,' . $base], $thingsDn),
+                ]
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('groupMemberProvider')]
+    public function testGroupMembers(array $expectedResult, array $groupsInfo): void {
+        $this->access->expects($this->any())
+            ->method('readAttribute')
+            ->willReturnCallback(function ($group) use ($groupsInfo) {
+                if (isset($groupsInfo[$group])) {
+                    return $groupsInfo[$group];
+                }
+                return [];
+            });
+
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function (string $name) {
+                if ($name === 'ldapNestedGroups') {
+                    return 1;
+                } elseif ($name === 'ldapGroupMemberAssocAttr') {
+                    return 'attr';
+                }
+                return null;
+            });
+
+        $this->initBackend();
+        foreach ($expectedResult as $groupDN => $expectedMembers) {
+            $resultingMembers = $this->invokePrivate($this->groupBackend, '_groupMembers', [$groupDN]);
+
+            sort($expectedMembers);
+            sort($resultingMembers);
+            $this->assertEquals($expectedMembers, $resultingMembers);
+        }
+    }
+
+    public static function displayNameProvider(): array {
+        return [
+            ['Graphic Novelists', ['Graphic Novelists']],
+            ['', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('displayNameProvider')]
+    public function testGetDisplayName(string $expected, bool|array $ldapResult): void {
+        $gid = 'graphic_novelists';
+
+        $this->access->expects($this->atLeastOnce())
+            ->method('readAttribute')
+            ->willReturn($ldapResult);
+
+        $this->access->connection->expects($this->any())
+            ->method('__get')
+            ->willReturnCallback(function ($name) {
+                if ($name === 'ldapGroupMemberAssocAttr') {
+                    return 'member';
+                } elseif ($name === 'ldapGroupFilter') {
+                    return 'objectclass=nextcloudGroup';
+                } elseif ($name === 'ldapGroupDisplayName') {
+                    return 'cn';
+                }
+                return null;
+            });
+
+        $this->access->expects($this->any())
+            ->method('groupname2dn')
+            ->willReturn('fakedn');
+
+        $this->initBackend();
+        $this->assertSame($expected, $this->groupBackend->getDisplayName($gid));
+    }
 }

Spacing +58 added lines, -58 removed lines

@@ -64,7 +64,7 @@ 
 			->willReturn($groupDN);
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn) use ($groupDN) {
+			->willReturnCallback(function($dn) use ($groupDN) {
 				if ($dn === $groupDN) {
 					return [
 						'uid=u11,ou=users,dc=foo,dc=bar',
@@ -112,7 +112,7 @@ 
 	private function enableGroups(): void {
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapDynamicGroupMemberURL') {
 					return '';
 				} elseif ($name === 'ldapBaseGroups') {
@@ -133,7 +133,7 @@ 
 			->willReturn([]);
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				//the search operation will call readAttribute, thus we need
 				//to analyze the "dn". All other times we just need to return
 				//something that is neither null or false, but once an array
@@ -146,8 +146,8 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('dn2username')
-			->willReturnCallback(function () {
-				return 'foobar' . Server::get(ISecureRandom::class)->generate(7);
+			->willReturnCallback(function() {
+				return 'foobar'.Server::get(ISecureRandom::class)->generate(7);
 			});
 		$this->access->expects($this->any())
 			->method('isDNPartOfBase')
@@ -287,7 +287,7 @@ 
 		$connection = $this->access->connection;
 		$connection->expects($this->once())
 			->method('getFromCache')
-			->with('primaryGroupIDtoName_' . $gid)
+			->with('primaryGroupIDtoName_'.$gid)
 			->willReturn('MyGroup');
 
 		$this->access->expects($this->never())
@@ -446,7 +446,7 @@ 
 
 		$uid = 'someUser';
 		$gid = 'someGroup';
-		$cacheKey = 'inGroup' . $uid . ':' . $gid;
+		$cacheKey = 'inGroup'.$uid.':'.$gid;
 
 		$this->access->connection->expects($this->once())
 			->method('getFromCache')
@@ -482,7 +482,7 @@ 
 
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				switch ($name) {
 					case 'ldapGroupMemberAssocAttr':
 						return 'member';
@@ -521,7 +521,7 @@ 
 
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				switch ($name) {
 					case 'ldapGroupMemberAssocAttr':
 						return 'member';
@@ -567,7 +567,7 @@ 
 
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				switch ($name) {
 					case 'ldapGroupMemberAssocAttr':
 						return 'memberUid';
@@ -636,7 +636,7 @@ 
 			->willReturn(null);
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				if ($attr === 'primaryGroupToken') {
 					return [1337];
 				} elseif ($attr === 'gidNumber') {
@@ -679,7 +679,7 @@ 
 			->willReturn(null);
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				if ($attr === 'primaryGroupToken') {
 					return [1337];
 				}
@@ -721,7 +721,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				if ($attr === 'primaryGroupToken') {
 					return [1337];
 				}
@@ -785,7 +785,7 @@ 
 	public function testGetUserGroupsMemberOfDisabled(): void {
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'useMemberOfToDetectMembership') {
 					return 0;
 				} elseif ($name === 'ldapDynamicGroupMemberURL') {
@@ -945,14 +945,14 @@ 
 		$groupFilter = '(&(objectclass=nextcloudGroup)(nextcloudEnabled=TRUE))';
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function (string $name) use ($nestedGroups, $groupFilter) {
+			->willReturnCallback(function(string $name) use ($nestedGroups, $groupFilter) {
 				switch ($name) {
 					case 'useMemberOfToDetectMembership':
 						return 0;
 					case 'ldapDynamicGroupMemberURL':
 						return '';
 					case 'ldapNestedGroups':
-						return (int)$nestedGroups;
+						return (int) $nestedGroups;
 					case 'ldapGroupMemberAssocAttr':
 						return 'member';
 					case 'ldapGroupFilter':
@@ -978,7 +978,7 @@ 
 			->willReturn([]);
 		$this->access->expects($this->any())
 			->method('combineFilterWithAnd')
-			->willReturnCallback(function (array $filterParts) {
+			->willReturnCallback(function(array $filterParts) {
 				// ⚠ returns a pseudo-filter only, not real LDAP Filter syntax
 				return implode('&', $filterParts);
 			});
@@ -1008,7 +1008,7 @@ 
 			->willReturn($expectedGroupsNames);
 		$this->access->expects($nestedGroups ? $this->atLeastOnce() : $this->once())
 			->method('fetchListOfGroups')
-			->willReturnCallback(function ($filter, $attr, $limit, $offset) use ($nestedGroups, $groupFilter, $group1, $group2, $group3, $dn) {
+			->willReturnCallback(function($filter, $attr, $limit, $offset) use ($nestedGroups, $groupFilter, $group1, $group2, $group3, $dn) {
 				static $firstRun = true;
 				if (!$nestedGroups) {
 					// When nested groups are enabled, groups cannot be filtered early as it would
@@ -1016,10 +1016,10 @@ 
 					$this->assertTrue(str_contains($filter, $groupFilter));
 				}
 				[$memberFilter] = explode('&', $filter);
-				if ($memberFilter === 'member=' . $dn) {
+				if ($memberFilter === 'member='.$dn) {
 					return [$group1, $group2];
 					return [];
-				} elseif ($memberFilter === 'member=' . $group2['dn'][0]) {
+				} elseif ($memberFilter === 'member='.$group2['dn'][0]) {
 					return [$group3];
 				} else {
 					return [];
@@ -1027,12 +1027,12 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('dn2groupname')
-			->willReturnCallback(function (string $dn) {
+			->willReturnCallback(function(string $dn) {
 				return ldap_explode_dn($dn, 1)[0];
 			});
 		$this->access->expects($this->any())
 			->method('groupname2dn')
-			->willReturnCallback(function (string $gid) use ($group1, $group2, $group3) {
+			->willReturnCallback(function(string $gid) use ($group1, $group2, $group3) {
 				if ($gid === $group1['cn']) {
 					return $group1['dn'][0];
 				}
@@ -1248,11 +1248,11 @@ 
 		$base = 'dc=species,dc=earth';
 
 		$birdsDn = [
-			'uid=3723,' . $base,
-			'uid=8372,' . $base,
-			'uid=8427,' . $base,
-			'uid=2333,' . $base,
-			'uid=4754,' . $base,
+			'uid=3723,'.$base,
+			'uid=8372,'.$base,
+			'uid=8427,'.$base,
+			'uid=2333,'.$base,
+			'uid=4754,'.$base,
 		];
 		$birdsUid = [
 			'3723',
@@ -1262,51 +1262,51 @@ 
 			'4754',
 		];
 		$animalsDn = [
-			'uid=lion,' . $base,
-			'uid=tiger,' . $base,
+			'uid=lion,'.$base,
+			'uid=tiger,'.$base,
 		];
 		$plantsDn = [
-			'uid=flower,' . $base,
-			'uid=tree,' . $base,
+			'uid=flower,'.$base,
+			'uid=tree,'.$base,
 		];
 		$thingsDn = [
-			'uid=thing1,' . $base,
-			'uid=thing2,' . $base,
+			'uid=thing1,'.$base,
+			'uid=thing2,'.$base,
 		];
 
 		return [
-			[ #0 – test DNs
-				['cn=Birds,' . $base => $birdsDn],
-				['cn=Birds,' . $base => $birdsDn]
+			[#0 – test DNs
+				['cn=Birds,'.$base => $birdsDn],
+				['cn=Birds,'.$base => $birdsDn]
 			],
-			[ #1 – test uids
-				['cn=Birds,' . $base => $birdsUid],
-				['cn=Birds,' . $base => $birdsUid]
+			[#1 – test uids
+				['cn=Birds,'.$base => $birdsUid],
+				['cn=Birds,'.$base => $birdsUid]
 			],
-			[ #2 – test simple nested group
-				['cn=Animals,' . $base => array_merge($birdsDn, $animalsDn)],
+			[#2 – test simple nested group
+				['cn=Animals,'.$base => array_merge($birdsDn, $animalsDn)],
 				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
-					'cn=Birds,' . $base => $birdsDn,
+					'cn=Animals,'.$base => array_merge(['cn=Birds,'.$base], $animalsDn),
+					'cn=Birds,'.$base => $birdsDn,
 				]
 			],
-			[ #3 – test recursive nested group
+			[#3 – test recursive nested group
 				[
-					'cn=Animals,' . $base => array_merge($birdsDn, $animalsDn),
-					'cn=Birds,' . $base => array_merge($birdsDn, $animalsDn),
+					'cn=Animals,'.$base => array_merge($birdsDn, $animalsDn),
+					'cn=Birds,'.$base => array_merge($birdsDn, $animalsDn),
 				],
 				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base,'cn=Birds,' . $base,'cn=Animals,' . $base], $animalsDn),
-					'cn=Birds,' . $base => array_merge(['cn=Animals,' . $base,'cn=Birds,' . $base], $birdsDn),
+					'cn=Animals,'.$base => array_merge(['cn=Birds,'.$base, 'cn=Birds,'.$base, 'cn=Animals,'.$base], $animalsDn),
+					'cn=Birds,'.$base => array_merge(['cn=Animals,'.$base, 'cn=Birds,'.$base], $birdsDn),
 				]
 			],
-			[ #4 – Complicated nested group
-				['cn=Things,' . $base => array_merge($birdsDn, $animalsDn, $thingsDn, $plantsDn)],
+			[#4 – Complicated nested group
+				['cn=Things,'.$base => array_merge($birdsDn, $animalsDn, $thingsDn, $plantsDn)],
 				[
-					'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
-					'cn=Birds,' . $base => $birdsDn,
-					'cn=Plants,' . $base => $plantsDn,
-					'cn=Things,' . $base => array_merge(['cn=Animals,' . $base,'cn=Plants,' . $base], $thingsDn),
+					'cn=Animals,'.$base => array_merge(['cn=Birds,'.$base], $animalsDn),
+					'cn=Birds,'.$base => $birdsDn,
+					'cn=Plants,'.$base => $plantsDn,
+					'cn=Things,'.$base => array_merge(['cn=Animals,'.$base, 'cn=Plants,'.$base], $thingsDn),
 				]
 			],
 		];
@@ -1316,7 +1316,7 @@ 
 	public function testGroupMembers(array $expectedResult, array $groupsInfo): void {
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($group) use ($groupsInfo) {
+			->willReturnCallback(function($group) use ($groupsInfo) {
 				if (isset($groupsInfo[$group])) {
 					return $groupsInfo[$group];
 				}
@@ -1325,7 +1325,7 @@ 
 
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function (string $name) {
+			->willReturnCallback(function(string $name) {
 				if ($name === 'ldapNestedGroups') {
 					return 1;
 				} elseif ($name === 'ldapGroupMemberAssocAttr') {
@@ -1352,7 +1352,7 @@ 
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('displayNameProvider')]
-	public function testGetDisplayName(string $expected, bool|array $ldapResult): void {
+	public function testGetDisplayName(string $expected, bool | array $ldapResult): void {
 		$gid = 'graphic_novelists';
 
 		$this->access->expects($this->atLeastOnce())
@@ -1361,7 +1361,7 @@ 
 
 		$this->access->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapGroupMemberAssocAttr') {
 					return 'member';
 				} elseif ($name === 'ldapGroupFilter') {