Inspection of "Merge pull request #53728 from nextcloud/rector-ph..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d14f8...2337bd )

by Robin

created 2025-07-02 16:35 UTC

Status

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -553,7 +553,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->any())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'newUser.generateUserID') {
 					return 'yes';
 				}
@@ -591,8 +591,8 @@  discard block
 block discarded – undo
 		$this->secureRandom->expects($this->any())
 			->method('generate')
 			->with(10)
-			->willReturnCallback(function () {
-				return (string)rand(100000000, 999999999);
+			->willReturnCallback(function() {
+				return (string) rand(100000000, 999999999);
 			});
 
 		$this->assertTrue(key_exists(
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->any())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'newUser.generateUserID') {
 					return 'yes';
 				}
@@ -697,7 +697,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->any())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'newUser.requireEmail') {
 					return 'yes';
 				}
@@ -789,7 +789,7 @@  discard block
 block discarded – undo
 		$this->logger
 			->expects($this->exactly(2))
 			->method('info')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -993,7 +993,7 @@  discard block
 block discarded – undo
 		$this->logger
 			->expects($this->exactly(3))
 			->method('info')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -1989,7 +1989,7 @@  discard block
 block discarded – undo
 			->method('updateAccount')
 			->with($accountMock);
 
-		$this->assertEquals([], $this->api->editUser('UserToEdit', $propertyName . 'Scope', $newScope)->getData());
+		$this->assertEquals([], $this->api->editUser('UserToEdit', $propertyName.'Scope', $newScope)->getData());
 	}
 
 	public function testEditUserRegularUserSelfEditChangePassword(): void {
@@ -2077,7 +2077,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->once())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'max_quota') {
 					return '-1';
 				}
@@ -2165,7 +2165,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->once())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'max_quota') {
 					return '-1';
 				}
@@ -2418,7 +2418,7 @@  discard block
 block discarded – undo
 		$this->config
 			->expects($this->once())
 			->method('getAppValue')
-			->willReturnCallback(function ($appid, $key, $default) {
+			->willReturnCallback(function($appid, $key, $default) {
 				if ($key === 'max_quota') {
 					return '-1';
 				}
@@ -4357,7 +4357,7 @@  discard block
 block discarded – undo
 		$this->config->method('getSystemValue')->willReturnCallback(fn (string $key, mixed $default) => match ($key) {
 			'allow_user_to_change_display_name' => $allowedToChangeDisplayName,
 			'allow_user_to_change_email' => $allowedToChangeEmail,
-			default => throw new RuntimeException('Unexpected system config key: ' . $key),
+			default => throw new RuntimeException('Unexpected system config key: '.$key),
 		});
 
 		$user = $this->createMock(IUser::class);

Please login to merge, or discard this patch.

apps/encryption/tests/Crypto/EncryptAllTest.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -196,7 +196,7 @@  discard block
 block discarded – undo
 
 		$this->keyManager->expects($this->exactly(2))->method('userHasKeys')
 			->willReturnCallback(
-				function ($user) {
+				function($user) {
 					if ($user === 'user1') {
 						return false;
 					}
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
 		$encryptAllCalls = [];
 		$encryptAll->expects($this->exactly(2))
 			->method('encryptUsersFiles')
-			->willReturnCallback(function ($uid) use (&$encryptAllCalls): void {
+			->willReturnCallback(function($uid) use (&$encryptAllCalls): void {
 				$encryptAllCalls[] = $uid;
 			});
 
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
 
 		$this->view->expects($this->any())->method('is_dir')
 			->willReturnCallback(
-				function ($path) {
+				function($path) {
 					if ($path === '/user1/files/foo') {
 						return true;
 					}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
 		$encryptAllCalls = [];
 		$encryptAll->expects($this->exactly(2))
 			->method('encryptFile')
-			->willReturnCallback(function (string $path) use (&$encryptAllCalls): void {
+			->willReturnCallback(function(string $path) use (&$encryptAllCalls): void {
 				$encryptAllCalls[] = $path;
 			});
 

Please login to merge, or discard this patch.

apps/encryption/tests/Settings/AdminTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -53,7 +53,7 @@
 block discarded – undo
 	public function testGetForm(): void {
 		$this->config
 			->method('getAppValue')
-			->willReturnCallback(function ($app, $key, $default) {
+			->willReturnCallback(function($app, $key, $default) {
 				if ($app === 'encryption' && $key === 'recoveryAdminEnabled' && $default === '0') {
 					return '1';
 				}

Please login to merge, or discard this patch.

apps/encryption/tests/KeyManagerTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -116,7 +116,7 @@  discard block
 block discarded – undo
 	public function testRecoveryKeyExists(): void {
 		$this->keyStorageMock->expects($this->any())
 			->method('getSystemUserKey')
-			->with($this->equalTo($this->systemKeyId . '.publicKey'))
+			->with($this->equalTo($this->systemKeyId.'.publicKey'))
 			->willReturn('recoveryKey');
 
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
 	public function testCheckRecoveryKeyPassword(): void {
 		$this->keyStorageMock->expects($this->any())
 			->method('getSystemUserKey')
-			->with($this->equalTo($this->systemKeyId . '.privateKey'))
+			->with($this->equalTo($this->systemKeyId.'.privateKey'))
 			->willReturn('recoveryKey');
 		$this->cryptMock->expects($this->any())
 			->method('decryptPrivateKey')
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
 
 		$this->keyStorageMock->expects($this->exactly(2))
 			->method('getUserKey')
-			->willReturnCallback(function ($uid, $keyID, $encryptionModuleId) {
+			->willReturnCallback(function($uid, $keyID, $encryptionModuleId) {
 				if ($keyID === 'privateKey') {
 					return '';
 				}
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
 
 		$this->keyStorageMock->expects($this->exactly(2))
 			->method('getUserKey')
-			->willReturnCallback(function ($uid, $keyID, $encryptionModuleId) {
+			->willReturnCallback(function($uid, $keyID, $encryptionModuleId) {
 				if ($keyID === 'publicKey') {
 					return '';
 				}
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
 		$sessionSetStatusCalls = [];
 		$this->sessionMock->expects($this->exactly(2))
 			->method('setStatus')
-			->willReturnCallback(function (string $status) use (&$sessionSetStatusCalls): void {
+			->willReturnCallback(function(string $status) use (&$sessionSetStatusCalls): void {
 				$sessionSetStatusCalls[] = $status;
 			});
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
 			->method('getFileKey')
 			->willReturnMap([
 				[$path, 'fileKey', 'OC_DEFAULT_MODULE', $encryptedFileKey],
-				[$path, $expectedUid . '.shareKey', 'OC_DEFAULT_MODULE', 'fileKey'],
+				[$path, $expectedUid.'.shareKey', 'OC_DEFAULT_MODULE', 'fileKey'],
 			]);
 
 		$this->utilMock->expects($this->any())->method('isMasterKeyEnabled')
@@ -462,13 +462,13 @@  discard block
 block discarded – undo
 
 		$this->keyStorageMock->expects($this->any())
 			->method('getSystemUserKey')
-			->willReturnCallback(function ($keyId, $encryptionModuleId) {
+			->willReturnCallback(function($keyId, $encryptionModuleId) {
 				return $keyId;
 			});
 
 		$this->utilMock->expects($this->any())
 			->method('isRecoveryEnabledForUser')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				if ($uid === 'user1') {
 					return true;
 				}
@@ -495,9 +495,9 @@  discard block
 block discarded – undo
 	 */
 	public static function dataTestAddSystemKeys(): array {
 		return [
-			[['public' => true],[], 'user1', ['publicShareKey', 'recoveryKey']],
+			[['public' => true], [], 'user1', ['publicShareKey', 'recoveryKey']],
 			[['public' => false], [], 'user1', ['recoveryKey']],
-			[['public' => true],[], 'user2', ['publicShareKey']],
+			[['public' => true], [], 'user2', ['publicShareKey']],
 			[['public' => false], [], 'user2', []],
 		];
 	}

Please login to merge, or discard this patch.

apps/user_status/tests/Unit/Service/StatusServiceTest.php 1 patch

Spacing +65 added lines, -65 removed lines patch added patch discarded remove patch

@@ -286,59 +286,59 @@  discard block
 block discarded – undo
 
 	public static function setStatusDataProvider(): array {
 		return [
-			['john.doe', 'online', 50,   true,  true,  true, false, false, null, null],
-			['john.doe', 'online', 50,   true,  false, true, false, false, null, null],
-			['john.doe', 'online', 50,   false, true,  true, false, false, null, null],
-			['john.doe', 'online', 50,   false, false, true, false, false, null, null],
-			['john.doe', 'online', null, true,  true,  true, true,  false, null, null],
-			['john.doe', 'online', null, true,  false, true, true,  false, null, null],
-			['john.doe', 'online', null, false, true,  true, true,  false, null, null],
-			['john.doe', 'online', null, false, false, true, true,  false, null, null],
-
-			['john.doe', 'away', 50,   true,  true,  true, false, false, null, null],
-			['john.doe', 'away', 50,   true,  false, true, false, false, null, null],
-			['john.doe', 'away', 50,   false, true,  true, false, false, null, null],
-			['john.doe', 'away', 50,   false, false, true, false, false, null, null],
-			['john.doe', 'away', null, true,  true,  true, true,  false, null, null],
-			['john.doe', 'away', null, true,  false, true, true,  false, null, null],
-			['john.doe', 'away', null, false, true,  true, true,  false, null, null],
-			['john.doe', 'away', null, false, false, true, true,  false, null, null],
-
-			['john.doe', 'dnd', 50,   true,  true,  true, false, false, null, null],
-			['john.doe', 'dnd', 50,   true,  false, true, false, false, null, null],
-			['john.doe', 'dnd', 50,   false, true,  true, false, false, null, null],
-			['john.doe', 'dnd', 50,   false, false, true, false, false, null, null],
-			['john.doe', 'dnd', null, true,  true,  true, true,  false, null, null],
-			['john.doe', 'dnd', null, true,  false, true, true,  false, null, null],
-			['john.doe', 'dnd', null, false, true,  true, true,  false, null, null],
-			['john.doe', 'dnd', null, false, false, true, true,  false, null, null],
-
-			['john.doe', 'invisible', 50,   true,  true,  true, false, false, null, null],
-			['john.doe', 'invisible', 50,   true,  false, true, false, false, null, null],
-			['john.doe', 'invisible', 50,   false, true,  true, false, false, null, null],
-			['john.doe', 'invisible', 50,   false, false, true, false, false, null, null],
-			['john.doe', 'invisible', null, true,  true,  true, true,  false, null, null],
-			['john.doe', 'invisible', null, true,  false, true, true,  false, null, null],
-			['john.doe', 'invisible', null, false, true,  true, true,  false, null, null],
-			['john.doe', 'invisible', null, false, false, true, true,  false, null, null],
-
-			['john.doe', 'offline', 50,   true,  true,  true, false, false, null, null],
-			['john.doe', 'offline', 50,   true,  false, true, false, false, null, null],
-			['john.doe', 'offline', 50,   false, true,  true, false, false, null, null],
-			['john.doe', 'offline', 50,   false, false, true, false, false, null, null],
-			['john.doe', 'offline', null, true,  true,  true, true,  false, null, null],
-			['john.doe', 'offline', null, true,  false, true, true,  false, null, null],
-			['john.doe', 'offline', null, false, true,  true, true,  false, null, null],
-			['john.doe', 'offline', null, false, false, true, true,  false, null, null],
-
-			['john.doe', 'illegal-status', 50,   true,  true,  false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', 50,   true,  false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', 50,   false, true,  false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', 50,   false, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', null, true,  true,  false, true,  true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', null, true,  false, false, true,  true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', null, false, true,  false, true,  true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
-			['john.doe', 'illegal-status', null, false, false, false, true,  true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'online', 50, true, true, true, false, false, null, null],
+			['john.doe', 'online', 50, true, false, true, false, false, null, null],
+			['john.doe', 'online', 50, false, true, true, false, false, null, null],
+			['john.doe', 'online', 50, false, false, true, false, false, null, null],
+			['john.doe', 'online', null, true, true, true, true, false, null, null],
+			['john.doe', 'online', null, true, false, true, true, false, null, null],
+			['john.doe', 'online', null, false, true, true, true, false, null, null],
+			['john.doe', 'online', null, false, false, true, true, false, null, null],
+
+			['john.doe', 'away', 50, true, true, true, false, false, null, null],
+			['john.doe', 'away', 50, true, false, true, false, false, null, null],
+			['john.doe', 'away', 50, false, true, true, false, false, null, null],
+			['john.doe', 'away', 50, false, false, true, false, false, null, null],
+			['john.doe', 'away', null, true, true, true, true, false, null, null],
+			['john.doe', 'away', null, true, false, true, true, false, null, null],
+			['john.doe', 'away', null, false, true, true, true, false, null, null],
+			['john.doe', 'away', null, false, false, true, true, false, null, null],
+
+			['john.doe', 'dnd', 50, true, true, true, false, false, null, null],
+			['john.doe', 'dnd', 50, true, false, true, false, false, null, null],
+			['john.doe', 'dnd', 50, false, true, true, false, false, null, null],
+			['john.doe', 'dnd', 50, false, false, true, false, false, null, null],
+			['john.doe', 'dnd', null, true, true, true, true, false, null, null],
+			['john.doe', 'dnd', null, true, false, true, true, false, null, null],
+			['john.doe', 'dnd', null, false, true, true, true, false, null, null],
+			['john.doe', 'dnd', null, false, false, true, true, false, null, null],
+
+			['john.doe', 'invisible', 50, true, true, true, false, false, null, null],
+			['john.doe', 'invisible', 50, true, false, true, false, false, null, null],
+			['john.doe', 'invisible', 50, false, true, true, false, false, null, null],
+			['john.doe', 'invisible', 50, false, false, true, false, false, null, null],
+			['john.doe', 'invisible', null, true, true, true, true, false, null, null],
+			['john.doe', 'invisible', null, true, false, true, true, false, null, null],
+			['john.doe', 'invisible', null, false, true, true, true, false, null, null],
+			['john.doe', 'invisible', null, false, false, true, true, false, null, null],
+
+			['john.doe', 'offline', 50, true, true, true, false, false, null, null],
+			['john.doe', 'offline', 50, true, false, true, false, false, null, null],
+			['john.doe', 'offline', 50, false, true, true, false, false, null, null],
+			['john.doe', 'offline', 50, false, false, true, false, false, null, null],
+			['john.doe', 'offline', null, true, true, true, true, false, null, null],
+			['john.doe', 'offline', null, true, false, true, true, false, null, null],
+			['john.doe', 'offline', null, false, true, true, true, false, null, null],
+			['john.doe', 'offline', null, false, false, true, true, false, null, null],
+
+			['john.doe', 'illegal-status', 50, true, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', 50, true, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', 50, false, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', 50, false, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', null, true, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', null, true, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', null, false, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
+			['john.doe', 'illegal-status', null, false, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
 		];
 	}
 
@@ -418,12 +418,12 @@  discard block
 block discarded – undo
 
 	public static function setPredefinedMessageDataProvider(): array {
 		return [
-			['john.doe', 'sick-leave', true, null, true,  true,  false, null, null],
-			['john.doe', 'sick-leave', true, null, false, true,  false, null, null],
-			['john.doe', 'sick-leave', true, 20,   true,  false, true,  InvalidClearAtException::class, 'ClearAt is in the past'],
-			['john.doe', 'sick-leave', true, 20,   false, false, true,  InvalidClearAtException::class, 'ClearAt is in the past'],
-			['john.doe', 'sick-leave', true, 60,   true,  true,  false, null, null],
-			['john.doe', 'sick-leave', true, 60,   false, true,  false, null, null],
+			['john.doe', 'sick-leave', true, null, true, true, false, null, null],
+			['john.doe', 'sick-leave', true, null, false, true, false, null, null],
+			['john.doe', 'sick-leave', true, 20, true, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
+			['john.doe', 'sick-leave', true, 20, false, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
+			['john.doe', 'sick-leave', true, 60, true, true, false, null, null],
+			['john.doe', 'sick-leave', true, 60, false, true, false, null, null],
 			['john.doe', 'illegal-message-id', false, null, true, false, true, InvalidMessageIdException::class, 'Message-Id "illegal-message-id" is not supported'],
 			['john.doe', 'illegal-message-id', false, null, false, false, true, InvalidMessageIdException::class, 'Message-Id "illegal-message-id" is not supported'],
 		];
@@ -504,17 +504,17 @@  discard block
 block discarded – undo
 
 	public static function setCustomMessageDataProvider(): array {
 		return [
-			['john.doe', '

Please login to merge, or discard this patch.

apps/dav/tests/unit/Connector/Sabre/NodeTest.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -39,8 +39,8 @@  discard block
 block discarded – undo
 			[Constants::PERMISSION_ALL, 'dir', false, Constants::PERMISSION_ALL, false, 'test', 'RGDNVCK'],
 			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, false, 'test', 'SRGDNVW'],
 			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, 'test', 'SRMGDNVW'],
-			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, '' , 'SRMGDNVW'],
-			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, true, '' , 'SRMGDNV'],
+			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, '', 'SRMGDNVW'],
+			[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, true, '', 'SRMGDNV'],
 			[Constants::PERMISSION_ALL - Constants::PERMISSION_SHARE, 'file', true, Constants::PERMISSION_ALL, false, 'test', 'SGDNVW'],
 			[Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, 'file', false, Constants::PERMISSION_ALL, false, 'test', 'RGD'],
 			[Constants::PERMISSION_ALL - Constants::PERMISSION_DELETE, 'file', false, Constants::PERMISSION_ALL, false, 'test', 'RGNVW'],
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
 		$info->method('getInternalPath')
 			->willReturn($internalPath);
 		$info->method('getMountPoint')
-			->willReturnCallback(function () use ($shared) {
+			->willReturnCallback(function() use ($shared) {
 				if ($shared) {
 					return $this->createMock(SharedMount::class);
 				} else {
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('sanitizeMtimeProvider')]
-	public function testSanitizeMtime(string|int $mtime, int $expected): void {
+	public function testSanitizeMtime(string | int $mtime, int $expected): void {
 		$view = $this->getMockBuilder(View::class)
 			->disableOriginalConstructor()
 			->getMock();
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('invalidSanitizeMtimeProvider')]
-	public function testInvalidSanitizeMtime(int|string $mtime): void {
+	public function testInvalidSanitizeMtime(int | string $mtime): void {
 		$this->expectException(\InvalidArgumentException::class);
 
 		$view = $this->createMock(View::class);

Please login to merge, or discard this patch.

apps/dav/tests/unit/Connector/Sabre/TagsPluginTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -265,7 +265,7 @@  discard block
 block discarded – undo
 		];
 		$this->tagger->expects($this->exactly(count($calls)))
 			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
 		];
 		$this->tagger->expects($this->exactly(count($calls)))
 			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

Please login to merge, or discard this patch.

apps/dav/tests/unit/Connector/Sabre/FakeLockerPluginTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 		];
 		$server->expects($this->exactly(count($calls)))
 			->method('on')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 		];
 		$propFind->expects($this->exactly(count($calls)))
 			->method('handle')
-			->willReturnCallback(function ($propertyName) use (&$calls): void {
+			->willReturnCallback(function($propertyName) use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $propertyName);
 			});

Please login to merge, or discard this patch.

apps/dav/tests/unit/Connector/Sabre/FilesPluginTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -686,7 +686,7 @@
 block discarded – undo
 		$response
 			->expects($this->exactly(count($calls)))
 			->method('addHeader')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertSame($expected, func_get_args());
 			});

Please login to merge, or discard this patch.

		@@ -553,7 +553,7 @@ discard block
		block discarded – undo
553	553	$this->config
554	554	->expects($this->any())
555	555	->method('getAppValue')
556		- ->willReturnCallback(function ($appid, $key, $default) {
	556	+ ->willReturnCallback(function($appid, $key, $default) {
557	557	if ($key === 'newUser.generateUserID') {
558	558	return 'yes';
559	559	}
		@@ -591,8 +591,8 @@ discard block
		block discarded – undo
591	591	$this->secureRandom->expects($this->any())
592	592	->method('generate')
593	593	->with(10)
594		- ->willReturnCallback(function () {
595		- return (string)rand(100000000, 999999999);
	594	+ ->willReturnCallback(function() {
	595	+ return (string) rand(100000000, 999999999);
596	596	});
597	597
598	598	$this->assertTrue(key_exists(
		@@ -654,7 +654,7 @@ discard block
		block discarded – undo
654	654	$this->config
655	655	->expects($this->any())
656	656	->method('getAppValue')
657		- ->willReturnCallback(function ($appid, $key, $default) {
	657	+ ->willReturnCallback(function($appid, $key, $default) {
658	658	if ($key === 'newUser.generateUserID') {
659	659	return 'yes';
660	660	}
		@@ -697,7 +697,7 @@ discard block
		block discarded – undo
697	697	$this->config
698	698	->expects($this->any())
699	699	->method('getAppValue')
700		- ->willReturnCallback(function ($appid, $key, $default) {
	700	+ ->willReturnCallback(function($appid, $key, $default) {
701	701	if ($key === 'newUser.requireEmail') {
702	702	return 'yes';
703	703	}
		@@ -789,7 +789,7 @@ discard block
		block discarded – undo
789	789	$this->logger
790	790	->expects($this->exactly(2))
791	791	->method('info')
792		- ->willReturnCallback(function () use (&$calls): void {
	792	+ ->willReturnCallback(function() use (&$calls): void {
793	793	$expected = array_shift($calls);
794	794	$this->assertEquals($expected, func_get_args());
795	795	});
		@@ -993,7 +993,7 @@ discard block
		block discarded – undo
993	993	$this->logger
994	994	->expects($this->exactly(3))
995	995	->method('info')
996		- ->willReturnCallback(function () use (&$calls): void {
	996	+ ->willReturnCallback(function() use (&$calls): void {
997	997	$expected = array_shift($calls);
998	998	$this->assertEquals($expected, func_get_args());
999	999	});
		@@ -1989,7 +1989,7 @@ discard block
		block discarded – undo
1989	1989	->method('updateAccount')
1990	1990	->with($accountMock);
1991	1991
1992		- $this->assertEquals([], $this->api->editUser('UserToEdit', $propertyName . 'Scope', $newScope)->getData());
	1992	+ $this->assertEquals([], $this->api->editUser('UserToEdit', $propertyName.'Scope', $newScope)->getData());
1993	1993	}
1994	1994
1995	1995	public function testEditUserRegularUserSelfEditChangePassword(): void {
		@@ -2077,7 +2077,7 @@ discard block
		block discarded – undo
2077	2077	$this->config
2078	2078	->expects($this->once())
2079	2079	->method('getAppValue')
2080		- ->willReturnCallback(function ($appid, $key, $default) {
	2080	+ ->willReturnCallback(function($appid, $key, $default) {
2081	2081	if ($key === 'max_quota') {
2082	2082	return '-1';
2083	2083	}
		@@ -2165,7 +2165,7 @@ discard block
		block discarded – undo
2165	2165	$this->config
2166	2166	->expects($this->once())
2167	2167	->method('getAppValue')
2168		- ->willReturnCallback(function ($appid, $key, $default) {
	2168	+ ->willReturnCallback(function($appid, $key, $default) {
2169	2169	if ($key === 'max_quota') {
2170	2170	return '-1';
2171	2171	}
		@@ -2418,7 +2418,7 @@ discard block
		block discarded – undo
2418	2418	$this->config
2419	2419	->expects($this->once())
2420	2420	->method('getAppValue')
2421		- ->willReturnCallback(function ($appid, $key, $default) {
	2421	+ ->willReturnCallback(function($appid, $key, $default) {
2422	2422	if ($key === 'max_quota') {
2423	2423	return '-1';
2424	2424	}
		@@ -4357,7 +4357,7 @@ discard block
		block discarded – undo
4357	4357	$this->config->method('getSystemValue')->willReturnCallback(fn (string $key, mixed $default) => match ($key) {
4358	4358	'allow_user_to_change_display_name' => $allowedToChangeDisplayName,
4359	4359	'allow_user_to_change_email' => $allowedToChangeEmail,
4360		- default => throw new RuntimeException('Unexpected system config key: ' . $key),
	4360	+ default => throw new RuntimeException('Unexpected system config key: '.$key),
4361	4361	});
4362	4362
4363	4363	$user = $this->createMock(IUser::class);

		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	public function testRecoveryKeyExists(): void {
117	117	$this->keyStorageMock->expects($this->any())
118	118	->method('getSystemUserKey')
119		- ->with($this->equalTo($this->systemKeyId . '.publicKey'))
	119	+ ->with($this->equalTo($this->systemKeyId.'.publicKey'))
120	120	->willReturn('recoveryKey');
121	121
122	122
		@@ -126,7 +126,7 @@ discard block
		block discarded – undo
126	126	public function testCheckRecoveryKeyPassword(): void {
127	127	$this->keyStorageMock->expects($this->any())
128	128	->method('getSystemUserKey')
129		- ->with($this->equalTo($this->systemKeyId . '.privateKey'))
	129	+ ->with($this->equalTo($this->systemKeyId.'.privateKey'))
130	130	->willReturn('recoveryKey');
131	131	$this->cryptMock->expects($this->any())
132	132	->method('decryptPrivateKey')
		@@ -192,7 +192,7 @@ discard block
		block discarded – undo
192	192
193	193	$this->keyStorageMock->expects($this->exactly(2))
194	194	->method('getUserKey')
195		- ->willReturnCallback(function ($uid, $keyID, $encryptionModuleId) {
	195	+ ->willReturnCallback(function($uid, $keyID, $encryptionModuleId) {
196	196	if ($keyID === 'privateKey') {
197	197	return '';
198	198	}
		@@ -208,7 +208,7 @@ discard block
		block discarded – undo
208	208
209	209	$this->keyStorageMock->expects($this->exactly(2))
210	210	->method('getUserKey')
211		- ->willReturnCallback(function ($uid, $keyID, $encryptionModuleId) {
	211	+ ->willReturnCallback(function($uid, $keyID, $encryptionModuleId) {
212	212	if ($keyID === 'publicKey') {
213	213	return '';
214	214	}
		@@ -245,7 +245,7 @@ discard block
		block discarded – undo
245	245	$sessionSetStatusCalls = [];
246	246	$this->sessionMock->expects($this->exactly(2))
247	247	->method('setStatus')
248		- ->willReturnCallback(function (string $status) use (&$sessionSetStatusCalls): void {
	248	+ ->willReturnCallback(function(string $status) use (&$sessionSetStatusCalls): void {
249	249	$sessionSetStatusCalls[] = $status;
250	250	});
251	251
		@@ -379,7 +379,7 @@ discard block
		block discarded – undo
379	379	->method('getFileKey')
380	380	->willReturnMap([
381	381	[$path, 'fileKey', 'OC_DEFAULT_MODULE', $encryptedFileKey],
382		- [$path, $expectedUid . '.shareKey', 'OC_DEFAULT_MODULE', 'fileKey'],
	382	+ [$path, $expectedUid.'.shareKey', 'OC_DEFAULT_MODULE', 'fileKey'],
383	383	]);
384	384
385	385	$this->utilMock->expects($this->any())->method('isMasterKeyEnabled')
		@@ -462,13 +462,13 @@ discard block
		block discarded – undo
462	462
463	463	$this->keyStorageMock->expects($this->any())
464	464	->method('getSystemUserKey')
465		- ->willReturnCallback(function ($keyId, $encryptionModuleId) {
	465	+ ->willReturnCallback(function($keyId, $encryptionModuleId) {
466	466	return $keyId;
467	467	});
468	468
469	469	$this->utilMock->expects($this->any())
470	470	->method('isRecoveryEnabledForUser')
471		- ->willReturnCallback(function ($uid) {
	471	+ ->willReturnCallback(function($uid) {
472	472	if ($uid === 'user1') {
473	473	return true;
474	474	}
		@@ -495,9 +495,9 @@ discard block
		block discarded – undo
495	495	*/
496	496	public static function dataTestAddSystemKeys(): array {
497	497	return [
498		- [['public' => true],[], 'user1', ['publicShareKey', 'recoveryKey']],
	498	+ [['public' => true], [], 'user1', ['publicShareKey', 'recoveryKey']],
499	499	[['public' => false], [], 'user1', ['recoveryKey']],
500		- [['public' => true],[], 'user2', ['publicShareKey']],
	500	+ [['public' => true], [], 'user2', ['publicShareKey']],
501	501	[['public' => false], [], 'user2', []],
502	502	];
503	503	}

		@@ -196,7 +196,7 @@ discard block
		block discarded – undo
196	196
197	197	$this->keyManager->expects($this->exactly(2))->method('userHasKeys')
198	198	->willReturnCallback(
199		- function ($user) {
	199	+ function($user) {
200	200	if ($user === 'user1') {
201	201	return false;
202	202	}
		@@ -249,7 +249,7 @@ discard block
		block discarded – undo
249	249	$encryptAllCalls = [];
250	250	$encryptAll->expects($this->exactly(2))
251	251	->method('encryptUsersFiles')
252		- ->willReturnCallback(function ($uid) use (&$encryptAllCalls): void {
	252	+ ->willReturnCallback(function($uid) use (&$encryptAllCalls): void {
253	253	$encryptAllCalls[] = $uid;
254	254	});
255	255
		@@ -306,7 +306,7 @@ discard block
		block discarded – undo
306	306
307	307	$this->view->expects($this->any())->method('is_dir')
308	308	->willReturnCallback(
309		- function ($path) {
	309	+ function($path) {
310	310	if ($path === '/user1/files/foo') {
311	311	return true;
312	312	}
		@@ -317,7 +317,7 @@ discard block
		block discarded – undo
317	317	$encryptAllCalls = [];
318	318	$encryptAll->expects($this->exactly(2))
319	319	->method('encryptFile')
320		- ->willReturnCallback(function (string $path) use (&$encryptAllCalls): void {
	320	+ ->willReturnCallback(function(string $path) use (&$encryptAllCalls): void {
321	321	$encryptAllCalls[] = $path;
322	322	});
323	323

		@@ -53,7 +53,7 @@
		block discarded – undo
53	53	public function testGetForm(): void {
54	54	$this->config
55	55	->method('getAppValue')
56		- ->willReturnCallback(function ($app, $key, $default) {
	56	+ ->willReturnCallback(function($app, $key, $default) {
57	57	if ($app === 'encryption' && $key === 'recoveryAdminEnabled' && $default === '0') {
58	58	return '1';
59	59	}

		@@ -286,59 +286,59 @@ discard block
		block discarded – undo
286	286
287	287	public static function setStatusDataProvider(): array {
288	288	return [
289		- ['john.doe', 'online', 50, true, true, true, false, false, null, null],
290		- ['john.doe', 'online', 50, true, false, true, false, false, null, null],
291		- ['john.doe', 'online', 50, false, true, true, false, false, null, null],
292		- ['john.doe', 'online', 50, false, false, true, false, false, null, null],
293		- ['john.doe', 'online', null, true, true, true, true, false, null, null],
294		- ['john.doe', 'online', null, true, false, true, true, false, null, null],
295		- ['john.doe', 'online', null, false, true, true, true, false, null, null],
296		- ['john.doe', 'online', null, false, false, true, true, false, null, null],
297		-
298		- ['john.doe', 'away', 50, true, true, true, false, false, null, null],
299		- ['john.doe', 'away', 50, true, false, true, false, false, null, null],
300		- ['john.doe', 'away', 50, false, true, true, false, false, null, null],
301		- ['john.doe', 'away', 50, false, false, true, false, false, null, null],
302		- ['john.doe', 'away', null, true, true, true, true, false, null, null],
303		- ['john.doe', 'away', null, true, false, true, true, false, null, null],
304		- ['john.doe', 'away', null, false, true, true, true, false, null, null],
305		- ['john.doe', 'away', null, false, false, true, true, false, null, null],
306		-
307		- ['john.doe', 'dnd', 50, true, true, true, false, false, null, null],
308		- ['john.doe', 'dnd', 50, true, false, true, false, false, null, null],
309		- ['john.doe', 'dnd', 50, false, true, true, false, false, null, null],
310		- ['john.doe', 'dnd', 50, false, false, true, false, false, null, null],
311		- ['john.doe', 'dnd', null, true, true, true, true, false, null, null],
312		- ['john.doe', 'dnd', null, true, false, true, true, false, null, null],
313		- ['john.doe', 'dnd', null, false, true, true, true, false, null, null],
314		- ['john.doe', 'dnd', null, false, false, true, true, false, null, null],
315		-
316		- ['john.doe', 'invisible', 50, true, true, true, false, false, null, null],
317		- ['john.doe', 'invisible', 50, true, false, true, false, false, null, null],
318		- ['john.doe', 'invisible', 50, false, true, true, false, false, null, null],
319		- ['john.doe', 'invisible', 50, false, false, true, false, false, null, null],
320		- ['john.doe', 'invisible', null, true, true, true, true, false, null, null],
321		- ['john.doe', 'invisible', null, true, false, true, true, false, null, null],
322		- ['john.doe', 'invisible', null, false, true, true, true, false, null, null],
323		- ['john.doe', 'invisible', null, false, false, true, true, false, null, null],
324		-
325		- ['john.doe', 'offline', 50, true, true, true, false, false, null, null],
326		- ['john.doe', 'offline', 50, true, false, true, false, false, null, null],
327		- ['john.doe', 'offline', 50, false, true, true, false, false, null, null],
328		- ['john.doe', 'offline', 50, false, false, true, false, false, null, null],
329		- ['john.doe', 'offline', null, true, true, true, true, false, null, null],
330		- ['john.doe', 'offline', null, true, false, true, true, false, null, null],
331		- ['john.doe', 'offline', null, false, true, true, true, false, null, null],
332		- ['john.doe', 'offline', null, false, false, true, true, false, null, null],
333		-
334		- ['john.doe', 'illegal-status', 50, true, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
335		- ['john.doe', 'illegal-status', 50, true, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
336		- ['john.doe', 'illegal-status', 50, false, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
337		- ['john.doe', 'illegal-status', 50, false, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
338		- ['john.doe', 'illegal-status', null, true, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
339		- ['john.doe', 'illegal-status', null, true, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
340		- ['john.doe', 'illegal-status', null, false, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
341		- ['john.doe', 'illegal-status', null, false, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	289	+ ['john.doe', 'online', 50, true, true, true, false, false, null, null],
	290	+ ['john.doe', 'online', 50, true, false, true, false, false, null, null],
	291	+ ['john.doe', 'online', 50, false, true, true, false, false, null, null],
	292	+ ['john.doe', 'online', 50, false, false, true, false, false, null, null],
	293	+ ['john.doe', 'online', null, true, true, true, true, false, null, null],
	294	+ ['john.doe', 'online', null, true, false, true, true, false, null, null],
	295	+ ['john.doe', 'online', null, false, true, true, true, false, null, null],
	296	+ ['john.doe', 'online', null, false, false, true, true, false, null, null],
	297	+
	298	+ ['john.doe', 'away', 50, true, true, true, false, false, null, null],
	299	+ ['john.doe', 'away', 50, true, false, true, false, false, null, null],
	300	+ ['john.doe', 'away', 50, false, true, true, false, false, null, null],
	301	+ ['john.doe', 'away', 50, false, false, true, false, false, null, null],
	302	+ ['john.doe', 'away', null, true, true, true, true, false, null, null],
	303	+ ['john.doe', 'away', null, true, false, true, true, false, null, null],
	304	+ ['john.doe', 'away', null, false, true, true, true, false, null, null],
	305	+ ['john.doe', 'away', null, false, false, true, true, false, null, null],
	306	+
	307	+ ['john.doe', 'dnd', 50, true, true, true, false, false, null, null],
	308	+ ['john.doe', 'dnd', 50, true, false, true, false, false, null, null],
	309	+ ['john.doe', 'dnd', 50, false, true, true, false, false, null, null],
	310	+ ['john.doe', 'dnd', 50, false, false, true, false, false, null, null],
	311	+ ['john.doe', 'dnd', null, true, true, true, true, false, null, null],
	312	+ ['john.doe', 'dnd', null, true, false, true, true, false, null, null],
	313	+ ['john.doe', 'dnd', null, false, true, true, true, false, null, null],
	314	+ ['john.doe', 'dnd', null, false, false, true, true, false, null, null],
	315	+
	316	+ ['john.doe', 'invisible', 50, true, true, true, false, false, null, null],
	317	+ ['john.doe', 'invisible', 50, true, false, true, false, false, null, null],
	318	+ ['john.doe', 'invisible', 50, false, true, true, false, false, null, null],
	319	+ ['john.doe', 'invisible', 50, false, false, true, false, false, null, null],
	320	+ ['john.doe', 'invisible', null, true, true, true, true, false, null, null],
	321	+ ['john.doe', 'invisible', null, true, false, true, true, false, null, null],
	322	+ ['john.doe', 'invisible', null, false, true, true, true, false, null, null],
	323	+ ['john.doe', 'invisible', null, false, false, true, true, false, null, null],
	324	+
	325	+ ['john.doe', 'offline', 50, true, true, true, false, false, null, null],
	326	+ ['john.doe', 'offline', 50, true, false, true, false, false, null, null],
	327	+ ['john.doe', 'offline', 50, false, true, true, false, false, null, null],
	328	+ ['john.doe', 'offline', 50, false, false, true, false, false, null, null],
	329	+ ['john.doe', 'offline', null, true, true, true, true, false, null, null],
	330	+ ['john.doe', 'offline', null, true, false, true, true, false, null, null],
	331	+ ['john.doe', 'offline', null, false, true, true, true, false, null, null],
	332	+ ['john.doe', 'offline', null, false, false, true, true, false, null, null],
	333	+
	334	+ ['john.doe', 'illegal-status', 50, true, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	335	+ ['john.doe', 'illegal-status', 50, true, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	336	+ ['john.doe', 'illegal-status', 50, false, true, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	337	+ ['john.doe', 'illegal-status', 50, false, false, false, false, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	338	+ ['john.doe', 'illegal-status', null, true, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	339	+ ['john.doe', 'illegal-status', null, true, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	340	+ ['john.doe', 'illegal-status', null, false, true, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
	341	+ ['john.doe', 'illegal-status', null, false, false, false, true, true, InvalidStatusTypeException::class, 'Status-type "illegal-status" is not supported'],
342	342	];
343	343	}
344	344
		@@ -418,12 +418,12 @@ discard block
		block discarded – undo
418	418
419	419	public static function setPredefinedMessageDataProvider(): array {
420	420	return [
421		- ['john.doe', 'sick-leave', true, null, true, true, false, null, null],
422		- ['john.doe', 'sick-leave', true, null, false, true, false, null, null],
423		- ['john.doe', 'sick-leave', true, 20, true, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
424		- ['john.doe', 'sick-leave', true, 20, false, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
425		- ['john.doe', 'sick-leave', true, 60, true, true, false, null, null],
426		- ['john.doe', 'sick-leave', true, 60, false, true, false, null, null],
	421	+ ['john.doe', 'sick-leave', true, null, true, true, false, null, null],
	422	+ ['john.doe', 'sick-leave', true, null, false, true, false, null, null],
	423	+ ['john.doe', 'sick-leave', true, 20, true, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
	424	+ ['john.doe', 'sick-leave', true, 20, false, false, true, InvalidClearAtException::class, 'ClearAt is in the past'],
	425	+ ['john.doe', 'sick-leave', true, 60, true, true, false, null, null],
	426	+ ['john.doe', 'sick-leave', true, 60, false, true, false, null, null],
427	427	['john.doe', 'illegal-message-id', false, null, true, false, true, InvalidMessageIdException::class, 'Message-Id "illegal-message-id" is not supported'],
428	428	['john.doe', 'illegal-message-id', false, null, false, false, true, InvalidMessageIdException::class, 'Message-Id "illegal-message-id" is not supported'],
429	429	];
		@@ -504,17 +504,17 @@ discard block
		block discarded – undo
504	504
505	505	public static function setCustomMessageDataProvider(): array {
506	506	return [
507		- ['john.doe', '

		@@ -39,8 +39,8 @@ discard block
		block discarded – undo
39	39	[Constants::PERMISSION_ALL, 'dir', false, Constants::PERMISSION_ALL, false, 'test', 'RGDNVCK'],
40	40	[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, false, 'test', 'SRGDNVW'],
41	41	[Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, 'test', 'SRMGDNVW'],
42		- [Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, '' , 'SRMGDNVW'],
43		- [Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, true, '' , 'SRMGDNV'],
	42	+ [Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL, true, '', 'SRMGDNVW'],
	43	+ [Constants::PERMISSION_ALL, 'file', true, Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, true, '', 'SRMGDNV'],
44	44	[Constants::PERMISSION_ALL - Constants::PERMISSION_SHARE, 'file', true, Constants::PERMISSION_ALL, false, 'test', 'SGDNVW'],
45	45	[Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE, 'file', false, Constants::PERMISSION_ALL, false, 'test', 'RGD'],
46	46	[Constants::PERMISSION_ALL - Constants::PERMISSION_DELETE, 'file', false, Constants::PERMISSION_ALL, false, 'test', 'RGNVW'],
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	$info->method('getInternalPath')
69	69	->willReturn($internalPath);
70	70	$info->method('getMountPoint')
71		- ->willReturnCallback(function () use ($shared) {
	71	+ ->willReturnCallback(function() use ($shared) {
72	72	if ($shared) {
73	73	return $this->createMock(SharedMount::class);
74	74	} else {
		@@ -239,7 +239,7 @@ discard block
		block discarded – undo
239	239	}
240	240
241	241	#[\PHPUnit\Framework\Attributes\DataProvider('sanitizeMtimeProvider')]
242		- public function testSanitizeMtime(string\|int $mtime, int $expected): void {
	242	+ public function testSanitizeMtime(string \| int $mtime, int $expected): void {
243	243	$view = $this->getMockBuilder(View::class)
244	244	->disableOriginalConstructor()
245	245	->getMock();
		@@ -259,7 +259,7 @@ discard block
		block discarded – undo
259	259	}
260	260
261	261	#[\PHPUnit\Framework\Attributes\DataProvider('invalidSanitizeMtimeProvider')]
262		- public function testInvalidSanitizeMtime(int\|string $mtime): void {
	262	+ public function testInvalidSanitizeMtime(int \| string $mtime): void {
263	263	$this->expectException(\InvalidArgumentException::class);
264	264
265	265	$view = $this->createMock(View::class);

		@@ -265,7 +265,7 @@ discard block
		block discarded – undo
265	265	];
266	266	$this->tagger->expects($this->exactly(count($calls)))
267	267	->method('tagAs')
268		- ->willReturnCallback(function () use (&$calls): void {
	268	+ ->willReturnCallback(function() use (&$calls): void {
269	269	$expected = array_shift($calls);
270	270	$this->assertEquals($expected, func_get_args());
271	271	});
		@@ -318,7 +318,7 @@ discard block
		block discarded – undo
318	318	];
319	319	$this->tagger->expects($this->exactly(count($calls)))
320	320	->method('tagAs')
321		- ->willReturnCallback(function () use (&$calls): void {
	321	+ ->willReturnCallback(function() use (&$calls): void {
322	322	$expected = array_shift($calls);
323	323	$this->assertEquals($expected, func_get_args());
324	324	});

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	];
42	42	$server->expects($this->exactly(count($calls)))
43	43	->method('on')
44		- ->willReturnCallback(function () use (&$calls): void {
	44	+ ->willReturnCallback(function() use (&$calls): void {
45	45	$expected = array_shift($calls);
46	46	$this->assertEquals($expected, func_get_args());
47	47	});
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	];
75	75	$propFind->expects($this->exactly(count($calls)))
76	76	->method('handle')
77		- ->willReturnCallback(function ($propertyName) use (&$calls): void {
	77	+ ->willReturnCallback(function($propertyName) use (&$calls): void {
78	78	$expected = array_shift($calls);
79	79	$this->assertEquals($expected, $propertyName);
80	80	});

		@@ -686,7 +686,7 @@
		block discarded – undo
686	686	$response
687	687	->expects($this->exactly(count($calls)))
688	688	->method('addHeader')
689		- ->willReturnCallback(function () use (&$calls): void {
	689	+ ->willReturnCallback(function() use (&$calls): void {
690	690	$expected = array_shift($calls);
691	691	$this->assertSame($expected, func_get_args());
692	692	});

nextcloud / server

Push — master ( 5d14f8...2337bd )

Status

Category

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +65 added lines, -65 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch