nextcloud / server

apps/dav/tests/unit/CalDAV/Reminder/NotifierTest.php

Indentation +239 added lines, -239 removed lines

@@ -21,243 +21,243 @@
 use Test\TestCase;
 
 class NotifierTest extends TestCase {
-	protected IFactory&MockObject $factory;
-	protected IURLGenerator&MockObject $urlGenerator;
-	protected IL10N&MockObject $l10n;
-	protected ITimeFactory&MockObject $timeFactory;
-	protected Notifier $notifier;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->l10n->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				if (!is_array($args)) {
-					$args = [$args];
-				}
-				return vsprintf($string, $args);
-			});
-		$this->l10n->expects($this->any())
-			->method('l')
-			->willReturnCallback(function ($string, $args) {
-				/** \DateTime $args */
-				return $args->format(\DateTime::ATOM);
-			});
-		$this->l10n->expects($this->any())
-			->method('n')
-			->willReturnCallback(function ($textSingular, $textPlural, $count, $args) {
-				$text = $count === 1 ? $textSingular : $textPlural;
-				$text = str_replace('%n', (string)$count, $text);
-				return vsprintf($text, $args);
-			});
-		$this->factory = $this->createMock(IFactory::class);
-		$this->factory->expects($this->any())
-			->method('get')
-			->willReturn($this->l10n);
-
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->timeFactory
-			->method('getDateTime')
-			->willReturn(\DateTime::createFromFormat(\DateTime::ATOM, '2005-08-15T14:00:00+02:00'));
-
-		$this->notifier = new Notifier(
-			$this->factory,
-			$this->urlGenerator,
-			$this->timeFactory
-		);
-	}
-
-	public function testGetId():void {
-		$this->assertEquals($this->notifier->getID(), 'dav');
-	}
-
-	public function testGetName():void {
-		$this->assertEquals($this->notifier->getName(), 'Calendar');
-	}
-
-
-	public function testPrepareWrongApp(): void {
-		$this->expectException(UnknownNotificationException::class);
-		$this->expectExceptionMessage('Notification not from this app');
-
-		/** @var INotification&MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn('notifications');
-		$notification->expects($this->never())
-			->method('getSubject');
-
-		$this->notifier->prepare($notification, 'en');
-	}
-
-
-	public function testPrepareWrongSubject(): void {
-		$this->expectException(UnknownNotificationException::class);
-		$this->expectExceptionMessage('Unknown subject');
-
-		/** @var INotification&MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn(Application::APP_ID);
-		$notification->expects($this->once())
-			->method('getSubject')
-			->willReturn('wrong subject');
-
-		$this->notifier->prepare($notification, 'en');
-	}
-
-	private static function hasPhpDatetimeDiffBug(): bool {
-		$d1 = \DateTime::createFromFormat(\DateTimeInterface::ATOM, '2023-11-22T11:52:00+01:00');
-		$d2 = new \DateTime('2023-11-22T10:52:03', new \DateTimeZone('UTC'));
-
-		// The difference is 3 seconds, not -1year+11months+…
-		return $d1->diff($d2)->y < 0;
-	}
-
-	public static function dataPrepare(): array {
-		return [
-			[
-				'calendar_reminder',
-				[
-					'title' => 'Title of this event',
-					'start_atom' => '2005-08-15T15:52:01+02:00'
-				],
-				self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (in 1 hour, 52 minutes)',
-				[
-					'title' => 'Title of this event',
-					'description' => null,
-					'location' => 'NC Headquarters',
-					'all_day' => false,
-					'start_atom' => '2005-08-15T15:52:01+02:00',
-					'start_is_floating' => false,
-					'start_timezone' => 'Europe/Berlin',
-					'end_atom' => '2005-08-15T17:52:01+02:00',
-					'end_is_floating' => false,
-					'end_timezone' => 'Europe/Berlin',
-					'calendar_displayname' => 'Personal',
-				],
-				"Calendar: Personal\r\nDate: 2005-08-15T15:52:01+02:00, 2005-08-15T15:52:01+02:00 - 2005-08-15T17:52:01+02:00 (Europe/Berlin)\r\nWhere: NC Headquarters"
-			],
-			[
-				'calendar_reminder',
-				[
-					'title' => 'Title of this event',
-					'start_atom' => '2005-08-15T13:00:00+02:00',
-				],
-				self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (1 hour ago)',
-				[
-					'title' => 'Title of this event',
-					'description' => null,
-					'location' => 'NC Headquarters',
-					'all_day' => false,
-					'start_atom' => '2005-08-15T13:00:00+02:00',
-					'start_is_floating' => false,
-					'start_timezone' => 'Europe/Berlin',
-					'end_atom' => '2005-08-15T15:00:00+02:00',
-					'end_is_floating' => false,
-					'end_timezone' => 'Europe/Berlin',
-					'calendar_displayname' => 'Personal',
-				],
-				"Calendar: Personal\r\nDate: 2005-08-15T13:00:00+02:00, 2005-08-15T13:00:00+02:00 - 2005-08-15T15:00:00+02:00 (Europe/Berlin)\r\nWhere: NC Headquarters"
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataPrepare')]
-	public function testPrepare(string $subjectType, array $subjectParams, string $subject, array $messageParams, string $message): void {
-		/** @var INotification&MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn(Application::APP_ID);
-		$notification->expects($this->once())
-			->method('getSubject')
-			->willReturn($subjectType);
-		$notification->expects($this->once())
-			->method('getSubjectParameters')
-			->willReturn($subjectParams);
-		$notification->expects($this->once())
-			->method('getMessageParameters')
-			->willReturn($messageParams);
-
-		$notification->expects($this->once())
-			->method('setParsedSubject')
-			->with($subject)
-			->willReturnSelf();
-
-		$notification->expects($this->once())
-			->method('setParsedMessage')
-			->with($message)
-			->willReturnSelf();
-
-		$this->urlGenerator->expects($this->once())
-			->method('imagePath')
-			->with('core', 'places/calendar.svg')
-			->willReturn('icon-url');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('icon-url')
-			->willReturn('absolute-icon-url');
-		$notification->expects($this->once())
-			->method('setIcon')
-			->with('absolute-icon-url')
-			->willReturnSelf();
-
-		$return = $this->notifier->prepare($notification, 'en');
-
-		$this->assertEquals($notification, $return);
-	}
-
-	public function testPassedEvent(): void {
-		/** @var INotification&MockObject $notification */
-		$notification = $this->createMock(INotification::class);
-
-		$notification->expects($this->once())
-			->method('getApp')
-			->willReturn(Application::APP_ID);
-		$notification->expects($this->once())
-			->method('getSubject')
-			->willReturn('calendar_reminder');
-		$notification->expects($this->once())
-			->method('getSubjectParameters')
-			->willReturn([
-				'title' => 'Title of this event',
-				'start_atom' => '2005-08-15T08:00:00+02:00'
-			]);
-
-		$notification->expects($this->once())
-			->method('getMessageParameters')
-			->willReturn([
-				'title' => 'Title of this event',
-				'description' => null,
-				'location' => 'NC Headquarters',
-				'all_day' => false,
-				'start_atom' => '2005-08-15T08:00:00+02:00',
-				'start_is_floating' => false,
-				'start_timezone' => 'Europe/Berlin',
-				'end_atom' => '2005-08-15T13:00:00+02:00',
-				'end_is_floating' => false,
-				'end_timezone' => 'Europe/Berlin',
-				'calendar_displayname' => 'Personal',
-			]);
-
-		$notification->expects($this->once())
-			->method('setParsedSubject')
-			->with(self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (6 hours ago)')
-			->willReturnSelf();
-
-		$this->expectException(AlreadyProcessedException::class);
-
-		$return = $this->notifier->prepare($notification, 'en');
-
-		$this->assertEquals($notification, $return);
-	}
+    protected IFactory&MockObject $factory;
+    protected IURLGenerator&MockObject $urlGenerator;
+    protected IL10N&MockObject $l10n;
+    protected ITimeFactory&MockObject $timeFactory;
+    protected Notifier $notifier;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->l10n->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                if (!is_array($args)) {
+                    $args = [$args];
+                }
+                return vsprintf($string, $args);
+            });
+        $this->l10n->expects($this->any())
+            ->method('l')
+            ->willReturnCallback(function ($string, $args) {
+                /** \DateTime $args */
+                return $args->format(\DateTime::ATOM);
+            });
+        $this->l10n->expects($this->any())
+            ->method('n')
+            ->willReturnCallback(function ($textSingular, $textPlural, $count, $args) {
+                $text = $count === 1 ? $textSingular : $textPlural;
+                $text = str_replace('%n', (string)$count, $text);
+                return vsprintf($text, $args);
+            });
+        $this->factory = $this->createMock(IFactory::class);
+        $this->factory->expects($this->any())
+            ->method('get')
+            ->willReturn($this->l10n);
+
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->timeFactory
+            ->method('getDateTime')
+            ->willReturn(\DateTime::createFromFormat(\DateTime::ATOM, '2005-08-15T14:00:00+02:00'));
+
+        $this->notifier = new Notifier(
+            $this->factory,
+            $this->urlGenerator,
+            $this->timeFactory
+        );
+    }
+
+    public function testGetId():void {
+        $this->assertEquals($this->notifier->getID(), 'dav');
+    }
+
+    public function testGetName():void {
+        $this->assertEquals($this->notifier->getName(), 'Calendar');
+    }
+
+
+    public function testPrepareWrongApp(): void {
+        $this->expectException(UnknownNotificationException::class);
+        $this->expectExceptionMessage('Notification not from this app');
+
+        /** @var INotification&MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn('notifications');
+        $notification->expects($this->never())
+            ->method('getSubject');
+
+        $this->notifier->prepare($notification, 'en');
+    }
+
+
+    public function testPrepareWrongSubject(): void {
+        $this->expectException(UnknownNotificationException::class);
+        $this->expectExceptionMessage('Unknown subject');
+
+        /** @var INotification&MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn(Application::APP_ID);
+        $notification->expects($this->once())
+            ->method('getSubject')
+            ->willReturn('wrong subject');
+
+        $this->notifier->prepare($notification, 'en');
+    }
+
+    private static function hasPhpDatetimeDiffBug(): bool {
+        $d1 = \DateTime::createFromFormat(\DateTimeInterface::ATOM, '2023-11-22T11:52:00+01:00');
+        $d2 = new \DateTime('2023-11-22T10:52:03', new \DateTimeZone('UTC'));
+
+        // The difference is 3 seconds, not -1year+11months+…
+        return $d1->diff($d2)->y < 0;
+    }
+
+    public static function dataPrepare(): array {
+        return [
+            [
+                'calendar_reminder',
+                [
+                    'title' => 'Title of this event',
+                    'start_atom' => '2005-08-15T15:52:01+02:00'
+                ],
+                self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (in 1 hour, 52 minutes)',
+                [
+                    'title' => 'Title of this event',
+                    'description' => null,
+                    'location' => 'NC Headquarters',
+                    'all_day' => false,
+                    'start_atom' => '2005-08-15T15:52:01+02:00',
+                    'start_is_floating' => false,
+                    'start_timezone' => 'Europe/Berlin',
+                    'end_atom' => '2005-08-15T17:52:01+02:00',
+                    'end_is_floating' => false,
+                    'end_timezone' => 'Europe/Berlin',
+                    'calendar_displayname' => 'Personal',
+                ],
+                "Calendar: Personal\r\nDate: 2005-08-15T15:52:01+02:00, 2005-08-15T15:52:01+02:00 - 2005-08-15T17:52:01+02:00 (Europe/Berlin)\r\nWhere: NC Headquarters"
+            ],
+            [
+                'calendar_reminder',
+                [
+                    'title' => 'Title of this event',
+                    'start_atom' => '2005-08-15T13:00:00+02:00',
+                ],
+                self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (1 hour ago)',
+                [
+                    'title' => 'Title of this event',
+                    'description' => null,
+                    'location' => 'NC Headquarters',
+                    'all_day' => false,
+                    'start_atom' => '2005-08-15T13:00:00+02:00',
+                    'start_is_floating' => false,
+                    'start_timezone' => 'Europe/Berlin',
+                    'end_atom' => '2005-08-15T15:00:00+02:00',
+                    'end_is_floating' => false,
+                    'end_timezone' => 'Europe/Berlin',
+                    'calendar_displayname' => 'Personal',
+                ],
+                "Calendar: Personal\r\nDate: 2005-08-15T13:00:00+02:00, 2005-08-15T13:00:00+02:00 - 2005-08-15T15:00:00+02:00 (Europe/Berlin)\r\nWhere: NC Headquarters"
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataPrepare')]
+    public function testPrepare(string $subjectType, array $subjectParams, string $subject, array $messageParams, string $message): void {
+        /** @var INotification&MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn(Application::APP_ID);
+        $notification->expects($this->once())
+            ->method('getSubject')
+            ->willReturn($subjectType);
+        $notification->expects($this->once())
+            ->method('getSubjectParameters')
+            ->willReturn($subjectParams);
+        $notification->expects($this->once())
+            ->method('getMessageParameters')
+            ->willReturn($messageParams);
+
+        $notification->expects($this->once())
+            ->method('setParsedSubject')
+            ->with($subject)
+            ->willReturnSelf();
+
+        $notification->expects($this->once())
+            ->method('setParsedMessage')
+            ->with($message)
+            ->willReturnSelf();
+
+        $this->urlGenerator->expects($this->once())
+            ->method('imagePath')
+            ->with('core', 'places/calendar.svg')
+            ->willReturn('icon-url');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('icon-url')
+            ->willReturn('absolute-icon-url');
+        $notification->expects($this->once())
+            ->method('setIcon')
+            ->with('absolute-icon-url')
+            ->willReturnSelf();
+
+        $return = $this->notifier->prepare($notification, 'en');
+
+        $this->assertEquals($notification, $return);
+    }
+
+    public function testPassedEvent(): void {
+        /** @var INotification&MockObject $notification */
+        $notification = $this->createMock(INotification::class);
+
+        $notification->expects($this->once())
+            ->method('getApp')
+            ->willReturn(Application::APP_ID);
+        $notification->expects($this->once())
+            ->method('getSubject')
+            ->willReturn('calendar_reminder');
+        $notification->expects($this->once())
+            ->method('getSubjectParameters')
+            ->willReturn([
+                'title' => 'Title of this event',
+                'start_atom' => '2005-08-15T08:00:00+02:00'
+            ]);
+
+        $notification->expects($this->once())
+            ->method('getMessageParameters')
+            ->willReturn([
+                'title' => 'Title of this event',
+                'description' => null,
+                'location' => 'NC Headquarters',
+                'all_day' => false,
+                'start_atom' => '2005-08-15T08:00:00+02:00',
+                'start_is_floating' => false,
+                'start_timezone' => 'Europe/Berlin',
+                'end_atom' => '2005-08-15T13:00:00+02:00',
+                'end_is_floating' => false,
+                'end_timezone' => 'Europe/Berlin',
+                'calendar_displayname' => 'Personal',
+            ]);
+
+        $notification->expects($this->once())
+            ->method('setParsedSubject')
+            ->with(self::hasPhpDatetimeDiffBug() ? 'Title of this event' : 'Title of this event (6 hours ago)')
+            ->willReturnSelf();
+
+        $this->expectException(AlreadyProcessedException::class);
+
+        $return = $this->notifier->prepare($notification, 'en');
+
+        $this->assertEquals($notification, $return);
+    }
 }

apps/dav/tests/unit/CalDAV/Reminder/ReminderServiceTest.php

Indentation +541 added lines, -541 removed lines

@@ -26,18 +26,18 @@ 
 use Test\TestCase;
 
 class ReminderServiceTest extends TestCase {
-	private Backend&MockObject $backend;
-	private NotificationProviderManager&MockObject $notificationProviderManager;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private CalDavBackend&MockObject $caldavBackend;
-	private ITimeFactory&MockObject $timeFactory;
-	private IConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private Principal&MockObject $principalConnector;
-	private ReminderService $reminderService;
-
-	public const CALENDAR_DATA = <<<EOD
+    private Backend&MockObject $backend;
+    private NotificationProviderManager&MockObject $notificationProviderManager;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private CalDavBackend&MockObject $caldavBackend;
+    private ITimeFactory&MockObject $timeFactory;
+    private IConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private Principal&MockObject $principalConnector;
+    private ReminderService $reminderService;
+
+    public const CALENDAR_DATA = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -62,7 +62,7 @@ 
 END:VCALENDAR
 EOD;
 
-	public const CALENDAR_DATA_REPEAT = <<<EOD
+    public const CALENDAR_DATA_REPEAT = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -85,7 +85,7 @@ 
 END:VCALENDAR
 EOD;
 
-	public const CALENDAR_DATA_RECURRING = <<<EOD
+    public const CALENDAR_DATA_RECURRING = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -111,7 +111,7 @@ 
 END:VCALENDAR
 EOD;
 
-	public const CALENDAR_DATA_RECURRING_REPEAT = <<<EOD
+    public const CALENDAR_DATA_RECURRING_REPEAT = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -139,7 +139,7 @@ 
 END:VCALENDAR
 EOD;
 
-	public const CALENDAR_DATA_NO_ALARM = <<<EOD
+    public const CALENDAR_DATA_NO_ALARM = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -156,7 +156,7 @@ 
 END:VCALENDAR
 EOD;
 
-	private const CALENDAR_DATA_ONE_TIME = <<<EOD
+    private const CALENDAR_DATA_ONE_TIME = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//IDN nextcloud.com//Calendar app 4.3.0-alpha.0//EN
 CALSCALE:GREGORIAN
@@ -196,7 +196,7 @@ 
 END:VCALENDAR
 EOD;
 
-	private const CALENDAR_DATA_ALL_DAY = <<<EOD
+    private const CALENDAR_DATA_ALL_DAY = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//IDN nextcloud.com//Calendar app 4.3.0-alpha.0//EN
 CALSCALE:GREGORIAN
@@ -219,7 +219,7 @@ 
 END:VCALENDAR
 EOD;
 
-	private const PAGO_PAGO_VTIMEZONE_ICS = <<<ICS
+    private const PAGO_PAGO_VTIMEZONE_ICS = <<<ICS
 BEGIN:VCALENDAR
 BEGIN:VTIMEZONE
 TZID:Pacific/Pago_Pago
@@ -233,82 +233,82 @@ 
 END:VCALENDAR
 ICS;
 
-	private ?string $oldTimezone;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->backend = $this->createMock(Backend::class);
-		$this->notificationProviderManager = $this->createMock(NotificationProviderManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->caldavBackend = $this->createMock(CalDavBackend::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->principalConnector = $this->createMock(Principal::class);
-
-		$this->caldavBackend->method('getShares')->willReturn([]);
-
-		$this->reminderService = new ReminderService(
-			$this->backend,
-			$this->notificationProviderManager,
-			$this->userManager,
-			$this->groupManager,
-			$this->caldavBackend,
-			$this->timeFactory,
-			$this->config,
-			$this->logger,
-			$this->principalConnector,
-		);
-	}
-
-	public function testOnCalendarObjectDelete():void {
-		$this->backend->expects($this->once())
-			->method('cleanRemindersForEvent')
-			->with(44);
-
-		$objectData = [
-			'id' => '44',
-			'component' => 'vevent',
-		];
-
-		$this->reminderService->onCalendarObjectDelete($objectData);
-	}
-
-	public function testOnCalendarObjectCreateSingleEntry():void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-
-		$calls = [
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'de919af7429d3b5c11e8b9d289b411a6', 'EMAIL', true, 1465429500, false],
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', '35b3eae8e792aa2209f0b4e1a302f105', 'DISPLAY', false, 1465344000, false]
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return 1;
-			});
-
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	/**
-	 * RFC5545 says DTSTART is REQUIRED, but we have seen event without the prop
-	 */
-	public function testOnCalendarObjectCreateNoDtstart(): void {
-		$calendarData = <<<EOD
+    private ?string $oldTimezone;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->backend = $this->createMock(Backend::class);
+        $this->notificationProviderManager = $this->createMock(NotificationProviderManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->caldavBackend = $this->createMock(CalDavBackend::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->principalConnector = $this->createMock(Principal::class);
+
+        $this->caldavBackend->method('getShares')->willReturn([]);
+
+        $this->reminderService = new ReminderService(
+            $this->backend,
+            $this->notificationProviderManager,
+            $this->userManager,
+            $this->groupManager,
+            $this->caldavBackend,
+            $this->timeFactory,
+            $this->config,
+            $this->logger,
+            $this->principalConnector,
+        );
+    }
+
+    public function testOnCalendarObjectDelete():void {
+        $this->backend->expects($this->once())
+            ->method('cleanRemindersForEvent')
+            ->with(44);
+
+        $objectData = [
+            'id' => '44',
+            'component' => 'vevent',
+        ];
+
+        $this->reminderService->onCalendarObjectDelete($objectData);
+    }
+
+    public function testOnCalendarObjectCreateSingleEntry():void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+
+        $calls = [
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'de919af7429d3b5c11e8b9d289b411a6', 'EMAIL', true, 1465429500, false],
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', '35b3eae8e792aa2209f0b4e1a302f105', 'DISPLAY', false, 1465344000, false]
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('insertReminder')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return 1;
+            });
+
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    /**
+     * RFC5545 says DTSTART is REQUIRED, but we have seen event without the prop
+     */
+    public function testOnCalendarObjectCreateNoDtstart(): void {
+        $calendarData = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//Nextcloud calendar v1.6.4
 BEGIN:VEVENT
@@ -328,450 +328,450 @@ 
 END:VEVENT
 END:VCALENDAR
 EOD;
-		$objectData = [
-			'calendardata' => $calendarData,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-
-		$this->backend->expects($this->never())
-			->method('insertReminder');
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateSingleEntryWithRepeat(): void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_REPEAT,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-
-		$calls = [
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429500, false],
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429620, true],
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429740, true],
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429860, true],
-			[1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429980, true]
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return 1;
-			});
-
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateRecurringEntry(): void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_RECURRING,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-
-		$calls = [
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'de919af7429d3b5c11e8b9d289b411a6', 'EMAIL', true, 1467243900, false],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467158400, false]
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return 1;
-			});
-
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-29T00:00:00+00:00'));
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateEmpty():void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_NO_ALARM,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-
-		$this->backend->expects($this->never())
-			->method('insertReminder');
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateAllDayWithNullTimezone(): void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_ALL_DAY,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
-			]);
-
-		// One hour before midnight relative to the server's time
-		$expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00'))->getTimestamp();
-		$this->backend->expects(self::once())
-			->method('insertReminder')
-			->with(1337, 42, self::anything(), false, 1675468800, false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateAllDayWithBlankTimezone(): void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_ALL_DAY,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => '',
-			]);
-
-		// One hour before midnight relative to the server's time
-		$expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00'))->getTimestamp();
-		$this->backend->expects(self::once())
-			->method('insertReminder')
-			->with(1337, 42, self::anything(), false, 1675468800, false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateAllDayWithTimezone(): void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_ALL_DAY,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => self::PAGO_PAGO_VTIMEZONE_ICS,
-			]);
-
-		// One hour before midnight relative to the timezone
-		$expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00', new DateTimeZone('Pacific/Pago_Pago')))->getTimestamp();
-		$this->backend->expects(self::once())
-			->method('insertReminder')
-			->with(1337, 42, 'a163a056-ba26-44a2-8080-955f19611a8f', false, self::anything(), false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateRecurringEntryWithRepeat():void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_RECURRING_REPEAT,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
-			]);
-
-		$calls = [
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467243900, false],
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244020, true],
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244140, true],
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244260, true],
-			[1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244380, true],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467158400, false]
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-				return 1;
-			});
-
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-29T00:00:00+00:00'));
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testOnCalendarObjectCreateWithEventTimezoneAndCalendarTimezone():void {
-		$objectData = [
-			'calendardata' => self::CALENDAR_DATA_ONE_TIME,
-			'id' => '42',
-			'calendarid' => '1337',
-			'component' => 'vevent',
-		];
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => self::PAGO_PAGO_VTIMEZONE_ICS,
-			]);
-		$expectedReminderTimstamp = (new DateTime('2023-02-04T08:00:00', new DateTimeZone('Europe/Vienna')))->getTimestamp();
-		$this->backend->expects(self::once())
-			->method('insertReminder')
-			->with(1337, 42, self::anything(), false, self::anything(), false, self::anything(), self::anything(), self::anything(), true, $expectedReminderTimstamp, false)
-			->willReturn(1);
-		$this->caldavBackend->expects(self::once())
-			->method('getCalendarById')
-			->with(1337)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
-			]);
-		$this->timeFactory->expects($this->once())
-			->method('getDateTime')
-			->with()
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
-		;
-
-		$this->reminderService->onCalendarObjectCreate($objectData);
-	}
-
-	public function testProcessReminders():void {
-		$this->backend->expects($this->once())
-			->method('getRemindersToProcess')
-			->with()
-			->willReturn([
-				[
-					'id' => 1,
-					'calendar_id' => 1337,
-					'object_id' => 42,
-					'uid' => 'wej2z68l9h',
-					'is_recurring' => false,
-					'recurrence_id' => 1465430400,
-					'is_recurrence_exception' => false,
-					'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
-					'alarm_hash' => 'de919af7429d3b5c11e8b9d289b411a6',
-					'type' => 'EMAIL',
-					'is_relative' => true,
-					'notification_date' => 1465429500,
-					'is_repeat_based' => false,
-					'calendardata' => self::CALENDAR_DATA,
-					'displayname' => 'Displayname 123',
-					'principaluri' => 'principals/users/user001',
-				],
-				[
-					'id' => 2,
-					'calendar_id' => 1337,
-					'object_id' => 42,
-					'uid' => 'wej2z68l9h',
-					'is_recurring' => false,
-					'recurrence_id' => 1465430400,
-					'is_recurrence_exception' => false,
-					'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
-					'alarm_hash' => 'ecacbf07d413c3c78d1ac7ad8c469602',
-					'type' => 'EMAIL',
-					'is_relative' => true,
-					'notification_date' => 1465429740,
-					'is_repeat_based' => true,
-					'calendardata' => self::CALENDAR_DATA_REPEAT,
-					'displayname' => 'Displayname 123',
-					'principaluri' => 'principals/users/user001',
-				],
-				[
-					'id' => 3,
-					'calendar_id' => 1337,
-					'object_id' => 42,
-					'uid' => 'wej2z68l9h',
-					'is_recurring' => false,
-					'recurrence_id' => 1465430400,
-					'is_recurrence_exception' => false,
-					'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
-					'alarm_hash' => '35b3eae8e792aa2209f0b4e1a302f105',
-					'type' => 'DISPLAY',
-					'is_relative' => false,
-					'notification_date' => 1465344000,
-					'is_repeat_based' => false,
-					'calendardata' => self::CALENDAR_DATA,
-					'displayname' => 'Displayname 123',
-					'principaluri' => 'principals/users/user001',
-				],
-				[
-					'id' => 4,
-					'calendar_id' => 1337,
-					'object_id' => 42,
-					'uid' => 'wej2z68l9h',
-					'is_recurring' => true,
-					'recurrence_id' => 1467244800,
-					'is_recurrence_exception' => false,
-					'event_hash' => 'fbdb2726bc0f7dfacac1d881c1453e20',
-					'alarm_hash' => 'ecacbf07d413c3c78d1ac7ad8c469602',
-					'type' => 'EMAIL',
-					'is_relative' => true,
-					'notification_date' => 1467243900,
-					'is_repeat_based' => false,
-					'calendardata' => self::CALENDAR_DATA_RECURRING_REPEAT,
-					'displayname' => 'Displayname 123',
-					'principaluri' => 'principals/users/user001',
-				],
-				[
-					'id' => 5,
-					'calendar_id' => 1337,
-					'object_id' => 42,
-					'uid' => 'wej2z68l9h',
-					'is_recurring' => true,
-					'recurrence_id' => 1467849600,
-					'is_recurrence_exception' => false,
-					'event_hash' => 'fbdb2726bc0f7dfacac1d881c1453e20',
-					'alarm_hash' => '8996992118817f9f311ac5cc56d1cc97',
-					'type' => 'EMAIL',
-					'is_relative' => true,
-					'notification_date' => 1467158400,
-					'is_repeat_based' => false,
-					'calendardata' => self::CALENDAR_DATA_RECURRING,
-					'displayname' => 'Displayname 123',
-					'principaluri' => 'principals/users/user001',
-				]
-			]);
-
-		$this->notificationProviderManager->expects($this->exactly(5))
-			->method('hasProvider')
-			->willReturnMap([
-				['EMAIL', true],
-				['DISPLAY', true],
-			]);
-
-		$provider1 = $this->createMock(INotificationProvider::class);
-		$provider2 = $this->createMock(INotificationProvider::class);
-		$provider3 = $this->createMock(INotificationProvider::class);
-		$provider4 = $this->createMock(INotificationProvider::class);
-		$provider5 = $this->createMock(INotificationProvider::class);
-
-		$getProviderCalls = [
-			['EMAIL', $provider1],
-			['EMAIL', $provider2],
-			['DISPLAY', $provider3],
-			['EMAIL', $provider4],
-			['EMAIL', $provider5],
-		];
-		$this->notificationProviderManager->expects($this->exactly(count($getProviderCalls)))
-			->method('getProvider')
-			->willReturnCallback(function () use (&$getProviderCalls) {
-				$expected = array_shift($getProviderCalls);
-				$return = array_pop($expected);
-				$this->assertEquals($expected, func_get_args());
-				return $return;
-			});
-
-		$user = $this->createMock(IUser::class);
-		$this->userManager->expects($this->exactly(5))
-			->method('get')
-			->with('user001')
-			->willReturn($user);
-
-		$provider1->expects($this->once())
-			->method('send')
-			->with($this->callback(function ($vevent) {
-				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
-					return false;
-				}
-				return true;
-			}, 'Displayname 123', $user));
-		$provider2->expects($this->once())
-			->method('send')
-			->with($this->callback(function ($vevent) {
-				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
-					return false;
-				}
-				return true;
-			}, 'Displayname 123', $user));
-		$provider3->expects($this->once())
-			->method('send')
-			->with($this->callback(function ($vevent) {
-				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
-					return false;
-				}
-				return true;
-			}, 'Displayname 123', $user));
-		$provider4->expects($this->once())
-			->method('send')
-			->with($this->callback(function ($vevent) {
-				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-30T00:00:00+00:00') {
-					return false;
-				}
-				return true;
-			}, 'Displayname 123', $user));
-		$provider5->expects($this->once())
-			->method('send')
-			->with($this->callback(function ($vevent) {
-				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-07-07T00:00:00+00:00') {
-					return false;
-				}
-				return true;
-			}, 'Displayname 123', $user));
-
-		$removeReminderCalls = [
-			[1],
-			[2],
-			[3],
-			[4],
-			[5],
-		];
-		$this->backend->expects($this->exactly(5))
-			->method('removeReminder')
-			->willReturnCallback(function () use (&$removeReminderCalls): void {
-				$expected = array_shift($removeReminderCalls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-
-		$insertReminderCalls = [
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848700, false],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848820, true],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848940, true],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467849060, true],
-			[1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467849180, true],
-			[1337, 42, 'wej2z68l9h', true, 1468454400, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467763200, false],
-		];
-		$this->backend->expects($this->exactly(count($insertReminderCalls)))
-			->method('insertReminder')
-			->willReturnCallback(function () use (&$insertReminderCalls) {
-				$expected = array_shift($insertReminderCalls);
-				$this->assertEquals($expected, func_get_args());
-				return 99;
-			});
-
-		$this->timeFactory->method('getDateTime')
-			->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
-
-		$this->reminderService->processReminders();
-	}
+        $objectData = [
+            'calendardata' => $calendarData,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+
+        $this->backend->expects($this->never())
+            ->method('insertReminder');
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateSingleEntryWithRepeat(): void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_REPEAT,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+
+        $calls = [
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429500, false],
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429620, true],
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429740, true],
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429860, true],
+            [1337, 42, 'wej2z68l9h', false, 1465430400, false, '5c70531aab15c92b52518ae10a2f78a4', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1465429980, true]
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('insertReminder')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return 1;
+            });
+
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateRecurringEntry(): void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_RECURRING,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+
+        $calls = [
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'de919af7429d3b5c11e8b9d289b411a6', 'EMAIL', true, 1467243900, false],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467158400, false]
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('insertReminder')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return 1;
+            });
+
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-29T00:00:00+00:00'));
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateEmpty():void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_NO_ALARM,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+
+        $this->backend->expects($this->never())
+            ->method('insertReminder');
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateAllDayWithNullTimezone(): void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_ALL_DAY,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
+            ]);
+
+        // One hour before midnight relative to the server's time
+        $expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00'))->getTimestamp();
+        $this->backend->expects(self::once())
+            ->method('insertReminder')
+            ->with(1337, 42, self::anything(), false, 1675468800, false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateAllDayWithBlankTimezone(): void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_ALL_DAY,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => '',
+            ]);
+
+        // One hour before midnight relative to the server's time
+        $expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00'))->getTimestamp();
+        $this->backend->expects(self::once())
+            ->method('insertReminder')
+            ->with(1337, 42, self::anything(), false, 1675468800, false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateAllDayWithTimezone(): void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_ALL_DAY,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => self::PAGO_PAGO_VTIMEZONE_ICS,
+            ]);
+
+        // One hour before midnight relative to the timezone
+        $expectedReminderTimstamp = (new DateTime('2023-02-03T23:00:00', new DateTimeZone('Pacific/Pago_Pago')))->getTimestamp();
+        $this->backend->expects(self::once())
+            ->method('insertReminder')
+            ->with(1337, 42, 'a163a056-ba26-44a2-8080-955f19611a8f', false, self::anything(), false, self::anything(), self::anything(), 'EMAIL', true, $expectedReminderTimstamp, false);
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateRecurringEntryWithRepeat():void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_RECURRING_REPEAT,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
+            ]);
+
+        $calls = [
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467243900, false],
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244020, true],
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244140, true],
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244260, true],
+            [1337, 42, 'wej2z68l9h', true, 1467244800, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467244380, true],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467158400, false]
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('insertReminder')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+                return 1;
+            });
+
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-29T00:00:00+00:00'));
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testOnCalendarObjectCreateWithEventTimezoneAndCalendarTimezone():void {
+        $objectData = [
+            'calendardata' => self::CALENDAR_DATA_ONE_TIME,
+            'id' => '42',
+            'calendarid' => '1337',
+            'component' => 'vevent',
+        ];
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => self::PAGO_PAGO_VTIMEZONE_ICS,
+            ]);
+        $expectedReminderTimstamp = (new DateTime('2023-02-04T08:00:00', new DateTimeZone('Europe/Vienna')))->getTimestamp();
+        $this->backend->expects(self::once())
+            ->method('insertReminder')
+            ->with(1337, 42, self::anything(), false, self::anything(), false, self::anything(), self::anything(), self::anything(), true, $expectedReminderTimstamp, false)
+            ->willReturn(1);
+        $this->caldavBackend->expects(self::once())
+            ->method('getCalendarById')
+            ->with(1337)
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => null,
+            ]);
+        $this->timeFactory->expects($this->once())
+            ->method('getDateTime')
+            ->with()
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2023-02-03T13:28:00+00:00'));
+        ;
+
+        $this->reminderService->onCalendarObjectCreate($objectData);
+    }
+
+    public function testProcessReminders():void {
+        $this->backend->expects($this->once())
+            ->method('getRemindersToProcess')
+            ->with()
+            ->willReturn([
+                [
+                    'id' => 1,
+                    'calendar_id' => 1337,
+                    'object_id' => 42,
+                    'uid' => 'wej2z68l9h',
+                    'is_recurring' => false,
+                    'recurrence_id' => 1465430400,
+                    'is_recurrence_exception' => false,
+                    'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
+                    'alarm_hash' => 'de919af7429d3b5c11e8b9d289b411a6',
+                    'type' => 'EMAIL',
+                    'is_relative' => true,
+                    'notification_date' => 1465429500,
+                    'is_repeat_based' => false,
+                    'calendardata' => self::CALENDAR_DATA,
+                    'displayname' => 'Displayname 123',
+                    'principaluri' => 'principals/users/user001',
+                ],
+                [
+                    'id' => 2,
+                    'calendar_id' => 1337,
+                    'object_id' => 42,
+                    'uid' => 'wej2z68l9h',
+                    'is_recurring' => false,
+                    'recurrence_id' => 1465430400,
+                    'is_recurrence_exception' => false,
+                    'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
+                    'alarm_hash' => 'ecacbf07d413c3c78d1ac7ad8c469602',
+                    'type' => 'EMAIL',
+                    'is_relative' => true,
+                    'notification_date' => 1465429740,
+                    'is_repeat_based' => true,
+                    'calendardata' => self::CALENDAR_DATA_REPEAT,
+                    'displayname' => 'Displayname 123',
+                    'principaluri' => 'principals/users/user001',
+                ],
+                [
+                    'id' => 3,
+                    'calendar_id' => 1337,
+                    'object_id' => 42,
+                    'uid' => 'wej2z68l9h',
+                    'is_recurring' => false,
+                    'recurrence_id' => 1465430400,
+                    'is_recurrence_exception' => false,
+                    'event_hash' => '5c70531aab15c92b52518ae10a2f78a4',
+                    'alarm_hash' => '35b3eae8e792aa2209f0b4e1a302f105',
+                    'type' => 'DISPLAY',
+                    'is_relative' => false,
+                    'notification_date' => 1465344000,
+                    'is_repeat_based' => false,
+                    'calendardata' => self::CALENDAR_DATA,
+                    'displayname' => 'Displayname 123',
+                    'principaluri' => 'principals/users/user001',
+                ],
+                [
+                    'id' => 4,
+                    'calendar_id' => 1337,
+                    'object_id' => 42,
+                    'uid' => 'wej2z68l9h',
+                    'is_recurring' => true,
+                    'recurrence_id' => 1467244800,
+                    'is_recurrence_exception' => false,
+                    'event_hash' => 'fbdb2726bc0f7dfacac1d881c1453e20',
+                    'alarm_hash' => 'ecacbf07d413c3c78d1ac7ad8c469602',
+                    'type' => 'EMAIL',
+                    'is_relative' => true,
+                    'notification_date' => 1467243900,
+                    'is_repeat_based' => false,
+                    'calendardata' => self::CALENDAR_DATA_RECURRING_REPEAT,
+                    'displayname' => 'Displayname 123',
+                    'principaluri' => 'principals/users/user001',
+                ],
+                [
+                    'id' => 5,
+                    'calendar_id' => 1337,
+                    'object_id' => 42,
+                    'uid' => 'wej2z68l9h',
+                    'is_recurring' => true,
+                    'recurrence_id' => 1467849600,
+                    'is_recurrence_exception' => false,
+                    'event_hash' => 'fbdb2726bc0f7dfacac1d881c1453e20',
+                    'alarm_hash' => '8996992118817f9f311ac5cc56d1cc97',
+                    'type' => 'EMAIL',
+                    'is_relative' => true,
+                    'notification_date' => 1467158400,
+                    'is_repeat_based' => false,
+                    'calendardata' => self::CALENDAR_DATA_RECURRING,
+                    'displayname' => 'Displayname 123',
+                    'principaluri' => 'principals/users/user001',
+                ]
+            ]);
+
+        $this->notificationProviderManager->expects($this->exactly(5))
+            ->method('hasProvider')
+            ->willReturnMap([
+                ['EMAIL', true],
+                ['DISPLAY', true],
+            ]);
+
+        $provider1 = $this->createMock(INotificationProvider::class);
+        $provider2 = $this->createMock(INotificationProvider::class);
+        $provider3 = $this->createMock(INotificationProvider::class);
+        $provider4 = $this->createMock(INotificationProvider::class);
+        $provider5 = $this->createMock(INotificationProvider::class);
+
+        $getProviderCalls = [
+            ['EMAIL', $provider1],
+            ['EMAIL', $provider2],
+            ['DISPLAY', $provider3],
+            ['EMAIL', $provider4],
+            ['EMAIL', $provider5],
+        ];
+        $this->notificationProviderManager->expects($this->exactly(count($getProviderCalls)))
+            ->method('getProvider')
+            ->willReturnCallback(function () use (&$getProviderCalls) {
+                $expected = array_shift($getProviderCalls);
+                $return = array_pop($expected);
+                $this->assertEquals($expected, func_get_args());
+                return $return;
+            });
+
+        $user = $this->createMock(IUser::class);
+        $this->userManager->expects($this->exactly(5))
+            ->method('get')
+            ->with('user001')
+            ->willReturn($user);
+
+        $provider1->expects($this->once())
+            ->method('send')
+            ->with($this->callback(function ($vevent) {
+                if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
+                    return false;
+                }
+                return true;
+            }, 'Displayname 123', $user));
+        $provider2->expects($this->once())
+            ->method('send')
+            ->with($this->callback(function ($vevent) {
+                if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
+                    return false;
+                }
+                return true;
+            }, 'Displayname 123', $user));
+        $provider3->expects($this->once())
+            ->method('send')
+            ->with($this->callback(function ($vevent) {
+                if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
+                    return false;
+                }
+                return true;
+            }, 'Displayname 123', $user));
+        $provider4->expects($this->once())
+            ->method('send')
+            ->with($this->callback(function ($vevent) {
+                if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-30T00:00:00+00:00') {
+                    return false;
+                }
+                return true;
+            }, 'Displayname 123', $user));
+        $provider5->expects($this->once())
+            ->method('send')
+            ->with($this->callback(function ($vevent) {
+                if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-07-07T00:00:00+00:00') {
+                    return false;
+                }
+                return true;
+            }, 'Displayname 123', $user));
+
+        $removeReminderCalls = [
+            [1],
+            [2],
+            [3],
+            [4],
+            [5],
+        ];
+        $this->backend->expects($this->exactly(5))
+            ->method('removeReminder')
+            ->willReturnCallback(function () use (&$removeReminderCalls): void {
+                $expected = array_shift($removeReminderCalls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+
+        $insertReminderCalls = [
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848700, false],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848820, true],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467848940, true],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467849060, true],
+            [1337, 42, 'wej2z68l9h', true, 1467849600, false, 'fbdb2726bc0f7dfacac1d881c1453e20', 'ecacbf07d413c3c78d1ac7ad8c469602', 'EMAIL', true, 1467849180, true],
+            [1337, 42, 'wej2z68l9h', true, 1468454400, false, 'fbdb2726bc0f7dfacac1d881c1453e20', '8996992118817f9f311ac5cc56d1cc97', 'EMAIL', true, 1467763200, false],
+        ];
+        $this->backend->expects($this->exactly(count($insertReminderCalls)))
+            ->method('insertReminder')
+            ->willReturnCallback(function () use (&$insertReminderCalls) {
+                $expected = array_shift($insertReminderCalls);
+                $this->assertEquals($expected, func_get_args());
+                return 99;
+            });
+
+        $this->timeFactory->method('getDateTime')
+            ->willReturn(DateTime::createFromFormat(DateTime::ATOM, '2016-06-08T00:00:00+00:00'));
+
+        $this->reminderService->processReminders();
+    }
 }

Spacing +12 added lines, -12 removed lines

@@ -290,7 +290,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($calls)))
 			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 				return 1;
@@ -358,7 +358,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($calls)))
 			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 				return 1;
@@ -386,7 +386,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($calls)))
 			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 				return 1;
@@ -518,7 +518,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($calls)))
 			->method('insertReminder')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 				return 1;
@@ -684,7 +684,7 @@ 
 		];
 		$this->notificationProviderManager->expects($this->exactly(count($getProviderCalls)))
 			->method('getProvider')
-			->willReturnCallback(function () use (&$getProviderCalls) {
+			->willReturnCallback(function() use (&$getProviderCalls) {
 				$expected = array_shift($getProviderCalls);
 				$return = array_pop($expected);
 				$this->assertEquals($expected, func_get_args());
@@ -699,7 +699,7 @@ 
 
 		$provider1->expects($this->once())
 			->method('send')
-			->with($this->callback(function ($vevent) {
+			->with($this->callback(function($vevent) {
 				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
 					return false;
 				}
@@ -707,7 +707,7 @@ 
 			}, 'Displayname 123', $user));
 		$provider2->expects($this->once())
 			->method('send')
-			->with($this->callback(function ($vevent) {
+			->with($this->callback(function($vevent) {
 				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
 					return false;
 				}
@@ -715,7 +715,7 @@ 
 			}, 'Displayname 123', $user));
 		$provider3->expects($this->once())
 			->method('send')
-			->with($this->callback(function ($vevent) {
+			->with($this->callback(function($vevent) {
 				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-09T00:00:00+00:00') {
 					return false;
 				}
@@ -723,7 +723,7 @@ 
 			}, 'Displayname 123', $user));
 		$provider4->expects($this->once())
 			->method('send')
-			->with($this->callback(function ($vevent) {
+			->with($this->callback(function($vevent) {
 				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-06-30T00:00:00+00:00') {
 					return false;
 				}
@@ -731,7 +731,7 @@ 
 			}, 'Displayname 123', $user));
 		$provider5->expects($this->once())
 			->method('send')
-			->with($this->callback(function ($vevent) {
+			->with($this->callback(function($vevent) {
 				if ($vevent->DTSTART->getDateTime()->format(DateTime::ATOM) !== '2016-07-07T00:00:00+00:00') {
 					return false;
 				}
@@ -747,7 +747,7 @@ 
 		];
 		$this->backend->expects($this->exactly(5))
 			->method('removeReminder')
-			->willReturnCallback(function () use (&$removeReminderCalls): void {
+			->willReturnCallback(function() use (&$removeReminderCalls): void {
 				$expected = array_shift($removeReminderCalls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -763,7 +763,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($insertReminderCalls)))
 			->method('insertReminder')
-			->willReturnCallback(function () use (&$insertReminderCalls) {
+			->willReturnCallback(function() use (&$insertReminderCalls) {
 				$expected = array_shift($insertReminderCalls);
 				$this->assertEquals($expected, func_get_args());
 				return 99;

apps/dav/tests/unit/CalDAV/Reminder/NotificationProvider/PushProviderTest.php

Indentation +154 added lines, -154 removed lines

@@ -16,158 +16,158 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class PushProviderTest extends AbstractNotificationProviderTestCase {
-	private IManager&MockObject $manager;
-	private ITimeFactory&MockObject $timeFactory;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->manager = $this->createMock(IManager::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-
-		$this->provider = new PushProvider(
-			$this->config,
-			$this->manager,
-			$this->logger,
-			$this->l10nFactory,
-			$this->urlGenerator,
-			$this->timeFactory
-		);
-	}
-
-	public function testNotificationType():void {
-		$this->assertEquals(PushProvider::NOTIFICATION_TYPE, 'DISPLAY');
-	}
-
-	public function testNotSend(): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'sendEventRemindersPush', 'yes')
-			->willReturn('no');
-
-		$this->manager->expects($this->never())
-			->method('createNotification');
-		$this->manager->expects($this->never())
-			->method('notify');
-
-		$user1 = $this->createMock(IUser::class);
-		$user1->method('getUID')
-			->willReturn('uid1');
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')
-			->willReturn('uid2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')
-			->willReturn('uid3');
-
-		$users = [$user1, $user2, $user3];
-
-		$this->provider->send($this->vcalendar->VEVENT, $this->calendarDisplayName, [], $users);
-	}
-
-	public function testSend(): void {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'sendEventRemindersPush', 'yes')
-			->willReturn('yes');
-
-		$user1 = $this->createMock(IUser::class);
-		$user1->method('getUID')
-			->willReturn('uid1');
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getUID')
-			->willReturn('uid2');
-		$user3 = $this->createMock(IUser::class);
-		$user3->method('getUID')
-			->willReturn('uid3');
-
-		$users = [$user1, $user2, $user3];
-
-		$dateTime = new \DateTime('@946684800');
-		$this->timeFactory->method('getDateTime')
-			->with()
-			->willReturn($dateTime);
-
-		$notification1 = $this->createNotificationMock('uid1', $dateTime);
-		$notification2 = $this->createNotificationMock('uid2', $dateTime);
-		$notification3 = $this->createNotificationMock('uid3', $dateTime);
-
-		$this->manager->expects($this->exactly(3))
-			->method('createNotification')
-			->willReturnOnConsecutiveCalls(
-				$notification1,
-				$notification2,
-				$notification3
-			);
-
-		$calls = [
-			$notification1,
-			$notification2,
-			$notification3,
-		];
-		$this->manager->expects($this->exactly(3))
-			->method('notify')
-			->willReturnCallback(function ($notification) use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $notification);
-			});
-
-		$this->provider->send($this->vcalendar->VEVENT, $this->calendarDisplayName, [], $users);
-	}
-
-	/**
-	 * @param string $uid
-	 * @param \DateTime $dt
-	 */
-	private function createNotificationMock(string $uid, \DateTime $dt):INotification {
-		$notification = $this->createMock(INotification::class);
-		$notification
-			->expects($this->once())
-			->method('setApp')
-			->with('dav')
-			->willReturn($notification);
-
-		$notification->expects($this->once())
-			->method('setUser')
-			->with($uid)
-			->willReturn($notification);
-
-		$notification->expects($this->once())
-			->method('setDateTime')
-			->with($dt)
-			->willReturn($notification);
-
-		$notification->expects($this->once())
-			->method('setObject')
-			->with('dav', hash('sha256', 'uid1234', false))
-			->willReturn($notification);
-
-		$notification->expects($this->once())
-			->method('setSubject')
-			->with('calendar_reminder', [
-				'title' => 'Fellowship meeting',
-				'start_atom' => '2017-01-01T00:00:00+00:00',
-			])
-			->willReturn($notification);
-
-		$notification
-			->expects($this->once())
-			->method('setMessage')
-			->with('calendar_reminder', [
-				'title' => 'Fellowship meeting',
-				'start_atom' => '2017-01-01T00:00:00+00:00',
-				'description' => null,
-				'location' => null,
-				'all_day' => false,
-				'start_is_floating' => false,
-				'start_timezone' => 'UTC',
-				'end_atom' => '2017-01-01T00:00:00+00:00',
-				'end_is_floating' => false,
-				'end_timezone' => 'UTC',
-				'calendar_displayname' => 'Personal',
-			])
-			->willReturn($notification);
-
-		return $notification;
-	}
+    private IManager&MockObject $manager;
+    private ITimeFactory&MockObject $timeFactory;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->manager = $this->createMock(IManager::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+
+        $this->provider = new PushProvider(
+            $this->config,
+            $this->manager,
+            $this->logger,
+            $this->l10nFactory,
+            $this->urlGenerator,
+            $this->timeFactory
+        );
+    }
+
+    public function testNotificationType():void {
+        $this->assertEquals(PushProvider::NOTIFICATION_TYPE, 'DISPLAY');
+    }
+
+    public function testNotSend(): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'sendEventRemindersPush', 'yes')
+            ->willReturn('no');
+
+        $this->manager->expects($this->never())
+            ->method('createNotification');
+        $this->manager->expects($this->never())
+            ->method('notify');
+
+        $user1 = $this->createMock(IUser::class);
+        $user1->method('getUID')
+            ->willReturn('uid1');
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')
+            ->willReturn('uid2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')
+            ->willReturn('uid3');
+
+        $users = [$user1, $user2, $user3];
+
+        $this->provider->send($this->vcalendar->VEVENT, $this->calendarDisplayName, [], $users);
+    }
+
+    public function testSend(): void {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'sendEventRemindersPush', 'yes')
+            ->willReturn('yes');
+
+        $user1 = $this->createMock(IUser::class);
+        $user1->method('getUID')
+            ->willReturn('uid1');
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getUID')
+            ->willReturn('uid2');
+        $user3 = $this->createMock(IUser::class);
+        $user3->method('getUID')
+            ->willReturn('uid3');
+
+        $users = [$user1, $user2, $user3];
+
+        $dateTime = new \DateTime('@946684800');
+        $this->timeFactory->method('getDateTime')
+            ->with()
+            ->willReturn($dateTime);
+
+        $notification1 = $this->createNotificationMock('uid1', $dateTime);
+        $notification2 = $this->createNotificationMock('uid2', $dateTime);
+        $notification3 = $this->createNotificationMock('uid3', $dateTime);
+
+        $this->manager->expects($this->exactly(3))
+            ->method('createNotification')
+            ->willReturnOnConsecutiveCalls(
+                $notification1,
+                $notification2,
+                $notification3
+            );
+
+        $calls = [
+            $notification1,
+            $notification2,
+            $notification3,
+        ];
+        $this->manager->expects($this->exactly(3))
+            ->method('notify')
+            ->willReturnCallback(function ($notification) use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $notification);
+            });
+
+        $this->provider->send($this->vcalendar->VEVENT, $this->calendarDisplayName, [], $users);
+    }
+
+    /**
+     * @param string $uid
+     * @param \DateTime $dt
+     */
+    private function createNotificationMock(string $uid, \DateTime $dt):INotification {
+        $notification = $this->createMock(INotification::class);
+        $notification
+            ->expects($this->once())
+            ->method('setApp')
+            ->with('dav')
+            ->willReturn($notification);
+
+        $notification->expects($this->once())
+            ->method('setUser')
+            ->with($uid)
+            ->willReturn($notification);
+
+        $notification->expects($this->once())
+            ->method('setDateTime')
+            ->with($dt)
+            ->willReturn($notification);
+
+        $notification->expects($this->once())
+            ->method('setObject')
+            ->with('dav', hash('sha256', 'uid1234', false))
+            ->willReturn($notification);
+
+        $notification->expects($this->once())
+            ->method('setSubject')
+            ->with('calendar_reminder', [
+                'title' => 'Fellowship meeting',
+                'start_atom' => '2017-01-01T00:00:00+00:00',
+            ])
+            ->willReturn($notification);
+
+        $notification
+            ->expects($this->once())
+            ->method('setMessage')
+            ->with('calendar_reminder', [
+                'title' => 'Fellowship meeting',
+                'start_atom' => '2017-01-01T00:00:00+00:00',
+                'description' => null,
+                'location' => null,
+                'all_day' => false,
+                'start_is_floating' => false,
+                'start_timezone' => 'UTC',
+                'end_atom' => '2017-01-01T00:00:00+00:00',
+                'end_is_floating' => false,
+                'end_timezone' => 'UTC',
+                'calendar_displayname' => 'Personal',
+            ])
+            ->willReturn($notification);
+
+        return $notification;
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
 		];
 		$this->manager->expects($this->exactly(3))
 			->method('notify')
-			->willReturnCallback(function ($notification) use (&$calls): void {
+			->willReturnCallback(function($notification) use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $notification);
 			});

apps/dav/tests/unit/BackgroundJob/UserStatusAutomationTest.php

Indentation +154 added lines, -154 removed lines

@@ -29,93 +29,93 @@ 
  * @group DB
  */
 class UserStatusAutomationTest extends TestCase {
-	protected ITimeFactory&MockObject $time;
-	protected IJobList&MockObject $jobList;
-	protected LoggerInterface&MockObject $logger;
-	protected IManager&MockObject $statusManager;
-	protected IConfig&MockObject $config;
-	private IAvailabilityCoordinator&MockObject $coordinator;
-	private IUserManager&MockObject $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->time = $this->createMock(ITimeFactory::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->statusManager = $this->createMock(IManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->coordinator = $this->createMock(IAvailabilityCoordinator::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-
-	}
-
-	protected function getAutomationMock(array $methods): MockObject|UserStatusAutomation {
-		if (empty($methods)) {
-			return new UserStatusAutomation(
-				$this->time,
-				Server::get(IDBConnection::class),
-				$this->jobList,
-				$this->logger,
-				$this->statusManager,
-				$this->config,
-				$this->coordinator,
-				$this->userManager,
-			);
-		}
-
-		return $this->getMockBuilder(UserStatusAutomation::class)
-			->setConstructorArgs([
-				$this->time,
-				Server::get(IDBConnection::class),
-				$this->jobList,
-				$this->logger,
-				$this->statusManager,
-				$this->config,
-				$this->coordinator,
-				$this->userManager,
-			])
-			->onlyMethods($methods)
-			->getMock();
-	}
-
-	public static function dataRun(): array {
-		return [
-			['20230217', '2023-02-24 10:49:36.613834', true],
-			['20230224', '2023-02-24 10:49:36.613834', true],
-			['20230217', '2023-02-24 13:58:24.479357', false],
-			['20230224', '2023-02-24 13:58:24.479357', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataRun')]
-	public function testRunNoOOO(string $ruleDay, string $currentTime, bool $isAvailable): void {
-		$user = $this->createConfiguredMock(IUser::class, [
-			'getUID' => 'user'
-		]);
-
-		$this->userManager->expects(self::once())
-			->method('get')
-			->willReturn($user);
-		$this->coordinator->expects(self::once())
-			->method('getCurrentOutOfOfficeData')
-			->willReturn(null);
-		$this->config->method('getUserValue')
-			->with('user', 'dav', 'user_status_automation', 'no')
-			->willReturn('yes');
-		$this->time->method('getDateTime')
-			->willReturn(new \DateTime($currentTime, new \DateTimeZone('UTC')));
-		$this->logger->expects(self::exactly(4))
-			->method('debug');
-		if (!$isAvailable) {
-			$this->statusManager->expects(self::once())
-				->method('setUserStatus')
-				->with('user', IUserStatus::MESSAGE_AVAILABILITY, IUserStatus::DND, true);
-		}
-		$automation = $this->getAutomationMock(['getAvailabilityFromPropertiesTable']);
-		$automation->method('getAvailabilityFromPropertiesTable')
-			->with('user')
-			->willReturn('BEGIN:VCALENDAR
+    protected ITimeFactory&MockObject $time;
+    protected IJobList&MockObject $jobList;
+    protected LoggerInterface&MockObject $logger;
+    protected IManager&MockObject $statusManager;
+    protected IConfig&MockObject $config;
+    private IAvailabilityCoordinator&MockObject $coordinator;
+    private IUserManager&MockObject $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->time = $this->createMock(ITimeFactory::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->statusManager = $this->createMock(IManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->coordinator = $this->createMock(IAvailabilityCoordinator::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+
+    }
+
+    protected function getAutomationMock(array $methods): MockObject|UserStatusAutomation {
+        if (empty($methods)) {
+            return new UserStatusAutomation(
+                $this->time,
+                Server::get(IDBConnection::class),
+                $this->jobList,
+                $this->logger,
+                $this->statusManager,
+                $this->config,
+                $this->coordinator,
+                $this->userManager,
+            );
+        }
+
+        return $this->getMockBuilder(UserStatusAutomation::class)
+            ->setConstructorArgs([
+                $this->time,
+                Server::get(IDBConnection::class),
+                $this->jobList,
+                $this->logger,
+                $this->statusManager,
+                $this->config,
+                $this->coordinator,
+                $this->userManager,
+            ])
+            ->onlyMethods($methods)
+            ->getMock();
+    }
+
+    public static function dataRun(): array {
+        return [
+            ['20230217', '2023-02-24 10:49:36.613834', true],
+            ['20230224', '2023-02-24 10:49:36.613834', true],
+            ['20230217', '2023-02-24 13:58:24.479357', false],
+            ['20230224', '2023-02-24 13:58:24.479357', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataRun')]
+    public function testRunNoOOO(string $ruleDay, string $currentTime, bool $isAvailable): void {
+        $user = $this->createConfiguredMock(IUser::class, [
+            'getUID' => 'user'
+        ]);
+
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->willReturn($user);
+        $this->coordinator->expects(self::once())
+            ->method('getCurrentOutOfOfficeData')
+            ->willReturn(null);
+        $this->config->method('getUserValue')
+            ->with('user', 'dav', 'user_status_automation', 'no')
+            ->willReturn('yes');
+        $this->time->method('getDateTime')
+            ->willReturn(new \DateTime($currentTime, new \DateTimeZone('UTC')));
+        $this->logger->expects(self::exactly(4))
+            ->method('debug');
+        if (!$isAvailable) {
+            $this->statusManager->expects(self::once())
+                ->method('setUserStatus')
+                ->with('user', IUserStatus::MESSAGE_AVAILABILITY, IUserStatus::DND, true);
+        }
+        $automation = $this->getAutomationMock(['getAvailabilityFromPropertiesTable']);
+        $automation->method('getAvailabilityFromPropertiesTable')
+            ->with('user')
+            ->willReturn('BEGIN:VCALENDAR
 PRODID:Nextcloud DAV app
 BEGIN:VTIMEZONE
 TZID:Europe/Berlin
@@ -150,71 +150,71 @@ 
 END:VAVAILABILITY
 END:VCALENDAR');
 
-		self::invokePrivate($automation, 'run', [['userId' => 'user']]);
-	}
-
-	public function testRunNoAvailabilityNoOOO(): void {
-		$user = $this->createConfiguredMock(IUser::class, [
-			'getUID' => 'user'
-		]);
-
-		$this->userManager->expects(self::once())
-			->method('get')
-			->willReturn($user);
-		$this->coordinator->expects(self::once())
-			->method('getCurrentOutOfOfficeData')
-			->willReturn(null);
-		$this->config->method('getUserValue')
-			->with('user', 'dav', 'user_status_automation', 'no')
-			->willReturn('yes');
-		$this->time->method('getDateTime')
-			->willReturn(new \DateTime('2023-02-24 13:58:24.479357', new \DateTimeZone('UTC')));
-		$this->jobList->expects($this->once())
-			->method('remove')
-			->with(UserStatusAutomation::class, ['userId' => 'user']);
-		$this->logger->expects(self::once())
-			->method('debug');
-		$this->logger->expects(self::once())
-			->method('info');
-		$automation = $this->getAutomationMock(['getAvailabilityFromPropertiesTable']);
-		$automation->method('getAvailabilityFromPropertiesTable')
-			->with('user')
-			->willReturn(false);
-
-		self::invokePrivate($automation, 'run', [['userId' => 'user']]);
-	}
-
-	public function testRunNoAvailabilityWithOOO(): void {
-		$user = $this->createConfiguredMock(IUser::class, [
-			'getUID' => 'user'
-		]);
-		$ooo = $this->createConfiguredMock(OutOfOfficeData::class, [
-			'getShortMessage' => 'On Vacation',
-			'getEndDate' => 123456,
-		]);
-
-		$this->userManager->expects(self::once())
-			->method('get')
-			->willReturn($user);
-		$this->coordinator->expects(self::once())
-			->method('getCurrentOutOfOfficeData')
-			->willReturn($ooo);
-		$this->coordinator->expects(self::once())
-			->method('isInEffect')
-			->willReturn(true);
-		$this->statusManager->expects(self::once())
-			->method('setUserStatus')
-			->with('user', IUserStatus::MESSAGE_OUT_OF_OFFICE, IUserStatus::DND, true, $ooo->getShortMessage());
-		$this->config->expects(self::never())
-			->method('getUserValue');
-		$this->time->method('getDateTime')
-			->willReturn(new \DateTime('2023-02-24 13:58:24.479357', new \DateTimeZone('UTC')));
-		$this->jobList->expects($this->never())
-			->method('remove');
-		$this->logger->expects(self::exactly(2))
-			->method('debug');
-		$automation = $this->getAutomationMock([]);
-
-		self::invokePrivate($automation, 'run', [['userId' => 'user']]);
-	}
+        self::invokePrivate($automation, 'run', [['userId' => 'user']]);
+    }
+
+    public function testRunNoAvailabilityNoOOO(): void {
+        $user = $this->createConfiguredMock(IUser::class, [
+            'getUID' => 'user'
+        ]);
+
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->willReturn($user);
+        $this->coordinator->expects(self::once())
+            ->method('getCurrentOutOfOfficeData')
+            ->willReturn(null);
+        $this->config->method('getUserValue')
+            ->with('user', 'dav', 'user_status_automation', 'no')
+            ->willReturn('yes');
+        $this->time->method('getDateTime')
+            ->willReturn(new \DateTime('2023-02-24 13:58:24.479357', new \DateTimeZone('UTC')));
+        $this->jobList->expects($this->once())
+            ->method('remove')
+            ->with(UserStatusAutomation::class, ['userId' => 'user']);
+        $this->logger->expects(self::once())
+            ->method('debug');
+        $this->logger->expects(self::once())
+            ->method('info');
+        $automation = $this->getAutomationMock(['getAvailabilityFromPropertiesTable']);
+        $automation->method('getAvailabilityFromPropertiesTable')
+            ->with('user')
+            ->willReturn(false);
+
+        self::invokePrivate($automation, 'run', [['userId' => 'user']]);
+    }
+
+    public function testRunNoAvailabilityWithOOO(): void {
+        $user = $this->createConfiguredMock(IUser::class, [
+            'getUID' => 'user'
+        ]);
+        $ooo = $this->createConfiguredMock(OutOfOfficeData::class, [
+            'getShortMessage' => 'On Vacation',
+            'getEndDate' => 123456,
+        ]);
+
+        $this->userManager->expects(self::once())
+            ->method('get')
+            ->willReturn($user);
+        $this->coordinator->expects(self::once())
+            ->method('getCurrentOutOfOfficeData')
+            ->willReturn($ooo);
+        $this->coordinator->expects(self::once())
+            ->method('isInEffect')
+            ->willReturn(true);
+        $this->statusManager->expects(self::once())
+            ->method('setUserStatus')
+            ->with('user', IUserStatus::MESSAGE_OUT_OF_OFFICE, IUserStatus::DND, true, $ooo->getShortMessage());
+        $this->config->expects(self::never())
+            ->method('getUserValue');
+        $this->time->method('getDateTime')
+            ->willReturn(new \DateTime('2023-02-24 13:58:24.479357', new \DateTimeZone('UTC')));
+        $this->jobList->expects($this->never())
+            ->method('remove');
+        $this->logger->expects(self::exactly(2))
+            ->method('debug');
+        $automation = $this->getAutomationMock([]);
+
+        self::invokePrivate($automation, 'run', [['userId' => 'user']]);
+    }
 }

apps/dav/tests/unit/BackgroundJob/PruneOutdatedSyncTokensJobTest.php

Indentation +53 added lines, -53 removed lines

@@ -20,63 +20,63 @@
 use Test\TestCase;
 
 class PruneOutdatedSyncTokensJobTest extends TestCase {
-	private ITimeFactory&MockObject $timeFactory;
-	private CalDavBackend&MockObject $calDavBackend;
-	private CardDavBackend&MockObject $cardDavBackend;
-	private IConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private PruneOutdatedSyncTokensJob $backgroundJob;
+    private ITimeFactory&MockObject $timeFactory;
+    private CalDavBackend&MockObject $calDavBackend;
+    private CardDavBackend&MockObject $cardDavBackend;
+    private IConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private PruneOutdatedSyncTokensJob $backgroundJob;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->calDavBackend = $this->createMock(CalDavBackend::class);
-		$this->cardDavBackend = $this->createMock(CardDavBackend::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->calDavBackend = $this->createMock(CalDavBackend::class);
+        $this->cardDavBackend = $this->createMock(CardDavBackend::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
 
-		$this->backgroundJob = new PruneOutdatedSyncTokensJob($this->timeFactory, $this->calDavBackend, $this->cardDavBackend, $this->config, $this->logger);
-	}
+        $this->backgroundJob = new PruneOutdatedSyncTokensJob($this->timeFactory, $this->calDavBackend, $this->cardDavBackend, $this->config, $this->logger);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataForTestRun')]
-	public function testRun(string $configToKeep, string $configRetentionDays, int $actualLimit, int $retentionDays, int $deletedCalendarSyncTokens, int $deletedAddressBookSyncTokens): void {
-		$this->config->expects($this->exactly(2))
-			->method('getAppValue')
-			->with(Application::APP_ID, self::anything(), self::anything())
-			->willReturnCallback(function ($app, $key) use ($configToKeep, $configRetentionDays) {
-				switch ($key) {
-					case 'totalNumberOfSyncTokensToKeep':
-						return $configToKeep;
-					case 'syncTokensRetentionDays':
-						return $configRetentionDays;
-					default:
-						throw new InvalidArgumentException();
-				}
-			});
-		$this->calDavBackend->expects($this->once())
-			->method('pruneOutdatedSyncTokens')
-			->with($actualLimit)
-			->willReturn($deletedCalendarSyncTokens);
-		$this->cardDavBackend->expects($this->once())
-			->method('pruneOutdatedSyncTokens')
-			->with($actualLimit, $retentionDays)
-			->willReturn($deletedAddressBookSyncTokens);
-		$this->logger->expects($this->once())
-			->method('info')
-			->with('Pruned {calendarSyncTokensNumber} calendar sync tokens and {addressBooksSyncTokensNumber} address book sync tokens', [
-				'calendarSyncTokensNumber' => $deletedCalendarSyncTokens,
-				'addressBooksSyncTokensNumber' => $deletedAddressBookSyncTokens
-			]);
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataForTestRun')]
+    public function testRun(string $configToKeep, string $configRetentionDays, int $actualLimit, int $retentionDays, int $deletedCalendarSyncTokens, int $deletedAddressBookSyncTokens): void {
+        $this->config->expects($this->exactly(2))
+            ->method('getAppValue')
+            ->with(Application::APP_ID, self::anything(), self::anything())
+            ->willReturnCallback(function ($app, $key) use ($configToKeep, $configRetentionDays) {
+                switch ($key) {
+                    case 'totalNumberOfSyncTokensToKeep':
+                        return $configToKeep;
+                    case 'syncTokensRetentionDays':
+                        return $configRetentionDays;
+                    default:
+                        throw new InvalidArgumentException();
+                }
+            });
+        $this->calDavBackend->expects($this->once())
+            ->method('pruneOutdatedSyncTokens')
+            ->with($actualLimit)
+            ->willReturn($deletedCalendarSyncTokens);
+        $this->cardDavBackend->expects($this->once())
+            ->method('pruneOutdatedSyncTokens')
+            ->with($actualLimit, $retentionDays)
+            ->willReturn($deletedAddressBookSyncTokens);
+        $this->logger->expects($this->once())
+            ->method('info')
+            ->with('Pruned {calendarSyncTokensNumber} calendar sync tokens and {addressBooksSyncTokensNumber} address book sync tokens', [
+                'calendarSyncTokensNumber' => $deletedCalendarSyncTokens,
+                'addressBooksSyncTokensNumber' => $deletedAddressBookSyncTokens
+            ]);
 
-		$this->backgroundJob->run(null);
-	}
+        $this->backgroundJob->run(null);
+    }
 
-	public static function dataForTestRun(): array {
-		return [
-			['100', '2', 100, 7 * 24 * 3600, 2, 3],
-			['100', '14', 100, 14 * 24 * 3600, 2, 3],
-			['0', '60', 1, 60 * 24 * 3600, 0, 0]
-		];
-	}
+    public static function dataForTestRun(): array {
+        return [
+            ['100', '2', 100, 7 * 24 * 3600, 2, 3],
+            ['100', '14', 100, 14 * 24 * 3600, 2, 3],
+            ['0', '60', 1, 60 * 24 * 3600, 0, 0]
+        ];
+    }
 }

apps/dav/tests/unit/BackgroundJob/EventReminderJobTest.php

Indentation +46 added lines, -46 removed lines

@@ -16,57 +16,57 @@
 use Test\TestCase;
 
 class EventReminderJobTest extends TestCase {
-	private ITimeFactory&MockObject $time;
-	private ReminderService&MockObject $reminderService;
-	private IConfig&MockObject $config;
-	private EventReminderJob $backgroundJob;
+    private ITimeFactory&MockObject $time;
+    private ReminderService&MockObject $reminderService;
+    private IConfig&MockObject $config;
+    private EventReminderJob $backgroundJob;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->time = $this->createMock(ITimeFactory::class);
-		$this->reminderService = $this->createMock(ReminderService::class);
-		$this->config = $this->createMock(IConfig::class);
+        $this->time = $this->createMock(ITimeFactory::class);
+        $this->reminderService = $this->createMock(ReminderService::class);
+        $this->config = $this->createMock(IConfig::class);
 
-		$this->backgroundJob = new EventReminderJob(
-			$this->time,
-			$this->reminderService,
-			$this->config,
-		);
-	}
+        $this->backgroundJob = new EventReminderJob(
+            $this->time,
+            $this->reminderService,
+            $this->config,
+        );
+    }
 
-	public static function data(): array {
-		return [
-			[true, true, true],
-			[true, false, false],
-			[false, true, false],
-			[false, false, false],
-		];
-	}
+    public static function data(): array {
+        return [
+            [true, true, true],
+            [true, false, false],
+            [false, true, false],
+            [false, false, false],
+        ];
+    }
 
-	/**
-	 *
-	 * @param bool $sendEventReminders
-	 * @param bool $sendEventRemindersMode
-	 * @param bool $expectCall
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('data')]
-	public function testRun(bool $sendEventReminders, bool $sendEventRemindersMode, bool $expectCall): void {
-		$this->config->expects($this->exactly($sendEventReminders ? 2 : 1))
-			->method('getAppValue')
-			->willReturnMap([
-				['dav', 'sendEventReminders', 'yes', ($sendEventReminders ? 'yes' : 'no')],
-				['dav', 'sendEventRemindersMode', 'backgroundjob', ($sendEventRemindersMode ? 'backgroundjob' : 'cron')],
-			]);
+    /**
+     *
+     * @param bool $sendEventReminders
+     * @param bool $sendEventRemindersMode
+     * @param bool $expectCall
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('data')]
+    public function testRun(bool $sendEventReminders, bool $sendEventRemindersMode, bool $expectCall): void {
+        $this->config->expects($this->exactly($sendEventReminders ? 2 : 1))
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['dav', 'sendEventReminders', 'yes', ($sendEventReminders ? 'yes' : 'no')],
+                ['dav', 'sendEventRemindersMode', 'backgroundjob', ($sendEventRemindersMode ? 'backgroundjob' : 'cron')],
+            ]);
 
-		if ($expectCall) {
-			$this->reminderService->expects($this->once())
-				->method('processReminders');
-		} else {
-			$this->reminderService->expects($this->never())
-				->method('processReminders');
-		}
+        if ($expectCall) {
+            $this->reminderService->expects($this->once())
+                ->method('processReminders');
+        } else {
+            $this->reminderService->expects($this->never())
+                ->method('processReminders');
+        }
 
-		$this->backgroundJob->run([]);
-	}
+        $this->backgroundJob->run([]);
+    }
 }

apps/dav/tests/unit/BackgroundJob/RefreshWebcalJobTest.php

Indentation +74 added lines, -74 removed lines

@@ -19,78 +19,78 @@
 use Test\TestCase;
 
 class RefreshWebcalJobTest extends TestCase {
-	private RefreshWebcalService&MockObject $refreshWebcalService;
-	private IConfig&MockObject $config;
-	private LoggerInterface $logger;
-	private ITimeFactory&MockObject $timeFactory;
-	private IJobList&MockObject $jobList;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-
-		$this->jobList = $this->createMock(IJobList::class);
-	}
-
-	/**
-	 *
-	 * @param int $lastRun
-	 * @param int $time
-	 * @param bool $process
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
-	public function testRun(int $lastRun, int $time, bool $process): void {
-		$backgroundJob = new RefreshWebcalJob($this->refreshWebcalService, $this->config, $this->logger, $this->timeFactory);
-		$backgroundJob->setId(42);
-
-		$backgroundJob->setArgument([
-			'principaluri' => 'principals/users/testuser',
-			'uri' => 'sub123',
-		]);
-		$backgroundJob->setLastRun($lastRun);
-
-		$this->refreshWebcalService->expects($this->once())
-			->method('getSubscription')
-			->with('principals/users/testuser', 'sub123')
-			->willReturn([
-				'id' => '99',
-				'uri' => 'sub456',
-				'{http://apple.com/ns/ical/}refreshrate' => 'P1D',
-				'{http://calendarserver.org/ns/}subscribed-strip-todos' => '1',
-				'{http://calendarserver.org/ns/}subscribed-strip-alarms' => '1',
-				'{http://calendarserver.org/ns/}subscribed-strip-attachments' => '1',
-				'source' => 'webcal://foo.bar/bla'
-			]);
-
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('dav', 'calendarSubscriptionRefreshRate', 'P1D')
-			->willReturn('P1W');
-
-		$this->timeFactory->method('getTime')
-			->willReturn($time);
-
-		if ($process) {
-			$this->refreshWebcalService->expects($this->once())
-				->method('refreshSubscription')
-				->with('principals/users/testuser', 'sub123');
-		} else {
-			$this->refreshWebcalService->expects($this->never())
-				->method('refreshSubscription')
-				->with('principals/users/testuser', 'sub123');
-		}
-
-		$backgroundJob->start($this->jobList);
-	}
-
-	public static function runDataProvider():array {
-		return [
-			[0, 100000, true],
-			[100000, 100000, false]
-		];
-	}
+    private RefreshWebcalService&MockObject $refreshWebcalService;
+    private IConfig&MockObject $config;
+    private LoggerInterface $logger;
+    private ITimeFactory&MockObject $timeFactory;
+    private IJobList&MockObject $jobList;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->refreshWebcalService = $this->createMock(RefreshWebcalService::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+
+        $this->jobList = $this->createMock(IJobList::class);
+    }
+
+    /**
+     *
+     * @param int $lastRun
+     * @param int $time
+     * @param bool $process
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
+    public function testRun(int $lastRun, int $time, bool $process): void {
+        $backgroundJob = new RefreshWebcalJob($this->refreshWebcalService, $this->config, $this->logger, $this->timeFactory);
+        $backgroundJob->setId(42);
+
+        $backgroundJob->setArgument([
+            'principaluri' => 'principals/users/testuser',
+            'uri' => 'sub123',
+        ]);
+        $backgroundJob->setLastRun($lastRun);
+
+        $this->refreshWebcalService->expects($this->once())
+            ->method('getSubscription')
+            ->with('principals/users/testuser', 'sub123')
+            ->willReturn([
+                'id' => '99',
+                'uri' => 'sub456',
+                '{http://apple.com/ns/ical/}refreshrate' => 'P1D',
+                '{http://calendarserver.org/ns/}subscribed-strip-todos' => '1',
+                '{http://calendarserver.org/ns/}subscribed-strip-alarms' => '1',
+                '{http://calendarserver.org/ns/}subscribed-strip-attachments' => '1',
+                'source' => 'webcal://foo.bar/bla'
+            ]);
+
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('dav', 'calendarSubscriptionRefreshRate', 'P1D')
+            ->willReturn('P1W');
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($time);
+
+        if ($process) {
+            $this->refreshWebcalService->expects($this->once())
+                ->method('refreshSubscription')
+                ->with('principals/users/testuser', 'sub123');
+        } else {
+            $this->refreshWebcalService->expects($this->never())
+                ->method('refreshSubscription')
+                ->with('principals/users/testuser', 'sub123');
+        }
+
+        $backgroundJob->start($this->jobList);
+    }
+
+    public static function runDataProvider():array {
+        return [
+            [0, 100000, true],
+            [100000, 100000, false]
+        ];
+    }
 }

apps/dav/tests/unit/Upload/UploadAutoMkcolPluginTest.php

Indentation +109 added lines, -109 removed lines

@@ -21,113 +21,113 @@
 
 class UploadAutoMkcolPluginTest extends TestCase {
 
-	private Tree&MockObject $tree;
-	private RequestInterface&MockObject $request;
-	private ResponseInterface&MockObject $response;
-
-	public static function dataMissingHeaderShouldReturnTrue(): Generator {
-		yield 'missing X-NC-WebDAV-Auto-Mkcol header' => [null];
-		yield 'empty X-NC-WebDAV-Auto-Mkcol header' => [''];
-		yield 'invalid X-NC-WebDAV-Auto-Mkcol header' => ['enable'];
-	}
-
-	public function testBeforeMethodWithRootNodeNotAnICollectionShouldReturnTrue(): void {
-		$this->request->method('getHeader')->willReturn('1');
-		$this->request->expects(self::once())
-			->method('getPath')
-			->willReturn('/non-relevant/path.txt');
-		$this->tree->expects(self::once())
-			->method('nodeExists')
-			->with('/non-relevant')
-			->willReturn(false);
-
-		$mockNode = $this->getMockBuilder(INode::class);
-		$this->tree->expects(self::once())
-			->method('getNodeForPath')
-			->willReturn($mockNode);
-
-		$return = $this->plugin->beforeMethod($this->request, $this->response);
-		$this->assertTrue($return);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataMissingHeaderShouldReturnTrue')]
-	public function testBeforeMethodWithMissingHeaderShouldReturnTrue(?string $header): void {
-		$this->request->expects(self::once())
-			->method('getHeader')
-			->with('X-NC-WebDAV-Auto-Mkcol')
-			->willReturn($header);
-
-		$this->request->expects(self::never())
-			->method('getPath');
-
-		$return = $this->plugin->beforeMethod($this->request, $this->response);
-		self::assertTrue($return);
-	}
-
-	public function testBeforeMethodWithExistingPathShouldReturnTrue(): void {
-		$this->request->method('getHeader')->willReturn('1');
-		$this->request->expects(self::once())
-			->method('getPath')
-			->willReturn('/files/user/deep/image.jpg');
-		$this->tree->expects(self::once())
-			->method('nodeExists')
-			->with('/files/user/deep')
-			->willReturn(true);
-
-		$this->tree->expects(self::never())
-			->method('getNodeForPath');
-
-		$return = $this->plugin->beforeMethod($this->request, $this->response);
-		self::assertTrue($return);
-	}
-
-	public function testBeforeMethodShouldSucceed(): void {
-		$this->request->method('getHeader')->willReturn('1');
-		$this->request->expects(self::once())
-			->method('getPath')
-			->willReturn('/files/user/my/deep/path/image.jpg');
-		$this->tree->expects(self::once())
-			->method('nodeExists')
-			->with('/files/user/my/deep/path')
-			->willReturn(false);
-
-		$mockNode = $this->createMock(ICollection::class);
-		$this->tree->expects(self::once())
-			->method('getNodeForPath')
-			->with('/files')
-			->willReturn($mockNode);
-		$mockNode->expects(self::exactly(4))
-			->method('childExists')
-			->willReturnMap([
-				['user', true],
-				['my', true],
-				['deep', false],
-				['path', false],
-			]);
-		$mockNode->expects(self::exactly(2))
-			->method('createDirectory');
-		$mockNode->expects(self::exactly(4))
-			->method('getChild')
-			->willReturn($mockNode);
-
-		$return = $this->plugin->beforeMethod($this->request, $this->response);
-		self::assertTrue($return);
-	}
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$server = $this->createMock(Server::class);
-		$this->tree = $this->createMock(Tree::class);
-
-		$server->tree = $this->tree;
-		$this->plugin = new UploadAutoMkcolPlugin();
-
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->response = $this->createMock(ResponseInterface::class);
-		$server->httpRequest = $this->request;
-		$server->httpResponse = $this->response;
-
-		$this->plugin->initialize($server);
-	}
+    private Tree&MockObject $tree;
+    private RequestInterface&MockObject $request;
+    private ResponseInterface&MockObject $response;
+
+    public static function dataMissingHeaderShouldReturnTrue(): Generator {
+        yield 'missing X-NC-WebDAV-Auto-Mkcol header' => [null];
+        yield 'empty X-NC-WebDAV-Auto-Mkcol header' => [''];
+        yield 'invalid X-NC-WebDAV-Auto-Mkcol header' => ['enable'];
+    }
+
+    public function testBeforeMethodWithRootNodeNotAnICollectionShouldReturnTrue(): void {
+        $this->request->method('getHeader')->willReturn('1');
+        $this->request->expects(self::once())
+            ->method('getPath')
+            ->willReturn('/non-relevant/path.txt');
+        $this->tree->expects(self::once())
+            ->method('nodeExists')
+            ->with('/non-relevant')
+            ->willReturn(false);
+
+        $mockNode = $this->getMockBuilder(INode::class);
+        $this->tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->willReturn($mockNode);
+
+        $return = $this->plugin->beforeMethod($this->request, $this->response);
+        $this->assertTrue($return);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataMissingHeaderShouldReturnTrue')]
+    public function testBeforeMethodWithMissingHeaderShouldReturnTrue(?string $header): void {
+        $this->request->expects(self::once())
+            ->method('getHeader')
+            ->with('X-NC-WebDAV-Auto-Mkcol')
+            ->willReturn($header);
+
+        $this->request->expects(self::never())
+            ->method('getPath');
+
+        $return = $this->plugin->beforeMethod($this->request, $this->response);
+        self::assertTrue($return);
+    }
+
+    public function testBeforeMethodWithExistingPathShouldReturnTrue(): void {
+        $this->request->method('getHeader')->willReturn('1');
+        $this->request->expects(self::once())
+            ->method('getPath')
+            ->willReturn('/files/user/deep/image.jpg');
+        $this->tree->expects(self::once())
+            ->method('nodeExists')
+            ->with('/files/user/deep')
+            ->willReturn(true);
+
+        $this->tree->expects(self::never())
+            ->method('getNodeForPath');
+
+        $return = $this->plugin->beforeMethod($this->request, $this->response);
+        self::assertTrue($return);
+    }
+
+    public function testBeforeMethodShouldSucceed(): void {
+        $this->request->method('getHeader')->willReturn('1');
+        $this->request->expects(self::once())
+            ->method('getPath')
+            ->willReturn('/files/user/my/deep/path/image.jpg');
+        $this->tree->expects(self::once())
+            ->method('nodeExists')
+            ->with('/files/user/my/deep/path')
+            ->willReturn(false);
+
+        $mockNode = $this->createMock(ICollection::class);
+        $this->tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->with('/files')
+            ->willReturn($mockNode);
+        $mockNode->expects(self::exactly(4))
+            ->method('childExists')
+            ->willReturnMap([
+                ['user', true],
+                ['my', true],
+                ['deep', false],
+                ['path', false],
+            ]);
+        $mockNode->expects(self::exactly(2))
+            ->method('createDirectory');
+        $mockNode->expects(self::exactly(4))
+            ->method('getChild')
+            ->willReturn($mockNode);
+
+        $return = $this->plugin->beforeMethod($this->request, $this->response);
+        self::assertTrue($return);
+    }
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $server = $this->createMock(Server::class);
+        $this->tree = $this->createMock(Tree::class);
+
+        $server->tree = $this->tree;
+        $this->plugin = new UploadAutoMkcolPlugin();
+
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->response = $this->createMock(ResponseInterface::class);
+        $server->httpRequest = $this->request;
+        $server->httpResponse = $this->response;
+
+        $this->plugin->initialize($server);
+    }
 }

apps/dav/tests/unit/Upload/AssemblyStreamTest.php

Indentation +151 added lines, -151 removed lines

@@ -12,155 +12,155 @@
 
 class AssemblyStreamTest extends \Test\TestCase {
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
-	public function testGetContents(string $expected, array $nodeData): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-		$stream = AssemblyStream::wrap($nodes);
-		$content = stream_get_contents($stream);
-
-		$this->assertEquals($expected, $content);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
-	public function testGetContentsFread(string $expected, array $nodeData, int $chunkLength = 3): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-		$stream = AssemblyStream::wrap($nodes);
-
-		$content = '';
-		while (!feof($stream)) {
-			$chunk = fread($stream, $chunkLength);
-			$content .= $chunk;
-			if ($chunkLength !== 3) {
-				$this->assertEquals($chunkLength, strlen($chunk));
-			}
-		}
-
-		$this->assertEquals($expected, $content);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
-	public function testSeek(string $expected, array $nodeData): void {
-		$nodes = [];
-		foreach ($nodeData as $data) {
-			$nodes[] = $this->buildNode(...$data);
-		}
-
-		$stream = AssemblyStream::wrap($nodes);
-
-		$offset = floor(strlen($expected) * 0.6);
-		if (fseek($stream, $offset) === -1) {
-			$this->fail('fseek failed');
-		}
-
-		$content = stream_get_contents($stream);
-		$this->assertEquals(substr($expected, $offset), $content);
-	}
-
-	public static function providesNodes(): array {
-		$data8k = self::makeData(8192);
-		$dataLess8k = self::makeData(8191);
-
-		$tonofnodes = [];
-		$tonofdata = '';
-		for ($i = 0; $i < 101; $i++) {
-			$thisdata = random_int(0, 100); // variable length and content
-			$tonofdata .= $thisdata;
-			$tonofnodes[] = [(string)$i, (string)$thisdata];
-		}
-
-		return[
-			'one node zero bytes' => [
-				'', [
-					['0', ''],
-				]],
-			'one node only' => [
-				'1234567890', [
-					['0', '1234567890'],
-				]],
-			'one node buffer boundary' => [
-				$data8k, [
-					['0', $data8k],
-				]],
-			'two nodes' => [
-				'1234567890', [
-					['1', '67890'],
-					['0', '12345'],
-				]],
-			'two nodes end on buffer boundary' => [
-				$data8k . $data8k, [
-					['1', $data8k],
-					['0', $data8k],
-				]],
-			'two nodes with one on buffer boundary' => [
-				$data8k . $dataLess8k, [
-					['1', $dataLess8k],
-					['0', $data8k],
-				]],
-			'two nodes on buffer boundary plus one byte' => [
-				$data8k . 'X' . $data8k, [
-					['1', $data8k],
-					['0', $data8k . 'X'],
-				]],
-			'two nodes on buffer boundary plus one byte at the end' => [
-				$data8k . $data8k . 'X', [
-					['1', $data8k . 'X'],
-					['0', $data8k],
-				]],
-			'a ton of nodes' => [
-				$tonofdata, $tonofnodes
-			],
-			'one read over multiple nodes' => [
-				'1234567890', [
-					['0', '1234'],
-					['1', '5678'],
-					['2', '90'],
-				], 10],
-			'two reads over multiple nodes' => [
-				'1234567890', [
-					['0', '1234'],
-					['1', '5678'],
-					['2', '90'],
-				], 5],
-		];
-	}
-
-	private static function makeData(int $count): string {
-		$data = '';
-		$base = '1234567890';
-		$j = 0;
-		for ($i = 0; $i < $count; $i++) {
-			$data .= $base[$j];
-			$j++;
-			if (!isset($base[$j])) {
-				$j = 0;
-			}
-		}
-		return $data;
-	}
-
-	private function buildNode(string $name, string $data) {
-		$node = $this->getMockBuilder(File::class)
-			->onlyMethods(['getName', 'get', 'getSize'])
-			->getMock();
-
-		$node->expects($this->any())
-			->method('getName')
-			->willReturn($name);
-
-		$node->expects($this->any())
-			->method('get')
-			->willReturn($data);
-
-		$node->expects($this->any())
-			->method('getSize')
-			->willReturn(strlen($data));
-
-		return $node;
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
+    public function testGetContents(string $expected, array $nodeData): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+        $stream = AssemblyStream::wrap($nodes);
+        $content = stream_get_contents($stream);
+
+        $this->assertEquals($expected, $content);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
+    public function testGetContentsFread(string $expected, array $nodeData, int $chunkLength = 3): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+        $stream = AssemblyStream::wrap($nodes);
+
+        $content = '';
+        while (!feof($stream)) {
+            $chunk = fread($stream, $chunkLength);
+            $content .= $chunk;
+            if ($chunkLength !== 3) {
+                $this->assertEquals($chunkLength, strlen($chunk));
+            }
+        }
+
+        $this->assertEquals($expected, $content);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesNodes')]
+    public function testSeek(string $expected, array $nodeData): void {
+        $nodes = [];
+        foreach ($nodeData as $data) {
+            $nodes[] = $this->buildNode(...$data);
+        }
+
+        $stream = AssemblyStream::wrap($nodes);
+
+        $offset = floor(strlen($expected) * 0.6);
+        if (fseek($stream, $offset) === -1) {
+            $this->fail('fseek failed');
+        }
+
+        $content = stream_get_contents($stream);
+        $this->assertEquals(substr($expected, $offset), $content);
+    }
+
+    public static function providesNodes(): array {
+        $data8k = self::makeData(8192);
+        $dataLess8k = self::makeData(8191);
+
+        $tonofnodes = [];
+        $tonofdata = '';
+        for ($i = 0; $i < 101; $i++) {
+            $thisdata = random_int(0, 100); // variable length and content
+            $tonofdata .= $thisdata;
+            $tonofnodes[] = [(string)$i, (string)$thisdata];
+        }
+
+        return[
+            'one node zero bytes' => [
+                '', [
+                    ['0', ''],
+                ]],
+            'one node only' => [
+                '1234567890', [
+                    ['0', '1234567890'],
+                ]],
+            'one node buffer boundary' => [
+                $data8k, [
+                    ['0', $data8k],
+                ]],
+            'two nodes' => [
+                '1234567890', [
+                    ['1', '67890'],
+                    ['0', '12345'],
+                ]],
+            'two nodes end on buffer boundary' => [
+                $data8k . $data8k, [
+                    ['1', $data8k],
+                    ['0', $data8k],
+                ]],
+            'two nodes with one on buffer boundary' => [
+                $data8k . $dataLess8k, [
+                    ['1', $dataLess8k],
+                    ['0', $data8k],
+                ]],
+            'two nodes on buffer boundary plus one byte' => [
+                $data8k . 'X' . $data8k, [
+                    ['1', $data8k],
+                    ['0', $data8k . 'X'],
+                ]],
+            'two nodes on buffer boundary plus one byte at the end' => [
+                $data8k . $data8k . 'X', [
+                    ['1', $data8k . 'X'],
+                    ['0', $data8k],
+                ]],
+            'a ton of nodes' => [
+                $tonofdata, $tonofnodes
+            ],
+            'one read over multiple nodes' => [
+                '1234567890', [
+                    ['0', '1234'],
+                    ['1', '5678'],
+                    ['2', '90'],
+                ], 10],
+            'two reads over multiple nodes' => [
+                '1234567890', [
+                    ['0', '1234'],
+                    ['1', '5678'],
+                    ['2', '90'],
+                ], 5],
+        ];
+    }
+
+    private static function makeData(int $count): string {
+        $data = '';
+        $base = '1234567890';
+        $j = 0;
+        for ($i = 0; $i < $count; $i++) {
+            $data .= $base[$j];
+            $j++;
+            if (!isset($base[$j])) {
+                $j = 0;
+            }
+        }
+        return $data;
+    }
+
+    private function buildNode(string $name, string $data) {
+        $node = $this->getMockBuilder(File::class)
+            ->onlyMethods(['getName', 'get', 'getSize'])
+            ->getMock();
+
+        $node->expects($this->any())
+            ->method('getName')
+            ->willReturn($name);
+
+        $node->expects($this->any())
+            ->method('get')
+            ->willReturn($data);
+
+        $node->expects($this->any())
+            ->method('getSize')
+            ->willReturn(strlen($data));
+
+        return $node;
+    }
 }