nextcloud / server

apps/dav/tests/unit/CalDAV/Activity/Provider/EventTest.php

Indentation +157 added lines, -157 removed lines

@@ -21,170 +21,170 @@
 use TypeError;
 
 class EventTest extends TestCase {
-	protected IUserManager&MockObject $userManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IURLGenerator&MockObject $url;
-	protected IAppManager&MockObject $appManager;
-	protected IFactory&MockObject $i10nFactory;
-	protected IManager&MockObject $activityManager;
-	protected IEventMerger&MockObject $eventMerger;
-	protected Event&MockObject $provider;
+    protected IUserManager&MockObject $userManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IURLGenerator&MockObject $url;
+    protected IAppManager&MockObject $appManager;
+    protected IFactory&MockObject $i10nFactory;
+    protected IManager&MockObject $activityManager;
+    protected IEventMerger&MockObject $eventMerger;
+    protected Event&MockObject $provider;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->i10nFactory = $this->createMock(IFactory::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->activityManager = $this->createMock(IManager::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->eventMerger = $this->createMock(IEventMerger::class);
-		$this->provider = $this->getMockBuilder(Event::class)
-			->setConstructorArgs([
-				$this->i10nFactory,
-				$this->url,
-				$this->activityManager,
-				$this->userManager,
-				$this->groupManager,
-				$this->eventMerger,
-				$this->appManager
-			])
-			->onlyMethods(['parse'])
-			->getMock();
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->i10nFactory = $this->createMock(IFactory::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->activityManager = $this->createMock(IManager::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->eventMerger = $this->createMock(IEventMerger::class);
+        $this->provider = $this->getMockBuilder(Event::class)
+            ->setConstructorArgs([
+                $this->i10nFactory,
+                $this->url,
+                $this->activityManager,
+                $this->userManager,
+                $this->groupManager,
+                $this->eventMerger,
+                $this->appManager
+            ])
+            ->onlyMethods(['parse'])
+            ->getMock();
+    }
 
-	public static function dataGenerateObjectParameter(): array {
-		$link = [
-			'object_uri' => 'someuuid.ics',
-			'calendar_uri' => 'personal',
-			'owner' => 'someuser'
-		];
+    public static function dataGenerateObjectParameter(): array {
+        $link = [
+            'object_uri' => 'someuuid.ics',
+            'calendar_uri' => 'personal',
+            'owner' => 'someuser'
+        ];
 
-		return [
-			[23, 'c1', $link, true],
-			[23, 'c1', $link, false],
-			[42, 'c2', null],
-		];
-	}
+        return [
+            [23, 'c1', $link, true],
+            [23, 'c1', $link, false],
+            [42, 'c2', null],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateObjectParameter')]
-	public function testGenerateObjectParameter(int $id, string $name, ?array $link, bool $calendarAppEnabled = true): void {
-		$affectedUser = 'otheruser';
-		if ($link) {
-			$affectedUser = $link['owner'];
-			$generatedLink = [
-				'objectId' => base64_encode('/remote.php/dav/calendars/' . $link['owner'] . '/' . $link['calendar_uri'] . '/' . $link['object_uri']),
-			];
-			$this->appManager->expects($this->once())
-				->method('isEnabledForUser')
-				->with('calendar')
-				->willReturn($calendarAppEnabled);
-			if ($calendarAppEnabled) {
-				$this->url->expects($this->once())
-					->method('getWebroot');
-				$this->url->expects($this->once())
-					->method('linkToRouteAbsolute')
-					->with('calendar.view.indexdirect.edit', $generatedLink)
-					->willReturn('fullLink');
-			}
-		}
-		$objectParameter = ['id' => $id, 'name' => $name];
-		if ($link) {
-			$objectParameter['link'] = $link;
-		}
-		$result = [
-			'type' => 'calendar-event',
-			'id' => $id,
-			'name' => $name,
-		];
-		if ($link && $calendarAppEnabled) {
-			$result['link'] = 'fullLink';
-		}
-		$this->assertEquals($result, $this->invokePrivate($this->provider, 'generateObjectParameter', [$objectParameter, $affectedUser]));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateObjectParameter')]
+    public function testGenerateObjectParameter(int $id, string $name, ?array $link, bool $calendarAppEnabled = true): void {
+        $affectedUser = 'otheruser';
+        if ($link) {
+            $affectedUser = $link['owner'];
+            $generatedLink = [
+                'objectId' => base64_encode('/remote.php/dav/calendars/' . $link['owner'] . '/' . $link['calendar_uri'] . '/' . $link['object_uri']),
+            ];
+            $this->appManager->expects($this->once())
+                ->method('isEnabledForUser')
+                ->with('calendar')
+                ->willReturn($calendarAppEnabled);
+            if ($calendarAppEnabled) {
+                $this->url->expects($this->once())
+                    ->method('getWebroot');
+                $this->url->expects($this->once())
+                    ->method('linkToRouteAbsolute')
+                    ->with('calendar.view.indexdirect.edit', $generatedLink)
+                    ->willReturn('fullLink');
+            }
+        }
+        $objectParameter = ['id' => $id, 'name' => $name];
+        if ($link) {
+            $objectParameter['link'] = $link;
+        }
+        $result = [
+            'type' => 'calendar-event',
+            'id' => $id,
+            'name' => $name,
+        ];
+        if ($link && $calendarAppEnabled) {
+            $result['link'] = 'fullLink';
+        }
+        $this->assertEquals($result, $this->invokePrivate($this->provider, 'generateObjectParameter', [$objectParameter, $affectedUser]));
+    }
 
-	public static function generateObjectParameterLinkEncodingDataProvider(): array {
-		return [
-			[ // Shared calendar
-				[
-					'object_uri' => 'someuuid.ics',
-					'calendar_uri' => 'personal',
-					'owner' => 'sharer'
-				],
-				base64_encode('/remote.php/dav/calendars/sharee/personal_shared_by_sharer/someuuid.ics'),
-			],
-			[ // Shared calendar with umlauts
-				[
-					'object_uri' => 'someuuid.ics',
-					'calendar_uri' => 'umlaut_äüöß',
-					'owner' => 'sharer'
-				],
-				base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
-			],
-			[ // Shared calendar with umlauts and mixed casing
-				[
-					'object_uri' => 'someuuid.ics',
-					'calendar_uri' => 'Umlaut_äüöß',
-					'owner' => 'sharer'
-				],
-				base64_encode('/remote.php/dav/calendars/sharee/Umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
-			],
-			[ // Owned calendar with umlauts
-				[
-					'object_uri' => 'someuuid.ics',
-					'calendar_uri' => 'umlaut_äüöß',
-					'owner' => 'sharee'
-				],
-				base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f/someuuid.ics'),
-			],
-			[ // Owned calendar with umlauts and mixed casing
-				[
-					'object_uri' => 'someuuid.ics',
-					'calendar_uri' => 'Umlaut_äüöß',
-					'owner' => 'sharee'
-				],
-				base64_encode('/remote.php/dav/calendars/sharee/Umlaut_%c3%a4%c3%bc%c3%b6%c3%9f/someuuid.ics'),
-			],
-		];
-	}
+    public static function generateObjectParameterLinkEncodingDataProvider(): array {
+        return [
+            [ // Shared calendar
+                [
+                    'object_uri' => 'someuuid.ics',
+                    'calendar_uri' => 'personal',
+                    'owner' => 'sharer'
+                ],
+                base64_encode('/remote.php/dav/calendars/sharee/personal_shared_by_sharer/someuuid.ics'),
+            ],
+            [ // Shared calendar with umlauts
+                [
+                    'object_uri' => 'someuuid.ics',
+                    'calendar_uri' => 'umlaut_äüöß',
+                    'owner' => 'sharer'
+                ],
+                base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
+            ],
+            [ // Shared calendar with umlauts and mixed casing
+                [
+                    'object_uri' => 'someuuid.ics',
+                    'calendar_uri' => 'Umlaut_äüöß',
+                    'owner' => 'sharer'
+                ],
+                base64_encode('/remote.php/dav/calendars/sharee/Umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
+            ],
+            [ // Owned calendar with umlauts
+                [
+                    'object_uri' => 'someuuid.ics',
+                    'calendar_uri' => 'umlaut_äüöß',
+                    'owner' => 'sharee'
+                ],
+                base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f/someuuid.ics'),
+            ],
+            [ // Owned calendar with umlauts and mixed casing
+                [
+                    'object_uri' => 'someuuid.ics',
+                    'calendar_uri' => 'Umlaut_äüöß',
+                    'owner' => 'sharee'
+                ],
+                base64_encode('/remote.php/dav/calendars/sharee/Umlaut_%c3%a4%c3%bc%c3%b6%c3%9f/someuuid.ics'),
+            ],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('generateObjectParameterLinkEncodingDataProvider')]
-	public function testGenerateObjectParameterLinkEncoding(array $link, string $objectId): void {
-		$generatedLink = [
-			'objectId' => $objectId,
-		];
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('calendar')
-			->willReturn(true);
-		$this->url->expects($this->once())
-			->method('getWebroot');
-		$this->url->expects($this->once())
-			->method('linkToRouteAbsolute')
-			->with('calendar.view.indexdirect.edit', $generatedLink)
-			->willReturn('fullLink');
-		$objectParameter = ['id' => 42, 'name' => 'calendar', 'link' => $link];
-		$result = [
-			'type' => 'calendar-event',
-			'id' => 42,
-			'name' => 'calendar',
-			'link' => 'fullLink',
-		];
-		$this->assertEquals($result, $this->invokePrivate($this->provider, 'generateObjectParameter', [$objectParameter, 'sharee']));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('generateObjectParameterLinkEncodingDataProvider')]
+    public function testGenerateObjectParameterLinkEncoding(array $link, string $objectId): void {
+        $generatedLink = [
+            'objectId' => $objectId,
+        ];
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('calendar')
+            ->willReturn(true);
+        $this->url->expects($this->once())
+            ->method('getWebroot');
+        $this->url->expects($this->once())
+            ->method('linkToRouteAbsolute')
+            ->with('calendar.view.indexdirect.edit', $generatedLink)
+            ->willReturn('fullLink');
+        $objectParameter = ['id' => 42, 'name' => 'calendar', 'link' => $link];
+        $result = [
+            'type' => 'calendar-event',
+            'id' => 42,
+            'name' => 'calendar',
+            'link' => 'fullLink',
+        ];
+        $this->assertEquals($result, $this->invokePrivate($this->provider, 'generateObjectParameter', [$objectParameter, 'sharee']));
+    }
 
-	public static function dataGenerateObjectParameterThrows(): array {
-		return [
-			['event', TypeError::class],
-			[['name' => 'event']],
-			[['id' => 42]],
-		];
-	}
+    public static function dataGenerateObjectParameterThrows(): array {
+        return [
+            ['event', TypeError::class],
+            [['name' => 'event']],
+            [['id' => 42]],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateObjectParameterThrows')]
-	public function testGenerateObjectParameterThrows(string|array $eventData, string $exception = InvalidArgumentException::class): void {
-		$this->expectException($exception);
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateObjectParameterThrows')]
+    public function testGenerateObjectParameterThrows(string|array $eventData, string $exception = InvalidArgumentException::class): void {
+        $this->expectException($exception);
 
-		$this->invokePrivate($this->provider, 'generateObjectParameter', [$eventData, 'no_user']);
-	}
+        $this->invokePrivate($this->provider, 'generateObjectParameter', [$eventData, 'no_user']);
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -73,7 +73,7 @@ 
 		if ($link) {
 			$affectedUser = $link['owner'];
 			$generatedLink = [
-				'objectId' => base64_encode('/remote.php/dav/calendars/' . $link['owner'] . '/' . $link['calendar_uri'] . '/' . $link['object_uri']),
+				'objectId' => base64_encode('/remote.php/dav/calendars/'.$link['owner'].'/'.$link['calendar_uri'].'/'.$link['object_uri']),
 			];
 			$this->appManager->expects($this->once())
 				->method('isEnabledForUser')
@@ -105,7 +105,7 @@ 
 
 	public static function generateObjectParameterLinkEncodingDataProvider(): array {
 		return [
-			[ // Shared calendar
+			[// Shared calendar
 				[
 					'object_uri' => 'someuuid.ics',
 					'calendar_uri' => 'personal',
@@ -113,7 +113,7 @@ 
 				],
 				base64_encode('/remote.php/dav/calendars/sharee/personal_shared_by_sharer/someuuid.ics'),
 			],
-			[ // Shared calendar with umlauts
+			[// Shared calendar with umlauts
 				[
 					'object_uri' => 'someuuid.ics',
 					'calendar_uri' => 'umlaut_äüöß',
@@ -121,7 +121,7 @@ 
 				],
 				base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
 			],
-			[ // Shared calendar with umlauts and mixed casing
+			[// Shared calendar with umlauts and mixed casing
 				[
 					'object_uri' => 'someuuid.ics',
 					'calendar_uri' => 'Umlaut_äüöß',
@@ -129,7 +129,7 @@ 
 				],
 				base64_encode('/remote.php/dav/calendars/sharee/Umlaut_%c3%a4%c3%bc%c3%b6%c3%9f_shared_by_sharer/someuuid.ics'),
 			],
-			[ // Owned calendar with umlauts
+			[// Owned calendar with umlauts
 				[
 					'object_uri' => 'someuuid.ics',
 					'calendar_uri' => 'umlaut_äüöß',
@@ -137,7 +137,7 @@ 
 				],
 				base64_encode('/remote.php/dav/calendars/sharee/umlaut_%c3%a4%c3%bc%c3%b6%c3%9f/someuuid.ics'),
 			],
-			[ // Owned calendar with umlauts and mixed casing
+			[// Owned calendar with umlauts and mixed casing
 				[
 					'object_uri' => 'someuuid.ics',
 					'calendar_uri' => 'Umlaut_äüöß',
@@ -182,7 +182,7 @@ 
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateObjectParameterThrows')]
-	public function testGenerateObjectParameterThrows(string|array $eventData, string $exception = InvalidArgumentException::class): void {
+	public function testGenerateObjectParameterThrows(string | array $eventData, string $exception = InvalidArgumentException::class): void {
 		$this->expectException($exception);
 
 		$this->invokePrivate($this->provider, 'generateObjectParameter', [$eventData, 'no_user']);

apps/dav/tests/unit/CalDAV/Activity/Provider/BaseTest.php

Indentation +85 added lines, -85 removed lines

@@ -17,100 +17,100 @@
 use Test\TestCase;
 
 class BaseTest extends TestCase {
-	protected IUserManager&MockObject $userManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IURLGenerator&MockObject $url;
-	protected Base&MockObject $provider;
+    protected IUserManager&MockObject $userManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IURLGenerator&MockObject $url;
+    protected Base&MockObject $provider;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-		$this->provider = $this->getMockBuilder(Base::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->url,
-			])
-			->onlyMethods(['parse'])
-			->getMock();
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+        $this->provider = $this->getMockBuilder(Base::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->url,
+            ])
+            ->onlyMethods(['parse'])
+            ->getMock();
+    }
 
-	public static function dataSetSubjects(): array {
-		return [
-			['abc', []],
-			['{actor} created {calendar}', ['actor' => ['name' => 'abc'], 'calendar' => ['name' => 'xyz']]],
-		];
-	}
+    public static function dataSetSubjects(): array {
+        return [
+            ['abc', []],
+            ['{actor} created {calendar}', ['actor' => ['name' => 'abc'], 'calendar' => ['name' => 'xyz']]],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSetSubjects')]
-	public function testSetSubjects(string $subject, array $parameters): void {
-		$event = $this->createMock(IEvent::class);
-		$event->expects($this->once())
-			->method('setRichSubject')
-			->with($subject, $parameters)
-			->willReturnSelf();
-		$event->expects($this->never())
-			->method('setParsedSubject');
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSetSubjects')]
+    public function testSetSubjects(string $subject, array $parameters): void {
+        $event = $this->createMock(IEvent::class);
+        $event->expects($this->once())
+            ->method('setRichSubject')
+            ->with($subject, $parameters)
+            ->willReturnSelf();
+        $event->expects($this->never())
+            ->method('setParsedSubject');
 
-		$this->invokePrivate($this->provider, 'setSubjects', [$event, $subject, $parameters]);
-	}
+        $this->invokePrivate($this->provider, 'setSubjects', [$event, $subject, $parameters]);
+    }
 
-	public static function dataGenerateCalendarParameter(): array {
-		return [
-			[['id' => 23, 'uri' => 'foo', 'name' => 'bar'], 'bar'],
-			[['id' => 42, 'uri' => 'foo', 'name' => 'Personal'], 'Personal'],
-			[['id' => 42, 'uri' => 'personal', 'name' => 'bar'], 'bar'],
-			[['id' => 42, 'uri' => 'personal', 'name' => 'Personal'], 't(Personal)'],
-		];
-	}
+    public static function dataGenerateCalendarParameter(): array {
+        return [
+            [['id' => 23, 'uri' => 'foo', 'name' => 'bar'], 'bar'],
+            [['id' => 42, 'uri' => 'foo', 'name' => 'Personal'], 'Personal'],
+            [['id' => 42, 'uri' => 'personal', 'name' => 'bar'], 'bar'],
+            [['id' => 42, 'uri' => 'personal', 'name' => 'Personal'], 't(Personal)'],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateCalendarParameter')]
-	public function testGenerateCalendarParameter(array $data, string $name): void {
-		$l = $this->createMock(IL10N::class);
-		$l->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				return 't(' . vsprintf($string, $args) . ')';
-			});
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateCalendarParameter')]
+    public function testGenerateCalendarParameter(array $data, string $name): void {
+        $l = $this->createMock(IL10N::class);
+        $l->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                return 't(' . vsprintf($string, $args) . ')';
+            });
 
-		$this->assertEquals([
-			'type' => 'calendar',
-			'id' => $data['id'],
-			'name' => $name,
-		], $this->invokePrivate($this->provider, 'generateCalendarParameter', [$data, $l]));
-	}
+        $this->assertEquals([
+            'type' => 'calendar',
+            'id' => $data['id'],
+            'name' => $name,
+        ], $this->invokePrivate($this->provider, 'generateCalendarParameter', [$data, $l]));
+    }
 
-	public static function dataGenerateLegacyCalendarParameter(): array {
-		return [
-			[23, 'c1'],
-			[42, 'c2'],
-		];
-	}
+    public static function dataGenerateLegacyCalendarParameter(): array {
+        return [
+            [23, 'c1'],
+            [42, 'c2'],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateLegacyCalendarParameter')]
-	public function testGenerateLegacyCalendarParameter(int $id, string $name): void {
-		$this->assertEquals([
-			'type' => 'calendar',
-			'id' => $id,
-			'name' => $name,
-		], $this->invokePrivate($this->provider, 'generateLegacyCalendarParameter', [$id, $name]));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateLegacyCalendarParameter')]
+    public function testGenerateLegacyCalendarParameter(int $id, string $name): void {
+        $this->assertEquals([
+            'type' => 'calendar',
+            'id' => $id,
+            'name' => $name,
+        ], $this->invokePrivate($this->provider, 'generateLegacyCalendarParameter', [$id, $name]));
+    }
 
-	public static function dataGenerateGroupParameter(): array {
-		return [
-			['g1'],
-			['g2'],
-		];
-	}
+    public static function dataGenerateGroupParameter(): array {
+        return [
+            ['g1'],
+            ['g2'],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateGroupParameter')]
-	public function testGenerateGroupParameter(string $gid): void {
-		$this->assertEquals([
-			'type' => 'user-group',
-			'id' => $gid,
-			'name' => $gid,
-		], $this->invokePrivate($this->provider, 'generateGroupParameter', [$gid]));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGenerateGroupParameter')]
+    public function testGenerateGroupParameter(string $gid): void {
+        $this->assertEquals([
+            'type' => 'user-group',
+            'id' => $gid,
+            'name' => $gid,
+        ], $this->invokePrivate($this->provider, 'generateGroupParameter', [$gid]));
+    }
 }

apps/dav/tests/unit/CalDAV/Activity/Setting/GenericTest.php

Indentation +57 added lines, -57 removed lines

@@ -15,69 +15,69 @@
 use Test\TestCase;
 
 class GenericTest extends TestCase {
-	public static function dataSettings(): array {
-		return [
-			[Calendar::class],
-			[Event::class],
-			[Todo::class],
-		];
-	}
+    public static function dataSettings(): array {
+        return [
+            [Calendar::class],
+            [Event::class],
+            [Todo::class],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testImplementsInterface(string $settingClass): void {
-		$setting = Server::get($settingClass);
-		$this->assertInstanceOf(ISetting::class, $setting);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testImplementsInterface(string $settingClass): void {
+        $setting = Server::get($settingClass);
+        $this->assertInstanceOf(ISetting::class, $setting);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testGetIdentifier(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsString($setting->getIdentifier());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testGetIdentifier(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsString($setting->getIdentifier());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testGetName(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsString($setting->getName());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testGetName(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsString($setting->getName());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testGetPriority(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$priority = $setting->getPriority();
-		$this->assertIsInt($setting->getPriority());
-		$this->assertGreaterThanOrEqual(0, $priority);
-		$this->assertLessThanOrEqual(100, $priority);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testGetPriority(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $priority = $setting->getPriority();
+        $this->assertIsInt($setting->getPriority());
+        $this->assertGreaterThanOrEqual(0, $priority);
+        $this->assertLessThanOrEqual(100, $priority);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testCanChangeStream(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsBool($setting->canChangeStream());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testCanChangeStream(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsBool($setting->canChangeStream());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testIsDefaultEnabledStream(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsBool($setting->isDefaultEnabledStream());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testIsDefaultEnabledStream(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsBool($setting->isDefaultEnabledStream());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testCanChangeMail(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsBool($setting->canChangeMail());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testCanChangeMail(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsBool($setting->canChangeMail());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
-	public function testIsDefaultEnabledMail(string $settingClass): void {
-		/** @var ISetting $setting */
-		$setting = Server::get($settingClass);
-		$this->assertIsBool($setting->isDefaultEnabledMail());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSettings')]
+    public function testIsDefaultEnabledMail(string $settingClass): void {
+        /** @var ISetting $setting */
+        $setting = Server::get($settingClass);
+        $this->assertIsBool($setting->isDefaultEnabledMail());
+    }
 }

apps/dav/tests/unit/CalDAV/Activity/Filter/GenericTest.php

Indentation +51 added lines, -51 removed lines

@@ -17,62 +17,62 @@
  * @group DB
  */
 class GenericTest extends TestCase {
-	public static function dataFilters(): array {
-		return [
-			[Calendar::class],
-			[Todo::class],
-		];
-	}
+    public static function dataFilters(): array {
+        return [
+            [Calendar::class],
+            [Todo::class],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testImplementsInterface(string $filterClass): void {
-		$filter = Server::get($filterClass);
-		$this->assertInstanceOf(IFilter::class, $filter);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testImplementsInterface(string $filterClass): void {
+        $filter = Server::get($filterClass);
+        $this->assertInstanceOf(IFilter::class, $filter);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testGetIdentifier(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$this->assertIsString($filter->getIdentifier());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testGetIdentifier(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $this->assertIsString($filter->getIdentifier());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testGetName(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$this->assertIsString($filter->getName());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testGetName(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $this->assertIsString($filter->getName());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testGetPriority(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$priority = $filter->getPriority();
-		$this->assertIsInt($filter->getPriority());
-		$this->assertGreaterThanOrEqual(0, $priority);
-		$this->assertLessThanOrEqual(100, $priority);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testGetPriority(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $priority = $filter->getPriority();
+        $this->assertIsInt($filter->getPriority());
+        $this->assertGreaterThanOrEqual(0, $priority);
+        $this->assertLessThanOrEqual(100, $priority);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testGetIcon(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$this->assertIsString($filter->getIcon());
-		$this->assertStringStartsWith('http', $filter->getIcon());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testGetIcon(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $this->assertIsString($filter->getIcon());
+        $this->assertStringStartsWith('http', $filter->getIcon());
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testFilterTypes(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$this->assertIsArray($filter->filterTypes([]));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testFilterTypes(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $this->assertIsArray($filter->filterTypes([]));
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
-	public function testAllowedApps(string $filterClass): void {
-		/** @var IFilter $filter */
-		$filter = Server::get($filterClass);
-		$this->assertIsArray($filter->allowedApps());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilters')]
+    public function testAllowedApps(string $filterClass): void {
+        /** @var IFilter $filter */
+        $filter = Server::get($filterClass);
+        $this->assertIsArray($filter->allowedApps());
+    }
 }

apps/dav/tests/unit/CalDAV/Activity/Filter/TodoTest.php

Indentation +42 added lines, -42 removed lines

@@ -15,53 +15,53 @@
 use Test\TestCase;
 
 class TodoTest extends TestCase {
-	protected IURLGenerator&MockObject $url;
-	protected IFilter $filter;
+    protected IURLGenerator&MockObject $url;
+    protected IFilter $filter;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->url = $this->createMock(IURLGenerator::class);
-		$l = $this->createMock(IL10N::class);
-		$l->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				return vsprintf($string, $args);
-			});
+    protected function setUp(): void {
+        parent::setUp();
+        $this->url = $this->createMock(IURLGenerator::class);
+        $l = $this->createMock(IL10N::class);
+        $l->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                return vsprintf($string, $args);
+            });
 
-		$this->filter = new Todo(
-			$l, $this->url
-		);
-	}
+        $this->filter = new Todo(
+            $l, $this->url
+        );
+    }
 
-	public function testGetIcon(): void {
-		$this->url->expects($this->once())
-			->method('imagePath')
-			->with('core', 'actions/checkmark.svg')
-			->willReturn('path-to-icon');
+    public function testGetIcon(): void {
+        $this->url->expects($this->once())
+            ->method('imagePath')
+            ->with('core', 'actions/checkmark.svg')
+            ->willReturn('path-to-icon');
 
-		$this->url->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('path-to-icon')
-			->willReturn('absolute-path-to-icon');
+        $this->url->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('path-to-icon')
+            ->willReturn('absolute-path-to-icon');
 
-		$this->assertEquals('absolute-path-to-icon', $this->filter->getIcon());
-	}
+        $this->assertEquals('absolute-path-to-icon', $this->filter->getIcon());
+    }
 
-	public static function dataFilterTypes(): array {
-		return [
-			[[], []],
-			[['calendar_todo'], ['calendar_todo']],
-			[['calendar', 'calendar_event', 'calendar_todo'], ['calendar_todo']],
-			[['calendar', 'calendar_todo', 'files'], ['calendar_todo']],
-		];
-	}
+    public static function dataFilterTypes(): array {
+        return [
+            [[], []],
+            [['calendar_todo'], ['calendar_todo']],
+            [['calendar', 'calendar_event', 'calendar_todo'], ['calendar_todo']],
+            [['calendar', 'calendar_todo', 'files'], ['calendar_todo']],
+        ];
+    }
 
-	/**
-	 * @param string[] $types
-	 * @param string[] $expected
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilterTypes')]
-	public function testFilterTypes(array $types, array $expected): void {
-		$this->assertEquals($expected, $this->filter->filterTypes($types));
-	}
+    /**
+     * @param string[] $types
+     * @param string[] $expected
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilterTypes')]
+    public function testFilterTypes(array $types, array $expected): void {
+        $this->assertEquals($expected, $this->filter->filterTypes($types));
+    }
 }

apps/dav/tests/unit/CalDAV/Activity/Filter/CalendarTest.php

Indentation +42 added lines, -42 removed lines

@@ -15,53 +15,53 @@
 use Test\TestCase;
 
 class CalendarTest extends TestCase {
-	protected IURLGenerator&MockObject $url;
-	protected IFilter $filter;
+    protected IURLGenerator&MockObject $url;
+    protected IFilter $filter;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->url = $this->createMock(IURLGenerator::class);
-		$l = $this->createMock(IL10N::class);
-		$l->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				return vsprintf($string, $args);
-			});
+    protected function setUp(): void {
+        parent::setUp();
+        $this->url = $this->createMock(IURLGenerator::class);
+        $l = $this->createMock(IL10N::class);
+        $l->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                return vsprintf($string, $args);
+            });
 
-		$this->filter = new Calendar(
-			$l, $this->url
-		);
-	}
+        $this->filter = new Calendar(
+            $l, $this->url
+        );
+    }
 
-	public function testGetIcon(): void {
-		$this->url->expects($this->once())
-			->method('imagePath')
-			->with('core', 'places/calendar.svg')
-			->willReturn('path-to-icon');
+    public function testGetIcon(): void {
+        $this->url->expects($this->once())
+            ->method('imagePath')
+            ->with('core', 'places/calendar.svg')
+            ->willReturn('path-to-icon');
 
-		$this->url->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('path-to-icon')
-			->willReturn('absolute-path-to-icon');
+        $this->url->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('path-to-icon')
+            ->willReturn('absolute-path-to-icon');
 
-		$this->assertEquals('absolute-path-to-icon', $this->filter->getIcon());
-	}
+        $this->assertEquals('absolute-path-to-icon', $this->filter->getIcon());
+    }
 
-	public static function dataFilterTypes(): array {
-		return [
-			[[], []],
-			[['calendar', 'calendar_event'], ['calendar', 'calendar_event']],
-			[['calendar', 'calendar_event', 'calendar_todo'], ['calendar', 'calendar_event']],
-			[['calendar', 'calendar_event', 'files'], ['calendar', 'calendar_event']],
-		];
-	}
+    public static function dataFilterTypes(): array {
+        return [
+            [[], []],
+            [['calendar', 'calendar_event'], ['calendar', 'calendar_event']],
+            [['calendar', 'calendar_event', 'calendar_todo'], ['calendar', 'calendar_event']],
+            [['calendar', 'calendar_event', 'files'], ['calendar', 'calendar_event']],
+        ];
+    }
 
-	/**
-	 * @param string[] $types
-	 * @param string[] $expected
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataFilterTypes')]
-	public function testFilterTypes(array $types, array $expected): void {
-		$this->assertEquals($expected, $this->filter->filterTypes($types));
-	}
+    /**
+     * @param string[] $types
+     * @param string[] $expected
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataFilterTypes')]
+    public function testFilterTypes(array $types, array $expected): void {
+        $this->assertEquals($expected, $this->filter->filterTypes($types));
+    }
 }

apps/dav/tests/unit/CalDAV/Activity/BackendTest.php

Indentation +325 added lines, -325 removed lines

@@ -21,329 +21,329 @@
 use Test\TestCase;
 
 class BackendTest extends TestCase {
-	protected IManager&MockObject $activityManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IUserSession&MockObject $userSession;
-	protected IAppManager&MockObject $appManager;
-	protected IUserManager&MockObject $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->activityManager = $this->createMock(IManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-	}
-
-	/**
-	 * @return Backend|(Backend&MockObject)
-	 */
-	protected function getBackend(array $methods = []): Backend {
-		if (empty($methods)) {
-			return new Backend(
-				$this->activityManager,
-				$this->groupManager,
-				$this->userSession,
-				$this->appManager,
-				$this->userManager
-			);
-		} else {
-			return $this->getMockBuilder(Backend::class)
-				->setConstructorArgs([
-					$this->activityManager,
-					$this->groupManager,
-					$this->userSession,
-					$this->appManager,
-					$this->userManager
-				])
-				->onlyMethods($methods)
-				->getMock();
-		}
-	}
-
-	public static function dataCallTriggerCalendarActivity(): array {
-		return [
-			['onCalendarAdd', [['data']], Calendar::SUBJECT_ADD, [['data'], [], []]],
-			['onCalendarUpdate', [['data'], ['shares'], ['changed-properties']], Calendar::SUBJECT_UPDATE, [['data'], ['shares'], ['changed-properties']]],
-			['onCalendarDelete', [['data'], ['shares']], Calendar::SUBJECT_DELETE, [['data'], ['shares'], []]],
-			['onCalendarPublication', [['data'], true], Calendar::SUBJECT_PUBLISH, [['data'], [], []]],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataCallTriggerCalendarActivity')]
-	public function testCallTriggerCalendarActivity(string $method, array $payload, string $expectedSubject, array $expectedPayload): void {
-		$backend = $this->getBackend(['triggerCalendarActivity']);
-		$backend->expects($this->once())
-			->method('triggerCalendarActivity')
-			->willReturnCallback(function () use ($expectedPayload, $expectedSubject): void {
-				$arguments = func_get_args();
-				$this->assertSame($expectedSubject, array_shift($arguments));
-				$this->assertEquals($expectedPayload, $arguments);
-			});
-
-		call_user_func_array([$backend, $method], $payload);
-	}
-
-	public static function dataTriggerCalendarActivity(): array {
-		return [
-			// Add calendar
-			[Calendar::SUBJECT_ADD, [], [], [], '', '', null, []],
-			[Calendar::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], [], [], '', 'admin', null, ['admin']],
-			[Calendar::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], [], [], 'test2', 'test2', null, ['admin']],
-
-			// Update calendar
-			[Calendar::SUBJECT_UPDATE, [], [], [], '', '', null, []],
-			// No visible change - owner only
-			[Calendar::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], '', 'admin', null, ['admin']],
-			// Visible change
-			[Calendar::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], ['{DAV:}displayname' => 'Name'], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Calendar::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], ['{DAV:}displayname' => 'Name'], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-
-			// Delete calendar
-			[Calendar::SUBJECT_DELETE, [], [], [], '', '', null, []],
-			[Calendar::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], '', 'admin', [], ['admin']],
-			[Calendar::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Calendar::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-
-			// Publish calendar
-			[Calendar::SUBJECT_PUBLISH, [], [], [], '', '', null, []],
-			[Calendar::SUBJECT_PUBLISH, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], '', 'admin', [], ['admin']],
-
-			// Unpublish calendar
-			[Calendar::SUBJECT_UNPUBLISH, [], [], [], '', '', null, []],
-			[Calendar::SUBJECT_UNPUBLISH, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of calendar',
-			], ['shares'], [], '', 'admin', [], ['admin']],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerCalendarActivity')]
-	public function testTriggerCalendarActivity(string $action, array $data, array $shares, array $changedProperties, string $currentUser, string $author, ?array $shareUsers, array $users): void {
-		$backend = $this->getBackend(['getUsersForShares']);
-
-		if ($shareUsers === null) {
-			$backend->expects($this->never())
-				->method('getUsersForShares');
-		} else {
-			$backend->expects($this->once())
-				->method('getUsersForShares')
-				->with($shares)
-				->willReturn($shareUsers);
-		}
-
-		if ($author !== '') {
-			if ($currentUser !== '') {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($this->getUserMock($currentUser));
-			} else {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn(null);
-			}
-
-			$event = $this->createMock(IEvent::class);
-			$this->activityManager->expects($this->once())
-				->method('generateEvent')
-				->willReturn($event);
-
-			$event->expects($this->once())
-				->method('setApp')
-				->with('dav')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setObject')
-				->with('calendar', $data['id'])
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setType')
-				->with('calendar')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setAuthor')
-				->with($author)
-				->willReturnSelf();
-
-			$this->userManager->expects($action === Calendar::SUBJECT_DELETE ? $this->exactly(sizeof($users)) : $this->never())
-				->method('userExists')
-				->willReturn(true);
-
-			$event->expects($this->exactly(sizeof($users)))
-				->method('setAffectedUser')
-				->willReturnSelf();
-			$event->expects($this->exactly(sizeof($users)))
-				->method('setSubject')
-				->willReturnSelf();
-			$this->activityManager->expects($this->exactly(sizeof($users)))
-				->method('publish')
-				->with($event);
-		} else {
-			$this->activityManager->expects($this->never())
-				->method('generateEvent');
-		}
-
-		$this->invokePrivate($backend, 'triggerCalendarActivity', [$action, $data, $shares, $changedProperties]);
-	}
-
-	public function testUserDeletionDoesNotCreateActivity(): void {
-		$backend = $this->getBackend();
-
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->willReturn(false);
-
-		$this->activityManager->expects($this->never())
-			->method('publish');
-
-		$this->invokePrivate($backend, 'triggerCalendarActivity', [Calendar::SUBJECT_DELETE, [
-			'principaluri' => 'principal/user/admin',
-			'id' => 42,
-			'uri' => 'this-uri',
-			'{DAV:}displayname' => 'Name of calendar',
-		], [], []]);
-	}
-
-	public static function dataGetUsersForShares(): array {
-		return [
-			[
-				[],
-				[],
-				[],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user3'],
-				],
-				[],
-				['user1', 'user2', 'user3'],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
-				],
-				['group2' => null, 'group3' => null],
-				['user1', 'user2'],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
-				],
-				['group2' => ['user1', 'user2', 'user3'], 'group3' => ['user2', 'user3', 'user4']],
-				['user1', 'user2', 'user3', 'user4'],
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGetUsersForShares')]
-	public function testGetUsersForShares(array $shares, array $groups, array $expected): void {
-		$backend = $this->getBackend();
-
-		$getGroups = [];
-		foreach ($groups as $gid => $members) {
-			if ($members === null) {
-				$getGroups[] = [$gid, null];
-				continue;
-			}
-
-			$group = $this->createMock(IGroup::class);
-			$group->expects($this->once())
-				->method('getUsers')
-				->willReturn($this->getUsers($members));
-
-			$getGroups[] = [$gid, $group];
-		}
-
-		$this->groupManager->expects($this->exactly(sizeof($getGroups)))
-			->method('get')
-			->willReturnMap($getGroups);
-
-		$users = $this->invokePrivate($backend, 'getUsersForShares', [$shares]);
-		sort($users);
-		$this->assertEquals($expected, $users);
-	}
-
-	/**
-	 * @param string[] $users
-	 * @return IUser[]&MockObject[]
-	 */
-	protected function getUsers(array $users) {
-		$list = [];
-		foreach ($users as $user) {
-			$list[] = $this->getUserMock($user);
-		}
-		return $list;
-	}
-
-	/**
-	 * @param string $uid
-	 * @return IUser&MockObject
-	 */
-	protected function getUserMock($uid) {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn($uid);
-		return $user;
-	}
+    protected IManager&MockObject $activityManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IUserSession&MockObject $userSession;
+    protected IAppManager&MockObject $appManager;
+    protected IUserManager&MockObject $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->activityManager = $this->createMock(IManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+    }
+
+    /**
+     * @return Backend|(Backend&MockObject)
+     */
+    protected function getBackend(array $methods = []): Backend {
+        if (empty($methods)) {
+            return new Backend(
+                $this->activityManager,
+                $this->groupManager,
+                $this->userSession,
+                $this->appManager,
+                $this->userManager
+            );
+        } else {
+            return $this->getMockBuilder(Backend::class)
+                ->setConstructorArgs([
+                    $this->activityManager,
+                    $this->groupManager,
+                    $this->userSession,
+                    $this->appManager,
+                    $this->userManager
+                ])
+                ->onlyMethods($methods)
+                ->getMock();
+        }
+    }
+
+    public static function dataCallTriggerCalendarActivity(): array {
+        return [
+            ['onCalendarAdd', [['data']], Calendar::SUBJECT_ADD, [['data'], [], []]],
+            ['onCalendarUpdate', [['data'], ['shares'], ['changed-properties']], Calendar::SUBJECT_UPDATE, [['data'], ['shares'], ['changed-properties']]],
+            ['onCalendarDelete', [['data'], ['shares']], Calendar::SUBJECT_DELETE, [['data'], ['shares'], []]],
+            ['onCalendarPublication', [['data'], true], Calendar::SUBJECT_PUBLISH, [['data'], [], []]],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataCallTriggerCalendarActivity')]
+    public function testCallTriggerCalendarActivity(string $method, array $payload, string $expectedSubject, array $expectedPayload): void {
+        $backend = $this->getBackend(['triggerCalendarActivity']);
+        $backend->expects($this->once())
+            ->method('triggerCalendarActivity')
+            ->willReturnCallback(function () use ($expectedPayload, $expectedSubject): void {
+                $arguments = func_get_args();
+                $this->assertSame($expectedSubject, array_shift($arguments));
+                $this->assertEquals($expectedPayload, $arguments);
+            });
+
+        call_user_func_array([$backend, $method], $payload);
+    }
+
+    public static function dataTriggerCalendarActivity(): array {
+        return [
+            // Add calendar
+            [Calendar::SUBJECT_ADD, [], [], [], '', '', null, []],
+            [Calendar::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], [], [], '', 'admin', null, ['admin']],
+            [Calendar::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], [], [], 'test2', 'test2', null, ['admin']],
+
+            // Update calendar
+            [Calendar::SUBJECT_UPDATE, [], [], [], '', '', null, []],
+            // No visible change - owner only
+            [Calendar::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], '', 'admin', null, ['admin']],
+            // Visible change
+            [Calendar::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], ['{DAV:}displayname' => 'Name'], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Calendar::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], ['{DAV:}displayname' => 'Name'], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+
+            // Delete calendar
+            [Calendar::SUBJECT_DELETE, [], [], [], '', '', null, []],
+            [Calendar::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], '', 'admin', [], ['admin']],
+            [Calendar::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Calendar::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+
+            // Publish calendar
+            [Calendar::SUBJECT_PUBLISH, [], [], [], '', '', null, []],
+            [Calendar::SUBJECT_PUBLISH, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], '', 'admin', [], ['admin']],
+
+            // Unpublish calendar
+            [Calendar::SUBJECT_UNPUBLISH, [], [], [], '', '', null, []],
+            [Calendar::SUBJECT_UNPUBLISH, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of calendar',
+            ], ['shares'], [], '', 'admin', [], ['admin']],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerCalendarActivity')]
+    public function testTriggerCalendarActivity(string $action, array $data, array $shares, array $changedProperties, string $currentUser, string $author, ?array $shareUsers, array $users): void {
+        $backend = $this->getBackend(['getUsersForShares']);
+
+        if ($shareUsers === null) {
+            $backend->expects($this->never())
+                ->method('getUsersForShares');
+        } else {
+            $backend->expects($this->once())
+                ->method('getUsersForShares')
+                ->with($shares)
+                ->willReturn($shareUsers);
+        }
+
+        if ($author !== '') {
+            if ($currentUser !== '') {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($this->getUserMock($currentUser));
+            } else {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn(null);
+            }
+
+            $event = $this->createMock(IEvent::class);
+            $this->activityManager->expects($this->once())
+                ->method('generateEvent')
+                ->willReturn($event);
+
+            $event->expects($this->once())
+                ->method('setApp')
+                ->with('dav')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setObject')
+                ->with('calendar', $data['id'])
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setType')
+                ->with('calendar')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setAuthor')
+                ->with($author)
+                ->willReturnSelf();
+
+            $this->userManager->expects($action === Calendar::SUBJECT_DELETE ? $this->exactly(sizeof($users)) : $this->never())
+                ->method('userExists')
+                ->willReturn(true);
+
+            $event->expects($this->exactly(sizeof($users)))
+                ->method('setAffectedUser')
+                ->willReturnSelf();
+            $event->expects($this->exactly(sizeof($users)))
+                ->method('setSubject')
+                ->willReturnSelf();
+            $this->activityManager->expects($this->exactly(sizeof($users)))
+                ->method('publish')
+                ->with($event);
+        } else {
+            $this->activityManager->expects($this->never())
+                ->method('generateEvent');
+        }
+
+        $this->invokePrivate($backend, 'triggerCalendarActivity', [$action, $data, $shares, $changedProperties]);
+    }
+
+    public function testUserDeletionDoesNotCreateActivity(): void {
+        $backend = $this->getBackend();
+
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->willReturn(false);
+
+        $this->activityManager->expects($this->never())
+            ->method('publish');
+
+        $this->invokePrivate($backend, 'triggerCalendarActivity', [Calendar::SUBJECT_DELETE, [
+            'principaluri' => 'principal/user/admin',
+            'id' => 42,
+            'uri' => 'this-uri',
+            '{DAV:}displayname' => 'Name of calendar',
+        ], [], []]);
+    }
+
+    public static function dataGetUsersForShares(): array {
+        return [
+            [
+                [],
+                [],
+                [],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user3'],
+                ],
+                [],
+                ['user1', 'user2', 'user3'],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
+                ],
+                ['group2' => null, 'group3' => null],
+                ['user1', 'user2'],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
+                ],
+                ['group2' => ['user1', 'user2', 'user3'], 'group3' => ['user2', 'user3', 'user4']],
+                ['user1', 'user2', 'user3', 'user4'],
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGetUsersForShares')]
+    public function testGetUsersForShares(array $shares, array $groups, array $expected): void {
+        $backend = $this->getBackend();
+
+        $getGroups = [];
+        foreach ($groups as $gid => $members) {
+            if ($members === null) {
+                $getGroups[] = [$gid, null];
+                continue;
+            }
+
+            $group = $this->createMock(IGroup::class);
+            $group->expects($this->once())
+                ->method('getUsers')
+                ->willReturn($this->getUsers($members));
+
+            $getGroups[] = [$gid, $group];
+        }
+
+        $this->groupManager->expects($this->exactly(sizeof($getGroups)))
+            ->method('get')
+            ->willReturnMap($getGroups);
+
+        $users = $this->invokePrivate($backend, 'getUsersForShares', [$shares]);
+        sort($users);
+        $this->assertEquals($expected, $users);
+    }
+
+    /**
+     * @param string[] $users
+     * @return IUser[]&MockObject[]
+     */
+    protected function getUsers(array $users) {
+        $list = [];
+        foreach ($users as $user) {
+            $list[] = $this->getUserMock($user);
+        }
+        return $list;
+    }
+
+    /**
+     * @param string $uid
+     * @return IUser&MockObject
+     */
+    protected function getUserMock($uid) {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn($uid);
+        return $user;
+    }
 }

apps/dav/tests/unit/CalDAV/AppCalendar/AppCalendarTest.php

Indentation +100 added lines, -100 removed lines

@@ -17,104 +17,104 @@
 use function rewind;
 
 class AppCalendarTest extends TestCase {
-	private string $principal = 'principals/users/foo';
-
-	private AppCalendar $appCalendar;
-	private AppCalendar $writeableAppCalendar;
-
-	private ICalendar&MockObject $calendar;
-	private ICalendar&MockObject $writeableCalendar;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->calendar = $this->getMockBuilder(ICalendar::class)->getMock();
-		$this->calendar->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$this->writeableCalendar = $this->getMockBuilder(ICreateFromString::class)->getMock();
-		$this->writeableCalendar->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_CREATE);
-
-		$this->appCalendar = new AppCalendar('dav-wrapper', $this->calendar, $this->principal);
-		$this->writeableAppCalendar = new AppCalendar('dav-wrapper', $this->writeableCalendar, $this->principal);
-	}
-
-	public function testGetPrincipal():void {
-		// Check that the correct name is returned
-		$this->assertEquals($this->principal, $this->appCalendar->getOwner());
-		$this->assertEquals($this->principal, $this->writeableAppCalendar->getOwner());
-	}
-
-	public function testDelete(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('Deleting an entry is not implemented');
-
-		$this->appCalendar->delete();
-	}
-
-	public function testCreateFile(): void {
-		$calls = [
-			['some-name', 'data'],
-			['other-name', ''],
-			['name', 'some data'],
-		];
-		$this->writeableCalendar->expects($this->exactly(3))
-			->method('createFromString')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// pass data
-		$this->assertNull($this->writeableAppCalendar->createFile('some-name', 'data'));
-		// null is empty string
-		$this->assertNull($this->writeableAppCalendar->createFile('other-name', null));
-		// resource to data
-		$fp = fopen('php://memory', 'r+');
-		fwrite($fp, 'some data');
-		rewind($fp);
-		$this->assertNull($this->writeableAppCalendar->createFile('name', $fp));
-		fclose($fp);
-	}
-
-	public function testCreateFile_readOnly(): void {
-		// If writing is not supported
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('Creating a new entry is not allowed');
-
-		$this->appCalendar->createFile('some-name', 'data');
-	}
-
-	public function testSetACL(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('Setting ACL is not supported on this node');
-
-		$this->appCalendar->setACL([]);
-	}
-
-	public function testGetACL():void {
-		$expectedRO = [
-			[
-				'privilege' => '{DAV:}read',
-				'principal' => $this->principal,
-				'protected' => true,
-			],
-			[
-				'privilege' => '{DAV:}write-properties',
-				'principal' => $this->principal,
-				'protected' => true,
-			]
-		];
-		$expectedRW = $expectedRO;
-		$expectedRW[] = [
-			'privilege' => '{DAV:}write',
-			'principal' => $this->principal,
-			'protected' => true,
-		];
-
-		// Check that the correct ACL is returned (default be only readable)
-		$this->assertEquals($expectedRO, $this->appCalendar->getACL());
-		$this->assertEquals($expectedRW, $this->writeableAppCalendar->getACL());
-	}
+    private string $principal = 'principals/users/foo';
+
+    private AppCalendar $appCalendar;
+    private AppCalendar $writeableAppCalendar;
+
+    private ICalendar&MockObject $calendar;
+    private ICalendar&MockObject $writeableCalendar;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->calendar = $this->getMockBuilder(ICalendar::class)->getMock();
+        $this->calendar->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $this->writeableCalendar = $this->getMockBuilder(ICreateFromString::class)->getMock();
+        $this->writeableCalendar->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_CREATE);
+
+        $this->appCalendar = new AppCalendar('dav-wrapper', $this->calendar, $this->principal);
+        $this->writeableAppCalendar = new AppCalendar('dav-wrapper', $this->writeableCalendar, $this->principal);
+    }
+
+    public function testGetPrincipal():void {
+        // Check that the correct name is returned
+        $this->assertEquals($this->principal, $this->appCalendar->getOwner());
+        $this->assertEquals($this->principal, $this->writeableAppCalendar->getOwner());
+    }
+
+    public function testDelete(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('Deleting an entry is not implemented');
+
+        $this->appCalendar->delete();
+    }
+
+    public function testCreateFile(): void {
+        $calls = [
+            ['some-name', 'data'],
+            ['other-name', ''],
+            ['name', 'some data'],
+        ];
+        $this->writeableCalendar->expects($this->exactly(3))
+            ->method('createFromString')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // pass data
+        $this->assertNull($this->writeableAppCalendar->createFile('some-name', 'data'));
+        // null is empty string
+        $this->assertNull($this->writeableAppCalendar->createFile('other-name', null));
+        // resource to data
+        $fp = fopen('php://memory', 'r+');
+        fwrite($fp, 'some data');
+        rewind($fp);
+        $this->assertNull($this->writeableAppCalendar->createFile('name', $fp));
+        fclose($fp);
+    }
+
+    public function testCreateFile_readOnly(): void {
+        // If writing is not supported
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('Creating a new entry is not allowed');
+
+        $this->appCalendar->createFile('some-name', 'data');
+    }
+
+    public function testSetACL(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('Setting ACL is not supported on this node');
+
+        $this->appCalendar->setACL([]);
+    }
+
+    public function testGetACL():void {
+        $expectedRO = [
+            [
+                'privilege' => '{DAV:}read',
+                'principal' => $this->principal,
+                'protected' => true,
+            ],
+            [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => $this->principal,
+                'protected' => true,
+            ]
+        ];
+        $expectedRW = $expectedRO;
+        $expectedRW[] = [
+            'privilege' => '{DAV:}write',
+            'principal' => $this->principal,
+            'protected' => true,
+        ];
+
+        // Check that the correct ACL is returned (default be only readable)
+        $this->assertEquals($expectedRO, $this->appCalendar->getACL());
+        $this->assertEquals($expectedRW, $this->writeableAppCalendar->getACL());
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
 		];
 		$this->writeableCalendar->expects($this->exactly(3))
 			->method('createFromString')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/CalDAV/Schedule/PluginTest.php

Indentation +731 added lines, -731 removed lines

@@ -36,735 +36,735 @@
 use Test\TestCase;
 
 class PluginTest extends TestCase {
-	private Plugin $plugin;
-	private Server&MockObject $server;
-	private IConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private DefaultCalendarValidator $calendarValidator;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->calendarValidator = new DefaultCalendarValidator();
-
-		$this->server = $this->createMock(Server::class);
-		$this->server->httpResponse = $this->createMock(ResponseInterface::class);
-		$this->server->xml = new Service();
-
-		$this->plugin = new Plugin($this->config, $this->logger, $this->calendarValidator);
-		$this->plugin->initialize($this->server);
-	}
-
-	public function testInitialize(): void {
-		$calls = [
-			// Sabre\CalDAV\Schedule\Plugin events
-			['method:POST', [$this->plugin, 'httpPost'], 100],
-			['propFind', [$this->plugin, 'propFind'], 100],
-			['propPatch', [$this->plugin, 'propPatch'], 100],
-			['calendarObjectChange', [$this->plugin, 'calendarObjectChange'], 100],
-			['beforeUnbind', [$this->plugin, 'beforeUnbind'], 100],
-			['schedule', [$this->plugin, 'scheduleLocalDelivery'], 100],
-			['getSupportedPrivilegeSet', [$this->plugin, 'getSupportedPrivilegeSet'], 100],
-			// OCA\DAV\CalDAV\Schedule\Plugin events
-			['propFind', [$this->plugin, 'propFindDefaultCalendarUrl'], 90],
-			['afterWriteContent', [$this->plugin, 'dispatchSchedulingResponses'], 100],
-			['afterCreateFile', [$this->plugin, 'dispatchSchedulingResponses'], 100],
-		];
-		$this->server->expects($this->exactly(count($calls)))
-			->method('on')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		$this->plugin->initialize($this->server);
-	}
-
-	public function testGetAddressesForPrincipal(): void {
-		$href = $this->createMock(Href::class);
-		$href
-			->expects($this->once())
-			->method('getHrefs')
-			->willReturn(['lukas@nextcloud.com', 'rullzer@nextcloud.com']);
-		$this->server
-			->expects($this->once())
-			->method('getProperties')
-			->with(
-				'MyPrincipal',
-				[
-					'{urn:ietf:params:xml:ns:caldav}calendar-user-address-set',
-				]
-			)
-			->willReturn([
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => $href
-			]);
-
-		$result = $this->invokePrivate($this->plugin, 'getAddressesForPrincipal', ['MyPrincipal']);
-		$this->assertSame(['lukas@nextcloud.com', 'rullzer@nextcloud.com'], $result);
-	}
-
-	public function testGetAddressesForPrincipalEmpty(): void {
-		$this->server
-			->expects($this->once())
-			->method('getProperties')
-			->with(
-				'MyPrincipal',
-				[
-					'{urn:ietf:params:xml:ns:caldav}calendar-user-address-set',
-				]
-			)
-			->willReturn(null);
-
-		$result = $this->invokePrivate($this->plugin, 'getAddressesForPrincipal', ['MyPrincipal']);
-		$this->assertSame([], $result);
-	}
-
-	public function testStripOffMailTo(): void {
-		$this->assertEquals('test@example.com', $this->invokePrivate($this->plugin, 'stripOffMailTo', ['test@example.com']));
-		$this->assertEquals('test@example.com', $this->invokePrivate($this->plugin, 'stripOffMailTo', ['mailto:test@example.com']));
-	}
-
-	public function testGetAttendeeRSVP(): void {
-		$property1 = $this->createMock(CalAddress::class);
-		$parameter1 = $this->createMock(Parameter::class);
-		$property1->expects($this->once())
-			->method('offsetGet')
-			->with('RSVP')
-			->willReturn($parameter1);
-		$parameter1->expects($this->once())
-			->method('getValue')
-			->with()
-			->willReturn('TRUE');
-
-		$property2 = $this->createMock(CalAddress::class);
-		$parameter2 = $this->createMock(Parameter::class);
-		$property2->expects($this->once())
-			->method('offsetGet')
-			->with('RSVP')
-			->willReturn($parameter2);
-		$parameter2->expects($this->once())
-			->method('getValue')
-			->with()
-			->willReturn('FALSE');
-
-		$property3 = $this->createMock(CalAddress::class);
-		$property3->expects($this->once())
-			->method('offsetGet')
-			->with('RSVP')
-			->willReturn(null);
-
-		$this->assertTrue($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property1]));
-		$this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property2]));
-		$this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property3]));
-	}
-
-	public static function propFindDefaultCalendarUrlProvider(): array {
-		return [
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				true
-			],
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				true,
-				true
-			],
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				false,
-				false,
-				true
-			],
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				false
-			],
-			[
-				'principals/users/myuser',
-				null,
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				true
-			],
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				true,
-				false,
-				false,
-				false,
-			],
-			[
-				'principals/users/myuser',
-				'calendars/myuser',
-				false,
-				'my_other_calendar',
-				'My Other Calendar',
-				true
-			],
-			[
-				'principals/calendar-resources',
-				'system-calendars/calendar-resources/myuser',
-				true,
-				CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
-				CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
-				true
-			],
-			[
-				'principals/calendar-resources',
-				'system-calendars/calendar-resources/myuser',
-				true,
-				CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
-				CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
-				false
-			],
-			[
-				'principals/something-else',
-				'calendars/whatever',
-				false,
-				CalDavBackend::PERSONAL_CALENDAR_URI,
-				CalDavBackend::PERSONAL_CALENDAR_NAME,
-				true
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('propFindDefaultCalendarUrlProvider')]
-	public function testPropFindDefaultCalendarUrl(string $principalUri, ?string $calendarHome, bool $isResource, string $calendarUri, string $displayName, bool $exists, bool $deleted = false, bool $hasExistingCalendars = false, bool $propertiesForPath = true): void {
-		$propFind = new PropFind(
-			$principalUri,
-			[
-				Plugin::SCHEDULE_DEFAULT_CALENDAR_URL
-			],
-			0
-		);
-		/** @var IPrincipal&MockObject $node */
-		$node = $this->getMockBuilder(IPrincipal::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$node->expects($this->once())
-			->method('getPrincipalUrl')
-			->with()
-			->willReturn($principalUri);
-
-		$calDAVPlugin = $this->getMockBuilder(CalDAVPlugin::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$calDAVPlugin->expects($this->once())
-			->method('getCalendarHomeForPrincipal')
-			->willReturn($calendarHome);
-
-		$this->server->expects($this->once())
-			->method('getPlugin')
-			->with('caldav')
-			->willReturn($calDAVPlugin);
-		if (!$calendarHome) {
-			$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
-
-			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
-			return;
-		}
-		if ($principalUri === 'principals/something-else') {
-			$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
-
-			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
-			return;
-		}
-
-		if (!$isResource) {
-			$this->config->expects($this->once())
-				->method('getUserValue')
-				->with('myuser', 'dav', 'defaultCalendar', CalDavBackend::PERSONAL_CALENDAR_URI)
-				->willReturn($calendarUri);
-		}
-
-		$calendarHomeObject = $this->createMock(CalendarHome::class);
-		$calendarHomeObject->expects($this->once())
-			->method('childExists')
-			->with($calendarUri)
-			->willReturn($exists);
-
-		if ($exists) {
-			$calendar = $this->createMock(Calendar::class);
-			$calendar->expects($this->once())->method('isDeleted')->willReturn($deleted);
-			$calendarHomeObject->expects($deleted && !$hasExistingCalendars ? $this->exactly(2) : $this->once())->method('getChild')->with($calendarUri)->willReturn($calendar);
-		}
-
-		$calendarBackend = $this->createMock(CalDavBackend::class);
-		$calendarUri = $hasExistingCalendars ? 'custom' : $calendarUri;
-		$displayName = $hasExistingCalendars ? 'Custom Calendar' : $displayName;
-
-		$existingCalendars = $hasExistingCalendars ? [
-			new Calendar(
-				$calendarBackend,
-				['uri' => 'deleted', '{DAV:}displayname' => 'A deleted calendar', TrashbinPlugin::PROPERTY_DELETED_AT => 42],
-				$this->createMock(IL10N::class),
-				$this->config,
-				$this->createMock(LoggerInterface::class)
-			),
-			new Calendar(
-				$calendarBackend,
-				['uri' => $calendarUri, '{DAV:}displayname' => $displayName],
-				$this->createMock(IL10N::class),
-				$this->config,
-				$this->createMock(LoggerInterface::class)
-			)
-		] : [];
-
-		if (!$exists || $deleted) {
-			if (!$hasExistingCalendars) {
-				$calendarBackend->expects($this->once())
-					->method('createCalendar')
-					->with($principalUri, $calendarUri, [
-						'{DAV:}displayname' => $displayName,
-					]);
-
-				$calendarHomeObject->expects($this->exactly($deleted ? 2 : 1))
-					->method('getCalDAVBackend')
-					->with()
-					->willReturn($calendarBackend);
-			}
-
-			if (!$isResource) {
-				$calendarHomeObject->expects($this->once())
-					->method('getChildren')
-					->with()
-					->willReturn($existingCalendars);
-			}
-		}
-
-		/** @var Tree&MockObject $tree */
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->once())
-			->method('getNodeForPath')
-			->with($calendarHome)
-			->willReturn($calendarHomeObject);
-		$this->server->tree = $tree;
-
-		$properties = $propertiesForPath ? [
-			['href' => '/remote.php/dav/' . $calendarHome . '/' . $calendarUri]
-		] : [];
-
-		$this->server->expects($this->once())
-			->method('getPropertiesForPath')
-			->with($calendarHome . '/' . $calendarUri, [], 1)
-			->willReturn($properties);
-
-		$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
-
-		if (!$propertiesForPath) {
-			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
-			return;
-		}
-
-		/** @var LocalHref $result */
-		$result = $propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL);
-		$this->assertEquals('/remote.php/dav/' . $calendarHome . '/' . $calendarUri, $result->getHref());
-	}
-
-	/**
-	 * Test Calendar Event Creation for Personal Calendar
-	 *
-	 * Should generate 2 messages for attendees User 2 and User External
-	 */
-	public function testCalendarObjectChangePersonalCalendarCreate(): void {
-
-		// define place holders
-		/** @var Message[] $iTipMessages */
-		$iTipMessages = [];
-		// construct calendar node
-		$calendarNode = new Calendar(
-			$this->createMock(BackendInterface::class),
-			[
-				'uri' => 'personal',
-				'principaluri' => 'principals/users/user1',
-				'{DAV:}displayname' => 'Calendar Shared By User1',
-			],
-			$this->createMock(IL10N::class),
-			$this->config,
-			$this->logger
-		);
-		// construct server request object
-		$request = new Request(
-			'PUT',
-			'/remote.php/dav/calendars/user1/personal/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
-		);
-		$request->setBaseUrl('/remote.php/dav/');
-		// construct server response object
-		$response = new Response();
-		// construct server tree object
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->once())
-			->method('getNodeForPath')
-			->with('calendars/user1/personal')
-			->willReturn($calendarNode);
-		// construct server properties and returns
-		$this->server->httpRequest = $request;
-		$this->server->tree = $tree;
-		$this->server->expects($this->exactly(1))->method('getProperties')
-			->willReturnMap([
-				[
-					'principals/users/user1',
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
-					)]
-				]
-			]);
-		$this->server->expects($this->exactly(2))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
-				$this->assertEquals('schedule', $eventName);
-				$this->assertCount(1, $arguments);
-				$iTipMessages[] = $arguments[0];
-				return true;
-			}
-		);
-		// construct calendar with a 1 hour event and same start/end time zones
-		$vCalendar = new VCalendar();
-		$vEvent = $vCalendar->add('VEVENT', []);
-		$vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
-		$vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('SUMMARY', 'Test Recurring Event');
-		$vEvent->add('ORGANIZER', 'mailto:user1@testing.local', ['CN' => 'User One']);
-		$vEvent->add('ATTENDEE', 'mailto:user2@testing.local', [
-			'CN' => 'User Two',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		$vEvent->add('ATTENDEE', 'mailto:user@external.local', [
-			'CN' => 'User External',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		// define flags
-		$newFlag = true;
-		$modifiedFlag = false;
-		// execute method
-		$this->plugin->calendarObjectChange(
-			$request,
-			$response,
-			$vCalendar,
-			'calendars/user1/personal',
-			$modifiedFlag,
-			$newFlag
-		);
-		// test for correct iTip message count
-		$this->assertCount(2, $iTipMessages);
-		// test for Sharer Attendee
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->sender);
-		$this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->recipient);
-		$this->assertTrue($iTipMessages[0]->significantChange);
-		// test for External Attendee
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[1]->sender);
-		$this->assertEquals('mailto:user@external.local', $iTipMessages[1]->recipient);
-		$this->assertTrue($iTipMessages[1]->significantChange);
-
-	}
-
-	/**
-	 * Test Calendar Event Creation for Shared Calendar as Sharer/Owner
-	 *
-	 * Should generate 3 messages for attendees User 2 (Sharee), User 3 (Non-Sharee) and User External
-	 */
-	public function testCalendarObjectChangeSharedCalendarSharerCreate(): void {
-
-		// define place holders
-		/** @var Message[] $iTipMessages */
-		$iTipMessages = [];
-		// construct calendar node
-		$calendarNode = new Calendar(
-			$this->createMock(BackendInterface::class),
-			[
-				'uri' => 'calendar_shared_by_user1',
-				'principaluri' => 'principals/users/user1',
-				'{DAV:}displayname' => 'Calendar Shared By User1',
-				'{http://owncloud.org/ns}owner-principal' => 'principals/users/user1'
-			],
-			$this->createMock(IL10N::class),
-			$this->config,
-			$this->logger
-		);
-		// construct server request object
-		$request = new Request(
-			'PUT',
-			'/remote.php/dav/calendars/user1/calendar_shared_by_user1/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
-		);
-		$request->setBaseUrl('/remote.php/dav/');
-		// construct server response object
-		$response = new Response();
-		// construct server tree object
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->once())
-			->method('getNodeForPath')
-			->with('calendars/user1/calendar_shared_by_user1')
-			->willReturn($calendarNode);
-		// construct server properties and returns
-		$this->server->httpRequest = $request;
-		$this->server->tree = $tree;
-		$this->server->expects($this->exactly(1))->method('getProperties')
-			->willReturnMap([
-				[
-					'principals/users/user1',
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
-					)]
-				]
-			]);
-		$this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
-				$this->assertEquals('schedule', $eventName);
-				$this->assertCount(1, $arguments);
-				$iTipMessages[] = $arguments[0];
-				return true;
-			}
-		);
-		// construct calendar with a 1 hour event and same start/end time zones
-		$vCalendar = new VCalendar();
-		$vEvent = $vCalendar->add('VEVENT', []);
-		$vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
-		$vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('SUMMARY', 'Test Recurring Event');
-		$vEvent->add('ORGANIZER', 'mailto:user1@testing.local', ['CN' => 'User One']);
-		$vEvent->add('ATTENDEE', 'mailto:user2@testing.local', [
-			'CN' => 'User Two',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		$vEvent->add('ATTENDEE', 'mailto:user3@testing.local', [
-			'CN' => 'User Three',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		$vEvent->add('ATTENDEE', 'mailto:user@external.local', [
-			'CN' => 'User External',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		// define flags
-		$newFlag = true;
-		$modifiedFlag = false;
-		// execute method
-		$this->plugin->calendarObjectChange(
-			$request,
-			$response,
-			$vCalendar,
-			'calendars/user1/calendar_shared_by_user1',
-			$modifiedFlag,
-			$newFlag
-		);
-		// test for correct iTip message count
-		$this->assertCount(3, $iTipMessages);
-		// test for Sharer Attendee
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->sender);
-		$this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->recipient);
-		$this->assertTrue($iTipMessages[0]->significantChange);
-		// test for Non Shee Attendee
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[1]->sender);
-		$this->assertEquals('mailto:user3@testing.local', $iTipMessages[1]->recipient);
-		$this->assertTrue($iTipMessages[1]->significantChange);
-		// test for External Attendee
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[2]->sender);
-		$this->assertEquals('mailto:user@external.local', $iTipMessages[2]->recipient);
-		$this->assertTrue($iTipMessages[2]->significantChange);
-
-	}
-
-	/**
-	 * Test Calendar Event Creation for Shared Calendar as Shree
-	 *
-	 * Should generate 3 messages for attendees User 1 (Sharer/Owner), User 3 (Non-Sharee) and User External
-	 */
-	public function testCalendarObjectChangeSharedCalendarShreeCreate(): void {
-
-		// define place holders
-		/** @var Message[] $iTipMessages */
-		$iTipMessages = [];
-		// construct calendar node
-		$calendarNode = new Calendar(
-			$this->createMock(BackendInterface::class),
-			[
-				'uri' => 'calendar_shared_by_user1',
-				'principaluri' => 'principals/users/user2',
-				'{DAV:}displayname' => 'Calendar Shared By User1',
-				'{http://owncloud.org/ns}owner-principal' => 'principals/users/user1'
-			],
-			$this->createMock(IL10N::class),
-			$this->config,
-			$this->logger
-		);
-		// construct server request object
-		$request = new Request(
-			'PUT',
-			'/remote.php/dav/calendars/user2/calendar_shared_by_user1/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
-		);
-		$request->setBaseUrl('/remote.php/dav/');
-		// construct server response object
-		$response = new Response();
-		// construct server tree object
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->once())
-			->method('getNodeForPath')
-			->with('calendars/user2/calendar_shared_by_user1')
-			->willReturn($calendarNode);
-		// construct server properties and returns
-		$this->server->httpRequest = $request;
-		$this->server->tree = $tree;
-		$this->server->expects($this->exactly(2))->method('getProperties')
-			->willReturnMap([
-				[
-					'principals/users/user1',
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
-					)]
-				],
-				[
-					'principals/users/user2',
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
-					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user2@testing.local','/remote.php/dav/principals/users/user2/']
-					)]
-				]
-			]);
-		$this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
-				$this->assertEquals('schedule', $eventName);
-				$this->assertCount(1, $arguments);
-				$iTipMessages[] = $arguments[0];
-				return true;
-			}
-		);
-		// construct calendar with a 1 hour event and same start/end time zones
-		$vCalendar = new VCalendar();
-		$vEvent = $vCalendar->add('VEVENT', []);
-		$vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
-		$vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
-		$vEvent->add('SUMMARY', 'Test Recurring Event');
-		$vEvent->add('ORGANIZER', 'mailto:user2@testing.local', ['CN' => 'User Two']);
-		$vEvent->add('ATTENDEE', 'mailto:user1@testing.local', [
-			'CN' => 'User One',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		$vEvent->add('ATTENDEE', 'mailto:user3@testing.local', [
-			'CN' => 'User Three',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		$vEvent->add('ATTENDEE', 'mailto:user@external.local', [
-			'CN' => 'User External',
-			'CUTYPE' => 'INDIVIDUAL',
-			'PARTSTAT' => 'NEEDS-ACTION',
-			'ROLE' => 'REQ-PARTICIPANT',
-			'RSVP' => 'TRUE'
-		]);
-		// define flags
-		$newFlag = true;
-		$modifiedFlag = false;
-		// execute method
-		$this->plugin->calendarObjectChange(
-			$request,
-			$response,
-			$vCalendar,
-			'calendars/user2/calendar_shared_by_user1',
-			$modifiedFlag,
-			$newFlag
-		);
-		// test for correct iTip message count
-		$this->assertCount(3, $iTipMessages);
-		// test for Sharer Attendee
-		$this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->sender);
-		$this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->recipient);
-		$this->assertTrue($iTipMessages[0]->significantChange);
-		// test for Non Shee Attendee
-		$this->assertEquals('mailto:user2@testing.local', $iTipMessages[1]->sender);
-		$this->assertEquals('mailto:user3@testing.local', $iTipMessages[1]->recipient);
-		$this->assertTrue($iTipMessages[1]->significantChange);
-		// test for External Attendee
-		$this->assertEquals('mailto:user2@testing.local', $iTipMessages[2]->sender);
-		$this->assertEquals('mailto:user@external.local', $iTipMessages[2]->recipient);
-		$this->assertTrue($iTipMessages[2]->significantChange);
-
-	}
-
-	/**
-	 * Test Calendar Event Creation with iTip and iMip disabled
-	 *
-	 * Should generate 2 messages for attendees User 2 and User External
-	 */
-	public function testCalendarObjectChangeWithSchedulingDisabled(): void {
-		// construct server request
-		$request = new Request(
-			'PUT',
-			'/remote.php/dav/calendars/user1/personal/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics',
-			['x-nc-scheduling' => 'false']
-		);
-		$request->setBaseUrl('/remote.php/dav/');
-		// construct server response
-		$response = new Response();
-		// construct server tree
-		$tree = $this->createMock(Tree::class);
-		$tree->expects($this->never())
-			->method('getNodeForPath');
-		// construct server properties and returns
-		$this->server->httpRequest = $request;
-		$this->server->tree = $tree;
-		// construct empty calendar event
-		$vCalendar = new VCalendar();
-		$vEvent = $vCalendar->add('VEVENT', []);
-		// define flags
-		$newFlag = true;
-		$modifiedFlag = false;
-		// execute method
-		$this->plugin->calendarObjectChange(
-			$request,
-			$response,
-			$vCalendar,
-			'calendars/user1/personal',
-			$modifiedFlag,
-			$newFlag
-		);
-	}
+    private Plugin $plugin;
+    private Server&MockObject $server;
+    private IConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private DefaultCalendarValidator $calendarValidator;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->calendarValidator = new DefaultCalendarValidator();
+
+        $this->server = $this->createMock(Server::class);
+        $this->server->httpResponse = $this->createMock(ResponseInterface::class);
+        $this->server->xml = new Service();
+
+        $this->plugin = new Plugin($this->config, $this->logger, $this->calendarValidator);
+        $this->plugin->initialize($this->server);
+    }
+
+    public function testInitialize(): void {
+        $calls = [
+            // Sabre\CalDAV\Schedule\Plugin events
+            ['method:POST', [$this->plugin, 'httpPost'], 100],
+            ['propFind', [$this->plugin, 'propFind'], 100],
+            ['propPatch', [$this->plugin, 'propPatch'], 100],
+            ['calendarObjectChange', [$this->plugin, 'calendarObjectChange'], 100],
+            ['beforeUnbind', [$this->plugin, 'beforeUnbind'], 100],
+            ['schedule', [$this->plugin, 'scheduleLocalDelivery'], 100],
+            ['getSupportedPrivilegeSet', [$this->plugin, 'getSupportedPrivilegeSet'], 100],
+            // OCA\DAV\CalDAV\Schedule\Plugin events
+            ['propFind', [$this->plugin, 'propFindDefaultCalendarUrl'], 90],
+            ['afterWriteContent', [$this->plugin, 'dispatchSchedulingResponses'], 100],
+            ['afterCreateFile', [$this->plugin, 'dispatchSchedulingResponses'], 100],
+        ];
+        $this->server->expects($this->exactly(count($calls)))
+            ->method('on')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        $this->plugin->initialize($this->server);
+    }
+
+    public function testGetAddressesForPrincipal(): void {
+        $href = $this->createMock(Href::class);
+        $href
+            ->expects($this->once())
+            ->method('getHrefs')
+            ->willReturn(['lukas@nextcloud.com', 'rullzer@nextcloud.com']);
+        $this->server
+            ->expects($this->once())
+            ->method('getProperties')
+            ->with(
+                'MyPrincipal',
+                [
+                    '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set',
+                ]
+            )
+            ->willReturn([
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => $href
+            ]);
+
+        $result = $this->invokePrivate($this->plugin, 'getAddressesForPrincipal', ['MyPrincipal']);
+        $this->assertSame(['lukas@nextcloud.com', 'rullzer@nextcloud.com'], $result);
+    }
+
+    public function testGetAddressesForPrincipalEmpty(): void {
+        $this->server
+            ->expects($this->once())
+            ->method('getProperties')
+            ->with(
+                'MyPrincipal',
+                [
+                    '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set',
+                ]
+            )
+            ->willReturn(null);
+
+        $result = $this->invokePrivate($this->plugin, 'getAddressesForPrincipal', ['MyPrincipal']);
+        $this->assertSame([], $result);
+    }
+
+    public function testStripOffMailTo(): void {
+        $this->assertEquals('test@example.com', $this->invokePrivate($this->plugin, 'stripOffMailTo', ['test@example.com']));
+        $this->assertEquals('test@example.com', $this->invokePrivate($this->plugin, 'stripOffMailTo', ['mailto:test@example.com']));
+    }
+
+    public function testGetAttendeeRSVP(): void {
+        $property1 = $this->createMock(CalAddress::class);
+        $parameter1 = $this->createMock(Parameter::class);
+        $property1->expects($this->once())
+            ->method('offsetGet')
+            ->with('RSVP')
+            ->willReturn($parameter1);
+        $parameter1->expects($this->once())
+            ->method('getValue')
+            ->with()
+            ->willReturn('TRUE');
+
+        $property2 = $this->createMock(CalAddress::class);
+        $parameter2 = $this->createMock(Parameter::class);
+        $property2->expects($this->once())
+            ->method('offsetGet')
+            ->with('RSVP')
+            ->willReturn($parameter2);
+        $parameter2->expects($this->once())
+            ->method('getValue')
+            ->with()
+            ->willReturn('FALSE');
+
+        $property3 = $this->createMock(CalAddress::class);
+        $property3->expects($this->once())
+            ->method('offsetGet')
+            ->with('RSVP')
+            ->willReturn(null);
+
+        $this->assertTrue($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property1]));
+        $this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property2]));
+        $this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property3]));
+    }
+
+    public static function propFindDefaultCalendarUrlProvider(): array {
+        return [
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                true
+            ],
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                true,
+                true
+            ],
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                false,
+                false,
+                true
+            ],
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                false
+            ],
+            [
+                'principals/users/myuser',
+                null,
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                true
+            ],
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                true,
+                false,
+                false,
+                false,
+            ],
+            [
+                'principals/users/myuser',
+                'calendars/myuser',
+                false,
+                'my_other_calendar',
+                'My Other Calendar',
+                true
+            ],
+            [
+                'principals/calendar-resources',
+                'system-calendars/calendar-resources/myuser',
+                true,
+                CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
+                CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
+                true
+            ],
+            [
+                'principals/calendar-resources',
+                'system-calendars/calendar-resources/myuser',
+                true,
+                CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
+                CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
+                false
+            ],
+            [
+                'principals/something-else',
+                'calendars/whatever',
+                false,
+                CalDavBackend::PERSONAL_CALENDAR_URI,
+                CalDavBackend::PERSONAL_CALENDAR_NAME,
+                true
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('propFindDefaultCalendarUrlProvider')]
+    public function testPropFindDefaultCalendarUrl(string $principalUri, ?string $calendarHome, bool $isResource, string $calendarUri, string $displayName, bool $exists, bool $deleted = false, bool $hasExistingCalendars = false, bool $propertiesForPath = true): void {
+        $propFind = new PropFind(
+            $principalUri,
+            [
+                Plugin::SCHEDULE_DEFAULT_CALENDAR_URL
+            ],
+            0
+        );
+        /** @var IPrincipal&MockObject $node */
+        $node = $this->getMockBuilder(IPrincipal::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $node->expects($this->once())
+            ->method('getPrincipalUrl')
+            ->with()
+            ->willReturn($principalUri);
+
+        $calDAVPlugin = $this->getMockBuilder(CalDAVPlugin::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $calDAVPlugin->expects($this->once())
+            ->method('getCalendarHomeForPrincipal')
+            ->willReturn($calendarHome);
+
+        $this->server->expects($this->once())
+            ->method('getPlugin')
+            ->with('caldav')
+            ->willReturn($calDAVPlugin);
+        if (!$calendarHome) {
+            $this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+            $this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+            return;
+        }
+        if ($principalUri === 'principals/something-else') {
+            $this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+            $this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+            return;
+        }
+
+        if (!$isResource) {
+            $this->config->expects($this->once())
+                ->method('getUserValue')
+                ->with('myuser', 'dav', 'defaultCalendar', CalDavBackend::PERSONAL_CALENDAR_URI)
+                ->willReturn($calendarUri);
+        }
+
+        $calendarHomeObject = $this->createMock(CalendarHome::class);
+        $calendarHomeObject->expects($this->once())
+            ->method('childExists')
+            ->with($calendarUri)
+            ->willReturn($exists);
+
+        if ($exists) {
+            $calendar = $this->createMock(Calendar::class);
+            $calendar->expects($this->once())->method('isDeleted')->willReturn($deleted);
+            $calendarHomeObject->expects($deleted && !$hasExistingCalendars ? $this->exactly(2) : $this->once())->method('getChild')->with($calendarUri)->willReturn($calendar);
+        }
+
+        $calendarBackend = $this->createMock(CalDavBackend::class);
+        $calendarUri = $hasExistingCalendars ? 'custom' : $calendarUri;
+        $displayName = $hasExistingCalendars ? 'Custom Calendar' : $displayName;
+
+        $existingCalendars = $hasExistingCalendars ? [
+            new Calendar(
+                $calendarBackend,
+                ['uri' => 'deleted', '{DAV:}displayname' => 'A deleted calendar', TrashbinPlugin::PROPERTY_DELETED_AT => 42],
+                $this->createMock(IL10N::class),
+                $this->config,
+                $this->createMock(LoggerInterface::class)
+            ),
+            new Calendar(
+                $calendarBackend,
+                ['uri' => $calendarUri, '{DAV:}displayname' => $displayName],
+                $this->createMock(IL10N::class),
+                $this->config,
+                $this->createMock(LoggerInterface::class)
+            )
+        ] : [];
+
+        if (!$exists || $deleted) {
+            if (!$hasExistingCalendars) {
+                $calendarBackend->expects($this->once())
+                    ->method('createCalendar')
+                    ->with($principalUri, $calendarUri, [
+                        '{DAV:}displayname' => $displayName,
+                    ]);
+
+                $calendarHomeObject->expects($this->exactly($deleted ? 2 : 1))
+                    ->method('getCalDAVBackend')
+                    ->with()
+                    ->willReturn($calendarBackend);
+            }
+
+            if (!$isResource) {
+                $calendarHomeObject->expects($this->once())
+                    ->method('getChildren')
+                    ->with()
+                    ->willReturn($existingCalendars);
+            }
+        }
+
+        /** @var Tree&MockObject $tree */
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with($calendarHome)
+            ->willReturn($calendarHomeObject);
+        $this->server->tree = $tree;
+
+        $properties = $propertiesForPath ? [
+            ['href' => '/remote.php/dav/' . $calendarHome . '/' . $calendarUri]
+        ] : [];
+
+        $this->server->expects($this->once())
+            ->method('getPropertiesForPath')
+            ->with($calendarHome . '/' . $calendarUri, [], 1)
+            ->willReturn($properties);
+
+        $this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+        if (!$propertiesForPath) {
+            $this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+            return;
+        }
+
+        /** @var LocalHref $result */
+        $result = $propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL);
+        $this->assertEquals('/remote.php/dav/' . $calendarHome . '/' . $calendarUri, $result->getHref());
+    }
+
+    /**
+     * Test Calendar Event Creation for Personal Calendar
+     *
+     * Should generate 2 messages for attendees User 2 and User External
+     */
+    public function testCalendarObjectChangePersonalCalendarCreate(): void {
+
+        // define place holders
+        /** @var Message[] $iTipMessages */
+        $iTipMessages = [];
+        // construct calendar node
+        $calendarNode = new Calendar(
+            $this->createMock(BackendInterface::class),
+            [
+                'uri' => 'personal',
+                'principaluri' => 'principals/users/user1',
+                '{DAV:}displayname' => 'Calendar Shared By User1',
+            ],
+            $this->createMock(IL10N::class),
+            $this->config,
+            $this->logger
+        );
+        // construct server request object
+        $request = new Request(
+            'PUT',
+            '/remote.php/dav/calendars/user1/personal/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
+        );
+        $request->setBaseUrl('/remote.php/dav/');
+        // construct server response object
+        $response = new Response();
+        // construct server tree object
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('calendars/user1/personal')
+            ->willReturn($calendarNode);
+        // construct server properties and returns
+        $this->server->httpRequest = $request;
+        $this->server->tree = $tree;
+        $this->server->expects($this->exactly(1))->method('getProperties')
+            ->willReturnMap([
+                [
+                    'principals/users/user1',
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
+                        ['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+                    )]
+                ]
+            ]);
+        $this->server->expects($this->exactly(2))->method('emit')->willReturnCallback(
+            function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+                $this->assertEquals('schedule', $eventName);
+                $this->assertCount(1, $arguments);
+                $iTipMessages[] = $arguments[0];
+                return true;
+            }
+        );
+        // construct calendar with a 1 hour event and same start/end time zones
+        $vCalendar = new VCalendar();
+        $vEvent = $vCalendar->add('VEVENT', []);
+        $vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
+        $vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('SUMMARY', 'Test Recurring Event');
+        $vEvent->add('ORGANIZER', 'mailto:user1@testing.local', ['CN' => 'User One']);
+        $vEvent->add('ATTENDEE', 'mailto:user2@testing.local', [
+            'CN' => 'User Two',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        $vEvent->add('ATTENDEE', 'mailto:user@external.local', [
+            'CN' => 'User External',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        // define flags
+        $newFlag = true;
+        $modifiedFlag = false;
+        // execute method
+        $this->plugin->calendarObjectChange(
+            $request,
+            $response,
+            $vCalendar,
+            'calendars/user1/personal',
+            $modifiedFlag,
+            $newFlag
+        );
+        // test for correct iTip message count
+        $this->assertCount(2, $iTipMessages);
+        // test for Sharer Attendee
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->sender);
+        $this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->recipient);
+        $this->assertTrue($iTipMessages[0]->significantChange);
+        // test for External Attendee
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[1]->sender);
+        $this->assertEquals('mailto:user@external.local', $iTipMessages[1]->recipient);
+        $this->assertTrue($iTipMessages[1]->significantChange);
+
+    }
+
+    /**
+     * Test Calendar Event Creation for Shared Calendar as Sharer/Owner
+     *
+     * Should generate 3 messages for attendees User 2 (Sharee), User 3 (Non-Sharee) and User External
+     */
+    public function testCalendarObjectChangeSharedCalendarSharerCreate(): void {
+
+        // define place holders
+        /** @var Message[] $iTipMessages */
+        $iTipMessages = [];
+        // construct calendar node
+        $calendarNode = new Calendar(
+            $this->createMock(BackendInterface::class),
+            [
+                'uri' => 'calendar_shared_by_user1',
+                'principaluri' => 'principals/users/user1',
+                '{DAV:}displayname' => 'Calendar Shared By User1',
+                '{http://owncloud.org/ns}owner-principal' => 'principals/users/user1'
+            ],
+            $this->createMock(IL10N::class),
+            $this->config,
+            $this->logger
+        );
+        // construct server request object
+        $request = new Request(
+            'PUT',
+            '/remote.php/dav/calendars/user1/calendar_shared_by_user1/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
+        );
+        $request->setBaseUrl('/remote.php/dav/');
+        // construct server response object
+        $response = new Response();
+        // construct server tree object
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('calendars/user1/calendar_shared_by_user1')
+            ->willReturn($calendarNode);
+        // construct server properties and returns
+        $this->server->httpRequest = $request;
+        $this->server->tree = $tree;
+        $this->server->expects($this->exactly(1))->method('getProperties')
+            ->willReturnMap([
+                [
+                    'principals/users/user1',
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
+                        ['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+                    )]
+                ]
+            ]);
+        $this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
+            function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+                $this->assertEquals('schedule', $eventName);
+                $this->assertCount(1, $arguments);
+                $iTipMessages[] = $arguments[0];
+                return true;
+            }
+        );
+        // construct calendar with a 1 hour event and same start/end time zones
+        $vCalendar = new VCalendar();
+        $vEvent = $vCalendar->add('VEVENT', []);
+        $vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
+        $vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('SUMMARY', 'Test Recurring Event');
+        $vEvent->add('ORGANIZER', 'mailto:user1@testing.local', ['CN' => 'User One']);
+        $vEvent->add('ATTENDEE', 'mailto:user2@testing.local', [
+            'CN' => 'User Two',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        $vEvent->add('ATTENDEE', 'mailto:user3@testing.local', [
+            'CN' => 'User Three',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        $vEvent->add('ATTENDEE', 'mailto:user@external.local', [
+            'CN' => 'User External',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        // define flags
+        $newFlag = true;
+        $modifiedFlag = false;
+        // execute method
+        $this->plugin->calendarObjectChange(
+            $request,
+            $response,
+            $vCalendar,
+            'calendars/user1/calendar_shared_by_user1',
+            $modifiedFlag,
+            $newFlag
+        );
+        // test for correct iTip message count
+        $this->assertCount(3, $iTipMessages);
+        // test for Sharer Attendee
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->sender);
+        $this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->recipient);
+        $this->assertTrue($iTipMessages[0]->significantChange);
+        // test for Non Shee Attendee
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[1]->sender);
+        $this->assertEquals('mailto:user3@testing.local', $iTipMessages[1]->recipient);
+        $this->assertTrue($iTipMessages[1]->significantChange);
+        // test for External Attendee
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[2]->sender);
+        $this->assertEquals('mailto:user@external.local', $iTipMessages[2]->recipient);
+        $this->assertTrue($iTipMessages[2]->significantChange);
+
+    }
+
+    /**
+     * Test Calendar Event Creation for Shared Calendar as Shree
+     *
+     * Should generate 3 messages for attendees User 1 (Sharer/Owner), User 3 (Non-Sharee) and User External
+     */
+    public function testCalendarObjectChangeSharedCalendarShreeCreate(): void {
+
+        // define place holders
+        /** @var Message[] $iTipMessages */
+        $iTipMessages = [];
+        // construct calendar node
+        $calendarNode = new Calendar(
+            $this->createMock(BackendInterface::class),
+            [
+                'uri' => 'calendar_shared_by_user1',
+                'principaluri' => 'principals/users/user2',
+                '{DAV:}displayname' => 'Calendar Shared By User1',
+                '{http://owncloud.org/ns}owner-principal' => 'principals/users/user1'
+            ],
+            $this->createMock(IL10N::class),
+            $this->config,
+            $this->logger
+        );
+        // construct server request object
+        $request = new Request(
+            'PUT',
+            '/remote.php/dav/calendars/user2/calendar_shared_by_user1/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics'
+        );
+        $request->setBaseUrl('/remote.php/dav/');
+        // construct server response object
+        $response = new Response();
+        // construct server tree object
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('calendars/user2/calendar_shared_by_user1')
+            ->willReturn($calendarNode);
+        // construct server properties and returns
+        $this->server->httpRequest = $request;
+        $this->server->tree = $tree;
+        $this->server->expects($this->exactly(2))->method('getProperties')
+            ->willReturnMap([
+                [
+                    'principals/users/user1',
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
+                        ['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+                    )]
+                ],
+                [
+                    'principals/users/user2',
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
+                    ['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
+                        ['mailto:user2@testing.local','/remote.php/dav/principals/users/user2/']
+                    )]
+                ]
+            ]);
+        $this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
+            function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+                $this->assertEquals('schedule', $eventName);
+                $this->assertCount(1, $arguments);
+                $iTipMessages[] = $arguments[0];
+                return true;
+            }
+        );
+        // construct calendar with a 1 hour event and same start/end time zones
+        $vCalendar = new VCalendar();
+        $vEvent = $vCalendar->add('VEVENT', []);
+        $vEvent->UID->setValue('96a0e6b1-d886-4a55-a60d-152b31401dcc');
+        $vEvent->add('DTSTART', '20240701T080000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('DTEND', '20240701T090000', ['TZID' => 'America/Toronto']);
+        $vEvent->add('SUMMARY', 'Test Recurring Event');
+        $vEvent->add('ORGANIZER', 'mailto:user2@testing.local', ['CN' => 'User Two']);
+        $vEvent->add('ATTENDEE', 'mailto:user1@testing.local', [
+            'CN' => 'User One',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        $vEvent->add('ATTENDEE', 'mailto:user3@testing.local', [
+            'CN' => 'User Three',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        $vEvent->add('ATTENDEE', 'mailto:user@external.local', [
+            'CN' => 'User External',
+            'CUTYPE' => 'INDIVIDUAL',
+            'PARTSTAT' => 'NEEDS-ACTION',
+            'ROLE' => 'REQ-PARTICIPANT',
+            'RSVP' => 'TRUE'
+        ]);
+        // define flags
+        $newFlag = true;
+        $modifiedFlag = false;
+        // execute method
+        $this->plugin->calendarObjectChange(
+            $request,
+            $response,
+            $vCalendar,
+            'calendars/user2/calendar_shared_by_user1',
+            $modifiedFlag,
+            $newFlag
+        );
+        // test for correct iTip message count
+        $this->assertCount(3, $iTipMessages);
+        // test for Sharer Attendee
+        $this->assertEquals('mailto:user2@testing.local', $iTipMessages[0]->sender);
+        $this->assertEquals('mailto:user1@testing.local', $iTipMessages[0]->recipient);
+        $this->assertTrue($iTipMessages[0]->significantChange);
+        // test for Non Shee Attendee
+        $this->assertEquals('mailto:user2@testing.local', $iTipMessages[1]->sender);
+        $this->assertEquals('mailto:user3@testing.local', $iTipMessages[1]->recipient);
+        $this->assertTrue($iTipMessages[1]->significantChange);
+        // test for External Attendee
+        $this->assertEquals('mailto:user2@testing.local', $iTipMessages[2]->sender);
+        $this->assertEquals('mailto:user@external.local', $iTipMessages[2]->recipient);
+        $this->assertTrue($iTipMessages[2]->significantChange);
+
+    }
+
+    /**
+     * Test Calendar Event Creation with iTip and iMip disabled
+     *
+     * Should generate 2 messages for attendees User 2 and User External
+     */
+    public function testCalendarObjectChangeWithSchedulingDisabled(): void {
+        // construct server request
+        $request = new Request(
+            'PUT',
+            '/remote.php/dav/calendars/user1/personal/B0DC78AE-6DD7-47E3-80BE-89F23E6D5383.ics',
+            ['x-nc-scheduling' => 'false']
+        );
+        $request->setBaseUrl('/remote.php/dav/');
+        // construct server response
+        $response = new Response();
+        // construct server tree
+        $tree = $this->createMock(Tree::class);
+        $tree->expects($this->never())
+            ->method('getNodeForPath');
+        // construct server properties and returns
+        $this->server->httpRequest = $request;
+        $this->server->tree = $tree;
+        // construct empty calendar event
+        $vCalendar = new VCalendar();
+        $vEvent = $vCalendar->add('VEVENT', []);
+        // define flags
+        $newFlag = true;
+        $modifiedFlag = false;
+        // execute method
+        $this->plugin->calendarObjectChange(
+            $request,
+            $response,
+            $vCalendar,
+            'calendars/user1/personal',
+            $modifiedFlag,
+            $newFlag
+        );
+    }
 }

Spacing +11 added lines, -11 removed lines

@@ -74,7 +74,7 @@ 
 		];
 		$this->server->expects($this->exactly(count($calls)))
 			->method('on')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -366,12 +366,12 @@ 
 		$this->server->tree = $tree;
 
 		$properties = $propertiesForPath ? [
-			['href' => '/remote.php/dav/' . $calendarHome . '/' . $calendarUri]
+			['href' => '/remote.php/dav/'.$calendarHome.'/'.$calendarUri]
 		] : [];
 
 		$this->server->expects($this->once())
 			->method('getPropertiesForPath')
-			->with($calendarHome . '/' . $calendarUri, [], 1)
+			->with($calendarHome.'/'.$calendarUri, [], 1)
 			->willReturn($properties);
 
 		$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
@@ -383,7 +383,7 @@ 
 
 		/** @var LocalHref $result */
 		$result = $propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL);
-		$this->assertEquals('/remote.php/dav/' . $calendarHome . '/' . $calendarUri, $result->getHref());
+		$this->assertEquals('/remote.php/dav/'.$calendarHome.'/'.$calendarUri, $result->getHref());
 	}
 
 	/**
@@ -431,12 +431,12 @@ 
 					'principals/users/user1',
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+						['mailto:user1@testing.local', '/remote.php/dav/principals/users/user1/']
 					)]
 				]
 			]);
 		$this->server->expects($this->exactly(2))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+			function(string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
 				$this->assertEquals('schedule', $eventName);
 				$this->assertCount(1, $arguments);
 				$iTipMessages[] = $arguments[0];
@@ -536,12 +536,12 @@ 
 					'principals/users/user1',
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+						['mailto:user1@testing.local', '/remote.php/dav/principals/users/user1/']
 					)]
 				]
 			]);
 		$this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+			function(string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
 				$this->assertEquals('schedule', $eventName);
 				$this->assertCount(1, $arguments);
 				$iTipMessages[] = $arguments[0];
@@ -652,19 +652,19 @@ 
 					'principals/users/user1',
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user1@testing.local','/remote.php/dav/principals/users/user1/']
+						['mailto:user1@testing.local', '/remote.php/dav/principals/users/user1/']
 					)]
 				],
 				[
 					'principals/users/user2',
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set'],
 					['{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => new LocalHref(
-						['mailto:user2@testing.local','/remote.php/dav/principals/users/user2/']
+						['mailto:user2@testing.local', '/remote.php/dav/principals/users/user2/']
 					)]
 				]
 			]);
 		$this->server->expects($this->exactly(3))->method('emit')->willReturnCallback(
-			function (string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
+			function(string $eventName, array $arguments = [], ?callable $continueCallBack = null) use (&$iTipMessages) {
 				$this->assertEquals('schedule', $eventName);
 				$this->assertCount(1, $arguments);
 				$iTipMessages[] = $arguments[0];