nextcloud / server

apps/dav/tests/unit/SystemTag/SystemTagMappingNodeTest.php

Indentation +136 added lines, -136 removed lines

@@ -18,140 +18,140 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class SystemTagMappingNodeTest extends \Test\TestCase {
-	private ISystemTagManager&MockObject $tagManager;
-	private ISystemTagObjectMapper&MockObject $tagMapper;
-	private IUser&MockObject $user;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-		$this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		$this->user = $this->createMock(IUser::class);
-	}
-
-	public function getMappingNode($tag = null, array $writableNodeIds = []) {
-		if ($tag === null) {
-			$tag = new SystemTag('1', 'Test', true, true);
-		}
-		return new SystemTagMappingNode(
-			$tag,
-			'123',
-			'files',
-			$this->user,
-			$this->tagManager,
-			$this->tagMapper,
-			fn ($id): bool => in_array($id, $writableNodeIds),
-		);
-	}
-
-	public function testGetters(): void {
-		$tag = new SystemTag('1', 'Test', true, false);
-		$node = $this->getMappingNode($tag);
-		$this->assertEquals('1', $node->getName());
-		$this->assertEquals($tag, $node->getSystemTag());
-		$this->assertEquals(123, $node->getObjectId());
-		$this->assertEquals('files', $node->getObjectType());
-	}
-
-	public function testDeleteTag(): void {
-		$node = $this->getMappingNode(null, [123]);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($node->getSystemTag())
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($node->getSystemTag())
-			->willReturn(true);
-		$this->tagManager->expects($this->never())
-			->method('deleteTags');
-		$this->tagMapper->expects($this->once())
-			->method('unassignTags')
-			->with(123, 'files', 1);
-
-		$node->delete();
-	}
-
-	public function testDeleteTagForbidden(): void {
-		$node = $this->getMappingNode();
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($node->getSystemTag())
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($node->getSystemTag())
-			->willReturn(true);
-		$this->tagManager->expects($this->never())
-			->method('deleteTags');
-		$this->tagMapper->expects($this->never())
-			->method('unassignTags');
-
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$node->delete();
-	}
-
-	public static function tagNodeDeleteProviderPermissionException(): array {
-		return [
-			[
-				// cannot unassign invisible tag
-				new SystemTag('1', 'Original', false, true),
-				'Sabre\DAV\Exception\NotFound',
-			],
-			[
-				// cannot unassign non-assignable tag
-				new SystemTag('1', 'Original', true, false),
-				'Sabre\DAV\Exception\Forbidden',
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagNodeDeleteProviderPermissionException')]
-	public function testDeleteTagExpectedException(ISystemTag $tag, $expectedException): void {
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($tag->isUserVisible());
-		$this->tagManager->expects($this->any())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn($tag->isUserAssignable());
-		$this->tagManager->expects($this->never())
-			->method('deleteTags');
-		$this->tagMapper->expects($this->never())
-			->method('unassignTags');
-
-		$thrown = null;
-		try {
-			$this->getMappingNode($tag)->delete();
-		} catch (\Exception $e) {
-			$thrown = $e;
-		}
-
-		$this->assertInstanceOf($expectedException, $thrown);
-	}
-
-
-	public function testDeleteTagNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-
-		// assuming the tag existed at the time the node was created,
-		// but got deleted concurrently in the database
-		$tag = new SystemTag('1', 'Test', true, true);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($tag->isUserVisible());
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn($tag->isUserAssignable());
-		$this->tagMapper->expects($this->once())
-			->method('unassignTags')
-			->with(123, 'files', 1)
-			->willThrowException(new TagNotFoundException());
-
-		$this->getMappingNode($tag, [123])->delete();
-	}
+    private ISystemTagManager&MockObject $tagManager;
+    private ISystemTagObjectMapper&MockObject $tagMapper;
+    private IUser&MockObject $user;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+        $this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        $this->user = $this->createMock(IUser::class);
+    }
+
+    public function getMappingNode($tag = null, array $writableNodeIds = []) {
+        if ($tag === null) {
+            $tag = new SystemTag('1', 'Test', true, true);
+        }
+        return new SystemTagMappingNode(
+            $tag,
+            '123',
+            'files',
+            $this->user,
+            $this->tagManager,
+            $this->tagMapper,
+            fn ($id): bool => in_array($id, $writableNodeIds),
+        );
+    }
+
+    public function testGetters(): void {
+        $tag = new SystemTag('1', 'Test', true, false);
+        $node = $this->getMappingNode($tag);
+        $this->assertEquals('1', $node->getName());
+        $this->assertEquals($tag, $node->getSystemTag());
+        $this->assertEquals(123, $node->getObjectId());
+        $this->assertEquals('files', $node->getObjectType());
+    }
+
+    public function testDeleteTag(): void {
+        $node = $this->getMappingNode(null, [123]);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($node->getSystemTag())
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($node->getSystemTag())
+            ->willReturn(true);
+        $this->tagManager->expects($this->never())
+            ->method('deleteTags');
+        $this->tagMapper->expects($this->once())
+            ->method('unassignTags')
+            ->with(123, 'files', 1);
+
+        $node->delete();
+    }
+
+    public function testDeleteTagForbidden(): void {
+        $node = $this->getMappingNode();
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($node->getSystemTag())
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($node->getSystemTag())
+            ->willReturn(true);
+        $this->tagManager->expects($this->never())
+            ->method('deleteTags');
+        $this->tagMapper->expects($this->never())
+            ->method('unassignTags');
+
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $node->delete();
+    }
+
+    public static function tagNodeDeleteProviderPermissionException(): array {
+        return [
+            [
+                // cannot unassign invisible tag
+                new SystemTag('1', 'Original', false, true),
+                'Sabre\DAV\Exception\NotFound',
+            ],
+            [
+                // cannot unassign non-assignable tag
+                new SystemTag('1', 'Original', true, false),
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagNodeDeleteProviderPermissionException')]
+    public function testDeleteTagExpectedException(ISystemTag $tag, $expectedException): void {
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($tag->isUserVisible());
+        $this->tagManager->expects($this->any())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn($tag->isUserAssignable());
+        $this->tagManager->expects($this->never())
+            ->method('deleteTags');
+        $this->tagMapper->expects($this->never())
+            ->method('unassignTags');
+
+        $thrown = null;
+        try {
+            $this->getMappingNode($tag)->delete();
+        } catch (\Exception $e) {
+            $thrown = $e;
+        }
+
+        $this->assertInstanceOf($expectedException, $thrown);
+    }
+
+
+    public function testDeleteTagNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+
+        // assuming the tag existed at the time the node was created,
+        // but got deleted concurrently in the database
+        $tag = new SystemTag('1', 'Test', true, true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($tag->isUserVisible());
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn($tag->isUserAssignable());
+        $this->tagMapper->expects($this->once())
+            ->method('unassignTags')
+            ->with(123, 'files', 1)
+            ->willThrowException(new TagNotFoundException());
+
+        $this->getMappingNode($tag, [123])->delete();
+    }
 }

apps/dav/tests/unit/SystemTag/SystemTagNodeTest.php

Indentation +221 added lines, -221 removed lines

@@ -20,253 +20,253 @@
 use Sabre\DAV\Exception\Forbidden;
 
 class SystemTagNodeTest extends \Test\TestCase {
-	private ISystemTagManager&MockObject $tagManager;
-	private ISystemTagObjectMapper&MockObject $tagMapper;
-	private IUser&MockObject $user;
+    private ISystemTagManager&MockObject $tagManager;
+    private ISystemTagObjectMapper&MockObject $tagMapper;
+    private IUser&MockObject $user;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-		$this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		$this->user = $this->createMock(IUser::class);
-	}
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+        $this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        $this->user = $this->createMock(IUser::class);
+    }
 
-	protected function getTagNode($isAdmin = true, $tag = null) {
-		if ($tag === null) {
-			$tag = new SystemTag('1', 'Test', true, true);
-		}
-		return new SystemTagNode(
-			$tag,
-			$this->user,
-			$isAdmin,
-			$this->tagManager,
-			$this->tagMapper,
-		);
-	}
+    protected function getTagNode($isAdmin = true, $tag = null) {
+        if ($tag === null) {
+            $tag = new SystemTag('1', 'Test', true, true);
+        }
+        return new SystemTagNode(
+            $tag,
+            $this->user,
+            $isAdmin,
+            $this->tagManager,
+            $this->tagMapper,
+        );
+    }
 
-	public static function adminFlagProvider(): array {
-		return [[true], [false]];
-	}
+    public static function adminFlagProvider(): array {
+        return [[true], [false]];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('adminFlagProvider')]
-	public function testGetters(bool $isAdmin): void {
-		$tag = new SystemTag('1', 'Test', true, true);
-		$node = $this->getTagNode($isAdmin, $tag);
-		$this->assertEquals('1', $node->getName());
-		$this->assertEquals($tag, $node->getSystemTag());
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('adminFlagProvider')]
+    public function testGetters(bool $isAdmin): void {
+        $tag = new SystemTag('1', 'Test', true, true);
+        $node = $this->getTagNode($isAdmin, $tag);
+        $this->assertEquals('1', $node->getName());
+        $this->assertEquals($tag, $node->getSystemTag());
+    }
 
 
-	public function testSetName(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+    public function testSetName(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
 
-		$this->getTagNode()->setName('2');
-	}
+        $this->getTagNode()->setName('2');
+    }
 
-	public static function tagNodeProvider(): array {
-		return [
-			// admin
-			[
-				true,
-				new SystemTag('1', 'Original', true, true),
-				['Renamed', true, true, null]
-			],
-			[
-				true,
-				new SystemTag('1', 'Original', true, true),
-				['Original', false, false, null]
-			],
-			// non-admin
-			[
-				// renaming allowed
-				false,
-				new SystemTag('1', 'Original', true, true),
-				['Rename', true, true, '0082c9']
-			],
-		];
-	}
+    public static function tagNodeProvider(): array {
+        return [
+            // admin
+            [
+                true,
+                new SystemTag('1', 'Original', true, true),
+                ['Renamed', true, true, null]
+            ],
+            [
+                true,
+                new SystemTag('1', 'Original', true, true),
+                ['Original', false, false, null]
+            ],
+            // non-admin
+            [
+                // renaming allowed
+                false,
+                new SystemTag('1', 'Original', true, true),
+                ['Rename', true, true, '0082c9']
+            ],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagNodeProvider')]
-	public function testUpdateTag(bool $isAdmin, ISystemTag $originalTag, array $changedArgs): void {
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($originalTag)
-			->willReturn($originalTag->isUserVisible() || $isAdmin);
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($originalTag)
-			->willReturn($originalTag->isUserAssignable() || $isAdmin);
-		$this->tagManager->expects($this->once())
-			->method('updateTag')
-			->with(1, $changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
-		$this->getTagNode($isAdmin, $originalTag)
-			->update($changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagNodeProvider')]
+    public function testUpdateTag(bool $isAdmin, ISystemTag $originalTag, array $changedArgs): void {
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($originalTag)
+            ->willReturn($originalTag->isUserVisible() || $isAdmin);
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($originalTag)
+            ->willReturn($originalTag->isUserAssignable() || $isAdmin);
+        $this->tagManager->expects($this->once())
+            ->method('updateTag')
+            ->with(1, $changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
+        $this->getTagNode($isAdmin, $originalTag)
+            ->update($changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
+    }
 
-	public static function tagNodeProviderPermissionException(): array {
-		return [
-			[
-				// changing permissions not allowed
-				new SystemTag('1', 'Original', true, true),
-				['Original', false, true, ''],
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// changing permissions not allowed
-				new SystemTag('1', 'Original', true, true),
-				['Original', true, false, ''],
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// changing permissions not allowed
-				new SystemTag('1', 'Original', true, true),
-				['Original', false, false, ''],
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// changing non-assignable not allowed
-				new SystemTag('1', 'Original', true, false),
-				['Rename', true, false, ''],
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// changing non-assignable not allowed
-				new SystemTag('1', 'Original', true, false),
-				['Original', true, true, ''],
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// invisible tag does not exist
-				new SystemTag('1', 'Original', false, false),
-				['Rename', false, false, ''],
-				'Sabre\DAV\Exception\NotFound',
-			],
-		];
-	}
+    public static function tagNodeProviderPermissionException(): array {
+        return [
+            [
+                // changing permissions not allowed
+                new SystemTag('1', 'Original', true, true),
+                ['Original', false, true, ''],
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // changing permissions not allowed
+                new SystemTag('1', 'Original', true, true),
+                ['Original', true, false, ''],
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // changing permissions not allowed
+                new SystemTag('1', 'Original', true, true),
+                ['Original', false, false, ''],
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // changing non-assignable not allowed
+                new SystemTag('1', 'Original', true, false),
+                ['Rename', true, false, ''],
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // changing non-assignable not allowed
+                new SystemTag('1', 'Original', true, false),
+                ['Original', true, true, ''],
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // invisible tag does not exist
+                new SystemTag('1', 'Original', false, false),
+                ['Rename', false, false, ''],
+                'Sabre\DAV\Exception\NotFound',
+            ],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagNodeProviderPermissionException')]
-	public function testUpdateTagPermissionException(ISystemTag $originalTag, array $changedArgs, string $expectedException): void {
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($originalTag)
-			->willReturn($originalTag->isUserVisible());
-		$this->tagManager->expects($this->any())
-			->method('canUserAssignTag')
-			->with($originalTag)
-			->willReturn($originalTag->isUserAssignable());
-		$this->tagManager->expects($this->never())
-			->method('updateTag');
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagNodeProviderPermissionException')]
+    public function testUpdateTagPermissionException(ISystemTag $originalTag, array $changedArgs, string $expectedException): void {
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($originalTag)
+            ->willReturn($originalTag->isUserVisible());
+        $this->tagManager->expects($this->any())
+            ->method('canUserAssignTag')
+            ->with($originalTag)
+            ->willReturn($originalTag->isUserAssignable());
+        $this->tagManager->expects($this->never())
+            ->method('updateTag');
 
-		$thrown = null;
+        $thrown = null;
 
-		try {
-			$this->getTagNode(false, $originalTag)
-				->update($changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
-		} catch (\Exception $e) {
-			$thrown = $e;
-		}
+        try {
+            $this->getTagNode(false, $originalTag)
+                ->update($changedArgs[0], $changedArgs[1], $changedArgs[2], $changedArgs[3]);
+        } catch (\Exception $e) {
+            $thrown = $e;
+        }
 
-		$this->assertInstanceOf($expectedException, $thrown);
-	}
+        $this->assertInstanceOf($expectedException, $thrown);
+    }
 
 
-	public function testUpdateTagAlreadyExists(): void {
-		$this->expectException(\Sabre\DAV\Exception\Conflict::class);
+    public function testUpdateTagAlreadyExists(): void {
+        $this->expectException(\Sabre\DAV\Exception\Conflict::class);
 
-		$tag = new SystemTag('1', 'tag1', true, true);
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->any())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('updateTag')
-			->with(1, 'Renamed', true, true)
-			->willThrowException(new TagAlreadyExistsException());
-		$this->getTagNode(false, $tag)->update('Renamed', true, true, null);
-	}
+        $tag = new SystemTag('1', 'tag1', true, true);
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->any())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('updateTag')
+            ->with(1, 'Renamed', true, true)
+            ->willThrowException(new TagAlreadyExistsException());
+        $this->getTagNode(false, $tag)->update('Renamed', true, true, null);
+    }
 
 
-	public function testUpdateTagNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testUpdateTagNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$tag = new SystemTag('1', 'tag1', true, true);
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->any())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('updateTag')
-			->with(1, 'Renamed', true, true)
-			->willThrowException(new TagNotFoundException());
-		$this->getTagNode(false, $tag)->update('Renamed', true, true, null);
-	}
+        $tag = new SystemTag('1', 'tag1', true, true);
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->any())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('updateTag')
+            ->with(1, 'Renamed', true, true)
+            ->willThrowException(new TagNotFoundException());
+        $this->getTagNode(false, $tag)->update('Renamed', true, true, null);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('adminFlagProvider')]
-	public function testDeleteTag(bool $isAdmin): void {
-		$tag = new SystemTag('1', 'tag1', true, true);
-		$this->tagManager->expects($isAdmin ? $this->once() : $this->never())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($isAdmin ? $this->once() : $this->never())
-			->method('deleteTags')
-			->with('1');
-		if (!$isAdmin) {
-			$this->expectException(Forbidden::class);
-		}
-		$this->getTagNode($isAdmin, $tag)->delete();
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('adminFlagProvider')]
+    public function testDeleteTag(bool $isAdmin): void {
+        $tag = new SystemTag('1', 'tag1', true, true);
+        $this->tagManager->expects($isAdmin ? $this->once() : $this->never())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($isAdmin ? $this->once() : $this->never())
+            ->method('deleteTags')
+            ->with('1');
+        if (!$isAdmin) {
+            $this->expectException(Forbidden::class);
+        }
+        $this->getTagNode($isAdmin, $tag)->delete();
+    }
 
-	public static function tagNodeDeleteProviderPermissionException(): array {
-		return [
-			[
-				// cannot delete invisible tag
-				new SystemTag('1', 'Original', false, true),
-				'Sabre\DAV\Exception\Forbidden',
-			],
-			[
-				// cannot delete non-assignable tag
-				new SystemTag('1', 'Original', true, false),
-				'Sabre\DAV\Exception\Forbidden',
-			],
-		];
-	}
+    public static function tagNodeDeleteProviderPermissionException(): array {
+        return [
+            [
+                // cannot delete invisible tag
+                new SystemTag('1', 'Original', false, true),
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+            [
+                // cannot delete non-assignable tag
+                new SystemTag('1', 'Original', true, false),
+                'Sabre\DAV\Exception\Forbidden',
+            ],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagNodeDeleteProviderPermissionException')]
-	public function testDeleteTagPermissionException(ISystemTag $tag, string $expectedException): void {
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($tag->isUserVisible());
-		$this->tagManager->expects($this->never())
-			->method('deleteTags');
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagNodeDeleteProviderPermissionException')]
+    public function testDeleteTagPermissionException(ISystemTag $tag, string $expectedException): void {
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($tag->isUserVisible());
+        $this->tagManager->expects($this->never())
+            ->method('deleteTags');
 
-		$this->expectException($expectedException);
-		$this->getTagNode(false, $tag)->delete();
-	}
+        $this->expectException($expectedException);
+        $this->getTagNode(false, $tag)->delete();
+    }
 
 
-	public function testDeleteTagNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testDeleteTagNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$tag = new SystemTag('1', 'tag1', true, true);
-		$this->tagManager->expects($this->any())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($tag->isUserVisible());
-		$this->tagManager->expects($this->once())
-			->method('deleteTags')
-			->with('1')
-			->willThrowException(new TagNotFoundException());
-		$this->getTagNode(true, $tag)->delete();
-	}
+        $tag = new SystemTag('1', 'tag1', true, true);
+        $this->tagManager->expects($this->any())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($tag->isUserVisible());
+        $this->tagManager->expects($this->once())
+            ->method('deleteTags')
+            ->with('1')
+            ->willThrowException(new TagNotFoundException());
+        $this->getTagNode(true, $tag)->delete();
+    }
 }

apps/dav/tests/unit/ServerTest.php

Indentation +19 added lines, -19 removed lines

@@ -20,23 +20,23 @@
  */
 class ServerTest extends \Test\TestCase {
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesUris')]
-	public function test(string $uri, array $plugins): void {
-		/** @var IRequest | \PHPUnit\Framework\MockObject\MockObject $r */
-		$r = $this->createMock(IRequest::class);
-		$r->expects($this->any())->method('getRequestUri')->willReturn($uri);
-		$this->loginAsUser('admin');
-		$s = new Server($r, '/');
-		$this->assertNotNull($s->server);
-		foreach ($plugins as $plugin) {
-			$this->assertNotNull($s->server->getPlugin($plugin));
-		}
-	}
-	public static function providesUris(): array {
-		return [
-			'principals' => ['principals/users/admin', ['caldav', 'oc-resource-sharing', 'carddav']],
-			'calendars' => ['calendars/admin', ['caldav', 'oc-resource-sharing']],
-			'addressbooks' => ['addressbooks/admin', ['carddav', 'oc-resource-sharing']],
-		];
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesUris')]
+    public function test(string $uri, array $plugins): void {
+        /** @var IRequest | \PHPUnit\Framework\MockObject\MockObject $r */
+        $r = $this->createMock(IRequest::class);
+        $r->expects($this->any())->method('getRequestUri')->willReturn($uri);
+        $this->loginAsUser('admin');
+        $s = new Server($r, '/');
+        $this->assertNotNull($s->server);
+        foreach ($plugins as $plugin) {
+            $this->assertNotNull($s->server->getPlugin($plugin));
+        }
+    }
+    public static function providesUris(): array {
+        return [
+            'principals' => ['principals/users/admin', ['caldav', 'oc-resource-sharing', 'carddav']],
+            'calendars' => ['calendars/admin', ['caldav', 'oc-resource-sharing']],
+            'addressbooks' => ['addressbooks/admin', ['carddav', 'oc-resource-sharing']],
+        ];
+    }
 }

apps/dav/tests/unit/CalDAV/PublicCalendarTest.php

Indentation +91 added lines, -91 removed lines

@@ -16,51 +16,51 @@ 
 
 class PublicCalendarTest extends CalendarTest {
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
-	public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->getMockBuilder(CalDavBackend::class)->disableOriginalConstructor()->getMock();
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject2)->with(666, 'event-2');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user2',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		/** @var IConfig&MockObject $config */
-		$config = $this->createMock(IConfig::class);
-		/** @var LoggerInterface&MockObject $logger */
-		$logger = $this->createMock(LoggerInterface::class);
-		$c = new PublicCalendar($backend, $calendarInfo, $this->l10n, $config, $logger);
-		$children = $c->getChildren();
-		$this->assertEquals(2, count($children));
-		$children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
-		$this->assertEquals(2, count($children));
-
-		$this->assertFalse($c->childExists('event-2'));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
-	public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
-		$start = '20160609';
-		$end = '20160610';
-
-		$calData = <<<EOD
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
+    public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->getMockBuilder(CalDavBackend::class)->disableOriginalConstructor()->getMock();
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject2)->with(666, 'event-2');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user2',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        /** @var IConfig&MockObject $config */
+        $config = $this->createMock(IConfig::class);
+        /** @var LoggerInterface&MockObject $logger */
+        $logger = $this->createMock(LoggerInterface::class);
+        $c = new PublicCalendar($backend, $calendarInfo, $this->l10n, $config, $logger);
+        $children = $c->getChildren();
+        $this->assertEquals(2, count($children));
+        $children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
+        $this->assertEquals(2, count($children));
+
+        $this->assertFalse($c->childExists('event-2'));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
+    public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
+        $start = '20160609';
+        $end = '20160610';
+
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//ownCloud calendar v1.2.2
 BEGIN:VEVENT
@@ -102,50 +102,50 @@ 
 END:VCALENDAR
 EOD;
 
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->getMockBuilder(CalDavBackend::class)->disableOriginalConstructor()->getMock();
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject1)->with(666, 'event-1');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		/** @var IConfig&MockObject $config */
-		$config = $this->createMock(IConfig::class);
-		/** @var LoggerInterface&MockObject $logger */
-		$logger = $this->createMock(LoggerInterface::class);
-		$c = new PublicCalendar($backend, $calendarInfo, $this->l10n, $config, $logger);
-
-		$this->assertEquals(count($c->getChildren()), 2);
-
-		// test private event
-		$privateEvent = $c->getChild('event-1');
-		$calData = $privateEvent->get();
-		$event = Reader::read($calData);
-
-		$this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
-		$this->assertEquals($end, $event->VEVENT->DTEND->getValue());
-
-		$this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
-		$this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
-		$this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
-		$this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
-		$this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
-	}
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->getMockBuilder(CalDavBackend::class)->disableOriginalConstructor()->getMock();
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject1)->with(666, 'event-1');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        /** @var IConfig&MockObject $config */
+        $config = $this->createMock(IConfig::class);
+        /** @var LoggerInterface&MockObject $logger */
+        $logger = $this->createMock(LoggerInterface::class);
+        $c = new PublicCalendar($backend, $calendarInfo, $this->l10n, $config, $logger);
+
+        $this->assertEquals(count($c->getChildren()), 2);
+
+        // test private event
+        $privateEvent = $c->getChild('event-1');
+        $calData = $privateEvent->get();
+        $event = Reader::read($calData);
+
+        $this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
+        $this->assertEquals($end, $event->VEVENT->DTEND->getValue());
+
+        $this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
+        $this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
+        $this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
+        $this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
+        $this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
+    }
 }

apps/dav/tests/unit/CalDAV/Integration/ExternalCalendarTest.php

Indentation +86 added lines, -86 removed lines

@@ -12,90 +12,90 @@
 use Test\TestCase;
 
 class ExternalCalendarTest extends TestCase {
-	private ExternalCalendar&MockObject $abstractExternalCalendar;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->abstractExternalCalendar
-			= $this->getMockForAbstractClass(ExternalCalendar::class, ['example-app-id', 'calendar-uri-in-backend']);
-	}
-
-	public function testGetName():void {
-		// Check that the correct name is returned
-		$this->assertEquals('app-generated--example-app-id--calendar-uri-in-backend',
-			$this->abstractExternalCalendar->getName());
-
-		// Check that the method is final and can't be overridden by other classes
-		$reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'getName');
-		$this->assertTrue($reflectionMethod->isFinal());
-	}
-
-	public function testSetName():void {
-		// Check that the method is final and can't be overridden by other classes
-		$reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'setName');
-		$this->assertTrue($reflectionMethod->isFinal());
-
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('Renaming calendars is not yet supported');
-
-		$this->abstractExternalCalendar->setName('other-name');
-	}
-
-	public function createDirectory(): void {
-		// Check that the method is final and can't be overridden by other classes
-		$reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'createDirectory');
-		$this->assertTrue($reflectionMethod->isFinal());
-
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
-		$this->expectExceptionMessage('Creating collections in calendar objects is not allowed');
-
-		$this->abstractExternalCalendar->createDirectory('other-name');
-	}
-
-	public function testIsAppGeneratedCalendar():void {
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('personal'));
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('work'));
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('contact_birthdays'));
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('company'));
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('app-generated'));
-		$this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('app-generated--example'));
-
-		$this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--deck--board-1'));
-		$this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--example--foo-2'));
-		$this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--example--foo--2'));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('splitAppGeneratedCalendarUriDataProvider')]
-	public function testSplitAppGeneratedCalendarUriInvalid(string $name):void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Provided calendar uri was not app-generated');
-
-		ExternalCalendar::splitAppGeneratedCalendarUri($name);
-	}
-
-	public static function splitAppGeneratedCalendarUriDataProvider():array {
-		return [
-			['personal'],
-			['foo_shared_by_admin'],
-			['contact_birthdays'],
-		];
-	}
-
-	public function testSplitAppGeneratedCalendarUri():void {
-		$this->assertEquals(['deck', 'board-1'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--deck--board-1'));
-		$this->assertEquals(['example', 'foo-2'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--example--foo-2'));
-		$this->assertEquals(['example', 'foo--2'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--example--foo--2'));
-	}
-
-	public function testDoesViolateReservedName():void {
-		$this->assertFalse(ExternalCalendar::doesViolateReservedName('personal'));
-		$this->assertFalse(ExternalCalendar::doesViolateReservedName('work'));
-		$this->assertFalse(ExternalCalendar::doesViolateReservedName('contact_birthdays'));
-		$this->assertFalse(ExternalCalendar::doesViolateReservedName('company'));
-
-		$this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated'));
-		$this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated-calendar'));
-		$this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated--deck-123'));
-	}
+    private ExternalCalendar&MockObject $abstractExternalCalendar;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->abstractExternalCalendar
+            = $this->getMockForAbstractClass(ExternalCalendar::class, ['example-app-id', 'calendar-uri-in-backend']);
+    }
+
+    public function testGetName():void {
+        // Check that the correct name is returned
+        $this->assertEquals('app-generated--example-app-id--calendar-uri-in-backend',
+            $this->abstractExternalCalendar->getName());
+
+        // Check that the method is final and can't be overridden by other classes
+        $reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'getName');
+        $this->assertTrue($reflectionMethod->isFinal());
+    }
+
+    public function testSetName():void {
+        // Check that the method is final and can't be overridden by other classes
+        $reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'setName');
+        $this->assertTrue($reflectionMethod->isFinal());
+
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('Renaming calendars is not yet supported');
+
+        $this->abstractExternalCalendar->setName('other-name');
+    }
+
+    public function createDirectory(): void {
+        // Check that the method is final and can't be overridden by other classes
+        $reflectionMethod = new \ReflectionMethod(ExternalCalendar::class, 'createDirectory');
+        $this->assertTrue($reflectionMethod->isFinal());
+
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+        $this->expectExceptionMessage('Creating collections in calendar objects is not allowed');
+
+        $this->abstractExternalCalendar->createDirectory('other-name');
+    }
+
+    public function testIsAppGeneratedCalendar():void {
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('personal'));
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('work'));
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('contact_birthdays'));
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('company'));
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('app-generated'));
+        $this->assertFalse(ExternalCalendar::isAppGeneratedCalendar('app-generated--example'));
+
+        $this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--deck--board-1'));
+        $this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--example--foo-2'));
+        $this->assertTrue(ExternalCalendar::isAppGeneratedCalendar('app-generated--example--foo--2'));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('splitAppGeneratedCalendarUriDataProvider')]
+    public function testSplitAppGeneratedCalendarUriInvalid(string $name):void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Provided calendar uri was not app-generated');
+
+        ExternalCalendar::splitAppGeneratedCalendarUri($name);
+    }
+
+    public static function splitAppGeneratedCalendarUriDataProvider():array {
+        return [
+            ['personal'],
+            ['foo_shared_by_admin'],
+            ['contact_birthdays'],
+        ];
+    }
+
+    public function testSplitAppGeneratedCalendarUri():void {
+        $this->assertEquals(['deck', 'board-1'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--deck--board-1'));
+        $this->assertEquals(['example', 'foo-2'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--example--foo-2'));
+        $this->assertEquals(['example', 'foo--2'], ExternalCalendar::splitAppGeneratedCalendarUri('app-generated--example--foo--2'));
+    }
+
+    public function testDoesViolateReservedName():void {
+        $this->assertFalse(ExternalCalendar::doesViolateReservedName('personal'));
+        $this->assertFalse(ExternalCalendar::doesViolateReservedName('work'));
+        $this->assertFalse(ExternalCalendar::doesViolateReservedName('contact_birthdays'));
+        $this->assertFalse(ExternalCalendar::doesViolateReservedName('company'));
+
+        $this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated'));
+        $this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated-calendar'));
+        $this->assertTrue(ExternalCalendar::doesViolateReservedName('app-generated--deck-123'));
+    }
 }

apps/dav/tests/unit/CalDAV/CalendarTest.php

Indentation +461 added lines, -461 removed lines

@@ -20,296 +20,296 @@ 
 use Test\TestCase;
 
 class CalendarTest extends TestCase {
-	protected IL10N&MockObject $l10n;
-	protected IConfig&MockObject $config;
-	protected LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-	}
-
-	public function testDelete(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())
-			->method('updateShares');
-		$backend->expects($this->once())
-			->method('unshare');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-
-	public function testDeleteFromGroup(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())
-			->method('updateShares');
-		$backend->expects($this->once())
-			->method('unshare');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public function testDeleteOwn(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->never())->method('updateShares');
-		$backend->expects($this->never())->method('getShares');
-
-		$this->config->expects($this->never())->method('setUserValue');
-
-		$backend->expects($this->once())->method('deleteCalendar')
-			->with(666);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public function testDeleteBirthdayCalendar(): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->once())->method('deleteCalendar')
-			->with(666);
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with('user1', 'dav', 'generateBirthdayCalendar', 'no');
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'principals/users/user1',
-			'principaluri' => 'principals/users/user1',
-			'id' => 666,
-			'uri' => 'contact_birthdays',
-			'{DAV:}displayname' => 'Test',
-		];
-
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$c->delete();
-	}
-
-	public static function dataPropPatch(): array {
-		return [
-			['user1', 'user2', [], true],
-			['user1', 'user2', [
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], true],
-			['user1', 'user2', [
-				'{DAV:}displayname' => true,
-			], true],
-			['user1', 'user2', [
-				'{DAV:}displayname' => true,
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], true],
-			['user1', 'user1', [], false],
-			['user1', 'user1', [
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], false],
-			['user1', 'user1', [
-				'{DAV:}displayname' => true,
-			], false],
-			['user1', 'user1', [
-				'{DAV:}displayname' => true,
-				'{http://owncloud.org/ns}calendar-enabled' => true,
-			], false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataPropPatch')]
-	public function testPropPatch(string $ownerPrincipal, string $principalUri, array $mutations, bool $shared): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => $ownerPrincipal,
-			'principaluri' => $principalUri,
-			'id' => 666,
-			'uri' => 'default'
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$propPatch = new PropPatch($mutations);
-
-		if (!$shared) {
-			$backend->expects($this->once())
-				->method('updateCalendar')
-				->with(666, $propPatch);
-		}
-		$c->propPatch($propPatch);
-		$this->addToAssertionCount(1);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesReadOnlyInfo')]
-	public function testAcl($expectsWrite, $readOnlyValue, $hasOwnerSet, $uri = 'default'): void {
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-		$calendarInfo = [
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => $uri
-		];
-		$calendarInfo['{DAV:}displayname'] = 'Test';
-		if (!is_null($readOnlyValue)) {
-			$calendarInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
-		}
-		if ($hasOwnerSet) {
-			$calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
-		}
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$acl = $c->getACL();
-		$childAcl = $c->getChildACL();
-
-		$expectedAcl = [[
-			'privilege' => '{DAV:}read',
-			'principal' => $hasOwnerSet ? 'user1' : 'user2',
-			'protected' => true
-		], [
-			'privilege' => '{DAV:}read',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-			'protected' => true,
-		], [
-			'privilege' => '{DAV:}read',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
-			'protected' => true,
-		]];
-		if ($uri === BirthdayService::BIRTHDAY_CALENDAR_URI) {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write-properties',
-				'principal' => $hasOwnerSet ? 'user1' : 'user2',
-				'protected' => true
-			];
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write-properties',
-				'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-				'protected' => true
-			];
-		} else {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write',
-				'principal' => $hasOwnerSet ? 'user1' : 'user2',
-				'protected' => true
-			];
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}write',
-				'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
-				'protected' => true
-			];
-		}
-
-		$expectedAcl[] = [
-			'privilege' => '{DAV:}write-properties',
-			'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
-			'protected' => true
-		];
-
-		if ($hasOwnerSet) {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}read',
-				'principal' => 'user2',
-				'protected' => true
-			];
-			if ($expectsWrite) {
-				$expectedAcl[] = [
-					'privilege' => '{DAV:}write',
-					'principal' => 'user2',
-					'protected' => true
-				];
-			} else {
-				$expectedAcl[] = [
-					'privilege' => '{DAV:}write-properties',
-					'principal' => 'user2',
-					'protected' => true
-				];
-			}
-		}
-		$this->assertEquals($expectedAcl, $acl);
-		$this->assertEquals($expectedAcl, $childAcl);
-	}
-
-	public static function providesReadOnlyInfo(): array {
-		return [
-			'read-only property not set' => [true, null, true],
-			'read-only property is false' => [true, false, true],
-			'read-only property is true' => [false, true, true],
-			'read-only property not set and no owner' => [true, null, false],
-			'read-only property is false and no owner' => [true, false, false],
-			'read-only property is true and no owner' => [false, true, false],
-			'birthday calendar' => [false, false, false, BirthdayService::BIRTHDAY_CALENDAR_URI]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
-	public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject2)->with(666, 'event-2');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		if ($isShared) {
-			$calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
-		}
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-		$children = $c->getChildren();
-		$this->assertEquals($expectedChildren, count($children));
-		$children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
-		$this->assertEquals($expectedChildren, count($children));
-
-		$this->assertEquals(!$isShared, $c->childExists('event-2'));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
-	public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
-		$start = '20160609';
-		$end = '20160610';
-
-		$calData = <<<EOD
+    protected IL10N&MockObject $l10n;
+    protected IConfig&MockObject $config;
+    protected LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+    }
+
+    public function testDelete(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())
+            ->method('updateShares');
+        $backend->expects($this->once())
+            ->method('unshare');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+
+    public function testDeleteFromGroup(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())
+            ->method('updateShares');
+        $backend->expects($this->once())
+            ->method('unshare');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public function testDeleteOwn(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->never())->method('updateShares');
+        $backend->expects($this->never())->method('getShares');
+
+        $this->config->expects($this->never())->method('setUserValue');
+
+        $backend->expects($this->once())->method('deleteCalendar')
+            ->with(666);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public function testDeleteBirthdayCalendar(): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->once())->method('deleteCalendar')
+            ->with(666);
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with('user1', 'dav', 'generateBirthdayCalendar', 'no');
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'principals/users/user1',
+            'principaluri' => 'principals/users/user1',
+            'id' => 666,
+            'uri' => 'contact_birthdays',
+            '{DAV:}displayname' => 'Test',
+        ];
+
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $c->delete();
+    }
+
+    public static function dataPropPatch(): array {
+        return [
+            ['user1', 'user2', [], true],
+            ['user1', 'user2', [
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], true],
+            ['user1', 'user2', [
+                '{DAV:}displayname' => true,
+            ], true],
+            ['user1', 'user2', [
+                '{DAV:}displayname' => true,
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], true],
+            ['user1', 'user1', [], false],
+            ['user1', 'user1', [
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], false],
+            ['user1', 'user1', [
+                '{DAV:}displayname' => true,
+            ], false],
+            ['user1', 'user1', [
+                '{DAV:}displayname' => true,
+                '{http://owncloud.org/ns}calendar-enabled' => true,
+            ], false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataPropPatch')]
+    public function testPropPatch(string $ownerPrincipal, string $principalUri, array $mutations, bool $shared): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => $ownerPrincipal,
+            'principaluri' => $principalUri,
+            'id' => 666,
+            'uri' => 'default'
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $propPatch = new PropPatch($mutations);
+
+        if (!$shared) {
+            $backend->expects($this->once())
+                ->method('updateCalendar')
+                ->with(666, $propPatch);
+        }
+        $c->propPatch($propPatch);
+        $this->addToAssertionCount(1);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesReadOnlyInfo')]
+    public function testAcl($expectsWrite, $readOnlyValue, $hasOwnerSet, $uri = 'default'): void {
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+        $calendarInfo = [
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => $uri
+        ];
+        $calendarInfo['{DAV:}displayname'] = 'Test';
+        if (!is_null($readOnlyValue)) {
+            $calendarInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
+        }
+        if ($hasOwnerSet) {
+            $calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
+        }
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $acl = $c->getACL();
+        $childAcl = $c->getChildACL();
+
+        $expectedAcl = [[
+            'privilege' => '{DAV:}read',
+            'principal' => $hasOwnerSet ? 'user1' : 'user2',
+            'protected' => true
+        ], [
+            'privilege' => '{DAV:}read',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+            'protected' => true,
+        ], [
+            'privilege' => '{DAV:}read',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
+            'protected' => true,
+        ]];
+        if ($uri === BirthdayService::BIRTHDAY_CALENDAR_URI) {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => $hasOwnerSet ? 'user1' : 'user2',
+                'protected' => true
+            ];
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write-properties',
+                'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+                'protected' => true
+            ];
+        } else {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write',
+                'principal' => $hasOwnerSet ? 'user1' : 'user2',
+                'protected' => true
+            ];
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}write',
+                'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-write',
+                'protected' => true
+            ];
+        }
+
+        $expectedAcl[] = [
+            'privilege' => '{DAV:}write-properties',
+            'principal' => ($hasOwnerSet ? 'user1' : 'user2') . '/calendar-proxy-read',
+            'protected' => true
+        ];
+
+        if ($hasOwnerSet) {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user2',
+                'protected' => true
+            ];
+            if ($expectsWrite) {
+                $expectedAcl[] = [
+                    'privilege' => '{DAV:}write',
+                    'principal' => 'user2',
+                    'protected' => true
+                ];
+            } else {
+                $expectedAcl[] = [
+                    'privilege' => '{DAV:}write-properties',
+                    'principal' => 'user2',
+                    'protected' => true
+                ];
+            }
+        }
+        $this->assertEquals($expectedAcl, $acl);
+        $this->assertEquals($expectedAcl, $childAcl);
+    }
+
+    public static function providesReadOnlyInfo(): array {
+        return [
+            'read-only property not set' => [true, null, true],
+            'read-only property is false' => [true, false, true],
+            'read-only property is true' => [false, true, true],
+            'read-only property not set and no owner' => [true, null, false],
+            'read-only property is false and no owner' => [true, false, false],
+            'read-only property is true and no owner' => [false, true, false],
+            'birthday calendar' => [false, false, false, BirthdayService::BIRTHDAY_CALENDAR_URI]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
+    public function testPrivateClassification(int $expectedChildren, bool $isShared): void {
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject2)->with(666, 'event-2');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        if ($isShared) {
+            $calendarInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
+        }
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+        $children = $c->getChildren();
+        $this->assertEquals($expectedChildren, count($children));
+        $children = $c->getMultipleChildren(['event-0', 'event-1', 'event-2']);
+        $this->assertEquals($expectedChildren, count($children));
+
+        $this->assertEquals(!$isShared, $c->childExists('event-2'));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesConfidentialClassificationData')]
+    public function testConfidentialClassification(int $expectedChildren, bool $isShared): void {
+        $start = '20160609';
+        $end = '20160610';
+
+        $calData = <<<EOD
 BEGIN:VCALENDAR
 PRODID:-//ownCloud calendar v1.2.2
 BEGIN:VEVENT
@@ -351,84 +351,84 @@ 
 END:VCALENDAR
 EOD;
 
-		$calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
-		$calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
-		$calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())->method('getCalendarObjects')->willReturn([
-			$calObject0, $calObject1, $calObject2
-		]);
-		$backend->expects($this->any())->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1', 'event-2'])
-			->willReturn([
-				$calObject0, $calObject1, $calObject2
-			]);
-		$backend->expects($this->any())->method('getCalendarObject')
-			->willReturn($calObject1)->with(666, 'event-1');
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-
-		$calendarInfo = [
-			'{http://owncloud.org/ns}owner-principal' => $isShared ? 'user1' : 'user2',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
-
-		$this->assertEquals(count($c->getChildren()), $expectedChildren);
-
-		// test private event
-		$privateEvent = $c->getChild('event-1');
-		$calData = $privateEvent->get();
-		$event = Reader::read($calData);
-
-		$this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
-		$this->assertEquals($end, $event->VEVENT->DTEND->getValue());
-
-		if ($isShared) {
-			$this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
-			$this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
-			$this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
-			$this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
-			$this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
-		} else {
-			$this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
-		}
-
-		// Test l10n
-		$l10n = $this->createMock(IL10N::class);
-		if ($isShared) {
-			$l10n->expects($this->once())
-				->method('t')
-				->with('Busy')
-				->willReturn('Translated busy');
-		} else {
-			$l10n->expects($this->never())
-				->method('t');
-		}
-		$c = new Calendar($backend, $calendarInfo, $l10n, $this->config, $this->logger);
-
-		$calData = $c->getChild('event-1')->get();
-		$event = Reader::read($calData);
-
-		if ($isShared) {
-			$this->assertEquals('Translated busy', $event->VEVENT->SUMMARY->getValue());
-		} else {
-			$this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
-		}
-	}
-
-	public static function providesConfidentialClassificationData(): array {
-		return [
-			[3, false],
-			[2, true]
-		];
-	}
-
-	public function testRemoveVAlarms(): void {
-		$publicObjectData = <<<EOD
+        $calObject0 = ['uri' => 'event-0', 'classification' => CalDavBackend::CLASSIFICATION_PUBLIC];
+        $calObject1 = ['uri' => 'event-1', 'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL, 'calendardata' => $calData];
+        $calObject2 = ['uri' => 'event-2', 'classification' => CalDavBackend::CLASSIFICATION_PRIVATE];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())->method('getCalendarObjects')->willReturn([
+            $calObject0, $calObject1, $calObject2
+        ]);
+        $backend->expects($this->any())->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1', 'event-2'])
+            ->willReturn([
+                $calObject0, $calObject1, $calObject2
+            ]);
+        $backend->expects($this->any())->method('getCalendarObject')
+            ->willReturn($calObject1)->with(666, 'event-1');
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+
+        $calendarInfo = [
+            '{http://owncloud.org/ns}owner-principal' => $isShared ? 'user1' : 'user2',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $c = new Calendar($backend, $calendarInfo, $this->l10n, $this->config, $this->logger);
+
+        $this->assertEquals(count($c->getChildren()), $expectedChildren);
+
+        // test private event
+        $privateEvent = $c->getChild('event-1');
+        $calData = $privateEvent->get();
+        $event = Reader::read($calData);
+
+        $this->assertEquals($start, $event->VEVENT->DTSTART->getValue());
+        $this->assertEquals($end, $event->VEVENT->DTEND->getValue());
+
+        if ($isShared) {
+            $this->assertEquals('Busy', $event->VEVENT->SUMMARY->getValue());
+            $this->assertArrayNotHasKey('ATTENDEE', $event->VEVENT);
+            $this->assertArrayNotHasKey('LOCATION', $event->VEVENT);
+            $this->assertArrayNotHasKey('DESCRIPTION', $event->VEVENT);
+            $this->assertArrayNotHasKey('ORGANIZER', $event->VEVENT);
+        } else {
+            $this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
+        }
+
+        // Test l10n
+        $l10n = $this->createMock(IL10N::class);
+        if ($isShared) {
+            $l10n->expects($this->once())
+                ->method('t')
+                ->with('Busy')
+                ->willReturn('Translated busy');
+        } else {
+            $l10n->expects($this->never())
+                ->method('t');
+        }
+        $c = new Calendar($backend, $calendarInfo, $l10n, $this->config, $this->logger);
+
+        $calData = $c->getChild('event-1')->get();
+        $event = Reader::read($calData);
+
+        if ($isShared) {
+            $this->assertEquals('Translated busy', $event->VEVENT->SUMMARY->getValue());
+        } else {
+            $this->assertEquals('Test Event', $event->VEVENT->SUMMARY->getValue());
+        }
+    }
+
+    public static function providesConfidentialClassificationData(): array {
+        return [
+            [3, false],
+            [2, true]
+        ];
+    }
+
+    public function testRemoveVAlarms(): void {
+        $publicObjectData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -452,7 +452,7 @@ 
 
 EOD;
 
-		$confidentialObjectData = <<<EOD
+        $confidentialObjectData = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -476,7 +476,7 @@ 
 
 EOD;
 
-		$publicObjectDataWithoutVAlarm = <<<EOD
+        $publicObjectDataWithoutVAlarm = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -496,7 +496,7 @@ 
 
 EOD;
 
-		$confidentialObjectCleaned = <<<EOD
+        $confidentialObjectCleaned = <<<EOD
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud calendar v1.5.6
@@ -515,94 +515,94 @@ 
 
 
 
-		$publicObject = ['uri' => 'event-0',
-			'classification' => CalDavBackend::CLASSIFICATION_PUBLIC,
-			'calendardata' => $publicObjectData];
-
-		$confidentialObject = ['uri' => 'event-1',
-			'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL,
-			'calendardata' => $confidentialObjectData];
-
-		/** @var CalDavBackend&MockObject $backend */
-		$backend = $this->createMock(CalDavBackend::class);
-		$backend->expects($this->any())
-			->method('getCalendarObjects')
-			->willReturn([$publicObject, $confidentialObject]);
-
-		$backend->expects($this->any())
-			->method('getMultipleCalendarObjects')
-			->with(666, ['event-0', 'event-1'])
-			->willReturn([$publicObject, $confidentialObject]);
-
-		$backend->expects($this->any())
-			->method('getCalendarObject')
-			->willReturnCallback(function ($cId, $uri) use ($publicObject, $confidentialObject) {
-				switch ($uri) {
-					case 'event-0':
-						return $publicObject;
-
-					case 'event-1':
-						return $confidentialObject;
-
-					default:
-						throw new \Exception('unexpected uri');
-				}
-			});
-
-		$backend->expects($this->any())
-			->method('applyShareAcl')
-			->willReturnArgument(1);
-
-		$calendarInfoOwner = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$calendarInfoSharedRW = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-		$calendarInfoSharedRO = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{http://owncloud.org/ns}read-only' => true,
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'cal',
-		];
-
-		$ownerCalendar = new Calendar($backend, $calendarInfoOwner, $this->l10n, $this->config, $this->logger);
-		$rwCalendar = new Calendar($backend, $calendarInfoSharedRW, $this->l10n, $this->config, $this->logger);
-		$roCalendar = new Calendar($backend, $calendarInfoSharedRO, $this->l10n, $this->config, $this->logger);
-
-		$this->assertCount(2, $ownerCalendar->getChildren());
-		$this->assertCount(2, $rwCalendar->getChildren());
-		$this->assertCount(2, $roCalendar->getChildren());
-
-		// calendar data shall not be altered for the owner
-		$this->assertEquals($ownerCalendar->getChild('event-0')->get(), $publicObjectData);
-		$this->assertEquals($ownerCalendar->getChild('event-1')->get(), $confidentialObjectData);
-
-		// valarms shall not be removed for read-write shares
-		$this->assertEquals(
-			$this->fixLinebreak($rwCalendar->getChild('event-0')->get()),
-			$this->fixLinebreak($publicObjectData));
-		$this->assertEquals(
-			$this->fixLinebreak($rwCalendar->getChild('event-1')->get()),
-			$this->fixLinebreak($confidentialObjectCleaned));
-
-		// valarms shall be removed for read-only shares
-		$this->assertEquals(
-			$this->fixLinebreak($roCalendar->getChild('event-0')->get()),
-			$this->fixLinebreak($publicObjectDataWithoutVAlarm));
-		$this->assertEquals(
-			$this->fixLinebreak($roCalendar->getChild('event-1')->get()),
-			$this->fixLinebreak($confidentialObjectCleaned));
-	}
-
-	private function fixLinebreak(string $str): string {
-		return preg_replace('~(*BSR_ANYCRLF)\R~', "\r\n", $str);
-	}
+        $publicObject = ['uri' => 'event-0',
+            'classification' => CalDavBackend::CLASSIFICATION_PUBLIC,
+            'calendardata' => $publicObjectData];
+
+        $confidentialObject = ['uri' => 'event-1',
+            'classification' => CalDavBackend::CLASSIFICATION_CONFIDENTIAL,
+            'calendardata' => $confidentialObjectData];
+
+        /** @var CalDavBackend&MockObject $backend */
+        $backend = $this->createMock(CalDavBackend::class);
+        $backend->expects($this->any())
+            ->method('getCalendarObjects')
+            ->willReturn([$publicObject, $confidentialObject]);
+
+        $backend->expects($this->any())
+            ->method('getMultipleCalendarObjects')
+            ->with(666, ['event-0', 'event-1'])
+            ->willReturn([$publicObject, $confidentialObject]);
+
+        $backend->expects($this->any())
+            ->method('getCalendarObject')
+            ->willReturnCallback(function ($cId, $uri) use ($publicObject, $confidentialObject) {
+                switch ($uri) {
+                    case 'event-0':
+                        return $publicObject;
+
+                    case 'event-1':
+                        return $confidentialObject;
+
+                    default:
+                        throw new \Exception('unexpected uri');
+                }
+            });
+
+        $backend->expects($this->any())
+            ->method('applyShareAcl')
+            ->willReturnArgument(1);
+
+        $calendarInfoOwner = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $calendarInfoSharedRW = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+        $calendarInfoSharedRO = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{http://owncloud.org/ns}read-only' => true,
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'cal',
+        ];
+
+        $ownerCalendar = new Calendar($backend, $calendarInfoOwner, $this->l10n, $this->config, $this->logger);
+        $rwCalendar = new Calendar($backend, $calendarInfoSharedRW, $this->l10n, $this->config, $this->logger);
+        $roCalendar = new Calendar($backend, $calendarInfoSharedRO, $this->l10n, $this->config, $this->logger);
+
+        $this->assertCount(2, $ownerCalendar->getChildren());
+        $this->assertCount(2, $rwCalendar->getChildren());
+        $this->assertCount(2, $roCalendar->getChildren());
+
+        // calendar data shall not be altered for the owner
+        $this->assertEquals($ownerCalendar->getChild('event-0')->get(), $publicObjectData);
+        $this->assertEquals($ownerCalendar->getChild('event-1')->get(), $confidentialObjectData);
+
+        // valarms shall not be removed for read-write shares
+        $this->assertEquals(
+            $this->fixLinebreak($rwCalendar->getChild('event-0')->get()),
+            $this->fixLinebreak($publicObjectData));
+        $this->assertEquals(
+            $this->fixLinebreak($rwCalendar->getChild('event-1')->get()),
+            $this->fixLinebreak($confidentialObjectCleaned));
+
+        // valarms shall be removed for read-only shares
+        $this->assertEquals(
+            $this->fixLinebreak($roCalendar->getChild('event-0')->get()),
+            $this->fixLinebreak($publicObjectDataWithoutVAlarm));
+        $this->assertEquals(
+            $this->fixLinebreak($roCalendar->getChild('event-1')->get()),
+            $this->fixLinebreak($confidentialObjectCleaned));
+    }
+
+    private function fixLinebreak(string $str): string {
+        return preg_replace('~(*BSR_ANYCRLF)\R~', "\r\n", $str);
+    }
 }

apps/dav/tests/unit/CalDAV/WebcalCaching/RefreshWebcalServiceTest.php

Indentation +302 added lines, -302 removed lines

@@ -20,306 +20,306 @@
 use Test\TestCase;
 
 class RefreshWebcalServiceTest extends TestCase {
-	private CalDavBackend&MockObject $caldavBackend;
-	private Connection&MockObject $connection;
-	private LoggerInterface&MockObject $logger;
-	private ITimeFactory&MockObject $time;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->caldavBackend = $this->createMock(CalDavBackend::class);
-		$this->connection = $this->createMock(Connection::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->time = $this->createMock(ITimeFactory::class);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
-	public function testRun(string $body, string $contentType, string $result): void {
-		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri'])
-			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
-			->getMock();
-
-		$refreshWebcalService
-			->method('getRandomCalendarObjectUri')
-			->willReturn('uri-1.ics');
-
-		$this->caldavBackend->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/testuser')
-			->willReturn([
-				[
-					'id' => '99',
-					'uri' => 'sub456',
-					RefreshWebcalService::REFRESH_RATE => 'P1D',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla',
-					'lastmodified' => 0,
-				],
-				[
-					'id' => '42',
-					'uri' => 'sub123',
-					RefreshWebcalService::REFRESH_RATE => 'PT1H',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla2',
-					'lastmodified' => 0,
-				],
-			]);
-
-		$this->connection->expects(self::once())
-			->method('queryWebcalFeed')
-			->willReturn($result);
-		$this->caldavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->with(42, 'uri-1.ics', $result, 1);
-
-		$refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('identicalDataProvider')]
-	public function testRunIdentical(string $uid, array $calendarObject, string $body, string $contentType, string $result): void {
-		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri'])
-			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
-			->getMock();
-
-		$refreshWebcalService
-			->method('getRandomCalendarObjectUri')
-			->willReturn('uri-1.ics');
-
-		$this->caldavBackend->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/testuser')
-			->willReturn([
-				[
-					'id' => '99',
-					'uri' => 'sub456',
-					RefreshWebcalService::REFRESH_RATE => 'P1D',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla',
-					'lastmodified' => 0,
-				],
-				[
-					'id' => '42',
-					'uri' => 'sub123',
-					RefreshWebcalService::REFRESH_RATE => 'PT1H',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla2',
-					'lastmodified' => 0,
-				],
-			]);
-
-		$this->connection->expects(self::once())
-			->method('queryWebcalFeed')
-			->willReturn($result);
-
-		$this->caldavBackend->expects(self::once())
-			->method('getLimitedCalendarObjects')
-			->willReturn($calendarObject);
-
-		$denormalised = [
-			'etag' => 100,
-			'size' => strlen($calendarObject[$uid]['calendardata']),
-			'uid' => 'sub456'
-		];
-
-		$this->caldavBackend->expects(self::once())
-			->method('getDenormalizedData')
-			->willReturn($denormalised);
-
-		$this->caldavBackend->expects(self::never())
-			->method('createCalendarObject');
-
-		$refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub456');
-	}
-
-	public function testRunJustUpdated(): void {
-		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri'])
-			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
-			->getMock();
-
-		$refreshWebcalService
-			->method('getRandomCalendarObjectUri')
-			->willReturn('uri-1.ics');
-
-		$this->caldavBackend->expects(self::once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/testuser')
-			->willReturn([
-				[
-					'id' => '99',
-					'uri' => 'sub456',
-					RefreshWebcalService::REFRESH_RATE => 'P1D',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla',
-					'lastmodified' => time(),
-				],
-				[
-					'id' => '42',
-					'uri' => 'sub123',
-					RefreshWebcalService::REFRESH_RATE => 'PT1H',
-					RefreshWebcalService::STRIP_TODOS => '1',
-					RefreshWebcalService::STRIP_ALARMS => '1',
-					RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-					'source' => 'webcal://foo.bar/bla2',
-					'lastmodified' => time(),
-				],
-			]);
-
-		$timeMock = $this->createMock(\DateTime::class);
-		$this->time->expects(self::once())
-			->method('getDateTime')
-			->willReturn($timeMock);
-		$timeMock->expects(self::once())
-			->method('getTimestamp')
-			->willReturn(2101724667);
-		$this->time->expects(self::once())
-			->method('getTime')
-			->willReturn(time());
-		$this->connection->expects(self::never())
-			->method('queryWebcalFeed');
-		$this->caldavBackend->expects(self::never())
-			->method('createCalendarObject');
-
-		$refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
-	public function testRunCreateCalendarNoException(string $body, string $contentType, string $result): void {
-		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription',])
-			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
-			->getMock();
-
-		$refreshWebcalService
-			->method('getRandomCalendarObjectUri')
-			->willReturn('uri-1.ics');
-
-		$refreshWebcalService
-			->method('getSubscription')
-			->willReturn([
-				'id' => '42',
-				'uri' => 'sub123',
-				RefreshWebcalService::REFRESH_RATE => 'PT1H',
-				RefreshWebcalService::STRIP_TODOS => '1',
-				RefreshWebcalService::STRIP_ALARMS => '1',
-				RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-				'source' => 'webcal://foo.bar/bla2',
-				'lastmodified' => 0,
-			]);
-
-		$this->connection->expects(self::once())
-			->method('queryWebcalFeed')
-			->willReturn($result);
-
-		$this->caldavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->with(42, 'uri-1.ics', $result, 1);
-
-		$noInstanceException = new NoInstancesException("can't add calendar object");
-		$this->caldavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->willThrowException($noInstanceException);
-
-		$this->logger->expects(self::once())
-			->method('warning')
-			->with('Unable to create calendar object from subscription {subscriptionId}', ['exception' => $noInstanceException, 'subscriptionId' => '42', 'source' => 'webcal://foo.bar/bla2']);
-
-		$refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
-	public function testRunCreateCalendarBadRequest(string $body, string $contentType, string $result): void {
-		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription'])
-			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
-			->getMock();
-
-		$refreshWebcalService
-			->method('getRandomCalendarObjectUri')
-			->willReturn('uri-1.ics');
-
-		$refreshWebcalService
-			->method('getSubscription')
-			->willReturn([
-				'id' => '42',
-				'uri' => 'sub123',
-				RefreshWebcalService::REFRESH_RATE => 'PT1H',
-				RefreshWebcalService::STRIP_TODOS => '1',
-				RefreshWebcalService::STRIP_ALARMS => '1',
-				RefreshWebcalService::STRIP_ATTACHMENTS => '1',
-				'source' => 'webcal://foo.bar/bla2',
-				'lastmodified' => 0,
-			]);
-
-		$this->connection->expects(self::once())
-			->method('queryWebcalFeed')
-			->willReturn($result);
-
-		$this->caldavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->with(42, 'uri-1.ics', $result, 1);
-
-		$badRequestException = new BadRequest("can't add reach calendar url");
-		$this->caldavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->willThrowException($badRequestException);
-
-		$this->logger->expects(self::once())
-			->method('warning')
-			->with('Unable to create calendar object from subscription {subscriptionId}', ['exception' => $badRequestException, 'subscriptionId' => '42', 'source' => 'webcal://foo.bar/bla2']);
-
-		$refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
-	}
-
-	public static function identicalDataProvider(): array {
-		return [
-			[
-				'12345',
-				[
-					'12345' => [
-						'id' => 42,
-						'etag' => 100,
-						'uri' => 'sub456',
-						'calendardata' => "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-					],
-				],
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-				'text/calendar;charset=utf8',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20180218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-			],
-		];
-	}
-
-	public static function runDataProvider(): array {
-		return [
-			[
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-				'text/calendar;charset=utf8',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-			],
-			[
-				'["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
-				'application/calendar+json',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VTIMEZONE\r\nLAST-MODIFIED:20040110T032845Z\r\nTZID:US/Eastern\r\nBEGIN:DAYLIGHT\r\nDTSTART:20000404T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=4\r\nTZNAME:EDT\r\nTZOFFSETFROM:-0500\r\nTZOFFSETTO:-0400\r\nEND:DAYLIGHT\r\nBEGIN:STANDARD\r\nDTSTART:20001026T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=10\r\nTZNAME:EST\r\nTZOFFSETFROM:-0400\r\nTZOFFSETTO:-0500\r\nEND:STANDARD\r\nEND:VTIMEZONE\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060102T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
-			],
-			[
-				'<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
-				'application/calendar+xml',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060104T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2 bis\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
-			]
-		];
-	}
+    private CalDavBackend&MockObject $caldavBackend;
+    private Connection&MockObject $connection;
+    private LoggerInterface&MockObject $logger;
+    private ITimeFactory&MockObject $time;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->caldavBackend = $this->createMock(CalDavBackend::class);
+        $this->connection = $this->createMock(Connection::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->time = $this->createMock(ITimeFactory::class);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
+    public function testRun(string $body, string $contentType, string $result): void {
+        $refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
+            ->onlyMethods(['getRandomCalendarObjectUri'])
+            ->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
+            ->getMock();
+
+        $refreshWebcalService
+            ->method('getRandomCalendarObjectUri')
+            ->willReturn('uri-1.ics');
+
+        $this->caldavBackend->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/testuser')
+            ->willReturn([
+                [
+                    'id' => '99',
+                    'uri' => 'sub456',
+                    RefreshWebcalService::REFRESH_RATE => 'P1D',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla',
+                    'lastmodified' => 0,
+                ],
+                [
+                    'id' => '42',
+                    'uri' => 'sub123',
+                    RefreshWebcalService::REFRESH_RATE => 'PT1H',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla2',
+                    'lastmodified' => 0,
+                ],
+            ]);
+
+        $this->connection->expects(self::once())
+            ->method('queryWebcalFeed')
+            ->willReturn($result);
+        $this->caldavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->with(42, 'uri-1.ics', $result, 1);
+
+        $refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('identicalDataProvider')]
+    public function testRunIdentical(string $uid, array $calendarObject, string $body, string $contentType, string $result): void {
+        $refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
+            ->onlyMethods(['getRandomCalendarObjectUri'])
+            ->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
+            ->getMock();
+
+        $refreshWebcalService
+            ->method('getRandomCalendarObjectUri')
+            ->willReturn('uri-1.ics');
+
+        $this->caldavBackend->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/testuser')
+            ->willReturn([
+                [
+                    'id' => '99',
+                    'uri' => 'sub456',
+                    RefreshWebcalService::REFRESH_RATE => 'P1D',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla',
+                    'lastmodified' => 0,
+                ],
+                [
+                    'id' => '42',
+                    'uri' => 'sub123',
+                    RefreshWebcalService::REFRESH_RATE => 'PT1H',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla2',
+                    'lastmodified' => 0,
+                ],
+            ]);
+
+        $this->connection->expects(self::once())
+            ->method('queryWebcalFeed')
+            ->willReturn($result);
+
+        $this->caldavBackend->expects(self::once())
+            ->method('getLimitedCalendarObjects')
+            ->willReturn($calendarObject);
+
+        $denormalised = [
+            'etag' => 100,
+            'size' => strlen($calendarObject[$uid]['calendardata']),
+            'uid' => 'sub456'
+        ];
+
+        $this->caldavBackend->expects(self::once())
+            ->method('getDenormalizedData')
+            ->willReturn($denormalised);
+
+        $this->caldavBackend->expects(self::never())
+            ->method('createCalendarObject');
+
+        $refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub456');
+    }
+
+    public function testRunJustUpdated(): void {
+        $refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
+            ->onlyMethods(['getRandomCalendarObjectUri'])
+            ->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
+            ->getMock();
+
+        $refreshWebcalService
+            ->method('getRandomCalendarObjectUri')
+            ->willReturn('uri-1.ics');
+
+        $this->caldavBackend->expects(self::once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/testuser')
+            ->willReturn([
+                [
+                    'id' => '99',
+                    'uri' => 'sub456',
+                    RefreshWebcalService::REFRESH_RATE => 'P1D',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla',
+                    'lastmodified' => time(),
+                ],
+                [
+                    'id' => '42',
+                    'uri' => 'sub123',
+                    RefreshWebcalService::REFRESH_RATE => 'PT1H',
+                    RefreshWebcalService::STRIP_TODOS => '1',
+                    RefreshWebcalService::STRIP_ALARMS => '1',
+                    RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                    'source' => 'webcal://foo.bar/bla2',
+                    'lastmodified' => time(),
+                ],
+            ]);
+
+        $timeMock = $this->createMock(\DateTime::class);
+        $this->time->expects(self::once())
+            ->method('getDateTime')
+            ->willReturn($timeMock);
+        $timeMock->expects(self::once())
+            ->method('getTimestamp')
+            ->willReturn(2101724667);
+        $this->time->expects(self::once())
+            ->method('getTime')
+            ->willReturn(time());
+        $this->connection->expects(self::never())
+            ->method('queryWebcalFeed');
+        $this->caldavBackend->expects(self::never())
+            ->method('createCalendarObject');
+
+        $refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
+    public function testRunCreateCalendarNoException(string $body, string $contentType, string $result): void {
+        $refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
+            ->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription',])
+            ->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
+            ->getMock();
+
+        $refreshWebcalService
+            ->method('getRandomCalendarObjectUri')
+            ->willReturn('uri-1.ics');
+
+        $refreshWebcalService
+            ->method('getSubscription')
+            ->willReturn([
+                'id' => '42',
+                'uri' => 'sub123',
+                RefreshWebcalService::REFRESH_RATE => 'PT1H',
+                RefreshWebcalService::STRIP_TODOS => '1',
+                RefreshWebcalService::STRIP_ALARMS => '1',
+                RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                'source' => 'webcal://foo.bar/bla2',
+                'lastmodified' => 0,
+            ]);
+
+        $this->connection->expects(self::once())
+            ->method('queryWebcalFeed')
+            ->willReturn($result);
+
+        $this->caldavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->with(42, 'uri-1.ics', $result, 1);
+
+        $noInstanceException = new NoInstancesException("can't add calendar object");
+        $this->caldavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->willThrowException($noInstanceException);
+
+        $this->logger->expects(self::once())
+            ->method('warning')
+            ->with('Unable to create calendar object from subscription {subscriptionId}', ['exception' => $noInstanceException, 'subscriptionId' => '42', 'source' => 'webcal://foo.bar/bla2']);
+
+        $refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
+    public function testRunCreateCalendarBadRequest(string $body, string $contentType, string $result): void {
+        $refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
+            ->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription'])
+            ->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
+            ->getMock();
+
+        $refreshWebcalService
+            ->method('getRandomCalendarObjectUri')
+            ->willReturn('uri-1.ics');
+
+        $refreshWebcalService
+            ->method('getSubscription')
+            ->willReturn([
+                'id' => '42',
+                'uri' => 'sub123',
+                RefreshWebcalService::REFRESH_RATE => 'PT1H',
+                RefreshWebcalService::STRIP_TODOS => '1',
+                RefreshWebcalService::STRIP_ALARMS => '1',
+                RefreshWebcalService::STRIP_ATTACHMENTS => '1',
+                'source' => 'webcal://foo.bar/bla2',
+                'lastmodified' => 0,
+            ]);
+
+        $this->connection->expects(self::once())
+            ->method('queryWebcalFeed')
+            ->willReturn($result);
+
+        $this->caldavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->with(42, 'uri-1.ics', $result, 1);
+
+        $badRequestException = new BadRequest("can't add reach calendar url");
+        $this->caldavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->willThrowException($badRequestException);
+
+        $this->logger->expects(self::once())
+            ->method('warning')
+            ->with('Unable to create calendar object from subscription {subscriptionId}', ['exception' => $badRequestException, 'subscriptionId' => '42', 'source' => 'webcal://foo.bar/bla2']);
+
+        $refreshWebcalService->refreshSubscription('principals/users/testuser', 'sub123');
+    }
+
+    public static function identicalDataProvider(): array {
+        return [
+            [
+                '12345',
+                [
+                    '12345' => [
+                        'id' => 42,
+                        'etag' => 100,
+                        'uri' => 'sub456',
+                        'calendardata' => "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+                    ],
+                ],
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+                'text/calendar;charset=utf8',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20180218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+            ],
+        ];
+    }
+
+    public static function runDataProvider(): array {
+        return [
+            [
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+                'text/calendar;charset=utf8',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+            ],
+            [
+                '["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
+                'application/calendar+json',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VTIMEZONE\r\nLAST-MODIFIED:20040110T032845Z\r\nTZID:US/Eastern\r\nBEGIN:DAYLIGHT\r\nDTSTART:20000404T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=4\r\nTZNAME:EDT\r\nTZOFFSETFROM:-0500\r\nTZOFFSETTO:-0400\r\nEND:DAYLIGHT\r\nBEGIN:STANDARD\r\nDTSTART:20001026T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=10\r\nTZNAME:EST\r\nTZOFFSETFROM:-0400\r\nTZOFFSETTO:-0500\r\nEND:STANDARD\r\nEND:VTIMEZONE\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060102T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
+            ],
+            [
+                '<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
+                'application/calendar+xml',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060104T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2 bis\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
+            ]
+        ];
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -199,7 +199,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('runDataProvider')]
 	public function testRunCreateCalendarNoException(string $body, string $contentType, string $result): void {
 		$refreshWebcalService = $this->getMockBuilder(RefreshWebcalService::class)
-			->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription',])
+			->onlyMethods(['getRandomCalendarObjectUri', 'getSubscription', ])
 			->setConstructorArgs([$this->caldavBackend, $this->logger, $this->connection, $this->time])
 			->getMock();
 
@@ -308,17 +308,17 @@ 
 			[
 				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
 				'text/calendar;charset=utf8',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject ".VObject\Version::VERSION."//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
 			],
 			[
 				'["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
 				'application/calendar+json',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VTIMEZONE\r\nLAST-MODIFIED:20040110T032845Z\r\nTZID:US/Eastern\r\nBEGIN:DAYLIGHT\r\nDTSTART:20000404T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=4\r\nTZNAME:EDT\r\nTZOFFSETFROM:-0500\r\nTZOFFSETTO:-0400\r\nEND:DAYLIGHT\r\nBEGIN:STANDARD\r\nDTSTART:20001026T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=10\r\nTZNAME:EST\r\nTZOFFSETFROM:-0400\r\nTZOFFSETTO:-0500\r\nEND:STANDARD\r\nEND:VTIMEZONE\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060102T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
+				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject ".VObject\Version::VERSION."//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VTIMEZONE\r\nLAST-MODIFIED:20040110T032845Z\r\nTZID:US/Eastern\r\nBEGIN:DAYLIGHT\r\nDTSTART:20000404T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=4\r\nTZNAME:EDT\r\nTZOFFSETFROM:-0500\r\nTZOFFSETTO:-0400\r\nEND:DAYLIGHT\r\nBEGIN:STANDARD\r\nDTSTART:20001026T020000\r\nRRULE:FREQ=YEARLY;BYDAY=1SU;BYMONTH=10\r\nTZNAME:EST\r\nTZOFFSETFROM:-0400\r\nTZOFFSETTO:-0500\r\nEND:STANDARD\r\nEND:VTIMEZONE\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060102T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
 			],
 			[
 				'<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
 				'application/calendar+xml',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject " . VObject\Version::VERSION . "//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060104T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2 bis\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
+				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject ".VObject\Version::VERSION."//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nDTSTAMP:20060206T001121Z\r\nDTSTART;TZID=US/Eastern:20060104T140000\r\nDURATION:PT1H\r\nRECURRENCE-ID;TZID=US/Eastern:20060104T120000\r\nSUMMARY:Event #2 bis\r\nUID:12345\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"
 			]
 		];
 	}

apps/dav/tests/unit/CalDAV/WebcalCaching/ConnectionTest.php

Indentation +153 added lines, -153 removed lines

@@ -20,157 +20,157 @@
 
 class ConnectionTest extends TestCase {
 
-	private IClientService&MockObject $clientService;
-	private IAppConfig&MockObject $config;
-	private LoggerInterface&MockObject $logger;
-	private Connection $connection;
-
-	public function setUp(): void {
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->config = $this->createMock(IAppConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->connection = new Connection($this->clientService, $this->config, $this->logger);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('runLocalURLDataProvider')]
-	public function testLocalUrl($source): void {
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => $source,
-			'lastmodified' => 0,
-		];
-
-		$client = $this->createMock(IClient::class);
-		$this->clientService->expects(self::once())
-			->method('newClient')
-			->with()
-			->willReturn($client);
-
-		$this->config->expects(self::once())
-			->method('getValueString')
-			->with('dav', 'webcalAllowLocalAccess', 'no')
-			->willReturn('no');
-
-		$localServerException = new LocalServerException();
-		$client->expects(self::once())
-			->method('get')
-			->willThrowException($localServerException);
-		$this->logger->expects(self::once())
-			->method('warning')
-			->with('Subscription 42 was not refreshed because it violates local access rules', ['exception' => $localServerException]);
-
-		$this->connection->queryWebcalFeed($subscription);
-	}
-
-	public function testInvalidUrl(): void {
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => '!@#$',
-			'lastmodified' => 0,
-		];
-
-		$client = $this->createMock(IClient::class);
-		$this->config->expects(self::never())
-			->method('getValueString');
-		$client->expects(self::never())
-			->method('get');
-
-		$this->connection->queryWebcalFeed($subscription);
-
-	}
-
-	/**
-	 * @param string $result
-	 * @param string $contentType
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('urlDataProvider')]
-	public function testConnection(string $url, string $result, string $contentType): void {
-		$client = $this->createMock(IClient::class);
-		$response = $this->createMock(IResponse::class);
-		$subscription = [
-			'id' => 42,
-			'uri' => 'sub123',
-			'refreshreate' => 'P1H',
-			'striptodos' => 1,
-			'stripalarms' => 1,
-			'stripattachments' => 1,
-			'source' => $url,
-			'lastmodified' => 0,
-		];
-
-		$this->clientService->expects($this->once())
-			->method('newClient')
-			->with()
-			->willReturn($client);
-
-		$this->config->expects($this->once())
-			->method('getValueString')
-			->with('dav', 'webcalAllowLocalAccess', 'no')
-			->willReturn('no');
-
-		$client->expects($this->once())
-			->method('get')
-			->with('https://foo.bar/bla2')
-			->willReturn($response);
-
-		$response->expects($this->once())
-			->method('getBody')
-			->with()
-			->willReturn($result);
-		$response->expects($this->once())
-			->method('getHeader')
-			->with('Content-Type')
-			->willReturn($contentType);
-
-		$this->connection->queryWebcalFeed($subscription);
-	}
-
-	public static function runLocalURLDataProvider(): array {
-		return [
-			['localhost/foo.bar'],
-			['localHost/foo.bar'],
-			['random-host/foo.bar'],
-			['[::1]/bla.blub'],
-			['[::]/bla.blub'],
-			['192.168.0.1'],
-			['172.16.42.1'],
-			['[fdf8:f53b:82e4::53]/secret.ics'],
-			['[fe80::200:5aee:feaa:20a2]/secret.ics'],
-			['[0:0:0:0:0:0:10.0.0.1]/secret.ics'],
-			['[0:0:0:0:0:ffff:127.0.0.0]/secret.ics'],
-			['10.0.0.1'],
-			['another-host.local'],
-			['service.localhost'],
-		];
-	}
-
-	public static function urlDataProvider(): array {
-		return [
-			[
-				'https://foo.bar/bla2',
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-				'text/calendar;charset=utf8',
-			],
-			[
-				'https://foo.bar/bla2',
-				'["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
-				'application/calendar+json',
-			],
-			[
-				'https://foo.bar/bla2',
-				'<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
-				'application/calendar+xml',
-			],
-		];
-	}
+    private IClientService&MockObject $clientService;
+    private IAppConfig&MockObject $config;
+    private LoggerInterface&MockObject $logger;
+    private Connection $connection;
+
+    public function setUp(): void {
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->config = $this->createMock(IAppConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->connection = new Connection($this->clientService, $this->config, $this->logger);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('runLocalURLDataProvider')]
+    public function testLocalUrl($source): void {
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => $source,
+            'lastmodified' => 0,
+        ];
+
+        $client = $this->createMock(IClient::class);
+        $this->clientService->expects(self::once())
+            ->method('newClient')
+            ->with()
+            ->willReturn($client);
+
+        $this->config->expects(self::once())
+            ->method('getValueString')
+            ->with('dav', 'webcalAllowLocalAccess', 'no')
+            ->willReturn('no');
+
+        $localServerException = new LocalServerException();
+        $client->expects(self::once())
+            ->method('get')
+            ->willThrowException($localServerException);
+        $this->logger->expects(self::once())
+            ->method('warning')
+            ->with('Subscription 42 was not refreshed because it violates local access rules', ['exception' => $localServerException]);
+
+        $this->connection->queryWebcalFeed($subscription);
+    }
+
+    public function testInvalidUrl(): void {
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => '!@#$',
+            'lastmodified' => 0,
+        ];
+
+        $client = $this->createMock(IClient::class);
+        $this->config->expects(self::never())
+            ->method('getValueString');
+        $client->expects(self::never())
+            ->method('get');
+
+        $this->connection->queryWebcalFeed($subscription);
+
+    }
+
+    /**
+     * @param string $result
+     * @param string $contentType
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('urlDataProvider')]
+    public function testConnection(string $url, string $result, string $contentType): void {
+        $client = $this->createMock(IClient::class);
+        $response = $this->createMock(IResponse::class);
+        $subscription = [
+            'id' => 42,
+            'uri' => 'sub123',
+            'refreshreate' => 'P1H',
+            'striptodos' => 1,
+            'stripalarms' => 1,
+            'stripattachments' => 1,
+            'source' => $url,
+            'lastmodified' => 0,
+        ];
+
+        $this->clientService->expects($this->once())
+            ->method('newClient')
+            ->with()
+            ->willReturn($client);
+
+        $this->config->expects($this->once())
+            ->method('getValueString')
+            ->with('dav', 'webcalAllowLocalAccess', 'no')
+            ->willReturn('no');
+
+        $client->expects($this->once())
+            ->method('get')
+            ->with('https://foo.bar/bla2')
+            ->willReturn($response);
+
+        $response->expects($this->once())
+            ->method('getBody')
+            ->with()
+            ->willReturn($result);
+        $response->expects($this->once())
+            ->method('getHeader')
+            ->with('Content-Type')
+            ->willReturn($contentType);
+
+        $this->connection->queryWebcalFeed($subscription);
+    }
+
+    public static function runLocalURLDataProvider(): array {
+        return [
+            ['localhost/foo.bar'],
+            ['localHost/foo.bar'],
+            ['random-host/foo.bar'],
+            ['[::1]/bla.blub'],
+            ['[::]/bla.blub'],
+            ['192.168.0.1'],
+            ['172.16.42.1'],
+            ['[fdf8:f53b:82e4::53]/secret.ics'],
+            ['[fe80::200:5aee:feaa:20a2]/secret.ics'],
+            ['[0:0:0:0:0:0:10.0.0.1]/secret.ics'],
+            ['[0:0:0:0:0:ffff:127.0.0.0]/secret.ics'],
+            ['10.0.0.1'],
+            ['another-host.local'],
+            ['service.localhost'],
+        ];
+    }
+
+    public static function urlDataProvider(): array {
+        return [
+            [
+                'https://foo.bar/bla2',
+                "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
+                'text/calendar;charset=utf8',
+            ],
+            [
+                'https://foo.bar/bla2',
+                '["vcalendar",[["prodid",{},"text","-//Example Corp.//Example Client//EN"],["version",{},"text","2.0"]],[["vtimezone",[["last-modified",{},"date-time","2004-01-10T03:28:45Z"],["tzid",{},"text","US/Eastern"]],[["daylight",[["dtstart",{},"date-time","2000-04-04T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":4}],["tzname",{},"text","EDT"],["tzoffsetfrom",{},"utc-offset","-05:00"],["tzoffsetto",{},"utc-offset","-04:00"]],[]],["standard",[["dtstart",{},"date-time","2000-10-26T02:00:00"],["rrule",{},"recur",{"freq":"YEARLY","byday":"1SU","bymonth":10}],["tzname",{},"text","EST"],["tzoffsetfrom",{},"utc-offset","-04:00"],["tzoffsetto",{},"utc-offset","-05:00"]],[]]]],["vevent",[["dtstamp",{},"date-time","2006-02-06T00:11:21Z"],["dtstart",{"tzid":"US/Eastern"},"date-time","2006-01-02T14:00:00"],["duration",{},"duration","PT1H"],["recurrence-id",{"tzid":"US/Eastern"},"date-time","2006-01-04T12:00:00"],["summary",{},"text","Event #2"],["uid",{},"text","12345"]],[]]]]',
+                'application/calendar+json',
+            ],
+            [
+                'https://foo.bar/bla2',
+                '<?xml version="1.0" encoding="utf-8" ?><icalendar xmlns="urn:ietf:params:xml:ns:icalendar-2.0"><vcalendar><properties><prodid><text>-//Example Inc.//Example Client//EN</text></prodid><version><text>2.0</text></version></properties><components><vevent><properties><dtstamp><date-time>2006-02-06T00:11:21Z</date-time></dtstamp><dtstart><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T14:00:00</date-time></dtstart><duration><duration>PT1H</duration></duration><recurrence-id><parameters><tzid><text>US/Eastern</text></tzid></parameters><date-time>2006-01-04T12:00:00</date-time></recurrence-id><summary><text>Event #2 bis</text></summary><uid><text>12345</text></uid></properties></vevent></components></vcalendar></icalendar>',
+                'application/calendar+xml',
+            ],
+        ];
+    }
 }

apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php

Indentation +533 added lines, -533 removed lines

@@ -20,537 +20,537 @@
 use Test\TestCase;
 
 abstract class AbstractPrincipalBackendTestCase extends TestCase {
-	protected ResourcePrincipalBackend|RoomPrincipalBackend $principalBackend;
-	protected IUserSession&MockObject $userSession;
-	protected IGroupManager&MockObject $groupManager;
-	protected LoggerInterface&MockObject $logger;
-	protected ProxyMapper&MockObject $proxyMapper;
-	protected string $mainDbTable;
-	protected string $metadataDbTable;
-	protected string $foreignKey;
-	protected string $principalPrefix;
-	protected string $expectedCUType;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->proxyMapper = $this->createMock(ProxyMapper::class);
-	}
-
-	protected function tearDown(): void {
-		$query = self::$realDatabase->getQueryBuilder();
-
-		$query->delete('calendar_resources')->executeStatement();
-		$query->delete('calendar_resources_md')->executeStatement();
-		$query->delete('calendar_rooms')->executeStatement();
-		$query->delete('calendar_rooms_md')->executeStatement();
-	}
-
-	public function testGetPrincipalsByPrefix(): void {
-		$actual = $this->principalBackend->getPrincipalsByPrefix($this->principalPrefix);
-
-		$this->assertEquals([
-			[
-				'uri' => $this->principalPrefix . '/backend1-res1',
-				'{DAV:}displayname' => 'Beamer1',
-				'{http://sabredav.org/ns}email-address' => 'res1@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-			],
-			[
-				'uri' => $this->principalPrefix . '/backend1-res2',
-				'{DAV:}displayname' => 'TV1',
-				'{http://sabredav.org/ns}email-address' => 'res2@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-			],
-			[
-				'uri' => $this->principalPrefix . '/backend2-res3',
-				'{DAV:}displayname' => 'Beamer2',
-				'{http://sabredav.org/ns}email-address' => 'res3@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-				'{http://nextcloud.com/ns}foo' => 'value1',
-				'{http://nextcloud.com/ns}meta2' => 'value2',
-			],
-			[
-				'uri' => $this->principalPrefix . '/backend2-res4',
-				'{DAV:}displayname' => 'TV2',
-				'{http://sabredav.org/ns}email-address' => 'res4@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-				'{http://nextcloud.com/ns}meta1' => 'value1',
-				'{http://nextcloud.com/ns}meta3' => 'value3-old',
-			],
-			[
-				'uri' => $this->principalPrefix . '/backend3-res5',
-				'{DAV:}displayname' => 'Beamer3',
-				'{http://sabredav.org/ns}email-address' => 'res5@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-			],
-			[
-				'uri' => $this->principalPrefix . '/backend3-res6',
-				'{DAV:}displayname' => 'Pointer',
-				'{http://sabredav.org/ns}email-address' => 'res6@foo.bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-				'{http://nextcloud.com/ns}meta99' => 'value99'
-			]
-		], $actual);
-	}
-
-	public function testGetNoPrincipalsByPrefixForWrongPrincipalPrefix(): void {
-		$actual = $this->principalBackend->getPrincipalsByPrefix('principals/users');
-		$this->assertEquals([], $actual);
-	}
-
-	public function testGetPrincipalByPath(): void {
-		$actual = $this->principalBackend->getPrincipalByPath($this->principalPrefix . '/backend2-res3');
-		$this->assertEquals([
-			'uri' => $this->principalPrefix . '/backend2-res3',
-			'{DAV:}displayname' => 'Beamer2',
-			'{http://sabredav.org/ns}email-address' => 'res3@foo.bar',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
-			'{http://nextcloud.com/ns}foo' => 'value1',
-			'{http://nextcloud.com/ns}meta2' => 'value2',
-		], $actual);
-	}
-
-	public function testGetPrincipalByPathNotFound(): void {
-		$actual = $this->principalBackend->getPrincipalByPath($this->principalPrefix . '/db-123');
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testGetPrincipalByPathWrongPrefix(): void {
-		$actual = $this->principalBackend->getPrincipalByPath('principals/users/foo-bar');
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testGetGroupMemberSet(): void {
-		$actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1');
-		$this->assertEquals([], $actual);
-	}
-
-	public function testGetGroupMemberSetProxyRead(): void {
-		$proxy1 = new Proxy();
-		$proxy1->setProxyId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setProxyId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$proxy3 = new Proxy();
-		$proxy3->setProxyId('proxyId3');
-		$proxy3->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with($this->principalPrefix . '/backend1-res1')
-			->willReturn([$proxy1, $proxy2, $proxy3]);
-
-		$actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-read');
-		$this->assertEquals(['proxyId1'], $actual);
-	}
-
-	public function testGetGroupMemberSetProxyWrite(): void {
-		$proxy1 = new Proxy();
-		$proxy1->setProxyId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setProxyId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$proxy3 = new Proxy();
-		$proxy3->setProxyId('proxyId3');
-		$proxy3->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with($this->principalPrefix . '/backend1-res1')
-			->willReturn([$proxy1, $proxy2, $proxy3]);
-
-		$actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-write');
-		$this->assertEquals(['proxyId2', 'proxyId3'], $actual);
-	}
-
-	public function testGetGroupMembership(): void {
-		$proxy1 = new Proxy();
-		$proxy1->setOwnerId('proxyId1');
-		$proxy1->setPermissions(1);
-
-		$proxy2 = new Proxy();
-		$proxy2->setOwnerId('proxyId2');
-		$proxy2->setPermissions(3);
-
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesFor')
-			->with($this->principalPrefix . '/backend1-res1')
-			->willReturn([$proxy1, $proxy2]);
-
-		$actual = $this->principalBackend->getGroupMembership($this->principalPrefix . '/backend1-res1');
-
-		$this->assertEquals(['proxyId1/calendar-proxy-read', 'proxyId2/calendar-proxy-write'], $actual);
-	}
-
-	public function testSetGroupMemberSet(): void {
-		$this->proxyMapper->expects($this->once())
-			->method('getProxiesOf')
-			->with($this->principalPrefix . '/backend1-res1')
-			->willReturn([]);
-
-		$calls = [
-			function ($proxy) {
-				/** @var Proxy $proxy */
-				if ($proxy->getOwnerId() !== $this->principalPrefix . '/backend1-res1') {
-					return false;
-				}
-				if ($proxy->getProxyId() !== $this->principalPrefix . '/backend1-res2') {
-					return false;
-				}
-				if ($proxy->getPermissions() !== 3) {
-					return false;
-				}
-
-				return true;
-			},
-			function ($proxy) {
-				/** @var Proxy $proxy */
-				if ($proxy->getOwnerId() !== $this->principalPrefix . '/backend1-res1') {
-					return false;
-				}
-				if ($proxy->getProxyId() !== $this->principalPrefix . '/backend2-res3') {
-					return false;
-				}
-				if ($proxy->getPermissions() !== 3) {
-					return false;
-				}
-
-				return true;
-			}
-		];
-		$this->proxyMapper->expects($this->exactly(2))
-			->method('insert')
-			->willReturnCallback(function ($proxy) use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertTrue($expected($proxy));
-				return $proxy;
-			});
-
-		$this->principalBackend->setGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-write', [$this->principalPrefix . '/backend1-res2', $this->principalPrefix . '/backend2-res3']);
-	}
-
-	public function testUpdatePrincipal(): void {
-		$propPatch = $this->createMock(PropPatch::class);
-		$actual = $this->principalBackend->updatePrincipal($this->principalPrefix . '/foo-bar', $propPatch);
-
-		$this->assertEquals(0, $actual);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSearchPrincipals')]
-	public function testSearchPrincipals($expected, $test): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
-			'{http://sabredav.org/ns}email-address' => 'foo',
-			'{DAV:}displayname' => 'Beamer',
-		], $test);
-
-		$this->assertEquals(
-			str_replace('%prefix%', $this->principalPrefix, $expected),
-			$actual);
-	}
-
-	public static function dataSearchPrincipals(): array {
-		// data providers are called before we subclass
-		// this class, $this->principalPrefix is null
-		// at that point, so we need this hack
-		return [
-			[[
-				'%prefix%/backend1-res1',
-				'%prefix%/backend2-res3',
-			], 'allof'],
-			[[
-				'%prefix%/backend1-res1',
-				'%prefix%/backend1-res2',
-				'%prefix%/backend2-res3',
-				'%prefix%/backend2-res4',
-				'%prefix%/backend3-res6',
-			], 'anyof'],
-		];
-	}
-
-	public function testSearchPrincipalsByMetadataKey(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
-			'{http://nextcloud.com/ns}meta3' => 'value',
-		]);
-
-		$this->assertEquals([
-			$this->principalPrefix . '/backend2-res4',
-		], $actual);
-	}
-
-	public function testSearchPrincipalsByCalendarUserAddressSet(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => 'res2@foo.bar',
-		]);
-
-		$this->assertEquals(
-			str_replace('%prefix%', $this->principalPrefix, [
-				'%prefix%/backend1-res2',
-			]),
-			$actual);
-	}
-
-	public function testSearchPrincipalsEmptySearchProperties(): void {
-		$this->userSession->expects($this->never())
-			->method('getUser');
-		$this->groupManager->expects($this->never())
-			->method('getUserGroupIds');
-
-		$this->principalBackend->searchPrincipals($this->principalPrefix, []);
-	}
-
-	public function testSearchPrincipalsWrongPrincipalPrefix(): void {
-		$this->userSession->expects($this->never())
-			->method('getUser');
-		$this->groupManager->expects($this->never())
-			->method('getUserGroupIds');
-
-		$this->principalBackend->searchPrincipals('principals/users', [
-			'{http://sabredav.org/ns}email-address' => 'foo'
-		]);
-	}
-
-	public function testFindByUriByEmail(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('mailto:res1@foo.bar', $this->principalPrefix);
-		$this->assertEquals($this->principalPrefix . '/backend1-res1', $actual);
-	}
-
-	public function testFindByUriByEmailForbiddenResource(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('mailto:res5@foo.bar', $this->principalPrefix);
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testFindByUriByEmailNotFound(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('mailto:res99@foo.bar', $this->principalPrefix);
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testFindByUriByPrincipal(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('mailto:res6@foo.bar', $this->principalPrefix);
-		$this->assertEquals($this->principalPrefix . '/backend3-res6', $actual);
-	}
-
-	public function testFindByUriByPrincipalForbiddenResource(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('principal:' . $this->principalPrefix . '/backend3-res5', $this->principalPrefix);
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testFindByUriByPrincipalNotFound(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('principal:' . $this->principalPrefix . '/db-123', $this->principalPrefix);
-		$this->assertEquals(null, $actual);
-	}
-
-	public function testFindByUriByUnknownUri(): void {
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->with()
-			->willReturn($user);
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn(['group1', 'group2']);
-
-		$actual = $this->principalBackend->findByUri('foobar:blub', $this->principalPrefix);
-		$this->assertEquals(null, $actual);
-	}
-
-	protected function createTestDatasetInDb() {
-		$query = self::$realDatabase->getQueryBuilder();
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend1'),
-				'resource_id' => $query->createNamedParameter('res1'),
-				'email' => $query->createNamedParameter('res1@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer1'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->execute();
-
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend1'),
-				'resource_id' => $query->createNamedParameter('res2'),
-				'email' => $query->createNamedParameter('res2@foo.bar'),
-				'displayname' => $query->createNamedParameter('TV1'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->execute();
-
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend2'),
-				'resource_id' => $query->createNamedParameter('res3'),
-				'email' => $query->createNamedParameter('res3@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer2'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->execute();
-		$id3 = $query->getLastInsertId();
-
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend2'),
-				'resource_id' => $query->createNamedParameter('res4'),
-				'email' => $query->createNamedParameter('res4@foo.bar'),
-				'displayname' => $query->createNamedParameter('TV2'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->execute();
-		$id4 = $query->getLastInsertId();
-
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend3'),
-				'resource_id' => $query->createNamedParameter('res5'),
-				'email' => $query->createNamedParameter('res5@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer3'),
-				'group_restrictions' => $query->createNamedParameter('["foo", "bar"]'),
-			])
-			->execute();
-
-		$query->insert($this->mainDbTable)
-			->values([
-				'backend_id' => $query->createNamedParameter('backend3'),
-				'resource_id' => $query->createNamedParameter('res6'),
-				'email' => $query->createNamedParameter('res6@foo.bar'),
-				'displayname' => $query->createNamedParameter('Pointer'),
-				'group_restrictions' => $query->createNamedParameter('["group1", "bar"]'),
-			])
-			->execute();
-		$id6 = $query->getLastInsertId();
-
-		$query->insert($this->metadataDbTable)
-			->values([
-				$this->foreignKey => $query->createNamedParameter($id3),
-				'key' => $query->createNamedParameter('{http://nextcloud.com/ns}foo'),
-				'value' => $query->createNamedParameter('value1')
-			])
-			->execute();
-		$query->insert($this->metadataDbTable)
-			->values([
-				$this->foreignKey => $query->createNamedParameter($id3),
-				'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta2'),
-				'value' => $query->createNamedParameter('value2')
-			])
-			->execute();
-		$query->insert($this->metadataDbTable)
-			->values([
-				$this->foreignKey => $query->createNamedParameter($id4),
-				'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta1'),
-				'value' => $query->createNamedParameter('value1')
-			])
-			->execute();
-		$query->insert($this->metadataDbTable)
-			->values([
-				$this->foreignKey => $query->createNamedParameter($id4),
-				'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta3'),
-				'value' => $query->createNamedParameter('value3-old')
-			])
-			->execute();
-		$query->insert($this->metadataDbTable)
-			->values([
-				$this->foreignKey => $query->createNamedParameter($id6),
-				'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta99'),
-				'value' => $query->createNamedParameter('value99')
-			])
-			->execute();
-	}
+    protected ResourcePrincipalBackend|RoomPrincipalBackend $principalBackend;
+    protected IUserSession&MockObject $userSession;
+    protected IGroupManager&MockObject $groupManager;
+    protected LoggerInterface&MockObject $logger;
+    protected ProxyMapper&MockObject $proxyMapper;
+    protected string $mainDbTable;
+    protected string $metadataDbTable;
+    protected string $foreignKey;
+    protected string $principalPrefix;
+    protected string $expectedCUType;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->proxyMapper = $this->createMock(ProxyMapper::class);
+    }
+
+    protected function tearDown(): void {
+        $query = self::$realDatabase->getQueryBuilder();
+
+        $query->delete('calendar_resources')->executeStatement();
+        $query->delete('calendar_resources_md')->executeStatement();
+        $query->delete('calendar_rooms')->executeStatement();
+        $query->delete('calendar_rooms_md')->executeStatement();
+    }
+
+    public function testGetPrincipalsByPrefix(): void {
+        $actual = $this->principalBackend->getPrincipalsByPrefix($this->principalPrefix);
+
+        $this->assertEquals([
+            [
+                'uri' => $this->principalPrefix . '/backend1-res1',
+                '{DAV:}displayname' => 'Beamer1',
+                '{http://sabredav.org/ns}email-address' => 'res1@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+            ],
+            [
+                'uri' => $this->principalPrefix . '/backend1-res2',
+                '{DAV:}displayname' => 'TV1',
+                '{http://sabredav.org/ns}email-address' => 'res2@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+            ],
+            [
+                'uri' => $this->principalPrefix . '/backend2-res3',
+                '{DAV:}displayname' => 'Beamer2',
+                '{http://sabredav.org/ns}email-address' => 'res3@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+                '{http://nextcloud.com/ns}foo' => 'value1',
+                '{http://nextcloud.com/ns}meta2' => 'value2',
+            ],
+            [
+                'uri' => $this->principalPrefix . '/backend2-res4',
+                '{DAV:}displayname' => 'TV2',
+                '{http://sabredav.org/ns}email-address' => 'res4@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+                '{http://nextcloud.com/ns}meta1' => 'value1',
+                '{http://nextcloud.com/ns}meta3' => 'value3-old',
+            ],
+            [
+                'uri' => $this->principalPrefix . '/backend3-res5',
+                '{DAV:}displayname' => 'Beamer3',
+                '{http://sabredav.org/ns}email-address' => 'res5@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+            ],
+            [
+                'uri' => $this->principalPrefix . '/backend3-res6',
+                '{DAV:}displayname' => 'Pointer',
+                '{http://sabredav.org/ns}email-address' => 'res6@foo.bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+                '{http://nextcloud.com/ns}meta99' => 'value99'
+            ]
+        ], $actual);
+    }
+
+    public function testGetNoPrincipalsByPrefixForWrongPrincipalPrefix(): void {
+        $actual = $this->principalBackend->getPrincipalsByPrefix('principals/users');
+        $this->assertEquals([], $actual);
+    }
+
+    public function testGetPrincipalByPath(): void {
+        $actual = $this->principalBackend->getPrincipalByPath($this->principalPrefix . '/backend2-res3');
+        $this->assertEquals([
+            'uri' => $this->principalPrefix . '/backend2-res3',
+            '{DAV:}displayname' => 'Beamer2',
+            '{http://sabredav.org/ns}email-address' => 'res3@foo.bar',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => $this->expectedCUType,
+            '{http://nextcloud.com/ns}foo' => 'value1',
+            '{http://nextcloud.com/ns}meta2' => 'value2',
+        ], $actual);
+    }
+
+    public function testGetPrincipalByPathNotFound(): void {
+        $actual = $this->principalBackend->getPrincipalByPath($this->principalPrefix . '/db-123');
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testGetPrincipalByPathWrongPrefix(): void {
+        $actual = $this->principalBackend->getPrincipalByPath('principals/users/foo-bar');
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testGetGroupMemberSet(): void {
+        $actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1');
+        $this->assertEquals([], $actual);
+    }
+
+    public function testGetGroupMemberSetProxyRead(): void {
+        $proxy1 = new Proxy();
+        $proxy1->setProxyId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setProxyId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $proxy3 = new Proxy();
+        $proxy3->setProxyId('proxyId3');
+        $proxy3->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with($this->principalPrefix . '/backend1-res1')
+            ->willReturn([$proxy1, $proxy2, $proxy3]);
+
+        $actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-read');
+        $this->assertEquals(['proxyId1'], $actual);
+    }
+
+    public function testGetGroupMemberSetProxyWrite(): void {
+        $proxy1 = new Proxy();
+        $proxy1->setProxyId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setProxyId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $proxy3 = new Proxy();
+        $proxy3->setProxyId('proxyId3');
+        $proxy3->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with($this->principalPrefix . '/backend1-res1')
+            ->willReturn([$proxy1, $proxy2, $proxy3]);
+
+        $actual = $this->principalBackend->getGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-write');
+        $this->assertEquals(['proxyId2', 'proxyId3'], $actual);
+    }
+
+    public function testGetGroupMembership(): void {
+        $proxy1 = new Proxy();
+        $proxy1->setOwnerId('proxyId1');
+        $proxy1->setPermissions(1);
+
+        $proxy2 = new Proxy();
+        $proxy2->setOwnerId('proxyId2');
+        $proxy2->setPermissions(3);
+
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesFor')
+            ->with($this->principalPrefix . '/backend1-res1')
+            ->willReturn([$proxy1, $proxy2]);
+
+        $actual = $this->principalBackend->getGroupMembership($this->principalPrefix . '/backend1-res1');
+
+        $this->assertEquals(['proxyId1/calendar-proxy-read', 'proxyId2/calendar-proxy-write'], $actual);
+    }
+
+    public function testSetGroupMemberSet(): void {
+        $this->proxyMapper->expects($this->once())
+            ->method('getProxiesOf')
+            ->with($this->principalPrefix . '/backend1-res1')
+            ->willReturn([]);
+
+        $calls = [
+            function ($proxy) {
+                /** @var Proxy $proxy */
+                if ($proxy->getOwnerId() !== $this->principalPrefix . '/backend1-res1') {
+                    return false;
+                }
+                if ($proxy->getProxyId() !== $this->principalPrefix . '/backend1-res2') {
+                    return false;
+                }
+                if ($proxy->getPermissions() !== 3) {
+                    return false;
+                }
+
+                return true;
+            },
+            function ($proxy) {
+                /** @var Proxy $proxy */
+                if ($proxy->getOwnerId() !== $this->principalPrefix . '/backend1-res1') {
+                    return false;
+                }
+                if ($proxy->getProxyId() !== $this->principalPrefix . '/backend2-res3') {
+                    return false;
+                }
+                if ($proxy->getPermissions() !== 3) {
+                    return false;
+                }
+
+                return true;
+            }
+        ];
+        $this->proxyMapper->expects($this->exactly(2))
+            ->method('insert')
+            ->willReturnCallback(function ($proxy) use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertTrue($expected($proxy));
+                return $proxy;
+            });
+
+        $this->principalBackend->setGroupMemberSet($this->principalPrefix . '/backend1-res1/calendar-proxy-write', [$this->principalPrefix . '/backend1-res2', $this->principalPrefix . '/backend2-res3']);
+    }
+
+    public function testUpdatePrincipal(): void {
+        $propPatch = $this->createMock(PropPatch::class);
+        $actual = $this->principalBackend->updatePrincipal($this->principalPrefix . '/foo-bar', $propPatch);
+
+        $this->assertEquals(0, $actual);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSearchPrincipals')]
+    public function testSearchPrincipals($expected, $test): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
+            '{http://sabredav.org/ns}email-address' => 'foo',
+            '{DAV:}displayname' => 'Beamer',
+        ], $test);
+
+        $this->assertEquals(
+            str_replace('%prefix%', $this->principalPrefix, $expected),
+            $actual);
+    }
+
+    public static function dataSearchPrincipals(): array {
+        // data providers are called before we subclass
+        // this class, $this->principalPrefix is null
+        // at that point, so we need this hack
+        return [
+            [[
+                '%prefix%/backend1-res1',
+                '%prefix%/backend2-res3',
+            ], 'allof'],
+            [[
+                '%prefix%/backend1-res1',
+                '%prefix%/backend1-res2',
+                '%prefix%/backend2-res3',
+                '%prefix%/backend2-res4',
+                '%prefix%/backend3-res6',
+            ], 'anyof'],
+        ];
+    }
+
+    public function testSearchPrincipalsByMetadataKey(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
+            '{http://nextcloud.com/ns}meta3' => 'value',
+        ]);
+
+        $this->assertEquals([
+            $this->principalPrefix . '/backend2-res4',
+        ], $actual);
+    }
+
+    public function testSearchPrincipalsByCalendarUserAddressSet(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->searchPrincipals($this->principalPrefix, [
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-address-set' => 'res2@foo.bar',
+        ]);
+
+        $this->assertEquals(
+            str_replace('%prefix%', $this->principalPrefix, [
+                '%prefix%/backend1-res2',
+            ]),
+            $actual);
+    }
+
+    public function testSearchPrincipalsEmptySearchProperties(): void {
+        $this->userSession->expects($this->never())
+            ->method('getUser');
+        $this->groupManager->expects($this->never())
+            ->method('getUserGroupIds');
+
+        $this->principalBackend->searchPrincipals($this->principalPrefix, []);
+    }
+
+    public function testSearchPrincipalsWrongPrincipalPrefix(): void {
+        $this->userSession->expects($this->never())
+            ->method('getUser');
+        $this->groupManager->expects($this->never())
+            ->method('getUserGroupIds');
+
+        $this->principalBackend->searchPrincipals('principals/users', [
+            '{http://sabredav.org/ns}email-address' => 'foo'
+        ]);
+    }
+
+    public function testFindByUriByEmail(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('mailto:res1@foo.bar', $this->principalPrefix);
+        $this->assertEquals($this->principalPrefix . '/backend1-res1', $actual);
+    }
+
+    public function testFindByUriByEmailForbiddenResource(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('mailto:res5@foo.bar', $this->principalPrefix);
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testFindByUriByEmailNotFound(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('mailto:res99@foo.bar', $this->principalPrefix);
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testFindByUriByPrincipal(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('mailto:res6@foo.bar', $this->principalPrefix);
+        $this->assertEquals($this->principalPrefix . '/backend3-res6', $actual);
+    }
+
+    public function testFindByUriByPrincipalForbiddenResource(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('principal:' . $this->principalPrefix . '/backend3-res5', $this->principalPrefix);
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testFindByUriByPrincipalNotFound(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('principal:' . $this->principalPrefix . '/db-123', $this->principalPrefix);
+        $this->assertEquals(null, $actual);
+    }
+
+    public function testFindByUriByUnknownUri(): void {
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->with()
+            ->willReturn($user);
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn(['group1', 'group2']);
+
+        $actual = $this->principalBackend->findByUri('foobar:blub', $this->principalPrefix);
+        $this->assertEquals(null, $actual);
+    }
+
+    protected function createTestDatasetInDb() {
+        $query = self::$realDatabase->getQueryBuilder();
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend1'),
+                'resource_id' => $query->createNamedParameter('res1'),
+                'email' => $query->createNamedParameter('res1@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer1'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->execute();
+
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend1'),
+                'resource_id' => $query->createNamedParameter('res2'),
+                'email' => $query->createNamedParameter('res2@foo.bar'),
+                'displayname' => $query->createNamedParameter('TV1'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->execute();
+
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend2'),
+                'resource_id' => $query->createNamedParameter('res3'),
+                'email' => $query->createNamedParameter('res3@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer2'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->execute();
+        $id3 = $query->getLastInsertId();
+
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend2'),
+                'resource_id' => $query->createNamedParameter('res4'),
+                'email' => $query->createNamedParameter('res4@foo.bar'),
+                'displayname' => $query->createNamedParameter('TV2'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->execute();
+        $id4 = $query->getLastInsertId();
+
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend3'),
+                'resource_id' => $query->createNamedParameter('res5'),
+                'email' => $query->createNamedParameter('res5@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer3'),
+                'group_restrictions' => $query->createNamedParameter('["foo", "bar"]'),
+            ])
+            ->execute();
+
+        $query->insert($this->mainDbTable)
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend3'),
+                'resource_id' => $query->createNamedParameter('res6'),
+                'email' => $query->createNamedParameter('res6@foo.bar'),
+                'displayname' => $query->createNamedParameter('Pointer'),
+                'group_restrictions' => $query->createNamedParameter('["group1", "bar"]'),
+            ])
+            ->execute();
+        $id6 = $query->getLastInsertId();
+
+        $query->insert($this->metadataDbTable)
+            ->values([
+                $this->foreignKey => $query->createNamedParameter($id3),
+                'key' => $query->createNamedParameter('{http://nextcloud.com/ns}foo'),
+                'value' => $query->createNamedParameter('value1')
+            ])
+            ->execute();
+        $query->insert($this->metadataDbTable)
+            ->values([
+                $this->foreignKey => $query->createNamedParameter($id3),
+                'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta2'),
+                'value' => $query->createNamedParameter('value2')
+            ])
+            ->execute();
+        $query->insert($this->metadataDbTable)
+            ->values([
+                $this->foreignKey => $query->createNamedParameter($id4),
+                'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta1'),
+                'value' => $query->createNamedParameter('value1')
+            ])
+            ->execute();
+        $query->insert($this->metadataDbTable)
+            ->values([
+                $this->foreignKey => $query->createNamedParameter($id4),
+                'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta3'),
+                'value' => $query->createNamedParameter('value3-old')
+            ])
+            ->execute();
+        $query->insert($this->metadataDbTable)
+            ->values([
+                $this->foreignKey => $query->createNamedParameter($id6),
+                'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta99'),
+                'value' => $query->createNamedParameter('value99')
+            ])
+            ->execute();
+    }
 }