nextcloud / server

apps/dav/tests/unit/Comments/EntityCollectionTest.php

Indentation +99 added lines, -99 removed lines

@@ -19,103 +19,103 @@
 use Psr\Log\LoggerInterface;
 
 class EntityCollectionTest extends \Test\TestCase {
-	protected ICommentsManager&MockObject $commentsManager;
-	protected IUserManager&MockObject $userManager;
-	protected LoggerInterface&MockObject $logger;
-	protected IUserSession&MockObject $userSession;
-	protected EntityCollection $collection;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->commentsManager = $this->createMock(ICommentsManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->collection = new EntityCollection(
-			'19',
-			'files',
-			$this->commentsManager,
-			$this->userManager,
-			$this->userSession,
-			$this->logger
-		);
-	}
-
-	public function testGetId(): void {
-		$this->assertSame($this->collection->getId(), '19');
-	}
-
-	public function testGetChild(): void {
-		$this->commentsManager->expects($this->once())
-			->method('get')
-			->with('55')
-			->willReturn(
-				$this->getMockBuilder(IComment::class)
-					->disableOriginalConstructor()
-					->getMock()
-			);
-
-		$node = $this->collection->getChild('55');
-		$this->assertInstanceOf(CommentNode::class, $node);
-	}
-
-
-	public function testGetChildException(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-
-		$this->commentsManager->expects($this->once())
-			->method('get')
-			->with('55')
-			->willThrowException(new NotFoundException());
-
-		$this->collection->getChild('55');
-	}
-
-	public function testGetChildren(): void {
-		$this->commentsManager->expects($this->once())
-			->method('getForObject')
-			->with('files', '19')
-			->willReturn([
-				$this->getMockBuilder(IComment::class)
-					->disableOriginalConstructor()
-					->getMock()
-			]);
-
-		$result = $this->collection->getChildren();
-
-		$this->assertCount(1, $result);
-		$this->assertInstanceOf(CommentNode::class, $result[0]);
-	}
-
-	public function testFindChildren(): void {
-		$dt = new \DateTime('2016-01-10 18:48:00');
-		$this->commentsManager->expects($this->once())
-			->method('getForObject')
-			->with('files', '19', 5, 15, $dt)
-			->willReturn([
-				$this->getMockBuilder(IComment::class)
-					->disableOriginalConstructor()
-					->getMock()
-			]);
-
-		$result = $this->collection->findChildren(5, 15, $dt);
-
-		$this->assertCount(1, $result);
-		$this->assertInstanceOf(CommentNode::class, $result[0]);
-	}
-
-	public function testChildExistsTrue(): void {
-		$this->assertTrue($this->collection->childExists('44'));
-	}
-
-	public function testChildExistsFalse(): void {
-		$this->commentsManager->expects($this->once())
-			->method('get')
-			->with('44')
-			->willThrowException(new NotFoundException());
-
-		$this->assertFalse($this->collection->childExists('44'));
-	}
+    protected ICommentsManager&MockObject $commentsManager;
+    protected IUserManager&MockObject $userManager;
+    protected LoggerInterface&MockObject $logger;
+    protected IUserSession&MockObject $userSession;
+    protected EntityCollection $collection;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->commentsManager = $this->createMock(ICommentsManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->collection = new EntityCollection(
+            '19',
+            'files',
+            $this->commentsManager,
+            $this->userManager,
+            $this->userSession,
+            $this->logger
+        );
+    }
+
+    public function testGetId(): void {
+        $this->assertSame($this->collection->getId(), '19');
+    }
+
+    public function testGetChild(): void {
+        $this->commentsManager->expects($this->once())
+            ->method('get')
+            ->with('55')
+            ->willReturn(
+                $this->getMockBuilder(IComment::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            );
+
+        $node = $this->collection->getChild('55');
+        $this->assertInstanceOf(CommentNode::class, $node);
+    }
+
+
+    public function testGetChildException(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+
+        $this->commentsManager->expects($this->once())
+            ->method('get')
+            ->with('55')
+            ->willThrowException(new NotFoundException());
+
+        $this->collection->getChild('55');
+    }
+
+    public function testGetChildren(): void {
+        $this->commentsManager->expects($this->once())
+            ->method('getForObject')
+            ->with('files', '19')
+            ->willReturn([
+                $this->getMockBuilder(IComment::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            ]);
+
+        $result = $this->collection->getChildren();
+
+        $this->assertCount(1, $result);
+        $this->assertInstanceOf(CommentNode::class, $result[0]);
+    }
+
+    public function testFindChildren(): void {
+        $dt = new \DateTime('2016-01-10 18:48:00');
+        $this->commentsManager->expects($this->once())
+            ->method('getForObject')
+            ->with('files', '19', 5, 15, $dt)
+            ->willReturn([
+                $this->getMockBuilder(IComment::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            ]);
+
+        $result = $this->collection->findChildren(5, 15, $dt);
+
+        $this->assertCount(1, $result);
+        $this->assertInstanceOf(CommentNode::class, $result[0]);
+    }
+
+    public function testChildExistsTrue(): void {
+        $this->assertTrue($this->collection->childExists('44'));
+    }
+
+    public function testChildExistsFalse(): void {
+        $this->commentsManager->expects($this->once())
+            ->method('get')
+            ->with('44')
+            ->willThrowException(new NotFoundException());
+
+        $this->assertFalse($this->collection->childExists('44'));
+    }
 }

apps/dav/tests/unit/Service/ExampleContactServiceTest.php

Indentation +167 added lines, -167 removed lines

@@ -24,171 +24,171 @@
 use Test\TestCase;
 
 class ExampleContactServiceTest extends TestCase {
-	protected ExampleContactService $service;
-	protected CardDavBackend&MockObject $cardDav;
-	protected IAppManager&MockObject $appManager;
-	protected IAppDataFactory&MockObject $appDataFactory;
-	protected LoggerInterface&MockObject $logger;
-	protected IAppConfig&MockObject $appConfig;
-	protected IAppData&MockObject $appData;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->cardDav = $this->createMock(CardDavBackend::class);
-		$this->appDataFactory = $this->createMock(IAppDataFactory::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
-
-		$this->appData = $this->createMock(IAppData::class);
-		$this->appDataFactory->method('get')
-			->with('dav')
-			->willReturn($this->appData);
-
-		$this->service = new ExampleContactService(
-			$this->appDataFactory,
-			$this->appConfig,
-			$this->logger,
-			$this->cardDav,
-		);
-	}
-
-	public function testCreateDefaultContactWithInvalidCard(): void {
-		// Invalid vCard missing required FN property
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nEND:VCARD";
-		$this->appConfig->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn(true);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$this->appData->method('getFolder')->willReturn($folder);
-
-		$this->logger->expects($this->once())
-			->method('error')
-			->with('Default contact is invalid', $this->anything());
-
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
-
-	public function testUidAndRevAreUpdated(): void {
-		$originalUid = 'original-uid';
-		$originalRev = '20200101T000000Z';
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nUID:$originalUid\nREV:$originalRev\nEND:VCARD";
-
-		$this->appConfig->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn(true);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$this->appData->method('getFolder')->willReturn($folder);
-
-		$capturedCardData = null;
-		$this->cardDav->expects($this->once())
-			->method('createCard')
-			->with(
-				$this->anything(),
-				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
-					$capturedCardData = $cardData;
-					return true;
-				}),
-				$this->anything()
-			)->willReturn(null);
-
-		$this->service->createDefaultContact(123);
-
-		$vcard = \Sabre\VObject\Reader::read($capturedCardData);
-		$this->assertNotEquals($originalUid, $vcard->UID->getValue());
-		$this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
-		$this->assertNotEquals($originalRev, $vcard->REV->getValue());
-	}
-
-	public function testDefaultContactFileDoesNotExist(): void {
-		$this->appConfig->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn(true);
-		$this->appData->method('getFolder')->willThrowException(new NotFoundException());
-
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
-
-	public function testUidAndRevAreAddedIfMissing(): void {
-		$vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nEND:VCARD";
-
-		$this->appConfig->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn(true);
-		$folder = $this->createMock(ISimpleFolder::class);
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getContent')->willReturn($vcardContent);
-		$folder->method('getFile')->willReturn($file);
-		$this->appData->method('getFolder')->willReturn($folder);
-
-		$capturedCardData = 'new-card-data';
-
-		$this->cardDav
-			->expects($this->once())
-			->method('createCard')
-			->with(
-				$this->anything(),
-				$this->anything(),
-				$this->callback(function ($cardData) use (&$capturedCardData) {
-					$capturedCardData = $cardData;
-					return true;
-				}),
-				$this->anything()
-			);
-
-		$this->service->createDefaultContact(123);
-		$vcard = \Sabre\VObject\Reader::read($capturedCardData);
-
-		$this->assertNotNull($vcard->REV);
-		$this->assertNotNull($vcard->UID);
-		$this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
-	}
-
-	public function testDefaultContactIsNotCreatedIfEnabled(): void {
-		$this->appConfig->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn(false);
-		$this->logger->expects($this->never())
-			->method('error');
-		$this->cardDav->expects($this->never())
-			->method('createCard');
-
-		$this->service->createDefaultContact(123);
-	}
-
-	public static function provideDefaultContactEnableData(): array {
-		return [[true], [false]];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideDefaultContactEnableData')]
-	public function testIsDefaultContactEnabled(bool $enabled): void {
-		$this->appConfig->expects(self::once())
-			->method('getAppValueBool')
-			->with('enableDefaultContact', true)
-			->willReturn($enabled);
-
-		$this->assertEquals($enabled, $this->service->isDefaultContactEnabled());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideDefaultContactEnableData')]
-	public function testSetDefaultContactEnabled(bool $enabled): void {
-		$this->appConfig->expects(self::once())
-			->method('setAppValueBool')
-			->with('enableDefaultContact', $enabled);
-
-		$this->service->setDefaultContactEnabled($enabled);
-	}
+    protected ExampleContactService $service;
+    protected CardDavBackend&MockObject $cardDav;
+    protected IAppManager&MockObject $appManager;
+    protected IAppDataFactory&MockObject $appDataFactory;
+    protected LoggerInterface&MockObject $logger;
+    protected IAppConfig&MockObject $appConfig;
+    protected IAppData&MockObject $appData;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->cardDav = $this->createMock(CardDavBackend::class);
+        $this->appDataFactory = $this->createMock(IAppDataFactory::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+
+        $this->appData = $this->createMock(IAppData::class);
+        $this->appDataFactory->method('get')
+            ->with('dav')
+            ->willReturn($this->appData);
+
+        $this->service = new ExampleContactService(
+            $this->appDataFactory,
+            $this->appConfig,
+            $this->logger,
+            $this->cardDav,
+        );
+    }
+
+    public function testCreateDefaultContactWithInvalidCard(): void {
+        // Invalid vCard missing required FN property
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nEND:VCARD";
+        $this->appConfig->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn(true);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $this->appData->method('getFolder')->willReturn($folder);
+
+        $this->logger->expects($this->once())
+            ->method('error')
+            ->with('Default contact is invalid', $this->anything());
+
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
+
+    public function testUidAndRevAreUpdated(): void {
+        $originalUid = 'original-uid';
+        $originalRev = '20200101T000000Z';
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nUID:$originalUid\nREV:$originalRev\nEND:VCARD";
+
+        $this->appConfig->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn(true);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $this->appData->method('getFolder')->willReturn($folder);
+
+        $capturedCardData = null;
+        $this->cardDav->expects($this->once())
+            ->method('createCard')
+            ->with(
+                $this->anything(),
+                $this->anything(),
+                $this->callback(function ($cardData) use (&$capturedCardData) {
+                    $capturedCardData = $cardData;
+                    return true;
+                }),
+                $this->anything()
+            )->willReturn(null);
+
+        $this->service->createDefaultContact(123);
+
+        $vcard = \Sabre\VObject\Reader::read($capturedCardData);
+        $this->assertNotEquals($originalUid, $vcard->UID->getValue());
+        $this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
+        $this->assertNotEquals($originalRev, $vcard->REV->getValue());
+    }
+
+    public function testDefaultContactFileDoesNotExist(): void {
+        $this->appConfig->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn(true);
+        $this->appData->method('getFolder')->willThrowException(new NotFoundException());
+
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
+
+    public function testUidAndRevAreAddedIfMissing(): void {
+        $vcardContent = "BEGIN:VCARD\nVERSION:3.0\nFN:Test User\nEND:VCARD";
+
+        $this->appConfig->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn(true);
+        $folder = $this->createMock(ISimpleFolder::class);
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getContent')->willReturn($vcardContent);
+        $folder->method('getFile')->willReturn($file);
+        $this->appData->method('getFolder')->willReturn($folder);
+
+        $capturedCardData = 'new-card-data';
+
+        $this->cardDav
+            ->expects($this->once())
+            ->method('createCard')
+            ->with(
+                $this->anything(),
+                $this->anything(),
+                $this->callback(function ($cardData) use (&$capturedCardData) {
+                    $capturedCardData = $cardData;
+                    return true;
+                }),
+                $this->anything()
+            );
+
+        $this->service->createDefaultContact(123);
+        $vcard = \Sabre\VObject\Reader::read($capturedCardData);
+
+        $this->assertNotNull($vcard->REV);
+        $this->assertNotNull($vcard->UID);
+        $this->assertTrue(Uuid::isValid($vcard->UID->getValue()));
+    }
+
+    public function testDefaultContactIsNotCreatedIfEnabled(): void {
+        $this->appConfig->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn(false);
+        $this->logger->expects($this->never())
+            ->method('error');
+        $this->cardDav->expects($this->never())
+            ->method('createCard');
+
+        $this->service->createDefaultContact(123);
+    }
+
+    public static function provideDefaultContactEnableData(): array {
+        return [[true], [false]];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideDefaultContactEnableData')]
+    public function testIsDefaultContactEnabled(bool $enabled): void {
+        $this->appConfig->expects(self::once())
+            ->method('getAppValueBool')
+            ->with('enableDefaultContact', true)
+            ->willReturn($enabled);
+
+        $this->assertEquals($enabled, $this->service->isDefaultContactEnabled());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideDefaultContactEnableData')]
+    public function testSetDefaultContactEnabled(bool $enabled): void {
+        $this->appConfig->expects(self::once())
+            ->method('setAppValueBool')
+            ->with('enableDefaultContact', $enabled);
+
+        $this->service->setDefaultContactEnabled($enabled);
+    }
 }

apps/dav/tests/unit/Service/ExampleEventServiceTest.php

Indentation +170 added lines, -170 removed lines

@@ -23,174 +23,174 @@
 use Test\TestCase;
 
 class ExampleEventServiceTest extends TestCase {
-	private ExampleEventService $service;
-
-	private CalDavBackend&MockObject $calDavBackend;
-	private ISecureRandom&MockObject $random;
-	private ITimeFactory&MockObject $time;
-	private IAppData&MockObject $appData;
-	private IAppConfig&MockObject $appConfig;
-	private IL10N&MockObject $l10n;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->calDavBackend = $this->createMock(CalDavBackend::class);
-		$this->random = $this->createMock(ISecureRandom::class);
-		$this->time = $this->createMock(ITimeFactory::class);
-		$this->appData = $this->createMock(IAppData::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
-		$this->l10n = $this->createMock(IL10N::class);
-
-		$this->l10n->method('t')
-			->willReturnArgument(0);
-
-		$this->service = new ExampleEventService(
-			$this->calDavBackend,
-			$this->random,
-			$this->time,
-			$this->appData,
-			$this->appConfig,
-			$this->l10n,
-		);
-	}
-
-	public static function provideCustomEventData(): array {
-		return [
-			[file_get_contents(__DIR__ . '/../test_fixtures/example-event.ics')],
-			[file_get_contents(__DIR__ . '/../test_fixtures/example-event-with-attendees.ics')],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideCustomEventData')]
-	public function testCreateExampleEventWithCustomEvent($customEventIcs): void {
-		$this->appConfig->expects(self::once())
-			->method('getValueBool')
-			->with('dav', 'create_example_event', true)
-			->willReturn(true);
-
-		$exampleEventFolder = $this->createMock(ISimpleFolder::class);
-		$this->appData->expects(self::once())
-			->method('getFolder')
-			->with('example_event')
-			->willReturn($exampleEventFolder);
-		$exampleEventFile = $this->createMock(ISimpleFile::class);
-		$exampleEventFolder->expects(self::once())
-			->method('getFile')
-			->with('example_event.ics')
-			->willReturn($exampleEventFile);
-		$exampleEventFile->expects(self::once())
-			->method('getContent')
-			->willReturn($customEventIcs);
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
-			->willReturn('RANDOM-UID');
-
-		$now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
-		$this->time->expects(self::exactly(2))
-			->method('now')
-			->willReturn($now);
-
-		$expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-expected.ics');
-		$this->calDavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->with(1000, 'RANDOM-UID.ics', $expectedIcs);
-
-		$this->service->createExampleEvent(1000);
-	}
-
-	public function testCreateExampleEventWithDefaultEvent(): void {
-		$this->appConfig->expects(self::once())
-			->method('getValueBool')
-			->with('dav', 'create_example_event', true)
-			->willReturn(true);
-
-		$this->appData->expects(self::once())
-			->method('getFolder')
-			->with('example_event')
-			->willThrowException(new NotFoundException());
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
-			->willReturn('RANDOM-UID');
-
-		$now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
-		$this->time->expects(self::exactly(3))
-			->method('now')
-			->willReturn($now);
-
-		$expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-default-expected.ics');
-		$this->calDavBackend->expects(self::once())
-			->method('createCalendarObject')
-			->with(1000, 'RANDOM-UID.ics', $expectedIcs);
-
-		$this->service->createExampleEvent(1000);
-	}
-
-	public function testCreateExampleWhenDisabled(): void {
-		$this->appConfig->expects(self::once())
-			->method('getValueBool')
-			->with('dav', 'create_example_event', true)
-			->willReturn(false);
-
-		$this->calDavBackend->expects(self::never())
-			->method('createCalendarObject');
-
-		$this->service->createExampleEvent(1000);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideCustomEventData')]
-	public function testGetExampleEventWithCustomEvent($customEventIcs): void {
-		$exampleEventFolder = $this->createMock(ISimpleFolder::class);
-		$this->appData->expects(self::once())
-			->method('getFolder')
-			->with('example_event')
-			->willReturn($exampleEventFolder);
-		$exampleEventFile = $this->createMock(ISimpleFile::class);
-		$exampleEventFolder->expects(self::once())
-			->method('getFile')
-			->with('example_event.ics')
-			->willReturn($exampleEventFile);
-		$exampleEventFile->expects(self::once())
-			->method('getContent')
-			->willReturn($customEventIcs);
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
-			->willReturn('RANDOM-UID');
-
-		$now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
-		$this->time->expects(self::exactly(2))
-			->method('now')
-			->willReturn($now);
-
-		$expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-expected.ics');
-		$actualIcs = $this->service->getExampleEvent()->getIcs();
-		$this->assertEquals($expectedIcs, $actualIcs);
-	}
-
-	public function testGetExampleEventWithDefault(): void {
-		$this->appData->expects(self::once())
-			->method('getFolder')
-			->with('example_event')
-			->willThrowException(new NotFoundException());
-
-		$this->random->expects(self::once())
-			->method('generate')
-			->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
-			->willReturn('RANDOM-UID');
-
-		$now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
-		$this->time->expects(self::exactly(3))
-			->method('now')
-			->willReturn($now);
-
-		$expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-default-expected.ics');
-		$actualIcs = $this->service->getExampleEvent()->getIcs();
-		$this->assertEquals($expectedIcs, $actualIcs);
-	}
+    private ExampleEventService $service;
+
+    private CalDavBackend&MockObject $calDavBackend;
+    private ISecureRandom&MockObject $random;
+    private ITimeFactory&MockObject $time;
+    private IAppData&MockObject $appData;
+    private IAppConfig&MockObject $appConfig;
+    private IL10N&MockObject $l10n;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->calDavBackend = $this->createMock(CalDavBackend::class);
+        $this->random = $this->createMock(ISecureRandom::class);
+        $this->time = $this->createMock(ITimeFactory::class);
+        $this->appData = $this->createMock(IAppData::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+        $this->l10n = $this->createMock(IL10N::class);
+
+        $this->l10n->method('t')
+            ->willReturnArgument(0);
+
+        $this->service = new ExampleEventService(
+            $this->calDavBackend,
+            $this->random,
+            $this->time,
+            $this->appData,
+            $this->appConfig,
+            $this->l10n,
+        );
+    }
+
+    public static function provideCustomEventData(): array {
+        return [
+            [file_get_contents(__DIR__ . '/../test_fixtures/example-event.ics')],
+            [file_get_contents(__DIR__ . '/../test_fixtures/example-event-with-attendees.ics')],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideCustomEventData')]
+    public function testCreateExampleEventWithCustomEvent($customEventIcs): void {
+        $this->appConfig->expects(self::once())
+            ->method('getValueBool')
+            ->with('dav', 'create_example_event', true)
+            ->willReturn(true);
+
+        $exampleEventFolder = $this->createMock(ISimpleFolder::class);
+        $this->appData->expects(self::once())
+            ->method('getFolder')
+            ->with('example_event')
+            ->willReturn($exampleEventFolder);
+        $exampleEventFile = $this->createMock(ISimpleFile::class);
+        $exampleEventFolder->expects(self::once())
+            ->method('getFile')
+            ->with('example_event.ics')
+            ->willReturn($exampleEventFile);
+        $exampleEventFile->expects(self::once())
+            ->method('getContent')
+            ->willReturn($customEventIcs);
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
+            ->willReturn('RANDOM-UID');
+
+        $now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
+        $this->time->expects(self::exactly(2))
+            ->method('now')
+            ->willReturn($now);
+
+        $expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-expected.ics');
+        $this->calDavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->with(1000, 'RANDOM-UID.ics', $expectedIcs);
+
+        $this->service->createExampleEvent(1000);
+    }
+
+    public function testCreateExampleEventWithDefaultEvent(): void {
+        $this->appConfig->expects(self::once())
+            ->method('getValueBool')
+            ->with('dav', 'create_example_event', true)
+            ->willReturn(true);
+
+        $this->appData->expects(self::once())
+            ->method('getFolder')
+            ->with('example_event')
+            ->willThrowException(new NotFoundException());
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
+            ->willReturn('RANDOM-UID');
+
+        $now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
+        $this->time->expects(self::exactly(3))
+            ->method('now')
+            ->willReturn($now);
+
+        $expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-default-expected.ics');
+        $this->calDavBackend->expects(self::once())
+            ->method('createCalendarObject')
+            ->with(1000, 'RANDOM-UID.ics', $expectedIcs);
+
+        $this->service->createExampleEvent(1000);
+    }
+
+    public function testCreateExampleWhenDisabled(): void {
+        $this->appConfig->expects(self::once())
+            ->method('getValueBool')
+            ->with('dav', 'create_example_event', true)
+            ->willReturn(false);
+
+        $this->calDavBackend->expects(self::never())
+            ->method('createCalendarObject');
+
+        $this->service->createExampleEvent(1000);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideCustomEventData')]
+    public function testGetExampleEventWithCustomEvent($customEventIcs): void {
+        $exampleEventFolder = $this->createMock(ISimpleFolder::class);
+        $this->appData->expects(self::once())
+            ->method('getFolder')
+            ->with('example_event')
+            ->willReturn($exampleEventFolder);
+        $exampleEventFile = $this->createMock(ISimpleFile::class);
+        $exampleEventFolder->expects(self::once())
+            ->method('getFile')
+            ->with('example_event.ics')
+            ->willReturn($exampleEventFile);
+        $exampleEventFile->expects(self::once())
+            ->method('getContent')
+            ->willReturn($customEventIcs);
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
+            ->willReturn('RANDOM-UID');
+
+        $now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
+        $this->time->expects(self::exactly(2))
+            ->method('now')
+            ->willReturn($now);
+
+        $expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-expected.ics');
+        $actualIcs = $this->service->getExampleEvent()->getIcs();
+        $this->assertEquals($expectedIcs, $actualIcs);
+    }
+
+    public function testGetExampleEventWithDefault(): void {
+        $this->appData->expects(self::once())
+            ->method('getFolder')
+            ->with('example_event')
+            ->willThrowException(new NotFoundException());
+
+        $this->random->expects(self::once())
+            ->method('generate')
+            ->with(32, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789')
+            ->willReturn('RANDOM-UID');
+
+        $now = new \DateTimeImmutable('2025-01-21T00:00:00Z');
+        $this->time->expects(self::exactly(3))
+            ->method('now')
+            ->willReturn($now);
+
+        $expectedIcs = file_get_contents(__DIR__ . '/../test_fixtures/example-event-default-expected.ics');
+        $actualIcs = $this->service->getExampleEvent()->getIcs();
+        $this->assertEquals($expectedIcs, $actualIcs);
+    }
 }

apps/dav/tests/unit/Avatars/AvatarHomeTest.php

Indentation +78 added lines, -78 removed lines

@@ -18,82 +18,82 @@
 use Test\TestCase;
 
 class AvatarHomeTest extends TestCase {
-	private AvatarHome $home;
-	private IAvatarManager&MockObject $avatarManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->avatarManager = $this->createMock(IAvatarManager::class);
-		$this->home = new AvatarHome(['uri' => 'principals/users/admin'], $this->avatarManager);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesForbiddenMethods')]
-	public function testForbiddenMethods($method): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$this->home->$method('');
-	}
-
-	public static function providesForbiddenMethods(): array {
-		return [
-			['createFile'],
-			['createDirectory'],
-			['delete'],
-			['setName']
-		];
-	}
-
-	public function testGetName(): void {
-		$n = $this->home->getName();
-		self::assertEquals('admin', $n);
-	}
-
-	public static function providesTestGetChild(): array {
-		return [
-			[MethodNotAllowed::class, false, ''],
-			[MethodNotAllowed::class, false, 'bla.foo'],
-			[MethodNotAllowed::class, false, 'bla.png'],
-			[NotFound::class, false, '512.png'],
-			[null, true, '512.png'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesTestGetChild')]
-	public function testGetChild(?string $expectedException, bool $hasAvatar, string $path): void {
-		if ($expectedException !== null) {
-			$this->expectException($expectedException);
-		}
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->method('exists')->willReturn($hasAvatar);
-
-		$this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
-		$avatarNode = $this->home->getChild($path);
-		$this->assertInstanceOf(AvatarNode::class, $avatarNode);
-	}
-
-	public function testGetChildren(): void {
-		$avatarNodes = $this->home->getChildren();
-		self::assertEquals(0, count($avatarNodes));
-
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->expects($this->once())->method('exists')->willReturn(true);
-		$this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
-		$avatarNodes = $this->home->getChildren();
-		self::assertEquals(1, count($avatarNodes));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesTestGetChild')]
-	public function testChildExists(?string $expectedException, bool $hasAvatar, string $path): void {
-		$avatar = $this->createMock(IAvatar::class);
-		$avatar->method('exists')->willReturn($hasAvatar);
-
-		$this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
-		$childExists = $this->home->childExists($path);
-		$this->assertEquals($hasAvatar, $childExists);
-	}
-
-	public function testGetLastModified(): void {
-		self::assertNull($this->home->getLastModified());
-	}
+    private AvatarHome $home;
+    private IAvatarManager&MockObject $avatarManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->avatarManager = $this->createMock(IAvatarManager::class);
+        $this->home = new AvatarHome(['uri' => 'principals/users/admin'], $this->avatarManager);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesForbiddenMethods')]
+    public function testForbiddenMethods($method): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $this->home->$method('');
+    }
+
+    public static function providesForbiddenMethods(): array {
+        return [
+            ['createFile'],
+            ['createDirectory'],
+            ['delete'],
+            ['setName']
+        ];
+    }
+
+    public function testGetName(): void {
+        $n = $this->home->getName();
+        self::assertEquals('admin', $n);
+    }
+
+    public static function providesTestGetChild(): array {
+        return [
+            [MethodNotAllowed::class, false, ''],
+            [MethodNotAllowed::class, false, 'bla.foo'],
+            [MethodNotAllowed::class, false, 'bla.png'],
+            [NotFound::class, false, '512.png'],
+            [null, true, '512.png'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesTestGetChild')]
+    public function testGetChild(?string $expectedException, bool $hasAvatar, string $path): void {
+        if ($expectedException !== null) {
+            $this->expectException($expectedException);
+        }
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->method('exists')->willReturn($hasAvatar);
+
+        $this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
+        $avatarNode = $this->home->getChild($path);
+        $this->assertInstanceOf(AvatarNode::class, $avatarNode);
+    }
+
+    public function testGetChildren(): void {
+        $avatarNodes = $this->home->getChildren();
+        self::assertEquals(0, count($avatarNodes));
+
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->expects($this->once())->method('exists')->willReturn(true);
+        $this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
+        $avatarNodes = $this->home->getChildren();
+        self::assertEquals(1, count($avatarNodes));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesTestGetChild')]
+    public function testChildExists(?string $expectedException, bool $hasAvatar, string $path): void {
+        $avatar = $this->createMock(IAvatar::class);
+        $avatar->method('exists')->willReturn($hasAvatar);
+
+        $this->avatarManager->expects($this->any())->method('getAvatar')->with('admin')->willReturn($avatar);
+        $childExists = $this->home->childExists($path);
+        $this->assertEquals($hasAvatar, $childExists);
+    }
+
+    public function testGetLastModified(): void {
+        self::assertNull($this->home->getLastModified());
+    }
 }

apps/dav/tests/unit/Migration/RefreshWebcalJobRegistrarTest.php

Indentation +98 added lines, -98 removed lines

@@ -18,102 +18,102 @@
 use Test\TestCase;
 
 class RefreshWebcalJobRegistrarTest extends TestCase {
-	private IDBConnection&MockObject $db;
-	private IJobList&MockObject $jobList;
-	private RefreshWebcalJobRegistrar $migration;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->db = $this->createMock(IDBConnection::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->migration = new RefreshWebcalJobRegistrar($this->db, $this->jobList);
-	}
-
-	public function testGetName(): void {
-		$this->assertEquals($this->migration->getName(), 'Registering background jobs to update cache for webcal calendars');
-	}
-
-	public function testRun(): void {
-		$output = $this->createMock(IOutput::class);
-
-		$queryBuilder = $this->createMock(IQueryBuilder::class);
-		$statement = $this->createMock(IResult::class);
-
-		$this->db->expects($this->once())
-			->method('getQueryBuilder')
-			->willReturn($queryBuilder);
-
-		$queryBuilder->expects($this->once())
-			->method('select')
-			->with(['principaluri', 'uri'])
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('from')
-			->with('calendarsubscriptions')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('execute')
-			->willReturn($statement);
-
-		$statement->expects($this->exactly(4))
-			->method('fetch')
-			->with(\PDO::FETCH_ASSOC)
-			->willReturnOnConsecutiveCalls(
-				[
-					'principaluri' => 'foo1',
-					'uri' => 'bar1',
-				],
-				[
-					'principaluri' => 'foo2',
-					'uri' => 'bar2',
-				],
-				[
-					'principaluri' => 'foo3',
-					'uri' => 'bar3',
-				],
-				null
-			);
-
-		$this->jobList->expects($this->exactly(3))
-			->method('has')
-			->willReturnMap([
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo1',
-					'uri' => 'bar1',
-				], false],
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo2',
-					'uri' => 'bar2',
-				], true ],
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo3',
-					'uri' => 'bar3',
-				], false],
-			]);
-
-		$calls = [
-			[RefreshWebcalJob::class, [
-				'principaluri' => 'foo1',
-				'uri' => 'bar1',
-			]],
-			[RefreshWebcalJob::class, [
-				'principaluri' => 'foo3',
-				'uri' => 'bar3',
-			]]
-		];
-		$this->jobList->expects($this->exactly(2))
-			->method('add')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		$output->expects($this->once())
-			->method('info')
-			->with('Added 2 background jobs to update webcal calendars');
-
-		$this->migration->run($output);
-	}
+    private IDBConnection&MockObject $db;
+    private IJobList&MockObject $jobList;
+    private RefreshWebcalJobRegistrar $migration;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->db = $this->createMock(IDBConnection::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->migration = new RefreshWebcalJobRegistrar($this->db, $this->jobList);
+    }
+
+    public function testGetName(): void {
+        $this->assertEquals($this->migration->getName(), 'Registering background jobs to update cache for webcal calendars');
+    }
+
+    public function testRun(): void {
+        $output = $this->createMock(IOutput::class);
+
+        $queryBuilder = $this->createMock(IQueryBuilder::class);
+        $statement = $this->createMock(IResult::class);
+
+        $this->db->expects($this->once())
+            ->method('getQueryBuilder')
+            ->willReturn($queryBuilder);
+
+        $queryBuilder->expects($this->once())
+            ->method('select')
+            ->with(['principaluri', 'uri'])
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('from')
+            ->with('calendarsubscriptions')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('execute')
+            ->willReturn($statement);
+
+        $statement->expects($this->exactly(4))
+            ->method('fetch')
+            ->with(\PDO::FETCH_ASSOC)
+            ->willReturnOnConsecutiveCalls(
+                [
+                    'principaluri' => 'foo1',
+                    'uri' => 'bar1',
+                ],
+                [
+                    'principaluri' => 'foo2',
+                    'uri' => 'bar2',
+                ],
+                [
+                    'principaluri' => 'foo3',
+                    'uri' => 'bar3',
+                ],
+                null
+            );
+
+        $this->jobList->expects($this->exactly(3))
+            ->method('has')
+            ->willReturnMap([
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo1',
+                    'uri' => 'bar1',
+                ], false],
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo2',
+                    'uri' => 'bar2',
+                ], true ],
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo3',
+                    'uri' => 'bar3',
+                ], false],
+            ]);
+
+        $calls = [
+            [RefreshWebcalJob::class, [
+                'principaluri' => 'foo1',
+                'uri' => 'bar1',
+            ]],
+            [RefreshWebcalJob::class, [
+                'principaluri' => 'foo3',
+                'uri' => 'bar3',
+            ]]
+        ];
+        $this->jobList->expects($this->exactly(2))
+            ->method('add')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        $output->expects($this->once())
+            ->method('info')
+            ->with('Added 2 background jobs to update webcal calendars');
+
+        $this->migration->run($output);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
 				[RefreshWebcalJob::class, [
 					'principaluri' => 'foo2',
 					'uri' => 'bar2',
-				], true ],
+				], true],
 				[RefreshWebcalJob::class, [
 					'principaluri' => 'foo3',
 					'uri' => 'bar3',
@@ -105,7 +105,7 @@ 
 		];
 		$this->jobList->expects($this->exactly(2))
 			->method('add')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/Migration/RemoveDeletedUsersCalendarSubscriptionsTest.php

Indentation +113 added lines, -113 removed lines

@@ -22,119 +22,119 @@
 use Test\TestCase;
 
 class RemoveDeletedUsersCalendarSubscriptionsTest extends TestCase {
-	private IDBConnection&MockObject $dbConnection;
-	private IUserManager&MockObject $userManager;
-	private IOutput&MockObject $output;
-	private RemoveDeletedUsersCalendarSubscriptions $migration;
+    private IDBConnection&MockObject $dbConnection;
+    private IUserManager&MockObject $userManager;
+    private IOutput&MockObject $output;
+    private RemoveDeletedUsersCalendarSubscriptions $migration;
 
 
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->output = $this->createMock(IOutput::class);
-
-		$this->migration = new RemoveDeletedUsersCalendarSubscriptions($this->dbConnection, $this->userManager);
-	}
-
-	public function testGetName(): void {
-		$this->assertEquals(
-			'Clean up old calendar subscriptions from deleted users that were not cleaned-up',
-			$this->migration->getName()
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
-	public function testRun(array $subscriptions, array $userExists, int $deletions): void {
-		$qb = $this->createMock(IQueryBuilder::class);
-
-		$qb->method('select')->willReturn($qb);
-
-		$functionBuilder = $this->createMock(IFunctionBuilder::class);
-
-		$qb->method('func')->willReturn($functionBuilder);
-		$functionBuilder->method('count')->willReturn($this->createMock(IQueryFunction::class));
-
-		$qb->method('selectDistinct')
-			->with(['id', 'principaluri'])
-			->willReturn($qb);
-
-		$qb->method('from')
-			->with('calendarsubscriptions')
-			->willReturn($qb);
-
-		$qb->method('setMaxResults')
-			->willReturn($qb);
-
-		$qb->method('setFirstResult')
-			->willReturn($qb);
-
-		$result = $this->createMock(IResult::class);
-
-		$qb->method('execute')
-			->willReturn($result);
-
-		$result->expects($this->once())
-			->method('fetchOne')
-			->willReturn(count($subscriptions));
-
-		$result
-			->method('fetch')
-			->willReturnOnConsecutiveCalls(...$subscriptions);
-
-		$qb->method('delete')
-			->with('calendarsubscriptions')
-			->willReturn($qb);
-
-		$expr = $this->createMock(IExpressionBuilder::class);
-
-		$qb->method('expr')->willReturn($expr);
-		$qb->method('createNamedParameter')->willReturn($this->createMock(IParameter::class));
-		$qb->method('where')->willReturn($qb);
-		// Only when user exists
-		$qb->expects($this->exactly($deletions))->method('executeStatement');
-
-		$this->dbConnection->method('getQueryBuilder')->willReturn($qb);
-
-
-		$this->output->expects($this->once())->method('startProgress');
-
-		$this->output->expects($subscriptions === [] ? $this->never(): $this->once())->method('advance');
-		if (count($subscriptions)) {
-			$this->userManager->method('userExists')
-				->willReturnCallback(function (string $username) use ($userExists) {
-					return $userExists[$username];
-				});
-		}
-		$this->output->expects($this->once())->method('finishProgress');
-		$this->output->expects($this->once())->method('info')->with(sprintf('%d calendar subscriptions without an user have been cleaned up', $deletions));
-
-		$this->migration->run($this->output);
-	}
-
-	public static function dataTestRun(): array {
-		return [
-			[[], [], 0],
-			[
-				[
-					[
-						'id' => 1,
-						'principaluri' => 'users/principals/foo1',
-					],
-					[
-						'id' => 2,
-						'principaluri' => 'users/principals/bar1',
-					],
-					[
-						'id' => 3,
-						'principaluri' => 'users/principals/bar1',
-					],
-					[],
-				],
-				['foo1' => true, 'bar1' => false],
-				2
-			],
-		];
-	}
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->output = $this->createMock(IOutput::class);
+
+        $this->migration = new RemoveDeletedUsersCalendarSubscriptions($this->dbConnection, $this->userManager);
+    }
+
+    public function testGetName(): void {
+        $this->assertEquals(
+            'Clean up old calendar subscriptions from deleted users that were not cleaned-up',
+            $this->migration->getName()
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
+    public function testRun(array $subscriptions, array $userExists, int $deletions): void {
+        $qb = $this->createMock(IQueryBuilder::class);
+
+        $qb->method('select')->willReturn($qb);
+
+        $functionBuilder = $this->createMock(IFunctionBuilder::class);
+
+        $qb->method('func')->willReturn($functionBuilder);
+        $functionBuilder->method('count')->willReturn($this->createMock(IQueryFunction::class));
+
+        $qb->method('selectDistinct')
+            ->with(['id', 'principaluri'])
+            ->willReturn($qb);
+
+        $qb->method('from')
+            ->with('calendarsubscriptions')
+            ->willReturn($qb);
+
+        $qb->method('setMaxResults')
+            ->willReturn($qb);
+
+        $qb->method('setFirstResult')
+            ->willReturn($qb);
+
+        $result = $this->createMock(IResult::class);
+
+        $qb->method('execute')
+            ->willReturn($result);
+
+        $result->expects($this->once())
+            ->method('fetchOne')
+            ->willReturn(count($subscriptions));
+
+        $result
+            ->method('fetch')
+            ->willReturnOnConsecutiveCalls(...$subscriptions);
+
+        $qb->method('delete')
+            ->with('calendarsubscriptions')
+            ->willReturn($qb);
+
+        $expr = $this->createMock(IExpressionBuilder::class);
+
+        $qb->method('expr')->willReturn($expr);
+        $qb->method('createNamedParameter')->willReturn($this->createMock(IParameter::class));
+        $qb->method('where')->willReturn($qb);
+        // Only when user exists
+        $qb->expects($this->exactly($deletions))->method('executeStatement');
+
+        $this->dbConnection->method('getQueryBuilder')->willReturn($qb);
+
+
+        $this->output->expects($this->once())->method('startProgress');
+
+        $this->output->expects($subscriptions === [] ? $this->never(): $this->once())->method('advance');
+        if (count($subscriptions)) {
+            $this->userManager->method('userExists')
+                ->willReturnCallback(function (string $username) use ($userExists) {
+                    return $userExists[$username];
+                });
+        }
+        $this->output->expects($this->once())->method('finishProgress');
+        $this->output->expects($this->once())->method('info')->with(sprintf('%d calendar subscriptions without an user have been cleaned up', $deletions));
+
+        $this->migration->run($this->output);
+    }
+
+    public static function dataTestRun(): array {
+        return [
+            [[], [], 0],
+            [
+                [
+                    [
+                        'id' => 1,
+                        'principaluri' => 'users/principals/foo1',
+                    ],
+                    [
+                        'id' => 2,
+                        'principaluri' => 'users/principals/bar1',
+                    ],
+                    [
+                        'id' => 3,
+                        'principaluri' => 'users/principals/bar1',
+                    ],
+                    [],
+                ],
+                ['foo1' => true, 'bar1' => false],
+                2
+            ],
+        ];
+    }
 }

apps/dav/tests/unit/Listener/ActivityUpdaterListenerTest.php

Indentation +50 added lines, -50 removed lines

@@ -20,61 +20,61 @@
 
 class ActivityUpdaterListenerTest extends TestCase {
 
-	private ActivityBackend&MockObject $activityBackend;
-	private LoggerInterface&MockObject $logger;
-	private ActivityUpdaterListener $listener;
+    private ActivityBackend&MockObject $activityBackend;
+    private LoggerInterface&MockObject $logger;
+    private ActivityUpdaterListener $listener;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->activityBackend = $this->createMock(ActivityBackend::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
+        $this->activityBackend = $this->createMock(ActivityBackend::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
 
-		$this->listener = new ActivityUpdaterListener(
-			$this->activityBackend,
-			$this->logger
-		);
-	}
+        $this->listener = new ActivityUpdaterListener(
+            $this->activityBackend,
+            $this->logger
+        );
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataForTestHandleCalendarObjectDeletedEvent')]
-	public function testHandleCalendarObjectDeletedEvent(int $calendarId, array $calendarData, array $shares, array $objectData, bool $createsActivity): void {
-		$event = new CalendarObjectDeletedEvent($calendarId, $calendarData, $shares, $objectData);
-		$this->logger->expects($this->once())->method('debug')->with(
-			$createsActivity ? "Activity generated for deleted calendar object in calendar $calendarId" : "Calendar object in calendar $calendarId was already in trashbin, skipping deletion activity"
-		);
-		$this->activityBackend->expects($createsActivity ? $this->once() : $this->never())->method('onTouchCalendarObject')->with(
-			Event::SUBJECT_OBJECT_DELETE,
-			$calendarData,
-			$shares,
-			$objectData
-		);
-		$this->listener->handle($event);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataForTestHandleCalendarObjectDeletedEvent')]
+    public function testHandleCalendarObjectDeletedEvent(int $calendarId, array $calendarData, array $shares, array $objectData, bool $createsActivity): void {
+        $event = new CalendarObjectDeletedEvent($calendarId, $calendarData, $shares, $objectData);
+        $this->logger->expects($this->once())->method('debug')->with(
+            $createsActivity ? "Activity generated for deleted calendar object in calendar $calendarId" : "Calendar object in calendar $calendarId was already in trashbin, skipping deletion activity"
+        );
+        $this->activityBackend->expects($createsActivity ? $this->once() : $this->never())->method('onTouchCalendarObject')->with(
+            Event::SUBJECT_OBJECT_DELETE,
+            $calendarData,
+            $shares,
+            $objectData
+        );
+        $this->listener->handle($event);
+    }
 
-	public static function dataForTestHandleCalendarObjectDeletedEvent(): array {
-		return [
-			[1, [], [], [], true],
-			[1, [], [], ['{' . SharingPlugin::NS_NEXTCLOUD . '}deleted-at' => 120], false],
-		];
-	}
+    public static function dataForTestHandleCalendarObjectDeletedEvent(): array {
+        return [
+            [1, [], [], [], true],
+            [1, [], [], ['{' . SharingPlugin::NS_NEXTCLOUD . '}deleted-at' => 120], false],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataForTestHandleCalendarDeletedEvent')]
-	public function testHandleCalendarDeletedEvent(int $calendarId, array $calendarData, array $shares, bool $createsActivity): void {
-		$event = new CalendarDeletedEvent($calendarId, $calendarData, $shares);
-		$this->logger->expects($this->once())->method('debug')->with(
-			$createsActivity ? "Activity generated for deleted calendar $calendarId" : "Calendar $calendarId was already in trashbin, skipping deletion activity"
-		);
-		$this->activityBackend->expects($createsActivity ? $this->once() : $this->never())->method('onCalendarDelete')->with(
-			$calendarData,
-			$shares
-		);
-		$this->listener->handle($event);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataForTestHandleCalendarDeletedEvent')]
+    public function testHandleCalendarDeletedEvent(int $calendarId, array $calendarData, array $shares, bool $createsActivity): void {
+        $event = new CalendarDeletedEvent($calendarId, $calendarData, $shares);
+        $this->logger->expects($this->once())->method('debug')->with(
+            $createsActivity ? "Activity generated for deleted calendar $calendarId" : "Calendar $calendarId was already in trashbin, skipping deletion activity"
+        );
+        $this->activityBackend->expects($createsActivity ? $this->once() : $this->never())->method('onCalendarDelete')->with(
+            $calendarData,
+            $shares
+        );
+        $this->listener->handle($event);
+    }
 
-	public static function dataForTestHandleCalendarDeletedEvent(): array {
-		return [
-			[1, [], [], true],
-			[1, ['{' . SharingPlugin::NS_NEXTCLOUD . '}deleted-at' => 120], [], false],
-		];
-	}
+    public static function dataForTestHandleCalendarDeletedEvent(): array {
+        return [
+            [1, [], [], true],
+            [1, ['{' . SharingPlugin::NS_NEXTCLOUD . '}deleted-at' => 120], [], false],
+        ];
+    }
 }

apps/dav/tests/unit/SystemTag/SystemTagsObjectMappingCollectionTest.php

Indentation +280 added lines, -280 removed lines

@@ -17,331 +17,331 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class SystemTagsObjectMappingCollectionTest extends \Test\TestCase {
-	private ISystemTagManager&MockObject $tagManager;
-	private ISystemTagObjectMapper&MockObject $tagMapper;
-	private IUser&MockObject $user;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-		$this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		$this->user = $this->createMock(IUser::class);
-	}
-
-	public function getNode(array $writableNodeIds = []): SystemTagsObjectMappingCollection {
-		return new SystemTagsObjectMappingCollection(
-			'111',
-			'files',
-			$this->user,
-			$this->tagManager,
-			$this->tagMapper,
-			fn ($id): bool => in_array($id, $writableNodeIds),
-		);
-	}
-
-	public function testAssignTag(): void {
-		$tag = new SystemTag('1', 'Test', true, true);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn([$tag]);
-		$this->tagMapper->expects($this->once())
-			->method('assignTags')
-			->with(111, 'files', '555');
-
-		$this->getNode([111])->createFile('555');
-	}
-
-	public function testAssignTagForbidden(): void {
-		$tag = new SystemTag('1', 'Test', true, true);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-		$this->tagManager->expects($this->once())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn([$tag]);
-		$this->tagMapper->expects($this->never())
-			->method('assignTags');
-
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->getNode()->createFile('555');
-	}
-
-	public static function permissionsProvider(): array {
-		return [
-			// invisible, tag does not exist for user
-			[false, true, '\Sabre\DAV\Exception\PreconditionFailed'],
-			// visible but static, cannot assign tag
-			[true, false, '\Sabre\DAV\Exception\Forbidden'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('permissionsProvider')]
-	public function testAssignTagNoPermission(bool $userVisible, bool $userAssignable, string $expectedException): void {
-		$tag = new SystemTag('1', 'Test', $userVisible, $userAssignable);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($userVisible);
-		$this->tagManager->expects($this->any())
-			->method('canUserAssignTag')
-			->with($tag)
-			->willReturn($userAssignable);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn([$tag]);
-		$this->tagMapper->expects($this->never())
-			->method('assignTags');
-
-		$thrown = null;
-		try {
-			$this->getNode()->createFile('555');
-		} catch (\Exception $e) {
-			$thrown = $e;
-		}
-
-		$this->assertInstanceOf($expectedException, $thrown);
-	}
-
-
-	public function testAssignTagNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\PreconditionFailed::class);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willThrowException(new TagNotFoundException());
-
-		$this->getNode()->createFile('555');
-	}
-
-
-	public function testForbiddenCreateDirectory(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$this->getNode()->createDirectory('789');
-	}
-
-	public function testGetChild(): void {
-		$tag = new SystemTag('555', 'TheTag', true, false);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
-
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555', true)
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn(['555' => $tag]);
-
-		$childNode = $this->getNode()->getChild('555');
-
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $childNode);
-		$this->assertEquals('555', $childNode->getName());
-	}
-
-
-	public function testGetChildNonVisible(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-
-		$tag = new SystemTag('555', 'TheTag', false, false);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(false);
-
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555', true)
-			->willReturn(true);
+    private ISystemTagManager&MockObject $tagManager;
+    private ISystemTagObjectMapper&MockObject $tagMapper;
+    private IUser&MockObject $user;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+        $this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        $this->user = $this->createMock(IUser::class);
+    }
+
+    public function getNode(array $writableNodeIds = []): SystemTagsObjectMappingCollection {
+        return new SystemTagsObjectMappingCollection(
+            '111',
+            'files',
+            $this->user,
+            $this->tagManager,
+            $this->tagMapper,
+            fn ($id): bool => in_array($id, $writableNodeIds),
+        );
+    }
+
+    public function testAssignTag(): void {
+        $tag = new SystemTag('1', 'Test', true, true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn([$tag]);
+        $this->tagMapper->expects($this->once())
+            ->method('assignTags')
+            ->with(111, 'files', '555');
+
+        $this->getNode([111])->createFile('555');
+    }
+
+    public function testAssignTagForbidden(): void {
+        $tag = new SystemTag('1', 'Test', true, true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn([$tag]);
+        $this->tagMapper->expects($this->never())
+            ->method('assignTags');
+
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->getNode()->createFile('555');
+    }
+
+    public static function permissionsProvider(): array {
+        return [
+            // invisible, tag does not exist for user
+            [false, true, '\Sabre\DAV\Exception\PreconditionFailed'],
+            // visible but static, cannot assign tag
+            [true, false, '\Sabre\DAV\Exception\Forbidden'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('permissionsProvider')]
+    public function testAssignTagNoPermission(bool $userVisible, bool $userAssignable, string $expectedException): void {
+        $tag = new SystemTag('1', 'Test', $userVisible, $userAssignable);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($userVisible);
+        $this->tagManager->expects($this->any())
+            ->method('canUserAssignTag')
+            ->with($tag)
+            ->willReturn($userAssignable);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn([$tag]);
+        $this->tagMapper->expects($this->never())
+            ->method('assignTags');
+
+        $thrown = null;
+        try {
+            $this->getNode()->createFile('555');
+        } catch (\Exception $e) {
+            $thrown = $e;
+        }
+
+        $this->assertInstanceOf($expectedException, $thrown);
+    }
+
+
+    public function testAssignTagNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\PreconditionFailed::class);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willThrowException(new TagNotFoundException());
+
+        $this->getNode()->createFile('555');
+    }
+
+
+    public function testForbiddenCreateDirectory(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $this->getNode()->createDirectory('789');
+    }
+
+    public function testGetChild(): void {
+        $tag = new SystemTag('555', 'TheTag', true, false);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
+
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555', true)
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn(['555' => $tag]);
+
+        $childNode = $this->getNode()->getChild('555');
+
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $childNode);
+        $this->assertEquals('555', $childNode->getName());
+    }
+
+
+    public function testGetChildNonVisible(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+
+        $tag = new SystemTag('555', 'TheTag', false, false);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(false);
+
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555', true)
+            ->willReturn(true);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn(['555' => $tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn(['555' => $tag]);
 
-		$this->getNode()->getChild('555');
-	}
+        $this->getNode()->getChild('555');
+    }
 
 
-	public function testGetChildRelationNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testGetChildRelationNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '777')
-			->willReturn(false);
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '777')
+            ->willReturn(false);
 
-		$this->getNode()->getChild('777');
-	}
+        $this->getNode()->getChild('777');
+    }
 
 
-	public function testGetChildInvalidId(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+    public function testGetChildInvalidId(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', 'badid')
-			->willThrowException(new \InvalidArgumentException());
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', 'badid')
+            ->willThrowException(new \InvalidArgumentException());
 
-		$this->getNode()->getChild('badid');
-	}
+        $this->getNode()->getChild('badid');
+    }
 
 
-	public function testGetChildTagDoesNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testGetChildTagDoesNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '777')
-			->willThrowException(new TagNotFoundException());
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '777')
+            ->willThrowException(new TagNotFoundException());
 
-		$this->getNode()->getChild('777');
-	}
+        $this->getNode()->getChild('777');
+    }
 
-	public function testGetChildren(): void {
-		$tag1 = new SystemTag('555', 'TagOne', true, false);
-		$tag2 = new SystemTag('556', 'TagTwo', true, true);
-		$tag3 = new SystemTag('557', 'InvisibleTag', false, true);
+    public function testGetChildren(): void {
+        $tag1 = new SystemTag('555', 'TagOne', true, false);
+        $tag2 = new SystemTag('556', 'TagTwo', true, true);
+        $tag3 = new SystemTag('557', 'InvisibleTag', false, true);
 
-		$this->tagMapper->expects($this->once())
-			->method('getTagIdsForObjects')
-			->with([111], 'files')
-			->willReturn(['111' => ['555', '556', '557']]);
+        $this->tagMapper->expects($this->once())
+            ->method('getTagIdsForObjects')
+            ->with([111], 'files')
+            ->willReturn(['111' => ['555', '556', '557']]);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555', '556', '557'])
-			->willReturn(['555' => $tag1, '556' => $tag2, '557' => $tag3]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555', '556', '557'])
+            ->willReturn(['555' => $tag1, '556' => $tag2, '557' => $tag3]);
 
-		$this->tagManager->expects($this->exactly(3))
-			->method('canUserSeeTag')
-			->willReturnCallback(function ($tag) {
-				return $tag->isUserVisible();
-			});
+        $this->tagManager->expects($this->exactly(3))
+            ->method('canUserSeeTag')
+            ->willReturnCallback(function ($tag) {
+                return $tag->isUserVisible();
+            });
 
-		$children = $this->getNode()->getChildren();
+        $children = $this->getNode()->getChildren();
 
-		$this->assertCount(2, $children);
+        $this->assertCount(2, $children);
 
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $children[0]);
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $children[1]);
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $children[0]);
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagMappingNode', $children[1]);
 
-		$this->assertEquals(111, $children[0]->getObjectId());
-		$this->assertEquals('files', $children[0]->getObjectType());
-		$this->assertEquals($tag1, $children[0]->getSystemTag());
+        $this->assertEquals(111, $children[0]->getObjectId());
+        $this->assertEquals('files', $children[0]->getObjectType());
+        $this->assertEquals($tag1, $children[0]->getSystemTag());
 
-		$this->assertEquals(111, $children[1]->getObjectId());
-		$this->assertEquals('files', $children[1]->getObjectType());
-		$this->assertEquals($tag2, $children[1]->getSystemTag());
-	}
+        $this->assertEquals(111, $children[1]->getObjectId());
+        $this->assertEquals('files', $children[1]->getObjectType());
+        $this->assertEquals($tag2, $children[1]->getSystemTag());
+    }
 
-	public function testChildExistsWithVisibleTag(): void {
-		$tag = new SystemTag('555', 'TagOne', true, false);
+    public function testChildExistsWithVisibleTag(): void {
+        $tag = new SystemTag('555', 'TagOne', true, false);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555')
-			->willReturn(true);
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555')
+            ->willReturn(true);
 
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn([$tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn([$tag]);
 
-		$this->assertTrue($this->getNode()->childExists('555'));
-	}
+        $this->assertTrue($this->getNode()->childExists('555'));
+    }
 
-	public function testChildExistsWithInvisibleTag(): void {
-		$tag = new SystemTag('555', 'TagOne', false, false);
+    public function testChildExistsWithInvisibleTag(): void {
+        $tag = new SystemTag('555', 'TagOne', false, false);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555')
-			->willReturn(true);
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555')
+            ->willReturn(true);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['555'])
-			->willReturn([$tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['555'])
+            ->willReturn([$tag]);
 
-		$this->assertFalse($this->getNode()->childExists('555'));
-	}
+        $this->assertFalse($this->getNode()->childExists('555'));
+    }
 
-	public function testChildExistsNotFound(): void {
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555')
-			->willReturn(false);
+    public function testChildExistsNotFound(): void {
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555')
+            ->willReturn(false);
 
-		$this->assertFalse($this->getNode()->childExists('555'));
-	}
+        $this->assertFalse($this->getNode()->childExists('555'));
+    }
 
-	public function testChildExistsTagNotFound(): void {
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555')
-			->willThrowException(new TagNotFoundException());
+    public function testChildExistsTagNotFound(): void {
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555')
+            ->willThrowException(new TagNotFoundException());
 
-		$this->assertFalse($this->getNode()->childExists('555'));
-	}
+        $this->assertFalse($this->getNode()->childExists('555'));
+    }
 
 
-	public function testChildExistsInvalidId(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+    public function testChildExistsInvalidId(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
 
-		$this->tagMapper->expects($this->once())
-			->method('haveTag')
-			->with([111], 'files', '555')
-			->willThrowException(new \InvalidArgumentException());
+        $this->tagMapper->expects($this->once())
+            ->method('haveTag')
+            ->with([111], 'files', '555')
+            ->willThrowException(new \InvalidArgumentException());
 
-		$this->getNode()->childExists('555');
-	}
+        $this->getNode()->childExists('555');
+    }
 
 
-	public function testDelete(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testDelete(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$this->getNode()->delete();
-	}
+        $this->getNode()->delete();
+    }
 
 
-	public function testSetName(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testSetName(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$this->getNode()->setName('somethingelse');
-	}
+        $this->getNode()->setName('somethingelse');
+    }
 
-	public function testGetName(): void {
-		$this->assertEquals('111', $this->getNode()->getName());
-	}
+    public function testGetName(): void {
+        $this->assertEquals('111', $this->getNode()->getName());
+    }
 }

apps/dav/tests/unit/SystemTag/SystemTagsByIdCollectionTest.php

Indentation +151 added lines, -151 removed lines

@@ -19,206 +19,206 @@
 use PHPUnit\Framework\MockObject\MockObject;
 
 class SystemTagsByIdCollectionTest extends \Test\TestCase {
-	private ISystemTagManager&MockObject $tagManager;
-	private IUser&MockObject $user;
+    private ISystemTagManager&MockObject $tagManager;
+    private IUser&MockObject $user;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-	}
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+    }
 
-	public function getNode(bool $isAdmin = true) {
-		$this->user = $this->createMock(IUser::class);
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('testuser');
+    public function getNode(bool $isAdmin = true) {
+        $this->user = $this->createMock(IUser::class);
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('testuser');
 
-		/** @var IUserSession&MockObject */
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($this->user);
+        /** @var IUserSession&MockObject */
+        $userSession = $this->createMock(IUserSession::class);
+        $userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->user);
 
-		/** @var IGroupManager&MockObject */
-		$groupManager = $this->createMock(IGroupManager::class);
-		$groupManager->expects($this->any())
-			->method('isAdmin')
-			->with('testuser')
-			->willReturn($isAdmin);
+        /** @var IGroupManager&MockObject */
+        $groupManager = $this->createMock(IGroupManager::class);
+        $groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->with('testuser')
+            ->willReturn($isAdmin);
 
-		/** @var ISystemTagObjectMapper&MockObject */
-		$tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		return new SystemTagsByIdCollection(
-			$this->tagManager,
-			$userSession,
-			$groupManager,
-			$tagMapper,
-		);
-	}
+        /** @var ISystemTagObjectMapper&MockObject */
+        $tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        return new SystemTagsByIdCollection(
+            $this->tagManager,
+            $userSession,
+            $groupManager,
+            $tagMapper,
+        );
+    }
 
-	public static function adminFlagProvider(): array {
-		return [[true], [false]];
-	}
+    public static function adminFlagProvider(): array {
+        return [[true], [false]];
+    }
 
 
-	public function testForbiddenCreateFile(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testForbiddenCreateFile(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$this->getNode()->createFile('555');
-	}
+        $this->getNode()->createFile('555');
+    }
 
 
-	public function testForbiddenCreateDirectory(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testForbiddenCreateDirectory(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$this->getNode()->createDirectory('789');
-	}
+        $this->getNode()->createDirectory('789');
+    }
 
-	public function testGetChild(): void {
-		$tag = new SystemTag('123', 'Test', true, false);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn(true);
+    public function testGetChild(): void {
+        $tag = new SystemTag('123', 'Test', true, false);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn(true);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willReturn([$tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willReturn([$tag]);
 
-		$childNode = $this->getNode()->getChild('123');
+        $childNode = $this->getNode()->getChild('123');
 
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $childNode);
-		$this->assertEquals('123', $childNode->getName());
-		$this->assertEquals($tag, $childNode->getSystemTag());
-	}
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $childNode);
+        $this->assertEquals('123', $childNode->getName());
+        $this->assertEquals($tag, $childNode->getSystemTag());
+    }
 
 
-	public function testGetChildInvalidName(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+    public function testGetChildInvalidName(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['invalid'])
-			->willThrowException(new \InvalidArgumentException());
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['invalid'])
+            ->willThrowException(new \InvalidArgumentException());
 
-		$this->getNode()->getChild('invalid');
-	}
+        $this->getNode()->getChild('invalid');
+    }
 
 
-	public function testGetChildNotFound(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testGetChildNotFound(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['444'])
-			->willThrowException(new TagNotFoundException());
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['444'])
+            ->willThrowException(new TagNotFoundException());
 
-		$this->getNode()->getChild('444');
-	}
+        $this->getNode()->getChild('444');
+    }
 
 
-	public function testGetChildUserNotVisible(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
+    public function testGetChildUserNotVisible(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
-		$tag = new SystemTag('123', 'Test', false, false);
+        $tag = new SystemTag('123', 'Test', false, false);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willReturn([$tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willReturn([$tag]);
 
-		$this->getNode(false)->getChild('123');
-	}
+        $this->getNode(false)->getChild('123');
+    }
 
-	public function testGetChildrenAdmin(): void {
-		$tag1 = new SystemTag('123', 'One', true, false);
-		$tag2 = new SystemTag('456', 'Two', true, true);
+    public function testGetChildrenAdmin(): void {
+        $tag1 = new SystemTag('123', 'One', true, false);
+        $tag2 = new SystemTag('456', 'Two', true, true);
 
-		$this->tagManager->expects($this->once())
-			->method('getAllTags')
-			->with(null)
-			->willReturn([$tag1, $tag2]);
+        $this->tagManager->expects($this->once())
+            ->method('getAllTags')
+            ->with(null)
+            ->willReturn([$tag1, $tag2]);
 
-		$children = $this->getNode(true)->getChildren();
+        $children = $this->getNode(true)->getChildren();
 
-		$this->assertCount(2, $children);
+        $this->assertCount(2, $children);
 
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[0]);
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[1]);
-		$this->assertEquals($tag1, $children[0]->getSystemTag());
-		$this->assertEquals($tag2, $children[1]->getSystemTag());
-	}
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[0]);
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[1]);
+        $this->assertEquals($tag1, $children[0]->getSystemTag());
+        $this->assertEquals($tag2, $children[1]->getSystemTag());
+    }
 
-	public function testGetChildrenNonAdmin(): void {
-		$tag1 = new SystemTag('123', 'One', true, false);
-		$tag2 = new SystemTag('456', 'Two', true, true);
+    public function testGetChildrenNonAdmin(): void {
+        $tag1 = new SystemTag('123', 'One', true, false);
+        $tag2 = new SystemTag('456', 'Two', true, true);
 
-		$this->tagManager->expects($this->once())
-			->method('getAllTags')
-			->with(true)
-			->willReturn([$tag1, $tag2]);
+        $this->tagManager->expects($this->once())
+            ->method('getAllTags')
+            ->with(true)
+            ->willReturn([$tag1, $tag2]);
 
-		$children = $this->getNode(false)->getChildren();
+        $children = $this->getNode(false)->getChildren();
 
-		$this->assertCount(2, $children);
+        $this->assertCount(2, $children);
 
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[0]);
-		$this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[1]);
-		$this->assertEquals($tag1, $children[0]->getSystemTag());
-		$this->assertEquals($tag2, $children[1]->getSystemTag());
-	}
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[0]);
+        $this->assertInstanceOf('\OCA\DAV\SystemTag\SystemTagNode', $children[1]);
+        $this->assertEquals($tag1, $children[0]->getSystemTag());
+        $this->assertEquals($tag2, $children[1]->getSystemTag());
+    }
 
-	public function testGetChildrenEmpty(): void {
-		$this->tagManager->expects($this->once())
-			->method('getAllTags')
-			->with(null)
-			->willReturn([]);
-		$this->assertCount(0, $this->getNode()->getChildren());
-	}
+    public function testGetChildrenEmpty(): void {
+        $this->tagManager->expects($this->once())
+            ->method('getAllTags')
+            ->with(null)
+            ->willReturn([]);
+        $this->assertCount(0, $this->getNode()->getChildren());
+    }
 
-	public static function childExistsProvider(): array {
-		return [
-			[true, true],
-			[false, false],
-		];
-	}
+    public static function childExistsProvider(): array {
+        return [
+            [true, true],
+            [false, false],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('childExistsProvider')]
-	public function testChildExists(bool $userVisible, bool $expectedResult): void {
-		$tag = new SystemTag('123', 'One', $userVisible, false);
-		$this->tagManager->expects($this->once())
-			->method('canUserSeeTag')
-			->with($tag)
-			->willReturn($userVisible);
+    #[\PHPUnit\Framework\Attributes\DataProvider('childExistsProvider')]
+    public function testChildExists(bool $userVisible, bool $expectedResult): void {
+        $tag = new SystemTag('123', 'One', $userVisible, false);
+        $this->tagManager->expects($this->once())
+            ->method('canUserSeeTag')
+            ->with($tag)
+            ->willReturn($userVisible);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willReturn([$tag]);
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willReturn([$tag]);
 
-		$this->assertEquals($expectedResult, $this->getNode()->childExists('123'));
-	}
+        $this->assertEquals($expectedResult, $this->getNode()->childExists('123'));
+    }
 
-	public function testChildExistsNotFound(): void {
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willThrowException(new TagNotFoundException());
+    public function testChildExistsNotFound(): void {
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willThrowException(new TagNotFoundException());
 
-		$this->assertFalse($this->getNode()->childExists('123'));
-	}
+        $this->assertFalse($this->getNode()->childExists('123'));
+    }
 
 
-	public function testChildExistsBadRequest(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+    public function testChildExistsBadRequest(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
 
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['invalid'])
-			->willThrowException(new \InvalidArgumentException());
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['invalid'])
+            ->willThrowException(new \InvalidArgumentException());
 
-		$this->getNode()->childExists('invalid');
-	}
+        $this->getNode()->childExists('invalid');
+    }
 }