nextcloud / server

apps/dav/tests/unit/DAV/GroupPrincipalTest.php

Indentation +308 added lines, -308 removed lines

@@ -20,312 +20,312 @@
 use Sabre\DAV\PropPatch;
 
 class GroupPrincipalTest extends \Test\TestCase {
-	private IConfig&MockObject $config;
-	private IGroupManager&MockObject $groupManager;
-	private IUserSession&MockObject $userSession;
-	private IManager&MockObject $shareManager;
-	private GroupPrincipalBackend $connector;
-
-	protected function setUp(): void {
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$this->connector = new GroupPrincipalBackend(
-			$this->groupManager,
-			$this->userSession,
-			$this->shareManager,
-			$this->config
-		);
-		parent::setUp();
-	}
-
-	public function testGetPrincipalsByPrefixWithoutPrefix(): void {
-		$response = $this->connector->getPrincipalsByPrefix('');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPrefixWithUsers(): void {
-		$group1 = $this->mockGroup('foo');
-		$group2 = $this->mockGroup('bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([$group1, $group2]);
-
-		$expectedResponse = [
-			0 => [
-				'uri' => 'principals/groups/foo',
-				'{DAV:}displayname' => 'Group foo',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-			],
-			1 => [
-				'uri' => 'principals/groups/bar',
-				'{DAV:}displayname' => 'Group bar',
-				'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-			]
-		];
-		$response = $this->connector->getPrincipalsByPrefix('principals/groups');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPrefixEmpty(): void {
-		$this->groupManager
-			->expects($this->once())
-			->method('search')
-			->with('')
-			->willReturn([]);
-
-		$response = $this->connector->getPrincipalsByPrefix('principals/groups');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetPrincipalsByPathWithoutMail(): void {
-		$group1 = $this->mockGroup('foo');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo',
-			'{DAV:}displayname' => 'Group foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathWithMail(): void {
-		$fooUser = $this->mockGroup('foo');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn($fooUser);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo',
-			'{DAV:}displayname' => 'Group foo',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathEmpty(): void {
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo')
-			->willReturn(null);
-
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo');
-		$this->assertSame(null, $response);
-	}
-
-	public function testGetPrincipalsByPathGroupWithSlash(): void {
-		$group1 = $this->mockGroup('foo/bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo/bar')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo%2Fbar',
-			'{DAV:}displayname' => 'Group foo/bar',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo/bar');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetPrincipalsByPathGroupWithHash(): void {
-		$group1 = $this->mockGroup('foo#bar');
-		$this->groupManager
-			->expects($this->once())
-			->method('get')
-			->with('foo#bar')
-			->willReturn($group1);
-
-		$expectedResponse = [
-			'uri' => 'principals/groups/foo%23bar',
-			'{DAV:}displayname' => 'Group foo#bar',
-			'{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
-		];
-		$response = $this->connector->getPrincipalByPath('principals/groups/foo#bar');
-		$this->assertSame($expectedResponse, $response);
-	}
-
-	public function testGetGroupMemberSet(): void {
-		$response = $this->connector->getGroupMemberSet('principals/groups/foo');
-		$this->assertSame([], $response);
-	}
-
-	public function testGetGroupMembership(): void {
-		$response = $this->connector->getGroupMembership('principals/groups/foo');
-		$this->assertSame([], $response);
-	}
-
-
-	public function testSetGroupMembership(): void {
-		$this->expectException(\Sabre\DAV\Exception::class);
-		$this->expectExceptionMessage('Setting members of the group is not supported yet');
-
-		$this->connector->setGroupMemberSet('principals/groups/foo', ['foo']);
-	}
-
-	public function testUpdatePrincipal(): void {
-		$this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
-	}
-
-	public function testSearchPrincipalsWithEmptySearchProperties(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/groups', []));
-	}
-
-	public function testSearchPrincipalsWithWrongPrefixPath(): void {
-		$this->assertSame([], $this->connector->searchPrincipals('principals/users',
-			['{DAV:}displayname' => 'Foo']));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('searchPrincipalsDataProvider')]
-	public function testSearchPrincipals(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $test, array $result): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn($sharingEnabled);
-
-		$this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
-			->method('allowGroupSharing')
-			->willReturn($groupSharingEnabled);
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->shareManager->expects($this->once())
-				->method('shareWithGroupMembersOnly')
-				->willReturn($groupsOnly);
-
-			if ($groupsOnly) {
-				$user = $this->createMock(IUser::class);
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($user);
-
-				$this->groupManager->expects($this->once())
-					->method('getUserGroupIds')
-					->with($user)
-					->willReturn(['group1', 'group2', 'group5']);
-			}
-		} else {
-			$this->shareManager->expects($this->never())
-				->method('shareWithGroupMembersOnly');
-			$this->groupManager->expects($this->never())
-				->method($this->anything());
-		}
-
-		$group1 = $this->createMock(IGroup::class);
-		$group1->method('getGID')->willReturn('group1');
-		$group2 = $this->createMock(IGroup::class);
-		$group2->method('getGID')->willReturn('group2');
-		$group3 = $this->createMock(IGroup::class);
-		$group3->method('getGID')->willReturn('group3');
-		$group4 = $this->createMock(IGroup::class);
-		$group4->method('getGID')->willReturn('group4');
-		$group5 = $this->createMock(IGroup::class);
-		$group5->method('getGID')->willReturn('group5');
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->groupManager->expects($this->once())
-				->method('search')
-				->with('Foo')
-				->willReturn([$group1, $group2, $group3, $group4, $group5]);
-		} else {
-			$this->groupManager->expects($this->never())
-				->method('search');
-		}
-
-		$this->assertSame($result, $this->connector->searchPrincipals('principals/groups',
-			['{DAV:}displayname' => 'Foo'], $test));
-	}
-
-	public static function searchPrincipalsDataProvider(): array {
-		return [
-			[true, true, false, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
-			[true, true, false, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
-			[true, true, true, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
-			[true, true, true, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
-			[true, false, false, 'allof', []],
-			[false, true, false, 'anyof', []],
-			[false, false, false, 'allof', []],
-			[false, false, false, 'anyof', []],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('findByUriDataProvider')]
-	public function testFindByUri(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $findUri, ?string $result): void {
-		$this->shareManager->expects($this->once())
-			->method('shareAPIEnabled')
-			->willReturn($sharingEnabled);
-
-		$this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
-			->method('allowGroupSharing')
-			->willReturn($groupSharingEnabled);
-
-		if ($sharingEnabled && $groupSharingEnabled) {
-			$this->shareManager->expects($this->once())
-				->method('shareWithGroupMembersOnly')
-				->willReturn($groupsOnly);
-
-			if ($groupsOnly) {
-				$user = $this->createMock(IUser::class);
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($user);
-
-				$this->groupManager->expects($this->once())
-					->method('getUserGroupIds')
-					->with($user)
-					->willReturn(['group1', 'group2', 'group5']);
-			}
-		} else {
-			$this->shareManager->expects($this->never())
-				->method('shareWithGroupMembersOnly');
-			$this->groupManager->expects($this->never())
-				->method($this->anything());
-		}
-
-		$this->assertEquals($result, $this->connector->findByUri($findUri, 'principals/groups'));
-	}
-
-	public static function findByUriDataProvider(): array {
-		return [
-			[false, false, false, 'principal:principals/groups/group1', null],
-			[false, false, false, 'principal:principals/groups/group3', null],
-			[false, true, false, 'principal:principals/groups/group1', null],
-			[false, true, false, 'principal:principals/groups/group3', null],
-			[false, false, true, 'principal:principals/groups/group1', null],
-			[false, false, true, 'principal:principals/groups/group3', null],
-			[true, false, true, 'principal:principals/groups/group1', null],
-			[true, false, true, 'principal:principals/groups/group3', null],
-			[true, true, true, 'principal:principals/groups/group1', 'principals/groups/group1'],
-			[true, true, true, 'principal:principals/groups/group3', null],
-			[true, true, false, 'principal:principals/groups/group1', 'principals/groups/group1'],
-			[true, true, false, 'principal:principals/groups/group3', 'principals/groups/group3'],
-		];
-	}
-
-	private function mockGroup(string $gid): Group&MockObject {
-		$fooGroup = $this->createMock(Group::class);
-		$fooGroup
-			->expects($this->exactly(1))
-			->method('getGID')
-			->willReturn($gid);
-		$fooGroup
-			->expects($this->exactly(1))
-			->method('getDisplayName')
-			->willReturn('Group ' . $gid);
-		return $fooGroup;
-	}
+    private IConfig&MockObject $config;
+    private IGroupManager&MockObject $groupManager;
+    private IUserSession&MockObject $userSession;
+    private IManager&MockObject $shareManager;
+    private GroupPrincipalBackend $connector;
+
+    protected function setUp(): void {
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $this->connector = new GroupPrincipalBackend(
+            $this->groupManager,
+            $this->userSession,
+            $this->shareManager,
+            $this->config
+        );
+        parent::setUp();
+    }
+
+    public function testGetPrincipalsByPrefixWithoutPrefix(): void {
+        $response = $this->connector->getPrincipalsByPrefix('');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPrefixWithUsers(): void {
+        $group1 = $this->mockGroup('foo');
+        $group2 = $this->mockGroup('bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([$group1, $group2]);
+
+        $expectedResponse = [
+            0 => [
+                'uri' => 'principals/groups/foo',
+                '{DAV:}displayname' => 'Group foo',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+            ],
+            1 => [
+                'uri' => 'principals/groups/bar',
+                '{DAV:}displayname' => 'Group bar',
+                '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+            ]
+        ];
+        $response = $this->connector->getPrincipalsByPrefix('principals/groups');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPrefixEmpty(): void {
+        $this->groupManager
+            ->expects($this->once())
+            ->method('search')
+            ->with('')
+            ->willReturn([]);
+
+        $response = $this->connector->getPrincipalsByPrefix('principals/groups');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetPrincipalsByPathWithoutMail(): void {
+        $group1 = $this->mockGroup('foo');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo',
+            '{DAV:}displayname' => 'Group foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathWithMail(): void {
+        $fooUser = $this->mockGroup('foo');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn($fooUser);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo',
+            '{DAV:}displayname' => 'Group foo',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathEmpty(): void {
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo')
+            ->willReturn(null);
+
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo');
+        $this->assertSame(null, $response);
+    }
+
+    public function testGetPrincipalsByPathGroupWithSlash(): void {
+        $group1 = $this->mockGroup('foo/bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo/bar')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo%2Fbar',
+            '{DAV:}displayname' => 'Group foo/bar',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo/bar');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetPrincipalsByPathGroupWithHash(): void {
+        $group1 = $this->mockGroup('foo#bar');
+        $this->groupManager
+            ->expects($this->once())
+            ->method('get')
+            ->with('foo#bar')
+            ->willReturn($group1);
+
+        $expectedResponse = [
+            'uri' => 'principals/groups/foo%23bar',
+            '{DAV:}displayname' => 'Group foo#bar',
+            '{urn:ietf:params:xml:ns:caldav}calendar-user-type' => 'GROUP',
+        ];
+        $response = $this->connector->getPrincipalByPath('principals/groups/foo#bar');
+        $this->assertSame($expectedResponse, $response);
+    }
+
+    public function testGetGroupMemberSet(): void {
+        $response = $this->connector->getGroupMemberSet('principals/groups/foo');
+        $this->assertSame([], $response);
+    }
+
+    public function testGetGroupMembership(): void {
+        $response = $this->connector->getGroupMembership('principals/groups/foo');
+        $this->assertSame([], $response);
+    }
+
+
+    public function testSetGroupMembership(): void {
+        $this->expectException(\Sabre\DAV\Exception::class);
+        $this->expectExceptionMessage('Setting members of the group is not supported yet');
+
+        $this->connector->setGroupMemberSet('principals/groups/foo', ['foo']);
+    }
+
+    public function testUpdatePrincipal(): void {
+        $this->assertSame(0, $this->connector->updatePrincipal('foo', new PropPatch([])));
+    }
+
+    public function testSearchPrincipalsWithEmptySearchProperties(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/groups', []));
+    }
+
+    public function testSearchPrincipalsWithWrongPrefixPath(): void {
+        $this->assertSame([], $this->connector->searchPrincipals('principals/users',
+            ['{DAV:}displayname' => 'Foo']));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('searchPrincipalsDataProvider')]
+    public function testSearchPrincipals(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $test, array $result): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn($sharingEnabled);
+
+        $this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
+            ->method('allowGroupSharing')
+            ->willReturn($groupSharingEnabled);
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->shareManager->expects($this->once())
+                ->method('shareWithGroupMembersOnly')
+                ->willReturn($groupsOnly);
+
+            if ($groupsOnly) {
+                $user = $this->createMock(IUser::class);
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($user);
+
+                $this->groupManager->expects($this->once())
+                    ->method('getUserGroupIds')
+                    ->with($user)
+                    ->willReturn(['group1', 'group2', 'group5']);
+            }
+        } else {
+            $this->shareManager->expects($this->never())
+                ->method('shareWithGroupMembersOnly');
+            $this->groupManager->expects($this->never())
+                ->method($this->anything());
+        }
+
+        $group1 = $this->createMock(IGroup::class);
+        $group1->method('getGID')->willReturn('group1');
+        $group2 = $this->createMock(IGroup::class);
+        $group2->method('getGID')->willReturn('group2');
+        $group3 = $this->createMock(IGroup::class);
+        $group3->method('getGID')->willReturn('group3');
+        $group4 = $this->createMock(IGroup::class);
+        $group4->method('getGID')->willReturn('group4');
+        $group5 = $this->createMock(IGroup::class);
+        $group5->method('getGID')->willReturn('group5');
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->groupManager->expects($this->once())
+                ->method('search')
+                ->with('Foo')
+                ->willReturn([$group1, $group2, $group3, $group4, $group5]);
+        } else {
+            $this->groupManager->expects($this->never())
+                ->method('search');
+        }
+
+        $this->assertSame($result, $this->connector->searchPrincipals('principals/groups',
+            ['{DAV:}displayname' => 'Foo'], $test));
+    }
+
+    public static function searchPrincipalsDataProvider(): array {
+        return [
+            [true, true, false, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
+            [true, true, false, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5']],
+            [true, true, true, 'allof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
+            [true, true, true, 'anyof', ['principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5']],
+            [true, false, false, 'allof', []],
+            [false, true, false, 'anyof', []],
+            [false, false, false, 'allof', []],
+            [false, false, false, 'anyof', []],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('findByUriDataProvider')]
+    public function testFindByUri(bool $sharingEnabled, bool $groupSharingEnabled, bool $groupsOnly, string $findUri, ?string $result): void {
+        $this->shareManager->expects($this->once())
+            ->method('shareAPIEnabled')
+            ->willReturn($sharingEnabled);
+
+        $this->shareManager->expects($sharingEnabled ? $this->once() : $this->never())
+            ->method('allowGroupSharing')
+            ->willReturn($groupSharingEnabled);
+
+        if ($sharingEnabled && $groupSharingEnabled) {
+            $this->shareManager->expects($this->once())
+                ->method('shareWithGroupMembersOnly')
+                ->willReturn($groupsOnly);
+
+            if ($groupsOnly) {
+                $user = $this->createMock(IUser::class);
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($user);
+
+                $this->groupManager->expects($this->once())
+                    ->method('getUserGroupIds')
+                    ->with($user)
+                    ->willReturn(['group1', 'group2', 'group5']);
+            }
+        } else {
+            $this->shareManager->expects($this->never())
+                ->method('shareWithGroupMembersOnly');
+            $this->groupManager->expects($this->never())
+                ->method($this->anything());
+        }
+
+        $this->assertEquals($result, $this->connector->findByUri($findUri, 'principals/groups'));
+    }
+
+    public static function findByUriDataProvider(): array {
+        return [
+            [false, false, false, 'principal:principals/groups/group1', null],
+            [false, false, false, 'principal:principals/groups/group3', null],
+            [false, true, false, 'principal:principals/groups/group1', null],
+            [false, true, false, 'principal:principals/groups/group3', null],
+            [false, false, true, 'principal:principals/groups/group1', null],
+            [false, false, true, 'principal:principals/groups/group3', null],
+            [true, false, true, 'principal:principals/groups/group1', null],
+            [true, false, true, 'principal:principals/groups/group3', null],
+            [true, true, true, 'principal:principals/groups/group1', 'principals/groups/group1'],
+            [true, true, true, 'principal:principals/groups/group3', null],
+            [true, true, false, 'principal:principals/groups/group1', 'principals/groups/group1'],
+            [true, true, false, 'principal:principals/groups/group3', 'principals/groups/group3'],
+        ];
+    }
+
+    private function mockGroup(string $gid): Group&MockObject {
+        $fooGroup = $this->createMock(Group::class);
+        $fooGroup
+            ->expects($this->exactly(1))
+            ->method('getGID')
+            ->willReturn($gid);
+        $fooGroup
+            ->expects($this->exactly(1))
+            ->method('getDisplayName')
+            ->willReturn('Group ' . $gid);
+        return $fooGroup;
+    }
 }

apps/dav/tests/unit/DAV/CustomPropertiesBackendTest.php

Indentation +430 added lines, -430 removed lines

@@ -28,434 +28,434 @@
  * @group DB
  */
 class CustomPropertiesBackendTest extends TestCase {
-	private const BASE_URI = '/remote.php/dav/';
-
-	private Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private IDBConnection $dbConnection;
-	private IUser&MockObject $user;
-	private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
-	private CustomPropertiesBackend $backend;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = $this->createMock(Server::class);
-		$this->server->method('getBaseUri')
-			->willReturn(self::BASE_URI);
-		$this->tree = $this->createMock(Tree::class);
-		$this->user = $this->createMock(IUser::class);
-		$this->user->method('getUID')
-			->with()
-			->willReturn('dummy_user_42');
-		$this->dbConnection = \OCP\Server::get(IDBConnection::class);
-		$this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
-
-		$this->backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$this->dbConnection,
-			$this->user,
-			$this->defaultCalendarValidator,
-		);
-	}
-
-	protected function tearDown(): void {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->delete('properties');
-		$query->execute();
-
-		parent::tearDown();
-	}
-
-	private function formatPath(string $path): string {
-		if (strlen($path) > 250) {
-			return sha1($path);
-		} else {
-			return $path;
-		}
-	}
-
-	protected function insertProps(string $user, string $path, array $props): void {
-		foreach ($props as $name => $value) {
-			$this->insertProp($user, $path, $name, $value);
-		}
-	}
-
-	protected function insertProp(string $user, string $path, string $name, mixed $value): void {
-		$type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
-		if ($value instanceof Href) {
-			$value = $value->getHref();
-			$type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
-		}
-
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->insert('properties')
-			->values([
-				'userid' => $query->createNamedParameter($user),
-				'propertypath' => $query->createNamedParameter($this->formatPath($path)),
-				'propertyname' => $query->createNamedParameter($name),
-				'propertyvalue' => $query->createNamedParameter($value),
-				'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
-			]);
-		$query->execute();
-	}
-
-	protected function getProps(string $user, string $path): array {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->select('propertyname', 'propertyvalue', 'valuetype')
-			->from('properties')
-			->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
-			->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
-
-		$result = $query->execute();
-		$data = [];
-		while ($row = $result->fetch()) {
-			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
-				$value = new Href($value);
-			}
-			$data[$row['propertyname']] = $value;
-		}
-		$result->closeCursor();
-
-		return $data;
-	}
-
-	public function testPropFindNoDbCalls(): void {
-		$db = $this->createMock(IDBConnection::class);
-		$backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$db,
-			$this->user,
-			$this->defaultCalendarValidator,
-		);
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->expects($this->once())
-			->method('get404Properties')
-			->with()
-			->willReturn([
-				'{http://owncloud.org/ns}permissions',
-				'{http://owncloud.org/ns}downloadURL',
-				'{http://owncloud.org/ns}dDC',
-				'{http://owncloud.org/ns}size',
-			]);
-
-		$db->expects($this->never())
-			->method($this->anything());
-
-		$backend->propFind('foo_bar_path_1337_0', $propFind);
-	}
-
-	public function testPropFindCalendarCall(): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{DAV:}displayname',
-				'{urn:ietf:params:xml:ns:caldav}calendar-description',
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone',
-				'{abc}def',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{DAV:}displayname' => 'b',
-			'{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
-			'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
-		];
-
-		$this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public function testPropFindPrincipalCall(): void {
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/dummy_user_42');
-				return $node;
-			});
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-				'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
-		];
-		$this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('principals/users/dummy_user_42', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
-		// [ user, nodes, existingProps, requestedProps, returnedProps ]
-		return [
-			[ // Exists
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-			],
-			[ // Doesn't exist
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // No privilege
-				'dummy_user_42',
-				['calendars/user2/baz/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // Not a calendar
-				'dummy_user_42',
-				['foo/dummy_user_42/bar/' => IACL::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-		];
-
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('propFindPrincipalScheduleDefaultCalendarProviderUrlProvider')]
-	public function testPropFindPrincipalScheduleDefaultCalendarUrl(
-		string $user,
-		array $nodes,
-		array $existingProps,
-		array $requestedProps,
-		array $returnedProps,
-	): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn(array_merge([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			],
-				$requestedProps,
-			));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (!str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
-				if (str_starts_with($uri, 'principals/')) {
-					return $this->createMock(IPrincipal::class);
-				}
-				if (array_key_exists($uri, $nodes)) {
-					$owner = explode('/', $uri)[1];
-					$node = $this->createMock($nodes[$uri]);
-					$node->method('getOwner')
-						->willReturn("principals/users/$owner");
-					return $node;
-				}
-				throw new NotFound('Node not found');
-			});
-
-		$this->insertProps($user, "principals/users/$user", $existingProps);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind("principals/users/$user", $propFind);
-		$this->assertEquals($returnedProps, $setProps);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
-	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
-				return $node;
-			});
-
-		$this->insertProps($this->user->getUID(), $path, $existing);
-		$propPatch = new PropPatch($props);
-
-		$this->backend->propPatch($path, $propPatch);
-		$propPatch->commit();
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals($result, $storedProps);
-	}
-
-	public static function propPatchProvider(): array {
-		$longPath = str_repeat('long_path', 100);
-		return [
-			['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
-			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-		];
-	}
-
-	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
-
-		$node = $this->createMock(Calendar::class);
-		$node->expects(self::once())
-			->method('getOwner')
-			->willReturn($path);
-
-		$this->defaultCalendarValidator->expects(self::once())
-			->method('validateScheduleDefaultCalendar')
-			->with($node)
-			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->expects(self::once())
-			->method('getNodeForPath')
-			->with('foo/bar/')
-			->willReturn($node);
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-
-		$propPatch = new PropPatch([
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
-		]);
-		$this->backend->propPatch($path, $propPatch);
-		try {
-			$propPatch->commit();
-		} catch (\Throwable $e) {
-			$this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
-		}
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('deleteProvider')]
-	public function testDelete(string $path): void {
-		$this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
-		$this->backend->delete($path);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $path));
-	}
-
-	public static function deleteProvider(): array {
-		return [
-			['foo_bar_path_1337'],
-			[str_repeat('long_path', 100)]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('moveProvider')]
-	public function testMove(string $source, string $target): void {
-		$this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
-		$this->backend->move($source, $target);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $source));
-		$this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
-	}
-
-	public static function moveProvider(): array {
-		return [
-			['foo_bar_path_1337', 'foo_bar_path_7333'],
-			[str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
-		];
-	}
-
-	public function testDecodeValueFromDatabaseObjectCurrent(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
-
-	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
+    private const BASE_URI = '/remote.php/dav/';
+
+    private Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private IDBConnection $dbConnection;
+    private IUser&MockObject $user;
+    private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
+    private CustomPropertiesBackend $backend;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = $this->createMock(Server::class);
+        $this->server->method('getBaseUri')
+            ->willReturn(self::BASE_URI);
+        $this->tree = $this->createMock(Tree::class);
+        $this->user = $this->createMock(IUser::class);
+        $this->user->method('getUID')
+            ->with()
+            ->willReturn('dummy_user_42');
+        $this->dbConnection = \OCP\Server::get(IDBConnection::class);
+        $this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
+
+        $this->backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $this->dbConnection,
+            $this->user,
+            $this->defaultCalendarValidator,
+        );
+    }
+
+    protected function tearDown(): void {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->delete('properties');
+        $query->execute();
+
+        parent::tearDown();
+    }
+
+    private function formatPath(string $path): string {
+        if (strlen($path) > 250) {
+            return sha1($path);
+        } else {
+            return $path;
+        }
+    }
+
+    protected function insertProps(string $user, string $path, array $props): void {
+        foreach ($props as $name => $value) {
+            $this->insertProp($user, $path, $name, $value);
+        }
+    }
+
+    protected function insertProp(string $user, string $path, string $name, mixed $value): void {
+        $type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
+        if ($value instanceof Href) {
+            $value = $value->getHref();
+            $type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
+        }
+
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->insert('properties')
+            ->values([
+                'userid' => $query->createNamedParameter($user),
+                'propertypath' => $query->createNamedParameter($this->formatPath($path)),
+                'propertyname' => $query->createNamedParameter($name),
+                'propertyvalue' => $query->createNamedParameter($value),
+                'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
+            ]);
+        $query->execute();
+    }
+
+    protected function getProps(string $user, string $path): array {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->select('propertyname', 'propertyvalue', 'valuetype')
+            ->from('properties')
+            ->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
+            ->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
+
+        $result = $query->execute();
+        $data = [];
+        while ($row = $result->fetch()) {
+            $value = $row['propertyvalue'];
+            if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+                $value = new Href($value);
+            }
+            $data[$row['propertyname']] = $value;
+        }
+        $result->closeCursor();
+
+        return $data;
+    }
+
+    public function testPropFindNoDbCalls(): void {
+        $db = $this->createMock(IDBConnection::class);
+        $backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $db,
+            $this->user,
+            $this->defaultCalendarValidator,
+        );
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->expects($this->once())
+            ->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{http://owncloud.org/ns}permissions',
+                '{http://owncloud.org/ns}downloadURL',
+                '{http://owncloud.org/ns}dDC',
+                '{http://owncloud.org/ns}size',
+            ]);
+
+        $db->expects($this->never())
+            ->method($this->anything());
+
+        $backend->propFind('foo_bar_path_1337_0', $propFind);
+    }
+
+    public function testPropFindCalendarCall(): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{DAV:}displayname',
+                '{urn:ietf:params:xml:ns:caldav}calendar-description',
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone',
+                '{abc}def',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{DAV:}displayname' => 'b',
+            '{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
+            '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
+        ];
+
+        $this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public function testPropFindPrincipalCall(): void {
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/dummy_user_42');
+                return $node;
+            });
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+                '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
+        ];
+        $this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('principals/users/dummy_user_42', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
+        // [ user, nodes, existingProps, requestedProps, returnedProps ]
+        return [
+            [ // Exists
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+            ],
+            [ // Doesn't exist
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // No privilege
+                'dummy_user_42',
+                ['calendars/user2/baz/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // Not a calendar
+                'dummy_user_42',
+                ['foo/dummy_user_42/bar/' => IACL::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+        ];
+
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('propFindPrincipalScheduleDefaultCalendarProviderUrlProvider')]
+    public function testPropFindPrincipalScheduleDefaultCalendarUrl(
+        string $user,
+        array $nodes,
+        array $existingProps,
+        array $requestedProps,
+        array $returnedProps,
+    ): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn(array_merge([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ],
+                $requestedProps,
+            ));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (!str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) use ($nodes) {
+                if (str_starts_with($uri, 'principals/')) {
+                    return $this->createMock(IPrincipal::class);
+                }
+                if (array_key_exists($uri, $nodes)) {
+                    $owner = explode('/', $uri)[1];
+                    $node = $this->createMock($nodes[$uri]);
+                    $node->method('getOwner')
+                        ->willReturn("principals/users/$owner");
+                    return $node;
+                }
+                throw new NotFound('Node not found');
+            });
+
+        $this->insertProps($user, "principals/users/$user", $existingProps);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind("principals/users/$user", $propFind);
+        $this->assertEquals($returnedProps, $setProps);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
+    public function testPropPatch(string $path, array $existing, array $props, array $result): void {
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/' . $this->user->getUID());
+                return $node;
+            });
+
+        $this->insertProps($this->user->getUID(), $path, $existing);
+        $propPatch = new PropPatch($props);
+
+        $this->backend->propPatch($path, $propPatch);
+        $propPatch->commit();
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals($result, $storedProps);
+    }
+
+    public static function propPatchProvider(): array {
+        $longPath = str_repeat('long_path', 100);
+        return [
+            ['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
+            [$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+        ];
+    }
+
+    public function testPropPatchWithUnsuitableCalendar(): void {
+        $path = 'principals/users/' . $this->user->getUID();
+
+        $node = $this->createMock(Calendar::class);
+        $node->expects(self::once())
+            ->method('getOwner')
+            ->willReturn($path);
+
+        $this->defaultCalendarValidator->expects(self::once())
+            ->method('validateScheduleDefaultCalendar')
+            ->with($node)
+            ->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->with('foo/bar/')
+            ->willReturn($node);
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+
+        $propPatch = new PropPatch([
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
+        ]);
+        $this->backend->propPatch($path, $propPatch);
+        try {
+            $propPatch->commit();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
+        }
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('deleteProvider')]
+    public function testDelete(string $path): void {
+        $this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
+        $this->backend->delete($path);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $path));
+    }
+
+    public static function deleteProvider(): array {
+        return [
+            ['foo_bar_path_1337'],
+            [str_repeat('long_path', 100)]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('moveProvider')]
+    public function testMove(string $source, string $target): void {
+        $this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
+        $this->backend->move($source, $target);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $source));
+        $this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
+    }
+
+    public static function moveProvider(): array {
+        return [
+            ['foo_bar_path_1337', 'foo_bar_path_7333'],
+            [str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
+        ];
+    }
+
+    public function testDecodeValueFromDatabaseObjectCurrent(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
+
+    public function testDecodeValueFromDatabaseObjectLegacy(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
 }

Spacing +18 added lines, -18 removed lines

@@ -112,7 +112,7 @@ 
 		$data = [];
 		while ($row = $result->fetch()) {
 			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+			if ((int) $row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
 				$value = new Href($value);
 			}
 			$data[$row['propertyname']] = $value;
@@ -183,7 +183,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -193,7 +193,7 @@ 
 
 	public function testPropFindPrincipalCall(): void {
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
 					->willReturn('principals/users/dummy_user_42');
@@ -228,7 +228,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -239,28 +239,28 @@ 
 	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
 		// [ user, nodes, existingProps, requestedProps, returnedProps ]
 		return [
-			[ // Exists
+			[// Exists
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 			],
-			[ // Doesn't exist
+			[// Doesn't exist
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // No privilege
+			[// No privilege
 				'dummy_user_42',
 				['calendars/user2/baz/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // Not a calendar
+			[// Not a calendar
 				'dummy_user_42',
 				['foo/dummy_user_42/bar/' => IACL::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
@@ -300,14 +300,14 @@ 
 			));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (!str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
+			->willReturnCallback(function($uri) use ($nodes) {
 				if (str_starts_with($uri, 'principals/')) {
 					return $this->createMock(IPrincipal::class);
 				}
@@ -325,7 +325,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -336,17 +336,17 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
 	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
+					->willReturn('principals/users/'.$this->user->getUID());
 				return $node;
 			});
 
@@ -368,12 +368,12 @@ 
 			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
 			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
 			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI.'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
 		];
 	}
 
 	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
+		$path = 'principals/users/'.$this->user->getUID();
 
 		$node = $this->createMock(Calendar::class);
 		$node->expects(self::once())
@@ -386,7 +386,7 @@ 
 			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
@@ -452,7 +452,7 @@ 
 	}
 
 	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"'.chr(0).'*'.chr(0).'value";s:6:"opaque";}';
 		$propertyType = 3;
 		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
 		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);

apps/dav/tests/unit/DAV/ViewOnlyPluginTest.php

Indentation +136 added lines, -136 removed lines

@@ -28,140 +28,140 @@
 use Test\TestCase;
 
 class ViewOnlyPluginTest extends TestCase {
-	private Tree&MockObject $tree;
-	private RequestInterface&MockObject $request;
-	private Folder&MockObject $userFolder;
-	private ViewOnlyPlugin $plugin;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->tree = $this->createMock(Tree::class);
-		$server = $this->createMock(Server::class);
-
-		$this->plugin = new ViewOnlyPlugin(
-			$this->userFolder,
-		);
-		$server->tree = $this->tree;
-
-		$this->plugin->initialize($server);
-	}
-
-	public function testCanGetNonDav(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$this->tree->method('getNodeForPath')->willReturn(null);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public function testCanGetNonShared(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$davNode = $this->createMock(DavFile::class);
-		$this->tree->method('getNodeForPath')->willReturn($davNode);
-
-		$file = $this->createMock(File::class);
-		$davNode->method('getNode')->willReturn($file);
-
-		$storage = $this->createMock(IStorage::class);
-		$file->method('getStorage')->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public static function providesDataForCanGet(): array {
-		return [
-			// has attribute permissions-download enabled - can get file
-			[false, true, true, true],
-			// has no attribute permissions-download - can get file
-			[false, null, true, true],
-			// has attribute permissions-download enabled - can get file version
-			[true, true, true, true],
-			// has no attribute permissions-download - can get file version
-			[true, null, true, true],
-			// has attribute permissions-download disabled - cannot get the file
-			[false, false, false, false],
-			// has attribute permissions-download disabled - cannot get the file version
-			[true, false, false, false],
-
-			// Has global allowViewWithoutDownload option enabled
-			// has attribute permissions-download disabled - can get file
-			[false, false, false, true],
-			// has attribute permissions-download disabled - can get file version
-			[true, false, false, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanGet')]
-	public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile, bool $allowViewWithoutDownload): void {
-		$nodeInfo = $this->createMock(File::class);
-		if ($isVersion) {
-			$davPath = 'versions/alice/versions/117/123456';
-			$version = $this->createMock(IVersion::class);
-			$version->expects($this->once())
-				->method('getSourceFile')
-				->willReturn($nodeInfo);
-			$davNode = $this->createMock(VersionFile::class);
-			$davNode->expects($this->once())
-				->method('getVersion')
-				->willReturn($version);
-
-			$currentUser = $this->createMock(IUser::class);
-			$currentUser->expects($this->once())
-				->method('getUID')
-				->willReturn('alice');
-			$nodeInfo->expects($this->once())
-				->method('getOwner')
-				->willReturn($currentUser);
-
-			$nodeInfo = $this->createMock(File::class);
-			$owner = $this->createMock(IUser::class);
-			$owner->expects($this->once())
-				->method('getUID')
-				->willReturn('bob');
-			$this->userFolder->expects($this->once())
-				->method('getById')
-				->willReturn([$nodeInfo]);
-			$this->userFolder->expects($this->once())
-				->method('getOwner')
-				->willReturn($owner);
-		} else {
-			$davPath = 'files/path/to/file.odt';
-			$davNode = $this->createMock(DavFile::class);
-			$davNode->method('getNode')->willReturn($nodeInfo);
-		}
-
-		$this->request->expects($this->once())->method('getPath')->willReturn($davPath);
-
-		$this->tree->expects($this->once())
-			->method('getNodeForPath')
-			->with($davPath)
-			->willReturn($davNode);
-
-		$storage = $this->createMock(SharedStorage::class);
-		$share = $this->createMock(IShare::class);
-		$nodeInfo->expects($this->once())
-			->method('getStorage')
-			->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
-		$storage->method('getShare')->willReturn($share);
-
-		$extAttr = $this->createMock(IAttributes::class);
-		$share->method('getAttributes')->willReturn($extAttr);
-		$extAttr->expects($this->once())
-			->method('getAttribute')
-			->with('permissions', 'download')
-			->willReturn($attrEnabled);
-
-		$share->expects($this->once())
-			->method('canSeeContent')
-			->willReturn($allowViewWithoutDownload);
-
-		if (!$expectCanDownloadFile) {
-			$this->expectException(Forbidden::class);
-		}
-		$this->plugin->checkViewOnly($this->request);
-	}
+    private Tree&MockObject $tree;
+    private RequestInterface&MockObject $request;
+    private Folder&MockObject $userFolder;
+    private ViewOnlyPlugin $plugin;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->tree = $this->createMock(Tree::class);
+        $server = $this->createMock(Server::class);
+
+        $this->plugin = new ViewOnlyPlugin(
+            $this->userFolder,
+        );
+        $server->tree = $this->tree;
+
+        $this->plugin->initialize($server);
+    }
+
+    public function testCanGetNonDav(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $this->tree->method('getNodeForPath')->willReturn(null);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public function testCanGetNonShared(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $davNode = $this->createMock(DavFile::class);
+        $this->tree->method('getNodeForPath')->willReturn($davNode);
+
+        $file = $this->createMock(File::class);
+        $davNode->method('getNode')->willReturn($file);
+
+        $storage = $this->createMock(IStorage::class);
+        $file->method('getStorage')->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public static function providesDataForCanGet(): array {
+        return [
+            // has attribute permissions-download enabled - can get file
+            [false, true, true, true],
+            // has no attribute permissions-download - can get file
+            [false, null, true, true],
+            // has attribute permissions-download enabled - can get file version
+            [true, true, true, true],
+            // has no attribute permissions-download - can get file version
+            [true, null, true, true],
+            // has attribute permissions-download disabled - cannot get the file
+            [false, false, false, false],
+            // has attribute permissions-download disabled - cannot get the file version
+            [true, false, false, false],
+
+            // Has global allowViewWithoutDownload option enabled
+            // has attribute permissions-download disabled - can get file
+            [false, false, false, true],
+            // has attribute permissions-download disabled - can get file version
+            [true, false, false, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesDataForCanGet')]
+    public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile, bool $allowViewWithoutDownload): void {
+        $nodeInfo = $this->createMock(File::class);
+        if ($isVersion) {
+            $davPath = 'versions/alice/versions/117/123456';
+            $version = $this->createMock(IVersion::class);
+            $version->expects($this->once())
+                ->method('getSourceFile')
+                ->willReturn($nodeInfo);
+            $davNode = $this->createMock(VersionFile::class);
+            $davNode->expects($this->once())
+                ->method('getVersion')
+                ->willReturn($version);
+
+            $currentUser = $this->createMock(IUser::class);
+            $currentUser->expects($this->once())
+                ->method('getUID')
+                ->willReturn('alice');
+            $nodeInfo->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($currentUser);
+
+            $nodeInfo = $this->createMock(File::class);
+            $owner = $this->createMock(IUser::class);
+            $owner->expects($this->once())
+                ->method('getUID')
+                ->willReturn('bob');
+            $this->userFolder->expects($this->once())
+                ->method('getById')
+                ->willReturn([$nodeInfo]);
+            $this->userFolder->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($owner);
+        } else {
+            $davPath = 'files/path/to/file.odt';
+            $davNode = $this->createMock(DavFile::class);
+            $davNode->method('getNode')->willReturn($nodeInfo);
+        }
+
+        $this->request->expects($this->once())->method('getPath')->willReturn($davPath);
+
+        $this->tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with($davPath)
+            ->willReturn($davNode);
+
+        $storage = $this->createMock(SharedStorage::class);
+        $share = $this->createMock(IShare::class);
+        $nodeInfo->expects($this->once())
+            ->method('getStorage')
+            ->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
+        $storage->method('getShare')->willReturn($share);
+
+        $extAttr = $this->createMock(IAttributes::class);
+        $share->method('getAttributes')->willReturn($extAttr);
+        $extAttr->expects($this->once())
+            ->method('getAttribute')
+            ->with('permissions', 'download')
+            ->willReturn($attrEnabled);
+
+        $share->expects($this->once())
+            ->method('canSeeContent')
+            ->willReturn($allowViewWithoutDownload);
+
+        if (!$expectCanDownloadFile) {
+            $this->expectException(Forbidden::class);
+        }
+        $this->plugin->checkViewOnly($this->request);
+    }
 }

apps/dav/tests/unit/DAV/SystemPrincipalBackendTest.php

Indentation +72 added lines, -72 removed lines

@@ -14,87 +14,87 @@
 
 class SystemPrincipalBackendTest extends TestCase {
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesPrefix')]
-	public function testGetPrincipalsByPrefix(array $expected, string $prefix): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getPrincipalsByPrefix($prefix);
-		$this->assertEquals($expected, $result);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesPrefix')]
+    public function testGetPrincipalsByPrefix(array $expected, string $prefix): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getPrincipalsByPrefix($prefix);
+        $this->assertEquals($expected, $result);
+    }
 
-	public static function providesPrefix(): array {
-		return [
-			[[], ''],
-			[[[
-				'uri' => 'principals/system/system',
-				'{DAV:}displayname' => 'system',
-			],
-				[
-					'uri' => 'principals/system/public',
-					'{DAV:}displayname' => 'public',
-				]
-			], 'principals/system'],
-		];
-	}
+    public static function providesPrefix(): array {
+        return [
+            [[], ''],
+            [[[
+                'uri' => 'principals/system/system',
+                '{DAV:}displayname' => 'system',
+            ],
+                [
+                    'uri' => 'principals/system/public',
+                    '{DAV:}displayname' => 'public',
+                ]
+            ], 'principals/system'],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesPath')]
-	public function testGetPrincipalByPath(?array $expected, string $path): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getPrincipalByPath($path);
-		$this->assertEquals($expected, $result);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesPath')]
+    public function testGetPrincipalByPath(?array $expected, string $path): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getPrincipalByPath($path);
+        $this->assertEquals($expected, $result);
+    }
 
-	public static function providesPath(): array {
-		return [
-			[null, ''],
-			[null, 'principals'],
-			[null, 'principals/system'],
-			[[
-				'uri' => 'principals/system/system',
-				'{DAV:}displayname' => 'system',
-			], 'principals/system/system'],
-		];
-	}
+    public static function providesPath(): array {
+        return [
+            [null, ''],
+            [null, 'principals'],
+            [null, 'principals/system'],
+            [[
+                'uri' => 'principals/system/system',
+                '{DAV:}displayname' => 'system',
+            ], 'principals/system/system'],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesPrincipalForGetGroupMemberSet')]
-	public function testGetGroupMemberSetExceptional(?string $principal): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesPrincipalForGetGroupMemberSet')]
+    public function testGetGroupMemberSetExceptional(?string $principal): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
 
-		$backend = new SystemPrincipalBackend();
-		$backend->getGroupMemberSet($principal);
-	}
+        $backend = new SystemPrincipalBackend();
+        $backend->getGroupMemberSet($principal);
+    }
 
-	public static function providesPrincipalForGetGroupMemberSet(): array {
-		return [
-			[null],
-			['principals/system'],
-		];
-	}
+    public static function providesPrincipalForGetGroupMemberSet(): array {
+        return [
+            [null],
+            ['principals/system'],
+        ];
+    }
 
-	public function testGetGroupMemberSet(): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getGroupMemberSet('principals/system/system');
-		$this->assertEquals(['principals/system/system'], $result);
-	}
+    public function testGetGroupMemberSet(): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getGroupMemberSet('principals/system/system');
+        $this->assertEquals(['principals/system/system'], $result);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesPrincipalForGetGroupMembership')]
-	public function testGetGroupMembershipExceptional(string $principal): void {
-		$this->expectException(Exception::class);
-		$this->expectExceptionMessage('Principal not found');
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesPrincipalForGetGroupMembership')]
+    public function testGetGroupMembershipExceptional(string $principal): void {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Principal not found');
 
-		$backend = new SystemPrincipalBackend();
-		$backend->getGroupMembership($principal);
-	}
+        $backend = new SystemPrincipalBackend();
+        $backend->getGroupMembership($principal);
+    }
 
-	public static function providesPrincipalForGetGroupMembership(): array {
-		return [
-			['principals/system/a'],
-		];
-	}
+    public static function providesPrincipalForGetGroupMembership(): array {
+        return [
+            ['principals/system/a'],
+        ];
+    }
 
-	public function testGetGroupMembership(): void {
-		$backend = new SystemPrincipalBackend();
-		$result = $backend->getGroupMembership('principals/system/system');
-		$this->assertEquals([], $result);
-	}
+    public function testGetGroupMembership(): void {
+        $backend = new SystemPrincipalBackend();
+        $result = $backend->getGroupMembership('principals/system/system');
+        $this->assertEquals([], $result);
+    }
 }

apps/dav/tests/unit/Search/EventsSearchProviderTest.php

Indentation +424 added lines, -424 removed lines

@@ -23,428 +23,428 @@
 use Test\TestCase;
 
 class EventsSearchProviderTest extends TestCase {
-	private IAppManager&MockObject $appManager;
-	private IL10N&MockObject $l10n;
-	private IURLGenerator&MockObject $urlGenerator;
-	private CalDavBackend&MockObject $backend;
-	private EventsSearchProvider $provider;
-
-	// NO SUMMARY
-	private static string $vEvent0 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20161004T144433Z' . PHP_EOL
-		. 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
-		. 'DTEND;VALUE=DATE:20161008' . PHP_EOL
-		. 'TRANSP:TRANSPARENT' . PHP_EOL
-		. 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
-		. 'DTSTAMP:20161004T144437Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// TIMED SAME DAY
-	private static string $vEvent1 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Tests//' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VTIMEZONE' . PHP_EOL
-		. 'TZID:Europe/Berlin' . PHP_EOL
-		. 'BEGIN:DAYLIGHT' . PHP_EOL
-		. 'TZOFFSETFROM:+0100' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19810329T020000' . PHP_EOL
-		. 'TZNAME:GMT+2' . PHP_EOL
-		. 'TZOFFSETTO:+0200' . PHP_EOL
-		. 'END:DAYLIGHT' . PHP_EOL
-		. 'BEGIN:STANDARD' . PHP_EOL
-		. 'TZOFFSETFROM:+0200' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19961027T030000' . PHP_EOL
-		. 'TZNAME:GMT+1' . PHP_EOL
-		. 'TZOFFSETTO:+0100' . PHP_EOL
-		. 'END:STANDARD' . PHP_EOL
-		. 'END:VTIMEZONE' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20160809T163629Z' . PHP_EOL
-		. 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
-		. 'DTEND;TZID=Europe/Berlin:20160816T100000' . PHP_EOL
-		. 'TRANSP:OPAQUE' . PHP_EOL
-		. 'SUMMARY:Test Europe Berlin' . PHP_EOL
-		. 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
-		. 'DTSTAMP:20160809T163632Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// TIMED DIFFERENT DAY
-	private static string $vEvent2 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Tests//' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VTIMEZONE' . PHP_EOL
-		. 'TZID:Europe/Berlin' . PHP_EOL
-		. 'BEGIN:DAYLIGHT' . PHP_EOL
-		. 'TZOFFSETFROM:+0100' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19810329T020000' . PHP_EOL
-		. 'TZNAME:GMT+2' . PHP_EOL
-		. 'TZOFFSETTO:+0200' . PHP_EOL
-		. 'END:DAYLIGHT' . PHP_EOL
-		. 'BEGIN:STANDARD' . PHP_EOL
-		. 'TZOFFSETFROM:+0200' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19961027T030000' . PHP_EOL
-		. 'TZNAME:GMT+1' . PHP_EOL
-		. 'TZOFFSETTO:+0100' . PHP_EOL
-		. 'END:STANDARD' . PHP_EOL
-		. 'END:VTIMEZONE' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20160809T163629Z' . PHP_EOL
-		. 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
-		. 'DTEND;TZID=Europe/Berlin:20160817T100000' . PHP_EOL
-		. 'TRANSP:OPAQUE' . PHP_EOL
-		. 'SUMMARY:Test Europe Berlin' . PHP_EOL
-		. 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
-		. 'DTSTAMP:20160809T163632Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// ALL-DAY ONE-DAY
-	private static string $vEvent3 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20161004T144433Z' . PHP_EOL
-		. 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
-		. 'DTEND;VALUE=DATE:20161006' . PHP_EOL
-		. 'TRANSP:TRANSPARENT' . PHP_EOL
-		. 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
-		. 'DTSTAMP:20161004T144437Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// ALL-DAY MULTIPLE DAYS
-	private static string $vEvent4 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20161004T144433Z' . PHP_EOL
-		. 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
-		. 'DTEND;VALUE=DATE:20161008' . PHP_EOL
-		. 'TRANSP:TRANSPARENT' . PHP_EOL
-		. 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
-		. 'DTSTAMP:20161004T144437Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// DURATION
-	private static string $vEvent5 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20161004T144433Z' . PHP_EOL
-		. 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
-		. 'DURATION:P5D' . PHP_EOL
-		. 'TRANSP:TRANSPARENT' . PHP_EOL
-		. 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
-		. 'DTSTAMP:20161004T144437Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// NO DTEND - DATE
-	private static string $vEvent6 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20161004T144433Z' . PHP_EOL
-		. 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
-		. 'TRANSP:TRANSPARENT' . PHP_EOL
-		. 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
-		. 'DTSTAMP:20161004T144437Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// NO DTEND - DATE-TIME
-	private static string $vEvent7 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'PRODID:-//Tests//' . PHP_EOL
-		. 'CALSCALE:GREGORIAN' . PHP_EOL
-		. 'BEGIN:VTIMEZONE' . PHP_EOL
-		. 'TZID:Europe/Berlin' . PHP_EOL
-		. 'BEGIN:DAYLIGHT' . PHP_EOL
-		. 'TZOFFSETFROM:+0100' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19810329T020000' . PHP_EOL
-		. 'TZNAME:GMT+2' . PHP_EOL
-		. 'TZOFFSETTO:+0200' . PHP_EOL
-		. 'END:DAYLIGHT' . PHP_EOL
-		. 'BEGIN:STANDARD' . PHP_EOL
-		. 'TZOFFSETFROM:+0200' . PHP_EOL
-		. 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
-		. 'DTSTART:19961027T030000' . PHP_EOL
-		. 'TZNAME:GMT+1' . PHP_EOL
-		. 'TZOFFSETTO:+0100' . PHP_EOL
-		. 'END:STANDARD' . PHP_EOL
-		. 'END:VTIMEZONE' . PHP_EOL
-		. 'BEGIN:VEVENT' . PHP_EOL
-		. 'CREATED:20160809T163629Z' . PHP_EOL
-		. 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
-		. 'TRANSP:OPAQUE' . PHP_EOL
-		. 'SUMMARY:Test Europe Berlin' . PHP_EOL
-		. 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
-		. 'DTSTAMP:20160809T163632Z' . PHP_EOL
-		. 'SEQUENCE:0' . PHP_EOL
-		. 'END:VEVENT' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->backend = $this->createMock(CalDavBackend::class);
-
-		$this->provider = new EventsSearchProvider(
-			$this->appManager,
-			$this->l10n,
-			$this->urlGenerator,
-			$this->backend
-		);
-	}
-
-	public function testGetId(): void {
-		$this->assertEquals('calendar', $this->provider->getId());
-	}
-
-	public function testGetName(): void {
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Events')
-			->willReturnArgument(0);
-
-		$this->assertEquals('Events', $this->provider->getName());
-	}
-
-	public function testSearchAppDisabled(): void {
-		$user = $this->createMock(IUser::class);
-		$query = $this->createMock(ISearchQuery::class);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('calendar', $user)
-			->willReturn(false);
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->willReturnArgument(0);
-		$this->backend->expects($this->never())
-			->method('getCalendarsForUser');
-		$this->backend->expects($this->never())
-			->method('getSubscriptionsForUser');
-		$this->backend->expects($this->never())
-			->method('searchPrincipalUri');
-
-		$actual = $this->provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Events', $data['name']);
-		$this->assertEmpty($data['entries']);
-		$this->assertFalse($data['isPaginated']);
-		$this->assertNull($data['cursor']);
-	}
-
-	public function testSearch(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('john.doe');
-		$query = $this->createMock(ISearchQuery::class);
-		$seachTermFilter = $this->createMock(IFilter::class);
-		$query->method('getFilter')->willReturnCallback(function ($name) use ($seachTermFilter) {
-			return match ($name) {
-				'term' => $seachTermFilter,
-				default => null,
-			};
-		});
-		$seachTermFilter->method('get')->willReturn('search term');
-		$query->method('getLimit')->willReturn(5);
-		$query->method('getCursor')->willReturn(20);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('calendar', $user)
-			->willReturn(true);
-		$this->l10n->method('t')->willReturnArgument(0);
-
-		$this->backend->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 99,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-99',
-				], [
-					'id' => 123,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-123',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 1337,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'subscription-uri-1337',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('searchPrincipalUri')
-			->with('principals/users/john.doe', 'search term', ['VEVENT'],
-				['SUMMARY', 'LOCATION', 'DESCRIPTION', 'ATTENDEE', 'ORGANIZER', 'CATEGORIES'],
-				['ATTENDEE' => ['CN'], 'ORGANIZER' => ['CN']],
-				['limit' => 5, 'offset' => 20, 'timerange' => ['start' => null, 'end' => null]])
-			->willReturn([
-				[
-					'calendarid' => 99,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'event0.ics',
-					'calendardata' => self::$vEvent0,
-				],
-				[
-					'calendarid' => 123,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'event1.ics',
-					'calendardata' => self::$vEvent1,
-				],
-				[
-					'calendarid' => 1337,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
-					'uri' => 'event2.ics',
-					'calendardata' => self::$vEvent2,
-				]
-			]);
-
-		$provider = $this->getMockBuilder(EventsSearchProvider::class)
-			->setConstructorArgs([
-				$this->appManager,
-				$this->l10n,
-				$this->urlGenerator,
-				$this->backend,
-			])
-			->onlyMethods([
-				'getDeepLinkToCalendarApp',
-				'generateSubline',
-			])
-			->getMock();
-
-		$provider->expects($this->exactly(3))
-			->method('generateSubline')
-			->willReturn('subline');
-		$provider->expects($this->exactly(3))
-			->method('getDeepLinkToCalendarApp')
-			->willReturnMap([
-				['principals/users/john.doe', 'calendar-uri-99', 'event0.ics', 'deep-link-to-calendar'],
-				['principals/users/john.doe', 'calendar-uri-123', 'event1.ics', 'deep-link-to-calendar'],
-				['principals/users/john.doe', 'subscription-uri-1337', 'event2.ics', 'deep-link-to-calendar']
-			]);
-
-		$actual = $provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Events', $data['name']);
-		$this->assertCount(3, $data['entries']);
-		$this->assertTrue($data['isPaginated']);
-		$this->assertEquals(23, $data['cursor']);
-
-		$result0 = $data['entries'][0];
-		$result0Data = $result0->jsonSerialize();
-		$result1 = $data['entries'][1];
-		$result1Data = $result1->jsonSerialize();
-		$result2 = $data['entries'][2];
-		$result2Data = $result2->jsonSerialize();
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result0);
-		$this->assertEmpty($result0Data['thumbnailUrl']);
-		$this->assertEquals('Untitled event', $result0Data['title']);
-		$this->assertEquals('subline', $result0Data['subline']);
-		$this->assertEquals('deep-link-to-calendar', $result0Data['resourceUrl']);
-		$this->assertEquals('icon-calendar-dark', $result0Data['icon']);
-		$this->assertFalse($result0Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result1);
-		$this->assertEmpty($result1Data['thumbnailUrl']);
-		$this->assertEquals('Test Europe Berlin', $result1Data['title']);
-		$this->assertEquals('subline', $result1Data['subline']);
-		$this->assertEquals('deep-link-to-calendar', $result1Data['resourceUrl']);
-		$this->assertEquals('icon-calendar-dark', $result1Data['icon']);
-		$this->assertFalse($result1Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result2);
-		$this->assertEmpty($result2Data['thumbnailUrl']);
-		$this->assertEquals('Test Europe Berlin', $result2Data['title']);
-		$this->assertEquals('subline', $result2Data['subline']);
-		$this->assertEquals('deep-link-to-calendar', $result2Data['resourceUrl']);
-		$this->assertEquals('icon-calendar-dark', $result2Data['icon']);
-		$this->assertFalse($result2Data['rounded']);
-	}
-
-	public function testGetDeepLinkToCalendarApp(): void {
-		$this->urlGenerator->expects($this->once())
-			->method('linkTo')
-			->with('', 'remote.php')
-			->willReturn('link-to-remote.php');
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with('calendar.view.index')
-			->willReturn('link-to-route-calendar/');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('link-to-route-calendar/edit/bGluay10by1yZW1vdGUucGhwL2Rhdi9jYWxlbmRhcnMvam9obi5kb2UvZm9vL2Jhci5pY3M=')
-			->willReturn('absolute-url-to-route');
-
-		$actual = self::invokePrivate($this->provider, 'getDeepLinkToCalendarApp', ['principals/users/john.doe', 'foo', 'bar.ics']);
-
-		$this->assertEquals('absolute-url-to-route', $actual);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('generateSublineDataProvider')]
-	public function testGenerateSubline(string $ics, string $expectedSubline): void {
-		$vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
-		$eventComponent = $vCalendar->VEVENT;
-
-		$this->l10n->method('l')
-			->willReturnCallback(static function (string $type, \DateTime $date, $_):string {
-				if ($type === 'time') {
-					return $date->format('H:i');
-				}
-
-				return $date->format('m-d');
-			});
-
-		$actual = self::invokePrivate($this->provider, 'generateSubline', [$eventComponent]);
-		$this->assertEquals($expectedSubline, $actual);
-	}
-
-	public static function generateSublineDataProvider(): array {
-		return [
-			[self::$vEvent1, '08-16 09:00 - 10:00'],
-			[self::$vEvent2, '08-16 09:00 - 08-17 10:00'],
-			[self::$vEvent3, '10-05'],
-			[self::$vEvent4, '10-05 - 10-07'],
-			[self::$vEvent5, '10-05 - 10-09'],
-			[self::$vEvent6, '10-05'],
-			[self::$vEvent7, '08-16 09:00 - 09:00'],
-		];
-	}
+    private IAppManager&MockObject $appManager;
+    private IL10N&MockObject $l10n;
+    private IURLGenerator&MockObject $urlGenerator;
+    private CalDavBackend&MockObject $backend;
+    private EventsSearchProvider $provider;
+
+    // NO SUMMARY
+    private static string $vEvent0 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20161004T144433Z' . PHP_EOL
+        . 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
+        . 'DTEND;VALUE=DATE:20161008' . PHP_EOL
+        . 'TRANSP:TRANSPARENT' . PHP_EOL
+        . 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
+        . 'DTSTAMP:20161004T144437Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // TIMED SAME DAY
+    private static string $vEvent1 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Tests//' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VTIMEZONE' . PHP_EOL
+        . 'TZID:Europe/Berlin' . PHP_EOL
+        . 'BEGIN:DAYLIGHT' . PHP_EOL
+        . 'TZOFFSETFROM:+0100' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19810329T020000' . PHP_EOL
+        . 'TZNAME:GMT+2' . PHP_EOL
+        . 'TZOFFSETTO:+0200' . PHP_EOL
+        . 'END:DAYLIGHT' . PHP_EOL
+        . 'BEGIN:STANDARD' . PHP_EOL
+        . 'TZOFFSETFROM:+0200' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19961027T030000' . PHP_EOL
+        . 'TZNAME:GMT+1' . PHP_EOL
+        . 'TZOFFSETTO:+0100' . PHP_EOL
+        . 'END:STANDARD' . PHP_EOL
+        . 'END:VTIMEZONE' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20160809T163629Z' . PHP_EOL
+        . 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
+        . 'DTEND;TZID=Europe/Berlin:20160816T100000' . PHP_EOL
+        . 'TRANSP:OPAQUE' . PHP_EOL
+        . 'SUMMARY:Test Europe Berlin' . PHP_EOL
+        . 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
+        . 'DTSTAMP:20160809T163632Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // TIMED DIFFERENT DAY
+    private static string $vEvent2 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Tests//' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VTIMEZONE' . PHP_EOL
+        . 'TZID:Europe/Berlin' . PHP_EOL
+        . 'BEGIN:DAYLIGHT' . PHP_EOL
+        . 'TZOFFSETFROM:+0100' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19810329T020000' . PHP_EOL
+        . 'TZNAME:GMT+2' . PHP_EOL
+        . 'TZOFFSETTO:+0200' . PHP_EOL
+        . 'END:DAYLIGHT' . PHP_EOL
+        . 'BEGIN:STANDARD' . PHP_EOL
+        . 'TZOFFSETFROM:+0200' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19961027T030000' . PHP_EOL
+        . 'TZNAME:GMT+1' . PHP_EOL
+        . 'TZOFFSETTO:+0100' . PHP_EOL
+        . 'END:STANDARD' . PHP_EOL
+        . 'END:VTIMEZONE' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20160809T163629Z' . PHP_EOL
+        . 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
+        . 'DTEND;TZID=Europe/Berlin:20160817T100000' . PHP_EOL
+        . 'TRANSP:OPAQUE' . PHP_EOL
+        . 'SUMMARY:Test Europe Berlin' . PHP_EOL
+        . 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
+        . 'DTSTAMP:20160809T163632Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // ALL-DAY ONE-DAY
+    private static string $vEvent3 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20161004T144433Z' . PHP_EOL
+        . 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
+        . 'DTEND;VALUE=DATE:20161006' . PHP_EOL
+        . 'TRANSP:TRANSPARENT' . PHP_EOL
+        . 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
+        . 'DTSTAMP:20161004T144437Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // ALL-DAY MULTIPLE DAYS
+    private static string $vEvent4 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20161004T144433Z' . PHP_EOL
+        . 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
+        . 'DTEND;VALUE=DATE:20161008' . PHP_EOL
+        . 'TRANSP:TRANSPARENT' . PHP_EOL
+        . 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
+        . 'DTSTAMP:20161004T144437Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // DURATION
+    private static string $vEvent5 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20161004T144433Z' . PHP_EOL
+        . 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
+        . 'DURATION:P5D' . PHP_EOL
+        . 'TRANSP:TRANSPARENT' . PHP_EOL
+        . 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
+        . 'DTSTAMP:20161004T144437Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // NO DTEND - DATE
+    private static string $vEvent6 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Apple Inc.//Mac OS X 10.11.6//EN' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20161004T144433Z' . PHP_EOL
+        . 'UID:85560E76-1B0D-47E1-A735-21625767FCA4' . PHP_EOL
+        . 'TRANSP:TRANSPARENT' . PHP_EOL
+        . 'DTSTART;VALUE=DATE:20161005' . PHP_EOL
+        . 'DTSTAMP:20161004T144437Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // NO DTEND - DATE-TIME
+    private static string $vEvent7 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'PRODID:-//Tests//' . PHP_EOL
+        . 'CALSCALE:GREGORIAN' . PHP_EOL
+        . 'BEGIN:VTIMEZONE' . PHP_EOL
+        . 'TZID:Europe/Berlin' . PHP_EOL
+        . 'BEGIN:DAYLIGHT' . PHP_EOL
+        . 'TZOFFSETFROM:+0100' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19810329T020000' . PHP_EOL
+        . 'TZNAME:GMT+2' . PHP_EOL
+        . 'TZOFFSETTO:+0200' . PHP_EOL
+        . 'END:DAYLIGHT' . PHP_EOL
+        . 'BEGIN:STANDARD' . PHP_EOL
+        . 'TZOFFSETFROM:+0200' . PHP_EOL
+        . 'RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU' . PHP_EOL
+        . 'DTSTART:19961027T030000' . PHP_EOL
+        . 'TZNAME:GMT+1' . PHP_EOL
+        . 'TZOFFSETTO:+0100' . PHP_EOL
+        . 'END:STANDARD' . PHP_EOL
+        . 'END:VTIMEZONE' . PHP_EOL
+        . 'BEGIN:VEVENT' . PHP_EOL
+        . 'CREATED:20160809T163629Z' . PHP_EOL
+        . 'UID:0AD16F58-01B3-463B-A215-FD09FC729A02' . PHP_EOL
+        . 'TRANSP:OPAQUE' . PHP_EOL
+        . 'SUMMARY:Test Europe Berlin' . PHP_EOL
+        . 'DTSTART;TZID=Europe/Berlin:20160816T090000' . PHP_EOL
+        . 'DTSTAMP:20160809T163632Z' . PHP_EOL
+        . 'SEQUENCE:0' . PHP_EOL
+        . 'END:VEVENT' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->backend = $this->createMock(CalDavBackend::class);
+
+        $this->provider = new EventsSearchProvider(
+            $this->appManager,
+            $this->l10n,
+            $this->urlGenerator,
+            $this->backend
+        );
+    }
+
+    public function testGetId(): void {
+        $this->assertEquals('calendar', $this->provider->getId());
+    }
+
+    public function testGetName(): void {
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Events')
+            ->willReturnArgument(0);
+
+        $this->assertEquals('Events', $this->provider->getName());
+    }
+
+    public function testSearchAppDisabled(): void {
+        $user = $this->createMock(IUser::class);
+        $query = $this->createMock(ISearchQuery::class);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('calendar', $user)
+            ->willReturn(false);
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->willReturnArgument(0);
+        $this->backend->expects($this->never())
+            ->method('getCalendarsForUser');
+        $this->backend->expects($this->never())
+            ->method('getSubscriptionsForUser');
+        $this->backend->expects($this->never())
+            ->method('searchPrincipalUri');
+
+        $actual = $this->provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Events', $data['name']);
+        $this->assertEmpty($data['entries']);
+        $this->assertFalse($data['isPaginated']);
+        $this->assertNull($data['cursor']);
+    }
+
+    public function testSearch(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('john.doe');
+        $query = $this->createMock(ISearchQuery::class);
+        $seachTermFilter = $this->createMock(IFilter::class);
+        $query->method('getFilter')->willReturnCallback(function ($name) use ($seachTermFilter) {
+            return match ($name) {
+                'term' => $seachTermFilter,
+                default => null,
+            };
+        });
+        $seachTermFilter->method('get')->willReturn('search term');
+        $query->method('getLimit')->willReturn(5);
+        $query->method('getCursor')->willReturn(20);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('calendar', $user)
+            ->willReturn(true);
+        $this->l10n->method('t')->willReturnArgument(0);
+
+        $this->backend->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-99',
+                ], [
+                    'id' => 123,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-123',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 1337,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'subscription-uri-1337',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('searchPrincipalUri')
+            ->with('principals/users/john.doe', 'search term', ['VEVENT'],
+                ['SUMMARY', 'LOCATION', 'DESCRIPTION', 'ATTENDEE', 'ORGANIZER', 'CATEGORIES'],
+                ['ATTENDEE' => ['CN'], 'ORGANIZER' => ['CN']],
+                ['limit' => 5, 'offset' => 20, 'timerange' => ['start' => null, 'end' => null]])
+            ->willReturn([
+                [
+                    'calendarid' => 99,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'event0.ics',
+                    'calendardata' => self::$vEvent0,
+                ],
+                [
+                    'calendarid' => 123,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'event1.ics',
+                    'calendardata' => self::$vEvent1,
+                ],
+                [
+                    'calendarid' => 1337,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
+                    'uri' => 'event2.ics',
+                    'calendardata' => self::$vEvent2,
+                ]
+            ]);
+
+        $provider = $this->getMockBuilder(EventsSearchProvider::class)
+            ->setConstructorArgs([
+                $this->appManager,
+                $this->l10n,
+                $this->urlGenerator,
+                $this->backend,
+            ])
+            ->onlyMethods([
+                'getDeepLinkToCalendarApp',
+                'generateSubline',
+            ])
+            ->getMock();
+
+        $provider->expects($this->exactly(3))
+            ->method('generateSubline')
+            ->willReturn('subline');
+        $provider->expects($this->exactly(3))
+            ->method('getDeepLinkToCalendarApp')
+            ->willReturnMap([
+                ['principals/users/john.doe', 'calendar-uri-99', 'event0.ics', 'deep-link-to-calendar'],
+                ['principals/users/john.doe', 'calendar-uri-123', 'event1.ics', 'deep-link-to-calendar'],
+                ['principals/users/john.doe', 'subscription-uri-1337', 'event2.ics', 'deep-link-to-calendar']
+            ]);
+
+        $actual = $provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Events', $data['name']);
+        $this->assertCount(3, $data['entries']);
+        $this->assertTrue($data['isPaginated']);
+        $this->assertEquals(23, $data['cursor']);
+
+        $result0 = $data['entries'][0];
+        $result0Data = $result0->jsonSerialize();
+        $result1 = $data['entries'][1];
+        $result1Data = $result1->jsonSerialize();
+        $result2 = $data['entries'][2];
+        $result2Data = $result2->jsonSerialize();
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result0);
+        $this->assertEmpty($result0Data['thumbnailUrl']);
+        $this->assertEquals('Untitled event', $result0Data['title']);
+        $this->assertEquals('subline', $result0Data['subline']);
+        $this->assertEquals('deep-link-to-calendar', $result0Data['resourceUrl']);
+        $this->assertEquals('icon-calendar-dark', $result0Data['icon']);
+        $this->assertFalse($result0Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result1);
+        $this->assertEmpty($result1Data['thumbnailUrl']);
+        $this->assertEquals('Test Europe Berlin', $result1Data['title']);
+        $this->assertEquals('subline', $result1Data['subline']);
+        $this->assertEquals('deep-link-to-calendar', $result1Data['resourceUrl']);
+        $this->assertEquals('icon-calendar-dark', $result1Data['icon']);
+        $this->assertFalse($result1Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result2);
+        $this->assertEmpty($result2Data['thumbnailUrl']);
+        $this->assertEquals('Test Europe Berlin', $result2Data['title']);
+        $this->assertEquals('subline', $result2Data['subline']);
+        $this->assertEquals('deep-link-to-calendar', $result2Data['resourceUrl']);
+        $this->assertEquals('icon-calendar-dark', $result2Data['icon']);
+        $this->assertFalse($result2Data['rounded']);
+    }
+
+    public function testGetDeepLinkToCalendarApp(): void {
+        $this->urlGenerator->expects($this->once())
+            ->method('linkTo')
+            ->with('', 'remote.php')
+            ->willReturn('link-to-remote.php');
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with('calendar.view.index')
+            ->willReturn('link-to-route-calendar/');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('link-to-route-calendar/edit/bGluay10by1yZW1vdGUucGhwL2Rhdi9jYWxlbmRhcnMvam9obi5kb2UvZm9vL2Jhci5pY3M=')
+            ->willReturn('absolute-url-to-route');
+
+        $actual = self::invokePrivate($this->provider, 'getDeepLinkToCalendarApp', ['principals/users/john.doe', 'foo', 'bar.ics']);
+
+        $this->assertEquals('absolute-url-to-route', $actual);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('generateSublineDataProvider')]
+    public function testGenerateSubline(string $ics, string $expectedSubline): void {
+        $vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
+        $eventComponent = $vCalendar->VEVENT;
+
+        $this->l10n->method('l')
+            ->willReturnCallback(static function (string $type, \DateTime $date, $_):string {
+                if ($type === 'time') {
+                    return $date->format('H:i');
+                }
+
+                return $date->format('m-d');
+            });
+
+        $actual = self::invokePrivate($this->provider, 'generateSubline', [$eventComponent]);
+        $this->assertEquals($expectedSubline, $actual);
+    }
+
+    public static function generateSublineDataProvider(): array {
+        return [
+            [self::$vEvent1, '08-16 09:00 - 10:00'],
+            [self::$vEvent2, '08-16 09:00 - 08-17 10:00'],
+            [self::$vEvent3, '10-05'],
+            [self::$vEvent4, '10-05 - 10-07'],
+            [self::$vEvent5, '10-05 - 10-09'],
+            [self::$vEvent6, '10-05'],
+            [self::$vEvent7, '08-16 09:00 - 09:00'],
+        ];
+    }
 }

apps/dav/tests/unit/Search/TasksSearchProviderTest.php

Indentation +288 added lines, -288 removed lines

@@ -22,292 +22,292 @@
 use Test\TestCase;
 
 class TasksSearchProviderTest extends TestCase {
-	private IAppManager&MockObject $appManager;
-	private IL10N&MockObject $l10n;
-	private IURLGenerator&MockObject $urlGenerator;
-	private CalDavBackend&MockObject $backend;
-	private TasksSearchProvider $provider;
-
-	// NO DUE NOR COMPLETED NOR SUMMARY
-	private static string $vTodo0 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'PRODID:TEST' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'BEGIN:VTODO' . PHP_EOL
-		. 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
-		. 'DTSTAMP:20070313T123432Z' . PHP_EOL
-		. 'STATUS:NEEDS-ACTION' . PHP_EOL
-		. 'END:VTODO' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// DUE AND COMPLETED
-	private static string $vTodo1 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'PRODID:TEST' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'BEGIN:VTODO' . PHP_EOL
-		. 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
-		. 'DTSTAMP:20070313T123432Z' . PHP_EOL
-		. 'COMPLETED:20070707T100000Z' . PHP_EOL
-		. 'DUE;VALUE=DATE:20070501' . PHP_EOL
-		. 'SUMMARY:Task title' . PHP_EOL
-		. 'STATUS:NEEDS-ACTION' . PHP_EOL
-		. 'END:VTODO' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// COMPLETED ONLY
-	private static string $vTodo2 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'PRODID:TEST' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'BEGIN:VTODO' . PHP_EOL
-		. 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
-		. 'DTSTAMP:20070313T123432Z' . PHP_EOL
-		. 'COMPLETED:20070707T100000Z' . PHP_EOL
-		. 'SUMMARY:Task title' . PHP_EOL
-		. 'STATUS:NEEDS-ACTION' . PHP_EOL
-		. 'END:VTODO' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// DUE DATE
-	private static string $vTodo3 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'PRODID:TEST' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'BEGIN:VTODO' . PHP_EOL
-		. 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
-		. 'DTSTAMP:20070313T123432Z' . PHP_EOL
-		. 'DUE;VALUE=DATE:20070501' . PHP_EOL
-		. 'SUMMARY:Task title' . PHP_EOL
-		. 'STATUS:NEEDS-ACTION' . PHP_EOL
-		. 'END:VTODO' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	// DUE DATETIME
-	private static string $vTodo4 = 'BEGIN:VCALENDAR' . PHP_EOL
-		. 'PRODID:TEST' . PHP_EOL
-		. 'VERSION:2.0' . PHP_EOL
-		. 'BEGIN:VTODO' . PHP_EOL
-		. 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
-		. 'DTSTAMP:20070313T123432Z' . PHP_EOL
-		. 'DUE:20070709T130000Z' . PHP_EOL
-		. 'SUMMARY:Task title' . PHP_EOL
-		. 'STATUS:NEEDS-ACTION' . PHP_EOL
-		. 'END:VTODO' . PHP_EOL
-		. 'END:VCALENDAR';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->backend = $this->createMock(CalDavBackend::class);
-
-		$this->provider = new TasksSearchProvider(
-			$this->appManager,
-			$this->l10n,
-			$this->urlGenerator,
-			$this->backend
-		);
-	}
-
-	public function testGetId(): void {
-		$this->assertEquals('tasks', $this->provider->getId());
-	}
-
-	public function testGetName(): void {
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->with('Tasks')
-			->willReturnArgument(0);
-
-		$this->assertEquals('Tasks', $this->provider->getName());
-	}
-
-	public function testSearchAppDisabled(): void {
-		$user = $this->createMock(IUser::class);
-		$query = $this->createMock(ISearchQuery::class);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('tasks', $user)
-			->willReturn(false);
-		$this->l10n->expects($this->exactly(1))
-			->method('t')
-			->willReturnArgument(0);
-		$this->backend->expects($this->never())
-			->method('getCalendarsForUser');
-		$this->backend->expects($this->never())
-			->method('getSubscriptionsForUser');
-		$this->backend->expects($this->never())
-			->method('searchPrincipalUri');
-
-		$actual = $this->provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Tasks', $data['name']);
-		$this->assertEmpty($data['entries']);
-		$this->assertFalse($data['isPaginated']);
-		$this->assertNull($data['cursor']);
-	}
-
-	public function testSearch(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('john.doe');
-		$query = $this->createMock(ISearchQuery::class);
-		$query->method('getTerm')->willReturn('search term');
-		$query->method('getLimit')->willReturn(5);
-		$query->method('getCursor')->willReturn(20);
-		$this->appManager->expects($this->once())
-			->method('isEnabledForUser')
-			->with('tasks', $user)
-			->willReturn(true);
-		$this->l10n->method('t')->willReturnArgument(0);
-
-		$this->backend->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 99,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-99',
-				], [
-					'id' => 123,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'calendar-uri-123',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('getSubscriptionsForUser')
-			->with('principals/users/john.doe')
-			->willReturn([
-				[
-					'id' => 1337,
-					'principaluri' => 'principals/users/john.doe',
-					'uri' => 'subscription-uri-1337',
-				]
-			]);
-		$this->backend->expects($this->once())
-			->method('searchPrincipalUri')
-			->with('principals/users/john.doe', '', ['VTODO'],
-				['SUMMARY', 'DESCRIPTION', 'CATEGORIES'],
-				[],
-				['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null])
-			->willReturn([
-				[
-					'calendarid' => 99,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'todo0.ics',
-					'calendardata' => self::$vTodo0,
-				],
-				[
-					'calendarid' => 123,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
-					'uri' => 'todo1.ics',
-					'calendardata' => self::$vTodo1,
-				],
-				[
-					'calendarid' => 1337,
-					'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
-					'uri' => 'todo2.ics',
-					'calendardata' => self::$vTodo2,
-				]
-			]);
-
-		$provider = $this->getMockBuilder(TasksSearchProvider::class)
-			->setConstructorArgs([
-				$this->appManager,
-				$this->l10n,
-				$this->urlGenerator,
-				$this->backend,
-			])
-			->onlyMethods([
-				'getDeepLinkToTasksApp',
-				'generateSubline',
-			])
-			->getMock();
-
-		$provider->expects($this->exactly(3))
-			->method('generateSubline')
-			->willReturn('subline');
-		$provider->expects($this->exactly(3))
-			->method('getDeepLinkToTasksApp')
-			->willReturnMap([
-				['calendar-uri-99', 'todo0.ics', 'deep-link-to-tasks'],
-				['calendar-uri-123', 'todo1.ics', 'deep-link-to-tasks'],
-				['subscription-uri-1337', 'todo2.ics', 'deep-link-to-tasks']
-			]);
-
-		$actual = $provider->search($user, $query);
-		$data = $actual->jsonSerialize();
-		$this->assertInstanceOf(SearchResult::class, $actual);
-		$this->assertEquals('Tasks', $data['name']);
-		$this->assertCount(3, $data['entries']);
-		$this->assertTrue($data['isPaginated']);
-		$this->assertEquals(23, $data['cursor']);
-
-		$result0 = $data['entries'][0];
-		$result0Data = $result0->jsonSerialize();
-		$result1 = $data['entries'][1];
-		$result1Data = $result1->jsonSerialize();
-		$result2 = $data['entries'][2];
-		$result2Data = $result2->jsonSerialize();
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result0);
-		$this->assertEmpty($result0Data['thumbnailUrl']);
-		$this->assertEquals('Untitled task', $result0Data['title']);
-		$this->assertEquals('subline', $result0Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result0Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result0Data['icon']);
-		$this->assertFalse($result0Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result1);
-		$this->assertEmpty($result1Data['thumbnailUrl']);
-		$this->assertEquals('Task title', $result1Data['title']);
-		$this->assertEquals('subline', $result1Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result1Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result1Data['icon']);
-		$this->assertFalse($result1Data['rounded']);
-
-		$this->assertInstanceOf(SearchResultEntry::class, $result2);
-		$this->assertEmpty($result2Data['thumbnailUrl']);
-		$this->assertEquals('Task title', $result2Data['title']);
-		$this->assertEquals('subline', $result2Data['subline']);
-		$this->assertEquals('deep-link-to-tasks', $result2Data['resourceUrl']);
-		$this->assertEquals('icon-checkmark', $result2Data['icon']);
-		$this->assertFalse($result2Data['rounded']);
-	}
-
-	public function testGetDeepLinkToTasksApp(): void {
-		$this->urlGenerator->expects($this->once())
-			->method('linkToRoute')
-			->with('tasks.page.index')
-			->willReturn('link-to-route-tasks.index');
-		$this->urlGenerator->expects($this->once())
-			->method('getAbsoluteURL')
-			->with('link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics')
-			->willReturn('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics');
-
-		$actual = self::invokePrivate($this->provider, 'getDeepLinkToTasksApp', ['uri-john.doe', 'task-uri.ics']);
-		$this->assertEquals('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics', $actual);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('generateSublineDataProvider')]
-	public function testGenerateSubline(string $ics, string $expectedSubline): void {
-		$vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
-		$taskComponent = $vCalendar->VTODO;
-
-		$this->l10n->method('t')->willReturnArgument(0);
-		$this->l10n->method('l')->willReturnArgument(0);
-
-		$actual = self::invokePrivate($this->provider, 'generateSubline', [$taskComponent]);
-		$this->assertEquals($expectedSubline, $actual);
-	}
-
-	public static function generateSublineDataProvider(): array {
-		return [
-			[self::$vTodo0, ''],
-			[self::$vTodo1, 'Completed on %s'],
-			[self::$vTodo2, 'Completed on %s'],
-			[self::$vTodo3, 'Due on %s'],
-			[self::$vTodo4, 'Due on %s by %s'],
-		];
-	}
+    private IAppManager&MockObject $appManager;
+    private IL10N&MockObject $l10n;
+    private IURLGenerator&MockObject $urlGenerator;
+    private CalDavBackend&MockObject $backend;
+    private TasksSearchProvider $provider;
+
+    // NO DUE NOR COMPLETED NOR SUMMARY
+    private static string $vTodo0 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'PRODID:TEST' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'BEGIN:VTODO' . PHP_EOL
+        . 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
+        . 'DTSTAMP:20070313T123432Z' . PHP_EOL
+        . 'STATUS:NEEDS-ACTION' . PHP_EOL
+        . 'END:VTODO' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // DUE AND COMPLETED
+    private static string $vTodo1 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'PRODID:TEST' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'BEGIN:VTODO' . PHP_EOL
+        . 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
+        . 'DTSTAMP:20070313T123432Z' . PHP_EOL
+        . 'COMPLETED:20070707T100000Z' . PHP_EOL
+        . 'DUE;VALUE=DATE:20070501' . PHP_EOL
+        . 'SUMMARY:Task title' . PHP_EOL
+        . 'STATUS:NEEDS-ACTION' . PHP_EOL
+        . 'END:VTODO' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // COMPLETED ONLY
+    private static string $vTodo2 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'PRODID:TEST' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'BEGIN:VTODO' . PHP_EOL
+        . 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
+        . 'DTSTAMP:20070313T123432Z' . PHP_EOL
+        . 'COMPLETED:20070707T100000Z' . PHP_EOL
+        . 'SUMMARY:Task title' . PHP_EOL
+        . 'STATUS:NEEDS-ACTION' . PHP_EOL
+        . 'END:VTODO' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // DUE DATE
+    private static string $vTodo3 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'PRODID:TEST' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'BEGIN:VTODO' . PHP_EOL
+        . 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
+        . 'DTSTAMP:20070313T123432Z' . PHP_EOL
+        . 'DUE;VALUE=DATE:20070501' . PHP_EOL
+        . 'SUMMARY:Task title' . PHP_EOL
+        . 'STATUS:NEEDS-ACTION' . PHP_EOL
+        . 'END:VTODO' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    // DUE DATETIME
+    private static string $vTodo4 = 'BEGIN:VCALENDAR' . PHP_EOL
+        . 'PRODID:TEST' . PHP_EOL
+        . 'VERSION:2.0' . PHP_EOL
+        . 'BEGIN:VTODO' . PHP_EOL
+        . 'UID:20070313T123432Z-456553@example.com' . PHP_EOL
+        . 'DTSTAMP:20070313T123432Z' . PHP_EOL
+        . 'DUE:20070709T130000Z' . PHP_EOL
+        . 'SUMMARY:Task title' . PHP_EOL
+        . 'STATUS:NEEDS-ACTION' . PHP_EOL
+        . 'END:VTODO' . PHP_EOL
+        . 'END:VCALENDAR';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->backend = $this->createMock(CalDavBackend::class);
+
+        $this->provider = new TasksSearchProvider(
+            $this->appManager,
+            $this->l10n,
+            $this->urlGenerator,
+            $this->backend
+        );
+    }
+
+    public function testGetId(): void {
+        $this->assertEquals('tasks', $this->provider->getId());
+    }
+
+    public function testGetName(): void {
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->with('Tasks')
+            ->willReturnArgument(0);
+
+        $this->assertEquals('Tasks', $this->provider->getName());
+    }
+
+    public function testSearchAppDisabled(): void {
+        $user = $this->createMock(IUser::class);
+        $query = $this->createMock(ISearchQuery::class);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('tasks', $user)
+            ->willReturn(false);
+        $this->l10n->expects($this->exactly(1))
+            ->method('t')
+            ->willReturnArgument(0);
+        $this->backend->expects($this->never())
+            ->method('getCalendarsForUser');
+        $this->backend->expects($this->never())
+            ->method('getSubscriptionsForUser');
+        $this->backend->expects($this->never())
+            ->method('searchPrincipalUri');
+
+        $actual = $this->provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Tasks', $data['name']);
+        $this->assertEmpty($data['entries']);
+        $this->assertFalse($data['isPaginated']);
+        $this->assertNull($data['cursor']);
+    }
+
+    public function testSearch(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('john.doe');
+        $query = $this->createMock(ISearchQuery::class);
+        $query->method('getTerm')->willReturn('search term');
+        $query->method('getLimit')->willReturn(5);
+        $query->method('getCursor')->willReturn(20);
+        $this->appManager->expects($this->once())
+            ->method('isEnabledForUser')
+            ->with('tasks', $user)
+            ->willReturn(true);
+        $this->l10n->method('t')->willReturnArgument(0);
+
+        $this->backend->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 99,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-99',
+                ], [
+                    'id' => 123,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'calendar-uri-123',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('getSubscriptionsForUser')
+            ->with('principals/users/john.doe')
+            ->willReturn([
+                [
+                    'id' => 1337,
+                    'principaluri' => 'principals/users/john.doe',
+                    'uri' => 'subscription-uri-1337',
+                ]
+            ]);
+        $this->backend->expects($this->once())
+            ->method('searchPrincipalUri')
+            ->with('principals/users/john.doe', '', ['VTODO'],
+                ['SUMMARY', 'DESCRIPTION', 'CATEGORIES'],
+                [],
+                ['limit' => 5, 'offset' => 20, 'since' => null, 'until' => null])
+            ->willReturn([
+                [
+                    'calendarid' => 99,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'todo0.ics',
+                    'calendardata' => self::$vTodo0,
+                ],
+                [
+                    'calendarid' => 123,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_CALENDAR,
+                    'uri' => 'todo1.ics',
+                    'calendardata' => self::$vTodo1,
+                ],
+                [
+                    'calendarid' => 1337,
+                    'calendartype' => CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION,
+                    'uri' => 'todo2.ics',
+                    'calendardata' => self::$vTodo2,
+                ]
+            ]);
+
+        $provider = $this->getMockBuilder(TasksSearchProvider::class)
+            ->setConstructorArgs([
+                $this->appManager,
+                $this->l10n,
+                $this->urlGenerator,
+                $this->backend,
+            ])
+            ->onlyMethods([
+                'getDeepLinkToTasksApp',
+                'generateSubline',
+            ])
+            ->getMock();
+
+        $provider->expects($this->exactly(3))
+            ->method('generateSubline')
+            ->willReturn('subline');
+        $provider->expects($this->exactly(3))
+            ->method('getDeepLinkToTasksApp')
+            ->willReturnMap([
+                ['calendar-uri-99', 'todo0.ics', 'deep-link-to-tasks'],
+                ['calendar-uri-123', 'todo1.ics', 'deep-link-to-tasks'],
+                ['subscription-uri-1337', 'todo2.ics', 'deep-link-to-tasks']
+            ]);
+
+        $actual = $provider->search($user, $query);
+        $data = $actual->jsonSerialize();
+        $this->assertInstanceOf(SearchResult::class, $actual);
+        $this->assertEquals('Tasks', $data['name']);
+        $this->assertCount(3, $data['entries']);
+        $this->assertTrue($data['isPaginated']);
+        $this->assertEquals(23, $data['cursor']);
+
+        $result0 = $data['entries'][0];
+        $result0Data = $result0->jsonSerialize();
+        $result1 = $data['entries'][1];
+        $result1Data = $result1->jsonSerialize();
+        $result2 = $data['entries'][2];
+        $result2Data = $result2->jsonSerialize();
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result0);
+        $this->assertEmpty($result0Data['thumbnailUrl']);
+        $this->assertEquals('Untitled task', $result0Data['title']);
+        $this->assertEquals('subline', $result0Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result0Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result0Data['icon']);
+        $this->assertFalse($result0Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result1);
+        $this->assertEmpty($result1Data['thumbnailUrl']);
+        $this->assertEquals('Task title', $result1Data['title']);
+        $this->assertEquals('subline', $result1Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result1Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result1Data['icon']);
+        $this->assertFalse($result1Data['rounded']);
+
+        $this->assertInstanceOf(SearchResultEntry::class, $result2);
+        $this->assertEmpty($result2Data['thumbnailUrl']);
+        $this->assertEquals('Task title', $result2Data['title']);
+        $this->assertEquals('subline', $result2Data['subline']);
+        $this->assertEquals('deep-link-to-tasks', $result2Data['resourceUrl']);
+        $this->assertEquals('icon-checkmark', $result2Data['icon']);
+        $this->assertFalse($result2Data['rounded']);
+    }
+
+    public function testGetDeepLinkToTasksApp(): void {
+        $this->urlGenerator->expects($this->once())
+            ->method('linkToRoute')
+            ->with('tasks.page.index')
+            ->willReturn('link-to-route-tasks.index');
+        $this->urlGenerator->expects($this->once())
+            ->method('getAbsoluteURL')
+            ->with('link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics')
+            ->willReturn('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics');
+
+        $actual = self::invokePrivate($this->provider, 'getDeepLinkToTasksApp', ['uri-john.doe', 'task-uri.ics']);
+        $this->assertEquals('absolute-url-link-to-route-tasks.indexcalendars/uri-john.doe/tasks/task-uri.ics', $actual);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('generateSublineDataProvider')]
+    public function testGenerateSubline(string $ics, string $expectedSubline): void {
+        $vCalendar = Reader::read($ics, Reader::OPTION_FORGIVING);
+        $taskComponent = $vCalendar->VTODO;
+
+        $this->l10n->method('t')->willReturnArgument(0);
+        $this->l10n->method('l')->willReturnArgument(0);
+
+        $actual = self::invokePrivate($this->provider, 'generateSubline', [$taskComponent]);
+        $this->assertEquals($expectedSubline, $actual);
+    }
+
+    public static function generateSublineDataProvider(): array {
+        return [
+            [self::$vTodo0, ''],
+            [self::$vTodo1, 'Completed on %s'],
+            [self::$vTodo2, 'Completed on %s'],
+            [self::$vTodo3, 'Due on %s'],
+            [self::$vTodo4, 'Due on %s by %s'],
+        ];
+    }
 }

apps/dav/tests/unit/Controller/InvitationResponseControllerTest.php

Indentation +359 added lines, -359 removed lines

@@ -23,50 +23,50 @@ 
 use Test\TestCase;
 
 class InvitationResponseControllerTest extends TestCase {
-	private IDBConnection&MockObject $dbConnection;
-	private IRequest&MockObject $request;
-	private ITimeFactory&MockObject $timeFactory;
-	private InvitationResponseServer&MockObject $responseServer;
-	private InvitationResponseController $controller;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->responseServer = $this->createMock(InvitationResponseServer::class);
-
-		$this->controller = new InvitationResponseController(
-			'appName',
-			$this->request,
-			$this->dbConnection,
-			$this->timeFactory,
-			$this->responseServer
-		);
-	}
-
-	public static function attendeeProvider(): array {
-		return [
-			'local attendee' => [false],
-			'external attendee' => [true]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAccept(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+    private IDBConnection&MockObject $dbConnection;
+    private IRequest&MockObject $request;
+    private ITimeFactory&MockObject $timeFactory;
+    private InvitationResponseServer&MockObject $responseServer;
+    private InvitationResponseController $controller;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->responseServer = $this->createMock(InvitationResponseServer::class);
+
+        $this->controller = new InvitationResponseController(
+            'appName',
+            $this->request,
+            $this->dbConnection,
+            $this->timeFactory,
+            $this->responseServer
+        );
+    }
+
+    public static function attendeeProvider(): array {
+        return [
+            'local attendee' => [false],
+            'external attendee' => [true]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAccept(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -82,53 +82,53 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAcceptSequence(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => 1337,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAcceptSequence(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => 1337,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -144,53 +144,53 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(1337, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(1337, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -207,80 +207,80 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(0, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testAcceptTokenNotFound(): void {
-		$this->buildQueryExpects('TOKEN123', null, 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	public function testAcceptExpiredToken(): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 42,
-		], 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testDecline(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(0, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testAcceptTokenNotFound(): void {
+        $this->buildQueryExpects('TOKEN123', null, 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    public function testAcceptExpiredToken(): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 42,
+        ], 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testDecline(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -296,65 +296,65 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->decline('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testOptions(): void {
-		$response = $this->controller->options('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-options', $response->getTemplateName());
-		$this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
-		$this->request->expects($this->once())
-			->method('getParam')
-			->with('partStat')
-			->willReturn('TENTATIVE');
-
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->decline('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testOptions(): void {
+        $response = $this->controller->options('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-options', $response->getTemplateName());
+        $this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
+        $this->request->expects($this->once())
+            ->method('getParam')
+            ->with('partStat')
+            ->willReturn('TENTATIVE');
+
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -370,92 +370,92 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-
-		$response = $this->controller->processMoreOptionsResult('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	private function buildQueryExpects(string $token, ?array $return, int $time): void {
-		$queryBuilder = $this->createMock(IQueryBuilder::class);
-		$stmt = $this->createMock(IResult::class);
-		$expr = $this->createMock(IExpressionBuilder::class);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-		$queryBuilder->method('expr')
-			->willReturn($expr);
-		$queryBuilder->method('createNamedParameter')
-			->willReturnMap([
-				[$token, \PDO::PARAM_STR, null, 'namedParameterToken']
-			]);
-
-		$stmt->expects($this->once())
-			->method('fetch')
-			->with(\PDO::FETCH_ASSOC)
-			->willReturn($return);
-		$stmt->expects($this->once())
-			->method('closeCursor');
-
-		$function = 'functionToken';
-		$expr->expects($this->once())
-			->method('eq')
-			->with('token', 'namedParameterToken')
-			->willReturn((string)$function);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-
-		$queryBuilder->expects($this->once())
-			->method('select')
-			->with('*')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('from')
-			->with('calendar_invitations')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('where')
-			->with($function)
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('executeQuery')
-			->with()
-			->willReturn($stmt);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($time);
-	}
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+
+        $response = $this->controller->processMoreOptionsResult('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    private function buildQueryExpects(string $token, ?array $return, int $time): void {
+        $queryBuilder = $this->createMock(IQueryBuilder::class);
+        $stmt = $this->createMock(IResult::class);
+        $expr = $this->createMock(IExpressionBuilder::class);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+        $queryBuilder->method('expr')
+            ->willReturn($expr);
+        $queryBuilder->method('createNamedParameter')
+            ->willReturnMap([
+                [$token, \PDO::PARAM_STR, null, 'namedParameterToken']
+            ]);
+
+        $stmt->expects($this->once())
+            ->method('fetch')
+            ->with(\PDO::FETCH_ASSOC)
+            ->willReturn($return);
+        $stmt->expects($this->once())
+            ->method('closeCursor');
+
+        $function = 'functionToken';
+        $expr->expects($this->once())
+            ->method('eq')
+            ->with('token', 'namedParameterToken')
+            ->willReturn((string)$function);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+
+        $queryBuilder->expects($this->once())
+            ->method('select')
+            ->with('*')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('from')
+            ->with('calendar_invitations')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('where')
+            ->with($function)
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('executeQuery')
+            ->with()
+            ->willReturn($stmt);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($time);
+    }
 }

apps/dav/tests/unit/Settings/CalDAVSettingsTest.php

Indentation +60 added lines, -60 removed lines

@@ -17,72 +17,72 @@
 use Test\TestCase;
 
 class CalDAVSettingsTest extends TestCase {
-	private IConfig&MockObject $config;
-	private IInitialState&MockObject $initialState;
-	private IURLGenerator&MockObject $urlGenerator;
-	private IAppManager&MockObject $appManager;
-	private CalDAVSettings $settings;
+    private IConfig&MockObject $config;
+    private IInitialState&MockObject $initialState;
+    private IURLGenerator&MockObject $urlGenerator;
+    private IAppManager&MockObject $appManager;
+    private CalDAVSettings $settings;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->createMock(IConfig::class);
-		$this->initialState = $this->createMock(IInitialState::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->settings = new CalDAVSettings($this->config, $this->initialState, $this->urlGenerator, $this->appManager);
-	}
+        $this->config = $this->createMock(IConfig::class);
+        $this->initialState = $this->createMock(IInitialState::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->settings = new CalDAVSettings($this->config, $this->initialState, $this->urlGenerator, $this->appManager);
+    }
 
-	public function testGetForm(): void {
-		$this->config->method('getAppValue')
-			->willReturnMap([
-				['dav', 'sendInvitations', 'yes', 'yes'],
-				['dav', 'generateBirthdayCalendar', 'yes', 'no'],
-				['dav', 'sendEventReminders', 'yes', 'yes'],
-				['dav', 'sendEventRemindersToSharedUsers', 'yes', 'yes'],
-				['dav', 'sendEventRemindersPush', 'yes', 'yes'],
-			]);
-		$this->urlGenerator
-			->expects($this->once())
-			->method('linkToDocs')
-			->with('user-sync-calendars')
-			->willReturn('Some docs URL');
+    public function testGetForm(): void {
+        $this->config->method('getAppValue')
+            ->willReturnMap([
+                ['dav', 'sendInvitations', 'yes', 'yes'],
+                ['dav', 'generateBirthdayCalendar', 'yes', 'no'],
+                ['dav', 'sendEventReminders', 'yes', 'yes'],
+                ['dav', 'sendEventRemindersToSharedUsers', 'yes', 'yes'],
+                ['dav', 'sendEventRemindersPush', 'yes', 'yes'],
+            ]);
+        $this->urlGenerator
+            ->expects($this->once())
+            ->method('linkToDocs')
+            ->with('user-sync-calendars')
+            ->willReturn('Some docs URL');
 
-		$calls = [
-			['userSyncCalendarsDocUrl', 'Some docs URL'],
-			['sendInvitations', true],
-			['generateBirthdayCalendar', false],
-			['sendEventReminders', true],
-			['sendEventRemindersToSharedUsers', true],
-			['sendEventRemindersPush', true],
-		];
-		$this->initialState->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$result = $this->settings->getForm();
+        $calls = [
+            ['userSyncCalendarsDocUrl', 'Some docs URL'],
+            ['sendInvitations', true],
+            ['generateBirthdayCalendar', false],
+            ['sendEventReminders', true],
+            ['sendEventRemindersToSharedUsers', true],
+            ['sendEventRemindersPush', true],
+        ];
+        $this->initialState->method('provideInitialState')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $result = $this->settings->getForm();
 
-		$this->assertInstanceOf(TemplateResponse::class, $result);
-	}
+        $this->assertInstanceOf(TemplateResponse::class, $result);
+    }
 
-	public function testGetSection(): void {
-		$this->appManager->expects(self::once())
-			->method('isBackendRequired')
-			->with(IAppManager::BACKEND_CALDAV)
-			->willReturn(true);
-		$this->assertEquals('groupware', $this->settings->getSection());
-	}
+    public function testGetSection(): void {
+        $this->appManager->expects(self::once())
+            ->method('isBackendRequired')
+            ->with(IAppManager::BACKEND_CALDAV)
+            ->willReturn(true);
+        $this->assertEquals('groupware', $this->settings->getSection());
+    }
 
-	public function testGetSectionWithoutCaldavBackend(): void {
-		$this->appManager->expects(self::once())
-			->method('isBackendRequired')
-			->with(IAppManager::BACKEND_CALDAV)
-			->willReturn(false);
-		$this->assertEquals(null, $this->settings->getSection());
-	}
+    public function testGetSectionWithoutCaldavBackend(): void {
+        $this->appManager->expects(self::once())
+            ->method('isBackendRequired')
+            ->with(IAppManager::BACKEND_CALDAV)
+            ->willReturn(false);
+        $this->assertEquals(null, $this->settings->getSection());
+    }
 
-	public function testGetPriority(): void {
-		$this->assertEquals(10, $this->settings->getPriority());
-	}
+    public function testGetPriority(): void {
+        $this->assertEquals(10, $this->settings->getPriority());
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 			['sendEventRemindersPush', true],
 		];
 		$this->initialState->method('provideInitialState')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/Comments/CommentsNodeTest.php

Indentation +413 added lines, -413 removed lines

@@ -20,480 +20,480 @@
 use Sabre\DAV\PropPatch;
 
 class CommentsNodeTest extends \Test\TestCase {
-	protected ICommentsManager&MockObject $commentsManager;
-	protected IComment&MockObject $comment;
-	protected IUserManager&MockObject $userManager;
-	protected LoggerInterface&MockObject $logger;
-	protected IUserSession&MockObject $userSession;
-	protected CommentNode $node;
+    protected ICommentsManager&MockObject $commentsManager;
+    protected IComment&MockObject $comment;
+    protected IUserManager&MockObject $userManager;
+    protected LoggerInterface&MockObject $logger;
+    protected IUserSession&MockObject $userSession;
+    protected CommentNode $node;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->commentsManager = $this->createMock(ICommentsManager::class);
-		$this->comment = $this->createMock(IComment::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
+        $this->commentsManager = $this->createMock(ICommentsManager::class);
+        $this->comment = $this->createMock(IComment::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
 
-		$this->node = new CommentNode(
-			$this->commentsManager,
-			$this->comment,
-			$this->userManager,
-			$this->userSession,
-			$this->logger
-		);
-	}
+        $this->node = new CommentNode(
+            $this->commentsManager,
+            $this->comment,
+            $this->userManager,
+            $this->userSession,
+            $this->logger
+        );
+    }
 
-	public function testDelete(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('alice');
+    public function testDelete(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('alice');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->once())
-			->method('getId')
-			->willReturn('19');
+        $this->comment->expects($this->once())
+            ->method('getId')
+            ->willReturn('19');
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->once())
-			->method('delete')
-			->with('19');
+        $this->commentsManager->expects($this->once())
+            ->method('delete')
+            ->with('19');
 
-		$this->node->delete();
-	}
+        $this->node->delete();
+    }
 
 
-	public function testDeleteForbidden(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testDeleteForbidden(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('mallory');
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('mallory');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->never())
-			->method('getId');
+        $this->comment->expects($this->never())
+            ->method('getId');
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->never())
-			->method('delete');
+        $this->commentsManager->expects($this->never())
+            ->method('delete');
 
-		$this->node->delete();
-	}
+        $this->node->delete();
+    }
 
-	public function testGetName(): void {
-		$id = '19';
-		$this->comment->expects($this->once())
-			->method('getId')
-			->willReturn($id);
+    public function testGetName(): void {
+        $id = '19';
+        $this->comment->expects($this->once())
+            ->method('getId')
+            ->willReturn($id);
 
-		$this->assertSame($this->node->getName(), $id);
-	}
+        $this->assertSame($this->node->getName(), $id);
+    }
 
 
-	public function testSetName(): void {
-		$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
+    public function testSetName(): void {
+        $this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
 
-		$this->node->setName('666');
-	}
+        $this->node->setName('666');
+    }
 
-	public function testGetLastModified(): void {
-		$this->assertSame($this->node->getLastModified(), null);
-	}
+    public function testGetLastModified(): void {
+        $this->assertSame($this->node->getLastModified(), null);
+    }
 
-	public function testUpdateComment(): void {
-		$msg = 'Hello Earth';
+    public function testUpdateComment(): void {
+        $msg = 'Hello Earth';
 
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('alice');
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('alice');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->once())
-			->method('setMessage')
-			->with($msg);
+        $this->comment->expects($this->once())
+            ->method('setMessage')
+            ->with($msg);
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->once())
-			->method('save')
-			->with($this->comment);
+        $this->commentsManager->expects($this->once())
+            ->method('save')
+            ->with($this->comment);
 
-		$this->assertTrue($this->node->updateComment($msg));
-	}
+        $this->assertTrue($this->node->updateComment($msg));
+    }
 
 
-	public function testUpdateCommentLogException(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('buh!');
+    public function testUpdateCommentLogException(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('buh!');
 
-		$msg = null;
+        $msg = null;
 
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('alice');
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('alice');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->once())
-			->method('setMessage')
-			->with($msg)
-			->willThrowException(new \Exception('buh!'));
+        $this->comment->expects($this->once())
+            ->method('setMessage')
+            ->with($msg)
+            ->willThrowException(new \Exception('buh!'));
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->never())
-			->method('save');
+        $this->commentsManager->expects($this->never())
+            ->method('save');
 
-		$this->logger->expects($this->once())
-			->method('error');
+        $this->logger->expects($this->once())
+            ->method('error');
 
-		$this->node->updateComment($msg);
-	}
+        $this->node->updateComment($msg);
+    }
 
 
-	public function testUpdateCommentMessageTooLongException(): void {
-		$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
-		$this->expectExceptionMessage('Message exceeds allowed character limit of');
+    public function testUpdateCommentMessageTooLongException(): void {
+        $this->expectException(\Sabre\DAV\Exception\BadRequest::class);
+        $this->expectExceptionMessage('Message exceeds allowed character limit of');
 
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('alice');
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('alice');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->once())
-			->method('setMessage')
-			->willThrowException(new MessageTooLongException());
+        $this->comment->expects($this->once())
+            ->method('setMessage')
+            ->willThrowException(new MessageTooLongException());
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->never())
-			->method('save');
+        $this->commentsManager->expects($this->never())
+            ->method('save');
 
-		$this->logger->expects($this->once())
-			->method('error');
+        $this->logger->expects($this->once())
+            ->method('error');
 
-		// imagine 'foo' has >1k characters. comment is mocked anyway.
-		$this->node->updateComment('foo');
-	}
+        // imagine 'foo' has >1k characters. comment is mocked anyway.
+        $this->node->updateComment('foo');
+    }
 
 
-	public function testUpdateForbiddenByUser(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testUpdateForbiddenByUser(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$msg = 'HaXX0r';
+        $msg = 'HaXX0r';
 
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('mallory');
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('mallory');
 
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
 
-		$this->comment->expects($this->never())
-			->method('setMessage');
+        $this->comment->expects($this->never())
+            ->method('setMessage');
 
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
 
-		$this->comment->expects($this->any())
-			->method('getActorId')
-			->willReturn('alice');
+        $this->comment->expects($this->any())
+            ->method('getActorId')
+            ->willReturn('alice');
 
-		$this->commentsManager->expects($this->never())
-			->method('save');
-
-		$this->node->updateComment($msg);
-	}
-
-
-	public function testUpdateForbiddenByType(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$msg = 'HaXX0r';
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->never())
-			->method('getUID');
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->comment->expects($this->never())
-			->method('setMessage');
-
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('bots');
-
-		$this->commentsManager->expects($this->never())
-			->method('save');
-
-		$this->node->updateComment($msg);
-	}
-
-
-	public function testUpdateForbiddenByNotLoggedIn(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$msg = 'HaXX0r';
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn(null);
-
-		$this->comment->expects($this->never())
-			->method('setMessage');
-
-		$this->comment->expects($this->any())
-			->method('getActorType')
-			->willReturn('users');
-
-		$this->commentsManager->expects($this->never())
-			->method('save');
-
-		$this->node->updateComment($msg);
-	}
-
-	public function testPropPatch(): void {
-		$propPatch = $this->createMock(PropPatch::class);
-		$propPatch->expects($this->once())
-			->method('handle')
-			->with('{http://owncloud.org/ns}message');
-
-		$this->node->propPatch($propPatch);
-	}
-
-	public function testGetProperties(): void {
-		$ns = '{http://owncloud.org/ns}';
-		$expected = [
-			$ns . 'id' => '123',
-			$ns . 'parentId' => '12',
-			$ns . 'topmostParentId' => '2',
-			$ns . 'childrenCount' => 3,
-			$ns . 'message' => 'such a nice file you have…',
-			$ns . 'mentions' => [
-				[ $ns . 'mention' => [
-					$ns . 'mentionType' => 'user',
-					$ns . 'mentionId' => 'alice',
-					$ns . 'mentionDisplayName' => 'Alice Al-Isson',
-				] ],
-				[ $ns . 'mention' => [
-					$ns . 'mentionType' => 'user',
-					$ns . 'mentionId' => 'bob',
-					$ns . 'mentionDisplayName' => 'Unknown user',
-				] ],
-			],
-			$ns . 'verb' => 'comment',
-			$ns . 'actorType' => 'users',
-			$ns . 'actorId' => 'alice',
-			$ns . 'actorDisplayName' => 'Alice of Wonderland',
-			$ns . 'creationDateTime' => new \DateTime('2016-01-10 18:48:00'),
-			$ns . 'latestChildDateTime' => new \DateTime('2016-01-12 18:48:00'),
-			$ns . 'objectType' => 'files',
-			$ns . 'objectId' => '1848',
-			$ns . 'referenceId' => 'ref',
-			$ns . 'isUnread' => null,
-			$ns . 'reactions' => [],
-			$ns . 'metaData' => [
-				'last_edited_at' => 1702553770,
-				'last_edited_by_id' => 'charly',
-				'last_edited_by_type' => 'user',
-			],
-			$ns . 'expireDate' => new \DateTime('2016-01-12 19:00:00'),
-		];
-
-		$this->commentsManager->expects($this->exactly(2))
-			->method('resolveDisplayName')
-			->willReturnMap([
-				['user', 'alice', 'Alice Al-Isson'],
-				['user', 'bob', 'Unknown user']
-			]);
-
-		$this->comment->expects($this->once())
-			->method('getId')
-			->willReturn($expected[$ns . 'id']);
-
-		$this->comment->expects($this->once())
-			->method('getParentId')
-			->willReturn($expected[$ns . 'parentId']);
-
-		$this->comment->expects($this->once())
-			->method('getTopmostParentId')
-			->willReturn($expected[$ns . 'topmostParentId']);
-
-		$this->comment->expects($this->once())
-			->method('getChildrenCount')
-			->willReturn($expected[$ns . 'childrenCount']);
-
-		$this->comment->expects($this->once())
-			->method('getMessage')
-			->willReturn($expected[$ns . 'message']);
-
-		$this->comment->expects($this->once())
-			->method('getMentions')
-			->willReturn([
-				['type' => 'user', 'id' => 'alice'],
-				['type' => 'user', 'id' => 'bob'],
-			]);
-
-		$this->comment->expects($this->once())
-			->method('getVerb')
-			->willReturn($expected[$ns . 'verb']);
-
-		$this->comment->expects($this->exactly(2))
-			->method('getActorType')
-			->willReturn($expected[$ns . 'actorType']);
-
-		$this->comment->expects($this->exactly(2))
-			->method('getActorId')
-			->willReturn($expected[$ns . 'actorId']);
-
-		$this->comment->expects($this->once())
-			->method('getCreationDateTime')
-			->willReturn($expected[$ns . 'creationDateTime']);
-
-		$this->comment->expects($this->once())
-			->method('getLatestChildDateTime')
-			->willReturn($expected[$ns . 'latestChildDateTime']);
-
-		$this->comment->expects($this->once())
-			->method('getObjectType')
-			->willReturn($expected[$ns . 'objectType']);
-
-		$this->comment->expects($this->once())
-			->method('getObjectId')
-			->willReturn($expected[$ns . 'objectId']);
-
-		$this->comment->expects($this->once())
-			->method('getReferenceId')
-			->willReturn($expected[$ns . 'referenceId']);
-
-		$this->comment->expects($this->once())
-			->method('getMetaData')
-			->willReturn($expected[$ns . 'metaData']);
-
-		$this->comment->expects($this->once())
-			->method('getExpireDate')
-			->willReturn($expected[$ns . 'expireDate']);
-
-		$user = $this->getMockBuilder(IUser::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$user->expects($this->once())
-			->method('getDisplayName')
-			->willReturn($expected[$ns . 'actorDisplayName']);
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with('alice')
-			->willReturn($user);
-
-		$properties = $this->node->getProperties(null);
-
-		foreach ($properties as $name => $value) {
-			$this->assertArrayHasKey($name, $expected, 'Key not found in the list of $expected');
-			$this->assertSame($expected[$name], $value);
-			unset($expected[$name]);
-		}
-		$this->assertTrue(empty($expected));
-	}
-
-	public static function readCommentProvider(): array {
-		$creationDT = new \DateTime('2016-01-19 18:48:00');
-		$diff = new \DateInterval('PT2H');
-		$readDT1 = clone $creationDT;
-		$readDT1->sub($diff);
-		$readDT2 = clone $creationDT;
-		$readDT2->add($diff);
-		return [
-			[$creationDT, $readDT1, 'true'],
-			[$creationDT, $readDT2, 'false'],
-			[$creationDT, null, 'true'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('readCommentProvider')]
-	public function testGetPropertiesUnreadProperty(\DateTime $creationDT, ?\DateTime $readDT, string $expected): void {
-		$this->comment->expects($this->any())
-			->method('getCreationDateTime')
-			->willReturn($creationDT);
-
-		$this->comment->expects($this->any())
-			->method('getMentions')
-			->willReturn([]);
-
-		$this->commentsManager->expects($this->once())
-			->method('getReadMark')
-			->willReturn($readDT);
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn(
-				$this->getMockBuilder(IUser::class)
-					->disableOriginalConstructor()
-					->getMock()
-			);
-
-		$properties = $this->node->getProperties(null);
-
-		$this->assertTrue(array_key_exists(CommentNode::PROPERTY_NAME_UNREAD, $properties));
-		$this->assertSame($properties[CommentNode::PROPERTY_NAME_UNREAD], $expected);
-	}
+        $this->commentsManager->expects($this->never())
+            ->method('save');
+
+        $this->node->updateComment($msg);
+    }
+
+
+    public function testUpdateForbiddenByType(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $msg = 'HaXX0r';
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->never())
+            ->method('getUID');
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->comment->expects($this->never())
+            ->method('setMessage');
+
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('bots');
+
+        $this->commentsManager->expects($this->never())
+            ->method('save');
+
+        $this->node->updateComment($msg);
+    }
+
+
+    public function testUpdateForbiddenByNotLoggedIn(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $msg = 'HaXX0r';
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn(null);
+
+        $this->comment->expects($this->never())
+            ->method('setMessage');
+
+        $this->comment->expects($this->any())
+            ->method('getActorType')
+            ->willReturn('users');
+
+        $this->commentsManager->expects($this->never())
+            ->method('save');
+
+        $this->node->updateComment($msg);
+    }
+
+    public function testPropPatch(): void {
+        $propPatch = $this->createMock(PropPatch::class);
+        $propPatch->expects($this->once())
+            ->method('handle')
+            ->with('{http://owncloud.org/ns}message');
+
+        $this->node->propPatch($propPatch);
+    }
+
+    public function testGetProperties(): void {
+        $ns = '{http://owncloud.org/ns}';
+        $expected = [
+            $ns . 'id' => '123',
+            $ns . 'parentId' => '12',
+            $ns . 'topmostParentId' => '2',
+            $ns . 'childrenCount' => 3,
+            $ns . 'message' => 'such a nice file you have…',
+            $ns . 'mentions' => [
+                [ $ns . 'mention' => [
+                    $ns . 'mentionType' => 'user',
+                    $ns . 'mentionId' => 'alice',
+                    $ns . 'mentionDisplayName' => 'Alice Al-Isson',
+                ] ],
+                [ $ns . 'mention' => [
+                    $ns . 'mentionType' => 'user',
+                    $ns . 'mentionId' => 'bob',
+                    $ns . 'mentionDisplayName' => 'Unknown user',
+                ] ],
+            ],
+            $ns . 'verb' => 'comment',
+            $ns . 'actorType' => 'users',
+            $ns . 'actorId' => 'alice',
+            $ns . 'actorDisplayName' => 'Alice of Wonderland',
+            $ns . 'creationDateTime' => new \DateTime('2016-01-10 18:48:00'),
+            $ns . 'latestChildDateTime' => new \DateTime('2016-01-12 18:48:00'),
+            $ns . 'objectType' => 'files',
+            $ns . 'objectId' => '1848',
+            $ns . 'referenceId' => 'ref',
+            $ns . 'isUnread' => null,
+            $ns . 'reactions' => [],
+            $ns . 'metaData' => [
+                'last_edited_at' => 1702553770,
+                'last_edited_by_id' => 'charly',
+                'last_edited_by_type' => 'user',
+            ],
+            $ns . 'expireDate' => new \DateTime('2016-01-12 19:00:00'),
+        ];
+
+        $this->commentsManager->expects($this->exactly(2))
+            ->method('resolveDisplayName')
+            ->willReturnMap([
+                ['user', 'alice', 'Alice Al-Isson'],
+                ['user', 'bob', 'Unknown user']
+            ]);
+
+        $this->comment->expects($this->once())
+            ->method('getId')
+            ->willReturn($expected[$ns . 'id']);
+
+        $this->comment->expects($this->once())
+            ->method('getParentId')
+            ->willReturn($expected[$ns . 'parentId']);
+
+        $this->comment->expects($this->once())
+            ->method('getTopmostParentId')
+            ->willReturn($expected[$ns . 'topmostParentId']);
+
+        $this->comment->expects($this->once())
+            ->method('getChildrenCount')
+            ->willReturn($expected[$ns . 'childrenCount']);
+
+        $this->comment->expects($this->once())
+            ->method('getMessage')
+            ->willReturn($expected[$ns . 'message']);
+
+        $this->comment->expects($this->once())
+            ->method('getMentions')
+            ->willReturn([
+                ['type' => 'user', 'id' => 'alice'],
+                ['type' => 'user', 'id' => 'bob'],
+            ]);
+
+        $this->comment->expects($this->once())
+            ->method('getVerb')
+            ->willReturn($expected[$ns . 'verb']);
+
+        $this->comment->expects($this->exactly(2))
+            ->method('getActorType')
+            ->willReturn($expected[$ns . 'actorType']);
+
+        $this->comment->expects($this->exactly(2))
+            ->method('getActorId')
+            ->willReturn($expected[$ns . 'actorId']);
+
+        $this->comment->expects($this->once())
+            ->method('getCreationDateTime')
+            ->willReturn($expected[$ns . 'creationDateTime']);
+
+        $this->comment->expects($this->once())
+            ->method('getLatestChildDateTime')
+            ->willReturn($expected[$ns . 'latestChildDateTime']);
+
+        $this->comment->expects($this->once())
+            ->method('getObjectType')
+            ->willReturn($expected[$ns . 'objectType']);
+
+        $this->comment->expects($this->once())
+            ->method('getObjectId')
+            ->willReturn($expected[$ns . 'objectId']);
+
+        $this->comment->expects($this->once())
+            ->method('getReferenceId')
+            ->willReturn($expected[$ns . 'referenceId']);
+
+        $this->comment->expects($this->once())
+            ->method('getMetaData')
+            ->willReturn($expected[$ns . 'metaData']);
+
+        $this->comment->expects($this->once())
+            ->method('getExpireDate')
+            ->willReturn($expected[$ns . 'expireDate']);
+
+        $user = $this->getMockBuilder(IUser::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $user->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn($expected[$ns . 'actorDisplayName']);
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with('alice')
+            ->willReturn($user);
+
+        $properties = $this->node->getProperties(null);
+
+        foreach ($properties as $name => $value) {
+            $this->assertArrayHasKey($name, $expected, 'Key not found in the list of $expected');
+            $this->assertSame($expected[$name], $value);
+            unset($expected[$name]);
+        }
+        $this->assertTrue(empty($expected));
+    }
+
+    public static function readCommentProvider(): array {
+        $creationDT = new \DateTime('2016-01-19 18:48:00');
+        $diff = new \DateInterval('PT2H');
+        $readDT1 = clone $creationDT;
+        $readDT1->sub($diff);
+        $readDT2 = clone $creationDT;
+        $readDT2->add($diff);
+        return [
+            [$creationDT, $readDT1, 'true'],
+            [$creationDT, $readDT2, 'false'],
+            [$creationDT, null, 'true'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('readCommentProvider')]
+    public function testGetPropertiesUnreadProperty(\DateTime $creationDT, ?\DateTime $readDT, string $expected): void {
+        $this->comment->expects($this->any())
+            ->method('getCreationDateTime')
+            ->willReturn($creationDT);
+
+        $this->comment->expects($this->any())
+            ->method('getMentions')
+            ->willReturn([]);
+
+        $this->commentsManager->expects($this->once())
+            ->method('getReadMark')
+            ->willReturn($readDT);
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn(
+                $this->getMockBuilder(IUser::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            );
+
+        $properties = $this->node->getProperties(null);
+
+        $this->assertTrue(array_key_exists(CommentNode::PROPERTY_NAME_UNREAD, $properties));
+        $this->assertSame($properties[CommentNode::PROPERTY_NAME_UNREAD], $expected);
+    }
 }