nextcloud / server

apps/dav/tests/unit/CardDAV/AddressBookTest.php

Indentation +162 added lines, -162 removed lines

@@ -19,166 +19,166 @@
 use Test\TestCase;
 
 class AddressBookTest extends TestCase {
-	public function testMove(): void {
-		$backend = $this->createMock(CardDavBackend::class);
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default',
-		];
-		$l10n = $this->createMock(IL10N::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-
-		$card = new Card($backend, $addressBookInfo, ['id' => 5, 'carddata' => 'RANDOM VCF DATA', 'uri' => 'something', 'addressbookid' => 23]);
-
-		$backend->expects($this->once())->method('moveCard')
-			->with(23, 666, 'something', 'user1')
-			->willReturn(true);
-
-		$addressBook->moveInto('new', 'old', $card);
-	}
-
-	public function testDelete(): void {
-		/** @var MockObject | CardDavBackend $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->once())->method('updateShares');
-		$backend->expects($this->any())->method('getShares')->willReturn([
-			['href' => 'principal:user2']
-		]);
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default',
-		];
-		$l10n = $this->createMock(IL10N::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-		$addressBook->delete();
-	}
-
-
-	public function testDeleteFromGroup(): void {
-		$this->expectException(Forbidden::class);
-
-		/** @var MockObject | CardDavBackend $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->never())->method('updateShares');
-		$backend->expects($this->any())->method('getShares')->willReturn([
-			['href' => 'principal:group2']
-		]);
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default',
-		];
-		$l10n = $this->createMock(IL10N::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-		$addressBook->delete();
-	}
-
-
-	public function testPropPatchShared(): void {
-		/** @var MockObject | CardDavBackend $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->never())->method('updateAddressBook');
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default',
-		];
-		$l10n = $this->createMock(IL10N::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-		$addressBook->propPatch(new PropPatch(['{DAV:}displayname' => 'Test address book']));
-	}
-
-	public function testPropPatchNotShared(): void {
-		/** @var MockObject | CardDavBackend $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->atLeast(1))->method('updateAddressBook');
-		$addressBookInfo = [
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'default',
-		];
-		$l10n = $this->createMock(IL10N::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-		$addressBook->propPatch(new PropPatch(['{DAV:}displayname' => 'Test address book']));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesReadOnlyInfo')]
-	public function testAcl(bool $expectsWrite, ?bool $readOnlyValue, bool $hasOwnerSet): void {
-		/** @var MockObject | CardDavBackend $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
-		$addressBookInfo = [
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default'
-		];
-		if (!is_null($readOnlyValue)) {
-			$addressBookInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
-		}
-		if ($hasOwnerSet) {
-			$addressBookInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
-		}
-		$l10n = $this->createMock(IL10N::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
-		$acl = $addressBook->getACL();
-		$childAcl = $addressBook->getChildACL();
-
-		$expectedAcl = [[
-			'privilege' => '{DAV:}read',
-			'principal' => $hasOwnerSet ? 'user1' : 'user2',
-			'protected' => true
-		], [
-			'privilege' => '{DAV:}write',
-			'principal' => $hasOwnerSet ? 'user1' : 'user2',
-			'protected' => true
-		], [
-			'privilege' => '{DAV:}write-properties',
-			'principal' => $hasOwnerSet ? 'user1' : 'user2',
-			'protected' => true
-		]];
-		if ($hasOwnerSet) {
-			$expectedAcl[] = [
-				'privilege' => '{DAV:}read',
-				'principal' => 'user2',
-				'protected' => true
-			];
-			if ($expectsWrite) {
-				$expectedAcl[] = [
-					'privilege' => '{DAV:}write',
-					'principal' => 'user2',
-					'protected' => true
-				];
-			}
-		}
-		$this->assertEquals($expectedAcl, $acl);
-		$this->assertEquals($expectedAcl, $childAcl);
-	}
-
-	public static function providesReadOnlyInfo(): array {
-		return [
-			'read-only property not set' => [true, null, true],
-			'read-only property is false' => [true, false, true],
-			'read-only property is true' => [false, true, true],
-			'read-only property not set and no owner' => [true, null, false],
-			'read-only property is false and no owner' => [true, false, false],
-			'read-only property is true and no owner' => [false, true, false],
-		];
-	}
+    public function testMove(): void {
+        $backend = $this->createMock(CardDavBackend::class);
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+        $l10n = $this->createMock(IL10N::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+
+        $card = new Card($backend, $addressBookInfo, ['id' => 5, 'carddata' => 'RANDOM VCF DATA', 'uri' => 'something', 'addressbookid' => 23]);
+
+        $backend->expects($this->once())->method('moveCard')
+            ->with(23, 666, 'something', 'user1')
+            ->willReturn(true);
+
+        $addressBook->moveInto('new', 'old', $card);
+    }
+
+    public function testDelete(): void {
+        /** @var MockObject | CardDavBackend $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->once())->method('updateShares');
+        $backend->expects($this->any())->method('getShares')->willReturn([
+            ['href' => 'principal:user2']
+        ]);
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+        $l10n = $this->createMock(IL10N::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+        $addressBook->delete();
+    }
+
+
+    public function testDeleteFromGroup(): void {
+        $this->expectException(Forbidden::class);
+
+        /** @var MockObject | CardDavBackend $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->never())->method('updateShares');
+        $backend->expects($this->any())->method('getShares')->willReturn([
+            ['href' => 'principal:group2']
+        ]);
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+        $l10n = $this->createMock(IL10N::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+        $addressBook->delete();
+    }
+
+
+    public function testPropPatchShared(): void {
+        /** @var MockObject | CardDavBackend $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->never())->method('updateAddressBook');
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+        $l10n = $this->createMock(IL10N::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+        $addressBook->propPatch(new PropPatch(['{DAV:}displayname' => 'Test address book']));
+    }
+
+    public function testPropPatchNotShared(): void {
+        /** @var MockObject | CardDavBackend $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->atLeast(1))->method('updateAddressBook');
+        $addressBookInfo = [
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+        $l10n = $this->createMock(IL10N::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+        $addressBook->propPatch(new PropPatch(['{DAV:}displayname' => 'Test address book']));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesReadOnlyInfo')]
+    public function testAcl(bool $expectsWrite, ?bool $readOnlyValue, bool $hasOwnerSet): void {
+        /** @var MockObject | CardDavBackend $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->any())->method('applyShareAcl')->willReturnArgument(1);
+        $addressBookInfo = [
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default'
+        ];
+        if (!is_null($readOnlyValue)) {
+            $addressBookInfo['{http://owncloud.org/ns}read-only'] = $readOnlyValue;
+        }
+        if ($hasOwnerSet) {
+            $addressBookInfo['{http://owncloud.org/ns}owner-principal'] = 'user1';
+        }
+        $l10n = $this->createMock(IL10N::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $addressBook = new AddressBook($backend, $addressBookInfo, $l10n);
+        $acl = $addressBook->getACL();
+        $childAcl = $addressBook->getChildACL();
+
+        $expectedAcl = [[
+            'privilege' => '{DAV:}read',
+            'principal' => $hasOwnerSet ? 'user1' : 'user2',
+            'protected' => true
+        ], [
+            'privilege' => '{DAV:}write',
+            'principal' => $hasOwnerSet ? 'user1' : 'user2',
+            'protected' => true
+        ], [
+            'privilege' => '{DAV:}write-properties',
+            'principal' => $hasOwnerSet ? 'user1' : 'user2',
+            'protected' => true
+        ]];
+        if ($hasOwnerSet) {
+            $expectedAcl[] = [
+                'privilege' => '{DAV:}read',
+                'principal' => 'user2',
+                'protected' => true
+            ];
+            if ($expectsWrite) {
+                $expectedAcl[] = [
+                    'privilege' => '{DAV:}write',
+                    'principal' => 'user2',
+                    'protected' => true
+                ];
+            }
+        }
+        $this->assertEquals($expectedAcl, $acl);
+        $this->assertEquals($expectedAcl, $childAcl);
+    }
+
+    public static function providesReadOnlyInfo(): array {
+        return [
+            'read-only property not set' => [true, null, true],
+            'read-only property is false' => [true, false, true],
+            'read-only property is true' => [false, true, true],
+            'read-only property not set and no owner' => [true, null, false],
+            'read-only property is false and no owner' => [true, false, false],
+            'read-only property is true and no owner' => [false, true, false],
+        ];
+    }
 }

apps/dav/tests/unit/CardDAV/SyncServiceTest.php

Indentation +371 added lines, -371 removed lines

@@ -29,103 +29,103 @@ 
 
 class SyncServiceTest extends TestCase {
 
-	protected CardDavBackend&MockObject $backend;
-	protected IUserManager&MockObject $userManager;
-	protected IDBConnection&MockObject $dbConnection;
-	protected LoggerInterface $logger;
-	protected Converter&MockObject $converter;
-	protected IClient&MockObject $client;
-	protected IConfig&MockObject $config;
-	protected SyncService $service;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$addressBook = [
-			'id' => 1,
-			'uri' => 'system',
-			'principaluri' => 'principals/system/system',
-			'{DAV:}displayname' => 'system',
-			// watch out, incomplete address book mock.
-		];
-
-		$this->backend = $this->createMock(CardDavBackend::class);
-		$this->backend->method('getAddressBooksByUri')
-			->with('principals/system/system', 1)
-			->willReturn($addressBook);
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->logger = new NullLogger();
-		$this->converter = $this->createMock(Converter::class);
-		$this->client = $this->createMock(IClient::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$clientService = $this->createMock(IClientService::class);
-		$clientService->method('newClient')
-			->willReturn($this->client);
-
-		$this->service = new SyncService(
-			$this->backend,
-			$this->userManager,
-			$this->dbConnection,
-			$this->logger,
-			$this->converter,
-			$clientService,
-			$this->config
-		);
-	}
-
-	public function testEmptySync(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$body = '<?xml version="1.0"?>
+    protected CardDavBackend&MockObject $backend;
+    protected IUserManager&MockObject $userManager;
+    protected IDBConnection&MockObject $dbConnection;
+    protected LoggerInterface $logger;
+    protected Converter&MockObject $converter;
+    protected IClient&MockObject $client;
+    protected IConfig&MockObject $config;
+    protected SyncService $service;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $addressBook = [
+            'id' => 1,
+            'uri' => 'system',
+            'principaluri' => 'principals/system/system',
+            '{DAV:}displayname' => 'system',
+            // watch out, incomplete address book mock.
+        ];
+
+        $this->backend = $this->createMock(CardDavBackend::class);
+        $this->backend->method('getAddressBooksByUri')
+            ->with('principals/system/system', 1)
+            ->willReturn($addressBook);
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->logger = new NullLogger();
+        $this->converter = $this->createMock(Converter::class);
+        $this->client = $this->createMock(IClient::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $clientService = $this->createMock(IClientService::class);
+        $clientService->method('newClient')
+            ->willReturn($this->client);
+
+        $this->service = new SyncService(
+            $this->backend,
+            $this->userManager,
+            $this->dbConnection,
+            $this->logger,
+            $this->converter,
+            $clientService,
+            $this->config
+        );
+    }
+
+    public function testEmptySync(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:sync-token>http://sabre.io/ns/sync/1</d:sync-token>
 </d:multistatus>';
 
-		$requestResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->willReturn($requestResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-
-		$this->assertEquals('http://sabre.io/ns/sync/1', $token);
-	}
-
-	public function testSyncWithNewElement(): void {
-		$this->backend->expects($this->exactly(1))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$this->backend->method('getCard')
-			->willReturn(false);
-
-
-		$body = '<?xml version="1.0"?>
+        $requestResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->willReturn($requestResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+
+        $this->assertEquals('http://sabre.io/ns/sync/1', $token);
+    }
+
+    public function testSyncWithNewElement(): void {
+        $this->backend->expects($this->exactly(1))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $this->backend->method('getCard')
+            ->willReturn(false);
+
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:response>
         <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -140,17 +140,17 @@ 
     <d:sync-token>http://sabre.io/ns/sync/2</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
 
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
 
-		$vCard = 'BEGIN:VCARD
+        $vCard = 'BEGIN:VCARD
 VERSION:3.0
 PRODID:-//Sabre//Sabre VObject 4.5.4//EN
 UID:alice
@@ -160,43 +160,43 @@ 
 CLOUD:alice@server2.internal
 END:VCARD';
 
-		$getResponse = new Response(new PsrResponse(
-			200,
-			['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
-			$vCard,
-		));
-
-		$this->client
-			->method('get')
-			->willReturn($getResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-
-		$this->assertEquals('http://sabre.io/ns/sync/2', $token);
-	}
-
-	public function testSyncWithUpdatedElement(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(1))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-
-		$this->backend->method('getCard')
-			->willReturn(true);
-
-
-		$body = '<?xml version="1.0"?>
+        $getResponse = new Response(new PsrResponse(
+            200,
+            ['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
+            $vCard,
+        ));
+
+        $this->client
+            ->method('get')
+            ->willReturn($getResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+
+        $this->assertEquals('http://sabre.io/ns/sync/2', $token);
+    }
+
+    public function testSyncWithUpdatedElement(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+
+        $this->backend->method('getCard')
+            ->willReturn(true);
+
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:response>
         <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -211,17 +211,17 @@ 
     <d:sync-token>http://sabre.io/ns/sync/3</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
 
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
 
-		$vCard = 'BEGIN:VCARD
+        $vCard = 'BEGIN:VCARD
 VERSION:3.0
 PRODID:-//Sabre//Sabre VObject 4.5.4//EN
 UID:alice
@@ -231,39 +231,39 @@ 
 CLOUD:alice@server2.internal
 END:VCARD';
 
-		$getResponse = new Response(new PsrResponse(
-			200,
-			['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
-			$vCard,
-		));
-
-		$this->client
-			->method('get')
-			->willReturn($getResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-
-		$this->assertEquals('http://sabre.io/ns/sync/3', $token);
-	}
-
-	public function testSyncWithDeletedElement(): void {
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(1))
-			->method('deleteCard');
-
-		$body = '<?xml version="1.0"?>
+        $getResponse = new Response(new PsrResponse(
+            200,
+            ['Content-Type' => 'text/vcard; charset=utf-8', 'Content-Length' => strlen($vCard)],
+            $vCard,
+        ));
+
+        $this->client
+            ->method('get')
+            ->willReturn($getResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+
+        $this->assertEquals('http://sabre.io/ns/sync/3', $token);
+    }
+
+    public function testSyncWithDeletedElement(): void {
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('deleteCard');
+
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
 <d:response>
     <d:href>/remote.php/dav/addressbooks/system/system/system/Database:alice.vcf</d:href>
@@ -272,209 +272,209 @@ 
 <d:sync-token>http://sabre.io/ns/sync/4</d:sync-token>
 </d:multistatus>';
 
-		$reportResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->willReturn($reportResponse);
-
-		$token = $this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-
-		$this->assertEquals('http://sabre.io/ns/sync/4', $token);
-	}
-
-	public function testEnsureSystemAddressBookExists(): void {
-		/** @var CardDavBackend&MockObject $backend */
-		$backend = $this->createMock(CardDavBackend::class);
-		$backend->expects($this->exactly(1))->method('createAddressBook');
-		$backend->expects($this->exactly(2))
-			->method('getAddressBooksByUri')
-			->willReturnOnConsecutiveCalls(
-				null,
-				[],
-			);
-
-		$userManager = $this->createMock(IUserManager::class);
-		$dbConnection = $this->createMock(IDBConnection::class);
-		$logger = $this->createMock(LoggerInterface::class);
-		$converter = $this->createMock(Converter::class);
-		$clientService = $this->createMock(IClientService::class);
-		$config = $this->createMock(IConfig::class);
-
-		$ss = new SyncService($backend, $userManager, $dbConnection, $logger, $converter, $clientService, $config);
-		$ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
-	}
-
-	public static function dataActivatedUsers(): array {
-		return [
-			[true, 1, 1, 1],
-			[false, 0, 0, 3],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataActivatedUsers')]
-	public function testUpdateAndDeleteUser(bool $activated, int $createCalls, int $updateCalls, int $deleteCalls): void {
-		/** @var CardDavBackend | MockObject $backend */
-		$backend = $this->getMockBuilder(CardDavBackend::class)->disableOriginalConstructor()->getMock();
-		$logger = $this->getMockBuilder(LoggerInterface::class)->disableOriginalConstructor()->getMock();
-
-		$backend->expects($this->exactly($createCalls))->method('createCard');
-		$backend->expects($this->exactly($updateCalls))->method('updateCard');
-		$backend->expects($this->exactly($deleteCalls))->method('deleteCard');
-
-		$backend->method('getCard')->willReturnOnConsecutiveCalls(false, [
-			'carddata' => "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n"
-		]);
-
-		$backend->method('getAddressBooksByUri')
-			->with('principals/system/system', 'system')
-			->willReturn(['id' => -1]);
-
-		$userManager = $this->createMock(IUserManager::class);
-		$dbConnection = $this->createMock(IDBConnection::class);
-		$user = $this->createMock(IUser::class);
-		$user->method('getBackendClassName')->willReturn('unittest');
-		$user->method('getUID')->willReturn('test-user');
-		$user->method('getCloudId')->willReturn('cloudId');
-		$user->method('getDisplayName')->willReturn('test-user');
-		$user->method('isEnabled')->willReturn($activated);
-		$converter = $this->createMock(Converter::class);
-		$converter->expects($this->any())
-			->method('createCardFromUser')
-			->willReturn($this->createMock(VCard::class));
-
-		$clientService = $this->createMock(IClientService::class);
-		$config = $this->createMock(IConfig::class);
-
-		$ss = new SyncService($backend, $userManager, $dbConnection, $logger, $converter, $clientService, $config);
-		$ss->updateUser($user);
-
-		$ss->updateUser($user);
-
-		$ss->deleteUser($user);
-	}
-
-	public function testDeleteAddressbookWhenAccessRevoked(): void {
-		$this->expectException(ClientExceptionInterface::class);
-
-		$this->backend->expects($this->exactly(0))
-			->method('createCard');
-		$this->backend->expects($this->exactly(0))
-			->method('updateCard');
-		$this->backend->expects($this->exactly(0))
-			->method('deleteCard');
-		$this->backend->expects($this->exactly(1))
-			->method('deleteAddressBook');
-
-		$request = new PsrRequest(
-			'REPORT',
-			'https://server2.internal/remote.php/dav/addressbooks/system/system/system',
-			['Content-Type' => 'application/xml'],
-		);
-
-		$body = '<?xml version="1.0" encoding="utf-8"?>
+        $reportResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->willReturn($reportResponse);
+
+        $token = $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+
+        $this->assertEquals('http://sabre.io/ns/sync/4', $token);
+    }
+
+    public function testEnsureSystemAddressBookExists(): void {
+        /** @var CardDavBackend&MockObject $backend */
+        $backend = $this->createMock(CardDavBackend::class);
+        $backend->expects($this->exactly(1))->method('createAddressBook');
+        $backend->expects($this->exactly(2))
+            ->method('getAddressBooksByUri')
+            ->willReturnOnConsecutiveCalls(
+                null,
+                [],
+            );
+
+        $userManager = $this->createMock(IUserManager::class);
+        $dbConnection = $this->createMock(IDBConnection::class);
+        $logger = $this->createMock(LoggerInterface::class);
+        $converter = $this->createMock(Converter::class);
+        $clientService = $this->createMock(IClientService::class);
+        $config = $this->createMock(IConfig::class);
+
+        $ss = new SyncService($backend, $userManager, $dbConnection, $logger, $converter, $clientService, $config);
+        $ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
+    }
+
+    public static function dataActivatedUsers(): array {
+        return [
+            [true, 1, 1, 1],
+            [false, 0, 0, 3],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataActivatedUsers')]
+    public function testUpdateAndDeleteUser(bool $activated, int $createCalls, int $updateCalls, int $deleteCalls): void {
+        /** @var CardDavBackend | MockObject $backend */
+        $backend = $this->getMockBuilder(CardDavBackend::class)->disableOriginalConstructor()->getMock();
+        $logger = $this->getMockBuilder(LoggerInterface::class)->disableOriginalConstructor()->getMock();
+
+        $backend->expects($this->exactly($createCalls))->method('createCard');
+        $backend->expects($this->exactly($updateCalls))->method('updateCard');
+        $backend->expects($this->exactly($deleteCalls))->method('deleteCard');
+
+        $backend->method('getCard')->willReturnOnConsecutiveCalls(false, [
+            'carddata' => "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n"
+        ]);
+
+        $backend->method('getAddressBooksByUri')
+            ->with('principals/system/system', 'system')
+            ->willReturn(['id' => -1]);
+
+        $userManager = $this->createMock(IUserManager::class);
+        $dbConnection = $this->createMock(IDBConnection::class);
+        $user = $this->createMock(IUser::class);
+        $user->method('getBackendClassName')->willReturn('unittest');
+        $user->method('getUID')->willReturn('test-user');
+        $user->method('getCloudId')->willReturn('cloudId');
+        $user->method('getDisplayName')->willReturn('test-user');
+        $user->method('isEnabled')->willReturn($activated);
+        $converter = $this->createMock(Converter::class);
+        $converter->expects($this->any())
+            ->method('createCardFromUser')
+            ->willReturn($this->createMock(VCard::class));
+
+        $clientService = $this->createMock(IClientService::class);
+        $config = $this->createMock(IConfig::class);
+
+        $ss = new SyncService($backend, $userManager, $dbConnection, $logger, $converter, $clientService, $config);
+        $ss->updateUser($user);
+
+        $ss->updateUser($user);
+
+        $ss->deleteUser($user);
+    }
+
+    public function testDeleteAddressbookWhenAccessRevoked(): void {
+        $this->expectException(ClientExceptionInterface::class);
+
+        $this->backend->expects($this->exactly(0))
+            ->method('createCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('updateCard');
+        $this->backend->expects($this->exactly(0))
+            ->method('deleteCard');
+        $this->backend->expects($this->exactly(1))
+            ->method('deleteAddressBook');
+
+        $request = new PsrRequest(
+            'REPORT',
+            'https://server2.internal/remote.php/dav/addressbooks/system/system/system',
+            ['Content-Type' => 'application/xml'],
+        );
+
+        $body = '<?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
   <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
   <s:message>No public access to this resource., Username or password was incorrect, No \'Authorization: Bearer\' header found. Either the client didn\'t send one, or the server is mis-configured, Username or password was incorrect</s:message>
 </d:error>';
 
-		$response = new PsrResponse(
-			401,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		);
+        $response = new PsrResponse(
+            401,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        );
 
-		$message = 'Client error: `REPORT https://server2.internal/cloud/remote.php/dav/addressbooks/system/system/system` resulted in a `401 Unauthorized` response:
+        $message = 'Client error: `REPORT https://server2.internal/cloud/remote.php/dav/addressbooks/system/system/system` resulted in a `401 Unauthorized` response:
 <?xml version="1.0" encoding="utf-8"?>
 <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
   <s:exception>Sabre\DA (truncated...)
 ';
 
-		$reportException = new ClientException(
-			$message,
-			$request,
-			$response
-		);
-
-		$this->client
-			->method('request')
-			->willThrowException($reportException);
-
-		$this->service->syncRemoteAddressBook(
-			'',
-			'system',
-			'system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providerUseAbsoluteUriReport')]
-	public function testUseAbsoluteUriReport(string $host, string $expected): void {
-		$body = '<?xml version="1.0"?>
+        $reportException = new ClientException(
+            $message,
+            $request,
+            $response
+        );
+
+        $this->client
+            ->method('request')
+            ->willThrowException($reportException);
+
+        $this->service->syncRemoteAddressBook(
+            '',
+            'system',
+            'system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providerUseAbsoluteUriReport')]
+    public function testUseAbsoluteUriReport(string $host, string $expected): void {
+        $body = '<?xml version="1.0"?>
 <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
     <d:sync-token>http://sabre.io/ns/sync/1</d:sync-token>
 </d:multistatus>';
 
-		$requestResponse = new Response(new PsrResponse(
-			207,
-			['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
-			$body
-		));
-
-		$this->client
-			->method('request')
-			->with(
-				'REPORT',
-				$this->callback(function ($uri) use ($expected) {
-					$this->assertEquals($expected, $uri);
-					return true;
-				}),
-				$this->callback(function ($options) {
-					$this->assertIsArray($options);
-					return true;
-				}),
-			)
-			->willReturn($requestResponse);
-
-		$this->service->syncRemoteAddressBook(
-			$host,
-			'system',
-			'remote.php/dav/addressbooks/system/system/system',
-			'1234567890',
-			null,
-			'1',
-			'principals/system/system',
-			[]
-		);
-	}
-
-	public static function providerUseAbsoluteUriReport(): array {
-		return [
-			['https://server.internal', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/nextcloud', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal/nextcloud/', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/nextcloud', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-			['https://server.internal:8080/nextcloud/', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
-		];
-	}
+        $requestResponse = new Response(new PsrResponse(
+            207,
+            ['Content-Type' => 'application/xml; charset=utf-8', 'Content-Length' => strlen($body)],
+            $body
+        ));
+
+        $this->client
+            ->method('request')
+            ->with(
+                'REPORT',
+                $this->callback(function ($uri) use ($expected) {
+                    $this->assertEquals($expected, $uri);
+                    return true;
+                }),
+                $this->callback(function ($options) {
+                    $this->assertIsArray($options);
+                    return true;
+                }),
+            )
+            ->willReturn($requestResponse);
+
+        $this->service->syncRemoteAddressBook(
+            $host,
+            'system',
+            'remote.php/dav/addressbooks/system/system/system',
+            '1234567890',
+            null,
+            '1',
+            'principals/system/system',
+            []
+        );
+    }
+
+    public static function providerUseAbsoluteUriReport(): array {
+        return [
+            ['https://server.internal', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/', 'https://server.internal/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/nextcloud', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal/nextcloud/', 'https://server.internal/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/', 'https://server.internal:8080/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/nextcloud', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+            ['https://server.internal:8080/nextcloud/', 'https://server.internal:8080/nextcloud/remote.php/dav/addressbooks/system/system/system'],
+        ];
+    }
 }

apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php

Indentation +147 added lines, -147 removed lines

@@ -24,151 +24,151 @@
 use Test\TestCase;
 
 class ImageExportPluginTest extends TestCase {
-	private ResponseInterface&MockObject $response;
-	private RequestInterface&MockObject $request;
-	private Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private PhotoCache&MockObject $cache;
-	private ImageExportPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->response = $this->createMock(ResponseInterface::class);
-		$this->server = $this->createMock(Server::class);
-		$this->tree = $this->createMock(Tree::class);
-		$this->server->tree = $this->tree;
-		$this->cache = $this->createMock(PhotoCache::class);
-
-		$this->plugin = new ImageExportPlugin($this->cache);
-		$this->plugin->initialize($this->server);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesQueryParams')]
-	public function testQueryParams(array $param): void {
-		$this->request->expects($this->once())->method('getQueryParameters')->willReturn($param);
-		$result = $this->plugin->httpGet($this->request, $this->response);
-		$this->assertTrue($result);
-	}
-
-	public static function providesQueryParams(): array {
-		return [
-			[[]],
-			[['1']],
-			[['foo' => 'bar']],
-		];
-	}
-
-	public function testNoCard(): void {
-		$this->request->method('getQueryParameters')
-			->willReturn([
-				'photo'
-			]);
-		$this->request->method('getPath')
-			->willReturn('user/book/card');
-
-		$node = $this->createMock(Node::class);
-		$this->tree->method('getNodeForPath')
-			->with('user/book/card')
-			->willReturn($node);
-
-		$result = $this->plugin->httpGet($this->request, $this->response);
-		$this->assertTrue($result);
-	}
-
-	public static function dataTestCard(): array {
-		return [
-			[null, false],
-			[null, true],
-			[32, false],
-			[32, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCard')]
-	public function testCard(?int $size, bool $photo): void {
-		$query = ['photo' => null];
-		if ($size !== null) {
-			$query['size'] = $size;
-		}
-
-		$this->request->method('getQueryParameters')
-			->willReturn($query);
-		$this->request->method('getPath')
-			->willReturn('user/book/card');
-
-		$card = $this->createMock(Card::class);
-		$card->method('getETag')
-			->willReturn('"myEtag"');
-		$card->method('getName')
-			->willReturn('card');
-		$book = $this->createMock(AddressBook::class);
-		$book->method('getResourceId')
-			->willReturn(1);
-
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($path) use ($card, $book) {
-				if ($path === 'user/book/card') {
-					return $card;
-				} elseif ($path === 'user/book') {
-					return $book;
-				}
-				$this->fail();
-			});
-
-		$size = $size === null ? -1 : $size;
-
-		if ($photo) {
-			$file = $this->createMock(ISimpleFile::class);
-			$file->method('getMimeType')
-				->willReturn('image/jpeg');
-			$file->method('getContent')
-				->willReturn('imgdata');
-
-			$this->cache->method('get')
-				->with(1, 'card', $size, $card)
-				->willReturn($file);
-
-			$setHeaderCalls = [
-				['Cache-Control', 'private, max-age=3600, must-revalidate'],
-				['Etag', '"myEtag"'],
-				['Content-Type', 'image/jpeg'],
-				['Content-Disposition', 'attachment; filename=card.jpg'],
-			];
-			$this->response->expects($this->exactly(count($setHeaderCalls)))
-				->method('setHeader')
-				->willReturnCallback(function () use (&$setHeaderCalls): void {
-					$expected = array_shift($setHeaderCalls);
-					$this->assertEquals($expected, func_get_args());
-				});
-
-			$this->response->expects($this->once())
-				->method('setStatus')
-				->with(200);
-			$this->response->expects($this->once())
-				->method('setBody')
-				->with('imgdata');
-		} else {
-			$setHeaderCalls = [
-				['Cache-Control', 'private, max-age=3600, must-revalidate'],
-				['Etag', '"myEtag"'],
-			];
-			$this->response->expects($this->exactly(count($setHeaderCalls)))
-				->method('setHeader')
-				->willReturnCallback(function () use (&$setHeaderCalls): void {
-					$expected = array_shift($setHeaderCalls);
-					$this->assertEquals($expected, func_get_args());
-				});
-			$this->cache->method('get')
-				->with(1, 'card', $size, $card)
-				->willThrowException(new NotFoundException());
-			$this->response->expects($this->once())
-				->method('setStatus')
-				->with(Http::STATUS_NO_CONTENT);
-		}
-
-		$result = $this->plugin->httpGet($this->request, $this->response);
-		$this->assertFalse($result);
-	}
+    private ResponseInterface&MockObject $response;
+    private RequestInterface&MockObject $request;
+    private Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private PhotoCache&MockObject $cache;
+    private ImageExportPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->response = $this->createMock(ResponseInterface::class);
+        $this->server = $this->createMock(Server::class);
+        $this->tree = $this->createMock(Tree::class);
+        $this->server->tree = $this->tree;
+        $this->cache = $this->createMock(PhotoCache::class);
+
+        $this->plugin = new ImageExportPlugin($this->cache);
+        $this->plugin->initialize($this->server);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesQueryParams')]
+    public function testQueryParams(array $param): void {
+        $this->request->expects($this->once())->method('getQueryParameters')->willReturn($param);
+        $result = $this->plugin->httpGet($this->request, $this->response);
+        $this->assertTrue($result);
+    }
+
+    public static function providesQueryParams(): array {
+        return [
+            [[]],
+            [['1']],
+            [['foo' => 'bar']],
+        ];
+    }
+
+    public function testNoCard(): void {
+        $this->request->method('getQueryParameters')
+            ->willReturn([
+                'photo'
+            ]);
+        $this->request->method('getPath')
+            ->willReturn('user/book/card');
+
+        $node = $this->createMock(Node::class);
+        $this->tree->method('getNodeForPath')
+            ->with('user/book/card')
+            ->willReturn($node);
+
+        $result = $this->plugin->httpGet($this->request, $this->response);
+        $this->assertTrue($result);
+    }
+
+    public static function dataTestCard(): array {
+        return [
+            [null, false],
+            [null, true],
+            [32, false],
+            [32, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCard')]
+    public function testCard(?int $size, bool $photo): void {
+        $query = ['photo' => null];
+        if ($size !== null) {
+            $query['size'] = $size;
+        }
+
+        $this->request->method('getQueryParameters')
+            ->willReturn($query);
+        $this->request->method('getPath')
+            ->willReturn('user/book/card');
+
+        $card = $this->createMock(Card::class);
+        $card->method('getETag')
+            ->willReturn('"myEtag"');
+        $card->method('getName')
+            ->willReturn('card');
+        $book = $this->createMock(AddressBook::class);
+        $book->method('getResourceId')
+            ->willReturn(1);
+
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($path) use ($card, $book) {
+                if ($path === 'user/book/card') {
+                    return $card;
+                } elseif ($path === 'user/book') {
+                    return $book;
+                }
+                $this->fail();
+            });
+
+        $size = $size === null ? -1 : $size;
+
+        if ($photo) {
+            $file = $this->createMock(ISimpleFile::class);
+            $file->method('getMimeType')
+                ->willReturn('image/jpeg');
+            $file->method('getContent')
+                ->willReturn('imgdata');
+
+            $this->cache->method('get')
+                ->with(1, 'card', $size, $card)
+                ->willReturn($file);
+
+            $setHeaderCalls = [
+                ['Cache-Control', 'private, max-age=3600, must-revalidate'],
+                ['Etag', '"myEtag"'],
+                ['Content-Type', 'image/jpeg'],
+                ['Content-Disposition', 'attachment; filename=card.jpg'],
+            ];
+            $this->response->expects($this->exactly(count($setHeaderCalls)))
+                ->method('setHeader')
+                ->willReturnCallback(function () use (&$setHeaderCalls): void {
+                    $expected = array_shift($setHeaderCalls);
+                    $this->assertEquals($expected, func_get_args());
+                });
+
+            $this->response->expects($this->once())
+                ->method('setStatus')
+                ->with(200);
+            $this->response->expects($this->once())
+                ->method('setBody')
+                ->with('imgdata');
+        } else {
+            $setHeaderCalls = [
+                ['Cache-Control', 'private, max-age=3600, must-revalidate'],
+                ['Etag', '"myEtag"'],
+            ];
+            $this->response->expects($this->exactly(count($setHeaderCalls)))
+                ->method('setHeader')
+                ->willReturnCallback(function () use (&$setHeaderCalls): void {
+                    $expected = array_shift($setHeaderCalls);
+                    $this->assertEquals($expected, func_get_args());
+                });
+            $this->cache->method('get')
+                ->with(1, 'card', $size, $card)
+                ->willThrowException(new NotFoundException());
+            $this->response->expects($this->once())
+                ->method('setStatus')
+                ->with(Http::STATUS_NO_CONTENT);
+        }
+
+        $result = $this->plugin->httpGet($this->request, $this->response);
+        $this->assertFalse($result);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -108,7 +108,7 @@ 
 			->willReturn(1);
 
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($path) use ($card, $book) {
+			->willReturnCallback(function($path) use ($card, $book) {
 				if ($path === 'user/book/card') {
 					return $card;
 				} elseif ($path === 'user/book') {
@@ -138,7 +138,7 @@ 
 			];
 			$this->response->expects($this->exactly(count($setHeaderCalls)))
 				->method('setHeader')
-				->willReturnCallback(function () use (&$setHeaderCalls): void {
+				->willReturnCallback(function() use (&$setHeaderCalls): void {
 					$expected = array_shift($setHeaderCalls);
 					$this->assertEquals($expected, func_get_args());
 				});
@@ -156,7 +156,7 @@ 
 			];
 			$this->response->expects($this->exactly(count($setHeaderCalls)))
 				->method('setHeader')
-				->willReturnCallback(function () use (&$setHeaderCalls): void {
+				->willReturnCallback(function() use (&$setHeaderCalls): void {
 					$expected = array_shift($setHeaderCalls);
 					$this->assertEquals($expected, func_get_args());
 				});

apps/dav/tests/unit/CardDAV/ConverterTest.php

Indentation +196 added lines, -196 removed lines

@@ -22,200 +22,200 @@
 use Test\TestCase;
 
 class ConverterTest extends TestCase {
-	private IAccountManager&MockObject $accountManager;
-	private IUserManager&MockObject $userManager;
-	private IURLGenerator&MockObject $urlGenerator;
-	private LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->accountManager = $this->createMock(IAccountManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-	}
-
-	/**
-	 * @return IAccountProperty&MockObject
-	 */
-	protected function getAccountPropertyMock(string $name, ?string $value, string $scope) {
-		$property = $this->createMock(IAccountProperty::class);
-		$property->expects($this->any())
-			->method('getName')
-			->willReturn($name);
-		$property->expects($this->any())
-			->method('getValue')
-			->willReturn((string)$value);
-		$property->expects($this->any())
-			->method('getScope')
-			->willReturn($scope);
-		$property->expects($this->any())
-			->method('getVerified')
-			->willReturn(IAccountManager::NOT_VERIFIED);
-		return $property;
-	}
-
-	public function getAccountManager(IUser $user) {
-		$account = $this->createMock(IAccount::class);
-		$account->expects($this->any())
-			->method('getAllProperties')
-			->willReturnCallback(function () use ($user) {
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_DISPLAYNAME, $user->getDisplayName(), IAccountManager::SCOPE_FEDERATED);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_ADDRESS, '', IAccountManager::SCOPE_LOCAL);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_WEBSITE, '', IAccountManager::SCOPE_LOCAL);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_EMAIL, $user->getEMailAddress(), IAccountManager::SCOPE_FEDERATED);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_AVATAR, $user->getAvatarImage(-1)->data(), IAccountManager::SCOPE_FEDERATED);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_PHONE, '', IAccountManager::SCOPE_LOCAL);
-				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_TWITTER, '', IAccountManager::SCOPE_LOCAL);
-			});
-
-		$accountManager = $this->createMock(IAccountManager::class);
-
-		$accountManager->expects($this->any())
-			->method('getAccount')
-			->willReturn($account);
-
-		return $accountManager;
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesNewUsers')]
-	public function testCreation($expectedVCard, $displayName = null, $eMailAddress = null, $cloudId = null): void {
-		$user = $this->getUserMock((string)$displayName, $eMailAddress, $cloudId);
-		$accountManager = $this->getAccountManager($user);
-
-		$converter = new Converter($accountManager, $this->userManager, $this->urlGenerator, $this->logger);
-		$vCard = $converter->createCardFromUser($user);
-		if ($expectedVCard !== null) {
-			$this->assertInstanceOf('Sabre\VObject\Component\VCard', $vCard);
-			$cardData = $vCard->jsonSerialize();
-			$this->compareData($expectedVCard, $cardData);
-		} else {
-			$this->assertSame($expectedVCard, $vCard);
-		}
-	}
-
-	public function testManagerProp(): void {
-		$user = $this->getUserMock('user', 'user@domain.tld', 'user@cloud.domain.tld');
-		$user->method('getManagerUids')
-			->willReturn(['mgr']);
-		$this->userManager->expects(self::once())
-			->method('getDisplayName')
-			->with('mgr')
-			->willReturn('Manager');
-		$accountManager = $this->getAccountManager($user);
-
-		$converter = new Converter($accountManager, $this->userManager, $this->urlGenerator, $this->logger);
-		$vCard = $converter->createCardFromUser($user);
-
-		$this->compareData(
-			[
-				'cloud' => 'user@cloud.domain.tld',
-				'email' => 'user@domain.tld',
-				'x-managersname' => 'Manager',
-			],
-			$vCard->jsonSerialize()
-		);
-	}
-
-	protected function compareData(array $expected, array $data): void {
-		foreach ($expected as $key => $value) {
-			$found = false;
-			foreach ($data[1] as $d) {
-				if ($d[0] === $key && $d[3] === $value) {
-					$found = true;
-					break;
-				}
-			}
-			if (!$found) {
-				$this->assertTrue(false, 'Expected data: ' . $key . ' not found.');
-			}
-		}
-	}
-
-	public static function providesNewUsers(): array {
-		return [
-			[
-				null
-			],
-			[
-				null,
-				null,
-				'foo@bar.net'
-			],
-			[
-				[
-					'cloud' => 'foo@cloud.net',
-					'email' => 'foo@bar.net',
-					'photo' => 'MTIzNDU2Nzg5',
-				],
-				null,
-				'foo@bar.net',
-				'foo@cloud.net'
-			],
-			[
-				[
-					'cloud' => 'foo@cloud.net',
-					'email' => 'foo@bar.net',
-					'fn' => 'Dr. Foo Bar',
-					'photo' => 'MTIzNDU2Nzg5',
-				],
-				'Dr. Foo Bar',
-				'foo@bar.net',
-				'foo@cloud.net'
-			],
-			[
-				[
-					'cloud' => 'foo@cloud.net',
-					'fn' => 'Dr. Foo Bar',
-					'photo' => 'MTIzNDU2Nzg5',
-				],
-				'Dr. Foo Bar',
-				null,
-				'foo@cloud.net'
-			],
-			[
-				[
-					'cloud' => 'foo@cloud.net',
-					'fn' => 'Dr. Foo Bar',
-					'photo' => 'MTIzNDU2Nzg5',
-				],
-				'Dr. Foo Bar',
-				'',
-				'foo@cloud.net'
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesNames')]
-	public function testNameSplitter(string $expected, string $fullName): void {
-		$converter = new Converter($this->accountManager, $this->userManager, $this->urlGenerator, $this->logger);
-		$r = $converter->splitFullName($fullName);
-		$r = implode(';', $r);
-		$this->assertEquals($expected, $r);
-	}
-
-	public static function providesNames(): array {
-		return [
-			['Sauron;;;;', 'Sauron'],
-			['Baggins;Bilbo;;;', 'Bilbo Baggins'],
-			['Tolkien;John;Ronald Reuel;;', 'John Ronald Reuel Tolkien'],
-		];
-	}
-
-	/**
-	 * @return IUser&MockObject
-	 */
-	protected function getUserMock(string $displayName, ?string $eMailAddress, ?string $cloudId) {
-		$image0 = $this->createMock(IImage::class);
-		$image0->method('mimeType')->willReturn('image/jpeg');
-		$image0->method('data')->willReturn('123456789');
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('12345');
-		$user->method('getDisplayName')->willReturn($displayName);
-		$user->method('getEMailAddress')->willReturn($eMailAddress);
-		$user->method('getCloudId')->willReturn($cloudId);
-		$user->method('getAvatarImage')->willReturn($image0);
-		return $user;
-	}
+    private IAccountManager&MockObject $accountManager;
+    private IUserManager&MockObject $userManager;
+    private IURLGenerator&MockObject $urlGenerator;
+    private LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->accountManager = $this->createMock(IAccountManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+    }
+
+    /**
+     * @return IAccountProperty&MockObject
+     */
+    protected function getAccountPropertyMock(string $name, ?string $value, string $scope) {
+        $property = $this->createMock(IAccountProperty::class);
+        $property->expects($this->any())
+            ->method('getName')
+            ->willReturn($name);
+        $property->expects($this->any())
+            ->method('getValue')
+            ->willReturn((string)$value);
+        $property->expects($this->any())
+            ->method('getScope')
+            ->willReturn($scope);
+        $property->expects($this->any())
+            ->method('getVerified')
+            ->willReturn(IAccountManager::NOT_VERIFIED);
+        return $property;
+    }
+
+    public function getAccountManager(IUser $user) {
+        $account = $this->createMock(IAccount::class);
+        $account->expects($this->any())
+            ->method('getAllProperties')
+            ->willReturnCallback(function () use ($user) {
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_DISPLAYNAME, $user->getDisplayName(), IAccountManager::SCOPE_FEDERATED);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_ADDRESS, '', IAccountManager::SCOPE_LOCAL);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_WEBSITE, '', IAccountManager::SCOPE_LOCAL);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_EMAIL, $user->getEMailAddress(), IAccountManager::SCOPE_FEDERATED);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_AVATAR, $user->getAvatarImage(-1)->data(), IAccountManager::SCOPE_FEDERATED);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_PHONE, '', IAccountManager::SCOPE_LOCAL);
+                yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_TWITTER, '', IAccountManager::SCOPE_LOCAL);
+            });
+
+        $accountManager = $this->createMock(IAccountManager::class);
+
+        $accountManager->expects($this->any())
+            ->method('getAccount')
+            ->willReturn($account);
+
+        return $accountManager;
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesNewUsers')]
+    public function testCreation($expectedVCard, $displayName = null, $eMailAddress = null, $cloudId = null): void {
+        $user = $this->getUserMock((string)$displayName, $eMailAddress, $cloudId);
+        $accountManager = $this->getAccountManager($user);
+
+        $converter = new Converter($accountManager, $this->userManager, $this->urlGenerator, $this->logger);
+        $vCard = $converter->createCardFromUser($user);
+        if ($expectedVCard !== null) {
+            $this->assertInstanceOf('Sabre\VObject\Component\VCard', $vCard);
+            $cardData = $vCard->jsonSerialize();
+            $this->compareData($expectedVCard, $cardData);
+        } else {
+            $this->assertSame($expectedVCard, $vCard);
+        }
+    }
+
+    public function testManagerProp(): void {
+        $user = $this->getUserMock('user', 'user@domain.tld', 'user@cloud.domain.tld');
+        $user->method('getManagerUids')
+            ->willReturn(['mgr']);
+        $this->userManager->expects(self::once())
+            ->method('getDisplayName')
+            ->with('mgr')
+            ->willReturn('Manager');
+        $accountManager = $this->getAccountManager($user);
+
+        $converter = new Converter($accountManager, $this->userManager, $this->urlGenerator, $this->logger);
+        $vCard = $converter->createCardFromUser($user);
+
+        $this->compareData(
+            [
+                'cloud' => 'user@cloud.domain.tld',
+                'email' => 'user@domain.tld',
+                'x-managersname' => 'Manager',
+            ],
+            $vCard->jsonSerialize()
+        );
+    }
+
+    protected function compareData(array $expected, array $data): void {
+        foreach ($expected as $key => $value) {
+            $found = false;
+            foreach ($data[1] as $d) {
+                if ($d[0] === $key && $d[3] === $value) {
+                    $found = true;
+                    break;
+                }
+            }
+            if (!$found) {
+                $this->assertTrue(false, 'Expected data: ' . $key . ' not found.');
+            }
+        }
+    }
+
+    public static function providesNewUsers(): array {
+        return [
+            [
+                null
+            ],
+            [
+                null,
+                null,
+                'foo@bar.net'
+            ],
+            [
+                [
+                    'cloud' => 'foo@cloud.net',
+                    'email' => 'foo@bar.net',
+                    'photo' => 'MTIzNDU2Nzg5',
+                ],
+                null,
+                'foo@bar.net',
+                'foo@cloud.net'
+            ],
+            [
+                [
+                    'cloud' => 'foo@cloud.net',
+                    'email' => 'foo@bar.net',
+                    'fn' => 'Dr. Foo Bar',
+                    'photo' => 'MTIzNDU2Nzg5',
+                ],
+                'Dr. Foo Bar',
+                'foo@bar.net',
+                'foo@cloud.net'
+            ],
+            [
+                [
+                    'cloud' => 'foo@cloud.net',
+                    'fn' => 'Dr. Foo Bar',
+                    'photo' => 'MTIzNDU2Nzg5',
+                ],
+                'Dr. Foo Bar',
+                null,
+                'foo@cloud.net'
+            ],
+            [
+                [
+                    'cloud' => 'foo@cloud.net',
+                    'fn' => 'Dr. Foo Bar',
+                    'photo' => 'MTIzNDU2Nzg5',
+                ],
+                'Dr. Foo Bar',
+                '',
+                'foo@cloud.net'
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesNames')]
+    public function testNameSplitter(string $expected, string $fullName): void {
+        $converter = new Converter($this->accountManager, $this->userManager, $this->urlGenerator, $this->logger);
+        $r = $converter->splitFullName($fullName);
+        $r = implode(';', $r);
+        $this->assertEquals($expected, $r);
+    }
+
+    public static function providesNames(): array {
+        return [
+            ['Sauron;;;;', 'Sauron'],
+            ['Baggins;Bilbo;;;', 'Bilbo Baggins'],
+            ['Tolkien;John;Ronald Reuel;;', 'John Ronald Reuel Tolkien'],
+        ];
+    }
+
+    /**
+     * @return IUser&MockObject
+     */
+    protected function getUserMock(string $displayName, ?string $eMailAddress, ?string $cloudId) {
+        $image0 = $this->createMock(IImage::class);
+        $image0->method('mimeType')->willReturn('image/jpeg');
+        $image0->method('data')->willReturn('123456789');
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('12345');
+        $user->method('getDisplayName')->willReturn($displayName);
+        $user->method('getEMailAddress')->willReturn($eMailAddress);
+        $user->method('getCloudId')->willReturn($cloudId);
+        $user->method('getAvatarImage')->willReturn($image0);
+        return $user;
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
 			->willReturn($name);
 		$property->expects($this->any())
 			->method('getValue')
-			->willReturn((string)$value);
+			->willReturn((string) $value);
 		$property->expects($this->any())
 			->method('getScope')
 			->willReturn($scope);
@@ -60,7 +60,7 @@ 
 		$account = $this->createMock(IAccount::class);
 		$account->expects($this->any())
 			->method('getAllProperties')
-			->willReturnCallback(function () use ($user) {
+			->willReturnCallback(function() use ($user) {
 				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_DISPLAYNAME, $user->getDisplayName(), IAccountManager::SCOPE_FEDERATED);
 				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_ADDRESS, '', IAccountManager::SCOPE_LOCAL);
 				yield $this->getAccountPropertyMock(IAccountManager::PROPERTY_WEBSITE, '', IAccountManager::SCOPE_LOCAL);
@@ -81,7 +81,7 @@ 
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('providesNewUsers')]
 	public function testCreation($expectedVCard, $displayName = null, $eMailAddress = null, $cloudId = null): void {
-		$user = $this->getUserMock((string)$displayName, $eMailAddress, $cloudId);
+		$user = $this->getUserMock((string) $displayName, $eMailAddress, $cloudId);
 		$accountManager = $this->getAccountManager($user);
 
 		$converter = new Converter($accountManager, $this->userManager, $this->urlGenerator, $this->logger);
@@ -128,7 +128,7 @@ 
 				}
 			}
 			if (!$found) {
-				$this->assertTrue(false, 'Expected data: ' . $key . ' not found.');
+				$this->assertTrue(false, 'Expected data: '.$key.' not found.');
 			}
 		}
 	}

apps/dav/tests/unit/CardDAV/Activity/BackendTest.php

Indentation +458 added lines, -458 removed lines

@@ -22,462 +22,462 @@
 use Test\TestCase;
 
 class BackendTest extends TestCase {
-	protected IManager&MockObject $activityManager;
-	protected IGroupManager&MockObject $groupManager;
-	protected IUserSession&MockObject $userSession;
-	protected IAppManager&MockObject $appManager;
-	protected IUserManager&MockObject $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->activityManager = $this->createMock(IManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-	}
-
-	/**
-	 * @return Backend|MockObject
-	 */
-	protected function getBackend(array $methods = []): Backend {
-		if (empty($methods)) {
-			return new Backend(
-				$this->activityManager,
-				$this->groupManager,
-				$this->userSession,
-				$this->appManager,
-				$this->userManager
-			);
-		} else {
-			return $this->getMockBuilder(Backend::class)
-				->setConstructorArgs([
-					$this->activityManager,
-					$this->groupManager,
-					$this->userSession,
-					$this->appManager,
-					$this->userManager
-				])
-				->onlyMethods($methods)
-				->getMock();
-		}
-	}
-
-	public static function dataCallTriggerAddressBookActivity(): array {
-		return [
-			['onAddressbookCreate', [['data']], Addressbook::SUBJECT_ADD, [['data'], [], []]],
-			['onAddressbookUpdate', [['data'], ['shares'], ['changed-properties']], Addressbook::SUBJECT_UPDATE, [['data'], ['shares'], ['changed-properties']]],
-			['onAddressbookDelete', [['data'], ['shares']], Addressbook::SUBJECT_DELETE, [['data'], ['shares'], []]],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataCallTriggerAddressBookActivity')]
-	public function testCallTriggerAddressBookActivity(string $method, array $payload, string $expectedSubject, array $expectedPayload): void {
-		$backend = $this->getBackend(['triggerAddressbookActivity']);
-		$backend->expects($this->once())
-			->method('triggerAddressbookActivity')
-			->willReturnCallback(function () use ($expectedPayload, $expectedSubject): void {
-				$arguments = func_get_args();
-				$this->assertSame($expectedSubject, array_shift($arguments));
-				$this->assertEquals($expectedPayload, $arguments);
-			});
-
-		call_user_func_array([$backend, $method], $payload);
-	}
-
-	public static function dataTriggerAddressBookActivity(): array {
-		return [
-			// Add addressbook
-			[Addressbook::SUBJECT_ADD, [], [], [], '', '', null, []],
-			[Addressbook::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], [], [], '', 'admin', null, ['admin']],
-			[Addressbook::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], [], [], 'test2', 'test2', null, ['admin']],
-
-			// Update addressbook
-			[Addressbook::SUBJECT_UPDATE, [], [], [], '', '', null, []],
-			// No visible change - owner only
-			[Addressbook::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], [], '', 'admin', null, ['admin']],
-			// Visible change
-			[Addressbook::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['{DAV:}displayname' => 'Name'], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Addressbook::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['{DAV:}displayname' => 'Name'], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-
-			// Delete addressbook
-			[Addressbook::SUBJECT_DELETE, [], [], [], '', '', null, []],
-			[Addressbook::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], [], '', 'admin', [], ['admin']],
-			[Addressbook::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], [], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Addressbook::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], [], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-		];
-	}
-
-	/**
-	 * @param string[]|null $shareUsers
-	 * @param string[] $users
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerAddressBookActivity')]
-	public function testTriggerAddressBookActivity(string $action, array $data, array $shares, array $changedProperties, string $currentUser, string $author, ?array $shareUsers, array $users): void {
-		$backend = $this->getBackend(['getUsersForShares']);
-
-		if ($shareUsers === null) {
-			$backend->expects($this->never())
-				->method('getUsersForShares');
-		} else {
-			$backend->expects($this->once())
-				->method('getUsersForShares')
-				->with($shares)
-				->willReturn($shareUsers);
-		}
-
-		if ($author !== '') {
-			if ($currentUser !== '') {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($this->getUserMock($currentUser));
-			} else {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn(null);
-			}
-
-			$event = $this->createMock(IEvent::class);
-			$this->activityManager->expects($this->once())
-				->method('generateEvent')
-				->willReturn($event);
-
-			$event->expects($this->once())
-				->method('setApp')
-				->with('dav')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setObject')
-				->with('addressbook', $data['id'])
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setType')
-				->with('contacts')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setAuthor')
-				->with($author)
-				->willReturnSelf();
-
-			$this->userManager->expects($action === Addressbook::SUBJECT_DELETE ? $this->exactly(sizeof($users)) : $this->never())
-				->method('userExists')
-				->willReturn(true);
-
-			$event->expects($this->exactly(count($users)))
-				->method('setAffectedUser')
-				->willReturnSelf();
-			$event->expects($this->exactly(count($users)))
-				->method('setSubject')
-				->willReturnSelf();
-			$this->activityManager->expects($this->exactly(count($users)))
-				->method('publish')
-				->with($event);
-		} else {
-			$this->activityManager->expects($this->never())
-				->method('generateEvent');
-		}
-
-		$this->invokePrivate($backend, 'triggerAddressbookActivity', [$action, $data, $shares, $changedProperties]);
-	}
-
-	public function testNoAddressbookActivityCreatedForSystemAddressbook(): void {
-		$backend = $this->getBackend();
-		$this->activityManager->expects($this->never())
-			->method('generateEvent');
-		$this->assertEmpty($this->invokePrivate($backend, 'triggerAddressbookActivity', [Addressbook::SUBJECT_ADD, ['principaluri' => 'principals/system/system'], [], [], '', '', null, []]));
-	}
-
-	public function testUserDeletionDoesNotCreateActivity(): void {
-		$backend = $this->getBackend();
-
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->willReturn(false);
-
-		$this->activityManager->expects($this->never())
-			->method('publish');
-
-		$this->invokePrivate($backend, 'triggerAddressbookActivity', [Addressbook::SUBJECT_DELETE, [
-			'principaluri' => 'principal/user/admin',
-			'id' => 42,
-			'uri' => 'this-uri',
-			'{DAV:}displayname' => 'Name of addressbook',
-		], [], []]);
-	}
-
-	public static function dataTriggerCardActivity(): array {
-		$cardData = "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n";
-
-		return [
-			// Add card
-			[Card::SUBJECT_ADD, [], [], [], '', '', null, []],
-			[Card::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], [], [
-				'carddata' => $cardData
-			], '', 'admin', [], ['admin']],
-			[Card::SUBJECT_ADD, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], [], ['carddata' => $cardData], 'test2', 'test2', [], ['admin']],
-
-			// Update card
-			[Card::SUBJECT_UPDATE, [], [], [], '', '', null, []],
-			// No visible change - owner only
-			[Card::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], '', 'admin', [], ['admin']],
-			// Visible change
-			[Card::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Card::SUBJECT_UPDATE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-
-			// Delete card
-			[Card::SUBJECT_DELETE, [], [], ['carddata' => $cardData], '', '', null, []],
-			[Card::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], '', 'admin', [], ['admin']],
-			[Card::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], '', 'admin', ['user1'], ['user1', 'admin']],
-			[Card::SUBJECT_DELETE, [
-				'principaluri' => 'principal/user/admin',
-				'id' => 42,
-				'uri' => 'this-uri',
-				'{DAV:}displayname' => 'Name of addressbook',
-			], ['shares'], ['carddata' => $cardData], 'test2', 'test2', ['user1'], ['user1', 'admin']],
-		];
-	}
-
-	/**
-	 * @param string[]|null $shareUsers
-	 * @param string[] $users
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerCardActivity')]
-	public function testTriggerCardActivity(string $action, array $addressBookData, array $shares, array $cardData, string $currentUser, string $author, ?array $shareUsers, array $users): void {
-		$backend = $this->getBackend(['getUsersForShares']);
-
-		if ($shareUsers === null) {
-			$backend->expects($this->never())
-				->method('getUsersForShares');
-		} else {
-			$backend->expects($this->once())
-				->method('getUsersForShares')
-				->with($shares)
-				->willReturn($shareUsers);
-		}
-
-		if ($author !== '') {
-			if ($currentUser !== '') {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn($this->getUserMock($currentUser));
-			} else {
-				$this->userSession->expects($this->once())
-					->method('getUser')
-					->willReturn(null);
-			}
-
-			$event = $this->createMock(IEvent::class);
-			$this->activityManager->expects($this->once())
-				->method('generateEvent')
-				->willReturn($event);
-
-			$event->expects($this->once())
-				->method('setApp')
-				->with('dav')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setObject')
-				->with('addressbook', $addressBookData['id'])
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setType')
-				->with('contacts')
-				->willReturnSelf();
-			$event->expects($this->once())
-				->method('setAuthor')
-				->with($author)
-				->willReturnSelf();
-
-			$event->expects($this->exactly(count($users)))
-				->method('setAffectedUser')
-				->willReturnSelf();
-			$event->expects($this->exactly(count($users)))
-				->method('setSubject')
-				->willReturnSelf();
-			$this->activityManager->expects($this->exactly(count($users)))
-				->method('publish')
-				->with($event);
-		} else {
-			$this->activityManager->expects($this->never())
-				->method('generateEvent');
-		}
-
-		$this->invokePrivate($backend, 'triggerCardActivity', [$action, $addressBookData, $shares, $cardData]);
-	}
-
-	public function testNoCardActivityCreatedForSystemAddressbook(): void {
-		$backend = $this->getBackend();
-		$this->activityManager->expects($this->never())
-			->method('generateEvent');
-		$this->assertEmpty($this->invokePrivate($backend, 'triggerCardActivity', [Card::SUBJECT_UPDATE, ['principaluri' => 'principals/system/system'], [], []]));
-	}
-
-	public static function dataGetUsersForShares(): array {
-		return [
-			[
-				[],
-				[],
-				[],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user3'],
-				],
-				[],
-				['user1', 'user2', 'user3'],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
-				],
-				['group2' => null, 'group3' => null],
-				['user1', 'user2'],
-			],
-			[
-				[
-					['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
-					['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
-				],
-				['group2' => ['user1', 'user2', 'user3'], 'group3' => ['user2', 'user3', 'user4']],
-				['user1', 'user2', 'user3', 'user4'],
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGetUsersForShares')]
-	public function testGetUsersForShares(array $shares, array $groups, array $expected): void {
-		$backend = $this->getBackend();
-
-		$getGroups = [];
-		foreach ($groups as $gid => $members) {
-			if ($members === null) {
-				$getGroups[] = [$gid, null];
-				continue;
-			}
-
-			$group = $this->createMock(IGroup::class);
-			$group->expects($this->once())
-				->method('getUsers')
-				->willReturn($this->getUsers($members));
-
-			$getGroups[] = [$gid, $group];
-		}
-
-		$this->groupManager->expects($this->exactly(sizeof($getGroups)))
-			->method('get')
-			->willReturnMap($getGroups);
-
-		$users = $this->invokePrivate($backend, 'getUsersForShares', [$shares]);
-		sort($users);
-		$this->assertEquals($expected, $users);
-	}
-
-	/**
-	 * @param string[] $users
-	 * @return IUser[]|MockObject[]
-	 */
-	protected function getUsers(array $users): array {
-		$list = [];
-		foreach ($users as $user) {
-			$list[] = $this->getUserMock($user);
-		}
-		return $list;
-	}
-
-	/**
-	 * @return IUser|MockObject
-	 */
-	protected function getUserMock(string $uid): IUser {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn($uid);
-		return $user;
-	}
+    protected IManager&MockObject $activityManager;
+    protected IGroupManager&MockObject $groupManager;
+    protected IUserSession&MockObject $userSession;
+    protected IAppManager&MockObject $appManager;
+    protected IUserManager&MockObject $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->activityManager = $this->createMock(IManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+    }
+
+    /**
+     * @return Backend|MockObject
+     */
+    protected function getBackend(array $methods = []): Backend {
+        if (empty($methods)) {
+            return new Backend(
+                $this->activityManager,
+                $this->groupManager,
+                $this->userSession,
+                $this->appManager,
+                $this->userManager
+            );
+        } else {
+            return $this->getMockBuilder(Backend::class)
+                ->setConstructorArgs([
+                    $this->activityManager,
+                    $this->groupManager,
+                    $this->userSession,
+                    $this->appManager,
+                    $this->userManager
+                ])
+                ->onlyMethods($methods)
+                ->getMock();
+        }
+    }
+
+    public static function dataCallTriggerAddressBookActivity(): array {
+        return [
+            ['onAddressbookCreate', [['data']], Addressbook::SUBJECT_ADD, [['data'], [], []]],
+            ['onAddressbookUpdate', [['data'], ['shares'], ['changed-properties']], Addressbook::SUBJECT_UPDATE, [['data'], ['shares'], ['changed-properties']]],
+            ['onAddressbookDelete', [['data'], ['shares']], Addressbook::SUBJECT_DELETE, [['data'], ['shares'], []]],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataCallTriggerAddressBookActivity')]
+    public function testCallTriggerAddressBookActivity(string $method, array $payload, string $expectedSubject, array $expectedPayload): void {
+        $backend = $this->getBackend(['triggerAddressbookActivity']);
+        $backend->expects($this->once())
+            ->method('triggerAddressbookActivity')
+            ->willReturnCallback(function () use ($expectedPayload, $expectedSubject): void {
+                $arguments = func_get_args();
+                $this->assertSame($expectedSubject, array_shift($arguments));
+                $this->assertEquals($expectedPayload, $arguments);
+            });
+
+        call_user_func_array([$backend, $method], $payload);
+    }
+
+    public static function dataTriggerAddressBookActivity(): array {
+        return [
+            // Add addressbook
+            [Addressbook::SUBJECT_ADD, [], [], [], '', '', null, []],
+            [Addressbook::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], [], [], '', 'admin', null, ['admin']],
+            [Addressbook::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], [], [], 'test2', 'test2', null, ['admin']],
+
+            // Update addressbook
+            [Addressbook::SUBJECT_UPDATE, [], [], [], '', '', null, []],
+            // No visible change - owner only
+            [Addressbook::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], [], '', 'admin', null, ['admin']],
+            // Visible change
+            [Addressbook::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['{DAV:}displayname' => 'Name'], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Addressbook::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['{DAV:}displayname' => 'Name'], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+
+            // Delete addressbook
+            [Addressbook::SUBJECT_DELETE, [], [], [], '', '', null, []],
+            [Addressbook::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], [], '', 'admin', [], ['admin']],
+            [Addressbook::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], [], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Addressbook::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], [], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+        ];
+    }
+
+    /**
+     * @param string[]|null $shareUsers
+     * @param string[] $users
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerAddressBookActivity')]
+    public function testTriggerAddressBookActivity(string $action, array $data, array $shares, array $changedProperties, string $currentUser, string $author, ?array $shareUsers, array $users): void {
+        $backend = $this->getBackend(['getUsersForShares']);
+
+        if ($shareUsers === null) {
+            $backend->expects($this->never())
+                ->method('getUsersForShares');
+        } else {
+            $backend->expects($this->once())
+                ->method('getUsersForShares')
+                ->with($shares)
+                ->willReturn($shareUsers);
+        }
+
+        if ($author !== '') {
+            if ($currentUser !== '') {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($this->getUserMock($currentUser));
+            } else {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn(null);
+            }
+
+            $event = $this->createMock(IEvent::class);
+            $this->activityManager->expects($this->once())
+                ->method('generateEvent')
+                ->willReturn($event);
+
+            $event->expects($this->once())
+                ->method('setApp')
+                ->with('dav')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setObject')
+                ->with('addressbook', $data['id'])
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setType')
+                ->with('contacts')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setAuthor')
+                ->with($author)
+                ->willReturnSelf();
+
+            $this->userManager->expects($action === Addressbook::SUBJECT_DELETE ? $this->exactly(sizeof($users)) : $this->never())
+                ->method('userExists')
+                ->willReturn(true);
+
+            $event->expects($this->exactly(count($users)))
+                ->method('setAffectedUser')
+                ->willReturnSelf();
+            $event->expects($this->exactly(count($users)))
+                ->method('setSubject')
+                ->willReturnSelf();
+            $this->activityManager->expects($this->exactly(count($users)))
+                ->method('publish')
+                ->with($event);
+        } else {
+            $this->activityManager->expects($this->never())
+                ->method('generateEvent');
+        }
+
+        $this->invokePrivate($backend, 'triggerAddressbookActivity', [$action, $data, $shares, $changedProperties]);
+    }
+
+    public function testNoAddressbookActivityCreatedForSystemAddressbook(): void {
+        $backend = $this->getBackend();
+        $this->activityManager->expects($this->never())
+            ->method('generateEvent');
+        $this->assertEmpty($this->invokePrivate($backend, 'triggerAddressbookActivity', [Addressbook::SUBJECT_ADD, ['principaluri' => 'principals/system/system'], [], [], '', '', null, []]));
+    }
+
+    public function testUserDeletionDoesNotCreateActivity(): void {
+        $backend = $this->getBackend();
+
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->willReturn(false);
+
+        $this->activityManager->expects($this->never())
+            ->method('publish');
+
+        $this->invokePrivate($backend, 'triggerAddressbookActivity', [Addressbook::SUBJECT_DELETE, [
+            'principaluri' => 'principal/user/admin',
+            'id' => 42,
+            'uri' => 'this-uri',
+            '{DAV:}displayname' => 'Name of addressbook',
+        ], [], []]);
+    }
+
+    public static function dataTriggerCardActivity(): array {
+        $cardData = "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.4.8//EN\r\nUID:test-user\r\nFN:test-user\r\nN:test-user;;;;\r\nEND:VCARD\r\n\r\n";
+
+        return [
+            // Add card
+            [Card::SUBJECT_ADD, [], [], [], '', '', null, []],
+            [Card::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], [], [
+                'carddata' => $cardData
+            ], '', 'admin', [], ['admin']],
+            [Card::SUBJECT_ADD, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], [], ['carddata' => $cardData], 'test2', 'test2', [], ['admin']],
+
+            // Update card
+            [Card::SUBJECT_UPDATE, [], [], [], '', '', null, []],
+            // No visible change - owner only
+            [Card::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], '', 'admin', [], ['admin']],
+            // Visible change
+            [Card::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Card::SUBJECT_UPDATE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+
+            // Delete card
+            [Card::SUBJECT_DELETE, [], [], ['carddata' => $cardData], '', '', null, []],
+            [Card::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], '', 'admin', [], ['admin']],
+            [Card::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], '', 'admin', ['user1'], ['user1', 'admin']],
+            [Card::SUBJECT_DELETE, [
+                'principaluri' => 'principal/user/admin',
+                'id' => 42,
+                'uri' => 'this-uri',
+                '{DAV:}displayname' => 'Name of addressbook',
+            ], ['shares'], ['carddata' => $cardData], 'test2', 'test2', ['user1'], ['user1', 'admin']],
+        ];
+    }
+
+    /**
+     * @param string[]|null $shareUsers
+     * @param string[] $users
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTriggerCardActivity')]
+    public function testTriggerCardActivity(string $action, array $addressBookData, array $shares, array $cardData, string $currentUser, string $author, ?array $shareUsers, array $users): void {
+        $backend = $this->getBackend(['getUsersForShares']);
+
+        if ($shareUsers === null) {
+            $backend->expects($this->never())
+                ->method('getUsersForShares');
+        } else {
+            $backend->expects($this->once())
+                ->method('getUsersForShares')
+                ->with($shares)
+                ->willReturn($shareUsers);
+        }
+
+        if ($author !== '') {
+            if ($currentUser !== '') {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn($this->getUserMock($currentUser));
+            } else {
+                $this->userSession->expects($this->once())
+                    ->method('getUser')
+                    ->willReturn(null);
+            }
+
+            $event = $this->createMock(IEvent::class);
+            $this->activityManager->expects($this->once())
+                ->method('generateEvent')
+                ->willReturn($event);
+
+            $event->expects($this->once())
+                ->method('setApp')
+                ->with('dav')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setObject')
+                ->with('addressbook', $addressBookData['id'])
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setType')
+                ->with('contacts')
+                ->willReturnSelf();
+            $event->expects($this->once())
+                ->method('setAuthor')
+                ->with($author)
+                ->willReturnSelf();
+
+            $event->expects($this->exactly(count($users)))
+                ->method('setAffectedUser')
+                ->willReturnSelf();
+            $event->expects($this->exactly(count($users)))
+                ->method('setSubject')
+                ->willReturnSelf();
+            $this->activityManager->expects($this->exactly(count($users)))
+                ->method('publish')
+                ->with($event);
+        } else {
+            $this->activityManager->expects($this->never())
+                ->method('generateEvent');
+        }
+
+        $this->invokePrivate($backend, 'triggerCardActivity', [$action, $addressBookData, $shares, $cardData]);
+    }
+
+    public function testNoCardActivityCreatedForSystemAddressbook(): void {
+        $backend = $this->getBackend();
+        $this->activityManager->expects($this->never())
+            ->method('generateEvent');
+        $this->assertEmpty($this->invokePrivate($backend, 'triggerCardActivity', [Card::SUBJECT_UPDATE, ['principaluri' => 'principals/system/system'], [], []]));
+    }
+
+    public static function dataGetUsersForShares(): array {
+        return [
+            [
+                [],
+                [],
+                [],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user3'],
+                ],
+                [],
+                ['user1', 'user2', 'user3'],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
+                ],
+                ['group2' => null, 'group3' => null],
+                ['user1', 'user2'],
+            ],
+            [
+                [
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user1'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/users/user2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group2'],
+                    ['{http://owncloud.org/ns}principal' => 'principal/groups/group3'],
+                ],
+                ['group2' => ['user1', 'user2', 'user3'], 'group3' => ['user2', 'user3', 'user4']],
+                ['user1', 'user2', 'user3', 'user4'],
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGetUsersForShares')]
+    public function testGetUsersForShares(array $shares, array $groups, array $expected): void {
+        $backend = $this->getBackend();
+
+        $getGroups = [];
+        foreach ($groups as $gid => $members) {
+            if ($members === null) {
+                $getGroups[] = [$gid, null];
+                continue;
+            }
+
+            $group = $this->createMock(IGroup::class);
+            $group->expects($this->once())
+                ->method('getUsers')
+                ->willReturn($this->getUsers($members));
+
+            $getGroups[] = [$gid, $group];
+        }
+
+        $this->groupManager->expects($this->exactly(sizeof($getGroups)))
+            ->method('get')
+            ->willReturnMap($getGroups);
+
+        $users = $this->invokePrivate($backend, 'getUsersForShares', [$shares]);
+        sort($users);
+        $this->assertEquals($expected, $users);
+    }
+
+    /**
+     * @param string[] $users
+     * @return IUser[]|MockObject[]
+     */
+    protected function getUsers(array $users): array {
+        $list = [];
+        foreach ($users as $user) {
+            $list[] = $this->getUserMock($user);
+        }
+        return $list;
+    }
+
+    /**
+     * @return IUser|MockObject
+     */
+    protected function getUserMock(string $uid): IUser {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn($uid);
+        return $user;
+    }
 }

apps/dav/tests/unit/Command/ListAddressbooksTest.php

Indentation +84 added lines, -84 removed lines

@@ -20,88 +20,88 @@
  * @package OCA\DAV\Tests\Command
  */
 class ListAddressbooksTest extends TestCase {
-	private IUserManager&MockObject $userManager;
-	private CardDavBackend&MockObject $cardDavBackend;
-	private ListAddressbooks $command;
-
-	public const USERNAME = 'username';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->cardDavBackend = $this->createMock(CardDavBackend::class);
-
-		$this->command = new ListAddressbooks(
-			$this->userManager,
-			$this->cardDavBackend
-		);
-	}
-
-	public function testWithBadUser(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(false);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString('User <' . self::USERNAME . '> in unknown', $commandTester->getDisplay());
-	}
-
-	public function testWithCorrectUserWithNoCalendars(): void {
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(true);
-
-		$this->cardDavBackend->expects($this->once())
-			->method('getAddressBooksForUser')
-			->with('principals/users/' . self::USERNAME)
-			->willReturn([]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString('User <' . self::USERNAME . "> has no addressbooks\n", $commandTester->getDisplay());
-	}
-
-	public static function dataExecute(): array {
-		return [
-			[false, '✓'],
-			[true, 'x']
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
-	public function testWithCorrectUser(bool $readOnly, string $output): void {
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(true);
-
-		$this->cardDavBackend->expects($this->once())
-			->method('getAddressBooksForUser')
-			->with('principals/users/' . self::USERNAME)
-			->willReturn([
-				[
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}read-only' => $readOnly,
-					'uri' => 'test',
-					'{DAV:}displayname' => 'dp',
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}owner-principal' => 'owner-principal',
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_NEXTCLOUD . '}owner-displayname' => 'owner-dp',
-				]
-			]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString($output, $commandTester->getDisplay());
-	}
+    private IUserManager&MockObject $userManager;
+    private CardDavBackend&MockObject $cardDavBackend;
+    private ListAddressbooks $command;
+
+    public const USERNAME = 'username';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->cardDavBackend = $this->createMock(CardDavBackend::class);
+
+        $this->command = new ListAddressbooks(
+            $this->userManager,
+            $this->cardDavBackend
+        );
+    }
+
+    public function testWithBadUser(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(false);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString('User <' . self::USERNAME . '> in unknown', $commandTester->getDisplay());
+    }
+
+    public function testWithCorrectUserWithNoCalendars(): void {
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(true);
+
+        $this->cardDavBackend->expects($this->once())
+            ->method('getAddressBooksForUser')
+            ->with('principals/users/' . self::USERNAME)
+            ->willReturn([]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString('User <' . self::USERNAME . "> has no addressbooks\n", $commandTester->getDisplay());
+    }
+
+    public static function dataExecute(): array {
+        return [
+            [false, '✓'],
+            [true, 'x']
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
+    public function testWithCorrectUser(bool $readOnly, string $output): void {
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(true);
+
+        $this->cardDavBackend->expects($this->once())
+            ->method('getAddressBooksForUser')
+            ->with('principals/users/' . self::USERNAME)
+            ->willReturn([
+                [
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}read-only' => $readOnly,
+                    'uri' => 'test',
+                    '{DAV:}displayname' => 'dp',
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}owner-principal' => 'owner-principal',
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_NEXTCLOUD . '}owner-displayname' => 'owner-dp',
+                ]
+            ]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString($output, $commandTester->getDisplay());
+    }
 }

apps/dav/tests/unit/Command/ListCalendarsTest.php

Indentation +88 added lines, -88 removed lines

@@ -21,92 +21,92 @@
  * @package OCA\DAV\Tests\Command
  */
 class ListCalendarsTest extends TestCase {
-	private IUserManager&MockObject $userManager;
-	private CalDavBackend&MockObject $calDav;
-	private ListCalendars $command;
-
-	public const USERNAME = 'username';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->calDav = $this->createMock(CalDavBackend::class);
-
-		$this->command = new ListCalendars(
-			$this->userManager,
-			$this->calDav
-		);
-	}
-
-	public function testWithBadUser(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(false);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString('User <' . self::USERNAME . '> in unknown', $commandTester->getDisplay());
-	}
-
-	public function testWithCorrectUserWithNoCalendars(): void {
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(true);
-
-		$this->calDav->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/' . self::USERNAME)
-			->willReturn([]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString('User <' . self::USERNAME . "> has no calendars\n", $commandTester->getDisplay());
-	}
-
-	public static function dataExecute(): array {
-		return [
-			[false, '✓'],
-			[true, 'x']
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
-	public function testWithCorrectUser(bool $readOnly, string $output): void {
-		$this->userManager->expects($this->once())
-			->method('userExists')
-			->with(self::USERNAME)
-			->willReturn(true);
-
-		$this->calDav->expects($this->once())
-			->method('getCalendarsForUser')
-			->with('principals/users/' . self::USERNAME)
-			->willReturn([
-				[
-					'uri' => BirthdayService::BIRTHDAY_CALENDAR_URI,
-				],
-				[
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}read-only' => $readOnly,
-					'uri' => 'test',
-					'{DAV:}displayname' => 'dp',
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}owner-principal' => 'owner-principal',
-					'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_NEXTCLOUD . '}owner-displayname' => 'owner-dp',
-				]
-			]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'uid' => self::USERNAME,
-		]);
-		$this->assertStringContainsString($output, $commandTester->getDisplay());
-		$this->assertStringNotContainsString(BirthdayService::BIRTHDAY_CALENDAR_URI, $commandTester->getDisplay());
-	}
+    private IUserManager&MockObject $userManager;
+    private CalDavBackend&MockObject $calDav;
+    private ListCalendars $command;
+
+    public const USERNAME = 'username';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->calDav = $this->createMock(CalDavBackend::class);
+
+        $this->command = new ListCalendars(
+            $this->userManager,
+            $this->calDav
+        );
+    }
+
+    public function testWithBadUser(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(false);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString('User <' . self::USERNAME . '> in unknown', $commandTester->getDisplay());
+    }
+
+    public function testWithCorrectUserWithNoCalendars(): void {
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(true);
+
+        $this->calDav->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/' . self::USERNAME)
+            ->willReturn([]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString('User <' . self::USERNAME . "> has no calendars\n", $commandTester->getDisplay());
+    }
+
+    public static function dataExecute(): array {
+        return [
+            [false, '✓'],
+            [true, 'x']
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
+    public function testWithCorrectUser(bool $readOnly, string $output): void {
+        $this->userManager->expects($this->once())
+            ->method('userExists')
+            ->with(self::USERNAME)
+            ->willReturn(true);
+
+        $this->calDav->expects($this->once())
+            ->method('getCalendarsForUser')
+            ->with('principals/users/' . self::USERNAME)
+            ->willReturn([
+                [
+                    'uri' => BirthdayService::BIRTHDAY_CALENDAR_URI,
+                ],
+                [
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}read-only' => $readOnly,
+                    'uri' => 'test',
+                    '{DAV:}displayname' => 'dp',
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}owner-principal' => 'owner-principal',
+                    '{' . \OCA\DAV\DAV\Sharing\Plugin::NS_NEXTCLOUD . '}owner-displayname' => 'owner-dp',
+                ]
+            ]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'uid' => self::USERNAME,
+        ]);
+        $this->assertStringContainsString($output, $commandTester->getDisplay());
+        $this->assertStringNotContainsString(BirthdayService::BIRTHDAY_CALENDAR_URI, $commandTester->getDisplay());
+    }
 }

apps/dav/tests/unit/Command/MoveCalendarTest.php

Indentation +325 added lines, -325 removed lines

@@ -26,329 +26,329 @@
  * @package OCA\DAV\Tests\Command
  */
 class MoveCalendarTest extends TestCase {
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private \OCP\Share\IManager&MockObject $shareManager;
-	private IConfig&MockObject $config;
-	private IL10N&MockObject $l10n;
-	private CalDavBackend&MockObject $calDav;
-	private LoggerInterface&MockObject $logger;
-	private MoveCalendar $command;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->calDav = $this->createMock(CalDavBackend::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->command = new MoveCalendar(
-			$this->userManager,
-			$this->groupManager,
-			$this->shareManager,
-			$this->config,
-			$this->l10n,
-			$this->calDav,
-			$this->logger
-		);
-	}
-
-	public static function dataExecute(): array {
-		return [
-			[false, true],
-			[true, false]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
-	public function testWithBadUserOrigin(bool $userOriginExists, bool $userDestinationExists): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->userManager->expects($this->exactly($userOriginExists ? 2 : 1))
-			->method('userExists')
-			->willReturnMap([
-				['user', $userOriginExists],
-				['user2', $userDestinationExists],
-			]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => $this->command->getName(),
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-	}
-
-
-	public function testMoveWithInexistantCalendar(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('User <user> has no calendar named <personal>. You can run occ dav:list-calendars to list calendars URIs for this user.');
-
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->once())->method('getCalendarByUri')
-			->with('principals/users/user', 'personal')
-			->willReturn(null);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-	}
-
-
-	public function testMoveWithExistingDestinationCalendar(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('User <user2> already has a calendar named <personal>.');
-
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-				]],
-				['principals/users/user2', 'personal', [
-					'id' => 1234,
-				]],
-			]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-	}
-
-	public function testMove(): void {
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-				]],
-				['principals/users/user2', 'personal', null],
-			]);
-
-		$this->calDav->expects($this->once())->method('getShares')
-			->with(1234)
-			->willReturn([]);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-
-		$this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
-	}
-
-	public static function dataTestMoveWithDestinationNotPartOfGroup(): array {
-		return [
-			[true],
-			[false]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestMoveWithDestinationNotPartOfGroup')]
-	public function testMoveWithDestinationNotPartOfGroup(bool $shareWithGroupMembersOnly): void {
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-					'uri' => 'personal',
-				]],
-				['principals/users/user2', 'personal', null],
-			]);
-
-		$this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
-			->willReturn($shareWithGroupMembersOnly);
-
-		$this->calDav->expects($this->once())->method('getShares')
-			->with(1234)
-			->willReturn([
-				['href' => 'principal:principals/groups/nextclouders']
-			]);
-		if ($shareWithGroupMembersOnly === true) {
-			$this->expectException(InvalidArgumentException::class);
-			$this->expectExceptionMessage('User <user2> is not part of the group <nextclouders> with whom the calendar <personal> was shared. You may use -f to move the calendar while deleting this share.');
-		}
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-	}
-
-	public function testMoveWithDestinationPartOfGroup(): void {
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-					'uri' => 'personal',
-				]],
-				['principals/users/user2', 'personal', null],
-			]);
-
-		$this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
-			->willReturn(true);
-
-		$this->calDav->expects($this->once())->method('getShares')
-			->with(1234)
-			->willReturn([
-				['href' => 'principal:principals/groups/nextclouders']
-			]);
-
-		$this->groupManager->expects($this->once())->method('isInGroup')
-			->with('user2', 'nextclouders')
-			->willReturn(true);
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-		]);
-
-		$this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
-	}
-
-	public function testMoveWithDestinationNotPartOfGroupAndForce(): void {
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-					'uri' => 'personal',
-					'{DAV:}displayname' => 'Personal'
-				]],
-				['principals/users/user2', 'personal', null],
-			]);
-
-		$this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
-			->willReturn(true);
-
-		$this->calDav->expects($this->once())->method('getShares')
-			->with(1234)
-			->willReturn([
-				[
-					'href' => 'principal:principals/groups/nextclouders',
-					'{DAV:}displayname' => 'Personal'
-				]
-			]);
-		$this->calDav->expects($this->once())->method('updateShares');
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-			'--force' => true
-		]);
-
-		$this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
-	}
-
-	public static function dataTestMoveWithCalendarAlreadySharedToDestination(): array {
-		return [
-			[true],
-			[false]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestMoveWithCalendarAlreadySharedToDestination')]
-	public function testMoveWithCalendarAlreadySharedToDestination(bool $force): void {
-		$this->userManager->expects($this->exactly(2))
-			->method('userExists')
-			->willReturnMap([
-				['user', true],
-				['user2', true],
-			]);
-
-		$this->calDav->expects($this->exactly(2))
-			->method('getCalendarByUri')
-			->willReturnMap([
-				['principals/users/user', 'personal', [
-					'id' => 1234,
-					'uri' => 'personal',
-					'{DAV:}displayname' => 'Personal'
-				]],
-				['principals/users/user2', 'personal', null],
-			]);
-
-		$this->calDav->expects($this->once())->method('getShares')
-			->with(1234)
-			->willReturn([
-				[
-					'href' => 'principal:principals/users/user2',
-					'{DAV:}displayname' => 'Personal'
-				]
-			]);
-
-		if ($force === false) {
-			$this->expectException(InvalidArgumentException::class);
-			$this->expectExceptionMessage('The calendar <personal> is already shared to user <user2>.You may use -f to move the calendar while deleting this share.');
-		} else {
-			$this->calDav->expects($this->once())->method('updateShares');
-		}
-
-		$commandTester = new CommandTester($this->command);
-		$commandTester->execute([
-			'name' => 'personal',
-			'sourceuid' => 'user',
-			'destinationuid' => 'user2',
-			'--force' => $force,
-		]);
-	}
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private \OCP\Share\IManager&MockObject $shareManager;
+    private IConfig&MockObject $config;
+    private IL10N&MockObject $l10n;
+    private CalDavBackend&MockObject $calDav;
+    private LoggerInterface&MockObject $logger;
+    private MoveCalendar $command;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->calDav = $this->createMock(CalDavBackend::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->command = new MoveCalendar(
+            $this->userManager,
+            $this->groupManager,
+            $this->shareManager,
+            $this->config,
+            $this->l10n,
+            $this->calDav,
+            $this->logger
+        );
+    }
+
+    public static function dataExecute(): array {
+        return [
+            [false, true],
+            [true, false]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataExecute')]
+    public function testWithBadUserOrigin(bool $userOriginExists, bool $userDestinationExists): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->userManager->expects($this->exactly($userOriginExists ? 2 : 1))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', $userOriginExists],
+                ['user2', $userDestinationExists],
+            ]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => $this->command->getName(),
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+    }
+
+
+    public function testMoveWithInexistantCalendar(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('User <user> has no calendar named <personal>. You can run occ dav:list-calendars to list calendars URIs for this user.');
+
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->once())->method('getCalendarByUri')
+            ->with('principals/users/user', 'personal')
+            ->willReturn(null);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+    }
+
+
+    public function testMoveWithExistingDestinationCalendar(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('User <user2> already has a calendar named <personal>.');
+
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                ]],
+                ['principals/users/user2', 'personal', [
+                    'id' => 1234,
+                ]],
+            ]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+    }
+
+    public function testMove(): void {
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                ]],
+                ['principals/users/user2', 'personal', null],
+            ]);
+
+        $this->calDav->expects($this->once())->method('getShares')
+            ->with(1234)
+            ->willReturn([]);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+
+        $this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
+    }
+
+    public static function dataTestMoveWithDestinationNotPartOfGroup(): array {
+        return [
+            [true],
+            [false]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestMoveWithDestinationNotPartOfGroup')]
+    public function testMoveWithDestinationNotPartOfGroup(bool $shareWithGroupMembersOnly): void {
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                    'uri' => 'personal',
+                ]],
+                ['principals/users/user2', 'personal', null],
+            ]);
+
+        $this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
+            ->willReturn($shareWithGroupMembersOnly);
+
+        $this->calDav->expects($this->once())->method('getShares')
+            ->with(1234)
+            ->willReturn([
+                ['href' => 'principal:principals/groups/nextclouders']
+            ]);
+        if ($shareWithGroupMembersOnly === true) {
+            $this->expectException(InvalidArgumentException::class);
+            $this->expectExceptionMessage('User <user2> is not part of the group <nextclouders> with whom the calendar <personal> was shared. You may use -f to move the calendar while deleting this share.');
+        }
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+    }
+
+    public function testMoveWithDestinationPartOfGroup(): void {
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                    'uri' => 'personal',
+                ]],
+                ['principals/users/user2', 'personal', null],
+            ]);
+
+        $this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
+            ->willReturn(true);
+
+        $this->calDav->expects($this->once())->method('getShares')
+            ->with(1234)
+            ->willReturn([
+                ['href' => 'principal:principals/groups/nextclouders']
+            ]);
+
+        $this->groupManager->expects($this->once())->method('isInGroup')
+            ->with('user2', 'nextclouders')
+            ->willReturn(true);
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+        ]);
+
+        $this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
+    }
+
+    public function testMoveWithDestinationNotPartOfGroupAndForce(): void {
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                    'uri' => 'personal',
+                    '{DAV:}displayname' => 'Personal'
+                ]],
+                ['principals/users/user2', 'personal', null],
+            ]);
+
+        $this->shareManager->expects($this->once())->method('shareWithGroupMembersOnly')
+            ->willReturn(true);
+
+        $this->calDav->expects($this->once())->method('getShares')
+            ->with(1234)
+            ->willReturn([
+                [
+                    'href' => 'principal:principals/groups/nextclouders',
+                    '{DAV:}displayname' => 'Personal'
+                ]
+            ]);
+        $this->calDav->expects($this->once())->method('updateShares');
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+            '--force' => true
+        ]);
+
+        $this->assertStringContainsString('[OK] Calendar <personal> was moved from user <user> to <user2>', $commandTester->getDisplay());
+    }
+
+    public static function dataTestMoveWithCalendarAlreadySharedToDestination(): array {
+        return [
+            [true],
+            [false]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestMoveWithCalendarAlreadySharedToDestination')]
+    public function testMoveWithCalendarAlreadySharedToDestination(bool $force): void {
+        $this->userManager->expects($this->exactly(2))
+            ->method('userExists')
+            ->willReturnMap([
+                ['user', true],
+                ['user2', true],
+            ]);
+
+        $this->calDav->expects($this->exactly(2))
+            ->method('getCalendarByUri')
+            ->willReturnMap([
+                ['principals/users/user', 'personal', [
+                    'id' => 1234,
+                    'uri' => 'personal',
+                    '{DAV:}displayname' => 'Personal'
+                ]],
+                ['principals/users/user2', 'personal', null],
+            ]);
+
+        $this->calDav->expects($this->once())->method('getShares')
+            ->with(1234)
+            ->willReturn([
+                [
+                    'href' => 'principal:principals/users/user2',
+                    '{DAV:}displayname' => 'Personal'
+                ]
+            ]);
+
+        if ($force === false) {
+            $this->expectException(InvalidArgumentException::class);
+            $this->expectExceptionMessage('The calendar <personal> is already shared to user <user2>.You may use -f to move the calendar while deleting this share.');
+        } else {
+            $this->calDav->expects($this->once())->method('updateShares');
+        }
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([
+            'name' => 'personal',
+            'sourceuid' => 'user',
+            'destinationuid' => 'user2',
+            '--force' => $force,
+        ]);
+    }
 }

apps/dav/tests/unit/Provisioning/Apple/AppleProvisioningPluginTest.php

Indentation +143 added lines, -143 removed lines

@@ -21,145 +21,145 @@ 
 use Test\TestCase;
 
 class AppleProvisioningPluginTest extends TestCase {
-	protected Server&MockObject $server;
-	protected IUserSession&MockObject $userSession;
-	protected IURLGenerator&MockObject $urlGenerator;
-	protected ThemingDefaults&MockObject $themingDefaults;
-	protected IRequest&MockObject $request;
-	protected IL10N&MockObject $l10n;
-	protected RequestInterface&MockObject $sabreRequest;
-	protected ResponseInterface&MockObject $sabreResponse;
-	protected AppleProvisioningPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = $this->createMock(Server::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->l10n = $this->createMock(IL10N::class);
-
-		$this->plugin = new AppleProvisioningPlugin($this->userSession,
-			$this->urlGenerator,
-			$this->themingDefaults,
-			$this->request,
-			$this->l10n,
-			function () {
-				return 'generated-uuid';
-			}
-		);
-
-		$this->sabreRequest = $this->createMock(RequestInterface::class);
-		$this->sabreResponse = $this->createMock(ResponseInterface::class);
-	}
-
-	public function testInitialize(): void {
-		$server = $this->createMock(Server::class);
-
-		$plugin = new AppleProvisioningPlugin($this->userSession,
-			$this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
-			function (): void {
-			});
-
-		$server->expects($this->once())
-			->method('on')
-			->with('method:GET', [$plugin, 'httpGet'], 90);
-
-		$plugin->initialize($server);
-	}
-
-	public function testHttpGetOnHttp(): void {
-		$this->sabreRequest->expects($this->once())
-			->method('getPath')
-			->with()
-			->willReturn('provisioning/apple-provisioning.mobileconfig');
-
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->request->expects($this->once())
-			->method('getServerProtocol')
-			->wilLReturn('http');
-
-		$this->themingDefaults->expects($this->once())
-			->method('getName')
-			->willReturn('InstanceName');
-
-		$this->l10n->expects($this->once())
-			->method('t')
-			->with('Your %s needs to be configured to use HTTPS in order to use CalDAV and CardDAV with iOS/macOS.', ['InstanceName'])
-			->willReturn('LocalizedErrorMessage');
-
-		$this->sabreResponse->expects($this->once())
-			->method('setStatus')
-			->with(200);
-		$this->sabreResponse->expects($this->once())
-			->method('setHeader')
-			->with('Content-Type', 'text/plain; charset=utf-8');
-		$this->sabreResponse->expects($this->once())
-			->method('setBody')
-			->with('LocalizedErrorMessage');
-
-		$returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
-
-		$this->assertFalse($returnValue);
-	}
-
-	public function testHttpGetOnHttps(): void {
-		$this->sabreRequest->expects($this->once())
-			->method('getPath')
-			->with()
-			->willReturn('provisioning/apple-provisioning.mobileconfig');
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('userName');
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->request->expects($this->once())
-			->method('getServerProtocol')
-			->wilLReturn('https');
-
-		$this->urlGenerator->expects($this->once())
-			->method('getBaseUrl')
-			->willReturn('https://nextcloud.tld/nextcloud');
-
-		$this->themingDefaults->expects($this->once())
-			->method('getName')
-			->willReturn('InstanceName');
-
-		$this->l10n->expects($this->exactly(2))
-			->method('t')
-			->willReturnMap([
-				['Configures a CalDAV account', [], 'LocalizedConfiguresCalDAV'],
-				['Configures a CardDAV account', [], 'LocalizedConfiguresCardDAV'],
-			]);
-
-		$this->sabreResponse->expects($this->once())
-			->method('setStatus')
-			->with(200);
-
-		$calls = [
-			['Content-Disposition', 'attachment; filename="userName-apple-provisioning.mobileconfig"'],
-			['Content-Type', 'application/xml; charset=utf-8'],
-		];
-		$this->sabreResponse->expects($this->exactly(2))
-			->method('setHeader')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->sabreResponse->expects($this->once())
-			->method('setBody')
-			->with(<<<EOF
+    protected Server&MockObject $server;
+    protected IUserSession&MockObject $userSession;
+    protected IURLGenerator&MockObject $urlGenerator;
+    protected ThemingDefaults&MockObject $themingDefaults;
+    protected IRequest&MockObject $request;
+    protected IL10N&MockObject $l10n;
+    protected RequestInterface&MockObject $sabreRequest;
+    protected ResponseInterface&MockObject $sabreResponse;
+    protected AppleProvisioningPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = $this->createMock(Server::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->l10n = $this->createMock(IL10N::class);
+
+        $this->plugin = new AppleProvisioningPlugin($this->userSession,
+            $this->urlGenerator,
+            $this->themingDefaults,
+            $this->request,
+            $this->l10n,
+            function () {
+                return 'generated-uuid';
+            }
+        );
+
+        $this->sabreRequest = $this->createMock(RequestInterface::class);
+        $this->sabreResponse = $this->createMock(ResponseInterface::class);
+    }
+
+    public function testInitialize(): void {
+        $server = $this->createMock(Server::class);
+
+        $plugin = new AppleProvisioningPlugin($this->userSession,
+            $this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
+            function (): void {
+            });
+
+        $server->expects($this->once())
+            ->method('on')
+            ->with('method:GET', [$plugin, 'httpGet'], 90);
+
+        $plugin->initialize($server);
+    }
+
+    public function testHttpGetOnHttp(): void {
+        $this->sabreRequest->expects($this->once())
+            ->method('getPath')
+            ->with()
+            ->willReturn('provisioning/apple-provisioning.mobileconfig');
+
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->request->expects($this->once())
+            ->method('getServerProtocol')
+            ->wilLReturn('http');
+
+        $this->themingDefaults->expects($this->once())
+            ->method('getName')
+            ->willReturn('InstanceName');
+
+        $this->l10n->expects($this->once())
+            ->method('t')
+            ->with('Your %s needs to be configured to use HTTPS in order to use CalDAV and CardDAV with iOS/macOS.', ['InstanceName'])
+            ->willReturn('LocalizedErrorMessage');
+
+        $this->sabreResponse->expects($this->once())
+            ->method('setStatus')
+            ->with(200);
+        $this->sabreResponse->expects($this->once())
+            ->method('setHeader')
+            ->with('Content-Type', 'text/plain; charset=utf-8');
+        $this->sabreResponse->expects($this->once())
+            ->method('setBody')
+            ->with('LocalizedErrorMessage');
+
+        $returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
+
+        $this->assertFalse($returnValue);
+    }
+
+    public function testHttpGetOnHttps(): void {
+        $this->sabreRequest->expects($this->once())
+            ->method('getPath')
+            ->with()
+            ->willReturn('provisioning/apple-provisioning.mobileconfig');
+
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('userName');
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->request->expects($this->once())
+            ->method('getServerProtocol')
+            ->wilLReturn('https');
+
+        $this->urlGenerator->expects($this->once())
+            ->method('getBaseUrl')
+            ->willReturn('https://nextcloud.tld/nextcloud');
+
+        $this->themingDefaults->expects($this->once())
+            ->method('getName')
+            ->willReturn('InstanceName');
+
+        $this->l10n->expects($this->exactly(2))
+            ->method('t')
+            ->willReturnMap([
+                ['Configures a CalDAV account', [], 'LocalizedConfiguresCalDAV'],
+                ['Configures a CardDAV account', [], 'LocalizedConfiguresCardDAV'],
+            ]);
+
+        $this->sabreResponse->expects($this->once())
+            ->method('setStatus')
+            ->with(200);
+
+        $calls = [
+            ['Content-Disposition', 'attachment; filename="userName-apple-provisioning.mobileconfig"'],
+            ['Content-Type', 'application/xml; charset=utf-8'],
+        ];
+        $this->sabreResponse->expects($this->exactly(2))
+            ->method('setHeader')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->sabreResponse->expects($this->once())
+            ->method('setBody')
+            ->with(<<<EOF
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
@@ -231,10 +231,10 @@ 
 </plist>
 
 EOF
-			);
+            );
 
-		$returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
+        $returnValue = $this->plugin->httpGet($this->sabreRequest, $this->sabreResponse);
 
-		$this->assertFalse($returnValue);
-	}
+        $this->assertFalse($returnValue);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
 			$this->themingDefaults,
 			$this->request,
 			$this->l10n,
-			function () {
+			function() {
 				return 'generated-uuid';
 			}
 		);
@@ -60,7 +60,7 @@ 
 
 		$plugin = new AppleProvisioningPlugin($this->userSession,
 			$this->urlGenerator, $this->themingDefaults, $this->request, $this->l10n,
-			function (): void {
+			function(): void {
 			});
 
 		$server->expects($this->once())
@@ -153,7 +153,7 @@ 
 		];
 		$this->sabreResponse->expects($this->exactly(2))
 			->method('setHeader')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});