nextcloud / server

apps/dav/tests/unit/Connector/Sabre/CommentsPropertiesPluginTest.php

Indentation +95 added lines, -95 removed lines

@@ -19,99 +19,99 @@
 use Sabre\DAV\Server;
 
 class CommentsPropertiesPluginTest extends \Test\TestCase {
-	protected CommentPropertiesPluginImplementation $plugin;
-	protected ICommentsManager&MockObject $commentsManager;
-	protected IUserSession&MockObject $userSession;
-	protected Server&MockObject $server;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->commentsManager = $this->createMock(ICommentsManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->server = $this->createMock(Server::class);
-
-		$this->plugin = new CommentPropertiesPluginImplementation($this->commentsManager, $this->userSession);
-		$this->plugin->initialize($this->server);
-	}
-
-	public static function nodeProvider(): array {
-		return [
-			[File::class, true],
-			[Directory::class, true],
-			[\Sabre\DAV\INode::class, false]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('nodeProvider')]
-	public function testHandleGetProperties(string $class, bool $expectedSuccessful): void {
-		$propFind = $this->createMock(PropFind::class);
-
-		if ($expectedSuccessful) {
-			$propFind->expects($this->exactly(3))
-				->method('handle');
-		} else {
-			$propFind->expects($this->never())
-				->method('handle');
-		}
-
-		$node = $this->createMock($class);
-		$this->plugin->handleGetProperties($propFind, $node);
-	}
-
-	public static function baseUriProvider(): array {
-		return [
-			['owncloud/remote.php/webdav/', '4567', 'owncloud/remote.php/dav/comments/files/4567'],
-			['owncloud/remote.php/files/', '4567', 'owncloud/remote.php/dav/comments/files/4567'],
-			['owncloud/wicked.php/files/', '4567', null]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('baseUriProvider')]
-	public function testGetCommentsLink(string $baseUri, string $fid, ?string $expectedHref): void {
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn($fid);
-
-		$this->server->expects($this->once())
-			->method('getBaseUri')
-			->willReturn($baseUri);
-
-		$href = $this->plugin->getCommentsLink($node);
-		$this->assertSame($expectedHref, $href);
-	}
-
-	public static function userProvider(): array {
-		return [
-			[IUser::class],
-			[null]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('userProvider')]
-	public function testGetUnreadCount(?string $user): void {
-		$node = $this->createMock(File::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn('4567');
-
-		if ($user !== null) {
-			$user = $this->createMock($user);
-		}
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->commentsManager->expects($this->any())
-			->method('getNumberOfCommentsForObject')
-			->willReturn(42);
-
-		$unread = $this->plugin->getUnreadCount($node);
-		if (is_null($user)) {
-			$this->assertNull($unread);
-		} else {
-			$this->assertSame($unread, 42);
-		}
-	}
+    protected CommentPropertiesPluginImplementation $plugin;
+    protected ICommentsManager&MockObject $commentsManager;
+    protected IUserSession&MockObject $userSession;
+    protected Server&MockObject $server;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->commentsManager = $this->createMock(ICommentsManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->server = $this->createMock(Server::class);
+
+        $this->plugin = new CommentPropertiesPluginImplementation($this->commentsManager, $this->userSession);
+        $this->plugin->initialize($this->server);
+    }
+
+    public static function nodeProvider(): array {
+        return [
+            [File::class, true],
+            [Directory::class, true],
+            [\Sabre\DAV\INode::class, false]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('nodeProvider')]
+    public function testHandleGetProperties(string $class, bool $expectedSuccessful): void {
+        $propFind = $this->createMock(PropFind::class);
+
+        if ($expectedSuccessful) {
+            $propFind->expects($this->exactly(3))
+                ->method('handle');
+        } else {
+            $propFind->expects($this->never())
+                ->method('handle');
+        }
+
+        $node = $this->createMock($class);
+        $this->plugin->handleGetProperties($propFind, $node);
+    }
+
+    public static function baseUriProvider(): array {
+        return [
+            ['owncloud/remote.php/webdav/', '4567', 'owncloud/remote.php/dav/comments/files/4567'],
+            ['owncloud/remote.php/files/', '4567', 'owncloud/remote.php/dav/comments/files/4567'],
+            ['owncloud/wicked.php/files/', '4567', null]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('baseUriProvider')]
+    public function testGetCommentsLink(string $baseUri, string $fid, ?string $expectedHref): void {
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn($fid);
+
+        $this->server->expects($this->once())
+            ->method('getBaseUri')
+            ->willReturn($baseUri);
+
+        $href = $this->plugin->getCommentsLink($node);
+        $this->assertSame($expectedHref, $href);
+    }
+
+    public static function userProvider(): array {
+        return [
+            [IUser::class],
+            [null]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('userProvider')]
+    public function testGetUnreadCount(?string $user): void {
+        $node = $this->createMock(File::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn('4567');
+
+        if ($user !== null) {
+            $user = $this->createMock($user);
+        }
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->commentsManager->expects($this->any())
+            ->method('getNumberOfCommentsForObject')
+            ->willReturn(42);
+
+        $unread = $this->plugin->getUnreadCount($node);
+        if (is_null($user)) {
+            $this->assertNull($unread);
+        } else {
+            $this->assertSame($unread, 42);
+        }
+    }
 }

apps/dav/tests/unit/Connector/Sabre/TagsPluginTest.php

Indentation +382 added lines, -382 removed lines

@@ -23,386 +23,386 @@
 use Sabre\DAV\Tree;
 
 class TagsPluginTest extends \Test\TestCase {
-	public const TAGS_PROPERTYNAME = TagsPlugin::TAGS_PROPERTYNAME;
-	public const FAVORITE_PROPERTYNAME = TagsPlugin::FAVORITE_PROPERTYNAME;
-	public const TAG_FAVORITE = TagsPlugin::TAG_FAVORITE;
-
-	private \Sabre\DAV\Server $server;
-	private Tree&MockObject $tree;
-	private ITagManager&MockObject $tagManager;
-	private ITags&MockObject $tagger;
-	private IEventDispatcher&MockObject $eventDispatcher;
-	private IUserSession&MockObject $userSession;
-	private TagsPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = new \Sabre\DAV\Server();
-		$this->tree = $this->createMock(Tree::class);
-		$this->tagger = $this->createMock(ITags::class);
-		$this->tagManager = $this->createMock(ITagManager::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$user = $this->createMock(IUser::class);
-
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->withAnyParameters()
-			->willReturn($user);
-		$this->tagManager->expects($this->any())
-			->method('load')
-			->with('files')
-			->willReturn($this->tagger);
-		$this->plugin = new TagsPlugin($this->tree, $this->tagManager, $this->eventDispatcher, $this->userSession);
-		$this->plugin->initialize($this->server);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagsGetPropertiesDataProvider')]
-	public function testGetProperties(array $tags, array $requestedProperties, array $expectedProperties): void {
-		$node = $this->createMock(Node::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$expectedCallCount = 0;
-		if (count($requestedProperties) > 0) {
-			$expectedCallCount = 1;
-		}
-
-		$this->tagger->expects($this->exactly($expectedCallCount))
-			->method('getTagsForObjects')
-			->with($this->equalTo([123]))
-			->willReturn([123 => $tags]);
-
-		$propFind = new \Sabre\DAV\PropFind(
-			'/dummyPath',
-			$requestedProperties,
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$result = $propFind->getResultForMultiStatus();
-
-		$this->assertEmpty($result[404]);
-		unset($result[404]);
-		$this->assertEquals($expectedProperties, $result);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('tagsGetPropertiesDataProvider')]
-	public function testPreloadThenGetProperties(array $tags, array $requestedProperties, array $expectedProperties): void {
-		$node1 = $this->createMock(File::class);
-		$node1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$node2 = $this->createMock(File::class);
-		$node2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-
-		$expectedCallCount = 0;
-		if (count($requestedProperties) > 0) {
-			// this guarantees that getTagsForObjects
-			// is only called once and then the tags
-			// are cached
-			$expectedCallCount = 1;
-		}
-
-		$node = $this->createMock(Directory::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-		$node->expects($this->exactly($expectedCallCount))
-			->method('getChildren')
-			->willReturn([$node1, $node2]);
-
-		$this->tagger->expects($this->exactly($expectedCallCount))
-			->method('getTagsForObjects')
-			->with($this->equalTo([123, 111, 222]))
-			->willReturn(
-				[
-					111 => $tags,
-					123 => $tags
-				]
-			);
-
-		// simulate sabre recursive PROPFIND traversal
-		$propFindRoot = new \Sabre\DAV\PropFind(
-			'/subdir',
-			$requestedProperties,
-			1
-		);
-		$propFind1 = new \Sabre\DAV\PropFind(
-			'/subdir/test.txt',
-			$requestedProperties,
-			0
-		);
-		$propFind2 = new \Sabre\DAV\PropFind(
-			'/subdir/test2.txt',
-			$requestedProperties,
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFindRoot,
-			$node
-		);
-		$this->plugin->handleGetProperties(
-			$propFind1,
-			$node1
-		);
-		$this->plugin->handleGetProperties(
-			$propFind2,
-			$node2
-		);
-
-		$result = $propFind1->getResultForMultiStatus();
-
-		$this->assertEmpty($result[404]);
-		unset($result[404]);
-		$this->assertEquals($expectedProperties, $result);
-	}
-
-	public static function tagsGetPropertiesDataProvider(): array {
-		return [
-			// request both, receive both
-			[
-				['tag1', 'tag2', self::TAG_FAVORITE],
-				[self::TAGS_PROPERTYNAME, self::FAVORITE_PROPERTYNAME],
-				[
-					200 => [
-						self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2']),
-						self::FAVORITE_PROPERTYNAME => true,
-					]
-				]
-			],
-			// request tags alone
-			[
-				['tag1', 'tag2', self::TAG_FAVORITE],
-				[self::TAGS_PROPERTYNAME],
-				[
-					200 => [
-						self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2']),
-					]
-				]
-			],
-			// request fav alone
-			[
-				['tag1', 'tag2', self::TAG_FAVORITE],
-				[self::FAVORITE_PROPERTYNAME],
-				[
-					200 => [
-						self::FAVORITE_PROPERTYNAME => true,
-					]
-				]
-			],
-			// request none
-			[
-				['tag1', 'tag2', self::TAG_FAVORITE],
-				[],
-				[
-					200 => []
-				],
-			],
-			// request both with none set, receive both
-			[
-				[],
-				[self::TAGS_PROPERTYNAME, self::FAVORITE_PROPERTYNAME],
-				[
-					200 => [
-						self::TAGS_PROPERTYNAME => new TagList([]),
-						self::FAVORITE_PROPERTYNAME => false,
-					]
-				]
-			],
-		];
-	}
-
-	public function testGetPropertiesSkipChunks(): void {
-		$sabreNode = $this->createMock(UploadFile::class);
-
-		$propFind = new \Sabre\DAV\PropFind(
-			'/dummyPath',
-			[self::TAGS_PROPERTYNAME, self::TAG_FAVORITE],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$sabreNode
-		);
-
-		$result = $propFind->getResultForMultiStatus();
-		$this->assertCount(2, $result[404]);
-	}
-
-	public function testUpdateTags(): void {
-		// this test will replace the existing tags "tagremove" with "tag1" and "tag2"
-		// and keep "tagkeep"
-		$node = $this->createMock(Node::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/dummypath')
-			->willReturn($node);
-
-		$this->tagger->expects($this->once())
-			->method('getTagsForObjects')
-			->with($this->equalTo([123]))
-			->willReturn([123 => ['tagkeep', 'tagremove', self::TAG_FAVORITE]]);
-
-		// then tag as tag1 and tag2
-		$calls = [
-			[123, 'tag1'],
-			[123, 'tag2'],
-		];
-		$this->tagger->expects($this->exactly(count($calls)))
-			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// it will untag tag3
-		$this->tagger->expects($this->once())
-			->method('unTag')
-			->with(123, 'tagremove');
-
-		// properties to set
-		$propPatch = new \Sabre\DAV\PropPatch([
-			self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2', 'tagkeep'])
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		// all requested properties removed, as they were processed already
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(200, $result[self::TAGS_PROPERTYNAME]);
-		$this->assertArrayNotHasKey(self::FAVORITE_PROPERTYNAME, $result);
-	}
-
-	public function testUpdateTagsFromScratch(): void {
-		$node = $this->createMock(Node::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/dummypath')
-			->willReturn($node);
-
-		$this->tagger->expects($this->once())
-			->method('getTagsForObjects')
-			->with($this->equalTo([123]))
-			->willReturn([]);
-
-		// then tag as tag1 and tag2
-		$calls = [
-			[123, 'tag1'],
-			[123, 'tag2'],
-		];
-		$this->tagger->expects($this->exactly(count($calls)))
-			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// properties to set
-		$propPatch = new \Sabre\DAV\PropPatch([
-			self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2'])
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		// all requested properties removed, as they were processed already
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(200, $result[self::TAGS_PROPERTYNAME]);
-		$this->assertArrayNotHasKey(self::FAVORITE_PROPERTYNAME, $result);
-	}
-
-	public function testUpdateFav(): void {
-		// this test will replace the existing tags "tagremove" with "tag1" and "tag2"
-		// and keep "tagkeep"
-		$node = $this->createMock(Node::class);
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/dummypath')
-			->willReturn($node);
-
-		// set favorite tag
-		$this->tagger->expects($this->once())
-			->method('tagAs')
-			->with(123, self::TAG_FAVORITE);
-
-		// properties to set
-		$propPatch = new \Sabre\DAV\PropPatch([
-			self::FAVORITE_PROPERTYNAME => true
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		// all requested properties removed, as they were processed already
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertArrayNotHasKey(self::TAGS_PROPERTYNAME, $result);
-		$this->assertEquals(200, $result[self::FAVORITE_PROPERTYNAME]);
-
-		// unfavorite now
-		// set favorite tag
-		$this->tagger->expects($this->once())
-			->method('unTag')
-			->with(123, self::TAG_FAVORITE);
-
-		// properties to set
-		$propPatch = new \Sabre\DAV\PropPatch([
-			self::FAVORITE_PROPERTYNAME => false
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		// all requested properties removed, as they were processed already
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertArrayNotHasKey(self::TAGS_PROPERTYNAME, $result);
-		$this->assertEquals(200, $result[self::FAVORITE_PROPERTYNAME]);
-	}
+    public const TAGS_PROPERTYNAME = TagsPlugin::TAGS_PROPERTYNAME;
+    public const FAVORITE_PROPERTYNAME = TagsPlugin::FAVORITE_PROPERTYNAME;
+    public const TAG_FAVORITE = TagsPlugin::TAG_FAVORITE;
+
+    private \Sabre\DAV\Server $server;
+    private Tree&MockObject $tree;
+    private ITagManager&MockObject $tagManager;
+    private ITags&MockObject $tagger;
+    private IEventDispatcher&MockObject $eventDispatcher;
+    private IUserSession&MockObject $userSession;
+    private TagsPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = new \Sabre\DAV\Server();
+        $this->tree = $this->createMock(Tree::class);
+        $this->tagger = $this->createMock(ITags::class);
+        $this->tagManager = $this->createMock(ITagManager::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $user = $this->createMock(IUser::class);
+
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->withAnyParameters()
+            ->willReturn($user);
+        $this->tagManager->expects($this->any())
+            ->method('load')
+            ->with('files')
+            ->willReturn($this->tagger);
+        $this->plugin = new TagsPlugin($this->tree, $this->tagManager, $this->eventDispatcher, $this->userSession);
+        $this->plugin->initialize($this->server);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagsGetPropertiesDataProvider')]
+    public function testGetProperties(array $tags, array $requestedProperties, array $expectedProperties): void {
+        $node = $this->createMock(Node::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $expectedCallCount = 0;
+        if (count($requestedProperties) > 0) {
+            $expectedCallCount = 1;
+        }
+
+        $this->tagger->expects($this->exactly($expectedCallCount))
+            ->method('getTagsForObjects')
+            ->with($this->equalTo([123]))
+            ->willReturn([123 => $tags]);
+
+        $propFind = new \Sabre\DAV\PropFind(
+            '/dummyPath',
+            $requestedProperties,
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $result = $propFind->getResultForMultiStatus();
+
+        $this->assertEmpty($result[404]);
+        unset($result[404]);
+        $this->assertEquals($expectedProperties, $result);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('tagsGetPropertiesDataProvider')]
+    public function testPreloadThenGetProperties(array $tags, array $requestedProperties, array $expectedProperties): void {
+        $node1 = $this->createMock(File::class);
+        $node1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $node2 = $this->createMock(File::class);
+        $node2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+
+        $expectedCallCount = 0;
+        if (count($requestedProperties) > 0) {
+            // this guarantees that getTagsForObjects
+            // is only called once and then the tags
+            // are cached
+            $expectedCallCount = 1;
+        }
+
+        $node = $this->createMock(Directory::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+        $node->expects($this->exactly($expectedCallCount))
+            ->method('getChildren')
+            ->willReturn([$node1, $node2]);
+
+        $this->tagger->expects($this->exactly($expectedCallCount))
+            ->method('getTagsForObjects')
+            ->with($this->equalTo([123, 111, 222]))
+            ->willReturn(
+                [
+                    111 => $tags,
+                    123 => $tags
+                ]
+            );
+
+        // simulate sabre recursive PROPFIND traversal
+        $propFindRoot = new \Sabre\DAV\PropFind(
+            '/subdir',
+            $requestedProperties,
+            1
+        );
+        $propFind1 = new \Sabre\DAV\PropFind(
+            '/subdir/test.txt',
+            $requestedProperties,
+            0
+        );
+        $propFind2 = new \Sabre\DAV\PropFind(
+            '/subdir/test2.txt',
+            $requestedProperties,
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFindRoot,
+            $node
+        );
+        $this->plugin->handleGetProperties(
+            $propFind1,
+            $node1
+        );
+        $this->plugin->handleGetProperties(
+            $propFind2,
+            $node2
+        );
+
+        $result = $propFind1->getResultForMultiStatus();
+
+        $this->assertEmpty($result[404]);
+        unset($result[404]);
+        $this->assertEquals($expectedProperties, $result);
+    }
+
+    public static function tagsGetPropertiesDataProvider(): array {
+        return [
+            // request both, receive both
+            [
+                ['tag1', 'tag2', self::TAG_FAVORITE],
+                [self::TAGS_PROPERTYNAME, self::FAVORITE_PROPERTYNAME],
+                [
+                    200 => [
+                        self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2']),
+                        self::FAVORITE_PROPERTYNAME => true,
+                    ]
+                ]
+            ],
+            // request tags alone
+            [
+                ['tag1', 'tag2', self::TAG_FAVORITE],
+                [self::TAGS_PROPERTYNAME],
+                [
+                    200 => [
+                        self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2']),
+                    ]
+                ]
+            ],
+            // request fav alone
+            [
+                ['tag1', 'tag2', self::TAG_FAVORITE],
+                [self::FAVORITE_PROPERTYNAME],
+                [
+                    200 => [
+                        self::FAVORITE_PROPERTYNAME => true,
+                    ]
+                ]
+            ],
+            // request none
+            [
+                ['tag1', 'tag2', self::TAG_FAVORITE],
+                [],
+                [
+                    200 => []
+                ],
+            ],
+            // request both with none set, receive both
+            [
+                [],
+                [self::TAGS_PROPERTYNAME, self::FAVORITE_PROPERTYNAME],
+                [
+                    200 => [
+                        self::TAGS_PROPERTYNAME => new TagList([]),
+                        self::FAVORITE_PROPERTYNAME => false,
+                    ]
+                ]
+            ],
+        ];
+    }
+
+    public function testGetPropertiesSkipChunks(): void {
+        $sabreNode = $this->createMock(UploadFile::class);
+
+        $propFind = new \Sabre\DAV\PropFind(
+            '/dummyPath',
+            [self::TAGS_PROPERTYNAME, self::TAG_FAVORITE],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $sabreNode
+        );
+
+        $result = $propFind->getResultForMultiStatus();
+        $this->assertCount(2, $result[404]);
+    }
+
+    public function testUpdateTags(): void {
+        // this test will replace the existing tags "tagremove" with "tag1" and "tag2"
+        // and keep "tagkeep"
+        $node = $this->createMock(Node::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/dummypath')
+            ->willReturn($node);
+
+        $this->tagger->expects($this->once())
+            ->method('getTagsForObjects')
+            ->with($this->equalTo([123]))
+            ->willReturn([123 => ['tagkeep', 'tagremove', self::TAG_FAVORITE]]);
+
+        // then tag as tag1 and tag2
+        $calls = [
+            [123, 'tag1'],
+            [123, 'tag2'],
+        ];
+        $this->tagger->expects($this->exactly(count($calls)))
+            ->method('tagAs')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // it will untag tag3
+        $this->tagger->expects($this->once())
+            ->method('unTag')
+            ->with(123, 'tagremove');
+
+        // properties to set
+        $propPatch = new \Sabre\DAV\PropPatch([
+            self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2', 'tagkeep'])
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        // all requested properties removed, as they were processed already
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(200, $result[self::TAGS_PROPERTYNAME]);
+        $this->assertArrayNotHasKey(self::FAVORITE_PROPERTYNAME, $result);
+    }
+
+    public function testUpdateTagsFromScratch(): void {
+        $node = $this->createMock(Node::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/dummypath')
+            ->willReturn($node);
+
+        $this->tagger->expects($this->once())
+            ->method('getTagsForObjects')
+            ->with($this->equalTo([123]))
+            ->willReturn([]);
+
+        // then tag as tag1 and tag2
+        $calls = [
+            [123, 'tag1'],
+            [123, 'tag2'],
+        ];
+        $this->tagger->expects($this->exactly(count($calls)))
+            ->method('tagAs')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // properties to set
+        $propPatch = new \Sabre\DAV\PropPatch([
+            self::TAGS_PROPERTYNAME => new TagList(['tag1', 'tag2'])
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        // all requested properties removed, as they were processed already
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(200, $result[self::TAGS_PROPERTYNAME]);
+        $this->assertArrayNotHasKey(self::FAVORITE_PROPERTYNAME, $result);
+    }
+
+    public function testUpdateFav(): void {
+        // this test will replace the existing tags "tagremove" with "tag1" and "tag2"
+        // and keep "tagkeep"
+        $node = $this->createMock(Node::class);
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/dummypath')
+            ->willReturn($node);
+
+        // set favorite tag
+        $this->tagger->expects($this->once())
+            ->method('tagAs')
+            ->with(123, self::TAG_FAVORITE);
+
+        // properties to set
+        $propPatch = new \Sabre\DAV\PropPatch([
+            self::FAVORITE_PROPERTYNAME => true
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        // all requested properties removed, as they were processed already
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertArrayNotHasKey(self::TAGS_PROPERTYNAME, $result);
+        $this->assertEquals(200, $result[self::FAVORITE_PROPERTYNAME]);
+
+        // unfavorite now
+        // set favorite tag
+        $this->tagger->expects($this->once())
+            ->method('unTag')
+            ->with(123, self::TAG_FAVORITE);
+
+        // properties to set
+        $propPatch = new \Sabre\DAV\PropPatch([
+            self::FAVORITE_PROPERTYNAME => false
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        // all requested properties removed, as they were processed already
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertArrayNotHasKey(self::TAGS_PROPERTYNAME, $result);
+        $this->assertEquals(200, $result[self::FAVORITE_PROPERTYNAME]);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -265,7 +265,7 @@ 
 		];
 		$this->tagger->expects($this->exactly(count($calls)))
 			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -318,7 +318,7 @@ 
 		];
 		$this->tagger->expects($this->exactly(count($calls)))
 			->method('tagAs')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});

apps/dav/tests/unit/Connector/Sabre/ObjectTreeTest.php

Indentation +212 added lines, -212 removed lines

@@ -28,216 +28,216 @@
  * @package OCA\DAV\Tests\Unit\Connector\Sabre
  */
 class ObjectTreeTest extends \Test\TestCase {
-	public static function copyDataProvider(): array {
-		return [
-			// copy into same dir
-			['a', 'b', ''],
-			// copy into same dir
-			['a/a', 'a/b', 'a'],
-			// copy into another dir
-			['a', 'sub/a', 'sub'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('copyDataProvider')]
-	public function testCopy(string $sourcePath, string $targetPath, string $targetParent): void {
-		$view = $this->createMock(View::class);
-		$view->expects($this->once())
-			->method('verifyPath')
-			->with($targetParent);
-		$view->expects($this->once())
-			->method('file_exists')
-			->with($targetPath)
-			->willReturn(false);
-		$view->expects($this->once())
-			->method('copy')
-			->with($sourcePath, $targetPath)
-			->willReturn(true);
-
-		$info = $this->createMock(FileInfo::class);
-		$info->expects($this->once())
-			->method('isCreatable')
-			->willReturn(true);
-
-		$view->expects($this->once())
-			->method('getFileInfo')
-			->with($targetParent === '' ? '.' : $targetParent)
-			->willReturn($info);
-
-		$rootDir = new Directory($view, $info);
-		$objectTree = $this->getMockBuilder(ObjectTree::class)
-			->onlyMethods(['nodeExists', 'getNodeForPath'])
-			->setConstructorArgs([$rootDir, $view])
-			->getMock();
-
-		$objectTree->expects($this->once())
-			->method('getNodeForPath')
-			->with($this->identicalTo($sourcePath))
-			->willReturn(false);
-
-		/** @var ObjectTree $objectTree */
-		$mountManager = Filesystem::getMountManager();
-		$objectTree->init($rootDir, $view, $mountManager);
-		$objectTree->copy($sourcePath, $targetPath);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('copyDataProvider')]
-	public function testCopyFailNotCreatable($sourcePath, $targetPath, $targetParent): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$view = $this->createMock(View::class);
-		$view->expects($this->never())
-			->method('verifyPath');
-		$view->expects($this->once())
-			->method('file_exists')
-			->with($targetPath)
-			->willReturn(false);
-		$view->expects($this->never())
-			->method('copy');
-
-		$info = $this->createMock(FileInfo::class);
-		$info->expects($this->once())
-			->method('isCreatable')
-			->willReturn(false);
-
-		$view->expects($this->once())
-			->method('getFileInfo')
-			->with($targetParent === '' ? '.' : $targetParent)
-			->willReturn($info);
-
-		$rootDir = new Directory($view, $info);
-		$objectTree = $this->getMockBuilder(ObjectTree::class)
-			->onlyMethods(['nodeExists', 'getNodeForPath'])
-			->setConstructorArgs([$rootDir, $view])
-			->getMock();
-
-		$objectTree->expects($this->never())
-			->method('getNodeForPath');
-
-		/** @var ObjectTree $objectTree */
-		$mountManager = Filesystem::getMountManager();
-		$objectTree->init($rootDir, $view, $mountManager);
-		$objectTree->copy($sourcePath, $targetPath);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('nodeForPathProvider')]
-	public function testGetNodeForPath(
-		string $inputFileName,
-		string $fileInfoQueryPath,
-		string $outputFileName,
-		string $type,
-	): void {
-		$rootNode = $this->createMock(Directory::class);
-		$mountManager = $this->createMock(Manager::class);
-		$view = $this->createMock(View::class);
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->method('getType')
-			->willReturn($type);
-		$fileInfo->method('getName')
-			->willReturn($outputFileName);
-		$fileInfo->method('getStorage')
-			->willReturn($this->createMock(Common::class));
-
-		$view->method('getFileInfo')
-			->with($fileInfoQueryPath)
-			->willReturn($fileInfo);
-
-		$tree = new ObjectTree();
-		$tree->init($rootNode, $view, $mountManager);
-
-		$node = $tree->getNodeForPath($inputFileName);
-
-		$this->assertNotNull($node);
-		$this->assertEquals($outputFileName, $node->getName());
-
-		if ($type === 'file') {
-			$this->assertInstanceOf(File::class, $node);
-		} else {
-			$this->assertInstanceOf(Directory::class, $node);
-		}
-	}
-
-	public static function nodeForPathProvider(): array {
-		return [
-			// regular file
-			[
-				'regularfile.txt',
-				'regularfile.txt',
-				'regularfile.txt',
-				'file',
-			],
-			// regular directory
-			[
-				'regulardir',
-				'regulardir',
-				'regulardir',
-				'dir',
-			],
-			// regular file in subdir
-			[
-				'subdir/regularfile.txt',
-				'subdir/regularfile.txt',
-				'regularfile.txt',
-				'file',
-			],
-			// regular directory in subdir
-			[
-				'subdir/regulardir',
-				'subdir/regulardir',
-				'regulardir',
-				'dir',
-			],
-		];
-	}
-
-
-	public function testGetNodeForPathInvalidPath(): void {
-		$this->expectException(InvalidPath::class);
-
-		$path = '/foo\bar';
-
-
-		$storage = new Temporary([]);
-
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['resolvePath'])
-			->getMock();
-		$view->expects($this->once())
-			->method('resolvePath')
-			->willReturnCallback(function ($path) use ($storage) {
-				return [$storage, ltrim($path, '/')];
-			});
-
-		$rootNode = $this->createMock(Directory::class);
-		$mountManager = $this->createMock(IMountManager::class);
-
-		$tree = new ObjectTree();
-		$tree->init($rootNode, $view, $mountManager);
-
-		$tree->getNodeForPath($path);
-	}
-
-	public function testGetNodeForPathRoot(): void {
-		$path = '/';
-
-
-		$storage = new Temporary([]);
-
-		$view = $this->getMockBuilder(View::class)
-			->onlyMethods(['resolvePath'])
-			->getMock();
-		$view->expects($this->any())
-			->method('resolvePath')
-			->willReturnCallback(function ($path) use ($storage) {
-				return [$storage, ltrim($path, '/')];
-			});
-
-		$rootNode = $this->createMock(Directory::class);
-		$mountManager = $this->createMock(IMountManager::class);
-
-		$tree = new ObjectTree();
-		$tree->init($rootNode, $view, $mountManager);
-
-		$this->assertInstanceOf('\Sabre\DAV\INode', $tree->getNodeForPath($path));
-	}
+    public static function copyDataProvider(): array {
+        return [
+            // copy into same dir
+            ['a', 'b', ''],
+            // copy into same dir
+            ['a/a', 'a/b', 'a'],
+            // copy into another dir
+            ['a', 'sub/a', 'sub'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('copyDataProvider')]
+    public function testCopy(string $sourcePath, string $targetPath, string $targetParent): void {
+        $view = $this->createMock(View::class);
+        $view->expects($this->once())
+            ->method('verifyPath')
+            ->with($targetParent);
+        $view->expects($this->once())
+            ->method('file_exists')
+            ->with($targetPath)
+            ->willReturn(false);
+        $view->expects($this->once())
+            ->method('copy')
+            ->with($sourcePath, $targetPath)
+            ->willReturn(true);
+
+        $info = $this->createMock(FileInfo::class);
+        $info->expects($this->once())
+            ->method('isCreatable')
+            ->willReturn(true);
+
+        $view->expects($this->once())
+            ->method('getFileInfo')
+            ->with($targetParent === '' ? '.' : $targetParent)
+            ->willReturn($info);
+
+        $rootDir = new Directory($view, $info);
+        $objectTree = $this->getMockBuilder(ObjectTree::class)
+            ->onlyMethods(['nodeExists', 'getNodeForPath'])
+            ->setConstructorArgs([$rootDir, $view])
+            ->getMock();
+
+        $objectTree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with($this->identicalTo($sourcePath))
+            ->willReturn(false);
+
+        /** @var ObjectTree $objectTree */
+        $mountManager = Filesystem::getMountManager();
+        $objectTree->init($rootDir, $view, $mountManager);
+        $objectTree->copy($sourcePath, $targetPath);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('copyDataProvider')]
+    public function testCopyFailNotCreatable($sourcePath, $targetPath, $targetParent): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $view = $this->createMock(View::class);
+        $view->expects($this->never())
+            ->method('verifyPath');
+        $view->expects($this->once())
+            ->method('file_exists')
+            ->with($targetPath)
+            ->willReturn(false);
+        $view->expects($this->never())
+            ->method('copy');
+
+        $info = $this->createMock(FileInfo::class);
+        $info->expects($this->once())
+            ->method('isCreatable')
+            ->willReturn(false);
+
+        $view->expects($this->once())
+            ->method('getFileInfo')
+            ->with($targetParent === '' ? '.' : $targetParent)
+            ->willReturn($info);
+
+        $rootDir = new Directory($view, $info);
+        $objectTree = $this->getMockBuilder(ObjectTree::class)
+            ->onlyMethods(['nodeExists', 'getNodeForPath'])
+            ->setConstructorArgs([$rootDir, $view])
+            ->getMock();
+
+        $objectTree->expects($this->never())
+            ->method('getNodeForPath');
+
+        /** @var ObjectTree $objectTree */
+        $mountManager = Filesystem::getMountManager();
+        $objectTree->init($rootDir, $view, $mountManager);
+        $objectTree->copy($sourcePath, $targetPath);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('nodeForPathProvider')]
+    public function testGetNodeForPath(
+        string $inputFileName,
+        string $fileInfoQueryPath,
+        string $outputFileName,
+        string $type,
+    ): void {
+        $rootNode = $this->createMock(Directory::class);
+        $mountManager = $this->createMock(Manager::class);
+        $view = $this->createMock(View::class);
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->method('getType')
+            ->willReturn($type);
+        $fileInfo->method('getName')
+            ->willReturn($outputFileName);
+        $fileInfo->method('getStorage')
+            ->willReturn($this->createMock(Common::class));
+
+        $view->method('getFileInfo')
+            ->with($fileInfoQueryPath)
+            ->willReturn($fileInfo);
+
+        $tree = new ObjectTree();
+        $tree->init($rootNode, $view, $mountManager);
+
+        $node = $tree->getNodeForPath($inputFileName);
+
+        $this->assertNotNull($node);
+        $this->assertEquals($outputFileName, $node->getName());
+
+        if ($type === 'file') {
+            $this->assertInstanceOf(File::class, $node);
+        } else {
+            $this->assertInstanceOf(Directory::class, $node);
+        }
+    }
+
+    public static function nodeForPathProvider(): array {
+        return [
+            // regular file
+            [
+                'regularfile.txt',
+                'regularfile.txt',
+                'regularfile.txt',
+                'file',
+            ],
+            // regular directory
+            [
+                'regulardir',
+                'regulardir',
+                'regulardir',
+                'dir',
+            ],
+            // regular file in subdir
+            [
+                'subdir/regularfile.txt',
+                'subdir/regularfile.txt',
+                'regularfile.txt',
+                'file',
+            ],
+            // regular directory in subdir
+            [
+                'subdir/regulardir',
+                'subdir/regulardir',
+                'regulardir',
+                'dir',
+            ],
+        ];
+    }
+
+
+    public function testGetNodeForPathInvalidPath(): void {
+        $this->expectException(InvalidPath::class);
+
+        $path = '/foo\bar';
+
+
+        $storage = new Temporary([]);
+
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['resolvePath'])
+            ->getMock();
+        $view->expects($this->once())
+            ->method('resolvePath')
+            ->willReturnCallback(function ($path) use ($storage) {
+                return [$storage, ltrim($path, '/')];
+            });
+
+        $rootNode = $this->createMock(Directory::class);
+        $mountManager = $this->createMock(IMountManager::class);
+
+        $tree = new ObjectTree();
+        $tree->init($rootNode, $view, $mountManager);
+
+        $tree->getNodeForPath($path);
+    }
+
+    public function testGetNodeForPathRoot(): void {
+        $path = '/';
+
+
+        $storage = new Temporary([]);
+
+        $view = $this->getMockBuilder(View::class)
+            ->onlyMethods(['resolvePath'])
+            ->getMock();
+        $view->expects($this->any())
+            ->method('resolvePath')
+            ->willReturnCallback(function ($path) use ($storage) {
+                return [$storage, ltrim($path, '/')];
+            });
+
+        $rootNode = $this->createMock(Directory::class);
+        $mountManager = $this->createMock(IMountManager::class);
+
+        $tree = new ObjectTree();
+        $tree->init($rootNode, $view, $mountManager);
+
+        $this->assertInstanceOf('\Sabre\DAV\INode', $tree->getNodeForPath($path));
+    }
 }

apps/dav/tests/unit/Connector/Sabre/SharesPluginTest.php

Indentation +256 added lines, -256 removed lines

@@ -22,260 +22,260 @@
 use Sabre\DAV\Tree;
 
 class SharesPluginTest extends \Test\TestCase {
-	public const SHARETYPES_PROPERTYNAME = SharesPlugin::SHARETYPES_PROPERTYNAME;
-
-	private \Sabre\DAV\Server $server;
-	private \Sabre\DAV\Tree&MockObject $tree;
-	private \OCP\Share\IManager&MockObject $shareManager;
-	private Folder&MockObject $userFolder;
-	private SharesPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->server = new \Sabre\DAV\Server();
-		$this->tree = $this->createMock(Tree::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('getUID')
-			->willReturn('user1');
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-		$this->userFolder = $this->createMock(Folder::class);
-
-		$this->plugin = new SharesPlugin(
-			$this->tree,
-			$userSession,
-			$this->userFolder,
-			$this->shareManager
-		);
-		$this->plugin->initialize($this->server);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('sharesGetPropertiesDataProvider')]
-	public function testGetProperties(array $shareTypes): void {
-		$sabreNode = $this->createMock(Node::class);
-		$sabreNode->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-		$sabreNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/subdir');
-
-		// node API nodes
-		$node = $this->createMock(Folder::class);
-
-		$sabreNode->method('getNode')
-			->willReturn($node);
-
-		$this->shareManager->expects($this->any())
-			->method('getSharesBy')
-			->with(
-				$this->equalTo('user1'),
-				$this->anything(),
-				$this->equalTo($node),
-				$this->equalTo(false),
-				$this->equalTo(-1)
-			)
-			->willReturnCallback(function ($userId, $requestedShareType, $node, $flag, $limit) use ($shareTypes) {
-				if (in_array($requestedShareType, $shareTypes)) {
-					$share = $this->createMock(IShare::class);
-					$share->method('getShareType')
-						->willReturn($requestedShareType);
-					return [$share];
-				}
-				return [];
-			});
-
-		$this->shareManager->expects($this->any())
-			->method('getSharedWith')
-			->with(
-				$this->equalTo('user1'),
-				$this->anything(),
-				$this->equalTo($node),
-				$this->equalTo(-1)
-			)
-			->willReturn([]);
-
-		$propFind = new \Sabre\DAV\PropFind(
-			'/dummyPath',
-			[self::SHARETYPES_PROPERTYNAME],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$sabreNode
-		);
-
-		$result = $propFind->getResultForMultiStatus();
-
-		$this->assertEmpty($result[404]);
-		unset($result[404]);
-		$this->assertEquals($shareTypes, $result[200][self::SHARETYPES_PROPERTYNAME]->getShareTypes());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('sharesGetPropertiesDataProvider')]
-	public function testPreloadThenGetProperties(array $shareTypes): void {
-		$sabreNode1 = $this->createMock(File::class);
-		$sabreNode1->method('getId')
-			->willReturn(111);
-		$sabreNode2 = $this->createMock(File::class);
-		$sabreNode2->method('getId')
-			->willReturn(222);
-		$sabreNode2->method('getPath')
-			->willReturn('/subdir/foo');
-
-		$sabreNode = $this->createMock(Directory::class);
-		$sabreNode->method('getId')
-			->willReturn(123);
-		// never, because we use getDirectoryListing from the Node API instead
-		$sabreNode->expects($this->never())
-			->method('getChildren');
-		$sabreNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/subdir');
-
-		// node API nodes
-		$node = $this->createMock(Folder::class);
-		$node->method('getId')
-			->willReturn(123);
-		$node1 = $this->createMock(\OC\Files\Node\File::class);
-		$node1->method('getId')
-			->willReturn(111);
-		$node2 = $this->createMock(\OC\Files\Node\File::class);
-		$node2->method('getId')
-			->willReturn(222);
-
-		$sabreNode->method('getNode')
-			->willReturn($node);
-		$sabreNode1->method('getNode')
-			->willReturn($node1);
-		$sabreNode2->method('getNode')
-			->willReturn($node2);
-
-		$dummyShares = array_map(function ($type) {
-			$share = $this->createMock(IShare::class);
-			$share->expects($this->any())
-				->method('getShareType')
-				->willReturn($type);
-			return $share;
-		}, $shareTypes);
-
-		$this->shareManager->expects($this->any())
-			->method('getSharesBy')
-			->with(
-				$this->equalTo('user1'),
-				$this->anything(),
-				$this->anything(),
-				$this->equalTo(false),
-				$this->equalTo(-1)
-			)
-			->willReturnCallback(function ($userId, $requestedShareType, $node, $flag, $limit) use ($shareTypes, $dummyShares) {
-				if ($node->getId() === 111 && in_array($requestedShareType, $shareTypes)) {
-					foreach ($dummyShares as $dummyShare) {
-						if ($dummyShare->getShareType() === $requestedShareType) {
-							return [$dummyShare];
-						}
-					}
-				}
-
-				return [];
-			});
-
-		$this->shareManager->expects($this->any())
-			->method('getSharedWith')
-			->with(
-				$this->equalTo('user1'),
-				$this->anything(),
-				$this->equalTo($node),
-				$this->equalTo(-1)
-			)
-			->willReturn([]);
-
-		$this->shareManager->expects($this->any())
-			->method('getSharesInFolder')
-			->with(
-				$this->equalTo('user1'),
-				$this->anything(),
-				$this->equalTo(true)
-			)
-			->willReturnCallback(function ($userId, $node, $flag) use ($shareTypes, $dummyShares) {
-				return [111 => $dummyShares];
-			});
-
-		// simulate sabre recursive PROPFIND traversal
-		$propFindRoot = new \Sabre\DAV\PropFind(
-			'/subdir',
-			[self::SHARETYPES_PROPERTYNAME],
-			1
-		);
-		$propFind1 = new \Sabre\DAV\PropFind(
-			'/subdir/test.txt',
-			[self::SHARETYPES_PROPERTYNAME],
-			0
-		);
-		$propFind2 = new \Sabre\DAV\PropFind(
-			'/subdir/test2.txt',
-			[self::SHARETYPES_PROPERTYNAME],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFindRoot,
-			$sabreNode
-		);
-		$this->plugin->handleGetProperties(
-			$propFind1,
-			$sabreNode1
-		);
-		$this->plugin->handleGetProperties(
-			$propFind2,
-			$sabreNode2
-		);
-
-		$result = $propFind1->getResultForMultiStatus();
-
-		$this->assertEmpty($result[404]);
-		unset($result[404]);
-		$this->assertEquals($shareTypes, $result[200][self::SHARETYPES_PROPERTYNAME]->getShareTypes());
-	}
-
-	public static function sharesGetPropertiesDataProvider(): array {
-		return [
-			[[]],
-			[[IShare::TYPE_USER]],
-			[[IShare::TYPE_GROUP]],
-			[[IShare::TYPE_LINK]],
-			[[IShare::TYPE_REMOTE]],
-			[[IShare::TYPE_ROOM]],
-			[[IShare::TYPE_DECK]],
-			[[IShare::TYPE_SCIENCEMESH]],
-			[[IShare::TYPE_USER, IShare::TYPE_GROUP]],
-			[[IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_LINK]],
-			[[IShare::TYPE_USER, IShare::TYPE_LINK]],
-			[[IShare::TYPE_GROUP, IShare::TYPE_LINK]],
-			[[IShare::TYPE_USER, IShare::TYPE_REMOTE]],
-		];
-	}
-
-	public function testGetPropertiesSkipChunks(): void {
-		$sabreNode = $this->createMock(UploadFile::class);
-
-		$propFind = new \Sabre\DAV\PropFind(
-			'/dummyPath',
-			[self::SHARETYPES_PROPERTYNAME],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$sabreNode
-		);
-
-		$result = $propFind->getResultForMultiStatus();
-		$this->assertCount(1, $result[404]);
-	}
+    public const SHARETYPES_PROPERTYNAME = SharesPlugin::SHARETYPES_PROPERTYNAME;
+
+    private \Sabre\DAV\Server $server;
+    private \Sabre\DAV\Tree&MockObject $tree;
+    private \OCP\Share\IManager&MockObject $shareManager;
+    private Folder&MockObject $userFolder;
+    private SharesPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->server = new \Sabre\DAV\Server();
+        $this->tree = $this->createMock(Tree::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('getUID')
+            ->willReturn('user1');
+        $userSession = $this->createMock(IUserSession::class);
+        $userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+        $this->userFolder = $this->createMock(Folder::class);
+
+        $this->plugin = new SharesPlugin(
+            $this->tree,
+            $userSession,
+            $this->userFolder,
+            $this->shareManager
+        );
+        $this->plugin->initialize($this->server);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('sharesGetPropertiesDataProvider')]
+    public function testGetProperties(array $shareTypes): void {
+        $sabreNode = $this->createMock(Node::class);
+        $sabreNode->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+        $sabreNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/subdir');
+
+        // node API nodes
+        $node = $this->createMock(Folder::class);
+
+        $sabreNode->method('getNode')
+            ->willReturn($node);
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharesBy')
+            ->with(
+                $this->equalTo('user1'),
+                $this->anything(),
+                $this->equalTo($node),
+                $this->equalTo(false),
+                $this->equalTo(-1)
+            )
+            ->willReturnCallback(function ($userId, $requestedShareType, $node, $flag, $limit) use ($shareTypes) {
+                if (in_array($requestedShareType, $shareTypes)) {
+                    $share = $this->createMock(IShare::class);
+                    $share->method('getShareType')
+                        ->willReturn($requestedShareType);
+                    return [$share];
+                }
+                return [];
+            });
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharedWith')
+            ->with(
+                $this->equalTo('user1'),
+                $this->anything(),
+                $this->equalTo($node),
+                $this->equalTo(-1)
+            )
+            ->willReturn([]);
+
+        $propFind = new \Sabre\DAV\PropFind(
+            '/dummyPath',
+            [self::SHARETYPES_PROPERTYNAME],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $sabreNode
+        );
+
+        $result = $propFind->getResultForMultiStatus();
+
+        $this->assertEmpty($result[404]);
+        unset($result[404]);
+        $this->assertEquals($shareTypes, $result[200][self::SHARETYPES_PROPERTYNAME]->getShareTypes());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('sharesGetPropertiesDataProvider')]
+    public function testPreloadThenGetProperties(array $shareTypes): void {
+        $sabreNode1 = $this->createMock(File::class);
+        $sabreNode1->method('getId')
+            ->willReturn(111);
+        $sabreNode2 = $this->createMock(File::class);
+        $sabreNode2->method('getId')
+            ->willReturn(222);
+        $sabreNode2->method('getPath')
+            ->willReturn('/subdir/foo');
+
+        $sabreNode = $this->createMock(Directory::class);
+        $sabreNode->method('getId')
+            ->willReturn(123);
+        // never, because we use getDirectoryListing from the Node API instead
+        $sabreNode->expects($this->never())
+            ->method('getChildren');
+        $sabreNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/subdir');
+
+        // node API nodes
+        $node = $this->createMock(Folder::class);
+        $node->method('getId')
+            ->willReturn(123);
+        $node1 = $this->createMock(\OC\Files\Node\File::class);
+        $node1->method('getId')
+            ->willReturn(111);
+        $node2 = $this->createMock(\OC\Files\Node\File::class);
+        $node2->method('getId')
+            ->willReturn(222);
+
+        $sabreNode->method('getNode')
+            ->willReturn($node);
+        $sabreNode1->method('getNode')
+            ->willReturn($node1);
+        $sabreNode2->method('getNode')
+            ->willReturn($node2);
+
+        $dummyShares = array_map(function ($type) {
+            $share = $this->createMock(IShare::class);
+            $share->expects($this->any())
+                ->method('getShareType')
+                ->willReturn($type);
+            return $share;
+        }, $shareTypes);
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharesBy')
+            ->with(
+                $this->equalTo('user1'),
+                $this->anything(),
+                $this->anything(),
+                $this->equalTo(false),
+                $this->equalTo(-1)
+            )
+            ->willReturnCallback(function ($userId, $requestedShareType, $node, $flag, $limit) use ($shareTypes, $dummyShares) {
+                if ($node->getId() === 111 && in_array($requestedShareType, $shareTypes)) {
+                    foreach ($dummyShares as $dummyShare) {
+                        if ($dummyShare->getShareType() === $requestedShareType) {
+                            return [$dummyShare];
+                        }
+                    }
+                }
+
+                return [];
+            });
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharedWith')
+            ->with(
+                $this->equalTo('user1'),
+                $this->anything(),
+                $this->equalTo($node),
+                $this->equalTo(-1)
+            )
+            ->willReturn([]);
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharesInFolder')
+            ->with(
+                $this->equalTo('user1'),
+                $this->anything(),
+                $this->equalTo(true)
+            )
+            ->willReturnCallback(function ($userId, $node, $flag) use ($shareTypes, $dummyShares) {
+                return [111 => $dummyShares];
+            });
+
+        // simulate sabre recursive PROPFIND traversal
+        $propFindRoot = new \Sabre\DAV\PropFind(
+            '/subdir',
+            [self::SHARETYPES_PROPERTYNAME],
+            1
+        );
+        $propFind1 = new \Sabre\DAV\PropFind(
+            '/subdir/test.txt',
+            [self::SHARETYPES_PROPERTYNAME],
+            0
+        );
+        $propFind2 = new \Sabre\DAV\PropFind(
+            '/subdir/test2.txt',
+            [self::SHARETYPES_PROPERTYNAME],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFindRoot,
+            $sabreNode
+        );
+        $this->plugin->handleGetProperties(
+            $propFind1,
+            $sabreNode1
+        );
+        $this->plugin->handleGetProperties(
+            $propFind2,
+            $sabreNode2
+        );
+
+        $result = $propFind1->getResultForMultiStatus();
+
+        $this->assertEmpty($result[404]);
+        unset($result[404]);
+        $this->assertEquals($shareTypes, $result[200][self::SHARETYPES_PROPERTYNAME]->getShareTypes());
+    }
+
+    public static function sharesGetPropertiesDataProvider(): array {
+        return [
+            [[]],
+            [[IShare::TYPE_USER]],
+            [[IShare::TYPE_GROUP]],
+            [[IShare::TYPE_LINK]],
+            [[IShare::TYPE_REMOTE]],
+            [[IShare::TYPE_ROOM]],
+            [[IShare::TYPE_DECK]],
+            [[IShare::TYPE_SCIENCEMESH]],
+            [[IShare::TYPE_USER, IShare::TYPE_GROUP]],
+            [[IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_LINK]],
+            [[IShare::TYPE_USER, IShare::TYPE_LINK]],
+            [[IShare::TYPE_GROUP, IShare::TYPE_LINK]],
+            [[IShare::TYPE_USER, IShare::TYPE_REMOTE]],
+        ];
+    }
+
+    public function testGetPropertiesSkipChunks(): void {
+        $sabreNode = $this->createMock(UploadFile::class);
+
+        $propFind = new \Sabre\DAV\PropFind(
+            '/dummyPath',
+            [self::SHARETYPES_PROPERTYNAME],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $sabreNode
+        );
+
+        $result = $propFind->getResultForMultiStatus();
+        $this->assertCount(1, $result[404]);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/FakeLockerPluginTest.php

Indentation +134 added lines, -134 removed lines

@@ -23,138 +23,138 @@
  * @package OCA\DAV\Tests\unit\Connector\Sabre
  */
 class FakeLockerPluginTest extends TestCase {
-	private FakeLockerPlugin $fakeLockerPlugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->fakeLockerPlugin = new FakeLockerPlugin();
-	}
-
-	public function testInitialize(): void {
-		/** @var Server $server */
-		$server = $this->createMock(Server::class);
-		$calls = [
-			['method:LOCK', [$this->fakeLockerPlugin, 'fakeLockProvider'], 1],
-			['method:UNLOCK', [$this->fakeLockerPlugin, 'fakeUnlockProvider'], 1],
-			['propFind', [$this->fakeLockerPlugin, 'propFind'], 100],
-			['validateTokens', [$this->fakeLockerPlugin, 'validateTokens'], 100],
-		];
-		$server->expects($this->exactly(count($calls)))
-			->method('on')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		$this->fakeLockerPlugin->initialize($server);
-	}
-
-	public function testGetHTTPMethods(): void {
-		$expected = [
-			'LOCK',
-			'UNLOCK',
-		];
-		$this->assertSame($expected, $this->fakeLockerPlugin->getHTTPMethods('Test'));
-	}
-
-	public function testGetFeatures(): void {
-		$expected = [
-			2,
-		];
-		$this->assertSame($expected, $this->fakeLockerPlugin->getFeatures());
-	}
-
-	public function testPropFind(): void {
-		$propFind = $this->createMock(PropFind::class);
-		$node = $this->createMock(INode::class);
-
-		$calls = [
-			'{DAV:}supportedlock',
-			'{DAV:}lockdiscovery',
-		];
-		$propFind->expects($this->exactly(count($calls)))
-			->method('handle')
-			->willReturnCallback(function ($propertyName) use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $propertyName);
-			});
-
-		$this->fakeLockerPlugin->propFind($propFind, $node);
-	}
-
-	public static function tokenDataProvider(): array {
-		return [
-			[
-				[
-					[
-						'tokens' => [
-							[
-								'token' => 'aToken',
-								'validToken' => false,
-							],
-							[],
-							[
-								'token' => 'opaquelocktoken:asdf',
-								'validToken' => false,
-							]
-						],
-					]
-				],
-				[
-					[
-						'tokens' => [
-							[
-								'token' => 'aToken',
-								'validToken' => false,
-							],
-							[],
-							[
-								'token' => 'opaquelocktoken:asdf',
-								'validToken' => true,
-							]
-						],
-					]
-				],
-			]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('tokenDataProvider')]
-	public function testValidateTokens(array $input, array $expected): void {
-		$request = $this->createMock(RequestInterface::class);
-		$this->fakeLockerPlugin->validateTokens($request, $input);
-		$this->assertSame($expected, $input);
-	}
-
-	public function testFakeLockProvider(): void {
-		$request = $this->createMock(RequestInterface::class);
-		$response = new Response();
-		$server = $this->getMockBuilder(Server::class)
-			->getMock();
-		$this->fakeLockerPlugin->initialize($server);
-
-		$request->expects($this->exactly(2))
-			->method('getPath')
-			->willReturn('MyPath');
-
-		$this->assertSame(false, $this->fakeLockerPlugin->fakeLockProvider($request, $response));
-
-		$expectedXml = '<?xml version="1.0" encoding="utf-8"?><d:prop xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns"><d:lockdiscovery><d:activelock><d:lockscope><d:exclusive/></d:lockscope><d:locktype><d:write/></d:locktype><d:lockroot><d:href>MyPath</d:href></d:lockroot><d:depth>infinity</d:depth><d:timeout>Second-1800</d:timeout><d:locktoken><d:href>opaquelocktoken:fe4f7f2437b151fbcb4e9f5c8118c6b1</d:href></d:locktoken></d:activelock></d:lockdiscovery></d:prop>';
-
-		$this->assertXmlStringEqualsXmlString($expectedXml, $response->getBody());
-	}
-
-	public function testFakeUnlockProvider(): void {
-		$request = $this->createMock(RequestInterface::class);
-		$response = $this->createMock(ResponseInterface::class);
-
-		$response->expects($this->once())
-			->method('setStatus')
-			->with('204');
-		$response->expects($this->once())
-			->method('setHeader')
-			->with('Content-Length', '0');
-
-		$this->assertSame(false, $this->fakeLockerPlugin->fakeUnlockProvider($request, $response));
-	}
+    private FakeLockerPlugin $fakeLockerPlugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->fakeLockerPlugin = new FakeLockerPlugin();
+    }
+
+    public function testInitialize(): void {
+        /** @var Server $server */
+        $server = $this->createMock(Server::class);
+        $calls = [
+            ['method:LOCK', [$this->fakeLockerPlugin, 'fakeLockProvider'], 1],
+            ['method:UNLOCK', [$this->fakeLockerPlugin, 'fakeUnlockProvider'], 1],
+            ['propFind', [$this->fakeLockerPlugin, 'propFind'], 100],
+            ['validateTokens', [$this->fakeLockerPlugin, 'validateTokens'], 100],
+        ];
+        $server->expects($this->exactly(count($calls)))
+            ->method('on')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        $this->fakeLockerPlugin->initialize($server);
+    }
+
+    public function testGetHTTPMethods(): void {
+        $expected = [
+            'LOCK',
+            'UNLOCK',
+        ];
+        $this->assertSame($expected, $this->fakeLockerPlugin->getHTTPMethods('Test'));
+    }
+
+    public function testGetFeatures(): void {
+        $expected = [
+            2,
+        ];
+        $this->assertSame($expected, $this->fakeLockerPlugin->getFeatures());
+    }
+
+    public function testPropFind(): void {
+        $propFind = $this->createMock(PropFind::class);
+        $node = $this->createMock(INode::class);
+
+        $calls = [
+            '{DAV:}supportedlock',
+            '{DAV:}lockdiscovery',
+        ];
+        $propFind->expects($this->exactly(count($calls)))
+            ->method('handle')
+            ->willReturnCallback(function ($propertyName) use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $propertyName);
+            });
+
+        $this->fakeLockerPlugin->propFind($propFind, $node);
+    }
+
+    public static function tokenDataProvider(): array {
+        return [
+            [
+                [
+                    [
+                        'tokens' => [
+                            [
+                                'token' => 'aToken',
+                                'validToken' => false,
+                            ],
+                            [],
+                            [
+                                'token' => 'opaquelocktoken:asdf',
+                                'validToken' => false,
+                            ]
+                        ],
+                    ]
+                ],
+                [
+                    [
+                        'tokens' => [
+                            [
+                                'token' => 'aToken',
+                                'validToken' => false,
+                            ],
+                            [],
+                            [
+                                'token' => 'opaquelocktoken:asdf',
+                                'validToken' => true,
+                            ]
+                        ],
+                    ]
+                ],
+            ]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('tokenDataProvider')]
+    public function testValidateTokens(array $input, array $expected): void {
+        $request = $this->createMock(RequestInterface::class);
+        $this->fakeLockerPlugin->validateTokens($request, $input);
+        $this->assertSame($expected, $input);
+    }
+
+    public function testFakeLockProvider(): void {
+        $request = $this->createMock(RequestInterface::class);
+        $response = new Response();
+        $server = $this->getMockBuilder(Server::class)
+            ->getMock();
+        $this->fakeLockerPlugin->initialize($server);
+
+        $request->expects($this->exactly(2))
+            ->method('getPath')
+            ->willReturn('MyPath');
+
+        $this->assertSame(false, $this->fakeLockerPlugin->fakeLockProvider($request, $response));
+
+        $expectedXml = '<?xml version="1.0" encoding="utf-8"?><d:prop xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns"><d:lockdiscovery><d:activelock><d:lockscope><d:exclusive/></d:lockscope><d:locktype><d:write/></d:locktype><d:lockroot><d:href>MyPath</d:href></d:lockroot><d:depth>infinity</d:depth><d:timeout>Second-1800</d:timeout><d:locktoken><d:href>opaquelocktoken:fe4f7f2437b151fbcb4e9f5c8118c6b1</d:href></d:locktoken></d:activelock></d:lockdiscovery></d:prop>';
+
+        $this->assertXmlStringEqualsXmlString($expectedXml, $response->getBody());
+    }
+
+    public function testFakeUnlockProvider(): void {
+        $request = $this->createMock(RequestInterface::class);
+        $response = $this->createMock(ResponseInterface::class);
+
+        $response->expects($this->once())
+            ->method('setStatus')
+            ->with('204');
+        $response->expects($this->once())
+            ->method('setHeader')
+            ->with('Content-Length', '0');
+
+        $this->assertSame(false, $this->fakeLockerPlugin->fakeUnlockProvider($request, $response));
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
 		];
 		$server->expects($this->exactly(count($calls)))
 			->method('on')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -74,7 +74,7 @@ 
 		];
 		$propFind->expects($this->exactly(count($calls)))
 			->method('handle')
-			->willReturnCallback(function ($propertyName) use (&$calls): void {
+			->willReturnCallback(function($propertyName) use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $propertyName);
 			});

apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php

Indentation +414 added lines, -414 removed lines

@@ -26,32 +26,32 @@ 
 use Test\Traits\UserTrait;
 
 class TestViewDirectory extends View {
-	public function __construct(
-		private $updatables,
-		private $deletables,
-		private $canRename = true,
-	) {
-	}
-
-	public function isUpdatable($path) {
-		return $this->updatables[$path];
-	}
-
-	public function isCreatable($path) {
-		return $this->updatables[$path];
-	}
-
-	public function isDeletable($path) {
-		return $this->deletables[$path];
-	}
-
-	public function rename($source, $target, array $options = []) {
-		return $this->canRename;
-	}
-
-	public function getRelativePath($path): ?string {
-		return $path;
-	}
+    public function __construct(
+        private $updatables,
+        private $deletables,
+        private $canRename = true,
+    ) {
+    }
+
+    public function isUpdatable($path) {
+        return $this->updatables[$path];
+    }
+
+    public function isCreatable($path) {
+        return $this->updatables[$path];
+    }
+
+    public function isDeletable($path) {
+        return $this->deletables[$path];
+    }
+
+    public function rename($source, $target, array $options = []) {
+        return $this->canRename;
+    }
+
+    public function getRelativePath($path): ?string {
+        return $path;
+    }
 }
 
 
@@ -59,410 +59,410 @@ 
  * @group DB
  */
 class DirectoryTest extends \Test\TestCase {
-	use UserTrait;
+    use UserTrait;
 
-	private View&MockObject $view;
-	private FileInfo&MockObject $info;
+    private View&MockObject $view;
+    private FileInfo&MockObject $info;
 
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->view = $this->createMock(View::class);
-		$this->info = $this->createMock(FileInfo::class);
-		$this->info->method('isReadable')
-			->willReturn(true);
-		$this->info->method('getType')
-			->willReturn(Node::TYPE_FOLDER);
-		$this->info->method('getName')
-			->willReturn('folder');
-		$this->info->method('getPath')
-			->willReturn('/admin/files/folder');
-		$this->info->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-	}
-
-	private function getDir(string $path = '/'): Directory {
-		$this->view->expects($this->once())
-			->method('getRelativePath')
-			->willReturn($path);
-
-		$this->info->expects($this->once())
-			->method('getPath')
-			->willReturn($path);
-
-		return new Directory($this->view, $this->info);
-	}
-
-
-	public function testDeleteRootFolderFails(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$this->info->expects($this->any())
-			->method('isDeletable')
-			->willReturn(true);
-		$this->view->expects($this->never())
-			->method('rmdir');
-		$dir = $this->getDir();
-		$dir->delete();
-	}
-
-
-	public function testDeleteForbidden(): void {
-		$this->expectException(Forbidden::class);
-
-		// deletion allowed
-		$this->info->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		// but fails
-		$this->view->expects($this->once())
-			->method('rmdir')
-			->with('sub')
-			->willThrowException(new ForbiddenException('', true));
-
-		$dir = $this->getDir('sub');
-		$dir->delete();
-	}
-
-
-	public function testDeleteFolderWhenAllowed(): void {
-		// deletion allowed
-		$this->info->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		// but fails
-		$this->view->expects($this->once())
-			->method('rmdir')
-			->with('sub')
-			->willReturn(true);
-
-		$dir = $this->getDir('sub');
-		$dir->delete();
-	}
-
-
-	public function testDeleteFolderFailsWhenNotAllowed(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->view = $this->createMock(View::class);
+        $this->info = $this->createMock(FileInfo::class);
+        $this->info->method('isReadable')
+            ->willReturn(true);
+        $this->info->method('getType')
+            ->willReturn(Node::TYPE_FOLDER);
+        $this->info->method('getName')
+            ->willReturn('folder');
+        $this->info->method('getPath')
+            ->willReturn('/admin/files/folder');
+        $this->info->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+    }
+
+    private function getDir(string $path = '/'): Directory {
+        $this->view->expects($this->once())
+            ->method('getRelativePath')
+            ->willReturn($path);
+
+        $this->info->expects($this->once())
+            ->method('getPath')
+            ->willReturn($path);
+
+        return new Directory($this->view, $this->info);
+    }
+
+
+    public function testDeleteRootFolderFails(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $this->info->expects($this->any())
+            ->method('isDeletable')
+            ->willReturn(true);
+        $this->view->expects($this->never())
+            ->method('rmdir');
+        $dir = $this->getDir();
+        $dir->delete();
+    }
+
+
+    public function testDeleteForbidden(): void {
+        $this->expectException(Forbidden::class);
+
+        // deletion allowed
+        $this->info->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        // but fails
+        $this->view->expects($this->once())
+            ->method('rmdir')
+            ->with('sub')
+            ->willThrowException(new ForbiddenException('', true));
+
+        $dir = $this->getDir('sub');
+        $dir->delete();
+    }
+
+
+    public function testDeleteFolderWhenAllowed(): void {
+        // deletion allowed
+        $this->info->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        // but fails
+        $this->view->expects($this->once())
+            ->method('rmdir')
+            ->with('sub')
+            ->willReturn(true);
+
+        $dir = $this->getDir('sub');
+        $dir->delete();
+    }
+
+
+    public function testDeleteFolderFailsWhenNotAllowed(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$this->info->expects($this->once())
-			->method('isDeletable')
-			->willReturn(false);
+        $this->info->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(false);
 
-		$dir = $this->getDir('sub');
-		$dir->delete();
-	}
+        $dir = $this->getDir('sub');
+        $dir->delete();
+    }
 
 
-	public function testDeleteFolderThrowsWhenDeletionFailed(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testDeleteFolderThrowsWhenDeletionFailed(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		// deletion allowed
-		$this->info->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		// but fails
-		$this->view->expects($this->once())
-			->method('rmdir')
-			->with('sub')
-			->willReturn(false);
-
-		$dir = $this->getDir('sub');
-		$dir->delete();
-	}
-
-	public function testGetChildren(): void {
-		$info1 = $this->createMock(FileInfo::class);
-		$info2 = $this->createMock(FileInfo::class);
-		$info1->method('getName')
-			->willReturn('first');
-		$info1->method('getPath')
-			->willReturn('folder/first');
-		$info1->method('getEtag')
-			->willReturn('abc');
-		$info2->method('getName')
-			->willReturn('second');
-		$info2->method('getPath')
-			->willReturn('folder/second');
-		$info2->method('getEtag')
-			->willReturn('def');
+        // deletion allowed
+        $this->info->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        // but fails
+        $this->view->expects($this->once())
+            ->method('rmdir')
+            ->with('sub')
+            ->willReturn(false);
+
+        $dir = $this->getDir('sub');
+        $dir->delete();
+    }
+
+    public function testGetChildren(): void {
+        $info1 = $this->createMock(FileInfo::class);
+        $info2 = $this->createMock(FileInfo::class);
+        $info1->method('getName')
+            ->willReturn('first');
+        $info1->method('getPath')
+            ->willReturn('folder/first');
+        $info1->method('getEtag')
+            ->willReturn('abc');
+        $info2->method('getName')
+            ->willReturn('second');
+        $info2->method('getPath')
+            ->willReturn('folder/second');
+        $info2->method('getEtag')
+            ->willReturn('def');
 
-		$this->view->expects($this->once())
-			->method('getDirectoryContent')
-			->willReturn([$info1, $info2]);
+        $this->view->expects($this->once())
+            ->method('getDirectoryContent')
+            ->willReturn([$info1, $info2]);
 
-		$this->view->expects($this->any())
-			->method('getRelativePath')
-			->willReturnCallback(function ($path) {
-				return str_replace('/admin/files/', '', $path);
-			});
-
-		$this->view->expects($this->any())
-			->method('getAbsolutePath')
-			->willReturnCallback(function ($path) {
-				return Filesystem::normalizePath('/admin/files' . $path);
-			});
+        $this->view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturnCallback(function ($path) {
+                return str_replace('/admin/files/', '', $path);
+            });
+
+        $this->view->expects($this->any())
+            ->method('getAbsolutePath')
+            ->willReturnCallback(function ($path) {
+                return Filesystem::normalizePath('/admin/files' . $path);
+            });
 
-		$this->overwriteService(View::class, $this->view);
-
-		$dir = new Directory($this->view, $this->info);
-		$nodes = $dir->getChildren();
-
-		$this->assertCount(2, $nodes);
-
-		// calling a second time just returns the cached values,
-		// does not call getDirectoryContents again
-		$dir->getChildren();
-	}
+        $this->overwriteService(View::class, $this->view);
+
+        $dir = new Directory($this->view, $this->info);
+        $nodes = $dir->getChildren();
+
+        $this->assertCount(2, $nodes);
+
+        // calling a second time just returns the cached values,
+        // does not call getDirectoryContents again
+        $dir->getChildren();
+    }
 
 
-	public function testGetChildrenNoPermission(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+    public function testGetChildrenNoPermission(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
 
-		$info = $this->createMock(FileInfo::class);
-		$info->expects($this->any())
-			->method('isReadable')
-			->willReturn(false);
-
-		$dir = new Directory($this->view, $info);
-		$dir->getChildren();
-	}
-
-
-	public function testGetChildNoPermission(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-
-		$this->info->expects($this->any())
-			->method('isReadable')
-			->willReturn(false);
-
-		$dir = new Directory($this->view, $this->info);
-		$dir->getChild('test');
-	}
-
-
-	public function testGetChildThrowStorageNotAvailableException(): void {
-		$this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
-
-		$this->view->expects($this->once())
-			->method('getFileInfo')
-			->willThrowException(new StorageNotAvailableException());
-
-		$dir = new Directory($this->view, $this->info);
-		$dir->getChild('.');
-	}
-
-
-	public function testGetChildThrowInvalidPath(): void {
-		$this->expectException(InvalidPath::class);
-
-		$this->view->expects($this->once())
-			->method('verifyPath')
-			->willThrowException(new InvalidPathException());
-		$this->view->expects($this->never())
-			->method('getFileInfo');
-
-		$dir = new Directory($this->view, $this->info);
-		$dir->getChild('.');
-	}
-
-	public function testGetQuotaInfoUnlimited(): void {
-		$this->createUser('user', 'password');
-		self::loginAsUser('user');
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$storage = $this->createMock(Quota::class);
-		$mountPoint->method('getStorage')
-			->willReturn($storage);
-
-		$storage->expects($this->any())
-			->method('instanceOfStorage')
-			->willReturnMap([
-				['\OCA\Files_Sharing\SharedStorage', false],
-				['\OC\Files\Storage\Wrapper\Quota', false],
-				[Storage::class, false],
-			]);
-
-		$storage->expects($this->once())
-			->method('getOwner')
-			->willReturn('user');
+        $info = $this->createMock(FileInfo::class);
+        $info->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(false);
+
+        $dir = new Directory($this->view, $info);
+        $dir->getChildren();
+    }
+
+
+    public function testGetChildNoPermission(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+
+        $this->info->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(false);
+
+        $dir = new Directory($this->view, $this->info);
+        $dir->getChild('test');
+    }
+
+
+    public function testGetChildThrowStorageNotAvailableException(): void {
+        $this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
+
+        $this->view->expects($this->once())
+            ->method('getFileInfo')
+            ->willThrowException(new StorageNotAvailableException());
+
+        $dir = new Directory($this->view, $this->info);
+        $dir->getChild('.');
+    }
+
+
+    public function testGetChildThrowInvalidPath(): void {
+        $this->expectException(InvalidPath::class);
+
+        $this->view->expects($this->once())
+            ->method('verifyPath')
+            ->willThrowException(new InvalidPathException());
+        $this->view->expects($this->never())
+            ->method('getFileInfo');
+
+        $dir = new Directory($this->view, $this->info);
+        $dir->getChild('.');
+    }
+
+    public function testGetQuotaInfoUnlimited(): void {
+        $this->createUser('user', 'password');
+        self::loginAsUser('user');
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $storage = $this->createMock(Quota::class);
+        $mountPoint->method('getStorage')
+            ->willReturn($storage);
+
+        $storage->expects($this->any())
+            ->method('instanceOfStorage')
+            ->willReturnMap([
+                ['\OCA\Files_Sharing\SharedStorage', false],
+                ['\OC\Files\Storage\Wrapper\Quota', false],
+                [Storage::class, false],
+            ]);
+
+        $storage->expects($this->once())
+            ->method('getOwner')
+            ->willReturn('user');
 
-		$storage->expects($this->never())
-			->method('getQuota');
+        $storage->expects($this->never())
+            ->method('getQuota');
 
-		$storage->expects($this->once())
-			->method('free_space')
-			->willReturn(800);
+        $storage->expects($this->once())
+            ->method('free_space')
+            ->willReturn(800);
 
-		$this->info->expects($this->any())
-			->method('getPath')
-			->willReturn('/admin/files/foo');
+        $this->info->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/admin/files/foo');
 
-		$this->info->expects($this->once())
-			->method('getSize')
-			->willReturn(200);
+        $this->info->expects($this->once())
+            ->method('getSize')
+            ->willReturn(200);
 
-		$this->info->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mountPoint);
-
-		$this->view->expects($this->any())
-			->method('getRelativePath')
-			->willReturn('/foo');
-
-		$this->info->expects($this->once())
-			->method('getInternalPath')
-			->willReturn('/foo');
-
-		$mountPoint->method('getMountPoint')
-			->willReturn('/user/files/mymountpoint');
-
-		$dir = new Directory($this->view, $this->info);
-		$this->assertEquals([200, -3], $dir->getQuotaInfo()); //200 used, unlimited
-	}
-
-	public function testGetQuotaInfoSpecific(): void {
-		$this->createUser('user', 'password');
-		self::loginAsUser('user');
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$storage = $this->createMock(Quota::class);
-		$mountPoint->method('getStorage')
-			->willReturn($storage);
-
-		$storage->expects($this->any())
-			->method('instanceOfStorage')
-			->willReturnMap([
-				['\OCA\Files_Sharing\SharedStorage', false],
-				['\OC\Files\Storage\Wrapper\Quota', true],
-				[Storage::class, false],
-			]);
-
-		$storage->expects($this->once())
-			->method('getOwner')
-			->willReturn('user');
-
-		$storage->expects($this->once())
-			->method('getQuota')
-			->willReturn(1000);
-
-		$storage->expects($this->once())
-			->method('free_space')
-			->willReturn(800);
-
-		$this->info->expects($this->once())
-			->method('getSize')
-			->willReturn(200);
-
-		$this->info->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mountPoint);
-
-		$this->info->expects($this->once())
-			->method('getInternalPath')
-			->willReturn('/foo');
-
-		$mountPoint->method('getMountPoint')
-			->willReturn('/user/files/mymountpoint');
-
-		$this->view->expects($this->any())
-			->method('getRelativePath')
-			->willReturn('/foo');
-
-		$dir = new Directory($this->view, $this->info);
-		$this->assertEquals([200, 800], $dir->getQuotaInfo()); //200 used, 800 free
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('moveFailedProvider')]
-	public function testMoveFailed(string $source, string $destination, array $updatables, array $deletables): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-
-		$this->moveTest($source, $destination, $updatables, $deletables);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('moveSuccessProvider')]
-	public function testMoveSuccess(string $source, string $destination, array $updatables, array $deletables): void {
-		$this->moveTest($source, $destination, $updatables, $deletables);
-		$this->addToAssertionCount(1);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('moveFailedInvalidCharsProvider')]
-	public function testMoveFailedInvalidChars(string $source, string $destination, array $updatables, array $deletables): void {
-		$this->expectException(InvalidPath::class);
-
-		$this->moveTest($source, $destination, $updatables, $deletables);
-	}
-
-	public static function moveFailedInvalidCharsProvider(): array {
-		return [
-			['a/valid', "a/i\nvalid", ['a' => true, 'a/valid' => true, 'a/c*' => false], []],
-		];
-	}
-
-	public static function moveFailedProvider(): array {
-		return [
-			['a/b', 'a/c', ['a' => false, 'a/b' => false, 'a/c' => false], []],
-			['a/b', 'b/b', ['a' => false, 'a/b' => false, 'b' => false, 'b/b' => false], []],
-			['a/b', 'b/b', ['a' => false, 'a/b' => true, 'b' => false, 'b/b' => false], []],
-			['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => false, 'b/b' => false], []],
-			['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => false]],
-			['a/b', 'a/c', ['a' => false, 'a/b' => true, 'a/c' => false], []],
-		];
-	}
-
-	public static function moveSuccessProvider(): array {
-		return [
-			['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => true]],
-			// older files with special chars can still be renamed to valid names
-			['a/b*', 'b/b', ['a' => true, 'a/b*' => true, 'b' => true, 'b/b' => false], ['a/b*' => true]],
-		];
-	}
-
-	private function moveTest(string $source, string $destination, array $updatables, array $deletables): void {
-		$view = new TestViewDirectory($updatables, $deletables);
-
-		$sourceInfo = new FileInfo($source, null, null, [
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-		$targetInfo = new FileInfo(dirname($destination), null, null, [
-			'type' => FileInfo::TYPE_FOLDER,
-		], null);
-
-		$sourceNode = new Directory($view, $sourceInfo);
-		$targetNode = $this->getMockBuilder(Directory::class)
-			->onlyMethods(['childExists'])
-			->setConstructorArgs([$view, $targetInfo])
-			->getMock();
-		$targetNode->expects($this->any())->method('childExists')
-			->with(basename($destination))
-			->willReturn(false);
-		$this->assertTrue($targetNode->moveInto(basename($destination), $source, $sourceNode));
-	}
-
-
-	public function testFailingMove(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('Could not copy directory b, target exists');
-
-		$source = 'a/b';
-		$destination = 'c/b';
-		$updatables = ['a' => true, 'a/b' => true, 'b' => true, 'c/b' => false];
-		$deletables = ['a/b' => true];
-
-		$view = new TestViewDirectory($updatables, $deletables);
-
-		$sourceInfo = new FileInfo($source, null, null, ['type' => FileInfo::TYPE_FOLDER], null);
-		$targetInfo = new FileInfo(dirname($destination), null, null, ['type' => FileInfo::TYPE_FOLDER], null);
-
-		$sourceNode = new Directory($view, $sourceInfo);
-		$targetNode = $this->getMockBuilder(Directory::class)
-			->onlyMethods(['childExists'])
-			->setConstructorArgs([$view, $targetInfo])
-			->getMock();
-		$targetNode->expects($this->once())->method('childExists')
-			->with(basename($destination))
-			->willReturn(true);
-
-		$targetNode->moveInto(basename($destination), $source, $sourceNode);
-	}
+        $this->info->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mountPoint);
+
+        $this->view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturn('/foo');
+
+        $this->info->expects($this->once())
+            ->method('getInternalPath')
+            ->willReturn('/foo');
+
+        $mountPoint->method('getMountPoint')
+            ->willReturn('/user/files/mymountpoint');
+
+        $dir = new Directory($this->view, $this->info);
+        $this->assertEquals([200, -3], $dir->getQuotaInfo()); //200 used, unlimited
+    }
+
+    public function testGetQuotaInfoSpecific(): void {
+        $this->createUser('user', 'password');
+        self::loginAsUser('user');
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $storage = $this->createMock(Quota::class);
+        $mountPoint->method('getStorage')
+            ->willReturn($storage);
+
+        $storage->expects($this->any())
+            ->method('instanceOfStorage')
+            ->willReturnMap([
+                ['\OCA\Files_Sharing\SharedStorage', false],
+                ['\OC\Files\Storage\Wrapper\Quota', true],
+                [Storage::class, false],
+            ]);
+
+        $storage->expects($this->once())
+            ->method('getOwner')
+            ->willReturn('user');
+
+        $storage->expects($this->once())
+            ->method('getQuota')
+            ->willReturn(1000);
+
+        $storage->expects($this->once())
+            ->method('free_space')
+            ->willReturn(800);
+
+        $this->info->expects($this->once())
+            ->method('getSize')
+            ->willReturn(200);
+
+        $this->info->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mountPoint);
+
+        $this->info->expects($this->once())
+            ->method('getInternalPath')
+            ->willReturn('/foo');
+
+        $mountPoint->method('getMountPoint')
+            ->willReturn('/user/files/mymountpoint');
+
+        $this->view->expects($this->any())
+            ->method('getRelativePath')
+            ->willReturn('/foo');
+
+        $dir = new Directory($this->view, $this->info);
+        $this->assertEquals([200, 800], $dir->getQuotaInfo()); //200 used, 800 free
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('moveFailedProvider')]
+    public function testMoveFailed(string $source, string $destination, array $updatables, array $deletables): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+
+        $this->moveTest($source, $destination, $updatables, $deletables);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('moveSuccessProvider')]
+    public function testMoveSuccess(string $source, string $destination, array $updatables, array $deletables): void {
+        $this->moveTest($source, $destination, $updatables, $deletables);
+        $this->addToAssertionCount(1);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('moveFailedInvalidCharsProvider')]
+    public function testMoveFailedInvalidChars(string $source, string $destination, array $updatables, array $deletables): void {
+        $this->expectException(InvalidPath::class);
+
+        $this->moveTest($source, $destination, $updatables, $deletables);
+    }
+
+    public static function moveFailedInvalidCharsProvider(): array {
+        return [
+            ['a/valid', "a/i\nvalid", ['a' => true, 'a/valid' => true, 'a/c*' => false], []],
+        ];
+    }
+
+    public static function moveFailedProvider(): array {
+        return [
+            ['a/b', 'a/c', ['a' => false, 'a/b' => false, 'a/c' => false], []],
+            ['a/b', 'b/b', ['a' => false, 'a/b' => false, 'b' => false, 'b/b' => false], []],
+            ['a/b', 'b/b', ['a' => false, 'a/b' => true, 'b' => false, 'b/b' => false], []],
+            ['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => false, 'b/b' => false], []],
+            ['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => false]],
+            ['a/b', 'a/c', ['a' => false, 'a/b' => true, 'a/c' => false], []],
+        ];
+    }
+
+    public static function moveSuccessProvider(): array {
+        return [
+            ['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => true]],
+            // older files with special chars can still be renamed to valid names
+            ['a/b*', 'b/b', ['a' => true, 'a/b*' => true, 'b' => true, 'b/b' => false], ['a/b*' => true]],
+        ];
+    }
+
+    private function moveTest(string $source, string $destination, array $updatables, array $deletables): void {
+        $view = new TestViewDirectory($updatables, $deletables);
+
+        $sourceInfo = new FileInfo($source, null, null, [
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+        $targetInfo = new FileInfo(dirname($destination), null, null, [
+            'type' => FileInfo::TYPE_FOLDER,
+        ], null);
+
+        $sourceNode = new Directory($view, $sourceInfo);
+        $targetNode = $this->getMockBuilder(Directory::class)
+            ->onlyMethods(['childExists'])
+            ->setConstructorArgs([$view, $targetInfo])
+            ->getMock();
+        $targetNode->expects($this->any())->method('childExists')
+            ->with(basename($destination))
+            ->willReturn(false);
+        $this->assertTrue($targetNode->moveInto(basename($destination), $source, $sourceNode));
+    }
+
+
+    public function testFailingMove(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('Could not copy directory b, target exists');
+
+        $source = 'a/b';
+        $destination = 'c/b';
+        $updatables = ['a' => true, 'a/b' => true, 'b' => true, 'c/b' => false];
+        $deletables = ['a/b' => true];
+
+        $view = new TestViewDirectory($updatables, $deletables);
+
+        $sourceInfo = new FileInfo($source, null, null, ['type' => FileInfo::TYPE_FOLDER], null);
+        $targetInfo = new FileInfo(dirname($destination), null, null, ['type' => FileInfo::TYPE_FOLDER], null);
+
+        $sourceNode = new Directory($view, $sourceInfo);
+        $targetNode = $this->getMockBuilder(Directory::class)
+            ->onlyMethods(['childExists'])
+            ->setConstructorArgs([$view, $targetInfo])
+            ->getMock();
+        $targetNode->expects($this->once())->method('childExists')
+            ->with(basename($destination))
+            ->willReturn(true);
+
+        $targetNode->moveInto(basename($destination), $source, $sourceNode);
+    }
 }

apps/dav/tests/unit/Connector/Sabre/FilesPluginTest.php

Indentation +677 added lines, -677 removed lines

@@ -40,681 +40,681 @@
  */
 class FilesPluginTest extends TestCase {
 
-	private Tree&MockObject $tree;
-	private Server&MockObject $server;
-	private IConfig&MockObject $config;
-	private IRequest&MockObject $request;
-	private IPreview&MockObject $previewManager;
-	private IUserSession&MockObject $userSession;
-	private IFilenameValidator&MockObject $filenameValidator;
-	private IAccountManager&MockObject $accountManager;
-	private FilesPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->server = $this->createMock(Server::class);
-		$this->tree = $this->createMock(Tree::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->config->expects($this->any())->method('getSystemValue')
-			->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
-			->willReturn('my_fingerprint');
-		$this->request = $this->createMock(IRequest::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->filenameValidator = $this->createMock(IFilenameValidator::class);
-		$this->accountManager = $this->createMock(IAccountManager::class);
-
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$this->request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-		);
-
-		$response = $this->createMock(ResponseInterface::class);
-		$this->server->httpResponse = $response;
-		$this->server->xml = new Service();
-
-		$this->plugin->initialize($this->server);
-	}
-
-	private function createTestNode(string $class, string $path = '/dummypath'): MockObject {
-		$node = $this->createMock($class);
-
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with($path)
-			->willReturn($node);
-
-		$node->expects($this->any())
-			->method('getFileId')
-			->willReturn('00000123instanceid');
-		$node->expects($this->any())
-			->method('getInternalFileId')
-			->willReturn('123');
-		$node->expects($this->any())
-			->method('getEtag')
-			->willReturn('"abc"');
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-		$fileInfo->expects($this->any())
-			->method('getCreationTime')
-			->willReturn(123456789);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		return $node;
-	}
-
-	public function testGetPropertiesForFile(): void {
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::OWNER_ID_PROPERTYNAME,
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-				FilesPlugin::CREATIONDATE_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->createMock(User::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$owner = $this->createMock(Account::class);
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->willReturn(['url' => 'http://example.com/']);
-		$node->expects($this->exactly(2))
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->createMock(AccountProperty::class);
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PUBLISHED);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
-		$this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
-		$this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([], $propFind->get404Properties());
-	}
-
-	public function testGetDisplayNamePropertyWhenNotPublished(): void {
-		$node = $this->createTestNode(File::class);
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn(null);
-
-		$user = $this->createMock(User::class);
-
-		$user->expects($this->never())
-			->method('getDisplayName');
-
-		$owner = $this->createMock(Account::class);
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->createMock(AccountProperty::class);
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PRIVATE);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
-
-	public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->createMock(User::class);
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$loggedInUser = $this->createMock(User::class);
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($loggedInUser);
-
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$this->accountManager->expects($this->never())
-			->method('getAccount');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesStorageNotAvailable(): void {
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->willThrowException(new StorageNotAvailableException());
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-	}
-
-	public function testGetPublicPermissions(): void {
-		/** @var IRequest&MockObject */
-		$request = $this->createMock(IRequest::class);
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-			true,
-		);
-		$this->plugin->initialize($this->server);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-			],
-			0
-		);
-
-		/** @var File&MockObject $node */
-		$node = $this->createTestNode(File::class);
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesForDirectory(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createTestNode(Directory::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getSize')
-			->willReturn(1025);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
-	}
-
-	public function testGetPropertiesForRootDirectory(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createMock(Directory::class);
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesWhenNoPermission(): void {
-		// No read permissions can be caused by files access control.
-		// But we still want to load the directory list, so this is okay for us.
-		// $this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		/** @var Directory&MockObject $node */
-		$node = $this->createMock(Directory::class);
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(false);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/test',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->addToAssertionCount(1);
-	}
-
-	public function testUpdateProps(): void {
-		$node = $this->createTestNode(File::class);
-
-		$testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
-		$testCreationDate = '2007-08-31T16:47+00:00';
-
-		$node->expects($this->once())
-			->method('touch')
-			->with($testDate);
-
-		$node->expects($this->once())
-			->method('setEtag')
-			->with('newetag')
-			->willReturn(true);
-
-		$node->expects($this->once())
-			->method('setCreationTime')
-			->with('1188578820');
-
-		// properties to set
-		$propPatch = new PropPatch([
-			FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
-			FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
-			FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
-		]);
-
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
-	}
-
-	public function testUpdatePropsForbidden(): void {
-		$propPatch = new PropPatch([
-			FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
-			FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
-			FilesPlugin::FILEID_PROPERTYNAME => 12345,
-			FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
-			FilesPlugin::SIZE_PROPERTYNAME => 123,
-			FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
-	}
-
-	/**
-	 * Test case from https://github.com/owncloud/core/issues/5251
-	 *
-	 * |-FolderA
-	 *  |-text.txt
-	 * |-test.txt
-	 *
-	 * FolderA is an incoming shared folder and there are no delete permissions.
-	 * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
-	 *
-	 */
-	public function testMoveSrcNotDeletable(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(false);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcDeletable(): void {
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects(self::any())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public function testCopySrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testCopyDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public static function downloadHeadersProvider(): array {
-		return [
-			[
-				false,
-				'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
-			],
-			[
-				true,
-				'attachment; filename="somefile.xml"'
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('downloadHeadersProvider')]
-	public function testDownloadHeaders(bool $isClumsyAgent, string $contentDispositionHeader): void {
-		$request = $this->createMock(RequestInterface::class);
-		$response = $this->createMock(ResponseInterface::class);
-
-		$request
-			->expects($this->once())
-			->method('getPath')
-			->willReturn('test/somefile.xml');
-
-		$node = $this->createMock(File::class);
-		$node
-			->expects($this->once())
-			->method('getName')
-			->willReturn('somefile.xml');
-
-		$this->tree
-			->expects($this->once())
-			->method('getNodeForPath')
-			->with('test/somefile.xml')
-			->willReturn($node);
-
-		$this->request
-			->expects($this->once())
-			->method('isUserAgent')
-			->willReturn($isClumsyAgent);
-
-		$calls = [
-			['Content-Disposition', $contentDispositionHeader],
-			['X-Accel-Buffering', 'no'],
-		];
-		$response
-			->expects($this->exactly(count($calls)))
-			->method('addHeader')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertSame($expected, func_get_args());
-			});
-
-		$this->plugin->httpGet($request, $response);
-	}
-
-	public function testHasPreview(): void {
-		/** @var Directory&MockObject $node */
-		$node = $this->createTestNode(Directory::class);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::HAS_PREVIEW_PROPERTYNAME
-			],
-			0
-		);
-
-		$this->previewManager->expects($this->once())
-			->method('isAvailable')
-			->willReturn(false);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
-	}
+    private Tree&MockObject $tree;
+    private Server&MockObject $server;
+    private IConfig&MockObject $config;
+    private IRequest&MockObject $request;
+    private IPreview&MockObject $previewManager;
+    private IUserSession&MockObject $userSession;
+    private IFilenameValidator&MockObject $filenameValidator;
+    private IAccountManager&MockObject $accountManager;
+    private FilesPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->server = $this->createMock(Server::class);
+        $this->tree = $this->createMock(Tree::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->config->expects($this->any())->method('getSystemValue')
+            ->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
+            ->willReturn('my_fingerprint');
+        $this->request = $this->createMock(IRequest::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->filenameValidator = $this->createMock(IFilenameValidator::class);
+        $this->accountManager = $this->createMock(IAccountManager::class);
+
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $this->request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+        );
+
+        $response = $this->createMock(ResponseInterface::class);
+        $this->server->httpResponse = $response;
+        $this->server->xml = new Service();
+
+        $this->plugin->initialize($this->server);
+    }
+
+    private function createTestNode(string $class, string $path = '/dummypath'): MockObject {
+        $node = $this->createMock($class);
+
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with($path)
+            ->willReturn($node);
+
+        $node->expects($this->any())
+            ->method('getFileId')
+            ->willReturn('00000123instanceid');
+        $node->expects($this->any())
+            ->method('getInternalFileId')
+            ->willReturn('123');
+        $node->expects($this->any())
+            ->method('getEtag')
+            ->willReturn('"abc"');
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+        $fileInfo->expects($this->any())
+            ->method('getCreationTime')
+            ->willReturn(123456789);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        return $node;
+    }
+
+    public function testGetPropertiesForFile(): void {
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::OWNER_ID_PROPERTYNAME,
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+                FilesPlugin::CREATIONDATE_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->createMock(User::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $owner = $this->createMock(Account::class);
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->willReturn(['url' => 'http://example.com/']);
+        $node->expects($this->exactly(2))
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->createMock(AccountProperty::class);
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PUBLISHED);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
+        $this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
+        $this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([], $propFind->get404Properties());
+    }
+
+    public function testGetDisplayNamePropertyWhenNotPublished(): void {
+        $node = $this->createTestNode(File::class);
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn(null);
+
+        $user = $this->createMock(User::class);
+
+        $user->expects($this->never())
+            ->method('getDisplayName');
+
+        $owner = $this->createMock(Account::class);
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->createMock(AccountProperty::class);
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PRIVATE);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
+
+    public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->createMock(User::class);
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $loggedInUser = $this->createMock(User::class);
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($loggedInUser);
+
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $this->accountManager->expects($this->never())
+            ->method('getAccount');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesStorageNotAvailable(): void {
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->willThrowException(new StorageNotAvailableException());
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+    }
+
+    public function testGetPublicPermissions(): void {
+        /** @var IRequest&MockObject */
+        $request = $this->createMock(IRequest::class);
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+            true,
+        );
+        $this->plugin->initialize($this->server);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+            ],
+            0
+        );
+
+        /** @var File&MockObject $node */
+        $node = $this->createTestNode(File::class);
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesForDirectory(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createTestNode(Directory::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1025);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
+    }
+
+    public function testGetPropertiesForRootDirectory(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createMock(Directory::class);
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesWhenNoPermission(): void {
+        // No read permissions can be caused by files access control.
+        // But we still want to load the directory list, so this is okay for us.
+        // $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        /** @var Directory&MockObject $node */
+        $node = $this->createMock(Directory::class);
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(false);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/test',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->addToAssertionCount(1);
+    }
+
+    public function testUpdateProps(): void {
+        $node = $this->createTestNode(File::class);
+
+        $testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
+        $testCreationDate = '2007-08-31T16:47+00:00';
+
+        $node->expects($this->once())
+            ->method('touch')
+            ->with($testDate);
+
+        $node->expects($this->once())
+            ->method('setEtag')
+            ->with('newetag')
+            ->willReturn(true);
+
+        $node->expects($this->once())
+            ->method('setCreationTime')
+            ->with('1188578820');
+
+        // properties to set
+        $propPatch = new PropPatch([
+            FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
+            FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
+            FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
+        ]);
+
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
+    }
+
+    public function testUpdatePropsForbidden(): void {
+        $propPatch = new PropPatch([
+            FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
+            FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
+            FilesPlugin::FILEID_PROPERTYNAME => 12345,
+            FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
+            FilesPlugin::SIZE_PROPERTYNAME => 123,
+            FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
+    }
+
+    /**
+     * Test case from https://github.com/owncloud/core/issues/5251
+     *
+     * |-FolderA
+     *  |-text.txt
+     * |-test.txt
+     *
+     * FolderA is an incoming shared folder and there are no delete permissions.
+     * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
+     *
+     */
+    public function testMoveSrcNotDeletable(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(false);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcDeletable(): void {
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects(self::any())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public function testCopySrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testCopyDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public static function downloadHeadersProvider(): array {
+        return [
+            [
+                false,
+                'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
+            ],
+            [
+                true,
+                'attachment; filename="somefile.xml"'
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('downloadHeadersProvider')]
+    public function testDownloadHeaders(bool $isClumsyAgent, string $contentDispositionHeader): void {
+        $request = $this->createMock(RequestInterface::class);
+        $response = $this->createMock(ResponseInterface::class);
+
+        $request
+            ->expects($this->once())
+            ->method('getPath')
+            ->willReturn('test/somefile.xml');
+
+        $node = $this->createMock(File::class);
+        $node
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('somefile.xml');
+
+        $this->tree
+            ->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('test/somefile.xml')
+            ->willReturn($node);
+
+        $this->request
+            ->expects($this->once())
+            ->method('isUserAgent')
+            ->willReturn($isClumsyAgent);
+
+        $calls = [
+            ['Content-Disposition', $contentDispositionHeader],
+            ['X-Accel-Buffering', 'no'],
+        ];
+        $response
+            ->expects($this->exactly(count($calls)))
+            ->method('addHeader')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertSame($expected, func_get_args());
+            });
+
+        $this->plugin->httpGet($request, $response);
+    }
+
+    public function testHasPreview(): void {
+        /** @var Directory&MockObject $node */
+        $node = $this->createTestNode(Directory::class);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::HAS_PREVIEW_PROPERTYNAME
+            ],
+            0
+        );
+
+        $this->previewManager->expects($this->once())
+            ->method('isAvailable')
+            ->willReturn(false);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -686,7 +686,7 @@
 		$response
 			->expects($this->exactly(count($calls)))
 			->method('addHeader')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertSame($expected, func_get_args());
 			});

apps/dav/tests/unit/CardDAV/AddressBookImplTest.php

Indentation +514 added lines, -514 removed lines

@@ -19,518 +19,518 @@
 use Test\TestCase;
 
 class AddressBookImplTest extends TestCase {
-	private array $addressBookInfo;
-	private AddressBook&MockObject $addressBook;
-	private IURLGenerator&MockObject $urlGenerator;
-	private CardDavBackend&MockObject $backend;
-	private PropertyMapper&MockObject $propertyMapper;
-	private VCard&MockObject $vCard;
-	private AddressBookImpl $addressBookImpl;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->addressBookInfo = [
-			'id' => 42,
-			'uri' => 'system',
-			'principaluri' => 'principals/system/system',
-			'{DAV:}displayname' => 'display name',
-		];
-		$this->addressBook = $this->createMock(AddressBook::class);
-		$this->backend = $this->createMock(CardDavBackend::class);
-		$this->vCard = $this->createMock(VCard::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->propertyMapper = $this->createMock(PropertyMapper::class);
-
-		$this->addressBookImpl = new AddressBookImpl(
-			$this->addressBook,
-			$this->addressBookInfo,
-			$this->backend,
-			$this->urlGenerator,
-			$this->propertyMapper,
-			null
-		);
-	}
-
-	public function testGetKey(): void {
-		$this->assertSame($this->addressBookInfo['id'],
-			$this->addressBookImpl->getKey());
-	}
-
-	public function testGetDisplayName(): void {
-		$this->assertSame($this->addressBookInfo['{DAV:}displayname'],
-			$this->addressBookImpl->getDisplayName());
-	}
-
-	public function testSearch(): void {
-		/** @var MockObject&AddressBookImpl $addressBookImpl */
-		$addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
-			->setConstructorArgs(
-				[
-					$this->addressBook,
-					$this->addressBookInfo,
-					$this->backend,
-					$this->urlGenerator,
-					$this->propertyMapper,
-					null
-				]
-			)
-			->onlyMethods(['vCard2Array', 'readCard'])
-			->getMock();
-
-		$pattern = 'pattern';
-		$searchProperties = 'properties';
-
-		$this->backend->expects($this->once())->method('search')
-			->with($this->addressBookInfo['id'], $pattern, $searchProperties)
-			->willReturn(
-				[
-					['uri' => 'foo.vcf', 'carddata' => 'cardData1'],
-					['uri' => 'bar.vcf', 'carddata' => 'cardData2']
-				]
-			);
-
-		$addressBookImpl->expects($this->exactly(2))->method('readCard')
-			->willReturn($this->vCard);
-		$addressBookImpl->expects($this->exactly(2))->method('vCard2Array')
-			->willReturnMap([
-				['foo.vcf', $this->vCard, 'vCard'],
-				['bar.vcf', $this->vCard, 'vCard'],
-			]);
-
-		$result = $addressBookImpl->search($pattern, $searchProperties, []);
-		$this->assertTrue((is_array($result)));
-		$this->assertSame(2, count($result));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreate')]
-	public function testCreate(array $properties): void {
-		$uid = 'uid';
-
-		/** @var MockObject&AddressBookImpl $addressBookImpl */
-		$addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
-			->setConstructorArgs(
-				[
-					$this->addressBook,
-					$this->addressBookInfo,
-					$this->backend,
-					$this->urlGenerator,
-					$this->propertyMapper,
-					null
-				]
-			)
-			->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard'])
-			->getMock();
-
-		$expectedProperties = 0;
-		foreach ($properties as $data) {
-			if (is_string($data)) {
-				$expectedProperties++;
-			} else {
-				$expectedProperties += count($data);
-			}
-		}
-
-		$addressBookImpl->expects($this->once())->method('createUid')
-			->willReturn($uid);
-		$addressBookImpl->expects($this->once())->method('createEmptyVCard')
-			->with($uid)->willReturn($this->vCard);
-		$this->vCard->expects($this->exactly($expectedProperties))
-			->method('createProperty');
-		$this->backend->expects($this->once())->method('createCard');
-		$this->backend->expects($this->never())->method('updateCard');
-		$this->backend->expects($this->never())->method('getCard');
-		$addressBookImpl->expects($this->once())->method('vCard2Array')
-			->with('uid.vcf', $this->vCard)->willReturn(true);
-
-		$this->assertTrue($addressBookImpl->createOrUpdate($properties));
-	}
-
-	public static function dataTestCreate(): array {
-		return [
-			[[]],
-			[['FN' => 'John Doe']],
-			[['FN' => 'John Doe', 'EMAIL' => ['john@doe.cloud', 'john.doe@example.org']]],
-		];
-	}
-
-	public function testUpdate(): void {
-		$uid = 'uid';
-		$uri = 'bla.vcf';
-		$properties = ['URI' => $uri, 'UID' => $uid, 'FN' => 'John Doe'];
-
-		/** @var MockObject&AddressBookImpl $addressBookImpl */
-		$addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
-			->setConstructorArgs(
-				[
-					$this->addressBook,
-					$this->addressBookInfo,
-					$this->backend,
-					$this->urlGenerator,
-					$this->propertyMapper,
-					null
-				]
-			)
-			->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard', 'readCard'])
-			->getMock();
-
-		$addressBookImpl->expects($this->never())->method('createUid');
-		$addressBookImpl->expects($this->never())->method('createEmptyVCard');
-		$this->backend->expects($this->once())->method('getCard')
-			->with($this->addressBookInfo['id'], $uri)
-			->willReturn(['carddata' => 'data']);
-		$addressBookImpl->expects($this->once())->method('readCard')
-			->with('data')->willReturn($this->vCard);
-		$this->vCard->expects($this->exactly(count($properties) - 1))
-			->method('createProperty');
-		$this->backend->expects($this->never())->method('createCard');
-		$this->backend->expects($this->once())->method('updateCard');
-		$addressBookImpl->expects($this->once())->method('vCard2Array')
-			->with($uri, $this->vCard)->willReturn(true);
-
-		$this->assertTrue($addressBookImpl->createOrUpdate($properties));
-	}
-
-	public function testUpdateWithTypes(): void {
-		$uid = 'uid';
-		$uri = 'bla.vcf';
-		$properties = ['URI' => $uri, 'UID' => $uid, 'FN' => 'John Doe', 'ADR' => [['type' => 'HOME', 'value' => ';;street;city;;;country']]];
-		$vCard = new vCard;
-		$textProperty = $vCard->createProperty('KEY', 'value');
-
-		/** @var MockObject&AddressBookImpl $addressBookImpl */
-		$addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
-			->setConstructorArgs(
-				[
-					$this->addressBook,
-					$this->addressBookInfo,
-					$this->backend,
-					$this->urlGenerator,
-					$this->propertyMapper,
-					null
-				]
-			)
-			->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard', 'readCard'])
-			->getMock();
-
-		$this->backend->expects($this->once())->method('getCard')
-			->with($this->addressBookInfo['id'], $uri)
-			->willReturn(['carddata' => 'data']);
-		$addressBookImpl->expects($this->once())->method('readCard')
-			->with('data')->willReturn($this->vCard);
-		$this->vCard->method('createProperty')->willReturn($textProperty);
-		$this->vCard->expects($this->exactly(count($properties) - 1))
-			->method('createProperty');
-		$this->vCard->expects($this->once())->method('remove')
-			->with('ADR');
-		$this->vCard->expects($this->once())->method('add');
-
-		$addressBookImpl->createOrUpdate($properties);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestGetPermissions')]
-	public function testGetPermissions(array $permissions, int $expected): void {
-		$this->addressBook->expects($this->once())->method('getACL')
-			->willReturn($permissions);
-
-		$this->assertSame($expected,
-			$this->addressBookImpl->getPermissions()
-		);
-	}
-
-	public static function dataTestGetPermissions(): array {
-		return [
-			[[], 0],
-			[[['privilege' => '{DAV:}read']], 1],
-			[[['privilege' => '{DAV:}write']], 6],
-			[[['privilege' => '{DAV:}all']], 31],
-			[[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write']], 7],
-			[[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}all']], 31],
-			[[['privilege' => '{DAV:}all'],['privilege' => '{DAV:}write']], 31],
-			[[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write'],['privilege' => '{DAV:}all']], 31],
-			[[['privilege' => '{DAV:}all'],['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write']], 31],
-		];
-	}
-
-	public function testDelete(): void {
-		$cardId = 1;
-		$cardUri = 'cardUri';
-		$this->backend->expects($this->once())->method('getCardUri')
-			->with($cardId)->willReturn($cardUri);
-		$this->backend->expects($this->once())->method('deleteCard')
-			->with($this->addressBookInfo['id'], $cardUri)
-			->willReturn(true);
-
-		$this->assertTrue($this->addressBookImpl->delete($cardId));
-	}
-
-	public function testReadCard(): void {
-		$vCard = new VCard();
-		$vCard->add(new Text($vCard, 'UID', 'uid'));
-		$vCardSerialized = $vCard->serialize();
-
-		$result = $this->invokePrivate($this->addressBookImpl, 'readCard', [$vCardSerialized]);
-		$resultSerialized = $result->serialize();
-
-		$this->assertSame($vCardSerialized, $resultSerialized);
-	}
-
-	public function testCreateUid(): void {
-		/** @var MockObject&AddressBookImpl $addressBookImpl */
-		$addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
-			->setConstructorArgs(
-				[
-					$this->addressBook,
-					$this->addressBookInfo,
-					$this->backend,
-					$this->urlGenerator,
-					$this->propertyMapper,
-					null
-				]
-			)
-			->onlyMethods(['getUid'])
-			->getMock();
-
-		$addressBookImpl->expects($this->exactly(2))
-			->method('getUid')
-			->willReturnOnConsecutiveCalls(
-				'uid0',
-				'uid1',
-			);
-
-		// simulate that 'uid0' already exists, so the second uid will be returned
-		$this->backend->expects($this->exactly(2))->method('getContact')
-			->willReturnCallback(
-				function ($id, $uid) {
-					return ($uid === 'uid0.vcf');
-				}
-			);
-
-		$this->assertSame('uid1',
-			$this->invokePrivate($addressBookImpl, 'createUid', [])
-		);
-	}
-
-	public function testCreateEmptyVCard(): void {
-		$uid = 'uid';
-		$expectedVCard = new VCard();
-		$expectedVCard->UID = $uid;
-		$expectedVCardSerialized = $expectedVCard->serialize();
-
-		$result = $this->invokePrivate($this->addressBookImpl, 'createEmptyVCard', [$uid]);
-		$resultSerialized = $result->serialize();
-
-		$this->assertSame($expectedVCardSerialized, $resultSerialized);
-	}
-
-	public function testVCard2Array(): void {
-		$vCard = new VCard();
-
-		$vCard->add($vCard->createProperty('FN', 'Full Name'));
-
-		// Multi-value properties
-		$vCard->add($vCard->createProperty('CLOUD', 'cloud-user1@localhost'));
-		$vCard->add($vCard->createProperty('CLOUD', 'cloud-user2@example.tld'));
-		$vCard->add($vCard->createProperty('EMAIL', 'email-user1@localhost'));
-		$vCard->add($vCard->createProperty('EMAIL', 'email-user2@example.tld'));
-		$vCard->add($vCard->createProperty('IMPP', 'impp-user1@localhost'));
-		$vCard->add($vCard->createProperty('IMPP', 'impp-user2@example.tld'));
-		$vCard->add($vCard->createProperty('TEL', '+49 123456789'));
-		$vCard->add($vCard->createProperty('TEL', '+1 555 123456789'));
-		$vCard->add($vCard->createProperty('URL', 'https://localhost'));
-		$vCard->add($vCard->createProperty('URL', 'https://example.tld'));
-
-		// Type depending properties
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example');
-		$property->add('TYPE', 'twitter');
-		$vCard->add($property);
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example-2');
-		$property->add('TYPE', 'twitter');
-		$vCard->add($property);
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'fb-example');
-		$property->add('TYPE', 'facebook');
-		$vCard->add($property);
-
-		$array = $this->invokePrivate($this->addressBookImpl, 'vCard2Array', ['uri', $vCard]);
-		unset($array['PRODID']);
-		unset($array['UID']);
-
-		$this->assertEquals([
-			'URI' => 'uri',
-			'VERSION' => '4.0',
-			'FN' => 'Full Name',
-			'CLOUD' => [
-				'cloud-user1@localhost',
-				'cloud-user2@example.tld',
-			],
-			'EMAIL' => [
-				'email-user1@localhost',
-				'email-user2@example.tld',
-			],
-			'IMPP' => [
-				'impp-user1@localhost',
-				'impp-user2@example.tld',
-			],
-			'TEL' => [
-				'+49 123456789',
-				'+1 555 123456789',
-			],
-			'URL' => [
-				'https://localhost',
-				'https://example.tld',
-			],
-
-			'X-SOCIALPROFILE' => [
-				'tw-example',
-				'tw-example-2',
-				'fb-example',
-			],
-
-			'isLocalSystemBook' => true,
-		], $array);
-	}
-
-	public function testVCard2ArrayWithTypes(): void {
-		$vCard = new VCard();
-
-		$vCard->add($vCard->createProperty('FN', 'Full Name'));
-
-		// Multi-value properties
-		$vCard->add($vCard->createProperty('CLOUD', 'cloud-user1@localhost'));
-		$vCard->add($vCard->createProperty('CLOUD', 'cloud-user2@example.tld'));
-
-		$property = $vCard->createProperty('EMAIL', 'email-user1@localhost');
-		$property->add('TYPE', 'HOME');
-		$vCard->add($property);
-		$property = $vCard->createProperty('EMAIL', 'email-user2@example.tld');
-		$property->add('TYPE', 'WORK');
-		$vCard->add($property);
-
-		$vCard->add($vCard->createProperty('IMPP', 'impp-user1@localhost'));
-		$vCard->add($vCard->createProperty('IMPP', 'impp-user2@example.tld'));
-
-		$property = $vCard->createProperty('TEL', '+49 123456789');
-		$property->add('TYPE', 'HOME,VOICE');
-		$vCard->add($property);
-		$property = $vCard->createProperty('TEL', '+1 555 123456789');
-		$property->add('TYPE', 'WORK');
-		$vCard->add($property);
-
-		$vCard->add($vCard->createProperty('URL', 'https://localhost'));
-		$vCard->add($vCard->createProperty('URL', 'https://example.tld'));
-
-		// Type depending properties
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example');
-		$property->add('TYPE', 'twitter');
-		$vCard->add($property);
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example-2');
-		$property->add('TYPE', 'twitter');
-		$vCard->add($property);
-		$property = $vCard->createProperty('X-SOCIALPROFILE', 'fb-example');
-		$property->add('TYPE', 'facebook');
-		$vCard->add($property);
-
-		$array = $this->invokePrivate($this->addressBookImpl, 'vCard2Array', ['uri', $vCard, true]);
-		unset($array['PRODID']);
-		unset($array['UID']);
-
-		$this->assertEquals([
-			'URI' => 'uri',
-			'VERSION' => '4.0',
-			'FN' => 'Full Name',
-			'CLOUD' => [
-				['type' => '', 'value' => 'cloud-user1@localhost'],
-				['type' => '', 'value' => 'cloud-user2@example.tld'],
-			],
-			'EMAIL' => [
-				['type' => 'HOME', 'value' => 'email-user1@localhost'],
-				['type' => 'WORK', 'value' => 'email-user2@example.tld'],
-			],
-			'IMPP' => [
-				['type' => '', 'value' => 'impp-user1@localhost'],
-				['type' => '', 'value' => 'impp-user2@example.tld'],
-			],
-			'TEL' => [
-				['type' => 'HOME,VOICE', 'value' => '+49 123456789'],
-				['type' => 'WORK', 'value' => '+1 555 123456789'],
-			],
-			'URL' => [
-				['type' => '', 'value' => 'https://localhost'],
-				['type' => '', 'value' => 'https://example.tld'],
-			],
-
-			'X-SOCIALPROFILE' => [
-				['type' => 'twitter', 'value' => 'tw-example'],
-				['type' => 'twitter', 'value' => 'tw-example-2'],
-				['type' => 'facebook', 'value' => 'fb-example'],
-			],
-
-			'isLocalSystemBook' => true,
-		], $array);
-	}
-
-	public function testIsSystemAddressBook(): void {
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'principals/system/system',
-			'principaluri' => 'principals/system/system',
-			'{DAV:}displayname' => 'display name',
-			'id' => 666,
-			'uri' => 'system',
-		];
-
-		$addressBookImpl = new AddressBookImpl(
-			$this->addressBook,
-			$addressBookInfo,
-			$this->backend,
-			$this->urlGenerator,
-			$this->propertyMapper,
-			null
-		);
-
-		$this->assertTrue($addressBookImpl->isSystemAddressBook());
-	}
-
-	public function testIsShared(): void {
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user2',
-			'id' => 666,
-			'uri' => 'default',
-		];
-
-		$addressBookImpl = new AddressBookImpl(
-			$this->addressBook,
-			$addressBookInfo,
-			$this->backend,
-			$this->urlGenerator,
-			$this->propertyMapper,
-			'user2'
-		);
-
-		$this->assertFalse($addressBookImpl->isSystemAddressBook());
-		$this->assertTrue($addressBookImpl->isShared());
-	}
-
-	public function testIsNotShared(): void {
-		$addressBookInfo = [
-			'{http://owncloud.org/ns}owner-principal' => 'user1',
-			'{DAV:}displayname' => 'Test address book',
-			'principaluri' => 'user1',
-			'id' => 666,
-			'uri' => 'default',
-		];
-
-		$addressBookImpl = new AddressBookImpl(
-			$this->addressBook,
-			$addressBookInfo,
-			$this->backend,
-			$this->urlGenerator,
-			$this->propertyMapper,
-			'user2'
-		);
-
-		$this->assertFalse($addressBookImpl->isSystemAddressBook());
-		$this->assertFalse($addressBookImpl->isShared());
-	}
+    private array $addressBookInfo;
+    private AddressBook&MockObject $addressBook;
+    private IURLGenerator&MockObject $urlGenerator;
+    private CardDavBackend&MockObject $backend;
+    private PropertyMapper&MockObject $propertyMapper;
+    private VCard&MockObject $vCard;
+    private AddressBookImpl $addressBookImpl;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->addressBookInfo = [
+            'id' => 42,
+            'uri' => 'system',
+            'principaluri' => 'principals/system/system',
+            '{DAV:}displayname' => 'display name',
+        ];
+        $this->addressBook = $this->createMock(AddressBook::class);
+        $this->backend = $this->createMock(CardDavBackend::class);
+        $this->vCard = $this->createMock(VCard::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->propertyMapper = $this->createMock(PropertyMapper::class);
+
+        $this->addressBookImpl = new AddressBookImpl(
+            $this->addressBook,
+            $this->addressBookInfo,
+            $this->backend,
+            $this->urlGenerator,
+            $this->propertyMapper,
+            null
+        );
+    }
+
+    public function testGetKey(): void {
+        $this->assertSame($this->addressBookInfo['id'],
+            $this->addressBookImpl->getKey());
+    }
+
+    public function testGetDisplayName(): void {
+        $this->assertSame($this->addressBookInfo['{DAV:}displayname'],
+            $this->addressBookImpl->getDisplayName());
+    }
+
+    public function testSearch(): void {
+        /** @var MockObject&AddressBookImpl $addressBookImpl */
+        $addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressBook,
+                    $this->addressBookInfo,
+                    $this->backend,
+                    $this->urlGenerator,
+                    $this->propertyMapper,
+                    null
+                ]
+            )
+            ->onlyMethods(['vCard2Array', 'readCard'])
+            ->getMock();
+
+        $pattern = 'pattern';
+        $searchProperties = 'properties';
+
+        $this->backend->expects($this->once())->method('search')
+            ->with($this->addressBookInfo['id'], $pattern, $searchProperties)
+            ->willReturn(
+                [
+                    ['uri' => 'foo.vcf', 'carddata' => 'cardData1'],
+                    ['uri' => 'bar.vcf', 'carddata' => 'cardData2']
+                ]
+            );
+
+        $addressBookImpl->expects($this->exactly(2))->method('readCard')
+            ->willReturn($this->vCard);
+        $addressBookImpl->expects($this->exactly(2))->method('vCard2Array')
+            ->willReturnMap([
+                ['foo.vcf', $this->vCard, 'vCard'],
+                ['bar.vcf', $this->vCard, 'vCard'],
+            ]);
+
+        $result = $addressBookImpl->search($pattern, $searchProperties, []);
+        $this->assertTrue((is_array($result)));
+        $this->assertSame(2, count($result));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestCreate')]
+    public function testCreate(array $properties): void {
+        $uid = 'uid';
+
+        /** @var MockObject&AddressBookImpl $addressBookImpl */
+        $addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressBook,
+                    $this->addressBookInfo,
+                    $this->backend,
+                    $this->urlGenerator,
+                    $this->propertyMapper,
+                    null
+                ]
+            )
+            ->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard'])
+            ->getMock();
+
+        $expectedProperties = 0;
+        foreach ($properties as $data) {
+            if (is_string($data)) {
+                $expectedProperties++;
+            } else {
+                $expectedProperties += count($data);
+            }
+        }
+
+        $addressBookImpl->expects($this->once())->method('createUid')
+            ->willReturn($uid);
+        $addressBookImpl->expects($this->once())->method('createEmptyVCard')
+            ->with($uid)->willReturn($this->vCard);
+        $this->vCard->expects($this->exactly($expectedProperties))
+            ->method('createProperty');
+        $this->backend->expects($this->once())->method('createCard');
+        $this->backend->expects($this->never())->method('updateCard');
+        $this->backend->expects($this->never())->method('getCard');
+        $addressBookImpl->expects($this->once())->method('vCard2Array')
+            ->with('uid.vcf', $this->vCard)->willReturn(true);
+
+        $this->assertTrue($addressBookImpl->createOrUpdate($properties));
+    }
+
+    public static function dataTestCreate(): array {
+        return [
+            [[]],
+            [['FN' => 'John Doe']],
+            [['FN' => 'John Doe', 'EMAIL' => ['john@doe.cloud', 'john.doe@example.org']]],
+        ];
+    }
+
+    public function testUpdate(): void {
+        $uid = 'uid';
+        $uri = 'bla.vcf';
+        $properties = ['URI' => $uri, 'UID' => $uid, 'FN' => 'John Doe'];
+
+        /** @var MockObject&AddressBookImpl $addressBookImpl */
+        $addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressBook,
+                    $this->addressBookInfo,
+                    $this->backend,
+                    $this->urlGenerator,
+                    $this->propertyMapper,
+                    null
+                ]
+            )
+            ->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard', 'readCard'])
+            ->getMock();
+
+        $addressBookImpl->expects($this->never())->method('createUid');
+        $addressBookImpl->expects($this->never())->method('createEmptyVCard');
+        $this->backend->expects($this->once())->method('getCard')
+            ->with($this->addressBookInfo['id'], $uri)
+            ->willReturn(['carddata' => 'data']);
+        $addressBookImpl->expects($this->once())->method('readCard')
+            ->with('data')->willReturn($this->vCard);
+        $this->vCard->expects($this->exactly(count($properties) - 1))
+            ->method('createProperty');
+        $this->backend->expects($this->never())->method('createCard');
+        $this->backend->expects($this->once())->method('updateCard');
+        $addressBookImpl->expects($this->once())->method('vCard2Array')
+            ->with($uri, $this->vCard)->willReturn(true);
+
+        $this->assertTrue($addressBookImpl->createOrUpdate($properties));
+    }
+
+    public function testUpdateWithTypes(): void {
+        $uid = 'uid';
+        $uri = 'bla.vcf';
+        $properties = ['URI' => $uri, 'UID' => $uid, 'FN' => 'John Doe', 'ADR' => [['type' => 'HOME', 'value' => ';;street;city;;;country']]];
+        $vCard = new vCard;
+        $textProperty = $vCard->createProperty('KEY', 'value');
+
+        /** @var MockObject&AddressBookImpl $addressBookImpl */
+        $addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressBook,
+                    $this->addressBookInfo,
+                    $this->backend,
+                    $this->urlGenerator,
+                    $this->propertyMapper,
+                    null
+                ]
+            )
+            ->onlyMethods(['vCard2Array', 'createUid', 'createEmptyVCard', 'readCard'])
+            ->getMock();
+
+        $this->backend->expects($this->once())->method('getCard')
+            ->with($this->addressBookInfo['id'], $uri)
+            ->willReturn(['carddata' => 'data']);
+        $addressBookImpl->expects($this->once())->method('readCard')
+            ->with('data')->willReturn($this->vCard);
+        $this->vCard->method('createProperty')->willReturn($textProperty);
+        $this->vCard->expects($this->exactly(count($properties) - 1))
+            ->method('createProperty');
+        $this->vCard->expects($this->once())->method('remove')
+            ->with('ADR');
+        $this->vCard->expects($this->once())->method('add');
+
+        $addressBookImpl->createOrUpdate($properties);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestGetPermissions')]
+    public function testGetPermissions(array $permissions, int $expected): void {
+        $this->addressBook->expects($this->once())->method('getACL')
+            ->willReturn($permissions);
+
+        $this->assertSame($expected,
+            $this->addressBookImpl->getPermissions()
+        );
+    }
+
+    public static function dataTestGetPermissions(): array {
+        return [
+            [[], 0],
+            [[['privilege' => '{DAV:}read']], 1],
+            [[['privilege' => '{DAV:}write']], 6],
+            [[['privilege' => '{DAV:}all']], 31],
+            [[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write']], 7],
+            [[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}all']], 31],
+            [[['privilege' => '{DAV:}all'],['privilege' => '{DAV:}write']], 31],
+            [[['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write'],['privilege' => '{DAV:}all']], 31],
+            [[['privilege' => '{DAV:}all'],['privilege' => '{DAV:}read'],['privilege' => '{DAV:}write']], 31],
+        ];
+    }
+
+    public function testDelete(): void {
+        $cardId = 1;
+        $cardUri = 'cardUri';
+        $this->backend->expects($this->once())->method('getCardUri')
+            ->with($cardId)->willReturn($cardUri);
+        $this->backend->expects($this->once())->method('deleteCard')
+            ->with($this->addressBookInfo['id'], $cardUri)
+            ->willReturn(true);
+
+        $this->assertTrue($this->addressBookImpl->delete($cardId));
+    }
+
+    public function testReadCard(): void {
+        $vCard = new VCard();
+        $vCard->add(new Text($vCard, 'UID', 'uid'));
+        $vCardSerialized = $vCard->serialize();
+
+        $result = $this->invokePrivate($this->addressBookImpl, 'readCard', [$vCardSerialized]);
+        $resultSerialized = $result->serialize();
+
+        $this->assertSame($vCardSerialized, $resultSerialized);
+    }
+
+    public function testCreateUid(): void {
+        /** @var MockObject&AddressBookImpl $addressBookImpl */
+        $addressBookImpl = $this->getMockBuilder(AddressBookImpl::class)
+            ->setConstructorArgs(
+                [
+                    $this->addressBook,
+                    $this->addressBookInfo,
+                    $this->backend,
+                    $this->urlGenerator,
+                    $this->propertyMapper,
+                    null
+                ]
+            )
+            ->onlyMethods(['getUid'])
+            ->getMock();
+
+        $addressBookImpl->expects($this->exactly(2))
+            ->method('getUid')
+            ->willReturnOnConsecutiveCalls(
+                'uid0',
+                'uid1',
+            );
+
+        // simulate that 'uid0' already exists, so the second uid will be returned
+        $this->backend->expects($this->exactly(2))->method('getContact')
+            ->willReturnCallback(
+                function ($id, $uid) {
+                    return ($uid === 'uid0.vcf');
+                }
+            );
+
+        $this->assertSame('uid1',
+            $this->invokePrivate($addressBookImpl, 'createUid', [])
+        );
+    }
+
+    public function testCreateEmptyVCard(): void {
+        $uid = 'uid';
+        $expectedVCard = new VCard();
+        $expectedVCard->UID = $uid;
+        $expectedVCardSerialized = $expectedVCard->serialize();
+
+        $result = $this->invokePrivate($this->addressBookImpl, 'createEmptyVCard', [$uid]);
+        $resultSerialized = $result->serialize();
+
+        $this->assertSame($expectedVCardSerialized, $resultSerialized);
+    }
+
+    public function testVCard2Array(): void {
+        $vCard = new VCard();
+
+        $vCard->add($vCard->createProperty('FN', 'Full Name'));
+
+        // Multi-value properties
+        $vCard->add($vCard->createProperty('CLOUD', 'cloud-user1@localhost'));
+        $vCard->add($vCard->createProperty('CLOUD', 'cloud-user2@example.tld'));
+        $vCard->add($vCard->createProperty('EMAIL', 'email-user1@localhost'));
+        $vCard->add($vCard->createProperty('EMAIL', 'email-user2@example.tld'));
+        $vCard->add($vCard->createProperty('IMPP', 'impp-user1@localhost'));
+        $vCard->add($vCard->createProperty('IMPP', 'impp-user2@example.tld'));
+        $vCard->add($vCard->createProperty('TEL', '+49 123456789'));
+        $vCard->add($vCard->createProperty('TEL', '+1 555 123456789'));
+        $vCard->add($vCard->createProperty('URL', 'https://localhost'));
+        $vCard->add($vCard->createProperty('URL', 'https://example.tld'));
+
+        // Type depending properties
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example');
+        $property->add('TYPE', 'twitter');
+        $vCard->add($property);
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example-2');
+        $property->add('TYPE', 'twitter');
+        $vCard->add($property);
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'fb-example');
+        $property->add('TYPE', 'facebook');
+        $vCard->add($property);
+
+        $array = $this->invokePrivate($this->addressBookImpl, 'vCard2Array', ['uri', $vCard]);
+        unset($array['PRODID']);
+        unset($array['UID']);
+
+        $this->assertEquals([
+            'URI' => 'uri',
+            'VERSION' => '4.0',
+            'FN' => 'Full Name',
+            'CLOUD' => [
+                'cloud-user1@localhost',
+                'cloud-user2@example.tld',
+            ],
+            'EMAIL' => [
+                'email-user1@localhost',
+                'email-user2@example.tld',
+            ],
+            'IMPP' => [
+                'impp-user1@localhost',
+                'impp-user2@example.tld',
+            ],
+            'TEL' => [
+                '+49 123456789',
+                '+1 555 123456789',
+            ],
+            'URL' => [
+                'https://localhost',
+                'https://example.tld',
+            ],
+
+            'X-SOCIALPROFILE' => [
+                'tw-example',
+                'tw-example-2',
+                'fb-example',
+            ],
+
+            'isLocalSystemBook' => true,
+        ], $array);
+    }
+
+    public function testVCard2ArrayWithTypes(): void {
+        $vCard = new VCard();
+
+        $vCard->add($vCard->createProperty('FN', 'Full Name'));
+
+        // Multi-value properties
+        $vCard->add($vCard->createProperty('CLOUD', 'cloud-user1@localhost'));
+        $vCard->add($vCard->createProperty('CLOUD', 'cloud-user2@example.tld'));
+
+        $property = $vCard->createProperty('EMAIL', 'email-user1@localhost');
+        $property->add('TYPE', 'HOME');
+        $vCard->add($property);
+        $property = $vCard->createProperty('EMAIL', 'email-user2@example.tld');
+        $property->add('TYPE', 'WORK');
+        $vCard->add($property);
+
+        $vCard->add($vCard->createProperty('IMPP', 'impp-user1@localhost'));
+        $vCard->add($vCard->createProperty('IMPP', 'impp-user2@example.tld'));
+
+        $property = $vCard->createProperty('TEL', '+49 123456789');
+        $property->add('TYPE', 'HOME,VOICE');
+        $vCard->add($property);
+        $property = $vCard->createProperty('TEL', '+1 555 123456789');
+        $property->add('TYPE', 'WORK');
+        $vCard->add($property);
+
+        $vCard->add($vCard->createProperty('URL', 'https://localhost'));
+        $vCard->add($vCard->createProperty('URL', 'https://example.tld'));
+
+        // Type depending properties
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example');
+        $property->add('TYPE', 'twitter');
+        $vCard->add($property);
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'tw-example-2');
+        $property->add('TYPE', 'twitter');
+        $vCard->add($property);
+        $property = $vCard->createProperty('X-SOCIALPROFILE', 'fb-example');
+        $property->add('TYPE', 'facebook');
+        $vCard->add($property);
+
+        $array = $this->invokePrivate($this->addressBookImpl, 'vCard2Array', ['uri', $vCard, true]);
+        unset($array['PRODID']);
+        unset($array['UID']);
+
+        $this->assertEquals([
+            'URI' => 'uri',
+            'VERSION' => '4.0',
+            'FN' => 'Full Name',
+            'CLOUD' => [
+                ['type' => '', 'value' => 'cloud-user1@localhost'],
+                ['type' => '', 'value' => 'cloud-user2@example.tld'],
+            ],
+            'EMAIL' => [
+                ['type' => 'HOME', 'value' => 'email-user1@localhost'],
+                ['type' => 'WORK', 'value' => 'email-user2@example.tld'],
+            ],
+            'IMPP' => [
+                ['type' => '', 'value' => 'impp-user1@localhost'],
+                ['type' => '', 'value' => 'impp-user2@example.tld'],
+            ],
+            'TEL' => [
+                ['type' => 'HOME,VOICE', 'value' => '+49 123456789'],
+                ['type' => 'WORK', 'value' => '+1 555 123456789'],
+            ],
+            'URL' => [
+                ['type' => '', 'value' => 'https://localhost'],
+                ['type' => '', 'value' => 'https://example.tld'],
+            ],
+
+            'X-SOCIALPROFILE' => [
+                ['type' => 'twitter', 'value' => 'tw-example'],
+                ['type' => 'twitter', 'value' => 'tw-example-2'],
+                ['type' => 'facebook', 'value' => 'fb-example'],
+            ],
+
+            'isLocalSystemBook' => true,
+        ], $array);
+    }
+
+    public function testIsSystemAddressBook(): void {
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'principals/system/system',
+            'principaluri' => 'principals/system/system',
+            '{DAV:}displayname' => 'display name',
+            'id' => 666,
+            'uri' => 'system',
+        ];
+
+        $addressBookImpl = new AddressBookImpl(
+            $this->addressBook,
+            $addressBookInfo,
+            $this->backend,
+            $this->urlGenerator,
+            $this->propertyMapper,
+            null
+        );
+
+        $this->assertTrue($addressBookImpl->isSystemAddressBook());
+    }
+
+    public function testIsShared(): void {
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user2',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+
+        $addressBookImpl = new AddressBookImpl(
+            $this->addressBook,
+            $addressBookInfo,
+            $this->backend,
+            $this->urlGenerator,
+            $this->propertyMapper,
+            'user2'
+        );
+
+        $this->assertFalse($addressBookImpl->isSystemAddressBook());
+        $this->assertTrue($addressBookImpl->isShared());
+    }
+
+    public function testIsNotShared(): void {
+        $addressBookInfo = [
+            '{http://owncloud.org/ns}owner-principal' => 'user1',
+            '{DAV:}displayname' => 'Test address book',
+            'principaluri' => 'user1',
+            'id' => 666,
+            'uri' => 'default',
+        ];
+
+        $addressBookImpl = new AddressBookImpl(
+            $this->addressBook,
+            $addressBookInfo,
+            $this->backend,
+            $this->urlGenerator,
+            $this->propertyMapper,
+            'user2'
+        );
+
+        $this->assertFalse($addressBookImpl->isSystemAddressBook());
+        $this->assertFalse($addressBookImpl->isShared());
+    }
 }

apps/dav/tests/unit/CardDAV/CardDavBackendTest.php

Indentation +866 added lines, -866 removed lines

@@ -46,870 +46,870 @@
  * @package OCA\DAV\Tests\unit\CardDAV
  */
 class CardDavBackendTest extends TestCase {
-	private Principal&MockObject $principal;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private IEventDispatcher&MockObject $dispatcher;
-	private Backend $sharingBackend;
-	private IDBConnection $db;
-	private CardDavBackend $backend;
-	private string $dbCardsTable = 'cards';
-	private string $dbCardsPropertiesTable = 'cards_properties';
-
-	public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
-	public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
-	public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
-
-	private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test' . PHP_EOL
-		. 'FN:Test' . PHP_EOL
-		. 'N:Test;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test2' . PHP_EOL
-		. 'FN:Test2' . PHP_EOL
-		. 'N:Test2;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test3' . PHP_EOL
-		. 'FN:Test3' . PHP_EOL
-		. 'N:Test3;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'FN:TestNoUID' . PHP_EOL
-		. 'N:TestNoUID;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->principal = $this->getMockBuilder(Principal::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->createMock(IAccountManager::class),
-				$this->createMock(ShareManager::class),
-				$this->createMock(IUserSession::class),
-				$this->createMock(IAppManager::class),
-				$this->createMock(ProxyMapper::class),
-				$this->createMock(KnownUserService::class),
-				$this->createMock(IConfig::class),
-				$this->createMock(IFactory::class)
-			])
-			->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
-			->getMock();
-		$this->principal->method('getPrincipalByPath')
-			->willReturn([
-				'uri' => 'principals/best-friend',
-				'{DAV:}displayname' => 'User\'s displayname',
-			]);
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-
-		$this->db = Server::get(IDBConnection::class);
-		$this->sharingBackend = new Backend($this->userManager,
-			$this->groupManager,
-			$this->principal,
-			$this->createMock(ICacheFactory::class),
-			new Service(new SharingMapper($this->db)),
-			$this->createMock(LoggerInterface::class)
-		);
-
-		$this->backend = new CardDavBackend($this->db,
-			$this->principal,
-			$this->userManager,
-			$this->dispatcher,
-			$this->sharingBackend,
-		);
-		// start every test with a empty cards_properties and cards table
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards_properties')->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards')->executeStatement();
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-	}
-
-	protected function tearDown(): void {
-		if (is_null($this->backend)) {
-			return;
-		}
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-
-		parent::tearDown();
-	}
-
-	public function testAddressBookOperations(): void {
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-
-		$this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Example', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
-
-		// update its display name
-		$patch = new PropPatch([
-			'{DAV:}displayname' => 'Unit test',
-			'{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
-		]);
-		$this->backend->updateAddressBook($books[0]['id'], $patch);
-		$patch->commit();
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testAddressBookSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::atLeastOnce())
-			->method('findByUri')
-			->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$l = $this->createMock(IL10N::class);
-		$addressBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($addressBook, [
-			[
-				'href' => 'principal:' . self::UNIT_TEST_USER1,
-			],
-			[
-				'href' => 'principal:' . self::UNIT_TEST_GROUP,
-			]
-		], []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testCardOperations(): void {
-		/** @var CardDavBackend&MockObject $backend */
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties', 'purgeProperties'])
-			->getMock();
-
-		// create a new address book
-		$backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		$uri = $this->getUniqueID('card');
-		// updateProperties is expected twice, once for createCard and once for updateCard
-		$calls = [
-			[$bookId, $uri, $this->vcardTest0],
-			[$bookId, $uri, $this->vcardTest1],
-		];
-		$backend->expects($this->exactly(count($calls)))
-			->method('updateProperties')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// Expect event
-		$this->dispatcher
-			->expects($this->exactly(3))
-			->method('dispatchTyped');
-
-		// create a card
-		$backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// get all the cards
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(1, count($cards));
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-
-		// get the cards
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertNotNull($card);
-		$this->assertArrayHasKey('id', $card);
-		$this->assertArrayHasKey('uri', $card);
-		$this->assertArrayHasKey('lastmodified', $card);
-		$this->assertArrayHasKey('etag', $card);
-		$this->assertArrayHasKey('size', $card);
-		$this->assertEquals($this->vcardTest0, $card['carddata']);
-
-		// update the card
-		$backend->updateCard($bookId, $uri, $this->vcardTest1);
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertEquals($this->vcardTest1, $card['carddata']);
-
-		// delete the card
-		$backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
-		$backend->deleteCard($bookId, $uri);
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultiCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-		$uri1 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri1, $this->vcardTest1);
-		$uri2 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri2, $this->vcardTest2);
-
-		// get all the cards
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(3, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-		$this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
-		$this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
-
-		// get the cards 1 & 2 (not 0)
-		$cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
-		$this->assertEquals(2, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-		foreach ($cards as $index => $card) {
-			$this->assertArrayHasKey('id', $card);
-			$this->assertArrayHasKey('uri', $card);
-			$this->assertArrayHasKey('lastmodified', $card);
-			$this->assertArrayHasKey('etag', $card);
-			$this->assertArrayHasKey('size', $card);
-			$this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
-		}
-
-		// delete the card
-		$this->backend->deleteCard($bookId, $uri0);
-		$this->backend->deleteCard($bookId, $uri1);
-		$this->backend->deleteCard($bookId, $uri2);
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultipleUIDOnDifferentAddressbooks(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create 2 new address books
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(2, count($books));
-		$bookId0 = $books[0]['id'];
-		$bookId1 = $books[1]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
-
-		// create another card with same uid but in second address book
-		$uri1 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
-	}
-
-	public function testMultipleUIDDenied(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// create another card with same uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
-	}
-
-	public function testNoValidUID(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card without uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
-	}
-
-	public function testDeleteWithoutCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods([
-				'getCardId',
-				'addChange',
-				'purgeProperties',
-				'updateProperties',
-			])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$bookId = $books[0]['id'];
-		$uri = $this->getUniqueID('card');
-
-		// create a new address book
-		$this->backend->expects($this->once())
-			->method('getCardId')
-			->with($bookId, $uri)
-			->willThrowException(new \InvalidArgumentException());
-
-		$calls = [
-			[$bookId, $uri, 1],
-			[$bookId, $uri, 3],
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('addChange')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->backend->expects($this->never())
-			->method('purgeProperties');
-
-		// create a card
-		$this->backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// delete the card
-		$this->assertTrue($this->backend->deleteCard($bookId, $uri));
-	}
-
-	public function testSyncSupport(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// fist call without synctoken
-		$changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		// add a change
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// look for changes
-		$changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
-		$this->assertEquals($uri0, $changes['added'][0]);
-	}
-
-	public function testSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::any())
-			->method('findByUri')
-			->willReturn(self::UNIT_TEST_USER1);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$l = $this->createMock(IL10N::class);
-		$exampleBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		// adding the same sharee again has no effect
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		$this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(0, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testUpdateProperties(): void {
-		$bookId = 42;
-		$cardUri = 'card-uri';
-		$cardId = 2;
-
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
-			->onlyMethods(['getCardId'])->getMock();
-
-		$backend->expects($this->any())->method('getCardId')->willReturn($cardId);
-
-		// add properties for new vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$vCard->FN = 'John Doe';
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties')
-			->orderBy('name');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(2, count($result));
-
-		$this->assertSame('FN', $result[0]['name']);
-		$this->assertSame('John Doe', $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-
-		$this->assertSame('UID', $result[1]['name']);
-		$this->assertSame($cardUri, $result[1]['value']);
-		$this->assertSame($bookId, (int)$result[1]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[1]['cardid']);
-
-		// update properties for existing vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-
-		$this->assertSame('UID', $result[0]['name']);
-		$this->assertSame($cardUri, $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-	}
-
-	public function testPurgeProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(1),
-					'name' => $query->createNamedParameter('name1'),
-					'value' => $query->createNamedParameter('value1'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(2),
-					'name' => $query->createNamedParameter('name2'),
-					'value' => $query->createNamedParameter('value2'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->execute();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-		$this->assertSame(1, (int)$result[0]['addressbookid']);
-		$this->assertSame(2, (int)$result[0]['cardid']);
-	}
-
-	public function testGetCardId(): void {
-		$query = $this->db->getQueryBuilder();
-
-		$query->insert('cards')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter(''),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(4738743),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120)
-				]
-			);
-		$query->execute();
-		$id = $query->getLastInsertId();
-
-		$this->assertSame($id,
-			$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
-	}
-
-
-	public function testGetCardIdFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
-	public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
-		/** @var VCard $vCards */
-		$vCards = [];
-		$vCards[0] = new VCard();
-		$vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
-		$vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
-		$vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
-		$vCards[1] = new VCard();
-		$vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
-		$vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
-		$vCards[2] = new VCard();
-		$vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
-		$vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
-		$vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
-
-		$vCardIds = [];
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 3; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter(0),
-						'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(time()),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->execute();
-			$vCardIds[] = $query->getLastInsertId();
-		}
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('John@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[1]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John M. Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('find without options'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->execute();
-
-		$result = $this->backend->search(0, $pattern, $properties, $options);
-
-		// check result
-		$this->assertSame(count($expected), count($result));
-		$found = [];
-		foreach ($result as $r) {
-			foreach ($expected as $exp) {
-				if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
-					$found[$exp[1]] = true;
-					break;
-				}
-			}
-		}
-
-		$this->assertSame(count($expected), count($found));
-	}
-
-	public static function dataTestSearch(): array {
-		return [
-			['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
-			['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
-			'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
-			'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
-			'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
-		];
-	}
-
-	public function testGetCardUri(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(5489543),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120),
-				]
-			);
-		$query->execute();
-
-		$id = $query->getLastInsertId();
-
-		$this->assertSame('uri', $this->backend->getCardUri($id));
-	}
-
-
-	public function testGetCardUriFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->backend->getCardUri(1);
-	}
-
-	public function testGetContact(): void {
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 2; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter($i),
-						'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(5489543),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->execute();
-		}
-
-		$result = $this->backend->getContact(0, 'uri0');
-		$this->assertSame(8, count($result));
-		$this->assertSame(0, (int)$result['addressbookid']);
-		$this->assertSame('uri0', $result['uri']);
-		$this->assertSame(5489543, (int)$result['lastmodified']);
-		$this->assertSame('"etag0"', $result['etag']);
-		$this->assertSame(120, (int)$result['size']);
-
-		// this shouldn't return any result because 'uri1' is in address book 1
-		// see https://github.com/nextcloud/server/issues/229
-		$result = $this->backend->getContact(0, 'uri1');
-		$this->assertEmpty($result);
-	}
-
-	public function testGetContactFail(): void {
-		$this->assertEmpty($this->backend->getContact(0, 'uri'));
-	}
-
-	public function testCollectCardProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(666),
-					'cardid' => $query->createNamedParameter(777),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			)
-			->execute();
-
-		$result = $this->backend->collectCardProperties(666, 'FN');
-		$this->assertEquals(['John Doe'], $result);
-	}
-
-	/**
-	 * @throws \OCP\DB\Exception
-	 * @throws \Sabre\DAV\Exception\BadRequest
-	 */
-	public function testPruneOutdatedSyncTokens(): void {
-		$addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-
-		// Do not delete anything if week data as old as ts=0
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
-		self::assertSame(0, $deleted);
-
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
-		// At least one from the object creation and one from the object update
-		$this->assertGreaterThanOrEqual(2, $deleted);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
-		$this->assertEmpty($changes['added']);
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Test that objects remain
-
-		// Currently changes are empty
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
-
-		// Create card
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		// We now have one add
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(1, count($changes['added']));
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Update card
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-		// One add, one modify, but shortened to modify
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Delete all but last change
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-		$this->assertEquals(1, $deleted); // We had two changes before, now one
-
-		// Only update should remain
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Check that no crash occurs when prune is called without current changes
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-	}
+    private Principal&MockObject $principal;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private IEventDispatcher&MockObject $dispatcher;
+    private Backend $sharingBackend;
+    private IDBConnection $db;
+    private CardDavBackend $backend;
+    private string $dbCardsTable = 'cards';
+    private string $dbCardsPropertiesTable = 'cards_properties';
+
+    public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
+    public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
+    public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
+
+    private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test' . PHP_EOL
+        . 'FN:Test' . PHP_EOL
+        . 'N:Test;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test2' . PHP_EOL
+        . 'FN:Test2' . PHP_EOL
+        . 'N:Test2;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test3' . PHP_EOL
+        . 'FN:Test3' . PHP_EOL
+        . 'N:Test3;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'FN:TestNoUID' . PHP_EOL
+        . 'N:TestNoUID;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->principal = $this->getMockBuilder(Principal::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->createMock(IAccountManager::class),
+                $this->createMock(ShareManager::class),
+                $this->createMock(IUserSession::class),
+                $this->createMock(IAppManager::class),
+                $this->createMock(ProxyMapper::class),
+                $this->createMock(KnownUserService::class),
+                $this->createMock(IConfig::class),
+                $this->createMock(IFactory::class)
+            ])
+            ->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
+            ->getMock();
+        $this->principal->method('getPrincipalByPath')
+            ->willReturn([
+                'uri' => 'principals/best-friend',
+                '{DAV:}displayname' => 'User\'s displayname',
+            ]);
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+
+        $this->db = Server::get(IDBConnection::class);
+        $this->sharingBackend = new Backend($this->userManager,
+            $this->groupManager,
+            $this->principal,
+            $this->createMock(ICacheFactory::class),
+            new Service(new SharingMapper($this->db)),
+            $this->createMock(LoggerInterface::class)
+        );
+
+        $this->backend = new CardDavBackend($this->db,
+            $this->principal,
+            $this->userManager,
+            $this->dispatcher,
+            $this->sharingBackend,
+        );
+        // start every test with a empty cards_properties and cards table
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards_properties')->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards')->executeStatement();
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+    }
+
+    protected function tearDown(): void {
+        if (is_null($this->backend)) {
+            return;
+        }
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+
+        parent::tearDown();
+    }
+
+    public function testAddressBookOperations(): void {
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+
+        $this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Example', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
+
+        // update its display name
+        $patch = new PropPatch([
+            '{DAV:}displayname' => 'Unit test',
+            '{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
+        ]);
+        $this->backend->updateAddressBook($books[0]['id'], $patch);
+        $patch->commit();
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testAddressBookSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::atLeastOnce())
+            ->method('findByUri')
+            ->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $l = $this->createMock(IL10N::class);
+        $addressBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($addressBook, [
+            [
+                'href' => 'principal:' . self::UNIT_TEST_USER1,
+            ],
+            [
+                'href' => 'principal:' . self::UNIT_TEST_GROUP,
+            ]
+        ], []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testCardOperations(): void {
+        /** @var CardDavBackend&MockObject $backend */
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties', 'purgeProperties'])
+            ->getMock();
+
+        // create a new address book
+        $backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        $uri = $this->getUniqueID('card');
+        // updateProperties is expected twice, once for createCard and once for updateCard
+        $calls = [
+            [$bookId, $uri, $this->vcardTest0],
+            [$bookId, $uri, $this->vcardTest1],
+        ];
+        $backend->expects($this->exactly(count($calls)))
+            ->method('updateProperties')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // Expect event
+        $this->dispatcher
+            ->expects($this->exactly(3))
+            ->method('dispatchTyped');
+
+        // create a card
+        $backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // get all the cards
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(1, count($cards));
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+
+        // get the cards
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertNotNull($card);
+        $this->assertArrayHasKey('id', $card);
+        $this->assertArrayHasKey('uri', $card);
+        $this->assertArrayHasKey('lastmodified', $card);
+        $this->assertArrayHasKey('etag', $card);
+        $this->assertArrayHasKey('size', $card);
+        $this->assertEquals($this->vcardTest0, $card['carddata']);
+
+        // update the card
+        $backend->updateCard($bookId, $uri, $this->vcardTest1);
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertEquals($this->vcardTest1, $card['carddata']);
+
+        // delete the card
+        $backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
+        $backend->deleteCard($bookId, $uri);
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultiCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+        $uri1 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri1, $this->vcardTest1);
+        $uri2 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri2, $this->vcardTest2);
+
+        // get all the cards
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(3, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+        $this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
+        $this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
+
+        // get the cards 1 & 2 (not 0)
+        $cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
+        $this->assertEquals(2, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+        foreach ($cards as $index => $card) {
+            $this->assertArrayHasKey('id', $card);
+            $this->assertArrayHasKey('uri', $card);
+            $this->assertArrayHasKey('lastmodified', $card);
+            $this->assertArrayHasKey('etag', $card);
+            $this->assertArrayHasKey('size', $card);
+            $this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
+        }
+
+        // delete the card
+        $this->backend->deleteCard($bookId, $uri0);
+        $this->backend->deleteCard($bookId, $uri1);
+        $this->backend->deleteCard($bookId, $uri2);
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultipleUIDOnDifferentAddressbooks(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create 2 new address books
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(2, count($books));
+        $bookId0 = $books[0]['id'];
+        $bookId1 = $books[1]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
+
+        // create another card with same uid but in second address book
+        $uri1 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
+    }
+
+    public function testMultipleUIDDenied(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // create another card with same uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
+    }
+
+    public function testNoValidUID(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card without uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
+    }
+
+    public function testDeleteWithoutCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods([
+                'getCardId',
+                'addChange',
+                'purgeProperties',
+                'updateProperties',
+            ])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $bookId = $books[0]['id'];
+        $uri = $this->getUniqueID('card');
+
+        // create a new address book
+        $this->backend->expects($this->once())
+            ->method('getCardId')
+            ->with($bookId, $uri)
+            ->willThrowException(new \InvalidArgumentException());
+
+        $calls = [
+            [$bookId, $uri, 1],
+            [$bookId, $uri, 3],
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('addChange')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->backend->expects($this->never())
+            ->method('purgeProperties');
+
+        // create a card
+        $this->backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // delete the card
+        $this->assertTrue($this->backend->deleteCard($bookId, $uri));
+    }
+
+    public function testSyncSupport(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // fist call without synctoken
+        $changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        // add a change
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // look for changes
+        $changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
+        $this->assertEquals($uri0, $changes['added'][0]);
+    }
+
+    public function testSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::any())
+            ->method('findByUri')
+            ->willReturn(self::UNIT_TEST_USER1);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $l = $this->createMock(IL10N::class);
+        $exampleBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        // adding the same sharee again has no effect
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        $this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(0, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testUpdateProperties(): void {
+        $bookId = 42;
+        $cardUri = 'card-uri';
+        $cardId = 2;
+
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend])
+            ->onlyMethods(['getCardId'])->getMock();
+
+        $backend->expects($this->any())->method('getCardId')->willReturn($cardId);
+
+        // add properties for new vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $vCard->FN = 'John Doe';
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties')
+            ->orderBy('name');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(2, count($result));
+
+        $this->assertSame('FN', $result[0]['name']);
+        $this->assertSame('John Doe', $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+
+        $this->assertSame('UID', $result[1]['name']);
+        $this->assertSame($cardUri, $result[1]['value']);
+        $this->assertSame($bookId, (int)$result[1]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[1]['cardid']);
+
+        // update properties for existing vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+
+        $this->assertSame('UID', $result[0]['name']);
+        $this->assertSame($cardUri, $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+    }
+
+    public function testPurgeProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(1),
+                    'name' => $query->createNamedParameter('name1'),
+                    'value' => $query->createNamedParameter('value1'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(2),
+                    'name' => $query->createNamedParameter('name2'),
+                    'value' => $query->createNamedParameter('value2'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->execute();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+        $this->assertSame(1, (int)$result[0]['addressbookid']);
+        $this->assertSame(2, (int)$result[0]['cardid']);
+    }
+
+    public function testGetCardId(): void {
+        $query = $this->db->getQueryBuilder();
+
+        $query->insert('cards')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter(''),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(4738743),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120)
+                ]
+            );
+        $query->execute();
+        $id = $query->getLastInsertId();
+
+        $this->assertSame($id,
+            $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
+    }
+
+
+    public function testGetCardIdFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
+    public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
+        /** @var VCard $vCards */
+        $vCards = [];
+        $vCards[0] = new VCard();
+        $vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
+        $vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
+        $vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
+        $vCards[1] = new VCard();
+        $vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
+        $vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
+        $vCards[2] = new VCard();
+        $vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
+        $vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
+        $vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
+
+        $vCardIds = [];
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 3; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter(0),
+                        'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(time()),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->execute();
+            $vCardIds[] = $query->getLastInsertId();
+        }
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('John@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[1]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John M. Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('find without options'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->execute();
+
+        $result = $this->backend->search(0, $pattern, $properties, $options);
+
+        // check result
+        $this->assertSame(count($expected), count($result));
+        $found = [];
+        foreach ($result as $r) {
+            foreach ($expected as $exp) {
+                if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
+                    $found[$exp[1]] = true;
+                    break;
+                }
+            }
+        }
+
+        $this->assertSame(count($expected), count($found));
+    }
+
+    public static function dataTestSearch(): array {
+        return [
+            ['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            ['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
+            ['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
+            'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
+            'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
+            'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
+        ];
+    }
+
+    public function testGetCardUri(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(5489543),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120),
+                ]
+            );
+        $query->execute();
+
+        $id = $query->getLastInsertId();
+
+        $this->assertSame('uri', $this->backend->getCardUri($id));
+    }
+
+
+    public function testGetCardUriFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->backend->getCardUri(1);
+    }
+
+    public function testGetContact(): void {
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 2; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter($i),
+                        'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(5489543),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->execute();
+        }
+
+        $result = $this->backend->getContact(0, 'uri0');
+        $this->assertSame(8, count($result));
+        $this->assertSame(0, (int)$result['addressbookid']);
+        $this->assertSame('uri0', $result['uri']);
+        $this->assertSame(5489543, (int)$result['lastmodified']);
+        $this->assertSame('"etag0"', $result['etag']);
+        $this->assertSame(120, (int)$result['size']);
+
+        // this shouldn't return any result because 'uri1' is in address book 1
+        // see https://github.com/nextcloud/server/issues/229
+        $result = $this->backend->getContact(0, 'uri1');
+        $this->assertEmpty($result);
+    }
+
+    public function testGetContactFail(): void {
+        $this->assertEmpty($this->backend->getContact(0, 'uri'));
+    }
+
+    public function testCollectCardProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(666),
+                    'cardid' => $query->createNamedParameter(777),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            )
+            ->execute();
+
+        $result = $this->backend->collectCardProperties(666, 'FN');
+        $this->assertEquals(['John Doe'], $result);
+    }
+
+    /**
+     * @throws \OCP\DB\Exception
+     * @throws \Sabre\DAV\Exception\BadRequest
+     */
+    public function testPruneOutdatedSyncTokens(): void {
+        $addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+
+        // Do not delete anything if week data as old as ts=0
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
+        self::assertSame(0, $deleted);
+
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
+        // At least one from the object creation and one from the object update
+        $this->assertGreaterThanOrEqual(2, $deleted);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
+        $this->assertEmpty($changes['added']);
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Test that objects remain
+
+        // Currently changes are empty
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
+
+        // Create card
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        // We now have one add
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(1, count($changes['added']));
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Update card
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+        // One add, one modify, but shortened to modify
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Delete all but last change
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+        $this->assertEquals(1, $deleted); // We had two changes before, now one
+
+        // Only update should remain
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Check that no crash occurs when prune is called without current changes
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+    }
 }

Spacing +49 added lines, -49 removed lines

@@ -60,35 +60,35 @@ 
 	public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
 	public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
 
-	private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test' . PHP_EOL
-		. 'FN:Test' . PHP_EOL
-		. 'N:Test;;;;' . PHP_EOL
+	private $vcardTest0 = 'BEGIN:VCARD'.PHP_EOL
+		. 'VERSION:3.0'.PHP_EOL
+		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL
+		. 'UID:Test'.PHP_EOL
+		. 'FN:Test'.PHP_EOL
+		. 'N:Test;;;;'.PHP_EOL
 		. 'END:VCARD';
 
-	private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test2' . PHP_EOL
-		. 'FN:Test2' . PHP_EOL
-		. 'N:Test2;;;;' . PHP_EOL
+	private $vcardTest1 = 'BEGIN:VCARD'.PHP_EOL
+		. 'VERSION:3.0'.PHP_EOL
+		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL
+		. 'UID:Test2'.PHP_EOL
+		. 'FN:Test2'.PHP_EOL
+		. 'N:Test2;;;;'.PHP_EOL
 		. 'END:VCARD';
 
-	private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test3' . PHP_EOL
-		. 'FN:Test3' . PHP_EOL
-		. 'N:Test3;;;;' . PHP_EOL
+	private $vcardTest2 = 'BEGIN:VCARD'.PHP_EOL
+		. 'VERSION:3.0'.PHP_EOL
+		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL
+		. 'UID:Test3'.PHP_EOL
+		. 'FN:Test3'.PHP_EOL
+		. 'N:Test3;;;;'.PHP_EOL
 		. 'END:VCARD';
 
-	private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'FN:TestNoUID' . PHP_EOL
-		. 'N:TestNoUID;;;;' . PHP_EOL
+	private $vcardTestNoUID = 'BEGIN:VCARD'.PHP_EOL
+		. 'VERSION:3.0'.PHP_EOL
+		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN'.PHP_EOL
+		. 'FN:TestNoUID'.PHP_EOL
+		. 'N:TestNoUID;;;;'.PHP_EOL
 		. 'END:VCARD';
 
 	protected function setUp(): void {
@@ -213,10 +213,10 @@ 
 		$addressBook = new AddressBook($this->backend, $books[0], $l);
 		$this->backend->updateShares($addressBook, [
 			[
-				'href' => 'principal:' . self::UNIT_TEST_USER1,
+				'href' => 'principal:'.self::UNIT_TEST_USER1,
 			],
 			[
-				'href' => 'principal:' . self::UNIT_TEST_GROUP,
+				'href' => 'principal:'.self::UNIT_TEST_GROUP,
 			]
 		], []);
 		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
@@ -249,7 +249,7 @@ 
 		];
 		$backend->expects($this->exactly(count($calls)))
 			->method('updateProperties')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -312,7 +312,7 @@ 
 		// get all the cards
 		$cards = $this->backend->getCards($bookId);
 		$this->assertEquals(3, count($cards));
-		usort($cards, function ($a, $b) {
+		usort($cards, function($a, $b) {
 			return $a['id'] < $b['id'] ? -1 : 1;
 		});
 
@@ -323,7 +323,7 @@ 
 		// get the cards 1 & 2 (not 0)
 		$cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
 		$this->assertEquals(2, count($cards));
-		usort($cards, function ($a, $b) {
+		usort($cards, function($a, $b) {
 			return $a['id'] < $b['id'] ? -1 : 1;
 		});
 		foreach ($cards as $index => $card) {
@@ -332,7 +332,7 @@ 
 			$this->assertArrayHasKey('lastmodified', $card);
 			$this->assertArrayHasKey('etag', $card);
 			$this->assertArrayHasKey('size', $card);
-			$this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
+			$this->assertEquals($this->{ 'vcardTest'.($index + 1) }, $card['carddata']);
 		}
 
 		// delete the card
@@ -437,7 +437,7 @@ 
 		];
 		$this->backend->expects($this->exactly(count($calls)))
 			->method('addChange')
-			->willReturnCallback(function () use (&$calls): void {
+			->willReturnCallback(function() use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -493,13 +493,13 @@ 
 
 		$l = $this->createMock(IL10N::class);
 		$exampleBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+		$this->backend->updateShares($exampleBook, [['href' => 'principal:'.self::UNIT_TEST_USER1]], []);
 
 		$shares = $this->backend->getShares($exampleBook->getResourceId());
 		$this->assertEquals(1, count($shares));
 
 		// adding the same sharee again has no effect
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+		$this->backend->updateShares($exampleBook, [['href' => 'principal:'.self::UNIT_TEST_USER1]], []);
 
 		$shares = $this->backend->getShares($exampleBook->getResourceId());
 		$this->assertEquals(1, count($shares));
@@ -507,7 +507,7 @@ 
 		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
 		$this->assertEquals(1, count($books));
 
-		$this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
+		$this->backend->updateShares($exampleBook, [], ['principal:'.self::UNIT_TEST_USER1]);
 
 		$shares = $this->backend->getShares($exampleBook->getResourceId());
 		$this->assertEquals(0, count($shares));
@@ -546,13 +546,13 @@ 
 
 		$this->assertSame('FN', $result[0]['name']);
 		$this->assertSame('John Doe', $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
+		$this->assertSame($bookId, (int) $result[0]['addressbookid']);
+		$this->assertSame($cardId, (int) $result[0]['cardid']);
 
 		$this->assertSame('UID', $result[1]['name']);
 		$this->assertSame($cardUri, $result[1]['value']);
-		$this->assertSame($bookId, (int)$result[1]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[1]['cardid']);
+		$this->assertSame($bookId, (int) $result[1]['addressbookid']);
+		$this->assertSame($cardId, (int) $result[1]['cardid']);
 
 		// update properties for existing vCard
 		$vCard = new VCard();
@@ -571,8 +571,8 @@ 
 
 		$this->assertSame('UID', $result[0]['name']);
 		$this->assertSame($cardUri, $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
+		$this->assertSame($bookId, (int) $result[0]['addressbookid']);
+		$this->assertSame($cardId, (int) $result[0]['cardid']);
 	}
 
 	public function testPurgeProperties(): void {
@@ -613,8 +613,8 @@ 
 		$qResult->closeCursor();
 
 		$this->assertSame(1, count($result));
-		$this->assertSame(1, (int)$result[0]['addressbookid']);
-		$this->assertSame(2, (int)$result[0]['cardid']);
+		$this->assertSame(1, (int) $result[0]['addressbookid']);
+		$this->assertSame(2, (int) $result[0]['cardid']);
 	}
 
 	public function testGetCardId(): void {
@@ -669,9 +669,9 @@ 
 					[
 						'addressbookid' => $query->createNamedParameter(0),
 						'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
+						'uri' => $query->createNamedParameter('uri'.$i),
 						'lastmodified' => $query->createNamedParameter(time()),
-						'etag' => $query->createNamedParameter('etag' . $i),
+						'etag' => $query->createNamedParameter('etag'.$i),
 						'size' => $query->createNamedParameter(120),
 					]
 				);
@@ -805,10 +805,10 @@ 
 				->values(
 					[
 						'addressbookid' => $query->createNamedParameter($i),
-						'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
+						'carddata' => $query->createNamedParameter('carddata'.$i, IQueryBuilder::PARAM_LOB),
+						'uri' => $query->createNamedParameter('uri'.$i),
 						'lastmodified' => $query->createNamedParameter(5489543),
-						'etag' => $query->createNamedParameter('etag' . $i),
+						'etag' => $query->createNamedParameter('etag'.$i),
 						'size' => $query->createNamedParameter(120),
 					]
 				);
@@ -817,11 +817,11 @@ 
 
 		$result = $this->backend->getContact(0, 'uri0');
 		$this->assertSame(8, count($result));
-		$this->assertSame(0, (int)$result['addressbookid']);
+		$this->assertSame(0, (int) $result['addressbookid']);
 		$this->assertSame('uri0', $result['uri']);
-		$this->assertSame(5489543, (int)$result['lastmodified']);
+		$this->assertSame(5489543, (int) $result['lastmodified']);
 		$this->assertSame('"etag0"', $result['etag']);
-		$this->assertSame(120, (int)$result['size']);
+		$this->assertSame(120, (int) $result['size']);
 
 		// this shouldn't return any result because 'uri1' is in address book 1
 		// see https://github.com/nextcloud/server/issues/229