Passed
Push — master ( 32bbe3...a17d01 )
by John
19:06 queued 13s
created
apps/dav/lib/Migration/RegenerateBirthdayCalendars.php 1 patch
Indentation   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -30,43 +30,43 @@
 block discarded – undo
30 30
 
31 31
 class RegenerateBirthdayCalendars implements IRepairStep {
32 32
 
33
-	/** @var IJobList */
34
-	private $jobList;
33
+    /** @var IJobList */
34
+    private $jobList;
35 35
 
36
-	/** @var IConfig */
37
-	private $config;
36
+    /** @var IConfig */
37
+    private $config;
38 38
 
39
-	/**
40
-	 * @param IJobList $jobList
41
-	 * @param IConfig $config
42
-	 */
43
-	public function __construct(IJobList $jobList,
44
-								IConfig $config) {
45
-		$this->jobList = $jobList;
46
-		$this->config = $config;
47
-	}
39
+    /**
40
+     * @param IJobList $jobList
41
+     * @param IConfig $config
42
+     */
43
+    public function __construct(IJobList $jobList,
44
+                                IConfig $config) {
45
+        $this->jobList = $jobList;
46
+        $this->config = $config;
47
+    }
48 48
 
49
-	/**
50
-	 * @return string
51
-	 */
52
-	public function getName() {
53
-		return 'Regenerating birthday calendars to use new icons and fix old birthday events without year';
54
-	}
49
+    /**
50
+     * @return string
51
+     */
52
+    public function getName() {
53
+        return 'Regenerating birthday calendars to use new icons and fix old birthday events without year';
54
+    }
55 55
 
56
-	/**
57
-	 * @param IOutput $output
58
-	 */
59
-	public function run(IOutput $output) {
60
-		// only run once
61
-		if ($this->config->getAppValue('dav', 'regeneratedBirthdayCalendarsForYearFix') === 'yes') {
62
-			$output->info('Repair step already executed');
63
-			return;
64
-		}
56
+    /**
57
+     * @param IOutput $output
58
+     */
59
+    public function run(IOutput $output) {
60
+        // only run once
61
+        if ($this->config->getAppValue('dav', 'regeneratedBirthdayCalendarsForYearFix') === 'yes') {
62
+            $output->info('Repair step already executed');
63
+            return;
64
+        }
65 65
 
66
-		$output->info('Adding background jobs to regenerate birthday calendar');
67
-		$this->jobList->add(RegisterRegenerateBirthdayCalendars::class);
66
+        $output->info('Adding background jobs to regenerate birthday calendar');
67
+        $this->jobList->add(RegisterRegenerateBirthdayCalendars::class);
68 68
 
69
-		// if all were done, no need to redo the repair during next upgrade
70
-		$this->config->setAppValue('dav', 'regeneratedBirthdayCalendarsForYearFix', 'yes');
71
-	}
69
+        // if all were done, no need to redo the repair during next upgrade
70
+        $this->config->setAppValue('dav', 'regeneratedBirthdayCalendarsForYearFix', 'yes');
71
+    }
72 72
 }
Please login to merge, or discard this patch.
apps/twofactor_backupcodes/lib/Listener/ProviderEnabled.php 1 patch
Indentation   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -33,30 +33,30 @@
 block discarded – undo
33 33
 
34 34
 class ProviderEnabled implements IEventListener {
35 35
 
36
-	/** @var IRegistry */
37
-	private $registry;
38
-
39
-	/** @var IJobList */
40
-	private $jobList;
41
-
42
-	public function __construct(IRegistry $registry,
43
-								IJobList $jobList) {
44
-		$this->registry = $registry;
45
-		$this->jobList = $jobList;
46
-	}
47
-
48
-	public function handle(Event $event): void {
49
-		if (!($event instanceof RegistryEvent)) {
50
-			return;
51
-		}
52
-
53
-		$providers = $this->registry->getProviderStates($event->getUser());
54
-		if (isset($providers['backup_codes']) && $providers['backup_codes'] === true) {
55
-			// Backup codes already generated nothing to do here
56
-			return;
57
-		}
58
-
59
-		$this->jobList->add(RememberBackupCodesJob::class, ['uid' => $event->getUser()->getUID()]);
60
-	}
36
+    /** @var IRegistry */
37
+    private $registry;
38
+
39
+    /** @var IJobList */
40
+    private $jobList;
41
+
42
+    public function __construct(IRegistry $registry,
43
+                                IJobList $jobList) {
44
+        $this->registry = $registry;
45
+        $this->jobList = $jobList;
46
+    }
47
+
48
+    public function handle(Event $event): void {
49
+        if (!($event instanceof RegistryEvent)) {
50
+            return;
51
+        }
52
+
53
+        $providers = $this->registry->getProviderStates($event->getUser());
54
+        if (isset($providers['backup_codes']) && $providers['backup_codes'] === true) {
55
+            // Backup codes already generated nothing to do here
56
+            return;
57
+        }
58
+
59
+        $this->jobList->add(RememberBackupCodesJob::class, ['uid' => $event->getUser()->getUID()]);
60
+    }
61 61
 
62 62
 }
Please login to merge, or discard this patch.
apps/twofactor_backupcodes/lib/Listener/ClearNotifications.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -33,22 +33,22 @@
 block discarded – undo
33 33
 
34 34
 class ClearNotifications implements IEventListener {
35 35
 
36
-	/** @var IManager */
37
-	private $manager;
38
-
39
-	public function __construct(IManager $manager) {
40
-		$this->manager = $manager;
41
-	}
42
-
43
-	public function handle(Event $event): void {
44
-		if (!($event instanceof CodesGenerated)) {
45
-			return;
46
-		}
47
-
48
-		$notification = $this->manager->createNotification();
49
-		$notification->setApp('twofactor_backupcodes')
50
-			->setUser($event->getUser()->getUID())
51
-			->setObject('create', 'codes');
52
-		$this->manager->markProcessed($notification);
53
-	}
36
+    /** @var IManager */
37
+    private $manager;
38
+
39
+    public function __construct(IManager $manager) {
40
+        $this->manager = $manager;
41
+    }
42
+
43
+    public function handle(Event $event): void {
44
+        if (!($event instanceof CodesGenerated)) {
45
+            return;
46
+        }
47
+
48
+        $notification = $this->manager->createNotification();
49
+        $notification->setApp('twofactor_backupcodes')
50
+            ->setUser($event->getUser()->getUID())
51
+            ->setObject('create', 'codes');
52
+        $this->manager->markProcessed($notification);
53
+    }
54 54
 }
Please login to merge, or discard this patch.
apps/twofactor_backupcodes/lib/Listener/ActivityPublisher.php 1 patch
Indentation   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -33,36 +33,36 @@
 block discarded – undo
33 33
 
34 34
 class ActivityPublisher implements IEventListener {
35 35
 
36
-	/** @var IManager */
37
-	private $activityManager;
36
+    /** @var IManager */
37
+    private $activityManager;
38 38
 
39
-	/** @var ILogger */
40
-	private $logger;
39
+    /** @var ILogger */
40
+    private $logger;
41 41
 
42
-	public function __construct(IManager $activityManager,
43
-								ILogger $logger) {
44
-		$this->activityManager = $activityManager;
45
-		$this->logger = $logger;
46
-	}
42
+    public function __construct(IManager $activityManager,
43
+                                ILogger $logger) {
44
+        $this->activityManager = $activityManager;
45
+        $this->logger = $logger;
46
+    }
47 47
 
48
-	/**
49
-	 * Push an event to the user's activity stream
50
-	 */
51
-	public function handle(Event $event): void {
52
-		if ($event instanceof CodesGenerated) {
53
-			$activity = $this->activityManager->generateEvent();
54
-			$activity->setApp('twofactor_backupcodes')
55
-				->setType('security')
56
-				->setAuthor($event->getUser()->getUID())
57
-				->setAffectedUser($event->getUser()->getUID())
58
-				->setSubject('codes_generated');
59
-			try {
60
-				$this->activityManager->publish($activity);
61
-			} catch (BadMethodCallException $e) {
62
-				$this->logger->warning('could not publish backup code creation activity', ['app' => 'twofactor_backupcodes']);
63
-				$this->logger->logException($e, ['app' => 'twofactor_backupcodes']);
64
-			}
65
-		}
66
-	}
48
+    /**
49
+     * Push an event to the user's activity stream
50
+     */
51
+    public function handle(Event $event): void {
52
+        if ($event instanceof CodesGenerated) {
53
+            $activity = $this->activityManager->generateEvent();
54
+            $activity->setApp('twofactor_backupcodes')
55
+                ->setType('security')
56
+                ->setAuthor($event->getUser()->getUID())
57
+                ->setAffectedUser($event->getUser()->getUID())
58
+                ->setSubject('codes_generated');
59
+            try {
60
+                $this->activityManager->publish($activity);
61
+            } catch (BadMethodCallException $e) {
62
+                $this->logger->warning('could not publish backup code creation activity', ['app' => 'twofactor_backupcodes']);
63
+                $this->logger->logException($e, ['app' => 'twofactor_backupcodes']);
64
+            }
65
+        }
66
+    }
67 67
 
68 68
 }
Please login to merge, or discard this patch.
apps/twofactor_backupcodes/lib/Listener/RegistryUpdater.php 1 patch
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -32,21 +32,21 @@
 block discarded – undo
32 32
 
33 33
 class RegistryUpdater implements IEventListener {
34 34
 
35
-	/** @var IRegistry */
36
-	private $registry;
37
-
38
-	/** @var BackupCodesProvider */
39
-	private $provider;
40
-
41
-	public function __construct(IRegistry $registry, BackupCodesProvider $provider) {
42
-		$this->registry = $registry;
43
-		$this->provider = $provider;
44
-	}
45
-
46
-	public function handle(Event $event): void {
47
-		if ($event instanceof CodesGenerated) {
48
-			$this->registry->enableProviderFor($this->provider, $event->getUser());
49
-		}
50
-	}
35
+    /** @var IRegistry */
36
+    private $registry;
37
+
38
+    /** @var BackupCodesProvider */
39
+    private $provider;
40
+
41
+    public function __construct(IRegistry $registry, BackupCodesProvider $provider) {
42
+        $this->registry = $registry;
43
+        $this->provider = $provider;
44
+    }
45
+
46
+    public function handle(Event $event): void {
47
+        if ($event instanceof CodesGenerated) {
48
+            $this->registry->enableProviderFor($this->provider, $event->getUser());
49
+        }
50
+    }
51 51
 
52 52
 }
Please login to merge, or discard this patch.
lib/public/Preview/IProvider.php 1 patch
Indentation   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -30,31 +30,31 @@
 block discarded – undo
30 30
  * @deprecated 17.0.0 use IProviderV2 instead
31 31
  */
32 32
 interface IProvider {
33
-	/**
34
-	 * @return string Regex with the mimetypes that are supported by this provider
35
-	 * @since 8.1.0
36
-	 */
37
-	public function getMimeType();
33
+    /**
34
+     * @return string Regex with the mimetypes that are supported by this provider
35
+     * @since 8.1.0
36
+     */
37
+    public function getMimeType();
38 38
 
39
-	/**
40
-	 * Check if a preview can be generated for $path
41
-	 *
42
-	 * @param \OCP\Files\FileInfo $file
43
-	 * @return bool
44
-	 * @since 8.1.0
45
-	 */
46
-	public function isAvailable(\OCP\Files\FileInfo $file);
39
+    /**
40
+     * Check if a preview can be generated for $path
41
+     *
42
+     * @param \OCP\Files\FileInfo $file
43
+     * @return bool
44
+     * @since 8.1.0
45
+     */
46
+    public function isAvailable(\OCP\Files\FileInfo $file);
47 47
 
48
-	/**
49
-	 * get thumbnail for file at path $path
50
-	 *
51
-	 * @param string $path Path of file
52
-	 * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
53
-	 * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
54
-	 * @param bool $scalingup Disable/Enable upscaling of previews
55
-	 * @param \OC\Files\View $fileview fileview object of user folder
56
-	 * @return bool|\OCP\IImage false if no preview was generated
57
-	 * @since 8.1.0
58
-	 */
59
-	public function getThumbnail($path, $maxX, $maxY, $scalingup, $fileview);
48
+    /**
49
+     * get thumbnail for file at path $path
50
+     *
51
+     * @param string $path Path of file
52
+     * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
53
+     * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
54
+     * @param bool $scalingup Disable/Enable upscaling of previews
55
+     * @param \OC\Files\View $fileview fileview object of user folder
56
+     * @return bool|\OCP\IImage false if no preview was generated
57
+     * @since 8.1.0
58
+     */
59
+    public function getThumbnail($path, $maxX, $maxY, $scalingup, $fileview);
60 60
 }
Please login to merge, or discard this patch.
lib/public/Preview/IProviderV2.php 1 patch
Indentation   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -29,29 +29,29 @@
 block discarded – undo
29 29
  * @since 17.0.0
30 30
  */
31 31
 interface IProviderV2 {
32
-	/**
33
-	 * @return string Regex with the mimetypes that are supported by this provider
34
-	 * @since 17.0.0
35
-	 */
36
-	public function getMimeType(): string;
32
+    /**
33
+     * @return string Regex with the mimetypes that are supported by this provider
34
+     * @since 17.0.0
35
+     */
36
+    public function getMimeType(): string;
37 37
 
38
-	/**
39
-	 * Check if a preview can be generated for $path
40
-	 *
41
-	 * @param FileInfo $file
42
-	 * @return bool
43
-	 * @since 17.0.0
44
-	 */
45
-	public function isAvailable(FileInfo $file): bool;
38
+    /**
39
+     * Check if a preview can be generated for $path
40
+     *
41
+     * @param FileInfo $file
42
+     * @return bool
43
+     * @since 17.0.0
44
+     */
45
+    public function isAvailable(FileInfo $file): bool;
46 46
 
47
-	/**
48
-	 * get thumbnail for file at path $path
49
-	 *
50
-	 * @param File $file
51
-	 * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
52
-	 * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
53
-	 * @return null|\OCP\IImage null if no preview was generated
54
-	 * @since 17.0.0
55
-	 */
56
-	public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage;
47
+    /**
48
+     * get thumbnail for file at path $path
49
+     *
50
+     * @param File $file
51
+     * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
52
+     * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
53
+     * @return null|\OCP\IImage null if no preview was generated
54
+     * @since 17.0.0
55
+     */
56
+    public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage;
57 57
 }
Please login to merge, or discard this patch.
lib/private/Preview/MSOfficeDoc.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,10 +23,10 @@
 block discarded – undo
23 23
 
24 24
 //.doc, .dot
25 25
 class MSOfficeDoc extends Office {
26
-	/**
27
-	 * {@inheritDoc}
28
-	 */
29
-	public function getMimeType(): string {
30
-		return '/application\/msword/';
31
-	}
26
+    /**
27
+     * {@inheritDoc}
28
+     */
29
+    public function getMimeType(): string {
30
+        return '/application\/msword/';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
lib/private/Preview/ProviderV2.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	/**
44 44
 	 * @return string Regex with the mimetypes that are supported by this provider
45 45
 	 */
46
-	abstract public function getMimeType(): string ;
46
+	abstract public function getMimeType(): string;
47 47
 
48 48
 	/**
49 49
 	 * Check if a preview can be generated for $path
Please login to merge, or discard this patch.
Indentation   +85 added lines, -85 removed lines patch added patch discarded remove patch
@@ -31,89 +31,89 @@
 block discarded – undo
31 31
 use OCP\Preview\IProviderV2;
32 32
 
33 33
 abstract class ProviderV2 implements IProviderV2 {
34
-	/** @var array */
35
-	protected $options;
36
-
37
-	/** @var array */
38
-	protected $tmpFiles = [];
39
-
40
-	/**
41
-	 * Constructor
42
-	 *
43
-	 * @param array $options
44
-	 */
45
-	public function __construct(array $options = []) {
46
-		$this->options = $options;
47
-	}
48
-
49
-	/**
50
-	 * @return string Regex with the mimetypes that are supported by this provider
51
-	 */
52
-	abstract public function getMimeType(): string ;
53
-
54
-	/**
55
-	 * Check if a preview can be generated for $path
56
-	 *
57
-	 * @param FileInfo $file
58
-	 * @return bool
59
-	 */
60
-	public function isAvailable(FileInfo $file): bool {
61
-		return true;
62
-	}
63
-
64
-	/**
65
-	 * get thumbnail for file at path $path
66
-	 *
67
-	 * @param File $file
68
-	 * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
69
-	 * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
70
-	 * @return null|\OCP\IImage false if no preview was generated
71
-	 * @since 17.0.0
72
-	 */
73
-	abstract public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage;
74
-
75
-	protected function useTempFile(File $file): bool {
76
-		return $file->isEncrypted() || !$file->getStorage()->isLocal();
77
-	}
78
-
79
-	/**
80
-	 * Get a path to either the local file or temporary file
81
-	 *
82
-	 * @param File $file
83
-	 * @param int $maxSize maximum size for temporary files
84
-	 * @return string|false
85
-	 */
86
-	protected function getLocalFile(File $file, int $maxSize = null) {
87
-		if ($this->useTempFile($file)) {
88
-			$absPath = \OC::$server->getTempManager()->getTemporaryFile();
89
-
90
-			$content = $file->fopen('r');
91
-
92
-			if ($maxSize) {
93
-				$content = stream_get_contents($content, $maxSize);
94
-			}
95
-
96
-			file_put_contents($absPath, $content);
97
-			$this->tmpFiles[] = $absPath;
98
-			return $absPath;
99
-		} else {
100
-			$path = $file->getStorage()->getLocalFile($file->getInternalPath());
101
-			if (is_string($path)) {
102
-				return $path;
103
-			} else {
104
-				return false;
105
-			}
106
-		}
107
-	}
108
-
109
-	/**
110
-	 * Clean any generated temporary files
111
-	 */
112
-	protected function cleanTmpFiles(): void {
113
-		foreach ($this->tmpFiles as $tmpFile) {
114
-			unlink($tmpFile);
115
-		}
116
-
117
-		$this->tmpFiles = [];
118
-	}
34
+    /** @var array */
35
+    protected $options;
36
+
37
+    /** @var array */
38
+    protected $tmpFiles = [];
39
+
40
+    /**
41
+     * Constructor
42
+     *
43
+     * @param array $options
44
+     */
45
+    public function __construct(array $options = []) {
46
+        $this->options = $options;
47
+    }
48
+
49
+    /**
50
+     * @return string Regex with the mimetypes that are supported by this provider
51
+     */
52
+    abstract public function getMimeType(): string ;
53
+
54
+    /**
55
+     * Check if a preview can be generated for $path
56
+     *
57
+     * @param FileInfo $file
58
+     * @return bool
59
+     */
60
+    public function isAvailable(FileInfo $file): bool {
61
+        return true;
62
+    }
63
+
64
+    /**
65
+     * get thumbnail for file at path $path
66
+     *
67
+     * @param File $file
68
+     * @param int $maxX The maximum X size of the thumbnail. It can be smaller depending on the shape of the image
69
+     * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
70
+     * @return null|\OCP\IImage false if no preview was generated
71
+     * @since 17.0.0
72
+     */
73
+    abstract public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage;
74
+
75
+    protected function useTempFile(File $file): bool {
76
+        return $file->isEncrypted() || !$file->getStorage()->isLocal();
77
+    }
78
+
79
+    /**
80
+     * Get a path to either the local file or temporary file
81
+     *
82
+     * @param File $file
83
+     * @param int $maxSize maximum size for temporary files
84
+     * @return string|false
85
+     */
86
+    protected function getLocalFile(File $file, int $maxSize = null) {
87
+        if ($this->useTempFile($file)) {
88
+            $absPath = \OC::$server->getTempManager()->getTemporaryFile();
89
+
90
+            $content = $file->fopen('r');
91
+
92
+            if ($maxSize) {
93
+                $content = stream_get_contents($content, $maxSize);
94
+            }
95
+
96
+            file_put_contents($absPath, $content);
97
+            $this->tmpFiles[] = $absPath;
98
+            return $absPath;
99
+        } else {
100
+            $path = $file->getStorage()->getLocalFile($file->getInternalPath());
101
+            if (is_string($path)) {
102
+                return $path;
103
+            } else {
104
+                return false;
105
+            }
106
+        }
107
+    }
108
+
109
+    /**
110
+     * Clean any generated temporary files
111
+     */
112
+    protected function cleanTmpFiles(): void {
113
+        foreach ($this->tmpFiles as $tmpFile) {
114
+            unlink($tmpFile);
115
+        }
116
+
117
+        $this->tmpFiles = [];
118
+    }
119 119
 }
Please login to merge, or discard this patch.