Passed
Push — master ( 54baf6...11341e )
by Roeland
25:32 queued 13:18
created
lib/private/Memcache/Redis.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 	}
52 52
 
53 53
 	public function get($key) {
54
-		$result = self::$cache->get($this->getNameSpace() . $key);
55
-		if ($result === false && !self::$cache->exists($this->getNameSpace() . $key)) {
54
+		$result = self::$cache->get($this->getNameSpace().$key);
55
+		if ($result === false && !self::$cache->exists($this->getNameSpace().$key)) {
56 56
 			return null;
57 57
 		} else {
58 58
 			return json_decode($result, true);
@@ -61,18 +61,18 @@  discard block
 block discarded – undo
61 61
 
62 62
 	public function set($key, $value, $ttl = 0) {
63 63
 		if ($ttl > 0) {
64
-			return self::$cache->setex($this->getNameSpace() . $key, $ttl, json_encode($value));
64
+			return self::$cache->setex($this->getNameSpace().$key, $ttl, json_encode($value));
65 65
 		} else {
66
-			return self::$cache->set($this->getNameSpace() . $key, json_encode($value));
66
+			return self::$cache->set($this->getNameSpace().$key, json_encode($value));
67 67
 		}
68 68
 	}
69 69
 
70 70
 	public function hasKey($key) {
71
-		return self::$cache->exists($this->getNameSpace() . $key);
71
+		return self::$cache->exists($this->getNameSpace().$key);
72 72
 	}
73 73
 
74 74
 	public function remove($key) {
75
-		if (self::$cache->del($this->getNameSpace() . $key)) {
75
+		if (self::$cache->del($this->getNameSpace().$key)) {
76 76
 			return true;
77 77
 		} else {
78 78
 			return false;
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	}
81 81
 
82 82
 	public function clear($prefix = '') {
83
-		$prefix = $this->getNameSpace() . $prefix . '*';
83
+		$prefix = $this->getNameSpace().$prefix.'*';
84 84
 		$keys = self::$cache->keys($prefix);
85 85
 		$deleted = self::$cache->del($keys);
86 86
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 		if (!is_int($value)) {
101 101
 			$value = json_encode($value);
102 102
 		}
103
-		return self::$cache->setnx($this->getPrefix() . $key, $value);
103
+		return self::$cache->setnx($this->getPrefix().$key, $value);
104 104
 	}
105 105
 
106 106
 	/**
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * @return int | bool
112 112
 	 */
113 113
 	public function inc($key, $step = 1) {
114
-		return self::$cache->incrBy($this->getNameSpace() . $key, $step);
114
+		return self::$cache->incrBy($this->getNameSpace().$key, $step);
115 115
 	}
116 116
 
117 117
 	/**
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		if (!$this->hasKey($key)) {
126 126
 			return false;
127 127
 		}
128
-		return self::$cache->decrBy($this->getNameSpace() . $key, $step);
128
+		return self::$cache->decrBy($this->getNameSpace().$key, $step);
129 129
 	}
130 130
 
131 131
 	/**
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
 		if (!is_int($new)) {
141 141
 			$new = json_encode($new);
142 142
 		}
143
-		self::$cache->watch($this->getNameSpace() . $key);
143
+		self::$cache->watch($this->getNameSpace().$key);
144 144
 		if ($this->get($key) === $old) {
145 145
 			$result = self::$cache->multi()
146
-				->set($this->getNameSpace() . $key, $new)
146
+				->set($this->getNameSpace().$key, $new)
147 147
 				->exec();
148 148
 			return $result !== false;
149 149
 		}
@@ -159,10 +159,10 @@  discard block
 block discarded – undo
159 159
 	 * @return bool
160 160
 	 */
161 161
 	public function cad($key, $old) {
162
-		self::$cache->watch($this->getNameSpace() . $key);
162
+		self::$cache->watch($this->getNameSpace().$key);
163 163
 		if ($this->get($key) === $old) {
164 164
 			$result = self::$cache->multi()
165
-				->del($this->getNameSpace() . $key)
165
+				->del($this->getNameSpace().$key)
166 166
 				->exec();
167 167
 			return $result !== false;
168 168
 		}
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	}
172 172
 
173 173
 	public function setTTL($key, $ttl) {
174
-		self::$cache->expire($this->getNameSpace() . $key, $ttl);
174
+		self::$cache->expire($this->getNameSpace().$key, $ttl);
175 175
 	}
176 176
 
177 177
 	static public function isAvailable() {
Please login to merge, or discard this patch.
apps/files/lib/App.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	public static function extendJsConfig($settings) {
58 58
 		$appConfig = json_decode($settings['array']['oc_appconfig'], true);
59 59
 
60
-		$maxChunkSize = (int)\OC::$server->getConfig()->getAppValue('files', 'max_chunk_size', 10 * 1024 * 1024);
60
+		$maxChunkSize = (int) \OC::$server->getConfig()->getAppValue('files', 'max_chunk_size', 10 * 1024 * 1024);
61 61
 		$appConfig['files'] = [
62 62
 			'max_chunk_size' => $maxChunkSize
63 63
 		];
Please login to merge, or discard this patch.
apps/user_ldap/lib/Group_Proxy.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -37,10 +37,10 @@  discard block
 block discarded – undo
37 37
 	 */
38 38
 	public function __construct($serverConfigPrefixes, ILDAPWrapper $ldap, GroupPluginManager $groupPluginManager) {
39 39
 		parent::__construct($ldap);
40
-		foreach($serverConfigPrefixes as $configPrefix) {
40
+		foreach ($serverConfigPrefixes as $configPrefix) {
41 41
 			$this->backends[$configPrefix] =
42 42
 				new \OCA\User_LDAP\Group_LDAP($this->getAccess($configPrefix), $groupPluginManager);
43
-			if(is_null($this->refBackend)) {
43
+			if (is_null($this->refBackend)) {
44 44
 				$this->refBackend = &$this->backends[$configPrefix];
45 45
 			}
46 46
 		}
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 	 */
56 56
 	protected function walkBackends($gid, $method, $parameters) {
57 57
 		$cacheKey = $this->getGroupCacheKey($gid);
58
-		foreach($this->backends as $configPrefix => $backend) {
59
-			if($result = call_user_func_array(array($backend, $method), $parameters)) {
58
+		foreach ($this->backends as $configPrefix => $backend) {
59
+			if ($result = call_user_func_array(array($backend, $method), $parameters)) {
60 60
 				$this->writeToCache($cacheKey, $configPrefix);
61 61
 				return $result;
62 62
 			}
@@ -76,17 +76,17 @@  discard block
 block discarded – undo
76 76
 		$cacheKey = $this->getGroupCacheKey($gid);
77 77
 		$prefix = $this->getFromCache($cacheKey);
78 78
 		//in case the uid has been found in the past, try this stored connection first
79
-		if(!is_null($prefix)) {
80
-			if(isset($this->backends[$prefix])) {
79
+		if (!is_null($prefix)) {
80
+			if (isset($this->backends[$prefix])) {
81 81
 				$result = call_user_func_array(array($this->backends[$prefix], $method), $parameters);
82
-				if($result === $passOnWhen) {
82
+				if ($result === $passOnWhen) {
83 83
 					//not found here, reset cache to null if group vanished
84 84
 					//because sometimes methods return false with a reason
85 85
 					$groupExists = call_user_func_array(
86 86
 						array($this->backends[$prefix], 'groupExists'),
87 87
 						array($gid)
88 88
 					);
89
-					if(!$groupExists) {
89
+					if (!$groupExists) {
90 90
 						$this->writeToCache($cacheKey, null);
91 91
 					}
92 92
 				}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	public function getUserGroups($uid) {
120 120
 		$groups = array();
121 121
 
122
-		foreach($this->backends as $backend) {
122
+		foreach ($this->backends as $backend) {
123 123
 			$backendGroups = $backend->getUserGroups($uid);
124 124
 			if (is_array($backendGroups)) {
125 125
 				$groups = array_merge($groups, $backendGroups);
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) {
137 137
 		$users = array();
138 138
 
139
-		foreach($this->backends as $backend) {
139
+		foreach ($this->backends as $backend) {
140 140
 			$backendUsers = $backend->usersInGroup($gid, $search, $limit, $offset);
141 141
 			if (is_array($backendUsers)) {
142 142
 				$users = array_merge($users, $backendUsers);
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	public function getGroups($search = '', $limit = -1, $offset = 0) {
222 222
 		$groups = array();
223 223
 
224
-		foreach($this->backends as $backend) {
224
+		foreach ($this->backends as $backend) {
225 225
 			$backendGroups = $backend->getGroups($search, $limit, $offset);
226 226
 			if (is_array($backendGroups)) {
227 227
 				$groups = array_merge($groups, $backendGroups);
Please login to merge, or discard this patch.
lib/private/DB/SQLiteSessionInit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@
 block discarded – undo
56 56
 	 */
57 57
 	public function postConnect(ConnectionEventArgs $args) {
58 58
 		$sensitive = $this->caseSensitiveLike ? 'true' : 'false';
59
-		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
60
-		$args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
59
+		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = '.$sensitive);
60
+		$args->getConnection()->executeUpdate('PRAGMA journal_mode = '.$this->journalMode);
61 61
 		/** @var \PDO $pdo */
62 62
 		$pdo = $args->getConnection()->getWrappedConnection();
63 63
 		$pdo->sqliteCreateFunction('md5', 'md5', 1);
Please login to merge, or discard this patch.
lib/private/Share/Helper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -93,14 +93,14 @@  discard block
 block discarded – undo
93 93
 			$params = array();
94 94
 			if (count($ids) == 1 && isset($uidOwner)) {
95 95
 				// FIXME: don't concat $parents, use Docrine's PARAM_INT_ARRAY approach
96
-				$queryString = 'SELECT `id`, `share_with`, `item_type`, `share_type`, ' .
97
-					'`item_target`, `file_target`, `parent` ' .
98
-					'FROM `*PREFIX*share` ' .
96
+				$queryString = 'SELECT `id`, `share_with`, `item_type`, `share_type`, '.
97
+					'`item_target`, `file_target`, `parent` '.
98
+					'FROM `*PREFIX*share` '.
99 99
 					'WHERE `parent` IN ('.$parents.') AND `uid_owner` = ? ';
100 100
 				$params[] = $uidOwner;
101 101
 			} else {
102
-				$queryString = 'SELECT `id`, `share_with`, `item_type`, `share_type`, ' .
103
-					'`item_target`, `file_target`, `parent`, `uid_owner` ' .
102
+				$queryString = 'SELECT `id`, `share_with`, `item_type`, `share_type`, '.
103
+					'`item_target`, `file_target`, `parent`, `uid_owner` '.
104 104
 					'FROM `*PREFIX*share` WHERE `parent` IN ('.$parents.') ';
105 105
 			}
106 106
 			if ($excludeGroupChildren) {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 					'shareWith' => $item['share_with'],
118 118
 					'itemTarget' => $item['item_target'],
119 119
 					'itemType' => $item['item_type'],
120
-					'shareType' => (int)$item['share_type'],
120
+					'shareType' => (int) $item['share_type'],
121 121
 				);
122 122
 				if (isset($item['file_target'])) {
123 123
 					$tmpItem['fileTarget'] = $item['file_target'];
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 		if ($defaultExpireDate === 'yes') {
169 169
 			$enforceExpireDate = $config->getAppValue('core', 'shareapi_enforce_expire_date', 'no');
170 170
 			$defaultExpireSettings['defaultExpireDateSet'] = true;
171
-			$defaultExpireSettings['expireAfterDays'] = (int)$config->getAppValue('core', 'shareapi_expire_after_n_days', '7');
171
+			$defaultExpireSettings['expireAfterDays'] = (int) $config->getAppValue('core', 'shareapi_expire_after_n_days', '7');
172 172
 			$defaultExpireSettings['enforceExpireDate'] = $enforceExpireDate === 'yes';
173 173
 		}
174 174
 
Please login to merge, or discard this patch.
lib/public/Settings/IManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	/**
37 37
 	 * @since 9.1.0
38 38
 	 */
39
-	const KEY_ADMIN_SECTION  = 'admin-section';
39
+	const KEY_ADMIN_SECTION = 'admin-section';
40 40
 
41 41
 	/**
42 42
 	 * @since 13.0.0
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	/**
47 47
 	 * @since 13.0.0
48 48
 	 */
49
-	const KEY_PERSONAL_SECTION  = 'personal-section';
49
+	const KEY_PERSONAL_SECTION = 'personal-section';
50 50
 
51 51
 	/**
52 52
 	 * @param string $type 'admin' or 'personal'
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Template/SimpleMenuAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
 	 * @since 14.0.0
165 165
 	 */
166 166
 	public function render(): string {
167
-		$detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">(' . Util::sanitizeHTML($this->detail) . ')</span>' : '';
167
+		$detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">('.Util::sanitizeHTML($this->detail).')</span>' : '';
168 168
 		return sprintf(
169 169
 			'<li id="%s"><a href="%s"><span class="icon %s"></span>%s %s</a></li>',
170 170
 			Util::sanitizeHTML($this->id), Util::sanitizeHTML($this->link), Util::sanitizeHTML($this->icon), Util::sanitizeHTML($this->label), $detailContent
Please login to merge, or discard this patch.
lib/private/Collaboration/Collaborators/GroupPlugin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,17 +57,17 @@
 block discarded – undo
57 57
 		$result = ['wide' => [], 'exact' => []];
58 58
 
59 59
 		$groups = $this->groupManager->search($search, $limit, $offset);
60
-		$groupIds = array_map(function (IGroup $group) { return $group->getGID(); }, $groups);
60
+		$groupIds = array_map(function(IGroup $group) { return $group->getGID(); }, $groups);
61 61
 
62 62
 		if (!$this->shareeEnumeration || count($groups) < $limit) {
63 63
 			$hasMoreResults = true;
64 64
 		}
65 65
 
66
-		$userGroups =  [];
66
+		$userGroups = [];
67 67
 		if (!empty($groups) && $this->shareWithGroupOnly) {
68 68
 			// Intersect all the groups that match with the groups this user is a member of
69 69
 			$userGroups = $this->groupManager->getUserGroups($this->userSession->getUser());
70
-			$userGroups = array_map(function (IGroup $group) { return $group->getGID(); }, $userGroups);
70
+			$userGroups = array_map(function(IGroup $group) { return $group->getGID(); }, $userGroups);
71 71
 			$groupIds = array_intersect($groupIds, $userGroups);
72 72
 		}
73 73
 
Please login to merge, or discard this patch.
core/Command/Config/System/DeleteConfig.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
 		if (count($configNames) > 1) {
68 68
 			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
69
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
69
+				$output->writeln('<error>System config '.implode(' => ', $configNames).' could not be deleted because it did not exist</error>');
70 70
 				return 1;
71 71
 			}
72 72
 
@@ -76,21 +76,21 @@  discard block
 block discarded – undo
76 76
 				$value = $this->removeSubValue(array_slice($configNames, 1), $value, $input->hasParameterOption('--error-if-not-exists'));
77 77
 			}
78 78
 			catch (\UnexpectedValueException $e) {
79
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
79
+				$output->writeln('<error>System config '.implode(' => ', $configNames).' could not be deleted because it did not exist</error>');
80 80
 				return 1;
81 81
 			}
82 82
 
83 83
 			$this->systemConfig->setValue($configName, $value);
84
-			$output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' deleted</info>');
84
+			$output->writeln('<info>System config value '.implode(' => ', $configNames).' deleted</info>');
85 85
 			return 0;
86 86
 		} else {
87 87
 			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
88
-				$output->writeln('<error>System config ' . $configName . ' could not be deleted because it did not exist</error>');
88
+				$output->writeln('<error>System config '.$configName.' could not be deleted because it did not exist</error>');
89 89
 				return 1;
90 90
 			}
91 91
 
92 92
 			$this->systemConfig->deleteValue($configName);
93
-			$output->writeln('<info>System config value ' . $configName . ' deleted</info>');
93
+			$output->writeln('<info>System config value '.$configName.' deleted</info>');
94 94
 			return 0;
95 95
 		}
96 96
 	}
Please login to merge, or discard this patch.