nextcloud / server

apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php

Doc Comments +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
 	 * share received from another server
 	 *
 	 * @param ICloudFederationShare $share
-	 * @return string provider specific unique ID of the share
+	 * @return integer provider specific unique ID of the share
 	 *
 	 * @throws ProviderCouldNotAddShareException
 	 * @throws \OCP\AppFramework\QueryException

lib/private/Share20/ProviderFactory.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OCA\FederatedFileSharing\AddressHandler;
 use OCA\FederatedFileSharing\FederatedShareProvider;
 use OCA\FederatedFileSharing\Notifications;
-use OCA\FederatedFileSharing\OCM\CloudFederationProvider;
 use OCA\FederatedFileSharing\TokenHandler;
 use OCA\ShareByMail\Settings\SettingsManager;
 use OCA\ShareByMail\ShareByMailProvider;

apps/federatedfilesharing/lib/Notifications.php

Doc Comments +7 added lines, -3 removed lines

@@ -156,7 +156,7 @@ 
 	 * @param string $remote url
 	 * @param int $id share id
 	 * @param string $token
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendRemoteUnShare($remote, $id, $token) {
 		$this->sendUpdateToRemote($remote, $id, $token, 'unshare');
@@ -168,7 +168,7 @@ 
 	 * @param string $remote url
 	 * @param int $id share id
 	 * @param string $token
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendRevokeShare($remote, $id, $token) {
 		$this->sendUpdateToRemote($remote, $id, $token, 'revoke');
@@ -181,7 +181,7 @@ 
 	 * @param int $remoteId
 	 * @param string $token
 	 * @param int $permissions
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendPermissionChange($remote, $remoteId, $token, $permissions) {
 		$this->sendUpdateToRemote($remote, $remoteId, $token, 'permissions', ['permissions' => $permissions]);
@@ -342,6 +342,10 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $remoteDomain
+	 * @param string $urlSuffix
+	 */
 	protected function sendNotificationToOCMEndPoint($remoteDomain, $urlSuffix, $fields) {
 		$client = $this->httpClientService->newClient();
 		switch ($urlSuffix) {

lib/private/Federation/CloudFederationProviderManager.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 namespace OC\Federation;
 
 use OCP\App\IAppManager;
-use OCP\Federation\Exceptions\ProviderAlreadyExistsException;
 use OCP\Federation\Exceptions\ProviderDoesNotExistsException;
 use OCP\Federation\ICloudFederationNotification;
 use OCP\Federation\ICloudFederationProvider;