Completed
Pull Request — master (#9345)
by Björn
41:51 queued 19:17
created
lib/private/User/Manager.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	public function __construct(IConfig $config) {
78 78
 		$this->config = $config;
79 79
 		$cachedUsers = &$this->cachedUsers;
80
-		$this->listen('\OC\User', 'postDelete', function ($user) use (&$cachedUsers) {
80
+		$this->listen('\OC\User', 'postDelete', function($user) use (&$cachedUsers) {
81 81
 			/** @var \OC\User\User $user */
82 82
 			unset($cachedUsers[$user->getUID()]);
83 83
 		});
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 		$result = $this->checkPasswordNoLogging($loginName, $password);
194 194
 
195 195
 		if ($result === false) {
196
-			\OC::$server->getLogger()->warning('Login failed: \''. $loginName .'\' (Remote IP: \''. \OC::$server->getRequest()->getRemoteAddress(). '\')', ['app' => 'core']);
196
+			\OC::$server->getLogger()->warning('Login failed: \''.$loginName.'\' (Remote IP: \''.\OC::$server->getRequest()->getRemoteAddress().'\')', ['app' => 'core']);
197 197
 		}
198 198
 
199 199
 		return $result;
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 			}
243 243
 		}
244 244
 
245
-		uasort($users, function ($a, $b) {
245
+		uasort($users, function($a, $b) {
246 246
 			/**
247 247
 			 * @var \OC\User\User $a
248 248
 			 * @var \OC\User\User $b
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 			}
272 272
 		}
273 273
 
274
-		usort($users, function ($a, $b) {
274
+		usort($users, function($a, $b) {
275 275
 			/**
276 276
 			 * @var \OC\User\User $a
277 277
 			 * @var \OC\User\User $b
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
 		$this->emit('\OC\User', 'preCreateUser', [$uid, $password]);
352 352
 		$state = $backend->createUser($uid, $password);
353
-		if($state === false) {
353
+		if ($state === false) {
354 354
 			throw new \InvalidArgumentException($l->t('Could not create user'));
355 355
 		}
356 356
 		$user = $this->getUserObject($uid, $backend);
@@ -376,13 +376,13 @@  discard block
 block discarded – undo
376 376
 		foreach ($this->backends as $backend) {
377 377
 			if ($backend->implementsActions(Backend::COUNT_USERS)) {
378 378
 				$backendUsers = $backend->countUsers();
379
-				if($backendUsers !== false) {
380
-					if($backend instanceof IUserBackend) {
379
+				if ($backendUsers !== false) {
380
+					if ($backend instanceof IUserBackend) {
381 381
 						$name = $backend->getBackendName();
382 382
 					} else {
383 383
 						$name = get_class($backend);
384 384
 					}
385
-					if(isset($userCountStatistics[$name])) {
385
+					if (isset($userCountStatistics[$name])) {
386 386
 						$userCountStatistics[$name] += $backendUsers;
387 387
 					} else {
388 388
 						$userCountStatistics[$name] = $backendUsers;
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
 
445 445
 		$query = $queryBuilder->execute();
446 446
 
447
-		$result = (int)$query->fetchColumn();
447
+		$result = (int) $query->fetchColumn();
448 448
 		$query->closeCursor();
449 449
 
450 450
 		return $result;
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
 
467 467
 		$query = $queryBuilder->execute();
468 468
 
469
-		$result = (int)$query->fetchColumn();
469
+		$result = (int) $query->fetchColumn();
470 470
 		$query->closeCursor();
471 471
 
472 472
 		return $result;
Please login to merge, or discard this patch.
core/Controller/LostController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	protected function checkPasswordResetToken($token, $userId) {
169 169
 		$user = $this->userManager->get($userId);
170
-		if($user === null || !$user->isEnabled()) {
170
+		if ($user === null || !$user->isEnabled()) {
171 171
 			throw new \Exception($this->l10n->t('Couldn\'t reset password because the token is invalid'));
172 172
 		}
173 173
 
@@ -180,11 +180,11 @@  discard block
 block discarded – undo
180 180
 		}
181 181
 
182 182
 		$splittedToken = explode(':', $decryptedToken);
183
-		if(count($splittedToken) !== 2) {
183
+		if (count($splittedToken) !== 2) {
184 184
 			throw new \Exception($this->l10n->t('Couldn\'t reset password because the token is invalid'));
185 185
 		}
186 186
 
187
-		if ($splittedToken[0] < ($this->timeFactory->getTime() - 60*60*12) ||
187
+		if ($splittedToken[0] < ($this->timeFactory->getTime() - 60 * 60 * 12) ||
188 188
 			$user->getLastLogin() > $splittedToken[0]) {
189 189
 			throw new \Exception($this->l10n->t('Couldn\'t reset password because the token is expired'));
190 190
 		}
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 	 * @param array $additional
200 200
 	 * @return array
201 201
 	 */
202
-	private function error($message, array $additional=array()) {
202
+	private function error($message, array $additional = array()) {
203 203
 		return array_merge(array('status' => 'error', 'msg' => $message), $additional);
204 204
 	}
205 205
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 	 * @param string $user
219 219
 	 * @return JSONResponse
220 220
 	 */
221
-	public function email($user){
221
+	public function email($user) {
222 222
 		if ($this->config->getSystemValue('lost_password_link', '') !== '') {
223 223
 			return new JSONResponse($this->error($this->l10n->t('Password reset is disabled')));
224 224
 		}
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 		// FIXME: use HTTP error codes
227 227
 		try {
228 228
 			$this->sendEmail($user);
229
-		} catch (\Exception $e){
229
+		} catch (\Exception $e) {
230 230
 			$response = new JSONResponse($this->error($e->getMessage()));
231 231
 			$response->throttle();
232 232
 			return $response;
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 
269 269
 			$this->config->deleteUserValue($userId, 'core', 'lostpassword');
270 270
 			@\OC::$server->getUserSession()->unsetMagicInCookie();
271
-		} catch (\Exception $e){
271
+		} catch (\Exception $e) {
272 272
 			return $this->error($e->getMessage());
273 273
 		}
274 274
 
@@ -299,8 +299,8 @@  discard block
 block discarded – undo
299 299
 			ISecureRandom::CHAR_LOWER.
300 300
 			ISecureRandom::CHAR_UPPER
301 301
 		);
302
-		$tokenValue = $this->timeFactory->getTime() .':'. $token;
303
-		$encryptedValue = $this->crypto->encrypt($tokenValue, $email . $this->config->getSystemValue('secret'));
302
+		$tokenValue = $this->timeFactory->getTime().':'.$token;
303
+		$encryptedValue = $this->crypto->encrypt($tokenValue, $email.$this->config->getSystemValue('secret'));
304 304
 		$this->config->setUserValue($user->getUID(), 'core', 'lostpassword', $encryptedValue);
305 305
 
306 306
 		$link = $this->urlGenerator->linkToRouteAbsolute('core.lost.resetform', array('userId' => $user->getUID(), 'token' => $token));
Please login to merge, or discard this patch.
apps/encryption/templates/settings-admin.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -7,17 +7,17 @@  discard block
 block discarded – undo
7 7
 ?>
8 8
 <form id="ocDefaultEncryptionModule" class="sub-section">
9 9
 	<h3><?php p($l->t("Default encryption module")); ?></h3>
10
-	<?php if(!$_["initStatus"] && $_['masterKeyEnabled'] === false): ?>
10
+	<?php if (!$_["initStatus"] && $_['masterKeyEnabled'] === false): ?>
11 11
 		<?php p($l->t("Encryption app is enabled but your keys are not initialized, please log-out and log-in again")); ?>
12 12
 	<?php else: ?>
13 13
 		<p id="encryptHomeStorageSetting">
14 14
 			<input type="checkbox" class="checkbox" name="encrypt_home_storage" id="encryptHomeStorage"
15 15
 				   value="1" <?php if ($_['encryptHomeStorage']) print_unescaped('checked="checked"'); ?> />
16
-			<label for="encryptHomeStorage"><?php p($l->t('Encrypt the home storage'));?></label></br>
17
-			<em><?php p( $l->t( "Enabling this option encrypts all files stored on the main storage, otherwise only files on external storage will be encrypted" ) ); ?></em>
16
+			<label for="encryptHomeStorage"><?php p($l->t('Encrypt the home storage')); ?></label></br>
17
+			<em><?php p($l->t("Enabling this option encrypts all files stored on the main storage, otherwise only files on external storage will be encrypted")); ?></em>
18 18
 		</p>
19 19
 		<br />
20
-		<?php if($_['masterKeyEnabled'] === false): ?>
20
+		<?php if ($_['masterKeyEnabled'] === false): ?>
21 21
 			<p id="encryptionSetRecoveryKey">
22 22
 				<?php $_["recoveryEnabled"] === '0' ?  p($l->t("Enable recovery key")) : p($l->t("Disable recovery key")); ?>
23 23
 				<span class="msg"></span>
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 			</p>
43 43
 			<br/><br/>
44 44
 
45
-			<p name="changeRecoveryPasswordBlock" id="encryptionChangeRecoveryKey" <?php if($_['recoveryEnabled'] === '0') print_unescaped('class="hidden"');?>>
45
+			<p name="changeRecoveryPasswordBlock" id="encryptionChangeRecoveryKey" <?php if ($_['recoveryEnabled'] === '0') print_unescaped('class="hidden"'); ?>>
46 46
 				<?php p($l->t("Change recovery key password:")); ?>
47 47
 				<span class="msg"></span>
48 48
 				<br/>
Please login to merge, or discard this patch.
lib/private/Files/Config/CachedMountFileInfo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,6 +43,6 @@
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	public function getPath() {
46
-		return $this->getMountPoint() . $this->getInternalPath();
46
+		return $this->getMountPoint().$this->getInternalPath();
47 47
 	}
48 48
 }
49 49
\ No newline at end of file
Please login to merge, or discard this patch.
core/Command/Maintenance/Mimetype/UpdateJS.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 		$keys = array_filter(array_keys($aliases), function($k) {
57 57
 			return $k[0] === '_';
58 58
 		});
59
-		foreach($keys as $key) {
59
+		foreach ($keys as $key) {
60 60
 			unset($aliases[$key]);
61 61
 		}
62 62
 
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		$dir = new \DirectoryIterator(\OC::$SERVERROOT.'/core/img/filetypes');
65 65
 
66 66
 		$files = [];
67
-		foreach($dir as $fileInfo) {
67
+		foreach ($dir as $fileInfo) {
68 68
 			if ($fileInfo->isFile()) {
69 69
 				$file = preg_replace('/.[^.]*$/', '', $fileInfo->getFilename());
70 70
 				$files[] = $file;
@@ -78,14 +78,14 @@  discard block
 block discarded – undo
78 78
 		// Fetch all themes!
79 79
 		$themes = [];
80 80
 		$dirs = new \DirectoryIterator(\OC::$SERVERROOT.'/themes/');
81
-		foreach($dirs as $dir) {
81
+		foreach ($dirs as $dir) {
82 82
 			//Valid theme dir
83 83
 			if ($dir->isFile() || $dir->isDot()) {
84 84
 				continue;
85 85
 			}
86 86
 
87 87
 			$theme = $dir->getFilename();
88
-			$themeDir = $dir->getPath() . '/' . $theme . '/core/img/filetypes/';
88
+			$themeDir = $dir->getPath().'/'.$theme.'/core/img/filetypes/';
89 89
 			// Check if this theme has its own filetype icons
90 90
 			if (!file_exists($themeDir)) {
91 91
 				continue;
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
 * To regenerate this file run ./occ maintenance:mimetype:update-js
117 117
 */
118 118
 OC.MimeTypeList={
119
-	aliases: ' . json_encode($aliases, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES) . ',
120
-	files: ' . json_encode($files, JSON_PRETTY_PRINT) . ',
121
-	themes: ' . json_encode($themes, JSON_PRETTY_PRINT) . '
119
+	aliases: ' . json_encode($aliases, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES).',
120
+	files: ' . json_encode($files, JSON_PRETTY_PRINT).',
121
+	themes: ' . json_encode($themes, JSON_PRETTY_PRINT).'
122 122
 };
123 123
 ';
124 124
 
Please login to merge, or discard this patch.
lib/private/Collaboration/Collaborators/LookupPlugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 		try {
55 55
 			$client = $this->clientService->newClient();
56 56
 			$response = $client->get(
57
-				$lookupServerUrl . '/users?search=' . urlencode($search),
57
+				$lookupServerUrl.'/users?search='.urlencode($search),
58 58
 				[
59 59
 					'timeout' => 10,
60 60
 					'connect_timeout' => 3,
Please login to merge, or discard this patch.
lib/private/Template/ResourceLocator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 				$this->doFind($resource);
76 76
 			} catch (ResourceNotFoundException $e) {
77 77
 				$resourceApp = substr($resource, 0, strpos($resource, '/'));
78
-				$this->logger->debug('Could not find resource file "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
78
+				$this->logger->debug('Could not find resource file "'.$e->getResourcePath().'"', ['app' => $resourceApp]);
79 79
 			}
80 80
 		}
81 81
 		if (!empty($this->theme)) {
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 					$this->doFindTheme($resource);
85 85
 				} catch (ResourceNotFoundException $e) {
86 86
 					$resourceApp = substr($resource, 0, strpos($resource, '/'));
87
-					$this->logger->debug('Could not find resource file in theme "' . $e->getResourcePath() . '"', ['app' => $resourceApp]);
87
+					$this->logger->debug('Could not find resource file in theme "'.$e->getResourcePath().'"', ['app' => $resourceApp]);
88 88
 				}
89 89
 			}
90 90
 		}
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 		}
186 186
 		$this->resources[] = array($root, $webRoot, $file);
187 187
 
188
-		if ($throw && !is_file($root . '/' . $file)) {
188
+		if ($throw && !is_file($root.'/'.$file)) {
189 189
 			throw new ResourceNotFoundException($file, $webRoot);
190 190
 		}
191 191
 	}
Please login to merge, or discard this patch.
lib/public/GroupInterface.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,15 +46,15 @@
 block discarded – undo
46 46
 	const CREATE_GROUP		= 0x00000001;
47 47
 	const DELETE_GROUP		= 0x00000010;
48 48
 	const ADD_TO_GROUP		= 0x00000100;
49
-	const REMOVE_FROM_GOUP	= 0x00001000; // oops
50
-	const REMOVE_FROM_GROUP	= 0x00001000;
49
+	const REMOVE_FROM_GOUP = 0x00001000; // oops
50
+	const REMOVE_FROM_GROUP = 0x00001000;
51 51
 	//OBSOLETE const GET_DISPLAYNAME	= 0x00010000;
52
-	const COUNT_USERS		= 0x00100000;
53
-	const GROUP_DETAILS		= 0x01000000;
52
+	const COUNT_USERS = 0x00100000;
53
+	const GROUP_DETAILS = 0x01000000;
54 54
 	/**
55 55
 	 * @since 13.0.0
56 56
 	 */
57
-	const IS_ADMIN  = 0x10000000;
57
+	const IS_ADMIN = 0x10000000;
58 58
 
59 59
 	/**
60 60
 	 * Check if backend implements actions
Please login to merge, or discard this patch.
lib/private/Setup/OCI.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -71,18 +71,18 @@
 block discarded – undo
71 71
 			$errorMessage = $this->getLastError();
72 72
 			if ($errorMessage) {
73 73
 				throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
74
-					$errorMessage . ' Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
75
-					. ' ORACLE_SID=' . getenv('ORACLE_SID')
76
-					. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
77
-					. ' NLS_LANG=' . getenv('NLS_LANG')
78
-					. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
74
+					$errorMessage.' Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
75
+					. ' ORACLE_SID='.getenv('ORACLE_SID')
76
+					. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
77
+					. ' NLS_LANG='.getenv('NLS_LANG')
78
+					. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable');
79 79
 			}
80 80
 			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
81
-				'Check environment: ORACLE_HOME=' . getenv('ORACLE_HOME')
82
-				. ' ORACLE_SID=' . getenv('ORACLE_SID')
83
-				. ' LD_LIBRARY_PATH=' . getenv('LD_LIBRARY_PATH')
84
-				. ' NLS_LANG=' . getenv('NLS_LANG')
85
-				. ' tnsnames.ora is ' . (is_readable(getenv('ORACLE_HOME') . '/network/admin/tnsnames.ora') ? '' : 'not ') . 'readable');
81
+				'Check environment: ORACLE_HOME='.getenv('ORACLE_HOME')
82
+				. ' ORACLE_SID='.getenv('ORACLE_SID')
83
+				. ' LD_LIBRARY_PATH='.getenv('LD_LIBRARY_PATH')
84
+				. ' NLS_LANG='.getenv('NLS_LANG')
85
+				. ' tnsnames.ora is '.(is_readable(getenv('ORACLE_HOME').'/network/admin/tnsnames.ora') ? '' : 'not ').'readable');
86 86
 		}
87 87
 
88 88
 		$this->config->setValues([
Please login to merge, or discard this patch.